Alexander Kornienko | 106c8e0 | 2014-10-26 02:58:07 +0000 | [diff] [blame] | 1 | // RUN: $(dirname %s)/check_clang_tidy.sh %s google-readability-function %t |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 2 | // REQUIRES: shell |
| 3 | |
| 4 | void Method(char *) { /* */ } |
| 5 | // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: all parameters should be named in a function |
| 6 | // CHECK-FIXES: void Method(char * /*unused*/) { /* */ } |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 7 | void Method2(char *) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 8 | // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 9 | // CHECK-FIXES: void Method2(char * /*unused*/) {} |
| 10 | void Method3(char *, void *) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 11 | // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 12 | // CHECK-FIXES: void Method3(char * /*unused*/, void * /*unused*/) {} |
| 13 | void Method4(char *, int /*unused*/) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 14 | // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 15 | // CHECK-FIXES: void Method4(char * /*unused*/, int /*unused*/) {} |
| 16 | void operator delete[](void *) throw() {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 17 | // CHECK-MESSAGES: :[[@LINE-1]]:30: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 18 | // CHECK-FIXES: void operator delete[](void * /*unused*/) throw() {} |
| 19 | int Method5(int) { return 0; } |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 20 | // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 21 | // CHECK-FIXES: int Method5(int /*unused*/) { return 0; } |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 22 | void Method6(void (*)(void *)) {} |
| 23 | // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: all parameters should be named in a function |
| 24 | // CHECK-FIXES: void Method6(void (* /*unused*/)(void *)) {} |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 25 | template <typename T> void Method7(T) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 26 | // CHECK-MESSAGES: :[[@LINE-1]]:37: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 27 | // CHECK-FIXES: template <typename T> void Method7(T /*unused*/) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 28 | |
| 29 | // Don't warn in macros. |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 30 | #define M void MethodM(int) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 31 | M |
| 32 | |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 33 | void operator delete(void *x) throw() {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 34 | void Method7(char * /*x*/) {} |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 35 | void Method8(char *x) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 36 | typedef void (*TypeM)(int x); |
| 37 | void operator delete[](void *x) throw(); |
| 38 | void operator delete[](void * /*x*/) throw(); |
| 39 | |
| 40 | struct X { |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 41 | X operator++(int) {} |
Benjamin Kramer | fec6705 | 2014-09-01 09:11:48 +0000 | [diff] [blame] | 42 | X operator--(int) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 43 | |
Benjamin Kramer | e59cd6e | 2014-08-29 08:58:35 +0000 | [diff] [blame] | 44 | X(X&) = delete; |
| 45 | X &operator=(X&) = default; |
| 46 | |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 47 | const int &i; |
| 48 | }; |
| 49 | |
| 50 | void (*Func1)(void *); |
| 51 | void Func2(void (*func)(void *)) {} |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 52 | template <void Func(void *)> void Func3() {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 53 | |
| 54 | template <typename T> |
| 55 | struct Y { |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 56 | void foo(T) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 57 | // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: all parameters should be named in a function |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 58 | // CHECK-FIXES: void foo(T /*unused*/) {} |
Benjamin Kramer | 14d42d9 | 2014-07-15 16:47:09 +0000 | [diff] [blame] | 59 | }; |
| 60 | |
| 61 | Y<int> y; |
| 62 | Y<float> z; |
| 63 | |
| 64 | struct Base { |
| 65 | virtual void foo(bool notThisOne); |
| 66 | virtual void foo(int argname); |
| 67 | }; |
| 68 | |
| 69 | struct Derived : public Base { |
| 70 | void foo(int); |
| 71 | // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: all parameters should be named in a function |
| 72 | // CHECK-FIXES: void foo(int /*argname*/); |
| 73 | }; |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 74 | |
| 75 | void FDef(int); |
| 76 | // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: all parameters should be named in a function |
| 77 | // CHECK-FIXES: void FDef(int /*n*/); |
Benjamin Kramer | 78cd546 | 2014-08-04 09:42:18 +0000 | [diff] [blame] | 78 | void FDef(int n) {} |
| 79 | |
| 80 | void FDef2(int, int); |
| 81 | // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: all parameters should be named in a function |
| 82 | // CHECK-FIXES: void FDef2(int /*n*/, int /*unused*/); |
| 83 | void FDef2(int n, int) {} |
| 84 | // CHECK-MESSAGES: :[[@LINE-1]]:22: warning: all parameters should be named in a function |
| 85 | // CHECK-FIXES: void FDef2(int n, int /*unused*/) {} |
Benjamin Kramer | 610ba53 | 2014-08-04 09:33:58 +0000 | [diff] [blame] | 86 | |
| 87 | void FNoDef(int); |
Benjamin Kramer | fec6705 | 2014-09-01 09:11:48 +0000 | [diff] [blame] | 88 | |
| 89 | class Z {}; |
| 90 | |
| 91 | Z &operator++(Z&) {} |
| 92 | // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: all parameters should be named in a function |
| 93 | // CHECK-FIXES: Z &operator++(Z& /*unused*/) {} |
| 94 | |
| 95 | Z &operator++(Z&, int) {} |
| 96 | // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: all parameters should be named in a function |
| 97 | // CHECK-FIXES: Z &operator++(Z& /*unused*/, int) {} |
| 98 | |
| 99 | Z &operator--(Z&) {} |
| 100 | // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: all parameters should be named in a function |
| 101 | // CHECK-FIXES: Z &operator--(Z& /*unused*/) {} |
| 102 | |
| 103 | Z &operator--(Z&, int) {} |
| 104 | // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: all parameters should be named in a function |
| 105 | // CHECK-FIXES: Z &operator--(Z& /*unused*/, int) {} |
Alexander Kornienko | f5a57c9 | 2014-09-25 08:16:24 +0000 | [diff] [blame] | 106 | |
| 107 | namespace testing { |
| 108 | namespace internal { |
| 109 | class IgnoredValue { |
| 110 | public: |
| 111 | template <typename T> |
| 112 | IgnoredValue(const T& /* ignored */) {} |
| 113 | }; |
| 114 | } |
| 115 | typedef internal::IgnoredValue Unused; |
| 116 | } |
| 117 | |
| 118 | using ::testing::Unused; |
| 119 | |
| 120 | void MockFunction(Unused, int q, Unused) { |
| 121 | ++q; |
| 122 | ++q; |
| 123 | ++q; |
| 124 | } |
Alexander Kornienko | e20ce07 | 2014-11-05 11:08:39 +0000 | [diff] [blame^] | 125 | |
| 126 | namespace std { |
| 127 | typedef decltype(nullptr) nullptr_t; |
| 128 | } |
| 129 | |
| 130 | void f(std::nullptr_t) {} |