blob: 22e3cbdb1091a6b4640719f4eba7a751d2f341e0 [file] [log] [blame]
Kristof Umann56963ae2018-08-13 18:17:05 +00001//===----- UninitializedPointer.cpp ------------------------------*- C++ -*-==//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines functions and methods for handling pointers and references
11// to reduce the size and complexity of UninitializedObjectChecker.cpp.
12//
13// To read about command line options and a description what this checker does,
14// refer to UninitializedObjectChecker.cpp.
15//
16// To read about how the checker works, refer to the comments in
17// UninitializedObject.h.
18//
19//===----------------------------------------------------------------------===//
20
Richard Smith651d6832018-08-13 22:07:11 +000021#include "../ClangSACheckers.h"
Kristof Umanna37bba42018-08-13 18:22:22 +000022#include "UninitializedObject.h"
Kristof Umann56963ae2018-08-13 18:17:05 +000023#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
24#include "clang/StaticAnalyzer/Core/Checker.h"
25#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
26#include "clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h"
27
28using namespace clang;
29using namespace clang::ento;
30
Kristof Umann015b0592018-08-13 18:43:08 +000031namespace {
32
33/// Represents a pointer or a reference field.
Richard Smith651d6832018-08-13 22:07:11 +000034class LocField final : public FieldNode {
Kristof Umann015b0592018-08-13 18:43:08 +000035 /// We'll store whether the pointee or the pointer itself is uninitialited.
36 const bool IsDereferenced;
37
38public:
39 LocField(const FieldRegion *FR, const bool IsDereferenced = true)
40 : FieldNode(FR), IsDereferenced(IsDereferenced) {}
41
42 virtual void printNoteMsg(llvm::raw_ostream &Out) const override {
43 if (IsDereferenced)
44 Out << "uninitialized pointee ";
45 else
46 Out << "uninitialized pointer ";
47 }
48
49 virtual void printPrefix(llvm::raw_ostream &Out) const override {}
50
51 virtual void printNode(llvm::raw_ostream &Out) const override {
52 Out << getVariableName(getDecl());
53 }
54
55 virtual void printSeparator(llvm::raw_ostream &Out) const override {
56 if (getDecl()->getType()->isPointerType())
57 Out << "->";
58 else
59 Out << '.';
60 }
61};
62
Kristof Umann5a424412018-08-14 08:20:51 +000063/// Represents a void* field that needs to be casted back to its dynamic type
64/// for a correct note message.
65class NeedsCastLocField final : public FieldNode {
66 QualType CastBackType;
67
68public:
69 NeedsCastLocField(const FieldRegion *FR, const QualType &T)
70 : FieldNode(FR), CastBackType(T) {}
71
72 virtual void printNoteMsg(llvm::raw_ostream &Out) const override {
73 Out << "uninitialized pointee ";
74 }
75
76 virtual void printPrefix(llvm::raw_ostream &Out) const override {
77 Out << "static_cast" << '<' << CastBackType.getAsString() << ">(";
78 }
79
80 virtual void printNode(llvm::raw_ostream &Out) const override {
81 Out << getVariableName(getDecl()) << ')';
82 }
83
84 virtual void printSeparator(llvm::raw_ostream &Out) const override {
85 Out << "->";
86 }
87};
88
Kristof Umann015b0592018-08-13 18:43:08 +000089} // end of anonymous namespace
90
Kristof Umann56963ae2018-08-13 18:17:05 +000091// Utility function declarations.
92
93/// Returns whether T can be (transitively) dereferenced to a void pointer type
94/// (void*, void**, ...). The type of the region behind a void pointer isn't
95/// known, and thus FD can not be analyzed.
96static bool isVoidPointer(QualType T);
97
Kristof Umannf0dd1012018-09-14 08:58:21 +000098using DereferenceInfo = std::pair<const TypedValueRegion *, bool>;
99
100/// Dereferences \p FR and returns with the pointee's region, and whether it
101/// needs to be casted back to it's location type. If for whatever reason
102/// dereferencing fails, returns with None.
103static llvm::Optional<DereferenceInfo> dereference(ProgramStateRef State,
104 const FieldRegion *FR);
Kristof Umann64601962018-08-21 10:45:21 +0000105
Kristof Umann56963ae2018-08-13 18:17:05 +0000106//===----------------------------------------------------------------------===//
107// Methods for FindUninitializedFields.
108//===----------------------------------------------------------------------===//
109
110// Note that pointers/references don't contain fields themselves, so in this
111// function we won't add anything to LocalChain.
112bool FindUninitializedFields::isPointerOrReferenceUninit(
113 const FieldRegion *FR, FieldChainInfo LocalChain) {
114
Kristof Umannf0dd1012018-09-14 08:58:21 +0000115 assert(isDereferencableType(FR->getDecl()->getType()) &&
116 "This method only checks dereferencable objects!");
Kristof Umann56963ae2018-08-13 18:17:05 +0000117
118 SVal V = State->getSVal(FR);
119
120 if (V.isUnknown() || V.getAs<loc::ConcreteInt>()) {
121 IsAnyFieldInitialized = true;
122 return false;
123 }
124
125 if (V.isUndef()) {
Kristof Umann015b0592018-08-13 18:43:08 +0000126 return addFieldToUninits(
127 LocalChain.add(LocField(FR, /*IsDereferenced*/ false)));
Kristof Umann56963ae2018-08-13 18:17:05 +0000128 }
129
130 if (!CheckPointeeInitialization) {
131 IsAnyFieldInitialized = true;
132 return false;
133 }
134
Kristof Umann56963ae2018-08-13 18:17:05 +0000135 // At this point the pointer itself is initialized and points to a valid
136 // location, we'll now check the pointee.
Kristof Umannf0dd1012018-09-14 08:58:21 +0000137 llvm::Optional<DereferenceInfo> DerefInfo = dereference(State, FR);
Kristof Umann64601962018-08-21 10:45:21 +0000138 if (!DerefInfo) {
139 IsAnyFieldInitialized = true;
140 return false;
Kristof Umann56963ae2018-08-13 18:17:05 +0000141 }
142
Kristof Umannf0dd1012018-09-14 08:58:21 +0000143 const TypedValueRegion *R = DerefInfo->first;
144 const bool NeedsCastBack = DerefInfo->second;
Kristof Umann64601962018-08-21 10:45:21 +0000145
Kristof Umannf0dd1012018-09-14 08:58:21 +0000146 QualType DynT = R->getLocationType();
147 QualType PointeeT = DynT->getPointeeType();
Kristof Umann56963ae2018-08-13 18:17:05 +0000148
Kristof Umannf0dd1012018-09-14 08:58:21 +0000149 if (PointeeT->isStructureOrClassType()) {
150 if (NeedsCastBack)
151 return isNonUnionUninit(R, LocalChain.add(NeedsCastLocField(FR, DynT)));
152 return isNonUnionUninit(R, LocalChain.add(LocField(FR)));
153 }
Kristof Umann56963ae2018-08-13 18:17:05 +0000154
Kristof Umannf0dd1012018-09-14 08:58:21 +0000155 if (PointeeT->isUnionType()) {
156 if (isUnionUninit(R)) {
Kristof Umann5a424412018-08-14 08:20:51 +0000157 if (NeedsCastBack)
Kristof Umannf0dd1012018-09-14 08:58:21 +0000158 return addFieldToUninits(LocalChain.add(NeedsCastLocField(FR, DynT)));
159 return addFieldToUninits(LocalChain.add(LocField(FR)));
160 } else {
Kristof Umann56963ae2018-08-13 18:17:05 +0000161 IsAnyFieldInitialized = true;
162 return false;
163 }
Kristof Umann56963ae2018-08-13 18:17:05 +0000164 }
165
Kristof Umannf0dd1012018-09-14 08:58:21 +0000166 if (PointeeT->isArrayType()) {
167 IsAnyFieldInitialized = true;
168 return false;
169 }
170
171 assert((isPrimitiveType(PointeeT) || isDereferencableType(PointeeT)) &&
Kristof Umann56963ae2018-08-13 18:17:05 +0000172 "At this point FR must either have a primitive dynamic type, or it "
173 "must be a null, undefined, unknown or concrete pointer!");
174
Kristof Umannf0dd1012018-09-14 08:58:21 +0000175 SVal PointeeV = State->getSVal(R);
176
177 if (isPrimitiveUninit(PointeeV)) {
Kristof Umann5a424412018-08-14 08:20:51 +0000178 if (NeedsCastBack)
179 return addFieldToUninits(LocalChain.add(NeedsCastLocField(FR, DynT)));
Kristof Umann015b0592018-08-13 18:43:08 +0000180 return addFieldToUninits(LocalChain.add(LocField(FR)));
Kristof Umann5a424412018-08-14 08:20:51 +0000181 }
Kristof Umann56963ae2018-08-13 18:17:05 +0000182
183 IsAnyFieldInitialized = true;
184 return false;
185}
186
187//===----------------------------------------------------------------------===//
188// Utility functions.
189//===----------------------------------------------------------------------===//
190
191static bool isVoidPointer(QualType T) {
192 while (!T.isNull()) {
193 if (T->isVoidPointerType())
194 return true;
195 T = T->getPointeeType();
196 }
197 return false;
198}
Kristof Umann64601962018-08-21 10:45:21 +0000199
Kristof Umannf0dd1012018-09-14 08:58:21 +0000200static llvm::Optional<DereferenceInfo> dereference(ProgramStateRef State,
201 const FieldRegion *FR) {
Kristof Umann64601962018-08-21 10:45:21 +0000202
Kristof Umannf0dd1012018-09-14 08:58:21 +0000203 llvm::SmallSet<const TypedValueRegion *, 5> VisitedRegions;
Kristof Umann64601962018-08-21 10:45:21 +0000204
205 // If the static type of the field is a void pointer, we need to cast it back
206 // to the dynamic type before dereferencing.
207 bool NeedsCastBack = isVoidPointer(FR->getDecl()->getType());
208
209 SVal V = State->getSVal(FR);
Kristof Umannf0dd1012018-09-14 08:58:21 +0000210 assert(V.getAsRegion() && "V must have an underlying region!");
Kristof Umann64601962018-08-21 10:45:21 +0000211
Kristof Umannf0dd1012018-09-14 08:58:21 +0000212 // The region we'd like to acquire.
213 const auto *R = V.getAsRegion()->getAs<TypedValueRegion>();
214 if (!R)
215 return None;
216
217 VisitedRegions.insert(R);
218
219 // We acquire the dynamic type of R,
220 QualType DynT = R->getLocationType();
221
222 while (const MemRegion *Tmp = State->getSVal(R, DynT).getAsRegion()) {
223
224 R = Tmp->getAs<TypedValueRegion>();
225
226 if (!R)
Kristof Umann64601962018-08-21 10:45:21 +0000227 return None;
Kristof Umann64601962018-08-21 10:45:21 +0000228
Kristof Umannf0dd1012018-09-14 08:58:21 +0000229 // We found a cyclic pointer, like int *ptr = (int *)&ptr.
230 // TODO: Report these fields too.
231 if (!VisitedRegions.insert(R).second)
Kristof Umann64601962018-08-21 10:45:21 +0000232 return None;
Kristof Umann64601962018-08-21 10:45:21 +0000233
Kristof Umannf0dd1012018-09-14 08:58:21 +0000234 DynT = R->getLocationType();
235 // In order to ensure that this loop terminates, we're also checking the
236 // dynamic type of R, since type hierarchy is finite.
237 if (isDereferencableType(DynT->getPointeeType()))
238 break;
Kristof Umann64601962018-08-21 10:45:21 +0000239 }
240
Kristof Umannf0dd1012018-09-14 08:58:21 +0000241 return std::make_pair(R, NeedsCastBack);
Kristof Umann64601962018-08-21 10:45:21 +0000242}