blob: 922d1b786673eba1bc5d4ebdee8770f72d506a60 [file] [log] [blame]
Peter Collingbournefd66a482015-06-08 02:32:01 +00001//===- ArchiveWriter.cpp - ar File Format implementation --------*- C++ -*-===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines the writeArchive function.
11//
12//===----------------------------------------------------------------------===//
13
14#include "llvm/Object/ArchiveWriter.h"
15#include "llvm/ADT/ArrayRef.h"
16#include "llvm/ADT/StringRef.h"
17#include "llvm/IR/LLVMContext.h"
18#include "llvm/Object/Archive.h"
19#include "llvm/Object/ObjectFile.h"
20#include "llvm/Object/SymbolicFile.h"
Benjamin Kramercd278b72015-06-17 16:02:56 +000021#include "llvm/Support/EndianStream.h"
Rafael Espindola74f29322015-06-13 17:23:04 +000022#include "llvm/Support/Errc.h"
Peter Collingbournefd66a482015-06-08 02:32:01 +000023#include "llvm/Support/ErrorHandling.h"
24#include "llvm/Support/Format.h"
25#include "llvm/Support/Path.h"
26#include "llvm/Support/ToolOutputFile.h"
27#include "llvm/Support/raw_ostream.h"
28
Peter Collingbourne7ab1a3b2015-06-08 02:43:32 +000029#if !defined(_MSC_VER) && !defined(__MINGW32__)
Peter Collingbournefd66a482015-06-08 02:32:01 +000030#include <unistd.h>
Peter Collingbourne7ab1a3b2015-06-08 02:43:32 +000031#else
32#include <io.h>
33#endif
Peter Collingbournefd66a482015-06-08 02:32:01 +000034
35using namespace llvm;
36
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000037NewArchiveMember::NewArchiveMember(MemoryBufferRef BufRef)
38 : Buf(MemoryBuffer::getMemBuffer(BufRef, false)) {}
Peter Collingbournefd66a482015-06-08 02:32:01 +000039
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000040Expected<NewArchiveMember>
41NewArchiveMember::getOldMember(const object::Archive::Child &OldMember,
42 bool Deterministic) {
Kevin Enderbyf4586032016-07-29 17:44:13 +000043 Expected<llvm::MemoryBufferRef> BufOrErr = OldMember.getMemoryBufferRef();
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000044 if (!BufOrErr)
Kevin Enderbyf4586032016-07-29 17:44:13 +000045 return BufOrErr.takeError();
Peter Collingbournefd66a482015-06-08 02:32:01 +000046
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000047 NewArchiveMember M;
48 M.Buf = MemoryBuffer::getMemBuffer(*BufOrErr, false);
49 if (!Deterministic) {
50 M.ModTime = OldMember.getLastModified();
51 M.UID = OldMember.getUID();
52 M.GID = OldMember.getGID();
53 M.Perms = OldMember.getAccessMode();
54 }
55 return std::move(M);
Peter Collingbournefd66a482015-06-08 02:32:01 +000056}
57
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000058Expected<NewArchiveMember> NewArchiveMember::getFile(StringRef FileName,
59 bool Deterministic) {
60 sys::fs::file_status Status;
61 int FD;
62 if (auto EC = sys::fs::openFileForRead(FileName, FD))
63 return errorCodeToError(EC);
64 assert(FD != -1);
Peter Collingbournefd66a482015-06-08 02:32:01 +000065
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000066 if (auto EC = sys::fs::status(FD, Status))
67 return errorCodeToError(EC);
Peter Collingbournefd66a482015-06-08 02:32:01 +000068
69 // Opening a directory doesn't make sense. Let it fail.
70 // Linux cannot open directories with open(2), although
71 // cygwin and *bsd can.
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000072 if (Status.type() == sys::fs::file_type::directory_file)
73 return errorCodeToError(make_error_code(errc::is_a_directory));
Peter Collingbournefd66a482015-06-08 02:32:01 +000074
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +000075 ErrorOr<std::unique_ptr<MemoryBuffer>> MemberBufferOrErr =
76 MemoryBuffer::getOpenFile(FD, FileName, Status.getSize(), false);
77 if (!MemberBufferOrErr)
78 return errorCodeToError(MemberBufferOrErr.getError());
79
80 if (close(FD) != 0)
81 return errorCodeToError(std::error_code(errno, std::generic_category()));
82
83 NewArchiveMember M;
84 M.Buf = std::move(*MemberBufferOrErr);
85 if (!Deterministic) {
86 M.ModTime = Status.getLastModificationTime();
87 M.UID = Status.getUser();
88 M.GID = Status.getGroup();
89 M.Perms = Status.permissions();
90 }
91 return std::move(M);
Peter Collingbournefd66a482015-06-08 02:32:01 +000092}
93
94template <typename T>
95static void printWithSpacePadding(raw_fd_ostream &OS, T Data, unsigned Size,
NAKAMURA Takumi0a7d0ad2015-09-22 11:15:07 +000096 bool MayTruncate = false) {
Peter Collingbournefd66a482015-06-08 02:32:01 +000097 uint64_t OldPos = OS.tell();
98 OS << Data;
99 unsigned SizeSoFar = OS.tell() - OldPos;
100 if (Size > SizeSoFar) {
Benjamin Kramercd278b72015-06-17 16:02:56 +0000101 OS.indent(Size - SizeSoFar);
Peter Collingbournefd66a482015-06-08 02:32:01 +0000102 } else if (Size < SizeSoFar) {
103 assert(MayTruncate && "Data doesn't fit in Size");
104 // Some of the data this is used for (like UID) can be larger than the
105 // space available in the archive format. Truncate in that case.
106 OS.seek(OldPos + Size);
107 }
108}
109
Rafael Espindolab870e9c2015-07-09 15:13:41 +0000110static void print32(raw_ostream &Out, object::Archive::Kind Kind,
111 uint32_t Val) {
112 if (Kind == object::Archive::K_GNU)
113 support::endian::Writer<support::big>(Out).write(Val);
114 else
115 support::endian::Writer<support::little>(Out).write(Val);
Peter Collingbournefd66a482015-06-08 02:32:01 +0000116}
117
118static void printRestOfMemberHeader(raw_fd_ostream &Out,
119 const sys::TimeValue &ModTime, unsigned UID,
120 unsigned GID, unsigned Perms,
121 unsigned Size) {
122 printWithSpacePadding(Out, ModTime.toEpochTime(), 12);
123 printWithSpacePadding(Out, UID, 6, true);
124 printWithSpacePadding(Out, GID, 6, true);
125 printWithSpacePadding(Out, format("%o", Perms), 8);
126 printWithSpacePadding(Out, Size, 10);
127 Out << "`\n";
128}
129
Rafael Espindola8cde5c02015-07-09 14:54:12 +0000130static void printGNUSmallMemberHeader(raw_fd_ostream &Out, StringRef Name,
131 const sys::TimeValue &ModTime,
132 unsigned UID, unsigned GID,
133 unsigned Perms, unsigned Size) {
Peter Collingbournefd66a482015-06-08 02:32:01 +0000134 printWithSpacePadding(Out, Twine(Name) + "/", 16);
135 printRestOfMemberHeader(Out, ModTime, UID, GID, Perms, Size);
136}
137
Rafael Espindola8cde5c02015-07-09 14:54:12 +0000138static void printBSDMemberHeader(raw_fd_ostream &Out, StringRef Name,
139 const sys::TimeValue &ModTime, unsigned UID,
140 unsigned GID, unsigned Perms, unsigned Size) {
141 uint64_t PosAfterHeader = Out.tell() + 60 + Name.size();
142 // Pad so that even 64 bit object files are aligned.
143 unsigned Pad = OffsetToAlignment(PosAfterHeader, 8);
144 unsigned NameWithPadding = Name.size() + Pad;
145 printWithSpacePadding(Out, Twine("#1/") + Twine(NameWithPadding), 16);
146 printRestOfMemberHeader(Out, ModTime, UID, GID, Perms,
147 NameWithPadding + Size);
148 Out << Name;
149 assert(PosAfterHeader == Out.tell());
150 while (Pad--)
151 Out.write(uint8_t(0));
152}
153
Rafael Espindolae6492582015-07-15 05:47:46 +0000154static bool useStringTable(bool Thin, StringRef Name) {
155 return Thin || Name.size() >= 16;
156}
157
Rafael Espindolac291a4b22015-07-08 17:08:26 +0000158static void
Rafael Espindolae6492582015-07-15 05:47:46 +0000159printMemberHeader(raw_fd_ostream &Out, object::Archive::Kind Kind, bool Thin,
Rafael Espindolaa2ed0b02015-07-08 20:47:32 +0000160 StringRef Name,
Rafael Espindolac291a4b22015-07-08 17:08:26 +0000161 std::vector<unsigned>::iterator &StringMapIndexIter,
162 const sys::TimeValue &ModTime, unsigned UID, unsigned GID,
163 unsigned Perms, unsigned Size) {
Rafael Espindola8cde5c02015-07-09 14:54:12 +0000164 if (Kind == object::Archive::K_BSD)
165 return printBSDMemberHeader(Out, Name, ModTime, UID, GID, Perms, Size);
Rafael Espindolae6492582015-07-15 05:47:46 +0000166 if (!useStringTable(Thin, Name))
Rafael Espindola8cde5c02015-07-09 14:54:12 +0000167 return printGNUSmallMemberHeader(Out, Name, ModTime, UID, GID, Perms, Size);
Rafael Espindola65a99532015-07-08 17:26:24 +0000168 Out << '/';
169 printWithSpacePadding(Out, *StringMapIndexIter++, 15);
170 printRestOfMemberHeader(Out, ModTime, UID, GID, Perms, Size);
Rafael Espindolac291a4b22015-07-08 17:08:26 +0000171}
172
Rafael Espindola06d6d192015-07-16 00:14:49 +0000173// Compute the relative path from From to To.
174static std::string computeRelativePath(StringRef From, StringRef To) {
175 if (sys::path::is_absolute(From) || sys::path::is_absolute(To))
176 return To;
177
178 StringRef DirFrom = sys::path::parent_path(From);
179 auto FromI = sys::path::begin(DirFrom);
180 auto ToI = sys::path::begin(To);
181 while (*FromI == *ToI) {
182 ++FromI;
183 ++ToI;
184 }
185
186 SmallString<128> Relative;
187 for (auto FromE = sys::path::end(DirFrom); FromI != FromE; ++FromI)
188 sys::path::append(Relative, "..");
189
190 for (auto ToE = sys::path::end(To); ToI != ToE; ++ToI)
191 sys::path::append(Relative, *ToI);
192
193 return Relative.str();
194}
195
196static void writeStringTable(raw_fd_ostream &Out, StringRef ArcName,
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000197 ArrayRef<NewArchiveMember> Members,
Rafael Espindolae6492582015-07-15 05:47:46 +0000198 std::vector<unsigned> &StringMapIndexes,
199 bool Thin) {
Peter Collingbournefd66a482015-06-08 02:32:01 +0000200 unsigned StartOffset = 0;
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000201 for (const NewArchiveMember &M : Members) {
202 StringRef Path = M.Buf->getBufferIdentifier();
203 StringRef Name = sys::path::filename(Path);
Rafael Espindolae6492582015-07-15 05:47:46 +0000204 if (!useStringTable(Thin, Name))
Peter Collingbournefd66a482015-06-08 02:32:01 +0000205 continue;
206 if (StartOffset == 0) {
207 printWithSpacePadding(Out, "//", 58);
208 Out << "`\n";
209 StartOffset = Out.tell();
210 }
211 StringMapIndexes.push_back(Out.tell() - StartOffset);
Rafael Espindola06d6d192015-07-16 00:14:49 +0000212
213 if (Thin)
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000214 Out << computeRelativePath(ArcName, Path);
Rafael Espindola06d6d192015-07-16 00:14:49 +0000215 else
216 Out << Name;
217
218 Out << "/\n";
Peter Collingbournefd66a482015-06-08 02:32:01 +0000219 }
220 if (StartOffset == 0)
221 return;
222 if (Out.tell() % 2)
223 Out << '\n';
224 int Pos = Out.tell();
225 Out.seek(StartOffset - 12);
226 printWithSpacePadding(Out, Pos - StartOffset, 10);
227 Out.seek(Pos);
228}
229
Rafael Espindola6a8e86f2015-07-13 20:38:09 +0000230static sys::TimeValue now(bool Deterministic) {
231 if (!Deterministic)
232 return sys::TimeValue::now();
233 sys::TimeValue TV;
234 TV.fromEpochTime(0);
235 return TV;
236}
237
Peter Collingbournefd66a482015-06-08 02:32:01 +0000238// Returns the offset of the first reference to a member offset.
239static ErrorOr<unsigned>
Rafael Espindolaa2ed0b02015-07-08 20:47:32 +0000240writeSymbolTable(raw_fd_ostream &Out, object::Archive::Kind Kind,
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000241 ArrayRef<NewArchiveMember> Members,
Rafael Espindola6a8e86f2015-07-13 20:38:09 +0000242 std::vector<unsigned> &MemberOffsetRefs, bool Deterministic) {
Rafael Espindolac79bff62015-07-09 15:56:23 +0000243 unsigned HeaderStartOffset = 0;
244 unsigned BodyStartOffset = 0;
Rafael Espindola80c662d2015-07-08 21:07:18 +0000245 SmallString<128> NameBuf;
246 raw_svector_ostream NameOS(NameBuf);
Peter Collingbournefd66a482015-06-08 02:32:01 +0000247 LLVMContext Context;
Rafael Espindola80c662d2015-07-08 21:07:18 +0000248 for (unsigned MemberNum = 0, N = Members.size(); MemberNum < N; ++MemberNum) {
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000249 MemoryBufferRef MemberBuffer = Members[MemberNum].Buf->getMemBufferRef();
Kevin Enderby3fcdf6a2016-04-06 22:14:09 +0000250 Expected<std::unique_ptr<object::SymbolicFile>> ObjOrErr =
Peter Collingbournefd66a482015-06-08 02:32:01 +0000251 object::SymbolicFile::createSymbolicFile(
252 MemberBuffer, sys::fs::file_magic::unknown, &Context);
Kevin Enderby3fcdf6a2016-04-06 22:14:09 +0000253 if (!ObjOrErr) {
254 // FIXME: check only for "not an object file" errors.
255 consumeError(ObjOrErr.takeError());
256 continue;
257 }
Peter Collingbournefd66a482015-06-08 02:32:01 +0000258 object::SymbolicFile &Obj = *ObjOrErr.get();
259
Rafael Espindolac79bff62015-07-09 15:56:23 +0000260 if (!HeaderStartOffset) {
261 HeaderStartOffset = Out.tell();
262 if (Kind == object::Archive::K_GNU)
Rafael Espindola6a8e86f2015-07-13 20:38:09 +0000263 printGNUSmallMemberHeader(Out, "", now(Deterministic), 0, 0, 0, 0);
Rafael Espindolac79bff62015-07-09 15:56:23 +0000264 else
Rafael Espindola6a8e86f2015-07-13 20:38:09 +0000265 printBSDMemberHeader(Out, "__.SYMDEF", now(Deterministic), 0, 0, 0, 0);
Rafael Espindolac79bff62015-07-09 15:56:23 +0000266 BodyStartOffset = Out.tell();
267 print32(Out, Kind, 0); // number of entries or bytes
Peter Collingbournefd66a482015-06-08 02:32:01 +0000268 }
269
270 for (const object::BasicSymbolRef &S : Obj.symbols()) {
271 uint32_t Symflags = S.getFlags();
272 if (Symflags & object::SymbolRef::SF_FormatSpecific)
273 continue;
274 if (!(Symflags & object::SymbolRef::SF_Global))
275 continue;
276 if (Symflags & object::SymbolRef::SF_Undefined)
277 continue;
Rafael Espindolac79bff62015-07-09 15:56:23 +0000278
279 unsigned NameOffset = NameOS.tell();
Peter Collingbournefd66a482015-06-08 02:32:01 +0000280 if (auto EC = S.printName(NameOS))
281 return EC;
282 NameOS << '\0';
Peter Collingbournefd66a482015-06-08 02:32:01 +0000283 MemberOffsetRefs.push_back(MemberNum);
Rafael Espindolac79bff62015-07-09 15:56:23 +0000284 if (Kind == object::Archive::K_BSD)
285 print32(Out, Kind, NameOffset);
286 print32(Out, Kind, 0); // member offset
Peter Collingbournefd66a482015-06-08 02:32:01 +0000287 }
288 }
Peter Collingbournefd66a482015-06-08 02:32:01 +0000289
Rafael Espindolac79bff62015-07-09 15:56:23 +0000290 if (HeaderStartOffset == 0)
Peter Collingbournefd66a482015-06-08 02:32:01 +0000291 return 0;
292
Rafael Espindolac79bff62015-07-09 15:56:23 +0000293 StringRef StringTable = NameOS.str();
294 if (Kind == object::Archive::K_BSD)
295 print32(Out, Kind, StringTable.size()); // byte count of the string table
296 Out << StringTable;
297
Rafael Espindola594e6762015-07-09 19:48:06 +0000298 // ld64 requires the next member header to start at an offset that is
299 // 4 bytes aligned.
300 unsigned Pad = OffsetToAlignment(Out.tell(), 4);
301 while (Pad--)
302 Out.write(uint8_t(0));
Peter Collingbournefd66a482015-06-08 02:32:01 +0000303
Rafael Espindolac79bff62015-07-09 15:56:23 +0000304 // Patch up the size of the symbol table now that we know how big it is.
Peter Collingbournefd66a482015-06-08 02:32:01 +0000305 unsigned Pos = Out.tell();
Rafael Espindolac79bff62015-07-09 15:56:23 +0000306 const unsigned MemberHeaderSize = 60;
307 Out.seek(HeaderStartOffset + 48); // offset of the size field.
308 printWithSpacePadding(Out, Pos - MemberHeaderSize - HeaderStartOffset, 10);
309
310 // Patch up the number of symbols.
311 Out.seek(BodyStartOffset);
Rafael Espindola2ba806c2015-07-09 15:24:39 +0000312 unsigned NumSyms = MemberOffsetRefs.size();
Rafael Espindolac79bff62015-07-09 15:56:23 +0000313 if (Kind == object::Archive::K_GNU)
314 print32(Out, Kind, NumSyms);
315 else
316 print32(Out, Kind, NumSyms * 8);
317
Peter Collingbournefd66a482015-06-08 02:32:01 +0000318 Out.seek(Pos);
Rafael Espindolac79bff62015-07-09 15:56:23 +0000319 return BodyStartOffset + 4;
Peter Collingbournefd66a482015-06-08 02:32:01 +0000320}
321
Rafael Espindolae6492582015-07-15 05:47:46 +0000322std::pair<StringRef, std::error_code>
323llvm::writeArchive(StringRef ArcName,
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000324 std::vector<NewArchiveMember> &NewMembers,
Rafael Espindolae6492582015-07-15 05:47:46 +0000325 bool WriteSymtab, object::Archive::Kind Kind,
Rafael Espindola484983f2016-05-09 13:31:11 +0000326 bool Deterministic, bool Thin,
327 std::unique_ptr<MemoryBuffer> OldArchiveBuf) {
Davide Italiano8a259332016-05-03 07:30:56 +0000328 assert((!Thin || Kind == object::Archive::K_GNU) &&
329 "Only the gnu format has a thin mode");
Peter Collingbournefd66a482015-06-08 02:32:01 +0000330 SmallString<128> TmpArchive;
331 int TmpArchiveFD;
332 if (auto EC = sys::fs::createUniqueFile(ArcName + ".temp-archive-%%%%%%%.a",
333 TmpArchiveFD, TmpArchive))
334 return std::make_pair(ArcName, EC);
335
336 tool_output_file Output(TmpArchive, TmpArchiveFD);
337 raw_fd_ostream &Out = Output.os();
Rafael Espindolae6492582015-07-15 05:47:46 +0000338 if (Thin)
339 Out << "!<thin>\n";
340 else
341 Out << "!<arch>\n";
Peter Collingbournefd66a482015-06-08 02:32:01 +0000342
343 std::vector<unsigned> MemberOffsetRefs;
344
345 std::vector<std::unique_ptr<MemoryBuffer>> Buffers;
346 std::vector<MemoryBufferRef> Members;
347 std::vector<sys::fs::file_status> NewMemberStatus;
348
Peter Collingbournefd66a482015-06-08 02:32:01 +0000349 unsigned MemberReferenceOffset = 0;
350 if (WriteSymtab) {
Rafael Espindola6a8e86f2015-07-13 20:38:09 +0000351 ErrorOr<unsigned> MemberReferenceOffsetOrErr = writeSymbolTable(
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000352 Out, Kind, NewMembers, MemberOffsetRefs, Deterministic);
Peter Collingbournefd66a482015-06-08 02:32:01 +0000353 if (auto EC = MemberReferenceOffsetOrErr.getError())
354 return std::make_pair(ArcName, EC);
355 MemberReferenceOffset = MemberReferenceOffsetOrErr.get();
356 }
357
358 std::vector<unsigned> StringMapIndexes;
Rafael Espindolaa2ed0b02015-07-08 20:47:32 +0000359 if (Kind != object::Archive::K_BSD)
Rafael Espindola06d6d192015-07-16 00:14:49 +0000360 writeStringTable(Out, ArcName, NewMembers, StringMapIndexes, Thin);
Peter Collingbournefd66a482015-06-08 02:32:01 +0000361
Rafael Espindolac291a4b22015-07-08 17:08:26 +0000362 std::vector<unsigned>::iterator StringMapIndexIter = StringMapIndexes.begin();
Peter Collingbournefd66a482015-06-08 02:32:01 +0000363 std::vector<unsigned> MemberOffset;
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000364 for (const NewArchiveMember &M : NewMembers) {
365 MemoryBufferRef File = M.Buf->getMemBufferRef();
Peter Collingbournefd66a482015-06-08 02:32:01 +0000366
367 unsigned Pos = Out.tell();
368 MemberOffset.push_back(Pos);
369
Peter Collingbourne8ec68fa2016-06-29 22:27:42 +0000370 printMemberHeader(Out, Kind, Thin,
371 sys::path::filename(M.Buf->getBufferIdentifier()),
372 StringMapIndexIter, M.ModTime, M.UID, M.GID, M.Perms,
373 M.Buf->getBufferSize());
Peter Collingbournefd66a482015-06-08 02:32:01 +0000374
Rafael Espindolae6492582015-07-15 05:47:46 +0000375 if (!Thin)
376 Out << File.getBuffer();
Peter Collingbournefd66a482015-06-08 02:32:01 +0000377
378 if (Out.tell() % 2)
379 Out << '\n';
380 }
381
382 if (MemberReferenceOffset) {
383 Out.seek(MemberReferenceOffset);
Rafael Espindolac79bff62015-07-09 15:56:23 +0000384 for (unsigned MemberNum : MemberOffsetRefs) {
385 if (Kind == object::Archive::K_BSD)
386 Out.seek(Out.tell() + 4); // skip over the string offset
Rafael Espindolab870e9c2015-07-09 15:13:41 +0000387 print32(Out, Kind, MemberOffset[MemberNum]);
Rafael Espindolac79bff62015-07-09 15:56:23 +0000388 }
Peter Collingbournefd66a482015-06-08 02:32:01 +0000389 }
390
391 Output.keep();
392 Out.close();
Rafael Espindola484983f2016-05-09 13:31:11 +0000393
394 // At this point, we no longer need whatever backing memory
395 // was used to generate the NewMembers. On Windows, this buffer
396 // could be a mapped view of the file we want to replace (if
397 // we're updating an existing archive, say). In that case, the
398 // rename would still succeed, but it would leave behind a
399 // temporary file (actually the original file renamed) because
400 // a file cannot be deleted while there's a handle open on it,
401 // only renamed. So by freeing this buffer, this ensures that
402 // the last open handle on the destination file, if any, is
403 // closed before we attempt to rename.
404 OldArchiveBuf.reset();
405
Peter Collingbournefd66a482015-06-08 02:32:01 +0000406 sys::fs::rename(TmpArchive, ArcName);
407 return std::make_pair("", std::error_code());
408}