blob: f4f4736fc0d6ca03dce5c9e5d602045b8eff5031 [file] [log] [blame]
Alexander Kornienko5b982e52015-03-09 11:48:54 +00001//===--- UnusedRAIICheck.h - clang-tidy -------------------------*- C++ -*-===//
Benjamin Kramerda3658e2014-07-23 11:49:46 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
Alexander Kornienko66580552015-03-09 16:52:33 +000010#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H
11#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H
Benjamin Kramerda3658e2014-07-23 11:49:46 +000012
13#include "../ClangTidy.h"
14
15namespace clang {
16namespace tidy {
Alexander Kornienko2b3124202015-03-02 12:25:03 +000017namespace misc {
Benjamin Kramerda3658e2014-07-23 11:49:46 +000018
Alexander Kornienkof8ed0a82015-08-27 18:01:58 +000019/// Finds temporaries that look like RAII objects.
Benjamin Kramerda3658e2014-07-23 11:49:46 +000020///
21/// The canonical example for this is a scoped lock.
Alexander Kornienkof8ed0a82015-08-27 18:01:58 +000022///
Benjamin Kramerda3658e2014-07-23 11:49:46 +000023/// \code
24/// {
25/// scoped_lock(&global_mutex);
26/// critical_section();
27/// }
28/// \endcode
Alexander Kornienkof8ed0a82015-08-27 18:01:58 +000029///
30/// The destructor of the scoped_lock is called before the `critical_section` is
Benjamin Kramerda3658e2014-07-23 11:49:46 +000031/// entered, leaving it unprotected.
32///
33/// We apply a number of heuristics to reduce the false positive count of this
34/// check:
Alexander Kornienkof8ed0a82015-08-27 18:01:58 +000035///
36/// * Ignore code expanded from macros. Testing frameworks make heavy use of
Benjamin Kramerda3658e2014-07-23 11:49:46 +000037/// this.
Alexander Kornienkof8ed0a82015-08-27 18:01:58 +000038/// * Ignore types with no user-declared constructor. Those are very unlikely
Benjamin Kramerda3658e2014-07-23 11:49:46 +000039/// to be RAII objects.
Alexander Kornienkof8ed0a82015-08-27 18:01:58 +000040/// * Ignore objects at the end of a compound statement (doesn't change
41/// behavior).
42/// * Ignore objects returned from a call.
Benjamin Kramerda3658e2014-07-23 11:49:46 +000043class UnusedRAIICheck : public ClangTidyCheck {
44public:
Alexander Kornienko6e0cbc82014-09-12 08:53:36 +000045 UnusedRAIICheck(StringRef Name, ClangTidyContext *Context)
46 : ClangTidyCheck(Name, Context) {}
Benjamin Kramerda3658e2014-07-23 11:49:46 +000047 void registerMatchers(ast_matchers::MatchFinder *Finder) override;
48 void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
49};
50
Alexander Kornienko2b3124202015-03-02 12:25:03 +000051} // namespace misc
Benjamin Kramerda3658e2014-07-23 11:49:46 +000052} // namespace tidy
53} // namespace clang
54
Alexander Kornienko66580552015-03-09 16:52:33 +000055#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_UNUSEDRAIICHECK_H