Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 1 | //===- Core/Resolver.cpp - Resolves Atom References -----------------------===// |
| 2 | // |
| 3 | // The LLVM Linker |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 10 | #include "lld/Core/Atom.h" |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 11 | #include "lld/Core/ArchiveLibraryFile.h" |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 12 | #include "lld/Core/File.h" |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 13 | #include "lld/Core/SharedLibraryFile.h" |
Michael J. Spencer | bd66d04 | 2013-05-28 18:55:39 +0000 | [diff] [blame] | 14 | #include "lld/Core/Instrumentation.h" |
Michael J. Spencer | e6203a5 | 2012-04-03 18:39:40 +0000 | [diff] [blame] | 15 | #include "lld/Core/LLVM.h" |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 16 | #include "lld/Core/Resolver.h" |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 17 | #include "lld/Core/SymbolTable.h" |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 18 | #include "lld/Core/LinkingContext.h" |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 19 | #include "lld/Core/UndefinedAtom.h" |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 20 | |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 21 | #include "llvm/Support/Debug.h" |
Michael J. Spencer | 4586fbc | 2013-01-22 20:49:42 +0000 | [diff] [blame] | 22 | #include "llvm/Support/ErrorHandling.h" |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 23 | #include "llvm/Support/Format.h" |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 24 | #include "llvm/Support/raw_ostream.h" |
| 25 | |
| 26 | #include <algorithm> |
| 27 | #include <cassert> |
| 28 | #include <vector> |
| 29 | |
| 30 | namespace lld { |
| 31 | |
Nick Kledzik | 80d8308 | 2013-05-08 21:34:11 +0000 | [diff] [blame] | 32 | namespace { |
| 33 | |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 34 | /// This is used as a filter function to std::remove_if to dead strip atoms. |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 35 | class NotLive { |
| 36 | public: |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 37 | explicit NotLive(const llvm::DenseSet<const Atom *> &la) : _liveAtoms(la) {} |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 38 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 39 | bool operator()(const Atom *atom) const { |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 40 | // don't remove if live |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 41 | if (_liveAtoms.count(atom)) |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 42 | return false; |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 43 | // don't remove if marked never-dead-strip |
Rui Ueyama | c53b3b0 | 2013-12-10 06:19:09 +0000 | [diff] [blame] | 44 | if (const DefinedAtom *defAtom = dyn_cast<DefinedAtom>(atom)) |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 45 | if (defAtom->deadStrip() == DefinedAtom::deadStripNever) |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 46 | return false; |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 47 | // do remove this atom |
| 48 | return true; |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 49 | } |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 50 | |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 51 | private: |
Rui Ueyama | 0cbd7e0 | 2013-12-26 06:57:37 +0000 | [diff] [blame] | 52 | const llvm::DenseSet<const Atom *> &_liveAtoms; |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 53 | }; |
| 54 | |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 55 | /// This is used as a filter function to std::remove_if to coalesced atoms. |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 56 | class AtomCoalescedAway { |
| 57 | public: |
Nick Kledzik | 80d8308 | 2013-05-08 21:34:11 +0000 | [diff] [blame] | 58 | explicit AtomCoalescedAway(SymbolTable &sym) : _symbolTable(sym) {} |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 59 | |
| 60 | bool operator()(const Atom *atom) const { |
| 61 | const Atom *rep = _symbolTable.replacement(atom); |
| 62 | return rep != atom; |
| 63 | } |
| 64 | |
| 65 | private: |
| 66 | SymbolTable &_symbolTable; |
| 67 | }; |
| 68 | |
Nick Kledzik | 80d8308 | 2013-05-08 21:34:11 +0000 | [diff] [blame] | 69 | } // namespace |
| 70 | |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 71 | void Resolver::handleFile(const File &file) { |
Rui Ueyama | 6aa91cf | 2014-04-03 21:00:03 +0000 | [diff] [blame] | 72 | bool isEmpty = file.defined().empty() && file.sharedLibrary().empty() && |
| 73 | file.absolute().empty() && file.undefined().empty(); |
| 74 | if (isEmpty) |
| 75 | return; |
| 76 | |
Rui Ueyama | edd5c0a | 2014-04-02 21:02:44 +0000 | [diff] [blame] | 77 | for (const DefinedAtom *atom : file.defined()) |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 78 | doDefinedAtom(*atom); |
Rui Ueyama | edd5c0a | 2014-04-02 21:02:44 +0000 | [diff] [blame] | 79 | |
Rui Ueyama | 9457510 | 2014-04-03 20:54:47 +0000 | [diff] [blame] | 80 | for (const UndefinedAtom *undefAtom : file.undefined()) { |
| 81 | doUndefinedAtom(*undefAtom); |
| 82 | // If the undefined symbol has an alternative name, try to resolve the |
| 83 | // symbol with the name to give it a second chance. This feature is used |
| 84 | // for COFF "weak external" symbol. |
| 85 | if (!_symbolTable.isDefined(undefAtom->name())) { |
| 86 | if (const UndefinedAtom *fallbackAtom = undefAtom->fallback()) { |
| 87 | doUndefinedAtom(*fallbackAtom); |
| 88 | _symbolTable.addReplacement(undefAtom, fallbackAtom); |
Rui Ueyama | 70f11d7 | 2013-11-20 20:51:55 +0000 | [diff] [blame] | 89 | } |
| 90 | } |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 91 | } |
Rui Ueyama | edd5c0a | 2014-04-02 21:02:44 +0000 | [diff] [blame] | 92 | |
Rui Ueyama | 9457510 | 2014-04-03 20:54:47 +0000 | [diff] [blame] | 93 | for (const SharedLibraryAtom *atom : file.sharedLibrary()) |
| 94 | doSharedLibraryAtom(*atom); |
| 95 | for (const AbsoluteAtom *atom : file.absolute()) |
| 96 | doAbsoluteAtom(*atom); |
Rui Ueyama | edd5c0a | 2014-04-02 21:02:44 +0000 | [diff] [blame] | 97 | |
Rui Ueyama | 6aa91cf | 2014-04-03 21:00:03 +0000 | [diff] [blame] | 98 | // Notify the input file manager of the fact that we have made some progress |
| 99 | // on linking using the current input file. It may want to know the fact for |
| 100 | // --start-group/--end-group. |
| 101 | _context.inputGraph().notifyProgress(); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 102 | } |
| 103 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 104 | void Resolver::forEachUndefines(UndefCallback callback, |
| 105 | bool searchForOverrides) { |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 106 | // Handle normal archives |
| 107 | int64_t undefineGenCount = 0; |
| 108 | do { |
| 109 | undefineGenCount = _symbolTable.size(); |
| 110 | std::vector<const UndefinedAtom *> undefines; |
| 111 | _symbolTable.undefines(undefines); |
| 112 | for (const UndefinedAtom *undefAtom : undefines) { |
| 113 | StringRef undefName = undefAtom->name(); |
| 114 | // load for previous undefine may also have loaded this undefine |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 115 | if (!_symbolTable.isDefined(undefName)) |
| 116 | callback(undefName, false); |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 117 | } |
| 118 | // search libraries for overrides of common symbols |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 119 | if (searchForOverrides) { |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 120 | std::vector<StringRef> tentDefNames; |
| 121 | _symbolTable.tentativeDefinitions(tentDefNames); |
| 122 | for (StringRef tentDefName : tentDefNames) { |
| 123 | // Load for previous tentative may also have loaded |
| 124 | // something that overrode this tentative, so always check. |
| 125 | const Atom *curAtom = _symbolTable.findByName(tentDefName); |
| 126 | assert(curAtom != nullptr); |
| 127 | if (const DefinedAtom *curDefAtom = dyn_cast<DefinedAtom>(curAtom)) { |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 128 | if (curDefAtom->merge() == DefinedAtom::mergeAsTentative) |
| 129 | callback(tentDefName, true); |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 130 | } |
| 131 | } |
| 132 | } |
| 133 | } while (undefineGenCount != _symbolTable.size()); |
| 134 | } |
| 135 | |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 136 | void Resolver::handleArchiveFile(const File &file) { |
Rui Ueyama | 0ca88e3 | 2014-04-02 06:54:43 +0000 | [diff] [blame] | 137 | const ArchiveLibraryFile *archiveFile = cast<ArchiveLibraryFile>(&file); |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 138 | auto callback = [&](StringRef undefName, bool dataSymbolOnly) { |
| 139 | if (const File *member = archiveFile->find(undefName, dataSymbolOnly)) { |
| 140 | member->setOrdinal(_context.getNextOrdinalAndIncrement()); |
| 141 | handleFile(*member); |
| 142 | } |
| 143 | }; |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 144 | bool searchForOverrides = |
| 145 | _context.searchArchivesToOverrideTentativeDefinitions(); |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 146 | forEachUndefines(callback, searchForOverrides); |
| 147 | } |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 148 | |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 149 | void Resolver::handleSharedLibrary(const File &file) { |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 150 | // Add all the atoms from the shared library |
Rui Ueyama | 0ca88e3 | 2014-04-02 06:54:43 +0000 | [diff] [blame] | 151 | const SharedLibraryFile *sharedLibrary = cast<SharedLibraryFile>(&file); |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 152 | handleFile(*sharedLibrary); |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 153 | |
| 154 | auto callback = [&](StringRef undefName, bool dataSymbolOnly) { |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 155 | if (const SharedLibraryAtom *shAtom = |
| 156 | sharedLibrary->exports(undefName, dataSymbolOnly)) |
Rui Ueyama | 3429d01 | 2013-11-15 04:58:54 +0000 | [diff] [blame] | 157 | doSharedLibraryAtom(*shAtom); |
| 158 | }; |
| 159 | bool searchForOverrides = |
| 160 | _context.searchSharedLibrariesToOverrideTentativeDefinitions(); |
| 161 | forEachUndefines(callback, searchForOverrides); |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 162 | } |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 163 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 164 | void Resolver::doUndefinedAtom(const UndefinedAtom &atom) { |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 165 | DEBUG_WITH_TYPE("resolver", llvm::dbgs() |
| 166 | << " UndefinedAtom: " |
| 167 | << llvm::format("0x%09lX", &atom) |
| 168 | << ", name=" |
| 169 | << atom.name() |
| 170 | << "\n"); |
| 171 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 172 | // add to list of known atoms |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 173 | _atoms.push_back(&atom); |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 174 | |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 175 | // tell symbol table |
| 176 | _symbolTable.add(atom); |
| 177 | } |
| 178 | |
Shankar Easwaran | 7ac2a3d | 2014-03-26 16:37:13 +0000 | [diff] [blame] | 179 | /// \brief Add the section group and the group-child reference members. |
Shankar Easwaran | 9316c40 | 2014-04-01 03:49:55 +0000 | [diff] [blame] | 180 | bool Resolver::maybeAddSectionGroupOrGnuLinkOnce(const DefinedAtom &atom) { |
Rui Ueyama | fb44f5e | 2014-04-03 21:06:23 +0000 | [diff] [blame^] | 181 | // First time adding a group? |
Shankar Easwaran | 7ac2a3d | 2014-03-26 16:37:13 +0000 | [diff] [blame] | 182 | bool isFirstTime = _symbolTable.addGroup(atom); |
Shankar Easwaran | 9316c40 | 2014-04-01 03:49:55 +0000 | [diff] [blame] | 183 | |
| 184 | if (!isFirstTime) { |
| 185 | // If duplicate symbols are allowed, select the first group. |
| 186 | if (_context.getAllowDuplicates()) |
| 187 | return true; |
| 188 | const DefinedAtom *prevGroup = |
Rui Ueyama | b461b1c | 2014-04-02 06:54:46 +0000 | [diff] [blame] | 189 | dyn_cast<DefinedAtom>(_symbolTable.findGroup(atom.name())); |
Shankar Easwaran | 9316c40 | 2014-04-01 03:49:55 +0000 | [diff] [blame] | 190 | assert(prevGroup && |
| 191 | "Internal Error: The group atom could only be a defined atom"); |
| 192 | // The atoms should be of the same content type, reject invalid group |
| 193 | // resolution behaviors. |
| 194 | if (atom.contentType() != prevGroup->contentType()) |
| 195 | return false; |
| 196 | return true; |
| 197 | } |
Shankar Easwaran | 7ac2a3d | 2014-03-26 16:37:13 +0000 | [diff] [blame] | 198 | |
| 199 | for (const Reference *r : atom) { |
| 200 | if ((r->kindNamespace() == lld::Reference::KindNamespace::all) && |
| 201 | (r->kindValue() == lld::Reference::kindGroupChild)) { |
Rui Ueyama | b461b1c | 2014-04-02 06:54:46 +0000 | [diff] [blame] | 202 | const DefinedAtom *target = dyn_cast<DefinedAtom>(r->target()); |
Shankar Easwaran | 7ac2a3d | 2014-03-26 16:37:13 +0000 | [diff] [blame] | 203 | assert(target && "Internal Error: kindGroupChild references need to " |
| 204 | "be associated with Defined Atoms only"); |
| 205 | _atoms.push_back(target); |
| 206 | _symbolTable.add(*target); |
| 207 | } |
| 208 | } |
Shankar Easwaran | 9316c40 | 2014-04-01 03:49:55 +0000 | [diff] [blame] | 209 | return true; |
Shankar Easwaran | 7ac2a3d | 2014-03-26 16:37:13 +0000 | [diff] [blame] | 210 | } |
| 211 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 212 | // called on each atom when a file is added |
Nick Kledzik | f4fb2c5 | 2012-01-11 01:06:19 +0000 | [diff] [blame] | 213 | void Resolver::doDefinedAtom(const DefinedAtom &atom) { |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 214 | DEBUG_WITH_TYPE("resolver", llvm::dbgs() |
| 215 | << " DefinedAtom: " |
| 216 | << llvm::format("0x%09lX", &atom) |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 217 | << ", file=#" |
| 218 | << atom.file().ordinal() |
| 219 | << ", atom=#" |
| 220 | << atom.ordinal() |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 221 | << ", name=" |
| 222 | << atom.name() |
| 223 | << "\n"); |
| 224 | |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 225 | // Verify on zero-size atoms are pinned to start or end of section. |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 226 | switch (atom.sectionPosition()) { |
Shankar Easwaran | 8962feb | 2013-03-14 16:09:49 +0000 | [diff] [blame] | 227 | case DefinedAtom::sectionPositionStart: |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 228 | case DefinedAtom::sectionPositionEnd: |
Rui Ueyama | e20474d | 2013-11-13 03:30:29 +0000 | [diff] [blame] | 229 | assert(atom.size() == 0); |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 230 | break; |
Shankar Easwaran | 8962feb | 2013-03-14 16:09:49 +0000 | [diff] [blame] | 231 | case DefinedAtom::sectionPositionEarly: |
| 232 | case DefinedAtom::sectionPositionAny: |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 233 | break; |
| 234 | } |
| 235 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 236 | // add to list of known atoms |
| 237 | _atoms.push_back(&atom); |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 238 | |
Shankar Easwaran | 9316c40 | 2014-04-01 03:49:55 +0000 | [diff] [blame] | 239 | if (atom.isGroupParent()) { |
| 240 | // Raise error if there exists a similar gnu linkonce section. |
| 241 | if (!maybeAddSectionGroupOrGnuLinkOnce(atom)) { |
| 242 | llvm::errs() << "SymbolTable: error while merging " << atom.name() |
| 243 | << "\n"; |
| 244 | llvm::report_fatal_error("duplicate symbol error"); |
| 245 | } |
| 246 | } else { |
Shankar Easwaran | 7ac2a3d | 2014-03-26 16:37:13 +0000 | [diff] [blame] | 247 | _symbolTable.add(atom); |
Shankar Easwaran | 9316c40 | 2014-04-01 03:49:55 +0000 | [diff] [blame] | 248 | } |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 249 | |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 250 | if (_context.deadStrip()) { |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 251 | // add to set of dead-strip-roots, all symbols that |
| 252 | // the compiler marks as don't strip |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 253 | if (atom.deadStrip() == DefinedAtom::deadStripNever) |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 254 | _deadStripRoots.insert(&atom); |
| 255 | } |
| 256 | } |
| 257 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 258 | void Resolver::doSharedLibraryAtom(const SharedLibraryAtom &atom) { |
| 259 | DEBUG_WITH_TYPE("resolver", llvm::dbgs() |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 260 | << " SharedLibraryAtom: " |
| 261 | << llvm::format("0x%09lX", &atom) |
| 262 | << ", name=" |
| 263 | << atom.name() |
| 264 | << "\n"); |
| 265 | |
Nick Kledzik | 6bc04c6 | 2012-02-22 21:56:59 +0000 | [diff] [blame] | 266 | // add to list of known atoms |
| 267 | _atoms.push_back(&atom); |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 268 | |
Nick Kledzik | 6bc04c6 | 2012-02-22 21:56:59 +0000 | [diff] [blame] | 269 | // tell symbol table |
| 270 | _symbolTable.add(atom); |
| 271 | } |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 272 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 273 | void Resolver::doAbsoluteAtom(const AbsoluteAtom &atom) { |
| 274 | DEBUG_WITH_TYPE("resolver", llvm::dbgs() |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 275 | << " AbsoluteAtom: " |
| 276 | << llvm::format("0x%09lX", &atom) |
| 277 | << ", name=" |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 278 | << atom.name() |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 279 | << "\n"); |
| 280 | |
Nick Kledzik | 6bc04c6 | 2012-02-22 21:56:59 +0000 | [diff] [blame] | 281 | // add to list of known atoms |
| 282 | _atoms.push_back(&atom); |
Michael J. Spencer | 765792d | 2012-04-03 18:40:27 +0000 | [diff] [blame] | 283 | |
Nick Kledzik | 6bc04c6 | 2012-02-22 21:56:59 +0000 | [diff] [blame] | 284 | // tell symbol table |
Rui Ueyama | c53b3b0 | 2013-12-10 06:19:09 +0000 | [diff] [blame] | 285 | if (atom.scope() != Atom::scopeTranslationUnit) |
Hemant Kulkarni | f828613 | 2012-11-05 19:13:54 +0000 | [diff] [blame] | 286 | _symbolTable.add(atom); |
Nick Kledzik | 6bc04c6 | 2012-02-22 21:56:59 +0000 | [diff] [blame] | 287 | } |
| 288 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 289 | // utility to add a vector of atoms |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 290 | void Resolver::addAtoms(const std::vector<const DefinedAtom *> &newAtoms) { |
Rui Ueyama | c53b3b0 | 2013-12-10 06:19:09 +0000 | [diff] [blame] | 291 | for (const DefinedAtom *newAtom : newAtoms) |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 292 | doDefinedAtom(*newAtom); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 293 | } |
| 294 | |
Rui Ueyama | 2ad117d | 2013-10-11 06:26:16 +0000 | [diff] [blame] | 295 | // Keep adding atoms until _context.nextFile() returns an error. This function |
| 296 | // is where undefined atoms are resolved. |
| 297 | bool Resolver::resolveUndefines() { |
Michael J. Spencer | bd66d04 | 2013-05-28 18:55:39 +0000 | [diff] [blame] | 298 | ScopedTask task(getDefaultDomain(), "resolveUndefines"); |
Shankar Easwaran | eeee23e | 2013-04-11 02:56:30 +0000 | [diff] [blame] | 299 | |
Rui Ueyama | d542b9e | 2013-10-11 03:48:06 +0000 | [diff] [blame] | 300 | for (;;) { |
Rui Ueyama | eb4b543 | 2014-04-02 05:03:40 +0000 | [diff] [blame] | 301 | ErrorOr<File &> file = _context.inputGraph().nextFile(); |
Rafael Espindola | d28918b | 2014-01-08 22:00:09 +0000 | [diff] [blame] | 302 | error_code ec = file.getError(); |
| 303 | if (ec == InputGraphError::no_more_files) |
Rui Ueyama | 2ad117d | 2013-10-11 06:26:16 +0000 | [diff] [blame] | 304 | return true; |
Rui Ueyama | d542b9e | 2013-10-11 03:48:06 +0000 | [diff] [blame] | 305 | if (!file) { |
| 306 | llvm::errs() << "Error occurred in nextFile: " |
Rafael Espindola | d28918b | 2014-01-08 22:00:09 +0000 | [diff] [blame] | 307 | << ec.message() << "\n"; |
Rui Ueyama | 2ad117d | 2013-10-11 06:26:16 +0000 | [diff] [blame] | 308 | return false; |
Rui Ueyama | d542b9e | 2013-10-11 03:48:06 +0000 | [diff] [blame] | 309 | } |
| 310 | |
| 311 | switch (file->kind()) { |
| 312 | case File::kindObject: |
| 313 | assert(!file->hasOrdinal()); |
| 314 | file->setOrdinal(_context.getNextOrdinalAndIncrement()); |
| 315 | handleFile(*file); |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 316 | break; |
Rui Ueyama | d542b9e | 2013-10-11 03:48:06 +0000 | [diff] [blame] | 317 | case File::kindArchiveLibrary: |
| 318 | if (!file->hasOrdinal()) |
| 319 | file->setOrdinal(_context.getNextOrdinalAndIncrement()); |
| 320 | handleArchiveFile(*file); |
| 321 | break; |
| 322 | case File::kindSharedLibrary: |
| 323 | if (!file->hasOrdinal()) |
| 324 | file->setOrdinal(_context.getNextOrdinalAndIncrement()); |
| 325 | handleSharedLibrary(*file); |
| 326 | break; |
Shankar Easwaran | 1d3c48f | 2013-10-09 05:23:23 +0000 | [diff] [blame] | 327 | } |
Shankar Easwaran | a96f3a3 | 2013-10-07 02:47:09 +0000 | [diff] [blame] | 328 | } |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 329 | } |
| 330 | |
| 331 | // switch all references to undefined or coalesced away atoms |
| 332 | // to the new defined atom |
| 333 | void Resolver::updateReferences() { |
Michael J. Spencer | bd66d04 | 2013-05-28 18:55:39 +0000 | [diff] [blame] | 334 | ScopedTask task(getDefaultDomain(), "updateReferences"); |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 335 | for (const Atom *atom : _atoms) { |
| 336 | if (const DefinedAtom *defAtom = dyn_cast<DefinedAtom>(atom)) { |
Nick Kledzik | 062a98c | 2012-04-08 23:52:13 +0000 | [diff] [blame] | 337 | for (const Reference *ref : *defAtom) { |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 338 | const Atom *newTarget = _symbolTable.replacement(ref->target()); |
| 339 | const_cast<Reference *>(ref)->setTarget(newTarget); |
Nick Kledzik | 1a6615d | 2012-03-08 00:18:30 +0000 | [diff] [blame] | 340 | } |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 341 | } |
| 342 | } |
| 343 | } |
| 344 | |
Rui Ueyama | e5531fa | 2013-12-26 07:13:28 +0000 | [diff] [blame] | 345 | // For dead code stripping, recursively mark atoms "live" |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 346 | void Resolver::markLive(const Atom &atom) { |
Rui Ueyama | e5531fa | 2013-12-26 07:13:28 +0000 | [diff] [blame] | 347 | // Mark the atom is live. If it's already marked live, then stop recursion. |
| 348 | auto exists = _liveAtoms.insert(&atom); |
| 349 | if (!exists.second) |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 350 | return; |
| 351 | |
Rui Ueyama | e5531fa | 2013-12-26 07:13:28 +0000 | [diff] [blame] | 352 | // Mark all atoms it references as live |
Rui Ueyama | c481b5b | 2013-12-26 07:02:33 +0000 | [diff] [blame] | 353 | if (const DefinedAtom *defAtom = dyn_cast<DefinedAtom>(&atom)) |
| 354 | for (const Reference *ref : *defAtom) |
| 355 | if (const Atom *target = ref->target()) |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 356 | markLive(*target); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 357 | } |
| 358 | |
| 359 | // remove all atoms not actually used |
Rui Ueyama | f3630fe | 2013-10-16 19:21:50 +0000 | [diff] [blame] | 360 | void Resolver::deadStripOptimize() { |
Michael J. Spencer | bd66d04 | 2013-05-28 18:55:39 +0000 | [diff] [blame] | 361 | ScopedTask task(getDefaultDomain(), "deadStripOptimize"); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 362 | // only do this optimization with -dead_strip |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 363 | if (!_context.deadStrip()) |
Rui Ueyama | f3630fe | 2013-10-16 19:21:50 +0000 | [diff] [blame] | 364 | return; |
Rui Ueyama | 841016a | 2013-12-26 08:11:06 +0000 | [diff] [blame] | 365 | assert(_liveAtoms.empty()); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 366 | |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 367 | // By default, shared libraries are built with all globals as dead strip roots |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 368 | if (_context.globalsAreDeadStripRoots()) { |
| 369 | for (const Atom *atom : _atoms) { |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 370 | const DefinedAtom *defAtom = dyn_cast<DefinedAtom>(atom); |
| 371 | if (defAtom == nullptr) |
| 372 | continue; |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 373 | if (defAtom->scope() == DefinedAtom::scopeGlobal) |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 374 | _deadStripRoots.insert(defAtom); |
| 375 | } |
| 376 | } |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 377 | |
Joerg Sonnenberger | 03ed4cf | 2014-01-03 18:43:32 +0000 | [diff] [blame] | 378 | // Or, use list of names that are dead strip roots. |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 379 | for (const StringRef &name : _context.deadStripRoots()) { |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 380 | const Atom *symAtom = _symbolTable.findByName(name); |
Rui Ueyama | f3630fe | 2013-10-16 19:21:50 +0000 | [diff] [blame] | 381 | assert(symAtom); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 382 | _deadStripRoots.insert(symAtom); |
| 383 | } |
| 384 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 385 | // mark all roots as live, and recursively all atoms they reference |
Rui Ueyama | c53b3b0 | 2013-12-10 06:19:09 +0000 | [diff] [blame] | 386 | for (const Atom *dsrAtom : _deadStripRoots) |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 387 | markLive(*dsrAtom); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 388 | |
| 389 | // now remove all non-live atoms from _atoms |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 390 | _atoms.erase( |
| 391 | std::remove_if(_atoms.begin(), _atoms.end(), NotLive(_liveAtoms)), |
| 392 | _atoms.end()); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 393 | } |
| 394 | |
| 395 | // error out if some undefines remain |
Rui Ueyama | 43a589c | 2014-04-02 06:38:46 +0000 | [diff] [blame] | 396 | bool Resolver::checkUndefines() { |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 397 | // build vector of remaining undefined symbols |
Michael J. Spencer | 280dadb | 2013-01-31 22:56:13 +0000 | [diff] [blame] | 398 | std::vector<const UndefinedAtom *> undefinedAtoms; |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 399 | _symbolTable.undefines(undefinedAtoms); |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 400 | if (_context.deadStrip()) { |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 401 | // When dead code stripping, we don't care if dead atoms are undefined. |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 402 | undefinedAtoms.erase(std::remove_if(undefinedAtoms.begin(), |
| 403 | undefinedAtoms.end(), |
| 404 | NotLive(_liveAtoms)), |
| 405 | undefinedAtoms.end()); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 406 | } |
| 407 | |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 408 | // error message about missing symbols |
Nick Kledzik | c314b46 | 2013-04-04 18:59:24 +0000 | [diff] [blame] | 409 | if (!undefinedAtoms.empty()) { |
Shankar Easwaran | eeee23e | 2013-04-11 02:56:30 +0000 | [diff] [blame] | 410 | // FIXME: need diagnostics interface for writing error messages |
Nick Kledzik | c314b46 | 2013-04-04 18:59:24 +0000 | [diff] [blame] | 411 | bool foundUndefines = false; |
Michael J. Spencer | 280dadb | 2013-01-31 22:56:13 +0000 | [diff] [blame] | 412 | for (const UndefinedAtom *undefAtom : undefinedAtoms) { |
Shankar Easwaran | eeee23e | 2013-04-11 02:56:30 +0000 | [diff] [blame] | 413 | const File &f = undefAtom->file(); |
Michael J. Spencer | 9d70cef | 2013-04-24 19:00:26 +0000 | [diff] [blame] | 414 | |
| 415 | // Skip over a weak symbol. |
| 416 | if (undefAtom->canBeNull() != UndefinedAtom::canBeNullNever) |
| 417 | continue; |
| 418 | |
| 419 | // If this is a library and undefined symbols are allowed on the |
| 420 | // target platform, skip over it. |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 421 | if (isa<SharedLibraryFile>(f) && _context.allowShlibUndefines()) |
Michael J. Spencer | 9d70cef | 2013-04-24 19:00:26 +0000 | [diff] [blame] | 422 | continue; |
| 423 | |
Rui Ueyama | 6f325496 | 2013-09-12 21:42:52 +0000 | [diff] [blame] | 424 | // If the undefine is coalesced away, skip over it. |
| 425 | if (_symbolTable.replacement(undefAtom) != undefAtom) |
| 426 | continue; |
| 427 | |
Michael J. Spencer | 9d70cef | 2013-04-24 19:00:26 +0000 | [diff] [blame] | 428 | // Seems like this symbol is undefined. Warn that. |
| 429 | foundUndefines = true; |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 430 | if (_context.printRemainingUndefines()) { |
Rui Ueyama | 8d7a6f2 | 2014-01-18 00:57:40 +0000 | [diff] [blame] | 431 | llvm::errs() << "Undefined symbol: " << undefAtom->file().path() |
| 432 | << ": " << undefAtom->name() << "\n"; |
Michael J. Spencer | 280dadb | 2013-01-31 22:56:13 +0000 | [diff] [blame] | 433 | } |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 434 | } |
Nick Kledzik | c314b46 | 2013-04-04 18:59:24 +0000 | [diff] [blame] | 435 | if (foundUndefines) { |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 436 | if (_context.printRemainingUndefines()) |
Nick Kledzik | c314b46 | 2013-04-04 18:59:24 +0000 | [diff] [blame] | 437 | llvm::errs() << "symbol(s) not found\n"; |
| 438 | return true; |
| 439 | } |
Nick Kledzik | bb963df | 2012-04-18 21:55:06 +0000 | [diff] [blame] | 440 | } |
Nick Kledzik | c314b46 | 2013-04-04 18:59:24 +0000 | [diff] [blame] | 441 | return false; |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 442 | } |
| 443 | |
| 444 | // remove from _atoms all coaleseced away atoms |
| 445 | void Resolver::removeCoalescedAwayAtoms() { |
Michael J. Spencer | bd66d04 | 2013-05-28 18:55:39 +0000 | [diff] [blame] | 446 | ScopedTask task(getDefaultDomain(), "removeCoalescedAwayAtoms"); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 447 | _atoms.erase(std::remove_if(_atoms.begin(), _atoms.end(), |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 448 | AtomCoalescedAway(_symbolTable)), |
| 449 | _atoms.end()); |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 450 | } |
| 451 | |
Nick Kledzik | c314b46 | 2013-04-04 18:59:24 +0000 | [diff] [blame] | 452 | bool Resolver::resolve() { |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 453 | if (!resolveUndefines()) |
Rui Ueyama | 2ad117d | 2013-10-11 06:26:16 +0000 | [diff] [blame] | 454 | return false; |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 455 | updateReferences(); |
| 456 | deadStripOptimize(); |
| 457 | if (checkUndefines()) |
Rui Ueyama | 0ca149f | 2013-08-06 22:31:59 +0000 | [diff] [blame] | 458 | if (!_context.allowRemainingUndefines()) |
Rui Ueyama | ee36604 | 2013-10-11 06:16:33 +0000 | [diff] [blame] | 459 | return false; |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 460 | removeCoalescedAwayAtoms(); |
| 461 | _result->addAtoms(_atoms); |
Rui Ueyama | ee36604 | 2013-10-11 06:16:33 +0000 | [diff] [blame] | 462 | return true; |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 463 | } |
| 464 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 465 | void Resolver::MergedFile::addAtom(const Atom &atom) { |
Rui Ueyama | 251e68b | 2014-01-18 00:38:44 +0000 | [diff] [blame] | 466 | if (auto *def = dyn_cast<DefinedAtom>(&atom)) { |
| 467 | _definedAtoms._atoms.push_back(def); |
| 468 | } else if (auto *undef = dyn_cast<UndefinedAtom>(&atom)) { |
| 469 | _undefinedAtoms._atoms.push_back(undef); |
| 470 | } else if (auto *shared = dyn_cast<SharedLibraryAtom>(&atom)) { |
| 471 | _sharedLibraryAtoms._atoms.push_back(shared); |
| 472 | } else if (auto *abs = dyn_cast<AbsoluteAtom>(&atom)) { |
| 473 | _absoluteAtoms._atoms.push_back(abs); |
Michael J. Spencer | b495562 | 2012-04-02 23:56:36 +0000 | [diff] [blame] | 474 | } else { |
Nick Kledzik | 751eb3d | 2012-06-15 20:37:24 +0000 | [diff] [blame] | 475 | llvm_unreachable("atom has unknown definition kind"); |
Nick Kledzik | 1a6615d | 2012-03-08 00:18:30 +0000 | [diff] [blame] | 476 | } |
| 477 | } |
| 478 | |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 479 | MutableFile::DefinedAtomRange Resolver::MergedFile::definedAtoms() { |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 480 | return range<std::vector<const DefinedAtom *>::iterator>( |
| 481 | _definedAtoms._atoms.begin(), _definedAtoms._atoms.end()); |
Nick Kledzik | 36293f6 | 2013-01-23 22:32:56 +0000 | [diff] [blame] | 482 | } |
| 483 | |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 484 | void Resolver::MergedFile::addAtoms(std::vector<const Atom *> &all) { |
Michael J. Spencer | bd66d04 | 2013-05-28 18:55:39 +0000 | [diff] [blame] | 485 | ScopedTask task(getDefaultDomain(), "addAtoms"); |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 486 | DEBUG_WITH_TYPE("resolver", llvm::dbgs() << "Resolver final atom list:\n"); |
Rui Ueyama | fd133b3 | 2013-11-21 23:41:53 +0000 | [diff] [blame] | 487 | for (const Atom *atom : all) { |
Nick Kledzik | abb6981 | 2012-05-31 22:34:00 +0000 | [diff] [blame] | 488 | DEBUG_WITH_TYPE("resolver", llvm::dbgs() |
| 489 | << llvm::format(" 0x%09lX", atom) |
| 490 | << ", name=" |
| 491 | << atom->name() |
| 492 | << "\n"); |
Rui Ueyama | 2b2ac91 | 2014-04-03 18:13:14 +0000 | [diff] [blame] | 493 | addAtom(*atom); |
Nick Kledzik | 1a6615d | 2012-03-08 00:18:30 +0000 | [diff] [blame] | 494 | } |
| 495 | } |
| 496 | |
Michael J. Spencer | 773a8fb | 2011-12-18 08:27:59 +0000 | [diff] [blame] | 497 | } // namespace lld |