blob: e34fcbb3a1538da3517a879a93c056e6f430bc3a [file] [log] [blame]
Alexander Kornienko76c28802015-08-19 11:15:36 +00001//===--- IdentifierNamingCheck.cpp - clang-tidy ---------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
10#include "IdentifierNamingCheck.h"
11
Alexander Kornienko76c28802015-08-19 11:15:36 +000012#include "clang/ASTMatchers/ASTMatchFinder.h"
Alexander Kornienko21503902016-06-17 09:25:24 +000013#include "clang/Frontend/CompilerInstance.h"
14#include "clang/Lex/PPCallbacks.h"
15#include "clang/Lex/Preprocessor.h"
Mandeep Singh Grang7c7ea7d2016-11-08 07:50:19 +000016#include "llvm/ADT/DenseMapInfo.h"
17#include "llvm/Support/Debug.h"
18#include "llvm/Support/Format.h"
Alexander Kornienko76c28802015-08-19 11:15:36 +000019
20#define DEBUG_TYPE "clang-tidy"
21
22using namespace clang::ast_matchers;
23
Alexander Kornienko21503902016-06-17 09:25:24 +000024namespace llvm {
25/// Specialisation of DenseMapInfo to allow NamingCheckId objects in DenseMaps
26template <>
27struct DenseMapInfo<
28 clang::tidy::readability::IdentifierNamingCheck::NamingCheckId> {
29 using NamingCheckId =
30 clang::tidy::readability::IdentifierNamingCheck::NamingCheckId;
31
32 static inline NamingCheckId getEmptyKey() {
33 return NamingCheckId(
34 clang::SourceLocation::getFromRawEncoding(static_cast<unsigned>(-1)),
35 "EMPTY");
36 }
37
38 static inline NamingCheckId getTombstoneKey() {
39 return NamingCheckId(
40 clang::SourceLocation::getFromRawEncoding(static_cast<unsigned>(-2)),
41 "TOMBSTONE");
42 }
43
44 static unsigned getHashValue(NamingCheckId Val) {
45 assert(Val != getEmptyKey() && "Cannot hash the empty key!");
46 assert(Val != getTombstoneKey() && "Cannot hash the tombstone key!");
47
48 std::hash<NamingCheckId::second_type> SecondHash;
49 return Val.first.getRawEncoding() + SecondHash(Val.second);
50 }
51
Benjamin Kramera079cdb2017-03-21 21:34:58 +000052 static bool isEqual(const NamingCheckId &LHS, const NamingCheckId &RHS) {
Alexander Kornienko21503902016-06-17 09:25:24 +000053 if (RHS == getEmptyKey())
54 return LHS == getEmptyKey();
55 if (RHS == getTombstoneKey())
56 return LHS == getTombstoneKey();
57 return LHS == RHS;
58 }
59};
60} // namespace llvm
61
Alexander Kornienko76c28802015-08-19 11:15:36 +000062namespace clang {
63namespace tidy {
64namespace readability {
65
Alexander Kornienko3d777682015-09-28 08:59:12 +000066// clang-format off
Alexander Kornienko76c28802015-08-19 11:15:36 +000067#define NAMING_KEYS(m) \
68 m(Namespace) \
69 m(InlineNamespace) \
70 m(EnumConstant) \
71 m(ConstexprVariable) \
72 m(ConstantMember) \
73 m(PrivateMember) \
74 m(ProtectedMember) \
75 m(PublicMember) \
76 m(Member) \
77 m(ClassConstant) \
78 m(ClassMember) \
79 m(GlobalConstant) \
80 m(GlobalVariable) \
81 m(LocalConstant) \
82 m(LocalVariable) \
83 m(StaticConstant) \
84 m(StaticVariable) \
85 m(Constant) \
86 m(Variable) \
87 m(ConstantParameter) \
88 m(ParameterPack) \
89 m(Parameter) \
90 m(AbstractClass) \
91 m(Struct) \
92 m(Class) \
93 m(Union) \
94 m(Enum) \
95 m(GlobalFunction) \
96 m(ConstexprFunction) \
97 m(Function) \
98 m(ConstexprMethod) \
99 m(VirtualMethod) \
100 m(ClassMethod) \
101 m(PrivateMethod) \
102 m(ProtectedMethod) \
103 m(PublicMethod) \
104 m(Method) \
105 m(Typedef) \
106 m(TypeTemplateParameter) \
107 m(ValueTemplateParameter) \
108 m(TemplateTemplateParameter) \
109 m(TemplateParameter) \
Alexander Kornienko5ae76e02016-06-07 09:11:19 +0000110 m(TypeAlias) \
Alexander Kornienko21503902016-06-17 09:25:24 +0000111 m(MacroDefinition) \
Yan Zhang004b6c62018-04-23 00:15:15 +0000112 m(ObjcIvar) \
Alexander Kornienko76c28802015-08-19 11:15:36 +0000113
114enum StyleKind {
115#define ENUMERATE(v) SK_ ## v,
116 NAMING_KEYS(ENUMERATE)
117#undef ENUMERATE
118 SK_Count,
119 SK_Invalid
120};
121
122static StringRef const StyleNames[] = {
123#define STRINGIZE(v) #v,
124 NAMING_KEYS(STRINGIZE)
125#undef STRINGIZE
126};
127
128#undef NAMING_KEYS
Alexander Kornienko3d777682015-09-28 08:59:12 +0000129// clang-format on
Alexander Kornienko76c28802015-08-19 11:15:36 +0000130
Alexander Kornienko21503902016-06-17 09:25:24 +0000131namespace {
132/// Callback supplies macros to IdentifierNamingCheck::checkMacro
133class IdentifierNamingCheckPPCallbacks : public PPCallbacks {
134public:
135 IdentifierNamingCheckPPCallbacks(Preprocessor *PP,
136 IdentifierNamingCheck *Check)
137 : PP(PP), Check(Check) {}
138
139 /// MacroDefined calls checkMacro for macros in the main file
140 void MacroDefined(const Token &MacroNameTok,
141 const MacroDirective *MD) override {
142 Check->checkMacro(PP->getSourceManager(), MacroNameTok, MD->getMacroInfo());
143 }
144
145 /// MacroExpands calls expandMacro for macros in the main file
146 void MacroExpands(const Token &MacroNameTok, const MacroDefinition &MD,
147 SourceRange /*Range*/,
148 const MacroArgs * /*Args*/) override {
149 Check->expandMacro(MacroNameTok, MD.getMacroInfo());
150 }
151
152private:
153 Preprocessor *PP;
154 IdentifierNamingCheck *Check;
155};
156} // namespace
157
Alexander Kornienko76c28802015-08-19 11:15:36 +0000158IdentifierNamingCheck::IdentifierNamingCheck(StringRef Name,
159 ClangTidyContext *Context)
160 : ClangTidyCheck(Name, Context) {
161 auto const fromString = [](StringRef Str) {
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000162 return llvm::StringSwitch<llvm::Optional<CaseType>>(Str)
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000163 .Case("aNy_CasE", CT_AnyCase)
Alexander Kornienko76c28802015-08-19 11:15:36 +0000164 .Case("lower_case", CT_LowerCase)
165 .Case("UPPER_CASE", CT_UpperCase)
166 .Case("camelBack", CT_CamelBack)
167 .Case("CamelCase", CT_CamelCase)
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000168 .Case("Camel_Snake_Case", CT_CamelSnakeCase)
169 .Case("camel_Snake_Back", CT_CamelSnakeBack)
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000170 .Default(llvm::None);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000171 };
172
173 for (auto const &Name : StyleNames) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000174 auto const caseOptional =
175 fromString(Options.get((Name + "Case").str(), ""));
176 auto prefix = Options.get((Name + "Prefix").str(), "");
177 auto postfix = Options.get((Name + "Suffix").str(), "");
178
179 if (caseOptional || !prefix.empty() || !postfix.empty()) {
180 NamingStyles.push_back(NamingStyle(caseOptional, prefix, postfix));
181 } else {
182 NamingStyles.push_back(llvm::None);
183 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000184 }
185
186 IgnoreFailedSplit = Options.get("IgnoreFailedSplit", 0);
187}
188
189void IdentifierNamingCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
190 auto const toString = [](CaseType Type) {
191 switch (Type) {
192 case CT_AnyCase:
193 return "aNy_CasE";
194 case CT_LowerCase:
195 return "lower_case";
196 case CT_CamelBack:
197 return "camelBack";
198 case CT_UpperCase:
199 return "UPPER_CASE";
200 case CT_CamelCase:
201 return "CamelCase";
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000202 case CT_CamelSnakeCase:
203 return "Camel_Snake_Case";
204 case CT_CamelSnakeBack:
205 return "camel_Snake_Back";
Alexander Kornienko76c28802015-08-19 11:15:36 +0000206 }
207
208 llvm_unreachable("Unknown Case Type");
209 };
210
211 for (size_t i = 0; i < SK_Count; ++i) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000212 if (NamingStyles[i]) {
213 if (NamingStyles[i]->Case) {
214 Options.store(Opts, (StyleNames[i] + "Case").str(),
215 toString(*NamingStyles[i]->Case));
216 }
217 Options.store(Opts, (StyleNames[i] + "Prefix").str(),
218 NamingStyles[i]->Prefix);
219 Options.store(Opts, (StyleNames[i] + "Suffix").str(),
220 NamingStyles[i]->Suffix);
221 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000222 }
223
224 Options.store(Opts, "IgnoreFailedSplit", IgnoreFailedSplit);
225}
226
227void IdentifierNamingCheck::registerMatchers(MatchFinder *Finder) {
Alexander Kornienko76c28802015-08-19 11:15:36 +0000228 Finder->addMatcher(namedDecl().bind("decl"), this);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000229 Finder->addMatcher(usingDecl().bind("using"), this);
230 Finder->addMatcher(declRefExpr().bind("declRef"), this);
231 Finder->addMatcher(cxxConstructorDecl().bind("classRef"), this);
232 Finder->addMatcher(cxxDestructorDecl().bind("classRef"), this);
233 Finder->addMatcher(typeLoc().bind("typeLoc"), this);
234 Finder->addMatcher(nestedNameSpecifierLoc().bind("nestedNameLoc"), this);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000235}
236
Alexander Kornienko21503902016-06-17 09:25:24 +0000237void IdentifierNamingCheck::registerPPCallbacks(CompilerInstance &Compiler) {
238 Compiler.getPreprocessor().addPPCallbacks(
239 llvm::make_unique<IdentifierNamingCheckPPCallbacks>(
240 &Compiler.getPreprocessor(), this));
241}
242
Alexander Kornienko76c28802015-08-19 11:15:36 +0000243static bool matchesStyle(StringRef Name,
244 IdentifierNamingCheck::NamingStyle Style) {
245 static llvm::Regex Matchers[] = {
246 llvm::Regex("^.*$"),
247 llvm::Regex("^[a-z][a-z0-9_]*$"),
248 llvm::Regex("^[a-z][a-zA-Z0-9]*$"),
249 llvm::Regex("^[A-Z][A-Z0-9_]*$"),
250 llvm::Regex("^[A-Z][a-zA-Z0-9]*$"),
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000251 llvm::Regex("^[A-Z]([a-z0-9]*(_[A-Z])?)*"),
252 llvm::Regex("^[a-z]([a-z0-9]*(_[A-Z])?)*"),
Alexander Kornienko76c28802015-08-19 11:15:36 +0000253 };
254
255 bool Matches = true;
256 if (Name.startswith(Style.Prefix))
257 Name = Name.drop_front(Style.Prefix.size());
258 else
259 Matches = false;
260
261 if (Name.endswith(Style.Suffix))
262 Name = Name.drop_back(Style.Suffix.size());
263 else
264 Matches = false;
265
Alexander Kornienkoeec01ad2017-04-26 16:39:11 +0000266 // Ensure the name doesn't have any extra underscores beyond those specified
267 // in the prefix and suffix.
268 if (Name.startswith("_") || Name.endswith("_"))
269 Matches = false;
270
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000271 if (Style.Case && !Matchers[static_cast<size_t>(*Style.Case)].match(Name))
Alexander Kornienko76c28802015-08-19 11:15:36 +0000272 Matches = false;
273
274 return Matches;
275}
276
277static std::string fixupWithCase(StringRef Name,
278 IdentifierNamingCheck::CaseType Case) {
279 static llvm::Regex Splitter(
280 "([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$)");
281
282 SmallVector<StringRef, 8> Substrs;
283 Name.split(Substrs, "_", -1, false);
284
285 SmallVector<StringRef, 8> Words;
286 for (auto Substr : Substrs) {
287 while (!Substr.empty()) {
288 SmallVector<StringRef, 8> Groups;
289 if (!Splitter.match(Substr, &Groups))
290 break;
291
292 if (Groups[2].size() > 0) {
293 Words.push_back(Groups[1]);
294 Substr = Substr.substr(Groups[0].size());
295 } else if (Groups[3].size() > 0) {
296 Words.push_back(Groups[3]);
297 Substr = Substr.substr(Groups[0].size() - Groups[4].size());
298 } else if (Groups[5].size() > 0) {
299 Words.push_back(Groups[5]);
300 Substr = Substr.substr(Groups[0].size() - Groups[6].size());
301 }
302 }
303 }
304
305 if (Words.empty())
306 return Name;
307
308 std::string Fixup;
309 switch (Case) {
310 case IdentifierNamingCheck::CT_AnyCase:
311 Fixup += Name;
312 break;
313
314 case IdentifierNamingCheck::CT_LowerCase:
315 for (auto const &Word : Words) {
316 if (&Word != &Words.front())
317 Fixup += "_";
318 Fixup += Word.lower();
319 }
320 break;
321
322 case IdentifierNamingCheck::CT_UpperCase:
323 for (auto const &Word : Words) {
324 if (&Word != &Words.front())
325 Fixup += "_";
326 Fixup += Word.upper();
327 }
328 break;
329
330 case IdentifierNamingCheck::CT_CamelCase:
331 for (auto const &Word : Words) {
332 Fixup += Word.substr(0, 1).upper();
333 Fixup += Word.substr(1).lower();
334 }
335 break;
336
337 case IdentifierNamingCheck::CT_CamelBack:
338 for (auto const &Word : Words) {
339 if (&Word == &Words.front()) {
340 Fixup += Word.lower();
341 } else {
342 Fixup += Word.substr(0, 1).upper();
343 Fixup += Word.substr(1).lower();
344 }
345 }
346 break;
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000347
348 case IdentifierNamingCheck::CT_CamelSnakeCase:
349 for (auto const &Word : Words) {
350 if (&Word != &Words.front())
351 Fixup += "_";
352 Fixup += Word.substr(0, 1).upper();
353 Fixup += Word.substr(1).lower();
354 }
355 break;
356
357 case IdentifierNamingCheck::CT_CamelSnakeBack:
358 for (auto const &Word : Words) {
359 if (&Word != &Words.front()) {
360 Fixup += "_";
361 Fixup += Word.substr(0, 1).upper();
362 } else {
363 Fixup += Word.substr(0, 1).lower();
364 }
365 Fixup += Word.substr(1).lower();
366 }
367 break;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000368 }
369
370 return Fixup;
371}
372
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000373static std::string
374fixupWithStyle(StringRef Name,
375 const IdentifierNamingCheck::NamingStyle &Style) {
Alexander Kornienkoeec01ad2017-04-26 16:39:11 +0000376 const std::string Fixed = fixupWithCase(
377 Name, Style.Case.getValueOr(IdentifierNamingCheck::CaseType::CT_AnyCase));
378 StringRef Mid = StringRef(Fixed).trim("_");
379 if (Mid.empty())
380 Mid = "_";
381 return (Style.Prefix + Mid + Style.Suffix).str();
Alexander Kornienko76c28802015-08-19 11:15:36 +0000382}
383
384static StyleKind findStyleKind(
385 const NamedDecl *D,
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000386 const std::vector<llvm::Optional<IdentifierNamingCheck::NamingStyle>>
387 &NamingStyles) {
Artem Belevichfcfcd502018-09-18 21:51:02 +0000388 assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() &&
389 "Decl must be an explicit identifier with a name.");
390
Yan Zhang004b6c62018-04-23 00:15:15 +0000391 if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar])
392 return SK_ObjcIvar;
393
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000394 if (isa<TypedefDecl>(D) && NamingStyles[SK_Typedef])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000395 return SK_Typedef;
396
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000397 if (isa<TypeAliasDecl>(D) && NamingStyles[SK_TypeAlias])
Alexander Kornienko5ae76e02016-06-07 09:11:19 +0000398 return SK_TypeAlias;
399
Alexander Kornienko76c28802015-08-19 11:15:36 +0000400 if (const auto *Decl = dyn_cast<NamespaceDecl>(D)) {
401 if (Decl->isAnonymousNamespace())
402 return SK_Invalid;
403
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000404 if (Decl->isInline() && NamingStyles[SK_InlineNamespace])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000405 return SK_InlineNamespace;
406
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000407 if (NamingStyles[SK_Namespace])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000408 return SK_Namespace;
409 }
410
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000411 if (isa<EnumDecl>(D) && NamingStyles[SK_Enum])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000412 return SK_Enum;
413
414 if (isa<EnumConstantDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000415 if (NamingStyles[SK_EnumConstant])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000416 return SK_EnumConstant;
417
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000418 if (NamingStyles[SK_Constant])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000419 return SK_Constant;
420
421 return SK_Invalid;
422 }
423
424 if (const auto *Decl = dyn_cast<CXXRecordDecl>(D)) {
425 if (Decl->isAnonymousStructOrUnion())
426 return SK_Invalid;
427
Jonathan Coe89f12c02016-11-03 13:52:09 +0000428 if (!Decl->getCanonicalDecl()->isThisDeclarationADefinition())
429 return SK_Invalid;
430
Alexander Kornienko76c28802015-08-19 11:15:36 +0000431 if (Decl->hasDefinition() && Decl->isAbstract() &&
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000432 NamingStyles[SK_AbstractClass])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000433 return SK_AbstractClass;
434
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000435 if (Decl->isStruct() && NamingStyles[SK_Struct])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000436 return SK_Struct;
437
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000438 if (Decl->isStruct() && NamingStyles[SK_Class])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000439 return SK_Class;
440
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000441 if (Decl->isClass() && NamingStyles[SK_Class])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000442 return SK_Class;
443
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000444 if (Decl->isClass() && NamingStyles[SK_Struct])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000445 return SK_Struct;
446
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000447 if (Decl->isUnion() && NamingStyles[SK_Union])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000448 return SK_Union;
449
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000450 if (Decl->isEnum() && NamingStyles[SK_Enum])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000451 return SK_Enum;
452
453 return SK_Invalid;
454 }
455
456 if (const auto *Decl = dyn_cast<FieldDecl>(D)) {
457 QualType Type = Decl->getType();
458
Alexander Kornienkoba874922017-12-11 19:02:26 +0000459 if (!Type.isNull() && Type.isConstQualified()) {
460 if (NamingStyles[SK_ConstantMember])
461 return SK_ConstantMember;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000462
Alexander Kornienkoba874922017-12-11 19:02:26 +0000463 if (NamingStyles[SK_Constant])
464 return SK_Constant;
465 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000466
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000467 if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000468 return SK_PrivateMember;
469
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000470 if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000471 return SK_ProtectedMember;
472
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000473 if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000474 return SK_PublicMember;
475
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000476 if (NamingStyles[SK_Member])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000477 return SK_Member;
478
479 return SK_Invalid;
480 }
481
482 if (const auto *Decl = dyn_cast<ParmVarDecl>(D)) {
483 QualType Type = Decl->getType();
484
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000485 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000486 return SK_ConstexprVariable;
487
Alexander Kornienkoba874922017-12-11 19:02:26 +0000488 if (!Type.isNull() && Type.isConstQualified()) {
489 if (NamingStyles[SK_ConstantParameter])
490 return SK_ConstantParameter;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000491
Alexander Kornienkoba874922017-12-11 19:02:26 +0000492 if (NamingStyles[SK_Constant])
493 return SK_Constant;
494 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000495
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000496 if (Decl->isParameterPack() && NamingStyles[SK_ParameterPack])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000497 return SK_ParameterPack;
498
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000499 if (NamingStyles[SK_Parameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000500 return SK_Parameter;
501
502 return SK_Invalid;
503 }
504
505 if (const auto *Decl = dyn_cast<VarDecl>(D)) {
506 QualType Type = Decl->getType();
507
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000508 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000509 return SK_ConstexprVariable;
510
Alexander Kornienkoba874922017-12-11 19:02:26 +0000511 if (!Type.isNull() && Type.isConstQualified()) {
512 if (Decl->isStaticDataMember() && NamingStyles[SK_ClassConstant])
513 return SK_ClassConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000514
Alexander Kornienkoba874922017-12-11 19:02:26 +0000515 if (Decl->isFileVarDecl() && NamingStyles[SK_GlobalConstant])
516 return SK_GlobalConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000517
Alexander Kornienkoba874922017-12-11 19:02:26 +0000518 if (Decl->isStaticLocal() && NamingStyles[SK_StaticConstant])
519 return SK_StaticConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000520
Alexander Kornienkoba874922017-12-11 19:02:26 +0000521 if (Decl->isLocalVarDecl() && NamingStyles[SK_LocalConstant])
522 return SK_LocalConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000523
Alexander Kornienkoba874922017-12-11 19:02:26 +0000524 if (Decl->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalConstant])
525 return SK_LocalConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000526
Alexander Kornienkoba874922017-12-11 19:02:26 +0000527 if (NamingStyles[SK_Constant])
528 return SK_Constant;
529 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000530
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000531 if (Decl->isStaticDataMember() && NamingStyles[SK_ClassMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000532 return SK_ClassMember;
533
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000534 if (Decl->isFileVarDecl() && NamingStyles[SK_GlobalVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000535 return SK_GlobalVariable;
536
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000537 if (Decl->isStaticLocal() && NamingStyles[SK_StaticVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000538 return SK_StaticVariable;
539
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000540 if (Decl->isLocalVarDecl() && NamingStyles[SK_LocalVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000541 return SK_LocalVariable;
542
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000543 if (Decl->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000544 return SK_LocalVariable;
545
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000546 if (NamingStyles[SK_Variable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000547 return SK_Variable;
548
549 return SK_Invalid;
550 }
551
552 if (const auto *Decl = dyn_cast<CXXMethodDecl>(D)) {
553 if (Decl->isMain() || !Decl->isUserProvided() ||
Alexander Kornienko76c28802015-08-19 11:15:36 +0000554 Decl->size_overridden_methods() > 0)
555 return SK_Invalid;
556
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000557 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000558 return SK_ConstexprMethod;
559
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000560 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000561 return SK_ConstexprFunction;
562
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000563 if (Decl->isStatic() && NamingStyles[SK_ClassMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000564 return SK_ClassMethod;
565
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000566 if (Decl->isVirtual() && NamingStyles[SK_VirtualMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000567 return SK_VirtualMethod;
568
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000569 if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000570 return SK_PrivateMethod;
571
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000572 if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000573 return SK_ProtectedMethod;
574
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000575 if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000576 return SK_PublicMethod;
577
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000578 if (NamingStyles[SK_Method])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000579 return SK_Method;
580
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000581 if (NamingStyles[SK_Function])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000582 return SK_Function;
583
584 return SK_Invalid;
585 }
586
587 if (const auto *Decl = dyn_cast<FunctionDecl>(D)) {
588 if (Decl->isMain())
589 return SK_Invalid;
590
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000591 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000592 return SK_ConstexprFunction;
593
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000594 if (Decl->isGlobal() && NamingStyles[SK_GlobalFunction])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000595 return SK_GlobalFunction;
596
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000597 if (NamingStyles[SK_Function])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000598 return SK_Function;
599 }
600
601 if (isa<TemplateTypeParmDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000602 if (NamingStyles[SK_TypeTemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000603 return SK_TypeTemplateParameter;
604
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000605 if (NamingStyles[SK_TemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000606 return SK_TemplateParameter;
607
608 return SK_Invalid;
609 }
610
611 if (isa<NonTypeTemplateParmDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000612 if (NamingStyles[SK_ValueTemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000613 return SK_ValueTemplateParameter;
614
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000615 if (NamingStyles[SK_TemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000616 return SK_TemplateParameter;
617
618 return SK_Invalid;
619 }
620
621 if (isa<TemplateTemplateParmDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000622 if (NamingStyles[SK_TemplateTemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000623 return SK_TemplateTemplateParameter;
624
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000625 if (NamingStyles[SK_TemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000626 return SK_TemplateParameter;
627
628 return SK_Invalid;
629 }
630
631 return SK_Invalid;
632}
633
Alexander Kornienko3d777682015-09-28 08:59:12 +0000634static void addUsage(IdentifierNamingCheck::NamingCheckFailureMap &Failures,
Alexander Kornienko21503902016-06-17 09:25:24 +0000635 const IdentifierNamingCheck::NamingCheckId &Decl,
Jason Henline481e6aa2016-10-24 17:20:32 +0000636 SourceRange Range, SourceManager *SourceMgr = nullptr) {
Jonathan Coe2c8592a2016-01-26 18:55:55 +0000637 // Do nothing if the provided range is invalid.
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000638 if (Range.getBegin().isInvalid() || Range.getEnd().isInvalid())
639 return;
640
Jason Henline481e6aa2016-10-24 17:20:32 +0000641 // If we have a source manager, use it to convert to the spelling location for
642 // performing the fix. This is necessary because macros can map the same
643 // spelling location to different source locations, and we only want to fix
644 // the token once, before it is expanded by the macro.
645 SourceLocation FixLocation = Range.getBegin();
646 if (SourceMgr)
647 FixLocation = SourceMgr->getSpellingLoc(FixLocation);
648 if (FixLocation.isInvalid())
649 return;
650
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000651 // Try to insert the identifier location in the Usages map, and bail out if it
652 // is already in there
Alexander Kornienko3d777682015-09-28 08:59:12 +0000653 auto &Failure = Failures[Decl];
Jason Henline481e6aa2016-10-24 17:20:32 +0000654 if (!Failure.RawUsageLocs.insert(FixLocation.getRawEncoding()).second)
Alexander Kornienko3d777682015-09-28 08:59:12 +0000655 return;
656
Jason Henline481e6aa2016-10-24 17:20:32 +0000657 if (!Failure.ShouldFix)
658 return;
659
660 // Check if the range is entirely contained within a macro argument.
661 SourceLocation MacroArgExpansionStartForRangeBegin;
662 SourceLocation MacroArgExpansionStartForRangeEnd;
663 bool RangeIsEntirelyWithinMacroArgument =
664 SourceMgr &&
665 SourceMgr->isMacroArgExpansion(Range.getBegin(),
666 &MacroArgExpansionStartForRangeBegin) &&
667 SourceMgr->isMacroArgExpansion(Range.getEnd(),
668 &MacroArgExpansionStartForRangeEnd) &&
669 MacroArgExpansionStartForRangeBegin == MacroArgExpansionStartForRangeEnd;
670
671 // Check if the range contains any locations from a macro expansion.
672 bool RangeContainsMacroExpansion = RangeIsEntirelyWithinMacroArgument ||
673 Range.getBegin().isMacroID() ||
674 Range.getEnd().isMacroID();
675
676 bool RangeCanBeFixed =
677 RangeIsEntirelyWithinMacroArgument || !RangeContainsMacroExpansion;
678 Failure.ShouldFix = RangeCanBeFixed;
Alexander Kornienko3d777682015-09-28 08:59:12 +0000679}
680
Alexander Kornienko21503902016-06-17 09:25:24 +0000681/// Convenience method when the usage to be added is a NamedDecl
682static void addUsage(IdentifierNamingCheck::NamingCheckFailureMap &Failures,
Mandeep Singh Grang7c7ea7d2016-11-08 07:50:19 +0000683 const NamedDecl *Decl, SourceRange Range,
684 SourceManager *SourceMgr = nullptr) {
Alexander Kornienkoba874922017-12-11 19:02:26 +0000685 return addUsage(Failures,
686 IdentifierNamingCheck::NamingCheckId(Decl->getLocation(),
687 Decl->getNameAsString()),
Jason Henline481e6aa2016-10-24 17:20:32 +0000688 Range, SourceMgr);
Alexander Kornienko21503902016-06-17 09:25:24 +0000689}
690
Alexander Kornienko76c28802015-08-19 11:15:36 +0000691void IdentifierNamingCheck::check(const MatchFinder::MatchResult &Result) {
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000692 if (const auto *Decl =
693 Result.Nodes.getNodeAs<CXXConstructorDecl>("classRef")) {
694 if (Decl->isImplicit())
695 return;
696
697 addUsage(NamingCheckFailures, Decl->getParent(),
Alexander Kornienko21503902016-06-17 09:25:24 +0000698 Decl->getNameInfo().getSourceRange());
Eric Fiselier732a3e02016-11-16 21:15:58 +0000699
700 for (const auto *Init : Decl->inits()) {
701 if (!Init->isWritten() || Init->isInClassMemberInitializer())
702 continue;
703 if (const auto *FD = Init->getAnyMember())
Alexander Kornienkoba874922017-12-11 19:02:26 +0000704 addUsage(NamingCheckFailures, FD,
705 SourceRange(Init->getMemberLocation()));
Eric Fiselier732a3e02016-11-16 21:15:58 +0000706 // Note: delegating constructors and base class initializers are handled
707 // via the "typeLoc" matcher.
708 }
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000709 return;
710 }
711
712 if (const auto *Decl =
713 Result.Nodes.getNodeAs<CXXDestructorDecl>("classRef")) {
714 if (Decl->isImplicit())
715 return;
716
717 SourceRange Range = Decl->getNameInfo().getSourceRange();
718 if (Range.getBegin().isInvalid())
719 return;
720 // The first token that will be found is the ~ (or the equivalent trigraph),
721 // we want instead to replace the next token, that will be the identifier.
722 Range.setBegin(CharSourceRange::getTokenRange(Range).getEnd());
723
Alexander Kornienko21503902016-06-17 09:25:24 +0000724 addUsage(NamingCheckFailures, Decl->getParent(), Range);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000725 return;
726 }
727
728 if (const auto *Loc = Result.Nodes.getNodeAs<TypeLoc>("typeLoc")) {
729 NamedDecl *Decl = nullptr;
730 if (const auto &Ref = Loc->getAs<TagTypeLoc>()) {
731 Decl = Ref.getDecl();
732 } else if (const auto &Ref = Loc->getAs<InjectedClassNameTypeLoc>()) {
733 Decl = Ref.getDecl();
734 } else if (const auto &Ref = Loc->getAs<UnresolvedUsingTypeLoc>()) {
735 Decl = Ref.getDecl();
736 } else if (const auto &Ref = Loc->getAs<TemplateTypeParmTypeLoc>()) {
737 Decl = Ref.getDecl();
738 }
739
740 if (Decl) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000741 addUsage(NamingCheckFailures, Decl, Loc->getSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000742 return;
743 }
744
745 if (const auto &Ref = Loc->getAs<TemplateSpecializationTypeLoc>()) {
746 const auto *Decl =
747 Ref.getTypePtr()->getTemplateName().getAsTemplateDecl();
748
749 SourceRange Range(Ref.getTemplateNameLoc(), Ref.getTemplateNameLoc());
750 if (const auto *ClassDecl = dyn_cast<TemplateDecl>(Decl)) {
Matthias Gehrea9e812b2016-07-09 20:09:28 +0000751 if (const auto *TemplDecl = ClassDecl->getTemplatedDecl())
752 addUsage(NamingCheckFailures, TemplDecl, Range);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000753 return;
754 }
755 }
756
757 if (const auto &Ref =
758 Loc->getAs<DependentTemplateSpecializationTypeLoc>()) {
Matthias Gehrea9e812b2016-07-09 20:09:28 +0000759 if (const auto *Decl = Ref.getTypePtr()->getAsTagDecl())
760 addUsage(NamingCheckFailures, Decl, Loc->getSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000761 return;
762 }
763 }
764
765 if (const auto *Loc =
766 Result.Nodes.getNodeAs<NestedNameSpecifierLoc>("nestedNameLoc")) {
767 if (NestedNameSpecifier *Spec = Loc->getNestedNameSpecifier()) {
768 if (NamespaceDecl *Decl = Spec->getAsNamespace()) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000769 addUsage(NamingCheckFailures, Decl, Loc->getLocalSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000770 return;
771 }
772 }
773 }
774
775 if (const auto *Decl = Result.Nodes.getNodeAs<UsingDecl>("using")) {
776 for (const auto &Shadow : Decl->shadows()) {
777 addUsage(NamingCheckFailures, Shadow->getTargetDecl(),
Alexander Kornienko21503902016-06-17 09:25:24 +0000778 Decl->getNameInfo().getSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000779 }
780 return;
781 }
782
783 if (const auto *DeclRef = Result.Nodes.getNodeAs<DeclRefExpr>("declRef")) {
Alexander Kornienko76c28802015-08-19 11:15:36 +0000784 SourceRange Range = DeclRef->getNameInfo().getSourceRange();
Mandeep Singh Grang7c7ea7d2016-11-08 07:50:19 +0000785 addUsage(NamingCheckFailures, DeclRef->getDecl(), Range,
786 Result.SourceManager);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000787 return;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000788 }
789
790 if (const auto *Decl = Result.Nodes.getNodeAs<NamedDecl>("decl")) {
791 if (!Decl->getIdentifier() || Decl->getName().empty() || Decl->isImplicit())
792 return;
793
Alexander Kornienko21503902016-06-17 09:25:24 +0000794 // Fix type aliases in value declarations
795 if (const auto *Value = Result.Nodes.getNodeAs<ValueDecl>("decl")) {
796 if (const auto *Typedef =
797 Value->getType().getTypePtr()->getAs<TypedefType>()) {
798 addUsage(NamingCheckFailures, Typedef->getDecl(),
799 Value->getSourceRange());
800 }
801 }
802
803 // Fix type aliases in function declarations
804 if (const auto *Value = Result.Nodes.getNodeAs<FunctionDecl>("decl")) {
805 if (const auto *Typedef =
806 Value->getReturnType().getTypePtr()->getAs<TypedefType>()) {
807 addUsage(NamingCheckFailures, Typedef->getDecl(),
808 Value->getSourceRange());
809 }
810 for (unsigned i = 0; i < Value->getNumParams(); ++i) {
811 if (const auto *Typedef = Value->parameters()[i]
812 ->getType()
813 .getTypePtr()
814 ->getAs<TypedefType>()) {
815 addUsage(NamingCheckFailures, Typedef->getDecl(),
816 Value->getSourceRange());
817 }
818 }
819 }
820
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000821 // Ignore ClassTemplateSpecializationDecl which are creating duplicate
822 // replacements with CXXRecordDecl
823 if (isa<ClassTemplateSpecializationDecl>(Decl))
824 return;
825
Alexander Kornienko76c28802015-08-19 11:15:36 +0000826 StyleKind SK = findStyleKind(Decl, NamingStyles);
827 if (SK == SK_Invalid)
828 return;
829
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000830 if (!NamingStyles[SK])
831 return;
832
833 const NamingStyle &Style = *NamingStyles[SK];
Alexander Kornienko76c28802015-08-19 11:15:36 +0000834 StringRef Name = Decl->getName();
835 if (matchesStyle(Name, Style))
836 return;
837
838 std::string KindName = fixupWithCase(StyleNames[SK], CT_LowerCase);
839 std::replace(KindName.begin(), KindName.end(), '_', ' ');
840
841 std::string Fixup = fixupWithStyle(Name, Style);
842 if (StringRef(Fixup).equals(Name)) {
843 if (!IgnoreFailedSplit) {
Nicola Zaghen0efd5242018-05-15 16:37:45 +0000844 LLVM_DEBUG(llvm::dbgs()
Stephen Kelly43465bf2018-08-09 22:42:26 +0000845 << Decl->getBeginLoc().printToString(*Result.SourceManager)
Nicola Zaghen0efd5242018-05-15 16:37:45 +0000846 << llvm::format(": unable to split words for %s '%s'\n",
847 KindName.c_str(), Name.str().c_str()));
Alexander Kornienko76c28802015-08-19 11:15:36 +0000848 }
849 } else {
Alexander Kornienko21503902016-06-17 09:25:24 +0000850 NamingCheckFailure &Failure = NamingCheckFailures[NamingCheckId(
851 Decl->getLocation(), Decl->getNameAsString())];
Alexander Kornienko76c28802015-08-19 11:15:36 +0000852 SourceRange Range =
853 DeclarationNameInfo(Decl->getDeclName(), Decl->getLocation())
854 .getSourceRange();
855
856 Failure.Fixup = std::move(Fixup);
857 Failure.KindName = std::move(KindName);
Alexander Kornienko21503902016-06-17 09:25:24 +0000858 addUsage(NamingCheckFailures, Decl, Range);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000859 }
860 }
861}
862
Alexander Kornienko21503902016-06-17 09:25:24 +0000863void IdentifierNamingCheck::checkMacro(SourceManager &SourceMgr,
864 const Token &MacroNameTok,
865 const MacroInfo *MI) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000866 if (!NamingStyles[SK_MacroDefinition])
867 return;
868
Alexander Kornienko21503902016-06-17 09:25:24 +0000869 StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000870 const NamingStyle &Style = *NamingStyles[SK_MacroDefinition];
Alexander Kornienko21503902016-06-17 09:25:24 +0000871 if (matchesStyle(Name, Style))
872 return;
873
874 std::string KindName =
875 fixupWithCase(StyleNames[SK_MacroDefinition], CT_LowerCase);
876 std::replace(KindName.begin(), KindName.end(), '_', ' ');
877
878 std::string Fixup = fixupWithStyle(Name, Style);
879 if (StringRef(Fixup).equals(Name)) {
880 if (!IgnoreFailedSplit) {
Nicola Zaghen0efd5242018-05-15 16:37:45 +0000881 LLVM_DEBUG(llvm::dbgs()
882 << MacroNameTok.getLocation().printToString(SourceMgr)
883 << llvm::format(": unable to split words for %s '%s'\n",
884 KindName.c_str(), Name.str().c_str()));
Alexander Kornienko21503902016-06-17 09:25:24 +0000885 }
886 } else {
887 NamingCheckId ID(MI->getDefinitionLoc(), Name);
888 NamingCheckFailure &Failure = NamingCheckFailures[ID];
889 SourceRange Range(MacroNameTok.getLocation(), MacroNameTok.getEndLoc());
890
891 Failure.Fixup = std::move(Fixup);
892 Failure.KindName = std::move(KindName);
893 addUsage(NamingCheckFailures, ID, Range);
894 }
895}
896
897void IdentifierNamingCheck::expandMacro(const Token &MacroNameTok,
898 const MacroInfo *MI) {
899 StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
900 NamingCheckId ID(MI->getDefinitionLoc(), Name);
901
902 auto Failure = NamingCheckFailures.find(ID);
903 if (Failure == NamingCheckFailures.end())
904 return;
905
906 SourceRange Range(MacroNameTok.getLocation(), MacroNameTok.getEndLoc());
907 addUsage(NamingCheckFailures, ID, Range);
908}
909
Alexander Kornienko76c28802015-08-19 11:15:36 +0000910void IdentifierNamingCheck::onEndOfTranslationUnit() {
911 for (const auto &Pair : NamingCheckFailures) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000912 const NamingCheckId &Decl = Pair.first;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000913 const NamingCheckFailure &Failure = Pair.second;
914
Alexander Kornienko3d777682015-09-28 08:59:12 +0000915 if (Failure.KindName.empty())
916 continue;
917
Alexander Kornienko76c28802015-08-19 11:15:36 +0000918 if (Failure.ShouldFix) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000919 auto Diag = diag(Decl.first, "invalid case style for %0 '%1'")
920 << Failure.KindName << Decl.second;
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000921
Alexander Kornienko3d777682015-09-28 08:59:12 +0000922 for (const auto &Loc : Failure.RawUsageLocs) {
923 // We assume that the identifier name is made of one token only. This is
924 // always the case as we ignore usages in macros that could build
925 // identifier names by combining multiple tokens.
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000926 //
927 // For destructors, we alread take care of it by remembering the
928 // location of the start of the identifier and not the start of the
929 // tilde.
930 //
931 // Other multi-token identifiers, such as operators are not checked at
932 // all.
Alexander Kornienko76c28802015-08-19 11:15:36 +0000933 Diag << FixItHint::CreateReplacement(
Alexander Kornienko3d777682015-09-28 08:59:12 +0000934 SourceRange(SourceLocation::getFromRawEncoding(Loc)),
935 Failure.Fixup);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000936 }
937 }
938 }
939}
940
941} // namespace readability
942} // namespace tidy
943} // namespace clang