Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 1 | //===-- SeparateConstOffsetFromGEP.cpp - ------------------------*- C++ -*-===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // Loop unrolling may create many similar GEPs for array accesses. |
| 11 | // e.g., a 2-level loop |
| 12 | // |
| 13 | // float a[32][32]; // global variable |
| 14 | // |
| 15 | // for (int i = 0; i < 2; ++i) { |
| 16 | // for (int j = 0; j < 2; ++j) { |
| 17 | // ... |
| 18 | // ... = a[x + i][y + j]; |
| 19 | // ... |
| 20 | // } |
| 21 | // } |
| 22 | // |
| 23 | // will probably be unrolled to: |
| 24 | // |
| 25 | // gep %a, 0, %x, %y; load |
| 26 | // gep %a, 0, %x, %y + 1; load |
| 27 | // gep %a, 0, %x + 1, %y; load |
| 28 | // gep %a, 0, %x + 1, %y + 1; load |
| 29 | // |
| 30 | // LLVM's GVN does not use partial redundancy elimination yet, and is thus |
| 31 | // unable to reuse (gep %a, 0, %x, %y). As a result, this misoptimization incurs |
| 32 | // significant slowdown in targets with limited addressing modes. For instance, |
| 33 | // because the PTX target does not support the reg+reg addressing mode, the |
| 34 | // NVPTX backend emits PTX code that literally computes the pointer address of |
| 35 | // each GEP, wasting tons of registers. It emits the following PTX for the |
| 36 | // first load and similar PTX for other loads. |
| 37 | // |
| 38 | // mov.u32 %r1, %x; |
| 39 | // mov.u32 %r2, %y; |
| 40 | // mul.wide.u32 %rl2, %r1, 128; |
| 41 | // mov.u64 %rl3, a; |
| 42 | // add.s64 %rl4, %rl3, %rl2; |
| 43 | // mul.wide.u32 %rl5, %r2, 4; |
| 44 | // add.s64 %rl6, %rl4, %rl5; |
| 45 | // ld.global.f32 %f1, [%rl6]; |
| 46 | // |
| 47 | // To reduce the register pressure, the optimization implemented in this file |
| 48 | // merges the common part of a group of GEPs, so we can compute each pointer |
| 49 | // address by adding a simple offset to the common part, saving many registers. |
| 50 | // |
| 51 | // It works by splitting each GEP into a variadic base and a constant offset. |
| 52 | // The variadic base can be computed once and reused by multiple GEPs, and the |
| 53 | // constant offsets can be nicely folded into the reg+immediate addressing mode |
| 54 | // (supported by most targets) without using any extra register. |
| 55 | // |
| 56 | // For instance, we transform the four GEPs and four loads in the above example |
| 57 | // into: |
| 58 | // |
| 59 | // base = gep a, 0, x, y |
| 60 | // load base |
| 61 | // laod base + 1 * sizeof(float) |
| 62 | // load base + 32 * sizeof(float) |
| 63 | // load base + 33 * sizeof(float) |
| 64 | // |
| 65 | // Given the transformed IR, a backend that supports the reg+immediate |
| 66 | // addressing mode can easily fold the pointer arithmetics into the loads. For |
| 67 | // example, the NVPTX backend can easily fold the pointer arithmetics into the |
| 68 | // ld.global.f32 instructions, and the resultant PTX uses much fewer registers. |
| 69 | // |
| 70 | // mov.u32 %r1, %tid.x; |
| 71 | // mov.u32 %r2, %tid.y; |
| 72 | // mul.wide.u32 %rl2, %r1, 128; |
| 73 | // mov.u64 %rl3, a; |
| 74 | // add.s64 %rl4, %rl3, %rl2; |
| 75 | // mul.wide.u32 %rl5, %r2, 4; |
| 76 | // add.s64 %rl6, %rl4, %rl5; |
| 77 | // ld.global.f32 %f1, [%rl6]; // so far the same as unoptimized PTX |
| 78 | // ld.global.f32 %f2, [%rl6+4]; // much better |
| 79 | // ld.global.f32 %f3, [%rl6+128]; // much better |
| 80 | // ld.global.f32 %f4, [%rl6+132]; // much better |
| 81 | // |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 82 | // Another improvement enabled by the LowerGEP flag is to lower a GEP with |
| 83 | // multiple indices to either multiple GEPs with a single index or arithmetic |
| 84 | // operations (depending on whether the target uses alias analysis in codegen). |
| 85 | // Such transformation can have following benefits: |
| 86 | // (1) It can always extract constants in the indices of structure type. |
| 87 | // (2) After such Lowering, there are more optimization opportunities such as |
| 88 | // CSE, LICM and CGP. |
| 89 | // |
| 90 | // E.g. The following GEPs have multiple indices: |
| 91 | // BB1: |
| 92 | // %p = getelementptr [10 x %struct]* %ptr, i64 %i, i64 %j1, i32 3 |
| 93 | // load %p |
| 94 | // ... |
| 95 | // BB2: |
| 96 | // %p2 = getelementptr [10 x %struct]* %ptr, i64 %i, i64 %j1, i32 2 |
| 97 | // load %p2 |
| 98 | // ... |
| 99 | // |
| 100 | // We can not do CSE for to the common part related to index "i64 %i". Lowering |
| 101 | // GEPs can achieve such goals. |
| 102 | // If the target does not use alias analysis in codegen, this pass will |
| 103 | // lower a GEP with multiple indices into arithmetic operations: |
| 104 | // BB1: |
| 105 | // %1 = ptrtoint [10 x %struct]* %ptr to i64 ; CSE opportunity |
| 106 | // %2 = mul i64 %i, length_of_10xstruct ; CSE opportunity |
| 107 | // %3 = add i64 %1, %2 ; CSE opportunity |
| 108 | // %4 = mul i64 %j1, length_of_struct |
| 109 | // %5 = add i64 %3, %4 |
| 110 | // %6 = add i64 %3, struct_field_3 ; Constant offset |
| 111 | // %p = inttoptr i64 %6 to i32* |
| 112 | // load %p |
| 113 | // ... |
| 114 | // BB2: |
| 115 | // %7 = ptrtoint [10 x %struct]* %ptr to i64 ; CSE opportunity |
| 116 | // %8 = mul i64 %i, length_of_10xstruct ; CSE opportunity |
| 117 | // %9 = add i64 %7, %8 ; CSE opportunity |
| 118 | // %10 = mul i64 %j2, length_of_struct |
| 119 | // %11 = add i64 %9, %10 |
| 120 | // %12 = add i64 %11, struct_field_2 ; Constant offset |
| 121 | // %p = inttoptr i64 %12 to i32* |
| 122 | // load %p2 |
| 123 | // ... |
| 124 | // |
| 125 | // If the target uses alias analysis in codegen, this pass will lower a GEP |
| 126 | // with multiple indices into multiple GEPs with a single index: |
| 127 | // BB1: |
| 128 | // %1 = bitcast [10 x %struct]* %ptr to i8* ; CSE opportunity |
| 129 | // %2 = mul i64 %i, length_of_10xstruct ; CSE opportunity |
| 130 | // %3 = getelementptr i8* %1, i64 %2 ; CSE opportunity |
| 131 | // %4 = mul i64 %j1, length_of_struct |
| 132 | // %5 = getelementptr i8* %3, i64 %4 |
| 133 | // %6 = getelementptr i8* %5, struct_field_3 ; Constant offset |
| 134 | // %p = bitcast i8* %6 to i32* |
| 135 | // load %p |
| 136 | // ... |
| 137 | // BB2: |
| 138 | // %7 = bitcast [10 x %struct]* %ptr to i8* ; CSE opportunity |
| 139 | // %8 = mul i64 %i, length_of_10xstruct ; CSE opportunity |
| 140 | // %9 = getelementptr i8* %7, i64 %8 ; CSE opportunity |
| 141 | // %10 = mul i64 %j2, length_of_struct |
| 142 | // %11 = getelementptr i8* %9, i64 %10 |
| 143 | // %12 = getelementptr i8* %11, struct_field_2 ; Constant offset |
| 144 | // %p2 = bitcast i8* %12 to i32* |
| 145 | // load %p2 |
| 146 | // ... |
| 147 | // |
| 148 | // Lowering GEPs can also benefit other passes such as LICM and CGP. |
| 149 | // LICM (Loop Invariant Code Motion) can not hoist/sink a GEP of multiple |
| 150 | // indices if one of the index is variant. If we lower such GEP into invariant |
| 151 | // parts and variant parts, LICM can hoist/sink those invariant parts. |
| 152 | // CGP (CodeGen Prepare) tries to sink address calculations that match the |
| 153 | // target's addressing modes. A GEP with multiple indices may not match and will |
| 154 | // not be sunk. If we lower such GEP into smaller parts, CGP may sink some of |
| 155 | // them. So we end up with a better addressing mode. |
| 156 | // |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 157 | //===----------------------------------------------------------------------===// |
| 158 | |
| 159 | #include "llvm/Analysis/TargetTransformInfo.h" |
| 160 | #include "llvm/Analysis/ValueTracking.h" |
| 161 | #include "llvm/IR/Constants.h" |
| 162 | #include "llvm/IR/DataLayout.h" |
| 163 | #include "llvm/IR/Instructions.h" |
| 164 | #include "llvm/IR/LLVMContext.h" |
| 165 | #include "llvm/IR/Module.h" |
| 166 | #include "llvm/IR/Operator.h" |
| 167 | #include "llvm/Support/CommandLine.h" |
| 168 | #include "llvm/Support/raw_ostream.h" |
| 169 | #include "llvm/Transforms/Scalar.h" |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 170 | #include "llvm/Target/TargetMachine.h" |
| 171 | #include "llvm/Target/TargetSubtargetInfo.h" |
| 172 | #include "llvm/IR/IRBuilder.h" |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 173 | |
| 174 | using namespace llvm; |
| 175 | |
| 176 | static cl::opt<bool> DisableSeparateConstOffsetFromGEP( |
| 177 | "disable-separate-const-offset-from-gep", cl::init(false), |
| 178 | cl::desc("Do not separate the constant offset from a GEP instruction"), |
| 179 | cl::Hidden); |
| 180 | |
| 181 | namespace { |
| 182 | |
| 183 | /// \brief A helper class for separating a constant offset from a GEP index. |
| 184 | /// |
| 185 | /// In real programs, a GEP index may be more complicated than a simple addition |
| 186 | /// of something and a constant integer which can be trivially splitted. For |
| 187 | /// example, to split ((a << 3) | 5) + b, we need to search deeper for the |
Alp Toker | beaca19 | 2014-05-15 01:52:21 +0000 | [diff] [blame] | 188 | /// constant offset, so that we can separate the index to (a << 3) + b and 5. |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 189 | /// |
| 190 | /// Therefore, this class looks into the expression that computes a given GEP |
| 191 | /// index, and tries to find a constant integer that can be hoisted to the |
| 192 | /// outermost level of the expression as an addition. Not every constant in an |
| 193 | /// expression can jump out. e.g., we cannot transform (b * (a + 5)) to (b * a + |
| 194 | /// 5); nor can we transform (3 * (a + 5)) to (3 * a + 5), however in this case, |
| 195 | /// -instcombine probably already optimized (3 * (a + 5)) to (3 * a + 15). |
| 196 | class ConstantOffsetExtractor { |
| 197 | public: |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 198 | /// Extracts a constant offset from the given GEP index. It returns the |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 199 | /// new index representing the remainder (equal to the original index minus |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 200 | /// the constant offset), or nullptr if we cannot extract a constant offset. |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 201 | /// \p Idx The given GEP index |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 202 | /// \p DL The datalayout of the module |
| 203 | /// \p GEP The given GEP |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 204 | static Value *Extract(Value *Idx, const DataLayout *DL, |
| 205 | GetElementPtrInst *GEP); |
| 206 | /// Looks for a constant offset from the given GEP index without extracting |
| 207 | /// it. It returns the numeric value of the extracted constant offset (0 if |
| 208 | /// failed). The meaning of the arguments are the same as Extract. |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 209 | static int64_t Find(Value *Idx, const DataLayout *DL, GetElementPtrInst *GEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 210 | |
| 211 | private: |
| 212 | ConstantOffsetExtractor(const DataLayout *Layout, Instruction *InsertionPt) |
| 213 | : DL(Layout), IP(InsertionPt) {} |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 214 | /// Searches the expression that computes V for a non-zero constant C s.t. |
| 215 | /// V can be reassociated into the form V' + C. If the searching is |
| 216 | /// successful, returns C and update UserChain as a def-use chain from C to V; |
| 217 | /// otherwise, UserChain is empty. |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 218 | /// |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 219 | /// \p V The given expression |
| 220 | /// \p SignExtended Whether V will be sign-extended in the computation of the |
| 221 | /// GEP index |
| 222 | /// \p ZeroExtended Whether V will be zero-extended in the computation of the |
| 223 | /// GEP index |
| 224 | /// \p NonNegative Whether V is guaranteed to be non-negative. For example, |
| 225 | /// an index of an inbounds GEP is guaranteed to be |
| 226 | /// non-negative. Levaraging this, we can better split |
| 227 | /// inbounds GEPs. |
| 228 | APInt find(Value *V, bool SignExtended, bool ZeroExtended, bool NonNegative); |
| 229 | /// A helper function to look into both operands of a binary operator. |
| 230 | APInt findInEitherOperand(BinaryOperator *BO, bool SignExtended, |
| 231 | bool ZeroExtended); |
| 232 | /// After finding the constant offset C from the GEP index I, we build a new |
| 233 | /// index I' s.t. I' + C = I. This function builds and returns the new |
| 234 | /// index I' according to UserChain produced by function "find". |
| 235 | /// |
| 236 | /// The building conceptually takes two steps: |
| 237 | /// 1) iteratively distribute s/zext towards the leaves of the expression tree |
| 238 | /// that computes I |
| 239 | /// 2) reassociate the expression tree to the form I' + C. |
| 240 | /// |
| 241 | /// For example, to extract the 5 from sext(a + (b + 5)), we first distribute |
| 242 | /// sext to a, b and 5 so that we have |
| 243 | /// sext(a) + (sext(b) + 5). |
| 244 | /// Then, we reassociate it to |
| 245 | /// (sext(a) + sext(b)) + 5. |
| 246 | /// Given this form, we know I' is sext(a) + sext(b). |
| 247 | Value *rebuildWithoutConstOffset(); |
| 248 | /// After the first step of rebuilding the GEP index without the constant |
| 249 | /// offset, distribute s/zext to the operands of all operators in UserChain. |
| 250 | /// e.g., zext(sext(a + (b + 5)) (assuming no overflow) => |
| 251 | /// zext(sext(a)) + (zext(sext(b)) + zext(sext(5))). |
| 252 | /// |
| 253 | /// The function also updates UserChain to point to new subexpressions after |
| 254 | /// distributing s/zext. e.g., the old UserChain of the above example is |
| 255 | /// 5 -> b + 5 -> a + (b + 5) -> sext(...) -> zext(sext(...)), |
| 256 | /// and the new UserChain is |
| 257 | /// zext(sext(5)) -> zext(sext(b)) + zext(sext(5)) -> |
| 258 | /// zext(sext(a)) + (zext(sext(b)) + zext(sext(5)) |
| 259 | /// |
| 260 | /// \p ChainIndex The index to UserChain. ChainIndex is initially |
| 261 | /// UserChain.size() - 1, and is decremented during |
| 262 | /// the recursion. |
| 263 | Value *distributeExtsAndCloneChain(unsigned ChainIndex); |
| 264 | /// Reassociates the GEP index to the form I' + C and returns I'. |
| 265 | Value *removeConstOffset(unsigned ChainIndex); |
| 266 | /// A helper function to apply ExtInsts, a list of s/zext, to value V. |
| 267 | /// e.g., if ExtInsts = [sext i32 to i64, zext i16 to i32], this function |
| 268 | /// returns "sext i32 (zext i16 V to i32) to i64". |
| 269 | Value *applyExts(Value *V); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 270 | |
| 271 | /// Returns true if LHS and RHS have no bits in common, i.e., LHS | RHS == 0. |
| 272 | bool NoCommonBits(Value *LHS, Value *RHS) const; |
| 273 | /// Computes which bits are known to be one or zero. |
| 274 | /// \p KnownOne Mask of all bits that are known to be one. |
| 275 | /// \p KnownZero Mask of all bits that are known to be zero. |
| 276 | void ComputeKnownBits(Value *V, APInt &KnownOne, APInt &KnownZero) const; |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 277 | /// A helper function that returns whether we can trace into the operands |
| 278 | /// of binary operator BO for a constant offset. |
| 279 | /// |
| 280 | /// \p SignExtended Whether BO is surrounded by sext |
| 281 | /// \p ZeroExtended Whether BO is surrounded by zext |
| 282 | /// \p NonNegative Whether BO is known to be non-negative, e.g., an in-bound |
| 283 | /// array index. |
| 284 | bool CanTraceInto(bool SignExtended, bool ZeroExtended, BinaryOperator *BO, |
| 285 | bool NonNegative); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 286 | |
| 287 | /// The path from the constant offset to the old GEP index. e.g., if the GEP |
| 288 | /// index is "a * b + (c + 5)". After running function find, UserChain[0] will |
| 289 | /// be the constant 5, UserChain[1] will be the subexpression "c + 5", and |
| 290 | /// UserChain[2] will be the entire expression "a * b + (c + 5)". |
| 291 | /// |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 292 | /// This path helps to rebuild the new GEP index. |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 293 | SmallVector<User *, 8> UserChain; |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 294 | /// A data structure used in rebuildWithoutConstOffset. Contains all |
| 295 | /// sext/zext instructions along UserChain. |
| 296 | SmallVector<CastInst *, 16> ExtInsts; |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 297 | /// The data layout of the module. Used in ComputeKnownBits. |
| 298 | const DataLayout *DL; |
| 299 | Instruction *IP; /// Insertion position of cloned instructions. |
| 300 | }; |
| 301 | |
| 302 | /// \brief A pass that tries to split every GEP in the function into a variadic |
Alp Toker | beaca19 | 2014-05-15 01:52:21 +0000 | [diff] [blame] | 303 | /// base and a constant offset. It is a FunctionPass because searching for the |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 304 | /// constant offset may inspect other basic blocks. |
| 305 | class SeparateConstOffsetFromGEP : public FunctionPass { |
| 306 | public: |
| 307 | static char ID; |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 308 | SeparateConstOffsetFromGEP(const TargetMachine *TM = nullptr, |
| 309 | bool LowerGEP = false) |
| 310 | : FunctionPass(ID), TM(TM), LowerGEP(LowerGEP) { |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 311 | initializeSeparateConstOffsetFromGEPPass(*PassRegistry::getPassRegistry()); |
| 312 | } |
| 313 | |
| 314 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
| 315 | AU.addRequired<DataLayoutPass>(); |
Chandler Carruth | 705b185 | 2015-01-31 03:43:40 +0000 | [diff] [blame] | 316 | AU.addRequired<TargetTransformInfoWrapperPass>(); |
Jingyue Wu | 6e091c8 | 2015-02-01 02:33:02 +0000 | [diff] [blame] | 317 | AU.setPreservesCFG(); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 318 | } |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 319 | |
| 320 | bool doInitialization(Module &M) override { |
| 321 | DataLayoutPass *DLP = getAnalysisIfAvailable<DataLayoutPass>(); |
| 322 | if (DLP == nullptr) |
| 323 | report_fatal_error("data layout missing"); |
| 324 | DL = &DLP->getDataLayout(); |
| 325 | return false; |
| 326 | } |
| 327 | |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 328 | bool runOnFunction(Function &F) override; |
| 329 | |
| 330 | private: |
| 331 | /// Tries to split the given GEP into a variadic base and a constant offset, |
| 332 | /// and returns true if the splitting succeeds. |
| 333 | bool splitGEP(GetElementPtrInst *GEP); |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 334 | /// Lower a GEP with multiple indices into multiple GEPs with a single index. |
| 335 | /// Function splitGEP already split the original GEP into a variadic part and |
| 336 | /// a constant offset (i.e., AccumulativeByteOffset). This function lowers the |
| 337 | /// variadic part into a set of GEPs with a single index and applies |
| 338 | /// AccumulativeByteOffset to it. |
| 339 | /// \p Variadic The variadic part of the original GEP. |
| 340 | /// \p AccumulativeByteOffset The constant offset. |
| 341 | void lowerToSingleIndexGEPs(GetElementPtrInst *Variadic, |
| 342 | int64_t AccumulativeByteOffset); |
| 343 | /// Lower a GEP with multiple indices into ptrtoint+arithmetics+inttoptr form. |
| 344 | /// Function splitGEP already split the original GEP into a variadic part and |
| 345 | /// a constant offset (i.e., AccumulativeByteOffset). This function lowers the |
| 346 | /// variadic part into a set of arithmetic operations and applies |
| 347 | /// AccumulativeByteOffset to it. |
| 348 | /// \p Variadic The variadic part of the original GEP. |
| 349 | /// \p AccumulativeByteOffset The constant offset. |
| 350 | void lowerToArithmetics(GetElementPtrInst *Variadic, |
| 351 | int64_t AccumulativeByteOffset); |
| 352 | /// Finds the constant offset within each index and accumulates them. If |
| 353 | /// LowerGEP is true, it finds in indices of both sequential and structure |
| 354 | /// types, otherwise it only finds in sequential indices. The output |
| 355 | /// NeedsExtraction indicates whether we successfully find a non-zero constant |
| 356 | /// offset. |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 357 | int64_t accumulateByteOffset(GetElementPtrInst *GEP, bool &NeedsExtraction); |
| 358 | /// Canonicalize array indices to pointer-size integers. This helps to |
| 359 | /// simplify the logic of splitting a GEP. For example, if a + b is a |
| 360 | /// pointer-size integer, we have |
| 361 | /// gep base, a + b = gep (gep base, a), b |
| 362 | /// However, this equality may not hold if the size of a + b is smaller than |
| 363 | /// the pointer size, because LLVM conceptually sign-extends GEP indices to |
| 364 | /// pointer size before computing the address |
| 365 | /// (http://llvm.org/docs/LangRef.html#id181). |
| 366 | /// |
| 367 | /// This canonicalization is very likely already done in clang and |
| 368 | /// instcombine. Therefore, the program will probably remain the same. |
| 369 | /// |
Jingyue Wu | 5c7b1ae | 2014-06-08 23:49:34 +0000 | [diff] [blame] | 370 | /// Returns true if the module changes. |
| 371 | /// |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 372 | /// Verified in @i32_add in split-gep.ll |
| 373 | bool canonicalizeArrayIndicesToPointerSize(GetElementPtrInst *GEP); |
| 374 | |
| 375 | const DataLayout *DL; |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 376 | const TargetMachine *TM; |
| 377 | /// Whether to lower a GEP with multiple indices into arithmetic operations or |
| 378 | /// multiple GEPs with a single index. |
| 379 | bool LowerGEP; |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 380 | }; |
| 381 | } // anonymous namespace |
| 382 | |
| 383 | char SeparateConstOffsetFromGEP::ID = 0; |
| 384 | INITIALIZE_PASS_BEGIN( |
| 385 | SeparateConstOffsetFromGEP, "separate-const-offset-from-gep", |
| 386 | "Split GEPs to a variadic base and a constant offset for better CSE", false, |
| 387 | false) |
Chandler Carruth | 705b185 | 2015-01-31 03:43:40 +0000 | [diff] [blame] | 388 | INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 389 | INITIALIZE_PASS_DEPENDENCY(DataLayoutPass) |
| 390 | INITIALIZE_PASS_END( |
| 391 | SeparateConstOffsetFromGEP, "separate-const-offset-from-gep", |
| 392 | "Split GEPs to a variadic base and a constant offset for better CSE", false, |
| 393 | false) |
| 394 | |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 395 | FunctionPass * |
| 396 | llvm::createSeparateConstOffsetFromGEPPass(const TargetMachine *TM, |
| 397 | bool LowerGEP) { |
| 398 | return new SeparateConstOffsetFromGEP(TM, LowerGEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 399 | } |
| 400 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 401 | bool ConstantOffsetExtractor::CanTraceInto(bool SignExtended, |
| 402 | bool ZeroExtended, |
| 403 | BinaryOperator *BO, |
| 404 | bool NonNegative) { |
| 405 | // We only consider ADD, SUB and OR, because a non-zero constant found in |
| 406 | // expressions composed of these operations can be easily hoisted as a |
| 407 | // constant offset by reassociation. |
| 408 | if (BO->getOpcode() != Instruction::Add && |
| 409 | BO->getOpcode() != Instruction::Sub && |
| 410 | BO->getOpcode() != Instruction::Or) { |
| 411 | return false; |
| 412 | } |
| 413 | |
| 414 | Value *LHS = BO->getOperand(0), *RHS = BO->getOperand(1); |
| 415 | // Do not trace into "or" unless it is equivalent to "add". If LHS and RHS |
| 416 | // don't have common bits, (LHS | RHS) is equivalent to (LHS + RHS). |
| 417 | if (BO->getOpcode() == Instruction::Or && !NoCommonBits(LHS, RHS)) |
| 418 | return false; |
| 419 | |
| 420 | // In addition, tracing into BO requires that its surrounding s/zext (if |
| 421 | // any) is distributable to both operands. |
| 422 | // |
| 423 | // Suppose BO = A op B. |
| 424 | // SignExtended | ZeroExtended | Distributable? |
| 425 | // --------------+--------------+---------------------------------- |
| 426 | // 0 | 0 | true because no s/zext exists |
| 427 | // 0 | 1 | zext(BO) == zext(A) op zext(B) |
| 428 | // 1 | 0 | sext(BO) == sext(A) op sext(B) |
| 429 | // 1 | 1 | zext(sext(BO)) == |
| 430 | // | | zext(sext(A)) op zext(sext(B)) |
Jingyue Wu | 01ceeb1 | 2014-06-08 20:19:38 +0000 | [diff] [blame] | 431 | if (BO->getOpcode() == Instruction::Add && !ZeroExtended && NonNegative) { |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 432 | // If a + b >= 0 and (a >= 0 or b >= 0), then |
Jingyue Wu | 01ceeb1 | 2014-06-08 20:19:38 +0000 | [diff] [blame] | 433 | // sext(a + b) = sext(a) + sext(b) |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 434 | // even if the addition is not marked nsw. |
| 435 | // |
| 436 | // Leveraging this invarient, we can trace into an sext'ed inbound GEP |
| 437 | // index if the constant offset is non-negative. |
| 438 | // |
| 439 | // Verified in @sext_add in split-gep.ll. |
| 440 | if (ConstantInt *ConstLHS = dyn_cast<ConstantInt>(LHS)) { |
| 441 | if (!ConstLHS->isNegative()) |
| 442 | return true; |
| 443 | } |
| 444 | if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(RHS)) { |
| 445 | if (!ConstRHS->isNegative()) |
| 446 | return true; |
| 447 | } |
| 448 | } |
Jingyue Wu | 80a738d | 2014-05-27 18:00:00 +0000 | [diff] [blame] | 449 | |
| 450 | // sext (add/sub nsw A, B) == add/sub nsw (sext A), (sext B) |
| 451 | // zext (add/sub nuw A, B) == add/sub nuw (zext A), (zext B) |
| 452 | if (BO->getOpcode() == Instruction::Add || |
| 453 | BO->getOpcode() == Instruction::Sub) { |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 454 | if (SignExtended && !BO->hasNoSignedWrap()) |
| 455 | return false; |
| 456 | if (ZeroExtended && !BO->hasNoUnsignedWrap()) |
| 457 | return false; |
Jingyue Wu | 80a738d | 2014-05-27 18:00:00 +0000 | [diff] [blame] | 458 | } |
| 459 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 460 | return true; |
Jingyue Wu | 80a738d | 2014-05-27 18:00:00 +0000 | [diff] [blame] | 461 | } |
| 462 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 463 | APInt ConstantOffsetExtractor::findInEitherOperand(BinaryOperator *BO, |
| 464 | bool SignExtended, |
| 465 | bool ZeroExtended) { |
| 466 | // BO being non-negative does not shed light on whether its operands are |
| 467 | // non-negative. Clear the NonNegative flag here. |
| 468 | APInt ConstantOffset = find(BO->getOperand(0), SignExtended, ZeroExtended, |
| 469 | /* NonNegative */ false); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 470 | // If we found a constant offset in the left operand, stop and return that. |
| 471 | // This shortcut might cause us to miss opportunities of combining the |
| 472 | // constant offsets in both operands, e.g., (a + 4) + (b + 5) => (a + b) + 9. |
| 473 | // However, such cases are probably already handled by -instcombine, |
| 474 | // given this pass runs after the standard optimizations. |
| 475 | if (ConstantOffset != 0) return ConstantOffset; |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 476 | ConstantOffset = find(BO->getOperand(1), SignExtended, ZeroExtended, |
| 477 | /* NonNegative */ false); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 478 | // If U is a sub operator, negate the constant offset found in the right |
| 479 | // operand. |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 480 | if (BO->getOpcode() == Instruction::Sub) |
| 481 | ConstantOffset = -ConstantOffset; |
| 482 | return ConstantOffset; |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 483 | } |
| 484 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 485 | APInt ConstantOffsetExtractor::find(Value *V, bool SignExtended, |
| 486 | bool ZeroExtended, bool NonNegative) { |
| 487 | // TODO(jingyue): We could trace into integer/pointer casts, such as |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 488 | // inttoptr, ptrtoint, bitcast, and addrspacecast. We choose to handle only |
| 489 | // integers because it gives good enough results for our benchmarks. |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 490 | unsigned BitWidth = cast<IntegerType>(V->getType())->getBitWidth(); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 491 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 492 | // We cannot do much with Values that are not a User, such as an Argument. |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 493 | User *U = dyn_cast<User>(V); |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 494 | if (U == nullptr) return APInt(BitWidth, 0); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 495 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 496 | APInt ConstantOffset(BitWidth, 0); |
| 497 | if (ConstantInt *CI = dyn_cast<ConstantInt>(V)) { |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 498 | // Hooray, we found it! |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 499 | ConstantOffset = CI->getValue(); |
| 500 | } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(V)) { |
| 501 | // Trace into subexpressions for more hoisting opportunities. |
| 502 | if (CanTraceInto(SignExtended, ZeroExtended, BO, NonNegative)) { |
| 503 | ConstantOffset = findInEitherOperand(BO, SignExtended, ZeroExtended); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 504 | } |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 505 | } else if (isa<SExtInst>(V)) { |
| 506 | ConstantOffset = find(U->getOperand(0), /* SignExtended */ true, |
| 507 | ZeroExtended, NonNegative).sext(BitWidth); |
| 508 | } else if (isa<ZExtInst>(V)) { |
| 509 | // As an optimization, we can clear the SignExtended flag because |
| 510 | // sext(zext(a)) = zext(a). Verified in @sext_zext in split-gep.ll. |
| 511 | // |
| 512 | // Clear the NonNegative flag, because zext(a) >= 0 does not imply a >= 0. |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 513 | ConstantOffset = |
| 514 | find(U->getOperand(0), /* SignExtended */ false, |
| 515 | /* ZeroExtended */ true, /* NonNegative */ false).zext(BitWidth); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 516 | } |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 517 | |
| 518 | // If we found a non-zero constant offset, add it to the path for |
| 519 | // rebuildWithoutConstOffset. Zero is a valid constant offset, but doesn't |
| 520 | // help this optimization. |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 521 | if (ConstantOffset != 0) |
| 522 | UserChain.push_back(U); |
| 523 | return ConstantOffset; |
| 524 | } |
| 525 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 526 | Value *ConstantOffsetExtractor::applyExts(Value *V) { |
| 527 | Value *Current = V; |
| 528 | // ExtInsts is built in the use-def order. Therefore, we apply them to V |
| 529 | // in the reversed order. |
| 530 | for (auto I = ExtInsts.rbegin(), E = ExtInsts.rend(); I != E; ++I) { |
| 531 | if (Constant *C = dyn_cast<Constant>(Current)) { |
| 532 | // If Current is a constant, apply s/zext using ConstantExpr::getCast. |
| 533 | // ConstantExpr::getCast emits a ConstantInt if C is a ConstantInt. |
| 534 | Current = ConstantExpr::getCast((*I)->getOpcode(), C, (*I)->getType()); |
| 535 | } else { |
| 536 | Instruction *Ext = (*I)->clone(); |
| 537 | Ext->setOperand(0, Current); |
| 538 | Ext->insertBefore(IP); |
| 539 | Current = Ext; |
| 540 | } |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 541 | } |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 542 | return Current; |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 543 | } |
| 544 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 545 | Value *ConstantOffsetExtractor::rebuildWithoutConstOffset() { |
| 546 | distributeExtsAndCloneChain(UserChain.size() - 1); |
| 547 | // Remove all nullptrs (used to be s/zext) from UserChain. |
| 548 | unsigned NewSize = 0; |
| 549 | for (auto I = UserChain.begin(), E = UserChain.end(); I != E; ++I) { |
| 550 | if (*I != nullptr) { |
| 551 | UserChain[NewSize] = *I; |
| 552 | NewSize++; |
| 553 | } |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 554 | } |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 555 | UserChain.resize(NewSize); |
| 556 | return removeConstOffset(UserChain.size() - 1); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 557 | } |
| 558 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 559 | Value * |
| 560 | ConstantOffsetExtractor::distributeExtsAndCloneChain(unsigned ChainIndex) { |
| 561 | User *U = UserChain[ChainIndex]; |
| 562 | if (ChainIndex == 0) { |
| 563 | assert(isa<ConstantInt>(U)); |
| 564 | // If U is a ConstantInt, applyExts will return a ConstantInt as well. |
| 565 | return UserChain[ChainIndex] = cast<ConstantInt>(applyExts(U)); |
| 566 | } |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 567 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 568 | if (CastInst *Cast = dyn_cast<CastInst>(U)) { |
| 569 | assert((isa<SExtInst>(Cast) || isa<ZExtInst>(Cast)) && |
| 570 | "We only traced into two types of CastInst: sext and zext"); |
| 571 | ExtInsts.push_back(Cast); |
| 572 | UserChain[ChainIndex] = nullptr; |
| 573 | return distributeExtsAndCloneChain(ChainIndex - 1); |
| 574 | } |
| 575 | |
| 576 | // Function find only trace into BinaryOperator and CastInst. |
| 577 | BinaryOperator *BO = cast<BinaryOperator>(U); |
| 578 | // OpNo = which operand of BO is UserChain[ChainIndex - 1] |
| 579 | unsigned OpNo = (BO->getOperand(0) == UserChain[ChainIndex - 1] ? 0 : 1); |
| 580 | Value *TheOther = applyExts(BO->getOperand(1 - OpNo)); |
| 581 | Value *NextInChain = distributeExtsAndCloneChain(ChainIndex - 1); |
| 582 | |
| 583 | BinaryOperator *NewBO = nullptr; |
| 584 | if (OpNo == 0) { |
| 585 | NewBO = BinaryOperator::Create(BO->getOpcode(), NextInChain, TheOther, |
| 586 | BO->getName(), IP); |
| 587 | } else { |
| 588 | NewBO = BinaryOperator::Create(BO->getOpcode(), TheOther, NextInChain, |
| 589 | BO->getName(), IP); |
| 590 | } |
| 591 | return UserChain[ChainIndex] = NewBO; |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 592 | } |
| 593 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 594 | Value *ConstantOffsetExtractor::removeConstOffset(unsigned ChainIndex) { |
| 595 | if (ChainIndex == 0) { |
| 596 | assert(isa<ConstantInt>(UserChain[ChainIndex])); |
| 597 | return ConstantInt::getNullValue(UserChain[ChainIndex]->getType()); |
| 598 | } |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 599 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 600 | BinaryOperator *BO = cast<BinaryOperator>(UserChain[ChainIndex]); |
| 601 | unsigned OpNo = (BO->getOperand(0) == UserChain[ChainIndex - 1] ? 0 : 1); |
| 602 | assert(BO->getOperand(OpNo) == UserChain[ChainIndex - 1]); |
| 603 | Value *NextInChain = removeConstOffset(ChainIndex - 1); |
| 604 | Value *TheOther = BO->getOperand(1 - OpNo); |
| 605 | |
| 606 | // If NextInChain is 0 and not the LHS of a sub, we can simplify the |
| 607 | // sub-expression to be just TheOther. |
| 608 | if (ConstantInt *CI = dyn_cast<ConstantInt>(NextInChain)) { |
| 609 | if (CI->isZero() && !(BO->getOpcode() == Instruction::Sub && OpNo == 0)) |
| 610 | return TheOther; |
| 611 | } |
| 612 | |
| 613 | if (BO->getOpcode() == Instruction::Or) { |
| 614 | // Rebuild "or" as "add", because "or" may be invalid for the new |
| 615 | // epxression. |
| 616 | // |
| 617 | // For instance, given |
| 618 | // a | (b + 5) where a and b + 5 have no common bits, |
| 619 | // we can extract 5 as the constant offset. |
| 620 | // |
| 621 | // However, reusing the "or" in the new index would give us |
| 622 | // (a | b) + 5 |
| 623 | // which does not equal a | (b + 5). |
| 624 | // |
| 625 | // Replacing the "or" with "add" is fine, because |
| 626 | // a | (b + 5) = a + (b + 5) = (a + b) + 5 |
Jingyue Wu | b723152 | 2014-10-25 17:36:21 +0000 | [diff] [blame] | 627 | if (OpNo == 0) { |
| 628 | return BinaryOperator::CreateAdd(NextInChain, TheOther, BO->getName(), |
| 629 | IP); |
| 630 | } else { |
| 631 | return BinaryOperator::CreateAdd(TheOther, NextInChain, BO->getName(), |
| 632 | IP); |
| 633 | } |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 634 | } |
| 635 | |
| 636 | // We can reuse BO in this case, because the new expression shares the same |
| 637 | // instruction type and BO is used at most once. |
| 638 | assert(BO->getNumUses() <= 1 && |
| 639 | "distributeExtsAndCloneChain clones each BinaryOperator in " |
| 640 | "UserChain, so no one should be used more than " |
| 641 | "once"); |
| 642 | BO->setOperand(OpNo, NextInChain); |
| 643 | BO->setHasNoSignedWrap(false); |
| 644 | BO->setHasNoUnsignedWrap(false); |
| 645 | // Make sure it appears after all instructions we've inserted so far. |
| 646 | BO->moveBefore(IP); |
| 647 | return BO; |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 648 | } |
| 649 | |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 650 | Value *ConstantOffsetExtractor::Extract(Value *Idx, const DataLayout *DL, |
| 651 | GetElementPtrInst *GEP) { |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 652 | ConstantOffsetExtractor Extractor(DL, GEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 653 | // Find a non-zero constant offset first. |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 654 | APInt ConstantOffset = |
| 655 | Extractor.find(Idx, /* SignExtended */ false, /* ZeroExtended */ false, |
| 656 | GEP->isInBounds()); |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 657 | if (ConstantOffset == 0) |
| 658 | return nullptr; |
| 659 | // Separates the constant offset from the GEP index. |
| 660 | return Extractor.rebuildWithoutConstOffset(); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 661 | } |
| 662 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 663 | int64_t ConstantOffsetExtractor::Find(Value *Idx, const DataLayout *DL, |
| 664 | GetElementPtrInst *GEP) { |
| 665 | // If Idx is an index of an inbound GEP, Idx is guaranteed to be non-negative. |
| 666 | return ConstantOffsetExtractor(DL, GEP) |
| 667 | .find(Idx, /* SignExtended */ false, /* ZeroExtended */ false, |
| 668 | GEP->isInBounds()) |
| 669 | .getSExtValue(); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 670 | } |
| 671 | |
| 672 | void ConstantOffsetExtractor::ComputeKnownBits(Value *V, APInt &KnownOne, |
| 673 | APInt &KnownZero) const { |
| 674 | IntegerType *IT = cast<IntegerType>(V->getType()); |
| 675 | KnownOne = APInt(IT->getBitWidth(), 0); |
| 676 | KnownZero = APInt(IT->getBitWidth(), 0); |
Jay Foad | a0653a3 | 2014-05-14 21:14:37 +0000 | [diff] [blame] | 677 | llvm::computeKnownBits(V, KnownZero, KnownOne, DL, 0); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 678 | } |
| 679 | |
| 680 | bool ConstantOffsetExtractor::NoCommonBits(Value *LHS, Value *RHS) const { |
| 681 | assert(LHS->getType() == RHS->getType() && |
| 682 | "LHS and RHS should have the same type"); |
| 683 | APInt LHSKnownOne, LHSKnownZero, RHSKnownOne, RHSKnownZero; |
| 684 | ComputeKnownBits(LHS, LHSKnownOne, LHSKnownZero); |
| 685 | ComputeKnownBits(RHS, RHSKnownOne, RHSKnownZero); |
| 686 | return (LHSKnownZero | RHSKnownZero).isAllOnesValue(); |
| 687 | } |
| 688 | |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 689 | bool SeparateConstOffsetFromGEP::canonicalizeArrayIndicesToPointerSize( |
| 690 | GetElementPtrInst *GEP) { |
| 691 | bool Changed = false; |
| 692 | Type *IntPtrTy = DL->getIntPtrType(GEP->getType()); |
| 693 | gep_type_iterator GTI = gep_type_begin(*GEP); |
| 694 | for (User::op_iterator I = GEP->op_begin() + 1, E = GEP->op_end(); |
| 695 | I != E; ++I, ++GTI) { |
| 696 | // Skip struct member indices which must be i32. |
| 697 | if (isa<SequentialType>(*GTI)) { |
| 698 | if ((*I)->getType() != IntPtrTy) { |
| 699 | *I = CastInst::CreateIntegerCast(*I, IntPtrTy, true, "idxprom", GEP); |
| 700 | Changed = true; |
| 701 | } |
| 702 | } |
| 703 | } |
| 704 | return Changed; |
| 705 | } |
| 706 | |
| 707 | int64_t |
| 708 | SeparateConstOffsetFromGEP::accumulateByteOffset(GetElementPtrInst *GEP, |
| 709 | bool &NeedsExtraction) { |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 710 | NeedsExtraction = false; |
| 711 | int64_t AccumulativeByteOffset = 0; |
| 712 | gep_type_iterator GTI = gep_type_begin(*GEP); |
| 713 | for (unsigned I = 1, E = GEP->getNumOperands(); I != E; ++I, ++GTI) { |
| 714 | if (isa<SequentialType>(*GTI)) { |
| 715 | // Tries to extract a constant offset from this GEP index. |
| 716 | int64_t ConstantOffset = |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 717 | ConstantOffsetExtractor::Find(GEP->getOperand(I), DL, GEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 718 | if (ConstantOffset != 0) { |
| 719 | NeedsExtraction = true; |
| 720 | // A GEP may have multiple indices. We accumulate the extracted |
| 721 | // constant offset to a byte offset, and later offset the remainder of |
| 722 | // the original GEP with this byte offset. |
| 723 | AccumulativeByteOffset += |
| 724 | ConstantOffset * DL->getTypeAllocSize(GTI.getIndexedType()); |
| 725 | } |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 726 | } else if (LowerGEP) { |
| 727 | StructType *StTy = cast<StructType>(*GTI); |
| 728 | uint64_t Field = cast<ConstantInt>(GEP->getOperand(I))->getZExtValue(); |
| 729 | // Skip field 0 as the offset is always 0. |
| 730 | if (Field != 0) { |
| 731 | NeedsExtraction = true; |
| 732 | AccumulativeByteOffset += |
| 733 | DL->getStructLayout(StTy)->getElementOffset(Field); |
| 734 | } |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 735 | } |
| 736 | } |
| 737 | return AccumulativeByteOffset; |
| 738 | } |
| 739 | |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 740 | void SeparateConstOffsetFromGEP::lowerToSingleIndexGEPs( |
| 741 | GetElementPtrInst *Variadic, int64_t AccumulativeByteOffset) { |
| 742 | IRBuilder<> Builder(Variadic); |
| 743 | Type *IntPtrTy = DL->getIntPtrType(Variadic->getType()); |
| 744 | |
| 745 | Type *I8PtrTy = |
| 746 | Builder.getInt8PtrTy(Variadic->getType()->getPointerAddressSpace()); |
| 747 | Value *ResultPtr = Variadic->getOperand(0); |
| 748 | if (ResultPtr->getType() != I8PtrTy) |
| 749 | ResultPtr = Builder.CreateBitCast(ResultPtr, I8PtrTy); |
| 750 | |
| 751 | gep_type_iterator GTI = gep_type_begin(*Variadic); |
| 752 | // Create an ugly GEP for each sequential index. We don't create GEPs for |
| 753 | // structure indices, as they are accumulated in the constant offset index. |
| 754 | for (unsigned I = 1, E = Variadic->getNumOperands(); I != E; ++I, ++GTI) { |
| 755 | if (isa<SequentialType>(*GTI)) { |
| 756 | Value *Idx = Variadic->getOperand(I); |
| 757 | // Skip zero indices. |
| 758 | if (ConstantInt *CI = dyn_cast<ConstantInt>(Idx)) |
| 759 | if (CI->isZero()) |
| 760 | continue; |
| 761 | |
| 762 | APInt ElementSize = APInt(IntPtrTy->getIntegerBitWidth(), |
| 763 | DL->getTypeAllocSize(GTI.getIndexedType())); |
| 764 | // Scale the index by element size. |
| 765 | if (ElementSize != 1) { |
| 766 | if (ElementSize.isPowerOf2()) { |
| 767 | Idx = Builder.CreateShl( |
| 768 | Idx, ConstantInt::get(IntPtrTy, ElementSize.logBase2())); |
| 769 | } else { |
| 770 | Idx = Builder.CreateMul(Idx, ConstantInt::get(IntPtrTy, ElementSize)); |
| 771 | } |
| 772 | } |
| 773 | // Create an ugly GEP with a single index for each index. |
| 774 | ResultPtr = Builder.CreateGEP(ResultPtr, Idx, "uglygep"); |
| 775 | } |
| 776 | } |
| 777 | |
| 778 | // Create a GEP with the constant offset index. |
| 779 | if (AccumulativeByteOffset != 0) { |
| 780 | Value *Offset = ConstantInt::get(IntPtrTy, AccumulativeByteOffset); |
| 781 | ResultPtr = Builder.CreateGEP(ResultPtr, Offset, "uglygep"); |
| 782 | } |
| 783 | if (ResultPtr->getType() != Variadic->getType()) |
| 784 | ResultPtr = Builder.CreateBitCast(ResultPtr, Variadic->getType()); |
| 785 | |
| 786 | Variadic->replaceAllUsesWith(ResultPtr); |
| 787 | Variadic->eraseFromParent(); |
| 788 | } |
| 789 | |
| 790 | void |
| 791 | SeparateConstOffsetFromGEP::lowerToArithmetics(GetElementPtrInst *Variadic, |
| 792 | int64_t AccumulativeByteOffset) { |
| 793 | IRBuilder<> Builder(Variadic); |
| 794 | Type *IntPtrTy = DL->getIntPtrType(Variadic->getType()); |
| 795 | |
| 796 | Value *ResultPtr = Builder.CreatePtrToInt(Variadic->getOperand(0), IntPtrTy); |
| 797 | gep_type_iterator GTI = gep_type_begin(*Variadic); |
| 798 | // Create ADD/SHL/MUL arithmetic operations for each sequential indices. We |
| 799 | // don't create arithmetics for structure indices, as they are accumulated |
| 800 | // in the constant offset index. |
| 801 | for (unsigned I = 1, E = Variadic->getNumOperands(); I != E; ++I, ++GTI) { |
| 802 | if (isa<SequentialType>(*GTI)) { |
| 803 | Value *Idx = Variadic->getOperand(I); |
| 804 | // Skip zero indices. |
| 805 | if (ConstantInt *CI = dyn_cast<ConstantInt>(Idx)) |
| 806 | if (CI->isZero()) |
| 807 | continue; |
| 808 | |
| 809 | APInt ElementSize = APInt(IntPtrTy->getIntegerBitWidth(), |
| 810 | DL->getTypeAllocSize(GTI.getIndexedType())); |
| 811 | // Scale the index by element size. |
| 812 | if (ElementSize != 1) { |
| 813 | if (ElementSize.isPowerOf2()) { |
| 814 | Idx = Builder.CreateShl( |
| 815 | Idx, ConstantInt::get(IntPtrTy, ElementSize.logBase2())); |
| 816 | } else { |
| 817 | Idx = Builder.CreateMul(Idx, ConstantInt::get(IntPtrTy, ElementSize)); |
| 818 | } |
| 819 | } |
| 820 | // Create an ADD for each index. |
| 821 | ResultPtr = Builder.CreateAdd(ResultPtr, Idx); |
| 822 | } |
| 823 | } |
| 824 | |
| 825 | // Create an ADD for the constant offset index. |
| 826 | if (AccumulativeByteOffset != 0) { |
| 827 | ResultPtr = Builder.CreateAdd( |
| 828 | ResultPtr, ConstantInt::get(IntPtrTy, AccumulativeByteOffset)); |
| 829 | } |
| 830 | |
| 831 | ResultPtr = Builder.CreateIntToPtr(ResultPtr, Variadic->getType()); |
| 832 | Variadic->replaceAllUsesWith(ResultPtr); |
| 833 | Variadic->eraseFromParent(); |
| 834 | } |
| 835 | |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 836 | bool SeparateConstOffsetFromGEP::splitGEP(GetElementPtrInst *GEP) { |
| 837 | // Skip vector GEPs. |
| 838 | if (GEP->getType()->isVectorTy()) |
| 839 | return false; |
| 840 | |
| 841 | // The backend can already nicely handle the case where all indices are |
| 842 | // constant. |
| 843 | if (GEP->hasAllConstantIndices()) |
| 844 | return false; |
| 845 | |
Jingyue Wu | 0bdc027 | 2014-07-16 23:25:00 +0000 | [diff] [blame] | 846 | bool Changed = canonicalizeArrayIndicesToPointerSize(GEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 847 | |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 848 | bool NeedsExtraction; |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 849 | int64_t AccumulativeByteOffset = accumulateByteOffset(GEP, NeedsExtraction); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 850 | |
| 851 | if (!NeedsExtraction) |
| 852 | return Changed; |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 853 | // If LowerGEP is disabled, before really splitting the GEP, check whether the |
| 854 | // backend supports the addressing mode we are about to produce. If no, this |
| 855 | // splitting probably won't be beneficial. |
| 856 | // If LowerGEP is enabled, even the extracted constant offset can not match |
| 857 | // the addressing mode, we can still do optimizations to other lowered parts |
| 858 | // of variable indices. Therefore, we don't check for addressing modes in that |
| 859 | // case. |
| 860 | if (!LowerGEP) { |
Chandler Carruth | 705b185 | 2015-01-31 03:43:40 +0000 | [diff] [blame] | 861 | TargetTransformInfo &TTI = |
Chandler Carruth | fdb9c57 | 2015-02-01 12:01:35 +0000 | [diff] [blame^] | 862 | getAnalysis<TargetTransformInfoWrapperPass>().getTTI( |
| 863 | *GEP->getParent()->getParent()); |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 864 | if (!TTI.isLegalAddressingMode(GEP->getType()->getElementType(), |
| 865 | /*BaseGV=*/nullptr, AccumulativeByteOffset, |
| 866 | /*HasBaseReg=*/true, /*Scale=*/0)) { |
| 867 | return Changed; |
| 868 | } |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 869 | } |
| 870 | |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 871 | // Remove the constant offset in each sequential index. The resultant GEP |
| 872 | // computes the variadic base. |
| 873 | // Notice that we don't remove struct field indices here. If LowerGEP is |
| 874 | // disabled, a structure index is not accumulated and we still use the old |
| 875 | // one. If LowerGEP is enabled, a structure index is accumulated in the |
| 876 | // constant offset. LowerToSingleIndexGEPs or lowerToArithmetics will later |
| 877 | // handle the constant offset and won't need a new structure index. |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 878 | gep_type_iterator GTI = gep_type_begin(*GEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 879 | for (unsigned I = 1, E = GEP->getNumOperands(); I != E; ++I, ++GTI) { |
| 880 | if (isa<SequentialType>(*GTI)) { |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 881 | // Splits this GEP index into a variadic part and a constant offset, and |
| 882 | // uses the variadic part as the new index. |
| 883 | Value *NewIdx = |
| 884 | ConstantOffsetExtractor::Extract(GEP->getOperand(I), DL, GEP); |
| 885 | if (NewIdx != nullptr) { |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 886 | GEP->setOperand(I, NewIdx); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 887 | } |
| 888 | } |
| 889 | } |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 890 | |
Jingyue Wu | 8446547 | 2014-06-05 22:07:33 +0000 | [diff] [blame] | 891 | // Clear the inbounds attribute because the new index may be off-bound. |
| 892 | // e.g., |
| 893 | // |
| 894 | // b = add i64 a, 5 |
| 895 | // addr = gep inbounds float* p, i64 b |
| 896 | // |
| 897 | // is transformed to: |
| 898 | // |
| 899 | // addr2 = gep float* p, i64 a |
| 900 | // addr = gep float* addr2, i64 5 |
| 901 | // |
| 902 | // If a is -4, although the old index b is in bounds, the new index a is |
| 903 | // off-bound. http://llvm.org/docs/LangRef.html#id181 says "if the |
| 904 | // inbounds keyword is not present, the offsets are added to the base |
| 905 | // address with silently-wrapping two's complement arithmetic". |
| 906 | // Therefore, the final code will be a semantically equivalent. |
| 907 | // |
| 908 | // TODO(jingyue): do some range analysis to keep as many inbounds as |
| 909 | // possible. GEPs with inbounds are more friendly to alias analysis. |
| 910 | GEP->setIsInBounds(false); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 911 | |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 912 | // Lowers a GEP to either GEPs with a single index or arithmetic operations. |
| 913 | if (LowerGEP) { |
| 914 | // As currently BasicAA does not analyze ptrtoint/inttoptr, do not lower to |
| 915 | // arithmetic operations if the target uses alias analysis in codegen. |
Eric Christopher | e38c8d4 | 2015-01-27 07:16:37 +0000 | [diff] [blame] | 916 | if (TM && TM->getSubtargetImpl(*GEP->getParent()->getParent())->useAA()) |
Hao Liu | 1d2a061 | 2014-11-19 06:24:44 +0000 | [diff] [blame] | 917 | lowerToSingleIndexGEPs(GEP, AccumulativeByteOffset); |
| 918 | else |
| 919 | lowerToArithmetics(GEP, AccumulativeByteOffset); |
| 920 | return true; |
| 921 | } |
| 922 | |
| 923 | // No need to create another GEP if the accumulative byte offset is 0. |
| 924 | if (AccumulativeByteOffset == 0) |
| 925 | return true; |
| 926 | |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 927 | // Offsets the base with the accumulative byte offset. |
| 928 | // |
| 929 | // %gep ; the base |
| 930 | // ... %gep ... |
| 931 | // |
| 932 | // => add the offset |
| 933 | // |
| 934 | // %gep2 ; clone of %gep |
Jingyue Wu | bbb6e4a | 2014-05-23 18:39:40 +0000 | [diff] [blame] | 935 | // %new.gep = gep %gep2, <offset / sizeof(*%gep)> |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 936 | // %gep ; will be removed |
| 937 | // ... %gep ... |
| 938 | // |
| 939 | // => replace all uses of %gep with %new.gep and remove %gep |
| 940 | // |
| 941 | // %gep2 ; clone of %gep |
Jingyue Wu | bbb6e4a | 2014-05-23 18:39:40 +0000 | [diff] [blame] | 942 | // %new.gep = gep %gep2, <offset / sizeof(*%gep)> |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 943 | // ... %new.gep ... |
| 944 | // |
Jingyue Wu | bbb6e4a | 2014-05-23 18:39:40 +0000 | [diff] [blame] | 945 | // If AccumulativeByteOffset is not a multiple of sizeof(*%gep), we emit an |
| 946 | // uglygep (http://llvm.org/docs/GetElementPtr.html#what-s-an-uglygep): |
| 947 | // bitcast %gep2 to i8*, add the offset, and bitcast the result back to the |
| 948 | // type of %gep. |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 949 | // |
Jingyue Wu | bbb6e4a | 2014-05-23 18:39:40 +0000 | [diff] [blame] | 950 | // %gep2 ; clone of %gep |
| 951 | // %0 = bitcast %gep2 to i8* |
| 952 | // %uglygep = gep %0, <offset> |
| 953 | // %new.gep = bitcast %uglygep to <type of %gep> |
| 954 | // ... %new.gep ... |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 955 | Instruction *NewGEP = GEP->clone(); |
| 956 | NewGEP->insertBefore(GEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 957 | |
Jingyue Wu | fe72fce | 2014-10-25 18:34:03 +0000 | [diff] [blame] | 958 | // Per ANSI C standard, signed / unsigned = unsigned and signed % unsigned = |
| 959 | // unsigned.. Therefore, we cast ElementTypeSizeOfGEP to signed because it is |
| 960 | // used with unsigned integers later. |
| 961 | int64_t ElementTypeSizeOfGEP = static_cast<int64_t>( |
| 962 | DL->getTypeAllocSize(GEP->getType()->getElementType())); |
Jingyue Wu | 48a5abe | 2014-06-08 20:15:45 +0000 | [diff] [blame] | 963 | Type *IntPtrTy = DL->getIntPtrType(GEP->getType()); |
Jingyue Wu | bbb6e4a | 2014-05-23 18:39:40 +0000 | [diff] [blame] | 964 | if (AccumulativeByteOffset % ElementTypeSizeOfGEP == 0) { |
| 965 | // Very likely. As long as %gep is natually aligned, the byte offset we |
| 966 | // extracted should be a multiple of sizeof(*%gep). |
Jingyue Wu | fe72fce | 2014-10-25 18:34:03 +0000 | [diff] [blame] | 967 | int64_t Index = AccumulativeByteOffset / ElementTypeSizeOfGEP; |
Jingyue Wu | bbb6e4a | 2014-05-23 18:39:40 +0000 | [diff] [blame] | 968 | NewGEP = GetElementPtrInst::Create( |
| 969 | NewGEP, ConstantInt::get(IntPtrTy, Index, true), GEP->getName(), GEP); |
| 970 | } else { |
| 971 | // Unlikely but possible. For example, |
| 972 | // #pragma pack(1) |
| 973 | // struct S { |
| 974 | // int a[3]; |
| 975 | // int64 b[8]; |
| 976 | // }; |
| 977 | // #pragma pack() |
| 978 | // |
| 979 | // Suppose the gep before extraction is &s[i + 1].b[j + 3]. After |
| 980 | // extraction, it becomes &s[i].b[j] and AccumulativeByteOffset is |
| 981 | // sizeof(S) + 3 * sizeof(int64) = 100, which is not a multiple of |
| 982 | // sizeof(int64). |
| 983 | // |
| 984 | // Emit an uglygep in this case. |
| 985 | Type *I8PtrTy = Type::getInt8PtrTy(GEP->getContext(), |
| 986 | GEP->getPointerAddressSpace()); |
| 987 | NewGEP = new BitCastInst(NewGEP, I8PtrTy, "", GEP); |
| 988 | NewGEP = GetElementPtrInst::Create( |
| 989 | NewGEP, ConstantInt::get(IntPtrTy, AccumulativeByteOffset, true), |
| 990 | "uglygep", GEP); |
| 991 | if (GEP->getType() != I8PtrTy) |
| 992 | NewGEP = new BitCastInst(NewGEP, GEP->getType(), GEP->getName(), GEP); |
| 993 | } |
| 994 | |
| 995 | GEP->replaceAllUsesWith(NewGEP); |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 996 | GEP->eraseFromParent(); |
| 997 | |
| 998 | return true; |
| 999 | } |
| 1000 | |
| 1001 | bool SeparateConstOffsetFromGEP::runOnFunction(Function &F) { |
Jingyue Wu | 6c26bb6 | 2015-02-01 02:34:41 +0000 | [diff] [blame] | 1002 | if (skipOptnoneFunction(F)) |
| 1003 | return false; |
| 1004 | |
Eli Bendersky | a108a65 | 2014-05-01 18:38:36 +0000 | [diff] [blame] | 1005 | if (DisableSeparateConstOffsetFromGEP) |
| 1006 | return false; |
| 1007 | |
| 1008 | bool Changed = false; |
| 1009 | for (Function::iterator B = F.begin(), BE = F.end(); B != BE; ++B) { |
| 1010 | for (BasicBlock::iterator I = B->begin(), IE = B->end(); I != IE; ) { |
| 1011 | if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(I++)) { |
| 1012 | Changed |= splitGEP(GEP); |
| 1013 | } |
| 1014 | // No need to split GEP ConstantExprs because all its indices are constant |
| 1015 | // already. |
| 1016 | } |
| 1017 | } |
| 1018 | return Changed; |
| 1019 | } |