commit 0c34e40d7c9fffe07d742504163c00c7d303b680
author Mitja Nikolaus <mitja@fairphone.com> Fri Aug 31 11:17:43 2018 +0200
committer Mitja Nikolaus <mitja@fairphone.com> Thu Sep 13 07:22:32 2018 +0000
tree 11699fc1bfac08bb4817577b12092accfdc24fb4
parent b61247bc3ab1aa3ea248a463cf7af102edd152f0

Remove FIXME and TODO comments

Jira issues have been created for each FIXME and TODO comment:

crashreport_stats/management/commands/stats.py
260: Agressively drop duplicates (HIC-180)

crashreport_stats/tests.py
561: Test for false duplicates: same timestamps but different UUIDs (HIC-181)
562:
    Test that the 'released_on' field changes or not once an older
    report has been sent depending on whether the field has been manually
    changed (HIC-182)
565: Test that tests the daily version stats (HIC-183)
566: Test creating stats from reports of different devices/users (HIC-184)

crashreports/models.py
137: Remove logfile_type or make it meaningful (HIC-179)

crashreports/rest_api_heartbeats.py
15:
    There is quite some code duplciation between here and the corresponding
    crashreport code. We should revisit this later. (HIC-178)

Issue: HIC-170
Change-Id: I9c81e34df22ff3d794f209cadbc4be81bdfd6a7d

crashreport_stats/management/commands/stats.py

diff --git a/crashreport_stats/management/commands/stats.py b/crashreport_stats/management/commands/stats.py
index 35133c5..d510a0e 100644
--- a/crashreport_stats/management/commands/stats.py
+++ b/crashreport_stats/management/commands/stats.py
@@ -254,10 +254,8 @@
 
         """
         return (
-            query_objects.annotate(_report_day=TruncDate("date")).values(
-                self.version_field_name, "_report_day"
-            )
-            # FIXME Agressively drop duplicates
+            query_objects.annotate(_report_day=TruncDate("date"))
+            .values(self.version_field_name, "_report_day")
             .annotate(count=Count("date", distinct=True))
         )
 

crashreport_stats/tests.py

diff --git a/crashreport_stats/tests.py b/crashreport_stats/tests.py
index 31cbe6b..0fd9fc9 100644
--- a/crashreport_stats/tests.py
+++ b/crashreport_stats/tests.py
@@ -558,13 +558,6 @@
 class StatsCommandVersionsTestCase(TestCase):
     """Test the generation of Version stats with the stats command."""
 
-    # FIXME: Test for false duplicates: same timestamps but different UUIDs
-    # FIXME: Test that the 'released_on' field changes or not once an older
-    #   report has been sent depending on whether the field has been manually
-    #   changed
-    # FIXME: Test that tests the daily version stats
-    # FIXME: Test creating stats from reports of different devices/users.
-
     # The class of the version type to be tested
     version_class = Version
     # The attribute name characterising the unicity of a stats entry (the

crashreports/models.py

diff --git a/crashreports/models.py b/crashreports/models.py
index ccdbc5b..7e33865 100644
--- a/crashreports/models.py
+++ b/crashreports/models.py
@@ -126,7 +126,6 @@
     uuid = property(_get_uuid)
 
 
-# TODO remove logfile_type or make it meaningful
 class LogFile(models.Model):
     """A log file that was sent along with a crashreport."""
 

crashreports/rest_api_heartbeats.py

diff --git a/crashreports/rest_api_heartbeats.py b/crashreports/rest_api_heartbeats.py
index e2e266e..adc15e4 100644
--- a/crashreports/rest_api_heartbeats.py
+++ b/crashreports/rest_api_heartbeats.py
@@ -12,9 +12,6 @@
 from crashreports.response_descriptions import default_desc
 from crashreports.serializers import HeartBeatSerializer
 
-# TODO: There is quite some code duplciation between here and the corresponding
-#       crashreport code. We should revisit this later.
-
 
 @method_decorator(
     name="get",