Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1 | //=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines malloc/free checker, which checks for potential memory |
| 11 | // leaks, double free, and use-after-free problems. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Anna Zaks | f0dfc9c | 2012-02-17 22:35:31 +0000 | [diff] [blame] | 16 | #include "InterCheckerAPI.h" |
Chandler Carruth | 55fc873 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 17 | #include "clang/AST/Attr.h" |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 18 | #include "clang/AST/ParentMap.h" |
Chandler Carruth | 55fc873 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 19 | #include "clang/Basic/SourceManager.h" |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 20 | #include "clang/Basic/TargetInfo.h" |
Chandler Carruth | 55fc873 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 21 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 23 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
Jordan Rose | f540c54 | 2012-07-26 21:39:41 +0000 | [diff] [blame] | 24 | #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" |
Chandler Carruth | 55fc873 | 2012-12-04 09:13:33 +0000 | [diff] [blame] | 25 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 26 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" |
| 27 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 28 | #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 29 | #include "llvm/ADT/ImmutableMap.h" |
Benjamin Kramer | 00bd44d | 2012-02-04 12:31:12 +0000 | [diff] [blame] | 30 | #include "llvm/ADT/STLExtras.h" |
Benjamin Kramer | 2fa67ef | 2012-12-01 15:09:41 +0000 | [diff] [blame] | 31 | #include "llvm/ADT/SmallString.h" |
Jordan Rose | 615a092 | 2012-09-22 01:24:42 +0000 | [diff] [blame] | 32 | #include "llvm/ADT/StringExtras.h" |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 33 | #include <climits> |
| 34 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 35 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 36 | using namespace ento; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 37 | |
| 38 | namespace { |
| 39 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 40 | // Used to check correspondence between allocators and deallocators. |
| 41 | enum AllocationFamily { |
| 42 | AF_None, |
| 43 | AF_Malloc, |
| 44 | AF_CXXNew, |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 45 | AF_CXXNewArray, |
| 46 | AF_IfNameIndex |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 47 | }; |
| 48 | |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 49 | class RefState { |
Anna Zaks | 050cdd7 | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 50 | enum Kind { // Reference to allocated memory. |
| 51 | Allocated, |
| 52 | // Reference to released/freed memory. |
| 53 | Released, |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 54 | // The responsibility for freeing resources has transferred from |
Anna Zaks | 050cdd7 | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 55 | // this reference. A relinquished symbol should not be freed. |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 56 | Relinquished, |
| 57 | // We are no longer guaranteed to have observed all manipulations |
| 58 | // of this pointer/memory. For example, it could have been |
| 59 | // passed as a parameter to an opaque function. |
| 60 | Escaped |
| 61 | }; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 62 | |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 63 | const Stmt *S; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 64 | unsigned K : 2; // Kind enum, but stored as a bitfield. |
| 65 | unsigned Family : 30; // Rest of 32-bit word, currently just an allocation |
| 66 | // family. |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 67 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 68 | RefState(Kind k, const Stmt *s, unsigned family) |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 69 | : S(s), K(k), Family(family) { |
| 70 | assert(family != AF_None); |
| 71 | } |
Zhongxing Xu | 7fb1464 | 2009-12-11 00:55:44 +0000 | [diff] [blame] | 72 | public: |
Anna Zaks | 050cdd7 | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 73 | bool isAllocated() const { return K == Allocated; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 74 | bool isReleased() const { return K == Released; } |
Anna Zaks | 050cdd7 | 2012-06-20 20:57:46 +0000 | [diff] [blame] | 75 | bool isRelinquished() const { return K == Relinquished; } |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 76 | bool isEscaped() const { return K == Escaped; } |
| 77 | AllocationFamily getAllocationFamily() const { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 78 | return (AllocationFamily)Family; |
| 79 | } |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 80 | const Stmt *getStmt() const { return S; } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 81 | |
| 82 | bool operator==(const RefState &X) const { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 83 | return K == X.K && S == X.S && Family == X.Family; |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 84 | } |
| 85 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 86 | static RefState getAllocated(unsigned family, const Stmt *s) { |
| 87 | return RefState(Allocated, s, family); |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 88 | } |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 89 | static RefState getReleased(unsigned family, const Stmt *s) { |
| 90 | return RefState(Released, s, family); |
| 91 | } |
| 92 | static RefState getRelinquished(unsigned family, const Stmt *s) { |
| 93 | return RefState(Relinquished, s, family); |
Ted Kremenek | dde201b | 2010-08-06 21:12:55 +0000 | [diff] [blame] | 94 | } |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 95 | static RefState getEscaped(const RefState *RS) { |
| 96 | return RefState(Escaped, RS->getStmt(), RS->getAllocationFamily()); |
| 97 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 98 | |
| 99 | void Profile(llvm::FoldingSetNodeID &ID) const { |
| 100 | ID.AddInteger(K); |
| 101 | ID.AddPointer(S); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 102 | ID.AddInteger(Family); |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 103 | } |
Ted Kremenek | c37fad6 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 104 | |
Dmitri Gribenko | cfa88f8 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 105 | void dump(raw_ostream &OS) const { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 106 | switch (static_cast<Kind>(K)) { |
| 107 | #define CASE(ID) case ID: OS << #ID; break; |
| 108 | CASE(Allocated) |
| 109 | CASE(Released) |
| 110 | CASE(Relinquished) |
| 111 | CASE(Escaped) |
| 112 | } |
Ted Kremenek | c37fad6 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 113 | } |
| 114 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 115 | LLVM_DUMP_METHOD void dump() const { dump(llvm::errs()); } |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 116 | }; |
| 117 | |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 118 | enum ReallocPairKind { |
| 119 | RPToBeFreedAfterFailure, |
| 120 | // The symbol has been freed when reallocation failed. |
| 121 | RPIsFreeOnFailure, |
| 122 | // The symbol does not need to be freed after reallocation fails. |
| 123 | RPDoNotTrackAfterFailure |
| 124 | }; |
| 125 | |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 126 | /// \class ReallocPair |
| 127 | /// \brief Stores information about the symbol being reallocated by a call to |
| 128 | /// 'realloc' to allow modeling failed reallocation later in the path. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 129 | struct ReallocPair { |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 130 | // \brief The symbol which realloc reallocated. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 131 | SymbolRef ReallocatedSym; |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 132 | ReallocPairKind Kind; |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 133 | |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 134 | ReallocPair(SymbolRef S, ReallocPairKind K) : |
| 135 | ReallocatedSym(S), Kind(K) {} |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 136 | void Profile(llvm::FoldingSetNodeID &ID) const { |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 137 | ID.AddInteger(Kind); |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 138 | ID.AddPointer(ReallocatedSym); |
| 139 | } |
| 140 | bool operator==(const ReallocPair &X) const { |
| 141 | return ReallocatedSym == X.ReallocatedSym && |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 142 | Kind == X.Kind; |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 143 | } |
| 144 | }; |
| 145 | |
Anna Zaks | 97bfb55 | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 146 | typedef std::pair<const ExplodedNode*, const MemRegion*> LeakInfo; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 147 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 148 | class MallocChecker : public Checker<check::DeadSymbols, |
Anna Zaks | bf53dfa | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 149 | check::PointerEscape, |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 150 | check::ConstPointerEscape, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 151 | check::PreStmt<ReturnStmt>, |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 152 | check::PreCall, |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 153 | check::PostStmt<CallExpr>, |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 154 | check::PostStmt<CXXNewExpr>, |
| 155 | check::PreStmt<CXXDeleteExpr>, |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 156 | check::PostStmt<BlockExpr>, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 157 | check::PostObjCMessage, |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 158 | check::Location, |
Anna Zaks | bf53dfa | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 159 | eval::Assume> |
Ted Kremenek | e3659a7 | 2012-01-04 23:48:37 +0000 | [diff] [blame] | 160 | { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 161 | public: |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 162 | MallocChecker() |
| 163 | : II_malloc(nullptr), II_free(nullptr), II_realloc(nullptr), |
| 164 | II_calloc(nullptr), II_valloc(nullptr), II_reallocf(nullptr), |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 165 | II_strndup(nullptr), II_strdup(nullptr), II_kmalloc(nullptr), |
| 166 | II_if_nameindex(nullptr), II_if_freenameindex(nullptr) {} |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 167 | |
| 168 | /// In pessimistic mode, the checker assumes that it does not know which |
| 169 | /// functions might free the memory. |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 170 | enum CheckKind { |
| 171 | CK_MallocPessimistic, |
| 172 | CK_MallocOptimistic, |
| 173 | CK_NewDeleteChecker, |
| 174 | CK_NewDeleteLeaksChecker, |
| 175 | CK_MismatchedDeallocatorChecker, |
| 176 | CK_NumCheckKinds |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 177 | }; |
| 178 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 179 | enum class MemoryOperationKind { |
| 180 | MOK_Allocate, |
| 181 | MOK_Free, |
| 182 | MOK_Any |
| 183 | }; |
| 184 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 185 | DefaultBool ChecksEnabled[CK_NumCheckKinds]; |
| 186 | CheckName CheckNames[CK_NumCheckKinds]; |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 187 | |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 188 | void checkPreCall(const CallEvent &Call, CheckerContext &C) const; |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 189 | void checkPostStmt(const CallExpr *CE, CheckerContext &C) const; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 190 | void checkPostStmt(const CXXNewExpr *NE, CheckerContext &C) const; |
| 191 | void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const; |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 192 | void checkPostObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const; |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 193 | void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 194 | void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const; |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 195 | void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 196 | ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 197 | bool Assumption) const; |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 198 | void checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 199 | CheckerContext &C) const; |
Anna Zaks | bf53dfa | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 200 | |
| 201 | ProgramStateRef checkPointerEscape(ProgramStateRef State, |
| 202 | const InvalidatedSymbols &Escaped, |
Anna Zaks | 233e26a | 2013-02-07 23:05:43 +0000 | [diff] [blame] | 203 | const CallEvent *Call, |
| 204 | PointerEscapeKind Kind) const; |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 205 | ProgramStateRef checkConstPointerEscape(ProgramStateRef State, |
| 206 | const InvalidatedSymbols &Escaped, |
| 207 | const CallEvent *Call, |
| 208 | PointerEscapeKind Kind) const; |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 209 | |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 210 | void printState(raw_ostream &Out, ProgramStateRef State, |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 211 | const char *NL, const char *Sep) const override; |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 212 | |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 213 | private: |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 214 | mutable std::unique_ptr<BugType> BT_DoubleFree[CK_NumCheckKinds]; |
| 215 | mutable std::unique_ptr<BugType> BT_DoubleDelete; |
| 216 | mutable std::unique_ptr<BugType> BT_Leak[CK_NumCheckKinds]; |
| 217 | mutable std::unique_ptr<BugType> BT_UseFree[CK_NumCheckKinds]; |
| 218 | mutable std::unique_ptr<BugType> BT_BadFree[CK_NumCheckKinds]; |
| 219 | mutable std::unique_ptr<BugType> BT_MismatchedDealloc; |
| 220 | mutable std::unique_ptr<BugType> BT_OffsetFree[CK_NumCheckKinds]; |
| 221 | mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc, |
| 222 | *II_valloc, *II_reallocf, *II_strndup, *II_strdup, |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 223 | *II_kmalloc, *II_if_nameindex, *II_if_freenameindex; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 224 | mutable Optional<uint64_t> KernelZeroFlagVal; |
| 225 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 226 | void initIdentifierInfo(ASTContext &C) const; |
| 227 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 228 | /// \brief Determine family of a deallocation expression. |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 229 | AllocationFamily getAllocationFamily(CheckerContext &C, const Stmt *S) const; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 230 | |
| 231 | /// \brief Print names of allocators and deallocators. |
| 232 | /// |
| 233 | /// \returns true on success. |
| 234 | bool printAllocDeallocName(raw_ostream &os, CheckerContext &C, |
| 235 | const Expr *E) const; |
| 236 | |
| 237 | /// \brief Print expected name of an allocator based on the deallocator's |
| 238 | /// family derived from the DeallocExpr. |
| 239 | void printExpectedAllocName(raw_ostream &os, CheckerContext &C, |
| 240 | const Expr *DeallocExpr) const; |
| 241 | /// \brief Print expected name of a deallocator based on the allocator's |
| 242 | /// family. |
| 243 | void printExpectedDeallocName(raw_ostream &os, AllocationFamily Family) const; |
| 244 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 245 | ///@{ |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 246 | /// Check if this is one of the functions which can allocate/reallocate memory |
| 247 | /// pointed to by one of its arguments. |
| 248 | bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const; |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 249 | bool isCMemFunction(const FunctionDecl *FD, |
| 250 | ASTContext &C, |
| 251 | AllocationFamily Family, |
| 252 | MemoryOperationKind MemKind) const; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 253 | bool isStandardNewDelete(const FunctionDecl *FD, ASTContext &C) const; |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 254 | ///@} |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 255 | ProgramStateRef MallocMemReturnsAttr(CheckerContext &C, |
| 256 | const CallExpr *CE, |
| 257 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 258 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 259 | const Expr *SizeEx, SVal Init, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 260 | ProgramStateRef State, |
| 261 | AllocationFamily Family = AF_Malloc) { |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 262 | return MallocMemAux(C, CE, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 263 | State->getSVal(SizeEx, C.getLocationContext()), |
| 264 | Init, State, Family); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 265 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 266 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 267 | static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE, |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 268 | SVal SizeEx, SVal Init, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 269 | ProgramStateRef State, |
| 270 | AllocationFamily Family = AF_Malloc); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 271 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 272 | // Check if this malloc() for special flags. At present that means M_ZERO or |
| 273 | // __GFP_ZERO (in which case, treat it like calloc). |
| 274 | llvm::Optional<ProgramStateRef> |
| 275 | performKernelMalloc(const CallExpr *CE, CheckerContext &C, |
| 276 | const ProgramStateRef &State) const; |
| 277 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 278 | /// Update the RefState to reflect the new memory allocation. |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 279 | static ProgramStateRef |
| 280 | MallocUpdateRefState(CheckerContext &C, const Expr *E, ProgramStateRef State, |
| 281 | AllocationFamily Family = AF_Malloc); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 282 | |
| 283 | ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE, |
| 284 | const OwnershipAttr* Att) const; |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 285 | ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE, |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 286 | ProgramStateRef state, unsigned Num, |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 287 | bool Hold, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 288 | bool &ReleasedAllocated, |
| 289 | bool ReturnsNullOnFailure = false) const; |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 290 | ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg, |
| 291 | const Expr *ParentExpr, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 292 | ProgramStateRef State, |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 293 | bool Hold, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 294 | bool &ReleasedAllocated, |
| 295 | bool ReturnsNullOnFailure = false) const; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 296 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 297 | ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE, |
| 298 | bool FreesMemOnFailure) const; |
| 299 | static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 300 | |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 301 | ///\brief Check if the memory associated with this symbol was released. |
| 302 | bool isReleased(SymbolRef Sym, CheckerContext &C) const; |
| 303 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 304 | bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, const Stmt *S) const; |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 305 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 306 | bool checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const; |
| 307 | |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 308 | /// Check if the function is known free memory, or if it is |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 309 | /// "interesting" and should be modeled explicitly. |
| 310 | /// |
Anna Zaks | 3370859 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 311 | /// \param [out] EscapingSymbol A function might not free memory in general, |
| 312 | /// but could be known to free a particular symbol. In this case, false is |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 313 | /// returned and the single escaping symbol is returned through the out |
| 314 | /// parameter. |
| 315 | /// |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 316 | /// We assume that pointers do not escape through calls to system functions |
| 317 | /// not handled by this checker. |
Anna Zaks | 3370859 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 318 | bool mayFreeAnyEscapedMemoryOrIsModeledExplicitly(const CallEvent *Call, |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 319 | ProgramStateRef State, |
| 320 | SymbolRef &EscapingSymbol) const; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 321 | |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 322 | // Implementation of the checkPointerEscape callabcks. |
| 323 | ProgramStateRef checkPointerEscapeAux(ProgramStateRef State, |
| 324 | const InvalidatedSymbols &Escaped, |
| 325 | const CallEvent *Call, |
| 326 | PointerEscapeKind Kind, |
| 327 | bool(*CheckRefState)(const RefState*)) const; |
| 328 | |
Anton Yartsev | 9ae7a92 | 2013-04-11 00:05:20 +0000 | [diff] [blame] | 329 | ///@{ |
| 330 | /// Tells if a given family/call/symbol is tracked by the current checker. |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 331 | /// Sets CheckKind to the kind of the checker responsible for this |
| 332 | /// family/call/symbol. |
| 333 | Optional<CheckKind> getCheckIfTracked(AllocationFamily Family) const; |
| 334 | Optional<CheckKind> getCheckIfTracked(CheckerContext &C, |
| 335 | const Stmt *AllocDeallocStmt) const; |
| 336 | Optional<CheckKind> getCheckIfTracked(CheckerContext &C, SymbolRef Sym) const; |
Anton Yartsev | 9ae7a92 | 2013-04-11 00:05:20 +0000 | [diff] [blame] | 337 | ///@} |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 338 | static bool SummarizeValue(raw_ostream &os, SVal V); |
| 339 | static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 340 | void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange Range, |
| 341 | const Expr *DeallocExpr) const; |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 342 | void ReportMismatchedDealloc(CheckerContext &C, SourceRange Range, |
Anton Yartsev | a3ae937 | 2013-04-05 11:25:10 +0000 | [diff] [blame] | 343 | const Expr *DeallocExpr, const RefState *RS, |
Anton Yartsev | 3084518 | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 344 | SymbolRef Sym, bool OwnershipTransferred) const; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 345 | void ReportOffsetFree(CheckerContext &C, SVal ArgVal, SourceRange Range, |
| 346 | const Expr *DeallocExpr, |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 347 | const Expr *AllocExpr = nullptr) const; |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 348 | void ReportUseAfterFree(CheckerContext &C, SourceRange Range, |
| 349 | SymbolRef Sym) const; |
| 350 | void ReportDoubleFree(CheckerContext &C, SourceRange Range, bool Released, |
Anton Yartsev | 3258d4b | 2013-03-13 17:07:32 +0000 | [diff] [blame] | 351 | SymbolRef Sym, SymbolRef PrevSym) const; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 352 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 353 | void ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const; |
| 354 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 355 | /// Find the location of the allocation for Sym on the path leading to the |
| 356 | /// exploded node N. |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 357 | LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 358 | CheckerContext &C) const; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 359 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 360 | void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const; |
| 361 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 362 | /// The bug visitor which allows us to print extra diagnostics along the |
| 363 | /// BugReport path. For example, showing the allocation site of the leaked |
| 364 | /// region. |
Jordy Rose | 0115349 | 2012-03-24 02:45:35 +0000 | [diff] [blame] | 365 | class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 366 | protected: |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 367 | enum NotificationMode { |
| 368 | Normal, |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 369 | ReallocationFailed |
| 370 | }; |
| 371 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 372 | // The allocated region symbol tracked by the main analysis. |
| 373 | SymbolRef Sym; |
| 374 | |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 375 | // The mode we are in, i.e. what kind of diagnostics will be emitted. |
| 376 | NotificationMode Mode; |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 377 | |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 378 | // A symbol from when the primary region should have been reallocated. |
| 379 | SymbolRef FailedReallocSymbol; |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 380 | |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 381 | bool IsLeak; |
| 382 | |
| 383 | public: |
| 384 | MallocBugVisitor(SymbolRef S, bool isLeak = false) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 385 | : Sym(S), Mode(Normal), FailedReallocSymbol(nullptr), IsLeak(isLeak) {} |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 386 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 387 | virtual ~MallocBugVisitor() {} |
| 388 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 389 | void Profile(llvm::FoldingSetNodeID &ID) const override { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 390 | static int X = 0; |
| 391 | ID.AddPointer(&X); |
| 392 | ID.AddPointer(Sym); |
| 393 | } |
| 394 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 395 | inline bool isAllocated(const RefState *S, const RefState *SPrev, |
| 396 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 397 | // Did not track -> allocated. Other state (released) -> allocated. |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 398 | return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXNewExpr>(Stmt)) && |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 399 | (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 400 | } |
| 401 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 402 | inline bool isReleased(const RefState *S, const RefState *SPrev, |
| 403 | const Stmt *Stmt) { |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 404 | // Did not track -> released. Other state (allocated) -> released. |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 405 | return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXDeleteExpr>(Stmt)) && |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 406 | (S && S->isReleased()) && (!SPrev || !SPrev->isReleased())); |
| 407 | } |
| 408 | |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 409 | inline bool isRelinquished(const RefState *S, const RefState *SPrev, |
| 410 | const Stmt *Stmt) { |
| 411 | // Did not track -> relinquished. Other state (allocated) -> relinquished. |
| 412 | return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) || |
| 413 | isa<ObjCPropertyRefExpr>(Stmt)) && |
| 414 | (S && S->isRelinquished()) && |
| 415 | (!SPrev || !SPrev->isRelinquished())); |
| 416 | } |
| 417 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 418 | inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev, |
| 419 | const Stmt *Stmt) { |
| 420 | // If the expression is not a call, and the state change is |
| 421 | // released -> allocated, it must be the realloc return value |
| 422 | // check. If we have to handle more cases here, it might be cleaner just |
| 423 | // to track this extra bit in the state itself. |
| 424 | return ((!Stmt || !isa<CallExpr>(Stmt)) && |
| 425 | (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated())); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 426 | } |
| 427 | |
| 428 | PathDiagnosticPiece *VisitNode(const ExplodedNode *N, |
| 429 | const ExplodedNode *PrevN, |
| 430 | BugReporterContext &BRC, |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 431 | BugReport &BR) override; |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 432 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 433 | std::unique_ptr<PathDiagnosticPiece> |
| 434 | getEndPath(BugReporterContext &BRC, const ExplodedNode *EndPathNode, |
| 435 | BugReport &BR) override { |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 436 | if (!IsLeak) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 437 | return nullptr; |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 438 | |
| 439 | PathDiagnosticLocation L = |
| 440 | PathDiagnosticLocation::createEndOfPath(EndPathNode, |
| 441 | BRC.getSourceManager()); |
| 442 | // Do not add the statement itself as a range in case of leak. |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 443 | return llvm::make_unique<PathDiagnosticEventPiece>(L, BR.getDescription(), |
| 444 | false); |
Anna Zaks | 88feba0 | 2012-05-10 01:37:40 +0000 | [diff] [blame] | 445 | } |
| 446 | |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 447 | private: |
| 448 | class StackHintGeneratorForReallocationFailed |
| 449 | : public StackHintGeneratorForSymbol { |
| 450 | public: |
| 451 | StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M) |
| 452 | : StackHintGeneratorForSymbol(S, M) {} |
| 453 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 454 | std::string getMessageForArg(const Expr *ArgE, |
| 455 | unsigned ArgIndex) override { |
Jordan Rose | 615a092 | 2012-09-22 01:24:42 +0000 | [diff] [blame] | 456 | // Printed parameters start at 1, not 0. |
| 457 | ++ArgIndex; |
| 458 | |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 459 | SmallString<200> buf; |
| 460 | llvm::raw_svector_ostream os(buf); |
| 461 | |
Jordan Rose | 615a092 | 2012-09-22 01:24:42 +0000 | [diff] [blame] | 462 | os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex) |
| 463 | << " parameter failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 464 | |
| 465 | return os.str(); |
| 466 | } |
| 467 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 468 | std::string getMessageForReturn(const CallExpr *CallExpr) override { |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 469 | return "Reallocation of returned value failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 470 | } |
| 471 | }; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 472 | }; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 473 | }; |
Kovarththanan Rajaratnam | ba5fb5a | 2009-11-28 06:07:30 +0000 | [diff] [blame] | 474 | } // end anonymous namespace |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 475 | |
Jordan Rose | 166d502 | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 476 | REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState) |
| 477 | REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 478 | |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 479 | // A map from the freed symbol to the symbol representing the return value of |
| 480 | // the free function. |
| 481 | REGISTER_MAP_WITH_PROGRAMSTATE(FreeReturnValue, SymbolRef, SymbolRef) |
| 482 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 483 | namespace { |
| 484 | class StopTrackingCallback : public SymbolVisitor { |
| 485 | ProgramStateRef state; |
| 486 | public: |
| 487 | StopTrackingCallback(ProgramStateRef st) : state(st) {} |
| 488 | ProgramStateRef getState() const { return state; } |
| 489 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 490 | bool VisitSymbol(SymbolRef sym) override { |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 491 | state = state->remove<RegionState>(sym); |
| 492 | return true; |
| 493 | } |
| 494 | }; |
| 495 | } // end anonymous namespace |
| 496 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 497 | void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const { |
Anna Zaks | a38cb2c | 2012-05-18 22:47:40 +0000 | [diff] [blame] | 498 | if (II_malloc) |
| 499 | return; |
| 500 | II_malloc = &Ctx.Idents.get("malloc"); |
| 501 | II_free = &Ctx.Idents.get("free"); |
| 502 | II_realloc = &Ctx.Idents.get("realloc"); |
| 503 | II_reallocf = &Ctx.Idents.get("reallocf"); |
| 504 | II_calloc = &Ctx.Idents.get("calloc"); |
| 505 | II_valloc = &Ctx.Idents.get("valloc"); |
| 506 | II_strdup = &Ctx.Idents.get("strdup"); |
| 507 | II_strndup = &Ctx.Idents.get("strndup"); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 508 | II_kmalloc = &Ctx.Idents.get("kmalloc"); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 509 | II_if_nameindex = &Ctx.Idents.get("if_nameindex"); |
| 510 | II_if_freenameindex = &Ctx.Idents.get("if_freenameindex"); |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 511 | } |
| 512 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 513 | bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const { |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 514 | if (isCMemFunction(FD, C, AF_Malloc, MemoryOperationKind::MOK_Any)) |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 515 | return true; |
| 516 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 517 | if (isCMemFunction(FD, C, AF_IfNameIndex, MemoryOperationKind::MOK_Any)) |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 518 | return true; |
| 519 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 520 | if (isStandardNewDelete(FD, C)) |
| 521 | return true; |
| 522 | |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 523 | return false; |
| 524 | } |
| 525 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 526 | bool MallocChecker::isCMemFunction(const FunctionDecl *FD, |
| 527 | ASTContext &C, |
| 528 | AllocationFamily Family, |
| 529 | MemoryOperationKind MemKind) const { |
Anna Zaks | 1d6cc6a | 2012-02-15 02:12:00 +0000 | [diff] [blame] | 530 | if (!FD) |
| 531 | return false; |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 532 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 533 | bool CheckFree = (MemKind == MemoryOperationKind::MOK_Any || |
| 534 | MemKind == MemoryOperationKind::MOK_Free); |
| 535 | bool CheckAlloc = (MemKind == MemoryOperationKind::MOK_Any || |
| 536 | MemKind == MemoryOperationKind::MOK_Allocate); |
| 537 | |
Jordan Rose | 5ef6e94 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 538 | if (FD->getKind() == Decl::Function) { |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 539 | const IdentifierInfo *FunI = FD->getIdentifier(); |
Jordan Rose | 5ef6e94 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 540 | initIdentifierInfo(C); |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 541 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 542 | if (Family == AF_Malloc && CheckFree) { |
| 543 | if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf) |
| 544 | return true; |
| 545 | } |
| 546 | |
| 547 | if (Family == AF_Malloc && CheckAlloc) { |
| 548 | if (FunI == II_malloc || FunI == II_realloc || FunI == II_reallocf || |
| 549 | FunI == II_calloc || FunI == II_valloc || FunI == II_strdup || |
| 550 | FunI == II_strndup || FunI == II_kmalloc) |
| 551 | return true; |
| 552 | } |
| 553 | |
| 554 | if (Family == AF_IfNameIndex && CheckFree) { |
| 555 | if (FunI == II_if_freenameindex) |
| 556 | return true; |
| 557 | } |
| 558 | |
| 559 | if (Family == AF_IfNameIndex && CheckAlloc) { |
| 560 | if (FunI == II_if_nameindex) |
| 561 | return true; |
| 562 | } |
Jordan Rose | 5ef6e94 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 563 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 564 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 565 | if (Family != AF_Malloc) |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 566 | return false; |
| 567 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 568 | if (ChecksEnabled[CK_MallocOptimistic] && FD->hasAttrs()) { |
| 569 | for (const auto *I : FD->specific_attrs<OwnershipAttr>()) { |
| 570 | OwnershipAttr::OwnershipKind OwnKind = I->getOwnKind(); |
| 571 | if(OwnKind == OwnershipAttr::Takes || OwnKind == OwnershipAttr::Holds) { |
| 572 | if (CheckFree) |
| 573 | return true; |
| 574 | } else if (OwnKind == OwnershipAttr::Returns) { |
| 575 | if (CheckAlloc) |
| 576 | return true; |
| 577 | } |
| 578 | } |
Jordan Rose | 5ef6e94 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 579 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 580 | |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 581 | return false; |
| 582 | } |
| 583 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 584 | // Tells if the callee is one of the following: |
| 585 | // 1) A global non-placement new/delete operator function. |
| 586 | // 2) A global placement operator function with the single placement argument |
| 587 | // of type std::nothrow_t. |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 588 | bool MallocChecker::isStandardNewDelete(const FunctionDecl *FD, |
| 589 | ASTContext &C) const { |
| 590 | if (!FD) |
| 591 | return false; |
| 592 | |
| 593 | OverloadedOperatorKind Kind = FD->getOverloadedOperator(); |
| 594 | if (Kind != OO_New && Kind != OO_Array_New && |
| 595 | Kind != OO_Delete && Kind != OO_Array_Delete) |
| 596 | return false; |
| 597 | |
Anton Yartsev | 6974628 | 2013-03-28 16:10:38 +0000 | [diff] [blame] | 598 | // Skip all operator new/delete methods. |
| 599 | if (isa<CXXMethodDecl>(FD)) |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 600 | return false; |
| 601 | |
| 602 | // Return true if tested operator is a standard placement nothrow operator. |
| 603 | if (FD->getNumParams() == 2) { |
| 604 | QualType T = FD->getParamDecl(1)->getType(); |
| 605 | if (const IdentifierInfo *II = T.getBaseTypeIdentifier()) |
| 606 | return II->getName().equals("nothrow_t"); |
| 607 | } |
| 608 | |
| 609 | // Skip placement operators. |
| 610 | if (FD->getNumParams() != 1 || FD->isVariadic()) |
| 611 | return false; |
| 612 | |
| 613 | // One of the standard new/new[]/delete/delete[] non-placement operators. |
| 614 | return true; |
| 615 | } |
| 616 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 617 | llvm::Optional<ProgramStateRef> MallocChecker::performKernelMalloc( |
| 618 | const CallExpr *CE, CheckerContext &C, const ProgramStateRef &State) const { |
| 619 | // 3-argument malloc(), as commonly used in {Free,Net,Open}BSD Kernels: |
| 620 | // |
| 621 | // void *malloc(unsigned long size, struct malloc_type *mtp, int flags); |
| 622 | // |
| 623 | // One of the possible flags is M_ZERO, which means 'give me back an |
| 624 | // allocation which is already zeroed', like calloc. |
| 625 | |
| 626 | // 2-argument kmalloc(), as used in the Linux kernel: |
| 627 | // |
| 628 | // void *kmalloc(size_t size, gfp_t flags); |
| 629 | // |
| 630 | // Has the similar flag value __GFP_ZERO. |
| 631 | |
| 632 | // This logic is largely cloned from O_CREAT in UnixAPIChecker, maybe some |
| 633 | // code could be shared. |
| 634 | |
| 635 | ASTContext &Ctx = C.getASTContext(); |
| 636 | llvm::Triple::OSType OS = Ctx.getTargetInfo().getTriple().getOS(); |
| 637 | |
| 638 | if (!KernelZeroFlagVal.hasValue()) { |
| 639 | if (OS == llvm::Triple::FreeBSD) |
| 640 | KernelZeroFlagVal = 0x0100; |
| 641 | else if (OS == llvm::Triple::NetBSD) |
| 642 | KernelZeroFlagVal = 0x0002; |
| 643 | else if (OS == llvm::Triple::OpenBSD) |
| 644 | KernelZeroFlagVal = 0x0008; |
| 645 | else if (OS == llvm::Triple::Linux) |
| 646 | // __GFP_ZERO |
| 647 | KernelZeroFlagVal = 0x8000; |
| 648 | else |
| 649 | // FIXME: We need a more general way of getting the M_ZERO value. |
| 650 | // See also: O_CREAT in UnixAPIChecker.cpp. |
| 651 | |
| 652 | // Fall back to normal malloc behavior on platforms where we don't |
| 653 | // know M_ZERO. |
| 654 | return None; |
| 655 | } |
| 656 | |
| 657 | // We treat the last argument as the flags argument, and callers fall-back to |
| 658 | // normal malloc on a None return. This works for the FreeBSD kernel malloc |
| 659 | // as well as Linux kmalloc. |
| 660 | if (CE->getNumArgs() < 2) |
| 661 | return None; |
| 662 | |
| 663 | const Expr *FlagsEx = CE->getArg(CE->getNumArgs() - 1); |
| 664 | const SVal V = State->getSVal(FlagsEx, C.getLocationContext()); |
| 665 | if (!V.getAs<NonLoc>()) { |
| 666 | // The case where 'V' can be a location can only be due to a bad header, |
| 667 | // so in this case bail out. |
| 668 | return None; |
| 669 | } |
| 670 | |
| 671 | NonLoc Flags = V.castAs<NonLoc>(); |
| 672 | NonLoc ZeroFlag = C.getSValBuilder() |
| 673 | .makeIntVal(KernelZeroFlagVal.getValue(), FlagsEx->getType()) |
| 674 | .castAs<NonLoc>(); |
| 675 | SVal MaskedFlagsUC = C.getSValBuilder().evalBinOpNN(State, BO_And, |
| 676 | Flags, ZeroFlag, |
| 677 | FlagsEx->getType()); |
| 678 | if (MaskedFlagsUC.isUnknownOrUndef()) |
| 679 | return None; |
| 680 | DefinedSVal MaskedFlags = MaskedFlagsUC.castAs<DefinedSVal>(); |
| 681 | |
| 682 | // Check if maskedFlags is non-zero. |
| 683 | ProgramStateRef TrueState, FalseState; |
| 684 | std::tie(TrueState, FalseState) = State->assume(MaskedFlags); |
| 685 | |
| 686 | // If M_ZERO is set, treat this like calloc (initialized). |
| 687 | if (TrueState && !FalseState) { |
| 688 | SVal ZeroVal = C.getSValBuilder().makeZeroVal(Ctx.CharTy); |
| 689 | return MallocMemAux(C, CE, CE->getArg(0), ZeroVal, TrueState); |
| 690 | } |
| 691 | |
| 692 | return None; |
| 693 | } |
| 694 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 695 | void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const { |
Jordan Rose | c20c727 | 2012-09-20 01:55:32 +0000 | [diff] [blame] | 696 | if (C.wasInlined) |
| 697 | return; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 698 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 699 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
| 700 | if (!FD) |
| 701 | return; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 702 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 703 | ProgramStateRef State = C.getState(); |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 704 | bool ReleasedAllocatedMemory = false; |
Jordan Rose | 5ef6e94 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 705 | |
| 706 | if (FD->getKind() == Decl::Function) { |
| 707 | initIdentifierInfo(C.getASTContext()); |
| 708 | IdentifierInfo *FunI = FD->getIdentifier(); |
| 709 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 710 | if (FunI == II_malloc) { |
| 711 | if (CE->getNumArgs() < 1) |
| 712 | return; |
| 713 | if (CE->getNumArgs() < 3) { |
| 714 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
| 715 | } else if (CE->getNumArgs() == 3) { |
| 716 | llvm::Optional<ProgramStateRef> MaybeState = |
| 717 | performKernelMalloc(CE, C, State); |
| 718 | if (MaybeState.hasValue()) |
| 719 | State = MaybeState.getValue(); |
| 720 | else |
| 721 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
| 722 | } |
| 723 | } else if (FunI == II_kmalloc) { |
| 724 | llvm::Optional<ProgramStateRef> MaybeState = |
| 725 | performKernelMalloc(CE, C, State); |
| 726 | if (MaybeState.hasValue()) |
| 727 | State = MaybeState.getValue(); |
| 728 | else |
| 729 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
| 730 | } else if (FunI == II_valloc) { |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 731 | if (CE->getNumArgs() < 1) |
| 732 | return; |
| 733 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State); |
| 734 | } else if (FunI == II_realloc) { |
| 735 | State = ReallocMem(C, CE, false); |
| 736 | } else if (FunI == II_reallocf) { |
| 737 | State = ReallocMem(C, CE, true); |
| 738 | } else if (FunI == II_calloc) { |
| 739 | State = CallocMem(C, CE); |
| 740 | } else if (FunI == II_free) { |
| 741 | State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory); |
| 742 | } else if (FunI == II_strdup) { |
| 743 | State = MallocUpdateRefState(C, CE, State); |
| 744 | } else if (FunI == II_strndup) { |
| 745 | State = MallocUpdateRefState(C, CE, State); |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 746 | } |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 747 | else if (isStandardNewDelete(FD, C.getASTContext())) { |
| 748 | // Process direct calls to operator new/new[]/delete/delete[] functions |
| 749 | // as distinct from new/new[]/delete/delete[] expressions that are |
| 750 | // processed by the checkPostStmt callbacks for CXXNewExpr and |
| 751 | // CXXDeleteExpr. |
| 752 | OverloadedOperatorKind K = FD->getOverloadedOperator(); |
| 753 | if (K == OO_New) |
| 754 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State, |
| 755 | AF_CXXNew); |
| 756 | else if (K == OO_Array_New) |
| 757 | State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State, |
| 758 | AF_CXXNewArray); |
| 759 | else if (K == OO_Delete || K == OO_Array_Delete) |
| 760 | State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory); |
| 761 | else |
| 762 | llvm_unreachable("not a new/delete operator"); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 763 | } else if (FunI == II_if_nameindex) { |
| 764 | // Should we model this differently? We can allocate a fixed number of |
| 765 | // elements with zeros in the last one. |
| 766 | State = MallocMemAux(C, CE, UnknownVal(), UnknownVal(), State, |
| 767 | AF_IfNameIndex); |
| 768 | } else if (FunI == II_if_freenameindex) { |
| 769 | State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory); |
Jordan Rose | 5ef6e94 | 2012-07-10 23:13:01 +0000 | [diff] [blame] | 770 | } |
| 771 | } |
| 772 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 773 | if (ChecksEnabled[CK_MallocOptimistic] || |
| 774 | ChecksEnabled[CK_MismatchedDeallocatorChecker]) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 775 | // Check all the attributes, if there are any. |
| 776 | // There can be multiple of these attributes. |
| 777 | if (FD->hasAttrs()) |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 778 | for (const auto *I : FD->specific_attrs<OwnershipAttr>()) { |
| 779 | switch (I->getOwnKind()) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 780 | case OwnershipAttr::Returns: |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 781 | State = MallocMemReturnsAttr(C, CE, I); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 782 | break; |
| 783 | case OwnershipAttr::Takes: |
| 784 | case OwnershipAttr::Holds: |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 785 | State = FreeMemAttr(C, CE, I); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 786 | break; |
| 787 | } |
| 788 | } |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 789 | } |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 790 | C.addTransition(State); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 791 | } |
| 792 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 793 | static QualType getDeepPointeeType(QualType T) { |
| 794 | QualType Result = T, PointeeType = T->getPointeeType(); |
| 795 | while (!PointeeType.isNull()) { |
| 796 | Result = PointeeType; |
| 797 | PointeeType = PointeeType->getPointeeType(); |
| 798 | } |
| 799 | return Result; |
| 800 | } |
| 801 | |
| 802 | static bool treatUnusedNewEscaped(const CXXNewExpr *NE) { |
| 803 | |
| 804 | const CXXConstructExpr *ConstructE = NE->getConstructExpr(); |
| 805 | if (!ConstructE) |
| 806 | return false; |
| 807 | |
| 808 | if (!NE->getAllocatedType()->getAsCXXRecordDecl()) |
| 809 | return false; |
| 810 | |
| 811 | const CXXConstructorDecl *CtorD = ConstructE->getConstructor(); |
| 812 | |
| 813 | // Iterate over the constructor parameters. |
| 814 | for (const auto *CtorParam : CtorD->params()) { |
| 815 | |
| 816 | QualType CtorParamPointeeT = CtorParam->getType()->getPointeeType(); |
| 817 | if (CtorParamPointeeT.isNull()) |
| 818 | continue; |
| 819 | |
| 820 | CtorParamPointeeT = getDeepPointeeType(CtorParamPointeeT); |
| 821 | |
| 822 | if (CtorParamPointeeT->getAsCXXRecordDecl()) |
| 823 | return true; |
| 824 | } |
| 825 | |
| 826 | return false; |
| 827 | } |
| 828 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 829 | void MallocChecker::checkPostStmt(const CXXNewExpr *NE, |
| 830 | CheckerContext &C) const { |
| 831 | |
| 832 | if (NE->getNumPlacementArgs()) |
| 833 | for (CXXNewExpr::const_arg_iterator I = NE->placement_arg_begin(), |
| 834 | E = NE->placement_arg_end(); I != E; ++I) |
| 835 | if (SymbolRef Sym = C.getSVal(*I).getAsSymbol()) |
| 836 | checkUseAfterFree(Sym, C, *I); |
| 837 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 838 | if (!isStandardNewDelete(NE->getOperatorNew(), C.getASTContext())) |
| 839 | return; |
| 840 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 841 | ParentMap &PM = C.getLocationContext()->getParentMap(); |
| 842 | if (!PM.isConsumedExpr(NE) && treatUnusedNewEscaped(NE)) |
| 843 | return; |
| 844 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 845 | ProgramStateRef State = C.getState(); |
| 846 | // The return value from operator new is bound to a specified initialization |
| 847 | // value (if any) and we don't want to loose this value. So we call |
| 848 | // MallocUpdateRefState() instead of MallocMemAux() which breakes the |
| 849 | // existing binding. |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 850 | State = MallocUpdateRefState(C, NE, State, NE->isArray() ? AF_CXXNewArray |
| 851 | : AF_CXXNew); |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 852 | C.addTransition(State); |
| 853 | } |
| 854 | |
| 855 | void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE, |
| 856 | CheckerContext &C) const { |
| 857 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 858 | if (!ChecksEnabled[CK_NewDeleteChecker]) |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 859 | if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol()) |
| 860 | checkUseAfterFree(Sym, C, DE->getArgument()); |
| 861 | |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 862 | if (!isStandardNewDelete(DE->getOperatorDelete(), C.getASTContext())) |
| 863 | return; |
| 864 | |
| 865 | ProgramStateRef State = C.getState(); |
| 866 | bool ReleasedAllocated; |
| 867 | State = FreeMemAux(C, DE->getArgument(), DE, State, |
| 868 | /*Hold*/false, ReleasedAllocated); |
| 869 | |
| 870 | C.addTransition(State); |
| 871 | } |
| 872 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 873 | static bool isKnownDeallocObjCMethodName(const ObjCMethodCall &Call) { |
| 874 | // If the first selector piece is one of the names below, assume that the |
| 875 | // object takes ownership of the memory, promising to eventually deallocate it |
| 876 | // with free(). |
| 877 | // Ex: [NSData dataWithBytesNoCopy:bytes length:10]; |
| 878 | // (...unless a 'freeWhenDone' parameter is false, but that's checked later.) |
| 879 | StringRef FirstSlot = Call.getSelector().getNameForSlot(0); |
| 880 | if (FirstSlot == "dataWithBytesNoCopy" || |
| 881 | FirstSlot == "initWithBytesNoCopy" || |
| 882 | FirstSlot == "initWithCharactersNoCopy") |
| 883 | return true; |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 884 | |
| 885 | return false; |
| 886 | } |
| 887 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 888 | static Optional<bool> getFreeWhenDoneArg(const ObjCMethodCall &Call) { |
| 889 | Selector S = Call.getSelector(); |
| 890 | |
| 891 | // FIXME: We should not rely on fully-constrained symbols being folded. |
| 892 | for (unsigned i = 1; i < S.getNumArgs(); ++i) |
| 893 | if (S.getNameForSlot(i).equals("freeWhenDone")) |
| 894 | return !Call.getArgSVal(i).isZeroConstant(); |
| 895 | |
| 896 | return None; |
| 897 | } |
| 898 | |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 899 | void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call, |
| 900 | CheckerContext &C) const { |
Anna Zaks | c2cca23 | 2012-12-11 00:17:53 +0000 | [diff] [blame] | 901 | if (C.wasInlined) |
| 902 | return; |
| 903 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 904 | if (!isKnownDeallocObjCMethodName(Call)) |
| 905 | return; |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 906 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 907 | if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(Call)) |
| 908 | if (!*FreeWhenDone) |
| 909 | return; |
| 910 | |
| 911 | bool ReleasedAllocatedMemory; |
| 912 | ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0), |
| 913 | Call.getOriginExpr(), C.getState(), |
| 914 | /*Hold=*/true, ReleasedAllocatedMemory, |
| 915 | /*RetNullOnFailure=*/true); |
| 916 | |
| 917 | C.addTransition(State); |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 918 | } |
| 919 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 920 | ProgramStateRef |
| 921 | MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE, |
| 922 | const OwnershipAttr *Att) const { |
| 923 | if (Att->getModule() != II_malloc) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 924 | return nullptr; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 925 | |
Sean Hunt | cf807c4 | 2010-08-18 23:23:40 +0000 | [diff] [blame] | 926 | OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 927 | if (I != E) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 928 | return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 929 | } |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 930 | return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState()); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 931 | } |
| 932 | |
Anna Zaks | b319e02 | 2012-02-08 20:13:28 +0000 | [diff] [blame] | 933 | ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C, |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 934 | const CallExpr *CE, |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 935 | SVal Size, SVal Init, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 936 | ProgramStateRef State, |
| 937 | AllocationFamily Family) { |
Anna Zaks | e17fdb2 | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 938 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 939 | // We expect the malloc functions to return a pointer. |
| 940 | if (!Loc::isLocType(CE->getType())) |
| 941 | return nullptr; |
| 942 | |
Anna Zaks | e17fdb2 | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 943 | // Bind the return value to the symbolic value from the heap region. |
| 944 | // TODO: We could rewrite post visit to eval call; 'malloc' does not have |
| 945 | // side effects other than what we model here. |
Ted Kremenek | 66c486f | 2012-08-22 06:26:15 +0000 | [diff] [blame] | 946 | unsigned Count = C.blockCount(); |
Anna Zaks | e17fdb2 | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 947 | SValBuilder &svalBuilder = C.getSValBuilder(); |
| 948 | const LocationContext *LCtx = C.getPredecessor()->getLocationContext(); |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 949 | DefinedSVal RetVal = svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count) |
| 950 | .castAs<DefinedSVal>(); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 951 | State = State->BindExpr(CE, C.getLocationContext(), RetVal); |
Zhongxing Xu | a49c6b7 | 2009-12-11 03:09:01 +0000 | [diff] [blame] | 952 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 953 | // Fill the region with the initialization value. |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 954 | State = State->bindDefault(RetVal, Init); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 955 | |
Jordy Rose | 32f2656 | 2010-07-04 00:00:41 +0000 | [diff] [blame] | 956 | // Set the region's extent equal to the Size parameter. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 957 | const SymbolicRegion *R = |
Anna Zaks | e17fdb2 | 2012-06-07 03:57:32 +0000 | [diff] [blame] | 958 | dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion()); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 959 | if (!R) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 960 | return nullptr; |
David Blaikie | dc84cd5 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 961 | if (Optional<DefinedOrUnknownSVal> DefinedSize = |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 962 | Size.getAs<DefinedOrUnknownSVal>()) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 963 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 964 | DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 965 | DefinedOrUnknownSVal extentMatchesSize = |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 966 | svalBuilder.evalEQ(State, Extent, *DefinedSize); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 967 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 968 | State = State->assume(extentMatchesSize, true); |
| 969 | assert(State); |
Anna Zaks | 60a1fa4 | 2012-02-22 03:14:20 +0000 | [diff] [blame] | 970 | } |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 971 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 972 | return MallocUpdateRefState(C, CE, State, Family); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 973 | } |
| 974 | |
| 975 | ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C, |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 976 | const Expr *E, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 977 | ProgramStateRef State, |
| 978 | AllocationFamily Family) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 979 | // Get the return value. |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 980 | SVal retVal = State->getSVal(E, C.getLocationContext()); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 981 | |
| 982 | // We expect the malloc functions to return a pointer. |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 983 | if (!retVal.getAs<Loc>()) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 984 | return nullptr; |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 985 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 986 | SymbolRef Sym = retVal.getAsLocSymbol(); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 987 | assert(Sym); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 988 | |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 989 | // Set the symbol's state to Allocated. |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 990 | return State->set<RegionState>(Sym, RefState::getAllocated(Family, E)); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 991 | } |
| 992 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 993 | ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C, |
| 994 | const CallExpr *CE, |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 995 | const OwnershipAttr *Att) const { |
| 996 | if (Att->getModule() != II_malloc) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 997 | return nullptr; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 998 | |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 999 | ProgramStateRef State = C.getState(); |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1000 | bool ReleasedAllocated = false; |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 1001 | |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1002 | for (const auto &Arg : Att->args()) { |
| 1003 | ProgramStateRef StateI = FreeMemAux(C, CE, State, Arg, |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1004 | Att->getOwnKind() == OwnershipAttr::Holds, |
| 1005 | ReleasedAllocated); |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 1006 | if (StateI) |
| 1007 | State = StateI; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1008 | } |
Anna Zaks | b3d7275 | 2012-03-01 22:06:06 +0000 | [diff] [blame] | 1009 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1010 | } |
| 1011 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1012 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1013 | const CallExpr *CE, |
| 1014 | ProgramStateRef state, |
| 1015 | unsigned Num, |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1016 | bool Hold, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1017 | bool &ReleasedAllocated, |
| 1018 | bool ReturnsNullOnFailure) const { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1019 | if (CE->getNumArgs() < (Num + 1)) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1020 | return nullptr; |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1021 | |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1022 | return FreeMemAux(C, CE->getArg(Num), CE, state, Hold, |
| 1023 | ReleasedAllocated, ReturnsNullOnFailure); |
| 1024 | } |
| 1025 | |
Anna Zaks | 2ccecfa | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1026 | /// Checks if the previous call to free on the given symbol failed - if free |
| 1027 | /// failed, returns true. Also, returns the corresponding return value symbol. |
Benjamin Kramer | 4d9f4e5 | 2012-11-22 15:02:44 +0000 | [diff] [blame] | 1028 | static bool didPreviousFreeFail(ProgramStateRef State, |
| 1029 | SymbolRef Sym, SymbolRef &RetStatusSymbol) { |
Anna Zaks | 2ccecfa | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1030 | const SymbolRef *Ret = State->get<FreeReturnValue>(Sym); |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1031 | if (Ret) { |
| 1032 | assert(*Ret && "We should not store the null return symbol"); |
| 1033 | ConstraintManager &CMgr = State->getConstraintManager(); |
| 1034 | ConditionTruthVal FreeFailed = CMgr.isNull(State, *Ret); |
Anna Zaks | 2ccecfa | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1035 | RetStatusSymbol = *Ret; |
| 1036 | return FreeFailed.isConstrainedTrue(); |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1037 | } |
Anna Zaks | 2ccecfa | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1038 | return false; |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1039 | } |
| 1040 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1041 | AllocationFamily MallocChecker::getAllocationFamily(CheckerContext &C, |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1042 | const Stmt *S) const { |
| 1043 | if (!S) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1044 | return AF_None; |
| 1045 | |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1046 | if (const CallExpr *CE = dyn_cast<CallExpr>(S)) { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1047 | const FunctionDecl *FD = C.getCalleeDecl(CE); |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1048 | |
| 1049 | if (!FD) |
| 1050 | FD = dyn_cast<FunctionDecl>(CE->getCalleeDecl()); |
| 1051 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1052 | ASTContext &Ctx = C.getASTContext(); |
| 1053 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1054 | if (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Any)) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1055 | return AF_Malloc; |
| 1056 | |
| 1057 | if (isStandardNewDelete(FD, Ctx)) { |
| 1058 | OverloadedOperatorKind Kind = FD->getOverloadedOperator(); |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1059 | if (Kind == OO_New || Kind == OO_Delete) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1060 | return AF_CXXNew; |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1061 | else if (Kind == OO_Array_New || Kind == OO_Array_Delete) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1062 | return AF_CXXNewArray; |
| 1063 | } |
| 1064 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1065 | if (isCMemFunction(FD, Ctx, AF_IfNameIndex, MemoryOperationKind::MOK_Any)) |
| 1066 | return AF_IfNameIndex; |
| 1067 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1068 | return AF_None; |
| 1069 | } |
| 1070 | |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1071 | if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(S)) |
| 1072 | return NE->isArray() ? AF_CXXNewArray : AF_CXXNew; |
| 1073 | |
| 1074 | if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(S)) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1075 | return DE->isArrayForm() ? AF_CXXNewArray : AF_CXXNew; |
| 1076 | |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1077 | if (isa<ObjCMessageExpr>(S)) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1078 | return AF_Malloc; |
| 1079 | |
| 1080 | return AF_None; |
| 1081 | } |
| 1082 | |
| 1083 | bool MallocChecker::printAllocDeallocName(raw_ostream &os, CheckerContext &C, |
| 1084 | const Expr *E) const { |
| 1085 | if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { |
| 1086 | // FIXME: This doesn't handle indirect calls. |
| 1087 | const FunctionDecl *FD = CE->getDirectCallee(); |
| 1088 | if (!FD) |
| 1089 | return false; |
| 1090 | |
| 1091 | os << *FD; |
| 1092 | if (!FD->isOverloadedOperator()) |
| 1093 | os << "()"; |
| 1094 | return true; |
| 1095 | } |
| 1096 | |
| 1097 | if (const ObjCMessageExpr *Msg = dyn_cast<ObjCMessageExpr>(E)) { |
| 1098 | if (Msg->isInstanceMessage()) |
| 1099 | os << "-"; |
| 1100 | else |
| 1101 | os << "+"; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1102 | Msg->getSelector().print(os); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1103 | return true; |
| 1104 | } |
| 1105 | |
| 1106 | if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) { |
| 1107 | os << "'" |
| 1108 | << getOperatorSpelling(NE->getOperatorNew()->getOverloadedOperator()) |
| 1109 | << "'"; |
| 1110 | return true; |
| 1111 | } |
| 1112 | |
| 1113 | if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(E)) { |
| 1114 | os << "'" |
| 1115 | << getOperatorSpelling(DE->getOperatorDelete()->getOverloadedOperator()) |
| 1116 | << "'"; |
| 1117 | return true; |
| 1118 | } |
| 1119 | |
| 1120 | return false; |
| 1121 | } |
| 1122 | |
| 1123 | void MallocChecker::printExpectedAllocName(raw_ostream &os, CheckerContext &C, |
| 1124 | const Expr *E) const { |
| 1125 | AllocationFamily Family = getAllocationFamily(C, E); |
| 1126 | |
| 1127 | switch(Family) { |
| 1128 | case AF_Malloc: os << "malloc()"; return; |
| 1129 | case AF_CXXNew: os << "'new'"; return; |
| 1130 | case AF_CXXNewArray: os << "'new[]'"; return; |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1131 | case AF_IfNameIndex: os << "'if_nameindex()'"; return; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1132 | case AF_None: llvm_unreachable("not a deallocation expression"); |
| 1133 | } |
| 1134 | } |
| 1135 | |
| 1136 | void MallocChecker::printExpectedDeallocName(raw_ostream &os, |
| 1137 | AllocationFamily Family) const { |
| 1138 | switch(Family) { |
| 1139 | case AF_Malloc: os << "free()"; return; |
| 1140 | case AF_CXXNew: os << "'delete'"; return; |
| 1141 | case AF_CXXNewArray: os << "'delete[]'"; return; |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1142 | case AF_IfNameIndex: os << "'if_freenameindex()'"; return; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1143 | case AF_None: llvm_unreachable("suspicious AF_None argument"); |
| 1144 | } |
| 1145 | } |
| 1146 | |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1147 | ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C, |
| 1148 | const Expr *ArgExpr, |
| 1149 | const Expr *ParentExpr, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1150 | ProgramStateRef State, |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1151 | bool Hold, |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1152 | bool &ReleasedAllocated, |
| 1153 | bool ReturnsNullOnFailure) const { |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 1154 | |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1155 | SVal ArgVal = State->getSVal(ArgExpr, C.getLocationContext()); |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1156 | if (!ArgVal.getAs<DefinedOrUnknownSVal>()) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1157 | return nullptr; |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1158 | DefinedOrUnknownSVal location = ArgVal.castAs<DefinedOrUnknownSVal>(); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1159 | |
| 1160 | // Check for null dereferences. |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1161 | if (!location.getAs<Loc>()) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1162 | return nullptr; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1163 | |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 1164 | // The explicit NULL case, no operation is performed. |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1165 | ProgramStateRef notNullState, nullState; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1166 | std::tie(notNullState, nullState) = State->assume(location); |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1167 | if (nullState && !notNullState) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1168 | return nullptr; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 1169 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1170 | // Unknown values could easily be okay |
| 1171 | // Undefined values are handled elsewhere |
| 1172 | if (ArgVal.isUnknownOrUndef()) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1173 | return nullptr; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1174 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1175 | const MemRegion *R = ArgVal.getAsRegion(); |
| 1176 | |
| 1177 | // Nonlocs can't be freed, of course. |
| 1178 | // Non-region locations (labels and fixed addresses) also shouldn't be freed. |
| 1179 | if (!R) { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1180 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1181 | return nullptr; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1182 | } |
| 1183 | |
| 1184 | R = R->StripCasts(); |
| 1185 | |
| 1186 | // Blocks might show up as heap data, but should not be free()d |
| 1187 | if (isa<BlockDataRegion>(R)) { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1188 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1189 | return nullptr; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1190 | } |
| 1191 | |
| 1192 | const MemSpaceRegion *MS = R->getMemorySpace(); |
| 1193 | |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1194 | // Parameters, locals, statics, globals, and memory returned by alloca() |
| 1195 | // shouldn't be freed. |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1196 | if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) { |
| 1197 | // FIXME: at the time this code was written, malloc() regions were |
| 1198 | // represented by conjured symbols, which are all in UnknownSpaceRegion. |
| 1199 | // This means that there isn't actually anything from HeapSpaceRegion |
| 1200 | // that should be freed, even though we allow it here. |
| 1201 | // Of course, free() can work on memory allocated outside the current |
| 1202 | // function, so UnknownSpaceRegion is always a possibility. |
| 1203 | // False negatives are better than false positives. |
| 1204 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1205 | ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1206 | return nullptr; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1207 | } |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1208 | |
| 1209 | const SymbolicRegion *SrBase = dyn_cast<SymbolicRegion>(R->getBaseRegion()); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1210 | // Various cases could lead to non-symbol values here. |
| 1211 | // For now, ignore them. |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1212 | if (!SrBase) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1213 | return nullptr; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1214 | |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1215 | SymbolRef SymBase = SrBase->getSymbol(); |
| 1216 | const RefState *RsBase = State->get<RegionState>(SymBase); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1217 | SymbolRef PreviousRetStatusSymbol = nullptr; |
Zhongxing Xu | 7e3cda9 | 2010-01-18 03:27:34 +0000 | [diff] [blame] | 1218 | |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1219 | if (RsBase) { |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1220 | |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1221 | // Check for double free first. |
| 1222 | if ((RsBase->isReleased() || RsBase->isRelinquished()) && |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1223 | !didPreviousFreeFail(State, SymBase, PreviousRetStatusSymbol)) { |
| 1224 | ReportDoubleFree(C, ParentExpr->getSourceRange(), RsBase->isReleased(), |
| 1225 | SymBase, PreviousRetStatusSymbol); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1226 | return nullptr; |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1227 | |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1228 | // If the pointer is allocated or escaped, but we are now trying to free it, |
| 1229 | // check that the call to free is proper. |
| 1230 | } else if (RsBase->isAllocated() || RsBase->isEscaped()) { |
| 1231 | |
| 1232 | // Check if an expected deallocation function matches the real one. |
| 1233 | bool DeallocMatchesAlloc = |
| 1234 | RsBase->getAllocationFamily() == getAllocationFamily(C, ParentExpr); |
| 1235 | if (!DeallocMatchesAlloc) { |
| 1236 | ReportMismatchedDealloc(C, ArgExpr->getSourceRange(), |
Anton Yartsev | 3084518 | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1237 | ParentExpr, RsBase, SymBase, Hold); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1238 | return nullptr; |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1239 | } |
| 1240 | |
| 1241 | // Check if the memory location being freed is the actual location |
| 1242 | // allocated, or an offset. |
| 1243 | RegionOffset Offset = R->getAsOffset(); |
| 1244 | if (Offset.isValid() && |
| 1245 | !Offset.hasSymbolicOffset() && |
| 1246 | Offset.getOffset() != 0) { |
| 1247 | const Expr *AllocExpr = cast<Expr>(RsBase->getStmt()); |
| 1248 | ReportOffsetFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr, |
| 1249 | AllocExpr); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1250 | return nullptr; |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 1251 | } |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1252 | } |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1253 | } |
| 1254 | |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1255 | ReleasedAllocated = (RsBase != nullptr) && RsBase->isAllocated(); |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1256 | |
Anna Zaks | 2ccecfa | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1257 | // Clean out the info on previous call to free return info. |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1258 | State = State->remove<FreeReturnValue>(SymBase); |
Anna Zaks | 2ccecfa | 2012-11-13 19:47:40 +0000 | [diff] [blame] | 1259 | |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1260 | // Keep track of the return value. If it is NULL, we will know that free |
| 1261 | // failed. |
| 1262 | if (ReturnsNullOnFailure) { |
| 1263 | SVal RetVal = C.getSVal(ParentExpr); |
| 1264 | SymbolRef RetStatusSymbol = RetVal.getAsSymbol(); |
| 1265 | if (RetStatusSymbol) { |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1266 | C.getSymbolManager().addSymbolDependency(SymBase, RetStatusSymbol); |
| 1267 | State = State->set<FreeReturnValue>(SymBase, RetStatusSymbol); |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1268 | } |
| 1269 | } |
| 1270 | |
Anton Yartsev | a3989b8 | 2013-04-05 19:08:04 +0000 | [diff] [blame] | 1271 | AllocationFamily Family = RsBase ? RsBase->getAllocationFamily() |
| 1272 | : getAllocationFamily(C, ParentExpr); |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1273 | // Normal free. |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1274 | if (Hold) |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1275 | return State->set<RegionState>(SymBase, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1276 | RefState::getRelinquished(Family, |
| 1277 | ParentExpr)); |
| 1278 | |
| 1279 | return State->set<RegionState>(SymBase, |
| 1280 | RefState::getReleased(Family, ParentExpr)); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1281 | } |
| 1282 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1283 | Optional<MallocChecker::CheckKind> |
| 1284 | MallocChecker::getCheckIfTracked(AllocationFamily Family) const { |
Anton Yartsev | 9c6bbb3 | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1285 | switch (Family) { |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1286 | case AF_Malloc: |
| 1287 | case AF_IfNameIndex: { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1288 | if (ChecksEnabled[CK_MallocOptimistic]) { |
| 1289 | return CK_MallocOptimistic; |
| 1290 | } else if (ChecksEnabled[CK_MallocPessimistic]) { |
| 1291 | return CK_MallocPessimistic; |
| 1292 | } |
| 1293 | return Optional<MallocChecker::CheckKind>(); |
Anton Yartsev | 9c6bbb3 | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1294 | } |
| 1295 | case AF_CXXNew: |
| 1296 | case AF_CXXNewArray: { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1297 | if (ChecksEnabled[CK_NewDeleteChecker]) { |
| 1298 | return CK_NewDeleteChecker; |
| 1299 | } |
| 1300 | return Optional<MallocChecker::CheckKind>(); |
Anton Yartsev | 9c6bbb3 | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1301 | } |
| 1302 | case AF_None: { |
Anton Yartsev | a3989b8 | 2013-04-05 19:08:04 +0000 | [diff] [blame] | 1303 | llvm_unreachable("no family"); |
Anton Yartsev | 9c6bbb3 | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1304 | } |
Anton Yartsev | 9c6bbb3 | 2013-04-05 00:31:02 +0000 | [diff] [blame] | 1305 | } |
Anton Yartsev | c845431 | 2013-04-05 02:12:04 +0000 | [diff] [blame] | 1306 | llvm_unreachable("unhandled family"); |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1307 | } |
| 1308 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1309 | Optional<MallocChecker::CheckKind> |
| 1310 | MallocChecker::getCheckIfTracked(CheckerContext &C, |
| 1311 | const Stmt *AllocDeallocStmt) const { |
| 1312 | return getCheckIfTracked(getAllocationFamily(C, AllocDeallocStmt)); |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1313 | } |
| 1314 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1315 | Optional<MallocChecker::CheckKind> |
| 1316 | MallocChecker::getCheckIfTracked(CheckerContext &C, SymbolRef Sym) const { |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1317 | |
Anton Yartsev | a3989b8 | 2013-04-05 19:08:04 +0000 | [diff] [blame] | 1318 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 1319 | assert(RS); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1320 | return getCheckIfTracked(RS->getAllocationFamily()); |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1321 | } |
| 1322 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 1323 | bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) { |
David Blaikie | dc84cd5 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1324 | if (Optional<nonloc::ConcreteInt> IntVal = V.getAs<nonloc::ConcreteInt>()) |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1325 | os << "an integer (" << IntVal->getValue() << ")"; |
David Blaikie | dc84cd5 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1326 | else if (Optional<loc::ConcreteInt> ConstAddr = V.getAs<loc::ConcreteInt>()) |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1327 | os << "a constant address (" << ConstAddr->getValue() << ")"; |
David Blaikie | dc84cd5 | 2013-02-20 22:23:23 +0000 | [diff] [blame] | 1328 | else if (Optional<loc::GotoLabel> Label = V.getAs<loc::GotoLabel>()) |
Chris Lattner | 6810630 | 2011-02-17 05:38:27 +0000 | [diff] [blame] | 1329 | os << "the address of the label '" << Label->getLabel()->getName() << "'"; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1330 | else |
| 1331 | return false; |
| 1332 | |
| 1333 | return true; |
| 1334 | } |
| 1335 | |
Ted Kremenek | 9c378f7 | 2011-08-12 23:37:29 +0000 | [diff] [blame] | 1336 | bool MallocChecker::SummarizeRegion(raw_ostream &os, |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1337 | const MemRegion *MR) { |
| 1338 | switch (MR->getKind()) { |
| 1339 | case MemRegion::FunctionTextRegionKind: { |
Anna Zaks | 5fc1d0c | 2012-09-17 19:13:56 +0000 | [diff] [blame] | 1340 | const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl(); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1341 | if (FD) |
Benjamin Kramer | b8989f2 | 2011-10-14 18:45:37 +0000 | [diff] [blame] | 1342 | os << "the address of the function '" << *FD << '\''; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1343 | else |
| 1344 | os << "the address of a function"; |
| 1345 | return true; |
| 1346 | } |
| 1347 | case MemRegion::BlockTextRegionKind: |
| 1348 | os << "block text"; |
| 1349 | return true; |
| 1350 | case MemRegion::BlockDataRegionKind: |
| 1351 | // FIXME: where the block came from? |
| 1352 | os << "a block"; |
| 1353 | return true; |
| 1354 | default: { |
| 1355 | const MemSpaceRegion *MS = MR->getMemorySpace(); |
| 1356 | |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1357 | if (isa<StackLocalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1358 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 1359 | const VarDecl *VD; |
| 1360 | if (VR) |
| 1361 | VD = VR->getDecl(); |
| 1362 | else |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1363 | VD = nullptr; |
| 1364 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1365 | if (VD) |
| 1366 | os << "the address of the local variable '" << VD->getName() << "'"; |
| 1367 | else |
| 1368 | os << "the address of a local stack variable"; |
| 1369 | return true; |
| 1370 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1371 | |
| 1372 | if (isa<StackArgumentsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1373 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 1374 | const VarDecl *VD; |
| 1375 | if (VR) |
| 1376 | VD = VR->getDecl(); |
| 1377 | else |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1378 | VD = nullptr; |
| 1379 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1380 | if (VD) |
| 1381 | os << "the address of the parameter '" << VD->getName() << "'"; |
| 1382 | else |
| 1383 | os << "the address of a parameter"; |
| 1384 | return true; |
| 1385 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1386 | |
| 1387 | if (isa<GlobalsSpaceRegion>(MS)) { |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1388 | const VarRegion *VR = dyn_cast<VarRegion>(MR); |
| 1389 | const VarDecl *VD; |
| 1390 | if (VR) |
| 1391 | VD = VR->getDecl(); |
| 1392 | else |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1393 | VD = nullptr; |
| 1394 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1395 | if (VD) { |
| 1396 | if (VD->isStaticLocal()) |
| 1397 | os << "the address of the static variable '" << VD->getName() << "'"; |
| 1398 | else |
| 1399 | os << "the address of the global variable '" << VD->getName() << "'"; |
| 1400 | } else |
| 1401 | os << "the address of a global variable"; |
| 1402 | return true; |
| 1403 | } |
Anna Zaks | eb31a76 | 2012-01-04 23:54:01 +0000 | [diff] [blame] | 1404 | |
| 1405 | return false; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1406 | } |
| 1407 | } |
| 1408 | } |
| 1409 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1410 | void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal, |
| 1411 | SourceRange Range, |
| 1412 | const Expr *DeallocExpr) const { |
| 1413 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1414 | if (!ChecksEnabled[CK_MallocOptimistic] && |
| 1415 | !ChecksEnabled[CK_MallocPessimistic] && |
| 1416 | !ChecksEnabled[CK_NewDeleteChecker]) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1417 | return; |
| 1418 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1419 | Optional<MallocChecker::CheckKind> CheckKind = |
| 1420 | getCheckIfTracked(C, DeallocExpr); |
| 1421 | if (!CheckKind.hasValue()) |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1422 | return; |
| 1423 | |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 1424 | if (ExplodedNode *N = C.generateSink()) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1425 | if (!BT_BadFree[*CheckKind]) |
| 1426 | BT_BadFree[*CheckKind].reset( |
| 1427 | new BugType(CheckNames[*CheckKind], "Bad free", "Memory Error")); |
| 1428 | |
Dylan Noblesmith | f7ccbad | 2012-02-05 02:13:05 +0000 | [diff] [blame] | 1429 | SmallString<100> buf; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1430 | llvm::raw_svector_ostream os(buf); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1431 | |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1432 | const MemRegion *MR = ArgVal.getAsRegion(); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1433 | while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR)) |
| 1434 | MR = ER->getSuperRegion(); |
| 1435 | |
| 1436 | if (MR && isa<AllocaRegion>(MR)) |
| 1437 | os << "Memory allocated by alloca() should not be deallocated"; |
| 1438 | else { |
| 1439 | os << "Argument to "; |
| 1440 | if (!printAllocDeallocName(os, C, DeallocExpr)) |
| 1441 | os << "deallocator"; |
| 1442 | |
| 1443 | os << " is "; |
| 1444 | bool Summarized = MR ? SummarizeRegion(os, MR) |
| 1445 | : SummarizeValue(os, ArgVal); |
| 1446 | if (Summarized) |
| 1447 | os << ", which is not memory allocated by "; |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1448 | else |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1449 | os << "not memory allocated by "; |
| 1450 | |
| 1451 | printExpectedAllocName(os, C, DeallocExpr); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1452 | } |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1453 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1454 | BugReport *R = new BugReport(*BT_BadFree[*CheckKind], os.str(), N); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 1455 | R->markInteresting(MR); |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1456 | R->addRange(Range); |
Jordan Rose | 785950e | 2012-11-02 01:53:40 +0000 | [diff] [blame] | 1457 | C.emitReport(R); |
Jordy Rose | 43859f6 | 2010-06-07 19:32:37 +0000 | [diff] [blame] | 1458 | } |
| 1459 | } |
| 1460 | |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1461 | void MallocChecker::ReportMismatchedDealloc(CheckerContext &C, |
| 1462 | SourceRange Range, |
| 1463 | const Expr *DeallocExpr, |
Anton Yartsev | a3ae937 | 2013-04-05 11:25:10 +0000 | [diff] [blame] | 1464 | const RefState *RS, |
Anton Yartsev | 3084518 | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1465 | SymbolRef Sym, |
| 1466 | bool OwnershipTransferred) const { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1467 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1468 | if (!ChecksEnabled[CK_MismatchedDeallocatorChecker]) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1469 | return; |
| 1470 | |
| 1471 | if (ExplodedNode *N = C.generateSink()) { |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1472 | if (!BT_MismatchedDealloc) |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1473 | BT_MismatchedDealloc.reset( |
| 1474 | new BugType(CheckNames[CK_MismatchedDeallocatorChecker], |
| 1475 | "Bad deallocator", "Memory Error")); |
| 1476 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1477 | SmallString<100> buf; |
| 1478 | llvm::raw_svector_ostream os(buf); |
| 1479 | |
| 1480 | const Expr *AllocExpr = cast<Expr>(RS->getStmt()); |
| 1481 | SmallString<20> AllocBuf; |
| 1482 | llvm::raw_svector_ostream AllocOs(AllocBuf); |
| 1483 | SmallString<20> DeallocBuf; |
| 1484 | llvm::raw_svector_ostream DeallocOs(DeallocBuf); |
| 1485 | |
Anton Yartsev | 3084518 | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1486 | if (OwnershipTransferred) { |
| 1487 | if (printAllocDeallocName(DeallocOs, C, DeallocExpr)) |
| 1488 | os << DeallocOs.str() << " cannot"; |
| 1489 | else |
| 1490 | os << "Cannot"; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1491 | |
Anton Yartsev | 3084518 | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1492 | os << " take ownership of memory"; |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1493 | |
Anton Yartsev | 3084518 | 2013-09-16 17:51:25 +0000 | [diff] [blame] | 1494 | if (printAllocDeallocName(AllocOs, C, AllocExpr)) |
| 1495 | os << " allocated by " << AllocOs.str(); |
| 1496 | } else { |
| 1497 | os << "Memory"; |
| 1498 | if (printAllocDeallocName(AllocOs, C, AllocExpr)) |
| 1499 | os << " allocated by " << AllocOs.str(); |
| 1500 | |
| 1501 | os << " should be deallocated by "; |
| 1502 | printExpectedDeallocName(os, RS->getAllocationFamily()); |
| 1503 | |
| 1504 | if (printAllocDeallocName(DeallocOs, C, DeallocExpr)) |
| 1505 | os << ", not " << DeallocOs.str(); |
| 1506 | } |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1507 | |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1508 | BugReport *R = new BugReport(*BT_MismatchedDealloc, os.str(), N); |
Anton Yartsev | a3ae937 | 2013-04-05 11:25:10 +0000 | [diff] [blame] | 1509 | R->markInteresting(Sym); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1510 | R->addRange(Range); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1511 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1512 | C.emitReport(R); |
| 1513 | } |
| 1514 | } |
| 1515 | |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1516 | void MallocChecker::ReportOffsetFree(CheckerContext &C, SVal ArgVal, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1517 | SourceRange Range, const Expr *DeallocExpr, |
| 1518 | const Expr *AllocExpr) const { |
| 1519 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1520 | if (!ChecksEnabled[CK_MallocOptimistic] && |
| 1521 | !ChecksEnabled[CK_MallocPessimistic] && |
| 1522 | !ChecksEnabled[CK_NewDeleteChecker]) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1523 | return; |
| 1524 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1525 | Optional<MallocChecker::CheckKind> CheckKind = |
| 1526 | getCheckIfTracked(C, AllocExpr); |
| 1527 | if (!CheckKind.hasValue()) |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1528 | return; |
| 1529 | |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1530 | ExplodedNode *N = C.generateSink(); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1531 | if (!N) |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1532 | return; |
| 1533 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1534 | if (!BT_OffsetFree[*CheckKind]) |
| 1535 | BT_OffsetFree[*CheckKind].reset( |
| 1536 | new BugType(CheckNames[*CheckKind], "Offset free", "Memory Error")); |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1537 | |
| 1538 | SmallString<100> buf; |
| 1539 | llvm::raw_svector_ostream os(buf); |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1540 | SmallString<20> AllocNameBuf; |
| 1541 | llvm::raw_svector_ostream AllocNameOs(AllocNameBuf); |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1542 | |
| 1543 | const MemRegion *MR = ArgVal.getAsRegion(); |
| 1544 | assert(MR && "Only MemRegion based symbols can have offset free errors"); |
| 1545 | |
| 1546 | RegionOffset Offset = MR->getAsOffset(); |
| 1547 | assert((Offset.isValid() && |
| 1548 | !Offset.hasSymbolicOffset() && |
| 1549 | Offset.getOffset() != 0) && |
| 1550 | "Only symbols with a valid offset can have offset free errors"); |
| 1551 | |
| 1552 | int offsetBytes = Offset.getOffset() / C.getASTContext().getCharWidth(); |
| 1553 | |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1554 | os << "Argument to "; |
| 1555 | if (!printAllocDeallocName(os, C, DeallocExpr)) |
| 1556 | os << "deallocator"; |
| 1557 | os << " is offset by " |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1558 | << offsetBytes |
| 1559 | << " " |
| 1560 | << ((abs(offsetBytes) > 1) ? "bytes" : "byte") |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1561 | << " from the start of "; |
| 1562 | if (AllocExpr && printAllocDeallocName(AllocNameOs, C, AllocExpr)) |
| 1563 | os << "memory allocated by " << AllocNameOs.str(); |
| 1564 | else |
| 1565 | os << "allocated memory"; |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1566 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1567 | BugReport *R = new BugReport(*BT_OffsetFree[*CheckKind], os.str(), N); |
Anna Zaks | 118aa75 | 2013-02-07 23:05:47 +0000 | [diff] [blame] | 1568 | R->markInteresting(MR->getBaseRegion()); |
| 1569 | R->addRange(Range); |
| 1570 | C.emitReport(R); |
| 1571 | } |
| 1572 | |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1573 | void MallocChecker::ReportUseAfterFree(CheckerContext &C, SourceRange Range, |
| 1574 | SymbolRef Sym) const { |
| 1575 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1576 | if (!ChecksEnabled[CK_MallocOptimistic] && |
| 1577 | !ChecksEnabled[CK_MallocPessimistic] && |
| 1578 | !ChecksEnabled[CK_NewDeleteChecker]) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1579 | return; |
| 1580 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1581 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
| 1582 | if (!CheckKind.hasValue()) |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1583 | return; |
| 1584 | |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1585 | if (ExplodedNode *N = C.generateSink()) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1586 | if (!BT_UseFree[*CheckKind]) |
| 1587 | BT_UseFree[*CheckKind].reset(new BugType( |
| 1588 | CheckNames[*CheckKind], "Use-after-free", "Memory Error")); |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1589 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1590 | BugReport *R = new BugReport(*BT_UseFree[*CheckKind], |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1591 | "Use of memory after it is freed", N); |
| 1592 | |
| 1593 | R->markInteresting(Sym); |
| 1594 | R->addRange(Range); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1595 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1596 | C.emitReport(R); |
| 1597 | } |
| 1598 | } |
| 1599 | |
| 1600 | void MallocChecker::ReportDoubleFree(CheckerContext &C, SourceRange Range, |
| 1601 | bool Released, SymbolRef Sym, |
Anton Yartsev | 3258d4b | 2013-03-13 17:07:32 +0000 | [diff] [blame] | 1602 | SymbolRef PrevSym) const { |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1603 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1604 | if (!ChecksEnabled[CK_MallocOptimistic] && |
| 1605 | !ChecksEnabled[CK_MallocPessimistic] && |
| 1606 | !ChecksEnabled[CK_NewDeleteChecker]) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1607 | return; |
| 1608 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1609 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
| 1610 | if (!CheckKind.hasValue()) |
Anton Yartsev | 648cb71 | 2013-04-04 23:46:29 +0000 | [diff] [blame] | 1611 | return; |
| 1612 | |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1613 | if (ExplodedNode *N = C.generateSink()) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1614 | if (!BT_DoubleFree[*CheckKind]) |
| 1615 | BT_DoubleFree[*CheckKind].reset( |
| 1616 | new BugType(CheckNames[*CheckKind], "Double free", "Memory Error")); |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1617 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1618 | BugReport *R = |
| 1619 | new BugReport(*BT_DoubleFree[*CheckKind], |
| 1620 | (Released ? "Attempt to free released memory" |
| 1621 | : "Attempt to free non-owned memory"), |
| 1622 | N); |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1623 | R->addRange(Range); |
Anton Yartsev | 3258d4b | 2013-03-13 17:07:32 +0000 | [diff] [blame] | 1624 | R->markInteresting(Sym); |
| 1625 | if (PrevSym) |
| 1626 | R->markInteresting(PrevSym); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1627 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 1628 | C.emitReport(R); |
| 1629 | } |
| 1630 | } |
| 1631 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1632 | void MallocChecker::ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const { |
| 1633 | |
| 1634 | if (!ChecksEnabled[CK_NewDeleteChecker]) |
| 1635 | return; |
| 1636 | |
| 1637 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, Sym); |
| 1638 | if (!CheckKind.hasValue()) |
| 1639 | return; |
| 1640 | assert(*CheckKind == CK_NewDeleteChecker && "invalid check kind"); |
| 1641 | |
| 1642 | if (ExplodedNode *N = C.generateSink()) { |
| 1643 | if (!BT_DoubleDelete) |
| 1644 | BT_DoubleDelete.reset(new BugType(CheckNames[CK_NewDeleteChecker], |
| 1645 | "Double delete", "Memory Error")); |
| 1646 | |
| 1647 | BugReport *R = new BugReport(*BT_DoubleDelete, |
| 1648 | "Attempt to delete released memory", N); |
| 1649 | |
| 1650 | R->markInteresting(Sym); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1651 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym)); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1652 | C.emitReport(R); |
| 1653 | } |
| 1654 | } |
| 1655 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1656 | ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C, |
| 1657 | const CallExpr *CE, |
| 1658 | bool FreesOnFail) const { |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1659 | if (CE->getNumArgs() < 2) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1660 | return nullptr; |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1661 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1662 | ProgramStateRef state = C.getState(); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1663 | const Expr *arg0Expr = CE->getArg(0); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 1664 | const LocationContext *LCtx = C.getLocationContext(); |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1665 | SVal Arg0Val = state->getSVal(arg0Expr, LCtx); |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1666 | if (!Arg0Val.getAs<DefinedOrUnknownSVal>()) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1667 | return nullptr; |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1668 | DefinedOrUnknownSVal arg0Val = Arg0Val.castAs<DefinedOrUnknownSVal>(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1669 | |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 1670 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1671 | |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1672 | DefinedOrUnknownSVal PtrEQ = |
| 1673 | svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull()); |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1674 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 1675 | // Get the size argument. If there is no size arg then give up. |
| 1676 | const Expr *Arg1 = CE->getArg(1); |
| 1677 | if (!Arg1) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1678 | return nullptr; |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 1679 | |
| 1680 | // Get the value of the size argument. |
Anna Zaks | e9ef562 | 2012-02-10 01:11:00 +0000 | [diff] [blame] | 1681 | SVal Arg1ValG = state->getSVal(Arg1, LCtx); |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1682 | if (!Arg1ValG.getAs<DefinedOrUnknownSVal>()) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1683 | return nullptr; |
David Blaikie | 5251abe | 2013-02-20 05:52:05 +0000 | [diff] [blame] | 1684 | DefinedOrUnknownSVal Arg1Val = Arg1ValG.castAs<DefinedOrUnknownSVal>(); |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 1685 | |
| 1686 | // Compare the size argument to 0. |
| 1687 | DefinedOrUnknownSVal SizeZero = |
| 1688 | svalBuilder.evalEQ(state, Arg1Val, |
| 1689 | svalBuilder.makeIntValWithPtrWidth(0, false)); |
| 1690 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1691 | ProgramStateRef StatePtrIsNull, StatePtrNotNull; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1692 | std::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1693 | ProgramStateRef StateSizeIsZero, StateSizeNotZero; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1694 | std::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1695 | // We only assume exceptional states if they are definitely true; if the |
| 1696 | // state is under-constrained, assume regular realloc behavior. |
| 1697 | bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull; |
| 1698 | bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero; |
| 1699 | |
Lenny Maiorani | 4d8d803 | 2011-04-27 14:49:29 +0000 | [diff] [blame] | 1700 | // If the ptr is NULL and the size is not 0, the call is equivalent to |
| 1701 | // malloc(size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1702 | if ( PrtIsNull && !SizeIsZero) { |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1703 | ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1), |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1704 | UndefinedVal(), StatePtrIsNull); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1705 | return stateMalloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1706 | } |
| 1707 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1708 | if (PrtIsNull && SizeIsZero) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1709 | return nullptr; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1710 | |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 1711 | // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size). |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1712 | assert(!PrtIsNull); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 1713 | SymbolRef FromPtr = arg0Val.getAsSymbol(); |
| 1714 | SVal RetVal = state->getSVal(CE, LCtx); |
| 1715 | SymbolRef ToPtr = RetVal.getAsSymbol(); |
| 1716 | if (!FromPtr || !ToPtr) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1717 | return nullptr; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1718 | |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1719 | bool ReleasedAllocated = false; |
| 1720 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1721 | // If the size is 0, free the memory. |
| 1722 | if (SizeIsZero) |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1723 | if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0, |
| 1724 | false, ReleasedAllocated)){ |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1725 | // The semantics of the return value are: |
| 1726 | // If size was equal to 0, either NULL or a pointer suitable to be passed |
Anna Zaks | ede875b | 2012-08-03 18:30:18 +0000 | [diff] [blame] | 1727 | // to free() is returned. We just free the input pointer and do not add |
| 1728 | // any constrains on the output pointer. |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1729 | return stateFree; |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1730 | } |
| 1731 | |
| 1732 | // Default behavior. |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1733 | if (ProgramStateRef stateFree = |
| 1734 | FreeMemAux(C, CE, state, 0, false, ReleasedAllocated)) { |
| 1735 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1736 | ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1), |
| 1737 | UnknownVal(), stateFree); |
Anna Zaks | 30838b9 | 2012-02-13 20:57:07 +0000 | [diff] [blame] | 1738 | if (!stateRealloc) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1739 | return nullptr; |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1740 | |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 1741 | ReallocPairKind Kind = RPToBeFreedAfterFailure; |
| 1742 | if (FreesOnFail) |
| 1743 | Kind = RPIsFreeOnFailure; |
| 1744 | else if (!ReleasedAllocated) |
| 1745 | Kind = RPDoNotTrackAfterFailure; |
| 1746 | |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1747 | // Record the info about the reallocated symbol so that we could properly |
| 1748 | // process failed reallocation. |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1749 | stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr, |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 1750 | ReallocPair(FromPtr, Kind)); |
Anna Zaks | 55dd956 | 2012-08-24 02:28:20 +0000 | [diff] [blame] | 1751 | // The reallocated symbol should stay alive for as long as the new symbol. |
Anna Zaks | b276bd9 | 2012-02-14 00:26:13 +0000 | [diff] [blame] | 1752 | C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr); |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1753 | return stateRealloc; |
Zhongxing Xu | d9c84c8 | 2009-12-12 12:29:38 +0000 | [diff] [blame] | 1754 | } |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1755 | return nullptr; |
Zhongxing Xu | 589c0f2 | 2009-11-12 08:38:56 +0000 | [diff] [blame] | 1756 | } |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 1757 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1758 | ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){ |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1759 | if (CE->getNumArgs() < 2) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1760 | return nullptr; |
Anna Zaks | 259052d | 2012-04-10 23:41:11 +0000 | [diff] [blame] | 1761 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1762 | ProgramStateRef state = C.getState(); |
Ted Kremenek | 846eabd | 2010-12-01 21:28:31 +0000 | [diff] [blame] | 1763 | SValBuilder &svalBuilder = C.getSValBuilder(); |
Ted Kremenek | 5eca482 | 2012-01-06 22:09:28 +0000 | [diff] [blame] | 1764 | const LocationContext *LCtx = C.getLocationContext(); |
| 1765 | SVal count = state->getSVal(CE->getArg(0), LCtx); |
| 1766 | SVal elementSize = state->getSVal(CE->getArg(1), LCtx); |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1767 | SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize, |
| 1768 | svalBuilder.getContext().getSizeType()); |
| 1769 | SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 1770 | |
Anna Zaks | 87cb5be | 2012-02-22 19:24:52 +0000 | [diff] [blame] | 1771 | return MallocMemAux(C, CE, TotalSize, zeroVal, state); |
Zhongxing Xu | a5ce966 | 2010-06-01 03:01:33 +0000 | [diff] [blame] | 1772 | } |
| 1773 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 1774 | LeakInfo |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1775 | MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym, |
| 1776 | CheckerContext &C) const { |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 1777 | const LocationContext *LeakContext = N->getLocationContext(); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1778 | // Walk the ExplodedGraph backwards and find the first node that referred to |
| 1779 | // the tracked symbol. |
| 1780 | const ExplodedNode *AllocNode = N; |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1781 | const MemRegion *ReferenceRegion = nullptr; |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1782 | |
| 1783 | while (N) { |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 1784 | ProgramStateRef State = N->getState(); |
| 1785 | if (!State->get<RegionState>(Sym)) |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1786 | break; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 1787 | |
| 1788 | // Find the most recent expression bound to the symbol in the current |
| 1789 | // context. |
Anna Zaks | 27d99dd | 2013-04-10 21:42:02 +0000 | [diff] [blame] | 1790 | if (!ReferenceRegion) { |
| 1791 | if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) { |
| 1792 | SVal Val = State->getSVal(MR); |
| 1793 | if (Val.getAsLocSymbol() == Sym) { |
Anna Zaks | 8cf91f7 | 2013-04-10 22:56:33 +0000 | [diff] [blame] | 1794 | const VarRegion* VR = MR->getBaseRegion()->getAs<VarRegion>(); |
Anna Zaks | 27d99dd | 2013-04-10 21:42:02 +0000 | [diff] [blame] | 1795 | // Do not show local variables belonging to a function other than |
| 1796 | // where the error is reported. |
| 1797 | if (!VR || |
| 1798 | (VR->getStackFrame() == LeakContext->getCurrentStackFrame())) |
| 1799 | ReferenceRegion = MR; |
| 1800 | } |
| 1801 | } |
Benjamin Kramer | 850f1b1 | 2012-03-21 21:03:48 +0000 | [diff] [blame] | 1802 | } |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 1803 | |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 1804 | // Allocation node, is the last node in the current context in which the |
| 1805 | // symbol was tracked. |
| 1806 | if (N->getLocationContext() == LeakContext) |
| 1807 | AllocNode = N; |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1808 | N = N->pred_empty() ? nullptr : *(N->pred_begin()); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1809 | } |
| 1810 | |
Anna Zaks | 97bfb55 | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 1811 | return LeakInfo(AllocNode, ReferenceRegion); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1812 | } |
| 1813 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 1814 | void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N, |
| 1815 | CheckerContext &C) const { |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1816 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1817 | if (!ChecksEnabled[CK_MallocOptimistic] && |
| 1818 | !ChecksEnabled[CK_MallocPessimistic] && |
| 1819 | !ChecksEnabled[CK_NewDeleteLeaksChecker]) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 1820 | return; |
| 1821 | |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 1822 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
| 1823 | assert(RS && "cannot leak an untracked symbol"); |
| 1824 | AllocationFamily Family = RS->getAllocationFamily(); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1825 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(Family); |
| 1826 | if (!CheckKind.hasValue()) |
Anton Yartsev | 418780f | 2013-04-05 02:25:02 +0000 | [diff] [blame] | 1827 | return; |
| 1828 | |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 1829 | // Special case for new and new[]; these are controlled by a separate checker |
| 1830 | // flag so that they can be selectively disabled. |
| 1831 | if (Family == AF_CXXNew || Family == AF_CXXNewArray) |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1832 | if (!ChecksEnabled[CK_NewDeleteLeaksChecker]) |
Jordan Rose | e85deb3 | 2013-04-05 17:55:00 +0000 | [diff] [blame] | 1833 | return; |
| 1834 | |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 1835 | assert(N); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1836 | if (!BT_Leak[*CheckKind]) { |
| 1837 | BT_Leak[*CheckKind].reset( |
| 1838 | new BugType(CheckNames[*CheckKind], "Memory leak", "Memory Error")); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 1839 | // Leaks should not be reported if they are post-dominated by a sink: |
| 1840 | // (1) Sinks are higher importance bugs. |
| 1841 | // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending |
| 1842 | // with __noreturn functions such as assert() or exit(). We choose not |
| 1843 | // to report leaks on such paths. |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1844 | BT_Leak[*CheckKind]->setSuppressOnSink(true); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 1845 | } |
| 1846 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1847 | // Most bug reports are cached at the location where they occurred. |
| 1848 | // With leaks, we want to unique them by the location where they were |
| 1849 | // allocated, and only report a single path. |
Anna Zaks | 7752d29 | 2012-02-27 23:40:55 +0000 | [diff] [blame] | 1850 | PathDiagnosticLocation LocUsedForUniqueing; |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1851 | const ExplodedNode *AllocNode = nullptr; |
| 1852 | const MemRegion *Region = nullptr; |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1853 | std::tie(AllocNode, Region) = getAllocationSite(N, Sym, C); |
Anna Zaks | 97bfb55 | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 1854 | |
| 1855 | ProgramPoint P = AllocNode->getLocation(); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 1856 | const Stmt *AllocationStmt = nullptr; |
David Blaikie | 7a95de6 | 2013-02-21 22:23:56 +0000 | [diff] [blame] | 1857 | if (Optional<CallExitEnd> Exit = P.getAs<CallExitEnd>()) |
Anna Zaks | 97bfb55 | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 1858 | AllocationStmt = Exit->getCalleeContext()->getCallSite(); |
David Blaikie | 7a95de6 | 2013-02-21 22:23:56 +0000 | [diff] [blame] | 1859 | else if (Optional<StmtPoint> SP = P.getAs<StmtPoint>()) |
Anna Zaks | 97bfb55 | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 1860 | AllocationStmt = SP->getStmt(); |
Anton Yartsev | 418780f | 2013-04-05 02:25:02 +0000 | [diff] [blame] | 1861 | if (AllocationStmt) |
Anna Zaks | 97bfb55 | 2013-01-08 00:25:29 +0000 | [diff] [blame] | 1862 | LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocationStmt, |
| 1863 | C.getSourceManager(), |
| 1864 | AllocNode->getLocationContext()); |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1865 | |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 1866 | SmallString<200> buf; |
| 1867 | llvm::raw_svector_ostream os(buf); |
Jordan Rose | 919e8a1 | 2012-08-08 18:23:36 +0000 | [diff] [blame] | 1868 | if (Region && Region->canPrintPretty()) { |
Anna Zaks | 9e2f597 | 2013-04-12 18:40:21 +0000 | [diff] [blame] | 1869 | os << "Potential leak of memory pointed to by "; |
Jordan Rose | 919e8a1 | 2012-08-08 18:23:36 +0000 | [diff] [blame] | 1870 | Region->printPretty(os); |
Anna Zaks | 68eb4c2 | 2013-04-06 00:41:36 +0000 | [diff] [blame] | 1871 | } else { |
| 1872 | os << "Potential memory leak"; |
Anna Zaks | 3d7c44e | 2012-03-21 19:45:08 +0000 | [diff] [blame] | 1873 | } |
| 1874 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1875 | BugReport *R = |
| 1876 | new BugReport(*BT_Leak[*CheckKind], os.str(), N, LocUsedForUniqueing, |
| 1877 | AllocNode->getLocationContext()->getDecl()); |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 1878 | R->markInteresting(Sym); |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1879 | R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym, true)); |
Jordan Rose | 785950e | 2012-11-02 01:53:40 +0000 | [diff] [blame] | 1880 | C.emitReport(R); |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 1881 | } |
| 1882 | |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 1883 | void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper, |
| 1884 | CheckerContext &C) const |
Ted Kremenek | c8413fd | 2010-12-02 07:49:45 +0000 | [diff] [blame] | 1885 | { |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 1886 | if (!SymReaper.hasDeadSymbols()) |
| 1887 | return; |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 1888 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 1889 | ProgramStateRef state = C.getState(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 1890 | RegionStateTy RS = state->get<RegionState>(); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 1891 | RegionStateTy::Factory &F = state->get_context<RegionState>(); |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 1892 | |
Dmitri Gribenko | cfa88f8 | 2013-01-12 19:30:44 +0000 | [diff] [blame] | 1893 | SmallVector<SymbolRef, 2> Errors; |
Zhongxing Xu | 173ff56 | 2010-08-15 08:19:57 +0000 | [diff] [blame] | 1894 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
| 1895 | if (SymReaper.isDead(I->first)) { |
Anna Zaks | 5445870 | 2012-10-29 22:51:54 +0000 | [diff] [blame] | 1896 | if (I->second.isAllocated()) |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 1897 | Errors.push_back(I->first); |
Jordy Rose | 9076014 | 2010-08-18 04:33:47 +0000 | [diff] [blame] | 1898 | // Remove the dead symbol from the map. |
Ted Kremenek | 3baf672 | 2010-11-24 00:54:37 +0000 | [diff] [blame] | 1899 | RS = F.remove(RS, I->first); |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 1900 | |
Zhongxing Xu | fc7ac8f | 2009-11-13 07:48:11 +0000 | [diff] [blame] | 1901 | } |
| 1902 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 1903 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1904 | // Cleanup the Realloc Pairs Map. |
Jordan Rose | 166d502 | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 1905 | ReallocPairsTy RP = state->get<ReallocPairs>(); |
| 1906 | for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 1907 | if (SymReaper.isDead(I->first) || |
| 1908 | SymReaper.isDead(I->second.ReallocatedSym)) { |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 1909 | state = state->remove<ReallocPairs>(I->first); |
| 1910 | } |
| 1911 | } |
| 1912 | |
Anna Zaks | 4141e4d | 2012-11-13 03:18:01 +0000 | [diff] [blame] | 1913 | // Cleanup the FreeReturnValue Map. |
| 1914 | FreeReturnValueTy FR = state->get<FreeReturnValue>(); |
| 1915 | for (FreeReturnValueTy::iterator I = FR.begin(), E = FR.end(); I != E; ++I) { |
| 1916 | if (SymReaper.isDead(I->first) || |
| 1917 | SymReaper.isDead(I->second)) { |
| 1918 | state = state->remove<FreeReturnValue>(I->first); |
| 1919 | } |
| 1920 | } |
| 1921 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1922 | // Generate leak node. |
Anna Zaks | 5445870 | 2012-10-29 22:51:54 +0000 | [diff] [blame] | 1923 | ExplodedNode *N = C.getPredecessor(); |
| 1924 | if (!Errors.empty()) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1925 | static CheckerProgramPointTag Tag("MallocChecker", "DeadSymbolsLeak"); |
Anna Zaks | 5445870 | 2012-10-29 22:51:54 +0000 | [diff] [blame] | 1926 | N = C.addTransition(C.getState(), C.getPredecessor(), &Tag); |
Craig Topper | 09d19ef | 2013-07-04 03:08:24 +0000 | [diff] [blame] | 1927 | for (SmallVectorImpl<SymbolRef>::iterator |
| 1928 | I = Errors.begin(), E = Errors.end(); I != E; ++I) { |
Anna Zaks | da04677 | 2012-02-11 21:02:40 +0000 | [diff] [blame] | 1929 | reportLeak(*I, N, C); |
Anna Zaks | f8c17b7 | 2012-02-09 06:48:19 +0000 | [diff] [blame] | 1930 | } |
Ted Kremenek | 217470e | 2011-07-28 23:07:51 +0000 | [diff] [blame] | 1931 | } |
Anna Zaks | 5445870 | 2012-10-29 22:51:54 +0000 | [diff] [blame] | 1932 | |
Anna Zaks | ca8e36e | 2012-02-23 21:38:21 +0000 | [diff] [blame] | 1933 | C.addTransition(state->set<RegionState>(RS), N); |
Zhongxing Xu | 7b76096 | 2009-11-13 07:25:27 +0000 | [diff] [blame] | 1934 | } |
Zhongxing Xu | 243fde9 | 2009-11-17 07:54:15 +0000 | [diff] [blame] | 1935 | |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 1936 | void MallocChecker::checkPreCall(const CallEvent &Call, |
| 1937 | CheckerContext &C) const { |
| 1938 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1939 | if (const CXXDestructorCall *DC = dyn_cast<CXXDestructorCall>(&Call)) { |
| 1940 | SymbolRef Sym = DC->getCXXThisVal().getAsSymbol(); |
| 1941 | if (!Sym || checkDoubleDelete(Sym, C)) |
| 1942 | return; |
| 1943 | } |
| 1944 | |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 1945 | // We will check for double free in the post visit. |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 1946 | if (const AnyFunctionCall *FC = dyn_cast<AnyFunctionCall>(&Call)) { |
| 1947 | const FunctionDecl *FD = FC->getDecl(); |
| 1948 | if (!FD) |
| 1949 | return; |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 1950 | |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1951 | ASTContext &Ctx = C.getASTContext(); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1952 | if ((ChecksEnabled[CK_MallocOptimistic] || |
| 1953 | ChecksEnabled[CK_MallocPessimistic]) && |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1954 | (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Free) || |
| 1955 | isCMemFunction(FD, Ctx, AF_IfNameIndex, |
| 1956 | MemoryOperationKind::MOK_Free))) |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 1957 | return; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1958 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 1959 | if (ChecksEnabled[CK_NewDeleteChecker] && |
Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame^] | 1960 | isStandardNewDelete(FD, Ctx)) |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 1961 | return; |
| 1962 | } |
| 1963 | |
| 1964 | // Check if the callee of a method is deleted. |
| 1965 | if (const CXXInstanceCall *CC = dyn_cast<CXXInstanceCall>(&Call)) { |
| 1966 | SymbolRef Sym = CC->getCXXThisVal().getAsSymbol(); |
| 1967 | if (!Sym || checkUseAfterFree(Sym, C, CC->getCXXThisExpr())) |
| 1968 | return; |
| 1969 | } |
| 1970 | |
| 1971 | // Check arguments for being used after free. |
| 1972 | for (unsigned I = 0, E = Call.getNumArgs(); I != E; ++I) { |
| 1973 | SVal ArgSVal = Call.getArgSVal(I); |
| 1974 | if (ArgSVal.getAs<Loc>()) { |
| 1975 | SymbolRef Sym = ArgSVal.getAsSymbol(); |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1976 | if (!Sym) |
| 1977 | continue; |
Anton Yartsev | 55e57a5 | 2013-04-10 22:21:41 +0000 | [diff] [blame] | 1978 | if (checkUseAfterFree(Sym, C, Call.getArgExpr(I))) |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 1979 | return; |
| 1980 | } |
| 1981 | } |
| 1982 | } |
| 1983 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 1984 | void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const { |
| 1985 | const Expr *E = S->getRetValue(); |
| 1986 | if (!E) |
| 1987 | return; |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 1988 | |
| 1989 | // Check if we are returning a symbol. |
Jordan Rose | 0d53ab4 | 2012-08-08 18:23:31 +0000 | [diff] [blame] | 1990 | ProgramStateRef State = C.getState(); |
| 1991 | SVal RetVal = State->getSVal(E, C.getLocationContext()); |
Anna Zaks | d9ab7bb | 2012-02-22 02:36:01 +0000 | [diff] [blame] | 1992 | SymbolRef Sym = RetVal.getAsSymbol(); |
| 1993 | if (!Sym) |
| 1994 | // If we are returning a field of the allocated struct or an array element, |
| 1995 | // the callee could still free the memory. |
| 1996 | // TODO: This logic should be a part of generic symbol escape callback. |
| 1997 | if (const MemRegion *MR = RetVal.getAsRegion()) |
| 1998 | if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR)) |
| 1999 | if (const SymbolicRegion *BMR = |
| 2000 | dyn_cast<SymbolicRegion>(MR->getBaseRegion())) |
| 2001 | Sym = BMR->getSymbol(); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 2002 | |
Anna Zaks | 0860cd0 | 2012-02-11 21:44:39 +0000 | [diff] [blame] | 2003 | // Check if we are returning freed memory. |
Jordan Rose | 0d53ab4 | 2012-08-08 18:23:31 +0000 | [diff] [blame] | 2004 | if (Sym) |
Jordan Rose | 65d4bd6 | 2012-11-15 19:11:33 +0000 | [diff] [blame] | 2005 | checkUseAfterFree(Sym, C, E); |
Zhongxing Xu | 4985e3e | 2009-11-17 08:58:18 +0000 | [diff] [blame] | 2006 | } |
Zhongxing Xu | b94b81a | 2009-12-31 06:13:07 +0000 | [diff] [blame] | 2007 | |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 2008 | // TODO: Blocks should be either inlined or should call invalidate regions |
| 2009 | // upon invocation. After that's in place, special casing here will not be |
| 2010 | // needed. |
| 2011 | void MallocChecker::checkPostStmt(const BlockExpr *BE, |
| 2012 | CheckerContext &C) const { |
| 2013 | |
| 2014 | // Scan the BlockDecRefExprs for any object the retain count checker |
| 2015 | // may be tracking. |
| 2016 | if (!BE->getBlockDecl()->hasCaptures()) |
| 2017 | return; |
| 2018 | |
| 2019 | ProgramStateRef state = C.getState(); |
| 2020 | const BlockDataRegion *R = |
| 2021 | cast<BlockDataRegion>(state->getSVal(BE, |
| 2022 | C.getLocationContext()).getAsRegion()); |
| 2023 | |
| 2024 | BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(), |
| 2025 | E = R->referenced_vars_end(); |
| 2026 | |
| 2027 | if (I == E) |
| 2028 | return; |
| 2029 | |
| 2030 | SmallVector<const MemRegion*, 10> Regions; |
| 2031 | const LocationContext *LC = C.getLocationContext(); |
| 2032 | MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager(); |
| 2033 | |
| 2034 | for ( ; I != E; ++I) { |
Ted Kremenek | e3ce2c1 | 2012-12-06 07:17:20 +0000 | [diff] [blame] | 2035 | const VarRegion *VR = I.getCapturedRegion(); |
Anna Zaks | f5aa3f5 | 2012-03-22 00:57:20 +0000 | [diff] [blame] | 2036 | if (VR->getSuperRegion() == R) { |
| 2037 | VR = MemMgr.getVarRegion(VR->getDecl(), LC); |
| 2038 | } |
| 2039 | Regions.push_back(VR); |
| 2040 | } |
| 2041 | |
| 2042 | state = |
| 2043 | state->scanReachableSymbols<StopTrackingCallback>(Regions.data(), |
| 2044 | Regions.data() + Regions.size()).getState(); |
| 2045 | C.addTransition(state); |
| 2046 | } |
| 2047 | |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2048 | bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2049 | assert(Sym); |
| 2050 | const RefState *RS = C.getState()->get<RegionState>(Sym); |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2051 | return (RS && RS->isReleased()); |
| 2052 | } |
| 2053 | |
| 2054 | bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C, |
| 2055 | const Stmt *S) const { |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2056 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2057 | if (isReleased(Sym, C)) { |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 2058 | ReportUseAfterFree(C, S->getSourceRange(), Sym); |
| 2059 | return true; |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2060 | } |
Anton Yartsev | bb36995 | 2013-03-13 14:39:10 +0000 | [diff] [blame] | 2061 | |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2062 | return false; |
| 2063 | } |
| 2064 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2065 | bool MallocChecker::checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const { |
| 2066 | |
| 2067 | if (isReleased(Sym, C)) { |
| 2068 | ReportDoubleDelete(C, Sym); |
| 2069 | return true; |
| 2070 | } |
| 2071 | return false; |
| 2072 | } |
| 2073 | |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 2074 | // Check if the location is a freed symbolic region. |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 2075 | void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S, |
| 2076 | CheckerContext &C) const { |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 2077 | SymbolRef Sym = l.getLocSymbolInBase(); |
Anna Zaks | 91c2a11 | 2012-02-08 23:16:56 +0000 | [diff] [blame] | 2078 | if (Sym) |
Anna Zaks | 1434518 | 2012-05-18 01:16:10 +0000 | [diff] [blame] | 2079 | checkUseAfterFree(Sym, C, S); |
Zhongxing Xu | c802378 | 2010-03-10 04:58:55 +0000 | [diff] [blame] | 2080 | } |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 2081 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2082 | // If a symbolic region is assumed to NULL (or another constant), stop tracking |
| 2083 | // it - assuming that allocation failed on this path. |
| 2084 | ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state, |
| 2085 | SVal Cond, |
| 2086 | bool Assumption) const { |
| 2087 | RegionStateTy RS = state->get<RegionState>(); |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2088 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
Ted Kremenek | 47cbd0f | 2012-09-07 22:31:01 +0000 | [diff] [blame] | 2089 | // If the symbol is assumed to be NULL, remove it from consideration. |
Jordan Rose | ec8d420 | 2012-11-01 00:18:27 +0000 | [diff] [blame] | 2090 | ConstraintManager &CMgr = state->getConstraintManager(); |
| 2091 | ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey()); |
| 2092 | if (AllocFailed.isConstrainedTrue()) |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2093 | state = state->remove<RegionState>(I.getKey()); |
| 2094 | } |
| 2095 | |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2096 | // Realloc returns 0 when reallocation fails, which means that we should |
| 2097 | // restore the state of the pointer being reallocated. |
Jordan Rose | 166d502 | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2098 | ReallocPairsTy RP = state->get<ReallocPairs>(); |
| 2099 | for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) { |
Ted Kremenek | 47cbd0f | 2012-09-07 22:31:01 +0000 | [diff] [blame] | 2100 | // If the symbol is assumed to be NULL, remove it from consideration. |
Jordan Rose | ec8d420 | 2012-11-01 00:18:27 +0000 | [diff] [blame] | 2101 | ConstraintManager &CMgr = state->getConstraintManager(); |
| 2102 | ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey()); |
Jordan Rose | 79a29eb | 2012-11-01 00:25:15 +0000 | [diff] [blame] | 2103 | if (!AllocFailed.isConstrainedTrue()) |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2104 | continue; |
Jordan Rose | ec8d420 | 2012-11-01 00:18:27 +0000 | [diff] [blame] | 2105 | |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2106 | SymbolRef ReallocSym = I.getData().ReallocatedSym; |
| 2107 | if (const RefState *RS = state->get<RegionState>(ReallocSym)) { |
| 2108 | if (RS->isReleased()) { |
| 2109 | if (I.getData().Kind == RPToBeFreedAfterFailure) |
Anna Zaks | 40add29 | 2012-02-15 00:11:25 +0000 | [diff] [blame] | 2110 | state = state->set<RegionState>(ReallocSym, |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 2111 | RefState::getAllocated(RS->getAllocationFamily(), RS->getStmt())); |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2112 | else if (I.getData().Kind == RPDoNotTrackAfterFailure) |
| 2113 | state = state->remove<RegionState>(ReallocSym); |
| 2114 | else |
| 2115 | assert(I.getData().Kind == RPIsFreeOnFailure); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2116 | } |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2117 | } |
Anna Zaks | 9dc298b | 2012-09-12 22:57:34 +0000 | [diff] [blame] | 2118 | state = state->remove<ReallocPairs>(I.getKey()); |
Anna Zaks | c8bb3be | 2012-02-13 18:05:39 +0000 | [diff] [blame] | 2119 | } |
| 2120 | |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2121 | return state; |
| 2122 | } |
| 2123 | |
Anna Zaks | 3370859 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 2124 | bool MallocChecker::mayFreeAnyEscapedMemoryOrIsModeledExplicitly( |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2125 | const CallEvent *Call, |
| 2126 | ProgramStateRef State, |
| 2127 | SymbolRef &EscapingSymbol) const { |
Jordan Rose | 85d7e01 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2128 | assert(Call); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2129 | EscapingSymbol = nullptr; |
| 2130 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2131 | // For now, assume that any C++ or block call can free memory. |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2132 | // TODO: If we want to be more optimistic here, we'll need to make sure that |
| 2133 | // regions escape to C++ containers. They seem to do that even now, but for |
| 2134 | // mysterious reasons. |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2135 | if (!(isa<SimpleFunctionCall>(Call) || isa<ObjCMethodCall>(Call))) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2136 | return true; |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2137 | |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2138 | // Check Objective-C messages by selector name. |
Jordan Rose | cde8cdb | 2012-07-02 19:27:56 +0000 | [diff] [blame] | 2139 | if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) { |
Jordan Rose | 85d7e01 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2140 | // If it's not a framework call, or if it takes a callback, assume it |
| 2141 | // can free memory. |
| 2142 | if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg()) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2143 | return true; |
Anna Zaks | 07d39a4 | 2012-02-28 01:54:22 +0000 | [diff] [blame] | 2144 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2145 | // If it's a method we know about, handle it explicitly post-call. |
| 2146 | // This should happen before the "freeWhenDone" check below. |
| 2147 | if (isKnownDeallocObjCMethodName(*Msg)) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2148 | return false; |
Anna Zaks | 52a0481 | 2012-06-20 23:35:57 +0000 | [diff] [blame] | 2149 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2150 | // If there's a "freeWhenDone" parameter, but the method isn't one we know |
| 2151 | // about, we can't be sure that the object will use free() to deallocate the |
| 2152 | // memory, so we can't model it explicitly. The best we can do is use it to |
| 2153 | // decide whether the pointer escapes. |
| 2154 | if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(*Msg)) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2155 | return *FreeWhenDone; |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2156 | |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2157 | // If the first selector piece ends with "NoCopy", and there is no |
| 2158 | // "freeWhenDone" parameter set to zero, we know ownership is being |
| 2159 | // transferred. Again, though, we can't be sure that the object will use |
| 2160 | // free() to deallocate the memory, so we can't model it explicitly. |
| 2161 | StringRef FirstSlot = Msg->getSelector().getNameForSlot(0); |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2162 | if (FirstSlot.endswith("NoCopy")) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2163 | return true; |
Anna Zaks | fb7f76f | 2012-03-05 17:42:10 +0000 | [diff] [blame] | 2164 | |
Anna Zaks | 5f75768 | 2012-06-19 05:10:32 +0000 | [diff] [blame] | 2165 | // If the first selector starts with addPointer, insertPointer, |
| 2166 | // or replacePointer, assume we are dealing with NSPointerArray or similar. |
| 2167 | // This is similar to C++ containers (vector); we still might want to check |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2168 | // that the pointers get freed by following the container itself. |
| 2169 | if (FirstSlot.startswith("addPointer") || |
| 2170 | FirstSlot.startswith("insertPointer") || |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2171 | FirstSlot.startswith("replacePointer") || |
| 2172 | FirstSlot.equals("valueWithPointer")) { |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2173 | return true; |
Anna Zaks | 5f75768 | 2012-06-19 05:10:32 +0000 | [diff] [blame] | 2174 | } |
| 2175 | |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2176 | // We should escape receiver on call to 'init'. This is especially relevant |
| 2177 | // to the receiver, as the corresponding symbol is usually not referenced |
| 2178 | // after the call. |
| 2179 | if (Msg->getMethodFamily() == OMF_init) { |
| 2180 | EscapingSymbol = Msg->getReceiverSVal().getAsSymbol(); |
| 2181 | return true; |
| 2182 | } |
Anna Zaks | ee1af23 | 2013-05-31 22:39:13 +0000 | [diff] [blame] | 2183 | |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2184 | // Otherwise, assume that the method does not free memory. |
| 2185 | // Most framework methods do not free memory. |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2186 | return false; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2187 | } |
| 2188 | |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2189 | // At this point the only thing left to handle is straight function calls. |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2190 | const FunctionDecl *FD = cast<SimpleFunctionCall>(Call)->getDecl(); |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2191 | if (!FD) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2192 | return true; |
Anna Zaks | 3cd89ad | 2012-02-24 23:56:53 +0000 | [diff] [blame] | 2193 | |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2194 | ASTContext &ASTC = State->getStateManager().getContext(); |
| 2195 | |
| 2196 | // If it's one of the allocation functions we can reason about, we model |
| 2197 | // its behavior explicitly. |
| 2198 | if (isMemFunction(FD, ASTC)) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2199 | return false; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2200 | |
| 2201 | // If it's not a system call, assume it frees memory. |
| 2202 | if (!Call->isInSystemHeader()) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2203 | return true; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2204 | |
| 2205 | // White list the system functions whose arguments escape. |
| 2206 | const IdentifierInfo *II = FD->getIdentifier(); |
| 2207 | if (!II) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2208 | return true; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2209 | StringRef FName = II->getName(); |
| 2210 | |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2211 | // White list the 'XXXNoCopy' CoreFoundation functions. |
Jordan Rose | 85d7e01 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2212 | // We specifically check these before |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2213 | if (FName.endswith("NoCopy")) { |
| 2214 | // Look for the deallocator argument. We know that the memory ownership |
| 2215 | // is not transferred only if the deallocator argument is |
| 2216 | // 'kCFAllocatorNull'. |
| 2217 | for (unsigned i = 1; i < Call->getNumArgs(); ++i) { |
| 2218 | const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts(); |
| 2219 | if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) { |
| 2220 | StringRef DeallocatorName = DE->getFoundDecl()->getName(); |
| 2221 | if (DeallocatorName == "kCFAllocatorNull") |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2222 | return false; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2223 | } |
| 2224 | } |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2225 | return true; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2226 | } |
| 2227 | |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2228 | // Associating streams with malloced buffers. The pointer can escape if |
Jordan Rose | 85d7e01 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2229 | // 'closefn' is specified (and if that function does free memory), |
| 2230 | // but it will not if closefn is not specified. |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2231 | // Currently, we do not inspect the 'closefn' function (PR12101). |
| 2232 | if (FName == "funopen") |
Jordan Rose | 85d7e01 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2233 | if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0)) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2234 | return false; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2235 | |
| 2236 | // Do not warn on pointers passed to 'setbuf' when used with std streams, |
| 2237 | // these leaks might be intentional when setting the buffer for stdio. |
| 2238 | // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer |
| 2239 | if (FName == "setbuf" || FName =="setbuffer" || |
| 2240 | FName == "setlinebuf" || FName == "setvbuf") { |
| 2241 | if (Call->getNumArgs() >= 1) { |
| 2242 | const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts(); |
| 2243 | if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE)) |
| 2244 | if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl())) |
| 2245 | if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2246 | return true; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2247 | } |
| 2248 | } |
| 2249 | |
| 2250 | // A bunch of other functions which either take ownership of a pointer or |
| 2251 | // wrap the result up in a struct or object, meaning it can be freed later. |
| 2252 | // (See RetainCountChecker.) Not all the parameters here are invalidated, |
| 2253 | // but the Malloc checker cannot differentiate between them. The right way |
| 2254 | // of doing this would be to implement a pointer escapes callback. |
| 2255 | if (FName == "CGBitmapContextCreate" || |
| 2256 | FName == "CGBitmapContextCreateWithData" || |
| 2257 | FName == "CVPixelBufferCreateWithBytes" || |
| 2258 | FName == "CVPixelBufferCreateWithPlanarBytes" || |
| 2259 | FName == "OSAtomicEnqueue") { |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2260 | return true; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2261 | } |
| 2262 | |
Jordan Rose | 85d7e01 | 2012-07-02 19:27:51 +0000 | [diff] [blame] | 2263 | // Handle cases where we know a buffer's /address/ can escape. |
| 2264 | // Note that the above checks handle some special cases where we know that |
| 2265 | // even though the address escapes, it's still our responsibility to free the |
| 2266 | // buffer. |
| 2267 | if (Call->argumentsMayEscape()) |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2268 | return true; |
Jordan Rose | 740d490 | 2012-07-02 19:27:35 +0000 | [diff] [blame] | 2269 | |
| 2270 | // Otherwise, assume that the function does not free memory. |
| 2271 | // Most system calls do not free the memory. |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2272 | return false; |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2273 | } |
| 2274 | |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 2275 | static bool retTrue(const RefState *RS) { |
| 2276 | return true; |
| 2277 | } |
| 2278 | |
| 2279 | static bool checkIfNewOrNewArrayFamily(const RefState *RS) { |
| 2280 | return (RS->getAllocationFamily() == AF_CXXNewArray || |
| 2281 | RS->getAllocationFamily() == AF_CXXNew); |
| 2282 | } |
| 2283 | |
Anna Zaks | bf53dfa | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 2284 | ProgramStateRef MallocChecker::checkPointerEscape(ProgramStateRef State, |
| 2285 | const InvalidatedSymbols &Escaped, |
Anna Zaks | 233e26a | 2013-02-07 23:05:43 +0000 | [diff] [blame] | 2286 | const CallEvent *Call, |
| 2287 | PointerEscapeKind Kind) const { |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 2288 | return checkPointerEscapeAux(State, Escaped, Call, Kind, &retTrue); |
| 2289 | } |
| 2290 | |
| 2291 | ProgramStateRef MallocChecker::checkConstPointerEscape(ProgramStateRef State, |
| 2292 | const InvalidatedSymbols &Escaped, |
| 2293 | const CallEvent *Call, |
| 2294 | PointerEscapeKind Kind) const { |
| 2295 | return checkPointerEscapeAux(State, Escaped, Call, Kind, |
| 2296 | &checkIfNewOrNewArrayFamily); |
| 2297 | } |
| 2298 | |
| 2299 | ProgramStateRef MallocChecker::checkPointerEscapeAux(ProgramStateRef State, |
| 2300 | const InvalidatedSymbols &Escaped, |
| 2301 | const CallEvent *Call, |
| 2302 | PointerEscapeKind Kind, |
| 2303 | bool(*CheckRefState)(const RefState*)) const { |
Jordan Rose | 9fe09f3 | 2013-03-09 00:59:10 +0000 | [diff] [blame] | 2304 | // If we know that the call does not free memory, or we want to process the |
| 2305 | // call later, keep tracking the top level arguments. |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2306 | SymbolRef EscapingSymbol = nullptr; |
Jordan Rose | 374ae32 | 2013-05-10 17:07:16 +0000 | [diff] [blame] | 2307 | if (Kind == PSK_DirectEscapeOnCall && |
Anna Zaks | 3370859 | 2013-06-08 00:29:29 +0000 | [diff] [blame] | 2308 | !mayFreeAnyEscapedMemoryOrIsModeledExplicitly(Call, State, |
| 2309 | EscapingSymbol) && |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2310 | !EscapingSymbol) { |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2311 | return State; |
Anna Zaks | 233e26a | 2013-02-07 23:05:43 +0000 | [diff] [blame] | 2312 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2313 | |
Anna Zaks | bf53dfa | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 2314 | for (InvalidatedSymbols::const_iterator I = Escaped.begin(), |
Anna Zaks | 41988f3 | 2013-03-28 23:15:29 +0000 | [diff] [blame] | 2315 | E = Escaped.end(); |
| 2316 | I != E; ++I) { |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2317 | SymbolRef sym = *I; |
Anna Zaks | bf53dfa | 2012-12-20 00:38:25 +0000 | [diff] [blame] | 2318 | |
Anna Zaks | e7a5c82 | 2013-05-31 23:47:32 +0000 | [diff] [blame] | 2319 | if (EscapingSymbol && EscapingSymbol != sym) |
| 2320 | continue; |
| 2321 | |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2322 | if (const RefState *RS = State->get<RegionState>(sym)) { |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 2323 | if (RS->isAllocated() && CheckRefState(RS)) { |
Anna Zaks | 431e35c | 2012-08-09 00:42:24 +0000 | [diff] [blame] | 2324 | State = State->remove<RegionState>(sym); |
Anna Zaks | 0413023 | 2013-04-09 00:30:28 +0000 | [diff] [blame] | 2325 | State = State->set<RegionState>(sym, RefState::getEscaped(RS)); |
| 2326 | } |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2327 | } |
Anna Zaks | 4fb5487 | 2012-02-11 21:02:35 +0000 | [diff] [blame] | 2328 | } |
Anna Zaks | 66c4040 | 2012-02-14 21:55:24 +0000 | [diff] [blame] | 2329 | return State; |
Ted Kremenek | dd0e490 | 2010-07-31 01:52:11 +0000 | [diff] [blame] | 2330 | } |
Argyrios Kyrtzidis | 312dbec | 2011-02-28 01:26:35 +0000 | [diff] [blame] | 2331 | |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2332 | static SymbolRef findFailedReallocSymbol(ProgramStateRef currState, |
| 2333 | ProgramStateRef prevState) { |
Jordan Rose | 166d502 | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2334 | ReallocPairsTy currMap = currState->get<ReallocPairs>(); |
| 2335 | ReallocPairsTy prevMap = prevState->get<ReallocPairs>(); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2336 | |
Jordan Rose | 166d502 | 2012-11-02 01:54:06 +0000 | [diff] [blame] | 2337 | for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end(); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2338 | I != E; ++I) { |
| 2339 | SymbolRef sym = I.getKey(); |
| 2340 | if (!currMap.lookup(sym)) |
| 2341 | return sym; |
| 2342 | } |
| 2343 | |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2344 | return nullptr; |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2345 | } |
| 2346 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2347 | PathDiagnosticPiece * |
| 2348 | MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N, |
| 2349 | const ExplodedNode *PrevN, |
| 2350 | BugReporterContext &BRC, |
| 2351 | BugReport &BR) { |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2352 | ProgramStateRef state = N->getState(); |
| 2353 | ProgramStateRef statePrev = PrevN->getState(); |
| 2354 | |
| 2355 | const RefState *RS = state->get<RegionState>(Sym); |
| 2356 | const RefState *RSPrev = statePrev->get<RegionState>(Sym); |
Anna Zaks | ede875b | 2012-08-03 18:30:18 +0000 | [diff] [blame] | 2357 | if (!RS) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2358 | return nullptr; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2359 | |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2360 | const Stmt *S = nullptr; |
| 2361 | const char *Msg = nullptr; |
| 2362 | StackHintGeneratorForSymbol *StackHint = nullptr; |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2363 | |
| 2364 | // Retrieve the associated statement. |
| 2365 | ProgramPoint ProgLoc = N->getLocation(); |
David Blaikie | 7a95de6 | 2013-02-21 22:23:56 +0000 | [diff] [blame] | 2366 | if (Optional<StmtPoint> SP = ProgLoc.getAs<StmtPoint>()) { |
Jordan Rose | 852aa0d | 2012-07-10 22:07:52 +0000 | [diff] [blame] | 2367 | S = SP->getStmt(); |
David Blaikie | 7a95de6 | 2013-02-21 22:23:56 +0000 | [diff] [blame] | 2368 | } else if (Optional<CallExitEnd> Exit = ProgLoc.getAs<CallExitEnd>()) { |
Jordan Rose | 852aa0d | 2012-07-10 22:07:52 +0000 | [diff] [blame] | 2369 | S = Exit->getCalleeContext()->getCallSite(); |
David Blaikie | 7a95de6 | 2013-02-21 22:23:56 +0000 | [diff] [blame] | 2370 | } else if (Optional<BlockEdge> Edge = ProgLoc.getAs<BlockEdge>()) { |
Ted Kremenek | a4a1759 | 2013-01-04 19:04:36 +0000 | [diff] [blame] | 2371 | // If an assumption was made on a branch, it should be caught |
| 2372 | // here by looking at the state transition. |
| 2373 | S = Edge->getSrc()->getTerminator(); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2374 | } |
Ted Kremenek | a4a1759 | 2013-01-04 19:04:36 +0000 | [diff] [blame] | 2375 | |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2376 | if (!S) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2377 | return nullptr; |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2378 | |
Jordan Rose | 28038f3 | 2012-07-10 22:07:42 +0000 | [diff] [blame] | 2379 | // FIXME: We will eventually need to handle non-statement-based events |
| 2380 | // (__attribute__((cleanup))). |
| 2381 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2382 | // Find out if this is an interesting point and what is the kind. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2383 | if (Mode == Normal) { |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 2384 | if (isAllocated(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2385 | Msg = "Memory is allocated"; |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 2386 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 2387 | "Returned allocated memory"); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 2388 | } else if (isReleased(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2389 | Msg = "Memory is released"; |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 2390 | StackHint = new StackHintGeneratorForSymbol(Sym, |
Anna Zaks | 148d922 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2391 | "Returning; memory was released"); |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2392 | } else if (isRelinquished(RS, RSPrev, S)) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2393 | Msg = "Memory ownership is transferred"; |
Anna Zaks | 5b7aa34 | 2012-06-22 02:04:31 +0000 | [diff] [blame] | 2394 | StackHint = new StackHintGeneratorForSymbol(Sym, ""); |
Anna Zaks | 368a0d5 | 2012-03-15 21:13:02 +0000 | [diff] [blame] | 2395 | } else if (isReallocFailedCheck(RS, RSPrev, S)) { |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2396 | Mode = ReallocationFailed; |
| 2397 | Msg = "Reallocation failed"; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 2398 | StackHint = new StackHintGeneratorForReallocationFailed(Sym, |
Anna Zaks | fbd5874 | 2012-03-16 23:44:28 +0000 | [diff] [blame] | 2399 | "Reallocation failed"); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2400 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2401 | if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) { |
| 2402 | // Is it possible to fail two reallocs WITHOUT testing in between? |
| 2403 | assert((!FailedReallocSymbol || FailedReallocSymbol == sym) && |
| 2404 | "We only support one failed realloc at a time."); |
Jordy Rose | 393f98b | 2012-03-18 07:43:35 +0000 | [diff] [blame] | 2405 | BR.markInteresting(sym); |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2406 | FailedReallocSymbol = sym; |
| 2407 | } |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2408 | } |
| 2409 | |
| 2410 | // We are in a special mode if a reallocation failed later in the path. |
| 2411 | } else if (Mode == ReallocationFailed) { |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2412 | assert(FailedReallocSymbol && "No symbol to look for."); |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2413 | |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2414 | // Is this is the first appearance of the reallocated symbol? |
| 2415 | if (!statePrev->get<RegionState>(FailedReallocSymbol)) { |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2416 | // We're at the reallocation point. |
| 2417 | Msg = "Attempt to reallocate memory"; |
| 2418 | StackHint = new StackHintGeneratorForSymbol(Sym, |
| 2419 | "Returned reallocated memory"); |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2420 | FailedReallocSymbol = nullptr; |
Jordy Rose | b000fb5 | 2012-03-24 03:15:09 +0000 | [diff] [blame] | 2421 | Mode = Normal; |
| 2422 | } |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2423 | } |
| 2424 | |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2425 | if (!Msg) |
Stephen Hines | 6bcf27b | 2014-05-29 04:14:42 -0700 | [diff] [blame] | 2426 | return nullptr; |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 2427 | assert(StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2428 | |
| 2429 | // Generate the extra diagnostic. |
Anna Zaks | fe57160 | 2012-02-16 22:26:07 +0000 | [diff] [blame] | 2430 | PathDiagnosticLocation Pos(S, BRC.getSourceManager(), |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2431 | N->getLocationContext()); |
Anna Zaks | 56a938f | 2012-03-16 23:24:20 +0000 | [diff] [blame] | 2432 | return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint); |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2433 | } |
| 2434 | |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 2435 | void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State, |
| 2436 | const char *NL, const char *Sep) const { |
| 2437 | |
| 2438 | RegionStateTy RS = State->get<RegionState>(); |
| 2439 | |
Ted Kremenek | c37fad6 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2440 | if (!RS.isEmpty()) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2441 | Out << Sep << "MallocChecker :" << NL; |
Ted Kremenek | c37fad6 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2442 | for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) { |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2443 | const RefState *RefS = State->get<RegionState>(I.getKey()); |
| 2444 | AllocationFamily Family = RefS->getAllocationFamily(); |
| 2445 | Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(Family); |
| 2446 | |
Ted Kremenek | c37fad6 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2447 | I.getKey()->dumpToStream(Out); |
| 2448 | Out << " : "; |
| 2449 | I.getData().dump(Out); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2450 | if (CheckKind.hasValue()) |
| 2451 | Out << " (" << CheckNames[*CheckKind].getName() << ")"; |
Ted Kremenek | c37fad6 | 2013-01-03 01:30:12 +0000 | [diff] [blame] | 2452 | Out << NL; |
| 2453 | } |
| 2454 | } |
Anna Zaks | 93c5a24 | 2012-05-02 00:05:20 +0000 | [diff] [blame] | 2455 | } |
Anna Zaks | ff3b9fd | 2012-02-09 06:25:51 +0000 | [diff] [blame] | 2456 | |
Anna Zaks | 148d922 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2457 | void ento::registerNewDeleteLeaksChecker(CheckerManager &mgr) { |
| 2458 | registerCStringCheckerBasic(mgr); |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2459 | MallocChecker *checker = mgr.registerChecker<MallocChecker>(); |
| 2460 | checker->ChecksEnabled[MallocChecker::CK_NewDeleteLeaksChecker] = true; |
| 2461 | checker->CheckNames[MallocChecker::CK_NewDeleteLeaksChecker] = |
| 2462 | mgr.getCurrentCheckName(); |
Anna Zaks | 148d922 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2463 | // We currently treat NewDeleteLeaks checker as a subchecker of NewDelete |
| 2464 | // checker. |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2465 | if (!checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker]) |
| 2466 | checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker] = true; |
Anna Zaks | 148d922 | 2013-04-16 00:22:55 +0000 | [diff] [blame] | 2467 | } |
Anton Yartsev | 9df151c | 2013-04-12 23:25:40 +0000 | [diff] [blame] | 2468 | |
Stephen Hines | 651f13c | 2014-04-23 16:59:28 -0700 | [diff] [blame] | 2469 | #define REGISTER_CHECKER(name) \ |
| 2470 | void ento::register##name(CheckerManager &mgr) { \ |
| 2471 | registerCStringCheckerBasic(mgr); \ |
| 2472 | MallocChecker *checker = mgr.registerChecker<MallocChecker>(); \ |
| 2473 | checker->ChecksEnabled[MallocChecker::CK_##name] = true; \ |
| 2474 | checker->CheckNames[MallocChecker::CK_##name] = mgr.getCurrentCheckName(); \ |
| 2475 | } |
Anna Zaks | 231361a | 2012-02-08 23:16:52 +0000 | [diff] [blame] | 2476 | |
| 2477 | REGISTER_CHECKER(MallocPessimistic) |
| 2478 | REGISTER_CHECKER(MallocOptimistic) |
Anton Yartsev | 2de19ed | 2013-03-25 01:35:45 +0000 | [diff] [blame] | 2479 | REGISTER_CHECKER(NewDeleteChecker) |
Anton Yartsev | 849c7bf | 2013-03-28 17:05:19 +0000 | [diff] [blame] | 2480 | REGISTER_CHECKER(MismatchedDeallocatorChecker) |