Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 1 | //===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | |
Manuel Klimek | ca547db | 2013-01-16 14:55:28 +0000 | [diff] [blame] | 10 | #define DEBUG_TYPE "format-test" |
| 11 | |
Chandler Carruth | 1050e8b | 2012-12-04 09:45:34 +0000 | [diff] [blame] | 12 | #include "clang/Format/Format.h" |
Manuel Klimek | ca547db | 2013-01-16 14:55:28 +0000 | [diff] [blame] | 13 | #include "../Tooling/RewriterTestContext.h" |
Chandler Carruth | b1ba0ef | 2013-01-19 08:09:44 +0000 | [diff] [blame] | 14 | #include "clang/Lex/Lexer.h" |
| 15 | #include "llvm/Support/Debug.h" |
| 16 | #include "gtest/gtest.h" |
Manuel Klimek | ca547db | 2013-01-16 14:55:28 +0000 | [diff] [blame] | 17 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 18 | namespace clang { |
| 19 | namespace format { |
| 20 | |
| 21 | class FormatTest : public ::testing::Test { |
| 22 | protected: |
| 23 | std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length, |
| 24 | const FormatStyle &Style) { |
Manuel Klimek | ca547db | 2013-01-16 14:55:28 +0000 | [diff] [blame] | 25 | DEBUG(llvm::errs() << "---\n"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 26 | RewriterTestContext Context; |
| 27 | FileID ID = Context.createInMemoryFile("input.cc", Code); |
| 28 | SourceLocation Start = |
| 29 | Context.Sources.getLocForStartOfFile(ID).getLocWithOffset(Offset); |
| 30 | std::vector<CharSourceRange> Ranges( |
| 31 | 1, |
| 32 | CharSourceRange::getCharRange(Start, Start.getLocWithOffset(Length))); |
Daniel Jasper | 46ef852 | 2013-01-10 13:08:12 +0000 | [diff] [blame] | 33 | Lexer Lex(ID, Context.Sources.getBuffer(ID), Context.Sources, |
| 34 | getFormattingLangOpts()); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 35 | tooling::Replacements Replace = reformat( |
| 36 | Style, Lex, Context.Sources, Ranges, new IgnoringDiagConsumer()); |
Daniel Jasper | afcbd85 | 2013-01-30 09:46:12 +0000 | [diff] [blame] | 37 | ReplacementCount = Replace.size(); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 38 | EXPECT_TRUE(applyAllReplacements(Replace, Context.Rewrite)); |
Manuel Klimek | ca547db | 2013-01-16 14:55:28 +0000 | [diff] [blame] | 39 | DEBUG(llvm::errs() << "\n" << Context.getRewrittenText(ID) << "\n\n"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 40 | return Context.getRewrittenText(ID); |
| 41 | } |
| 42 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 43 | std::string |
| 44 | format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) { |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 45 | return format(Code, 0, Code.size(), Style); |
| 46 | } |
| 47 | |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 48 | std::string messUp(llvm::StringRef Code) { |
| 49 | std::string MessedUp(Code.str()); |
| 50 | bool InComment = false; |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 51 | bool InPreprocessorDirective = false; |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 52 | bool JustReplacedNewline = false; |
| 53 | for (unsigned i = 0, e = MessedUp.size() - 1; i != e; ++i) { |
| 54 | if (MessedUp[i] == '/' && MessedUp[i + 1] == '/') { |
| 55 | if (JustReplacedNewline) |
| 56 | MessedUp[i - 1] = '\n'; |
| 57 | InComment = true; |
Daniel Jasper | e0b15ea | 2013-01-14 15:40:57 +0000 | [diff] [blame] | 58 | } else if (MessedUp[i] == '#' && (JustReplacedNewline || i == 0)) { |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 59 | if (i != 0) |
| 60 | MessedUp[i - 1] = '\n'; |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 61 | InPreprocessorDirective = true; |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 62 | } else if (MessedUp[i] == '\\' && MessedUp[i + 1] == '\n') { |
| 63 | MessedUp[i] = ' '; |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 64 | MessedUp[i + 1] = ' '; |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 65 | } else if (MessedUp[i] == '\n') { |
| 66 | if (InComment) { |
| 67 | InComment = false; |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 68 | } else if (InPreprocessorDirective) { |
| 69 | InPreprocessorDirective = false; |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 70 | } else { |
| 71 | JustReplacedNewline = true; |
| 72 | MessedUp[i] = ' '; |
| 73 | } |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 74 | } else if (MessedUp[i] != ' ') { |
| 75 | JustReplacedNewline = false; |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 76 | } |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 77 | } |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 78 | return MessedUp; |
| 79 | } |
| 80 | |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 81 | FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { |
| 82 | FormatStyle Style = getLLVMStyle(); |
| 83 | Style.ColumnLimit = ColumnLimit; |
| 84 | return Style; |
| 85 | } |
| 86 | |
Daniel Jasper | 6f5bb2c | 2013-01-14 16:24:39 +0000 | [diff] [blame] | 87 | FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) { |
| 88 | FormatStyle Style = getGoogleStyle(); |
| 89 | Style.ColumnLimit = ColumnLimit; |
| 90 | return Style; |
| 91 | } |
| 92 | |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 93 | void verifyFormat(llvm::StringRef Code, |
| 94 | const FormatStyle &Style = getLLVMStyle()) { |
| 95 | EXPECT_EQ(Code.str(), format(messUp(Code), Style)); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 96 | } |
| 97 | |
| 98 | void verifyGoogleFormat(llvm::StringRef Code) { |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 99 | verifyFormat(Code, getGoogleStyle()); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 100 | } |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 101 | |
| 102 | void verifyIndependentOfContext(llvm::StringRef text) { |
| 103 | verifyFormat(text); |
| 104 | verifyFormat(llvm::Twine("void f() { " + text + " }").str()); |
| 105 | } |
Daniel Jasper | afcbd85 | 2013-01-30 09:46:12 +0000 | [diff] [blame] | 106 | |
| 107 | int ReplacementCount; |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 108 | }; |
| 109 | |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 110 | TEST_F(FormatTest, MessUp) { |
| 111 | EXPECT_EQ("1 2 3", messUp("1 2 3")); |
| 112 | EXPECT_EQ("1 2 3\n", messUp("1\n2\n3\n")); |
| 113 | EXPECT_EQ("a\n//b\nc", messUp("a\n//b\nc")); |
| 114 | EXPECT_EQ("a\n#b\nc", messUp("a\n#b\nc")); |
| 115 | EXPECT_EQ("a\n#b c d\ne", messUp("a\n#b\\\nc\\\nd\ne")); |
| 116 | } |
| 117 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 118 | //===----------------------------------------------------------------------===// |
| 119 | // Basic function tests. |
| 120 | //===----------------------------------------------------------------------===// |
| 121 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 122 | TEST_F(FormatTest, DoesNotChangeCorrectlyFormatedCode) { |
| 123 | EXPECT_EQ(";", format(";")); |
| 124 | } |
| 125 | |
| 126 | TEST_F(FormatTest, FormatsGlobalStatementsAt0) { |
| 127 | EXPECT_EQ("int i;", format(" int i;")); |
| 128 | EXPECT_EQ("\nint i;", format(" \n\t \r int i;")); |
| 129 | EXPECT_EQ("int i;\nint j;", format(" int i; int j;")); |
| 130 | EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;")); |
| 131 | } |
| 132 | |
| 133 | TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) { |
| 134 | EXPECT_EQ("int i;", format("int\ni;")); |
| 135 | } |
| 136 | |
| 137 | TEST_F(FormatTest, FormatsNestedBlockStatements) { |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 138 | EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}")); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 139 | } |
| 140 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 141 | TEST_F(FormatTest, FormatsNestedCall) { |
| 142 | verifyFormat("Method(f1, f2(f3));"); |
| 143 | verifyFormat("Method(f1(f2, f3()));"); |
Daniel Jasper | 4e9008a | 2013-01-13 08:19:51 +0000 | [diff] [blame] | 144 | verifyFormat("Method(f1(f2, (f3())));"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 145 | } |
| 146 | |
Daniel Jasper | daf1a15 | 2013-02-07 21:08:36 +0000 | [diff] [blame] | 147 | TEST_F(FormatTest, NestedNameSpecifiers) { |
Daniel Jasper | 6b825c2 | 2013-01-16 07:19:28 +0000 | [diff] [blame] | 148 | verifyFormat("vector< ::Type> v;"); |
Daniel Jasper | daf1a15 | 2013-02-07 21:08:36 +0000 | [diff] [blame] | 149 | verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())"); |
Daniel Jasper | 6b825c2 | 2013-01-16 07:19:28 +0000 | [diff] [blame] | 150 | } |
| 151 | |
Daniel Jasper | afcbd85 | 2013-01-30 09:46:12 +0000 | [diff] [blame] | 152 | TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) { |
| 153 | EXPECT_EQ("if (a) {\n" |
| 154 | " f();\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 155 | "}", |
| 156 | format("if(a){f();}")); |
Daniel Jasper | afcbd85 | 2013-01-30 09:46:12 +0000 | [diff] [blame] | 157 | EXPECT_EQ(4, ReplacementCount); |
| 158 | EXPECT_EQ("if (a) {\n" |
| 159 | " f();\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 160 | "}", |
| 161 | format("if (a) {\n" |
| 162 | " f();\n" |
| 163 | "}")); |
Daniel Jasper | afcbd85 | 2013-01-30 09:46:12 +0000 | [diff] [blame] | 164 | EXPECT_EQ(0, ReplacementCount); |
| 165 | } |
| 166 | |
Daniel Jasper | c78c6b3 | 2013-02-14 09:58:41 +0000 | [diff] [blame] | 167 | TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) { |
| 168 | EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle())); |
Daniel Jasper | 516fb31 | 2013-03-01 18:11:39 +0000 | [diff] [blame] | 169 | EXPECT_EQ("int a;", format("int a; ")); |
| 170 | EXPECT_EQ("int a;\n", format("int a; \n \n \n ")); |
| 171 | EXPECT_EQ("int a;\nint b; ", |
| 172 | format("int a; \nint b; ", 0, 0, getLLVMStyle())); |
Daniel Jasper | c78c6b3 | 2013-02-14 09:58:41 +0000 | [diff] [blame] | 173 | } |
| 174 | |
Daniel Jasper | 1eee6c4 | 2013-03-04 13:43:19 +0000 | [diff] [blame] | 175 | TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) { |
| 176 | EXPECT_EQ("int b;\nint a;", |
| 177 | format("int b;\n int a;", 7, 0, getLLVMStyle())); |
| 178 | EXPECT_EQ("int b;\n int a;", |
| 179 | format("int b;\n int a;", 6, 0, getLLVMStyle())); |
| 180 | |
| 181 | EXPECT_EQ("#define A \\\n" |
| 182 | " int a; \\\n" |
| 183 | " int b;", |
| 184 | format("#define A \\\n" |
| 185 | " int a; \\\n" |
| 186 | " int b;", |
| 187 | 26, 0, getLLVMStyleWithColumns(12))); |
| 188 | EXPECT_EQ("#define A \\\n" |
| 189 | " int a; \\\n" |
| 190 | " int b;", |
| 191 | format("#define A \\\n" |
| 192 | " int a; \\\n" |
| 193 | " int b;", |
| 194 | 25, 0, getLLVMStyleWithColumns(12))); |
| 195 | } |
| 196 | |
Daniel Jasper | f302354 | 2013-03-07 20:50:00 +0000 | [diff] [blame] | 197 | TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) { |
| 198 | EXPECT_EQ("int a;\n\n int b;", |
| 199 | format("int a;\n \n\n int b;", 7, 0, getLLVMStyle())); |
| 200 | EXPECT_EQ("int a;\n\n int b;", |
| 201 | format("int a;\n \n\n int b;", 9, 0, getLLVMStyle())); |
| 202 | } |
| 203 | |
Daniel Jasper | 2933316 | 2013-02-18 13:08:03 +0000 | [diff] [blame] | 204 | TEST_F(FormatTest, ReformatsMovedLines) { |
| 205 | EXPECT_EQ( |
| 206 | "template <typename T> T *getFETokenInfo() const {\n" |
| 207 | " return static_cast<T *>(FETokenInfo);\n" |
| 208 | "}\n" |
| 209 | " int a; // <- Should not be formatted", |
| 210 | format( |
| 211 | "template<typename T>\n" |
| 212 | "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n" |
| 213 | " int a; // <- Should not be formatted", |
| 214 | 9, 5, getLLVMStyle())); |
| 215 | } |
| 216 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 217 | //===----------------------------------------------------------------------===// |
| 218 | // Tests for control statements. |
| 219 | //===----------------------------------------------------------------------===// |
| 220 | |
| 221 | TEST_F(FormatTest, FormatIfWithoutCompountStatement) { |
Daniel Jasper | 6f5bb2c | 2013-01-14 16:24:39 +0000 | [diff] [blame] | 222 | verifyFormat("if (true)\n f();\ng();"); |
| 223 | verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 224 | verifyFormat("if (a)\n if (b) {\n f();\n }\ng();"); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 225 | |
| 226 | FormatStyle AllowsMergedIf = getGoogleStyle(); |
| 227 | AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; |
| 228 | verifyFormat("if (a)\n" |
| 229 | " // comment\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 230 | " f();", |
| 231 | AllowsMergedIf); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 232 | |
| 233 | verifyFormat("if (a) // Can't merge this\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 234 | " f();\n", |
| 235 | AllowsMergedIf); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 236 | verifyFormat("if (a) /* still don't merge */\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 237 | " f();", |
| 238 | AllowsMergedIf); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 239 | verifyFormat("if (a) { // Never merge this\n" |
| 240 | " f();\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 241 | "}", |
| 242 | AllowsMergedIf); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 243 | verifyFormat("if (a) { /* Never merge this */\n" |
| 244 | " f();\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 245 | "}", |
| 246 | AllowsMergedIf); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 247 | |
| 248 | AllowsMergedIf.ColumnLimit = 14; |
| 249 | verifyFormat("if (a) return;", AllowsMergedIf); |
Daniel Jasper | fd0ca97 | 2013-01-14 16:02:06 +0000 | [diff] [blame] | 250 | verifyFormat("if (aaaaaaaaa)\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 251 | " return;", |
| 252 | AllowsMergedIf); |
Daniel Jasper | df3736a | 2013-01-16 15:44:34 +0000 | [diff] [blame] | 253 | |
| 254 | AllowsMergedIf.ColumnLimit = 13; |
| 255 | verifyFormat("if (a)\n return;", AllowsMergedIf); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 256 | } |
| 257 | |
| 258 | TEST_F(FormatTest, ParseIfElse) { |
| 259 | verifyFormat("if (true)\n" |
| 260 | " if (true)\n" |
| 261 | " if (true)\n" |
| 262 | " f();\n" |
| 263 | " else\n" |
| 264 | " g();\n" |
| 265 | " else\n" |
| 266 | " h();\n" |
| 267 | "else\n" |
| 268 | " i();"); |
| 269 | verifyFormat("if (true)\n" |
| 270 | " if (true)\n" |
| 271 | " if (true) {\n" |
Daniel Jasper | 6f5bb2c | 2013-01-14 16:24:39 +0000 | [diff] [blame] | 272 | " if (true)\n" |
| 273 | " f();\n" |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 274 | " } else {\n" |
| 275 | " g();\n" |
| 276 | " }\n" |
| 277 | " else\n" |
| 278 | " h();\n" |
| 279 | "else {\n" |
| 280 | " i();\n" |
| 281 | "}"); |
| 282 | } |
| 283 | |
| 284 | TEST_F(FormatTest, ElseIf) { |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 285 | verifyFormat("if (a) {\n} else if (b) {\n}"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 286 | verifyFormat("if (a)\n" |
| 287 | " f();\n" |
| 288 | "else if (b)\n" |
| 289 | " g();\n" |
| 290 | "else\n" |
| 291 | " h();"); |
| 292 | } |
| 293 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 294 | TEST_F(FormatTest, FormatsForLoop) { |
| 295 | verifyFormat( |
| 296 | "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n" |
Alexander Kornienko | 2e97cfc | 2012-12-05 15:06:06 +0000 | [diff] [blame] | 297 | " ++VeryVeryLongLoopVariable)\n" |
| 298 | " ;"); |
| 299 | verifyFormat("for (;;)\n" |
| 300 | " f();"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 301 | verifyFormat("for (;;) {\n}"); |
Alexander Kornienko | 2e97cfc | 2012-12-05 15:06:06 +0000 | [diff] [blame] | 302 | verifyFormat("for (;;) {\n" |
| 303 | " f();\n" |
| 304 | "}"); |
Daniel Jasper | 454cb70 | 2013-05-03 14:50:50 +0000 | [diff] [blame] | 305 | verifyFormat("for (int i = 0; (i < 10); ++i) {\n}"); |
Daniel Jasper | a324a0e | 2012-12-21 14:37:20 +0000 | [diff] [blame] | 306 | |
| 307 | verifyFormat( |
| 308 | "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" |
| 309 | " E = UnwrappedLines.end();\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 310 | " I != E; ++I) {\n}"); |
Daniel Jasper | a324a0e | 2012-12-21 14:37:20 +0000 | [diff] [blame] | 311 | |
| 312 | verifyFormat( |
| 313 | "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 314 | " ++IIIII) {\n}"); |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 315 | verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n" |
| 316 | " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 317 | " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}"); |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 318 | verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n" |
| 319 | " I = FD->getDeclsInPrototypeScope().begin(),\n" |
| 320 | " E = FD->getDeclsInPrototypeScope().end();\n" |
| 321 | " I != E; ++I) {\n}"); |
Daniel Jasper | 7522318 | 2013-01-28 17:30:17 +0000 | [diff] [blame] | 322 | |
| 323 | // FIXME: Not sure whether we want extra identation in line 3 here: |
| 324 | verifyFormat( |
| 325 | "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" |
| 326 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n" |
Daniel Jasper | f9955d3 | 2013-03-20 12:37:50 +0000 | [diff] [blame] | 327 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 328 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" |
Daniel Jasper | 7522318 | 2013-01-28 17:30:17 +0000 | [diff] [blame] | 329 | " ++aaaaaaaaaaa) {\n}"); |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 330 | verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n" |
| 331 | " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" |
| 332 | "}"); |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 333 | verifyFormat("for (some_namespace::SomeIterator iter( // force break\n" |
| 334 | " aaaaaaaaaa);\n" |
| 335 | " iter; ++iter) {\n" |
| 336 | "}"); |
Daniel Jasper | 8159d2f | 2013-02-04 07:30:30 +0000 | [diff] [blame] | 337 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 338 | FormatStyle NoBinPacking = getLLVMStyle(); |
| 339 | NoBinPacking.BinPackParameters = false; |
| 340 | verifyFormat("for (int aaaaaaaaaaa = 1;\n" |
| 341 | " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n" |
| 342 | " aaaaaaaaaaaaaaaa,\n" |
| 343 | " aaaaaaaaaaaaaaaa,\n" |
| 344 | " aaaaaaaaaaaaaaaa);\n" |
| 345 | " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" |
| 346 | "}", |
| 347 | NoBinPacking); |
| 348 | verifyFormat( |
Daniel Jasper | 237d4c1 | 2013-02-23 21:01:55 +0000 | [diff] [blame] | 349 | "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" |
| 350 | " E = UnwrappedLines.end();\n" |
| 351 | " I != E;\n" |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 352 | " ++I) {\n}", |
| 353 | NoBinPacking); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 354 | } |
| 355 | |
Daniel Jasper | 3b9a8fc | 2013-01-28 13:21:16 +0000 | [diff] [blame] | 356 | TEST_F(FormatTest, RangeBasedForLoops) { |
| 357 | verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" |
| 358 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); |
| 359 | verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n" |
| 360 | " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}"); |
Daniel Jasper | 84a1a63 | 2013-02-26 13:18:08 +0000 | [diff] [blame] | 361 | verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n" |
| 362 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); |
Daniel Jasper | 3b9a8fc | 2013-01-28 13:21:16 +0000 | [diff] [blame] | 363 | } |
| 364 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 365 | TEST_F(FormatTest, FormatsWhileLoop) { |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 366 | verifyFormat("while (true) {\n}"); |
Alexander Kornienko | 2e97cfc | 2012-12-05 15:06:06 +0000 | [diff] [blame] | 367 | verifyFormat("while (true)\n" |
| 368 | " f();"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 369 | verifyFormat("while () {\n}"); |
Alexander Kornienko | 2e97cfc | 2012-12-05 15:06:06 +0000 | [diff] [blame] | 370 | verifyFormat("while () {\n" |
| 371 | " f();\n" |
| 372 | "}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 373 | } |
| 374 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 375 | TEST_F(FormatTest, FormatsDoWhile) { |
| 376 | verifyFormat("do {\n" |
| 377 | " do_something();\n" |
| 378 | "} while (something());"); |
| 379 | verifyFormat("do\n" |
| 380 | " do_something();\n" |
| 381 | "while (something());"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 382 | } |
| 383 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 384 | TEST_F(FormatTest, FormatsSwitchStatement) { |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 385 | verifyFormat("switch (x) {\n" |
| 386 | "case 1:\n" |
| 387 | " f();\n" |
| 388 | " break;\n" |
| 389 | "case kFoo:\n" |
| 390 | "case ns::kBar:\n" |
| 391 | "case kBaz:\n" |
| 392 | " break;\n" |
| 393 | "default:\n" |
| 394 | " g();\n" |
| 395 | " break;\n" |
| 396 | "}"); |
| 397 | verifyFormat("switch (x) {\n" |
| 398 | "case 1: {\n" |
| 399 | " f();\n" |
| 400 | " break;\n" |
| 401 | "}\n" |
| 402 | "}"); |
Nico Weber | 94fb729 | 2013-01-18 05:50:57 +0000 | [diff] [blame] | 403 | verifyFormat("switch (x) {\n" |
| 404 | "case 1: {\n" |
| 405 | " f();\n" |
| 406 | " {\n" |
| 407 | " g();\n" |
| 408 | " h();\n" |
| 409 | " }\n" |
| 410 | " break;\n" |
| 411 | "}\n" |
| 412 | "}"); |
| 413 | verifyFormat("switch (x) {\n" |
| 414 | "case 1: {\n" |
| 415 | " f();\n" |
| 416 | " if (foo) {\n" |
| 417 | " g();\n" |
| 418 | " h();\n" |
| 419 | " }\n" |
| 420 | " break;\n" |
| 421 | "}\n" |
| 422 | "}"); |
| 423 | verifyFormat("switch (x) {\n" |
| 424 | "case 1: {\n" |
| 425 | " f();\n" |
| 426 | " g();\n" |
| 427 | "} break;\n" |
| 428 | "}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 429 | verifyFormat("switch (test)\n" |
| 430 | " ;"); |
Daniel Jasper | 4ba9bfd | 2013-03-12 12:26:55 +0000 | [diff] [blame] | 431 | verifyFormat("switch (x) {\n" |
| 432 | "default: {\n" |
| 433 | " // Do nothing.\n" |
Manuel Klimek | 67d080d | 2013-04-12 14:13:36 +0000 | [diff] [blame] | 434 | "}\n" |
Daniel Jasper | 4ba9bfd | 2013-03-12 12:26:55 +0000 | [diff] [blame] | 435 | "}"); |
Daniel Jasper | 6050a1e | 2013-03-13 15:53:12 +0000 | [diff] [blame] | 436 | verifyFormat("switch (x) {\n" |
Daniel Jasper | 5999f76 | 2013-04-09 17:46:55 +0000 | [diff] [blame] | 437 | "// comment\n" |
Daniel Jasper | 6050a1e | 2013-03-13 15:53:12 +0000 | [diff] [blame] | 438 | "// if 1, do f()\n" |
| 439 | "case 1:\n" |
| 440 | " f();\n" |
| 441 | "}"); |
Daniel Jasper | c30eb51 | 2013-03-19 18:33:58 +0000 | [diff] [blame] | 442 | verifyFormat("switch (x) {\n" |
| 443 | "case 1:\n" |
| 444 | " // Do amazing stuff\n" |
| 445 | " {\n" |
| 446 | " f();\n" |
| 447 | " g();\n" |
| 448 | " }\n" |
| 449 | " break;\n" |
| 450 | "}"); |
Daniel Jasper | bcca7e4 | 2013-03-20 10:23:53 +0000 | [diff] [blame] | 451 | verifyFormat("#define A \\\n" |
| 452 | " switch (x) { \\\n" |
| 453 | " case a: \\\n" |
| 454 | " foo = b; \\\n" |
| 455 | " }", getLLVMStyleWithColumns(20)); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 456 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 457 | verifyGoogleFormat("switch (x) {\n" |
| 458 | " case 1:\n" |
| 459 | " f();\n" |
| 460 | " break;\n" |
| 461 | " case kFoo:\n" |
| 462 | " case ns::kBar:\n" |
| 463 | " case kBaz:\n" |
| 464 | " break;\n" |
| 465 | " default:\n" |
| 466 | " g();\n" |
| 467 | " break;\n" |
| 468 | "}"); |
| 469 | verifyGoogleFormat("switch (x) {\n" |
| 470 | " case 1: {\n" |
| 471 | " f();\n" |
| 472 | " break;\n" |
| 473 | " }\n" |
| 474 | "}"); |
| 475 | verifyGoogleFormat("switch (test)\n" |
| 476 | " ;"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 477 | } |
| 478 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 479 | TEST_F(FormatTest, FormatsLabels) { |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 480 | verifyFormat("void f() {\n" |
| 481 | " some_code();\n" |
| 482 | "test_label:\n" |
| 483 | " some_other_code();\n" |
| 484 | " {\n" |
| 485 | " some_more_code();\n" |
| 486 | " another_label:\n" |
| 487 | " some_more_code();\n" |
| 488 | " }\n" |
| 489 | "}"); |
| 490 | verifyFormat("some_code();\n" |
| 491 | "test_label:\n" |
| 492 | "some_other_code();"); |
| 493 | } |
| 494 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 495 | //===----------------------------------------------------------------------===// |
| 496 | // Tests for comments. |
| 497 | //===----------------------------------------------------------------------===// |
| 498 | |
| 499 | TEST_F(FormatTest, UnderstandsSingleLineComments) { |
Daniel Jasper | b64eca0 | 2013-03-22 10:01:29 +0000 | [diff] [blame] | 500 | verifyFormat("//* */"); |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 501 | verifyFormat("// line 1\n" |
| 502 | "// line 2\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 503 | "void f() {}\n"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 504 | |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 505 | verifyFormat("void f() {\n" |
| 506 | " // Doesn't do anything\n" |
| 507 | "}"); |
Daniel Jasper | dcc2a62 | 2013-01-18 08:44:07 +0000 | [diff] [blame] | 508 | verifyFormat("void f(int i, // some comment (probably for i)\n" |
| 509 | " int j, // some comment (probably for j)\n" |
Daniel Jasper | 487f64b | 2013-01-13 16:10:20 +0000 | [diff] [blame] | 510 | " int k); // some comment (probably for k)"); |
| 511 | verifyFormat("void f(int i,\n" |
| 512 | " // some comment (probably for j)\n" |
| 513 | " int j,\n" |
| 514 | " // some comment (probably for k)\n" |
| 515 | " int k);"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 516 | |
Daniel Jasper | dcc2a62 | 2013-01-18 08:44:07 +0000 | [diff] [blame] | 517 | verifyFormat("int i // This is a fancy variable\n" |
| 518 | " = 5; // with nicely aligned comment."); |
| 519 | |
| 520 | verifyFormat("// Leading comment.\n" |
| 521 | "int a; // Trailing comment."); |
| 522 | verifyFormat("int a; // Trailing comment\n" |
| 523 | " // on 2\n" |
| 524 | " // or 3 lines.\n" |
| 525 | "int b;"); |
| 526 | verifyFormat("int a; // Trailing comment\n" |
| 527 | "\n" |
| 528 | "// Leading comment.\n" |
| 529 | "int b;"); |
| 530 | verifyFormat("int a; // Comment.\n" |
| 531 | " // More details.\n" |
| 532 | "int bbbb; // Another comment."); |
| 533 | verifyFormat( |
| 534 | "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n" |
| 535 | "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n" |
| 536 | "int cccccccccccccccccccccccccccccc; // comment\n" |
| 537 | "int ddd; // looooooooooooooooooooooooong comment\n" |
| 538 | "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n" |
| 539 | "int bbbbbbbbbbbbbbbbbbbbb; // comment\n" |
| 540 | "int ccccccccccccccccccc; // comment"); |
| 541 | |
Daniel Jasper | 7d1185d | 2013-01-18 09:19:33 +0000 | [diff] [blame] | 542 | verifyFormat("#include \"a\" // comment\n" |
| 543 | "#include \"a/b/c\" // comment"); |
| 544 | verifyFormat("#include <a> // comment\n" |
| 545 | "#include <a/b/c> // comment"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 546 | |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 547 | verifyFormat("enum E {\n" |
| 548 | " // comment\n" |
Daniel Jasper | 7ad4eff | 2013-01-07 11:09:06 +0000 | [diff] [blame] | 549 | " VAL_A, // comment\n" |
Daniel Jasper | e35ec2b | 2012-12-18 19:56:56 +0000 | [diff] [blame] | 550 | " VAL_B\n" |
| 551 | "};"); |
Daniel Jasper | 05b1ac8 | 2012-12-17 11:29:41 +0000 | [diff] [blame] | 552 | |
| 553 | verifyFormat( |
| 554 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" |
Daniel Jasper | 7ad4eff | 2013-01-07 11:09:06 +0000 | [diff] [blame] | 555 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment"); |
Daniel Jasper | 043835a | 2013-01-09 09:33:39 +0000 | [diff] [blame] | 556 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" |
| 557 | " // Comment inside a statement.\n" |
| 558 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); |
Daniel Jasper | 36ba0ff | 2013-02-06 15:23:09 +0000 | [diff] [blame] | 559 | verifyFormat( |
| 560 | "bool aaaaaaaaaaaaa = // comment\n" |
| 561 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 562 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Manuel Klimek | 6cf5814 | 2013-01-07 08:54:53 +0000 | [diff] [blame] | 563 | |
Daniel Jasper | 42f458d | 2013-02-13 19:25:54 +0000 | [diff] [blame] | 564 | verifyFormat("int aaaa; // aaaaa\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 565 | "int aa; // aaaaaaa", |
| 566 | getLLVMStyleWithColumns(20)); |
Daniel Jasper | 42f458d | 2013-02-13 19:25:54 +0000 | [diff] [blame] | 567 | |
Daniel Jasper | 821627e | 2013-01-21 22:49:20 +0000 | [diff] [blame] | 568 | EXPECT_EQ("void f() { // This does something ..\n" |
| 569 | "}\n" |
| 570 | "int a; // This is unrelated", |
| 571 | format("void f() { // This does something ..\n" |
| 572 | " }\n" |
| 573 | "int a; // This is unrelated")); |
| 574 | EXPECT_EQ("void f() { // This does something ..\n" |
| 575 | "} // awesome..\n" |
| 576 | "\n" |
| 577 | "int a; // This is unrelated", |
| 578 | format("void f() { // This does something ..\n" |
| 579 | " } // awesome..\n" |
| 580 | " \n" |
| 581 | "int a; // This is unrelated")); |
| 582 | |
Daniel Jasper | 7ad4eff | 2013-01-07 11:09:06 +0000 | [diff] [blame] | 583 | EXPECT_EQ("int i; // single line trailing comment", |
Manuel Klimek | 6cf5814 | 2013-01-07 08:54:53 +0000 | [diff] [blame] | 584 | format("int i;\\\n// single line trailing comment")); |
Daniel Jasper | 7ad4eff | 2013-01-07 11:09:06 +0000 | [diff] [blame] | 585 | |
| 586 | verifyGoogleFormat("int a; // Trailing comment."); |
Daniel Jasper | d4f2c2e | 2013-01-29 19:41:55 +0000 | [diff] [blame] | 587 | |
| 588 | verifyFormat("someFunction(anotherFunction( // Force break.\n" |
| 589 | " parameter));"); |
Daniel Jasper | 5b7e7b0 | 2013-02-05 09:34:14 +0000 | [diff] [blame] | 590 | |
| 591 | verifyGoogleFormat("#endif // HEADER_GUARD"); |
Daniel Jasper | 474e462 | 2013-02-06 22:04:05 +0000 | [diff] [blame] | 592 | |
| 593 | verifyFormat("const char *test[] = {\n" |
| 594 | " // A\n" |
| 595 | " \"aaaa\",\n" |
| 596 | " // B\n" |
| 597 | " \"aaaaa\",\n" |
| 598 | "};"); |
Daniel Jasper | 729a743 | 2013-02-11 12:36:37 +0000 | [diff] [blame] | 599 | verifyGoogleFormat( |
| 600 | "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 601 | " aaaaaaaaaaaaaaaaaaaaaa); // 81 cols with this comment"); |
Alexander Kornienko | 4128e19 | 2013-04-03 12:38:53 +0000 | [diff] [blame] | 602 | EXPECT_EQ("D(a, {\n" |
| 603 | " // test\n" |
| 604 | " int a;\n" |
| 605 | "});", |
| 606 | format("D(a, {\n" |
| 607 | "// test\n" |
| 608 | "int a;\n" |
| 609 | "});")); |
Daniel Jasper | 05b1ac8 | 2012-12-17 11:29:41 +0000 | [diff] [blame] | 610 | } |
| 611 | |
Daniel Jasper | c363dbb | 2013-03-22 16:25:51 +0000 | [diff] [blame] | 612 | TEST_F(FormatTest, CanFormatCommentsLocally) { |
| 613 | EXPECT_EQ("int a; // comment\n" |
| 614 | "int b; // comment", |
| 615 | format("int a; // comment\n" |
| 616 | "int b; // comment", |
| 617 | 0, 0, getLLVMStyle())); |
| 618 | EXPECT_EQ("int a; // comment\n" |
| 619 | " // line 2\n" |
| 620 | "int b;", |
| 621 | format("int a; // comment\n" |
| 622 | " // line 2\n" |
| 623 | "int b;", |
| 624 | 28, 0, getLLVMStyle())); |
Daniel Jasper | af84976 | 2013-04-24 06:33:59 +0000 | [diff] [blame] | 625 | EXPECT_EQ("int aaaaaa; // comment\n" |
| 626 | "int b;\n" |
| 627 | "int c; // unrelated comment", |
| 628 | format("int aaaaaa; // comment\n" |
| 629 | "int b;\n" |
| 630 | "int c; // unrelated comment", |
| 631 | 31, 0, getLLVMStyle())); |
Daniel Jasper | c363dbb | 2013-03-22 16:25:51 +0000 | [diff] [blame] | 632 | } |
| 633 | |
Daniel Jasper | 812c045 | 2013-03-01 16:45:59 +0000 | [diff] [blame] | 634 | TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) { |
| 635 | EXPECT_EQ("// comment", format("// comment ")); |
| 636 | EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment", |
| 637 | format("int aaaaaaa, bbbbbbb; // comment ", |
| 638 | getLLVMStyleWithColumns(33))); |
| 639 | } |
| 640 | |
Daniel Jasper | 05b1ac8 | 2012-12-17 11:29:41 +0000 | [diff] [blame] | 641 | TEST_F(FormatTest, UnderstandsMultiLineComments) { |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 642 | verifyFormat("f(/*test=*/ true);"); |
Daniel Jasper | 2c6cc48 | 2013-01-17 12:53:34 +0000 | [diff] [blame] | 643 | EXPECT_EQ( |
| 644 | "f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n" |
| 645 | " bbbbbbbbbbbbbbbbbbbbbbbbb);", |
Alexander Kornienko | 919398b | 2013-04-17 17:34:05 +0000 | [diff] [blame] | 646 | format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n/* Trailing comment for aa... */\n" |
Daniel Jasper | 2c6cc48 | 2013-01-17 12:53:34 +0000 | [diff] [blame] | 647 | " bbbbbbbbbbbbbbbbbbbbbbbbb);")); |
| 648 | EXPECT_EQ( |
| 649 | "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 650 | " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);", |
| 651 | format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n" |
| 652 | "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);")); |
Daniel Jasper | d4f2c2e | 2013-01-29 19:41:55 +0000 | [diff] [blame] | 653 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 654 | FormatStyle NoBinPacking = getLLVMStyle(); |
| 655 | NoBinPacking.BinPackParameters = false; |
| 656 | verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n" |
| 657 | " /* parameter 2 */ aaaaaa,\n" |
| 658 | " /* parameter 3 */ aaaaaa,\n" |
| 659 | " /* parameter 4 */ aaaaaa);", |
| 660 | NoBinPacking); |
Daniel Jasper | 2c6cc48 | 2013-01-17 12:53:34 +0000 | [diff] [blame] | 661 | } |
| 662 | |
Alexander Kornienko | f753615 | 2013-03-14 16:10:54 +0000 | [diff] [blame] | 663 | TEST_F(FormatTest, AlignsMultiLineComments) { |
| 664 | EXPECT_EQ("/*\n" |
| 665 | " * Really multi-line\n" |
| 666 | " * comment.\n" |
| 667 | " */\n" |
| 668 | "void f() {}", |
| 669 | format(" /*\n" |
| 670 | " * Really multi-line\n" |
| 671 | " * comment.\n" |
| 672 | " */\n" |
| 673 | " void f() {}")); |
Alexander Kornienko | f753615 | 2013-03-14 16:10:54 +0000 | [diff] [blame] | 674 | EXPECT_EQ("class C {\n" |
| 675 | " /*\n" |
| 676 | " * Another multi-line\n" |
| 677 | " * comment.\n" |
| 678 | " */\n" |
| 679 | " void f() {}\n" |
| 680 | "};", |
| 681 | format("class C {\n" |
| 682 | "/*\n" |
| 683 | " * Another multi-line\n" |
| 684 | " * comment.\n" |
| 685 | " */\n" |
| 686 | "void f() {}\n" |
| 687 | "};")); |
Alexander Kornienko | 1fdd8b3 | 2013-03-15 13:42:02 +0000 | [diff] [blame] | 688 | EXPECT_EQ("/*\n" |
| 689 | " 1. This is a comment with non-trivial formatting.\n" |
| 690 | " 1.1. We have to indent/outdent all lines equally\n" |
| 691 | " 1.1.1. to keep the formatting.\n" |
| 692 | " */", |
| 693 | format(" /*\n" |
| 694 | " 1. This is a comment with non-trivial formatting.\n" |
| 695 | " 1.1. We have to indent/outdent all lines equally\n" |
| 696 | " 1.1.1. to keep the formatting.\n" |
| 697 | " */")); |
| 698 | EXPECT_EQ("/*\n" |
| 699 | " Don't try to outdent if there's not enough inentation.\n" |
| 700 | " */", |
| 701 | format(" /*\n" |
| 702 | " Don't try to outdent if there's not enough inentation.\n" |
| 703 | " */")); |
Alexander Kornienko | f753615 | 2013-03-14 16:10:54 +0000 | [diff] [blame] | 704 | } |
| 705 | |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 706 | TEST_F(FormatTest, SplitsLongCxxComments) { |
| 707 | EXPECT_EQ("// A comment that\n" |
| 708 | "// doesn't fit on\n" |
| 709 | "// one line", |
| 710 | format("// A comment that doesn't fit on one line", |
| 711 | getLLVMStyleWithColumns(20))); |
Alexander Kornienko | 919398b | 2013-04-17 17:34:05 +0000 | [diff] [blame] | 712 | EXPECT_EQ("// a b c d\n" |
| 713 | "// e f g\n" |
| 714 | "// h i j k", |
| 715 | format("// a b c d e f g h i j k", |
| 716 | getLLVMStyleWithColumns(10))); |
| 717 | EXPECT_EQ("// a b c d\n" |
| 718 | "// e f g\n" |
| 719 | "// h i j k", |
| 720 | format("\\\n// a b c d e f g h i j k", |
| 721 | getLLVMStyleWithColumns(10))); |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 722 | EXPECT_EQ("if (true) // A comment that\n" |
| 723 | " // doesn't fit on\n" |
| 724 | " // one line", |
| 725 | format("if (true) // A comment that doesn't fit on one line ", |
| 726 | getLLVMStyleWithColumns(30))); |
| 727 | EXPECT_EQ("// Don't_touch_leading_whitespace", |
| 728 | format("// Don't_touch_leading_whitespace", |
| 729 | getLLVMStyleWithColumns(20))); |
| 730 | EXPECT_EQ( |
| 731 | "//Don't add leading\n" |
| 732 | "//whitespace", |
| 733 | format("//Don't add leading whitespace", getLLVMStyleWithColumns(20))); |
Alexander Kornienko | 9fdc00a | 2013-03-28 18:40:55 +0000 | [diff] [blame] | 734 | EXPECT_EQ("// A comment before\n" |
| 735 | "// a macro\n" |
| 736 | "// definition\n" |
| 737 | "#define a b", |
| 738 | format("// A comment before a macro definition\n" |
| 739 | "#define a b", |
| 740 | getLLVMStyleWithColumns(20))); |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 741 | } |
| 742 | |
Alexander Kornienko | f52d527 | 2013-04-02 13:04:06 +0000 | [diff] [blame] | 743 | TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) { |
| 744 | EXPECT_EQ("namespace {}\n// Test\n#define A", |
| 745 | format("namespace {}\n // Test\n#define A")); |
| 746 | EXPECT_EQ("namespace {}\n/* Test */\n#define A", |
| 747 | format("namespace {}\n /* Test */\n#define A")); |
| 748 | EXPECT_EQ("namespace {}\n/* Test */ #define A", |
| 749 | format("namespace {}\n /* Test */ #define A")); |
| 750 | } |
| 751 | |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 752 | TEST_F(FormatTest, SplitsLongLinesInComments) { |
| 753 | EXPECT_EQ("/* This is a long\n" |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 754 | " * comment that\n" |
| 755 | " * doesn't\n" |
| 756 | " * fit on one line.\n" |
| 757 | " */", |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 758 | format("/* " |
| 759 | "This is a long " |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 760 | "comment that " |
| 761 | "doesn't " |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 762 | "fit on one line. */", |
| 763 | getLLVMStyleWithColumns(20))); |
Alexander Kornienko | 919398b | 2013-04-17 17:34:05 +0000 | [diff] [blame] | 764 | EXPECT_EQ("/* a b c d\n" |
| 765 | " * e f g\n" |
| 766 | " * h i j k\n" |
| 767 | " */", |
| 768 | format("/* a b c d e f g h i j k */", |
| 769 | getLLVMStyleWithColumns(10))); |
| 770 | EXPECT_EQ("/* a b c d\n" |
| 771 | " * e f g\n" |
| 772 | " * h i j k\n" |
| 773 | " */", |
| 774 | format("\\\n/* a b c d e f g h i j k */", |
| 775 | getLLVMStyleWithColumns(10))); |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 776 | EXPECT_EQ("/*\n" |
| 777 | "This is a long\n" |
| 778 | "comment that doesn't\n" |
| 779 | "fit on one line.\n" |
| 780 | "*/", |
| 781 | format("/*\n" |
| 782 | "This is a long " |
| 783 | "comment that doesn't " |
| 784 | "fit on one line. \n" |
| 785 | "*/", getLLVMStyleWithColumns(20))); |
| 786 | EXPECT_EQ("/*\n" |
| 787 | " * This is a long\n" |
| 788 | " * comment that\n" |
| 789 | " * doesn't fit on\n" |
| 790 | " * one line.\n" |
| 791 | " */", |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 792 | format("/* \n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 793 | " * This is a long " |
| 794 | " comment that " |
| 795 | " doesn't fit on " |
| 796 | " one line. \n" |
| 797 | " */", getLLVMStyleWithColumns(20))); |
| 798 | EXPECT_EQ("/*\n" |
| 799 | " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n" |
| 800 | " * so_it_should_be_broken\n" |
| 801 | " * wherever_a_space_occurs\n" |
| 802 | " */", |
| 803 | format("/*\n" |
| 804 | " * This_is_a_comment_with_words_that_dont_fit_on_one_line " |
| 805 | " so_it_should_be_broken " |
| 806 | " wherever_a_space_occurs \n" |
| 807 | " */", |
| 808 | getLLVMStyleWithColumns(20))); |
| 809 | EXPECT_EQ("/*\n" |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 810 | " * This_comment_can_not_be_broken_into_lines\n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 811 | " */", |
| 812 | format("/*\n" |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 813 | " * This_comment_can_not_be_broken_into_lines\n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 814 | " */", |
| 815 | getLLVMStyleWithColumns(20))); |
| 816 | EXPECT_EQ("{\n" |
| 817 | " /*\n" |
| 818 | " This is another\n" |
| 819 | " long comment that\n" |
| 820 | " doesn't fit on one\n" |
| 821 | " line 1234567890\n" |
| 822 | " */\n" |
| 823 | "}", |
| 824 | format("{\n" |
| 825 | "/*\n" |
| 826 | "This is another " |
| 827 | " long comment that " |
| 828 | " doesn't fit on one" |
| 829 | " line 1234567890\n" |
| 830 | "*/\n" |
| 831 | "}", getLLVMStyleWithColumns(20))); |
| 832 | EXPECT_EQ("{\n" |
| 833 | " /*\n" |
| 834 | " * This i s\n" |
| 835 | " * another comment\n" |
| 836 | " * t hat doesn' t\n" |
| 837 | " * fit on one l i\n" |
| 838 | " * n e\n" |
| 839 | " */\n" |
| 840 | "}", |
| 841 | format("{\n" |
| 842 | "/*\n" |
| 843 | " * This i s" |
| 844 | " another comment" |
| 845 | " t hat doesn' t" |
| 846 | " fit on one l i" |
| 847 | " n e\n" |
| 848 | " */\n" |
| 849 | "}", getLLVMStyleWithColumns(20))); |
| 850 | EXPECT_EQ("/*\n" |
| 851 | " * This is a long\n" |
| 852 | " * comment that\n" |
| 853 | " * doesn't fit on\n" |
| 854 | " * one line\n" |
| 855 | " */", |
| 856 | format(" /*\n" |
| 857 | " * This is a long comment that doesn't fit on one line\n" |
| 858 | " */", getLLVMStyleWithColumns(20))); |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 859 | EXPECT_EQ("{\n" |
| 860 | " if (something) /* This is a\n" |
| 861 | "long comment */\n" |
| 862 | " ;\n" |
| 863 | "}", |
| 864 | format("{\n" |
| 865 | " if (something) /* This is a long comment */\n" |
| 866 | " ;\n" |
| 867 | "}", |
| 868 | getLLVMStyleWithColumns(30))); |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 869 | } |
| 870 | |
| 871 | TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) { |
| 872 | EXPECT_EQ("#define X \\\n" |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 873 | " /* \\\n" |
| 874 | " Test \\\n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 875 | " Macro comment \\\n" |
| 876 | " with a long \\\n" |
| 877 | " line \\\n" |
Alexander Kornienko | 70ce788 | 2013-04-15 14:28:00 +0000 | [diff] [blame] | 878 | " */ \\\n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 879 | " A + B", |
| 880 | format("#define X \\\n" |
| 881 | " /*\n" |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 882 | " Test\n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 883 | " Macro comment with a long line\n" |
| 884 | " */ \\\n" |
| 885 | " A + B", |
| 886 | getLLVMStyleWithColumns(20))); |
| 887 | EXPECT_EQ("#define X \\\n" |
| 888 | " /* Macro comment \\\n" |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 889 | " with a long \\\n" |
Alexander Kornienko | 70ce788 | 2013-04-15 14:28:00 +0000 | [diff] [blame] | 890 | " line */ \\\n" |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 891 | " A + B", |
| 892 | format("#define X \\\n" |
| 893 | " /* Macro comment with a long\n" |
| 894 | " line */ \\\n" |
| 895 | " A + B", |
| 896 | getLLVMStyleWithColumns(20))); |
| 897 | EXPECT_EQ("#define X \\\n" |
| 898 | " /* Macro comment \\\n" |
| 899 | " * with a long \\\n" |
Alexander Kornienko | 70ce788 | 2013-04-15 14:28:00 +0000 | [diff] [blame] | 900 | " * line */ \\\n" |
Alexander Kornienko | 052685c | 2013-03-19 17:41:36 +0000 | [diff] [blame] | 901 | " A + B", |
| 902 | format("#define X \\\n" |
| 903 | " /* Macro comment with a long line */ \\\n" |
| 904 | " A + B", |
| 905 | getLLVMStyleWithColumns(20))); |
| 906 | } |
| 907 | |
Daniel Jasper | 2c6cc48 | 2013-01-17 12:53:34 +0000 | [diff] [blame] | 908 | TEST_F(FormatTest, CommentsInStaticInitializers) { |
| 909 | EXPECT_EQ( |
| 910 | "static SomeType type = { aaaaaaaaaaaaaaaaaaaa, /* comment */\n" |
| 911 | " aaaaaaaaaaaaaaaaaaaa /* comment */,\n" |
| 912 | " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n" |
| 913 | " aaaaaaaaaaaaaaaaaaaa, // comment\n" |
| 914 | " aaaaaaaaaaaaaaaaaaaa };", |
| 915 | format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n" |
| 916 | " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n" |
| 917 | " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n" |
| 918 | " aaaaaaaaaaaaaaaaaaaa , // comment\n" |
| 919 | " aaaaaaaaaaaaaaaaaaaa };")); |
| 920 | verifyFormat("static SomeType type = { aaaaaaaaaaa, // comment for aa...\n" |
| 921 | " bbbbbbbbbbb, ccccccccccc };"); |
| 922 | verifyFormat("static SomeType type = { aaaaaaaaaaa,\n" |
| 923 | " // comment for bb....\n" |
| 924 | " bbbbbbbbbbb, ccccccccccc };"); |
| 925 | verifyGoogleFormat( |
| 926 | "static SomeType type = { aaaaaaaaaaa, // comment for aa...\n" |
Daniel Jasper | f343cab | 2013-01-31 14:59:26 +0000 | [diff] [blame] | 927 | " bbbbbbbbbbb, ccccccccccc };"); |
Daniel Jasper | 2c6cc48 | 2013-01-17 12:53:34 +0000 | [diff] [blame] | 928 | verifyGoogleFormat("static SomeType type = { aaaaaaaaaaa,\n" |
| 929 | " // comment for bb....\n" |
Daniel Jasper | f343cab | 2013-01-31 14:59:26 +0000 | [diff] [blame] | 930 | " bbbbbbbbbbb, ccccccccccc };"); |
Daniel Jasper | 2c6cc48 | 2013-01-17 12:53:34 +0000 | [diff] [blame] | 931 | |
Daniel Jasper | f343cab | 2013-01-31 14:59:26 +0000 | [diff] [blame] | 932 | verifyFormat("S s = { { a, b, c }, // Group #1\n" |
| 933 | " { d, e, f }, // Group #2\n" |
| 934 | " { g, h, i } }; // Group #3"); |
| 935 | verifyFormat("S s = { { // Group #1\n" |
| 936 | " a, b, c },\n" |
| 937 | " { // Group #2\n" |
| 938 | " d, e, f },\n" |
| 939 | " { // Group #3\n" |
| 940 | " g, h, i } };"); |
Daniel Jasper | c4615b7 | 2013-02-20 12:56:39 +0000 | [diff] [blame] | 941 | |
| 942 | EXPECT_EQ("S s = {\n" |
| 943 | " // Some comment\n" |
Daniel Jasper | 1ef81d5 | 2013-02-26 13:10:34 +0000 | [diff] [blame] | 944 | " a,\n" |
Daniel Jasper | c4615b7 | 2013-02-20 12:56:39 +0000 | [diff] [blame] | 945 | "\n" |
| 946 | " // Comment after empty line\n" |
| 947 | " b\n" |
Daniel Jasper | 1ef81d5 | 2013-02-26 13:10:34 +0000 | [diff] [blame] | 948 | "}", |
| 949 | format("S s = {\n" |
| 950 | " // Some comment\n" |
| 951 | " a,\n" |
| 952 | " \n" |
| 953 | " // Comment after empty line\n" |
| 954 | " b\n" |
| 955 | "}")); |
| 956 | EXPECT_EQ("S s = { a, b };", format("S s = {\n" |
Daniel Jasper | 84a1a63 | 2013-02-26 13:18:08 +0000 | [diff] [blame] | 957 | " a,\n" |
| 958 | "\n" |
| 959 | " b\n" |
| 960 | "};")); |
Daniel Jasper | 25e81b2 | 2013-02-28 15:04:12 +0000 | [diff] [blame] | 961 | verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n" |
| 962 | " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" |
| 963 | " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" |
| 964 | " 0x00, 0x00, 0x00, 0x00 // comment\n" |
| 965 | "};"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 966 | } |
| 967 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 968 | //===----------------------------------------------------------------------===// |
| 969 | // Tests for classes, namespaces, etc. |
| 970 | //===----------------------------------------------------------------------===// |
| 971 | |
| 972 | TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) { |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 973 | verifyFormat("class A {\n};"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 974 | } |
| 975 | |
| 976 | TEST_F(FormatTest, UnderstandsAccessSpecifiers) { |
| 977 | verifyFormat("class A {\n" |
| 978 | "public:\n" |
Daniel Jasper | ac3223e | 2013-04-10 09:49:49 +0000 | [diff] [blame] | 979 | "public: // comment\n" |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 980 | "protected:\n" |
| 981 | "private:\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 982 | " void f() {}\n" |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 983 | "};"); |
| 984 | verifyGoogleFormat("class A {\n" |
| 985 | " public:\n" |
| 986 | " protected:\n" |
| 987 | " private:\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 988 | " void f() {}\n" |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 989 | "};"); |
| 990 | } |
| 991 | |
Alexander Kornienko | 94b748f | 2013-03-27 17:08:02 +0000 | [diff] [blame] | 992 | TEST_F(FormatTest, SeparatesLogicalBlocks) { |
| 993 | EXPECT_EQ("class A {\n" |
| 994 | "public:\n" |
| 995 | " void f();\n" |
| 996 | "\n" |
| 997 | "private:\n" |
| 998 | " void g() {}\n" |
| 999 | " // test\n" |
| 1000 | "protected:\n" |
| 1001 | " int h;\n" |
| 1002 | "};", |
| 1003 | format("class A {\n" |
| 1004 | "public:\n" |
| 1005 | "void f();\n" |
| 1006 | "private:\n" |
| 1007 | "void g() {}\n" |
| 1008 | "// test\n" |
| 1009 | "protected:\n" |
| 1010 | "int h;\n" |
| 1011 | "};")); |
| 1012 | } |
| 1013 | |
Daniel Jasper | 6b119d6 | 2013-04-05 17:22:09 +0000 | [diff] [blame] | 1014 | TEST_F(FormatTest, FormatsClasses) { |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1015 | verifyFormat("class A : public B {\n};"); |
| 1016 | verifyFormat("class A : public ::B {\n};"); |
Daniel Jasper | 6cabab4 | 2013-02-14 08:42:54 +0000 | [diff] [blame] | 1017 | |
| 1018 | verifyFormat( |
| 1019 | "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" |
| 1020 | " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {\n" |
| 1021 | "};\n"); |
Daniel Jasper | c194c95 | 2013-05-06 06:45:09 +0000 | [diff] [blame] | 1022 | verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n" |
| 1023 | " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" |
| 1024 | " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {\n" |
Daniel Jasper | 6cabab4 | 2013-02-14 08:42:54 +0000 | [diff] [blame] | 1025 | "};\n"); |
| 1026 | verifyFormat( |
| 1027 | "class A : public B, public C, public D, public E, public F, public G {\n" |
| 1028 | "};"); |
| 1029 | verifyFormat("class AAAAAAAAAAAA : public B,\n" |
| 1030 | " public C,\n" |
| 1031 | " public D,\n" |
| 1032 | " public E,\n" |
| 1033 | " public F,\n" |
| 1034 | " public G {\n" |
| 1035 | "};"); |
Daniel Jasper | 6b119d6 | 2013-04-05 17:22:09 +0000 | [diff] [blame] | 1036 | |
| 1037 | verifyFormat("class\n" |
| 1038 | " ReallyReallyLongClassName {\n};", |
| 1039 | getLLVMStyleWithColumns(32)); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 1040 | } |
| 1041 | |
Manuel Klimek | de76854 | 2013-01-07 18:10:23 +0000 | [diff] [blame] | 1042 | TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) { |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1043 | verifyFormat("class A {\n} a, b;"); |
| 1044 | verifyFormat("struct A {\n} a, b;"); |
| 1045 | verifyFormat("union A {\n} a;"); |
Manuel Klimek | de76854 | 2013-01-07 18:10:23 +0000 | [diff] [blame] | 1046 | } |
| 1047 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1048 | TEST_F(FormatTest, FormatsEnum) { |
Alexander Kornienko | a166e73 | 2012-12-04 14:46:19 +0000 | [diff] [blame] | 1049 | verifyFormat("enum {\n" |
| 1050 | " Zero,\n" |
| 1051 | " One = 1,\n" |
| 1052 | " Two = One + 1,\n" |
| 1053 | " Three = (One + Two),\n" |
| 1054 | " Four = (Zero && (One ^ Two)) | (One << Two),\n" |
| 1055 | " Five = (One, Two, Three, Four, 5)\n" |
| 1056 | "};"); |
| 1057 | verifyFormat("enum Enum {\n" |
| 1058 | "};"); |
| 1059 | verifyFormat("enum {\n" |
| 1060 | "};"); |
Manuel Klimek | 308232c | 2013-01-21 19:17:52 +0000 | [diff] [blame] | 1061 | verifyFormat("enum X E {\n} d;"); |
| 1062 | verifyFormat("enum __attribute__((...)) E {\n} d;"); |
| 1063 | verifyFormat("enum __declspec__((...)) E {\n} d;"); |
| 1064 | verifyFormat("enum X f() {\n a();\n return 42;\n}"); |
Alexander Kornienko | a166e73 | 2012-12-04 14:46:19 +0000 | [diff] [blame] | 1065 | } |
| 1066 | |
Nico Weber | efaddc0 | 2013-01-14 05:49:49 +0000 | [diff] [blame] | 1067 | TEST_F(FormatTest, FormatsBitfields) { |
| 1068 | verifyFormat("struct Bitfields {\n" |
| 1069 | " unsigned sClass : 8;\n" |
| 1070 | " unsigned ValueKind : 2;\n" |
| 1071 | "};"); |
| 1072 | } |
| 1073 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1074 | TEST_F(FormatTest, FormatsNamespaces) { |
| 1075 | verifyFormat("namespace some_namespace {\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1076 | "class A {\n};\n" |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1077 | "void f() { f(); }\n" |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1078 | "}"); |
| 1079 | verifyFormat("namespace {\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1080 | "class A {\n};\n" |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1081 | "void f() { f(); }\n" |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1082 | "}"); |
Dmitri Gribenko | 1f94f2b | 2012-12-30 21:27:25 +0000 | [diff] [blame] | 1083 | verifyFormat("inline namespace X {\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1084 | "class A {\n};\n" |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1085 | "void f() { f(); }\n" |
Dmitri Gribenko | 1f94f2b | 2012-12-30 21:27:25 +0000 | [diff] [blame] | 1086 | "}"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1087 | verifyFormat("using namespace some_namespace;\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1088 | "class A {\n};\n" |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1089 | "void f() { f(); }"); |
Manuel Klimek | 7fc2db0 | 2013-02-06 16:08:09 +0000 | [diff] [blame] | 1090 | |
| 1091 | // This code is more common than we thought; if we |
| 1092 | // layout this correctly the semicolon will go into |
| 1093 | // its own line, which is undesireable. |
| 1094 | verifyFormat("namespace {\n};"); |
| 1095 | verifyFormat("namespace {\n" |
| 1096 | "class A {\n" |
| 1097 | "};\n" |
| 1098 | "};"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1099 | } |
| 1100 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1101 | TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); } |
Manuel Klimek | d19dc2d | 2013-01-21 14:32:05 +0000 | [diff] [blame] | 1102 | |
Daniel Jasper | 923ebef | 2013-03-14 13:45:21 +0000 | [diff] [blame] | 1103 | TEST_F(FormatTest, FormatsInlineASM) { |
| 1104 | verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));"); |
| 1105 | verifyFormat( |
| 1106 | "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n" |
| 1107 | " \"cpuid\\n\\t\"\n" |
| 1108 | " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n" |
| 1109 | " : \"=a\" (*rEAX), \"=S\" (*rEBX), \"=c\" (*rECX), \"=d\" (*rEDX)\n" |
| 1110 | " : \"a\"(value));"); |
| 1111 | } |
| 1112 | |
Nico Weber | a9ccdd1 | 2013-01-07 16:36:17 +0000 | [diff] [blame] | 1113 | TEST_F(FormatTest, FormatTryCatch) { |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1114 | // FIXME: Handle try-catch explicitly in the UnwrappedLineParser, then we'll |
| 1115 | // also not create single-line-blocks. |
Nico Weber | a9ccdd1 | 2013-01-07 16:36:17 +0000 | [diff] [blame] | 1116 | verifyFormat("try {\n" |
| 1117 | " throw a * b;\n" |
| 1118 | "}\n" |
| 1119 | "catch (int a) {\n" |
| 1120 | " // Do nothing.\n" |
| 1121 | "}\n" |
| 1122 | "catch (...) {\n" |
| 1123 | " exit(42);\n" |
| 1124 | "}"); |
| 1125 | |
| 1126 | // Function-level try statements. |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1127 | verifyFormat("int f() try { return 4; }\n" |
Nico Weber | a9ccdd1 | 2013-01-07 16:36:17 +0000 | [diff] [blame] | 1128 | "catch (...) {\n" |
| 1129 | " return 5;\n" |
| 1130 | "}"); |
| 1131 | verifyFormat("class A {\n" |
| 1132 | " int a;\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 1133 | " A() try : a(0) {}\n" |
Nico Weber | a9ccdd1 | 2013-01-07 16:36:17 +0000 | [diff] [blame] | 1134 | " catch (...) {\n" |
| 1135 | " throw;\n" |
| 1136 | " }\n" |
| 1137 | "};\n"); |
| 1138 | } |
| 1139 | |
| 1140 | TEST_F(FormatTest, FormatObjCTryCatch) { |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 1141 | verifyFormat("@try {\n" |
| 1142 | " f();\n" |
| 1143 | "}\n" |
| 1144 | "@catch (NSException e) {\n" |
| 1145 | " @throw;\n" |
| 1146 | "}\n" |
| 1147 | "@finally {\n" |
| 1148 | " exit(42);\n" |
| 1149 | "}"); |
Nico Weber | a9ccdd1 | 2013-01-07 16:36:17 +0000 | [diff] [blame] | 1150 | } |
| 1151 | |
Daniel Jasper | 05b1ac8 | 2012-12-17 11:29:41 +0000 | [diff] [blame] | 1152 | TEST_F(FormatTest, StaticInitializers) { |
| 1153 | verifyFormat("static SomeClass SC = { 1, 'a' };"); |
| 1154 | |
| 1155 | // FIXME: Format like enums if the static initializer does not fit on a line. |
| 1156 | verifyFormat( |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 1157 | "static SomeClass WithALoooooooooooooooooooongName = {\n" |
Manuel Klimek | c8c8a47 | 2013-01-10 15:58:26 +0000 | [diff] [blame] | 1158 | " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" |
| 1159 | "};"); |
| 1160 | |
| 1161 | verifyFormat( |
| 1162 | "static SomeClass = { a, b, c, d, e, f, g, h, i, j,\n" |
| 1163 | " looooooooooooooooooooooooooooooooooongname,\n" |
| 1164 | " looooooooooooooooooooooooooooooong };"); |
Daniel Jasper | f343cab | 2013-01-31 14:59:26 +0000 | [diff] [blame] | 1165 | // Allow bin-packing in static initializers as this would often lead to |
| 1166 | // terrible results, e.g.: |
| 1167 | verifyGoogleFormat( |
| 1168 | "static SomeClass = { a, b, c, d, e, f, g, h, i, j,\n" |
| 1169 | " looooooooooooooooooooooooooooooooooongname,\n" |
| 1170 | " looooooooooooooooooooooooooooooong };"); |
Daniel Jasper | 05b1ac8 | 2012-12-17 11:29:41 +0000 | [diff] [blame] | 1171 | } |
| 1172 | |
Manuel Klimek | 2c7739e | 2013-01-14 16:41:43 +0000 | [diff] [blame] | 1173 | TEST_F(FormatTest, NestedStaticInitializers) { |
| 1174 | verifyFormat("static A x = { { {} } };\n"); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1175 | verifyFormat("static A x = { { { init1, init2, init3, init4 },\n" |
| 1176 | " { init1, init2, init3, init4 } } };"); |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1177 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1178 | verifyFormat("somes Status::global_reps[3] = {\n" |
| 1179 | " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n" |
| 1180 | " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n" |
| 1181 | " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n" |
| 1182 | "};"); |
| 1183 | verifyGoogleFormat("somes Status::global_reps[3] = {\n" |
| 1184 | " { kGlobalRef, OK_CODE, NULL, NULL, NULL },\n" |
| 1185 | " { kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL },\n" |
| 1186 | " { kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL }\n" |
| 1187 | "};"); |
Manuel Klimek | 2c7739e | 2013-01-14 16:41:43 +0000 | [diff] [blame] | 1188 | verifyFormat( |
| 1189 | "CGRect cg_rect = { { rect.fLeft, rect.fTop },\n" |
| 1190 | " { rect.fRight - rect.fLeft, rect.fBottom - rect.fTop" |
| 1191 | " } };"); |
| 1192 | |
Daniel Jasper | f343cab | 2013-01-31 14:59:26 +0000 | [diff] [blame] | 1193 | verifyFormat( |
| 1194 | "SomeArrayOfSomeType a = { { { 1, 2, 3 }, { 1, 2, 3 },\n" |
| 1195 | " { 111111111111111111111111111111,\n" |
| 1196 | " 222222222222222222222222222222,\n" |
| 1197 | " 333333333333333333333333333333 },\n" |
| 1198 | " { 1, 2, 3 }, { 1, 2, 3 } } };"); |
Daniel Jasper | 6bd0232 | 2013-02-03 18:07:15 +0000 | [diff] [blame] | 1199 | verifyFormat( |
| 1200 | "SomeArrayOfSomeType a = { { { 1, 2, 3 } }, { { 1, 2, 3 } },\n" |
| 1201 | " { { 111111111111111111111111111111,\n" |
| 1202 | " 222222222222222222222222222222,\n" |
| 1203 | " 333333333333333333333333333333 } },\n" |
| 1204 | " { { 1, 2, 3 } }, { { 1, 2, 3 } } };"); |
Daniel Jasper | f343cab | 2013-01-31 14:59:26 +0000 | [diff] [blame] | 1205 | |
Nico Weber | 6a21a55 | 2013-01-18 02:43:57 +0000 | [diff] [blame] | 1206 | // FIXME: We might at some point want to handle this similar to parameter |
Manuel Klimek | 2c7739e | 2013-01-14 16:41:43 +0000 | [diff] [blame] | 1207 | // lists, where we have an option to put each on a single line. |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1208 | verifyFormat( |
| 1209 | "struct {\n" |
| 1210 | " unsigned bit;\n" |
| 1211 | " const char *const name;\n" |
| 1212 | "} kBitsToOs[] = { { kOsMac, \"Mac\" }, { kOsWin, \"Windows\" },\n" |
| 1213 | " { kOsLinux, \"Linux\" }, { kOsCrOS, \"Chrome OS\" } };"); |
Manuel Klimek | 2c7739e | 2013-01-14 16:41:43 +0000 | [diff] [blame] | 1214 | } |
| 1215 | |
Manuel Klimek | a080a18 | 2013-01-02 16:30:12 +0000 | [diff] [blame] | 1216 | TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) { |
| 1217 | verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro(" |
| 1218 | " \\\n" |
| 1219 | " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)"); |
| 1220 | } |
| 1221 | |
Daniel Jasper | 7160751 | 2013-01-07 10:48:50 +0000 | [diff] [blame] | 1222 | TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) { |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 1223 | verifyFormat( |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 1224 | "virtual void write(ELFWriter *writerrr,\n" |
| 1225 | " OwningPtr<FileOutputBuffer> &buffer) = 0;"); |
Daniel Jasper | 7160751 | 2013-01-07 10:48:50 +0000 | [diff] [blame] | 1226 | } |
| 1227 | |
Manuel Klimek | bd04f2a | 2013-01-31 15:58:48 +0000 | [diff] [blame] | 1228 | TEST_F(FormatTest, LayoutUnknownPPDirective) { |
| 1229 | EXPECT_EQ("#123 \"A string literal\"", |
| 1230 | format(" # 123 \"A string literal\"")); |
| 1231 | EXPECT_EQ("#;", format("#;")); |
Manuel Klimek | dd5b101 | 2013-01-07 10:03:37 +0000 | [diff] [blame] | 1232 | verifyFormat("#\n;\n;\n;"); |
Manuel Klimek | a080a18 | 2013-01-02 16:30:12 +0000 | [diff] [blame] | 1233 | } |
| 1234 | |
| 1235 | TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) { |
| 1236 | EXPECT_EQ("#line 42 \"test\"\n", |
| 1237 | format("# \\\n line \\\n 42 \\\n \"test\"\n")); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1238 | EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n", |
| 1239 | getLLVMStyleWithColumns(12))); |
Manuel Klimek | a080a18 | 2013-01-02 16:30:12 +0000 | [diff] [blame] | 1240 | } |
| 1241 | |
| 1242 | TEST_F(FormatTest, EndOfFileEndsPPDirective) { |
| 1243 | EXPECT_EQ("#line 42 \"test\"", |
| 1244 | format("# \\\n line \\\n 42 \\\n \"test\"")); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1245 | EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B")); |
Manuel Klimek | a080a18 | 2013-01-02 16:30:12 +0000 | [diff] [blame] | 1246 | } |
| 1247 | |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 1248 | TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) { |
Daniel Jasper | a4d4621 | 2013-02-28 11:05:57 +0000 | [diff] [blame] | 1249 | verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13)); |
| 1250 | verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12)); |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 1251 | verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12)); |
Daniel Jasper | a4d4621 | 2013-02-28 11:05:57 +0000 | [diff] [blame] | 1252 | // FIXME: We never break before the macro name. |
| 1253 | verifyFormat("#define AA(\\\n B)", getLLVMStyleWithColumns(12)); |
Daniel Jasper | e0b15ea | 2013-01-14 15:40:57 +0000 | [diff] [blame] | 1254 | |
| 1255 | verifyFormat("#define A A\n#define A A"); |
| 1256 | verifyFormat("#define A(X) A\n#define A A"); |
| 1257 | |
Daniel Jasper | a4d4621 | 2013-02-28 11:05:57 +0000 | [diff] [blame] | 1258 | verifyFormat("#define Something Other", getLLVMStyleWithColumns(23)); |
| 1259 | verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22)); |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 1260 | } |
| 1261 | |
| 1262 | TEST_F(FormatTest, HandlePreprocessorDirectiveContext) { |
Alexander Kornienko | 9fdc00a | 2013-03-28 18:40:55 +0000 | [diff] [blame] | 1263 | EXPECT_EQ("// somecomment\n" |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1264 | "#include \"a.h\"\n" |
Daniel Jasper | a4d4621 | 2013-02-28 11:05:57 +0000 | [diff] [blame] | 1265 | "#define A( \\\n" |
| 1266 | " A, B)\n" |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1267 | "#include \"b.h\"\n" |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 1268 | "// somecomment\n", |
Alexander Kornienko | 9fdc00a | 2013-03-28 18:40:55 +0000 | [diff] [blame] | 1269 | format(" // somecomment\n" |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1270 | " #include \"a.h\"\n" |
| 1271 | "#define A(A,\\\n" |
| 1272 | " B)\n" |
| 1273 | " #include \"b.h\"\n" |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 1274 | " // somecomment\n", |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1275 | getLLVMStyleWithColumns(13))); |
Manuel Klimek | 060143e | 2013-01-02 18:33:23 +0000 | [diff] [blame] | 1276 | } |
| 1277 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1278 | TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); } |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1279 | |
| 1280 | TEST_F(FormatTest, LayoutCodeInMacroDefinitions) { |
| 1281 | EXPECT_EQ("#define A \\\n" |
| 1282 | " c; \\\n" |
| 1283 | " e;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1284 | "f;", |
| 1285 | format("#define A c; e;\n" |
| 1286 | "f;", |
| 1287 | getLLVMStyleWithColumns(14))); |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1288 | } |
| 1289 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1290 | TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); } |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1291 | |
| 1292 | TEST_F(FormatTest, LayoutSingleUnwrappedLineInMacro) { |
Daniel Jasper | 26f7e78 | 2013-01-08 14:56:18 +0000 | [diff] [blame] | 1293 | EXPECT_EQ("# define A\\\n b;", |
| 1294 | format("# define A b;", 11, 2, getLLVMStyleWithColumns(11))); |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1295 | } |
| 1296 | |
| 1297 | TEST_F(FormatTest, MacroDefinitionInsideStatement) { |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 1298 | EXPECT_EQ("int x,\n" |
| 1299 | "#define A\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1300 | " y;", |
| 1301 | format("int x,\n#define A\ny;")); |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1302 | } |
| 1303 | |
Manuel Klimek | 6f8424b | 2013-01-05 21:34:55 +0000 | [diff] [blame] | 1304 | TEST_F(FormatTest, HashInMacroDefinition) { |
| 1305 | verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11)); |
| 1306 | verifyFormat("#define A \\\n" |
| 1307 | " { \\\n" |
| 1308 | " f(#c);\\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1309 | " }", |
| 1310 | getLLVMStyleWithColumns(11)); |
Daniel Jasper | 765561f | 2013-01-08 16:17:54 +0000 | [diff] [blame] | 1311 | |
| 1312 | verifyFormat("#define A(X) \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1313 | " void function##X()", |
| 1314 | getLLVMStyleWithColumns(22)); |
Daniel Jasper | 765561f | 2013-01-08 16:17:54 +0000 | [diff] [blame] | 1315 | |
| 1316 | verifyFormat("#define A(a, b, c) \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1317 | " void a##b##c()", |
| 1318 | getLLVMStyleWithColumns(22)); |
Daniel Jasper | 765561f | 2013-01-08 16:17:54 +0000 | [diff] [blame] | 1319 | |
Daniel Jasper | e0b15ea | 2013-01-14 15:40:57 +0000 | [diff] [blame] | 1320 | verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22)); |
Manuel Klimek | 6f8424b | 2013-01-05 21:34:55 +0000 | [diff] [blame] | 1321 | } |
| 1322 | |
Manuel Klimek | 7ccbc21 | 2013-01-23 14:37:36 +0000 | [diff] [blame] | 1323 | TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) { |
| 1324 | verifyFormat("#define A (1)"); |
| 1325 | } |
| 1326 | |
Manuel Klimek | a28fc06 | 2013-02-11 12:33:24 +0000 | [diff] [blame] | 1327 | TEST_F(FormatTest, EmptyLinesInMacroDefinitions) { |
| 1328 | EXPECT_EQ("#define A b;", format("#define A \\\n" |
| 1329 | " \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1330 | " b;", |
| 1331 | getLLVMStyleWithColumns(25))); |
Manuel Klimek | a28fc06 | 2013-02-11 12:33:24 +0000 | [diff] [blame] | 1332 | EXPECT_EQ("#define A \\\n" |
| 1333 | " \\\n" |
| 1334 | " a; \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1335 | " b;", |
| 1336 | format("#define A \\\n" |
| 1337 | " \\\n" |
| 1338 | " a; \\\n" |
| 1339 | " b;", |
| 1340 | getLLVMStyleWithColumns(11))); |
Manuel Klimek | a28fc06 | 2013-02-11 12:33:24 +0000 | [diff] [blame] | 1341 | EXPECT_EQ("#define A \\\n" |
| 1342 | " a; \\\n" |
| 1343 | " \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1344 | " b;", |
| 1345 | format("#define A \\\n" |
| 1346 | " a; \\\n" |
| 1347 | " \\\n" |
| 1348 | " b;", |
| 1349 | getLLVMStyleWithColumns(11))); |
Manuel Klimek | a28fc06 | 2013-02-11 12:33:24 +0000 | [diff] [blame] | 1350 | } |
| 1351 | |
Daniel Jasper | 34511fb | 2013-02-19 17:14:38 +0000 | [diff] [blame] | 1352 | TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) { |
Daniel Jasper | cf6d76a | 2013-03-18 12:50:26 +0000 | [diff] [blame] | 1353 | verifyFormat("#define A :"); |
| 1354 | |
Daniel Jasper | 34511fb | 2013-02-19 17:14:38 +0000 | [diff] [blame] | 1355 | // FIXME: Improve formatting of case labels in macros. |
| 1356 | verifyFormat("#define SOMECASES \\\n" |
Daniel Jasper | bcca7e4 | 2013-03-20 10:23:53 +0000 | [diff] [blame] | 1357 | " case 1: \\\n" |
Daniel Jasper | 34511fb | 2013-02-19 17:14:38 +0000 | [diff] [blame] | 1358 | " case 2\n", |
| 1359 | getLLVMStyleWithColumns(20)); |
| 1360 | |
| 1361 | verifyFormat("#define A template <typename T>"); |
Daniel Jasper | 03628b8 | 2013-02-19 20:05:41 +0000 | [diff] [blame] | 1362 | verifyFormat("#define STR(x) #x\n" |
| 1363 | "f(STR(this_is_a_string_literal{));"); |
Daniel Jasper | 34511fb | 2013-02-19 17:14:38 +0000 | [diff] [blame] | 1364 | } |
| 1365 | |
Alexander Kornienko | 3d713a7 | 2013-04-08 22:16:06 +0000 | [diff] [blame] | 1366 | TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) { |
| 1367 | EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" |
| 1368 | "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" |
| 1369 | "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" |
| 1370 | "class X {\n" |
| 1371 | "};\n" |
| 1372 | "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" |
| 1373 | "int *createScopDetectionPass() { return 0; }", |
| 1374 | format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" |
| 1375 | " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" |
| 1376 | " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" |
| 1377 | " class X {};\n" |
| 1378 | " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" |
| 1379 | " int *createScopDetectionPass() { return 0; }")); |
Alexander Kornienko | 99b0e14 | 2013-04-09 16:15:19 +0000 | [diff] [blame] | 1380 | // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as |
| 1381 | // braces, so that inner block is indented one level more. |
| 1382 | EXPECT_EQ("int q() {\n" |
| 1383 | " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" |
| 1384 | " IPC_MESSAGE_HANDLER(xxx, qqq)\n" |
| 1385 | " IPC_END_MESSAGE_MAP()\n" |
| 1386 | "}", |
| 1387 | format("int q() {\n" |
| 1388 | " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" |
| 1389 | " IPC_MESSAGE_HANDLER(xxx, qqq)\n" |
| 1390 | " IPC_END_MESSAGE_MAP()\n" |
| 1391 | "}")); |
| 1392 | EXPECT_EQ("int q() {\n" |
| 1393 | " f(x);\n" |
| 1394 | " f(x) {}\n" |
| 1395 | " f(x)->g();\n" |
| 1396 | " f(x)->*g();\n" |
| 1397 | " f(x).g();\n" |
| 1398 | " f(x) = x;\n" |
| 1399 | " f(x) += x;\n" |
| 1400 | " f(x) -= x;\n" |
| 1401 | " f(x) *= x;\n" |
| 1402 | " f(x) /= x;\n" |
| 1403 | " f(x) %= x;\n" |
| 1404 | " f(x) &= x;\n" |
| 1405 | " f(x) |= x;\n" |
| 1406 | " f(x) ^= x;\n" |
| 1407 | " f(x) >>= x;\n" |
| 1408 | " f(x) <<= x;\n" |
| 1409 | " f(x)[y].z();\n" |
| 1410 | " LOG(INFO) << x;\n" |
| 1411 | " ifstream(x) >> x;\n" |
| 1412 | "}\n", |
| 1413 | format("int q() {\n" |
| 1414 | " f(x)\n;\n" |
| 1415 | " f(x)\n {}\n" |
| 1416 | " f(x)\n->g();\n" |
| 1417 | " f(x)\n->*g();\n" |
| 1418 | " f(x)\n.g();\n" |
| 1419 | " f(x)\n = x;\n" |
| 1420 | " f(x)\n += x;\n" |
| 1421 | " f(x)\n -= x;\n" |
| 1422 | " f(x)\n *= x;\n" |
| 1423 | " f(x)\n /= x;\n" |
| 1424 | " f(x)\n %= x;\n" |
| 1425 | " f(x)\n &= x;\n" |
| 1426 | " f(x)\n |= x;\n" |
| 1427 | " f(x)\n ^= x;\n" |
| 1428 | " f(x)\n >>= x;\n" |
| 1429 | " f(x)\n <<= x;\n" |
| 1430 | " f(x)\n[y].z();\n" |
| 1431 | " LOG(INFO)\n << x;\n" |
| 1432 | " ifstream(x)\n >> x;\n" |
| 1433 | "}\n")); |
| 1434 | EXPECT_EQ("int q() {\n" |
| 1435 | " f(x)\n" |
| 1436 | " if (1) {\n" |
| 1437 | " }\n" |
| 1438 | " f(x)\n" |
| 1439 | " while (1) {\n" |
| 1440 | " }\n" |
| 1441 | " f(x)\n" |
| 1442 | " g(x);\n" |
| 1443 | " f(x)\n" |
| 1444 | " try {\n" |
| 1445 | " q();\n" |
| 1446 | " }\n" |
| 1447 | " catch (...) {\n" |
| 1448 | " }\n" |
| 1449 | "}\n", |
| 1450 | format("int q() {\n" |
| 1451 | "f(x)\n" |
| 1452 | "if (1) {}\n" |
| 1453 | "f(x)\n" |
| 1454 | "while (1) {}\n" |
| 1455 | "f(x)\n" |
| 1456 | "g(x);\n" |
| 1457 | "f(x)\n" |
| 1458 | "try { q(); } catch (...) {}\n" |
| 1459 | "}\n")); |
| 1460 | EXPECT_EQ("class A {\n" |
| 1461 | " A() : t(0) {}\n" |
| 1462 | " A(X x)\n" // FIXME: function-level try blocks are broken. |
| 1463 | " try : t(0) {\n" |
| 1464 | " }\n" |
| 1465 | " catch (...) {\n" |
| 1466 | " }\n" |
| 1467 | "};", |
| 1468 | format("class A {\n" |
| 1469 | " A()\n : t(0) {}\n" |
| 1470 | " A(X x)\n" |
| 1471 | " try : t(0) {} catch (...) {}\n" |
| 1472 | "};")); |
Alexander Kornienko | 3d713a7 | 2013-04-08 22:16:06 +0000 | [diff] [blame] | 1473 | } |
| 1474 | |
Manuel Klimek | c37b4d6 | 2013-01-05 22:14:16 +0000 | [diff] [blame] | 1475 | TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) { |
| 1476 | EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}")); |
| 1477 | } |
| 1478 | |
Manuel Klimek | f6fd00b | 2013-01-05 22:56:06 +0000 | [diff] [blame] | 1479 | TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1480 | verifyFormat("{\n { a #c; }\n}"); |
Manuel Klimek | f6fd00b | 2013-01-05 22:56:06 +0000 | [diff] [blame] | 1481 | } |
| 1482 | |
Manuel Klimek | a5342db | 2013-01-06 20:07:31 +0000 | [diff] [blame] | 1483 | TEST_F(FormatTest, FormatUnbalancedStructuralElements) { |
| 1484 | EXPECT_EQ("#define A \\\n { \\\n {\nint i;", |
| 1485 | format("#define A { {\nint i;", getLLVMStyleWithColumns(11))); |
| 1486 | EXPECT_EQ("#define A \\\n } \\\n }\nint i;", |
| 1487 | format("#define A } }\nint i;", getLLVMStyleWithColumns(11))); |
| 1488 | } |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1489 | |
Manuel Klimek | 9541938 | 2013-01-07 07:56:50 +0000 | [diff] [blame] | 1490 | TEST_F(FormatTest, EscapedNewlineAtStartOfTokenInMacroDefinition) { |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 1491 | EXPECT_EQ( |
| 1492 | "#define A \\\n int i; \\\n int j;", |
| 1493 | format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11))); |
Manuel Klimek | 9541938 | 2013-01-07 07:56:50 +0000 | [diff] [blame] | 1494 | } |
| 1495 | |
Manuel Klimek | d544c57 | 2013-01-07 09:24:17 +0000 | [diff] [blame] | 1496 | TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) { |
| 1497 | verifyFormat("#define A \\\n" |
| 1498 | " int v( \\\n" |
| 1499 | " a); \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1500 | " int i;", |
| 1501 | getLLVMStyleWithColumns(11)); |
Manuel Klimek | d544c57 | 2013-01-07 09:24:17 +0000 | [diff] [blame] | 1502 | } |
| 1503 | |
Manuel Klimek | a080a18 | 2013-01-02 16:30:12 +0000 | [diff] [blame] | 1504 | TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) { |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 1505 | EXPECT_EQ( |
| 1506 | "#define ALooooooooooooooooooooooooooooooooooooooongMacro(" |
| 1507 | " \\\n" |
| 1508 | " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" |
| 1509 | "\n" |
| 1510 | "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" |
| 1511 | " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n", |
| 1512 | format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro(" |
| 1513 | "\\\n" |
| 1514 | "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" |
| 1515 | " \n" |
| 1516 | " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" |
| 1517 | " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n")); |
Manuel Klimek | a080a18 | 2013-01-02 16:30:12 +0000 | [diff] [blame] | 1518 | } |
| 1519 | |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 1520 | TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) { |
| 1521 | EXPECT_EQ("int\n" |
| 1522 | "#define A\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 1523 | " a;", |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 1524 | format("int\n#define A\na;")); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1525 | verifyFormat("functionCallTo(\n" |
| 1526 | " someOtherFunction(\n" |
| 1527 | " withSomeParameters, whichInSequence,\n" |
| 1528 | " areLongerThanALine(andAnotherCall,\n" |
| 1529 | "#define A B\n" |
| 1530 | " withMoreParamters,\n" |
| 1531 | " whichStronglyInfluenceTheLayout),\n" |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 1532 | " andMoreParameters),\n" |
| 1533 | " trailing);", |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1534 | getLLVMStyleWithColumns(69)); |
Manuel Klimek | 526ed11 | 2013-01-09 15:25:02 +0000 | [diff] [blame] | 1535 | } |
| 1536 | |
Manuel Klimek | bb42bf1 | 2013-01-10 11:52:21 +0000 | [diff] [blame] | 1537 | TEST_F(FormatTest, LayoutBlockInsideParens) { |
| 1538 | EXPECT_EQ("functionCall({\n" |
| 1539 | " int i;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1540 | "});", |
| 1541 | format(" functionCall ( {int i;} );")); |
Manuel Klimek | bb42bf1 | 2013-01-10 11:52:21 +0000 | [diff] [blame] | 1542 | } |
| 1543 | |
| 1544 | TEST_F(FormatTest, LayoutBlockInsideStatement) { |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 1545 | EXPECT_EQ("SOME_MACRO { int i; }\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1546 | "int i;", |
| 1547 | format(" SOME_MACRO {int i;} int i;")); |
Manuel Klimek | bb42bf1 | 2013-01-10 11:52:21 +0000 | [diff] [blame] | 1548 | } |
| 1549 | |
| 1550 | TEST_F(FormatTest, LayoutNestedBlocks) { |
| 1551 | verifyFormat("void AddOsStrings(unsigned bitmask) {\n" |
| 1552 | " struct s {\n" |
| 1553 | " int i;\n" |
| 1554 | " };\n" |
| 1555 | " s kBitsToOs[] = { { 10 } };\n" |
| 1556 | " for (int i = 0; i < 10; ++i)\n" |
| 1557 | " return;\n" |
| 1558 | "}"); |
| 1559 | } |
| 1560 | |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 1561 | TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) { |
| 1562 | EXPECT_EQ("{}", format("{}")); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1563 | |
| 1564 | // Negative test for enum. |
| 1565 | verifyFormat("enum E {\n};"); |
| 1566 | |
| 1567 | // Note that when there's a missing ';', we still join... |
| 1568 | verifyFormat("enum E {}"); |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 1569 | } |
| 1570 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1571 | //===----------------------------------------------------------------------===// |
| 1572 | // Line break tests. |
| 1573 | //===----------------------------------------------------------------------===// |
| 1574 | |
| 1575 | TEST_F(FormatTest, FormatsFunctionDefinition) { |
| 1576 | verifyFormat("void f(int a, int b, int c, int d, int e, int f, int g," |
| 1577 | " int h, int j, int f,\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1578 | " int c, int ddddddddddddd) {}"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1579 | } |
| 1580 | |
| 1581 | TEST_F(FormatTest, FormatsAwesomeMethodCall) { |
| 1582 | verifyFormat( |
Daniel Jasper | 986e17f | 2013-01-28 07:35:34 +0000 | [diff] [blame] | 1583 | "SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n" |
| 1584 | " parameter, parameter, parameter)),\n" |
Daniel Jasper | a4974cf | 2012-12-24 16:43:00 +0000 | [diff] [blame] | 1585 | " SecondLongCall(parameter));"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1586 | } |
| 1587 | |
Daniel Jasper | ae8699b | 2013-01-28 09:35:24 +0000 | [diff] [blame] | 1588 | TEST_F(FormatTest, PreventConfusingIndents) { |
Daniel Jasper | 986e17f | 2013-01-28 07:35:34 +0000 | [diff] [blame] | 1589 | verifyFormat( |
| 1590 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1591 | " aaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1592 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" |
| 1593 | " aaaaaaaaaaaaaaaaaaaaaaaa);"); |
| 1594 | verifyFormat( |
| 1595 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[\n" |
| 1596 | " aaaaaaaaaaaaaaaaaaaaaaaa[\n" |
| 1597 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa],\n" |
| 1598 | " aaaaaaaaaaaaaaaaaaaaaaaa];"); |
| 1599 | verifyFormat( |
| 1600 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" |
| 1601 | " aaaaaaaaaaaaaaaaaaaaaaaa<\n" |
| 1602 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n" |
| 1603 | " aaaaaaaaaaaaaaaaaaaaaaaa>;"); |
Daniel Jasper | ae8699b | 2013-01-28 09:35:24 +0000 | [diff] [blame] | 1604 | verifyFormat("int a = bbbb && ccc && fffff(\n" |
| 1605 | "#define A Just forcing a new line\n" |
| 1606 | " ddd);"); |
Daniel Jasper | 986e17f | 2013-01-28 07:35:34 +0000 | [diff] [blame] | 1607 | } |
| 1608 | |
Daniel Jasper | 11e1380 | 2013-05-08 14:12:04 +0000 | [diff] [blame] | 1609 | TEST_F(FormatTest, LineBreakingInBinaryExpressions) { |
| 1610 | verifyFormat( |
| 1611 | "bool aaaaaaa =\n" |
| 1612 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n" |
| 1613 | " bbbbbbbb();"); |
| 1614 | verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" |
| 1615 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n" |
| 1616 | " ccccccccc == ddddddddddd;"); |
| 1617 | |
| 1618 | verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" |
| 1619 | " aaaaaa) &&\n" |
| 1620 | " bbbbbb && cccccc;"); |
| 1621 | verifyFormat("Whitespaces.addUntouchableComment(\n" |
| 1622 | " SourceMgr.getSpellingColumnNumber(\n" |
| 1623 | " TheLine.Last->FormatTok.Tok.getLocation()) -\n" |
| 1624 | " 1);"); |
| 1625 | } |
| 1626 | |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 1627 | TEST_F(FormatTest, ExpressionIndentation) { |
| 1628 | verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 1629 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 1630 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" |
| 1631 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" |
| 1632 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n" |
| 1633 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n" |
| 1634 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" |
| 1635 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n" |
| 1636 | " ccccccccccccccccccccccccccccccccccccccccc;"); |
| 1637 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" |
| 1638 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 1639 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" |
| 1640 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); |
| 1641 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 1642 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" |
| 1643 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" |
| 1644 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); |
| 1645 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" |
| 1646 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" |
| 1647 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 1648 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); |
| 1649 | } |
| 1650 | |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1651 | TEST_F(FormatTest, ConstructorInitializers) { |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 1652 | verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); |
Daniel Jasper | 7e9bf8c | 2013-01-11 11:37:55 +0000 | [diff] [blame] | 1653 | verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}", |
| 1654 | getLLVMStyleWithColumns(45)); |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1655 | verifyFormat("Constructor()\n" |
| 1656 | " : Inttializer(FitsOnTheLine) {}", |
Daniel Jasper | 7e9bf8c | 2013-01-11 11:37:55 +0000 | [diff] [blame] | 1657 | getLLVMStyleWithColumns(44)); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1658 | verifyFormat("Constructor()\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1659 | " : Inttializer(FitsOnTheLine) {}", |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1660 | getLLVMStyleWithColumns(43)); |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1661 | |
| 1662 | verifyFormat( |
| 1663 | "SomeClass::Constructor()\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1664 | " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1665 | |
| 1666 | verifyFormat( |
| 1667 | "SomeClass::Constructor()\n" |
Daniel Jasper | 7e9bf8c | 2013-01-11 11:37:55 +0000 | [diff] [blame] | 1668 | " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1669 | " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); |
Daniel Jasper | 7e9bf8c | 2013-01-11 11:37:55 +0000 | [diff] [blame] | 1670 | verifyFormat( |
| 1671 | "SomeClass::Constructor()\n" |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1672 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1673 | " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1674 | |
| 1675 | verifyFormat("Constructor()\n" |
| 1676 | " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" |
| 1677 | " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1678 | " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1679 | " aaaaaaaaaaaaaaaaaaaaaaa() {}"); |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1680 | |
Daniel Jasper | 02b771e | 2013-01-28 13:31:35 +0000 | [diff] [blame] | 1681 | verifyFormat("Constructor()\n" |
| 1682 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1683 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); |
Daniel Jasper | 02b771e | 2013-01-28 13:31:35 +0000 | [diff] [blame] | 1684 | |
Daniel Jasper | 9c3e71a | 2013-02-25 15:59:54 +0000 | [diff] [blame] | 1685 | verifyFormat("Constructor(int Parameter = 0)\n" |
| 1686 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" |
| 1687 | " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}"); |
| 1688 | |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1689 | // Here a line could be saved by splitting the second initializer onto two |
| 1690 | // lines, but that is not desireable. |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1691 | verifyFormat("Constructor()\n" |
| 1692 | " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" |
| 1693 | " aaaaaaaaaaa(aaaaaaaaaaa),\n" |
| 1694 | " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1695 | |
Daniel Jasper | b130a54 | 2013-02-15 16:49:44 +0000 | [diff] [blame] | 1696 | FormatStyle OnePerLine = getLLVMStyle(); |
| 1697 | OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; |
| 1698 | verifyFormat("SomeClass::Constructor()\n" |
| 1699 | " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" |
| 1700 | " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1701 | " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1702 | OnePerLine); |
Daniel Jasper | b130a54 | 2013-02-15 16:49:44 +0000 | [diff] [blame] | 1703 | verifyFormat("SomeClass::Constructor()\n" |
| 1704 | " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" |
| 1705 | " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1706 | " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1707 | OnePerLine); |
Daniel Jasper | b130a54 | 2013-02-15 16:49:44 +0000 | [diff] [blame] | 1708 | verifyFormat("MyClass::MyClass(int var)\n" |
| 1709 | " : some_var_(var), // 4 space indent\n" |
| 1710 | " some_other_var_(var + 1) { // lined up\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1711 | "}", |
| 1712 | OnePerLine); |
Daniel Jasper | 3a39ac7 | 2013-02-28 09:39:12 +0000 | [diff] [blame] | 1713 | verifyFormat("Constructor()\n" |
| 1714 | " : aaaaa(aaaaaa),\n" |
| 1715 | " aaaaa(aaaaaa),\n" |
| 1716 | " aaaaa(aaaaaa),\n" |
| 1717 | " aaaaa(aaaaaa),\n" |
| 1718 | " aaaaa(aaaaaa) {}", |
| 1719 | OnePerLine); |
Daniel Jasper | 001bf4e | 2013-04-22 07:59:53 +0000 | [diff] [blame] | 1720 | verifyFormat("Constructor()\n" |
| 1721 | " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1722 | " aaaaaaaaaaaaaaaaaaaaaa) {}", |
| 1723 | OnePerLine); |
Daniel Jasper | fca24bc | 2013-04-25 13:31:51 +0000 | [diff] [blame] | 1724 | } |
| 1725 | |
| 1726 | TEST_F(FormatTest, MemoizationTests) { |
| 1727 | // This breaks if the memoization lookup does not take \c Indent and |
| 1728 | // \c LastSpace into account. |
| 1729 | verifyFormat( |
| 1730 | "extern CFRunLoopTimerRef\n" |
| 1731 | "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n" |
| 1732 | " CFTimeInterval interval, CFOptionFlags flags,\n" |
| 1733 | " CFIndex order, CFRunLoopTimerCallBack callout,\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 1734 | " CFRunLoopTimerContext *context) {}"); |
Daniel Jasper | fca24bc | 2013-04-25 13:31:51 +0000 | [diff] [blame] | 1735 | |
| 1736 | // Deep nesting somewhat works around our memoization. |
| 1737 | verifyFormat( |
| 1738 | "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" |
| 1739 | " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" |
| 1740 | " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" |
| 1741 | " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" |
| 1742 | " aaaaa())))))))))))))))))))))))))))))))))))))));", |
| 1743 | getLLVMStyleWithColumns(65)); |
Daniel Jasper | b312314 | 2013-01-12 07:36:22 +0000 | [diff] [blame] | 1744 | |
| 1745 | // This test takes VERY long when memoization is broken. |
Daniel Jasper | fca24bc | 2013-04-25 13:31:51 +0000 | [diff] [blame] | 1746 | FormatStyle OnePerLine = getLLVMStyle(); |
| 1747 | OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1748 | OnePerLine.BinPackParameters = false; |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1749 | std::string input = "Constructor()\n" |
Daniel Jasper | 3499dda | 2013-01-25 15:43:32 +0000 | [diff] [blame] | 1750 | " : aaaa(a,\n"; |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1751 | for (unsigned i = 0, e = 80; i != e; ++i) { |
| 1752 | input += " a,\n"; |
| 1753 | } |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1754 | input += " a) {}"; |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1755 | verifyFormat(input, OnePerLine); |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 1756 | } |
| 1757 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1758 | TEST_F(FormatTest, BreaksAsHighAsPossible) { |
| 1759 | verifyFormat( |
Alexander Kornienko | 3fd9ccd | 2013-03-12 16:28:18 +0000 | [diff] [blame] | 1760 | "void f() {\n" |
| 1761 | " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n" |
| 1762 | " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n" |
| 1763 | " f();\n" |
| 1764 | "}"); |
Daniel Jasper | 518ee34 | 2013-02-26 13:59:14 +0000 | [diff] [blame] | 1765 | verifyFormat("if (Intervals[i].getRange().getFirst() <\n" |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 1766 | " Intervals[i - 1].getRange().getLast()) {\n}"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 1767 | } |
| 1768 | |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 1769 | TEST_F(FormatTest, BreaksFunctionDeclarations) { |
| 1770 | // Principially, we break function declarations in a certain order: |
| 1771 | // 1) break amongst arguments. |
| 1772 | verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n" |
| 1773 | " Cccccccccccccc cccccccccccccc);"); |
| 1774 | |
| 1775 | // 2) break after return type. |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 1776 | verifyFormat( |
| 1777 | "Aaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 1778 | " bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);"); |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 1779 | |
| 1780 | // 3) break after (. |
| 1781 | verifyFormat( |
| 1782 | "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n" |
| 1783 | " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);"); |
| 1784 | |
| 1785 | // 4) break before after nested name specifiers. |
| 1786 | verifyFormat( |
| 1787 | "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 1788 | " SomeClasssssssssssssssssssssssssssssssssssssss::\n" |
| 1789 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);"); |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 1790 | |
| 1791 | // However, there are exceptions, if a sufficient amount of lines can be |
| 1792 | // saved. |
| 1793 | // FIXME: The precise cut-offs wrt. the number of saved lines might need some |
| 1794 | // more adjusting. |
| 1795 | verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" |
| 1796 | " Cccccccccccccc cccccccccc,\n" |
| 1797 | " Cccccccccccccc cccccccccc,\n" |
| 1798 | " Cccccccccccccc cccccccccc,\n" |
| 1799 | " Cccccccccccccc cccccccccc);"); |
| 1800 | verifyFormat( |
| 1801 | "Aaaaaaaaaaaaaaaaaa\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 1802 | " bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" |
| 1803 | " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" |
| 1804 | " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 1805 | verifyFormat( |
| 1806 | "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" |
| 1807 | " Cccccccccccccc cccccccccc,\n" |
| 1808 | " Cccccccccccccc cccccccccc,\n" |
| 1809 | " Cccccccccccccc cccccccccc,\n" |
| 1810 | " Cccccccccccccc cccccccccc,\n" |
| 1811 | " Cccccccccccccc cccccccccc,\n" |
| 1812 | " Cccccccccccccc cccccccccc);"); |
| 1813 | verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" |
| 1814 | " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" |
| 1815 | " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" |
| 1816 | " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" |
| 1817 | " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); |
Daniel Jasper | 01218ff | 2013-04-15 22:36:37 +0000 | [diff] [blame] | 1818 | |
| 1819 | // Break after multi-line parameters. |
| 1820 | verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1821 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 1822 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1823 | " bbbb bbbb);"); |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 1824 | } |
| 1825 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 1826 | TEST_F(FormatTest, BreaksDesireably) { |
| 1827 | verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" |
| 1828 | " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1829 | " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}"); |
Daniel Jasper | e438bac | 2013-01-23 20:41:06 +0000 | [diff] [blame] | 1830 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1831 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" |
| 1832 | "}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 1833 | |
| 1834 | verifyFormat( |
| 1835 | "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 1836 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 1837 | |
| 1838 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1839 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1840 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); |
Daniel Jasper | a88bb45 | 2012-12-04 10:50:12 +0000 | [diff] [blame] | 1841 | |
| 1842 | verifyFormat( |
| 1843 | "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1844 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" |
| 1845 | " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1846 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));"); |
Daniel Jasper | 33182dd | 2012-12-05 14:57:28 +0000 | [diff] [blame] | 1847 | |
| 1848 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 1849 | " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
| 1850 | |
Daniel Jasper | 723f030 | 2013-01-02 14:40:02 +0000 | [diff] [blame] | 1851 | verifyFormat( |
Alexander Kornienko | 3fd9ccd | 2013-03-12 16:28:18 +0000 | [diff] [blame] | 1852 | "void f() {\n" |
| 1853 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" |
| 1854 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" |
| 1855 | "}"); |
Daniel Jasper | 3499dda | 2013-01-25 15:43:32 +0000 | [diff] [blame] | 1856 | verifyFormat( |
| 1857 | "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1858 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); |
| 1859 | verifyFormat( |
| 1860 | "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1861 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); |
Daniel Jasper | 64f0928 | 2013-03-20 13:53:11 +0000 | [diff] [blame] | 1862 | verifyFormat( |
| 1863 | "aaaaaaaaaaaaaaaaa(\n" |
| 1864 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1865 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 723f030 | 2013-01-02 14:40:02 +0000 | [diff] [blame] | 1866 | |
Daniel Jasper | 33182dd | 2012-12-05 14:57:28 +0000 | [diff] [blame] | 1867 | // This test case breaks on an incorrect memoization, i.e. an optimization not |
| 1868 | // taking into account the StopAt value. |
| 1869 | verifyFormat( |
| 1870 | "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 1871 | " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 1872 | " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 1873 | " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | a4974cf | 2012-12-24 16:43:00 +0000 | [diff] [blame] | 1874 | |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 1875 | verifyFormat("{\n {\n {\n" |
| 1876 | " Annotation.SpaceRequiredBefore =\n" |
| 1877 | " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n" |
| 1878 | " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n" |
| 1879 | " }\n }\n}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 1880 | } |
| 1881 | |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1882 | TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) { |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 1883 | FormatStyle NoBinPacking = getGoogleStyle(); |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1884 | NoBinPacking.BinPackParameters = false; |
| 1885 | verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n" |
| 1886 | " aaaaaaaaaaaaaaaaaaaa,\n" |
| 1887 | " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);", |
| 1888 | NoBinPacking); |
| 1889 | verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n" |
| 1890 | " aaaaaaaaaaaaa,\n" |
| 1891 | " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));", |
| 1892 | NoBinPacking); |
| 1893 | verifyFormat( |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1894 | "aaaaaaaa(aaaaaaaaaaaaa,\n" |
| 1895 | " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1896 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" |
| 1897 | " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1898 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));", |
| 1899 | NoBinPacking); |
| 1900 | verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" |
| 1901 | " .aaaaaaaaaaaaaaaaaa();", |
| 1902 | NoBinPacking); |
| 1903 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 1904 | " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);", |
| 1905 | NoBinPacking); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1906 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1907 | verifyFormat( |
Daniel Jasper | 8f4bd7a | 2013-01-23 10:08:28 +0000 | [diff] [blame] | 1908 | "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1909 | " aaaaaaaaaaaa,\n" |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1910 | " aaaaaaaaaaaa);", |
| 1911 | NoBinPacking); |
| 1912 | verifyFormat( |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1913 | "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n" |
| 1914 | " ddddddddddddddddddddddddddddd),\n" |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1915 | " test);", |
| 1916 | NoBinPacking); |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1917 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1918 | verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1919 | " aaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1920 | " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;", |
| 1921 | NoBinPacking); |
| 1922 | verifyFormat("a(\"a\"\n" |
| 1923 | " \"a\",\n" |
| 1924 | " a);"); |
Daniel Jasper | 8f4bd7a | 2013-01-23 10:08:28 +0000 | [diff] [blame] | 1925 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1926 | NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; |
Daniel Jasper | f157960 | 2013-01-29 16:03:49 +0000 | [diff] [blame] | 1927 | verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n" |
Daniel Jasper | 8f4bd7a | 2013-01-23 10:08:28 +0000 | [diff] [blame] | 1928 | " aaaaaaaaa,\n" |
Daniel Jasper | f157960 | 2013-01-29 16:03:49 +0000 | [diff] [blame] | 1929 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1930 | NoBinPacking); |
Daniel Jasper | fc75908 | 2013-02-14 14:26:07 +0000 | [diff] [blame] | 1931 | verifyFormat( |
| 1932 | "void f() {\n" |
| 1933 | " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" |
| 1934 | " .aaaaaaa();\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 1935 | "}", |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 1936 | NoBinPacking); |
Daniel Jasper | 0df6acd | 2013-01-16 14:59:02 +0000 | [diff] [blame] | 1937 | } |
| 1938 | |
Daniel Jasper | c79afda | 2013-01-18 10:56:38 +0000 | [diff] [blame] | 1939 | TEST_F(FormatTest, FormatsBuilderPattern) { |
| 1940 | verifyFormat( |
| 1941 | "return llvm::StringSwitch<Reference::Kind>(name)\n" |
Daniel Jasper | 65622aa | 2013-04-08 10:45:44 +0000 | [diff] [blame] | 1942 | " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n" |
| 1943 | " .StartsWith(\".eh_frame\", ORDER_EH_FRAME).StartsWith(\".init\", ORDER_INIT)\n" |
| 1944 | " .StartsWith(\".fini\", ORDER_FINI).StartsWith(\".hash\", ORDER_HASH)\n" |
| 1945 | " .Default(ORDER_TEXT);\n"); |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 1946 | |
Daniel Jasper | 4a544e5 | 2013-02-15 20:33:06 +0000 | [diff] [blame] | 1947 | verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n" |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 1948 | " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();"); |
Daniel Jasper | 515f65d | 2013-02-18 13:24:21 +0000 | [diff] [blame] | 1949 | verifyFormat( |
| 1950 | "aaaaaaa->aaaaaaa\n" |
| 1951 | " ->aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
| 1952 | " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); |
Daniel Jasper | 82282dc | 2013-02-18 13:52:06 +0000 | [diff] [blame] | 1953 | verifyFormat( |
| 1954 | "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n" |
Daniel Jasper | 2484971 | 2013-03-01 16:48:32 +0000 | [diff] [blame] | 1955 | " aaaaaaaaaaaaaa);"); |
Daniel Jasper | 82282dc | 2013-02-18 13:52:06 +0000 | [diff] [blame] | 1956 | verifyFormat( |
| 1957 | "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa = aaaaaa->aaaaaaaaaaaa()\n" |
| 1958 | " ->aaaaaaaaaaaaaaaa(\n" |
| 1959 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
| 1960 | " ->aaaaaaaaaaaaaaaaa();"); |
Daniel Jasper | c79afda | 2013-01-18 10:56:38 +0000 | [diff] [blame] | 1961 | } |
| 1962 | |
Daniel Jasper | 7d19bc2 | 2013-01-11 14:23:32 +0000 | [diff] [blame] | 1963 | TEST_F(FormatTest, DoesNotBreakTrailingAnnotation) { |
| 1964 | verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
Daniel Jasper | 8ef19a2 | 2013-03-14 09:50:46 +0000 | [diff] [blame] | 1965 | " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); |
Daniel Jasper | 60ca75d | 2013-01-17 13:31:52 +0000 | [diff] [blame] | 1966 | verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" |
Daniel Jasper | 8ef19a2 | 2013-03-14 09:50:46 +0000 | [diff] [blame] | 1967 | " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); |
Daniel Jasper | 60ca75d | 2013-01-17 13:31:52 +0000 | [diff] [blame] | 1968 | verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" |
Daniel Jasper | 8ef19a2 | 2013-03-14 09:50:46 +0000 | [diff] [blame] | 1969 | " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}"); |
Daniel Jasper | 8ed4100 | 2013-02-28 14:44:25 +0000 | [diff] [blame] | 1970 | verifyFormat( |
| 1971 | "void aaaaaaaaaaaaaaaaaa()\n" |
| 1972 | " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 1973 | " aaaaaaaaaaaaaaaaaaaaaaaaa));"); |
Daniel Jasper | 8ef19a2 | 2013-03-14 09:50:46 +0000 | [diff] [blame] | 1974 | verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 1975 | " __attribute__((unused));"); |
Daniel Jasper | 8ef19a2 | 2013-03-14 09:50:46 +0000 | [diff] [blame] | 1976 | verifyFormat( |
| 1977 | "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 1978 | " GUARDED_BY(aaaaaaaaaaaa);"); |
Daniel Jasper | 7d19bc2 | 2013-01-11 14:23:32 +0000 | [diff] [blame] | 1979 | } |
| 1980 | |
Daniel Jasper | e2c7acf | 2012-12-24 00:13:23 +0000 | [diff] [blame] | 1981 | TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) { |
| 1982 | verifyFormat( |
| 1983 | "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1984 | " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}"); |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 1985 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1986 | " ccccccccccccccccccccccccc) {\n}"); |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 1987 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1988 | " ccccccccccccccccccccccccc) {\n}"); |
Daniel Jasper | e2c7acf | 2012-12-24 00:13:23 +0000 | [diff] [blame] | 1989 | verifyFormat( |
| 1990 | "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 1991 | " ccccccccccccccccccccccccc) {\n}"); |
Daniel Jasper | 29f123b | 2013-02-08 15:28:42 +0000 | [diff] [blame] | 1992 | verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n" |
| 1993 | " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n" |
| 1994 | " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n" |
| 1995 | " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); |
| 1996 | verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n" |
| 1997 | " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n" |
| 1998 | " aaaaaaaaaaaaaaa != aa) {\n}"); |
Daniel Jasper | e2c7acf | 2012-12-24 00:13:23 +0000 | [diff] [blame] | 1999 | } |
| 2000 | |
Daniel Jasper | 7006e7e | 2013-01-23 12:27:43 +0000 | [diff] [blame] | 2001 | TEST_F(FormatTest, BreaksAfterAssignments) { |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2002 | verifyFormat( |
Daniel Jasper | 7006e7e | 2013-01-23 12:27:43 +0000 | [diff] [blame] | 2003 | "unsigned Cost =\n" |
| 2004 | " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n" |
| 2005 | " SI->getPointerAddressSpaceee());\n"); |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2006 | verifyFormat( |
Daniel Jasper | 13cb7c2 | 2013-01-23 15:55:19 +0000 | [diff] [blame] | 2007 | "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n" |
| 2008 | " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());"); |
Daniel Jasper | f39c885 | 2013-01-23 16:58:21 +0000 | [diff] [blame] | 2009 | |
| 2010 | verifyFormat( |
| 2011 | "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa()\n" |
| 2012 | " .aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2013 | } |
| 2014 | |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 2015 | TEST_F(FormatTest, AlignsAfterAssignments) { |
| 2016 | verifyFormat( |
| 2017 | "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2018 | " aaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 2019 | verifyFormat( |
| 2020 | "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2021 | " aaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 2022 | verifyFormat( |
| 2023 | "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2024 | " aaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 2025 | verifyFormat( |
| 2026 | "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
Daniel Jasper | 9cda800 | 2013-01-07 13:08:40 +0000 | [diff] [blame] | 2027 | " aaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2028 | verifyFormat("double LooooooooooooooooooooooooongResult =\n" |
| 2029 | " aaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 2030 | " aaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 2031 | } |
| 2032 | |
| 2033 | TEST_F(FormatTest, AlignsAfterReturn) { |
| 2034 | verifyFormat( |
| 2035 | "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 2036 | " aaaaaaaaaaaaaaaaaaaaaaaaa;"); |
| 2037 | verifyFormat( |
| 2038 | "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" |
| 2039 | " aaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2040 | verifyFormat( |
| 2041 | "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 2042 | " aaaaaaaaaaaaaaaaaaaaaa();"); |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2043 | verifyFormat( |
| 2044 | "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 2045 | " aaaaaaaaaaaaaaaaaaaaaa());"); |
| 2046 | verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2047 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
| 2048 | verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2049 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n" |
| 2050 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | cf225b6 | 2012-12-24 13:43:52 +0000 | [diff] [blame] | 2051 | } |
| 2052 | |
Daniel Jasper | 9c837d0 | 2013-01-09 07:06:56 +0000 | [diff] [blame] | 2053 | TEST_F(FormatTest, BreaksConditionalExpressions) { |
| 2054 | verifyFormat( |
| 2055 | "aaaa(aaaaaaaaaaaaaaaaaaaa,\n" |
Daniel Jasper | bfe6fd4 | 2013-01-28 12:45:14 +0000 | [diff] [blame] | 2056 | " aaaaaaaaaaaaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2057 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 1f2b078 | 2013-01-16 16:23:19 +0000 | [diff] [blame] | 2058 | verifyFormat( |
Daniel Jasper | bfe6fd4 | 2013-01-28 12:45:14 +0000 | [diff] [blame] | 2059 | "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2060 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
| 2061 | verifyFormat( |
| 2062 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n" |
| 2063 | " : aaaaaaaaaaaaa);"); |
| 2064 | verifyFormat( |
| 2065 | "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
Daniel Jasper | 64f0928 | 2013-03-20 13:53:11 +0000 | [diff] [blame] | 2066 | " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
Daniel Jasper | bfe6fd4 | 2013-01-28 12:45:14 +0000 | [diff] [blame] | 2067 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2068 | " aaaaaaaaaaaaa);"); |
| 2069 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2070 | " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2071 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
| 2072 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2073 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
| 2074 | verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2075 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2076 | " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2077 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
| 2078 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2079 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" |
| 2080 | " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 7878a7b | 2013-02-15 11:07:25 +0000 | [diff] [blame] | 2081 | |
| 2082 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2083 | " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2084 | " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2085 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" |
| 2086 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2087 | " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2088 | " : aaaaaaaaaaaaaaaa;"); |
Daniel Jasper | 237d4c1 | 2013-02-23 21:01:55 +0000 | [diff] [blame] | 2089 | verifyFormat( |
| 2090 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2091 | " ? aaaaaaaaaaaaaaa\n" |
| 2092 | " : aaaaaaaaaaaaaaa;"); |
| 2093 | verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 2094 | " aaaaaaaaa\n" |
Daniel Jasper | 65622aa | 2013-04-08 10:45:44 +0000 | [diff] [blame] | 2095 | " ? b\n" |
| 2096 | " : c);"); |
Daniel Jasper | 087387a | 2013-02-08 16:49:27 +0000 | [diff] [blame] | 2097 | verifyFormat( |
Daniel Jasper | 7878a7b | 2013-02-15 11:07:25 +0000 | [diff] [blame] | 2098 | "unsigned Indent =\n" |
| 2099 | " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n" |
| 2100 | " ? IndentForLevel[TheLine.Level]\n" |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 2101 | " : TheLine * 2,\n" |
| 2102 | " TheLine.InPPDirective, PreviousEndOfLineColumn);", |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2103 | getLLVMStyleWithColumns(70)); |
Daniel Jasper | 7878a7b | 2013-02-15 11:07:25 +0000 | [diff] [blame] | 2104 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2105 | FormatStyle NoBinPacking = getLLVMStyle(); |
| 2106 | NoBinPacking.BinPackParameters = false; |
| 2107 | verifyFormat( |
Daniel Jasper | 237d4c1 | 2013-02-23 21:01:55 +0000 | [diff] [blame] | 2108 | "void f() {\n" |
| 2109 | " g(aaa,\n" |
| 2110 | " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" |
| 2111 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2112 | " ? aaaaaaaaaaaaaaa\n" |
| 2113 | " : aaaaaaaaaaaaaaa);\n" |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2114 | "}", |
| 2115 | NoBinPacking); |
Daniel Jasper | 9c837d0 | 2013-01-09 07:06:56 +0000 | [diff] [blame] | 2116 | } |
| 2117 | |
Daniel Jasper | 2e60377 | 2013-01-29 11:21:01 +0000 | [diff] [blame] | 2118 | TEST_F(FormatTest, DeclarationsOfMultipleVariables) { |
| 2119 | verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n" |
| 2120 | " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();"); |
| 2121 | verifyFormat("bool a = true, b = false;"); |
| 2122 | |
Daniel Jasper | 2e60377 | 2013-01-29 11:21:01 +0000 | [diff] [blame] | 2123 | verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n" |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 2124 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n" |
Daniel Jasper | 2e60377 | 2013-01-29 11:21:01 +0000 | [diff] [blame] | 2125 | " bbbbbbbbbbbbbbbbbbbbbbbbb =\n" |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2126 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);"); |
Daniel Jasper | 2e60377 | 2013-01-29 11:21:01 +0000 | [diff] [blame] | 2127 | verifyFormat( |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 2128 | "bool aaaaaaaaaaaaaaaaaaaaa =\n" |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 2129 | " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n" |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 2130 | " d = e && f;"); |
Daniel Jasper | adc0f09 | 2013-04-05 09:38:50 +0000 | [diff] [blame] | 2131 | verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n" |
| 2132 | " c = cccccccccccccccccccc, d = dddddddddddddddddddd;"); |
| 2133 | verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" |
| 2134 | " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;"); |
| 2135 | verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n" |
| 2136 | " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;"); |
| 2137 | // FIXME: If multiple variables are defined, the "*" needs to move to the new |
| 2138 | // line. Also fix indent for breaking after the type, this looks bad. |
| 2139 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 2140 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n" |
| 2141 | " *b = bbbbbbbbbbbbbbbbbbb;"); |
Daniel Jasper | 2e60377 | 2013-01-29 11:21:01 +0000 | [diff] [blame] | 2142 | |
Daniel Jasper | adc0f09 | 2013-04-05 09:38:50 +0000 | [diff] [blame] | 2143 | // Not ideal, but pointer-with-type does not allow much here. |
| 2144 | verifyGoogleFormat( |
| 2145 | "aaaaaaaaa* a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" |
| 2146 | " *b = bbbbbbbbbbbbbbbbbbb, *d = ddddddddddddddddddd;"); |
Daniel Jasper | 2e60377 | 2013-01-29 11:21:01 +0000 | [diff] [blame] | 2147 | } |
| 2148 | |
Nico Weber | 7d37b8b | 2013-01-12 01:28:06 +0000 | [diff] [blame] | 2149 | TEST_F(FormatTest, ConditionalExpressionsInBrackets) { |
| 2150 | verifyFormat("arr[foo ? bar : baz];"); |
| 2151 | verifyFormat("f()[foo ? bar : baz];"); |
| 2152 | verifyFormat("(a + b)[foo ? bar : baz];"); |
| 2153 | verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];"); |
| 2154 | } |
| 2155 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2156 | TEST_F(FormatTest, AlignsStringLiterals) { |
| 2157 | verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n" |
| 2158 | " \"short literal\");"); |
| 2159 | verifyFormat( |
| 2160 | "looooooooooooooooooooooooongFunction(\n" |
| 2161 | " \"short literal\"\n" |
| 2162 | " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");"); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2163 | verifyFormat("someFunction(\"Always break between multi-line\"\n" |
| 2164 | " \" string literals\",\n" |
| 2165 | " and, other, parameters);"); |
Manuel Klimek | b56b6d1 | 2013-02-20 15:25:48 +0000 | [diff] [blame] | 2166 | EXPECT_EQ("fun + \"1243\" /* comment */\n" |
| 2167 | " \"5678\";", |
| 2168 | format("fun + \"1243\" /* comment */\n" |
| 2169 | " \"5678\";", |
| 2170 | getLLVMStyleWithColumns(28))); |
| 2171 | EXPECT_EQ( |
| 2172 | "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" |
| 2173 | " \"aaaaaaaaaaaaaaaaaaaaa\"\n" |
| 2174 | " \"aaaaaaaaaaaaaaaa\";", |
| 2175 | format("aaaaaa =" |
| 2176 | "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa " |
| 2177 | "aaaaaaaaaaaaaaaaaaaaa\" " |
| 2178 | "\"aaaaaaaaaaaaaaaa\";")); |
Manuel Klimek | e9a6226 | 2013-02-20 15:32:58 +0000 | [diff] [blame] | 2179 | verifyFormat("a = a + \"a\"\n" |
| 2180 | " \"a\"\n" |
| 2181 | " \"a\";"); |
Daniel Jasper | 3a20441 | 2013-02-23 07:46:38 +0000 | [diff] [blame] | 2182 | |
| 2183 | verifyFormat( |
| 2184 | "#define LL_FORMAT \"ll\"\n" |
| 2185 | "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n" |
| 2186 | " \"d, ddddddddd: %\" LL_FORMAT \"d\");"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2187 | } |
| 2188 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 2189 | TEST_F(FormatTest, AlignsPipes) { |
| 2190 | verifyFormat( |
| 2191 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2192 | " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2193 | " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
| 2194 | verifyFormat( |
| 2195 | "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n" |
| 2196 | " << aaaaaaaaaaaaaaaaaaaa;"); |
| 2197 | verifyFormat( |
| 2198 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2199 | " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
| 2200 | verifyFormat( |
| 2201 | "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" |
| 2202 | " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n" |
| 2203 | " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";"); |
| 2204 | verifyFormat( |
| 2205 | "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2206 | " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
| 2207 | " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | fa543ac | 2013-02-04 07:34:48 +0000 | [diff] [blame] | 2208 | |
| 2209 | verifyFormat("return out << \"somepacket = {\\n\"\n" |
| 2210 | " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n" |
| 2211 | " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n" |
| 2212 | " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n" |
| 2213 | " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n" |
| 2214 | " << \"}\";"); |
Daniel Jasper | 4e8a7b4 | 2013-02-06 21:04:05 +0000 | [diff] [blame] | 2215 | |
| 2216 | verifyFormat( |
| 2217 | "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n" |
| 2218 | " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n" |
| 2219 | " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n" |
| 2220 | " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n" |
| 2221 | " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;"); |
Daniel Jasper | bfa1edd | 2013-03-14 14:00:17 +0000 | [diff] [blame] | 2222 | verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n" |
| 2223 | " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2224 | |
| 2225 | verifyFormat( |
| 2226 | "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2227 | " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 2228 | } |
| 2229 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2230 | TEST_F(FormatTest, UnderstandsEquals) { |
| 2231 | verifyFormat( |
| 2232 | "aaaaaaaaaaaaaaaaa =\n" |
| 2233 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
| 2234 | verifyFormat( |
| 2235 | "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2236 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2237 | verifyFormat( |
| 2238 | "if (a) {\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2239 | " f();\n" |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2240 | "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2241 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" |
| 2242 | "}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2243 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2244 | verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" |
| 2245 | " 100000000 + 10000000) {\n}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2246 | } |
| 2247 | |
Daniel Jasper | 9a0b494 | 2012-12-17 14:34:14 +0000 | [diff] [blame] | 2248 | TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) { |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 2249 | verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" |
| 2250 | " .looooooooooooooooooooooooooooooooooooooongFunction();"); |
Daniel Jasper | 9a0b494 | 2012-12-17 14:34:14 +0000 | [diff] [blame] | 2251 | |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 2252 | verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" |
| 2253 | " ->looooooooooooooooooooooooooooooooooooooongFunction();"); |
Daniel Jasper | 9a0b494 | 2012-12-17 14:34:14 +0000 | [diff] [blame] | 2254 | |
| 2255 | verifyFormat( |
| 2256 | "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n" |
| 2257 | " Parameter2);"); |
| 2258 | |
| 2259 | verifyFormat( |
| 2260 | "ShortObject->shortFunction(\n" |
| 2261 | " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n" |
| 2262 | " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);"); |
| 2263 | |
| 2264 | verifyFormat("loooooooooooooongFunction(\n" |
| 2265 | " LoooooooooooooongObject->looooooooooooooooongFunction());"); |
| 2266 | |
| 2267 | verifyFormat( |
| 2268 | "function(LoooooooooooooooooooooooooooooooooooongObject\n" |
| 2269 | " ->loooooooooooooooooooooooooooooooooooooooongFunction());"); |
| 2270 | |
Daniel Jasper | fc75908 | 2013-02-14 14:26:07 +0000 | [diff] [blame] | 2271 | verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" |
| 2272 | " .WillRepeatedly(Return(SomeValue));"); |
| 2273 | verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)]\n" |
| 2274 | " .insert(ccccccccccccccccccccccc);"); |
Daniel Jasper | 3af59ce | 2013-03-15 14:57:30 +0000 | [diff] [blame] | 2275 | verifyFormat( |
| 2276 | "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2277 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" |
| 2278 | " .aaaaaaaaaaaaaaa(\n" |
| 2279 | " aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2280 | " aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2281 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2282 | " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2283 | " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2284 | " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n" |
| 2285 | "}"); |
Daniel Jasper | fc75908 | 2013-02-14 14:26:07 +0000 | [diff] [blame] | 2286 | |
Daniel Jasper | 46a46a2 | 2013-01-07 07:13:20 +0000 | [diff] [blame] | 2287 | // Here, it is not necessary to wrap at "." or "->". |
Daniel Jasper | 1321eb5 | 2012-12-18 21:05:13 +0000 | [diff] [blame] | 2288 | verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2289 | " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); |
Daniel Jasper | 46a46a2 | 2013-01-07 07:13:20 +0000 | [diff] [blame] | 2290 | verifyFormat( |
| 2291 | "aaaaaaaaaaa->aaaaaaaaa(\n" |
| 2292 | " aaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2293 | " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n"); |
Daniel Jasper | 9fc56f2 | 2013-02-14 15:01:34 +0000 | [diff] [blame] | 2294 | |
| 2295 | verifyFormat( |
| 2296 | "aaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2297 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());"); |
Daniel Jasper | 8d0d19a | 2013-03-13 15:37:48 +0000 | [diff] [blame] | 2298 | verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n" |
| 2299 | " aaaaaaaaa()->aaaaaa()->aaaaa());"); |
| 2300 | verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n" |
| 2301 | " aaaaaaaaa()->aaaaaa()->aaaaa());"); |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2302 | |
Daniel Jasper | 3af59ce | 2013-03-15 14:57:30 +0000 | [diff] [blame] | 2303 | // FIXME: Should we break before .a()? |
| 2304 | verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2305 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();"); |
| 2306 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2307 | FormatStyle NoBinPacking = getLLVMStyle(); |
| 2308 | NoBinPacking.BinPackParameters = false; |
| 2309 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" |
| 2310 | " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" |
| 2311 | " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n" |
| 2312 | " aaaaaaaaaaaaaaaaaaa,\n" |
| 2313 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", |
| 2314 | NoBinPacking); |
Daniel Jasper | 9a0b494 | 2012-12-17 14:34:14 +0000 | [diff] [blame] | 2315 | } |
| 2316 | |
Daniel Jasper | 9a64fb5 | 2013-01-02 15:08:56 +0000 | [diff] [blame] | 2317 | TEST_F(FormatTest, WrapsTemplateDeclarations) { |
| 2318 | verifyFormat("template <typename T>\n" |
| 2319 | "virtual void loooooooooooongFunction(int Param1, int Param2);"); |
| 2320 | verifyFormat( |
Daniel Jasper | c79afda | 2013-01-18 10:56:38 +0000 | [diff] [blame] | 2321 | "template <typename T>\n" |
Daniel Jasper | 29f123b | 2013-02-08 15:28:42 +0000 | [diff] [blame] | 2322 | "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;"); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2323 | verifyFormat("template <typename T>\n" |
| 2324 | "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n" |
| 2325 | " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);"); |
Daniel Jasper | 9a64fb5 | 2013-01-02 15:08:56 +0000 | [diff] [blame] | 2326 | verifyFormat( |
| 2327 | "template <typename T>\n" |
| 2328 | "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n" |
| 2329 | " int Paaaaaaaaaaaaaaaaaaaaram2);"); |
Daniel Jasper | 5eda31e | 2013-01-02 18:30:06 +0000 | [diff] [blame] | 2330 | verifyFormat( |
| 2331 | "template <typename T>\n" |
| 2332 | "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n" |
| 2333 | " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n" |
| 2334 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | d64f738 | 2013-01-09 09:50:48 +0000 | [diff] [blame] | 2335 | verifyFormat("template <typename T>\n" |
| 2336 | "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
Daniel Jasper | 8ed9f2b | 2013-04-03 13:36:17 +0000 | [diff] [blame] | 2337 | " int aaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 3fc0bb7 | 2013-01-09 10:40:23 +0000 | [diff] [blame] | 2338 | verifyFormat( |
| 2339 | "template <typename T1, typename T2 = char, typename T3 = char,\n" |
| 2340 | " typename T4 = char>\n" |
| 2341 | "void f();"); |
Daniel Jasper | 3499dda | 2013-01-25 15:43:32 +0000 | [diff] [blame] | 2342 | verifyFormat( |
| 2343 | "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n" |
| 2344 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 0178673 | 2013-02-04 07:21:18 +0000 | [diff] [blame] | 2345 | |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2346 | verifyFormat("a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n" |
| 2347 | " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));"); |
Daniel Jasper | 9a64fb5 | 2013-01-02 15:08:56 +0000 | [diff] [blame] | 2348 | } |
| 2349 | |
Daniel Jasper | 63f0036 | 2013-01-25 10:57:27 +0000 | [diff] [blame] | 2350 | TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) { |
| 2351 | verifyFormat( |
| 2352 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" |
| 2353 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); |
| 2354 | verifyFormat( |
| 2355 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" |
| 2356 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2357 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); |
| 2358 | |
Daniel Jasper | b2f063a | 2013-05-08 10:00:18 +0000 | [diff] [blame] | 2359 | // FIXME: Should we have the extra indent after the second break? |
Daniel Jasper | 63f0036 | 2013-01-25 10:57:27 +0000 | [diff] [blame] | 2360 | verifyFormat( |
| 2361 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" |
| 2362 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" |
Daniel Jasper | b2f063a | 2013-05-08 10:00:18 +0000 | [diff] [blame] | 2363 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); |
Daniel Jasper | 63f0036 | 2013-01-25 10:57:27 +0000 | [diff] [blame] | 2364 | |
| 2365 | // FIXME: Look into whether we should indent 4 from the start or 4 from |
| 2366 | // "bbbbb..." here instead of what we are doing now. |
| 2367 | verifyFormat( |
| 2368 | "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n" |
Daniel Jasper | 5f2173e | 2013-01-28 07:43:15 +0000 | [diff] [blame] | 2369 | " cccccccccccccccccccccccccccccccccccccccccccccc());"); |
Daniel Jasper | 63f0036 | 2013-01-25 10:57:27 +0000 | [diff] [blame] | 2370 | |
| 2371 | // Breaking at nested name specifiers is generally not desirable. |
| 2372 | verifyFormat( |
| 2373 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2374 | " aaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | bfe6fd4 | 2013-01-28 12:45:14 +0000 | [diff] [blame] | 2375 | |
| 2376 | verifyFormat( |
| 2377 | "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" |
| 2378 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2379 | " aaaaaaaaaaaaaaaaaaaaa);", |
| 2380 | getLLVMStyleWithColumns(74)); |
Daniel Jasper | 3791130 | 2013-04-02 14:33:13 +0000 | [diff] [blame] | 2381 | |
| 2382 | verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" |
| 2383 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" |
| 2384 | " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); |
Daniel Jasper | 63f0036 | 2013-01-25 10:57:27 +0000 | [diff] [blame] | 2385 | } |
| 2386 | |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2387 | TEST_F(FormatTest, UnderstandsTemplateParameters) { |
| 2388 | verifyFormat("A<int> a;"); |
| 2389 | verifyFormat("A<A<A<int> > > a;"); |
| 2390 | verifyFormat("A<A<A<int, 2>, 3>, 4> a;"); |
| 2391 | verifyFormat("bool x = a < 1 || 2 > a;"); |
| 2392 | verifyFormat("bool x = 5 < f<int>();"); |
| 2393 | verifyFormat("bool x = f<int>() > 5;"); |
| 2394 | verifyFormat("bool x = 5 < a<int>::x;"); |
| 2395 | verifyFormat("bool x = a < 4 ? a > 2 : false;"); |
| 2396 | verifyFormat("bool x = f() ? a < 2 : a > 2;"); |
| 2397 | |
| 2398 | verifyGoogleFormat("A<A<int>> a;"); |
| 2399 | verifyGoogleFormat("A<A<A<int>>> a;"); |
| 2400 | verifyGoogleFormat("A<A<A<A<int>>>> a;"); |
Daniel Jasper | 8ff690a | 2013-02-06 14:22:40 +0000 | [diff] [blame] | 2401 | verifyGoogleFormat("A<A<int> > a;"); |
| 2402 | verifyGoogleFormat("A<A<A<int> > > a;"); |
| 2403 | verifyGoogleFormat("A<A<A<A<int> > > > a;"); |
| 2404 | EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle())); |
| 2405 | EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle())); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2406 | |
| 2407 | verifyFormat("test >> a >> b;"); |
| 2408 | verifyFormat("test << a >> b;"); |
| 2409 | |
| 2410 | verifyFormat("f<int>();"); |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2411 | verifyFormat("template <typename T> void f() {}"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2412 | } |
| 2413 | |
Daniel Jasper | 807809c | 2013-02-28 09:21:10 +0000 | [diff] [blame] | 2414 | TEST_F(FormatTest, UnderstandsBinaryOperators) { |
| 2415 | verifyFormat("COMPARE(a, ==, b);"); |
Alexander Kornienko | 54a38bd | 2013-03-20 16:41:56 +0000 | [diff] [blame] | 2416 | } |
| 2417 | |
| 2418 | TEST_F(FormatTest, UnderstandsPointersToMembers) { |
| 2419 | verifyFormat("int A::*x;"); |
| 2420 | // FIXME: Recognize pointers to member functions. |
| 2421 | //verifyFormat("int (S::*func)(void *);"); |
| 2422 | verifyFormat("int(S::*func)(void *);"); |
| 2423 | verifyFormat("(a->*f)();"); |
| 2424 | verifyFormat("a->*x;"); |
| 2425 | verifyFormat("(a.*f)();"); |
| 2426 | verifyFormat("((*a).*f)();"); |
| 2427 | verifyFormat("a.*x;"); |
Daniel Jasper | 807809c | 2013-02-28 09:21:10 +0000 | [diff] [blame] | 2428 | } |
| 2429 | |
Daniel Jasper | 98e6b4a | 2012-12-21 09:41:31 +0000 | [diff] [blame] | 2430 | TEST_F(FormatTest, UnderstandsUnaryOperators) { |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2431 | verifyFormat("int a = -2;"); |
Daniel Jasper | 8822d3a | 2012-12-04 13:02:32 +0000 | [diff] [blame] | 2432 | verifyFormat("f(-1, -2, -3);"); |
| 2433 | verifyFormat("a[-1] = 5;"); |
| 2434 | verifyFormat("int a = 5 + -2;"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2435 | verifyFormat("if (i == -1) {\n}"); |
| 2436 | verifyFormat("if (i != -1) {\n}"); |
| 2437 | verifyFormat("if (i > -1) {\n}"); |
| 2438 | verifyFormat("if (i < -1) {\n}"); |
Daniel Jasper | d56a737 | 2012-12-06 13:16:39 +0000 | [diff] [blame] | 2439 | verifyFormat("++(a->f());"); |
| 2440 | verifyFormat("--(a->f());"); |
Daniel Jasper | 4abbb53 | 2013-01-14 12:18:19 +0000 | [diff] [blame] | 2441 | verifyFormat("(a->f())++;"); |
| 2442 | verifyFormat("a[42]++;"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2443 | verifyFormat("if (!(a->f())) {\n}"); |
Daniel Jasper | 98e6b4a | 2012-12-21 09:41:31 +0000 | [diff] [blame] | 2444 | |
| 2445 | verifyFormat("a-- > b;"); |
| 2446 | verifyFormat("b ? -a : c;"); |
| 2447 | verifyFormat("n * sizeof char16;"); |
Daniel Jasper | ba3d307 | 2013-01-02 17:21:36 +0000 | [diff] [blame] | 2448 | verifyFormat("n * alignof char16;"); |
Daniel Jasper | 98e6b4a | 2012-12-21 09:41:31 +0000 | [diff] [blame] | 2449 | verifyFormat("sizeof(char);"); |
Daniel Jasper | ba3d307 | 2013-01-02 17:21:36 +0000 | [diff] [blame] | 2450 | verifyFormat("alignof(char);"); |
Daniel Jasper | 1f0754b | 2013-01-02 15:26:16 +0000 | [diff] [blame] | 2451 | |
| 2452 | verifyFormat("return -1;"); |
| 2453 | verifyFormat("switch (a) {\n" |
| 2454 | "case -1:\n" |
| 2455 | " break;\n" |
| 2456 | "}"); |
Daniel Jasper | b598542 | 2013-03-22 10:44:43 +0000 | [diff] [blame] | 2457 | verifyFormat("#define X -1"); |
| 2458 | verifyFormat("#define X -kConstant"); |
Nico Weber | cc191d1 | 2013-01-12 05:41:23 +0000 | [diff] [blame] | 2459 | |
| 2460 | verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { -5, +3 };"); |
| 2461 | verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = { +5, -3 };"); |
Daniel Jasper | b369c2c | 2013-01-15 14:27:39 +0000 | [diff] [blame] | 2462 | |
| 2463 | verifyFormat("int a = /* confusing comment */ -1;"); |
| 2464 | // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case. |
| 2465 | verifyFormat("int a = i /* confusing comment */++;"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2466 | } |
| 2467 | |
| 2468 | TEST_F(FormatTest, UndestandsOverloadedOperators) { |
Daniel Jasper | f6aef6a | 2012-12-24 10:56:04 +0000 | [diff] [blame] | 2469 | verifyFormat("bool operator<();"); |
| 2470 | verifyFormat("bool operator>();"); |
| 2471 | verifyFormat("bool operator=();"); |
| 2472 | verifyFormat("bool operator==();"); |
| 2473 | verifyFormat("bool operator!=();"); |
| 2474 | verifyFormat("int operator+();"); |
| 2475 | verifyFormat("int operator++();"); |
| 2476 | verifyFormat("bool operator();"); |
| 2477 | verifyFormat("bool operator()();"); |
| 2478 | verifyFormat("bool operator[]();"); |
| 2479 | verifyFormat("operator bool();"); |
Daniel Jasper | 2b4c924 | 2013-02-11 08:01:18 +0000 | [diff] [blame] | 2480 | verifyFormat("operator int();"); |
| 2481 | verifyFormat("operator void *();"); |
Daniel Jasper | f6aef6a | 2012-12-24 10:56:04 +0000 | [diff] [blame] | 2482 | verifyFormat("operator SomeType<int>();"); |
Daniel Jasper | 2b4c924 | 2013-02-11 08:01:18 +0000 | [diff] [blame] | 2483 | verifyFormat("operator SomeType<int, int>();"); |
| 2484 | verifyFormat("operator SomeType<SomeType<int> >();"); |
Daniel Jasper | f6aef6a | 2012-12-24 10:56:04 +0000 | [diff] [blame] | 2485 | verifyFormat("void *operator new(std::size_t size);"); |
| 2486 | verifyFormat("void *operator new[](std::size_t size);"); |
| 2487 | verifyFormat("void operator delete(void *ptr);"); |
| 2488 | verifyFormat("void operator delete[](void *ptr);"); |
Daniel Jasper | 2b4c924 | 2013-02-11 08:01:18 +0000 | [diff] [blame] | 2489 | |
Daniel Jasper | dc2efa1 | 2013-02-15 19:24:08 +0000 | [diff] [blame] | 2490 | verifyFormat( |
| 2491 | "ostream &operator<<(ostream &OutputStream,\n" |
| 2492 | " SomeReallyLongType WithSomeReallyLongValue);"); |
Daniel Jasper | 27b91cc | 2013-04-05 17:21:59 +0000 | [diff] [blame] | 2493 | verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n" |
| 2494 | " const aaaaaaaaaaaaaaaaaaaaa &right) {\n" |
| 2495 | " return left.group < right.group;\n" |
| 2496 | "}"); |
Daniel Jasper | 2eb23b7 | 2013-04-11 08:48:20 +0000 | [diff] [blame] | 2497 | verifyFormat("SomeType &operator=(const SomeType &S);"); |
Daniel Jasper | dc2efa1 | 2013-02-15 19:24:08 +0000 | [diff] [blame] | 2498 | |
Daniel Jasper | 2b4c924 | 2013-02-11 08:01:18 +0000 | [diff] [blame] | 2499 | verifyGoogleFormat("operator void*();"); |
| 2500 | verifyGoogleFormat("operator SomeType<SomeType<int>>();"); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2501 | } |
| 2502 | |
Daniel Jasper | 088dab5 | 2013-01-11 16:09:04 +0000 | [diff] [blame] | 2503 | TEST_F(FormatTest, UnderstandsNewAndDelete) { |
Daniel Jasper | 37eff83 | 2013-02-23 08:07:18 +0000 | [diff] [blame] | 2504 | verifyFormat("void f() {\n" |
| 2505 | " A *a = new A;\n" |
| 2506 | " A *a = new (placement) A;\n" |
| 2507 | " delete a;\n" |
| 2508 | " delete (A *)a;\n" |
| 2509 | "}"); |
Daniel Jasper | 088dab5 | 2013-01-11 16:09:04 +0000 | [diff] [blame] | 2510 | } |
| 2511 | |
Daniel Jasper | 5d33440 | 2013-01-02 08:57:10 +0000 | [diff] [blame] | 2512 | TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2513 | verifyFormat("int *f(int *a) {}"); |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2514 | verifyFormat("int main(int argc, char **argv) {}"); |
Daniel Jasper | d0f349b | 2013-02-18 12:44:35 +0000 | [diff] [blame] | 2515 | verifyFormat("Test::Test(int b) : a(b * b) {}"); |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2516 | verifyIndependentOfContext("f(a, *a);"); |
Daniel Jasper | 8a5d7cd | 2013-03-01 17:13:29 +0000 | [diff] [blame] | 2517 | verifyFormat("void g() { f(*a); }"); |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2518 | verifyIndependentOfContext("int a = b * 10;"); |
| 2519 | verifyIndependentOfContext("int a = 10 * b;"); |
| 2520 | verifyIndependentOfContext("int a = b * c;"); |
| 2521 | verifyIndependentOfContext("int a += b * c;"); |
| 2522 | verifyIndependentOfContext("int a -= b * c;"); |
| 2523 | verifyIndependentOfContext("int a *= b * c;"); |
| 2524 | verifyIndependentOfContext("int a /= b * c;"); |
| 2525 | verifyIndependentOfContext("int a = *b;"); |
| 2526 | verifyIndependentOfContext("int a = *b * c;"); |
| 2527 | verifyIndependentOfContext("int a = b * *c;"); |
| 2528 | verifyIndependentOfContext("return 10 * b;"); |
| 2529 | verifyIndependentOfContext("return *b * *c;"); |
| 2530 | verifyIndependentOfContext("return a & ~b;"); |
| 2531 | verifyIndependentOfContext("f(b ? *c : *d);"); |
| 2532 | verifyIndependentOfContext("int a = b ? *c : *d;"); |
| 2533 | verifyIndependentOfContext("*b = a;"); |
| 2534 | verifyIndependentOfContext("a * ~b;"); |
| 2535 | verifyIndependentOfContext("a * !b;"); |
| 2536 | verifyIndependentOfContext("a * +b;"); |
| 2537 | verifyIndependentOfContext("a * -b;"); |
| 2538 | verifyIndependentOfContext("a * ++b;"); |
| 2539 | verifyIndependentOfContext("a * --b;"); |
| 2540 | verifyIndependentOfContext("a[4] * b;"); |
Daniel Jasper | 9c65b06 | 2013-02-27 11:43:50 +0000 | [diff] [blame] | 2541 | verifyIndependentOfContext("a[a * a] = 1;"); |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2542 | verifyIndependentOfContext("f() * b;"); |
| 2543 | verifyIndependentOfContext("a * [self dostuff];"); |
Daniel Jasper | 81d2d38 | 2013-04-01 17:13:26 +0000 | [diff] [blame] | 2544 | verifyIndependentOfContext("int x = a * (a + b);"); |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2545 | verifyIndependentOfContext("(a *)(a + b);"); |
| 2546 | verifyIndependentOfContext("int *pa = (int *)&a;"); |
Nico Weber | 95e8e46 | 2013-02-12 16:17:07 +0000 | [diff] [blame] | 2547 | verifyIndependentOfContext("return sizeof(int **);"); |
| 2548 | verifyIndependentOfContext("return sizeof(int ******);"); |
| 2549 | verifyIndependentOfContext("return (int **&)a;"); |
Daniel Jasper | 8a5d7cd | 2013-03-01 17:13:29 +0000 | [diff] [blame] | 2550 | verifyFormat("void f(Type (*parameter)[10]) {}"); |
Nico Weber | 95e8e46 | 2013-02-12 16:17:07 +0000 | [diff] [blame] | 2551 | verifyGoogleFormat("return sizeof(int**);"); |
| 2552 | verifyIndependentOfContext("Type **A = static_cast<Type **>(P);"); |
| 2553 | verifyGoogleFormat("Type** A = static_cast<Type**>(P);"); |
| 2554 | // FIXME: The newline is wrong. |
| 2555 | verifyFormat("auto a = [](int **&, int ***) {}\n;"); |
Daniel Jasper | c74e279 | 2012-12-07 09:52:15 +0000 | [diff] [blame] | 2556 | |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2557 | verifyIndependentOfContext("InvalidRegions[*R] = 0;"); |
Daniel Jasper | 9bb0d28 | 2013-01-04 20:46:38 +0000 | [diff] [blame] | 2558 | |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2559 | verifyIndependentOfContext("A<int *> a;"); |
| 2560 | verifyIndependentOfContext("A<int **> a;"); |
| 2561 | verifyIndependentOfContext("A<int *, int *> a;"); |
Daniel Jasper | 4e77809 | 2013-02-06 10:05:46 +0000 | [diff] [blame] | 2562 | verifyIndependentOfContext( |
| 2563 | "const char *const p = reinterpret_cast<const char *const>(q);"); |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2564 | verifyIndependentOfContext("A<int **, int **> a;"); |
Daniel Jasper | 6b5ba8b | 2013-02-06 10:57:42 +0000 | [diff] [blame] | 2565 | verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);"); |
Daniel Jasper | d3cf17b | 2013-03-14 10:50:25 +0000 | [diff] [blame] | 2566 | verifyFormat("for (char **a = b; *a; ++a) {\n}"); |
Daniel Jasper | 16a69ef | 2013-05-03 14:41:24 +0000 | [diff] [blame] | 2567 | verifyFormat("for (; a && b;) {\n}"); |
Daniel Jasper | 8b39c66 | 2012-12-10 18:59:13 +0000 | [diff] [blame] | 2568 | |
Daniel Jasper | 2db356d | 2013-01-08 20:03:18 +0000 | [diff] [blame] | 2569 | verifyFormat( |
| 2570 | "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" |
| 2571 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); |
| 2572 | |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2573 | verifyGoogleFormat("int main(int argc, char** argv) {}"); |
Daniel Jasper | 8b39c66 | 2012-12-10 18:59:13 +0000 | [diff] [blame] | 2574 | verifyGoogleFormat("A<int*> a;"); |
| 2575 | verifyGoogleFormat("A<int**> a;"); |
| 2576 | verifyGoogleFormat("A<int*, int*> a;"); |
| 2577 | verifyGoogleFormat("A<int**, int**> a;"); |
Daniel Jasper | 5d33440 | 2013-01-02 08:57:10 +0000 | [diff] [blame] | 2578 | verifyGoogleFormat("f(b ? *c : *d);"); |
| 2579 | verifyGoogleFormat("int a = b ? *c : *d;"); |
Daniel Jasper | 48bd7b7 | 2013-01-16 16:04:06 +0000 | [diff] [blame] | 2580 | verifyGoogleFormat("Type* t = **x;"); |
| 2581 | verifyGoogleFormat("Type* t = *++*x;"); |
| 2582 | verifyGoogleFormat("*++*x;"); |
| 2583 | verifyGoogleFormat("Type* t = const_cast<T*>(&*x);"); |
| 2584 | verifyGoogleFormat("Type* t = x++ * y;"); |
Daniel Jasper | 4e77809 | 2013-02-06 10:05:46 +0000 | [diff] [blame] | 2585 | verifyGoogleFormat( |
| 2586 | "const char* const p = reinterpret_cast<const char* const>(q);"); |
Manuel Klimek | 1b6f4bd | 2013-01-14 10:58:01 +0000 | [diff] [blame] | 2587 | |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2588 | verifyIndependentOfContext("a = *(x + y);"); |
| 2589 | verifyIndependentOfContext("a = &(x + y);"); |
| 2590 | verifyIndependentOfContext("*(x + y).call();"); |
| 2591 | verifyIndependentOfContext("&(x + y)->call();"); |
Daniel Jasper | 8a5d7cd | 2013-03-01 17:13:29 +0000 | [diff] [blame] | 2592 | verifyFormat("void f() { &(*I).first; }"); |
Daniel Jasper | b369c2c | 2013-01-15 14:27:39 +0000 | [diff] [blame] | 2593 | |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2594 | verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); |
Daniel Jasper | b369c2c | 2013-01-15 14:27:39 +0000 | [diff] [blame] | 2595 | verifyFormat( |
| 2596 | "int *MyValues = {\n" |
| 2597 | " *A, // Operator detection might be confused by the '{'\n" |
| 2598 | " *BB // Operator detection might be confused by previous comment\n" |
| 2599 | "};"); |
Nico Weber | 5096a44 | 2013-01-17 17:17:19 +0000 | [diff] [blame] | 2600 | |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2601 | verifyIndependentOfContext("if (int *a = &b)"); |
| 2602 | verifyIndependentOfContext("if (int &a = *b)"); |
| 2603 | verifyIndependentOfContext("if (a & b[i])"); |
| 2604 | verifyIndependentOfContext("if (a::b::c::d & b[i])"); |
| 2605 | verifyIndependentOfContext("if (*b[i])"); |
| 2606 | verifyIndependentOfContext("if (int *a = (&b))"); |
| 2607 | verifyIndependentOfContext("while (int *a = &b)"); |
Daniel Jasper | 20d3583 | 2013-01-23 12:58:14 +0000 | [diff] [blame] | 2608 | verifyFormat("void f() {\n" |
| 2609 | " for (const int &v : Values) {\n" |
| 2610 | " }\n" |
| 2611 | "}"); |
Daniel Jasper | d0f349b | 2013-02-18 12:44:35 +0000 | [diff] [blame] | 2612 | verifyFormat("for (int i = a * a; i < 10; ++i) {\n}"); |
| 2613 | verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); |
Daniel Jasper | ffee171 | 2013-01-22 11:46:26 +0000 | [diff] [blame] | 2614 | |
Daniel Jasper | 6f21a98 | 2013-03-13 07:49:51 +0000 | [diff] [blame] | 2615 | verifyIndependentOfContext("A = new SomeType *[Length];"); |
Daniel Jasper | 4bfc65a | 2013-01-23 12:10:53 +0000 | [diff] [blame] | 2616 | verifyIndependentOfContext("A = new SomeType *[Length]();"); |
Daniel Jasper | ffee171 | 2013-01-22 11:46:26 +0000 | [diff] [blame] | 2617 | verifyGoogleFormat("A = new SomeType* [Length]();"); |
Daniel Jasper | 6f21a98 | 2013-03-13 07:49:51 +0000 | [diff] [blame] | 2618 | verifyGoogleFormat("A = new SomeType* [Length];"); |
Daniel Jasper | dbef71e | 2013-05-07 14:17:18 +0000 | [diff] [blame] | 2619 | FormatStyle PointerLeft = getLLVMStyle(); |
| 2620 | PointerLeft.PointerBindsToType = true; |
| 2621 | verifyFormat("delete *x;", PointerLeft); |
Daniel Jasper | 8a5d7cd | 2013-03-01 17:13:29 +0000 | [diff] [blame] | 2622 | } |
Daniel Jasper | 8ff690a | 2013-02-06 14:22:40 +0000 | [diff] [blame] | 2623 | |
Daniel Jasper | f022018 | 2013-05-06 06:35:44 +0000 | [diff] [blame] | 2624 | TEST_F(FormatTest, UnderstandsEllipsis) { |
| 2625 | verifyFormat("int printf(const char *fmt, ...);"); |
| 2626 | verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }"); |
| 2627 | } |
| 2628 | |
Daniel Jasper | 8a5d7cd | 2013-03-01 17:13:29 +0000 | [diff] [blame] | 2629 | TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) { |
Daniel Jasper | 8ff690a | 2013-02-06 14:22:40 +0000 | [diff] [blame] | 2630 | EXPECT_EQ("int *a;\n" |
| 2631 | "int *a;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2632 | "int *a;", |
| 2633 | format("int *a;\n" |
| 2634 | "int* a;\n" |
| 2635 | "int *a;", |
| 2636 | getGoogleStyle())); |
Daniel Jasper | 8ff690a | 2013-02-06 14:22:40 +0000 | [diff] [blame] | 2637 | EXPECT_EQ("int* a;\n" |
| 2638 | "int* a;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2639 | "int* a;", |
| 2640 | format("int* a;\n" |
| 2641 | "int* a;\n" |
| 2642 | "int *a;", |
| 2643 | getGoogleStyle())); |
Daniel Jasper | 8ff690a | 2013-02-06 14:22:40 +0000 | [diff] [blame] | 2644 | EXPECT_EQ("int *a;\n" |
| 2645 | "int *a;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2646 | "int *a;", |
| 2647 | format("int *a;\n" |
| 2648 | "int * a;\n" |
| 2649 | "int * a;", |
| 2650 | getGoogleStyle())); |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2651 | } |
| 2652 | |
Alexander Kornienko | 3fd9ccd | 2013-03-12 16:28:18 +0000 | [diff] [blame] | 2653 | TEST_F(FormatTest, UnderstandsRvalueReferences) { |
| 2654 | verifyFormat("int f(int &&a) {}"); |
| 2655 | verifyFormat("int f(int a, char &&b) {}"); |
| 2656 | verifyFormat("void f() { int &&a = b; }"); |
| 2657 | verifyGoogleFormat("int f(int a, char&& b) {}"); |
| 2658 | verifyGoogleFormat("void f() { int&& a = b; }"); |
| 2659 | |
| 2660 | // FIXME: These require somewhat deeper changes in template arguments |
| 2661 | // formatting. |
| 2662 | // verifyIndependentOfContext("A<int &&> a;"); |
| 2663 | // verifyIndependentOfContext("A<int &&, int &&> a;"); |
| 2664 | // verifyGoogleFormat("A<int&&> a;"); |
| 2665 | // verifyGoogleFormat("A<int&&, int&&> a;"); |
| 2666 | } |
| 2667 | |
Manuel Klimek | a32a7fd | 2013-01-23 14:08:21 +0000 | [diff] [blame] | 2668 | TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) { |
| 2669 | verifyFormat("void f() {\n" |
| 2670 | " x[aaaaaaaaa -\n" |
Daniel Jasper | bf71ba2 | 2013-04-08 20:33:42 +0000 | [diff] [blame] | 2671 | " b] = 23;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2672 | "}", |
| 2673 | getLLVMStyleWithColumns(15)); |
Manuel Klimek | a32a7fd | 2013-01-23 14:08:21 +0000 | [diff] [blame] | 2674 | } |
| 2675 | |
Daniel Jasper | 4981bd0 | 2013-01-13 08:01:36 +0000 | [diff] [blame] | 2676 | TEST_F(FormatTest, FormatsCasts) { |
| 2677 | verifyFormat("Type *A = static_cast<Type *>(P);"); |
| 2678 | verifyFormat("Type *A = (Type *)P;"); |
| 2679 | verifyFormat("Type *A = (vector<Type *, int *>)P;"); |
| 2680 | verifyFormat("int a = (int)(2.0f);"); |
| 2681 | |
| 2682 | // FIXME: These also need to be identified. |
| 2683 | verifyFormat("int a = (int) 2.0f;"); |
| 2684 | verifyFormat("int a = (int) * b;"); |
| 2685 | |
| 2686 | // These are not casts. |
| 2687 | verifyFormat("void f(int *) {}"); |
Nico Weber | 6fa7e74 | 2013-02-13 04:32:57 +0000 | [diff] [blame] | 2688 | verifyFormat("f(foo)->b;"); |
| 2689 | verifyFormat("f(foo).b;"); |
| 2690 | verifyFormat("f(foo)(b);"); |
| 2691 | verifyFormat("f(foo)[b];"); |
| 2692 | verifyFormat("[](foo) { return 4; }(bar)];"); |
| 2693 | verifyFormat("(*funptr)(foo)[4];"); |
| 2694 | verifyFormat("funptrs[4](foo)[4];"); |
Daniel Jasper | 4981bd0 | 2013-01-13 08:01:36 +0000 | [diff] [blame] | 2695 | verifyFormat("void f(int *);"); |
| 2696 | verifyFormat("void f(int *) = 0;"); |
| 2697 | verifyFormat("void f(SmallVector<int>) {}"); |
| 2698 | verifyFormat("void f(SmallVector<int>);"); |
| 2699 | verifyFormat("void f(SmallVector<int>) = 0;"); |
Nico Weber | 7728057 | 2013-02-09 18:02:07 +0000 | [diff] [blame] | 2700 | verifyFormat("void f(int i = (kValue) * kMask) {}"); |
| 2701 | verifyFormat("void f(int i = (kA * kB) & kMask) {}"); |
Nico Weber | 6fa7e74 | 2013-02-13 04:32:57 +0000 | [diff] [blame] | 2702 | verifyFormat("int a = sizeof(int) * b;"); |
| 2703 | verifyFormat("int a = alignof(int) * b;"); |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2704 | |
Daniel Jasper | 37eff83 | 2013-02-23 08:07:18 +0000 | [diff] [blame] | 2705 | // These are not casts, but at some point were confused with casts. |
| 2706 | verifyFormat("virtual void foo(int *) override;"); |
| 2707 | verifyFormat("virtual void foo(char &) const;"); |
| 2708 | verifyFormat("virtual void foo(int *a, char *) const;"); |
Daniel Jasper | 6a365aa | 2013-03-13 17:13:53 +0000 | [diff] [blame] | 2709 | verifyFormat("int a = sizeof(int *) + b;"); |
| 2710 | verifyFormat("int a = alignof(int *) + b;"); |
Daniel Jasper | 4981bd0 | 2013-01-13 08:01:36 +0000 | [diff] [blame] | 2711 | } |
| 2712 | |
Daniel Jasper | 46ef852 | 2013-01-10 13:08:12 +0000 | [diff] [blame] | 2713 | TEST_F(FormatTest, FormatsFunctionTypes) { |
Daniel Jasper | 46ef852 | 2013-01-10 13:08:12 +0000 | [diff] [blame] | 2714 | verifyFormat("A<bool()> a;"); |
| 2715 | verifyFormat("A<SomeType()> a;"); |
| 2716 | verifyFormat("A<void(*)(int, std::string)> a;"); |
Daniel Jasper | 9322aae | 2013-03-20 09:53:18 +0000 | [diff] [blame] | 2717 | verifyFormat("A<void *(int)>;"); |
Daniel Jasper | 81d2d38 | 2013-04-01 17:13:26 +0000 | [diff] [blame] | 2718 | verifyFormat("void *(*a)(int *, SomeType *);"); |
Daniel Jasper | 46ef852 | 2013-01-10 13:08:12 +0000 | [diff] [blame] | 2719 | |
Daniel Jasper | 8a5d7cd | 2013-03-01 17:13:29 +0000 | [diff] [blame] | 2720 | // FIXME: Inconsistent. |
| 2721 | verifyFormat("int (*func)(void *);"); |
| 2722 | verifyFormat("void f() { int(*func)(void *); }"); |
Daniel Jasper | 9322aae | 2013-03-20 09:53:18 +0000 | [diff] [blame] | 2723 | |
Daniel Jasper | 81d2d38 | 2013-04-01 17:13:26 +0000 | [diff] [blame] | 2724 | verifyGoogleFormat("A<void*(int*, SomeType*)>;"); |
| 2725 | verifyGoogleFormat("void* (*a)(int);"); |
Daniel Jasper | 46ef852 | 2013-01-10 13:08:12 +0000 | [diff] [blame] | 2726 | } |
| 2727 | |
Daniel Jasper | 3c08a81 | 2013-02-24 18:54:32 +0000 | [diff] [blame] | 2728 | TEST_F(FormatTest, BreaksLongDeclarations) { |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 2729 | verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n" |
| 2730 | " AnotherNameForTheLongType;"); |
| 2731 | verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" |
| 2732 | " LoooooooooooooooooooooooooooooooooooooooongVariable;"); |
| 2733 | verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" |
| 2734 | " LoooooooooooooooooooooooooooooooongFunctionDeclaration();"); |
| 2735 | verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" |
| 2736 | "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); |
| 2737 | |
| 2738 | // FIXME: Without the comment, this breaks after "(". |
| 2739 | verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n" |
| 2740 | " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();"); |
| 2741 | |
Daniel Jasper | 83f25ba | 2013-01-28 15:16:31 +0000 | [diff] [blame] | 2742 | verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 2743 | " int LoooooooooooooooooooongParam2) {}"); |
Daniel Jasper | 4dc41de | 2013-01-02 08:44:14 +0000 | [diff] [blame] | 2744 | verifyFormat( |
Daniel Jasper | 1407bee | 2013-04-11 14:29:13 +0000 | [diff] [blame] | 2745 | "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n" |
| 2746 | " SourceLocation L, IdentifierIn *II,\n" |
| 2747 | " Type *T) {}"); |
Daniel Jasper | 3c08a81 | 2013-02-24 18:54:32 +0000 | [diff] [blame] | 2748 | verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n" |
| 2749 | "ReallyReallyLongFunctionName(\n" |
| 2750 | " const std::string &SomeParameter,\n" |
| 2751 | " const SomeType<string, SomeOtherTemplateParameter> &\n" |
| 2752 | " ReallyReallyLongParameterName,\n" |
| 2753 | " const SomeType<string, SomeOtherTemplateParameter> &\n" |
| 2754 | " AnotherLongParameterName) {}"); |
| 2755 | verifyFormat( |
| 2756 | "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n" |
Daniel Jasper | 53e72cd | 2013-05-06 08:27:33 +0000 | [diff] [blame] | 2757 | " aaaaaaaaaaaaaaaaaaaaaaa;"); |
Daniel Jasper | 3c08a81 | 2013-02-24 18:54:32 +0000 | [diff] [blame] | 2758 | |
Daniel Jasper | d75ff64 | 2013-01-28 15:40:20 +0000 | [diff] [blame] | 2759 | verifyGoogleFormat( |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2760 | "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n" |
| 2761 | " SourceLocation L) {}"); |
Daniel Jasper | a03ab10 | 2013-02-13 20:33:44 +0000 | [diff] [blame] | 2762 | verifyGoogleFormat( |
| 2763 | "some_namespace::LongReturnType\n" |
| 2764 | "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 2765 | " int first_long_parameter, int second_parameter) {}"); |
Daniel Jasper | a03ab10 | 2013-02-13 20:33:44 +0000 | [diff] [blame] | 2766 | |
| 2767 | verifyGoogleFormat("template <typename T>\n" |
| 2768 | "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n" |
Daniel Jasper | f11a705 | 2013-02-21 21:33:55 +0000 | [diff] [blame] | 2769 | "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}"); |
Daniel Jasper | b6f02f3 | 2013-02-28 10:06:05 +0000 | [diff] [blame] | 2770 | verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" |
| 2771 | " int aaaaaaaaaaaaaaaaaaaaaaa);"); |
Daniel Jasper | 4dc41de | 2013-01-02 08:44:14 +0000 | [diff] [blame] | 2772 | } |
| 2773 | |
Daniel Jasper | 3b5943f | 2012-12-06 09:56:08 +0000 | [diff] [blame] | 2774 | TEST_F(FormatTest, LineStartsWithSpecialCharacter) { |
| 2775 | verifyFormat("(a)->b();"); |
| 2776 | verifyFormat("--a;"); |
| 2777 | } |
| 2778 | |
Daniel Jasper | 8822d3a | 2012-12-04 13:02:32 +0000 | [diff] [blame] | 2779 | TEST_F(FormatTest, HandlesIncludeDirectives) { |
Daniel Jasper | 2b9c10b | 2013-01-14 15:52:06 +0000 | [diff] [blame] | 2780 | verifyFormat("#include <string>\n" |
| 2781 | "#include <a/b/c.h>\n" |
| 2782 | "#include \"a/b/string\"\n" |
| 2783 | "#include \"string.h\"\n" |
| 2784 | "#include \"string.h\"\n" |
Manuel Klimek | 407a31a | 2013-01-15 15:50:27 +0000 | [diff] [blame] | 2785 | "#include <a-a>\n" |
Daniel Jasper | 3a20441 | 2013-02-23 07:46:38 +0000 | [diff] [blame] | 2786 | "#include < path with space >\n" |
Daniel Jasper | 7ff96ed | 2013-05-06 10:24:51 +0000 | [diff] [blame] | 2787 | "#include \"abc.h\" // this is included for ABC\n" |
Daniel Jasper | 3a20441 | 2013-02-23 07:46:38 +0000 | [diff] [blame] | 2788 | "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"", |
| 2789 | getLLVMStyleWithColumns(35)); |
Nico Weber | b23ae0c | 2012-12-21 18:21:56 +0000 | [diff] [blame] | 2790 | |
Daniel Jasper | 8134e1e | 2013-01-13 08:12:18 +0000 | [diff] [blame] | 2791 | verifyFormat("#import <string>"); |
| 2792 | verifyFormat("#import <a/b/c.h>"); |
| 2793 | verifyFormat("#import \"a/b/string\""); |
| 2794 | verifyFormat("#import \"string.h\""); |
| 2795 | verifyFormat("#import \"string.h\""); |
Daniel Jasper | 8822d3a | 2012-12-04 13:02:32 +0000 | [diff] [blame] | 2796 | } |
| 2797 | |
Alexander Kornienko | 1575731 | 2012-12-06 18:03:27 +0000 | [diff] [blame] | 2798 | //===----------------------------------------------------------------------===// |
| 2799 | // Error recovery tests. |
| 2800 | //===----------------------------------------------------------------------===// |
| 2801 | |
Daniel Jasper | c5cfa49 | 2013-02-14 09:19:04 +0000 | [diff] [blame] | 2802 | TEST_F(FormatTest, IncompleteParameterLists) { |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 2803 | FormatStyle NoBinPacking = getLLVMStyle(); |
| 2804 | NoBinPacking.BinPackParameters = false; |
| 2805 | verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n" |
| 2806 | " double *min_x,\n" |
| 2807 | " double *max_x,\n" |
| 2808 | " double *min_y,\n" |
| 2809 | " double *max_y,\n" |
| 2810 | " double *min_z,\n" |
| 2811 | " double *max_z, ) {}", |
| 2812 | NoBinPacking); |
Daniel Jasper | c5cfa49 | 2013-02-14 09:19:04 +0000 | [diff] [blame] | 2813 | } |
| 2814 | |
Daniel Jasper | 700e710 | 2013-01-10 09:26:47 +0000 | [diff] [blame] | 2815 | TEST_F(FormatTest, IncorrectCodeTrailingStuff) { |
Alexander Kornienko | 51c23fa | 2013-01-16 11:45:16 +0000 | [diff] [blame] | 2816 | verifyFormat("void f() { return; }\n42"); |
| 2817 | verifyFormat("void f() {\n" |
| 2818 | " if (0)\n" |
| 2819 | " return;\n" |
| 2820 | "}\n" |
| 2821 | "42"); |
Alexander Kornienko | d881875 | 2013-01-16 11:43:46 +0000 | [diff] [blame] | 2822 | verifyFormat("void f() { return }\n42"); |
| 2823 | verifyFormat("void f() {\n" |
| 2824 | " if (0)\n" |
| 2825 | " return\n" |
| 2826 | "}\n" |
| 2827 | "42"); |
| 2828 | } |
| 2829 | |
| 2830 | TEST_F(FormatTest, IncorrectCodeMissingSemicolon) { |
| 2831 | EXPECT_EQ("void f() { return }", format("void f ( ) { return }")); |
| 2832 | EXPECT_EQ("void f() {\n" |
| 2833 | " if (a)\n" |
| 2834 | " return\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2835 | "}", |
| 2836 | format("void f ( ) { if ( a ) return }")); |
Alexander Kornienko | d881875 | 2013-01-16 11:43:46 +0000 | [diff] [blame] | 2837 | EXPECT_EQ("namespace N { void f() }", format("namespace N { void f() }")); |
| 2838 | EXPECT_EQ("namespace N {\n" |
| 2839 | "void f() {}\n" |
| 2840 | "void g()\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2841 | "}", |
| 2842 | format("namespace N { void f( ) { } void g( ) }")); |
Daniel Jasper | 700e710 | 2013-01-10 09:26:47 +0000 | [diff] [blame] | 2843 | } |
| 2844 | |
Daniel Jasper | ceb99ab | 2013-01-09 10:16:05 +0000 | [diff] [blame] | 2845 | TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) { |
| 2846 | verifyFormat("int aaaaaaaa =\n" |
Alexander Kornienko | 5262dd9 | 2013-03-27 11:52:18 +0000 | [diff] [blame] | 2847 | " // Overlylongcomment\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2848 | " b;", |
| 2849 | getLLVMStyleWithColumns(20)); |
Daniel Jasper | ceb99ab | 2013-01-09 10:16:05 +0000 | [diff] [blame] | 2850 | verifyFormat("function(\n" |
| 2851 | " ShortArgument,\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2852 | " LoooooooooooongArgument);\n", |
| 2853 | getLLVMStyleWithColumns(20)); |
Daniel Jasper | ceb99ab | 2013-01-09 10:16:05 +0000 | [diff] [blame] | 2854 | } |
| 2855 | |
Alexander Kornienko | 56e49c5 | 2012-12-10 16:34:48 +0000 | [diff] [blame] | 2856 | TEST_F(FormatTest, IncorrectAccessSpecifier) { |
| 2857 | verifyFormat("public:"); |
| 2858 | verifyFormat("class A {\n" |
| 2859 | "public\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2860 | " void f() {}\n" |
Alexander Kornienko | 56e49c5 | 2012-12-10 16:34:48 +0000 | [diff] [blame] | 2861 | "};"); |
| 2862 | verifyFormat("public\n" |
| 2863 | "int qwerty;"); |
| 2864 | verifyFormat("public\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2865 | "B {}"); |
Alexander Kornienko | 56e49c5 | 2012-12-10 16:34:48 +0000 | [diff] [blame] | 2866 | verifyFormat("public\n" |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2867 | "{}"); |
Alexander Kornienko | 56e49c5 | 2012-12-10 16:34:48 +0000 | [diff] [blame] | 2868 | verifyFormat("public\n" |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 2869 | "B { int x; }"); |
Alexander Kornienko | 56e49c5 | 2012-12-10 16:34:48 +0000 | [diff] [blame] | 2870 | } |
Daniel Jasper | bac016b | 2012-12-03 18:12:45 +0000 | [diff] [blame] | 2871 | |
Daniel Jasper | 92f9faf | 2013-03-20 15:58:10 +0000 | [diff] [blame] | 2872 | TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) { |
| 2873 | verifyFormat("{"); |
| 2874 | verifyFormat("#})"); |
| 2875 | } |
Alexander Kornienko | 393b008 | 2012-12-04 15:40:36 +0000 | [diff] [blame] | 2876 | |
| 2877 | TEST_F(FormatTest, IncorrectCodeDoNoWhile) { |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2878 | verifyFormat("do {\n}"); |
| 2879 | verifyFormat("do {\n}\n" |
Alexander Kornienko | 393b008 | 2012-12-04 15:40:36 +0000 | [diff] [blame] | 2880 | "f();"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2881 | verifyFormat("do {\n}\n" |
Alexander Kornienko | 393b008 | 2012-12-04 15:40:36 +0000 | [diff] [blame] | 2882 | "wheeee(fun);"); |
| 2883 | verifyFormat("do {\n" |
| 2884 | " f();\n" |
Manuel Klimek | de76854 | 2013-01-07 18:10:23 +0000 | [diff] [blame] | 2885 | "}"); |
Alexander Kornienko | 393b008 | 2012-12-04 15:40:36 +0000 | [diff] [blame] | 2886 | } |
| 2887 | |
Manuel Klimek | 6eca03f | 2013-01-11 19:23:05 +0000 | [diff] [blame] | 2888 | TEST_F(FormatTest, IncorrectCodeMissingParens) { |
Manuel Klimek | d465843 | 2013-01-11 18:28:36 +0000 | [diff] [blame] | 2889 | verifyFormat("if {\n foo;\n foo();\n}"); |
Manuel Klimek | 6eca03f | 2013-01-11 19:23:05 +0000 | [diff] [blame] | 2890 | verifyFormat("switch {\n foo;\n foo();\n}"); |
| 2891 | verifyFormat("for {\n foo;\n foo();\n}"); |
| 2892 | verifyFormat("while {\n foo;\n foo();\n}"); |
| 2893 | verifyFormat("do {\n foo;\n foo();\n} while;"); |
Manuel Klimek | d465843 | 2013-01-11 18:28:36 +0000 | [diff] [blame] | 2894 | } |
| 2895 | |
Daniel Jasper | 1f42f11 | 2013-01-04 18:52:56 +0000 | [diff] [blame] | 2896 | TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) { |
| 2897 | verifyFormat("namespace {\n" |
Manuel Klimek | d4397b9 | 2013-01-04 23:34:14 +0000 | [diff] [blame] | 2898 | "class Foo { Foo ( }; } // comment"); |
Daniel Jasper | 1f42f11 | 2013-01-04 18:52:56 +0000 | [diff] [blame] | 2899 | } |
| 2900 | |
Alexander Kornienko | cff563c | 2012-12-04 17:27:50 +0000 | [diff] [blame] | 2901 | TEST_F(FormatTest, IncorrectCodeErrorDetection) { |
Manuel Klimek | 36fab8d | 2013-01-10 13:24:24 +0000 | [diff] [blame] | 2902 | EXPECT_EQ("{\n{}\n", format("{\n{\n}\n")); |
| 2903 | EXPECT_EQ("{\n {}\n", format("{\n {\n}\n")); |
| 2904 | EXPECT_EQ("{\n {}\n", format("{\n {\n }\n")); |
| 2905 | EXPECT_EQ("{\n {}\n }\n}\n", format("{\n {\n }\n }\n}\n")); |
Alexander Kornienko | cff563c | 2012-12-04 17:27:50 +0000 | [diff] [blame] | 2906 | |
Alexander Kornienko | cff563c | 2012-12-04 17:27:50 +0000 | [diff] [blame] | 2907 | EXPECT_EQ("{\n" |
| 2908 | " {\n" |
| 2909 | " breakme(\n" |
| 2910 | " qwe);\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2911 | "}\n", |
| 2912 | format("{\n" |
| 2913 | " {\n" |
| 2914 | " breakme(qwe);\n" |
| 2915 | "}\n", |
| 2916 | getLLVMStyleWithColumns(10))); |
Alexander Kornienko | cff563c | 2012-12-04 17:27:50 +0000 | [diff] [blame] | 2917 | } |
| 2918 | |
Manuel Klimek | 2851c16 | 2013-01-10 14:36:46 +0000 | [diff] [blame] | 2919 | TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) { |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 2920 | verifyFormat("int x = {\n" |
| 2921 | " avariable,\n" |
| 2922 | " b(alongervariable)\n" |
| 2923 | "};", |
| 2924 | getLLVMStyleWithColumns(25)); |
Manuel Klimek | 2851c16 | 2013-01-10 14:36:46 +0000 | [diff] [blame] | 2925 | } |
| 2926 | |
Manuel Klimek | c44ee89 | 2013-01-21 10:07:49 +0000 | [diff] [blame] | 2927 | TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) { |
| 2928 | verifyFormat("return (a)(b) { 1, 2, 3 };"); |
| 2929 | } |
| 2930 | |
Manuel Klimek | 2851c16 | 2013-01-10 14:36:46 +0000 | [diff] [blame] | 2931 | TEST_F(FormatTest, LayoutTokensFollowingBlockInParentheses) { |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 2932 | // FIXME: This is bad, find a better and more generic solution. |
Manuel Klimek | 2851c16 | 2013-01-10 14:36:46 +0000 | [diff] [blame] | 2933 | verifyFormat( |
| 2934 | "Aaa({\n" |
| 2935 | " int i;\n" |
Daniel Jasper | 7d81281 | 2013-02-21 15:00:29 +0000 | [diff] [blame] | 2936 | "},\n" |
| 2937 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" |
| 2938 | " ccccccccccccccccc));"); |
Manuel Klimek | 2851c16 | 2013-01-10 14:36:46 +0000 | [diff] [blame] | 2939 | } |
| 2940 | |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 2941 | TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) { |
| 2942 | verifyFormat("void f() { return 42; }"); |
| 2943 | verifyFormat("void f() {\n" |
| 2944 | " // Comment\n" |
| 2945 | "}"); |
| 2946 | verifyFormat("{\n" |
| 2947 | "#error {\n" |
| 2948 | " int a;\n" |
| 2949 | "}"); |
| 2950 | verifyFormat("{\n" |
| 2951 | " int a;\n" |
| 2952 | "#error {\n" |
| 2953 | "}"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2954 | |
| 2955 | verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23)); |
| 2956 | verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22)); |
| 2957 | |
| 2958 | verifyFormat("void f() {}", getLLVMStyleWithColumns(11)); |
| 2959 | verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10)); |
Manuel Klimek | 517e894 | 2013-01-11 17:54:10 +0000 | [diff] [blame] | 2960 | } |
| 2961 | |
Manuel Klimek | 47ea7f6 | 2013-01-15 13:38:33 +0000 | [diff] [blame] | 2962 | TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) { |
| 2963 | // Elaborate type variable declarations. |
Manuel Klimek | 606e07e | 2013-01-11 18:13:04 +0000 | [diff] [blame] | 2964 | verifyFormat("struct foo a = { bar };\nint n;"); |
Manuel Klimek | 47ea7f6 | 2013-01-15 13:38:33 +0000 | [diff] [blame] | 2965 | verifyFormat("class foo a = { bar };\nint n;"); |
| 2966 | verifyFormat("union foo a = { bar };\nint n;"); |
| 2967 | |
| 2968 | // Elaborate types inside function definitions. |
| 2969 | verifyFormat("struct foo f() {}\nint n;"); |
| 2970 | verifyFormat("class foo f() {}\nint n;"); |
| 2971 | verifyFormat("union foo f() {}\nint n;"); |
| 2972 | |
| 2973 | // Templates. |
| 2974 | verifyFormat("template <class X> void f() {}\nint n;"); |
| 2975 | verifyFormat("template <struct X> void f() {}\nint n;"); |
| 2976 | verifyFormat("template <union X> void f() {}\nint n;"); |
| 2977 | |
| 2978 | // Actual definitions... |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2979 | verifyFormat("struct {\n} n;"); |
| 2980 | verifyFormat( |
| 2981 | "template <template <class T, class Y>, class Z> class X {\n} n;"); |
Manuel Klimek | 47ea7f6 | 2013-01-15 13:38:33 +0000 | [diff] [blame] | 2982 | verifyFormat("union Z {\n int n;\n} x;"); |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2983 | verifyFormat("class MACRO Z {\n} n;"); |
| 2984 | verifyFormat("class MACRO(X) Z {\n} n;"); |
| 2985 | verifyFormat("class __attribute__(X) Z {\n} n;"); |
| 2986 | verifyFormat("class __declspec(X) Z {\n} n;"); |
Manuel Klimek | b8b1ce1 | 2013-02-06 15:57:54 +0000 | [diff] [blame] | 2987 | verifyFormat("class A##B##C {\n} n;"); |
Manuel Klimek | 47ea7f6 | 2013-01-15 13:38:33 +0000 | [diff] [blame] | 2988 | |
Manuel Klimek | 7f5b025 | 2013-01-21 10:17:14 +0000 | [diff] [blame] | 2989 | // Redefinition from nested context: |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2990 | verifyFormat("class A::B::C {\n} n;"); |
Manuel Klimek | 7f5b025 | 2013-01-21 10:17:14 +0000 | [diff] [blame] | 2991 | |
Manuel Klimek | 3a3408c | 2013-01-21 13:58:54 +0000 | [diff] [blame] | 2992 | // Template definitions. |
| 2993 | // FIXME: This is still incorrectly handled at the formatter side. |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2994 | verifyFormat("template <> struct X < 15, i < 3 && 42 < 50 && 33<28> {\n};"); |
Manuel Klimek | 3a3408c | 2013-01-21 13:58:54 +0000 | [diff] [blame] | 2995 | |
| 2996 | // FIXME: |
| 2997 | // This now gets parsed incorrectly as class definition. |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 2998 | // verifyFormat("class A<int> f() {\n}\nint n;"); |
Manuel Klimek | 3a3408c | 2013-01-21 13:58:54 +0000 | [diff] [blame] | 2999 | |
Manuel Klimek | 47ea7f6 | 2013-01-15 13:38:33 +0000 | [diff] [blame] | 3000 | // Elaborate types where incorrectly parsing the structural element would |
| 3001 | // break the indent. |
| 3002 | verifyFormat("if (true)\n" |
| 3003 | " class X x;\n" |
| 3004 | "else\n" |
| 3005 | " f();\n"); |
Daniel Jasper | 6fe554e | 2013-03-20 15:12:38 +0000 | [diff] [blame] | 3006 | |
| 3007 | // This is simply incomplete. Formatting is not important, but must not crash. |
| 3008 | verifyFormat("class A:"); |
Manuel Klimek | 606e07e | 2013-01-11 18:13:04 +0000 | [diff] [blame] | 3009 | } |
| 3010 | |
Manuel Klimek | 407a31a | 2013-01-15 15:50:27 +0000 | [diff] [blame] | 3011 | TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) { |
| 3012 | verifyFormat("#error Leave all white!!!!! space* alone!\n"); |
| 3013 | verifyFormat("#warning Leave all white!!!!! space* alone!\n"); |
| 3014 | EXPECT_EQ("#error 1", format(" # error 1")); |
| 3015 | EXPECT_EQ("#warning 1", format(" # warning 1")); |
| 3016 | } |
| 3017 | |
Daniel Jasper | aae7bad | 2013-04-23 13:54:04 +0000 | [diff] [blame] | 3018 | TEST_F(FormatTest, FormatHashIfExpressions) { |
| 3019 | // FIXME: Come up with a better indentation for #elif. |
| 3020 | verifyFormat( |
| 3021 | "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n" |
| 3022 | " defined(BBBBBBBB)\n" |
| 3023 | "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n" |
| 3024 | " defined(BBBBBBBB)\n" |
| 3025 | "#endif", |
| 3026 | getLLVMStyleWithColumns(65)); |
| 3027 | } |
| 3028 | |
Manuel Klimek | 525fe16 | 2013-01-18 14:04:34 +0000 | [diff] [blame] | 3029 | TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) { |
| 3030 | FormatStyle AllowsMergedIf = getGoogleStyle(); |
| 3031 | AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; |
| 3032 | verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf); |
| 3033 | verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf); |
Manuel Klimek | 4c12812 | 2013-01-18 14:46:43 +0000 | [diff] [blame] | 3034 | verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf); |
| 3035 | EXPECT_EQ("if (true) return 42;", |
| 3036 | format("if (true)\nreturn 42;", AllowsMergedIf)); |
| 3037 | FormatStyle ShortMergedIf = AllowsMergedIf; |
| 3038 | ShortMergedIf.ColumnLimit = 25; |
Daniel Jasper | 2972d04 | 2013-04-25 08:56:26 +0000 | [diff] [blame] | 3039 | verifyFormat("#define A \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3040 | " if (true) return 42;", |
| 3041 | ShortMergedIf); |
Daniel Jasper | 2972d04 | 2013-04-25 08:56:26 +0000 | [diff] [blame] | 3042 | verifyFormat("#define A \\\n" |
| 3043 | " f(); \\\n" |
Manuel Klimek | 4c12812 | 2013-01-18 14:46:43 +0000 | [diff] [blame] | 3044 | " if (true)\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3045 | "#define B", |
| 3046 | ShortMergedIf); |
Daniel Jasper | 2972d04 | 2013-04-25 08:56:26 +0000 | [diff] [blame] | 3047 | verifyFormat("#define A \\\n" |
| 3048 | " f(); \\\n" |
Manuel Klimek | 4c12812 | 2013-01-18 14:46:43 +0000 | [diff] [blame] | 3049 | " if (true)\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3050 | "g();", |
| 3051 | ShortMergedIf); |
Manuel Klimek | 0fbe008 | 2013-01-21 14:16:56 +0000 | [diff] [blame] | 3052 | verifyFormat("{\n" |
| 3053 | "#ifdef A\n" |
| 3054 | " // Comment\n" |
| 3055 | " if (true) continue;\n" |
| 3056 | "#endif\n" |
| 3057 | " // Comment\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3058 | " if (true) continue;", |
| 3059 | ShortMergedIf); |
Manuel Klimek | 525fe16 | 2013-01-18 14:04:34 +0000 | [diff] [blame] | 3060 | } |
| 3061 | |
Manuel Klimek | 86721d2 | 2013-01-22 16:31:55 +0000 | [diff] [blame] | 3062 | TEST_F(FormatTest, BlockCommentsInControlLoops) { |
| 3063 | verifyFormat("if (0) /* a comment in a strange place */ {\n" |
| 3064 | " f();\n" |
| 3065 | "}"); |
| 3066 | verifyFormat("if (0) /* a comment in a strange place */ {\n" |
| 3067 | " f();\n" |
| 3068 | "} /* another comment */ else /* comment #3 */ {\n" |
| 3069 | " g();\n" |
| 3070 | "}"); |
| 3071 | verifyFormat("while (0) /* a comment in a strange place */ {\n" |
| 3072 | " f();\n" |
| 3073 | "}"); |
| 3074 | verifyFormat("for (;;) /* a comment in a strange place */ {\n" |
| 3075 | " f();\n" |
| 3076 | "}"); |
| 3077 | verifyFormat("do /* a comment in a strange place */ {\n" |
| 3078 | " f();\n" |
| 3079 | "} /* another comment */ while (0);"); |
| 3080 | } |
| 3081 | |
| 3082 | TEST_F(FormatTest, BlockComments) { |
| 3083 | EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */", |
| 3084 | format("/* *//* */ /* */\n/* *//* */ /* */")); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3085 | EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;")); |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 3086 | EXPECT_EQ("#define A /*123*/\\\n" |
Manuel Klimek | 86721d2 | 2013-01-22 16:31:55 +0000 | [diff] [blame] | 3087 | " b\n" |
| 3088 | "/* */\n" |
| 3089 | "someCall(\n" |
| 3090 | " parameter);", |
Alexander Kornienko | 7c22cf3 | 2013-03-21 12:28:10 +0000 | [diff] [blame] | 3091 | format("#define A /*123*/ b\n" |
Manuel Klimek | 86721d2 | 2013-01-22 16:31:55 +0000 | [diff] [blame] | 3092 | "/* */\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3093 | "someCall(parameter);", |
| 3094 | getLLVMStyleWithColumns(15))); |
Manuel Klimek | 86721d2 | 2013-01-22 16:31:55 +0000 | [diff] [blame] | 3095 | |
| 3096 | EXPECT_EQ("#define A\n" |
| 3097 | "/* */ someCall(\n" |
| 3098 | " parameter);", |
| 3099 | format("#define A\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3100 | "/* */someCall(parameter);", |
| 3101 | getLLVMStyleWithColumns(15))); |
Daniel Jasper | 2752ff3 | 2013-02-04 07:32:14 +0000 | [diff] [blame] | 3102 | |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 3103 | FormatStyle NoBinPacking = getLLVMStyle(); |
| 3104 | NoBinPacking.BinPackParameters = false; |
Daniel Jasper | 2752ff3 | 2013-02-04 07:32:14 +0000 | [diff] [blame] | 3105 | EXPECT_EQ("someFunction(1, /* comment 1 */\n" |
| 3106 | " 2, /* comment 2 */\n" |
| 3107 | " 3, /* comment 3 */\n" |
Daniel Jasper | cda1650 | 2013-02-04 08:34:57 +0000 | [diff] [blame] | 3108 | " aaaa,\n" |
| 3109 | " bbbb);", |
Daniel Jasper | 2752ff3 | 2013-02-04 07:32:14 +0000 | [diff] [blame] | 3110 | format("someFunction (1, /* comment 1 */\n" |
| 3111 | " 2, /* comment 2 */ \n" |
| 3112 | " 3, /* comment 3 */\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3113 | "aaaa, bbbb );", |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 3114 | NoBinPacking)); |
Daniel Jasper | 36ba0ff | 2013-02-06 15:23:09 +0000 | [diff] [blame] | 3115 | verifyFormat( |
| 3116 | "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 3117 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); |
| 3118 | EXPECT_EQ( |
| 3119 | "bool aaaaaaaaaaaaa = /* trailing comment */\n" |
| 3120 | " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 3121 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;", |
| 3122 | format( |
| 3123 | "bool aaaaaaaaaaaaa = /* trailing comment */\n" |
| 3124 | " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" |
| 3125 | " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;")); |
Daniel Jasper | 15417ef | 2013-02-06 20:07:35 +0000 | [diff] [blame] | 3126 | EXPECT_EQ( |
| 3127 | "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" |
| 3128 | "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" |
| 3129 | "int cccccccccccccccccccccccccccccc; /* comment */\n", |
| 3130 | format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" |
| 3131 | "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" |
| 3132 | "int cccccccccccccccccccccccccccccc; /* comment */\n")); |
Manuel Klimek | 86721d2 | 2013-01-22 16:31:55 +0000 | [diff] [blame] | 3133 | } |
| 3134 | |
Manuel Klimek | b3507cd | 2013-02-06 16:40:56 +0000 | [diff] [blame] | 3135 | TEST_F(FormatTest, BlockCommentsInMacros) { |
| 3136 | EXPECT_EQ("#define A \\\n" |
| 3137 | " { \\\n" |
| 3138 | " /* one line */ \\\n" |
| 3139 | " someCall();", |
| 3140 | format("#define A { \\\n" |
| 3141 | " /* one line */ \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3142 | " someCall();", |
| 3143 | getLLVMStyleWithColumns(20))); |
Manuel Klimek | b3507cd | 2013-02-06 16:40:56 +0000 | [diff] [blame] | 3144 | EXPECT_EQ("#define A \\\n" |
| 3145 | " { \\\n" |
| 3146 | " /* previous */ \\\n" |
| 3147 | " /* one line */ \\\n" |
| 3148 | " someCall();", |
| 3149 | format("#define A { \\\n" |
| 3150 | " /* previous */ \\\n" |
| 3151 | " /* one line */ \\\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3152 | " someCall();", |
| 3153 | getLLVMStyleWithColumns(20))); |
Manuel Klimek | b3507cd | 2013-02-06 16:40:56 +0000 | [diff] [blame] | 3154 | } |
| 3155 | |
| 3156 | TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) { |
| 3157 | // FIXME: This is not what we want... |
| 3158 | verifyFormat("{\n" |
| 3159 | "// a" |
| 3160 | "// b"); |
| 3161 | } |
| 3162 | |
Manuel Klimek | 092a2c7 | 2013-01-23 10:09:28 +0000 | [diff] [blame] | 3163 | TEST_F(FormatTest, FormatStarDependingOnContext) { |
Manuel Klimek | 70b03f4 | 2013-01-23 09:32:48 +0000 | [diff] [blame] | 3164 | verifyFormat("void f(int *a);"); |
| 3165 | verifyFormat("void f() { f(fint * b); }"); |
Manuel Klimek | 836b58f | 2013-01-23 11:03:04 +0000 | [diff] [blame] | 3166 | verifyFormat("class A {\n void f(int *a);\n};"); |
| 3167 | verifyFormat("class A {\n int *a;\n};"); |
| 3168 | verifyFormat("namespace a {\n" |
| 3169 | "namespace b {\n" |
| 3170 | "class A {\n" |
| 3171 | " void f() {}\n" |
| 3172 | " int *a;\n" |
| 3173 | "};\n" |
| 3174 | "}\n" |
| 3175 | "}"); |
Manuel Klimek | 70b03f4 | 2013-01-23 09:32:48 +0000 | [diff] [blame] | 3176 | } |
| 3177 | |
Manuel Klimek | 092a2c7 | 2013-01-23 10:09:28 +0000 | [diff] [blame] | 3178 | TEST_F(FormatTest, SpecialTokensAtEndOfLine) { |
| 3179 | verifyFormat("while"); |
| 3180 | verifyFormat("operator"); |
| 3181 | } |
| 3182 | |
Nico Weber | cf4a79c | 2013-01-08 17:56:31 +0000 | [diff] [blame] | 3183 | //===----------------------------------------------------------------------===// |
| 3184 | // Objective-C tests. |
| 3185 | //===----------------------------------------------------------------------===// |
| 3186 | |
Fariborz Jahanian | 154120c | 2012-12-20 19:54:13 +0000 | [diff] [blame] | 3187 | TEST_F(FormatTest, FormatForObjectiveCMethodDecls) { |
| 3188 | verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;"); |
| 3189 | EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;", |
| 3190 | format("-(NSUInteger)indexOfObject:(id)anObject;")); |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 3191 | EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;")); |
Fariborz Jahanian | 154120c | 2012-12-20 19:54:13 +0000 | [diff] [blame] | 3192 | EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;")); |
| 3193 | EXPECT_EQ("- (NSInteger)Method3:(id)anObject;", |
| 3194 | format("-(NSInteger)Method3:(id)anObject;")); |
| 3195 | EXPECT_EQ("- (NSInteger)Method4:(id)anObject;", |
| 3196 | format("-(NSInteger)Method4:(id)anObject;")); |
| 3197 | EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;", |
| 3198 | format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;")); |
| 3199 | EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;", |
| 3200 | format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;")); |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 3201 | EXPECT_EQ( |
| 3202 | "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;", |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3203 | format( |
| 3204 | "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;")); |
Fariborz Jahanian | 9b3f02c | 2012-12-21 22:51:18 +0000 | [diff] [blame] | 3205 | |
| 3206 | // Very long objectiveC method declaration. |
Daniel Jasper | 63d7ced | 2013-02-05 10:07:47 +0000 | [diff] [blame] | 3207 | verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n" |
| 3208 | " inRange:(NSRange)range\n" |
| 3209 | " outRange:(NSRange)out_range\n" |
| 3210 | " outRange1:(NSRange)out_range1\n" |
| 3211 | " outRange2:(NSRange)out_range2\n" |
| 3212 | " outRange3:(NSRange)out_range3\n" |
| 3213 | " outRange4:(NSRange)out_range4\n" |
| 3214 | " outRange5:(NSRange)out_range5\n" |
| 3215 | " outRange6:(NSRange)out_range6\n" |
| 3216 | " outRange7:(NSRange)out_range7\n" |
| 3217 | " outRange8:(NSRange)out_range8\n" |
| 3218 | " outRange9:(NSRange)out_range9;"); |
Nico Weber | e0fd429 | 2013-01-10 20:18:33 +0000 | [diff] [blame] | 3219 | |
| 3220 | verifyFormat("- (int)sum:(vector<int>)numbers;"); |
Nico Weber | aab6005 | 2013-01-17 06:14:50 +0000 | [diff] [blame] | 3221 | verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;"); |
Nico Weber | e0fd429 | 2013-01-10 20:18:33 +0000 | [diff] [blame] | 3222 | // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC |
| 3223 | // protocol lists (but not for template classes): |
| 3224 | //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;"); |
Nico Weber | cd52bda | 2013-01-10 23:11:41 +0000 | [diff] [blame] | 3225 | |
| 3226 | verifyFormat("- (int(*)())foo:(int(*)())f;"); |
Nico Weber | aab6005 | 2013-01-17 06:14:50 +0000 | [diff] [blame] | 3227 | verifyGoogleFormat("- (int(*)())foo:(int(*)())foo;"); |
Nico Weber | cd52bda | 2013-01-10 23:11:41 +0000 | [diff] [blame] | 3228 | |
| 3229 | // If there's no return type (very rare in practice!), LLVM and Google style |
| 3230 | // agree. |
Daniel Jasper | 627707b | 2013-03-22 16:55:40 +0000 | [diff] [blame] | 3231 | verifyFormat("- foo;"); |
Nico Weber | cd52bda | 2013-01-10 23:11:41 +0000 | [diff] [blame] | 3232 | verifyFormat("- foo:(int)f;"); |
| 3233 | verifyGoogleFormat("- foo:(int)foo;"); |
Fariborz Jahanian | 154120c | 2012-12-20 19:54:13 +0000 | [diff] [blame] | 3234 | } |
| 3235 | |
Daniel Jasper | 886568d | 2013-01-09 08:36:49 +0000 | [diff] [blame] | 3236 | TEST_F(FormatTest, FormatObjCBlocks) { |
Daniel Jasper | 46ef852 | 2013-01-10 13:08:12 +0000 | [diff] [blame] | 3237 | verifyFormat("int (^Block)(int, int);"); |
| 3238 | verifyFormat("int (^Block1)(int, int) = ^(int i, int j)"); |
Daniel Jasper | 886568d | 2013-01-09 08:36:49 +0000 | [diff] [blame] | 3239 | } |
| 3240 | |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3241 | TEST_F(FormatTest, FormatObjCInterface) { |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3242 | verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3243 | "@public\n" |
| 3244 | " int field1;\n" |
| 3245 | "@protected\n" |
| 3246 | " int field2;\n" |
| 3247 | "@private\n" |
| 3248 | " int field3;\n" |
| 3249 | "@package\n" |
| 3250 | " int field4;\n" |
| 3251 | "}\n" |
| 3252 | "+ (id)init;\n" |
| 3253 | "@end"); |
| 3254 | |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3255 | verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n" |
| 3256 | " @public\n" |
| 3257 | " int field1;\n" |
| 3258 | " @protected\n" |
| 3259 | " int field2;\n" |
| 3260 | " @private\n" |
| 3261 | " int field3;\n" |
| 3262 | " @package\n" |
| 3263 | " int field4;\n" |
| 3264 | "}\n" |
Nico Weber | aab6005 | 2013-01-17 06:14:50 +0000 | [diff] [blame] | 3265 | "+ (id)init;\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3266 | "@end"); |
| 3267 | |
Nico Weber | f5ecfa5 | 2013-01-22 16:53:59 +0000 | [diff] [blame] | 3268 | verifyFormat("@interface /* wait for it */ Foo\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3269 | "+ (id)init;\n" |
| 3270 | "// Look, a comment!\n" |
| 3271 | "- (int)answerWith:(int)i;\n" |
| 3272 | "@end"); |
| 3273 | |
| 3274 | verifyFormat("@interface Foo\n" |
Nico Weber | 049c447 | 2013-01-09 21:42:32 +0000 | [diff] [blame] | 3275 | "@end\n" |
| 3276 | "@interface Bar\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3277 | "@end"); |
| 3278 | |
| 3279 | verifyFormat("@interface Foo : Bar\n" |
| 3280 | "+ (id)init;\n" |
| 3281 | "@end"); |
| 3282 | |
Nico Weber | f5ecfa5 | 2013-01-22 16:53:59 +0000 | [diff] [blame] | 3283 | verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3284 | "+ (id)init;\n" |
| 3285 | "@end"); |
| 3286 | |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3287 | verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n" |
Nico Weber | aab6005 | 2013-01-17 06:14:50 +0000 | [diff] [blame] | 3288 | "+ (id)init;\n" |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3289 | "@end"); |
| 3290 | |
Nico Weber | ed91bba | 2013-01-10 19:19:14 +0000 | [diff] [blame] | 3291 | verifyFormat("@interface Foo (HackStuff)\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3292 | "+ (id)init;\n" |
| 3293 | "@end"); |
| 3294 | |
Nico Weber | ed91bba | 2013-01-10 19:19:14 +0000 | [diff] [blame] | 3295 | verifyFormat("@interface Foo ()\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3296 | "+ (id)init;\n" |
| 3297 | "@end"); |
| 3298 | |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3299 | verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3300 | "+ (id)init;\n" |
| 3301 | "@end"); |
| 3302 | |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3303 | verifyGoogleFormat("@interface Foo (HackStuff)<MyProtocol>\n" |
Nico Weber | aab6005 | 2013-01-17 06:14:50 +0000 | [diff] [blame] | 3304 | "+ (id)init;\n" |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3305 | "@end"); |
| 3306 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3307 | verifyFormat("@interface Foo {\n" |
| 3308 | " int _i;\n" |
| 3309 | "}\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3310 | "+ (id)init;\n" |
| 3311 | "@end"); |
| 3312 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3313 | verifyFormat("@interface Foo : Bar {\n" |
| 3314 | " int _i;\n" |
| 3315 | "}\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3316 | "+ (id)init;\n" |
| 3317 | "@end"); |
| 3318 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3319 | verifyFormat("@interface Foo : Bar <Baz, Quux> {\n" |
| 3320 | " int _i;\n" |
| 3321 | "}\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3322 | "+ (id)init;\n" |
| 3323 | "@end"); |
| 3324 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3325 | verifyFormat("@interface Foo (HackStuff) {\n" |
| 3326 | " int _i;\n" |
| 3327 | "}\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3328 | "+ (id)init;\n" |
| 3329 | "@end"); |
| 3330 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3331 | verifyFormat("@interface Foo () {\n" |
| 3332 | " int _i;\n" |
| 3333 | "}\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3334 | "+ (id)init;\n" |
| 3335 | "@end"); |
| 3336 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3337 | verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n" |
| 3338 | " int _i;\n" |
| 3339 | "}\n" |
Nico Weber | 27d1367 | 2013-01-09 20:25:35 +0000 | [diff] [blame] | 3340 | "+ (id)init;\n" |
| 3341 | "@end"); |
| 3342 | } |
| 3343 | |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3344 | TEST_F(FormatTest, FormatObjCImplementation) { |
| 3345 | verifyFormat("@implementation Foo : NSObject {\n" |
| 3346 | "@public\n" |
| 3347 | " int field1;\n" |
| 3348 | "@protected\n" |
| 3349 | " int field2;\n" |
| 3350 | "@private\n" |
| 3351 | " int field3;\n" |
| 3352 | "@package\n" |
| 3353 | " int field4;\n" |
| 3354 | "}\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 3355 | "+ (id)init {\n}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3356 | "@end"); |
| 3357 | |
| 3358 | verifyGoogleFormat("@implementation Foo : NSObject {\n" |
| 3359 | " @public\n" |
| 3360 | " int field1;\n" |
| 3361 | " @protected\n" |
| 3362 | " int field2;\n" |
| 3363 | " @private\n" |
| 3364 | " int field3;\n" |
| 3365 | " @package\n" |
| 3366 | " int field4;\n" |
| 3367 | "}\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 3368 | "+ (id)init {\n}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3369 | "@end"); |
| 3370 | |
| 3371 | verifyFormat("@implementation Foo\n" |
| 3372 | "+ (id)init {\n" |
Daniel Jasper | 6f5bb2c | 2013-01-14 16:24:39 +0000 | [diff] [blame] | 3373 | " if (true)\n" |
| 3374 | " return nil;\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3375 | "}\n" |
| 3376 | "// Look, a comment!\n" |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3377 | "- (int)answerWith:(int)i {\n" |
| 3378 | " return i;\n" |
| 3379 | "}\n" |
Nico Weber | 67015ed | 2013-01-11 21:14:08 +0000 | [diff] [blame] | 3380 | "+ (int)answerWith:(int)i {\n" |
| 3381 | " return i;\n" |
| 3382 | "}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3383 | "@end"); |
| 3384 | |
| 3385 | verifyFormat("@implementation Foo\n" |
| 3386 | "@end\n" |
| 3387 | "@implementation Bar\n" |
| 3388 | "@end"); |
| 3389 | |
| 3390 | verifyFormat("@implementation Foo : Bar\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 3391 | "+ (id)init {\n}\n" |
| 3392 | "- (void)foo {\n}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3393 | "@end"); |
| 3394 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3395 | verifyFormat("@implementation Foo {\n" |
| 3396 | " int _i;\n" |
| 3397 | "}\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 3398 | "+ (id)init {\n}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3399 | "@end"); |
| 3400 | |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3401 | verifyFormat("@implementation Foo : Bar {\n" |
| 3402 | " int _i;\n" |
| 3403 | "}\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 3404 | "+ (id)init {\n}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3405 | "@end"); |
| 3406 | |
Nico Weber | ed91bba | 2013-01-10 19:19:14 +0000 | [diff] [blame] | 3407 | verifyFormat("@implementation Foo (HackStuff)\n" |
Manuel Klimek | 2f1ac41 | 2013-01-21 16:42:44 +0000 | [diff] [blame] | 3408 | "+ (id)init {\n}\n" |
Nico Weber | 50767d8 | 2013-01-09 23:25:37 +0000 | [diff] [blame] | 3409 | "@end"); |
| 3410 | } |
| 3411 | |
Nico Weber | 1abe6ea | 2013-01-09 21:15:03 +0000 | [diff] [blame] | 3412 | TEST_F(FormatTest, FormatObjCProtocol) { |
| 3413 | verifyFormat("@protocol Foo\n" |
| 3414 | "@property(weak) id delegate;\n" |
| 3415 | "- (NSUInteger)numberOfThings;\n" |
| 3416 | "@end"); |
| 3417 | |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3418 | verifyFormat("@protocol MyProtocol <NSObject>\n" |
Nico Weber | 1abe6ea | 2013-01-09 21:15:03 +0000 | [diff] [blame] | 3419 | "- (NSUInteger)numberOfThings;\n" |
| 3420 | "@end"); |
| 3421 | |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3422 | verifyGoogleFormat("@protocol MyProtocol<NSObject>\n" |
Nico Weber | aab6005 | 2013-01-17 06:14:50 +0000 | [diff] [blame] | 3423 | "- (NSUInteger)numberOfThings;\n" |
Nico Weber | 5f500df | 2013-01-10 20:12:55 +0000 | [diff] [blame] | 3424 | "@end"); |
| 3425 | |
Nico Weber | 1abe6ea | 2013-01-09 21:15:03 +0000 | [diff] [blame] | 3426 | verifyFormat("@protocol Foo;\n" |
| 3427 | "@protocol Bar;\n"); |
Nico Weber | 049c447 | 2013-01-09 21:42:32 +0000 | [diff] [blame] | 3428 | |
| 3429 | verifyFormat("@protocol Foo\n" |
| 3430 | "@end\n" |
| 3431 | "@protocol Bar\n" |
| 3432 | "@end"); |
Nico Weber | b530fa3 | 2013-01-10 00:25:19 +0000 | [diff] [blame] | 3433 | |
| 3434 | verifyFormat("@protocol myProtocol\n" |
| 3435 | "- (void)mandatoryWithInt:(int)i;\n" |
| 3436 | "@optional\n" |
| 3437 | "- (void)optional;\n" |
| 3438 | "@required\n" |
| 3439 | "- (void)required;\n" |
Nico Weber | 880e538 | 2013-01-10 00:42:07 +0000 | [diff] [blame] | 3440 | "@optional\n" |
| 3441 | "@property(assign) int madProp;\n" |
Nico Weber | b530fa3 | 2013-01-10 00:25:19 +0000 | [diff] [blame] | 3442 | "@end\n"); |
Nico Weber | 1abe6ea | 2013-01-09 21:15:03 +0000 | [diff] [blame] | 3443 | } |
| 3444 | |
Daniel Jasper | 63d7ced | 2013-02-05 10:07:47 +0000 | [diff] [blame] | 3445 | TEST_F(FormatTest, FormatObjCMethodDeclarations) { |
| 3446 | verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" |
| 3447 | " rect:(NSRect)theRect\n" |
| 3448 | " interval:(float)theInterval {\n" |
| 3449 | "}"); |
| 3450 | verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" |
| 3451 | " longKeyword:(NSRect)theRect\n" |
| 3452 | " evenLongerKeyword:(float)theInterval\n" |
| 3453 | " error:(NSError **)theError {\n" |
| 3454 | "}"); |
| 3455 | } |
| 3456 | |
Nico Weber | bcfdd26 | 2013-01-12 06:18:40 +0000 | [diff] [blame] | 3457 | TEST_F(FormatTest, FormatObjCMethodExpr) { |
| 3458 | verifyFormat("[foo bar:baz];"); |
| 3459 | verifyFormat("return [foo bar:baz];"); |
| 3460 | verifyFormat("f([foo bar:baz]);"); |
| 3461 | verifyFormat("f(2, [foo bar:baz]);"); |
| 3462 | verifyFormat("f(2, a ? b : c);"); |
| 3463 | verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); |
| 3464 | |
Nico Weber | ee0feec | 2013-02-05 16:21:00 +0000 | [diff] [blame] | 3465 | // Unary operators. |
| 3466 | verifyFormat("int a = +[foo bar:baz];"); |
| 3467 | verifyFormat("int a = -[foo bar:baz];"); |
| 3468 | verifyFormat("int a = ![foo bar:baz];"); |
| 3469 | verifyFormat("int a = ~[foo bar:baz];"); |
| 3470 | verifyFormat("int a = ++[foo bar:baz];"); |
| 3471 | verifyFormat("int a = --[foo bar:baz];"); |
| 3472 | verifyFormat("int a = sizeof [foo bar:baz];"); |
| 3473 | verifyFormat("int a = alignof [foo bar:baz];"); |
Nico Weber | e8a9798 | 2013-02-06 06:20:11 +0000 | [diff] [blame] | 3474 | verifyFormat("int a = &[foo bar:baz];"); |
| 3475 | verifyFormat("int a = *[foo bar:baz];"); |
Nico Weber | ee0feec | 2013-02-05 16:21:00 +0000 | [diff] [blame] | 3476 | // FIXME: Make casts work, without breaking f()[4]. |
Nico Weber | 4c2cc60 | 2013-02-13 03:48:27 +0000 | [diff] [blame] | 3477 | //verifyFormat("int a = (int)[foo bar:baz];"); |
Nico Weber | e0dc7c7 | 2013-02-13 04:40:03 +0000 | [diff] [blame] | 3478 | //verifyFormat("return (int)[foo bar:baz];"); |
| 3479 | //verifyFormat("(void)[foo bar:baz];"); |
Nico Weber | 4c2cc60 | 2013-02-13 03:48:27 +0000 | [diff] [blame] | 3480 | verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); |
Nico Weber | ee0feec | 2013-02-05 16:21:00 +0000 | [diff] [blame] | 3481 | |
| 3482 | // Binary operators. |
Nico Weber | bcfdd26 | 2013-01-12 06:18:40 +0000 | [diff] [blame] | 3483 | verifyFormat("[foo bar:baz], [foo bar:baz];"); |
| 3484 | verifyFormat("[foo bar:baz] = [foo bar:baz];"); |
| 3485 | verifyFormat("[foo bar:baz] *= [foo bar:baz];"); |
| 3486 | verifyFormat("[foo bar:baz] /= [foo bar:baz];"); |
| 3487 | verifyFormat("[foo bar:baz] %= [foo bar:baz];"); |
| 3488 | verifyFormat("[foo bar:baz] += [foo bar:baz];"); |
| 3489 | verifyFormat("[foo bar:baz] -= [foo bar:baz];"); |
| 3490 | verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); |
| 3491 | verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); |
| 3492 | verifyFormat("[foo bar:baz] &= [foo bar:baz];"); |
| 3493 | verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); |
| 3494 | verifyFormat("[foo bar:baz] |= [foo bar:baz];"); |
| 3495 | verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); |
| 3496 | verifyFormat("[foo bar:baz] || [foo bar:baz];"); |
| 3497 | verifyFormat("[foo bar:baz] && [foo bar:baz];"); |
| 3498 | verifyFormat("[foo bar:baz] | [foo bar:baz];"); |
| 3499 | verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); |
| 3500 | verifyFormat("[foo bar:baz] & [foo bar:baz];"); |
| 3501 | verifyFormat("[foo bar:baz] == [foo bar:baz];"); |
| 3502 | verifyFormat("[foo bar:baz] != [foo bar:baz];"); |
| 3503 | verifyFormat("[foo bar:baz] >= [foo bar:baz];"); |
| 3504 | verifyFormat("[foo bar:baz] <= [foo bar:baz];"); |
| 3505 | verifyFormat("[foo bar:baz] > [foo bar:baz];"); |
| 3506 | verifyFormat("[foo bar:baz] < [foo bar:baz];"); |
| 3507 | verifyFormat("[foo bar:baz] >> [foo bar:baz];"); |
| 3508 | verifyFormat("[foo bar:baz] << [foo bar:baz];"); |
| 3509 | verifyFormat("[foo bar:baz] - [foo bar:baz];"); |
| 3510 | verifyFormat("[foo bar:baz] + [foo bar:baz];"); |
| 3511 | verifyFormat("[foo bar:baz] * [foo bar:baz];"); |
| 3512 | verifyFormat("[foo bar:baz] / [foo bar:baz];"); |
| 3513 | verifyFormat("[foo bar:baz] % [foo bar:baz];"); |
| 3514 | // Whew! |
| 3515 | |
Nico Weber | c2e6d2a | 2013-02-11 15:32:15 +0000 | [diff] [blame] | 3516 | verifyFormat("return in[42];"); |
| 3517 | verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" |
| 3518 | "}"); |
| 3519 | |
Nico Weber | bcfdd26 | 2013-01-12 06:18:40 +0000 | [diff] [blame] | 3520 | verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); |
| 3521 | verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); |
| 3522 | verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); |
| 3523 | verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); |
| 3524 | verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); |
Nico Weber | 6292dd4 | 2013-01-12 23:41:33 +0000 | [diff] [blame] | 3525 | verifyFormat("[button setAction:@selector(zoomOut:)];"); |
Nico Weber | cd45833 | 2013-01-12 23:48:49 +0000 | [diff] [blame] | 3526 | verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); |
Daniel Jasper | 63d7ced | 2013-02-05 10:07:47 +0000 | [diff] [blame] | 3527 | |
Nico Weber | bcfdd26 | 2013-01-12 06:18:40 +0000 | [diff] [blame] | 3528 | verifyFormat("arr[[self indexForFoo:a]];"); |
| 3529 | verifyFormat("throw [self errorFor:a];"); |
| 3530 | verifyFormat("@throw [self errorFor:a];"); |
| 3531 | |
Nico Weber | e8ccc81 | 2013-01-12 22:48:47 +0000 | [diff] [blame] | 3532 | // This tests that the formatter doesn't break after "backing" but before ":", |
| 3533 | // which would be at 80 columns. |
Nico Weber | bcfdd26 | 2013-01-12 06:18:40 +0000 | [diff] [blame] | 3534 | verifyFormat( |
| 3535 | "void f() {\n" |
Daniel Jasper | 63d7ced | 2013-02-05 10:07:47 +0000 | [diff] [blame] | 3536 | " if ((self = [super initWithContentRect:contentRect\n" |
| 3537 | " styleMask:styleMask\n" |
| 3538 | " backing:NSBackingStoreBuffered\n" |
| 3539 | " defer:YES]))"); |
| 3540 | |
Daniel Jasper | 4e77809 | 2013-02-06 10:05:46 +0000 | [diff] [blame] | 3541 | verifyFormat( |
| 3542 | "[foo checkThatBreakingAfterColonWorksOk:\n" |
| 3543 | " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); |
Daniel Jasper | 63d7ced | 2013-02-05 10:07:47 +0000 | [diff] [blame] | 3544 | |
| 3545 | verifyFormat("[myObj short:arg1 // Force line break\n" |
| 3546 | " longKeyword:arg2\n" |
| 3547 | " evenLongerKeyword:arg3\n" |
| 3548 | " error:arg4];"); |
| 3549 | verifyFormat( |
| 3550 | "void f() {\n" |
| 3551 | " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" |
| 3552 | " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" |
| 3553 | " pos.width(), pos.height())\n" |
| 3554 | " styleMask:NSBorderlessWindowMask\n" |
| 3555 | " backing:NSBackingStoreBuffered\n" |
| 3556 | " defer:NO]);\n" |
| 3557 | "}"); |
Daniel Jasper | 4e77809 | 2013-02-06 10:05:46 +0000 | [diff] [blame] | 3558 | verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" |
| 3559 | " with:contentsNativeView];"); |
| 3560 | |
| 3561 | verifyFormat( |
| 3562 | "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" |
| 3563 | " owner:nillllll];"); |
| 3564 | |
Daniel Jasper | 4e77809 | 2013-02-06 10:05:46 +0000 | [diff] [blame] | 3565 | verifyFormat( |
Daniel Jasper | ce3d1a6 | 2013-02-08 08:22:00 +0000 | [diff] [blame] | 3566 | "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" |
Daniel Jasper | 4e77809 | 2013-02-06 10:05:46 +0000 | [diff] [blame] | 3567 | " forType:kBookmarkButtonDragType];"); |
| 3568 | |
| 3569 | verifyFormat("[defaultCenter addObserver:self\n" |
| 3570 | " selector:@selector(willEnterFullscreen)\n" |
| 3571 | " name:kWillEnterFullscreenNotification\n" |
| 3572 | " object:nil];"); |
Daniel Jasper | 9e9e6e0 | 2013-02-06 16:00:26 +0000 | [diff] [blame] | 3573 | verifyFormat("[image_rep drawInRect:drawRect\n" |
| 3574 | " fromRect:NSZeroRect\n" |
| 3575 | " operation:NSCompositeCopy\n" |
| 3576 | " fraction:1.0\n" |
| 3577 | " respectFlipped:NO\n" |
| 3578 | " hints:nil];"); |
Nico Weber | 4ed7f3e | 2013-02-06 16:54:35 +0000 | [diff] [blame] | 3579 | |
| 3580 | verifyFormat( |
| 3581 | "scoped_nsobject<NSTextField> message(\n" |
| 3582 | " // The frame will be fixed up when |-setMessageText:| is called.\n" |
| 3583 | " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); |
Nico Weber | bcfdd26 | 2013-01-12 06:18:40 +0000 | [diff] [blame] | 3584 | } |
| 3585 | |
Nico Weber | 581f557 | 2013-01-07 15:56:25 +0000 | [diff] [blame] | 3586 | TEST_F(FormatTest, ObjCAt) { |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3587 | verifyFormat("@autoreleasepool"); |
Nico Weber | d0af4b4 | 2013-01-07 16:14:28 +0000 | [diff] [blame] | 3588 | verifyFormat("@catch"); |
| 3589 | verifyFormat("@class"); |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3590 | verifyFormat("@compatibility_alias"); |
| 3591 | verifyFormat("@defs"); |
Nico Weber | efcfe73 | 2013-01-07 15:17:23 +0000 | [diff] [blame] | 3592 | verifyFormat("@dynamic"); |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3593 | verifyFormat("@encode"); |
| 3594 | verifyFormat("@end"); |
| 3595 | verifyFormat("@finally"); |
| 3596 | verifyFormat("@implementation"); |
| 3597 | verifyFormat("@import"); |
| 3598 | verifyFormat("@interface"); |
| 3599 | verifyFormat("@optional"); |
| 3600 | verifyFormat("@package"); |
Nico Weber | d0af4b4 | 2013-01-07 16:14:28 +0000 | [diff] [blame] | 3601 | verifyFormat("@private"); |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3602 | verifyFormat("@property"); |
Nico Weber | d0af4b4 | 2013-01-07 16:14:28 +0000 | [diff] [blame] | 3603 | verifyFormat("@protected"); |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3604 | verifyFormat("@protocol"); |
Nico Weber | d0af4b4 | 2013-01-07 16:14:28 +0000 | [diff] [blame] | 3605 | verifyFormat("@public"); |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3606 | verifyFormat("@required"); |
| 3607 | verifyFormat("@selector"); |
| 3608 | verifyFormat("@synchronized"); |
| 3609 | verifyFormat("@synthesize"); |
Nico Weber | d0af4b4 | 2013-01-07 16:14:28 +0000 | [diff] [blame] | 3610 | verifyFormat("@throw"); |
| 3611 | verifyFormat("@try"); |
Nico Weber | 4a293a2 | 2013-01-07 16:07:07 +0000 | [diff] [blame] | 3612 | |
Nico Weber | 581f557 | 2013-01-07 15:56:25 +0000 | [diff] [blame] | 3613 | EXPECT_EQ("@interface", format("@ interface")); |
| 3614 | |
| 3615 | // The precise formatting of this doesn't matter, nobody writes code like |
| 3616 | // this. |
| 3617 | verifyFormat("@ /*foo*/ interface"); |
Nico Weber | efcfe73 | 2013-01-07 15:17:23 +0000 | [diff] [blame] | 3618 | } |
| 3619 | |
Nico Weber | c31689a | 2013-01-08 19:15:23 +0000 | [diff] [blame] | 3620 | TEST_F(FormatTest, ObjCSnippets) { |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3621 | verifyFormat("@autoreleasepool {\n" |
| 3622 | " foo();\n" |
| 3623 | "}"); |
Nico Weber | cf4a79c | 2013-01-08 17:56:31 +0000 | [diff] [blame] | 3624 | verifyFormat("@class Foo, Bar;"); |
Nico Weber | c31689a | 2013-01-08 19:15:23 +0000 | [diff] [blame] | 3625 | verifyFormat("@compatibility_alias AliasName ExistingClass;"); |
Nico Weber | cf4a79c | 2013-01-08 17:56:31 +0000 | [diff] [blame] | 3626 | verifyFormat("@dynamic textColor;"); |
Nico Weber | 5dfe9b4 | 2013-01-18 05:11:47 +0000 | [diff] [blame] | 3627 | verifyFormat("char *buf1 = @encode(int *);"); |
| 3628 | verifyFormat("char *buf1 = @encode(typeof(4 * 5));"); |
Nico Weber | 95e8e46 | 2013-02-12 16:17:07 +0000 | [diff] [blame] | 3629 | verifyFormat("char *buf1 = @encode(int **);"); |
Nico Weber | 3a2673e | 2013-01-08 20:16:23 +0000 | [diff] [blame] | 3630 | verifyFormat("Protocol *proto = @protocol(p1);"); |
Nico Weber | 6a21a55 | 2013-01-18 02:43:57 +0000 | [diff] [blame] | 3631 | verifyFormat("SEL s = @selector(foo:);"); |
Manuel Klimek | d5688cf | 2013-01-11 19:17:44 +0000 | [diff] [blame] | 3632 | verifyFormat("@synchronized(self) {\n" |
| 3633 | " f();\n" |
| 3634 | "}"); |
Nico Weber | cf4a79c | 2013-01-08 17:56:31 +0000 | [diff] [blame] | 3635 | |
Nico Weber | 7084823 | 2013-01-10 21:30:42 +0000 | [diff] [blame] | 3636 | verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); |
| 3637 | verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); |
| 3638 | |
Nico Weber | cf4a79c | 2013-01-08 17:56:31 +0000 | [diff] [blame] | 3639 | verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;"); |
Nico Weber | 7084823 | 2013-01-10 21:30:42 +0000 | [diff] [blame] | 3640 | verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); |
| 3641 | verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;"); |
Nico Weber | cf4a79c | 2013-01-08 17:56:31 +0000 | [diff] [blame] | 3642 | } |
| 3643 | |
Nico Weber | 712f5b3 | 2013-02-07 00:19:29 +0000 | [diff] [blame] | 3644 | TEST_F(FormatTest, ObjCLiterals) { |
| 3645 | verifyFormat("@\"String\""); |
| 3646 | verifyFormat("@1"); |
| 3647 | verifyFormat("@+4.8"); |
| 3648 | verifyFormat("@-4"); |
| 3649 | verifyFormat("@1LL"); |
| 3650 | verifyFormat("@.5"); |
| 3651 | verifyFormat("@'c'"); |
| 3652 | verifyFormat("@true"); |
| 3653 | |
| 3654 | verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);"); |
| 3655 | verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);"); |
| 3656 | verifyFormat("NSNumber *favoriteColor = @(Green);"); |
| 3657 | verifyFormat("NSString *path = @(getenv(\"PATH\"));"); |
| 3658 | |
Nico Weber | 712f5b3 | 2013-02-07 00:19:29 +0000 | [diff] [blame] | 3659 | verifyFormat("@["); |
Nico Weber | 051860e | 2013-02-10 02:08:05 +0000 | [diff] [blame] | 3660 | verifyFormat("@[]"); |
| 3661 | verifyFormat( |
| 3662 | "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); |
| 3663 | verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];"); |
| 3664 | |
Nico Weber | 712f5b3 | 2013-02-07 00:19:29 +0000 | [diff] [blame] | 3665 | verifyFormat("@{"); |
Nico Weber | d74fcdb | 2013-02-10 20:35:35 +0000 | [diff] [blame] | 3666 | verifyFormat("@{}"); |
| 3667 | verifyFormat("@{ @\"one\" : @1 }"); |
| 3668 | verifyFormat("return @{ @\"one\" : @1 };"); |
| 3669 | verifyFormat("@{ @\"one\" : @1, }"); |
Manuel Klimek | 67d080d | 2013-04-12 14:13:36 +0000 | [diff] [blame] | 3670 | |
| 3671 | // FIXME: Breaking in cases where we think there's a structural error |
| 3672 | // showed that we're incorrectly parsing this code. We need to fix the |
| 3673 | // parsing here. |
| 3674 | verifyFormat("@{ @\"one\" : @\n" |
| 3675 | "{ @2 : @1 }\n" |
| 3676 | "}"); |
| 3677 | verifyFormat("@{ @\"one\" : @\n" |
| 3678 | "{ @2 : @1 }\n" |
| 3679 | ",\n" |
| 3680 | "}"); |
| 3681 | |
Nico Weber | d74fcdb | 2013-02-10 20:35:35 +0000 | [diff] [blame] | 3682 | verifyFormat("@{ 1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2 }"); |
| 3683 | verifyFormat("[self setDict:@{}"); |
| 3684 | verifyFormat("[self setDict:@{ @1 : @2 }"); |
| 3685 | verifyFormat("NSLog(@\"%@\", @{ @1 : @2, @2 : @3 }[@1]);"); |
| 3686 | verifyFormat( |
| 3687 | "NSDictionary *masses = @{ @\"H\" : @1.0078, @\"He\" : @4.0026 };"); |
Nico Weber | e626200 | 2013-02-10 20:39:05 +0000 | [diff] [blame] | 3688 | verifyFormat( |
| 3689 | "NSDictionary *settings = @{ AVEncoderKey : @(AVAudioQualityMax) };"); |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3690 | |
Nico Weber | d74fcdb | 2013-02-10 20:35:35 +0000 | [diff] [blame] | 3691 | // FIXME: Nested and multi-line array and dictionary literals need more work. |
Nico Weber | 0ac717b | 2013-02-10 20:48:24 +0000 | [diff] [blame] | 3692 | verifyFormat( |
| 3693 | "NSDictionary *d = @{ @\"nam\" : NSUserNam(), @\"dte\" : [NSDate date],\n" |
| 3694 | " @\"processInfo\" : [NSProcessInfo processInfo] };"); |
Nico Weber | 712f5b3 | 2013-02-07 00:19:29 +0000 | [diff] [blame] | 3695 | } |
| 3696 | |
Manuel Klimek | 547d5db | 2013-02-08 17:38:27 +0000 | [diff] [blame] | 3697 | TEST_F(FormatTest, ReformatRegionAdjustsIndent) { |
| 3698 | EXPECT_EQ("{\n" |
| 3699 | "{\n" |
| 3700 | "a;\n" |
| 3701 | "b;\n" |
| 3702 | "}\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3703 | "}", |
| 3704 | format("{\n" |
| 3705 | "{\n" |
| 3706 | "a;\n" |
| 3707 | " b;\n" |
| 3708 | "}\n" |
| 3709 | "}", |
| 3710 | 13, 2, getLLVMStyle())); |
Manuel Klimek | 547d5db | 2013-02-08 17:38:27 +0000 | [diff] [blame] | 3711 | EXPECT_EQ("{\n" |
| 3712 | "{\n" |
| 3713 | " a;\n" |
| 3714 | "b;\n" |
| 3715 | "}\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3716 | "}", |
| 3717 | format("{\n" |
| 3718 | "{\n" |
| 3719 | " a;\n" |
| 3720 | "b;\n" |
| 3721 | "}\n" |
| 3722 | "}", |
| 3723 | 9, 2, getLLVMStyle())); |
Manuel Klimek | 547d5db | 2013-02-08 17:38:27 +0000 | [diff] [blame] | 3724 | EXPECT_EQ("{\n" |
| 3725 | "{\n" |
| 3726 | "public:\n" |
| 3727 | " b;\n" |
| 3728 | "}\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3729 | "}", |
| 3730 | format("{\n" |
| 3731 | "{\n" |
| 3732 | "public:\n" |
| 3733 | " b;\n" |
| 3734 | "}\n" |
| 3735 | "}", |
| 3736 | 17, 2, getLLVMStyle())); |
Manuel Klimek | 547d5db | 2013-02-08 17:38:27 +0000 | [diff] [blame] | 3737 | EXPECT_EQ("{\n" |
| 3738 | "{\n" |
| 3739 | "a;\n" |
| 3740 | "}\n" |
| 3741 | "{\n" |
| 3742 | " b;\n" |
| 3743 | "}\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3744 | "}", |
| 3745 | format("{\n" |
| 3746 | "{\n" |
| 3747 | "a;\n" |
| 3748 | "}\n" |
| 3749 | "{\n" |
| 3750 | " b;\n" |
| 3751 | "}\n" |
| 3752 | "}", |
| 3753 | 22, 2, getLLVMStyle())); |
Manuel Klimek | 52635ff | 2013-02-08 19:53:32 +0000 | [diff] [blame] | 3754 | EXPECT_EQ(" {\n" |
| 3755 | " a;\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3756 | " }", |
| 3757 | format(" {\n" |
| 3758 | "a;\n" |
| 3759 | " }", |
| 3760 | 4, 2, getLLVMStyle())); |
Daniel Jasper | 9ece2bb | 2013-02-12 16:51:23 +0000 | [diff] [blame] | 3761 | EXPECT_EQ("void f() {}\n" |
Daniel Jasper | 66d19bd | 2013-02-18 11:59:17 +0000 | [diff] [blame] | 3762 | "void g() {}", |
| 3763 | format("void f() {}\n" |
| 3764 | "void g() {}", |
| 3765 | 13, 0, getLLVMStyle())); |
Daniel Jasper | 83a90e5 | 2013-03-20 14:31:47 +0000 | [diff] [blame] | 3766 | EXPECT_EQ("int a; // comment\n" |
| 3767 | " // line 2\n" |
| 3768 | "int b;", |
| 3769 | format("int a; // comment\n" |
| 3770 | " // line 2\n" |
| 3771 | " int b;", |
| 3772 | 35, 0, getLLVMStyle())); |
Manuel Klimek | 52635ff | 2013-02-08 19:53:32 +0000 | [diff] [blame] | 3773 | } |
Manuel Klimek | 547d5db | 2013-02-08 17:38:27 +0000 | [diff] [blame] | 3774 | |
Manuel Klimek | 8092a94 | 2013-02-20 10:15:13 +0000 | [diff] [blame] | 3775 | TEST_F(FormatTest, BreakStringLiterals) { |
| 3776 | EXPECT_EQ("\"some text \"\n" |
| 3777 | "\"other\";", |
| 3778 | format("\"some text other\";", getLLVMStyleWithColumns(12))); |
Alexander Kornienko | 919398b | 2013-04-17 17:34:05 +0000 | [diff] [blame] | 3779 | EXPECT_EQ("\"some text \"\n" |
| 3780 | "\"other\";", |
| 3781 | format("\\\n\"some text other\";", getLLVMStyleWithColumns(12))); |
Manuel Klimek | 8092a94 | 2013-02-20 10:15:13 +0000 | [diff] [blame] | 3782 | EXPECT_EQ( |
| 3783 | "#define A \\\n" |
| 3784 | " \"some \" \\\n" |
| 3785 | " \"text \" \\\n" |
| 3786 | " \"other\";", |
| 3787 | format("#define A \"some text other\";", getLLVMStyleWithColumns(12))); |
| 3788 | EXPECT_EQ( |
| 3789 | "#define A \\\n" |
| 3790 | " \"so \" \\\n" |
| 3791 | " \"text \" \\\n" |
| 3792 | " \"other\";", |
| 3793 | format("#define A \"so text other\";", getLLVMStyleWithColumns(12))); |
| 3794 | |
| 3795 | EXPECT_EQ("\"some text\"", |
| 3796 | format("\"some text\"", getLLVMStyleWithColumns(1))); |
| 3797 | EXPECT_EQ("\"some text\"", |
| 3798 | format("\"some text\"", getLLVMStyleWithColumns(11))); |
| 3799 | EXPECT_EQ("\"some \"\n" |
| 3800 | "\"text\"", |
| 3801 | format("\"some text\"", getLLVMStyleWithColumns(10))); |
| 3802 | EXPECT_EQ("\"some \"\n" |
| 3803 | "\"text\"", |
| 3804 | format("\"some text\"", getLLVMStyleWithColumns(7))); |
Manuel Klimek | af31fd7 | 2013-03-01 13:14:08 +0000 | [diff] [blame] | 3805 | EXPECT_EQ("\"some\"\n" |
Alexander Kornienko | 70ce788 | 2013-04-15 14:28:00 +0000 | [diff] [blame] | 3806 | "\" tex\"\n" |
| 3807 | "\"t\"", |
Manuel Klimek | 8092a94 | 2013-02-20 10:15:13 +0000 | [diff] [blame] | 3808 | format("\"some text\"", getLLVMStyleWithColumns(6))); |
Manuel Klimek | 0090591 | 2013-03-04 20:03:38 +0000 | [diff] [blame] | 3809 | EXPECT_EQ("\"some\"\n" |
| 3810 | "\" tex\"\n" |
| 3811 | "\" and\"", |
| 3812 | format("\"some tex and\"", getLLVMStyleWithColumns(6))); |
| 3813 | EXPECT_EQ("\"some\"\n" |
| 3814 | "\"/tex\"\n" |
| 3815 | "\"/and\"", |
| 3816 | format("\"some/tex/and\"", getLLVMStyleWithColumns(6))); |
Manuel Klimek | 8092a94 | 2013-02-20 10:15:13 +0000 | [diff] [blame] | 3817 | |
| 3818 | EXPECT_EQ("variable =\n" |
| 3819 | " \"long string \"\n" |
| 3820 | " \"literal\";", |
| 3821 | format("variable = \"long string literal\";", |
| 3822 | getLLVMStyleWithColumns(20))); |
| 3823 | |
| 3824 | EXPECT_EQ("variable = f(\n" |
| 3825 | " \"long string \"\n" |
Daniel Jasper | faab0d3 | 2013-02-27 09:47:53 +0000 | [diff] [blame] | 3826 | " \"literal\",\n" |
| 3827 | " short,\n" |
Manuel Klimek | 8092a94 | 2013-02-20 10:15:13 +0000 | [diff] [blame] | 3828 | " loooooooooooooooooooong);", |
| 3829 | format("variable = f(\"long string literal\", short, " |
| 3830 | "loooooooooooooooooooong);", |
| 3831 | getLLVMStyleWithColumns(20))); |
| 3832 | EXPECT_EQ( |
| 3833 | "f(\"one two\".split(\n" |
| 3834 | " variable));", |
| 3835 | format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20))); |
| 3836 | EXPECT_EQ("f(\"one two three four five six \"\n" |
| 3837 | " \"seven\".split(\n" |
| 3838 | " really_looooong_variable));", |
| 3839 | format("f(\"one two three four five six seven\"." |
| 3840 | "split(really_looooong_variable));", |
| 3841 | getLLVMStyleWithColumns(33))); |
| 3842 | |
| 3843 | EXPECT_EQ("f(\"some \"\n" |
| 3844 | " \"text\",\n" |
| 3845 | " other);", |
| 3846 | format("f(\"some text\", other);", getLLVMStyleWithColumns(10))); |
Daniel Jasper | 0fb382b | 2013-02-26 12:52:34 +0000 | [diff] [blame] | 3847 | |
| 3848 | // Only break as a last resort. |
| 3849 | verifyFormat( |
| 3850 | "aaaaaaaaaaaaaaaaaaaa(\n" |
| 3851 | " aaaaaaaaaaaaaaaaaaaa,\n" |
| 3852 | " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));"); |
Manuel Klimek | af31fd7 | 2013-03-01 13:14:08 +0000 | [diff] [blame] | 3853 | |
| 3854 | EXPECT_EQ( |
| 3855 | "\"splitmea\"\n" |
Manuel Klimek | bc30c71 | 2013-03-01 13:29:19 +0000 | [diff] [blame] | 3856 | "\"trandomp\"\n" |
| 3857 | "\"oint\"", |
Manuel Klimek | af31fd7 | 2013-03-01 13:14:08 +0000 | [diff] [blame] | 3858 | format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10))); |
Manuel Klimek | bc30c71 | 2013-03-01 13:29:19 +0000 | [diff] [blame] | 3859 | |
| 3860 | EXPECT_EQ( |
| 3861 | "\"split/\"\n" |
| 3862 | "\"pathat/\"\n" |
| 3863 | "\"slashes\"", |
| 3864 | format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); |
Daniel Jasper | 2972d04 | 2013-04-25 08:56:26 +0000 | [diff] [blame] | 3865 | |
| 3866 | FormatStyle AlignLeft = getLLVMStyleWithColumns(12); |
| 3867 | AlignLeft.AlignEscapedNewlinesLeft = true; |
| 3868 | EXPECT_EQ( |
| 3869 | "#define A \\\n" |
| 3870 | " \"some \" \\\n" |
| 3871 | " \"text \" \\\n" |
| 3872 | " \"other\";", |
| 3873 | format("#define A \"some text other\";", AlignLeft)); |
Manuel Klimek | 8092a94 | 2013-02-20 10:15:13 +0000 | [diff] [blame] | 3874 | } |
| 3875 | |
Manuel Klimek | aa62d0c | 2013-03-08 18:59:48 +0000 | [diff] [blame] | 3876 | TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) { |
| 3877 | EXPECT_EQ("\"\\a\"", |
| 3878 | format("\"\\a\"", getLLVMStyleWithColumns(3))); |
| 3879 | EXPECT_EQ("\"\\\"", |
| 3880 | format("\"\\\"", getLLVMStyleWithColumns(2))); |
| 3881 | EXPECT_EQ("\"test\"\n" |
| 3882 | "\"\\n\"", |
| 3883 | format("\"test\\n\"", getLLVMStyleWithColumns(7))); |
| 3884 | EXPECT_EQ("\"tes\\\\\"\n" |
| 3885 | "\"n\"", |
| 3886 | format("\"tes\\\\n\"", getLLVMStyleWithColumns(7))); |
| 3887 | EXPECT_EQ("\"\\\\\\\\\"\n" |
| 3888 | "\"\\n\"", |
| 3889 | format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7))); |
| 3890 | EXPECT_EQ("\"\\uff01\"", |
| 3891 | format("\"\\uff01\"", getLLVMStyleWithColumns(7))); |
| 3892 | EXPECT_EQ("\"\\uff01\"\n" |
| 3893 | "\"test\"", |
| 3894 | format("\"\\uff01test\"", getLLVMStyleWithColumns(8))); |
| 3895 | EXPECT_EQ("\"\\Uff01ff02\"", |
| 3896 | format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11))); |
| 3897 | EXPECT_EQ("\"\\x000000000001\"\n" |
| 3898 | "\"next\"", |
| 3899 | format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16))); |
| 3900 | EXPECT_EQ("\"\\x000000000001next\"", |
| 3901 | format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15))); |
| 3902 | EXPECT_EQ("\"\\x000000000001\"", |
| 3903 | format("\"\\x000000000001\"", getLLVMStyleWithColumns(7))); |
| 3904 | EXPECT_EQ("\"test\"\n" |
| 3905 | "\"\\000000\"\n" |
| 3906 | "\"000001\"", |
| 3907 | format("\"test\\000000000001\"", getLLVMStyleWithColumns(9))); |
| 3908 | EXPECT_EQ("\"test\\000\"\n" |
Alexander Kornienko | 70ce788 | 2013-04-15 14:28:00 +0000 | [diff] [blame] | 3909 | "\"00000000\"\n" |
| 3910 | "\"1\"", |
Manuel Klimek | aa62d0c | 2013-03-08 18:59:48 +0000 | [diff] [blame] | 3911 | format("\"test\\000000000001\"", getLLVMStyleWithColumns(10))); |
| 3912 | EXPECT_EQ("R\"(\\x\\x00)\"\n", |
| 3913 | format("R\"(\\x\\x00)\"\n", getLLVMStyleWithColumns(7))); |
| 3914 | } |
| 3915 | |
Manuel Klimek | 423dd93 | 2013-04-10 09:52:05 +0000 | [diff] [blame] | 3916 | TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) { |
| 3917 | verifyFormat("void f() {\n" |
| 3918 | " return g() {}\n" |
| 3919 | " void h() {}"); |
| 3920 | verifyFormat("if (foo)\n" |
| 3921 | " return { forgot_closing_brace();\n" |
| 3922 | "test();"); |
| 3923 | verifyFormat("int a[] = { void forgot_closing_brace()\n" |
| 3924 | "{\n" |
| 3925 | " f();\n" |
| 3926 | " g();\n" |
| 3927 | "}"); |
| 3928 | } |
| 3929 | |
Alexander Kornienko | d71ec16 | 2013-05-07 15:32:14 +0000 | [diff] [blame] | 3930 | bool operator==(const FormatStyle &L, const FormatStyle &R) { |
| 3931 | return L.AccessModifierOffset == R.AccessModifierOffset && |
| 3932 | L.AlignEscapedNewlinesLeft == R.AlignEscapedNewlinesLeft && |
| 3933 | L.AllowAllParametersOfDeclarationOnNextLine == |
| 3934 | R.AllowAllParametersOfDeclarationOnNextLine && |
| 3935 | L.AllowShortIfStatementsOnASingleLine == |
| 3936 | R.AllowShortIfStatementsOnASingleLine && |
| 3937 | L.BinPackParameters == R.BinPackParameters && |
| 3938 | L.ColumnLimit == R.ColumnLimit && |
| 3939 | L.ConstructorInitializerAllOnOneLineOrOnePerLine == |
| 3940 | R.ConstructorInitializerAllOnOneLineOrOnePerLine && |
| 3941 | L.DerivePointerBinding == R.DerivePointerBinding && |
| 3942 | L.IndentCaseLabels == R.IndentCaseLabels && |
| 3943 | L.MaxEmptyLinesToKeep == R.MaxEmptyLinesToKeep && |
| 3944 | L.ObjCSpaceBeforeProtocolList == R.ObjCSpaceBeforeProtocolList && |
| 3945 | L.PenaltyExcessCharacter == R.PenaltyExcessCharacter && |
| 3946 | L.PenaltyReturnTypeOnItsOwnLine == R.PenaltyReturnTypeOnItsOwnLine && |
| 3947 | L.PointerBindsToType == R.PointerBindsToType && |
| 3948 | L.SpacesBeforeTrailingComments == R.SpacesBeforeTrailingComments && |
| 3949 | L.Standard == R.Standard; |
| 3950 | } |
| 3951 | |
| 3952 | bool allStylesEqual(ArrayRef<FormatStyle> Styles) { |
| 3953 | for (size_t i = 1; i < Styles.size(); ++i) |
| 3954 | if (!(Styles[0] == Styles[i])) |
| 3955 | return false; |
| 3956 | return true; |
| 3957 | } |
| 3958 | |
| 3959 | TEST_F(FormatTest, GetsPredefinedStyleByName) { |
| 3960 | FormatStyle LLVMStyles[] = { getLLVMStyle(), getPredefinedStyle("LLVM"), |
| 3961 | getPredefinedStyle("llvm"), |
| 3962 | getPredefinedStyle("lLvM") }; |
| 3963 | EXPECT_TRUE(allStylesEqual(LLVMStyles)); |
| 3964 | |
| 3965 | FormatStyle GoogleStyles[] = { getGoogleStyle(), getPredefinedStyle("Google"), |
| 3966 | getPredefinedStyle("google"), |
| 3967 | getPredefinedStyle("gOOgle") }; |
| 3968 | EXPECT_TRUE(allStylesEqual(GoogleStyles)); |
| 3969 | |
| 3970 | FormatStyle ChromiumStyles[] = { getChromiumStyle(), |
| 3971 | getPredefinedStyle("Chromium"), |
| 3972 | getPredefinedStyle("chromium"), |
| 3973 | getPredefinedStyle("chROmiUM") }; |
| 3974 | EXPECT_TRUE(allStylesEqual(ChromiumStyles)); |
| 3975 | |
| 3976 | FormatStyle MozillaStyles[] = { getMozillaStyle(), |
| 3977 | getPredefinedStyle("Mozilla"), |
| 3978 | getPredefinedStyle("mozilla"), |
| 3979 | getPredefinedStyle("moZilla") }; |
| 3980 | EXPECT_TRUE(allStylesEqual(MozillaStyles)); |
| 3981 | } |
| 3982 | |
| 3983 | TEST_F(FormatTest, ParsesConfiguration) { |
| 3984 | FormatStyle Style = {}; |
| 3985 | #define CHECK_PARSE(TEXT, FIELD, VALUE) \ |
| 3986 | EXPECT_NE(VALUE, Style.FIELD); \ |
| 3987 | EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \ |
| 3988 | EXPECT_EQ(VALUE, Style.FIELD) |
| 3989 | |
| 3990 | #define CHECK_PARSE_BOOL(FIELD) \ |
| 3991 | Style.FIELD = false; \ |
| 3992 | EXPECT_EQ(0, parseConfiguration(#FIELD ": true", &Style).value()); \ |
| 3993 | EXPECT_EQ(true, Style.FIELD); \ |
| 3994 | EXPECT_EQ(0, parseConfiguration(#FIELD ": false", &Style).value()); \ |
| 3995 | EXPECT_EQ(false, Style.FIELD); |
| 3996 | |
| 3997 | CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft); |
| 3998 | CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine); |
| 3999 | CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine); |
| 4000 | CHECK_PARSE_BOOL(BinPackParameters); |
| 4001 | CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine); |
| 4002 | CHECK_PARSE_BOOL(DerivePointerBinding); |
| 4003 | CHECK_PARSE_BOOL(IndentCaseLabels); |
| 4004 | CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList); |
| 4005 | CHECK_PARSE_BOOL(PointerBindsToType); |
| 4006 | |
| 4007 | CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234); |
| 4008 | CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u); |
| 4009 | CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u); |
| 4010 | CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u); |
| 4011 | CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234", |
| 4012 | PenaltyReturnTypeOnItsOwnLine, 1234u); |
| 4013 | CHECK_PARSE("SpacesBeforeTrailingComments: 1234", |
| 4014 | SpacesBeforeTrailingComments, 1234u); |
| 4015 | |
| 4016 | Style.Standard = FormatStyle::LS_Auto; |
| 4017 | CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03); |
| 4018 | CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11); |
| 4019 | CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto); |
| 4020 | |
| 4021 | Style.ColumnLimit = 123; |
| 4022 | FormatStyle BaseStyle = getLLVMStyle(); |
| 4023 | CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); |
| 4024 | CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); |
| 4025 | |
| 4026 | #undef CHECK_PARSE |
| 4027 | #undef CHECK_PARSE_BOOL |
| 4028 | } |
| 4029 | |
| 4030 | TEST_F(FormatTest, ConfigurationRoundTripTest) { |
| 4031 | FormatStyle Style = getLLVMStyle(); |
| 4032 | std::string YAML = configurationAsText(Style); |
| 4033 | FormatStyle ParsedStyle = {}; |
| 4034 | EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value()); |
| 4035 | EXPECT_EQ(Style, ParsedStyle); |
| 4036 | } |
| 4037 | |
Daniel Jasper | cd16238 | 2013-01-07 13:26:07 +0000 | [diff] [blame] | 4038 | } // end namespace tooling |
| 4039 | } // end namespace clang |