Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 1 | //===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 0bc735f | 2007-12-29 19:59:25 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 10 | // This file implements extra semantic analysis beyond what is enforced |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 11 | // by the C type system. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
| 15 | #include "Sema.h" |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 16 | #include "clang/Analysis/Analyses/PrintfFormatString.h" |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 17 | #include "clang/AST/ASTContext.h" |
Ken Dyck | 199c3d6 | 2010-01-11 17:06:35 +0000 | [diff] [blame] | 18 | #include "clang/AST/CharUnits.h" |
Daniel Dunbar | c4a1dea | 2008-08-11 05:35:13 +0000 | [diff] [blame] | 19 | #include "clang/AST/DeclObjC.h" |
Ted Kremenek | 2324512 | 2007-08-20 16:18:38 +0000 | [diff] [blame] | 20 | #include "clang/AST/ExprCXX.h" |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 21 | #include "clang/AST/ExprObjC.h" |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 22 | #include "clang/AST/DeclObjC.h" |
| 23 | #include "clang/AST/StmtCXX.h" |
| 24 | #include "clang/AST/StmtObjC.h" |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 25 | #include "clang/Lex/LiteralSupport.h" |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 26 | #include "clang/Lex/Preprocessor.h" |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 27 | #include "llvm/ADT/BitVector.h" |
| 28 | #include "llvm/ADT/STLExtras.h" |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 29 | #include "clang/Basic/TargetBuiltins.h" |
Zhongxing Xu | a1f3dba | 2009-05-20 01:55:10 +0000 | [diff] [blame] | 30 | #include <limits> |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 31 | using namespace clang; |
| 32 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 33 | /// getLocationOfStringLiteralByte - Return a source location that points to the |
| 34 | /// specified byte of the specified string literal. |
| 35 | /// |
| 36 | /// Strings are amazingly complex. They can be formed from multiple tokens and |
| 37 | /// can have escape sequences in them in addition to the usual trigraph and |
| 38 | /// escaped newline business. This routine handles this complexity. |
| 39 | /// |
| 40 | SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, |
| 41 | unsigned ByteNo) const { |
| 42 | assert(!SL->isWide() && "This doesn't work for wide strings yet"); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 43 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 44 | // Loop over all of the tokens in this string until we find the one that |
| 45 | // contains the byte we're looking for. |
| 46 | unsigned TokNo = 0; |
| 47 | while (1) { |
| 48 | assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!"); |
| 49 | SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 50 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 51 | // Get the spelling of the string so that we can get the data that makes up |
| 52 | // the string literal, not the identifier for the macro it is potentially |
| 53 | // expanded through. |
| 54 | SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc); |
| 55 | |
| 56 | // Re-lex the token to get its length and original spelling. |
| 57 | std::pair<FileID, unsigned> LocInfo = |
| 58 | SourceMgr.getDecomposedLoc(StrTokSpellingLoc); |
Douglas Gregor | f715ca1 | 2010-03-16 00:06:06 +0000 | [diff] [blame] | 59 | bool Invalid = false; |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 60 | llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid); |
Douglas Gregor | f715ca1 | 2010-03-16 00:06:06 +0000 | [diff] [blame] | 61 | if (Invalid) |
Douglas Gregor | aea67db | 2010-03-15 22:54:52 +0000 | [diff] [blame] | 62 | return StrTokSpellingLoc; |
| 63 | |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 64 | const char *StrData = Buffer.data()+LocInfo.second; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 65 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 66 | // Create a langops struct and enable trigraphs. This is sufficient for |
| 67 | // relexing tokens. |
| 68 | LangOptions LangOpts; |
| 69 | LangOpts.Trigraphs = true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 70 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 71 | // Create a lexer starting at the beginning of this token. |
Benjamin Kramer | f6ac97b | 2010-03-16 14:14:31 +0000 | [diff] [blame] | 72 | Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData, |
| 73 | Buffer.end()); |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 74 | Token TheTok; |
| 75 | TheLexer.LexFromRawLexer(TheTok); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 76 | |
Chris Lattner | 443e53c | 2009-02-18 19:26:42 +0000 | [diff] [blame] | 77 | // Use the StringLiteralParser to compute the length of the string in bytes. |
| 78 | StringLiteralParser SLP(&TheTok, 1, PP); |
| 79 | unsigned TokNumBytes = SLP.GetStringLength(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 80 | |
Chris Lattner | 2197c96 | 2009-02-18 18:52:52 +0000 | [diff] [blame] | 81 | // If the byte is in this token, return the location of the byte. |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 82 | if (ByteNo < TokNumBytes || |
| 83 | (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 84 | unsigned Offset = |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 85 | StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 86 | |
Chris Lattner | 719e615 | 2009-02-18 19:21:10 +0000 | [diff] [blame] | 87 | // Now that we know the offset of the token in the spelling, use the |
| 88 | // preprocessor to get the offset in the original source. |
| 89 | return PP.AdvanceToTokenCharacter(StrTokLoc, Offset); |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 90 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 91 | |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 92 | // Move to the next string token. |
| 93 | ++TokNo; |
| 94 | ByteNo -= TokNumBytes; |
| 95 | } |
| 96 | } |
| 97 | |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 98 | /// CheckablePrintfAttr - does a function call have a "printf" attribute |
| 99 | /// and arguments that merit checking? |
| 100 | bool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { |
| 101 | if (Format->getType() == "printf") return true; |
| 102 | if (Format->getType() == "printf0") { |
| 103 | // printf0 allows null "format" string; if so don't check format/args |
| 104 | unsigned format_idx = Format->getFormatIdx() - 1; |
Sebastian Redl | 4a2614e | 2009-11-17 18:02:24 +0000 | [diff] [blame] | 105 | // Does the index refer to the implicit object argument? |
| 106 | if (isa<CXXMemberCallExpr>(TheCall)) { |
| 107 | if (format_idx == 0) |
| 108 | return false; |
| 109 | --format_idx; |
| 110 | } |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 111 | if (format_idx < TheCall->getNumArgs()) { |
| 112 | Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 113 | if (!Format->isNullPointerConstant(Context, |
| 114 | Expr::NPC_ValueDependentIsNull)) |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 115 | return true; |
| 116 | } |
| 117 | } |
| 118 | return false; |
| 119 | } |
Chris Lattner | 6080008 | 2009-02-18 17:49:48 +0000 | [diff] [blame] | 120 | |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 121 | Action::OwningExprResult |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 122 | Sema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 123 | OwningExprResult TheCallResult(Owned(TheCall)); |
Douglas Gregor | 2def483 | 2008-11-17 20:34:05 +0000 | [diff] [blame] | 124 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 125 | switch (BuiltinID) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 126 | case Builtin::BI__builtin___CFStringMakeConstantString: |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 127 | assert(TheCall->getNumArgs() == 1 && |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 128 | "Wrong # arguments to builtin CFStringMakeConstantString"); |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 129 | if (CheckObjCString(TheCall->getArg(0))) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 130 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 131 | break; |
Ted Kremenek | 49ff7a1 | 2008-07-09 17:58:53 +0000 | [diff] [blame] | 132 | case Builtin::BI__builtin_stdarg_start: |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 133 | case Builtin::BI__builtin_va_start: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 134 | if (SemaBuiltinVAStart(TheCall)) |
| 135 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 136 | break; |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 137 | case Builtin::BI__builtin_isgreater: |
| 138 | case Builtin::BI__builtin_isgreaterequal: |
| 139 | case Builtin::BI__builtin_isless: |
| 140 | case Builtin::BI__builtin_islessequal: |
| 141 | case Builtin::BI__builtin_islessgreater: |
| 142 | case Builtin::BI__builtin_isunordered: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 143 | if (SemaBuiltinUnorderedCompare(TheCall)) |
| 144 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 145 | break; |
Benjamin Kramer | e771a7a | 2010-02-15 22:42:31 +0000 | [diff] [blame] | 146 | case Builtin::BI__builtin_fpclassify: |
| 147 | if (SemaBuiltinFPClassification(TheCall, 6)) |
| 148 | return ExprError(); |
| 149 | break; |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 150 | case Builtin::BI__builtin_isfinite: |
| 151 | case Builtin::BI__builtin_isinf: |
| 152 | case Builtin::BI__builtin_isinf_sign: |
| 153 | case Builtin::BI__builtin_isnan: |
| 154 | case Builtin::BI__builtin_isnormal: |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 155 | if (SemaBuiltinFPClassification(TheCall, 1)) |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 156 | return ExprError(); |
| 157 | break; |
Eli Friedman | 6cfda23 | 2008-05-20 08:23:37 +0000 | [diff] [blame] | 158 | case Builtin::BI__builtin_return_address: |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 159 | case Builtin::BI__builtin_frame_address: { |
| 160 | llvm::APSInt Result; |
| 161 | if (SemaBuiltinConstantArg(TheCall, 0, Result)) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 162 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 163 | break; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 164 | } |
| 165 | case Builtin::BI__builtin_eh_return_data_regno: { |
| 166 | llvm::APSInt Result; |
| 167 | if (SemaBuiltinConstantArg(TheCall, 0, Result)) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 168 | return ExprError(); |
| 169 | break; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 170 | } |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 171 | case Builtin::BI__builtin_shufflevector: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 172 | return SemaBuiltinShuffleVector(TheCall); |
| 173 | // TheCall will be freed by the smart pointer here, but that's fine, since |
| 174 | // SemaBuiltinShuffleVector guts it, but then doesn't release it. |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 175 | case Builtin::BI__builtin_prefetch: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 176 | if (SemaBuiltinPrefetch(TheCall)) |
| 177 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 178 | break; |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 179 | case Builtin::BI__builtin_object_size: |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 180 | if (SemaBuiltinObjectSize(TheCall)) |
| 181 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 182 | break; |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 183 | case Builtin::BI__builtin_longjmp: |
| 184 | if (SemaBuiltinLongjmp(TheCall)) |
| 185 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 186 | break; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 187 | case Builtin::BI__sync_fetch_and_add: |
| 188 | case Builtin::BI__sync_fetch_and_sub: |
| 189 | case Builtin::BI__sync_fetch_and_or: |
| 190 | case Builtin::BI__sync_fetch_and_and: |
| 191 | case Builtin::BI__sync_fetch_and_xor: |
| 192 | case Builtin::BI__sync_add_and_fetch: |
| 193 | case Builtin::BI__sync_sub_and_fetch: |
| 194 | case Builtin::BI__sync_and_and_fetch: |
| 195 | case Builtin::BI__sync_or_and_fetch: |
| 196 | case Builtin::BI__sync_xor_and_fetch: |
| 197 | case Builtin::BI__sync_val_compare_and_swap: |
| 198 | case Builtin::BI__sync_bool_compare_and_swap: |
| 199 | case Builtin::BI__sync_lock_test_and_set: |
| 200 | case Builtin::BI__sync_lock_release: |
| 201 | if (SemaBuiltinAtomicOverloaded(TheCall)) |
| 202 | return ExprError(); |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 203 | break; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 204 | |
| 205 | // Target specific builtins start here. |
| 206 | case X86::BI__builtin_ia32_palignr128: |
| 207 | case X86::BI__builtin_ia32_palignr: { |
| 208 | llvm::APSInt Result; |
| 209 | if (SemaBuiltinConstantArg(TheCall, 2, Result)) |
| 210 | return ExprError(); |
| 211 | break; |
| 212 | } |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 213 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 214 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 215 | return move(TheCallResult); |
| 216 | } |
Daniel Dunbar | de45428 | 2008-10-02 18:44:07 +0000 | [diff] [blame] | 217 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 218 | /// CheckFunctionCall - Check a direct function call for various correctness |
| 219 | /// and safety properties not strictly enforced by the C type system. |
| 220 | bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { |
| 221 | // Get the IdentifierInfo* for the called function. |
| 222 | IdentifierInfo *FnInfo = FDecl->getIdentifier(); |
| 223 | |
| 224 | // None of the checks below are needed for functions that don't have |
| 225 | // simple names (e.g., C++ conversion functions). |
| 226 | if (!FnInfo) |
| 227 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 228 | |
Daniel Dunbar | de45428 | 2008-10-02 18:44:07 +0000 | [diff] [blame] | 229 | // FIXME: This mechanism should be abstracted to be less fragile and |
| 230 | // more efficient. For example, just map function ids to custom |
| 231 | // handlers. |
| 232 | |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 233 | // Printf checking. |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 234 | if (const FormatAttr *Format = FDecl->getAttr<FormatAttr>()) { |
Ryan Flynn | 4403a5e | 2009-08-06 03:00:50 +0000 | [diff] [blame] | 235 | if (CheckablePrintfAttr(Format, TheCall)) { |
Ted Kremenek | 3d692df | 2009-02-27 17:58:43 +0000 | [diff] [blame] | 236 | bool HasVAListArg = Format->getFirstArg() == 0; |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 237 | CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, |
Ted Kremenek | 3d692df | 2009-02-27 17:58:43 +0000 | [diff] [blame] | 238 | HasVAListArg ? 0 : Format->getFirstArg() - 1); |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 239 | } |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 240 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 241 | |
| 242 | for (const NonNullAttr *NonNull = FDecl->getAttr<NonNullAttr>(); NonNull; |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 243 | NonNull = NonNull->getNext<NonNullAttr>()) |
| 244 | CheckNonNullArguments(NonNull, TheCall); |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 245 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 246 | return false; |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 247 | } |
| 248 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 249 | bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 250 | // Printf checking. |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 251 | const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 252 | if (!Format) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 253 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 254 | |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 255 | const VarDecl *V = dyn_cast<VarDecl>(NDecl); |
| 256 | if (!V) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 257 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 258 | |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 259 | QualType Ty = V->getType(); |
| 260 | if (!Ty->isBlockPointerType()) |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 261 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 262 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 263 | if (!CheckablePrintfAttr(Format, TheCall)) |
| 264 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 265 | |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 266 | bool HasVAListArg = Format->getFirstArg() == 0; |
Anders Carlsson | d406bf0 | 2009-08-16 01:56:34 +0000 | [diff] [blame] | 267 | CheckPrintfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, |
| 268 | HasVAListArg ? 0 : Format->getFirstArg() - 1); |
| 269 | |
| 270 | return false; |
Fariborz Jahanian | 725165f | 2009-05-18 21:05:18 +0000 | [diff] [blame] | 271 | } |
| 272 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 273 | /// SemaBuiltinAtomicOverloaded - We have a call to a function like |
| 274 | /// __sync_fetch_and_add, which is an overloaded function based on the pointer |
| 275 | /// type of its first argument. The main ActOnCallExpr routines have already |
| 276 | /// promoted the types of arguments because all of these calls are prototyped as |
| 277 | /// void(...). |
| 278 | /// |
| 279 | /// This function goes through and does final semantic checking for these |
| 280 | /// builtins, |
| 281 | bool Sema::SemaBuiltinAtomicOverloaded(CallExpr *TheCall) { |
| 282 | DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); |
| 283 | FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); |
| 284 | |
| 285 | // Ensure that we have at least one argument to do type inference from. |
| 286 | if (TheCall->getNumArgs() < 1) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 287 | return Diag(TheCall->getLocEnd(), |
| 288 | diag::err_typecheck_call_too_few_args_at_least) |
| 289 | << 0 << 1 << TheCall->getNumArgs() |
| 290 | << TheCall->getCallee()->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 291 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 292 | // Inspect the first argument of the atomic builtin. This should always be |
| 293 | // a pointer type, whose element is an integral scalar or pointer type. |
| 294 | // Because it is a pointer type, we don't have to worry about any implicit |
| 295 | // casts here. |
| 296 | Expr *FirstArg = TheCall->getArg(0); |
| 297 | if (!FirstArg->getType()->isPointerType()) |
| 298 | return Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) |
| 299 | << FirstArg->getType() << FirstArg->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 300 | |
Ted Kremenek | 6217b80 | 2009-07-29 21:53:49 +0000 | [diff] [blame] | 301 | QualType ValType = FirstArg->getType()->getAs<PointerType>()->getPointeeType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 302 | if (!ValType->isIntegerType() && !ValType->isPointerType() && |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 303 | !ValType->isBlockPointerType()) |
| 304 | return Diag(DRE->getLocStart(), |
| 305 | diag::err_atomic_builtin_must_be_pointer_intptr) |
| 306 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 307 | |
| 308 | // We need to figure out which concrete builtin this maps onto. For example, |
| 309 | // __sync_fetch_and_add with a 2 byte object turns into |
| 310 | // __sync_fetch_and_add_2. |
| 311 | #define BUILTIN_ROW(x) \ |
| 312 | { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ |
| 313 | Builtin::BI##x##_8, Builtin::BI##x##_16 } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 314 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 315 | static const unsigned BuiltinIndices[][5] = { |
| 316 | BUILTIN_ROW(__sync_fetch_and_add), |
| 317 | BUILTIN_ROW(__sync_fetch_and_sub), |
| 318 | BUILTIN_ROW(__sync_fetch_and_or), |
| 319 | BUILTIN_ROW(__sync_fetch_and_and), |
| 320 | BUILTIN_ROW(__sync_fetch_and_xor), |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 321 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 322 | BUILTIN_ROW(__sync_add_and_fetch), |
| 323 | BUILTIN_ROW(__sync_sub_and_fetch), |
| 324 | BUILTIN_ROW(__sync_and_and_fetch), |
| 325 | BUILTIN_ROW(__sync_or_and_fetch), |
| 326 | BUILTIN_ROW(__sync_xor_and_fetch), |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 327 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 328 | BUILTIN_ROW(__sync_val_compare_and_swap), |
| 329 | BUILTIN_ROW(__sync_bool_compare_and_swap), |
| 330 | BUILTIN_ROW(__sync_lock_test_and_set), |
| 331 | BUILTIN_ROW(__sync_lock_release) |
| 332 | }; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 333 | #undef BUILTIN_ROW |
| 334 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 335 | // Determine the index of the size. |
| 336 | unsigned SizeIndex; |
Ken Dyck | 199c3d6 | 2010-01-11 17:06:35 +0000 | [diff] [blame] | 337 | switch (Context.getTypeSizeInChars(ValType).getQuantity()) { |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 338 | case 1: SizeIndex = 0; break; |
| 339 | case 2: SizeIndex = 1; break; |
| 340 | case 4: SizeIndex = 2; break; |
| 341 | case 8: SizeIndex = 3; break; |
| 342 | case 16: SizeIndex = 4; break; |
| 343 | default: |
| 344 | return Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) |
| 345 | << FirstArg->getType() << FirstArg->getSourceRange(); |
| 346 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 347 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 348 | // Each of these builtins has one pointer argument, followed by some number of |
| 349 | // values (0, 1 or 2) followed by a potentially empty varags list of stuff |
| 350 | // that we ignore. Find out which row of BuiltinIndices to read from as well |
| 351 | // as the number of fixed args. |
Douglas Gregor | 7814e6d | 2009-09-12 00:22:50 +0000 | [diff] [blame] | 352 | unsigned BuiltinID = FDecl->getBuiltinID(); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 353 | unsigned BuiltinIndex, NumFixed = 1; |
| 354 | switch (BuiltinID) { |
| 355 | default: assert(0 && "Unknown overloaded atomic builtin!"); |
| 356 | case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; |
| 357 | case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; |
| 358 | case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; |
| 359 | case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; |
| 360 | case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 361 | |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 362 | case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; |
| 363 | case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; |
| 364 | case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; |
| 365 | case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; |
| 366 | case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 367 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 368 | case Builtin::BI__sync_val_compare_and_swap: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 369 | BuiltinIndex = 10; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 370 | NumFixed = 2; |
| 371 | break; |
| 372 | case Builtin::BI__sync_bool_compare_and_swap: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 373 | BuiltinIndex = 11; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 374 | NumFixed = 2; |
| 375 | break; |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 376 | case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 377 | case Builtin::BI__sync_lock_release: |
Daniel Dunbar | 7eff7c4 | 2010-03-25 17:13:09 +0000 | [diff] [blame] | 378 | BuiltinIndex = 13; |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 379 | NumFixed = 0; |
| 380 | break; |
| 381 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 382 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 383 | // Now that we know how many fixed arguments we expect, first check that we |
| 384 | // have at least that many. |
| 385 | if (TheCall->getNumArgs() < 1+NumFixed) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 386 | return Diag(TheCall->getLocEnd(), |
| 387 | diag::err_typecheck_call_too_few_args_at_least) |
| 388 | << 0 << 1+NumFixed << TheCall->getNumArgs() |
| 389 | << TheCall->getCallee()->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 390 | |
| 391 | |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 392 | // Get the decl for the concrete builtin from this, we can tell what the |
| 393 | // concrete integer type we should convert to is. |
| 394 | unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; |
| 395 | const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); |
| 396 | IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 397 | FunctionDecl *NewBuiltinDecl = |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 398 | cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, |
| 399 | TUScope, false, DRE->getLocStart())); |
| 400 | const FunctionProtoType *BuiltinFT = |
John McCall | 183700f | 2009-09-21 23:43:11 +0000 | [diff] [blame] | 401 | NewBuiltinDecl->getType()->getAs<FunctionProtoType>(); |
Ted Kremenek | 6217b80 | 2009-07-29 21:53:49 +0000 | [diff] [blame] | 402 | ValType = BuiltinFT->getArgType(0)->getAs<PointerType>()->getPointeeType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 403 | |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 404 | // If the first type needs to be converted (e.g. void** -> int*), do it now. |
| 405 | if (BuiltinFT->getArgType(0) != FirstArg->getType()) { |
Eli Friedman | 73c39ab | 2009-10-20 08:27:19 +0000 | [diff] [blame] | 406 | ImpCastExprToType(FirstArg, BuiltinFT->getArgType(0), CastExpr::CK_BitCast); |
Chris Lattner | e7ac0a9 | 2009-05-08 15:36:58 +0000 | [diff] [blame] | 407 | TheCall->setArg(0, FirstArg); |
| 408 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 409 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 410 | // Next, walk the valid ones promoting to the right type. |
| 411 | for (unsigned i = 0; i != NumFixed; ++i) { |
| 412 | Expr *Arg = TheCall->getArg(i+1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 413 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 414 | // If the argument is an implicit cast, then there was a promotion due to |
| 415 | // "...", just remove it now. |
| 416 | if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { |
| 417 | Arg = ICE->getSubExpr(); |
| 418 | ICE->setSubExpr(0); |
| 419 | ICE->Destroy(Context); |
| 420 | TheCall->setArg(i+1, Arg); |
| 421 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 422 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 423 | // GCC does an implicit conversion to the pointer or integer ValType. This |
| 424 | // can fail in some cases (1i -> int**), check for this error case now. |
Anders Carlsson | cdb6197 | 2009-08-07 22:21:05 +0000 | [diff] [blame] | 425 | CastExpr::CastKind Kind = CastExpr::CK_Unknown; |
Douglas Gregor | d6e44a3 | 2010-04-16 22:09:46 +0000 | [diff] [blame] | 426 | if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind)) |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 427 | return true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 428 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 429 | // Okay, we have something that *can* be converted to the right type. Check |
| 430 | // to see if there is a potentially weird extension going on here. This can |
| 431 | // happen when you do an atomic operation on something like an char* and |
| 432 | // pass in 42. The 42 gets converted to char. This is even more strange |
| 433 | // for things like 45.123 -> char, etc. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 434 | // FIXME: Do this check. |
Anders Carlsson | cdb6197 | 2009-08-07 22:21:05 +0000 | [diff] [blame] | 435 | ImpCastExprToType(Arg, ValType, Kind, /*isLvalue=*/false); |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 436 | TheCall->setArg(i+1, Arg); |
| 437 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 438 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 439 | // Switch the DeclRefExpr to refer to the new decl. |
| 440 | DRE->setDecl(NewBuiltinDecl); |
| 441 | DRE->setType(NewBuiltinDecl->getType()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 442 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 443 | // Set the callee in the CallExpr. |
| 444 | // FIXME: This leaks the original parens and implicit casts. |
| 445 | Expr *PromotedCall = DRE; |
| 446 | UsualUnaryConversions(PromotedCall); |
| 447 | TheCall->setCallee(PromotedCall); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 448 | |
Chris Lattner | 5caa370 | 2009-05-08 06:58:22 +0000 | [diff] [blame] | 449 | |
| 450 | // Change the result type of the call to match the result type of the decl. |
| 451 | TheCall->setType(NewBuiltinDecl->getResultType()); |
| 452 | return false; |
| 453 | } |
| 454 | |
| 455 | |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 456 | /// CheckObjCString - Checks that the argument to the builtin |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 457 | /// CFString constructor is correct |
Steve Naroff | fd94262 | 2009-04-13 20:26:29 +0000 | [diff] [blame] | 458 | /// FIXME: GCC currently emits the following warning: |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 459 | /// "warning: input conversion stopped due to an input byte that does not |
Steve Naroff | fd94262 | 2009-04-13 20:26:29 +0000 | [diff] [blame] | 460 | /// belong to the input codeset UTF-8" |
| 461 | /// Note: It might also make sense to do the UTF-16 conversion here (would |
| 462 | /// simplify the backend). |
Chris Lattner | 6903981 | 2009-02-18 06:01:06 +0000 | [diff] [blame] | 463 | bool Sema::CheckObjCString(Expr *Arg) { |
Chris Lattner | 56f3494 | 2008-02-13 01:02:39 +0000 | [diff] [blame] | 464 | Arg = Arg->IgnoreParenCasts(); |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 465 | StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); |
| 466 | |
| 467 | if (!Literal || Literal->isWide()) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 468 | Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) |
| 469 | << Arg->getSourceRange(); |
Anders Carlsson | 9cdc4d3 | 2007-08-17 15:44:17 +0000 | [diff] [blame] | 470 | return true; |
Anders Carlsson | 71993dd | 2007-08-17 05:31:46 +0000 | [diff] [blame] | 471 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 472 | |
Daniel Dunbar | f015b03 | 2009-09-22 10:03:52 +0000 | [diff] [blame] | 473 | const char *Data = Literal->getStrData(); |
| 474 | unsigned Length = Literal->getByteLength(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 475 | |
Daniel Dunbar | f015b03 | 2009-09-22 10:03:52 +0000 | [diff] [blame] | 476 | for (unsigned i = 0; i < Length; ++i) { |
| 477 | if (!Data[i]) { |
| 478 | Diag(getLocationOfStringLiteralByte(Literal, i), |
| 479 | diag::warn_cfstring_literal_contains_nul_character) |
| 480 | << Arg->getSourceRange(); |
| 481 | break; |
| 482 | } |
| 483 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 484 | |
Anders Carlsson | 9cdc4d3 | 2007-08-17 15:44:17 +0000 | [diff] [blame] | 485 | return false; |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 486 | } |
| 487 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 488 | /// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. |
| 489 | /// Emit an error and return true on failure, return false on success. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 490 | bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { |
| 491 | Expr *Fn = TheCall->getCallee(); |
| 492 | if (TheCall->getNumArgs() > 2) { |
Chris Lattner | 2c21a07 | 2008-11-21 18:44:24 +0000 | [diff] [blame] | 493 | Diag(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 494 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 495 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
| 496 | << Fn->getSourceRange() |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 497 | << SourceRange(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 498 | (*(TheCall->arg_end()-1))->getLocEnd()); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 499 | return true; |
| 500 | } |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 501 | |
| 502 | if (TheCall->getNumArgs() < 2) { |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 503 | return Diag(TheCall->getLocEnd(), |
| 504 | diag::err_typecheck_call_too_few_args_at_least) |
| 505 | << 0 /*function call*/ << 2 << TheCall->getNumArgs(); |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 506 | } |
| 507 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 508 | // Determine whether the current function is variadic or not. |
Douglas Gregor | 9ea9bdb | 2010-03-01 23:15:13 +0000 | [diff] [blame] | 509 | BlockScopeInfo *CurBlock = getCurBlock(); |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 510 | bool isVariadic; |
Steve Naroff | cd9c514 | 2009-04-15 19:33:47 +0000 | [diff] [blame] | 511 | if (CurBlock) |
| 512 | isVariadic = CurBlock->isVariadic; |
| 513 | else if (getCurFunctionDecl()) { |
Douglas Gregor | 72564e7 | 2009-02-26 23:50:07 +0000 | [diff] [blame] | 514 | if (FunctionProtoType* FTP = |
| 515 | dyn_cast<FunctionProtoType>(getCurFunctionDecl()->getType())) |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 516 | isVariadic = FTP->isVariadic(); |
| 517 | else |
| 518 | isVariadic = false; |
| 519 | } else { |
Argyrios Kyrtzidis | 53d0ea5 | 2008-06-28 06:07:14 +0000 | [diff] [blame] | 520 | isVariadic = getCurMethodDecl()->isVariadic(); |
Eli Friedman | 56f20ae | 2008-12-15 22:05:35 +0000 | [diff] [blame] | 521 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 522 | |
Chris Lattner | c27c665 | 2007-12-20 00:05:45 +0000 | [diff] [blame] | 523 | if (!isVariadic) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 524 | Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); |
| 525 | return true; |
| 526 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 527 | |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 528 | // Verify that the second argument to the builtin is the last argument of the |
| 529 | // current function or method. |
| 530 | bool SecondArgIsLastNamedArgument = false; |
Anders Carlsson | e2c1410 | 2008-02-13 01:22:59 +0000 | [diff] [blame] | 531 | const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 532 | |
Anders Carlsson | 88cf226 | 2008-02-11 04:20:54 +0000 | [diff] [blame] | 533 | if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { |
| 534 | if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 535 | // FIXME: This isn't correct for methods (results in bogus warning). |
| 536 | // Get the last formal in the current function. |
Anders Carlsson | 88cf226 | 2008-02-11 04:20:54 +0000 | [diff] [blame] | 537 | const ParmVarDecl *LastArg; |
Steve Naroff | cd9c514 | 2009-04-15 19:33:47 +0000 | [diff] [blame] | 538 | if (CurBlock) |
| 539 | LastArg = *(CurBlock->TheDecl->param_end()-1); |
| 540 | else if (FunctionDecl *FD = getCurFunctionDecl()) |
Chris Lattner | 371f258 | 2008-12-04 23:50:19 +0000 | [diff] [blame] | 541 | LastArg = *(FD->param_end()-1); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 542 | else |
Argyrios Kyrtzidis | 53d0ea5 | 2008-06-28 06:07:14 +0000 | [diff] [blame] | 543 | LastArg = *(getCurMethodDecl()->param_end()-1); |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 544 | SecondArgIsLastNamedArgument = PV == LastArg; |
| 545 | } |
| 546 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 547 | |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 548 | if (!SecondArgIsLastNamedArgument) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 549 | Diag(TheCall->getArg(1)->getLocStart(), |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 550 | diag::warn_second_parameter_of_va_start_not_last_named_argument); |
| 551 | return false; |
Eli Friedman | 6cfda23 | 2008-05-20 08:23:37 +0000 | [diff] [blame] | 552 | } |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 553 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 554 | /// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and |
| 555 | /// friends. This is declared to take (...), so we have to check everything. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 556 | bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { |
| 557 | if (TheCall->getNumArgs() < 2) |
Chris Lattner | 2c21a07 | 2008-11-21 18:44:24 +0000 | [diff] [blame] | 558 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 559 | << 0 << 2 << TheCall->getNumArgs()/*function call*/; |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 560 | if (TheCall->getNumArgs() > 2) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 561 | return Diag(TheCall->getArg(2)->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 562 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 563 | << 0 /*function call*/ << 2 << TheCall->getNumArgs() |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 564 | << SourceRange(TheCall->getArg(2)->getLocStart(), |
| 565 | (*(TheCall->arg_end()-1))->getLocEnd()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 566 | |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 567 | Expr *OrigArg0 = TheCall->getArg(0); |
| 568 | Expr *OrigArg1 = TheCall->getArg(1); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 569 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 570 | // Do standard promotions between the two arguments, returning their common |
| 571 | // type. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 572 | QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); |
Daniel Dunbar | 403bc2b | 2009-02-19 19:28:43 +0000 | [diff] [blame] | 573 | |
| 574 | // Make sure any conversions are pushed back into the call; this is |
| 575 | // type safe since unordered compare builtins are declared as "_Bool |
| 576 | // foo(...)". |
| 577 | TheCall->setArg(0, OrigArg0); |
| 578 | TheCall->setArg(1, OrigArg1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 579 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 580 | if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) |
| 581 | return false; |
| 582 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 583 | // If the common type isn't a real floating type, then the arguments were |
| 584 | // invalid for this operation. |
| 585 | if (!Res->isRealFloatingType()) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 586 | return Diag(OrigArg0->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 587 | diag::err_typecheck_call_invalid_ordered_compare) |
Chris Lattner | d162584 | 2008-11-24 06:25:27 +0000 | [diff] [blame] | 588 | << OrigArg0->getType() << OrigArg1->getType() |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 589 | << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 590 | |
Chris Lattner | 1b9a079 | 2007-12-20 00:26:33 +0000 | [diff] [blame] | 591 | return false; |
| 592 | } |
| 593 | |
Benjamin Kramer | e771a7a | 2010-02-15 22:42:31 +0000 | [diff] [blame] | 594 | /// SemaBuiltinSemaBuiltinFPClassification - Handle functions like |
| 595 | /// __builtin_isnan and friends. This is declared to take (...), so we have |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 596 | /// to check everything. We expect the last argument to be a floating point |
| 597 | /// value. |
| 598 | bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { |
| 599 | if (TheCall->getNumArgs() < NumArgs) |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 600 | return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 601 | << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 602 | if (TheCall->getNumArgs() > NumArgs) |
| 603 | return Diag(TheCall->getArg(NumArgs)->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 604 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 605 | << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 606 | << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 607 | (*(TheCall->arg_end()-1))->getLocEnd()); |
| 608 | |
Benjamin Kramer | 3b1e26b | 2010-02-16 10:07:31 +0000 | [diff] [blame] | 609 | Expr *OrigArg = TheCall->getArg(NumArgs-1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 610 | |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 611 | if (OrigArg->isTypeDependent()) |
| 612 | return false; |
| 613 | |
| 614 | // This operation requires a floating-point number |
| 615 | if (!OrigArg->getType()->isRealFloatingType()) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 616 | return Diag(OrigArg->getLocStart(), |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 617 | diag::err_typecheck_call_invalid_unary_fp) |
| 618 | << OrigArg->getType() << OrigArg->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 619 | |
Eli Friedman | 9ac6f62 | 2009-08-31 20:06:00 +0000 | [diff] [blame] | 620 | return false; |
| 621 | } |
| 622 | |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 623 | /// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. |
| 624 | // This is declared to take (...), so we have to check everything. |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 625 | Action::OwningExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 626 | if (TheCall->getNumArgs() < 3) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 627 | return ExprError(Diag(TheCall->getLocEnd(), |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 628 | diag::err_typecheck_call_too_few_args_at_least) |
| 629 | << 0 /*function call*/ << 3 << TheCall->getNumArgs() |
| 630 | << TheCall->getSourceRange()); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 631 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 632 | unsigned numElements = std::numeric_limits<unsigned>::max(); |
| 633 | if (!TheCall->getArg(0)->isTypeDependent() && |
| 634 | !TheCall->getArg(1)->isTypeDependent()) { |
| 635 | QualType FAType = TheCall->getArg(0)->getType(); |
| 636 | QualType SAType = TheCall->getArg(1)->getType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 637 | |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 638 | if (!FAType->isVectorType() || !SAType->isVectorType()) { |
| 639 | Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 640 | << SourceRange(TheCall->getArg(0)->getLocStart(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 641 | TheCall->getArg(1)->getLocEnd()); |
| 642 | return ExprError(); |
| 643 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 644 | |
Douglas Gregor | a4923eb | 2009-11-16 21:35:15 +0000 | [diff] [blame] | 645 | if (!Context.hasSameUnqualifiedType(FAType, SAType)) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 646 | Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 647 | << SourceRange(TheCall->getArg(0)->getLocStart(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 648 | TheCall->getArg(1)->getLocEnd()); |
| 649 | return ExprError(); |
| 650 | } |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 651 | |
John McCall | 183700f | 2009-09-21 23:43:11 +0000 | [diff] [blame] | 652 | numElements = FAType->getAs<VectorType>()->getNumElements(); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 653 | if (TheCall->getNumArgs() != numElements+2) { |
| 654 | if (TheCall->getNumArgs() < numElements+2) |
| 655 | return ExprError(Diag(TheCall->getLocEnd(), |
| 656 | diag::err_typecheck_call_too_few_args) |
Eric Christopher | d77b9a2 | 2010-04-16 04:48:22 +0000 | [diff] [blame] | 657 | << 0 /*function call*/ |
| 658 | << numElements+2 << TheCall->getNumArgs() |
| 659 | << TheCall->getSourceRange()); |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 660 | return ExprError(Diag(TheCall->getLocEnd(), |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 661 | diag::err_typecheck_call_too_many_args) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 662 | << 0 /*function call*/ |
| 663 | << numElements+2 << TheCall->getNumArgs() |
| 664 | << TheCall->getSourceRange()); |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 665 | } |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 666 | } |
| 667 | |
| 668 | for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 669 | if (TheCall->getArg(i)->isTypeDependent() || |
| 670 | TheCall->getArg(i)->isValueDependent()) |
| 671 | continue; |
| 672 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 673 | llvm::APSInt Result; |
| 674 | if (SemaBuiltinConstantArg(TheCall, i, Result)) |
| 675 | return ExprError(); |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 676 | |
Chris Lattner | d1a0b6d | 2008-08-10 02:05:13 +0000 | [diff] [blame] | 677 | if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 678 | return ExprError(Diag(TheCall->getLocStart(), |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 679 | diag::err_shufflevector_argument_too_large) |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 680 | << TheCall->getArg(i)->getSourceRange()); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 681 | } |
| 682 | |
| 683 | llvm::SmallVector<Expr*, 32> exprs; |
| 684 | |
Chris Lattner | d1a0b6d | 2008-08-10 02:05:13 +0000 | [diff] [blame] | 685 | for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 686 | exprs.push_back(TheCall->getArg(i)); |
| 687 | TheCall->setArg(i, 0); |
| 688 | } |
| 689 | |
Nate Begeman | a88dc30 | 2009-08-12 02:10:25 +0000 | [diff] [blame] | 690 | return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), |
| 691 | exprs.size(), exprs[0]->getType(), |
Ted Kremenek | 8189cde | 2009-02-07 01:47:29 +0000 | [diff] [blame] | 692 | TheCall->getCallee()->getLocStart(), |
| 693 | TheCall->getRParenLoc())); |
Eli Friedman | d38617c | 2008-05-14 19:38:39 +0000 | [diff] [blame] | 694 | } |
Chris Lattner | 30ce344 | 2007-12-19 23:59:04 +0000 | [diff] [blame] | 695 | |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 696 | /// SemaBuiltinPrefetch - Handle __builtin_prefetch. |
| 697 | // This is declared to take (const void*, ...) and can take two |
| 698 | // optional constant int args. |
| 699 | bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 700 | unsigned NumArgs = TheCall->getNumArgs(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 701 | |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 702 | if (NumArgs > 3) |
Eric Christopher | ccfa963 | 2010-04-16 04:56:46 +0000 | [diff] [blame] | 703 | return Diag(TheCall->getLocEnd(), |
| 704 | diag::err_typecheck_call_too_many_args_at_most) |
| 705 | << 0 /*function call*/ << 3 << NumArgs |
| 706 | << TheCall->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 707 | |
| 708 | // Argument 0 is checked for us and the remaining arguments must be |
| 709 | // constant integers. |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 710 | for (unsigned i = 1; i != NumArgs; ++i) { |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 711 | Expr *Arg = TheCall->getArg(i); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 712 | |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 713 | llvm::APSInt Result; |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 714 | if (SemaBuiltinConstantArg(TheCall, i, Result)) |
| 715 | return true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 716 | |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 717 | // FIXME: gcc issues a warning and rewrites these to 0. These |
| 718 | // seems especially odd for the third argument since the default |
| 719 | // is 3. |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 720 | if (i == 1) { |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 721 | if (Result.getLimitedValue() > 1) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 722 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 723 | << "0" << "1" << Arg->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 724 | } else { |
Eli Friedman | 9aef726 | 2009-12-04 00:30:06 +0000 | [diff] [blame] | 725 | if (Result.getLimitedValue() > 3) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 726 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 727 | << "0" << "3" << Arg->getSourceRange(); |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 728 | } |
| 729 | } |
| 730 | |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 731 | return false; |
Daniel Dunbar | 4493f79 | 2008-07-21 22:59:13 +0000 | [diff] [blame] | 732 | } |
| 733 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 734 | /// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr |
| 735 | /// TheCall is a constant expression. |
| 736 | bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, |
| 737 | llvm::APSInt &Result) { |
| 738 | Expr *Arg = TheCall->getArg(ArgNum); |
| 739 | DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); |
| 740 | FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); |
| 741 | |
| 742 | if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; |
| 743 | |
| 744 | if (!Arg->isIntegerConstantExpr(Result, Context)) |
| 745 | return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) |
| 746 | << ArgNum << FDecl->getDeclName() << Arg->getSourceRange(); |
| 747 | |
Chris Lattner | 21fb98e | 2009-09-23 06:06:36 +0000 | [diff] [blame] | 748 | return false; |
| 749 | } |
| 750 | |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 751 | /// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, |
| 752 | /// int type). This simply type checks that type is one of the defined |
| 753 | /// constants (0-3). |
Eric Christopher | fee667f | 2009-12-23 03:49:37 +0000 | [diff] [blame] | 754 | // For compatability check 0-3, llvm only handles 0 and 2. |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 755 | bool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 756 | llvm::APSInt Result; |
| 757 | |
| 758 | // Check constant-ness first. |
| 759 | if (SemaBuiltinConstantArg(TheCall, 1, Result)) |
| 760 | return true; |
| 761 | |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 762 | Expr *Arg = TheCall->getArg(1); |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 763 | if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 764 | return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) |
| 765 | << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); |
Daniel Dunbar | d5f8a4f | 2008-09-03 21:13:56 +0000 | [diff] [blame] | 766 | } |
| 767 | |
| 768 | return false; |
| 769 | } |
| 770 | |
Eli Friedman | 586d6a8 | 2009-05-03 06:04:26 +0000 | [diff] [blame] | 771 | /// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 772 | /// This checks that val is a constant 1. |
| 773 | bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { |
| 774 | Expr *Arg = TheCall->getArg(1); |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 775 | llvm::APSInt Result; |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 776 | |
Eric Christopher | 691ebc3 | 2010-04-17 02:26:23 +0000 | [diff] [blame^] | 777 | // TODO: This is less than ideal. Overload this to take a value. |
| 778 | if (SemaBuiltinConstantArg(TheCall, 1, Result)) |
| 779 | return true; |
| 780 | |
| 781 | if (Result != 1) |
Eli Friedman | d875fed | 2009-05-03 04:46:36 +0000 | [diff] [blame] | 782 | return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) |
| 783 | << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); |
| 784 | |
| 785 | return false; |
| 786 | } |
| 787 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 788 | // Handle i > 1 ? "x" : "y", recursivelly |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 789 | bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, |
| 790 | bool HasVAListArg, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 791 | unsigned format_idx, unsigned firstDataArg) { |
Douglas Gregor | cde0173 | 2009-05-19 22:10:17 +0000 | [diff] [blame] | 792 | if (E->isTypeDependent() || E->isValueDependent()) |
| 793 | return false; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 794 | |
| 795 | switch (E->getStmtClass()) { |
| 796 | case Stmt::ConditionalOperatorClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 797 | const ConditionalOperator *C = cast<ConditionalOperator>(E); |
Chris Lattner | 813b70d | 2009-12-22 06:00:13 +0000 | [diff] [blame] | 798 | return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 799 | HasVAListArg, format_idx, firstDataArg) |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 800 | && SemaCheckStringLiteral(C->getRHS(), TheCall, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 801 | HasVAListArg, format_idx, firstDataArg); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 802 | } |
| 803 | |
| 804 | case Stmt::ImplicitCastExprClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 805 | const ImplicitCastExpr *Expr = cast<ImplicitCastExpr>(E); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 806 | return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 807 | format_idx, firstDataArg); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 808 | } |
| 809 | |
| 810 | case Stmt::ParenExprClass: { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 811 | const ParenExpr *Expr = cast<ParenExpr>(E); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 812 | return SemaCheckStringLiteral(Expr->getSubExpr(), TheCall, HasVAListArg, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 813 | format_idx, firstDataArg); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 814 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 815 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 816 | case Stmt::DeclRefExprClass: { |
| 817 | const DeclRefExpr *DR = cast<DeclRefExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 818 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 819 | // As an exception, do not flag errors for variables binding to |
| 820 | // const string literals. |
| 821 | if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { |
| 822 | bool isConstant = false; |
| 823 | QualType T = DR->getType(); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 824 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 825 | if (const ArrayType *AT = Context.getAsArrayType(T)) { |
| 826 | isConstant = AT->getElementType().isConstant(Context); |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 827 | } else if (const PointerType *PT = T->getAs<PointerType>()) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 828 | isConstant = T.isConstant(Context) && |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 829 | PT->getPointeeType().isConstant(Context); |
| 830 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 831 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 832 | if (isConstant) { |
Sebastian Redl | 31310a2 | 2010-02-01 20:16:42 +0000 | [diff] [blame] | 833 | if (const Expr *Init = VD->getAnyInitializer()) |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 834 | return SemaCheckStringLiteral(Init, TheCall, |
| 835 | HasVAListArg, format_idx, firstDataArg); |
| 836 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 837 | |
Anders Carlsson | d966a55 | 2009-06-28 19:55:58 +0000 | [diff] [blame] | 838 | // For vprintf* functions (i.e., HasVAListArg==true), we add a |
| 839 | // special check to see if the format string is a function parameter |
| 840 | // of the function calling the printf function. If the function |
| 841 | // has an attribute indicating it is a printf-like function, then we |
| 842 | // should suppress warnings concerning non-literals being used in a call |
| 843 | // to a vprintf function. For example: |
| 844 | // |
| 845 | // void |
| 846 | // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ |
| 847 | // va_list ap; |
| 848 | // va_start(ap, fmt); |
| 849 | // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". |
| 850 | // ... |
| 851 | // |
| 852 | // |
| 853 | // FIXME: We don't have full attribute support yet, so just check to see |
| 854 | // if the argument is a DeclRefExpr that references a parameter. We'll |
| 855 | // add proper support for checking the attribute later. |
| 856 | if (HasVAListArg) |
| 857 | if (isa<ParmVarDecl>(VD)) |
| 858 | return true; |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 859 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 860 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 861 | return false; |
| 862 | } |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 863 | |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 864 | case Stmt::CallExprClass: { |
| 865 | const CallExpr *CE = cast<CallExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 866 | if (const ImplicitCastExpr *ICE |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 867 | = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { |
| 868 | if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { |
| 869 | if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { |
Argyrios Kyrtzidis | 40b598e | 2009-06-30 02:34:44 +0000 | [diff] [blame] | 870 | if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 871 | unsigned ArgIndex = FA->getFormatIdx(); |
| 872 | const Expr *Arg = CE->getArg(ArgIndex - 1); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 873 | |
| 874 | return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 875 | format_idx, firstDataArg); |
| 876 | } |
| 877 | } |
| 878 | } |
| 879 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 880 | |
Anders Carlsson | 8f031b3 | 2009-06-27 04:05:33 +0000 | [diff] [blame] | 881 | return false; |
| 882 | } |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 883 | case Stmt::ObjCStringLiteralClass: |
| 884 | case Stmt::StringLiteralClass: { |
| 885 | const StringLiteral *StrE = NULL; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 886 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 887 | if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 888 | StrE = ObjCFExpr->getString(); |
| 889 | else |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 890 | StrE = cast<StringLiteral>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 891 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 892 | if (StrE) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 893 | CheckPrintfString(StrE, E, TheCall, HasVAListArg, format_idx, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 894 | firstDataArg); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 895 | return true; |
| 896 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 897 | |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 898 | return false; |
| 899 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 900 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 901 | default: |
| 902 | return false; |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 903 | } |
| 904 | } |
| 905 | |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 906 | void |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 907 | Sema::CheckNonNullArguments(const NonNullAttr *NonNull, |
| 908 | const CallExpr *TheCall) { |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 909 | for (NonNullAttr::iterator i = NonNull->begin(), e = NonNull->end(); |
| 910 | i != e; ++i) { |
Chris Lattner | 12b97ff | 2009-05-25 18:23:36 +0000 | [diff] [blame] | 911 | const Expr *ArgExpr = TheCall->getArg(*i); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 912 | if (ArgExpr->isNullPointerConstant(Context, |
Douglas Gregor | ce94049 | 2009-09-25 04:25:58 +0000 | [diff] [blame] | 913 | Expr::NPC_ValueDependentIsNotNull)) |
Chris Lattner | 12b97ff | 2009-05-25 18:23:36 +0000 | [diff] [blame] | 914 | Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) |
| 915 | << ArgExpr->getSourceRange(); |
Fariborz Jahanian | e898f8a | 2009-05-21 18:48:51 +0000 | [diff] [blame] | 916 | } |
| 917 | } |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 918 | |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 919 | /// CheckPrintfArguments - Check calls to printf (and similar functions) for |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 920 | /// correct use of format strings. |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 921 | /// |
| 922 | /// HasVAListArg - A predicate indicating whether the printf-like |
| 923 | /// function is passed an explicit va_arg argument (e.g., vprintf) |
| 924 | /// |
| 925 | /// format_idx - The index into Args for the format string. |
| 926 | /// |
| 927 | /// Improper format strings to functions in the printf family can be |
| 928 | /// the source of bizarre bugs and very serious security holes. A |
| 929 | /// good source of information is available in the following paper |
| 930 | /// (which includes additional references): |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 931 | /// |
| 932 | /// FormatGuard: Automatic Protection From printf Format String |
| 933 | /// Vulnerabilities, Proceedings of the 10th USENIX Security Symposium, 2001. |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 934 | /// |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 935 | /// TODO: |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 936 | /// Functionality implemented: |
| 937 | /// |
| 938 | /// We can statically check the following properties for string |
| 939 | /// literal format strings for non v.*printf functions (where the |
| 940 | /// arguments are passed directly): |
| 941 | // |
| 942 | /// (1) Are the number of format conversions equal to the number of |
| 943 | /// data arguments? |
| 944 | /// |
| 945 | /// (2) Does each format conversion correctly match the type of the |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 946 | /// corresponding data argument? |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 947 | /// |
| 948 | /// Moreover, for all printf functions we can: |
| 949 | /// |
| 950 | /// (3) Check for a missing format string (when not caught by type checking). |
| 951 | /// |
| 952 | /// (4) Check for no-operation flags; e.g. using "#" with format |
| 953 | /// conversion 'c' (TODO) |
| 954 | /// |
| 955 | /// (5) Check the use of '%n', a major source of security holes. |
| 956 | /// |
| 957 | /// (6) Check for malformed format conversions that don't specify anything. |
| 958 | /// |
| 959 | /// (7) Check for empty format strings. e.g: printf(""); |
| 960 | /// |
| 961 | /// (8) Check that the format string is a wide literal. |
| 962 | /// |
| 963 | /// All of these checks can be done by parsing the format string. |
| 964 | /// |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 965 | void |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 966 | Sema::CheckPrintfArguments(const CallExpr *TheCall, bool HasVAListArg, |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 967 | unsigned format_idx, unsigned firstDataArg) { |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 968 | const Expr *Fn = TheCall->getCallee(); |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 969 | |
Sebastian Redl | 4a2614e | 2009-11-17 18:02:24 +0000 | [diff] [blame] | 970 | // The way the format attribute works in GCC, the implicit this argument |
| 971 | // of member functions is counted. However, it doesn't appear in our own |
| 972 | // lists, so decrement format_idx in that case. |
| 973 | if (isa<CXXMemberCallExpr>(TheCall)) { |
| 974 | // Catch a format attribute mistakenly referring to the object argument. |
| 975 | if (format_idx == 0) |
| 976 | return; |
| 977 | --format_idx; |
| 978 | if(firstDataArg != 0) |
| 979 | --firstDataArg; |
| 980 | } |
| 981 | |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 982 | // CHECK: printf-like function is called with no format string. |
Chris Lattner | 925e60d | 2007-12-28 05:29:59 +0000 | [diff] [blame] | 983 | if (format_idx >= TheCall->getNumArgs()) { |
Chris Lattner | dcd5ef1 | 2008-11-19 05:27:50 +0000 | [diff] [blame] | 984 | Diag(TheCall->getRParenLoc(), diag::warn_printf_missing_format_string) |
| 985 | << Fn->getSourceRange(); |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 986 | return; |
| 987 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 988 | |
Ted Kremenek | 082d936 | 2009-03-20 21:35:28 +0000 | [diff] [blame] | 989 | const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 990 | |
Chris Lattner | 59907c4 | 2007-08-10 20:18:51 +0000 | [diff] [blame] | 991 | // CHECK: format string is not a string literal. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 992 | // |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 993 | // Dynamically generated format strings are difficult to |
| 994 | // automatically vet at compile time. Requiring that format strings |
| 995 | // are string literals: (1) permits the checking of format strings by |
| 996 | // the compiler and thereby (2) can practically remove the source of |
| 997 | // many format string exploits. |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 998 | |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 999 | // Format string can be either ObjC string (e.g. @"%d") or |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1000 | // C string (e.g. "%d") |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1001 | // ObjC string uses the same format specifiers as C string, so we can use |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1002 | // the same format string checking logic for both ObjC and C strings. |
Chris Lattner | 1cd3e1f | 2009-04-29 04:49:34 +0000 | [diff] [blame] | 1003 | if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, |
| 1004 | firstDataArg)) |
| 1005 | return; // Literal format string found, check done! |
Ted Kremenek | 7ff22b2 | 2008-06-16 18:00:42 +0000 | [diff] [blame] | 1006 | |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1007 | // If there are no arguments specified, warn with -Wformat-security, otherwise |
| 1008 | // warn only with -Wformat-nonliteral. |
| 1009 | if (TheCall->getNumArgs() == format_idx+1) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1010 | Diag(TheCall->getArg(format_idx)->getLocStart(), |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1011 | diag::warn_printf_nonliteral_noargs) |
| 1012 | << OrigFormatExpr->getSourceRange(); |
| 1013 | else |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1014 | Diag(TheCall->getArg(format_idx)->getLocStart(), |
Chris Lattner | 655f141 | 2009-04-29 04:59:47 +0000 | [diff] [blame] | 1015 | diag::warn_printf_nonliteral) |
| 1016 | << OrigFormatExpr->getSourceRange(); |
Ted Kremenek | d30ef87 | 2009-01-12 23:09:09 +0000 | [diff] [blame] | 1017 | } |
Ted Kremenek | 71895b9 | 2007-08-14 17:39:48 +0000 | [diff] [blame] | 1018 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1019 | namespace { |
Ted Kremenek | 74d56a1 | 2010-02-04 20:46:58 +0000 | [diff] [blame] | 1020 | class CheckPrintfHandler : public analyze_printf::FormatStringHandler { |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1021 | Sema &S; |
| 1022 | const StringLiteral *FExpr; |
| 1023 | const Expr *OrigFormatExpr; |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1024 | const unsigned FirstDataArg; |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1025 | const unsigned NumDataArgs; |
| 1026 | const bool IsObjCLiteral; |
| 1027 | const char *Beg; // Start of format string. |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1028 | const bool HasVAListArg; |
| 1029 | const CallExpr *TheCall; |
| 1030 | unsigned FormatIdx; |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1031 | llvm::BitVector CoveredArgs; |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1032 | bool usesPositionalArgs; |
| 1033 | bool atFirstArg; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1034 | public: |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1035 | CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1036 | const Expr *origFormatExpr, unsigned firstDataArg, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1037 | unsigned numDataArgs, bool isObjCLiteral, |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1038 | const char *beg, bool hasVAListArg, |
| 1039 | const CallExpr *theCall, unsigned formatIdx) |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1040 | : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1041 | FirstDataArg(firstDataArg), |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1042 | NumDataArgs(numDataArgs), |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1043 | IsObjCLiteral(isObjCLiteral), Beg(beg), |
| 1044 | HasVAListArg(hasVAListArg), |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1045 | TheCall(theCall), FormatIdx(formatIdx), |
| 1046 | usesPositionalArgs(false), atFirstArg(true) { |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1047 | CoveredArgs.resize(numDataArgs); |
| 1048 | CoveredArgs.reset(); |
| 1049 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1050 | |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1051 | void DoneProcessing(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1052 | |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1053 | void HandleIncompleteFormatSpecifier(const char *startSpecifier, |
| 1054 | unsigned specifierLen); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1055 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1056 | bool |
Ted Kremenek | 74d56a1 | 2010-02-04 20:46:58 +0000 | [diff] [blame] | 1057 | HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS, |
| 1058 | const char *startSpecifier, |
| 1059 | unsigned specifierLen); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1060 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1061 | virtual void HandleInvalidPosition(const char *startSpecifier, |
| 1062 | unsigned specifierLen, |
| 1063 | analyze_printf::PositionContext p); |
| 1064 | |
| 1065 | virtual void HandleZeroPosition(const char *startPos, unsigned posLen); |
| 1066 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1067 | void HandleNullChar(const char *nullCharacter); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1068 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1069 | bool HandleFormatSpecifier(const analyze_printf::FormatSpecifier &FS, |
| 1070 | const char *startSpecifier, |
| 1071 | unsigned specifierLen); |
| 1072 | private: |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1073 | SourceRange getFormatStringRange(); |
| 1074 | SourceRange getFormatSpecifierRange(const char *startSpecifier, |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1075 | unsigned specifierLen); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1076 | SourceLocation getLocationOfByte(const char *x); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1077 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1078 | bool HandleAmount(const analyze_printf::OptionalAmount &Amt, unsigned k, |
| 1079 | const char *startSpecifier, unsigned specifierLen); |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1080 | void HandleFlags(const analyze_printf::FormatSpecifier &FS, |
| 1081 | llvm::StringRef flag, llvm::StringRef cspec, |
| 1082 | const char *startSpecifier, unsigned specifierLen); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1083 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1084 | const Expr *getDataArg(unsigned i) const; |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1085 | }; |
| 1086 | } |
| 1087 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1088 | SourceRange CheckPrintfHandler::getFormatStringRange() { |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1089 | return OrigFormatExpr->getSourceRange(); |
| 1090 | } |
| 1091 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1092 | SourceRange CheckPrintfHandler:: |
| 1093 | getFormatSpecifierRange(const char *startSpecifier, unsigned specifierLen) { |
| 1094 | return SourceRange(getLocationOfByte(startSpecifier), |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1095 | getLocationOfByte(startSpecifier+specifierLen-1)); |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1096 | } |
| 1097 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1098 | SourceLocation CheckPrintfHandler::getLocationOfByte(const char *x) { |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1099 | return S.getLocationOfStringLiteralByte(FExpr, x - Beg); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1100 | } |
| 1101 | |
Ted Kremenek | 26ac2e0 | 2010-01-29 02:40:24 +0000 | [diff] [blame] | 1102 | void CheckPrintfHandler:: |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1103 | HandleIncompleteFormatSpecifier(const char *startSpecifier, |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1104 | unsigned specifierLen) { |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1105 | SourceLocation Loc = getLocationOfByte(startSpecifier); |
| 1106 | S.Diag(Loc, diag::warn_printf_incomplete_specifier) |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1107 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1108 | } |
| 1109 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1110 | void |
| 1111 | CheckPrintfHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, |
| 1112 | analyze_printf::PositionContext p) { |
| 1113 | SourceLocation Loc = getLocationOfByte(startPos); |
| 1114 | S.Diag(Loc, diag::warn_printf_invalid_positional_specifier) |
| 1115 | << (unsigned) p << getFormatSpecifierRange(startPos, posLen); |
| 1116 | } |
| 1117 | |
| 1118 | void CheckPrintfHandler::HandleZeroPosition(const char *startPos, |
| 1119 | unsigned posLen) { |
| 1120 | SourceLocation Loc = getLocationOfByte(startPos); |
| 1121 | S.Diag(Loc, diag::warn_printf_zero_positional_specifier) |
| 1122 | << getFormatSpecifierRange(startPos, posLen); |
| 1123 | } |
| 1124 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1125 | bool CheckPrintfHandler:: |
Ted Kremenek | 26ac2e0 | 2010-01-29 02:40:24 +0000 | [diff] [blame] | 1126 | HandleInvalidConversionSpecifier(const analyze_printf::FormatSpecifier &FS, |
| 1127 | const char *startSpecifier, |
| 1128 | unsigned specifierLen) { |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1129 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1130 | unsigned argIndex = FS.getArgIndex(); |
| 1131 | bool keepGoing = true; |
| 1132 | if (argIndex < NumDataArgs) { |
| 1133 | // Consider the argument coverered, even though the specifier doesn't |
| 1134 | // make sense. |
| 1135 | CoveredArgs.set(argIndex); |
| 1136 | } |
| 1137 | else { |
| 1138 | // If argIndex exceeds the number of data arguments we |
| 1139 | // don't issue a warning because that is just a cascade of warnings (and |
| 1140 | // they may have intended '%%' anyway). We don't want to continue processing |
| 1141 | // the format string after this point, however, as we will like just get |
| 1142 | // gibberish when trying to match arguments. |
| 1143 | keepGoing = false; |
| 1144 | } |
| 1145 | |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1146 | const analyze_printf::ConversionSpecifier &CS = |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1147 | FS.getConversionSpecifier(); |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1148 | SourceLocation Loc = getLocationOfByte(CS.getStart()); |
Ted Kremenek | 26ac2e0 | 2010-01-29 02:40:24 +0000 | [diff] [blame] | 1149 | S.Diag(Loc, diag::warn_printf_invalid_conversion) |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1150 | << llvm::StringRef(CS.getStart(), CS.getLength()) |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1151 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1152 | |
| 1153 | return keepGoing; |
Ted Kremenek | 26ac2e0 | 2010-01-29 02:40:24 +0000 | [diff] [blame] | 1154 | } |
| 1155 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1156 | void CheckPrintfHandler::HandleNullChar(const char *nullCharacter) { |
| 1157 | // The presence of a null character is likely an error. |
| 1158 | S.Diag(getLocationOfByte(nullCharacter), |
| 1159 | diag::warn_printf_format_string_contains_null_char) |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1160 | << getFormatStringRange(); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1161 | } |
| 1162 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1163 | const Expr *CheckPrintfHandler::getDataArg(unsigned i) const { |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1164 | return TheCall->getArg(FirstDataArg + i); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1165 | } |
| 1166 | |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1167 | void CheckPrintfHandler::HandleFlags(const analyze_printf::FormatSpecifier &FS, |
| 1168 | llvm::StringRef flag, |
| 1169 | llvm::StringRef cspec, |
| 1170 | const char *startSpecifier, |
| 1171 | unsigned specifierLen) { |
| 1172 | const analyze_printf::ConversionSpecifier &CS = FS.getConversionSpecifier(); |
| 1173 | S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_nonsensical_flag) |
| 1174 | << flag << cspec << getFormatSpecifierRange(startSpecifier, specifierLen); |
| 1175 | } |
| 1176 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1177 | bool |
| 1178 | CheckPrintfHandler::HandleAmount(const analyze_printf::OptionalAmount &Amt, |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1179 | unsigned k, const char *startSpecifier, |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1180 | unsigned specifierLen) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1181 | |
| 1182 | if (Amt.hasDataArgument()) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1183 | if (!HasVAListArg) { |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1184 | unsigned argIndex = Amt.getArgIndex(); |
| 1185 | if (argIndex >= NumDataArgs) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1186 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1187 | diag::warn_printf_asterisk_missing_arg) |
| 1188 | << k << getFormatSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1189 | // Don't do any more checking. We will just emit |
| 1190 | // spurious errors. |
| 1191 | return false; |
| 1192 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1193 | |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1194 | // Type check the data argument. It should be an 'int'. |
Ted Kremenek | 31f8e32 | 2010-01-29 23:32:22 +0000 | [diff] [blame] | 1195 | // Although not in conformance with C99, we also allow the argument to be |
| 1196 | // an 'unsigned int' as that is a reasonably safe case. GCC also |
| 1197 | // doesn't emit a warning for that case. |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1198 | CoveredArgs.set(argIndex); |
| 1199 | const Expr *Arg = getDataArg(argIndex); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1200 | QualType T = Arg->getType(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1201 | |
| 1202 | const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); |
| 1203 | assert(ATR.isValid()); |
| 1204 | |
| 1205 | if (!ATR.matchesType(S.Context, T)) { |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1206 | S.Diag(getLocationOfByte(Amt.getStart()), |
| 1207 | diag::warn_printf_asterisk_wrong_type) |
| 1208 | << k |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1209 | << ATR.getRepresentativeType(S.Context) << T |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1210 | << getFormatSpecifierRange(startSpecifier, specifierLen) |
| 1211 | << Arg->getSourceRange(); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1212 | // Don't do any more checking. We will just emit |
| 1213 | // spurious errors. |
| 1214 | return false; |
| 1215 | } |
| 1216 | } |
| 1217 | } |
| 1218 | return true; |
| 1219 | } |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1220 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1221 | bool |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1222 | CheckPrintfHandler::HandleFormatSpecifier(const analyze_printf::FormatSpecifier |
| 1223 | &FS, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1224 | const char *startSpecifier, |
| 1225 | unsigned specifierLen) { |
| 1226 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1227 | using namespace analyze_printf; |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1228 | const ConversionSpecifier &CS = FS.getConversionSpecifier(); |
| 1229 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1230 | if (atFirstArg) { |
| 1231 | atFirstArg = false; |
| 1232 | usesPositionalArgs = FS.usesPositionalArg(); |
| 1233 | } |
| 1234 | else if (usesPositionalArgs != FS.usesPositionalArg()) { |
| 1235 | // Cannot mix-and-match positional and non-positional arguments. |
| 1236 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1237 | diag::warn_printf_mix_positional_nonpositional_args) |
| 1238 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1239 | return false; |
| 1240 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1241 | |
Ted Kremenek | efaff19 | 2010-02-27 01:41:03 +0000 | [diff] [blame] | 1242 | // First check if the field width, precision, and conversion specifier |
| 1243 | // have matching data arguments. |
| 1244 | if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, |
| 1245 | startSpecifier, specifierLen)) { |
| 1246 | return false; |
| 1247 | } |
| 1248 | |
| 1249 | if (!HandleAmount(FS.getPrecision(), /* precision */ 1, |
| 1250 | startSpecifier, specifierLen)) { |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1251 | return false; |
| 1252 | } |
| 1253 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1254 | if (!CS.consumesDataArgument()) { |
| 1255 | // FIXME: Technically specifying a precision or field width here |
| 1256 | // makes no sense. Worth issuing a warning at some point. |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1257 | return true; |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1258 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1259 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1260 | // Consume the argument. |
| 1261 | unsigned argIndex = FS.getArgIndex(); |
Ted Kremenek | e3fc547 | 2010-02-27 08:34:51 +0000 | [diff] [blame] | 1262 | if (argIndex < NumDataArgs) { |
| 1263 | // The check to see if the argIndex is valid will come later. |
| 1264 | // We set the bit here because we may exit early from this |
| 1265 | // function if we encounter some other error. |
| 1266 | CoveredArgs.set(argIndex); |
| 1267 | } |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1268 | |
| 1269 | // Check for using an Objective-C specific conversion specifier |
| 1270 | // in a non-ObjC literal. |
| 1271 | if (!IsObjCLiteral && CS.isObjCArg()) { |
| 1272 | return HandleInvalidConversionSpecifier(FS, startSpecifier, specifierLen); |
| 1273 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1274 | |
Ted Kremenek | e82d804 | 2010-01-29 01:35:25 +0000 | [diff] [blame] | 1275 | // Are we using '%n'? Issue a warning about this being |
| 1276 | // a possible security issue. |
| 1277 | if (CS.getKind() == ConversionSpecifier::OutIntPtrArg) { |
| 1278 | S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1279 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
Ted Kremenek | e82d804 | 2010-01-29 01:35:25 +0000 | [diff] [blame] | 1280 | // Continue checking the other format specifiers. |
| 1281 | return true; |
| 1282 | } |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1283 | |
| 1284 | if (CS.getKind() == ConversionSpecifier::VoidPtrArg) { |
| 1285 | if (FS.getPrecision().getHowSpecified() != OptionalAmount::NotSpecified) |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1286 | S.Diag(getLocationOfByte(CS.getStart()), |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1287 | diag::warn_printf_nonsensical_precision) |
| 1288 | << CS.getCharacters() |
| 1289 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
| 1290 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1291 | if (CS.getKind() == ConversionSpecifier::VoidPtrArg || |
| 1292 | CS.getKind() == ConversionSpecifier::CStrArg) { |
Ted Kremenek | 5c41ee8 | 2010-02-11 09:27:41 +0000 | [diff] [blame] | 1293 | // FIXME: Instead of using "0", "+", etc., eventually get them from |
| 1294 | // the FormatSpecifier. |
| 1295 | if (FS.hasLeadingZeros()) |
| 1296 | HandleFlags(FS, "0", CS.getCharacters(), startSpecifier, specifierLen); |
| 1297 | if (FS.hasPlusPrefix()) |
| 1298 | HandleFlags(FS, "+", CS.getCharacters(), startSpecifier, specifierLen); |
| 1299 | if (FS.hasSpacePrefix()) |
| 1300 | HandleFlags(FS, " ", CS.getCharacters(), startSpecifier, specifierLen); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1301 | } |
| 1302 | |
Ted Kremenek | da51f0d | 2010-01-29 01:43:31 +0000 | [diff] [blame] | 1303 | // The remaining checks depend on the data arguments. |
| 1304 | if (HasVAListArg) |
| 1305 | return true; |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1306 | |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1307 | if (argIndex >= NumDataArgs) { |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1308 | if (FS.usesPositionalArg()) { |
| 1309 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1310 | diag::warn_printf_positional_arg_exceeds_data_args) |
| 1311 | << (argIndex+1) << NumDataArgs |
| 1312 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
| 1313 | } |
| 1314 | else { |
| 1315 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1316 | diag::warn_printf_insufficient_data_args) |
| 1317 | << getFormatSpecifierRange(startSpecifier, specifierLen); |
| 1318 | } |
| 1319 | |
Ted Kremenek | da51f0d | 2010-01-29 01:43:31 +0000 | [diff] [blame] | 1320 | // Don't do any more checking. |
| 1321 | return false; |
| 1322 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1323 | |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1324 | // Now type check the data expression that matches the |
| 1325 | // format specifier. |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1326 | const Expr *Ex = getDataArg(argIndex); |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1327 | const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1328 | if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { |
| 1329 | // Check if we didn't match because of an implicit cast from a 'char' |
| 1330 | // or 'short' to an 'int'. This is done because printf is a varargs |
| 1331 | // function. |
| 1332 | if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) |
| 1333 | if (ICE->getType() == S.Context.IntTy) |
| 1334 | if (ATR.matchesType(S.Context, ICE->getSubExpr()->getType())) |
| 1335 | return true; |
Ted Kremenek | 105d41c | 2010-02-01 19:38:10 +0000 | [diff] [blame] | 1336 | |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1337 | S.Diag(getLocationOfByte(CS.getStart()), |
| 1338 | diag::warn_printf_conversion_argument_type_mismatch) |
| 1339 | << ATR.getRepresentativeType(S.Context) << Ex->getType() |
Ted Kremenek | 1497bff | 2010-02-11 19:37:25 +0000 | [diff] [blame] | 1340 | << getFormatSpecifierRange(startSpecifier, specifierLen) |
| 1341 | << Ex->getSourceRange(); |
Ted Kremenek | d635c5f | 2010-01-30 00:49:51 +0000 | [diff] [blame] | 1342 | } |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1343 | |
| 1344 | return true; |
| 1345 | } |
| 1346 | |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1347 | void CheckPrintfHandler::DoneProcessing() { |
| 1348 | // Does the number of data arguments exceed the number of |
| 1349 | // format conversions in the format string? |
Ted Kremenek | 7f70dc8 | 2010-02-26 19:18:41 +0000 | [diff] [blame] | 1350 | if (!HasVAListArg) { |
| 1351 | // Find any arguments that weren't covered. |
| 1352 | CoveredArgs.flip(); |
| 1353 | signed notCoveredArg = CoveredArgs.find_first(); |
| 1354 | if (notCoveredArg >= 0) { |
| 1355 | assert((unsigned)notCoveredArg < NumDataArgs); |
| 1356 | S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), |
| 1357 | diag::warn_printf_data_arg_not_used) |
| 1358 | << getFormatStringRange(); |
| 1359 | } |
| 1360 | } |
Ted Kremenek | 07d161f | 2010-01-29 01:50:07 +0000 | [diff] [blame] | 1361 | } |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1362 | |
Ted Kremenek | f88c8e0 | 2010-01-29 20:55:36 +0000 | [diff] [blame] | 1363 | void Sema::CheckPrintfString(const StringLiteral *FExpr, |
Ted Kremenek | 0e5675d | 2010-02-10 02:16:30 +0000 | [diff] [blame] | 1364 | const Expr *OrigFormatExpr, |
| 1365 | const CallExpr *TheCall, bool HasVAListArg, |
| 1366 | unsigned format_idx, unsigned firstDataArg) { |
| 1367 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1368 | // CHECK: is the format string a wide literal? |
| 1369 | if (FExpr->isWide()) { |
| 1370 | Diag(FExpr->getLocStart(), |
| 1371 | diag::warn_printf_format_string_is_wide_literal) |
| 1372 | << OrigFormatExpr->getSourceRange(); |
| 1373 | return; |
| 1374 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1375 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1376 | // Str - The format string. NOTE: this is NOT null-terminated! |
| 1377 | const char *Str = FExpr->getStrData(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1378 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1379 | // CHECK: empty format string? |
| 1380 | unsigned StrLen = FExpr->getByteLength(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1381 | |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1382 | if (StrLen == 0) { |
| 1383 | Diag(FExpr->getLocStart(), diag::warn_printf_empty_format_string) |
| 1384 | << OrigFormatExpr->getSourceRange(); |
| 1385 | return; |
| 1386 | } |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1387 | |
Ted Kremenek | 6ee7653 | 2010-03-25 03:59:12 +0000 | [diff] [blame] | 1388 | CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1389 | TheCall->getNumArgs() - firstDataArg, |
Ted Kremenek | 0d27735 | 2010-01-29 01:06:55 +0000 | [diff] [blame] | 1390 | isa<ObjCStringLiteral>(OrigFormatExpr), Str, |
| 1391 | HasVAListArg, TheCall, format_idx); |
Ted Kremenek | e0e5313 | 2010-01-28 23:39:18 +0000 | [diff] [blame] | 1392 | |
Ted Kremenek | 74d56a1 | 2010-02-04 20:46:58 +0000 | [diff] [blame] | 1393 | if (!analyze_printf::ParseFormatString(H, Str, Str + StrLen)) |
Ted Kremenek | 808015a | 2010-01-29 03:16:21 +0000 | [diff] [blame] | 1394 | H.DoneProcessing(); |
Ted Kremenek | ce7024e | 2010-01-28 01:18:22 +0000 | [diff] [blame] | 1395 | } |
| 1396 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1397 | //===--- CHECK: Return Address of Stack Variable --------------------------===// |
| 1398 | |
| 1399 | static DeclRefExpr* EvalVal(Expr *E); |
| 1400 | static DeclRefExpr* EvalAddr(Expr* E); |
| 1401 | |
| 1402 | /// CheckReturnStackAddr - Check if a return statement returns the address |
| 1403 | /// of a stack variable. |
| 1404 | void |
| 1405 | Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, |
| 1406 | SourceLocation ReturnLoc) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1407 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1408 | // Perform checking for returned stack addresses. |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1409 | if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1410 | if (DeclRefExpr *DR = EvalAddr(RetValExp)) |
Chris Lattner | 3c73c41 | 2008-11-19 08:23:25 +0000 | [diff] [blame] | 1411 | Diag(DR->getLocStart(), diag::warn_ret_stack_addr) |
Chris Lattner | 08631c5 | 2008-11-23 21:45:46 +0000 | [diff] [blame] | 1412 | << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1413 | |
Steve Naroff | c50a4a5 | 2008-09-16 22:25:10 +0000 | [diff] [blame] | 1414 | // Skip over implicit cast expressions when checking for block expressions. |
Chris Lattner | 4ca606e | 2009-09-08 00:36:37 +0000 | [diff] [blame] | 1415 | RetValExp = RetValExp->IgnoreParenCasts(); |
Steve Naroff | c50a4a5 | 2008-09-16 22:25:10 +0000 | [diff] [blame] | 1416 | |
Chris Lattner | 9e6b37a | 2009-10-30 04:01:58 +0000 | [diff] [blame] | 1417 | if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp)) |
Mike Stump | 397195b | 2009-04-17 00:09:41 +0000 | [diff] [blame] | 1418 | if (C->hasBlockDeclRefExprs()) |
| 1419 | Diag(C->getLocStart(), diag::err_ret_local_block) |
| 1420 | << C->getSourceRange(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1421 | |
Chris Lattner | 9e6b37a | 2009-10-30 04:01:58 +0000 | [diff] [blame] | 1422 | if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp)) |
| 1423 | Diag(ALE->getLocStart(), diag::warn_ret_addr_label) |
| 1424 | << ALE->getSourceRange(); |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1425 | |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 1426 | } else if (lhsType->isReferenceType()) { |
| 1427 | // Perform checking for stack values returned by reference. |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1428 | // Check for a reference to the stack |
| 1429 | if (DeclRefExpr *DR = EvalVal(RetValExp)) |
Chris Lattner | dcd5ef1 | 2008-11-19 05:27:50 +0000 | [diff] [blame] | 1430 | Diag(DR->getLocStart(), diag::warn_ret_stack_ref) |
Chris Lattner | 08631c5 | 2008-11-23 21:45:46 +0000 | [diff] [blame] | 1431 | << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1432 | } |
| 1433 | } |
| 1434 | |
| 1435 | /// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that |
| 1436 | /// check if the expression in a return statement evaluates to an address |
| 1437 | /// to a location on the stack. The recursion is used to traverse the |
| 1438 | /// AST of the return expression, with recursion backtracking when we |
| 1439 | /// encounter a subexpression that (1) clearly does not lead to the address |
| 1440 | /// of a stack variable or (2) is something we cannot determine leads to |
| 1441 | /// the address of a stack variable based on such local checking. |
| 1442 | /// |
Ted Kremenek | e8c600f | 2007-08-28 17:02:55 +0000 | [diff] [blame] | 1443 | /// EvalAddr processes expressions that are pointers that are used as |
| 1444 | /// references (and not L-values). EvalVal handles all other values. |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1445 | /// At the base case of the recursion is a check for a DeclRefExpr* in |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1446 | /// the refers to a stack variable. |
| 1447 | /// |
| 1448 | /// This implementation handles: |
| 1449 | /// |
| 1450 | /// * pointer-to-pointer casts |
| 1451 | /// * implicit conversions from array references to pointers |
| 1452 | /// * taking the address of fields |
| 1453 | /// * arbitrary interplay between "&" and "*" operators |
| 1454 | /// * pointer arithmetic from an address of a stack variable |
| 1455 | /// * taking the address of an array element where the array is on the stack |
| 1456 | static DeclRefExpr* EvalAddr(Expr *E) { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1457 | // We should only be called for evaluating pointer expressions. |
David Chisnall | 0f43656 | 2009-08-17 16:35:33 +0000 | [diff] [blame] | 1458 | assert((E->getType()->isAnyPointerType() || |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1459 | E->getType()->isBlockPointerType() || |
Ted Kremenek | a526c5c | 2008-01-07 19:49:32 +0000 | [diff] [blame] | 1460 | E->getType()->isObjCQualifiedIdType()) && |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1461 | "EvalAddr only works on pointers"); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1462 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1463 | // Our "symbolic interpreter" is just a dispatch off the currently |
| 1464 | // viewed AST node. We then recursively traverse the AST by calling |
| 1465 | // EvalAddr and EvalVal appropriately. |
| 1466 | switch (E->getStmtClass()) { |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1467 | case Stmt::ParenExprClass: |
| 1468 | // Ignore parentheses. |
| 1469 | return EvalAddr(cast<ParenExpr>(E)->getSubExpr()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1470 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1471 | case Stmt::UnaryOperatorClass: { |
| 1472 | // The only unary operator that make sense to handle here |
| 1473 | // is AddrOf. All others don't make sense as pointers. |
| 1474 | UnaryOperator *U = cast<UnaryOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1475 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1476 | if (U->getOpcode() == UnaryOperator::AddrOf) |
| 1477 | return EvalVal(U->getSubExpr()); |
| 1478 | else |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1479 | return NULL; |
| 1480 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1481 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1482 | case Stmt::BinaryOperatorClass: { |
| 1483 | // Handle pointer arithmetic. All other binary operators are not valid |
| 1484 | // in this context. |
| 1485 | BinaryOperator *B = cast<BinaryOperator>(E); |
| 1486 | BinaryOperator::Opcode op = B->getOpcode(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1487 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1488 | if (op != BinaryOperator::Add && op != BinaryOperator::Sub) |
| 1489 | return NULL; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1490 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1491 | Expr *Base = B->getLHS(); |
| 1492 | |
| 1493 | // Determine which argument is the real pointer base. It could be |
| 1494 | // the RHS argument instead of the LHS. |
| 1495 | if (!Base->getType()->isPointerType()) Base = B->getRHS(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1496 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1497 | assert (Base->getType()->isPointerType()); |
| 1498 | return EvalAddr(Base); |
| 1499 | } |
Steve Naroff | 61f40a2 | 2008-09-10 19:17:48 +0000 | [diff] [blame] | 1500 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1501 | // For conditional operators we need to see if either the LHS or RHS are |
| 1502 | // valid DeclRefExpr*s. If one of them is valid, we return it. |
| 1503 | case Stmt::ConditionalOperatorClass: { |
| 1504 | ConditionalOperator *C = cast<ConditionalOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1505 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1506 | // Handle the GNU extension for missing LHS. |
| 1507 | if (Expr *lhsExpr = C->getLHS()) |
| 1508 | if (DeclRefExpr* LHS = EvalAddr(lhsExpr)) |
| 1509 | return LHS; |
| 1510 | |
| 1511 | return EvalAddr(C->getRHS()); |
| 1512 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1513 | |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1514 | // For casts, we need to handle conversions from arrays to |
| 1515 | // pointer values, and pointer-to-pointer conversions. |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1516 | case Stmt::ImplicitCastExprClass: |
Douglas Gregor | 6eec8e8 | 2008-10-28 15:36:24 +0000 | [diff] [blame] | 1517 | case Stmt::CStyleCastExprClass: |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1518 | case Stmt::CXXFunctionalCastExprClass: { |
Argyrios Kyrtzidis | 0835a3c | 2008-08-18 23:01:59 +0000 | [diff] [blame] | 1519 | Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1520 | QualType T = SubExpr->getType(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1521 | |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1522 | if (SubExpr->getType()->isPointerType() || |
| 1523 | SubExpr->getType()->isBlockPointerType() || |
| 1524 | SubExpr->getType()->isObjCQualifiedIdType()) |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1525 | return EvalAddr(SubExpr); |
| 1526 | else if (T->isArrayType()) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1527 | return EvalVal(SubExpr); |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1528 | else |
Ted Kremenek | 54b5274 | 2008-08-07 00:49:01 +0000 | [diff] [blame] | 1529 | return 0; |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1530 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1531 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1532 | // C++ casts. For dynamic casts, static casts, and const casts, we |
| 1533 | // are always converting from a pointer-to-pointer, so we just blow |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1534 | // through the cast. In the case the dynamic cast doesn't fail (and |
| 1535 | // return NULL), we take the conservative route and report cases |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1536 | // where we return the address of a stack variable. For Reinterpre |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1537 | // FIXME: The comment about is wrong; we're not always converting |
| 1538 | // from pointer to pointer. I'm guessing that this code should also |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1539 | // handle references to objects. |
| 1540 | case Stmt::CXXStaticCastExprClass: |
| 1541 | case Stmt::CXXDynamicCastExprClass: |
Douglas Gregor | 49badde | 2008-10-27 19:41:14 +0000 | [diff] [blame] | 1542 | case Stmt::CXXConstCastExprClass: |
| 1543 | case Stmt::CXXReinterpretCastExprClass: { |
| 1544 | Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); |
Steve Naroff | dd972f2 | 2008-09-05 22:11:13 +0000 | [diff] [blame] | 1545 | if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1546 | return EvalAddr(S); |
| 1547 | else |
| 1548 | return NULL; |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1549 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1550 | |
Chris Lattner | fae3f1f | 2007-12-28 05:31:15 +0000 | [diff] [blame] | 1551 | // Everything else: we simply don't reason about them. |
| 1552 | default: |
| 1553 | return NULL; |
| 1554 | } |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1555 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1556 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1557 | |
| 1558 | /// EvalVal - This function is complements EvalAddr in the mutual recursion. |
| 1559 | /// See the comments for EvalAddr for more details. |
| 1560 | static DeclRefExpr* EvalVal(Expr *E) { |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1561 | |
Ted Kremenek | e8c600f | 2007-08-28 17:02:55 +0000 | [diff] [blame] | 1562 | // We should only be called for evaluating non-pointer expressions, or |
| 1563 | // expressions with a pointer type that are not used as references but instead |
| 1564 | // are l-values (e.g., DeclRefExpr with a pointer type). |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1565 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1566 | // Our "symbolic interpreter" is just a dispatch off the currently |
| 1567 | // viewed AST node. We then recursively traverse the AST by calling |
| 1568 | // EvalAddr and EvalVal appropriately. |
| 1569 | switch (E->getStmtClass()) { |
Douglas Gregor | a2813ce | 2009-10-23 18:54:35 +0000 | [diff] [blame] | 1570 | case Stmt::DeclRefExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1571 | // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking |
| 1572 | // at code that refers to a variable's name. We check if it has local |
| 1573 | // storage within the function, and if so, return the expression. |
| 1574 | DeclRefExpr *DR = cast<DeclRefExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1575 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1576 | if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1577 | if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR; |
| 1578 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1579 | return NULL; |
| 1580 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1581 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1582 | case Stmt::ParenExprClass: |
| 1583 | // Ignore parentheses. |
| 1584 | return EvalVal(cast<ParenExpr>(E)->getSubExpr()); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1585 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1586 | case Stmt::UnaryOperatorClass: { |
| 1587 | // The only unary operator that make sense to handle here |
| 1588 | // is Deref. All others don't resolve to a "name." This includes |
| 1589 | // handling all sorts of rvalues passed to a unary operator. |
| 1590 | UnaryOperator *U = cast<UnaryOperator>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1591 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1592 | if (U->getOpcode() == UnaryOperator::Deref) |
| 1593 | return EvalAddr(U->getSubExpr()); |
| 1594 | |
| 1595 | return NULL; |
| 1596 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1597 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1598 | case Stmt::ArraySubscriptExprClass: { |
| 1599 | // Array subscripts are potential references to data on the stack. We |
| 1600 | // retrieve the DeclRefExpr* for the array variable if it indeed |
| 1601 | // has local storage. |
Ted Kremenek | 2324512 | 2007-08-20 16:18:38 +0000 | [diff] [blame] | 1602 | return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1603 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1604 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1605 | case Stmt::ConditionalOperatorClass: { |
| 1606 | // For conditional operators we need to see if either the LHS or RHS are |
| 1607 | // non-NULL DeclRefExpr's. If one is non-NULL, we return it. |
| 1608 | ConditionalOperator *C = cast<ConditionalOperator>(E); |
| 1609 | |
Anders Carlsson | 3907323 | 2007-11-30 19:04:31 +0000 | [diff] [blame] | 1610 | // Handle the GNU extension for missing LHS. |
| 1611 | if (Expr *lhsExpr = C->getLHS()) |
| 1612 | if (DeclRefExpr *LHS = EvalVal(lhsExpr)) |
| 1613 | return LHS; |
| 1614 | |
| 1615 | return EvalVal(C->getRHS()); |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1616 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1617 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1618 | // Accesses to members are potential references to data on the stack. |
Douglas Gregor | 83f6faf | 2009-08-31 23:41:50 +0000 | [diff] [blame] | 1619 | case Stmt::MemberExprClass: { |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1620 | MemberExpr *M = cast<MemberExpr>(E); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1621 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1622 | // Check for indirect access. We only want direct field accesses. |
| 1623 | if (!M->isArrow()) |
| 1624 | return EvalVal(M->getBase()); |
| 1625 | else |
| 1626 | return NULL; |
| 1627 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1628 | |
Ted Kremenek | 06de276 | 2007-08-17 16:46:58 +0000 | [diff] [blame] | 1629 | // Everything else: we simply don't reason about them. |
| 1630 | default: |
| 1631 | return NULL; |
| 1632 | } |
| 1633 | } |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1634 | |
| 1635 | //===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// |
| 1636 | |
| 1637 | /// Check for comparisons of floating point operands using != and ==. |
| 1638 | /// Issue a warning if these are no self-comparisons, as they are not likely |
| 1639 | /// to do what the programmer intended. |
| 1640 | void Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { |
| 1641 | bool EmitWarning = true; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1642 | |
Ted Kremenek | 4e99a5f | 2008-01-17 16:57:34 +0000 | [diff] [blame] | 1643 | Expr* LeftExprSansParen = lex->IgnoreParens(); |
Ted Kremenek | 32e97b6 | 2008-01-17 17:55:13 +0000 | [diff] [blame] | 1644 | Expr* RightExprSansParen = rex->IgnoreParens(); |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1645 | |
| 1646 | // Special case: check for x == x (which is OK). |
| 1647 | // Do not emit warnings for such cases. |
| 1648 | if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) |
| 1649 | if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) |
| 1650 | if (DRL->getDecl() == DRR->getDecl()) |
| 1651 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1652 | |
| 1653 | |
Ted Kremenek | 1b500bb | 2007-11-29 00:59:04 +0000 | [diff] [blame] | 1654 | // Special case: check for comparisons against literals that can be exactly |
| 1655 | // represented by APFloat. In such cases, do not emit a warning. This |
| 1656 | // is a heuristic: often comparison against such literals are used to |
| 1657 | // detect if a value in a variable has not changed. This clearly can |
| 1658 | // lead to false negatives. |
| 1659 | if (EmitWarning) { |
| 1660 | if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { |
| 1661 | if (FLL->isExact()) |
| 1662 | EmitWarning = false; |
Mike Stump | ac5fc7c | 2009-08-04 21:02:39 +0000 | [diff] [blame] | 1663 | } else |
Ted Kremenek | 1b500bb | 2007-11-29 00:59:04 +0000 | [diff] [blame] | 1664 | if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ |
| 1665 | if (FLR->isExact()) |
| 1666 | EmitWarning = false; |
| 1667 | } |
| 1668 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1669 | |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1670 | // Check for comparisons with builtin types. |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 1671 | if (EmitWarning) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1672 | if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 1673 | if (CL->isBuiltinCall(Context)) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1674 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1675 | |
Sebastian Redl | 0eb2330 | 2009-01-19 00:08:26 +0000 | [diff] [blame] | 1676 | if (EmitWarning) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1677 | if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) |
Douglas Gregor | 3c385e5 | 2009-02-14 18:57:46 +0000 | [diff] [blame] | 1678 | if (CR->isBuiltinCall(Context)) |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1679 | EmitWarning = false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 1680 | |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1681 | // Emit the diagnostic. |
| 1682 | if (EmitWarning) |
Chris Lattner | fa25bbb | 2008-11-19 05:08:23 +0000 | [diff] [blame] | 1683 | Diag(loc, diag::warn_floatingpoint_eq) |
| 1684 | << lex->getSourceRange() << rex->getSourceRange(); |
Ted Kremenek | 588e5eb | 2007-11-25 00:58:00 +0000 | [diff] [blame] | 1685 | } |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 1686 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1687 | //===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// |
| 1688 | //===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 1689 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1690 | namespace { |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 1691 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1692 | /// Structure recording the 'active' range of an integer-valued |
| 1693 | /// expression. |
| 1694 | struct IntRange { |
| 1695 | /// The number of bits active in the int. |
| 1696 | unsigned Width; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 1697 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1698 | /// True if the int is known not to have negative values. |
| 1699 | bool NonNegative; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 1700 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1701 | IntRange() {} |
| 1702 | IntRange(unsigned Width, bool NonNegative) |
| 1703 | : Width(Width), NonNegative(NonNegative) |
| 1704 | {} |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 1705 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1706 | // Returns the range of the bool type. |
| 1707 | static IntRange forBoolType() { |
| 1708 | return IntRange(1, true); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1709 | } |
| 1710 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1711 | // Returns the range of an integral type. |
| 1712 | static IntRange forType(ASTContext &C, QualType T) { |
| 1713 | return forCanonicalType(C, T->getCanonicalTypeInternal().getTypePtr()); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1714 | } |
| 1715 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1716 | // Returns the range of an integeral type based on its canonical |
| 1717 | // representation. |
| 1718 | static IntRange forCanonicalType(ASTContext &C, const Type *T) { |
| 1719 | assert(T->isCanonicalUnqualified()); |
| 1720 | |
| 1721 | if (const VectorType *VT = dyn_cast<VectorType>(T)) |
| 1722 | T = VT->getElementType().getTypePtr(); |
| 1723 | if (const ComplexType *CT = dyn_cast<ComplexType>(T)) |
| 1724 | T = CT->getElementType().getTypePtr(); |
| 1725 | if (const EnumType *ET = dyn_cast<EnumType>(T)) |
| 1726 | T = ET->getDecl()->getIntegerType().getTypePtr(); |
| 1727 | |
| 1728 | const BuiltinType *BT = cast<BuiltinType>(T); |
| 1729 | assert(BT->isInteger()); |
| 1730 | |
| 1731 | return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); |
| 1732 | } |
| 1733 | |
| 1734 | // Returns the supremum of two ranges: i.e. their conservative merge. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 1735 | static IntRange join(IntRange L, IntRange R) { |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1736 | return IntRange(std::max(L.Width, R.Width), |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1737 | L.NonNegative && R.NonNegative); |
| 1738 | } |
| 1739 | |
| 1740 | // Returns the infinum of two ranges: i.e. their aggressive merge. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 1741 | static IntRange meet(IntRange L, IntRange R) { |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1742 | return IntRange(std::min(L.Width, R.Width), |
| 1743 | L.NonNegative || R.NonNegative); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1744 | } |
| 1745 | }; |
| 1746 | |
| 1747 | IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { |
| 1748 | if (value.isSigned() && value.isNegative()) |
| 1749 | return IntRange(value.getMinSignedBits(), false); |
| 1750 | |
| 1751 | if (value.getBitWidth() > MaxWidth) |
| 1752 | value.trunc(MaxWidth); |
| 1753 | |
| 1754 | // isNonNegative() just checks the sign bit without considering |
| 1755 | // signedness. |
| 1756 | return IntRange(value.getActiveBits(), true); |
| 1757 | } |
| 1758 | |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 1759 | IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1760 | unsigned MaxWidth) { |
| 1761 | if (result.isInt()) |
| 1762 | return GetValueRange(C, result.getInt(), MaxWidth); |
| 1763 | |
| 1764 | if (result.isVector()) { |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 1765 | IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); |
| 1766 | for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { |
| 1767 | IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); |
| 1768 | R = IntRange::join(R, El); |
| 1769 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1770 | return R; |
| 1771 | } |
| 1772 | |
| 1773 | if (result.isComplexInt()) { |
| 1774 | IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); |
| 1775 | IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); |
| 1776 | return IntRange::join(R, I); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1777 | } |
| 1778 | |
| 1779 | // This can happen with lossless casts to intptr_t of "based" lvalues. |
| 1780 | // Assume it might use arbitrary bits. |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 1781 | // FIXME: The only reason we need to pass the type in here is to get |
| 1782 | // the sign right on this one case. It would be nice if APValue |
| 1783 | // preserved this. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1784 | assert(result.isLValue()); |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 1785 | return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1786 | } |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1787 | |
| 1788 | /// Pseudo-evaluate the given integer expression, estimating the |
| 1789 | /// range of values it might take. |
| 1790 | /// |
| 1791 | /// \param MaxWidth - the width to which the value will be truncated |
| 1792 | IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { |
| 1793 | E = E->IgnoreParens(); |
| 1794 | |
| 1795 | // Try a full evaluation first. |
| 1796 | Expr::EvalResult result; |
| 1797 | if (E->Evaluate(result, C)) |
John McCall | 0acc311 | 2010-01-06 22:57:21 +0000 | [diff] [blame] | 1798 | return GetValueRange(C, result.Val, E->getType(), MaxWidth); |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1799 | |
| 1800 | // I think we only want to look through implicit casts here; if the |
| 1801 | // user has an explicit widening cast, we should treat the value as |
| 1802 | // being of the new, wider type. |
| 1803 | if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { |
| 1804 | if (CE->getCastKind() == CastExpr::CK_NoOp) |
| 1805 | return GetExprRange(C, CE->getSubExpr(), MaxWidth); |
| 1806 | |
| 1807 | IntRange OutputTypeRange = IntRange::forType(C, CE->getType()); |
| 1808 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1809 | bool isIntegerCast = (CE->getCastKind() == CastExpr::CK_IntegralCast); |
| 1810 | if (!isIntegerCast && CE->getCastKind() == CastExpr::CK_Unknown) |
| 1811 | isIntegerCast = CE->getSubExpr()->getType()->isIntegerType(); |
| 1812 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1813 | // Assume that non-integer casts can span the full range of the type. |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1814 | if (!isIntegerCast) |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1815 | return OutputTypeRange; |
| 1816 | |
| 1817 | IntRange SubRange |
| 1818 | = GetExprRange(C, CE->getSubExpr(), |
| 1819 | std::min(MaxWidth, OutputTypeRange.Width)); |
| 1820 | |
| 1821 | // Bail out if the subexpr's range is as wide as the cast type. |
| 1822 | if (SubRange.Width >= OutputTypeRange.Width) |
| 1823 | return OutputTypeRange; |
| 1824 | |
| 1825 | // Otherwise, we take the smaller width, and we're non-negative if |
| 1826 | // either the output type or the subexpr is. |
| 1827 | return IntRange(SubRange.Width, |
| 1828 | SubRange.NonNegative || OutputTypeRange.NonNegative); |
| 1829 | } |
| 1830 | |
| 1831 | if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { |
| 1832 | // If we can fold the condition, just take that operand. |
| 1833 | bool CondResult; |
| 1834 | if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) |
| 1835 | return GetExprRange(C, CondResult ? CO->getTrueExpr() |
| 1836 | : CO->getFalseExpr(), |
| 1837 | MaxWidth); |
| 1838 | |
| 1839 | // Otherwise, conservatively merge. |
| 1840 | IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); |
| 1841 | IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); |
| 1842 | return IntRange::join(L, R); |
| 1843 | } |
| 1844 | |
| 1845 | if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { |
| 1846 | switch (BO->getOpcode()) { |
| 1847 | |
| 1848 | // Boolean-valued operations are single-bit and positive. |
| 1849 | case BinaryOperator::LAnd: |
| 1850 | case BinaryOperator::LOr: |
| 1851 | case BinaryOperator::LT: |
| 1852 | case BinaryOperator::GT: |
| 1853 | case BinaryOperator::LE: |
| 1854 | case BinaryOperator::GE: |
| 1855 | case BinaryOperator::EQ: |
| 1856 | case BinaryOperator::NE: |
| 1857 | return IntRange::forBoolType(); |
| 1858 | |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 1859 | // The type of these compound assignments is the type of the LHS, |
| 1860 | // so the RHS is not necessarily an integer. |
| 1861 | case BinaryOperator::MulAssign: |
| 1862 | case BinaryOperator::DivAssign: |
| 1863 | case BinaryOperator::RemAssign: |
| 1864 | case BinaryOperator::AddAssign: |
| 1865 | case BinaryOperator::SubAssign: |
| 1866 | return IntRange::forType(C, E->getType()); |
| 1867 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1868 | // Operations with opaque sources are black-listed. |
| 1869 | case BinaryOperator::PtrMemD: |
| 1870 | case BinaryOperator::PtrMemI: |
| 1871 | return IntRange::forType(C, E->getType()); |
| 1872 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1873 | // Bitwise-and uses the *infinum* of the two source ranges. |
| 1874 | case BinaryOperator::And: |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 1875 | case BinaryOperator::AndAssign: |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1876 | return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), |
| 1877 | GetExprRange(C, BO->getRHS(), MaxWidth)); |
| 1878 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1879 | // Left shift gets black-listed based on a judgement call. |
| 1880 | case BinaryOperator::Shl: |
John McCall | 3aae609 | 2010-04-07 01:14:35 +0000 | [diff] [blame] | 1881 | // ...except that we want to treat '1 << (blah)' as logically |
| 1882 | // positive. It's an important idiom. |
| 1883 | if (IntegerLiteral *I |
| 1884 | = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { |
| 1885 | if (I->getValue() == 1) { |
| 1886 | IntRange R = IntRange::forType(C, E->getType()); |
| 1887 | return IntRange(R.Width, /*NonNegative*/ true); |
| 1888 | } |
| 1889 | } |
| 1890 | // fallthrough |
| 1891 | |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 1892 | case BinaryOperator::ShlAssign: |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1893 | return IntRange::forType(C, E->getType()); |
| 1894 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1895 | // Right shift by a constant can narrow its left argument. |
John McCall | c0cd21d | 2010-02-23 19:22:29 +0000 | [diff] [blame] | 1896 | case BinaryOperator::Shr: |
| 1897 | case BinaryOperator::ShrAssign: { |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1898 | IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); |
| 1899 | |
| 1900 | // If the shift amount is a positive constant, drop the width by |
| 1901 | // that much. |
| 1902 | llvm::APSInt shift; |
| 1903 | if (BO->getRHS()->isIntegerConstantExpr(shift, C) && |
| 1904 | shift.isNonNegative()) { |
| 1905 | unsigned zext = shift.getZExtValue(); |
| 1906 | if (zext >= L.Width) |
| 1907 | L.Width = (L.NonNegative ? 0 : 1); |
| 1908 | else |
| 1909 | L.Width -= zext; |
| 1910 | } |
| 1911 | |
| 1912 | return L; |
| 1913 | } |
| 1914 | |
| 1915 | // Comma acts as its right operand. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1916 | case BinaryOperator::Comma: |
| 1917 | return GetExprRange(C, BO->getRHS(), MaxWidth); |
| 1918 | |
John McCall | 60fad45 | 2010-01-06 22:07:33 +0000 | [diff] [blame] | 1919 | // Black-list pointer subtractions. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1920 | case BinaryOperator::Sub: |
| 1921 | if (BO->getLHS()->getType()->isPointerType()) |
| 1922 | return IntRange::forType(C, E->getType()); |
| 1923 | // fallthrough |
Ted Kremenek | 4e4b30e | 2010-02-16 01:46:59 +0000 | [diff] [blame] | 1924 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1925 | default: |
| 1926 | break; |
| 1927 | } |
| 1928 | |
| 1929 | // Treat every other operator as if it were closed on the |
| 1930 | // narrowest type that encompasses both operands. |
| 1931 | IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); |
| 1932 | IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); |
| 1933 | return IntRange::join(L, R); |
| 1934 | } |
| 1935 | |
| 1936 | if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { |
| 1937 | switch (UO->getOpcode()) { |
| 1938 | // Boolean-valued operations are white-listed. |
| 1939 | case UnaryOperator::LNot: |
| 1940 | return IntRange::forBoolType(); |
| 1941 | |
| 1942 | // Operations with opaque sources are black-listed. |
| 1943 | case UnaryOperator::Deref: |
| 1944 | case UnaryOperator::AddrOf: // should be impossible |
| 1945 | case UnaryOperator::OffsetOf: |
| 1946 | return IntRange::forType(C, E->getType()); |
| 1947 | |
| 1948 | default: |
| 1949 | return GetExprRange(C, UO->getSubExpr(), MaxWidth); |
| 1950 | } |
| 1951 | } |
| 1952 | |
| 1953 | FieldDecl *BitField = E->getBitField(); |
| 1954 | if (BitField) { |
| 1955 | llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); |
| 1956 | unsigned BitWidth = BitWidthAP.getZExtValue(); |
| 1957 | |
| 1958 | return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); |
| 1959 | } |
| 1960 | |
| 1961 | return IntRange::forType(C, E->getType()); |
| 1962 | } |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1963 | |
| 1964 | /// Checks whether the given value, which currently has the given |
| 1965 | /// source semantics, has the same value when coerced through the |
| 1966 | /// target semantics. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1967 | bool IsSameFloatAfterCast(const llvm::APFloat &value, |
| 1968 | const llvm::fltSemantics &Src, |
| 1969 | const llvm::fltSemantics &Tgt) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1970 | llvm::APFloat truncated = value; |
| 1971 | |
| 1972 | bool ignored; |
| 1973 | truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); |
| 1974 | truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); |
| 1975 | |
| 1976 | return truncated.bitwiseIsEqual(value); |
| 1977 | } |
| 1978 | |
| 1979 | /// Checks whether the given value, which currently has the given |
| 1980 | /// source semantics, has the same value when coerced through the |
| 1981 | /// target semantics. |
| 1982 | /// |
| 1983 | /// The value might be a vector of floats (or a complex number). |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 1984 | bool IsSameFloatAfterCast(const APValue &value, |
| 1985 | const llvm::fltSemantics &Src, |
| 1986 | const llvm::fltSemantics &Tgt) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 1987 | if (value.isFloat()) |
| 1988 | return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); |
| 1989 | |
| 1990 | if (value.isVector()) { |
| 1991 | for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) |
| 1992 | if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) |
| 1993 | return false; |
| 1994 | return true; |
| 1995 | } |
| 1996 | |
| 1997 | assert(value.isComplexFloat()); |
| 1998 | return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && |
| 1999 | IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); |
| 2000 | } |
| 2001 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2002 | } // end anonymous namespace |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2003 | |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2004 | /// \brief Implements -Wsign-compare. |
| 2005 | /// |
| 2006 | /// \param lex the left-hand expression |
| 2007 | /// \param rex the right-hand expression |
| 2008 | /// \param OpLoc the location of the joining operator |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2009 | /// \param BinOpc binary opcode or 0 |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2010 | void Sema::CheckSignCompare(Expr *lex, Expr *rex, SourceLocation OpLoc, |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2011 | const BinaryOperator::Opcode* BinOpc) { |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2012 | // Don't warn if we're in an unevaluated context. |
| 2013 | if (ExprEvalContexts.back().Context == Unevaluated) |
| 2014 | return; |
| 2015 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2016 | // If either expression is value-dependent, don't warn. We'll get another |
| 2017 | // chance at instantiation time. |
| 2018 | if (lex->isValueDependent() || rex->isValueDependent()) |
| 2019 | return; |
| 2020 | |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2021 | QualType lt = lex->getType(), rt = rex->getType(); |
| 2022 | |
| 2023 | // Only warn if both operands are integral. |
| 2024 | if (!lt->isIntegerType() || !rt->isIntegerType()) |
| 2025 | return; |
| 2026 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2027 | // In C, the width of a bitfield determines its type, and the |
| 2028 | // declared type only contributes the signedness. This duplicates |
| 2029 | // the work that will later be done by UsualUnaryConversions. |
| 2030 | // Eventually, this check will be reorganized in a way that avoids |
| 2031 | // this duplication. |
| 2032 | if (!getLangOptions().CPlusPlus) { |
| 2033 | QualType tmp; |
| 2034 | tmp = Context.isPromotableBitField(lex); |
| 2035 | if (!tmp.isNull()) lt = tmp; |
| 2036 | tmp = Context.isPromotableBitField(rex); |
| 2037 | if (!tmp.isNull()) rt = tmp; |
| 2038 | } |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2039 | |
John McCall | a2936be | 2010-03-19 18:53:26 +0000 | [diff] [blame] | 2040 | if (const EnumType *E = lt->getAs<EnumType>()) |
| 2041 | lt = E->getDecl()->getPromotionType(); |
| 2042 | if (const EnumType *E = rt->getAs<EnumType>()) |
| 2043 | rt = E->getDecl()->getPromotionType(); |
| 2044 | |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2045 | // The rule is that the signed operand becomes unsigned, so isolate the |
| 2046 | // signed operand. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2047 | Expr *signedOperand = lex, *unsignedOperand = rex; |
| 2048 | QualType signedType = lt, unsignedType = rt; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2049 | if (lt->isSignedIntegerType()) { |
| 2050 | if (rt->isSignedIntegerType()) return; |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2051 | } else { |
| 2052 | if (!rt->isSignedIntegerType()) return; |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2053 | std::swap(signedOperand, unsignedOperand); |
| 2054 | std::swap(signedType, unsignedType); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2055 | } |
| 2056 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2057 | unsigned unsignedWidth = Context.getIntWidth(unsignedType); |
| 2058 | unsigned signedWidth = Context.getIntWidth(signedType); |
| 2059 | |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2060 | // If the unsigned type is strictly smaller than the signed type, |
| 2061 | // then (1) the result type will be signed and (2) the unsigned |
| 2062 | // value will fit fully within the signed type, and thus the result |
| 2063 | // of the comparison will be exact. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2064 | if (signedWidth > unsignedWidth) |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2065 | return; |
| 2066 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2067 | // Otherwise, calculate the effective ranges. |
| 2068 | IntRange signedRange = GetExprRange(Context, signedOperand, signedWidth); |
| 2069 | IntRange unsignedRange = GetExprRange(Context, unsignedOperand, unsignedWidth); |
| 2070 | |
| 2071 | // We should never be unable to prove that the unsigned operand is |
| 2072 | // non-negative. |
| 2073 | assert(unsignedRange.NonNegative && "unsigned range includes negative?"); |
| 2074 | |
| 2075 | // If the signed operand is non-negative, then the signed->unsigned |
| 2076 | // conversion won't change it. |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2077 | if (signedRange.NonNegative) { |
| 2078 | // Emit warnings for comparisons of unsigned to integer constant 0. |
| 2079 | // always false: x < 0 (or 0 > x) |
| 2080 | // always true: x >= 0 (or 0 <= x) |
| 2081 | llvm::APSInt X; |
| 2082 | if (BinOpc && signedOperand->isIntegerConstantExpr(X, Context) && X == 0) { |
| 2083 | if (signedOperand != lex) { |
| 2084 | if (*BinOpc == BinaryOperator::LT) { |
| 2085 | Diag(OpLoc, diag::warn_lunsigned_always_true_comparison) |
| 2086 | << "< 0" << "false" |
| 2087 | << lex->getSourceRange() << rex->getSourceRange(); |
| 2088 | } |
| 2089 | else if (*BinOpc == BinaryOperator::GE) { |
| 2090 | Diag(OpLoc, diag::warn_lunsigned_always_true_comparison) |
| 2091 | << ">= 0" << "true" |
| 2092 | << lex->getSourceRange() << rex->getSourceRange(); |
| 2093 | } |
| 2094 | } |
| 2095 | else { |
| 2096 | if (*BinOpc == BinaryOperator::GT) { |
| 2097 | Diag(OpLoc, diag::warn_runsigned_always_true_comparison) |
| 2098 | << "0 >" << "false" |
| 2099 | << lex->getSourceRange() << rex->getSourceRange(); |
| 2100 | } |
| 2101 | else if (*BinOpc == BinaryOperator::LE) { |
| 2102 | Diag(OpLoc, diag::warn_runsigned_always_true_comparison) |
| 2103 | << "0 <=" << "true" |
| 2104 | << lex->getSourceRange() << rex->getSourceRange(); |
| 2105 | } |
| 2106 | } |
| 2107 | } |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2108 | return; |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2109 | } |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2110 | |
| 2111 | // For (in)equality comparisons, if the unsigned operand is a |
| 2112 | // constant which cannot collide with a overflowed signed operand, |
| 2113 | // then reinterpreting the signed operand as unsigned will not |
| 2114 | // change the result of the comparison. |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2115 | if (BinOpc && |
| 2116 | (*BinOpc == BinaryOperator::EQ || *BinOpc == BinaryOperator::NE) && |
| 2117 | unsignedRange.Width < unsignedWidth) |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2118 | return; |
| 2119 | |
John McCall | d1b47bf | 2010-03-11 19:43:18 +0000 | [diff] [blame] | 2120 | Diag(OpLoc, BinOpc ? diag::warn_mixed_sign_comparison |
| 2121 | : diag::warn_mixed_sign_conditional) |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2122 | << lt << rt << lex->getSourceRange() << rex->getSourceRange(); |
John McCall | ba26e58 | 2010-01-04 23:21:16 +0000 | [diff] [blame] | 2123 | } |
| 2124 | |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2125 | /// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. |
| 2126 | static void DiagnoseImpCast(Sema &S, Expr *E, QualType T, unsigned diag) { |
| 2127 | S.Diag(E->getExprLoc(), diag) << E->getType() << T << E->getSourceRange(); |
| 2128 | } |
| 2129 | |
| 2130 | /// Implements -Wconversion. |
| 2131 | void Sema::CheckImplicitConversion(Expr *E, QualType T) { |
| 2132 | // Don't diagnose in unevaluated contexts. |
| 2133 | if (ExprEvalContexts.back().Context == Sema::Unevaluated) |
| 2134 | return; |
| 2135 | |
| 2136 | // Don't diagnose for value-dependent expressions. |
| 2137 | if (E->isValueDependent()) |
| 2138 | return; |
| 2139 | |
| 2140 | const Type *Source = Context.getCanonicalType(E->getType()).getTypePtr(); |
| 2141 | const Type *Target = Context.getCanonicalType(T).getTypePtr(); |
| 2142 | |
| 2143 | // Never diagnose implicit casts to bool. |
| 2144 | if (Target->isSpecificBuiltinType(BuiltinType::Bool)) |
| 2145 | return; |
| 2146 | |
| 2147 | // Strip vector types. |
| 2148 | if (isa<VectorType>(Source)) { |
| 2149 | if (!isa<VectorType>(Target)) |
| 2150 | return DiagnoseImpCast(*this, E, T, diag::warn_impcast_vector_scalar); |
| 2151 | |
| 2152 | Source = cast<VectorType>(Source)->getElementType().getTypePtr(); |
| 2153 | Target = cast<VectorType>(Target)->getElementType().getTypePtr(); |
| 2154 | } |
| 2155 | |
| 2156 | // Strip complex types. |
| 2157 | if (isa<ComplexType>(Source)) { |
| 2158 | if (!isa<ComplexType>(Target)) |
| 2159 | return DiagnoseImpCast(*this, E, T, diag::warn_impcast_complex_scalar); |
| 2160 | |
| 2161 | Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); |
| 2162 | Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); |
| 2163 | } |
| 2164 | |
| 2165 | const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); |
| 2166 | const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); |
| 2167 | |
| 2168 | // If the source is floating point... |
| 2169 | if (SourceBT && SourceBT->isFloatingPoint()) { |
| 2170 | // ...and the target is floating point... |
| 2171 | if (TargetBT && TargetBT->isFloatingPoint()) { |
| 2172 | // ...then warn if we're dropping FP rank. |
| 2173 | |
| 2174 | // Builtin FP kinds are ordered by increasing FP rank. |
| 2175 | if (SourceBT->getKind() > TargetBT->getKind()) { |
| 2176 | // Don't warn about float constants that are precisely |
| 2177 | // representable in the target type. |
| 2178 | Expr::EvalResult result; |
| 2179 | if (E->Evaluate(result, Context)) { |
| 2180 | // Value might be a float, a float vector, or a float complex. |
| 2181 | if (IsSameFloatAfterCast(result.Val, |
| 2182 | Context.getFloatTypeSemantics(QualType(TargetBT, 0)), |
| 2183 | Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) |
| 2184 | return; |
| 2185 | } |
| 2186 | |
| 2187 | DiagnoseImpCast(*this, E, T, diag::warn_impcast_float_precision); |
| 2188 | } |
| 2189 | return; |
| 2190 | } |
| 2191 | |
| 2192 | // If the target is integral, always warn. |
| 2193 | if ((TargetBT && TargetBT->isInteger())) |
| 2194 | // TODO: don't warn for integer values? |
| 2195 | return DiagnoseImpCast(*this, E, T, diag::warn_impcast_float_integer); |
| 2196 | |
| 2197 | return; |
| 2198 | } |
| 2199 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2200 | if (!Source->isIntegerType() || !Target->isIntegerType()) |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2201 | return; |
| 2202 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2203 | IntRange SourceRange = GetExprRange(Context, E, Context.getIntWidth(E->getType())); |
| 2204 | IntRange TargetRange = IntRange::forCanonicalType(Context, Target); |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2205 | |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2206 | // FIXME: also signed<->unsigned? |
| 2207 | |
| 2208 | if (SourceRange.Width > TargetRange.Width) { |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2209 | // People want to build with -Wshorten-64-to-32 and not -Wconversion |
| 2210 | // and by god we'll let them. |
John McCall | f2370c9 | 2010-01-06 05:24:50 +0000 | [diff] [blame] | 2211 | if (SourceRange.Width == 64 && TargetRange.Width == 32) |
John McCall | 51313c3 | 2010-01-04 23:31:57 +0000 | [diff] [blame] | 2212 | return DiagnoseImpCast(*this, E, T, diag::warn_impcast_integer_64_32); |
| 2213 | return DiagnoseImpCast(*this, E, T, diag::warn_impcast_integer_precision); |
| 2214 | } |
| 2215 | |
| 2216 | return; |
| 2217 | } |
| 2218 | |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2219 | /// CheckParmsForFunctionDef - Check that the parameters of the given |
| 2220 | /// function are appropriate for the definition of a function. This |
| 2221 | /// takes care of any checks that cannot be performed on the |
| 2222 | /// declaration itself, e.g., that the types of each of the function |
| 2223 | /// parameters are complete. |
| 2224 | bool Sema::CheckParmsForFunctionDef(FunctionDecl *FD) { |
| 2225 | bool HasInvalidParm = false; |
| 2226 | for (unsigned p = 0, NumParams = FD->getNumParams(); p < NumParams; ++p) { |
| 2227 | ParmVarDecl *Param = FD->getParamDecl(p); |
| 2228 | |
| 2229 | // C99 6.7.5.3p4: the parameters in a parameter type list in a |
| 2230 | // function declarator that is part of a function definition of |
| 2231 | // that function shall not have incomplete type. |
| 2232 | // |
| 2233 | // This is also C++ [dcl.fct]p6. |
| 2234 | if (!Param->isInvalidDecl() && |
| 2235 | RequireCompleteType(Param->getLocation(), Param->getType(), |
| 2236 | diag::err_typecheck_decl_incomplete_type)) { |
| 2237 | Param->setInvalidDecl(); |
| 2238 | HasInvalidParm = true; |
| 2239 | } |
| 2240 | |
| 2241 | // C99 6.9.1p5: If the declarator includes a parameter type list, the |
| 2242 | // declaration of each parameter shall include an identifier. |
| 2243 | if (Param->getIdentifier() == 0 && |
| 2244 | !Param->isImplicit() && |
| 2245 | !getLangOptions().CPlusPlus) |
| 2246 | Diag(Param->getLocation(), diag::err_parameter_name_omitted); |
Sam Weinig | d17e340 | 2010-02-01 05:02:49 +0000 | [diff] [blame] | 2247 | |
| 2248 | // C99 6.7.5.3p12: |
| 2249 | // If the function declarator is not part of a definition of that |
| 2250 | // function, parameters may have incomplete type and may use the [*] |
| 2251 | // notation in their sequences of declarator specifiers to specify |
| 2252 | // variable length array types. |
| 2253 | QualType PType = Param->getOriginalType(); |
| 2254 | if (const ArrayType *AT = Context.getAsArrayType(PType)) { |
| 2255 | if (AT->getSizeModifier() == ArrayType::Star) { |
| 2256 | // FIXME: This diagnosic should point the the '[*]' if source-location |
| 2257 | // information is added for it. |
| 2258 | Diag(Param->getLocation(), diag::err_array_star_in_function_definition); |
| 2259 | } |
| 2260 | } |
Mike Stump | f8c4921 | 2010-01-21 03:59:47 +0000 | [diff] [blame] | 2261 | } |
| 2262 | |
| 2263 | return HasInvalidParm; |
| 2264 | } |