blob: 213a52a9b91ee2655b6dbf230744ac61f6a7b043 [file] [log] [blame]
Ted Kremenek53500662009-07-22 17:55:28 +00001// BugReporterVisitors.cpp - Helpers for reporting bugs -----------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines a set of BugReporter "visitors" which can be used to
11// enhance the diagnostics reported for a bug.
12//
13//===----------------------------------------------------------------------===//
Anna Zaks50bbc162011-08-19 22:33:38 +000014#include "clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h"
Ted Kremenek53500662009-07-22 17:55:28 +000015
16#include "clang/AST/Expr.h"
17#include "clang/AST/ExprObjC.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000018#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
19#include "clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h"
Anna Zaks80de4872012-08-29 21:22:37 +000020#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
Ted Kremenek681bc112011-08-16 01:53:41 +000023#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
Jordan Rose7aba1172012-08-28 00:50:42 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000025#include "llvm/ADT/SmallString.h"
Jordan Rose85e99372012-09-22 01:24:46 +000026#include "llvm/ADT/StringExtras.h"
Ted Kremenek53500662009-07-22 17:55:28 +000027
28using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000029using namespace ento;
Ted Kremenek53500662009-07-22 17:55:28 +000030
31//===----------------------------------------------------------------------===//
32// Utility functions.
33//===----------------------------------------------------------------------===//
34
Anna Zaks9b925ac2012-09-05 23:41:54 +000035bool bugreporter::isDeclRefExprToReference(const Expr *E) {
36 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) {
37 return DRE->getDecl()->getType()->isReferenceType();
38 }
39 return false;
40}
41
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +000042const Stmt *bugreporter::GetDerefExpr(const ExplodedNode *N) {
Ted Kremenek53500662009-07-22 17:55:28 +000043 // Pattern match for a few useful cases (do something smarter later):
44 // a[0], p->f, *p
Jordan Rose3682f1e2012-08-25 01:06:23 +000045 const PostStmt *Loc = N->getLocationAs<PostStmt>();
46 if (!Loc)
47 return 0;
48
Jordan Rose364b9f92012-08-27 20:18:30 +000049 const Expr *S = dyn_cast<Expr>(Loc->getStmt());
50 if (!S)
51 return 0;
52 S = S->IgnoreParenCasts();
Mike Stump1eb44332009-09-09 15:08:12 +000053
Ted Kremenek11abcec2012-05-02 00:31:29 +000054 while (true) {
55 if (const BinaryOperator *B = dyn_cast<BinaryOperator>(S)) {
56 assert(B->isAssignmentOp());
57 S = B->getLHS()->IgnoreParenCasts();
58 continue;
59 }
60 else if (const UnaryOperator *U = dyn_cast<UnaryOperator>(S)) {
61 if (U->getOpcode() == UO_Deref)
62 return U->getSubExpr()->IgnoreParenCasts();
63 }
64 else if (const MemberExpr *ME = dyn_cast<MemberExpr>(S)) {
Anna Zaks9b925ac2012-09-05 23:41:54 +000065 if (ME->isArrow() || isDeclRefExprToReference(ME->getBase())) {
Anna Zaksd91696e2012-09-05 22:31:55 +000066 return ME->getBase()->IgnoreParenCasts();
67 }
Ted Kremenek11abcec2012-05-02 00:31:29 +000068 }
Jordan Rose991bcb42012-09-22 01:24:38 +000069 else if (const ObjCIvarRefExpr *IvarRef = dyn_cast<ObjCIvarRefExpr>(S)) {
70 return IvarRef->getBase()->IgnoreParenCasts();
71 }
Ted Kremenek11abcec2012-05-02 00:31:29 +000072 else if (const ArraySubscriptExpr *AE = dyn_cast<ArraySubscriptExpr>(S)) {
73 return AE->getBase();
74 }
75 break;
Ted Kremenek53500662009-07-22 17:55:28 +000076 }
Mike Stump1eb44332009-09-09 15:08:12 +000077
78 return NULL;
Ted Kremenek53500662009-07-22 17:55:28 +000079}
80
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +000081const Stmt *bugreporter::GetDenomExpr(const ExplodedNode *N) {
Zhongxing Xu6403b572009-09-02 13:26:26 +000082 const Stmt *S = N->getLocationAs<PreStmt>()->getStmt();
Ted Kremenek53500662009-07-22 17:55:28 +000083 if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(S))
84 return BE->getRHS();
85 return NULL;
86}
87
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +000088const Stmt *bugreporter::GetRetValExpr(const ExplodedNode *N) {
Ted Kremenek53500662009-07-22 17:55:28 +000089 const Stmt *S = N->getLocationAs<PostStmt>()->getStmt();
90 if (const ReturnStmt *RS = dyn_cast<ReturnStmt>(S))
91 return RS->getRetValue();
92 return NULL;
93}
94
95//===----------------------------------------------------------------------===//
96// Definitions for bug reporter visitors.
97//===----------------------------------------------------------------------===//
Anna Zaks23f395e2011-08-20 01:27:22 +000098
99PathDiagnosticPiece*
100BugReporterVisitor::getEndPath(BugReporterContext &BRC,
101 const ExplodedNode *EndPathNode,
102 BugReport &BR) {
103 return 0;
104}
105
106PathDiagnosticPiece*
107BugReporterVisitor::getDefaultEndPath(BugReporterContext &BRC,
108 const ExplodedNode *EndPathNode,
109 BugReport &BR) {
Anna Zaks5a0917d2012-02-16 03:41:01 +0000110 PathDiagnosticLocation L =
111 PathDiagnosticLocation::createEndOfPath(EndPathNode,BRC.getSourceManager());
Anna Zaks23f395e2011-08-20 01:27:22 +0000112
113 BugReport::ranges_iterator Beg, End;
114 llvm::tie(Beg, End) = BR.getRanges();
115
116 // Only add the statement itself as a range if we didn't specify any
117 // special ranges for this report.
118 PathDiagnosticPiece *P = new PathDiagnosticEventPiece(L,
119 BR.getDescription(),
120 Beg == End);
121 for (; Beg != End; ++Beg)
122 P->addRange(*Beg);
123
124 return P;
125}
126
127
Jordan Rose7aba1172012-08-28 00:50:42 +0000128namespace {
129/// Emits an extra note at the return statement of an interesting stack frame.
130///
131/// The returned value is marked as an interesting value, and if it's null,
132/// adds a visitor to track where it became null.
133///
134/// This visitor is intended to be used when another visitor discovers that an
135/// interesting value comes from an inlined function call.
136class ReturnVisitor : public BugReporterVisitorImpl<ReturnVisitor> {
137 const StackFrameContext *StackFrame;
138 bool Satisfied;
139public:
140 ReturnVisitor(const StackFrameContext *Frame)
141 : StackFrame(Frame), Satisfied(false) {}
142
Jordan Roseb9d4e5e2012-09-22 01:25:06 +0000143 static void *getTag() {
Jordan Rose7aba1172012-08-28 00:50:42 +0000144 static int Tag = 0;
Jordan Roseb9d4e5e2012-09-22 01:25:06 +0000145 return static_cast<void *>(&Tag);
146 }
147
148 virtual void Profile(llvm::FoldingSetNodeID &ID) const {
149 ID.AddPointer(ReturnVisitor::getTag());
Jordan Rose7aba1172012-08-28 00:50:42 +0000150 ID.AddPointer(StackFrame);
151 }
152
153 /// Adds a ReturnVisitor if the given statement represents a call that was
154 /// inlined.
155 ///
156 /// This will search back through the ExplodedGraph, starting from the given
157 /// node, looking for when the given statement was processed. If it turns out
158 /// the statement is a call that was inlined, we add the visitor to the
159 /// bug report, so it can print a note later.
160 static void addVisitorIfNecessary(const ExplodedNode *Node, const Stmt *S,
161 BugReport &BR) {
162 if (!CallEvent::isCallStmt(S))
163 return;
164
165 // First, find when we processed the statement.
166 do {
167 if (const CallExitEnd *CEE = Node->getLocationAs<CallExitEnd>())
168 if (CEE->getCalleeContext()->getCallSite() == S)
169 break;
170 if (const StmtPoint *SP = Node->getLocationAs<StmtPoint>())
171 if (SP->getStmt() == S)
172 break;
173
174 Node = Node->getFirstPred();
175 } while (Node);
176
177 // Next, step over any post-statement checks.
178 while (Node && isa<PostStmt>(Node->getLocation()))
179 Node = Node->getFirstPred();
180
181 // Finally, see if we inlined the call.
Jordan Rose53221da2012-09-22 01:25:00 +0000182 if (Node) {
183 if (const CallExitEnd *CEE = Node->getLocationAs<CallExitEnd>()) {
184 const StackFrameContext *CalleeContext = CEE->getCalleeContext();
185 if (CalleeContext->getCallSite() == S) {
186 BR.markInteresting(CalleeContext);
187 BR.addVisitor(new ReturnVisitor(CalleeContext));
188 }
189 }
190 }
Jordan Rose7aba1172012-08-28 00:50:42 +0000191 }
192
193 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
194 const ExplodedNode *PrevN,
195 BugReporterContext &BRC,
196 BugReport &BR) {
197 if (Satisfied)
198 return 0;
199
200 // Only print a message at the interesting return statement.
201 if (N->getLocationContext() != StackFrame)
202 return 0;
203
204 const StmtPoint *SP = N->getLocationAs<StmtPoint>();
205 if (!SP)
206 return 0;
207
208 const ReturnStmt *Ret = dyn_cast<ReturnStmt>(SP->getStmt());
209 if (!Ret)
210 return 0;
211
212 // Okay, we're at the right return statement, but do we have the return
213 // value available?
214 ProgramStateRef State = N->getState();
215 SVal V = State->getSVal(Ret, StackFrame);
216 if (V.isUnknownOrUndef())
217 return 0;
218
219 // Don't print any more notes after this one.
220 Satisfied = true;
221
Jordan Rose7aba1172012-08-28 00:50:42 +0000222 const Expr *RetE = Ret->getRetValue();
223 assert(RetE && "Tracking a return value for a void function");
224 RetE = RetE->IgnoreParenCasts();
225
Jordan Rose53221da2012-09-22 01:25:00 +0000226 // If we can't prove the return value is 0, just mark it interesting, and
227 // make sure to track it into any further inner functions.
228 if (State->assume(cast<DefinedSVal>(V), true)) {
Jordan Rose7aba1172012-08-28 00:50:42 +0000229 BR.markInteresting(V);
Jordan Rose53221da2012-09-22 01:25:00 +0000230 ReturnVisitor::addVisitorIfNecessary(N, RetE, BR);
231 return 0;
232 }
233
234 // If we're returning 0, we should track where that 0 came from.
235 bugreporter::trackNullOrUndefValue(N, RetE, BR);
236
Jordan Roseb9d4e5e2012-09-22 01:25:06 +0000237 // Build an appropriate message based on the return value.
238 SmallString<64> Msg;
239 llvm::raw_svector_ostream Out(Msg);
240
Jordan Rose53221da2012-09-22 01:25:00 +0000241 if (isa<Loc>(V)) {
Jordan Roseb9d4e5e2012-09-22 01:25:06 +0000242 // If we are pruning null-return paths as unlikely error paths, mark the
243 // report invalid. We still want to emit a path note, however, in case
244 // the report is resurrected as valid later on.
245 ExprEngine &Eng = BRC.getBugReporter().getEngine();
246 if (Eng.getAnalysisManager().options.shouldPruneNullReturnPaths())
247 BR.markInvalid(ReturnVisitor::getTag(), StackFrame);
248
Jordan Rose53221da2012-09-22 01:25:00 +0000249 if (RetE->getType()->isObjCObjectPointerType())
250 Out << "Returning nil";
251 else
252 Out << "Returning null pointer";
253 } else {
254 Out << "Returning zero";
Jordan Rose7aba1172012-08-28 00:50:42 +0000255 }
256
257 // FIXME: We should have a more generalized location printing mechanism.
258 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(RetE))
259 if (const DeclaratorDecl *DD = dyn_cast<DeclaratorDecl>(DR->getDecl()))
260 Out << " (loaded from '" << *DD << "')";
261
262 PathDiagnosticLocation L(Ret, BRC.getSourceManager(), StackFrame);
263 return new PathDiagnosticEventPiece(L, Out.str());
264 }
265};
266} // end anonymous namespace
267
268
Anna Zaks50bbc162011-08-19 22:33:38 +0000269void FindLastStoreBRVisitor ::Profile(llvm::FoldingSetNodeID &ID) const {
270 static int tag = 0;
271 ID.AddPointer(&tag);
272 ID.AddPointer(R);
273 ID.Add(V);
274}
Ted Kremenek53500662009-07-22 17:55:28 +0000275
Jordan Rose166b7bd2012-08-28 00:50:45 +0000276PathDiagnosticPiece *FindLastStoreBRVisitor::VisitNode(const ExplodedNode *Succ,
277 const ExplodedNode *Pred,
278 BugReporterContext &BRC,
279 BugReport &BR) {
Mike Stump1eb44332009-09-09 15:08:12 +0000280
Anna Zaks50bbc162011-08-19 22:33:38 +0000281 if (satisfied)
282 return NULL;
283
Jordan Rose166b7bd2012-08-28 00:50:45 +0000284 const ExplodedNode *StoreSite = 0;
285 const Expr *InitE = 0;
Anna Zaks50bbc162011-08-19 22:33:38 +0000286
Jordan Rose166b7bd2012-08-28 00:50:45 +0000287 // First see if we reached the declaration of the region.
288 if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
289 if (const PostStmt *P = Pred->getLocationAs<PostStmt>()) {
290 if (const DeclStmt *DS = P->getStmtAs<DeclStmt>()) {
291 if (DS->getSingleDecl() == VR->getDecl()) {
292 StoreSite = Pred;
293 InitE = VR->getDecl()->getInit();
Jordan Rose7aba1172012-08-28 00:50:42 +0000294 }
Jordan Rose7aba1172012-08-28 00:50:42 +0000295 }
Jordan Rose7aba1172012-08-28 00:50:42 +0000296 }
Ted Kremenek1b431022010-03-20 18:01:57 +0000297 }
298
Jordan Rose166b7bd2012-08-28 00:50:45 +0000299 // Otherwise, check that Succ has this binding and Pred does not, i.e. this is
300 // where the binding first occurred.
301 if (!StoreSite) {
302 if (Succ->getState()->getSVal(R) != V)
303 return NULL;
304 if (Pred->getState()->getSVal(R) == V)
305 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +0000306
Jordan Rose166b7bd2012-08-28 00:50:45 +0000307 StoreSite = Succ;
308
309 // If this is an assignment expression, we can track the value
310 // being assigned.
311 if (const PostStmt *P = Succ->getLocationAs<PostStmt>())
312 if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>())
313 if (BO->isAssignmentOp())
314 InitE = BO->getRHS();
Jordan Rose85e99372012-09-22 01:24:46 +0000315
316 // If this is a call entry, the variable should be a parameter.
317 // FIXME: Handle CXXThisRegion as well. (This is not a priority because
318 // 'this' should never be NULL, but this visitor isn't just for NULL and
319 // UndefinedVal.)
320 if (const CallEnter *CE = Succ->getLocationAs<CallEnter>()) {
321 const VarRegion *VR = cast<VarRegion>(R);
322 const ParmVarDecl *Param = cast<ParmVarDecl>(VR->getDecl());
323
324 ProgramStateManager &StateMgr = BRC.getStateManager();
325 CallEventManager &CallMgr = StateMgr.getCallEventManager();
326
327 CallEventRef<> Call = CallMgr.getCaller(CE->getCalleeContext(),
328 Succ->getState());
329 InitE = Call->getArgExpr(Param->getFunctionScopeIndex());
330 }
Jordan Rose166b7bd2012-08-28 00:50:45 +0000331 }
332
333 if (!StoreSite)
334 return NULL;
Anna Zaks50bbc162011-08-19 22:33:38 +0000335 satisfied = true;
Jordan Rose166b7bd2012-08-28 00:50:45 +0000336
Jordan Rose53221da2012-09-22 01:25:00 +0000337 // If we have an expression that provided the value, try to track where it
338 // came from.
Jordan Rose166b7bd2012-08-28 00:50:45 +0000339 if (InitE) {
340 InitE = InitE->IgnoreParenCasts();
Jordan Rose53221da2012-09-22 01:25:00 +0000341
342 if (V.isUndef() || isa<loc::ConcreteInt>(V))
343 bugreporter::trackNullOrUndefValue(StoreSite, InitE, BR);
344 else
345 ReturnVisitor::addVisitorIfNecessary(StoreSite, InitE, BR);
Jordan Rose166b7bd2012-08-28 00:50:45 +0000346 }
347
Jordan Rose85e99372012-09-22 01:24:46 +0000348 if (!R->canPrintPretty())
349 return 0;
350
Jordan Rose166b7bd2012-08-28 00:50:45 +0000351 // Okay, we've found the binding. Emit an appropriate message.
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000352 SmallString<256> sbuf;
Anna Zaks50bbc162011-08-19 22:33:38 +0000353 llvm::raw_svector_ostream os(sbuf);
Mike Stump1eb44332009-09-09 15:08:12 +0000354
Jordan Rose166b7bd2012-08-28 00:50:45 +0000355 if (const PostStmt *PS = StoreSite->getLocationAs<PostStmt>()) {
Anna Zaks50bbc162011-08-19 22:33:38 +0000356 if (const DeclStmt *DS = PS->getStmtAs<DeclStmt>()) {
Mike Stump1eb44332009-09-09 15:08:12 +0000357
Anna Zaks50bbc162011-08-19 22:33:38 +0000358 if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000359 os << "Variable '" << *VR->getDecl() << "' ";
Ted Kremenek53500662009-07-22 17:55:28 +0000360 }
Anna Zaks50bbc162011-08-19 22:33:38 +0000361 else
Ted Kremenek53500662009-07-22 17:55:28 +0000362 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +0000363
Ted Kremenek53500662009-07-22 17:55:28 +0000364 if (isa<loc::ConcreteInt>(V)) {
365 bool b = false;
Ted Kremenek53500662009-07-22 17:55:28 +0000366 if (R->isBoundable()) {
Ted Kremenek96979342011-08-12 20:02:48 +0000367 if (const TypedValueRegion *TR = dyn_cast<TypedValueRegion>(R)) {
Zhongxing Xu018220c2010-08-11 06:10:55 +0000368 if (TR->getValueType()->isObjCObjectPointerType()) {
Anna Zaks50bbc162011-08-19 22:33:38 +0000369 os << "initialized to nil";
Ted Kremenek53500662009-07-22 17:55:28 +0000370 b = true;
371 }
372 }
373 }
Mike Stump1eb44332009-09-09 15:08:12 +0000374
Ted Kremenek53500662009-07-22 17:55:28 +0000375 if (!b)
Anna Zaks50bbc162011-08-19 22:33:38 +0000376 os << "initialized to a null pointer value";
Ted Kremenek53500662009-07-22 17:55:28 +0000377 }
Ted Kremenek592362b2009-08-18 01:05:30 +0000378 else if (isa<nonloc::ConcreteInt>(V)) {
Anna Zaks50bbc162011-08-19 22:33:38 +0000379 os << "initialized to " << cast<nonloc::ConcreteInt>(V).getValue();
Ted Kremenek592362b2009-08-18 01:05:30 +0000380 }
Anna Zaks50bbc162011-08-19 22:33:38 +0000381 else if (V.isUndef()) {
382 if (isa<VarRegion>(R)) {
383 const VarDecl *VD = cast<VarDecl>(DS->getSingleDecl());
384 if (VD->getInit())
385 os << "initialized to a garbage value";
386 else
387 os << "declared without an initial value";
388 }
Ted Kremenek53500662009-07-22 17:55:28 +0000389 }
Jordan Rose68537992012-08-03 23:09:01 +0000390 else {
391 os << "initialized here";
392 }
Ted Kremenek53500662009-07-22 17:55:28 +0000393 }
Jordan Rose85e99372012-09-22 01:24:46 +0000394 } else if (isa<CallEnter>(StoreSite->getLocation())) {
395 const ParmVarDecl *Param = cast<ParmVarDecl>(cast<VarRegion>(R)->getDecl());
396
397 os << "Passing ";
398
399 if (isa<loc::ConcreteInt>(V)) {
400 if (Param->getType()->isObjCObjectPointerType())
401 os << "nil object reference";
402 else
403 os << "null pointer value";
404 } else if (V.isUndef()) {
405 os << "uninitialized value";
406 } else if (isa<nonloc::ConcreteInt>(V)) {
407 os << "the value " << cast<nonloc::ConcreteInt>(V).getValue();
408 } else {
409 os << "value";
410 }
411
412 // Printed parameter indexes are 1-based, not 0-based.
413 unsigned Idx = Param->getFunctionScopeIndex() + 1;
414 os << " via " << Idx << llvm::getOrdinalSuffix(Idx) << " parameter '";
415
416 R->printPretty(os);
417 os << '\'';
Anna Zaks50bbc162011-08-19 22:33:38 +0000418 }
419
420 if (os.str().empty()) {
421 if (isa<loc::ConcreteInt>(V)) {
422 bool b = false;
423 if (R->isBoundable()) {
424 if (const TypedValueRegion *TR = dyn_cast<TypedValueRegion>(R)) {
425 if (TR->getValueType()->isObjCObjectPointerType()) {
426 os << "nil object reference stored to ";
427 b = true;
428 }
429 }
430 }
431
432 if (!b)
433 os << "Null pointer value stored to ";
434 }
435 else if (V.isUndef()) {
436 os << "Uninitialized value stored to ";
437 }
438 else if (isa<nonloc::ConcreteInt>(V)) {
439 os << "The value " << cast<nonloc::ConcreteInt>(V).getValue()
440 << " is assigned to ";
441 }
442 else
Jordan Rose68537992012-08-03 23:09:01 +0000443 os << "Value assigned to ";
Anna Zaks50bbc162011-08-19 22:33:38 +0000444
Jordan Rose85e99372012-09-22 01:24:46 +0000445 os << '\'';
446 R->printPretty(os);
447 os << '\'';
Anna Zaks50bbc162011-08-19 22:33:38 +0000448 }
449
Anna Zaks50bbc162011-08-19 22:33:38 +0000450 // Construct a new PathDiagnosticPiece.
Jordan Rose166b7bd2012-08-28 00:50:45 +0000451 ProgramPoint P = StoreSite->getLocation();
Jordan Rose85e99372012-09-22 01:24:46 +0000452 PathDiagnosticLocation L;
453 if (isa<CallEnter>(P))
454 L = PathDiagnosticLocation(InitE, BRC.getSourceManager(),
455 P.getLocationContext());
456 else
457 L = PathDiagnosticLocation::create(P, BRC.getSourceManager());
Anna Zaks4fdf97b2011-09-15 18:56:07 +0000458 if (!L.isValid())
459 return NULL;
Anna Zaks50bbc162011-08-19 22:33:38 +0000460 return new PathDiagnosticEventPiece(L, os.str());
461}
462
463void TrackConstraintBRVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
464 static int tag = 0;
465 ID.AddPointer(&tag);
466 ID.AddBoolean(Assumption);
467 ID.Add(Constraint);
468}
469
Ted Kremenekb85cce02012-10-25 22:07:10 +0000470/// Return the tag associated with this visitor. This tag will be used
471/// to make all PathDiagnosticPieces created by this visitor.
472const char *TrackConstraintBRVisitor::getTag() {
473 return "TrackConstraintBRVisitor";
474}
475
Anna Zaks50bbc162011-08-19 22:33:38 +0000476PathDiagnosticPiece *
477TrackConstraintBRVisitor::VisitNode(const ExplodedNode *N,
478 const ExplodedNode *PrevN,
479 BugReporterContext &BRC,
480 BugReport &BR) {
481 if (isSatisfied)
482 return NULL;
483
484 // Check if in the previous state it was feasible for this constraint
485 // to *not* be true.
486 if (PrevN->getState()->assume(Constraint, !Assumption)) {
487
488 isSatisfied = true;
489
490 // As a sanity check, make sure that the negation of the constraint
491 // was infeasible in the current state. If it is feasible, we somehow
492 // missed the transition point.
493 if (N->getState()->assume(Constraint, !Assumption))
494 return NULL;
495
496 // We found the transition point for the constraint. We now need to
497 // pretty-print the constraint. (work-in-progress)
498 std::string sbuf;
499 llvm::raw_string_ostream os(sbuf);
500
501 if (isa<Loc>(Constraint)) {
502 os << "Assuming pointer value is ";
503 os << (Assumption ? "non-null" : "null");
504 }
505
506 if (os.str().empty())
507 return NULL;
Mike Stump1eb44332009-09-09 15:08:12 +0000508
Ted Kremenek53500662009-07-22 17:55:28 +0000509 // Construct a new PathDiagnosticPiece.
Anna Zaks4fdf97b2011-09-15 18:56:07 +0000510 ProgramPoint P = N->getLocation();
Anna Zaks1531bb02011-09-20 01:38:47 +0000511 PathDiagnosticLocation L =
512 PathDiagnosticLocation::create(P, BRC.getSourceManager());
Anna Zaks4fdf97b2011-09-15 18:56:07 +0000513 if (!L.isValid())
514 return NULL;
Ted Kremenekb85cce02012-10-25 22:07:10 +0000515
516 PathDiagnosticEventPiece *X = new PathDiagnosticEventPiece(L, os.str());
517 X->setTag(getTag());
518 return X;
Ted Kremenek53500662009-07-22 17:55:28 +0000519 }
Ted Kremenek53500662009-07-22 17:55:28 +0000520
Anna Zaks50bbc162011-08-19 22:33:38 +0000521 return NULL;
Ted Kremenek53500662009-07-22 17:55:28 +0000522}
523
Jordan Rosea1f81bb2012-08-28 00:50:51 +0000524void bugreporter::trackNullOrUndefValue(const ExplodedNode *N, const Stmt *S,
525 BugReport &report) {
Anna Zaks50bbc162011-08-19 22:33:38 +0000526 if (!S || !N)
Jordan Rose68537992012-08-03 23:09:01 +0000527 return;
Mike Stump1eb44332009-09-09 15:08:12 +0000528
Jordan Rose6686b662012-09-22 01:24:49 +0000529 if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(S))
530 S = OVE->getSourceExpr();
531
Anna Zaks8e6431a2011-08-18 22:37:56 +0000532 ProgramStateManager &StateMgr = N->getState()->getStateManager();
533
Jordan Rose364b9f92012-08-27 20:18:30 +0000534 // Walk through nodes until we get one that matches the statement exactly.
Ted Kremenek88299892011-07-28 23:07:59 +0000535 while (N) {
536 const ProgramPoint &pp = N->getLocation();
537 if (const PostStmt *ps = dyn_cast<PostStmt>(&pp)) {
538 if (ps->getStmt() == S)
539 break;
Jordan Rose23df2432012-08-24 16:34:31 +0000540 } else if (const CallExitEnd *CEE = dyn_cast<CallExitEnd>(&pp)) {
541 if (CEE->getCalleeContext()->getCallSite() == S)
542 break;
Ted Kremenek88299892011-07-28 23:07:59 +0000543 }
Anna Zaksb459cf32011-10-01 06:35:19 +0000544 N = N->getFirstPred();
Ted Kremenek88299892011-07-28 23:07:59 +0000545 }
546
547 if (!N)
Jordan Rose68537992012-08-03 23:09:01 +0000548 return;
Ted Kremenek88299892011-07-28 23:07:59 +0000549
Ted Kremenek8bef8232012-01-26 21:29:00 +0000550 ProgramStateRef state = N->getState();
Mike Stump1eb44332009-09-09 15:08:12 +0000551
Jordan Rose364b9f92012-08-27 20:18:30 +0000552 // See if the expression we're interested refers to a variable.
553 // If so, we can track both its contents and constraints on its value.
554 if (const Expr *Ex = dyn_cast<Expr>(S)) {
555 // Strip off parens and casts. Note that this will never have issues with
556 // C++ user-defined implicit conversions, because those have a constructor
557 // or function call inside.
Jordan Rosee6cd0542012-08-16 00:03:33 +0000558 Ex = Ex->IgnoreParenCasts();
Ted Kremenek76aadc32012-03-09 01:13:14 +0000559 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Ex)) {
Jordan Rose364b9f92012-08-27 20:18:30 +0000560 // FIXME: Right now we only track VarDecls because it's non-trivial to
561 // get a MemRegion for any other DeclRefExprs. <rdar://problem/12114812>
Ted Kremenek76aadc32012-03-09 01:13:14 +0000562 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
563 const VarRegion *R =
564 StateMgr.getRegionManager().getVarRegion(VD, N->getLocationContext());
Mike Stump1eb44332009-09-09 15:08:12 +0000565
Jordan Rose364b9f92012-08-27 20:18:30 +0000566 // Mark both the variable region and its contents as interesting.
Ted Kremenek11abcec2012-05-02 00:31:29 +0000567 SVal V = state->getRawSVal(loc::MemRegionVal(R));
Jordan Rosea1f81bb2012-08-28 00:50:51 +0000568 report.markInteresting(R);
569 report.markInteresting(V);
Anna Zaks80de4872012-08-29 21:22:37 +0000570 report.addVisitor(new UndefOrNullArgVisitor(R));
Jordan Rose68537992012-08-03 23:09:01 +0000571
Jordan Rose364b9f92012-08-27 20:18:30 +0000572 // If the contents are symbolic, find out when they became null.
Jordan Rose68537992012-08-03 23:09:01 +0000573 if (V.getAsLocSymbol()) {
574 BugReporterVisitor *ConstraintTracker
Jordan Rose53221da2012-09-22 01:25:00 +0000575 = new TrackConstraintBRVisitor(cast<DefinedSVal>(V), false);
Jordan Rosea1f81bb2012-08-28 00:50:51 +0000576 report.addVisitor(ConstraintTracker);
Jordan Rose68537992012-08-03 23:09:01 +0000577 }
578
Jordan Rosea1f81bb2012-08-28 00:50:51 +0000579 report.addVisitor(new FindLastStoreBRVisitor(V, R));
Jordan Rose68537992012-08-03 23:09:01 +0000580 return;
Ted Kremenek53500662009-07-22 17:55:28 +0000581 }
582 }
583 }
Mike Stump1eb44332009-09-09 15:08:12 +0000584
Jordan Rose364b9f92012-08-27 20:18:30 +0000585 // If the expression does NOT refer to a variable, we can still track
586 // constraints on its contents.
Ted Kremenek5eca4822012-01-06 22:09:28 +0000587 SVal V = state->getSValAsScalarOrLoc(S, N->getLocationContext());
Mike Stump1eb44332009-09-09 15:08:12 +0000588
Ted Kremenek53500662009-07-22 17:55:28 +0000589 // Uncomment this to find cases where we aren't properly getting the
590 // base value that was dereferenced.
591 // assert(!V.isUnknownOrUndef());
Mike Stump1eb44332009-09-09 15:08:12 +0000592
Ted Kremenek53500662009-07-22 17:55:28 +0000593 // Is it a symbolic value?
594 if (loc::MemRegionVal *L = dyn_cast<loc::MemRegionVal>(&V)) {
Anna Zaksd91696e2012-09-05 22:31:55 +0000595 // At this point we are dealing with the region's LValue.
596 // However, if the rvalue is a symbolic region, we should track it as well.
597 SVal RVal = state->getSVal(L->getRegion());
598 const MemRegion *RegionRVal = RVal.getAsRegion();
Anna Zaks522fc212012-09-12 22:57:30 +0000599 report.addVisitor(new UndefOrNullArgVisitor(L->getRegion()));
600
Anna Zaksd91696e2012-09-05 22:31:55 +0000601
602 if (RegionRVal && isa<SymbolicRegion>(RegionRVal)) {
603 report.markInteresting(RegionRVal);
604 report.addVisitor(new TrackConstraintBRVisitor(
605 loc::MemRegionVal(RegionRVal), false));
Ted Kremenek53500662009-07-22 17:55:28 +0000606 }
Jordan Rose7aba1172012-08-28 00:50:42 +0000607 } else {
608 // Otherwise, if the value came from an inlined function call,
609 // we should at least make sure that function isn't pruned in our output.
Jordan Rose53221da2012-09-22 01:25:00 +0000610 if (const Expr *E = dyn_cast<Expr>(S))
611 S = E->IgnoreParenCasts();
Jordan Rosea1f81bb2012-08-28 00:50:51 +0000612 ReturnVisitor::addVisitorIfNecessary(N, S, report);
Ted Kremenek53500662009-07-22 17:55:28 +0000613 }
614}
Ted Kremenek94fd0b82010-02-16 08:33:59 +0000615
Anna Zaks50bbc162011-08-19 22:33:38 +0000616BugReporterVisitor *
617FindLastStoreBRVisitor::createVisitorObject(const ExplodedNode *N,
618 const MemRegion *R) {
619 assert(R && "The memory region is null.");
Ted Kremenek94fd0b82010-02-16 08:33:59 +0000620
Ted Kremenek8bef8232012-01-26 21:29:00 +0000621 ProgramStateRef state = N->getState();
Ted Kremenek94fd0b82010-02-16 08:33:59 +0000622 SVal V = state->getSVal(R);
Ted Kremenek94fd0b82010-02-16 08:33:59 +0000623 if (V.isUnknown())
Anna Zaks50bbc162011-08-19 22:33:38 +0000624 return 0;
Ted Kremenek94fd0b82010-02-16 08:33:59 +0000625
Anna Zaks50bbc162011-08-19 22:33:38 +0000626 return new FindLastStoreBRVisitor(V, R);
Ted Kremenek94fd0b82010-02-16 08:33:59 +0000627}
Ted Kremenekff7f7362010-03-20 18:02:01 +0000628
629
Anna Zaks50bbc162011-08-19 22:33:38 +0000630PathDiagnosticPiece *NilReceiverBRVisitor::VisitNode(const ExplodedNode *N,
631 const ExplodedNode *PrevN,
632 BugReporterContext &BRC,
633 BugReport &BR) {
634 const PostStmt *P = N->getLocationAs<PostStmt>();
635 if (!P)
636 return 0;
637 const ObjCMessageExpr *ME = P->getStmtAs<ObjCMessageExpr>();
638 if (!ME)
639 return 0;
640 const Expr *Receiver = ME->getInstanceReceiver();
641 if (!Receiver)
642 return 0;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000643 ProgramStateRef state = N->getState();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000644 const SVal &V = state->getSVal(Receiver, N->getLocationContext());
Anna Zaks50bbc162011-08-19 22:33:38 +0000645 const DefinedOrUnknownSVal *DV = dyn_cast<DefinedOrUnknownSVal>(&V);
646 if (!DV)
647 return 0;
648 state = state->assume(*DV, true);
649 if (state)
650 return 0;
Ted Kremenekff7f7362010-03-20 18:02:01 +0000651
Anna Zaks50bbc162011-08-19 22:33:38 +0000652 // The receiver was nil, and hence the method was skipped.
653 // Register a BugReporterVisitor to issue a message telling us how
654 // the receiver was null.
Jordan Rosea1f81bb2012-08-28 00:50:51 +0000655 bugreporter::trackNullOrUndefValue(N, Receiver, BR);
Anna Zaks50bbc162011-08-19 22:33:38 +0000656 // Issue a message saying that the method was skipped.
Anna Zaks220ac8c2011-09-15 01:08:34 +0000657 PathDiagnosticLocation L(Receiver, BRC.getSourceManager(),
658 N->getLocationContext());
Anna Zaks907344e2012-04-05 02:10:19 +0000659 return new PathDiagnosticEventPiece(L, "No method is called "
Anna Zaks50bbc162011-08-19 22:33:38 +0000660 "because the receiver is nil");
Ted Kremenekff7f7362010-03-20 18:02:01 +0000661}
Tom Care2bbbe502010-09-02 23:30:22 +0000662
Anna Zaks8e6431a2011-08-18 22:37:56 +0000663// Registers every VarDecl inside a Stmt with a last store visitor.
Anna Zaks50bbc162011-08-19 22:33:38 +0000664void FindLastStoreBRVisitor::registerStatementVarDecls(BugReport &BR,
665 const Stmt *S) {
Anna Zaks8e6431a2011-08-18 22:37:56 +0000666 const ExplodedNode *N = BR.getErrorNode();
Tom Care2bbbe502010-09-02 23:30:22 +0000667 std::deque<const Stmt *> WorkList;
Tom Care2bbbe502010-09-02 23:30:22 +0000668 WorkList.push_back(S);
669
670 while (!WorkList.empty()) {
671 const Stmt *Head = WorkList.front();
672 WorkList.pop_front();
673
Ted Kremenek8bef8232012-01-26 21:29:00 +0000674 ProgramStateRef state = N->getState();
Anna Zaks8e6431a2011-08-18 22:37:56 +0000675 ProgramStateManager &StateMgr = state->getStateManager();
Tom Care2bbbe502010-09-02 23:30:22 +0000676
677 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Head)) {
678 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
679 const VarRegion *R =
680 StateMgr.getRegionManager().getVarRegion(VD, N->getLocationContext());
681
682 // What did we load?
Ted Kremenek5eca4822012-01-06 22:09:28 +0000683 SVal V = state->getSVal(S, N->getLocationContext());
Tom Care2bbbe502010-09-02 23:30:22 +0000684
685 if (isa<loc::ConcreteInt>(V) || isa<nonloc::ConcreteInt>(V)) {
Anna Zaks50bbc162011-08-19 22:33:38 +0000686 // Register a new visitor with the BugReport.
687 BR.addVisitor(new FindLastStoreBRVisitor(V, R));
Tom Care2bbbe502010-09-02 23:30:22 +0000688 }
689 }
690 }
691
692 for (Stmt::const_child_iterator I = Head->child_begin();
693 I != Head->child_end(); ++I)
694 WorkList.push_back(*I);
695 }
696}
Ted Kremenek993124e2011-08-06 06:54:45 +0000697
698//===----------------------------------------------------------------------===//
699// Visitor that tries to report interesting diagnostics from conditions.
700//===----------------------------------------------------------------------===//
Ted Kremenekb85cce02012-10-25 22:07:10 +0000701
702/// Return the tag associated with this visitor. This tag will be used
703/// to make all PathDiagnosticPieces created by this visitor.
704const char *ConditionBRVisitor::getTag() {
705 return "ConditionBRVisitor";
706}
707
Anna Zaks50bbc162011-08-19 22:33:38 +0000708PathDiagnosticPiece *ConditionBRVisitor::VisitNode(const ExplodedNode *N,
709 const ExplodedNode *Prev,
710 BugReporterContext &BRC,
711 BugReport &BR) {
Ted Kremenekc89f4b02012-02-28 23:06:21 +0000712 PathDiagnosticPiece *piece = VisitNodeImpl(N, Prev, BRC, BR);
Ted Kremenekb85cce02012-10-25 22:07:10 +0000713 if (piece) {
714 piece->setTag(getTag());
715 if (PathDiagnosticEventPiece *ev=dyn_cast<PathDiagnosticEventPiece>(piece))
716 ev->setPrunable(true, /* override */ false);
717 }
Ted Kremenekc89f4b02012-02-28 23:06:21 +0000718 return piece;
719}
720
721PathDiagnosticPiece *ConditionBRVisitor::VisitNodeImpl(const ExplodedNode *N,
722 const ExplodedNode *Prev,
723 BugReporterContext &BRC,
724 BugReport &BR) {
Ted Kremenek993124e2011-08-06 06:54:45 +0000725
Ted Kremenek22505ef2012-09-08 07:18:18 +0000726 ProgramPoint progPoint = N->getLocation();
Ted Kremenek8bef8232012-01-26 21:29:00 +0000727 ProgramStateRef CurrentState = N->getState();
728 ProgramStateRef PrevState = Prev->getState();
Ted Kremenek681bc112011-08-16 01:53:41 +0000729
730 // Compare the GDMs of the state, because that is where constraints
731 // are managed. Note that ensure that we only look at nodes that
732 // were generated by the analyzer engine proper, not checkers.
733 if (CurrentState->getGDM().getRoot() ==
734 PrevState->getGDM().getRoot())
735 return 0;
Ted Kremenek993124e2011-08-06 06:54:45 +0000736
737 // If an assumption was made on a branch, it should be caught
738 // here by looking at the state transition.
739 if (const BlockEdge *BE = dyn_cast<BlockEdge>(&progPoint)) {
Ted Kremenek681bc112011-08-16 01:53:41 +0000740 const CFGBlock *srcBlk = BE->getSrc();
741 if (const Stmt *term = srcBlk->getTerminator())
Ted Kremenek76aadc32012-03-09 01:13:14 +0000742 return VisitTerminator(term, N, srcBlk, BE->getDst(), BR, BRC);
Ted Kremenek681bc112011-08-16 01:53:41 +0000743 return 0;
744 }
745
746 if (const PostStmt *PS = dyn_cast<PostStmt>(&progPoint)) {
747 // FIXME: Assuming that BugReporter is a GRBugReporter is a layering
748 // violation.
749 const std::pair<const ProgramPointTag *, const ProgramPointTag *> &tags =
750 cast<GRBugReporter>(BRC.getBugReporter()).
Ted Kremenek0caa2d42012-08-30 19:26:48 +0000751 getEngine().geteagerlyAssumeBinOpBifurcationTags();
Ted Kremenek681bc112011-08-16 01:53:41 +0000752
753 const ProgramPointTag *tag = PS->getTag();
754 if (tag == tags.first)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000755 return VisitTrueTest(cast<Expr>(PS->getStmt()), true,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000756 BRC, BR, N);
Ted Kremenek681bc112011-08-16 01:53:41 +0000757 if (tag == tags.second)
Anna Zaks220ac8c2011-09-15 01:08:34 +0000758 return VisitTrueTest(cast<Expr>(PS->getStmt()), false,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000759 BRC, BR, N);
Ted Kremenek681bc112011-08-16 01:53:41 +0000760
Ted Kremenek993124e2011-08-06 06:54:45 +0000761 return 0;
762 }
763
764 return 0;
765}
766
767PathDiagnosticPiece *
Anna Zaks50bbc162011-08-19 22:33:38 +0000768ConditionBRVisitor::VisitTerminator(const Stmt *Term,
Anna Zaks220ac8c2011-09-15 01:08:34 +0000769 const ExplodedNode *N,
Anna Zaks50bbc162011-08-19 22:33:38 +0000770 const CFGBlock *srcBlk,
771 const CFGBlock *dstBlk,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000772 BugReport &R,
Anna Zaks50bbc162011-08-19 22:33:38 +0000773 BugReporterContext &BRC) {
Ted Kremenek993124e2011-08-06 06:54:45 +0000774 const Expr *Cond = 0;
775
776 switch (Term->getStmtClass()) {
777 default:
778 return 0;
779 case Stmt::IfStmtClass:
780 Cond = cast<IfStmt>(Term)->getCond();
781 break;
782 case Stmt::ConditionalOperatorClass:
783 Cond = cast<ConditionalOperator>(Term)->getCond();
784 break;
785 }
786
787 assert(Cond);
788 assert(srcBlk->succ_size() == 2);
789 const bool tookTrue = *(srcBlk->succ_begin()) == dstBlk;
Ted Kremenekc47dc1b2012-09-07 06:51:37 +0000790 return VisitTrueTest(Cond, tookTrue, BRC, R, N);
Ted Kremenek993124e2011-08-06 06:54:45 +0000791}
792
793PathDiagnosticPiece *
Anna Zaks50bbc162011-08-19 22:33:38 +0000794ConditionBRVisitor::VisitTrueTest(const Expr *Cond,
795 bool tookTrue,
Anna Zaks220ac8c2011-09-15 01:08:34 +0000796 BugReporterContext &BRC,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000797 BugReport &R,
798 const ExplodedNode *N) {
Ted Kremenek993124e2011-08-06 06:54:45 +0000799
800 const Expr *Ex = Cond;
801
Ted Kremenek681bc112011-08-16 01:53:41 +0000802 while (true) {
Ted Kremenekc47dc1b2012-09-07 06:51:37 +0000803 Ex = Ex->IgnoreParenCasts();
Ted Kremenek993124e2011-08-06 06:54:45 +0000804 switch (Ex->getStmtClass()) {
805 default:
806 return 0;
Ted Kremenek681bc112011-08-16 01:53:41 +0000807 case Stmt::BinaryOperatorClass:
Ted Kremenek76aadc32012-03-09 01:13:14 +0000808 return VisitTrueTest(Cond, cast<BinaryOperator>(Ex), tookTrue, BRC,
809 R, N);
Ted Kremenek993124e2011-08-06 06:54:45 +0000810 case Stmt::DeclRefExprClass:
Ted Kremenek76aadc32012-03-09 01:13:14 +0000811 return VisitTrueTest(Cond, cast<DeclRefExpr>(Ex), tookTrue, BRC,
812 R, N);
Ted Kremenek993124e2011-08-06 06:54:45 +0000813 case Stmt::UnaryOperatorClass: {
814 const UnaryOperator *UO = cast<UnaryOperator>(Ex);
815 if (UO->getOpcode() == UO_LNot) {
816 tookTrue = !tookTrue;
Ted Kremenekc47dc1b2012-09-07 06:51:37 +0000817 Ex = UO->getSubExpr();
Ted Kremenek993124e2011-08-06 06:54:45 +0000818 continue;
819 }
820 return 0;
821 }
822 }
Ted Kremenek681bc112011-08-16 01:53:41 +0000823 }
824}
825
Anna Zaks50bbc162011-08-19 22:33:38 +0000826bool ConditionBRVisitor::patternMatch(const Expr *Ex, llvm::raw_ostream &Out,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000827 BugReporterContext &BRC,
828 BugReport &report,
829 const ExplodedNode *N,
830 llvm::Optional<bool> &prunable) {
Ted Kremenek681bc112011-08-16 01:53:41 +0000831 const Expr *OriginalExpr = Ex;
832 Ex = Ex->IgnoreParenCasts();
833
834 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Ex)) {
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000835 const bool quotes = isa<VarDecl>(DR->getDecl());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000836 if (quotes) {
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000837 Out << '\'';
Ted Kremenek76aadc32012-03-09 01:13:14 +0000838 const LocationContext *LCtx = N->getLocationContext();
839 const ProgramState *state = N->getState().getPtr();
840 if (const MemRegion *R = state->getLValue(cast<VarDecl>(DR->getDecl()),
841 LCtx).getAsRegion()) {
842 if (report.isInteresting(R))
843 prunable = false;
844 else {
845 const ProgramState *state = N->getState().getPtr();
846 SVal V = state->getSVal(R);
847 if (report.isInteresting(V))
848 prunable = false;
849 }
850 }
851 }
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000852 Out << DR->getDecl()->getDeclName().getAsString();
853 if (quotes)
854 Out << '\'';
855 return quotes;
Ted Kremenek681bc112011-08-16 01:53:41 +0000856 }
857
858 if (const IntegerLiteral *IL = dyn_cast<IntegerLiteral>(Ex)) {
859 QualType OriginalTy = OriginalExpr->getType();
860 if (OriginalTy->isPointerType()) {
861 if (IL->getValue() == 0) {
862 Out << "null";
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000863 return false;
Ted Kremenek681bc112011-08-16 01:53:41 +0000864 }
865 }
866 else if (OriginalTy->isObjCObjectPointerType()) {
867 if (IL->getValue() == 0) {
868 Out << "nil";
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000869 return false;
Ted Kremenek681bc112011-08-16 01:53:41 +0000870 }
871 }
872
873 Out << IL->getValue();
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000874 return false;
Ted Kremenek681bc112011-08-16 01:53:41 +0000875 }
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000876
877 return false;
Ted Kremenek681bc112011-08-16 01:53:41 +0000878}
879
880PathDiagnosticPiece *
Anna Zaks50bbc162011-08-19 22:33:38 +0000881ConditionBRVisitor::VisitTrueTest(const Expr *Cond,
882 const BinaryOperator *BExpr,
883 const bool tookTrue,
Anna Zaks220ac8c2011-09-15 01:08:34 +0000884 BugReporterContext &BRC,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000885 BugReport &R,
886 const ExplodedNode *N) {
Ted Kremenek681bc112011-08-16 01:53:41 +0000887
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000888 bool shouldInvert = false;
Ted Kremenek76aadc32012-03-09 01:13:14 +0000889 llvm::Optional<bool> shouldPrune;
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000890
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000891 SmallString<128> LhsString, RhsString;
Ted Kremenek681bc112011-08-16 01:53:41 +0000892 {
Ted Kremenek76aadc32012-03-09 01:13:14 +0000893 llvm::raw_svector_ostream OutLHS(LhsString), OutRHS(RhsString);
894 const bool isVarLHS = patternMatch(BExpr->getLHS(), OutLHS, BRC, R, N,
895 shouldPrune);
896 const bool isVarRHS = patternMatch(BExpr->getRHS(), OutRHS, BRC, R, N,
897 shouldPrune);
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000898
899 shouldInvert = !isVarLHS && isVarRHS;
Ted Kremenek681bc112011-08-16 01:53:41 +0000900 }
901
Ted Kremenekd1247c52012-01-04 08:18:09 +0000902 BinaryOperator::Opcode Op = BExpr->getOpcode();
903
904 if (BinaryOperator::isAssignmentOp(Op)) {
905 // For assignment operators, all that we care about is that the LHS
906 // evaluates to "true" or "false".
907 return VisitConditionVariable(LhsString, BExpr->getLHS(), tookTrue,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000908 BRC, R, N);
Ted Kremenekd1247c52012-01-04 08:18:09 +0000909 }
910
911 // For non-assignment operations, we require that we can understand
912 // both the LHS and RHS.
Ted Kremenek681bc112011-08-16 01:53:41 +0000913 if (LhsString.empty() || RhsString.empty())
914 return 0;
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000915
Ted Kremenekd1247c52012-01-04 08:18:09 +0000916 // Should we invert the strings if the LHS is not a variable name?
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000917 SmallString<256> buf;
Ted Kremenek681bc112011-08-16 01:53:41 +0000918 llvm::raw_svector_ostream Out(buf);
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000919 Out << "Assuming " << (shouldInvert ? RhsString : LhsString) << " is ";
Ted Kremenek681bc112011-08-16 01:53:41 +0000920
921 // Do we need to invert the opcode?
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000922 if (shouldInvert)
923 switch (Op) {
924 default: break;
925 case BO_LT: Op = BO_GT; break;
926 case BO_GT: Op = BO_LT; break;
927 case BO_LE: Op = BO_GE; break;
928 case BO_GE: Op = BO_LE; break;
929 }
930
Ted Kremenek681bc112011-08-16 01:53:41 +0000931 if (!tookTrue)
932 switch (Op) {
933 case BO_EQ: Op = BO_NE; break;
934 case BO_NE: Op = BO_EQ; break;
935 case BO_LT: Op = BO_GE; break;
936 case BO_GT: Op = BO_LE; break;
937 case BO_LE: Op = BO_GT; break;
Ted Kremenek4ee7c9c2011-08-16 03:44:38 +0000938 case BO_GE: Op = BO_LT; break;
Ted Kremenek681bc112011-08-16 01:53:41 +0000939 default:
940 return 0;
941 }
942
Ted Kremenek6ae32572011-12-20 22:00:25 +0000943 switch (Op) {
Ted Kremenek681bc112011-08-16 01:53:41 +0000944 case BO_EQ:
945 Out << "equal to ";
946 break;
947 case BO_NE:
948 Out << "not equal to ";
949 break;
950 default:
951 Out << BinaryOperator::getOpcodeStr(Op) << ' ';
952 break;
953 }
954
Ted Kremenek3b9e8e42011-08-16 10:57:37 +0000955 Out << (shouldInvert ? LhsString : RhsString);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000956 const LocationContext *LCtx = N->getLocationContext();
957 PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
958 PathDiagnosticEventPiece *event =
959 new PathDiagnosticEventPiece(Loc, Out.str());
960 if (shouldPrune.hasValue())
961 event->setPrunable(shouldPrune.getValue());
962 return event;
Ted Kremenek993124e2011-08-06 06:54:45 +0000963}
Ted Kremenekd1247c52012-01-04 08:18:09 +0000964
965PathDiagnosticPiece *
966ConditionBRVisitor::VisitConditionVariable(StringRef LhsString,
967 const Expr *CondVarExpr,
968 const bool tookTrue,
969 BugReporterContext &BRC,
Ted Kremenek76aadc32012-03-09 01:13:14 +0000970 BugReport &report,
971 const ExplodedNode *N) {
Jordan Roseb0e1bad2012-08-03 23:08:54 +0000972 // FIXME: If there's already a constraint tracker for this variable,
973 // we shouldn't emit anything here (c.f. the double note in
974 // test/Analysis/inlining/path-notes.c)
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000975 SmallString<256> buf;
Ted Kremenekd1247c52012-01-04 08:18:09 +0000976 llvm::raw_svector_ostream Out(buf);
977 Out << "Assuming " << LhsString << " is ";
978
979 QualType Ty = CondVarExpr->getType();
980
981 if (Ty->isPointerType())
982 Out << (tookTrue ? "not null" : "null");
983 else if (Ty->isObjCObjectPointerType())
984 Out << (tookTrue ? "not nil" : "nil");
985 else if (Ty->isBooleanType())
986 Out << (tookTrue ? "true" : "false");
987 else if (Ty->isIntegerType())
988 Out << (tookTrue ? "non-zero" : "zero");
989 else
990 return 0;
991
Ted Kremenek76aadc32012-03-09 01:13:14 +0000992 const LocationContext *LCtx = N->getLocationContext();
993 PathDiagnosticLocation Loc(CondVarExpr, BRC.getSourceManager(), LCtx);
994 PathDiagnosticEventPiece *event =
995 new PathDiagnosticEventPiece(Loc, Out.str());
996
997 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(CondVarExpr)) {
998 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
999 const ProgramState *state = N->getState().getPtr();
1000 if (const MemRegion *R = state->getLValue(VD, LCtx).getAsRegion()) {
1001 if (report.isInteresting(R))
1002 event->setPrunable(false);
1003 }
1004 }
1005 }
1006
1007 return event;
Ted Kremenekd1247c52012-01-04 08:18:09 +00001008}
Ted Kremenek993124e2011-08-06 06:54:45 +00001009
1010PathDiagnosticPiece *
Anna Zaks50bbc162011-08-19 22:33:38 +00001011ConditionBRVisitor::VisitTrueTest(const Expr *Cond,
1012 const DeclRefExpr *DR,
1013 const bool tookTrue,
Anna Zaks220ac8c2011-09-15 01:08:34 +00001014 BugReporterContext &BRC,
Ted Kremenek76aadc32012-03-09 01:13:14 +00001015 BugReport &report,
1016 const ExplodedNode *N) {
Ted Kremenek993124e2011-08-06 06:54:45 +00001017
1018 const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl());
1019 if (!VD)
1020 return 0;
1021
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +00001022 SmallString<256> Buf;
Ted Kremenek993124e2011-08-06 06:54:45 +00001023 llvm::raw_svector_ostream Out(Buf);
1024
1025 Out << "Assuming '";
1026 VD->getDeclName().printName(Out);
1027 Out << "' is ";
1028
1029 QualType VDTy = VD->getType();
1030
1031 if (VDTy->isPointerType())
1032 Out << (tookTrue ? "non-null" : "null");
1033 else if (VDTy->isObjCObjectPointerType())
1034 Out << (tookTrue ? "non-nil" : "nil");
1035 else if (VDTy->isScalarType())
1036 Out << (tookTrue ? "not equal to 0" : "0");
1037 else
1038 return 0;
1039
Ted Kremenek76aadc32012-03-09 01:13:14 +00001040 const LocationContext *LCtx = N->getLocationContext();
1041 PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
1042 PathDiagnosticEventPiece *event =
1043 new PathDiagnosticEventPiece(Loc, Out.str());
1044
1045 const ProgramState *state = N->getState().getPtr();
1046 if (const MemRegion *R = state->getLValue(VD, LCtx).getAsRegion()) {
1047 if (report.isInteresting(R))
1048 event->setPrunable(false);
1049 else {
1050 SVal V = state->getSVal(R);
1051 if (report.isInteresting(V))
1052 event->setPrunable(false);
1053 }
1054 }
1055 return event;
Ted Kremenek993124e2011-08-06 06:54:45 +00001056}
Ted Kremenek0cf3d472012-02-07 00:24:33 +00001057
Anna Zaks80de4872012-08-29 21:22:37 +00001058PathDiagnosticPiece *
1059UndefOrNullArgVisitor::VisitNode(const ExplodedNode *N,
1060 const ExplodedNode *PrevN,
1061 BugReporterContext &BRC,
1062 BugReport &BR) {
1063
1064 ProgramStateRef State = N->getState();
1065 ProgramPoint ProgLoc = N->getLocation();
1066
1067 // We are only interested in visiting CallEnter nodes.
1068 CallEnter *CEnter = dyn_cast<CallEnter>(&ProgLoc);
1069 if (!CEnter)
1070 return 0;
1071
1072 // Check if one of the arguments is the region the visitor is tracking.
1073 CallEventManager &CEMgr = BRC.getStateManager().getCallEventManager();
1074 CallEventRef<> Call = CEMgr.getCaller(CEnter->getCalleeContext(), State);
1075 unsigned Idx = 0;
1076 for (CallEvent::param_iterator I = Call->param_begin(),
1077 E = Call->param_end(); I != E; ++I, ++Idx) {
1078 const MemRegion *ArgReg = Call->getArgSVal(Idx).getAsRegion();
1079
Anna Zaks522fc212012-09-12 22:57:30 +00001080 // Are we tracking the argument or its subregion?
1081 if ( !ArgReg || (ArgReg != R && !R->isSubRegionOf(ArgReg->StripCasts())))
Anna Zaks28694c12012-08-29 23:23:39 +00001082 continue;
Anna Zaks80de4872012-08-29 21:22:37 +00001083
1084 // Check the function parameter type.
1085 const ParmVarDecl *ParamDecl = *I;
1086 assert(ParamDecl && "Formal parameter has no decl?");
1087 QualType T = ParamDecl->getType();
1088
1089 if (!(T->isAnyPointerType() || T->isReferenceType())) {
1090 // Function can only change the value passed in by address.
Anna Zaks28694c12012-08-29 23:23:39 +00001091 continue;
Anna Zaks80de4872012-08-29 21:22:37 +00001092 }
1093
1094 // If it is a const pointer value, the function does not intend to
1095 // change the value.
1096 if (T->getPointeeType().isConstQualified())
Anna Zaks28694c12012-08-29 23:23:39 +00001097 continue;
Anna Zaks80de4872012-08-29 21:22:37 +00001098
1099 // Mark the call site (LocationContext) as interesting if the value of the
1100 // argument is undefined or '0'/'NULL'.
Anna Zaks522fc212012-09-12 22:57:30 +00001101 SVal BoundVal = State->getSVal(R);
Anna Zaks80de4872012-08-29 21:22:37 +00001102 if (BoundVal.isUndef() || BoundVal.isZeroConstant()) {
1103 BR.markInteresting(CEnter->getCalleeContext());
1104 return 0;
1105 }
1106 }
1107 return 0;
1108}