blob: 41cd80e01e0b2ef2add916ca2423d3d0ec1d4bf3 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Jordan Rose740d4902012-07-02 19:27:35 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/Calls.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000029#include <climits>
30
Zhongxing Xu589c0f22009-11-12 08:38:56 +000031using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000032using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033
34namespace {
35
Zhongxing Xu7fb14642009-12-11 00:55:44 +000036class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000037 enum Kind { // Reference to allocated memory.
38 Allocated,
39 // Reference to released/freed memory.
40 Released,
41 // Reference to escaped memory - no assumptions can be made of
42 // the state after the reference escapes.
43 Escaped,
44 // The responsibility for freeing resources has transfered from
45 // this reference. A relinquished symbol should not be freed.
Ted Kremenekdde201b2010-08-06 21:12:55 +000046 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000047 const Stmt *S;
48
Zhongxing Xu7fb14642009-12-11 00:55:44 +000049public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000050 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
51
Anna Zaks050cdd72012-06-20 20:57:46 +000052 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000053 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000054 bool isRelinquished() const { return K == Relinquished; }
Anna Zaksca23eb22012-02-29 18:42:47 +000055
Anna Zaksc8bb3be2012-02-13 18:05:39 +000056 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000057
58 bool operator==(const RefState &X) const {
59 return K == X.K && S == X.S;
60 }
61
Anna Zaks050cdd72012-06-20 20:57:46 +000062 static RefState getAllocated(const Stmt *s) {
63 return RefState(Allocated, s);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000064 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000065 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
66 static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000067 static RefState getRelinquished(const Stmt *s) {
68 return RefState(Relinquished, s);
69 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000070
71 void Profile(llvm::FoldingSetNodeID &ID) const {
72 ID.AddInteger(K);
73 ID.AddPointer(S);
74 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000075};
76
Anna Zaks40add292012-02-15 00:11:25 +000077struct ReallocPair {
78 SymbolRef ReallocatedSym;
79 bool IsFreeOnFailure;
80 ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {}
81 void Profile(llvm::FoldingSetNodeID &ID) const {
82 ID.AddInteger(IsFreeOnFailure);
83 ID.AddPointer(ReallocatedSym);
84 }
85 bool operator==(const ReallocPair &X) const {
86 return ReallocatedSym == X.ReallocatedSym &&
87 IsFreeOnFailure == X.IsFreeOnFailure;
88 }
89};
90
Anna Zaks3d7c44e2012-03-21 19:45:08 +000091typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
92
Anna Zaksb319e022012-02-08 20:13:28 +000093class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +000094 check::EndPath,
95 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +000096 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +000097 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +000098 check::PostStmt<BlockExpr>,
Anna Zaks5b7aa342012-06-22 02:04:31 +000099 check::PreObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000100 check::Location,
101 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +0000102 eval::Assume,
103 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000104{
Anna Zaksfebdc322012-02-16 22:26:12 +0000105 mutable OwningPtr<BugType> BT_DoubleFree;
106 mutable OwningPtr<BugType> BT_Leak;
107 mutable OwningPtr<BugType> BT_UseFree;
108 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000109 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000110 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
111
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000112public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000113 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000114 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000115
116 /// In pessimistic mode, the checker assumes that it does not know which
117 /// functions might free the memory.
118 struct ChecksFilter {
119 DefaultBool CMallocPessimistic;
120 DefaultBool CMallocOptimistic;
121 };
122
123 ChecksFilter Filter;
124
Anna Zaks66c40402012-02-14 21:55:24 +0000125 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000126 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Jordan Rosede507ea2012-07-02 19:28:04 +0000127 void checkPreObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000128 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000129 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000130 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000131 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000132 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000133 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000134 void checkLocation(SVal l, bool isLoad, const Stmt *S,
135 CheckerContext &C) const;
136 void checkBind(SVal location, SVal val, const Stmt*S,
137 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000138 ProgramStateRef
139 checkRegionChanges(ProgramStateRef state,
140 const StoreManager::InvalidatedSymbols *invalidated,
141 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000142 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +0000143 const CallEvent *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000144 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
145 return true;
146 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000147
Anna Zaks93c5a242012-05-02 00:05:20 +0000148 void printState(raw_ostream &Out, ProgramStateRef State,
149 const char *NL, const char *Sep) const;
150
Zhongxing Xu7b760962009-11-13 07:25:27 +0000151private:
Anna Zaks66c40402012-02-14 21:55:24 +0000152 void initIdentifierInfo(ASTContext &C) const;
153
154 /// Check if this is one of the functions which can allocate/reallocate memory
155 /// pointed to by one of its arguments.
156 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000157 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
158 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000159
Anna Zaks87cb5be2012-02-22 19:24:52 +0000160 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
161 const CallExpr *CE,
162 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000163 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000164 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000165 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000166 return MallocMemAux(C, CE,
167 state->getSVal(SizeEx, C.getLocationContext()),
168 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000169 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000170
Ted Kremenek8bef8232012-01-26 21:29:00 +0000171 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000172 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000173 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000174
Anna Zaks87cb5be2012-02-22 19:24:52 +0000175 /// Update the RefState to reflect the new memory allocation.
176 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
177 const CallExpr *CE,
178 ProgramStateRef state);
179
180 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
181 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000182 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000183 ProgramStateRef state, unsigned Num,
184 bool Hold) const;
185 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
186 const Expr *ParentExpr,
187 ProgramStateRef state,
188 bool Hold) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000189
Anna Zaks87cb5be2012-02-22 19:24:52 +0000190 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
191 bool FreesMemOnFailure) const;
192 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000193
Anna Zaks14345182012-05-18 01:16:10 +0000194 ///\brief Check if the memory associated with this symbol was released.
195 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
196
Anna Zaks91c2a112012-02-08 23:16:56 +0000197 bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const;
198 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
199 const Stmt *S = 0) const;
200
Anna Zaks66c40402012-02-14 21:55:24 +0000201 /// Check if the function is not known to us. So, for example, we could
202 /// conservatively assume it can free/reallocate it's pointer arguments.
Jordan Rose740d4902012-07-02 19:27:35 +0000203 bool doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000204 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000205
Ted Kremenek9c378f72011-08-12 23:37:29 +0000206 static bool SummarizeValue(raw_ostream &os, SVal V);
207 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000208 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000209
Anna Zaksca8e36e2012-02-23 21:38:21 +0000210 /// Find the location of the allocation for Sym on the path leading to the
211 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000212 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
213 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000214
Anna Zaksda046772012-02-11 21:02:40 +0000215 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
216
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000217 /// The bug visitor which allows us to print extra diagnostics along the
218 /// BugReport path. For example, showing the allocation site of the leaked
219 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000220 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000221 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000222 enum NotificationMode {
223 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000224 ReallocationFailed
225 };
226
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000227 // The allocated region symbol tracked by the main analysis.
228 SymbolRef Sym;
229
Anna Zaks88feba02012-05-10 01:37:40 +0000230 // The mode we are in, i.e. what kind of diagnostics will be emitted.
231 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000232
Anna Zaks88feba02012-05-10 01:37:40 +0000233 // A symbol from when the primary region should have been reallocated.
234 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000235
Anna Zaks88feba02012-05-10 01:37:40 +0000236 bool IsLeak;
237
238 public:
239 MallocBugVisitor(SymbolRef S, bool isLeak = false)
240 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000241
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000242 virtual ~MallocBugVisitor() {}
243
244 void Profile(llvm::FoldingSetNodeID &ID) const {
245 static int X = 0;
246 ID.AddPointer(&X);
247 ID.AddPointer(Sym);
248 }
249
Anna Zaksfe571602012-02-16 22:26:07 +0000250 inline bool isAllocated(const RefState *S, const RefState *SPrev,
251 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000252 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000253 return (Stmt && isa<CallExpr>(Stmt) &&
254 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000255 }
256
Anna Zaksfe571602012-02-16 22:26:07 +0000257 inline bool isReleased(const RefState *S, const RefState *SPrev,
258 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000259 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000260 return (Stmt && isa<CallExpr>(Stmt) &&
261 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
262 }
263
Anna Zaks5b7aa342012-06-22 02:04:31 +0000264 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
265 const Stmt *Stmt) {
266 // Did not track -> relinquished. Other state (allocated) -> relinquished.
267 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
268 isa<ObjCPropertyRefExpr>(Stmt)) &&
269 (S && S->isRelinquished()) &&
270 (!SPrev || !SPrev->isRelinquished()));
271 }
272
Anna Zaksfe571602012-02-16 22:26:07 +0000273 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
274 const Stmt *Stmt) {
275 // If the expression is not a call, and the state change is
276 // released -> allocated, it must be the realloc return value
277 // check. If we have to handle more cases here, it might be cleaner just
278 // to track this extra bit in the state itself.
279 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
280 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000281 }
282
283 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
284 const ExplodedNode *PrevN,
285 BugReporterContext &BRC,
286 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000287
288 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
289 const ExplodedNode *EndPathNode,
290 BugReport &BR) {
291 if (!IsLeak)
292 return 0;
293
294 PathDiagnosticLocation L =
295 PathDiagnosticLocation::createEndOfPath(EndPathNode,
296 BRC.getSourceManager());
297 // Do not add the statement itself as a range in case of leak.
298 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
299 }
300
Anna Zaks56a938f2012-03-16 23:24:20 +0000301 private:
302 class StackHintGeneratorForReallocationFailed
303 : public StackHintGeneratorForSymbol {
304 public:
305 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
306 : StackHintGeneratorForSymbol(S, M) {}
307
308 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
309 SmallString<200> buf;
310 llvm::raw_svector_ostream os(buf);
311
Anna Zaksfbd58742012-03-16 23:44:28 +0000312 os << "Reallocation of ";
Anna Zaks56a938f2012-03-16 23:24:20 +0000313 // Printed parameters start at 1, not 0.
314 printOrdinal(++ArgIndex, os);
315 os << " parameter failed";
316
317 return os.str();
318 }
319
320 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000321 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000322 }
323 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000324 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000325};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000326} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000327
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000328typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000329typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000330class RegionState {};
331class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000332namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000333namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000334 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000335 struct ProgramStateTrait<RegionState>
336 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000337 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000338 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000339
340 template <>
341 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000342 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000343 static void *GDMIndex() { static int x; return &x; }
344 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000345}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000346}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000347
Anna Zaks4fb54872012-02-11 21:02:35 +0000348namespace {
349class StopTrackingCallback : public SymbolVisitor {
350 ProgramStateRef state;
351public:
352 StopTrackingCallback(ProgramStateRef st) : state(st) {}
353 ProgramStateRef getState() const { return state; }
354
355 bool VisitSymbol(SymbolRef sym) {
356 state = state->remove<RegionState>(sym);
357 return true;
358 }
359};
360} // end anonymous namespace
361
Anna Zaks66c40402012-02-14 21:55:24 +0000362void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000363 if (II_malloc)
364 return;
365 II_malloc = &Ctx.Idents.get("malloc");
366 II_free = &Ctx.Idents.get("free");
367 II_realloc = &Ctx.Idents.get("realloc");
368 II_reallocf = &Ctx.Idents.get("reallocf");
369 II_calloc = &Ctx.Idents.get("calloc");
370 II_valloc = &Ctx.Idents.get("valloc");
371 II_strdup = &Ctx.Idents.get("strdup");
372 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000373}
374
Anna Zaks66c40402012-02-14 21:55:24 +0000375bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000376 if (isFreeFunction(FD, C))
377 return true;
378
379 if (isAllocationFunction(FD, C))
380 return true;
381
382 return false;
383}
384
385bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
386 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000387 if (!FD)
388 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000389
Anna Zaks66c40402012-02-14 21:55:24 +0000390 IdentifierInfo *FunI = FD->getIdentifier();
391 if (!FunI)
392 return false;
393
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000394 initIdentifierInfo(C);
395
Anna Zaks14345182012-05-18 01:16:10 +0000396 if (FunI == II_malloc || FunI == II_realloc ||
Anna Zaks60a1fa42012-02-22 03:14:20 +0000397 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
398 FunI == II_strdup || FunI == II_strndup)
Anna Zaks66c40402012-02-14 21:55:24 +0000399 return true;
400
Anna Zaks14345182012-05-18 01:16:10 +0000401 if (Filter.CMallocOptimistic && FD->hasAttrs())
402 for (specific_attr_iterator<OwnershipAttr>
403 i = FD->specific_attr_begin<OwnershipAttr>(),
404 e = FD->specific_attr_end<OwnershipAttr>();
405 i != e; ++i)
406 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
407 return true;
408 return false;
409}
410
411bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
412 if (!FD)
413 return false;
414
415 IdentifierInfo *FunI = FD->getIdentifier();
416 if (!FunI)
417 return false;
418
419 initIdentifierInfo(C);
420
421 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
Anna Zaks66c40402012-02-14 21:55:24 +0000422 return true;
423
Anna Zaks14345182012-05-18 01:16:10 +0000424 if (Filter.CMallocOptimistic && FD->hasAttrs())
425 for (specific_attr_iterator<OwnershipAttr>
426 i = FD->specific_attr_begin<OwnershipAttr>(),
427 e = FD->specific_attr_end<OwnershipAttr>();
428 i != e; ++i)
429 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
430 (*i)->getOwnKind() == OwnershipAttr::Holds)
431 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000432 return false;
433}
434
Anna Zaksb319e022012-02-08 20:13:28 +0000435void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
436 const FunctionDecl *FD = C.getCalleeDecl(CE);
437 if (!FD)
438 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000439
Anna Zaksb16ce452012-02-15 00:11:22 +0000440 initIdentifierInfo(C.getASTContext());
441 IdentifierInfo *FunI = FD->getIdentifier();
442 if (!FunI)
443 return;
444
Anna Zaks87cb5be2012-02-22 19:24:52 +0000445 ProgramStateRef State = C.getState();
Anna Zaksb16ce452012-02-15 00:11:22 +0000446 if (FunI == II_malloc || FunI == II_valloc) {
Anna Zaks259052d2012-04-10 23:41:11 +0000447 if (CE->getNumArgs() < 1)
448 return;
Anna Zaks87cb5be2012-02-22 19:24:52 +0000449 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anna Zaksb16ce452012-02-15 00:11:22 +0000450 } else if (FunI == II_realloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000451 State = ReallocMem(C, CE, false);
Anna Zaks40add292012-02-15 00:11:25 +0000452 } else if (FunI == II_reallocf) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000453 State = ReallocMem(C, CE, true);
Anna Zaksb16ce452012-02-15 00:11:22 +0000454 } else if (FunI == II_calloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000455 State = CallocMem(C, CE);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000456 } else if (FunI == II_free) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000457 State = FreeMemAux(C, CE, C.getState(), 0, false);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000458 } else if (FunI == II_strdup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000459 State = MallocUpdateRefState(C, CE, State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000460 } else if (FunI == II_strndup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000461 State = MallocUpdateRefState(C, CE, State);
462 } else if (Filter.CMallocOptimistic) {
463 // Check all the attributes, if there are any.
464 // There can be multiple of these attributes.
465 if (FD->hasAttrs())
466 for (specific_attr_iterator<OwnershipAttr>
467 i = FD->specific_attr_begin<OwnershipAttr>(),
468 e = FD->specific_attr_end<OwnershipAttr>();
469 i != e; ++i) {
470 switch ((*i)->getOwnKind()) {
471 case OwnershipAttr::Returns:
472 State = MallocMemReturnsAttr(C, CE, *i);
473 break;
474 case OwnershipAttr::Takes:
475 case OwnershipAttr::Holds:
476 State = FreeMemAttr(C, CE, *i);
477 break;
478 }
479 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000480 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000481 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000482}
483
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000484static bool isFreeWhenDoneSetToZero(const ObjCMethodCall &Call) {
485 Selector S = Call.getSelector();
Anna Zaks3e4f65d2012-06-22 22:08:09 +0000486 for (unsigned i = 1; i < S.getNumArgs(); ++i)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000487 if (S.getNameForSlot(i).equals("freeWhenDone"))
488 if (Call.getArgSVal(i).isConstant(0))
489 return true;
490
491 return false;
492}
493
Jordan Rosede507ea2012-07-02 19:28:04 +0000494void MallocChecker::checkPreObjCMessage(const ObjCMethodCall &Call,
Jordan Rose740d4902012-07-02 19:27:35 +0000495 CheckerContext &C) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000496 // If the first selector is dataWithBytesNoCopy, assume that the memory will
497 // be released with 'free' by the new object.
498 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
499 // Unless 'freeWhenDone' param set to 0.
500 // TODO: Check that the memory was allocated with malloc.
Jordan Rosede507ea2012-07-02 19:28:04 +0000501 Selector S = Call.getSelector();
Anna Zaks7186dc62012-06-22 22:42:30 +0000502 if ((S.getNameForSlot(0) == "dataWithBytesNoCopy" ||
503 S.getNameForSlot(0) == "initWithBytesNoCopy" ||
504 S.getNameForSlot(0) == "initWithCharactersNoCopy") &&
Jordan Rosecde8cdb2012-07-02 19:27:56 +0000505 !isFreeWhenDoneSetToZero(Call)){
Anna Zaks5b7aa342012-06-22 02:04:31 +0000506 unsigned int argIdx = 0;
Jordan Rose740d4902012-07-02 19:27:35 +0000507 C.addTransition(FreeMemAux(C, Call.getArgExpr(argIdx),
Jordan Rosede507ea2012-07-02 19:28:04 +0000508 Call.getOriginExpr(), C.getState(), true));
Anna Zaks5b7aa342012-06-22 02:04:31 +0000509 }
510}
511
Anna Zaks87cb5be2012-02-22 19:24:52 +0000512ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
513 const CallExpr *CE,
514 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000515 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000516 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000517
Sean Huntcf807c42010-08-18 23:23:40 +0000518 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000519 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000520 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000521 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000522 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000523}
524
Anna Zaksb319e022012-02-08 20:13:28 +0000525ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000526 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000527 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000528 ProgramStateRef state) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000529
530 // Bind the return value to the symbolic value from the heap region.
531 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
532 // side effects other than what we model here.
533 unsigned Count = C.getCurrentBlockCount();
534 SValBuilder &svalBuilder = C.getSValBuilder();
535 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
536 DefinedSVal RetVal =
537 cast<DefinedSVal>(svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count));
538 state = state->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000539
Anna Zaksb16ce452012-02-15 00:11:22 +0000540 // We expect the malloc functions to return a pointer.
Anna Zakse17fdb22012-06-07 03:57:32 +0000541 if (!isa<Loc>(RetVal))
Anna Zaksb16ce452012-02-15 00:11:22 +0000542 return 0;
543
Jordy Rose32f26562010-07-04 00:00:41 +0000544 // Fill the region with the initialization value.
Anna Zakse17fdb22012-06-07 03:57:32 +0000545 state = state->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000546
Jordy Rose32f26562010-07-04 00:00:41 +0000547 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000548 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000549 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000550 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000551 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000552 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000553 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000554 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
555 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
556 DefinedOrUnknownSVal extentMatchesSize =
557 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000558
Anna Zaks60a1fa42012-02-22 03:14:20 +0000559 state = state->assume(extentMatchesSize, true);
560 assert(state);
561 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000562
Anna Zaks87cb5be2012-02-22 19:24:52 +0000563 return MallocUpdateRefState(C, CE, state);
564}
565
566ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
567 const CallExpr *CE,
568 ProgramStateRef state) {
569 // Get the return value.
570 SVal retVal = state->getSVal(CE, C.getLocationContext());
571
572 // We expect the malloc functions to return a pointer.
573 if (!isa<Loc>(retVal))
574 return 0;
575
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000576 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000577 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000578
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000579 // Set the symbol's state to Allocated.
Anna Zaks050cdd72012-06-20 20:57:46 +0000580 return state->set<RegionState>(Sym, RefState::getAllocated(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000581
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000582}
583
Anna Zaks87cb5be2012-02-22 19:24:52 +0000584ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
585 const CallExpr *CE,
586 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000587 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000588 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000589
Anna Zaksb3d72752012-03-01 22:06:06 +0000590 ProgramStateRef State = C.getState();
591
Sean Huntcf807c42010-08-18 23:23:40 +0000592 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
593 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000594 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
595 Att->getOwnKind() == OwnershipAttr::Holds);
596 if (StateI)
597 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000598 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000599 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000600}
601
Ted Kremenek8bef8232012-01-26 21:29:00 +0000602ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000603 const CallExpr *CE,
604 ProgramStateRef state,
605 unsigned Num,
606 bool Hold) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000607 if (CE->getNumArgs() < (Num + 1))
608 return 0;
609
Anna Zaks5b7aa342012-06-22 02:04:31 +0000610 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold);
611}
612
613ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
614 const Expr *ArgExpr,
615 const Expr *ParentExpr,
616 ProgramStateRef state,
617 bool Hold) const {
618
Ted Kremenek5eca4822012-01-06 22:09:28 +0000619 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000620 if (!isa<DefinedOrUnknownSVal>(ArgVal))
621 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000622 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
623
624 // Check for null dereferences.
625 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000626 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000627
Anna Zaksb276bd92012-02-14 00:26:13 +0000628 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000629 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000630 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000631 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000632 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000633
Jordy Rose43859f62010-06-07 19:32:37 +0000634 // Unknown values could easily be okay
635 // Undefined values are handled elsewhere
636 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000637 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000638
Jordy Rose43859f62010-06-07 19:32:37 +0000639 const MemRegion *R = ArgVal.getAsRegion();
640
641 // Nonlocs can't be freed, of course.
642 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
643 if (!R) {
644 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000645 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000646 }
647
648 R = R->StripCasts();
649
650 // Blocks might show up as heap data, but should not be free()d
651 if (isa<BlockDataRegion>(R)) {
652 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000653 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000654 }
655
656 const MemSpaceRegion *MS = R->getMemorySpace();
657
658 // Parameters, locals, statics, and globals shouldn't be freed.
659 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
660 // FIXME: at the time this code was written, malloc() regions were
661 // represented by conjured symbols, which are all in UnknownSpaceRegion.
662 // This means that there isn't actually anything from HeapSpaceRegion
663 // that should be freed, even though we allow it here.
664 // Of course, free() can work on memory allocated outside the current
665 // function, so UnknownSpaceRegion is always a possibility.
666 // False negatives are better than false positives.
667
668 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000669 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000670 }
671
672 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
673 // Various cases could lead to non-symbol values here.
674 // For now, ignore them.
675 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000676 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000677
678 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000679 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000680
681 // If the symbol has not been tracked, return. This is possible when free() is
682 // called on a pointer that does not get its pointee directly from malloc().
683 // Full support of this requires inter-procedural analysis.
684 if (!RS)
Anna Zaksb319e022012-02-08 20:13:28 +0000685 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000686
687 // Check double free.
Anna Zaks050cdd72012-06-20 20:57:46 +0000688 if (RS->isReleased() || RS->isRelinquished()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000689 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000690 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000691 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000692 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000693 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000694 (RS->isReleased() ? "Attempt to free released memory" :
695 "Attempt to free non-owned memory"), N);
Anna Zaksfe571602012-02-16 22:26:07 +0000696 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000697 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000698 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000699 C.EmitReport(R);
700 }
Anna Zaksb319e022012-02-08 20:13:28 +0000701 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000702 }
703
704 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000705 if (Hold)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000706 return state->set<RegionState>(Sym, RefState::getRelinquished(ParentExpr));
707 return state->set<RegionState>(Sym, RefState::getReleased(ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000708}
709
Ted Kremenek9c378f72011-08-12 23:37:29 +0000710bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000711 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
712 os << "an integer (" << IntVal->getValue() << ")";
713 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
714 os << "a constant address (" << ConstAddr->getValue() << ")";
715 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000716 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000717 else
718 return false;
719
720 return true;
721}
722
Ted Kremenek9c378f72011-08-12 23:37:29 +0000723bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000724 const MemRegion *MR) {
725 switch (MR->getKind()) {
726 case MemRegion::FunctionTextRegionKind: {
727 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
728 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000729 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000730 else
731 os << "the address of a function";
732 return true;
733 }
734 case MemRegion::BlockTextRegionKind:
735 os << "block text";
736 return true;
737 case MemRegion::BlockDataRegionKind:
738 // FIXME: where the block came from?
739 os << "a block";
740 return true;
741 default: {
742 const MemSpaceRegion *MS = MR->getMemorySpace();
743
Anna Zakseb31a762012-01-04 23:54:01 +0000744 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000745 const VarRegion *VR = dyn_cast<VarRegion>(MR);
746 const VarDecl *VD;
747 if (VR)
748 VD = VR->getDecl();
749 else
750 VD = NULL;
751
752 if (VD)
753 os << "the address of the local variable '" << VD->getName() << "'";
754 else
755 os << "the address of a local stack variable";
756 return true;
757 }
Anna Zakseb31a762012-01-04 23:54:01 +0000758
759 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000760 const VarRegion *VR = dyn_cast<VarRegion>(MR);
761 const VarDecl *VD;
762 if (VR)
763 VD = VR->getDecl();
764 else
765 VD = NULL;
766
767 if (VD)
768 os << "the address of the parameter '" << VD->getName() << "'";
769 else
770 os << "the address of a parameter";
771 return true;
772 }
Anna Zakseb31a762012-01-04 23:54:01 +0000773
774 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000775 const VarRegion *VR = dyn_cast<VarRegion>(MR);
776 const VarDecl *VD;
777 if (VR)
778 VD = VR->getDecl();
779 else
780 VD = NULL;
781
782 if (VD) {
783 if (VD->isStaticLocal())
784 os << "the address of the static variable '" << VD->getName() << "'";
785 else
786 os << "the address of the global variable '" << VD->getName() << "'";
787 } else
788 os << "the address of a global variable";
789 return true;
790 }
Anna Zakseb31a762012-01-04 23:54:01 +0000791
792 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000793 }
794 }
795}
796
797void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000798 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000799 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000800 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000801 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000802
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000803 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000804 llvm::raw_svector_ostream os(buf);
805
806 const MemRegion *MR = ArgVal.getAsRegion();
807 if (MR) {
808 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
809 MR = ER->getSuperRegion();
810
811 // Special case for alloca()
812 if (isa<AllocaRegion>(MR))
813 os << "Argument to free() was allocated by alloca(), not malloc()";
814 else {
815 os << "Argument to free() is ";
816 if (SummarizeRegion(os, MR))
817 os << ", which is not memory allocated by malloc()";
818 else
819 os << "not memory allocated by malloc()";
820 }
821 } else {
822 os << "Argument to free() is ";
823 if (SummarizeValue(os, ArgVal))
824 os << ", which is not memory allocated by malloc()";
825 else
826 os << "not memory allocated by malloc()";
827 }
828
Anna Zakse172e8b2011-08-17 23:00:25 +0000829 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000830 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000831 R->addRange(range);
832 C.EmitReport(R);
833 }
834}
835
Anna Zaks87cb5be2012-02-22 19:24:52 +0000836ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
837 const CallExpr *CE,
838 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000839 if (CE->getNumArgs() < 2)
840 return 0;
841
Ted Kremenek8bef8232012-01-26 21:29:00 +0000842 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000843 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000844 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000845 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
846 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000847 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000848 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000849
Ted Kremenek846eabd2010-12-01 21:28:31 +0000850 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000851
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000852 DefinedOrUnknownSVal PtrEQ =
853 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000854
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000855 // Get the size argument. If there is no size arg then give up.
856 const Expr *Arg1 = CE->getArg(1);
857 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000858 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000859
860 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000861 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
862 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000863 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000864 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000865
866 // Compare the size argument to 0.
867 DefinedOrUnknownSVal SizeZero =
868 svalBuilder.evalEQ(state, Arg1Val,
869 svalBuilder.makeIntValWithPtrWidth(0, false));
870
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000871 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
872 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
873 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
874 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
875 // We only assume exceptional states if they are definitely true; if the
876 // state is under-constrained, assume regular realloc behavior.
877 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
878 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
879
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000880 // If the ptr is NULL and the size is not 0, the call is equivalent to
881 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000882 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000883 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000884 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000885 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000886 }
887
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000888 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000889 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000890
Anna Zaks30838b92012-02-13 20:57:07 +0000891 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000892 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000893 SymbolRef FromPtr = arg0Val.getAsSymbol();
894 SVal RetVal = state->getSVal(CE, LCtx);
895 SymbolRef ToPtr = RetVal.getAsSymbol();
896 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000897 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000898
899 // If the size is 0, free the memory.
900 if (SizeIsZero)
901 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000902 // The semantics of the return value are:
903 // If size was equal to 0, either NULL or a pointer suitable to be passed
904 // to free() is returned.
Anna Zaks40add292012-02-15 00:11:25 +0000905 stateFree = stateFree->set<ReallocPairs>(ToPtr,
906 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000907 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000908 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000909 }
910
911 // Default behavior.
912 if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) {
913 // FIXME: We should copy the content of the original buffer.
914 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
915 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000916 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000917 return 0;
Anna Zaks40add292012-02-15 00:11:25 +0000918 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
919 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000920 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000921 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000922 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000923 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000924}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000925
Anna Zaks87cb5be2012-02-22 19:24:52 +0000926ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000927 if (CE->getNumArgs() < 2)
928 return 0;
929
Ted Kremenek8bef8232012-01-26 21:29:00 +0000930 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000931 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000932 const LocationContext *LCtx = C.getLocationContext();
933 SVal count = state->getSVal(CE->getArg(0), LCtx);
934 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000935 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
936 svalBuilder.getContext().getSizeType());
937 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000938
Anna Zaks87cb5be2012-02-22 19:24:52 +0000939 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000940}
941
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000942LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000943MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
944 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000945 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000946 // Walk the ExplodedGraph backwards and find the first node that referred to
947 // the tracked symbol.
948 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000949 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000950
951 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000952 ProgramStateRef State = N->getState();
953 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000954 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000955
956 // Find the most recent expression bound to the symbol in the current
957 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000958 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000959 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
960 SVal Val = State->getSVal(MR);
961 if (Val.getAsLocSymbol() == Sym)
962 ReferenceRegion = MR;
963 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000964 }
965
Anna Zaks7752d292012-02-27 23:40:55 +0000966 // Allocation node, is the last node in the current context in which the
967 // symbol was tracked.
968 if (N->getLocationContext() == LeakContext)
969 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000970 N = N->pred_empty() ? NULL : *(N->pred_begin());
971 }
972
973 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000974 const Stmt *AllocationStmt = 0;
975 if (isa<StmtPoint>(P))
976 AllocationStmt = cast<StmtPoint>(P).getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000977
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000978 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000979}
980
Anna Zaksda046772012-02-11 21:02:40 +0000981void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
982 CheckerContext &C) const {
983 assert(N);
984 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +0000985 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +0000986 // Leaks should not be reported if they are post-dominated by a sink:
987 // (1) Sinks are higher importance bugs.
988 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
989 // with __noreturn functions such as assert() or exit(). We choose not
990 // to report leaks on such paths.
991 BT_Leak->setSuppressOnSink(true);
992 }
993
Anna Zaksca8e36e2012-02-23 21:38:21 +0000994 // Most bug reports are cached at the location where they occurred.
995 // With leaks, we want to unique them by the location where they were
996 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +0000997 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000998 const Stmt *AllocStmt = 0;
999 const MemRegion *Region = 0;
1000 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
1001 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +00001002 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
1003 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001004
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001005 SmallString<200> buf;
1006 llvm::raw_svector_ostream os(buf);
1007 os << "Memory is never released; potential leak";
1008 if (Region) {
1009 os << " of memory pointed to by '";
1010 Region->dumpPretty(os);
1011 os <<'\'';
1012 }
1013
1014 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001015 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001016 R->addVisitor(new MallocBugVisitor(Sym, true));
Anna Zaksda046772012-02-11 21:02:40 +00001017 C.EmitReport(R);
1018}
1019
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001020void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1021 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001022{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001023 if (!SymReaper.hasDeadSymbols())
1024 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001025
Ted Kremenek8bef8232012-01-26 21:29:00 +00001026 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001027 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001028 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001029
Ted Kremenek217470e2011-07-28 23:07:51 +00001030 bool generateReport = false;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001031 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001032 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1033 if (SymReaper.isDead(I->first)) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001034 if (I->second.isAllocated()) {
Ted Kremenek217470e2011-07-28 23:07:51 +00001035 generateReport = true;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001036 Errors.push_back(I->first);
1037 }
Jordy Rose90760142010-08-18 04:33:47 +00001038 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001039 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001040
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001041 }
1042 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001043
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001044 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +00001045 ReallocMap RP = state->get<ReallocPairs>();
1046 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
1047 if (SymReaper.isDead(I->first) ||
1048 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001049 state = state->remove<ReallocPairs>(I->first);
1050 }
1051 }
1052
Anna Zaksca8e36e2012-02-23 21:38:21 +00001053 // Generate leak node.
1054 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1055 ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Ted Kremenek217470e2011-07-28 23:07:51 +00001056
Anna Zaksca8e36e2012-02-23 21:38:21 +00001057 if (generateReport) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001058 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaksda046772012-02-11 21:02:40 +00001059 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
1060 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001061 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001062 }
Anna Zaksca8e36e2012-02-23 21:38:21 +00001063 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001064}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001065
Anna Zaksda046772012-02-11 21:02:40 +00001066void MallocChecker::checkEndPath(CheckerContext &C) const {
1067 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +00001068 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +00001069
Anna Zaksa19581a2012-02-20 22:25:23 +00001070 // If inside inlined call, skip it.
1071 if (C.getLocationContext()->getParent() != 0)
1072 return;
1073
Jordy Rose09cef092010-08-18 04:26:59 +00001074 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +00001075 RefState RS = I->second;
1076 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +00001077 ExplodedNode *N = C.addTransition(state);
1078 if (N)
1079 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +00001080 }
1081 }
1082}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001083
Anna Zaks91c2a112012-02-08 23:16:56 +00001084bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S,
1085 CheckerContext &C) const {
Ted Kremenek8bef8232012-01-26 21:29:00 +00001086 ProgramStateRef state = C.getState();
Anna Zaks91c2a112012-02-08 23:16:56 +00001087 const RefState *RS = state->get<RegionState>(Sym);
1088 if (!RS)
1089 return false;
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001090
Anna Zaks91c2a112012-02-08 23:16:56 +00001091 if (RS->isAllocated()) {
1092 state = state->set<RegionState>(Sym, RefState::getEscaped(S));
1093 C.addTransition(state);
1094 return true;
1095 }
1096 return false;
1097}
1098
Anna Zaks66c40402012-02-14 21:55:24 +00001099void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001100 // We will check for double free in the post visit.
1101 if (isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001102 return;
1103
1104 // Check use after free, when a freed pointer is passed to a call.
1105 ProgramStateRef State = C.getState();
1106 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1107 E = CE->arg_end(); I != E; ++I) {
1108 const Expr *A = *I;
1109 if (A->getType().getTypePtr()->isAnyPointerType()) {
1110 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1111 if (!Sym)
1112 continue;
1113 if (checkUseAfterFree(Sym, C, A))
1114 return;
1115 }
1116 }
1117}
1118
Anna Zaks91c2a112012-02-08 23:16:56 +00001119void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1120 const Expr *E = S->getRetValue();
1121 if (!E)
1122 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001123
1124 // Check if we are returning a symbol.
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001125 SVal RetVal = C.getState()->getSVal(E, C.getLocationContext());
1126 SymbolRef Sym = RetVal.getAsSymbol();
1127 if (!Sym)
1128 // If we are returning a field of the allocated struct or an array element,
1129 // the callee could still free the memory.
1130 // TODO: This logic should be a part of generic symbol escape callback.
1131 if (const MemRegion *MR = RetVal.getAsRegion())
1132 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1133 if (const SymbolicRegion *BMR =
1134 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1135 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001136 if (!Sym)
1137 return;
1138
Anna Zaks0860cd02012-02-11 21:44:39 +00001139 // Check if we are returning freed memory.
Anna Zaksfe571602012-02-16 22:26:07 +00001140 if (checkUseAfterFree(Sym, C, E))
Anna Zaks15d0ae12012-02-11 23:46:36 +00001141 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001142
Anna Zaksa19581a2012-02-20 22:25:23 +00001143 // If this function body is not inlined, check if the symbol is escaping.
1144 if (C.getLocationContext()->getParent() == 0)
1145 checkEscape(Sym, E, C);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001146}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001147
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001148// TODO: Blocks should be either inlined or should call invalidate regions
1149// upon invocation. After that's in place, special casing here will not be
1150// needed.
1151void MallocChecker::checkPostStmt(const BlockExpr *BE,
1152 CheckerContext &C) const {
1153
1154 // Scan the BlockDecRefExprs for any object the retain count checker
1155 // may be tracking.
1156 if (!BE->getBlockDecl()->hasCaptures())
1157 return;
1158
1159 ProgramStateRef state = C.getState();
1160 const BlockDataRegion *R =
1161 cast<BlockDataRegion>(state->getSVal(BE,
1162 C.getLocationContext()).getAsRegion());
1163
1164 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1165 E = R->referenced_vars_end();
1166
1167 if (I == E)
1168 return;
1169
1170 SmallVector<const MemRegion*, 10> Regions;
1171 const LocationContext *LC = C.getLocationContext();
1172 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1173
1174 for ( ; I != E; ++I) {
1175 const VarRegion *VR = *I;
1176 if (VR->getSuperRegion() == R) {
1177 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1178 }
1179 Regions.push_back(VR);
1180 }
1181
1182 state =
1183 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1184 Regions.data() + Regions.size()).getState();
1185 C.addTransition(state);
1186}
1187
Anna Zaks14345182012-05-18 01:16:10 +00001188bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001189 assert(Sym);
1190 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001191 return (RS && RS->isReleased());
1192}
1193
1194bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1195 const Stmt *S) const {
1196 if (isReleased(Sym, C)) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001197 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001198 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001199 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001200
Anna Zaksfebdc322012-02-16 22:26:12 +00001201 BugReport *R = new BugReport(*BT_UseFree,
1202 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001203 if (S)
1204 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001205 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001206 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001207 C.EmitReport(R);
1208 return true;
1209 }
1210 }
1211 return false;
1212}
1213
Zhongxing Xuc8023782010-03-10 04:58:55 +00001214// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001215void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1216 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001217 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001218 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001219 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001220}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001221
Anna Zaks4fb54872012-02-11 21:02:35 +00001222//===----------------------------------------------------------------------===//
1223// Check various ways a symbol can be invalidated.
1224// TODO: This logic (the next 3 functions) is copied/similar to the
1225// RetainRelease checker. We might want to factor this out.
1226//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001227
Anna Zaks4fb54872012-02-11 21:02:35 +00001228// Stop tracking symbols when a value escapes as a result of checkBind.
1229// A value escapes in three possible cases:
1230// (1) we are binding to something that is not a memory region.
1231// (2) we are binding to a memregion that does not have stack storage
1232// (3) we are binding to a memregion with stack storage that the store
1233// does not understand.
1234void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1235 CheckerContext &C) const {
1236 // Are we storing to something that causes the value to "escape"?
1237 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001238 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001239
Anna Zaks4fb54872012-02-11 21:02:35 +00001240 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1241 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001242
Anna Zaks4fb54872012-02-11 21:02:35 +00001243 if (!escapes) {
1244 // To test (3), generate a new state with the binding added. If it is
1245 // the same state, then it escapes (since the store cannot represent
1246 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001247 // Do this only if we know that the store is not supposed to generate the
1248 // same state.
1249 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1250 if (StoredVal != val)
1251 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001252 }
Anna Zaksac593002012-02-16 03:40:57 +00001253 if (!escapes) {
1254 // Case 4: We do not currently model what happens when a symbol is
1255 // assigned to a struct field, so be conservative here and let the symbol
1256 // go. TODO: This could definitely be improved upon.
1257 escapes = !isa<VarRegion>(regionLoc->getRegion());
1258 }
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001259 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001260
1261 // If our store can represent the binding and we aren't storing to something
1262 // that doesn't have local storage then just return and have the simulation
1263 // state continue as is.
1264 if (!escapes)
1265 return;
1266
1267 // Otherwise, find all symbols referenced by 'val' that we are tracking
1268 // and stop tracking them.
1269 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1270 C.addTransition(state);
1271}
1272
1273// If a symbolic region is assumed to NULL (or another constant), stop tracking
1274// it - assuming that allocation failed on this path.
1275ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1276 SVal Cond,
1277 bool Assumption) const {
1278 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001279 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1280 // If the symbol is assumed to NULL or another constant, this will
1281 // return an APSInt*.
1282 if (state->getSymVal(I.getKey()))
1283 state = state->remove<RegionState>(I.getKey());
1284 }
1285
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001286 // Realloc returns 0 when reallocation fails, which means that we should
1287 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001288 ReallocMap RP = state->get<ReallocPairs>();
1289 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001290 // If the symbol is assumed to NULL or another constant, this will
1291 // return an APSInt*.
1292 if (state->getSymVal(I.getKey())) {
Anna Zaks40add292012-02-15 00:11:25 +00001293 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1294 const RefState *RS = state->get<RegionState>(ReallocSym);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001295 if (RS) {
Anna Zaks40add292012-02-15 00:11:25 +00001296 if (RS->isReleased() && ! I.getData().IsFreeOnFailure)
1297 state = state->set<RegionState>(ReallocSym,
Anna Zaks050cdd72012-06-20 20:57:46 +00001298 RefState::getAllocated(RS->getStmt()));
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001299 }
1300 state = state->remove<ReallocPairs>(I.getKey());
1301 }
1302 }
1303
Anna Zaks4fb54872012-02-11 21:02:35 +00001304 return state;
1305}
1306
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001307// Check if the function is known to us. So, for example, we could
Jordan Rose740d4902012-07-02 19:27:35 +00001308// conservatively assume it can free/reallocate its pointer arguments.
Anna Zaks66c40402012-02-14 21:55:24 +00001309// (We assume that the pointers cannot escape through calls to system
1310// functions not handled by this checker.)
Jordan Rose740d4902012-07-02 19:27:35 +00001311bool MallocChecker::doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001312 ProgramStateRef State) const {
Jordan Rose85d7e012012-07-02 19:27:51 +00001313 assert(Call);
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001314
1315 // For now, assume that any C++ call can free memory.
1316 // TODO: If we want to be more optimistic here, we'll need to make sure that
1317 // regions escape to C++ containers. They seem to do that even now, but for
1318 // mysterious reasons.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001319 if (!(isa<FunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001320 return false;
1321
Jordan Rose740d4902012-07-02 19:27:35 +00001322 // Check Objective-C messages by selector name.
Jordan Rosecde8cdb2012-07-02 19:27:56 +00001323 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose85d7e012012-07-02 19:27:51 +00001324 // If it's not a framework call, or if it takes a callback, assume it
1325 // can free memory.
1326 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaks07d39a42012-02-28 01:54:22 +00001327 return false;
1328
Jordan Rose740d4902012-07-02 19:27:35 +00001329 Selector S = Msg->getSelector();
Anna Zaks52a04812012-06-20 23:35:57 +00001330
Jordan Rose740d4902012-07-02 19:27:35 +00001331 // Whitelist the ObjC methods which do free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001332 // - Anything containing 'freeWhenDone' param set to 1.
1333 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
Anna Zaks3e4f65d2012-06-22 22:08:09 +00001334 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001335 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1336 if (Call->getArgSVal(i).isConstant(1))
1337 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001338 else
1339 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001340 }
1341 }
1342
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001343 // If the first selector ends with NoCopy, assume that the ownership is
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001344 // transferred as well.
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001345 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
Jordan Rose740d4902012-07-02 19:27:35 +00001346 StringRef FirstSlot = S.getNameForSlot(0);
1347 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001348 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001349
Anna Zaks5f757682012-06-19 05:10:32 +00001350 // If the first selector starts with addPointer, insertPointer,
1351 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1352 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001353 // that the pointers get freed by following the container itself.
1354 if (FirstSlot.startswith("addPointer") ||
1355 FirstSlot.startswith("insertPointer") ||
1356 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001357 return false;
1358 }
1359
Jordan Rose740d4902012-07-02 19:27:35 +00001360 // Otherwise, assume that the method does not free memory.
1361 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001362 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001363 }
1364
Jordan Rose740d4902012-07-02 19:27:35 +00001365 // At this point the only thing left to handle is straight function calls.
1366 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1367 if (!FD)
1368 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001369
Jordan Rose740d4902012-07-02 19:27:35 +00001370 ASTContext &ASTC = State->getStateManager().getContext();
1371
1372 // If it's one of the allocation functions we can reason about, we model
1373 // its behavior explicitly.
1374 if (isMemFunction(FD, ASTC))
1375 return true;
1376
1377 // If it's not a system call, assume it frees memory.
1378 if (!Call->isInSystemHeader())
1379 return false;
1380
1381 // White list the system functions whose arguments escape.
1382 const IdentifierInfo *II = FD->getIdentifier();
1383 if (!II)
1384 return false;
1385 StringRef FName = II->getName();
1386
Jordan Rose740d4902012-07-02 19:27:35 +00001387 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose85d7e012012-07-02 19:27:51 +00001388 // We specifically check these before
Jordan Rose740d4902012-07-02 19:27:35 +00001389 if (FName.endswith("NoCopy")) {
1390 // Look for the deallocator argument. We know that the memory ownership
1391 // is not transferred only if the deallocator argument is
1392 // 'kCFAllocatorNull'.
1393 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1394 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1395 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1396 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1397 if (DeallocatorName == "kCFAllocatorNull")
1398 return true;
1399 }
1400 }
1401 return false;
1402 }
1403
Jordan Rose740d4902012-07-02 19:27:35 +00001404 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose85d7e012012-07-02 19:27:51 +00001405 // 'closefn' is specified (and if that function does free memory),
1406 // but it will not if closefn is not specified.
Jordan Rose740d4902012-07-02 19:27:35 +00001407 // Currently, we do not inspect the 'closefn' function (PR12101).
1408 if (FName == "funopen")
Jordan Rose85d7e012012-07-02 19:27:51 +00001409 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
1410 return true;
Jordan Rose740d4902012-07-02 19:27:35 +00001411
1412 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1413 // these leaks might be intentional when setting the buffer for stdio.
1414 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1415 if (FName == "setbuf" || FName =="setbuffer" ||
1416 FName == "setlinebuf" || FName == "setvbuf") {
1417 if (Call->getNumArgs() >= 1) {
1418 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1419 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1420 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1421 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1422 return false;
1423 }
1424 }
1425
1426 // A bunch of other functions which either take ownership of a pointer or
1427 // wrap the result up in a struct or object, meaning it can be freed later.
1428 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1429 // but the Malloc checker cannot differentiate between them. The right way
1430 // of doing this would be to implement a pointer escapes callback.
1431 if (FName == "CGBitmapContextCreate" ||
1432 FName == "CGBitmapContextCreateWithData" ||
1433 FName == "CVPixelBufferCreateWithBytes" ||
1434 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1435 FName == "OSAtomicEnqueue") {
1436 return false;
1437 }
1438
Jordan Rose85d7e012012-07-02 19:27:51 +00001439 // Handle cases where we know a buffer's /address/ can escape.
1440 // Note that the above checks handle some special cases where we know that
1441 // even though the address escapes, it's still our responsibility to free the
1442 // buffer.
1443 if (Call->argumentsMayEscape())
Jordan Rose740d4902012-07-02 19:27:35 +00001444 return false;
1445
1446 // Otherwise, assume that the function does not free memory.
1447 // Most system calls do not free the memory.
1448 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001449}
1450
Anna Zaks4fb54872012-02-11 21:02:35 +00001451// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1452// escapes, when we are tracking p), do not track the symbol as we cannot reason
1453// about it anymore.
1454ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001455MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001456 const StoreManager::InvalidatedSymbols *invalidated,
1457 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001458 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +00001459 const CallEvent *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001460 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001461 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001462 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001463
Anna Zaks66c40402012-02-14 21:55:24 +00001464 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001465 // regions (explicit and implicit) escaped.
1466
1467 // Otherwise, whitelist explicit pointers; we still can track them.
1468 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001469 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1470 E = ExplicitRegions.end(); I != E; ++I) {
1471 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1472 WhitelistedSymbols.insert(R->getSymbol());
1473 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001474 }
1475
1476 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1477 E = invalidated->end(); I!=E; ++I) {
1478 SymbolRef sym = *I;
1479 if (WhitelistedSymbols.count(sym))
1480 continue;
Anna Zaks5b7aa342012-06-22 02:04:31 +00001481 // The symbol escaped. Note, we assume that if the symbol is released,
1482 // passing it out will result in a use after free. We also keep tracking
1483 // relinquished symbols.
1484 if (const RefState *RS = State->get<RegionState>(sym)) {
1485 if (RS->isAllocated())
1486 State = State->set<RegionState>(sym,
1487 RefState::getEscaped(RS->getStmt()));
1488 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001489 }
Anna Zaks66c40402012-02-14 21:55:24 +00001490 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001491}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001492
Jordy Rose393f98b2012-03-18 07:43:35 +00001493static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1494 ProgramStateRef prevState) {
1495 ReallocMap currMap = currState->get<ReallocPairs>();
1496 ReallocMap prevMap = prevState->get<ReallocPairs>();
1497
1498 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1499 I != E; ++I) {
1500 SymbolRef sym = I.getKey();
1501 if (!currMap.lookup(sym))
1502 return sym;
1503 }
1504
1505 return NULL;
1506}
1507
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001508PathDiagnosticPiece *
1509MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1510 const ExplodedNode *PrevN,
1511 BugReporterContext &BRC,
1512 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001513 ProgramStateRef state = N->getState();
1514 ProgramStateRef statePrev = PrevN->getState();
1515
1516 const RefState *RS = state->get<RegionState>(Sym);
1517 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001518 if (!RS && !RSPrev)
1519 return 0;
1520
Anna Zaksfe571602012-02-16 22:26:07 +00001521 const Stmt *S = 0;
1522 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001523 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001524
1525 // Retrieve the associated statement.
1526 ProgramPoint ProgLoc = N->getLocation();
1527 if (isa<StmtPoint>(ProgLoc))
1528 S = cast<StmtPoint>(ProgLoc).getStmt();
1529 // If an assumption was made on a branch, it should be caught
1530 // here by looking at the state transition.
1531 if (isa<BlockEdge>(ProgLoc)) {
1532 const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc();
1533 S = srcBlk->getTerminator();
1534 }
1535 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001536 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001537
1538 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001539 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001540 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001541 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001542 StackHint = new StackHintGeneratorForSymbol(Sym,
1543 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001544 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001545 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001546 StackHint = new StackHintGeneratorForSymbol(Sym,
1547 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00001548 } else if (isRelinquished(RS, RSPrev, S)) {
1549 Msg = "Memory ownership is transfered";
1550 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00001551 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001552 Mode = ReallocationFailed;
1553 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001554 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001555 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001556
Jordy Roseb000fb52012-03-24 03:15:09 +00001557 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1558 // Is it possible to fail two reallocs WITHOUT testing in between?
1559 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1560 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001561 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001562 FailedReallocSymbol = sym;
1563 }
Anna Zaksfe571602012-02-16 22:26:07 +00001564 }
1565
1566 // We are in a special mode if a reallocation failed later in the path.
1567 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001568 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001569
Jordy Roseb000fb52012-03-24 03:15:09 +00001570 // Is this is the first appearance of the reallocated symbol?
1571 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
1572 // If we ever hit this assert, that means BugReporter has decided to skip
1573 // node pairs or visit them out of order.
1574 assert(state->get<RegionState>(FailedReallocSymbol) &&
1575 "Missed the reallocation point");
1576
1577 // We're at the reallocation point.
1578 Msg = "Attempt to reallocate memory";
1579 StackHint = new StackHintGeneratorForSymbol(Sym,
1580 "Returned reallocated memory");
1581 FailedReallocSymbol = NULL;
1582 Mode = Normal;
1583 }
Anna Zaksfe571602012-02-16 22:26:07 +00001584 }
1585
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001586 if (!Msg)
1587 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001588 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001589
1590 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001591 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001592 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001593 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001594}
1595
Anna Zaks93c5a242012-05-02 00:05:20 +00001596void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1597 const char *NL, const char *Sep) const {
1598
1599 RegionStateTy RS = State->get<RegionState>();
1600
1601 if (!RS.isEmpty())
1602 Out << "Has Malloc data" << NL;
1603}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001604
Anna Zaks231361a2012-02-08 23:16:52 +00001605#define REGISTER_CHECKER(name) \
1606void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001607 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001608 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001609}
Anna Zaks231361a2012-02-08 23:16:52 +00001610
1611REGISTER_CHECKER(MallocPessimistic)
1612REGISTER_CHECKER(MallocOptimistic)