blob: e6b522496250373ea1700ceaf8bf801fbff7b66a [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
2 *
3 * This program is free software; you can redistribute it and/or
4 * modify it under the terms of version 2 of the GNU General Public
5 * License as published by the Free Software Foundation.
6 *
7 * This program is distributed in the hope that it will be useful, but
8 * WITHOUT ANY WARRANTY; without even the implied warranty of
9 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
10 * General Public License for more details.
11 */
12#include <linux/kernel.h>
13#include <linux/types.h>
14#include <linux/slab.h>
15#include <linux/bpf.h>
16#include <linux/filter.h>
17#include <net/netlink.h>
18#include <linux/file.h>
19#include <linux/vmalloc.h>
20
21/* bpf_check() is a static code analyzer that walks eBPF program
22 * instruction by instruction and updates register/stack state.
23 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
24 *
25 * The first pass is depth-first-search to check that the program is a DAG.
26 * It rejects the following programs:
27 * - larger than BPF_MAXINSNS insns
28 * - if loop is present (detected via back-edge)
29 * - unreachable insns exist (shouldn't be a forest. program = one function)
30 * - out of bounds or malformed jumps
31 * The second pass is all possible path descent from the 1st insn.
32 * Since it's analyzing all pathes through the program, the length of the
33 * analysis is limited to 32k insn, which may be hit even if total number of
34 * insn is less then 4K, but there are too many branches that change stack/regs.
35 * Number of 'branches to be analyzed' is limited to 1k
36 *
37 * On entry to each instruction, each register has a type, and the instruction
38 * changes the types of the registers depending on instruction semantics.
39 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
40 * copied to R1.
41 *
42 * All registers are 64-bit.
43 * R0 - return register
44 * R1-R5 argument passing registers
45 * R6-R9 callee saved registers
46 * R10 - frame pointer read-only
47 *
48 * At the start of BPF program the register R1 contains a pointer to bpf_context
49 * and has type PTR_TO_CTX.
50 *
51 * Verifier tracks arithmetic operations on pointers in case:
52 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
53 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
54 * 1st insn copies R10 (which has FRAME_PTR) type into R1
55 * and 2nd arithmetic instruction is pattern matched to recognize
56 * that it wants to construct a pointer to some element within stack.
57 * So after 2nd insn, the register R1 has type PTR_TO_STACK
58 * (and -20 constant is saved for further stack bounds checking).
59 * Meaning that this reg is a pointer to stack plus known immediate constant.
60 *
61 * Most of the time the registers have UNKNOWN_VALUE type, which
62 * means the register has some value, but it's not a valid pointer.
63 * (like pointer plus pointer becomes UNKNOWN_VALUE type)
64 *
65 * When verifier sees load or store instructions the type of base register
66 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, FRAME_PTR. These are three pointer
67 * types recognized by check_mem_access() function.
68 *
69 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
70 * and the range of [ptr, ptr + map's value_size) is accessible.
71 *
72 * registers used to pass values to function calls are checked against
73 * function argument constraints.
74 *
75 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
76 * It means that the register type passed to this function must be
77 * PTR_TO_STACK and it will be used inside the function as
78 * 'pointer to map element key'
79 *
80 * For example the argument constraints for bpf_map_lookup_elem():
81 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
82 * .arg1_type = ARG_CONST_MAP_PTR,
83 * .arg2_type = ARG_PTR_TO_MAP_KEY,
84 *
85 * ret_type says that this function returns 'pointer to map elem value or null'
86 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
87 * 2nd argument should be a pointer to stack, which will be used inside
88 * the helper function as a pointer to map element key.
89 *
90 * On the kernel side the helper function looks like:
91 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
92 * {
93 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
94 * void *key = (void *) (unsigned long) r2;
95 * void *value;
96 *
97 * here kernel can access 'key' and 'map' pointers safely, knowing that
98 * [key, key + map->key_size) bytes are valid and were initialized on
99 * the stack of eBPF program.
100 * }
101 *
102 * Corresponding eBPF program may look like:
103 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
104 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
105 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
106 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
107 * here verifier looks at prototype of map_lookup_elem() and sees:
108 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
109 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
110 *
111 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
112 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
113 * and were initialized prior to this call.
114 * If it's ok, then verifier allows this BPF_CALL insn and looks at
115 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
116 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
117 * returns ether pointer to map value or NULL.
118 *
119 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
120 * insn, the register holding that pointer in the true branch changes state to
121 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
122 * branch. See check_cond_jmp_op().
123 *
124 * After the call R0 is set to return type of the function and registers R1-R5
125 * are set to NOT_INIT to indicate that they are no longer readable.
126 */
127
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700128/* types of values stored in eBPF registers */
129enum bpf_reg_type {
130 NOT_INIT = 0, /* nothing was written into register */
131 UNKNOWN_VALUE, /* reg doesn't contain a valid pointer */
132 PTR_TO_CTX, /* reg points to bpf_context */
133 CONST_PTR_TO_MAP, /* reg points to struct bpf_map */
134 PTR_TO_MAP_VALUE, /* reg points to map element value */
135 PTR_TO_MAP_VALUE_OR_NULL,/* points to map elem value or NULL */
136 FRAME_PTR, /* reg == frame_pointer */
137 PTR_TO_STACK, /* reg == frame_pointer + imm */
138 CONST_IMM, /* constant integer value */
139};
140
141struct reg_state {
142 enum bpf_reg_type type;
143 union {
144 /* valid when type == CONST_IMM | PTR_TO_STACK */
145 int imm;
146
147 /* valid when type == CONST_PTR_TO_MAP | PTR_TO_MAP_VALUE |
148 * PTR_TO_MAP_VALUE_OR_NULL
149 */
150 struct bpf_map *map_ptr;
151 };
152};
153
154enum bpf_stack_slot_type {
155 STACK_INVALID, /* nothing was stored in this stack slot */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700156 STACK_SPILL, /* register spilled into stack */
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700157 STACK_MISC /* BPF program wrote some data into this slot */
158};
159
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700160#define BPF_REG_SIZE 8 /* size of eBPF register in bytes */
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700161
162/* state of the program:
163 * type of all registers and stack info
164 */
165struct verifier_state {
166 struct reg_state regs[MAX_BPF_REG];
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700167 u8 stack_slot_type[MAX_BPF_STACK];
168 struct reg_state spilled_regs[MAX_BPF_STACK / BPF_REG_SIZE];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700169};
170
171/* linked list of verifier states used to prune search */
172struct verifier_state_list {
173 struct verifier_state state;
174 struct verifier_state_list *next;
175};
176
177/* verifier_state + insn_idx are pushed to stack when branch is encountered */
178struct verifier_stack_elem {
179 /* verifer state is 'st'
180 * before processing instruction 'insn_idx'
181 * and after processing instruction 'prev_insn_idx'
182 */
183 struct verifier_state st;
184 int insn_idx;
185 int prev_insn_idx;
186 struct verifier_stack_elem *next;
187};
188
Alexei Starovoitov0246e642014-09-26 00:17:04 -0700189#define MAX_USED_MAPS 64 /* max number of maps accessed by one eBPF program */
190
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700191/* single container for all structs
192 * one verifier_env per bpf_check() call
193 */
194struct verifier_env {
Alexei Starovoitov0246e642014-09-26 00:17:04 -0700195 struct bpf_prog *prog; /* eBPF program being verified */
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700196 struct verifier_stack_elem *head; /* stack of verifier states to be processed */
197 int stack_size; /* number of states to be processed */
198 struct verifier_state cur_state; /* current verifier state */
Alexei Starovoitovf1bca822014-09-29 18:50:01 -0700199 struct verifier_state_list **explored_states; /* search pruning optimization */
Alexei Starovoitov0246e642014-09-26 00:17:04 -0700200 struct bpf_map *used_maps[MAX_USED_MAPS]; /* array of map's used by eBPF program */
201 u32 used_map_cnt; /* number of used maps */
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700202};
203
204/* verbose verifier prints what it's seeing
205 * bpf_check() is called under lock, so no race to access these global vars
206 */
207static u32 log_level, log_size, log_len;
208static char *log_buf;
209
210static DEFINE_MUTEX(bpf_verifier_lock);
211
212/* log_level controls verbosity level of eBPF verifier.
213 * verbose() is used to dump the verification trace to the log, so the user
214 * can figure out what's wrong with the program
215 */
216static void verbose(const char *fmt, ...)
217{
218 va_list args;
219
220 if (log_level == 0 || log_len >= log_size - 1)
221 return;
222
223 va_start(args, fmt);
224 log_len += vscnprintf(log_buf + log_len, log_size - log_len, fmt, args);
225 va_end(args);
226}
227
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700228/* string representation of 'enum bpf_reg_type' */
229static const char * const reg_type_str[] = {
230 [NOT_INIT] = "?",
231 [UNKNOWN_VALUE] = "inv",
232 [PTR_TO_CTX] = "ctx",
233 [CONST_PTR_TO_MAP] = "map_ptr",
234 [PTR_TO_MAP_VALUE] = "map_value",
235 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
236 [FRAME_PTR] = "fp",
237 [PTR_TO_STACK] = "fp",
238 [CONST_IMM] = "imm",
239};
240
241static void print_verifier_state(struct verifier_env *env)
242{
243 enum bpf_reg_type t;
244 int i;
245
246 for (i = 0; i < MAX_BPF_REG; i++) {
247 t = env->cur_state.regs[i].type;
248 if (t == NOT_INIT)
249 continue;
250 verbose(" R%d=%s", i, reg_type_str[t]);
251 if (t == CONST_IMM || t == PTR_TO_STACK)
252 verbose("%d", env->cur_state.regs[i].imm);
253 else if (t == CONST_PTR_TO_MAP || t == PTR_TO_MAP_VALUE ||
254 t == PTR_TO_MAP_VALUE_OR_NULL)
255 verbose("(ks=%d,vs=%d)",
256 env->cur_state.regs[i].map_ptr->key_size,
257 env->cur_state.regs[i].map_ptr->value_size);
258 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700259 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
260 if (env->cur_state.stack_slot_type[i] == STACK_SPILL)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700261 verbose(" fp%d=%s", -MAX_BPF_STACK + i,
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700262 reg_type_str[env->cur_state.spilled_regs[i / BPF_REG_SIZE].type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700263 }
264 verbose("\n");
265}
266
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700267static const char *const bpf_class_string[] = {
268 [BPF_LD] = "ld",
269 [BPF_LDX] = "ldx",
270 [BPF_ST] = "st",
271 [BPF_STX] = "stx",
272 [BPF_ALU] = "alu",
273 [BPF_JMP] = "jmp",
274 [BPF_RET] = "BUG",
275 [BPF_ALU64] = "alu64",
276};
277
278static const char *const bpf_alu_string[] = {
279 [BPF_ADD >> 4] = "+=",
280 [BPF_SUB >> 4] = "-=",
281 [BPF_MUL >> 4] = "*=",
282 [BPF_DIV >> 4] = "/=",
283 [BPF_OR >> 4] = "|=",
284 [BPF_AND >> 4] = "&=",
285 [BPF_LSH >> 4] = "<<=",
286 [BPF_RSH >> 4] = ">>=",
287 [BPF_NEG >> 4] = "neg",
288 [BPF_MOD >> 4] = "%=",
289 [BPF_XOR >> 4] = "^=",
290 [BPF_MOV >> 4] = "=",
291 [BPF_ARSH >> 4] = "s>>=",
292 [BPF_END >> 4] = "endian",
293};
294
295static const char *const bpf_ldst_string[] = {
296 [BPF_W >> 3] = "u32",
297 [BPF_H >> 3] = "u16",
298 [BPF_B >> 3] = "u8",
299 [BPF_DW >> 3] = "u64",
300};
301
302static const char *const bpf_jmp_string[] = {
303 [BPF_JA >> 4] = "jmp",
304 [BPF_JEQ >> 4] = "==",
305 [BPF_JGT >> 4] = ">",
306 [BPF_JGE >> 4] = ">=",
307 [BPF_JSET >> 4] = "&",
308 [BPF_JNE >> 4] = "!=",
309 [BPF_JSGT >> 4] = "s>",
310 [BPF_JSGE >> 4] = "s>=",
311 [BPF_CALL >> 4] = "call",
312 [BPF_EXIT >> 4] = "exit",
313};
314
315static void print_bpf_insn(struct bpf_insn *insn)
316{
317 u8 class = BPF_CLASS(insn->code);
318
319 if (class == BPF_ALU || class == BPF_ALU64) {
320 if (BPF_SRC(insn->code) == BPF_X)
321 verbose("(%02x) %sr%d %s %sr%d\n",
322 insn->code, class == BPF_ALU ? "(u32) " : "",
323 insn->dst_reg,
324 bpf_alu_string[BPF_OP(insn->code) >> 4],
325 class == BPF_ALU ? "(u32) " : "",
326 insn->src_reg);
327 else
328 verbose("(%02x) %sr%d %s %s%d\n",
329 insn->code, class == BPF_ALU ? "(u32) " : "",
330 insn->dst_reg,
331 bpf_alu_string[BPF_OP(insn->code) >> 4],
332 class == BPF_ALU ? "(u32) " : "",
333 insn->imm);
334 } else if (class == BPF_STX) {
335 if (BPF_MODE(insn->code) == BPF_MEM)
336 verbose("(%02x) *(%s *)(r%d %+d) = r%d\n",
337 insn->code,
338 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
339 insn->dst_reg,
340 insn->off, insn->src_reg);
341 else if (BPF_MODE(insn->code) == BPF_XADD)
342 verbose("(%02x) lock *(%s *)(r%d %+d) += r%d\n",
343 insn->code,
344 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
345 insn->dst_reg, insn->off,
346 insn->src_reg);
347 else
348 verbose("BUG_%02x\n", insn->code);
349 } else if (class == BPF_ST) {
350 if (BPF_MODE(insn->code) != BPF_MEM) {
351 verbose("BUG_st_%02x\n", insn->code);
352 return;
353 }
354 verbose("(%02x) *(%s *)(r%d %+d) = %d\n",
355 insn->code,
356 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
357 insn->dst_reg,
358 insn->off, insn->imm);
359 } else if (class == BPF_LDX) {
360 if (BPF_MODE(insn->code) != BPF_MEM) {
361 verbose("BUG_ldx_%02x\n", insn->code);
362 return;
363 }
364 verbose("(%02x) r%d = *(%s *)(r%d %+d)\n",
365 insn->code, insn->dst_reg,
366 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
367 insn->src_reg, insn->off);
368 } else if (class == BPF_LD) {
369 if (BPF_MODE(insn->code) == BPF_ABS) {
370 verbose("(%02x) r0 = *(%s *)skb[%d]\n",
371 insn->code,
372 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
373 insn->imm);
374 } else if (BPF_MODE(insn->code) == BPF_IND) {
375 verbose("(%02x) r0 = *(%s *)skb[r%d + %d]\n",
376 insn->code,
377 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
378 insn->src_reg, insn->imm);
379 } else if (BPF_MODE(insn->code) == BPF_IMM) {
380 verbose("(%02x) r%d = 0x%x\n",
381 insn->code, insn->dst_reg, insn->imm);
382 } else {
383 verbose("BUG_ld_%02x\n", insn->code);
384 return;
385 }
386 } else if (class == BPF_JMP) {
387 u8 opcode = BPF_OP(insn->code);
388
389 if (opcode == BPF_CALL) {
390 verbose("(%02x) call %d\n", insn->code, insn->imm);
391 } else if (insn->code == (BPF_JMP | BPF_JA)) {
392 verbose("(%02x) goto pc%+d\n",
393 insn->code, insn->off);
394 } else if (insn->code == (BPF_JMP | BPF_EXIT)) {
395 verbose("(%02x) exit\n", insn->code);
396 } else if (BPF_SRC(insn->code) == BPF_X) {
397 verbose("(%02x) if r%d %s r%d goto pc%+d\n",
398 insn->code, insn->dst_reg,
399 bpf_jmp_string[BPF_OP(insn->code) >> 4],
400 insn->src_reg, insn->off);
401 } else {
402 verbose("(%02x) if r%d %s 0x%x goto pc%+d\n",
403 insn->code, insn->dst_reg,
404 bpf_jmp_string[BPF_OP(insn->code) >> 4],
405 insn->imm, insn->off);
406 }
407 } else {
408 verbose("(%02x) %s\n", insn->code, bpf_class_string[class]);
409 }
410}
411
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700412static int pop_stack(struct verifier_env *env, int *prev_insn_idx)
413{
414 struct verifier_stack_elem *elem;
415 int insn_idx;
416
417 if (env->head == NULL)
418 return -1;
419
420 memcpy(&env->cur_state, &env->head->st, sizeof(env->cur_state));
421 insn_idx = env->head->insn_idx;
422 if (prev_insn_idx)
423 *prev_insn_idx = env->head->prev_insn_idx;
424 elem = env->head->next;
425 kfree(env->head);
426 env->head = elem;
427 env->stack_size--;
428 return insn_idx;
429}
430
431static struct verifier_state *push_stack(struct verifier_env *env, int insn_idx,
432 int prev_insn_idx)
433{
434 struct verifier_stack_elem *elem;
435
436 elem = kmalloc(sizeof(struct verifier_stack_elem), GFP_KERNEL);
437 if (!elem)
438 goto err;
439
440 memcpy(&elem->st, &env->cur_state, sizeof(env->cur_state));
441 elem->insn_idx = insn_idx;
442 elem->prev_insn_idx = prev_insn_idx;
443 elem->next = env->head;
444 env->head = elem;
445 env->stack_size++;
446 if (env->stack_size > 1024) {
447 verbose("BPF program is too complex\n");
448 goto err;
449 }
450 return &elem->st;
451err:
452 /* pop all elements and return */
453 while (pop_stack(env, NULL) >= 0);
454 return NULL;
455}
456
457#define CALLER_SAVED_REGS 6
458static const int caller_saved[CALLER_SAVED_REGS] = {
459 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
460};
461
462static void init_reg_state(struct reg_state *regs)
463{
464 int i;
465
466 for (i = 0; i < MAX_BPF_REG; i++) {
467 regs[i].type = NOT_INIT;
468 regs[i].imm = 0;
469 regs[i].map_ptr = NULL;
470 }
471
472 /* frame pointer */
473 regs[BPF_REG_FP].type = FRAME_PTR;
474
475 /* 1st arg to a function */
476 regs[BPF_REG_1].type = PTR_TO_CTX;
477}
478
479static void mark_reg_unknown_value(struct reg_state *regs, u32 regno)
480{
481 BUG_ON(regno >= MAX_BPF_REG);
482 regs[regno].type = UNKNOWN_VALUE;
483 regs[regno].imm = 0;
484 regs[regno].map_ptr = NULL;
485}
486
487enum reg_arg_type {
488 SRC_OP, /* register is used as source operand */
489 DST_OP, /* register is used as destination operand */
490 DST_OP_NO_MARK /* same as above, check only, don't mark */
491};
492
493static int check_reg_arg(struct reg_state *regs, u32 regno,
494 enum reg_arg_type t)
495{
496 if (regno >= MAX_BPF_REG) {
497 verbose("R%d is invalid\n", regno);
498 return -EINVAL;
499 }
500
501 if (t == SRC_OP) {
502 /* check whether register used as source operand can be read */
503 if (regs[regno].type == NOT_INIT) {
504 verbose("R%d !read_ok\n", regno);
505 return -EACCES;
506 }
507 } else {
508 /* check whether register used as dest operand can be written to */
509 if (regno == BPF_REG_FP) {
510 verbose("frame pointer is read only\n");
511 return -EACCES;
512 }
513 if (t == DST_OP)
514 mark_reg_unknown_value(regs, regno);
515 }
516 return 0;
517}
518
519static int bpf_size_to_bytes(int bpf_size)
520{
521 if (bpf_size == BPF_W)
522 return 4;
523 else if (bpf_size == BPF_H)
524 return 2;
525 else if (bpf_size == BPF_B)
526 return 1;
527 else if (bpf_size == BPF_DW)
528 return 8;
529 else
530 return -EINVAL;
531}
532
533/* check_stack_read/write functions track spill/fill of registers,
534 * stack boundary and alignment are checked in check_mem_access()
535 */
536static int check_stack_write(struct verifier_state *state, int off, int size,
537 int value_regno)
538{
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700539 int i;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700540 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
541 * so it's aligned access and [off, off + size) are within stack limits
542 */
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700543
544 if (value_regno >= 0 &&
545 (state->regs[value_regno].type == PTR_TO_MAP_VALUE ||
546 state->regs[value_regno].type == PTR_TO_STACK ||
547 state->regs[value_regno].type == PTR_TO_CTX)) {
548
549 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700550 if (size != BPF_REG_SIZE) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700551 verbose("invalid size of register spill\n");
552 return -EACCES;
553 }
554
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700555 /* save register state */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700556 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE] =
557 state->regs[value_regno];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700558
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700559 for (i = 0; i < BPF_REG_SIZE; i++)
560 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_SPILL;
561 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700562 /* regular write of data into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700563 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE] =
564 (struct reg_state) {};
565
566 for (i = 0; i < size; i++)
567 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_MISC;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700568 }
569 return 0;
570}
571
572static int check_stack_read(struct verifier_state *state, int off, int size,
573 int value_regno)
574{
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700575 u8 *slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700576 int i;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700577
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700578 slot_type = &state->stack_slot_type[MAX_BPF_STACK + off];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700579
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700580 if (slot_type[0] == STACK_SPILL) {
581 if (size != BPF_REG_SIZE) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700582 verbose("invalid size of register spill\n");
583 return -EACCES;
584 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700585 for (i = 1; i < BPF_REG_SIZE; i++) {
586 if (slot_type[i] != STACK_SPILL) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700587 verbose("corrupted spill memory\n");
588 return -EACCES;
589 }
590 }
591
592 if (value_regno >= 0)
593 /* restore register state from stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700594 state->regs[value_regno] =
595 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700596 return 0;
597 } else {
598 for (i = 0; i < size; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700599 if (slot_type[i] != STACK_MISC) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700600 verbose("invalid read from stack off %d+%d size %d\n",
601 off, i, size);
602 return -EACCES;
603 }
604 }
605 if (value_regno >= 0)
606 /* have read misc data from the stack */
607 mark_reg_unknown_value(state->regs, value_regno);
608 return 0;
609 }
610}
611
612/* check read/write into map element returned by bpf_map_lookup_elem() */
613static int check_map_access(struct verifier_env *env, u32 regno, int off,
614 int size)
615{
616 struct bpf_map *map = env->cur_state.regs[regno].map_ptr;
617
618 if (off < 0 || off + size > map->value_size) {
619 verbose("invalid access to map value, value_size=%d off=%d size=%d\n",
620 map->value_size, off, size);
621 return -EACCES;
622 }
623 return 0;
624}
625
626/* check access to 'struct bpf_context' fields */
627static int check_ctx_access(struct verifier_env *env, int off, int size,
628 enum bpf_access_type t)
629{
630 if (env->prog->aux->ops->is_valid_access &&
631 env->prog->aux->ops->is_valid_access(off, size, t))
632 return 0;
633
634 verbose("invalid bpf_context access off=%d size=%d\n", off, size);
635 return -EACCES;
636}
637
638/* check whether memory at (regno + off) is accessible for t = (read | write)
639 * if t==write, value_regno is a register which value is stored into memory
640 * if t==read, value_regno is a register which will receive the value from memory
641 * if t==write && value_regno==-1, some unknown value is stored into memory
642 * if t==read && value_regno==-1, don't care what we read from memory
643 */
644static int check_mem_access(struct verifier_env *env, u32 regno, int off,
645 int bpf_size, enum bpf_access_type t,
646 int value_regno)
647{
648 struct verifier_state *state = &env->cur_state;
649 int size, err = 0;
650
651 size = bpf_size_to_bytes(bpf_size);
652 if (size < 0)
653 return size;
654
655 if (off % size != 0) {
656 verbose("misaligned access off %d size %d\n", off, size);
657 return -EACCES;
658 }
659
660 if (state->regs[regno].type == PTR_TO_MAP_VALUE) {
661 err = check_map_access(env, regno, off, size);
662 if (!err && t == BPF_READ && value_regno >= 0)
663 mark_reg_unknown_value(state->regs, value_regno);
664
665 } else if (state->regs[regno].type == PTR_TO_CTX) {
666 err = check_ctx_access(env, off, size, t);
667 if (!err && t == BPF_READ && value_regno >= 0)
668 mark_reg_unknown_value(state->regs, value_regno);
669
670 } else if (state->regs[regno].type == FRAME_PTR) {
671 if (off >= 0 || off < -MAX_BPF_STACK) {
672 verbose("invalid stack off=%d size=%d\n", off, size);
673 return -EACCES;
674 }
675 if (t == BPF_WRITE)
676 err = check_stack_write(state, off, size, value_regno);
677 else
678 err = check_stack_read(state, off, size, value_regno);
679 } else {
680 verbose("R%d invalid mem access '%s'\n",
681 regno, reg_type_str[state->regs[regno].type]);
682 return -EACCES;
683 }
684 return err;
685}
686
687static int check_xadd(struct verifier_env *env, struct bpf_insn *insn)
688{
689 struct reg_state *regs = env->cur_state.regs;
690 int err;
691
692 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
693 insn->imm != 0) {
694 verbose("BPF_XADD uses reserved fields\n");
695 return -EINVAL;
696 }
697
698 /* check src1 operand */
699 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
700 if (err)
701 return err;
702
703 /* check src2 operand */
704 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
705 if (err)
706 return err;
707
708 /* check whether atomic_add can read the memory */
709 err = check_mem_access(env, insn->dst_reg, insn->off,
710 BPF_SIZE(insn->code), BPF_READ, -1);
711 if (err)
712 return err;
713
714 /* check whether atomic_add can write into the same memory */
715 return check_mem_access(env, insn->dst_reg, insn->off,
716 BPF_SIZE(insn->code), BPF_WRITE, -1);
717}
718
719/* when register 'regno' is passed into function that will read 'access_size'
720 * bytes from that pointer, make sure that it's within stack boundary
721 * and all elements of stack are initialized
722 */
723static int check_stack_boundary(struct verifier_env *env,
724 int regno, int access_size)
725{
726 struct verifier_state *state = &env->cur_state;
727 struct reg_state *regs = state->regs;
728 int off, i;
729
730 if (regs[regno].type != PTR_TO_STACK)
731 return -EACCES;
732
733 off = regs[regno].imm;
734 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
735 access_size <= 0) {
736 verbose("invalid stack type R%d off=%d access_size=%d\n",
737 regno, off, access_size);
738 return -EACCES;
739 }
740
741 for (i = 0; i < access_size; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700742 if (state->stack_slot_type[MAX_BPF_STACK + off + i] != STACK_MISC) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700743 verbose("invalid indirect read from stack off %d+%d size %d\n",
744 off, i, access_size);
745 return -EACCES;
746 }
747 }
748 return 0;
749}
750
751static int check_func_arg(struct verifier_env *env, u32 regno,
752 enum bpf_arg_type arg_type, struct bpf_map **mapp)
753{
754 struct reg_state *reg = env->cur_state.regs + regno;
755 enum bpf_reg_type expected_type;
756 int err = 0;
757
Daniel Borkmann80f1d682015-03-12 17:21:42 +0100758 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700759 return 0;
760
761 if (reg->type == NOT_INIT) {
762 verbose("R%d !read_ok\n", regno);
763 return -EACCES;
764 }
765
Daniel Borkmann80f1d682015-03-12 17:21:42 +0100766 if (arg_type == ARG_ANYTHING)
767 return 0;
768
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700769 if (arg_type == ARG_PTR_TO_STACK || arg_type == ARG_PTR_TO_MAP_KEY ||
770 arg_type == ARG_PTR_TO_MAP_VALUE) {
771 expected_type = PTR_TO_STACK;
772 } else if (arg_type == ARG_CONST_STACK_SIZE) {
773 expected_type = CONST_IMM;
774 } else if (arg_type == ARG_CONST_MAP_PTR) {
775 expected_type = CONST_PTR_TO_MAP;
776 } else {
777 verbose("unsupported arg_type %d\n", arg_type);
778 return -EFAULT;
779 }
780
781 if (reg->type != expected_type) {
782 verbose("R%d type=%s expected=%s\n", regno,
783 reg_type_str[reg->type], reg_type_str[expected_type]);
784 return -EACCES;
785 }
786
787 if (arg_type == ARG_CONST_MAP_PTR) {
788 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
789 *mapp = reg->map_ptr;
790
791 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
792 /* bpf_map_xxx(..., map_ptr, ..., key) call:
793 * check that [key, key + map->key_size) are within
794 * stack limits and initialized
795 */
796 if (!*mapp) {
797 /* in function declaration map_ptr must come before
798 * map_key, so that it's verified and known before
799 * we have to check map_key here. Otherwise it means
800 * that kernel subsystem misconfigured verifier
801 */
802 verbose("invalid map_ptr to access map->key\n");
803 return -EACCES;
804 }
805 err = check_stack_boundary(env, regno, (*mapp)->key_size);
806
807 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
808 /* bpf_map_xxx(..., map_ptr, ..., value) call:
809 * check [value, value + map->value_size) validity
810 */
811 if (!*mapp) {
812 /* kernel subsystem misconfigured verifier */
813 verbose("invalid map_ptr to access map->value\n");
814 return -EACCES;
815 }
816 err = check_stack_boundary(env, regno, (*mapp)->value_size);
817
818 } else if (arg_type == ARG_CONST_STACK_SIZE) {
819 /* bpf_xxx(..., buf, len) call will access 'len' bytes
820 * from stack pointer 'buf'. Check it
821 * note: regno == len, regno - 1 == buf
822 */
823 if (regno == 0) {
824 /* kernel subsystem misconfigured verifier */
825 verbose("ARG_CONST_STACK_SIZE cannot be first argument\n");
826 return -EACCES;
827 }
828 err = check_stack_boundary(env, regno - 1, reg->imm);
829 }
830
831 return err;
832}
833
834static int check_call(struct verifier_env *env, int func_id)
835{
836 struct verifier_state *state = &env->cur_state;
837 const struct bpf_func_proto *fn = NULL;
838 struct reg_state *regs = state->regs;
839 struct bpf_map *map = NULL;
840 struct reg_state *reg;
841 int i, err;
842
843 /* find function prototype */
844 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
845 verbose("invalid func %d\n", func_id);
846 return -EINVAL;
847 }
848
849 if (env->prog->aux->ops->get_func_proto)
850 fn = env->prog->aux->ops->get_func_proto(func_id);
851
852 if (!fn) {
853 verbose("unknown func %d\n", func_id);
854 return -EINVAL;
855 }
856
857 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +0100858 if (!env->prog->gpl_compatible && fn->gpl_only) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700859 verbose("cannot call GPL only function from proprietary program\n");
860 return -EINVAL;
861 }
862
863 /* check args */
864 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &map);
865 if (err)
866 return err;
867 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &map);
868 if (err)
869 return err;
870 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &map);
871 if (err)
872 return err;
873 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &map);
874 if (err)
875 return err;
876 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &map);
877 if (err)
878 return err;
879
880 /* reset caller saved regs */
881 for (i = 0; i < CALLER_SAVED_REGS; i++) {
882 reg = regs + caller_saved[i];
883 reg->type = NOT_INIT;
884 reg->imm = 0;
885 }
886
887 /* update return register */
888 if (fn->ret_type == RET_INTEGER) {
889 regs[BPF_REG_0].type = UNKNOWN_VALUE;
890 } else if (fn->ret_type == RET_VOID) {
891 regs[BPF_REG_0].type = NOT_INIT;
892 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
893 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
894 /* remember map_ptr, so that check_map_access()
895 * can check 'value_size' boundary of memory access
896 * to map element returned from bpf_map_lookup_elem()
897 */
898 if (map == NULL) {
899 verbose("kernel subsystem misconfigured verifier\n");
900 return -EINVAL;
901 }
902 regs[BPF_REG_0].map_ptr = map;
903 } else {
904 verbose("unknown return type %d of func %d\n",
905 fn->ret_type, func_id);
906 return -EINVAL;
907 }
908 return 0;
909}
910
911/* check validity of 32-bit and 64-bit arithmetic operations */
912static int check_alu_op(struct reg_state *regs, struct bpf_insn *insn)
913{
914 u8 opcode = BPF_OP(insn->code);
915 int err;
916
917 if (opcode == BPF_END || opcode == BPF_NEG) {
918 if (opcode == BPF_NEG) {
919 if (BPF_SRC(insn->code) != 0 ||
920 insn->src_reg != BPF_REG_0 ||
921 insn->off != 0 || insn->imm != 0) {
922 verbose("BPF_NEG uses reserved fields\n");
923 return -EINVAL;
924 }
925 } else {
926 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
927 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64)) {
928 verbose("BPF_END uses reserved fields\n");
929 return -EINVAL;
930 }
931 }
932
933 /* check src operand */
934 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
935 if (err)
936 return err;
937
938 /* check dest operand */
939 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
940 if (err)
941 return err;
942
943 } else if (opcode == BPF_MOV) {
944
945 if (BPF_SRC(insn->code) == BPF_X) {
946 if (insn->imm != 0 || insn->off != 0) {
947 verbose("BPF_MOV uses reserved fields\n");
948 return -EINVAL;
949 }
950
951 /* check src operand */
952 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
953 if (err)
954 return err;
955 } else {
956 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
957 verbose("BPF_MOV uses reserved fields\n");
958 return -EINVAL;
959 }
960 }
961
962 /* check dest operand */
963 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
964 if (err)
965 return err;
966
967 if (BPF_SRC(insn->code) == BPF_X) {
968 if (BPF_CLASS(insn->code) == BPF_ALU64) {
969 /* case: R1 = R2
970 * copy register state to dest reg
971 */
972 regs[insn->dst_reg] = regs[insn->src_reg];
973 } else {
974 regs[insn->dst_reg].type = UNKNOWN_VALUE;
975 regs[insn->dst_reg].map_ptr = NULL;
976 }
977 } else {
978 /* case: R = imm
979 * remember the value we stored into this reg
980 */
981 regs[insn->dst_reg].type = CONST_IMM;
982 regs[insn->dst_reg].imm = insn->imm;
983 }
984
985 } else if (opcode > BPF_END) {
986 verbose("invalid BPF_ALU opcode %x\n", opcode);
987 return -EINVAL;
988
989 } else { /* all other ALU ops: and, sub, xor, add, ... */
990
991 bool stack_relative = false;
992
993 if (BPF_SRC(insn->code) == BPF_X) {
994 if (insn->imm != 0 || insn->off != 0) {
995 verbose("BPF_ALU uses reserved fields\n");
996 return -EINVAL;
997 }
998 /* check src1 operand */
999 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1000 if (err)
1001 return err;
1002 } else {
1003 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1004 verbose("BPF_ALU uses reserved fields\n");
1005 return -EINVAL;
1006 }
1007 }
1008
1009 /* check src2 operand */
1010 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1011 if (err)
1012 return err;
1013
1014 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
1015 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
1016 verbose("div by zero\n");
1017 return -EINVAL;
1018 }
1019
1020 /* pattern match 'bpf_add Rx, imm' instruction */
1021 if (opcode == BPF_ADD && BPF_CLASS(insn->code) == BPF_ALU64 &&
1022 regs[insn->dst_reg].type == FRAME_PTR &&
1023 BPF_SRC(insn->code) == BPF_K)
1024 stack_relative = true;
1025
1026 /* check dest operand */
1027 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1028 if (err)
1029 return err;
1030
1031 if (stack_relative) {
1032 regs[insn->dst_reg].type = PTR_TO_STACK;
1033 regs[insn->dst_reg].imm = insn->imm;
1034 }
1035 }
1036
1037 return 0;
1038}
1039
1040static int check_cond_jmp_op(struct verifier_env *env,
1041 struct bpf_insn *insn, int *insn_idx)
1042{
1043 struct reg_state *regs = env->cur_state.regs;
1044 struct verifier_state *other_branch;
1045 u8 opcode = BPF_OP(insn->code);
1046 int err;
1047
1048 if (opcode > BPF_EXIT) {
1049 verbose("invalid BPF_JMP opcode %x\n", opcode);
1050 return -EINVAL;
1051 }
1052
1053 if (BPF_SRC(insn->code) == BPF_X) {
1054 if (insn->imm != 0) {
1055 verbose("BPF_JMP uses reserved fields\n");
1056 return -EINVAL;
1057 }
1058
1059 /* check src1 operand */
1060 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1061 if (err)
1062 return err;
1063 } else {
1064 if (insn->src_reg != BPF_REG_0) {
1065 verbose("BPF_JMP uses reserved fields\n");
1066 return -EINVAL;
1067 }
1068 }
1069
1070 /* check src2 operand */
1071 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1072 if (err)
1073 return err;
1074
1075 /* detect if R == 0 where R was initialized to zero earlier */
1076 if (BPF_SRC(insn->code) == BPF_K &&
1077 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
1078 regs[insn->dst_reg].type == CONST_IMM &&
1079 regs[insn->dst_reg].imm == insn->imm) {
1080 if (opcode == BPF_JEQ) {
1081 /* if (imm == imm) goto pc+off;
1082 * only follow the goto, ignore fall-through
1083 */
1084 *insn_idx += insn->off;
1085 return 0;
1086 } else {
1087 /* if (imm != imm) goto pc+off;
1088 * only follow fall-through branch, since
1089 * that's where the program will go
1090 */
1091 return 0;
1092 }
1093 }
1094
1095 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
1096 if (!other_branch)
1097 return -EFAULT;
1098
1099 /* detect if R == 0 where R is returned value from bpf_map_lookup_elem() */
1100 if (BPF_SRC(insn->code) == BPF_K &&
1101 insn->imm == 0 && (opcode == BPF_JEQ ||
1102 opcode == BPF_JNE) &&
1103 regs[insn->dst_reg].type == PTR_TO_MAP_VALUE_OR_NULL) {
1104 if (opcode == BPF_JEQ) {
1105 /* next fallthrough insn can access memory via
1106 * this register
1107 */
1108 regs[insn->dst_reg].type = PTR_TO_MAP_VALUE;
1109 /* branch targer cannot access it, since reg == 0 */
1110 other_branch->regs[insn->dst_reg].type = CONST_IMM;
1111 other_branch->regs[insn->dst_reg].imm = 0;
1112 } else {
1113 other_branch->regs[insn->dst_reg].type = PTR_TO_MAP_VALUE;
1114 regs[insn->dst_reg].type = CONST_IMM;
1115 regs[insn->dst_reg].imm = 0;
1116 }
1117 } else if (BPF_SRC(insn->code) == BPF_K &&
1118 (opcode == BPF_JEQ || opcode == BPF_JNE)) {
1119
1120 if (opcode == BPF_JEQ) {
1121 /* detect if (R == imm) goto
1122 * and in the target state recognize that R = imm
1123 */
1124 other_branch->regs[insn->dst_reg].type = CONST_IMM;
1125 other_branch->regs[insn->dst_reg].imm = insn->imm;
1126 } else {
1127 /* detect if (R != imm) goto
1128 * and in the fall-through state recognize that R = imm
1129 */
1130 regs[insn->dst_reg].type = CONST_IMM;
1131 regs[insn->dst_reg].imm = insn->imm;
1132 }
1133 }
1134 if (log_level)
1135 print_verifier_state(env);
1136 return 0;
1137}
1138
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001139/* return the map pointer stored inside BPF_LD_IMM64 instruction */
1140static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
1141{
1142 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
1143
1144 return (struct bpf_map *) (unsigned long) imm64;
1145}
1146
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001147/* verify BPF_LD_IMM64 instruction */
1148static int check_ld_imm(struct verifier_env *env, struct bpf_insn *insn)
1149{
1150 struct reg_state *regs = env->cur_state.regs;
1151 int err;
1152
1153 if (BPF_SIZE(insn->code) != BPF_DW) {
1154 verbose("invalid BPF_LD_IMM insn\n");
1155 return -EINVAL;
1156 }
1157 if (insn->off != 0) {
1158 verbose("BPF_LD_IMM64 uses reserved fields\n");
1159 return -EINVAL;
1160 }
1161
1162 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1163 if (err)
1164 return err;
1165
1166 if (insn->src_reg == 0)
1167 /* generic move 64-bit immediate into a register */
1168 return 0;
1169
1170 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
1171 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
1172
1173 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
1174 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
1175 return 0;
1176}
1177
Daniel Borkmann96be4322015-03-01 12:31:46 +01001178static bool may_access_skb(enum bpf_prog_type type)
1179{
1180 switch (type) {
1181 case BPF_PROG_TYPE_SOCKET_FILTER:
1182 case BPF_PROG_TYPE_SCHED_CLS:
1183 return true;
1184 default:
1185 return false;
1186 }
1187}
1188
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08001189/* verify safety of LD_ABS|LD_IND instructions:
1190 * - they can only appear in the programs where ctx == skb
1191 * - since they are wrappers of function calls, they scratch R1-R5 registers,
1192 * preserve R6-R9, and store return value into R0
1193 *
1194 * Implicit input:
1195 * ctx == skb == R6 == CTX
1196 *
1197 * Explicit input:
1198 * SRC == any register
1199 * IMM == 32-bit immediate
1200 *
1201 * Output:
1202 * R0 - 8/16/32-bit skb data converted to cpu endianness
1203 */
1204static int check_ld_abs(struct verifier_env *env, struct bpf_insn *insn)
1205{
1206 struct reg_state *regs = env->cur_state.regs;
1207 u8 mode = BPF_MODE(insn->code);
1208 struct reg_state *reg;
1209 int i, err;
1210
Daniel Borkmann24701ec2015-03-01 12:31:47 +01001211 if (!may_access_skb(env->prog->type)) {
Daniel Borkmann96be4322015-03-01 12:31:46 +01001212 verbose("BPF_LD_ABS|IND instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08001213 return -EINVAL;
1214 }
1215
1216 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
1217 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
1218 verbose("BPF_LD_ABS uses reserved fields\n");
1219 return -EINVAL;
1220 }
1221
1222 /* check whether implicit source operand (register R6) is readable */
1223 err = check_reg_arg(regs, BPF_REG_6, SRC_OP);
1224 if (err)
1225 return err;
1226
1227 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
1228 verbose("at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
1229 return -EINVAL;
1230 }
1231
1232 if (mode == BPF_IND) {
1233 /* check explicit source operand */
1234 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1235 if (err)
1236 return err;
1237 }
1238
1239 /* reset caller saved regs to unreadable */
1240 for (i = 0; i < CALLER_SAVED_REGS; i++) {
1241 reg = regs + caller_saved[i];
1242 reg->type = NOT_INIT;
1243 reg->imm = 0;
1244 }
1245
1246 /* mark destination R0 register as readable, since it contains
1247 * the value fetched from the packet
1248 */
1249 regs[BPF_REG_0].type = UNKNOWN_VALUE;
1250 return 0;
1251}
1252
Alexei Starovoitov475fb782014-09-26 00:17:05 -07001253/* non-recursive DFS pseudo code
1254 * 1 procedure DFS-iterative(G,v):
1255 * 2 label v as discovered
1256 * 3 let S be a stack
1257 * 4 S.push(v)
1258 * 5 while S is not empty
1259 * 6 t <- S.pop()
1260 * 7 if t is what we're looking for:
1261 * 8 return t
1262 * 9 for all edges e in G.adjacentEdges(t) do
1263 * 10 if edge e is already labelled
1264 * 11 continue with the next edge
1265 * 12 w <- G.adjacentVertex(t,e)
1266 * 13 if vertex w is not discovered and not explored
1267 * 14 label e as tree-edge
1268 * 15 label w as discovered
1269 * 16 S.push(w)
1270 * 17 continue at 5
1271 * 18 else if vertex w is discovered
1272 * 19 label e as back-edge
1273 * 20 else
1274 * 21 // vertex w is explored
1275 * 22 label e as forward- or cross-edge
1276 * 23 label t as explored
1277 * 24 S.pop()
1278 *
1279 * convention:
1280 * 0x10 - discovered
1281 * 0x11 - discovered and fall-through edge labelled
1282 * 0x12 - discovered and fall-through and branch edges labelled
1283 * 0x20 - explored
1284 */
1285
1286enum {
1287 DISCOVERED = 0x10,
1288 EXPLORED = 0x20,
1289 FALLTHROUGH = 1,
1290 BRANCH = 2,
1291};
1292
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001293#define STATE_LIST_MARK ((struct verifier_state_list *) -1L)
1294
Alexei Starovoitov475fb782014-09-26 00:17:05 -07001295static int *insn_stack; /* stack of insns to process */
1296static int cur_stack; /* current stack index */
1297static int *insn_state;
1298
1299/* t, w, e - match pseudo-code above:
1300 * t - index of current instruction
1301 * w - next instruction
1302 * e - edge
1303 */
1304static int push_insn(int t, int w, int e, struct verifier_env *env)
1305{
1306 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
1307 return 0;
1308
1309 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
1310 return 0;
1311
1312 if (w < 0 || w >= env->prog->len) {
1313 verbose("jump out of range from insn %d to %d\n", t, w);
1314 return -EINVAL;
1315 }
1316
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001317 if (e == BRANCH)
1318 /* mark branch target for state pruning */
1319 env->explored_states[w] = STATE_LIST_MARK;
1320
Alexei Starovoitov475fb782014-09-26 00:17:05 -07001321 if (insn_state[w] == 0) {
1322 /* tree-edge */
1323 insn_state[t] = DISCOVERED | e;
1324 insn_state[w] = DISCOVERED;
1325 if (cur_stack >= env->prog->len)
1326 return -E2BIG;
1327 insn_stack[cur_stack++] = w;
1328 return 1;
1329 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
1330 verbose("back-edge from insn %d to %d\n", t, w);
1331 return -EINVAL;
1332 } else if (insn_state[w] == EXPLORED) {
1333 /* forward- or cross-edge */
1334 insn_state[t] = DISCOVERED | e;
1335 } else {
1336 verbose("insn state internal bug\n");
1337 return -EFAULT;
1338 }
1339 return 0;
1340}
1341
1342/* non-recursive depth-first-search to detect loops in BPF program
1343 * loop == back-edge in directed graph
1344 */
1345static int check_cfg(struct verifier_env *env)
1346{
1347 struct bpf_insn *insns = env->prog->insnsi;
1348 int insn_cnt = env->prog->len;
1349 int ret = 0;
1350 int i, t;
1351
1352 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
1353 if (!insn_state)
1354 return -ENOMEM;
1355
1356 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
1357 if (!insn_stack) {
1358 kfree(insn_state);
1359 return -ENOMEM;
1360 }
1361
1362 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
1363 insn_stack[0] = 0; /* 0 is the first instruction */
1364 cur_stack = 1;
1365
1366peek_stack:
1367 if (cur_stack == 0)
1368 goto check_state;
1369 t = insn_stack[cur_stack - 1];
1370
1371 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
1372 u8 opcode = BPF_OP(insns[t].code);
1373
1374 if (opcode == BPF_EXIT) {
1375 goto mark_explored;
1376 } else if (opcode == BPF_CALL) {
1377 ret = push_insn(t, t + 1, FALLTHROUGH, env);
1378 if (ret == 1)
1379 goto peek_stack;
1380 else if (ret < 0)
1381 goto err_free;
1382 } else if (opcode == BPF_JA) {
1383 if (BPF_SRC(insns[t].code) != BPF_K) {
1384 ret = -EINVAL;
1385 goto err_free;
1386 }
1387 /* unconditional jump with single edge */
1388 ret = push_insn(t, t + insns[t].off + 1,
1389 FALLTHROUGH, env);
1390 if (ret == 1)
1391 goto peek_stack;
1392 else if (ret < 0)
1393 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001394 /* tell verifier to check for equivalent states
1395 * after every call and jump
1396 */
1397 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07001398 } else {
1399 /* conditional jump with two edges */
1400 ret = push_insn(t, t + 1, FALLTHROUGH, env);
1401 if (ret == 1)
1402 goto peek_stack;
1403 else if (ret < 0)
1404 goto err_free;
1405
1406 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
1407 if (ret == 1)
1408 goto peek_stack;
1409 else if (ret < 0)
1410 goto err_free;
1411 }
1412 } else {
1413 /* all other non-branch instructions with single
1414 * fall-through edge
1415 */
1416 ret = push_insn(t, t + 1, FALLTHROUGH, env);
1417 if (ret == 1)
1418 goto peek_stack;
1419 else if (ret < 0)
1420 goto err_free;
1421 }
1422
1423mark_explored:
1424 insn_state[t] = EXPLORED;
1425 if (cur_stack-- <= 0) {
1426 verbose("pop stack internal bug\n");
1427 ret = -EFAULT;
1428 goto err_free;
1429 }
1430 goto peek_stack;
1431
1432check_state:
1433 for (i = 0; i < insn_cnt; i++) {
1434 if (insn_state[i] != EXPLORED) {
1435 verbose("unreachable insn %d\n", i);
1436 ret = -EINVAL;
1437 goto err_free;
1438 }
1439 }
1440 ret = 0; /* cfg looks good */
1441
1442err_free:
1443 kfree(insn_state);
1444 kfree(insn_stack);
1445 return ret;
1446}
1447
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001448/* compare two verifier states
1449 *
1450 * all states stored in state_list are known to be valid, since
1451 * verifier reached 'bpf_exit' instruction through them
1452 *
1453 * this function is called when verifier exploring different branches of
1454 * execution popped from the state stack. If it sees an old state that has
1455 * more strict register state and more strict stack state then this execution
1456 * branch doesn't need to be explored further, since verifier already
1457 * concluded that more strict state leads to valid finish.
1458 *
1459 * Therefore two states are equivalent if register state is more conservative
1460 * and explored stack state is more conservative than the current one.
1461 * Example:
1462 * explored current
1463 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
1464 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
1465 *
1466 * In other words if current stack state (one being explored) has more
1467 * valid slots than old one that already passed validation, it means
1468 * the verifier can stop exploring and conclude that current state is valid too
1469 *
1470 * Similarly with registers. If explored state has register type as invalid
1471 * whereas register type in current state is meaningful, it means that
1472 * the current state will reach 'bpf_exit' instruction safely
1473 */
1474static bool states_equal(struct verifier_state *old, struct verifier_state *cur)
1475{
1476 int i;
1477
1478 for (i = 0; i < MAX_BPF_REG; i++) {
1479 if (memcmp(&old->regs[i], &cur->regs[i],
1480 sizeof(old->regs[0])) != 0) {
1481 if (old->regs[i].type == NOT_INIT ||
Alexei Starovoitov32bf08a2014-10-20 14:54:57 -07001482 (old->regs[i].type == UNKNOWN_VALUE &&
1483 cur->regs[i].type != NOT_INIT))
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001484 continue;
1485 return false;
1486 }
1487 }
1488
1489 for (i = 0; i < MAX_BPF_STACK; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001490 if (old->stack_slot_type[i] == STACK_INVALID)
1491 continue;
1492 if (old->stack_slot_type[i] != cur->stack_slot_type[i])
1493 /* Ex: old explored (safe) state has STACK_SPILL in
1494 * this stack slot, but current has has STACK_MISC ->
1495 * this verifier states are not equivalent,
1496 * return false to continue verification of this path
1497 */
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001498 return false;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001499 if (i % BPF_REG_SIZE)
1500 continue;
1501 if (memcmp(&old->spilled_regs[i / BPF_REG_SIZE],
1502 &cur->spilled_regs[i / BPF_REG_SIZE],
1503 sizeof(old->spilled_regs[0])))
1504 /* when explored and current stack slot types are
1505 * the same, check that stored pointers types
1506 * are the same as well.
1507 * Ex: explored safe path could have stored
1508 * (struct reg_state) {.type = PTR_TO_STACK, .imm = -8}
1509 * but current path has stored:
1510 * (struct reg_state) {.type = PTR_TO_STACK, .imm = -16}
1511 * such verifier states are not equivalent.
1512 * return false to continue verification of this path
1513 */
1514 return false;
1515 else
1516 continue;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001517 }
1518 return true;
1519}
1520
1521static int is_state_visited(struct verifier_env *env, int insn_idx)
1522{
1523 struct verifier_state_list *new_sl;
1524 struct verifier_state_list *sl;
1525
1526 sl = env->explored_states[insn_idx];
1527 if (!sl)
1528 /* this 'insn_idx' instruction wasn't marked, so we will not
1529 * be doing state search here
1530 */
1531 return 0;
1532
1533 while (sl != STATE_LIST_MARK) {
1534 if (states_equal(&sl->state, &env->cur_state))
1535 /* reached equivalent register/stack state,
1536 * prune the search
1537 */
1538 return 1;
1539 sl = sl->next;
1540 }
1541
1542 /* there were no equivalent states, remember current one.
1543 * technically the current state is not proven to be safe yet,
1544 * but it will either reach bpf_exit (which means it's safe) or
1545 * it will be rejected. Since there are no loops, we won't be
1546 * seeing this 'insn_idx' instruction again on the way to bpf_exit
1547 */
1548 new_sl = kmalloc(sizeof(struct verifier_state_list), GFP_USER);
1549 if (!new_sl)
1550 return -ENOMEM;
1551
1552 /* add new state to the head of linked list */
1553 memcpy(&new_sl->state, &env->cur_state, sizeof(env->cur_state));
1554 new_sl->next = env->explored_states[insn_idx];
1555 env->explored_states[insn_idx] = new_sl;
1556 return 0;
1557}
1558
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001559static int do_check(struct verifier_env *env)
1560{
1561 struct verifier_state *state = &env->cur_state;
1562 struct bpf_insn *insns = env->prog->insnsi;
1563 struct reg_state *regs = state->regs;
1564 int insn_cnt = env->prog->len;
1565 int insn_idx, prev_insn_idx = 0;
1566 int insn_processed = 0;
1567 bool do_print_state = false;
1568
1569 init_reg_state(regs);
1570 insn_idx = 0;
1571 for (;;) {
1572 struct bpf_insn *insn;
1573 u8 class;
1574 int err;
1575
1576 if (insn_idx >= insn_cnt) {
1577 verbose("invalid insn idx %d insn_cnt %d\n",
1578 insn_idx, insn_cnt);
1579 return -EFAULT;
1580 }
1581
1582 insn = &insns[insn_idx];
1583 class = BPF_CLASS(insn->code);
1584
1585 if (++insn_processed > 32768) {
1586 verbose("BPF program is too large. Proccessed %d insn\n",
1587 insn_processed);
1588 return -E2BIG;
1589 }
1590
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001591 err = is_state_visited(env, insn_idx);
1592 if (err < 0)
1593 return err;
1594 if (err == 1) {
1595 /* found equivalent state, can prune the search */
1596 if (log_level) {
1597 if (do_print_state)
1598 verbose("\nfrom %d to %d: safe\n",
1599 prev_insn_idx, insn_idx);
1600 else
1601 verbose("%d: safe\n", insn_idx);
1602 }
1603 goto process_bpf_exit;
1604 }
1605
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001606 if (log_level && do_print_state) {
1607 verbose("\nfrom %d to %d:", prev_insn_idx, insn_idx);
1608 print_verifier_state(env);
1609 do_print_state = false;
1610 }
1611
1612 if (log_level) {
1613 verbose("%d: ", insn_idx);
1614 print_bpf_insn(insn);
1615 }
1616
1617 if (class == BPF_ALU || class == BPF_ALU64) {
1618 err = check_alu_op(regs, insn);
1619 if (err)
1620 return err;
1621
1622 } else if (class == BPF_LDX) {
1623 if (BPF_MODE(insn->code) != BPF_MEM ||
1624 insn->imm != 0) {
1625 verbose("BPF_LDX uses reserved fields\n");
1626 return -EINVAL;
1627 }
1628 /* check src operand */
1629 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1630 if (err)
1631 return err;
1632
1633 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
1634 if (err)
1635 return err;
1636
1637 /* check that memory (src_reg + off) is readable,
1638 * the state of dst_reg will be updated by this func
1639 */
1640 err = check_mem_access(env, insn->src_reg, insn->off,
1641 BPF_SIZE(insn->code), BPF_READ,
1642 insn->dst_reg);
1643 if (err)
1644 return err;
1645
1646 } else if (class == BPF_STX) {
1647 if (BPF_MODE(insn->code) == BPF_XADD) {
1648 err = check_xadd(env, insn);
1649 if (err)
1650 return err;
1651 insn_idx++;
1652 continue;
1653 }
1654
1655 if (BPF_MODE(insn->code) != BPF_MEM ||
1656 insn->imm != 0) {
1657 verbose("BPF_STX uses reserved fields\n");
1658 return -EINVAL;
1659 }
1660 /* check src1 operand */
1661 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1662 if (err)
1663 return err;
1664 /* check src2 operand */
1665 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1666 if (err)
1667 return err;
1668
1669 /* check that memory (dst_reg + off) is writeable */
1670 err = check_mem_access(env, insn->dst_reg, insn->off,
1671 BPF_SIZE(insn->code), BPF_WRITE,
1672 insn->src_reg);
1673 if (err)
1674 return err;
1675
1676 } else if (class == BPF_ST) {
1677 if (BPF_MODE(insn->code) != BPF_MEM ||
1678 insn->src_reg != BPF_REG_0) {
1679 verbose("BPF_ST uses reserved fields\n");
1680 return -EINVAL;
1681 }
1682 /* check src operand */
1683 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1684 if (err)
1685 return err;
1686
1687 /* check that memory (dst_reg + off) is writeable */
1688 err = check_mem_access(env, insn->dst_reg, insn->off,
1689 BPF_SIZE(insn->code), BPF_WRITE,
1690 -1);
1691 if (err)
1692 return err;
1693
1694 } else if (class == BPF_JMP) {
1695 u8 opcode = BPF_OP(insn->code);
1696
1697 if (opcode == BPF_CALL) {
1698 if (BPF_SRC(insn->code) != BPF_K ||
1699 insn->off != 0 ||
1700 insn->src_reg != BPF_REG_0 ||
1701 insn->dst_reg != BPF_REG_0) {
1702 verbose("BPF_CALL uses reserved fields\n");
1703 return -EINVAL;
1704 }
1705
1706 err = check_call(env, insn->imm);
1707 if (err)
1708 return err;
1709
1710 } else if (opcode == BPF_JA) {
1711 if (BPF_SRC(insn->code) != BPF_K ||
1712 insn->imm != 0 ||
1713 insn->src_reg != BPF_REG_0 ||
1714 insn->dst_reg != BPF_REG_0) {
1715 verbose("BPF_JA uses reserved fields\n");
1716 return -EINVAL;
1717 }
1718
1719 insn_idx += insn->off + 1;
1720 continue;
1721
1722 } else if (opcode == BPF_EXIT) {
1723 if (BPF_SRC(insn->code) != BPF_K ||
1724 insn->imm != 0 ||
1725 insn->src_reg != BPF_REG_0 ||
1726 insn->dst_reg != BPF_REG_0) {
1727 verbose("BPF_EXIT uses reserved fields\n");
1728 return -EINVAL;
1729 }
1730
1731 /* eBPF calling convetion is such that R0 is used
1732 * to return the value from eBPF program.
1733 * Make sure that it's readable at this time
1734 * of bpf_exit, which means that program wrote
1735 * something into it earlier
1736 */
1737 err = check_reg_arg(regs, BPF_REG_0, SRC_OP);
1738 if (err)
1739 return err;
1740
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001741process_bpf_exit:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001742 insn_idx = pop_stack(env, &prev_insn_idx);
1743 if (insn_idx < 0) {
1744 break;
1745 } else {
1746 do_print_state = true;
1747 continue;
1748 }
1749 } else {
1750 err = check_cond_jmp_op(env, insn, &insn_idx);
1751 if (err)
1752 return err;
1753 }
1754 } else if (class == BPF_LD) {
1755 u8 mode = BPF_MODE(insn->code);
1756
1757 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08001758 err = check_ld_abs(env, insn);
1759 if (err)
1760 return err;
1761
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001762 } else if (mode == BPF_IMM) {
1763 err = check_ld_imm(env, insn);
1764 if (err)
1765 return err;
1766
1767 insn_idx++;
1768 } else {
1769 verbose("invalid BPF_LD mode\n");
1770 return -EINVAL;
1771 }
1772 } else {
1773 verbose("unknown insn class %d\n", class);
1774 return -EINVAL;
1775 }
1776
1777 insn_idx++;
1778 }
1779
1780 return 0;
1781}
1782
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001783/* look for pseudo eBPF instructions that access map FDs and
1784 * replace them with actual map pointers
1785 */
1786static int replace_map_fd_with_map_ptr(struct verifier_env *env)
1787{
1788 struct bpf_insn *insn = env->prog->insnsi;
1789 int insn_cnt = env->prog->len;
1790 int i, j;
1791
1792 for (i = 0; i < insn_cnt; i++, insn++) {
1793 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
1794 struct bpf_map *map;
1795 struct fd f;
1796
1797 if (i == insn_cnt - 1 || insn[1].code != 0 ||
1798 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
1799 insn[1].off != 0) {
1800 verbose("invalid bpf_ld_imm64 insn\n");
1801 return -EINVAL;
1802 }
1803
1804 if (insn->src_reg == 0)
1805 /* valid generic load 64-bit imm */
1806 goto next_insn;
1807
1808 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
1809 verbose("unrecognized bpf_ld_imm64 insn\n");
1810 return -EINVAL;
1811 }
1812
1813 f = fdget(insn->imm);
1814
1815 map = bpf_map_get(f);
1816 if (IS_ERR(map)) {
1817 verbose("fd %d is not pointing to valid bpf_map\n",
1818 insn->imm);
1819 fdput(f);
1820 return PTR_ERR(map);
1821 }
1822
1823 /* store map pointer inside BPF_LD_IMM64 instruction */
1824 insn[0].imm = (u32) (unsigned long) map;
1825 insn[1].imm = ((u64) (unsigned long) map) >> 32;
1826
1827 /* check whether we recorded this map already */
1828 for (j = 0; j < env->used_map_cnt; j++)
1829 if (env->used_maps[j] == map) {
1830 fdput(f);
1831 goto next_insn;
1832 }
1833
1834 if (env->used_map_cnt >= MAX_USED_MAPS) {
1835 fdput(f);
1836 return -E2BIG;
1837 }
1838
1839 /* remember this map */
1840 env->used_maps[env->used_map_cnt++] = map;
1841
1842 /* hold the map. If the program is rejected by verifier,
1843 * the map will be released by release_maps() or it
1844 * will be used by the valid program until it's unloaded
1845 * and all maps are released in free_bpf_prog_info()
1846 */
1847 atomic_inc(&map->refcnt);
1848
1849 fdput(f);
1850next_insn:
1851 insn++;
1852 i++;
1853 }
1854 }
1855
1856 /* now all pseudo BPF_LD_IMM64 instructions load valid
1857 * 'struct bpf_map *' into a register instead of user map_fd.
1858 * These pointers will be used later by verifier to validate map access.
1859 */
1860 return 0;
1861}
1862
1863/* drop refcnt of maps used by the rejected program */
1864static void release_maps(struct verifier_env *env)
1865{
1866 int i;
1867
1868 for (i = 0; i < env->used_map_cnt; i++)
1869 bpf_map_put(env->used_maps[i]);
1870}
1871
1872/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
1873static void convert_pseudo_ld_imm64(struct verifier_env *env)
1874{
1875 struct bpf_insn *insn = env->prog->insnsi;
1876 int insn_cnt = env->prog->len;
1877 int i;
1878
1879 for (i = 0; i < insn_cnt; i++, insn++)
1880 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
1881 insn->src_reg = 0;
1882}
1883
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001884static void free_states(struct verifier_env *env)
1885{
1886 struct verifier_state_list *sl, *sln;
1887 int i;
1888
1889 if (!env->explored_states)
1890 return;
1891
1892 for (i = 0; i < env->prog->len; i++) {
1893 sl = env->explored_states[i];
1894
1895 if (sl)
1896 while (sl != STATE_LIST_MARK) {
1897 sln = sl->next;
1898 kfree(sl);
1899 sl = sln;
1900 }
1901 }
1902
1903 kfree(env->explored_states);
1904}
1905
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001906int bpf_check(struct bpf_prog *prog, union bpf_attr *attr)
1907{
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07001908 char __user *log_ubuf = NULL;
1909 struct verifier_env *env;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001910 int ret = -EINVAL;
1911
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07001912 if (prog->len <= 0 || prog->len > BPF_MAXINSNS)
1913 return -E2BIG;
1914
1915 /* 'struct verifier_env' can be global, but since it's not small,
1916 * allocate/free it every time bpf_check() is called
1917 */
1918 env = kzalloc(sizeof(struct verifier_env), GFP_KERNEL);
1919 if (!env)
1920 return -ENOMEM;
1921
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001922 env->prog = prog;
1923
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07001924 /* grab the mutex to protect few globals used by verifier */
1925 mutex_lock(&bpf_verifier_lock);
1926
1927 if (attr->log_level || attr->log_buf || attr->log_size) {
1928 /* user requested verbose verifier output
1929 * and supplied buffer to store the verification trace
1930 */
1931 log_level = attr->log_level;
1932 log_ubuf = (char __user *) (unsigned long) attr->log_buf;
1933 log_size = attr->log_size;
1934 log_len = 0;
1935
1936 ret = -EINVAL;
1937 /* log_* values have to be sane */
1938 if (log_size < 128 || log_size > UINT_MAX >> 8 ||
1939 log_level == 0 || log_ubuf == NULL)
1940 goto free_env;
1941
1942 ret = -ENOMEM;
1943 log_buf = vmalloc(log_size);
1944 if (!log_buf)
1945 goto free_env;
1946 } else {
1947 log_level = 0;
1948 }
1949
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001950 ret = replace_map_fd_with_map_ptr(env);
1951 if (ret < 0)
1952 goto skip_full_check;
1953
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001954 env->explored_states = kcalloc(prog->len,
1955 sizeof(struct verifier_state_list *),
1956 GFP_USER);
1957 ret = -ENOMEM;
1958 if (!env->explored_states)
1959 goto skip_full_check;
1960
Alexei Starovoitov475fb782014-09-26 00:17:05 -07001961 ret = check_cfg(env);
1962 if (ret < 0)
1963 goto skip_full_check;
1964
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001965 ret = do_check(env);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07001966
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001967skip_full_check:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001968 while (pop_stack(env, NULL) >= 0);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07001969 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001970
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07001971 if (log_level && log_len >= log_size - 1) {
1972 BUG_ON(log_len >= log_size);
1973 /* verifier log exceeded user supplied buffer */
1974 ret = -ENOSPC;
1975 /* fall through to return what was recorded */
1976 }
1977
1978 /* copy verifier log back to user space including trailing zero */
1979 if (log_level && copy_to_user(log_ubuf, log_buf, log_len + 1) != 0) {
1980 ret = -EFAULT;
1981 goto free_log_buf;
1982 }
1983
Alexei Starovoitov0246e642014-09-26 00:17:04 -07001984 if (ret == 0 && env->used_map_cnt) {
1985 /* if program passed verifier, update used_maps in bpf_prog_info */
1986 prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
1987 sizeof(env->used_maps[0]),
1988 GFP_KERNEL);
1989
1990 if (!prog->aux->used_maps) {
1991 ret = -ENOMEM;
1992 goto free_log_buf;
1993 }
1994
1995 memcpy(prog->aux->used_maps, env->used_maps,
1996 sizeof(env->used_maps[0]) * env->used_map_cnt);
1997 prog->aux->used_map_cnt = env->used_map_cnt;
1998
1999 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
2000 * bpf_ld_imm64 instructions
2001 */
2002 convert_pseudo_ld_imm64(env);
2003 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07002004
2005free_log_buf:
2006 if (log_level)
2007 vfree(log_buf);
2008free_env:
Alexei Starovoitov0246e642014-09-26 00:17:04 -07002009 if (!prog->aux->used_maps)
2010 /* if we didn't copy map pointers into bpf_prog_info, release
2011 * them now. Otherwise free_bpf_prog_info() will release them.
2012 */
2013 release_maps(env);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07002014 kfree(env);
2015 mutex_unlock(&bpf_verifier_lock);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07002016 return ret;
2017}