blob: adde88a6d9c4dc864efda6b9ff9055d0208ce245 [file] [log] [blame]
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -08001HOWTO do Linux kernel development
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -03002=================================
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -08003
4This is the be-all, end-all document on this topic. It contains
5instructions on how to become a Linux kernel developer and how to learn
6to work with the Linux kernel development community. It tries to not
7contain anything related to the technical aspects of kernel programming,
8but will help point you in the right direction for that.
9
10If anything in this document becomes out of date, please send in patches
11to the maintainer of this file, who is listed at the bottom of the
12document.
13
14
15Introduction
16------------
17
18So, you want to learn how to become a Linux kernel developer? Or you
19have been told by your manager, "Go write a Linux driver for this
20device." This document's goal is to teach you everything you need to
21know to achieve this by describing the process you need to go through,
22and hints on how to work with the community. It will also try to
23explain some of the reasons why the community works like it does.
24
25The kernel is written mostly in C, with some architecture-dependent
26parts written in assembly. A good understanding of C is required for
27kernel development. Assembly (any architecture) is not required unless
28you plan to do low-level development for that architecture. Though they
29are not a good substitute for a solid C education and/or years of
30experience, the following books are good for, if anything, reference:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030031
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080032 - "The C Programming Language" by Kernighan and Ritchie [Prentice Hall]
33 - "Practical C Programming" by Steve Oualline [O'Reilly]
Robert P. J. Day4de0ca82007-01-17 04:54:07 -050034 - "C: A Reference Manual" by Harbison and Steele [Prentice Hall]
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080035
36The kernel is written using GNU C and the GNU toolchain. While it
37adheres to the ISO C89 standard, it uses a number of extensions that are
38not featured in the standard. The kernel is a freestanding C
39environment, with no reliance on the standard C library, so some
40portions of the C standard are not supported. Arbitrary long long
41divisions and floating point are not allowed. It can sometimes be
42difficult to understand the assumptions the kernel has on the toolchain
43and the extensions that it uses, and unfortunately there is no
44definitive reference for them. Please check the gcc info pages (`info
45gcc`) for some information on them.
46
47Please remember that you are trying to learn how to work with the
48existing development community. It is a diverse group of people, with
49high standards for coding, style and procedure. These standards have
50been created over time based on what they have found to work best for
51such a large and geographically dispersed team. Try to learn as much as
52possible about these standards ahead of time, as they are well
53documented; do not expect people to adapt to you or your company's way
54of doing things.
55
56
57Legal Issues
58------------
59
60The Linux kernel source code is released under the GPL. Please see the
61file, COPYING, in the main directory of the source tree, for details on
62the license. If you have further questions about the license, please
63contact a lawyer, and do not ask on the Linux kernel mailing list. The
64people on the mailing lists are not lawyers, and you should not rely on
65their statements on legal matters.
66
67For common questions and answers about the GPL, please see:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030068
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -030069 https://www.gnu.org/licenses/gpl-faq.html
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080070
71
72Documentation
Philippe Loctauxce655082016-03-07 02:36:18 +010073-------------
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080074
75The Linux kernel source tree has a large range of documents that are
76invaluable for learning how to interact with the kernel community. When
77new features are added to the kernel, it is recommended that new
78documentation files are also added which explain how to use the feature.
79When a kernel change causes the interface that the kernel exposes to
80userspace to change, it is recommended that you send the information or
81a patch to the manual pages explaining the change to the manual pages
Michael Kerrisk09b05f52008-10-03 15:23:45 -070082maintainer at mtk.manpages@gmail.com, and CC the list
83linux-api@vger.kernel.org.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080084
85Here is a list of files that are in the kernel source tree that are
86required reading:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030087
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080088 README
89 This file gives a short background on the Linux kernel and describes
90 what is necessary to do to configure and build the kernel. People
91 who are new to the kernel should start here.
92
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -030093 :ref:`Documentation/Changes <changes>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080094 This file gives a list of the minimum levels of various software
95 packages that are necessary to build and run the kernel
96 successfully.
97
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -030098 :ref:`Documentation/CodingStyle <codingstyle>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080099 This describes the Linux kernel coding style, and some of the
100 rationale behind it. All new code is expected to follow the
101 guidelines in this document. Most maintainers will only accept
102 patches if these rules are followed, and many people will only
103 review code if it is in the proper style.
104
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300105 :ref:`Documentation/SubmittingPatches <submittingpatches>` and :ref:`Documentation/SubmittingDrivers <submittingdrivers>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800106 These files describe in explicit detail how to successfully create
107 and send a patch, including (but not limited to):
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300108
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800109 - Email contents
110 - Email format
111 - Who to send it to
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300112
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800113 Following these rules will not guarantee success (as all patches are
114 subject to scrutiny for content and style), but not following them
115 will almost always prevent it.
116
117 Other excellent descriptions of how to create patches properly are:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300118
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800119 "The Perfect Patch"
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300120 https://www.ozlabs.org/~akpm/stuff/tpp.txt
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300121
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800122 "Linux kernel patch submission format"
123 http://linux.yyz.us/patch-format.html
124
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300125 :ref:`Documentation/stable_api_nonsense.txt <stable_api_nonsense>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800126 This file describes the rationale behind the conscious decision to
127 not have a stable API within the kernel, including things like:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300128
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800129 - Subsystem shim-layers (for compatibility?)
130 - Driver portability between Operating Systems.
131 - Mitigating rapid change within the kernel source tree (or
132 preventing rapid change)
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300133
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800134 This document is crucial for understanding the Linux development
135 philosophy and is very important for people moving to Linux from
136 development on other Operating Systems.
137
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300138 :ref:`Documentation/SecurityBugs <securitybugs>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800139 If you feel you have found a security problem in the Linux kernel,
140 please follow the steps in this document to help notify the kernel
141 developers, and help solve the issue.
142
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300143 :ref:`Documentation/ManagementStyle <managementstyle>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800144 This document describes how Linux kernel maintainers operate and the
145 shared ethos behind their methodologies. This is important reading
146 for anyone new to kernel development (or anyone simply curious about
147 it), as it resolves a lot of common misconceptions and confusion
148 about the unique behavior of kernel maintainers.
149
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300150 :ref:`Documentation/stable_kernel_rules.txt <stable_kernel_rules>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800151 This file describes the rules on how the stable kernel releases
152 happen, and what to do if you want to get a change into one of these
153 releases.
154
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300155 :ref:`Documentation/kernel-docs.txt <kernel_docs>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800156 A list of external documentation that pertains to kernel
157 development. Please consult this list if you do not find what you
158 are looking for within the in-kernel documentation.
159
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300160 :ref:`Documentation/applying-patches.txt <applying_patches>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800161 A good introduction describing exactly what a patch is and how to
162 apply it to the different development branches of the kernel.
163
164The kernel also has a large number of documents that can be
Mauro Carvalho Chehab43fb67a2016-09-19 08:07:57 -0300165automatically generated from the source code itself or from
166ReStructuredText markups (ReST), like this one. This includes a
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800167full description of the in-kernel API, and rules on how to handle
Mauro Carvalho Chehab43fb67a2016-09-19 08:07:57 -0300168locking properly.
169
170All such documents can be generated as PDF or HTML by running:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300171
172::
173
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800174 make pdfdocs
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800175 make htmldocs
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300176
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800177respectively from the main kernel source directory.
178
Mauro Carvalho Chehab43fb67a2016-09-19 08:07:57 -0300179The documents that uses ReST markup will be generated at Documentation/output.
180They can also be generated on LaTeX and ePub formats with:
181
182::
183
184 make latexdocs
185 make epubdocs
186
187Currently, there are some documents written on DocBook that are in
188the process of conversion to ReST. Such documents will be created in the
189Documentation/DocBook/ directory and can be generated also as
190Postscript or man pages by running:
191
192::
193
194 make psdocs
195 make mandocs
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800196
197Becoming A Kernel Developer
198---------------------------
199
200If you do not know anything about Linux kernel development, you should
201look at the Linux KernelNewbies project:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300202
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300203 https://kernelnewbies.org
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300204
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800205It consists of a helpful mailing list where you can ask almost any type
206of basic kernel development question (make sure to search the archives
207first, before asking something that has already been answered in the
208past.) It also has an IRC channel that you can use to ask questions in
209real-time, and a lot of helpful documentation that is useful for
210learning about Linux kernel development.
211
212The website has basic information about code organization, subsystems,
213and current projects (both in-tree and out-of-tree). It also describes
214some basic logistical information, like how to compile a kernel and
215apply a patch.
216
217If you do not know where you want to start, but you want to look for
218some task to start doing to join into the kernel development community,
219go to the Linux Kernel Janitor's project:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300220
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300221 https://kernelnewbies.org/KernelJanitors
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300222
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800223It is a great place to start. It describes a list of relatively simple
224problems that need to be cleaned up and fixed within the Linux kernel
225source tree. Working with the developers in charge of this project, you
226will learn the basics of getting your patch into the Linux kernel tree,
227and possibly be pointed in the direction of what to go work on next, if
228you do not already have an idea.
229
230If you already have a chunk of code that you want to put into the kernel
231tree, but need some help getting it in the proper form, the
232kernel-mentors project was created to help you out with this. It is a
233mailing list, and can be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300234
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300235 https://selenic.com/mailman/listinfo/kernel-mentors
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800236
237Before making any actual modifications to the Linux kernel code, it is
238imperative to understand how the code in question works. For this
239purpose, nothing is better than reading through it directly (most tricky
240bits are commented well), perhaps even with the help of specialized
241tools. One such tool that is particularly recommended is the Linux
242Cross-Reference project, which is able to present source code in a
243self-referential, indexed webpage format. An excellent up-to-date
244repository of the kernel code may be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300245
Doug Smythies1d125542015-11-22 15:42:48 -0800246 http://lxr.free-electrons.com/
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800247
248
249The development process
250-----------------------
251
252Linux kernel development process currently consists of a few different
253main kernel "branches" and lots of different subsystem-specific kernel
254branches. These different branches are:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300255
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500256 - main 4.x kernel tree
257 - 4.x.y -stable kernel tree
258 - 4.x -git kernel patches
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800259 - subsystem specific kernel trees and patches
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500260 - the 4.x -next kernel tree for integration tests
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800261
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002624.x kernel tree
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800263-----------------
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002644.x kernels are maintained by Linus Torvalds, and can be found on
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300265https://kernel.org in the pub/linux/kernel/v4.x/ directory. Its development
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800266process is as follows:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300267
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800268 - As soon as a new kernel is released a two weeks window is open,
269 during this period of time maintainers can submit big diffs to
270 Linus, usually the patches that have already been included in the
Stefan Richterc607cf02010-01-15 13:23:51 +0100271 -next kernel for a few weeks. The preferred way to submit big changes
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800272 is using git (the kernel's source management tool, more information
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300273 can be found at https://git-scm.com/) but plain patches are also just
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800274 fine.
275 - After two weeks a -rc1 kernel is released it is now possible to push
276 only patches that do not include new features that could affect the
277 stability of the whole kernel. Please note that a whole new driver
278 (or filesystem) might be accepted after -rc1 because there is no
279 risk of causing regressions with such a change as long as the change
280 is self-contained and does not affect areas outside of the code that
281 is being added. git can be used to send patches to Linus after -rc1
282 is released, but the patches need to also be sent to a public
283 mailing list for review.
284 - A new -rc is released whenever Linus deems the current git tree to
285 be in a reasonably sane state adequate for testing. The goal is to
286 release a new -rc kernel every week.
287 - Process continues until the kernel is considered "ready", the
288 process should last around 6 weeks.
289
290It is worth mentioning what Andrew Morton wrote on the linux-kernel
291mailing list about kernel releases:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300292
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300293 *"Nobody knows when a kernel will be released, because it's
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800294 released according to perceived bug status, not according to a
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300295 preconceived timeline."*
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800296
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002974.x.y -stable kernel tree
Philippe Loctauxce655082016-03-07 02:36:18 +0100298-------------------------
Kees Cook591bfc62012-04-18 23:16:45 -0700299Kernels with 3-part versions are -stable kernels. They contain
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800300relatively small and critical fixes for security problems or significant
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500301regressions discovered in a given 4.x kernel.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800302
303This is the recommended branch for users who want the most recent stable
304kernel and are not interested in helping test development/experimental
305versions.
306
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500307If no 4.x.y kernel is available, then the highest numbered 4.x
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800308kernel is the current stable kernel.
309
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003104.x.y are maintained by the "stable" team <stable@vger.kernel.org>, and
Joe Perches2eb7f202011-12-09 14:12:00 -0800311are released as needs dictate. The normal release period is approximately
Jonathan Corbet0fe8a3c2008-04-25 11:23:56 -0600312two weeks, but it can be longer if there are no pressing problems. A
313security-related problem, instead, can cause a release to happen almost
314instantly.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800315
316The file Documentation/stable_kernel_rules.txt in the kernel tree
317documents what kinds of changes are acceptable for the -stable tree, and
318how the release process works.
319
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003204.x -git patches
Philippe Loctauxce655082016-03-07 02:36:18 +0100321----------------
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800322These are daily snapshots of Linus' kernel tree which are managed in a
323git repository (hence the name.) These patches are usually released
324daily and represent the current state of Linus' tree. They are more
325experimental than -rc kernels since they are generated automatically
326without even a cursory glance to see if they are sane.
327
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800328Subsystem Specific kernel trees and patches
329-------------------------------------------
Stefan Richterc607cf02010-01-15 13:23:51 +0100330The maintainers of the various kernel subsystems --- and also many
331kernel subsystem developers --- expose their current state of
332development in source repositories. That way, others can see what is
333happening in the different areas of the kernel. In areas where
334development is rapid, a developer may be asked to base his submissions
335onto such a subsystem kernel tree so that conflicts between the
336submission and other already ongoing work are avoided.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800337
Stefan Richterc607cf02010-01-15 13:23:51 +0100338Most of these repositories are git trees, but there are also other SCMs
339in use, or patch queues being published as quilt series. Addresses of
340these subsystem repositories are listed in the MAINTAINERS file. Many
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300341of them can be browsed at https://git.kernel.org/.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800342
Stefan Richterc607cf02010-01-15 13:23:51 +0100343Before a proposed patch is committed to such a subsystem tree, it is
344subject to review which primarily happens on mailing lists (see the
345respective section below). For several kernel subsystems, this review
346process is tracked with the tool patchwork. Patchwork offers a web
347interface which shows patch postings, any comments on a patch or
348revisions to it, and maintainers can mark patches as under review,
349accepted, or rejected. Most of these patchwork sites are listed at
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300350https://patchwork.kernel.org/.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800351
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003524.x -next kernel tree for integration tests
Philippe Loctauxce655082016-03-07 02:36:18 +0100353-------------------------------------------
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500354Before updates from subsystem trees are merged into the mainline 4.x
Stefan Richterc607cf02010-01-15 13:23:51 +0100355tree, they need to be integration-tested. For this purpose, a special
356testing repository exists into which virtually all subsystem trees are
357pulled on an almost daily basis:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300358
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300359 https://git.kernel.org/?p=linux/kernel/git/next/linux-next.git
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800360
Stefan Richterc607cf02010-01-15 13:23:51 +0100361This way, the -next kernel gives a summary outlook onto what will be
362expected to go into the mainline kernel at the next merge period.
363Adventurous testers are very welcome to runtime-test the -next kernel.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800364
Stefan Richter8a465c32007-06-27 14:10:01 -0700365
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800366Bug Reporting
367-------------
368
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300369https://bugzilla.kernel.org is where the Linux kernel developers track kernel
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800370bugs. Users are encouraged to report all bugs that they find in this
371tool. For details on how to use the kernel bugzilla, please see:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300372
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300373 https://bugzilla.kernel.org/page.cgi?id=faq.html
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800374
375The file REPORTING-BUGS in the main kernel source directory has a good
376template for how to report a possible kernel bug, and details what kind
377of information is needed by the kernel developers to help track down the
378problem.
379
380
Diego Calleja3f271002006-09-30 23:27:49 -0700381Managing bug reports
382--------------------
383
384One of the best ways to put into practice your hacking skills is by fixing
385bugs reported by other people. Not only you will help to make the kernel
386more stable, you'll learn to fix real world problems and you will improve
387your skills, and other developers will be aware of your presence. Fixing
Qi Yong4db29c12007-06-12 13:06:49 +0800388bugs is one of the best ways to get merits among other developers, because
Diego Calleja3f271002006-09-30 23:27:49 -0700389not many people like wasting time fixing other people's bugs.
390
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300391To work in the already reported bug reports, go to https://bugzilla.kernel.org.
Diego Calleja3f271002006-09-30 23:27:49 -0700392If you want to be advised of the future bug reports, you can subscribe to the
393bugme-new mailing list (only new bug reports are mailed here) or to the
394bugme-janitor mailing list (every change in the bugzilla is mailed here)
395
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300396 https://lists.linux-foundation.org/mailman/listinfo/bugme-new
397
398 https://lists.linux-foundation.org/mailman/listinfo/bugme-janitors
Diego Calleja3f271002006-09-30 23:27:49 -0700399
400
401
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800402Mailing lists
403-------------
404
405As some of the above documents describe, the majority of the core kernel
406developers participate on the Linux Kernel Mailing list. Details on how
407to subscribe and unsubscribe from the list can be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300408
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800409 http://vger.kernel.org/vger-lists.html#linux-kernel
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300410
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800411There are archives of the mailing list on the web in many different
412places. Use a search engine to find these archives. For example:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300413
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800414 http://dir.gmane.org/gmane.linux.kernel
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300415
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800416It is highly recommended that you search the archives about the topic
417you want to bring up, before you post it to the list. A lot of things
418already discussed in detail are only recorded at the mailing list
419archives.
420
421Most of the individual kernel subsystems also have their own separate
422mailing list where they do their development efforts. See the
423MAINTAINERS file for a list of what these lists are for the different
424groups.
425
426Many of the lists are hosted on kernel.org. Information on them can be
427found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300428
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800429 http://vger.kernel.org/vger-lists.html
430
431Please remember to follow good behavioral habits when using the lists.
432Though a bit cheesy, the following URL has some simple guidelines for
433interacting with the list (or any list):
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300434
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800435 http://www.albion.com/netiquette/
436
437If multiple people respond to your mail, the CC: list of recipients may
438get pretty large. Don't remove anybody from the CC: list without a good
439reason, or don't reply only to the list address. Get used to receiving the
440mail twice, one from the sender and the one from the list, and don't try
441to tune that by adding fancy mail-headers, people will not like it.
442
443Remember to keep the context and the attribution of your replies intact,
444keep the "John Kernelhacker wrote ...:" lines at the top of your reply, and
445add your statements between the individual quoted sections instead of
446writing at the top of the mail.
447
448If you add patches to your mail, make sure they are plain readable text
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300449as stated in Documentation/SubmittingPatches.
450Kernel developers don't want to deal with
451attachments or compressed patches; they may want to comment on
452individual lines of your patch, which works only that way. Make sure you
453use a mail program that does not mangle spaces and tab characters. A
454good first test is to send the mail to yourself and try to apply your
455own patch by yourself. If that doesn't work, get your mail program fixed
456or change it until it works.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800457
458Above all, please remember to show respect to other subscribers.
459
460
461Working with the community
462--------------------------
463
464The goal of the kernel community is to provide the best possible kernel
465there is. When you submit a patch for acceptance, it will be reviewed
466on its technical merits and those alone. So, what should you be
467expecting?
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300468
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800469 - criticism
470 - comments
471 - requests for change
472 - requests for justification
473 - silence
474
475Remember, this is part of getting your patch into the kernel. You have
476to be able to take criticism and comments about your patches, evaluate
477them at a technical level and either rework your patches or provide
478clear and concise reasoning as to why those changes should not be made.
479If there are no responses to your posting, wait a few days and try
480again, sometimes things get lost in the huge volume.
481
482What should you not do?
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300483
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800484 - expect your patch to be accepted without question
485 - become defensive
486 - ignore comments
487 - resubmit the patch without making any of the requested changes
488
489In a community that is looking for the best technical solution possible,
490there will always be differing opinions on how beneficial a patch is.
491You have to be cooperative, and willing to adapt your idea to fit within
492the kernel. Or at least be willing to prove your idea is worth it.
493Remember, being wrong is acceptable as long as you are willing to work
494toward a solution that is right.
495
496It is normal that the answers to your first patch might simply be a list
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300497of a dozen things you should correct. This does **not** imply that your
498patch will not be accepted, and it is **not** meant against you
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800499personally. Simply correct all issues raised against your patch and
500resend it.
501
502
503Differences between the kernel community and corporate structures
504-----------------------------------------------------------------
505
506The kernel community works differently than most traditional corporate
507development environments. Here are a list of things that you can try to
Cristian Stoica106f9d92012-12-07 16:37:11 +0200508do to avoid problems:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300509
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800510 Good things to say regarding your proposed changes:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300511
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800512 - "This solves multiple problems."
513 - "This deletes 2000 lines of code."
514 - "Here is a patch that explains what I am trying to describe."
515 - "I tested it on 5 different architectures..."
516 - "Here is a series of small patches that..."
517 - "This increases performance on typical machines..."
518
519 Bad things you should avoid saying:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300520
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800521 - "We did it this way in AIX/ptx/Solaris, so therefore it must be
522 good..."
523 - "I've being doing this for 20 years, so..."
524 - "This is required for my company to make money"
525 - "This is for our Enterprise product line."
526 - "Here is my 1000 page design document that describes my idea"
527 - "I've been working on this for 6 months..."
528 - "Here's a 5000 line patch that..."
529 - "I rewrote all of the current mess, and here it is..."
530 - "I have a deadline, and this patch needs to be applied now."
531
532Another way the kernel community is different than most traditional
533software engineering work environments is the faceless nature of
534interaction. One benefit of using email and irc as the primary forms of
535communication is the lack of discrimination based on gender or race.
536The Linux kernel work environment is accepting of women and minorities
537because all you are is an email address. The international aspect also
538helps to level the playing field because you can't guess gender based on
539a person's name. A man may be named Andrea and a woman may be named Pat.
540Most women who have worked in the Linux kernel and have expressed an
541opinion have had positive experiences.
542
543The language barrier can cause problems for some people who are not
544comfortable with English. A good grasp of the language can be needed in
545order to get ideas across properly on mailing lists, so it is
546recommended that you check your emails to make sure they make sense in
547English before sending them.
548
549
550Break up your changes
551---------------------
552
553The Linux kernel community does not gladly accept large chunks of code
554dropped on it all at once. The changes need to be properly introduced,
555discussed, and broken up into tiny, individual portions. This is almost
556the exact opposite of what companies are used to doing. Your proposal
557should also be introduced very early in the development process, so that
558you can receive feedback on what you are doing. It also lets the
559community feel that you are working with them, and not simply using them
560as a dumping ground for your feature. However, don't send 50 emails at
561one time to a mailing list, your patch series should be smaller than
562that almost all of the time.
563
564The reasons for breaking things up are the following:
565
5661) Small patches increase the likelihood that your patches will be
567 applied, since they don't take much time or effort to verify for
568 correctness. A 5 line patch can be applied by a maintainer with
569 barely a second glance. However, a 500 line patch may take hours to
570 review for correctness (the time it takes is exponentially
571 proportional to the size of the patch, or something).
572
573 Small patches also make it very easy to debug when something goes
574 wrong. It's much easier to back out patches one by one than it is
575 to dissect a very large patch after it's been applied (and broken
576 something).
577
5782) It's important not only to send small patches, but also to rewrite
579 and simplify (or simply re-order) patches before submitting them.
580
581Here is an analogy from kernel developer Al Viro:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300582
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300583 *"Think of a teacher grading homework from a math student. The
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800584 teacher does not want to see the student's trials and errors
585 before they came up with the solution. They want to see the
586 cleanest, most elegant answer. A good student knows this, and
587 would never submit her intermediate work before the final
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300588 solution.*
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800589
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300590 *The same is true of kernel development. The maintainers and
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800591 reviewers do not want to see the thought process behind the
592 solution to the problem one is solving. They want to see a
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300593 simple and elegant solution."*
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800594
595It may be challenging to keep the balance between presenting an elegant
596solution and working together with the community and discussing your
597unfinished work. Therefore it is good to get early in the process to
598get feedback to improve your work, but also keep your changes in small
599chunks that they may get already accepted, even when your whole task is
600not ready for inclusion now.
601
602Also realize that it is not acceptable to send patches for inclusion
603that are unfinished and will be "fixed up later."
604
605
606Justify your change
607-------------------
608
609Along with breaking up your patches, it is very important for you to let
610the Linux community know why they should add this change. New features
611must be justified as being needed and useful.
612
613
614Document your change
615--------------------
616
617When sending in your patches, pay special attention to what you say in
618the text in your email. This information will become the ChangeLog
619information for the patch, and will be preserved for everyone to see for
620all time. It should describe the patch completely, containing:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300621
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800622 - why the change is necessary
623 - the overall design approach in the patch
624 - implementation details
625 - testing results
626
627For more details on what this should all look like, please see the
628ChangeLog section of the document:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300629
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800630 "The Perfect Patch"
SeongJae Park937d9f52013-12-06 18:04:42 +0900631 http://www.ozlabs.org/~akpm/stuff/tpp.txt
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800632
633
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800634All of these things are sometimes very hard to do. It can take years to
635perfect these practices (if at all). It's a continuous process of
636improvement that requires a lot of patience and determination. But
637don't give up, it's possible. Many have done it before, and each had to
638start exactly where you are now.
639
640
641
642
643----------
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300644
Paolo Ciarrocchi5bd982e2006-04-25 22:47:51 +0200645Thanks to Paolo Ciarrocchi who allowed the "Development Process"
Mauro Carvalho Chehabf1eebe92016-09-19 08:07:59 -0300646(https://lwn.net/Articles/94386/) section
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800647to be based on text he had written, and to Randy Dunlap and Gerrit
648Huizenga for some of the list of things you should and should not say.
649Also thanks to Pat Mochel, Hanna Linder, Randy Dunlap, Kay Sievers,
650Vojtech Pavlik, Jan Kara, Josh Boyer, Kees Cook, Andrew Morton, Andi
651Kleen, Vadim Lobanov, Jesper Juhl, Adrian Bunk, Keri Harris, Frans Pop,
652David A. Wheeler, Junio Hamano, Michael Kerrisk, and Alex Shepard for
653their review, comments, and contributions. Without their help, this
654document would not have been possible.
655
656
657
658Maintainer: Greg Kroah-Hartman <greg@kroah.com>