blob: 5262b8617eb9cc21b1070e48d1c1efda584aef6f [file] [log] [blame]
Linus Torvalds1da177e2005-04-16 15:20:36 -07001/*
2 * Userspace interface
3 * Linux ethernet bridge
4 *
5 * Authors:
6 * Lennert Buytenhek <buytenh@gnu.org>
7 *
Linus Torvalds1da177e2005-04-16 15:20:36 -07008 * This program is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU General Public License
10 * as published by the Free Software Foundation; either version
11 * 2 of the License, or (at your option) any later version.
12 */
13
14#include <linux/kernel.h>
15#include <linux/netdevice.h>
stephen hemminger77f98592011-09-30 14:37:26 +000016#include <linux/etherdevice.h>
WANG Congc06ee962010-05-06 00:48:24 -070017#include <linux/netpoll.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070018#include <linux/ethtool.h>
19#include <linux/if_arp.h>
20#include <linux/module.h>
21#include <linux/init.h>
22#include <linux/rtnetlink.h>
Kris Katterjohn46f25df2006-01-05 16:35:42 -080023#include <linux/if_ether.h>
Tejun Heo5a0e3ad2010-03-24 17:04:11 +090024#include <linux/slab.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070025#include <net/sock.h>
Vlad Yasevich407af322013-02-13 12:00:12 +000026#include <linux/if_vlan.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070027
28#include "br_private.h"
29
30/*
31 * Determine initial path cost based on speed.
32 * using recommendations from 802.1d standard
33 *
Matthew Wilcox61a44b92007-07-31 14:00:02 -070034 * Since driver might sleep need to not be holding any locks.
Linus Torvalds1da177e2005-04-16 15:20:36 -070035 */
Stephen Hemminger4433f422005-12-20 15:19:51 -080036static int port_cost(struct net_device *dev)
Linus Torvalds1da177e2005-04-16 15:20:36 -070037{
Jiri Pirkofa3df922011-09-01 03:29:38 +000038 struct ethtool_cmd ecmd;
Stephen Hemmingerb4a488d2007-08-30 22:16:22 -070039
Jiri Pirko4bc71cb2011-09-03 03:34:30 +000040 if (!__ethtool_get_settings(dev, &ecmd)) {
Jiri Pirkofa3df922011-09-01 03:29:38 +000041 switch (ethtool_cmd_speed(&ecmd)) {
42 case SPEED_10000:
43 return 2;
44 case SPEED_1000:
45 return 4;
46 case SPEED_100:
47 return 19;
48 case SPEED_10:
49 return 100;
Linus Torvalds1da177e2005-04-16 15:20:36 -070050 }
51 }
52
53 /* Old silly heuristics based on name */
54 if (!strncmp(dev->name, "lec", 3))
55 return 7;
56
57 if (!strncmp(dev->name, "plip", 4))
58 return 2500;
59
60 return 100; /* assume old 10Mbps */
61}
62
Stephen Hemminger4433f422005-12-20 15:19:51 -080063
tanxiaojun1a81a2e2013-12-16 21:32:46 +080064/* Check for port carrier transitions. */
Stephen Hemminger269def72007-02-22 01:10:18 -080065void br_port_carrier_check(struct net_bridge_port *p)
Stephen Hemminger4433f422005-12-20 15:19:51 -080066{
Stephen Hemminger269def72007-02-22 01:10:18 -080067 struct net_device *dev = p->dev;
68 struct net_bridge *br = p->br;
Stephen Hemmingerb3f1be42006-02-09 17:08:52 -080069
stephen hemminger8f3359b2013-04-13 14:06:07 +000070 if (!(p->flags & BR_ADMIN_COST) &&
71 netif_running(dev) && netif_oper_up(dev))
Stephen Hemminger6e86b892006-03-03 17:14:51 -080072 p->path_cost = port_cost(dev);
Stephen Hemminger4433f422005-12-20 15:19:51 -080073
stephen hemmingeraa7c6e52010-08-24 13:12:56 +000074 if (!netif_running(br->dev))
75 return;
76
77 spin_lock_bh(&br->lock);
stephen hemminger576eb622012-12-28 18:15:22 +000078 if (netif_running(dev) && netif_oper_up(dev)) {
stephen hemmingeraa7c6e52010-08-24 13:12:56 +000079 if (p->state == BR_STATE_DISABLED)
80 br_stp_enable_port(p);
81 } else {
82 if (p->state != BR_STATE_DISABLED)
83 br_stp_disable_port(p);
Stephen Hemminger4433f422005-12-20 15:19:51 -080084 }
stephen hemmingeraa7c6e52010-08-24 13:12:56 +000085 spin_unlock_bh(&br->lock);
Stephen Hemminger4433f422005-12-20 15:19:51 -080086}
87
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -080088static void release_nbp(struct kobject *kobj)
89{
90 struct net_bridge_port *p
91 = container_of(kobj, struct net_bridge_port, kobj);
92 kfree(p);
93}
94
95static struct kobj_type brport_ktype = {
96#ifdef CONFIG_SYSFS
97 .sysfs_ops = &brport_sysfs_ops,
98#endif
99 .release = release_nbp,
100};
101
Linus Torvalds1da177e2005-04-16 15:20:36 -0700102static void destroy_nbp(struct net_bridge_port *p)
103{
104 struct net_device *dev = p->dev;
105
Linus Torvalds1da177e2005-04-16 15:20:36 -0700106 p->br = NULL;
107 p->dev = NULL;
108 dev_put(dev);
109
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800110 kobject_put(&p->kobj);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700111}
112
113static void destroy_nbp_rcu(struct rcu_head *head)
114{
115 struct net_bridge_port *p =
116 container_of(head, struct net_bridge_port, rcu);
117 destroy_nbp(p);
118}
119
Stephen Hemminger3f4cfc22006-01-31 17:44:07 -0800120/* Delete port(interface) from bridge is done in two steps.
121 * via RCU. First step, marks device as down. That deletes
122 * all the timers and stops new packets from flowing through.
123 *
124 * Final cleanup doesn't occur until after all CPU's finished
125 * processing packets.
126 *
127 * Protected from multiple admin operations by RTNL mutex
128 */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700129static void del_nbp(struct net_bridge_port *p)
130{
131 struct net_bridge *br = p->br;
132 struct net_device *dev = p->dev;
133
Randy Dunlapb3bcb722010-05-18 12:26:27 -0700134 sysfs_remove_link(br->ifobj, p->dev->name);
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800135
Linus Torvalds1da177e2005-04-16 15:20:36 -0700136 dev_set_promiscuity(dev, -1);
137
138 spin_lock_bh(&br->lock);
139 br_stp_disable_port(p);
140 spin_unlock_bh(&br->lock);
141
Stephen Hemmingerb86c4502007-03-22 14:08:46 -0700142 br_ifinfo_notify(RTM_DELLINK, p);
143
Vlad Yasevich243a2e62013-02-13 12:00:09 +0000144 nbp_vlan_flush(p);
Stephen Hemminger1a620692006-10-12 14:45:38 -0700145 br_fdb_delete_by_port(br, p, 1);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700146
147 list_del_rcu(&p->list);
148
Jiri Pirkof350a0a82010-06-15 06:50:45 +0000149 dev->priv_flags &= ~IFF_BRIDGE_PORT;
150
Jiri Pirkoab95bfe2010-06-01 21:52:08 +0000151 netdev_rx_handler_unregister(dev);
Stephen Hemmingerb3f1be42006-02-09 17:08:52 -0800152
Jiri Pirko74fdd932013-01-03 22:48:54 +0000153 netdev_upper_dev_unlink(dev, br->dev);
Jiri Pirkoafc61512011-02-13 09:33:42 +0000154
Herbert Xu3fe2d7c2010-02-28 00:49:38 -0800155 br_multicast_del_port(p);
156
Stephen Hemminger125a12c2006-03-03 17:16:15 -0800157 kobject_uevent(&p->kobj, KOBJ_REMOVE);
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800158 kobject_del(&p->kobj);
159
Herbert Xu91d2c342010-06-10 16:12:50 +0000160 br_netpoll_disable(p);
161
Linus Torvalds1da177e2005-04-16 15:20:36 -0700162 call_rcu(&p->rcu, destroy_nbp_rcu);
163}
164
stephen hemminger1ce5cce2011-10-06 11:19:41 +0000165/* Delete bridge device */
166void br_dev_delete(struct net_device *dev, struct list_head *head)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700167{
stephen hemminger1ce5cce2011-10-06 11:19:41 +0000168 struct net_bridge *br = netdev_priv(dev);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700169 struct net_bridge_port *p, *n;
170
171 list_for_each_entry_safe(p, n, &br->port_list, list) {
Linus Torvalds1da177e2005-04-16 15:20:36 -0700172 del_nbp(p);
173 }
174
Ding Tianhongf8730422013-12-07 22:12:05 +0800175 br_fdb_delete_by_port(br, NULL, 1);
176
Toshiaki Makitab4e09b22013-11-13 17:26:14 +0900177 br_vlan_flush(br);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700178 del_timer_sync(&br->gc_timer);
179
180 br_sysfs_delbr(br->dev);
Eric Dumazet8c56ba02009-10-28 05:35:35 +0000181 unregister_netdevice_queue(br->dev, head);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700182}
183
Linus Torvalds1da177e2005-04-16 15:20:36 -0700184/* find an available port number */
185static int find_portno(struct net_bridge *br)
186{
187 int index;
188 struct net_bridge_port *p;
189 unsigned long *inuse;
190
Stephen Hemminger3b781fa2006-03-20 22:56:50 -0800191 inuse = kcalloc(BITS_TO_LONGS(BR_MAX_PORTS), sizeof(unsigned long),
Linus Torvalds1da177e2005-04-16 15:20:36 -0700192 GFP_KERNEL);
193 if (!inuse)
194 return -ENOMEM;
195
Linus Torvalds1da177e2005-04-16 15:20:36 -0700196 set_bit(0, inuse); /* zero is reserved */
197 list_for_each_entry(p, &br->port_list, list) {
198 set_bit(p->port_no, inuse);
199 }
200 index = find_first_zero_bit(inuse, BR_MAX_PORTS);
201 kfree(inuse);
202
203 return (index >= BR_MAX_PORTS) ? -EXFULL : index;
204}
205
Stephen Hemminger4433f422005-12-20 15:19:51 -0800206/* called with RTNL but without bridge lock */
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900207static struct net_bridge_port *new_nbp(struct net_bridge *br,
Stephen Hemminger4433f422005-12-20 15:19:51 -0800208 struct net_device *dev)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700209{
210 int index;
211 struct net_bridge_port *p;
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900212
Linus Torvalds1da177e2005-04-16 15:20:36 -0700213 index = find_portno(br);
214 if (index < 0)
215 return ERR_PTR(index);
216
Stephen Hemmingercee48542006-03-20 22:57:03 -0800217 p = kzalloc(sizeof(*p), GFP_KERNEL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700218 if (p == NULL)
219 return ERR_PTR(-ENOMEM);
220
Linus Torvalds1da177e2005-04-16 15:20:36 -0700221 p->br = br;
222 dev_hold(dev);
223 p->dev = dev;
Stephen Hemminger4433f422005-12-20 15:19:51 -0800224 p->path_cost = port_cost(dev);
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900225 p->priority = 0x8000 >> BR_PORT_BITS;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700226 p->port_no = index;
Vlad Yasevich867a5942013-06-05 10:08:01 -0400227 p->flags = BR_LEARNING | BR_FLOOD;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700228 br_init_port(p);
229 p->state = BR_STATE_DISABLED;
Stephen Hemmingerd32439c2006-03-03 17:15:34 -0800230 br_stp_port_timer_init(p);
Herbert Xu3fe2d7c2010-02-28 00:49:38 -0800231 br_multicast_add_port(p);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700232
233 return p;
234}
235
Alexey Dobriyan4aa678b2008-09-08 16:19:58 -0700236int br_add_bridge(struct net *net, const char *name)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700237{
238 struct net_device *dev;
Eric Dumazet11f3a6b2011-08-22 06:05:59 +0000239 int res;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700240
stephen hemmingerbb900b22011-04-04 14:03:32 +0000241 dev = alloc_netdev(sizeof(struct net_bridge), name,
242 br_dev_setup);
243
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900244 if (!dev)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700245 return -ENOMEM;
246
stephen hemmingerbb900b22011-04-04 14:03:32 +0000247 dev_net_set(dev, net);
stephen hemminger149ddd82012-06-26 05:48:45 +0000248 dev->rtnl_link_ops = &br_link_ops;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700249
Eric Dumazet11f3a6b2011-08-22 06:05:59 +0000250 res = register_netdev(dev);
251 if (res)
252 free_netdev(dev);
253 return res;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700254}
255
Alexey Dobriyan4aa678b2008-09-08 16:19:58 -0700256int br_del_bridge(struct net *net, const char *name)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700257{
258 struct net_device *dev;
259 int ret = 0;
260
261 rtnl_lock();
Alexey Dobriyan4aa678b2008-09-08 16:19:58 -0700262 dev = __dev_get_by_name(net, name);
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900263 if (dev == NULL)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700264 ret = -ENXIO; /* Could not find device */
265
266 else if (!(dev->priv_flags & IFF_EBRIDGE)) {
267 /* Attempt to delete non bridge device! */
268 ret = -EPERM;
269 }
270
271 else if (dev->flags & IFF_UP) {
272 /* Not shutdown yet. */
273 ret = -EBUSY;
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900274 }
Linus Torvalds1da177e2005-04-16 15:20:36 -0700275
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900276 else
stephen hemminger1ce5cce2011-10-06 11:19:41 +0000277 br_dev_delete(dev, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700278
279 rtnl_unlock();
280 return ret;
281}
282
Kris Katterjohn46f25df2006-01-05 16:35:42 -0800283/* MTU of the bridge pseudo-device: ETH_DATA_LEN or the minimum of the ports */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700284int br_min_mtu(const struct net_bridge *br)
285{
286 const struct net_bridge_port *p;
287 int mtu = 0;
288
289 ASSERT_RTNL();
290
291 if (list_empty(&br->port_list))
Kris Katterjohn46f25df2006-01-05 16:35:42 -0800292 mtu = ETH_DATA_LEN;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700293 else {
294 list_for_each_entry(p, &br->port_list, list) {
295 if (!mtu || p->dev->mtu < mtu)
296 mtu = p->dev->mtu;
297 }
298 }
299 return mtu;
300}
301
Stephen Hemminger81d35302005-05-29 14:15:17 -0700302/*
303 * Recomputes features using slave's features
304 */
Michał Mirosławc8f44af2011-11-15 15:29:55 +0000305netdev_features_t br_features_recompute(struct net_bridge *br,
306 netdev_features_t features)
Stephen Hemminger81d35302005-05-29 14:15:17 -0700307{
308 struct net_bridge_port *p;
Michał Mirosławc8f44af2011-11-15 15:29:55 +0000309 netdev_features_t mask;
Stephen Hemminger81d35302005-05-29 14:15:17 -0700310
Herbert Xub63365a2008-10-23 01:11:29 -0700311 if (list_empty(&br->port_list))
Michał Mirosławc4d27ef2011-04-22 06:31:16 +0000312 return features;
Herbert Xub63365a2008-10-23 01:11:29 -0700313
Michał Mirosławc4d27ef2011-04-22 06:31:16 +0000314 mask = features;
Herbert Xub63365a2008-10-23 01:11:29 -0700315 features &= ~NETIF_F_ONE_FOR_ALL;
Stephen Hemminger81d35302005-05-29 14:15:17 -0700316
317 list_for_each_entry(p, &br->port_list, list) {
Herbert Xub63365a2008-10-23 01:11:29 -0700318 features = netdev_increment_features(features,
319 p->dev->features, mask);
Stephen Hemminger81d35302005-05-29 14:15:17 -0700320 }
321
Michał Mirosławc4d27ef2011-04-22 06:31:16 +0000322 return features;
Stephen Hemminger81d35302005-05-29 14:15:17 -0700323}
324
Linus Torvalds1da177e2005-04-16 15:20:36 -0700325/* called with RTNL */
326int br_add_if(struct net_bridge *br, struct net_device *dev)
327{
328 struct net_bridge_port *p;
329 int err = 0;
stephen hemmingeredf947f2011-03-24 13:24:01 +0000330 bool changed_addr;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700331
Stephen Hemminger1056bd52009-11-05 20:46:52 -0800332 /* Don't allow bridging non-ethernet like devices */
333 if ((dev->flags & IFF_LOOPBACK) ||
stephen hemminger77f98592011-09-30 14:37:26 +0000334 dev->type != ARPHRD_ETHER || dev->addr_len != ETH_ALEN ||
335 !is_valid_ether_addr(dev->dev_addr))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700336 return -EINVAL;
337
Stephen Hemminger1056bd52009-11-05 20:46:52 -0800338 /* No bridging of bridges */
Stephen Hemminger00829822008-11-20 20:14:53 -0800339 if (dev->netdev_ops->ndo_start_xmit == br_dev_xmit)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700340 return -ELOOP;
341
Stephen Hemminger1056bd52009-11-05 20:46:52 -0800342 /* Device is already being bridged */
Jiri Pirkof350a0a82010-06-15 06:50:45 +0000343 if (br_port_exists(dev))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700344 return -EBUSY;
345
Johannes Bergad4bb6f2009-11-19 00:56:30 +0100346 /* No bridging devices that dislike that (e.g. wireless) */
347 if (dev->priv_flags & IFF_DONT_BRIDGE)
348 return -EOPNOTSUPP;
349
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800350 p = new_nbp(br, dev);
351 if (IS_ERR(p))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700352 return PTR_ERR(p);
353
Amerigo Wangbb8ed632011-05-19 21:39:11 +0000354 call_netdevice_notifiers(NETDEV_JOIN, dev);
355
Wang Chenbc3f9072008-07-14 20:53:13 -0700356 err = dev_set_promiscuity(dev, 1);
357 if (err)
358 goto put_back;
359
Greg Kroah-Hartmane32cc732007-12-17 23:05:35 -0700360 err = kobject_init_and_add(&p->kobj, &brport_ktype, &(dev->dev.kobj),
361 SYSFS_BRIDGE_PORT_ATTR);
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800362 if (err)
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800363 goto err1;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700364
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800365 err = br_sysfs_addif(p);
366 if (err)
367 goto err2;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700368
Eric W. Biedermana8779ec2014-03-27 15:36:38 -0700369 err = br_netpoll_enable(p);
stephen hemminger93d8bf92013-07-24 11:51:41 -0700370 if (err)
Herbert Xu91d2c342010-06-10 16:12:50 +0000371 goto err3;
372
Jiri Pirko74fdd932013-01-03 22:48:54 +0000373 err = netdev_master_upper_dev_link(dev, br->dev);
Jiri Pirkoab95bfe2010-06-01 21:52:08 +0000374 if (err)
Gao feng9b1536c2012-12-19 23:41:43 +0000375 goto err4;
Jiri Pirkof350a0a82010-06-15 06:50:45 +0000376
Jiri Pirkoafc61512011-02-13 09:33:42 +0000377 err = netdev_rx_handler_register(dev, br_handle_frame, p);
378 if (err)
Gao feng9b1536c2012-12-19 23:41:43 +0000379 goto err5;
Jiri Pirkoafc61512011-02-13 09:33:42 +0000380
Jiri Pirkof350a0a82010-06-15 06:50:45 +0000381 dev->priv_flags |= IFF_BRIDGE_PORT;
Jiri Pirkoab95bfe2010-06-01 21:52:08 +0000382
Ben Hutchings0187bdf2008-06-19 16:15:47 -0700383 dev_disable_lro(dev);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700384
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800385 list_add_rcu(&p->list, &br->port_list);
386
Michał Mirosławc4d27ef2011-04-22 06:31:16 +0000387 netdev_update_features(br->dev);
388
Florian Fainellifd094802013-08-27 12:03:53 +0100389 if (br->dev->needed_headroom < dev->needed_headroom)
390 br->dev->needed_headroom = dev->needed_headroom;
391
Toshiaki Makitaa4b816d2014-02-07 16:48:21 +0900392 if (br_fdb_insert(br, p, dev->dev_addr, 0))
393 netdev_err(dev, "failed insert local address bridge forwarding table\n");
394
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800395 spin_lock_bh(&br->lock);
stephen hemmingeredf947f2011-03-24 13:24:01 +0000396 changed_addr = br_stp_recalculate_bridge_id(br);
Aji Srinivasde790592007-03-07 16:10:53 -0800397
stephen hemminger576eb622012-12-28 18:15:22 +0000398 if (netif_running(dev) && netif_oper_up(dev) &&
Aji Srinivasde790592007-03-07 16:10:53 -0800399 (br->dev->flags & IFF_UP))
400 br_stp_enable_port(p);
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800401 spin_unlock_bh(&br->lock);
402
Stephen Hemmingerb86c4502007-03-22 14:08:46 -0700403 br_ifinfo_notify(RTM_NEWLINK, p);
404
stephen hemmingeredf947f2011-03-24 13:24:01 +0000405 if (changed_addr)
stephen hemminger56139fc2011-07-22 07:47:08 +0000406 call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
stephen hemmingeredf947f2011-03-24 13:24:01 +0000407
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800408 dev_set_mtu(br->dev, br_min_mtu(br));
Stephen Hemminger269def72007-02-22 01:10:18 -0800409
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800410 kobject_uevent(&p->kobj, KOBJ_ADD);
411
412 return 0;
Jiri Pirkoafc61512011-02-13 09:33:42 +0000413
Gao feng9b1536c2012-12-19 23:41:43 +0000414err5:
Jiri Pirko74fdd932013-01-03 22:48:54 +0000415 netdev_upper_dev_unlink(dev, br->dev);
Gao feng9b1536c2012-12-19 23:41:43 +0000416err4:
417 br_netpoll_disable(p);
Herbert Xu91d2c342010-06-10 16:12:50 +0000418err3:
419 sysfs_remove_link(br->ifobj, p->dev->name);
Stephen Hemmingerbab1dee2006-02-09 17:10:12 -0800420err2:
Xiaotian Fengc587aea2009-07-23 23:06:32 +0000421 kobject_put(&p->kobj);
Jeff Hansen30df94f2009-09-28 12:54:25 -0700422 p = NULL; /* kobject_put frees */
stephen hemminger77f98592011-09-30 14:37:26 +0000423err1:
Wang Chenbc3f9072008-07-14 20:53:13 -0700424 dev_set_promiscuity(dev, -1);
Volodymyr G Lukiianyk43af8532008-04-29 03:17:42 -0700425put_back:
426 dev_put(dev);
Wang Chenbc3f9072008-07-14 20:53:13 -0700427 kfree(p);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700428 return err;
429}
430
431/* called with RTNL */
432int br_del_if(struct net_bridge *br, struct net_device *dev)
433{
Jiri Pirkof350a0a82010-06-15 06:50:45 +0000434 struct net_bridge_port *p;
Andrei Warkentin9be6dd62011-08-05 11:04:10 +0000435 bool changed_addr;
YOSHIFUJI Hideaki9d6f2292007-02-09 23:24:35 +0900436
Eric Dumazetec1e5612010-11-15 06:38:14 +0000437 p = br_port_get_rtnl(dev);
stephen hemmingerb5ed54e2010-11-15 06:38:13 +0000438 if (!p || p->br != br)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700439 return -EINVAL;
440
Amerigo Wangd30362c2012-08-10 01:24:43 +0000441 /* Since more than one interface can be attached to a bridge,
442 * there still maybe an alternate path for netconsole to use;
443 * therefore there is no reason for a NETDEV_RELEASE event.
444 */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700445 del_nbp(p);
446
447 spin_lock_bh(&br->lock);
Andrei Warkentin9be6dd62011-08-05 11:04:10 +0000448 changed_addr = br_stp_recalculate_bridge_id(br);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700449 spin_unlock_bh(&br->lock);
450
Andrei Warkentin9be6dd62011-08-05 11:04:10 +0000451 if (changed_addr)
452 call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);
453
Michał Mirosławc4d27ef2011-04-22 06:31:16 +0000454 netdev_update_features(br->dev);
455
Linus Torvalds1da177e2005-04-16 15:20:36 -0700456 return 0;
457}