blob: c26c0757d75543f71f6eb86623139aad35eaefdd [file] [log] [blame]
Florian Fainelliaa096772014-02-13 16:08:48 -08001/*
2 * Broadcom GENET MDIO routines
3 *
4 * Copyright (c) 2014 Broadcom Corporation
5 *
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License version 2 as
8 * published by the Free Software Foundation.
Florian Fainelliaa096772014-02-13 16:08:48 -08009 */
10
11
12#include <linux/types.h>
13#include <linux/delay.h>
14#include <linux/wait.h>
15#include <linux/mii.h>
16#include <linux/ethtool.h>
17#include <linux/bitops.h>
18#include <linux/netdevice.h>
19#include <linux/platform_device.h>
20#include <linux/phy.h>
21#include <linux/phy_fixed.h>
22#include <linux/brcmphy.h>
23#include <linux/of.h>
24#include <linux/of_net.h>
25#include <linux/of_mdio.h>
Petri Gyntherb0ba5122014-12-01 16:18:08 -080026#include <linux/platform_data/bcmgenet.h>
Florian Fainelliaa096772014-02-13 16:08:48 -080027
28#include "bcmgenet.h"
29
30/* read a value from the MII */
31static int bcmgenet_mii_read(struct mii_bus *bus, int phy_id, int location)
32{
33 int ret;
34 struct net_device *dev = bus->priv;
35 struct bcmgenet_priv *priv = netdev_priv(dev);
36 u32 reg;
37
38 bcmgenet_umac_writel(priv, (MDIO_RD | (phy_id << MDIO_PMD_SHIFT) |
Florian Fainellic91b7f62014-07-23 10:42:12 -070039 (location << MDIO_REG_SHIFT)), UMAC_MDIO_CMD);
Florian Fainelliaa096772014-02-13 16:08:48 -080040 /* Start MDIO transaction*/
41 reg = bcmgenet_umac_readl(priv, UMAC_MDIO_CMD);
42 reg |= MDIO_START_BUSY;
43 bcmgenet_umac_writel(priv, reg, UMAC_MDIO_CMD);
44 wait_event_timeout(priv->wq,
Florian Fainellic91b7f62014-07-23 10:42:12 -070045 !(bcmgenet_umac_readl(priv, UMAC_MDIO_CMD)
46 & MDIO_START_BUSY),
47 HZ / 100);
Florian Fainelliaa096772014-02-13 16:08:48 -080048 ret = bcmgenet_umac_readl(priv, UMAC_MDIO_CMD);
49
50 if (ret & MDIO_READ_FAIL)
51 return -EIO;
52
53 return ret & 0xffff;
54}
55
56/* write a value to the MII */
57static int bcmgenet_mii_write(struct mii_bus *bus, int phy_id,
Florian Fainellic91b7f62014-07-23 10:42:12 -070058 int location, u16 val)
Florian Fainelliaa096772014-02-13 16:08:48 -080059{
60 struct net_device *dev = bus->priv;
61 struct bcmgenet_priv *priv = netdev_priv(dev);
62 u32 reg;
63
64 bcmgenet_umac_writel(priv, (MDIO_WR | (phy_id << MDIO_PMD_SHIFT) |
Florian Fainellic91b7f62014-07-23 10:42:12 -070065 (location << MDIO_REG_SHIFT) | (0xffff & val)),
66 UMAC_MDIO_CMD);
Florian Fainelliaa096772014-02-13 16:08:48 -080067 reg = bcmgenet_umac_readl(priv, UMAC_MDIO_CMD);
68 reg |= MDIO_START_BUSY;
69 bcmgenet_umac_writel(priv, reg, UMAC_MDIO_CMD);
70 wait_event_timeout(priv->wq,
Florian Fainellic91b7f62014-07-23 10:42:12 -070071 !(bcmgenet_umac_readl(priv, UMAC_MDIO_CMD) &
72 MDIO_START_BUSY),
73 HZ / 100);
Florian Fainelliaa096772014-02-13 16:08:48 -080074
75 return 0;
76}
77
78/* setup netdev link state when PHY link status change and
79 * update UMAC and RGMII block when link up
80 */
Florian Fainellic96e7312014-11-10 18:06:20 -080081void bcmgenet_mii_setup(struct net_device *dev)
Florian Fainelliaa096772014-02-13 16:08:48 -080082{
83 struct bcmgenet_priv *priv = netdev_priv(dev);
84 struct phy_device *phydev = priv->phydev;
85 u32 reg, cmd_bits = 0;
Petri Gynther5ad6e6c2014-10-03 12:25:01 -070086 bool status_changed = false;
Florian Fainelliaa096772014-02-13 16:08:48 -080087
88 if (priv->old_link != phydev->link) {
Petri Gynther5ad6e6c2014-10-03 12:25:01 -070089 status_changed = true;
Florian Fainelliaa096772014-02-13 16:08:48 -080090 priv->old_link = phydev->link;
91 }
92
93 if (phydev->link) {
Petri Gynther5ad6e6c2014-10-03 12:25:01 -070094 /* check speed/duplex/pause changes */
95 if (priv->old_speed != phydev->speed) {
96 status_changed = true;
97 priv->old_speed = phydev->speed;
98 }
99
100 if (priv->old_duplex != phydev->duplex) {
101 status_changed = true;
102 priv->old_duplex = phydev->duplex;
103 }
104
105 if (priv->old_pause != phydev->pause) {
106 status_changed = true;
107 priv->old_pause = phydev->pause;
108 }
109
110 /* done if nothing has changed */
111 if (!status_changed)
112 return;
Florian Fainelliaa096772014-02-13 16:08:48 -0800113
114 /* speed */
115 if (phydev->speed == SPEED_1000)
116 cmd_bits = UMAC_SPEED_1000;
117 else if (phydev->speed == SPEED_100)
118 cmd_bits = UMAC_SPEED_100;
119 else
120 cmd_bits = UMAC_SPEED_10;
121 cmd_bits <<= CMD_SPEED_SHIFT;
122
Florian Fainelliaa096772014-02-13 16:08:48 -0800123 /* duplex */
124 if (phydev->duplex != DUPLEX_FULL)
125 cmd_bits |= CMD_HD_EN;
126
Florian Fainelliaa096772014-02-13 16:08:48 -0800127 /* pause capability */
128 if (!phydev->pause)
129 cmd_bits |= CMD_RX_PAUSE_IGNORE | CMD_TX_PAUSE_IGNORE;
130
Petri Gynther5ad6e6c2014-10-03 12:25:01 -0700131 /*
132 * Program UMAC and RGMII block based on established
133 * link speed, duplex, and pause. The speed set in
134 * umac->cmd tell RGMII block which clock to use for
135 * transmit -- 25MHz(100Mbps) or 125MHz(1Gbps).
136 * Receive clock is provided by the PHY.
137 */
138 reg = bcmgenet_ext_readl(priv, EXT_RGMII_OOB_CTRL);
139 reg &= ~OOB_DISABLE;
140 reg |= RGMII_LINK;
141 bcmgenet_ext_writel(priv, reg, EXT_RGMII_OOB_CTRL);
Florian Fainellic677ba82014-08-11 14:50:44 -0700142
Florian Fainelliaa096772014-02-13 16:08:48 -0800143 reg = bcmgenet_umac_readl(priv, UMAC_CMD);
144 reg &= ~((CMD_SPEED_MASK << CMD_SPEED_SHIFT) |
145 CMD_HD_EN |
146 CMD_RX_PAUSE_IGNORE | CMD_TX_PAUSE_IGNORE);
147 reg |= cmd_bits;
148 bcmgenet_umac_writel(priv, reg, UMAC_CMD);
Petri Gynther5ad6e6c2014-10-03 12:25:01 -0700149 } else {
150 /* done if nothing has changed */
151 if (!status_changed)
152 return;
Florian Fainelliaa096772014-02-13 16:08:48 -0800153
Petri Gynther5ad6e6c2014-10-03 12:25:01 -0700154 /* needed for MoCA fixed PHY to reflect correct link status */
155 netif_carrier_off(dev);
Florian Fainelli24052402014-07-21 17:42:39 -0700156 }
Florian Fainellic677ba82014-08-11 14:50:44 -0700157
158 phy_print_status(phydev);
Florian Fainelliaa096772014-02-13 16:08:48 -0800159}
160
161void bcmgenet_mii_reset(struct net_device *dev)
162{
163 struct bcmgenet_priv *priv = netdev_priv(dev);
164
165 if (priv->phydev) {
166 phy_init_hw(priv->phydev);
167 phy_start_aneg(priv->phydev);
168 }
169}
170
Florian Fainelli8212c982015-03-23 15:09:53 -0700171static void bcmgenet_phy_power_set(struct net_device *dev, bool enable)
Florian Fainelliaa096772014-02-13 16:08:48 -0800172{
173 struct bcmgenet_priv *priv = netdev_priv(dev);
174 u32 reg = 0;
175
176 /* EXT_GPHY_CTRL is only valid for GENETv4 and onward */
177 if (!GENET_IS_V4(priv))
178 return;
179
Florian Fainelli8212c982015-03-23 15:09:53 -0700180 if (enable) {
181 reg = bcmgenet_ext_readl(priv, EXT_GPHY_CTRL);
Florian Fainelli0c81a8e2015-03-23 15:09:54 -0700182 reg &= ~EXT_CK25_DIS;
183 bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
184 mdelay(1);
185
186 reg &= ~(EXT_CFG_IDDQ_BIAS | EXT_CFG_PWR_DOWN);
Florian Fainelli8212c982015-03-23 15:09:53 -0700187 reg |= EXT_GPHY_RESET;
188 bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
Florian Fainelli0c81a8e2015-03-23 15:09:54 -0700189 mdelay(1);
Florian Fainelliaa096772014-02-13 16:08:48 -0800190
Florian Fainelli8212c982015-03-23 15:09:53 -0700191 reg &= ~EXT_GPHY_RESET;
192 bcmgenet_ext_writel(priv, reg, EXT_GPHY_CTRL);
Florian Fainelli0c81a8e2015-03-23 15:09:54 -0700193 udelay(60);
Florian Fainelli8212c982015-03-23 15:09:53 -0700194 }
Florian Fainelliaa096772014-02-13 16:08:48 -0800195}
196
197static void bcmgenet_internal_phy_setup(struct net_device *dev)
198{
199 struct bcmgenet_priv *priv = netdev_priv(dev);
200 u32 reg;
201
Florian Fainelli8212c982015-03-23 15:09:53 -0700202 /* Power up PHY */
203 bcmgenet_phy_power_set(dev, true);
Florian Fainelliaa096772014-02-13 16:08:48 -0800204 /* enable APD */
205 reg = bcmgenet_ext_readl(priv, EXT_EXT_PWR_MGMT);
206 reg |= EXT_PWR_DN_EN_LD;
207 bcmgenet_ext_writel(priv, reg, EXT_EXT_PWR_MGMT);
208 bcmgenet_mii_reset(dev);
209}
210
211static void bcmgenet_moca_phy_setup(struct bcmgenet_priv *priv)
212{
213 u32 reg;
214
215 /* Speed settings are set in bcmgenet_mii_setup() */
216 reg = bcmgenet_sys_readl(priv, SYS_PORT_CTRL);
217 reg |= LED_ACT_SOURCE_MAC;
218 bcmgenet_sys_writel(priv, reg, SYS_PORT_CTRL);
219}
220
Florian Fainellidbd479d2014-11-10 18:06:21 -0800221int bcmgenet_mii_config(struct net_device *dev, bool init)
Florian Fainelliaa096772014-02-13 16:08:48 -0800222{
223 struct bcmgenet_priv *priv = netdev_priv(dev);
224 struct phy_device *phydev = priv->phydev;
225 struct device *kdev = &priv->pdev->dev;
226 const char *phy_name = NULL;
227 u32 id_mode_dis = 0;
228 u32 port_ctrl;
229 u32 reg;
230
231 priv->ext_phy = !phy_is_internal(priv->phydev) &&
232 (priv->phy_interface != PHY_INTERFACE_MODE_MOCA);
233
234 if (phy_is_internal(priv->phydev))
235 priv->phy_interface = PHY_INTERFACE_MODE_NA;
236
237 switch (priv->phy_interface) {
238 case PHY_INTERFACE_MODE_NA:
239 case PHY_INTERFACE_MODE_MOCA:
240 /* Irrespective of the actually configured PHY speed (100 or
241 * 1000) GENETv4 only has an internal GPHY so we will just end
242 * up masking the Gigabit features from what we support, not
243 * switching to the EPHY
244 */
245 if (GENET_IS_V4(priv))
246 port_ctrl = PORT_MODE_INT_GPHY;
247 else
248 port_ctrl = PORT_MODE_INT_EPHY;
249
250 bcmgenet_sys_writel(priv, port_ctrl, SYS_PORT_CTRL);
251
252 if (phy_is_internal(priv->phydev)) {
253 phy_name = "internal PHY";
254 bcmgenet_internal_phy_setup(dev);
255 } else if (priv->phy_interface == PHY_INTERFACE_MODE_MOCA) {
256 phy_name = "MoCA";
257 bcmgenet_moca_phy_setup(priv);
258 }
259 break;
260
261 case PHY_INTERFACE_MODE_MII:
262 phy_name = "external MII";
263 phydev->supported &= PHY_BASIC_FEATURES;
264 bcmgenet_sys_writel(priv,
Florian Fainellic91b7f62014-07-23 10:42:12 -0700265 PORT_MODE_EXT_EPHY, SYS_PORT_CTRL);
Florian Fainelliaa096772014-02-13 16:08:48 -0800266 break;
267
268 case PHY_INTERFACE_MODE_REVMII:
269 phy_name = "external RvMII";
270 /* of_mdiobus_register took care of reading the 'max-speed'
271 * PHY property for us, effectively limiting the PHY supported
272 * capabilities, use that knowledge to also configure the
273 * Reverse MII interface correctly.
274 */
275 if ((priv->phydev->supported & PHY_BASIC_FEATURES) ==
276 PHY_BASIC_FEATURES)
277 port_ctrl = PORT_MODE_EXT_RVMII_25;
278 else
279 port_ctrl = PORT_MODE_EXT_RVMII_50;
280 bcmgenet_sys_writel(priv, port_ctrl, SYS_PORT_CTRL);
281 break;
282
283 case PHY_INTERFACE_MODE_RGMII:
284 /* RGMII_NO_ID: TXC transitions at the same time as TXD
285 * (requires PCB or receiver-side delay)
286 * RGMII: Add 2ns delay on TXC (90 degree shift)
287 *
288 * ID is implicitly disabled for 100Mbps (RG)MII operation.
289 */
290 id_mode_dis = BIT(16);
291 /* fall through */
292 case PHY_INTERFACE_MODE_RGMII_TXID:
293 if (id_mode_dis)
294 phy_name = "external RGMII (no delay)";
295 else
296 phy_name = "external RGMII (TX delay)";
297 reg = bcmgenet_ext_readl(priv, EXT_RGMII_OOB_CTRL);
298 reg |= RGMII_MODE_EN | id_mode_dis;
299 bcmgenet_ext_writel(priv, reg, EXT_RGMII_OOB_CTRL);
300 bcmgenet_sys_writel(priv,
Florian Fainellic91b7f62014-07-23 10:42:12 -0700301 PORT_MODE_EXT_GPHY, SYS_PORT_CTRL);
Florian Fainelliaa096772014-02-13 16:08:48 -0800302 break;
303 default:
304 dev_err(kdev, "unknown phy mode: %d\n", priv->phy_interface);
305 return -EINVAL;
306 }
307
Florian Fainellidbd479d2014-11-10 18:06:21 -0800308 if (init)
309 dev_info(kdev, "configuring instance for %s\n", phy_name);
Florian Fainelliaa096772014-02-13 16:08:48 -0800310
311 return 0;
312}
313
314static int bcmgenet_mii_probe(struct net_device *dev)
315{
316 struct bcmgenet_priv *priv = netdev_priv(dev);
Florian Fainelli9abf0c22014-05-22 09:47:45 -0700317 struct device_node *dn = priv->pdev->dev.of_node;
Florian Fainelliaa096772014-02-13 16:08:48 -0800318 struct phy_device *phydev;
Florian Fainelli487320c2014-09-19 13:07:53 -0700319 u32 phy_flags;
Florian Fainelliaa096772014-02-13 16:08:48 -0800320 int ret;
321
Florian Fainelli487320c2014-09-19 13:07:53 -0700322 /* Communicate the integrated PHY revision */
323 phy_flags = priv->gphy_rev;
324
Petri Gynther5ad6e6c2014-10-03 12:25:01 -0700325 /* Initialize link state variables that bcmgenet_mii_setup() uses */
326 priv->old_link = -1;
327 priv->old_speed = -1;
328 priv->old_duplex = -1;
329 priv->old_pause = -1;
330
Petri Gyntherb0ba5122014-12-01 16:18:08 -0800331 if (dn) {
332 if (priv->phydev) {
333 pr_info("PHY already attached\n");
334 return 0;
335 }
336
337 /* In the case of a fixed PHY, the DT node associated
338 * to the PHY is the Ethernet MAC DT node.
339 */
340 if (!priv->phy_dn && of_phy_is_fixed_link(dn)) {
341 ret = of_phy_register_fixed_link(dn);
342 if (ret)
343 return ret;
344
345 priv->phy_dn = of_node_get(dn);
346 }
347
348 phydev = of_phy_connect(dev, priv->phy_dn, bcmgenet_mii_setup,
349 phy_flags, priv->phy_interface);
350 if (!phydev) {
351 pr_err("could not attach to PHY\n");
352 return -ENODEV;
353 }
354 } else {
355 phydev = priv->phydev;
356 phydev->dev_flags = phy_flags;
357
358 ret = phy_connect_direct(dev, phydev, bcmgenet_mii_setup,
359 priv->phy_interface);
360 if (ret) {
361 pr_err("could not attach to PHY\n");
362 return -ENODEV;
363 }
Florian Fainelliaa096772014-02-13 16:08:48 -0800364 }
365
Florian Fainelliaa096772014-02-13 16:08:48 -0800366 priv->phydev = phydev;
367
368 /* Configure port multiplexer based on what the probed PHY device since
369 * reading the 'max-speed' property determines the maximum supported
370 * PHY speed which is needed for bcmgenet_mii_config() to configure
371 * things appropriately.
372 */
Florian Fainellidbd479d2014-11-10 18:06:21 -0800373 ret = bcmgenet_mii_config(dev, true);
Florian Fainelliaa096772014-02-13 16:08:48 -0800374 if (ret) {
375 phy_disconnect(priv->phydev);
376 return ret;
377 }
378
Florian Fainelliaa096772014-02-13 16:08:48 -0800379 phydev->advertising = phydev->supported;
380
381 /* The internal PHY has its link interrupts routed to the
382 * Ethernet MAC ISRs
383 */
384 if (phy_is_internal(priv->phydev))
385 priv->mii_bus->irq[phydev->addr] = PHY_IGNORE_INTERRUPT;
386 else
387 priv->mii_bus->irq[phydev->addr] = PHY_POLL;
388
389 pr_info("attached PHY at address %d [%s]\n",
Florian Fainellic91b7f62014-07-23 10:42:12 -0700390 phydev->addr, phydev->drv->name);
Florian Fainelliaa096772014-02-13 16:08:48 -0800391
392 return 0;
393}
394
395static int bcmgenet_mii_alloc(struct bcmgenet_priv *priv)
396{
397 struct mii_bus *bus;
398
399 if (priv->mii_bus)
400 return 0;
401
402 priv->mii_bus = mdiobus_alloc();
403 if (!priv->mii_bus) {
404 pr_err("failed to allocate\n");
405 return -ENOMEM;
406 }
407
408 bus = priv->mii_bus;
409 bus->priv = priv->dev;
410 bus->name = "bcmgenet MII bus";
411 bus->parent = &priv->pdev->dev;
412 bus->read = bcmgenet_mii_read;
413 bus->write = bcmgenet_mii_write;
414 snprintf(bus->id, MII_BUS_ID_SIZE, "%s-%d",
Florian Fainellic91b7f62014-07-23 10:42:12 -0700415 priv->pdev->name, priv->pdev->id);
Florian Fainelliaa096772014-02-13 16:08:48 -0800416
Florian Fainellic489be02014-07-23 10:42:15 -0700417 bus->irq = kcalloc(PHY_MAX_ADDR, sizeof(int), GFP_KERNEL);
Florian Fainelliaa096772014-02-13 16:08:48 -0800418 if (!bus->irq) {
419 mdiobus_free(priv->mii_bus);
420 return -ENOMEM;
421 }
422
423 return 0;
424}
425
426static int bcmgenet_mii_of_init(struct bcmgenet_priv *priv)
427{
428 struct device_node *dn = priv->pdev->dev.of_node;
429 struct device *kdev = &priv->pdev->dev;
430 struct device_node *mdio_dn;
431 char *compat;
432 int ret;
433
434 compat = kasprintf(GFP_KERNEL, "brcm,genet-mdio-v%d", priv->version);
435 if (!compat)
436 return -ENOMEM;
437
438 mdio_dn = of_find_compatible_node(dn, NULL, compat);
439 kfree(compat);
440 if (!mdio_dn) {
441 dev_err(kdev, "unable to find MDIO bus node\n");
442 return -ENODEV;
443 }
444
445 ret = of_mdiobus_register(priv->mii_bus, mdio_dn);
446 if (ret) {
447 dev_err(kdev, "failed to register MDIO bus\n");
448 return ret;
449 }
450
451 /* Fetch the PHY phandle */
452 priv->phy_dn = of_parse_phandle(dn, "phy-handle", 0);
453
454 /* Get the link mode */
455 priv->phy_interface = of_get_phy_mode(dn);
456
457 return 0;
458}
459
Petri Gyntherb0ba5122014-12-01 16:18:08 -0800460static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
461{
462 struct device *kdev = &priv->pdev->dev;
463 struct bcmgenet_platform_data *pd = kdev->platform_data;
464 struct mii_bus *mdio = priv->mii_bus;
465 struct phy_device *phydev;
466 int ret;
467
468 if (pd->phy_interface != PHY_INTERFACE_MODE_MOCA && pd->mdio_enabled) {
469 /*
470 * Internal or external PHY with MDIO access
471 */
472 if (pd->phy_address >= 0 && pd->phy_address < PHY_MAX_ADDR)
473 mdio->phy_mask = ~(1 << pd->phy_address);
474 else
475 mdio->phy_mask = 0;
476
477 ret = mdiobus_register(mdio);
478 if (ret) {
479 dev_err(kdev, "failed to register MDIO bus\n");
480 return ret;
481 }
482
483 if (pd->phy_address >= 0 && pd->phy_address < PHY_MAX_ADDR)
484 phydev = mdio->phy_map[pd->phy_address];
485 else
486 phydev = phy_find_first(mdio);
487
488 if (!phydev) {
489 dev_err(kdev, "failed to register PHY device\n");
490 mdiobus_unregister(mdio);
491 return -ENODEV;
492 }
493 } else {
494 /*
495 * MoCA port or no MDIO access.
496 * Use fixed PHY to represent the link layer.
497 */
498 struct fixed_phy_status fphy_status = {
499 .link = 1,
500 .speed = pd->phy_speed,
501 .duplex = pd->phy_duplex,
502 .pause = 0,
503 .asym_pause = 0,
504 };
505
506 phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
507 if (!phydev || IS_ERR(phydev)) {
508 dev_err(kdev, "failed to register fixed PHY device\n");
509 return -ENODEV;
510 }
511 }
512
513 priv->phydev = phydev;
514 priv->phy_interface = pd->phy_interface;
515
516 return 0;
517}
518
519static int bcmgenet_mii_bus_init(struct bcmgenet_priv *priv)
520{
521 struct device_node *dn = priv->pdev->dev.of_node;
522
523 if (dn)
524 return bcmgenet_mii_of_init(priv);
525 else
526 return bcmgenet_mii_pd_init(priv);
527}
528
Florian Fainelliaa096772014-02-13 16:08:48 -0800529int bcmgenet_mii_init(struct net_device *dev)
530{
531 struct bcmgenet_priv *priv = netdev_priv(dev);
532 int ret;
533
534 ret = bcmgenet_mii_alloc(priv);
535 if (ret)
536 return ret;
537
Petri Gyntherb0ba5122014-12-01 16:18:08 -0800538 ret = bcmgenet_mii_bus_init(priv);
Florian Fainelliaa096772014-02-13 16:08:48 -0800539 if (ret)
540 goto out_free;
541
542 ret = bcmgenet_mii_probe(dev);
543 if (ret)
544 goto out;
545
546 return 0;
547
548out:
Uwe Kleine-König95182592014-08-07 22:53:40 +0200549 of_node_put(priv->phy_dn);
Florian Fainelliaa096772014-02-13 16:08:48 -0800550 mdiobus_unregister(priv->mii_bus);
551out_free:
552 kfree(priv->mii_bus->irq);
553 mdiobus_free(priv->mii_bus);
554 return ret;
555}
556
557void bcmgenet_mii_exit(struct net_device *dev)
558{
559 struct bcmgenet_priv *priv = netdev_priv(dev);
560
Uwe Kleine-König95182592014-08-07 22:53:40 +0200561 of_node_put(priv->phy_dn);
Florian Fainelliaa096772014-02-13 16:08:48 -0800562 mdiobus_unregister(priv->mii_bus);
563 kfree(priv->mii_bus->irq);
564 mdiobus_free(priv->mii_bus);
565}