Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright © 2008,2010 Intel Corporation |
| 3 | * |
| 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 5 | * copy of this software and associated documentation files (the "Software"), |
| 6 | * to deal in the Software without restriction, including without limitation |
| 7 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 8 | * and/or sell copies of the Software, and to permit persons to whom the |
| 9 | * Software is furnished to do so, subject to the following conditions: |
| 10 | * |
| 11 | * The above copyright notice and this permission notice (including the next |
| 12 | * paragraph) shall be included in all copies or substantial portions of the |
| 13 | * Software. |
| 14 | * |
| 15 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
| 16 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 17 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 18 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
| 19 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING |
| 20 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS |
| 21 | * IN THE SOFTWARE. |
| 22 | * |
| 23 | * Authors: |
| 24 | * Eric Anholt <eric@anholt.net> |
| 25 | * Chris Wilson <chris@chris-wilson.co.uk> |
| 26 | * |
| 27 | */ |
| 28 | |
David Howells | 760285e | 2012-10-02 18:01:07 +0100 | [diff] [blame] | 29 | #include <drm/drmP.h> |
| 30 | #include <drm/i915_drm.h> |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 31 | #include "i915_drv.h" |
| 32 | #include "i915_trace.h" |
| 33 | #include "intel_drv.h" |
Eugeni Dodonov | f45b555 | 2011-12-09 17:16:37 -0800 | [diff] [blame] | 34 | #include <linux/dma_remapping.h> |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 35 | |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 36 | #define __EXEC_OBJECT_HAS_PIN (1<<31) |
| 37 | #define __EXEC_OBJECT_HAS_FENCE (1<<30) |
| 38 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 39 | struct eb_vmas { |
| 40 | struct list_head vmas; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 41 | int and; |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 42 | union { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 43 | struct i915_vma *lut[0]; |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 44 | struct hlist_head buckets[0]; |
| 45 | }; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 46 | }; |
| 47 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 48 | static struct eb_vmas * |
Ben Widawsky | 17601cbc | 2013-11-25 09:54:38 -0800 | [diff] [blame] | 49 | eb_create(struct drm_i915_gem_execbuffer2 *args) |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 50 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 51 | struct eb_vmas *eb = NULL; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 52 | |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 53 | if (args->flags & I915_EXEC_HANDLE_LUT) { |
Daniel Vetter | b205ca5 | 2013-09-19 14:00:11 +0200 | [diff] [blame] | 54 | unsigned size = args->buffer_count; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 55 | size *= sizeof(struct i915_vma *); |
| 56 | size += sizeof(struct eb_vmas); |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 57 | eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY); |
| 58 | } |
| 59 | |
| 60 | if (eb == NULL) { |
Daniel Vetter | b205ca5 | 2013-09-19 14:00:11 +0200 | [diff] [blame] | 61 | unsigned size = args->buffer_count; |
| 62 | unsigned count = PAGE_SIZE / sizeof(struct hlist_head) / 2; |
Lauri Kasanen | 27b7c63 | 2013-03-27 15:04:55 +0200 | [diff] [blame] | 63 | BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head)); |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 64 | while (count > 2*size) |
| 65 | count >>= 1; |
| 66 | eb = kzalloc(count*sizeof(struct hlist_head) + |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 67 | sizeof(struct eb_vmas), |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 68 | GFP_TEMPORARY); |
| 69 | if (eb == NULL) |
| 70 | return eb; |
| 71 | |
| 72 | eb->and = count - 1; |
| 73 | } else |
| 74 | eb->and = -args->buffer_count; |
| 75 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 76 | INIT_LIST_HEAD(&eb->vmas); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 77 | return eb; |
| 78 | } |
| 79 | |
| 80 | static void |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 81 | eb_reset(struct eb_vmas *eb) |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 82 | { |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 83 | if (eb->and >= 0) |
| 84 | memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head)); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 85 | } |
| 86 | |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 87 | static int |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 88 | eb_lookup_vmas(struct eb_vmas *eb, |
| 89 | struct drm_i915_gem_exec_object2 *exec, |
| 90 | const struct drm_i915_gem_execbuffer2 *args, |
| 91 | struct i915_address_space *vm, |
| 92 | struct drm_file *file) |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 93 | { |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 94 | struct drm_i915_private *dev_priv = vm->dev->dev_private; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 95 | struct drm_i915_gem_object *obj; |
| 96 | struct list_head objects; |
| 97 | int i, ret = 0; |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 98 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 99 | INIT_LIST_HEAD(&objects); |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 100 | spin_lock(&file->table_lock); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 101 | /* Grab a reference to the object and release the lock so we can lookup |
| 102 | * or create the VMA without using GFP_ATOMIC */ |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 103 | for (i = 0; i < args->buffer_count; i++) { |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 104 | obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle)); |
| 105 | if (obj == NULL) { |
| 106 | spin_unlock(&file->table_lock); |
| 107 | DRM_DEBUG("Invalid object handle %d at index %d\n", |
| 108 | exec[i].handle, i); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 109 | ret = -ENOENT; |
| 110 | goto out; |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 111 | } |
| 112 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 113 | if (!list_empty(&obj->obj_exec_link)) { |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 114 | spin_unlock(&file->table_lock); |
| 115 | DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n", |
| 116 | obj, exec[i].handle, i); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 117 | ret = -EINVAL; |
| 118 | goto out; |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 119 | } |
| 120 | |
| 121 | drm_gem_object_reference(&obj->base); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 122 | list_add_tail(&obj->obj_exec_link, &objects); |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 123 | } |
| 124 | spin_unlock(&file->table_lock); |
| 125 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 126 | i = 0; |
| 127 | list_for_each_entry(obj, &objects, obj_exec_link) { |
| 128 | struct i915_vma *vma; |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 129 | struct i915_address_space *bind_vm = vm; |
| 130 | |
Daniel Vetter | 2c9f8d5 | 2013-12-18 17:38:53 +0100 | [diff] [blame^] | 131 | if (exec[i].flags & EXEC_OBJECT_NEEDS_GTT && |
| 132 | USES_FULL_PPGTT(vm->dev)) { |
| 133 | ret = -EINVAL; |
| 134 | goto out; |
| 135 | } |
| 136 | |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 137 | /* If we have secure dispatch, or the userspace assures us that |
| 138 | * they know what they're doing, use the GGTT VM. |
| 139 | */ |
| 140 | if (exec[i].flags & EXEC_OBJECT_NEEDS_GTT || |
| 141 | ((args->flags & I915_EXEC_SECURE) && |
| 142 | (i == (args->buffer_count - 1)))) |
| 143 | bind_vm = &dev_priv->gtt.base; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 144 | |
Daniel Vetter | e656a6c | 2013-08-14 14:14:04 +0200 | [diff] [blame] | 145 | /* |
| 146 | * NOTE: We can leak any vmas created here when something fails |
| 147 | * later on. But that's no issue since vma_unbind can deal with |
| 148 | * vmas which are not actually bound. And since only |
| 149 | * lookup_or_create exists as an interface to get at the vma |
| 150 | * from the (obj, vm) we don't run the risk of creating |
| 151 | * duplicated vmas for the same vm. |
| 152 | */ |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 153 | vma = i915_gem_obj_lookup_or_create_vma(obj, bind_vm); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 154 | if (IS_ERR(vma)) { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 155 | DRM_DEBUG("Failed to lookup VMA\n"); |
| 156 | ret = PTR_ERR(vma); |
| 157 | goto out; |
| 158 | } |
| 159 | |
| 160 | list_add_tail(&vma->exec_list, &eb->vmas); |
| 161 | |
| 162 | vma->exec_entry = &exec[i]; |
| 163 | if (eb->and < 0) { |
| 164 | eb->lut[i] = vma; |
| 165 | } else { |
| 166 | uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle; |
| 167 | vma->exec_handle = handle; |
| 168 | hlist_add_head(&vma->exec_node, |
| 169 | &eb->buckets[handle & eb->and]); |
| 170 | } |
| 171 | ++i; |
| 172 | } |
| 173 | |
| 174 | |
| 175 | out: |
| 176 | while (!list_empty(&objects)) { |
| 177 | obj = list_first_entry(&objects, |
| 178 | struct drm_i915_gem_object, |
| 179 | obj_exec_link); |
| 180 | list_del_init(&obj->obj_exec_link); |
| 181 | if (ret) |
| 182 | drm_gem_object_unreference(&obj->base); |
| 183 | } |
| 184 | return ret; |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 185 | } |
| 186 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 187 | static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle) |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 188 | { |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 189 | if (eb->and < 0) { |
| 190 | if (handle >= -eb->and) |
| 191 | return NULL; |
| 192 | return eb->lut[handle]; |
| 193 | } else { |
| 194 | struct hlist_head *head; |
| 195 | struct hlist_node *node; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 196 | |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 197 | head = &eb->buckets[handle & eb->and]; |
| 198 | hlist_for_each(node, head) { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 199 | struct i915_vma *vma; |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 200 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 201 | vma = hlist_entry(node, struct i915_vma, exec_node); |
| 202 | if (vma->exec_handle == handle) |
| 203 | return vma; |
Chris Wilson | eef90cc | 2013-01-08 10:53:17 +0000 | [diff] [blame] | 204 | } |
| 205 | return NULL; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 206 | } |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 207 | } |
| 208 | |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 209 | static void |
| 210 | i915_gem_execbuffer_unreserve_vma(struct i915_vma *vma) |
| 211 | { |
| 212 | struct drm_i915_gem_exec_object2 *entry; |
| 213 | struct drm_i915_gem_object *obj = vma->obj; |
| 214 | |
| 215 | if (!drm_mm_node_allocated(&vma->node)) |
| 216 | return; |
| 217 | |
| 218 | entry = vma->exec_entry; |
| 219 | |
| 220 | if (entry->flags & __EXEC_OBJECT_HAS_FENCE) |
| 221 | i915_gem_object_unpin_fence(obj); |
| 222 | |
| 223 | if (entry->flags & __EXEC_OBJECT_HAS_PIN) |
Daniel Vetter | 3d7f0f9 | 2013-12-18 16:23:37 +0100 | [diff] [blame] | 224 | vma->pin_count--; |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 225 | |
| 226 | entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN); |
| 227 | } |
| 228 | |
| 229 | static void eb_destroy(struct eb_vmas *eb) |
| 230 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 231 | while (!list_empty(&eb->vmas)) { |
| 232 | struct i915_vma *vma; |
Chris Wilson | bcffc3f | 2013-01-08 10:53:15 +0000 | [diff] [blame] | 233 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 234 | vma = list_first_entry(&eb->vmas, |
| 235 | struct i915_vma, |
Chris Wilson | bcffc3f | 2013-01-08 10:53:15 +0000 | [diff] [blame] | 236 | exec_list); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 237 | list_del_init(&vma->exec_list); |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 238 | i915_gem_execbuffer_unreserve_vma(vma); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 239 | drm_gem_object_unreference(&vma->obj->base); |
Chris Wilson | bcffc3f | 2013-01-08 10:53:15 +0000 | [diff] [blame] | 240 | } |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 241 | kfree(eb); |
| 242 | } |
| 243 | |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 244 | static inline int use_cpu_reloc(struct drm_i915_gem_object *obj) |
| 245 | { |
Chris Wilson | 2cc86b8 | 2013-08-26 19:51:00 -0300 | [diff] [blame] | 246 | return (HAS_LLC(obj->base.dev) || |
| 247 | obj->base.write_domain == I915_GEM_DOMAIN_CPU || |
Chris Wilson | 504c726 | 2012-08-23 13:12:52 +0100 | [diff] [blame] | 248 | !obj->map_and_fenceable || |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 249 | obj->cache_level != I915_CACHE_NONE); |
| 250 | } |
| 251 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 252 | static int |
Rafael Barbalho | 5032d87 | 2013-08-21 17:10:51 +0100 | [diff] [blame] | 253 | relocate_entry_cpu(struct drm_i915_gem_object *obj, |
| 254 | struct drm_i915_gem_relocation_entry *reloc) |
| 255 | { |
Ben Widawsky | 3c94cee | 2013-11-02 21:07:11 -0700 | [diff] [blame] | 256 | struct drm_device *dev = obj->base.dev; |
Rafael Barbalho | 5032d87 | 2013-08-21 17:10:51 +0100 | [diff] [blame] | 257 | uint32_t page_offset = offset_in_page(reloc->offset); |
| 258 | char *vaddr; |
| 259 | int ret = -EINVAL; |
| 260 | |
Chris Wilson | 2cc86b8 | 2013-08-26 19:51:00 -0300 | [diff] [blame] | 261 | ret = i915_gem_object_set_to_cpu_domain(obj, true); |
Rafael Barbalho | 5032d87 | 2013-08-21 17:10:51 +0100 | [diff] [blame] | 262 | if (ret) |
| 263 | return ret; |
| 264 | |
| 265 | vaddr = kmap_atomic(i915_gem_object_get_page(obj, |
| 266 | reloc->offset >> PAGE_SHIFT)); |
| 267 | *(uint32_t *)(vaddr + page_offset) = reloc->delta; |
Ben Widawsky | 3c94cee | 2013-11-02 21:07:11 -0700 | [diff] [blame] | 268 | |
| 269 | if (INTEL_INFO(dev)->gen >= 8) { |
| 270 | page_offset = offset_in_page(page_offset + sizeof(uint32_t)); |
| 271 | |
| 272 | if (page_offset == 0) { |
| 273 | kunmap_atomic(vaddr); |
| 274 | vaddr = kmap_atomic(i915_gem_object_get_page(obj, |
| 275 | (reloc->offset + sizeof(uint32_t)) >> PAGE_SHIFT)); |
| 276 | } |
| 277 | |
| 278 | *(uint32_t *)(vaddr + page_offset) = 0; |
| 279 | } |
| 280 | |
Rafael Barbalho | 5032d87 | 2013-08-21 17:10:51 +0100 | [diff] [blame] | 281 | kunmap_atomic(vaddr); |
| 282 | |
| 283 | return 0; |
| 284 | } |
| 285 | |
| 286 | static int |
| 287 | relocate_entry_gtt(struct drm_i915_gem_object *obj, |
| 288 | struct drm_i915_gem_relocation_entry *reloc) |
| 289 | { |
| 290 | struct drm_device *dev = obj->base.dev; |
| 291 | struct drm_i915_private *dev_priv = dev->dev_private; |
| 292 | uint32_t __iomem *reloc_entry; |
| 293 | void __iomem *reloc_page; |
| 294 | int ret = -EINVAL; |
| 295 | |
| 296 | ret = i915_gem_object_set_to_gtt_domain(obj, true); |
| 297 | if (ret) |
| 298 | return ret; |
| 299 | |
| 300 | ret = i915_gem_object_put_fence(obj); |
| 301 | if (ret) |
| 302 | return ret; |
| 303 | |
| 304 | /* Map the page containing the relocation we're going to perform. */ |
| 305 | reloc->offset += i915_gem_obj_ggtt_offset(obj); |
| 306 | reloc_page = io_mapping_map_atomic_wc(dev_priv->gtt.mappable, |
| 307 | reloc->offset & PAGE_MASK); |
| 308 | reloc_entry = (uint32_t __iomem *) |
| 309 | (reloc_page + offset_in_page(reloc->offset)); |
| 310 | iowrite32(reloc->delta, reloc_entry); |
Ben Widawsky | 3c94cee | 2013-11-02 21:07:11 -0700 | [diff] [blame] | 311 | |
| 312 | if (INTEL_INFO(dev)->gen >= 8) { |
| 313 | reloc_entry += 1; |
| 314 | |
| 315 | if (offset_in_page(reloc->offset + sizeof(uint32_t)) == 0) { |
| 316 | io_mapping_unmap_atomic(reloc_page); |
| 317 | reloc_page = io_mapping_map_atomic_wc( |
| 318 | dev_priv->gtt.mappable, |
| 319 | reloc->offset + sizeof(uint32_t)); |
| 320 | reloc_entry = reloc_page; |
| 321 | } |
| 322 | |
| 323 | iowrite32(0, reloc_entry); |
| 324 | } |
| 325 | |
Rafael Barbalho | 5032d87 | 2013-08-21 17:10:51 +0100 | [diff] [blame] | 326 | io_mapping_unmap_atomic(reloc_page); |
| 327 | |
| 328 | return 0; |
| 329 | } |
| 330 | |
| 331 | static int |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 332 | i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj, |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 333 | struct eb_vmas *eb, |
Ben Widawsky | 3e7a032 | 2013-12-06 14:10:57 -0800 | [diff] [blame] | 334 | struct drm_i915_gem_relocation_entry *reloc) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 335 | { |
| 336 | struct drm_device *dev = obj->base.dev; |
| 337 | struct drm_gem_object *target_obj; |
Daniel Vetter | 149c840 | 2012-02-15 23:50:23 +0100 | [diff] [blame] | 338 | struct drm_i915_gem_object *target_i915_obj; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 339 | struct i915_vma *target_vma; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 340 | uint32_t target_offset; |
| 341 | int ret = -EINVAL; |
| 342 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 343 | /* we've already hold a reference to all valid objects */ |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 344 | target_vma = eb_get_vma(eb, reloc->target_handle); |
| 345 | if (unlikely(target_vma == NULL)) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 346 | return -ENOENT; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 347 | target_i915_obj = target_vma->obj; |
| 348 | target_obj = &target_vma->obj->base; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 349 | |
Ben Widawsky | 5ce0972 | 2013-11-25 09:54:40 -0800 | [diff] [blame] | 350 | target_offset = target_vma->node.start; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 351 | |
Eric Anholt | e844b99 | 2012-07-31 15:35:01 -0700 | [diff] [blame] | 352 | /* Sandybridge PPGTT errata: We need a global gtt mapping for MI and |
| 353 | * pipe_control writes because the gpu doesn't properly redirect them |
| 354 | * through the ppgtt for non_secure batchbuffers. */ |
| 355 | if (unlikely(IS_GEN6(dev) && |
| 356 | reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION && |
| 357 | !target_i915_obj->has_global_gtt_mapping)) { |
Ben Widawsky | 3e7a032 | 2013-12-06 14:10:57 -0800 | [diff] [blame] | 358 | struct i915_vma *vma = |
| 359 | list_first_entry(&target_i915_obj->vma_list, |
| 360 | typeof(*vma), vma_link); |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 361 | vma->bind_vma(vma, target_i915_obj->cache_level, GLOBAL_BIND); |
Eric Anholt | e844b99 | 2012-07-31 15:35:01 -0700 | [diff] [blame] | 362 | } |
| 363 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 364 | /* Validate that the target is in a valid r/w GPU domain */ |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 365 | if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 366 | DRM_DEBUG("reloc with multiple write domains: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 367 | "obj %p target %d offset %d " |
| 368 | "read %08x write %08x", |
| 369 | obj, reloc->target_handle, |
| 370 | (int) reloc->offset, |
| 371 | reloc->read_domains, |
| 372 | reloc->write_domain); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 373 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 374 | } |
Daniel Vetter | 4ca4a25 | 2011-12-14 13:57:27 +0100 | [diff] [blame] | 375 | if (unlikely((reloc->write_domain | reloc->read_domains) |
| 376 | & ~I915_GEM_GPU_DOMAINS)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 377 | DRM_DEBUG("reloc with read/write non-GPU domains: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 378 | "obj %p target %d offset %d " |
| 379 | "read %08x write %08x", |
| 380 | obj, reloc->target_handle, |
| 381 | (int) reloc->offset, |
| 382 | reloc->read_domains, |
| 383 | reloc->write_domain); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 384 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 385 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 386 | |
| 387 | target_obj->pending_read_domains |= reloc->read_domains; |
| 388 | target_obj->pending_write_domain |= reloc->write_domain; |
| 389 | |
| 390 | /* If the relocation already has the right value in it, no |
| 391 | * more work needs to be done. |
| 392 | */ |
| 393 | if (target_offset == reloc->presumed_offset) |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 394 | return 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 395 | |
| 396 | /* Check that the relocation address is valid... */ |
Ben Widawsky | 3c94cee | 2013-11-02 21:07:11 -0700 | [diff] [blame] | 397 | if (unlikely(reloc->offset > |
| 398 | obj->base.size - (INTEL_INFO(dev)->gen >= 8 ? 8 : 4))) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 399 | DRM_DEBUG("Relocation beyond object bounds: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 400 | "obj %p target %d offset %d size %d.\n", |
| 401 | obj, reloc->target_handle, |
| 402 | (int) reloc->offset, |
| 403 | (int) obj->base.size); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 404 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 405 | } |
Chris Wilson | b8f7ab1 | 2010-12-08 10:43:06 +0000 | [diff] [blame] | 406 | if (unlikely(reloc->offset & 3)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 407 | DRM_DEBUG("Relocation not 4-byte aligned: " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 408 | "obj %p target %d offset %d.\n", |
| 409 | obj, reloc->target_handle, |
| 410 | (int) reloc->offset); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 411 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 412 | } |
| 413 | |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 414 | /* We can't wait for rendering with pagefaults disabled */ |
| 415 | if (obj->active && in_atomic()) |
| 416 | return -EFAULT; |
| 417 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 418 | reloc->delta += target_offset; |
Rafael Barbalho | 5032d87 | 2013-08-21 17:10:51 +0100 | [diff] [blame] | 419 | if (use_cpu_reloc(obj)) |
| 420 | ret = relocate_entry_cpu(obj, reloc); |
| 421 | else |
| 422 | ret = relocate_entry_gtt(obj, reloc); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 423 | |
Daniel Vetter | d4d3601 | 2013-09-02 20:56:23 +0200 | [diff] [blame] | 424 | if (ret) |
| 425 | return ret; |
| 426 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 427 | /* and update the user's relocation entry */ |
| 428 | reloc->presumed_offset = target_offset; |
| 429 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 430 | return 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 431 | } |
| 432 | |
| 433 | static int |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 434 | i915_gem_execbuffer_relocate_vma(struct i915_vma *vma, |
| 435 | struct eb_vmas *eb) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 436 | { |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 437 | #define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry)) |
| 438 | struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(512)]; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 439 | struct drm_i915_gem_relocation_entry __user *user_relocs; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 440 | struct drm_i915_gem_exec_object2 *entry = vma->exec_entry; |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 441 | int remain, ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 442 | |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 443 | user_relocs = to_user_ptr(entry->relocs_ptr); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 444 | |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 445 | remain = entry->relocation_count; |
| 446 | while (remain) { |
| 447 | struct drm_i915_gem_relocation_entry *r = stack_reloc; |
| 448 | int count = remain; |
| 449 | if (count > ARRAY_SIZE(stack_reloc)) |
| 450 | count = ARRAY_SIZE(stack_reloc); |
| 451 | remain -= count; |
| 452 | |
| 453 | if (__copy_from_user_inatomic(r, user_relocs, count*sizeof(r[0]))) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 454 | return -EFAULT; |
| 455 | |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 456 | do { |
| 457 | u64 offset = r->presumed_offset; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 458 | |
Ben Widawsky | 3e7a032 | 2013-12-06 14:10:57 -0800 | [diff] [blame] | 459 | ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, r); |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 460 | if (ret) |
| 461 | return ret; |
| 462 | |
| 463 | if (r->presumed_offset != offset && |
| 464 | __copy_to_user_inatomic(&user_relocs->presumed_offset, |
| 465 | &r->presumed_offset, |
| 466 | sizeof(r->presumed_offset))) { |
| 467 | return -EFAULT; |
| 468 | } |
| 469 | |
| 470 | user_relocs++; |
| 471 | r++; |
| 472 | } while (--count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 473 | } |
| 474 | |
| 475 | return 0; |
Chris Wilson | 1d83f44 | 2012-03-24 20:12:53 +0000 | [diff] [blame] | 476 | #undef N_RELOC |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 477 | } |
| 478 | |
| 479 | static int |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 480 | i915_gem_execbuffer_relocate_vma_slow(struct i915_vma *vma, |
| 481 | struct eb_vmas *eb, |
| 482 | struct drm_i915_gem_relocation_entry *relocs) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 483 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 484 | const struct drm_i915_gem_exec_object2 *entry = vma->exec_entry; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 485 | int i, ret; |
| 486 | |
| 487 | for (i = 0; i < entry->relocation_count; i++) { |
Ben Widawsky | 3e7a032 | 2013-12-06 14:10:57 -0800 | [diff] [blame] | 488 | ret = i915_gem_execbuffer_relocate_entry(vma->obj, eb, &relocs[i]); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 489 | if (ret) |
| 490 | return ret; |
| 491 | } |
| 492 | |
| 493 | return 0; |
| 494 | } |
| 495 | |
| 496 | static int |
Ben Widawsky | 17601cbc | 2013-11-25 09:54:38 -0800 | [diff] [blame] | 497 | i915_gem_execbuffer_relocate(struct eb_vmas *eb) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 498 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 499 | struct i915_vma *vma; |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 500 | int ret = 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 501 | |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 502 | /* This is the fast path and we cannot handle a pagefault whilst |
| 503 | * holding the struct mutex lest the user pass in the relocations |
| 504 | * contained within a mmaped bo. For in such a case we, the page |
| 505 | * fault handler would call i915_gem_fault() and we would try to |
| 506 | * acquire the struct mutex again. Obviously this is bad and so |
| 507 | * lockdep complains vehemently. |
| 508 | */ |
| 509 | pagefault_disable(); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 510 | list_for_each_entry(vma, &eb->vmas, exec_list) { |
| 511 | ret = i915_gem_execbuffer_relocate_vma(vma, eb); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 512 | if (ret) |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 513 | break; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 514 | } |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 515 | pagefault_enable(); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 516 | |
Chris Wilson | d4aeee7 | 2011-03-14 15:11:24 +0000 | [diff] [blame] | 517 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 518 | } |
| 519 | |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 520 | static int |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 521 | need_reloc_mappable(struct i915_vma *vma) |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 522 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 523 | struct drm_i915_gem_exec_object2 *entry = vma->exec_entry; |
| 524 | return entry->relocation_count && !use_cpu_reloc(vma->obj) && |
| 525 | i915_is_ggtt(vma->vm); |
Chris Wilson | dabdfe0 | 2012-03-26 10:10:27 +0200 | [diff] [blame] | 526 | } |
| 527 | |
| 528 | static int |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 529 | i915_gem_execbuffer_reserve_vma(struct i915_vma *vma, |
| 530 | struct intel_ring_buffer *ring, |
| 531 | bool *need_reloc) |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 532 | { |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 533 | struct drm_i915_gem_object *obj = vma->obj; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 534 | struct drm_i915_gem_exec_object2 *entry = vma->exec_entry; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 535 | bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4; |
| 536 | bool need_fence, need_mappable; |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 537 | u32 flags = (entry->flags & EXEC_OBJECT_NEEDS_GTT) && |
| 538 | !vma->obj->has_global_gtt_mapping ? GLOBAL_BIND : 0; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 539 | int ret; |
| 540 | |
| 541 | need_fence = |
| 542 | has_fenced_gpu_access && |
| 543 | entry->flags & EXEC_OBJECT_NEEDS_FENCE && |
| 544 | obj->tiling_mode != I915_TILING_NONE; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 545 | need_mappable = need_fence || need_reloc_mappable(vma); |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 546 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 547 | ret = i915_gem_object_pin(obj, vma->vm, entry->alignment, need_mappable, |
Ben Widawsky | 28d6a7b | 2013-07-31 17:00:02 -0700 | [diff] [blame] | 548 | false); |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 549 | if (ret) |
| 550 | return ret; |
| 551 | |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 552 | entry->flags |= __EXEC_OBJECT_HAS_PIN; |
| 553 | |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 554 | if (has_fenced_gpu_access) { |
| 555 | if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) { |
Chris Wilson | 06d9813 | 2012-04-17 15:31:24 +0100 | [diff] [blame] | 556 | ret = i915_gem_object_get_fence(obj); |
Chris Wilson | 9a5a53b | 2012-03-22 15:10:00 +0000 | [diff] [blame] | 557 | if (ret) |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 558 | return ret; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 559 | |
Chris Wilson | 9a5a53b | 2012-03-22 15:10:00 +0000 | [diff] [blame] | 560 | if (i915_gem_object_pin_fence(obj)) |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 561 | entry->flags |= __EXEC_OBJECT_HAS_FENCE; |
Chris Wilson | 9a5a53b | 2012-03-22 15:10:00 +0000 | [diff] [blame] | 562 | |
Chris Wilson | 7dd4906 | 2012-03-21 10:48:18 +0000 | [diff] [blame] | 563 | obj->pending_fenced_gpu_access = true; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 564 | } |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 565 | } |
| 566 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 567 | if (entry->offset != vma->node.start) { |
| 568 | entry->offset = vma->node.start; |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 569 | *need_reloc = true; |
| 570 | } |
| 571 | |
| 572 | if (entry->flags & EXEC_OBJECT_WRITE) { |
| 573 | obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER; |
| 574 | obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER; |
| 575 | } |
| 576 | |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 577 | vma->bind_vma(vma, obj->cache_level, flags); |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 578 | |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 579 | return 0; |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 580 | } |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 581 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 582 | static int |
Chris Wilson | d9e86c0 | 2010-11-10 16:40:20 +0000 | [diff] [blame] | 583 | i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring, |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 584 | struct list_head *vmas, |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 585 | bool *need_relocs) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 586 | { |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 587 | struct drm_i915_gem_object *obj; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 588 | struct i915_vma *vma; |
Ben Widawsky | 68c8c17 | 2013-09-11 14:57:50 -0700 | [diff] [blame] | 589 | struct i915_address_space *vm; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 590 | struct list_head ordered_vmas; |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 591 | bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4; |
| 592 | int retry; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 593 | |
Ben Widawsky | 68c8c17 | 2013-09-11 14:57:50 -0700 | [diff] [blame] | 594 | if (list_empty(vmas)) |
| 595 | return 0; |
| 596 | |
| 597 | vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm; |
| 598 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 599 | INIT_LIST_HEAD(&ordered_vmas); |
| 600 | while (!list_empty(vmas)) { |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 601 | struct drm_i915_gem_exec_object2 *entry; |
| 602 | bool need_fence, need_mappable; |
| 603 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 604 | vma = list_first_entry(vmas, struct i915_vma, exec_list); |
| 605 | obj = vma->obj; |
| 606 | entry = vma->exec_entry; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 607 | |
| 608 | need_fence = |
| 609 | has_fenced_gpu_access && |
| 610 | entry->flags & EXEC_OBJECT_NEEDS_FENCE && |
| 611 | obj->tiling_mode != I915_TILING_NONE; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 612 | need_mappable = need_fence || need_reloc_mappable(vma); |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 613 | |
| 614 | if (need_mappable) |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 615 | list_move(&vma->exec_list, &ordered_vmas); |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 616 | else |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 617 | list_move_tail(&vma->exec_list, &ordered_vmas); |
Chris Wilson | 595dad7 | 2011-01-13 11:03:48 +0000 | [diff] [blame] | 618 | |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 619 | obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND; |
Chris Wilson | 595dad7 | 2011-01-13 11:03:48 +0000 | [diff] [blame] | 620 | obj->base.pending_write_domain = 0; |
Chris Wilson | 016fd0c | 2012-07-20 12:41:07 +0100 | [diff] [blame] | 621 | obj->pending_fenced_gpu_access = false; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 622 | } |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 623 | list_splice(&ordered_vmas, vmas); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 624 | |
| 625 | /* Attempt to pin all of the buffers into the GTT. |
| 626 | * This is done in 3 phases: |
| 627 | * |
| 628 | * 1a. Unbind all objects that do not match the GTT constraints for |
| 629 | * the execbuffer (fenceable, mappable, alignment etc). |
| 630 | * 1b. Increment pin count for already bound objects. |
| 631 | * 2. Bind new objects. |
| 632 | * 3. Decrement pin count. |
| 633 | * |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 634 | * This avoid unnecessary unbinding of later objects in order to make |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 635 | * room for the earlier objects *unless* we need to defragment. |
| 636 | */ |
| 637 | retry = 0; |
| 638 | do { |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 639 | int ret = 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 640 | |
| 641 | /* Unbind any ill-fitting objects or pin. */ |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 642 | list_for_each_entry(vma, vmas, exec_list) { |
| 643 | struct drm_i915_gem_exec_object2 *entry = vma->exec_entry; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 644 | bool need_fence, need_mappable; |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 645 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 646 | obj = vma->obj; |
| 647 | |
| 648 | if (!drm_mm_node_allocated(&vma->node)) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 649 | continue; |
| 650 | |
| 651 | need_fence = |
Chris Wilson | 9b3826b | 2010-12-05 17:11:54 +0000 | [diff] [blame] | 652 | has_fenced_gpu_access && |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 653 | entry->flags & EXEC_OBJECT_NEEDS_FENCE && |
| 654 | obj->tiling_mode != I915_TILING_NONE; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 655 | need_mappable = need_fence || need_reloc_mappable(vma); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 656 | |
Ben Widawsky | 28d6a7b | 2013-07-31 17:00:02 -0700 | [diff] [blame] | 657 | WARN_ON((need_mappable || need_fence) && |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 658 | !i915_is_ggtt(vma->vm)); |
Ben Widawsky | 28d6a7b | 2013-07-31 17:00:02 -0700 | [diff] [blame] | 659 | |
Ben Widawsky | f343c5f | 2013-07-05 14:41:04 -0700 | [diff] [blame] | 660 | if ((entry->alignment && |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 661 | vma->node.start & (entry->alignment - 1)) || |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 662 | (need_mappable && !obj->map_and_fenceable)) |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 663 | ret = i915_vma_unbind(vma); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 664 | else |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 665 | ret = i915_gem_execbuffer_reserve_vma(vma, ring, need_relocs); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 666 | if (ret) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 667 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 668 | } |
| 669 | |
| 670 | /* Bind fresh objects */ |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 671 | list_for_each_entry(vma, vmas, exec_list) { |
| 672 | if (drm_mm_node_allocated(&vma->node)) |
Chris Wilson | 1690e1e | 2011-12-14 13:57:08 +0100 | [diff] [blame] | 673 | continue; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 674 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 675 | ret = i915_gem_execbuffer_reserve_vma(vma, ring, need_relocs); |
Chris Wilson | 7788a76 | 2012-08-24 19:18:18 +0100 | [diff] [blame] | 676 | if (ret) |
| 677 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 678 | } |
| 679 | |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 680 | err: |
Chris Wilson | 6c085a7 | 2012-08-20 11:40:46 +0200 | [diff] [blame] | 681 | if (ret != -ENOSPC || retry++) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 682 | return ret; |
| 683 | |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 684 | /* Decrement pin count for bound objects */ |
| 685 | list_for_each_entry(vma, vmas, exec_list) |
| 686 | i915_gem_execbuffer_unreserve_vma(vma); |
| 687 | |
Ben Widawsky | 68c8c17 | 2013-09-11 14:57:50 -0700 | [diff] [blame] | 688 | ret = i915_gem_evict_vm(vm, true); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 689 | if (ret) |
| 690 | return ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 691 | } while (1); |
| 692 | } |
| 693 | |
| 694 | static int |
| 695 | i915_gem_execbuffer_relocate_slow(struct drm_device *dev, |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 696 | struct drm_i915_gem_execbuffer2 *args, |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 697 | struct drm_file *file, |
Chris Wilson | d9e86c0 | 2010-11-10 16:40:20 +0000 | [diff] [blame] | 698 | struct intel_ring_buffer *ring, |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 699 | struct eb_vmas *eb, |
| 700 | struct drm_i915_gem_exec_object2 *exec) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 701 | { |
| 702 | struct drm_i915_gem_relocation_entry *reloc; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 703 | struct i915_address_space *vm; |
| 704 | struct i915_vma *vma; |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 705 | bool need_relocs; |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 706 | int *reloc_offset; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 707 | int i, total, ret; |
Daniel Vetter | b205ca5 | 2013-09-19 14:00:11 +0200 | [diff] [blame] | 708 | unsigned count = args->buffer_count; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 709 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 710 | if (WARN_ON(list_empty(&eb->vmas))) |
| 711 | return 0; |
| 712 | |
| 713 | vm = list_first_entry(&eb->vmas, struct i915_vma, exec_list)->vm; |
| 714 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 715 | /* We may process another execbuffer during the unlock... */ |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 716 | while (!list_empty(&eb->vmas)) { |
| 717 | vma = list_first_entry(&eb->vmas, struct i915_vma, exec_list); |
| 718 | list_del_init(&vma->exec_list); |
Chris Wilson | a415d35 | 2013-11-26 11:23:15 +0000 | [diff] [blame] | 719 | i915_gem_execbuffer_unreserve_vma(vma); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 720 | drm_gem_object_unreference(&vma->obj->base); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 721 | } |
| 722 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 723 | mutex_unlock(&dev->struct_mutex); |
| 724 | |
| 725 | total = 0; |
| 726 | for (i = 0; i < count; i++) |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 727 | total += exec[i].relocation_count; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 728 | |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 729 | reloc_offset = drm_malloc_ab(count, sizeof(*reloc_offset)); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 730 | reloc = drm_malloc_ab(total, sizeof(*reloc)); |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 731 | if (reloc == NULL || reloc_offset == NULL) { |
| 732 | drm_free_large(reloc); |
| 733 | drm_free_large(reloc_offset); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 734 | mutex_lock(&dev->struct_mutex); |
| 735 | return -ENOMEM; |
| 736 | } |
| 737 | |
| 738 | total = 0; |
| 739 | for (i = 0; i < count; i++) { |
| 740 | struct drm_i915_gem_relocation_entry __user *user_relocs; |
Chris Wilson | 262b6d3 | 2013-01-15 16:17:54 +0000 | [diff] [blame] | 741 | u64 invalid_offset = (u64)-1; |
| 742 | int j; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 743 | |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 744 | user_relocs = to_user_ptr(exec[i].relocs_ptr); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 745 | |
| 746 | if (copy_from_user(reloc+total, user_relocs, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 747 | exec[i].relocation_count * sizeof(*reloc))) { |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 748 | ret = -EFAULT; |
| 749 | mutex_lock(&dev->struct_mutex); |
| 750 | goto err; |
| 751 | } |
| 752 | |
Chris Wilson | 262b6d3 | 2013-01-15 16:17:54 +0000 | [diff] [blame] | 753 | /* As we do not update the known relocation offsets after |
| 754 | * relocating (due to the complexities in lock handling), |
| 755 | * we need to mark them as invalid now so that we force the |
| 756 | * relocation processing next time. Just in case the target |
| 757 | * object is evicted and then rebound into its old |
| 758 | * presumed_offset before the next execbuffer - if that |
| 759 | * happened we would make the mistake of assuming that the |
| 760 | * relocations were valid. |
| 761 | */ |
| 762 | for (j = 0; j < exec[i].relocation_count; j++) { |
| 763 | if (copy_to_user(&user_relocs[j].presumed_offset, |
| 764 | &invalid_offset, |
| 765 | sizeof(invalid_offset))) { |
| 766 | ret = -EFAULT; |
| 767 | mutex_lock(&dev->struct_mutex); |
| 768 | goto err; |
| 769 | } |
| 770 | } |
| 771 | |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 772 | reloc_offset[i] = total; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 773 | total += exec[i].relocation_count; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 774 | } |
| 775 | |
| 776 | ret = i915_mutex_lock_interruptible(dev); |
| 777 | if (ret) { |
| 778 | mutex_lock(&dev->struct_mutex); |
| 779 | goto err; |
| 780 | } |
| 781 | |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 782 | /* reacquire the objects */ |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 783 | eb_reset(eb); |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 784 | ret = eb_lookup_vmas(eb, exec, args, vm, file); |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 785 | if (ret) |
| 786 | goto err; |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 787 | |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 788 | need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 789 | ret = i915_gem_execbuffer_reserve(ring, &eb->vmas, &need_relocs); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 790 | if (ret) |
| 791 | goto err; |
| 792 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 793 | list_for_each_entry(vma, &eb->vmas, exec_list) { |
| 794 | int offset = vma->exec_entry - exec; |
| 795 | ret = i915_gem_execbuffer_relocate_vma_slow(vma, eb, |
| 796 | reloc + reloc_offset[offset]); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 797 | if (ret) |
| 798 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 799 | } |
| 800 | |
| 801 | /* Leave the user relocations as are, this is the painfully slow path, |
| 802 | * and we want to avoid the complication of dropping the lock whilst |
| 803 | * having buffers reserved in the aperture and so causing spurious |
| 804 | * ENOSPC for random operations. |
| 805 | */ |
| 806 | |
| 807 | err: |
| 808 | drm_free_large(reloc); |
Chris Wilson | dd6864a | 2011-01-12 23:49:13 +0000 | [diff] [blame] | 809 | drm_free_large(reloc_offset); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 810 | return ret; |
| 811 | } |
| 812 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 813 | static int |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 814 | i915_gem_execbuffer_move_to_gpu(struct intel_ring_buffer *ring, |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 815 | struct list_head *vmas) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 816 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 817 | struct i915_vma *vma; |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 818 | uint32_t flush_domains = 0; |
Chris Wilson | 000433b | 2013-08-08 14:41:09 +0100 | [diff] [blame] | 819 | bool flush_chipset = false; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 820 | int ret; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 821 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 822 | list_for_each_entry(vma, vmas, exec_list) { |
| 823 | struct drm_i915_gem_object *obj = vma->obj; |
Ben Widawsky | 2911a35 | 2012-04-05 14:47:36 -0700 | [diff] [blame] | 824 | ret = i915_gem_object_sync(obj, ring); |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 825 | if (ret) |
| 826 | return ret; |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 827 | |
| 828 | if (obj->base.write_domain & I915_GEM_DOMAIN_CPU) |
Chris Wilson | 000433b | 2013-08-08 14:41:09 +0100 | [diff] [blame] | 829 | flush_chipset |= i915_gem_clflush_object(obj, false); |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 830 | |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 831 | flush_domains |= obj->base.write_domain; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 832 | } |
| 833 | |
Chris Wilson | 000433b | 2013-08-08 14:41:09 +0100 | [diff] [blame] | 834 | if (flush_chipset) |
Ben Widawsky | e76e9ae | 2012-11-04 09:21:27 -0800 | [diff] [blame] | 835 | i915_gem_chipset_flush(ring->dev); |
Daniel Vetter | 6ac42f4 | 2012-07-21 12:25:01 +0200 | [diff] [blame] | 836 | |
| 837 | if (flush_domains & I915_GEM_DOMAIN_GTT) |
| 838 | wmb(); |
| 839 | |
Chris Wilson | 09cf7c9 | 2012-07-13 14:14:08 +0100 | [diff] [blame] | 840 | /* Unconditionally invalidate gpu caches and ensure that we do flush |
| 841 | * any residual writes from the previous batch. |
| 842 | */ |
Chris Wilson | a7b9761 | 2012-07-20 12:41:08 +0100 | [diff] [blame] | 843 | return intel_ring_invalidate_all_caches(ring); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 844 | } |
| 845 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 846 | static bool |
| 847 | i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 848 | { |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 849 | if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS) |
| 850 | return false; |
| 851 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 852 | return ((exec->batch_start_offset | exec->batch_len) & 0x7) == 0; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 853 | } |
| 854 | |
| 855 | static int |
| 856 | validate_exec_list(struct drm_i915_gem_exec_object2 *exec, |
| 857 | int count) |
| 858 | { |
| 859 | int i; |
Daniel Vetter | b205ca5 | 2013-09-19 14:00:11 +0200 | [diff] [blame] | 860 | unsigned relocs_total = 0; |
| 861 | unsigned relocs_max = UINT_MAX / sizeof(struct drm_i915_gem_relocation_entry); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 862 | |
| 863 | for (i = 0; i < count; i++) { |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 864 | char __user *ptr = to_user_ptr(exec[i].relocs_ptr); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 865 | int length; /* limited by fault_in_pages_readable() */ |
| 866 | |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 867 | if (exec[i].flags & __EXEC_OBJECT_UNKNOWN_FLAGS) |
| 868 | return -EINVAL; |
| 869 | |
Kees Cook | 3118a4f | 2013-03-11 17:31:45 -0700 | [diff] [blame] | 870 | /* First check for malicious input causing overflow in |
| 871 | * the worst case where we need to allocate the entire |
| 872 | * relocation tree as a single array. |
| 873 | */ |
| 874 | if (exec[i].relocation_count > relocs_max - relocs_total) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 875 | return -EINVAL; |
Kees Cook | 3118a4f | 2013-03-11 17:31:45 -0700 | [diff] [blame] | 876 | relocs_total += exec[i].relocation_count; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 877 | |
| 878 | length = exec[i].relocation_count * |
| 879 | sizeof(struct drm_i915_gem_relocation_entry); |
Kees Cook | 3058753 | 2013-03-11 14:37:35 -0700 | [diff] [blame] | 880 | /* |
| 881 | * We must check that the entire relocation array is safe |
| 882 | * to read, but since we may need to update the presumed |
| 883 | * offsets during execution, check for full write access. |
| 884 | */ |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 885 | if (!access_ok(VERIFY_WRITE, ptr, length)) |
| 886 | return -EFAULT; |
| 887 | |
Xiong Zhang | 0b74b50 | 2013-07-19 13:51:24 +0800 | [diff] [blame] | 888 | if (likely(!i915_prefault_disable)) { |
| 889 | if (fault_in_multipages_readable(ptr, length)) |
| 890 | return -EFAULT; |
| 891 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 892 | } |
| 893 | |
| 894 | return 0; |
| 895 | } |
| 896 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 897 | static struct i915_hw_context * |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 898 | i915_gem_validate_context(struct drm_device *dev, struct drm_file *file, |
Daniel Vetter | 7c9c4b8 | 2013-12-18 16:37:49 +0100 | [diff] [blame] | 899 | struct intel_ring_buffer *ring, const u32 ctx_id) |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 900 | { |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 901 | struct i915_hw_context *ctx = NULL; |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 902 | struct i915_ctx_hang_stats *hs; |
| 903 | |
Daniel Vetter | 7c9c4b8 | 2013-12-18 16:37:49 +0100 | [diff] [blame] | 904 | if (ring->id != RCS && ctx_id != DEFAULT_CONTEXT_ID) |
| 905 | return ERR_PTR(-EINVAL); |
| 906 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 907 | ctx = i915_gem_context_get(file->driver_priv, ctx_id); |
| 908 | if (IS_ERR_OR_NULL(ctx)) |
| 909 | return ctx; |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 910 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 911 | hs = &ctx->hang_stats; |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 912 | if (hs->banned) { |
| 913 | DRM_DEBUG("Context %u tried to submit while banned\n", ctx_id); |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 914 | return ERR_PTR(-EIO); |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 915 | } |
| 916 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 917 | return ctx; |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 918 | } |
| 919 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 920 | static void |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 921 | i915_gem_execbuffer_move_to_active(struct list_head *vmas, |
Chris Wilson | 9d773091 | 2012-11-27 16:22:52 +0000 | [diff] [blame] | 922 | struct intel_ring_buffer *ring) |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 923 | { |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 924 | struct i915_vma *vma; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 925 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 926 | list_for_each_entry(vma, vmas, exec_list) { |
| 927 | struct drm_i915_gem_object *obj = vma->obj; |
Chris Wilson | 69c2fc8 | 2012-07-20 12:41:03 +0100 | [diff] [blame] | 928 | u32 old_read = obj->base.read_domains; |
| 929 | u32 old_write = obj->base.write_domain; |
Chris Wilson | db53a30 | 2011-02-03 11:57:46 +0000 | [diff] [blame] | 930 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 931 | obj->base.write_domain = obj->base.pending_write_domain; |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 932 | if (obj->base.write_domain == 0) |
| 933 | obj->base.pending_read_domains |= obj->base.read_domains; |
| 934 | obj->base.read_domains = obj->base.pending_read_domains; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 935 | obj->fenced_gpu_access = obj->pending_fenced_gpu_access; |
| 936 | |
Ben Widawsky | e2d05a8 | 2013-09-24 09:57:58 -0700 | [diff] [blame] | 937 | i915_vma_move_to_active(vma, ring); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 938 | if (obj->base.write_domain) { |
| 939 | obj->dirty = 1; |
Chris Wilson | 9d773091 | 2012-11-27 16:22:52 +0000 | [diff] [blame] | 940 | obj->last_write_seqno = intel_ring_get_seqno(ring); |
Ben Widawsky | d7f46fc | 2013-12-06 14:10:55 -0800 | [diff] [blame] | 941 | /* check for potential scanout */ |
| 942 | if (i915_gem_obj_ggtt_bound(obj) && |
| 943 | i915_gem_obj_to_ggtt(obj)->pin_count) |
Chris Wilson | c65355b | 2013-06-06 16:53:41 -0300 | [diff] [blame] | 944 | intel_mark_fb_busy(obj, ring); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 945 | } |
| 946 | |
Chris Wilson | db53a30 | 2011-02-03 11:57:46 +0000 | [diff] [blame] | 947 | trace_i915_gem_object_change_domain(obj, old_read, old_write); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 948 | } |
| 949 | } |
| 950 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 951 | static void |
| 952 | i915_gem_execbuffer_retire_commands(struct drm_device *dev, |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 953 | struct drm_file *file, |
Mika Kuoppala | 7d736f4 | 2013-06-12 15:01:39 +0300 | [diff] [blame] | 954 | struct intel_ring_buffer *ring, |
| 955 | struct drm_i915_gem_object *obj) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 956 | { |
Daniel Vetter | cc889e0 | 2012-06-13 20:45:19 +0200 | [diff] [blame] | 957 | /* Unconditionally force add_request to emit a full flush. */ |
| 958 | ring->gpu_caches_dirty = true; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 959 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 960 | /* Add a breadcrumb for the completion of the batch buffer */ |
Mika Kuoppala | 7d736f4 | 2013-06-12 15:01:39 +0300 | [diff] [blame] | 961 | (void)__i915_add_request(ring, file, obj, NULL); |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 962 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 963 | |
| 964 | static int |
Eric Anholt | ae662d3 | 2012-01-03 09:23:29 -0800 | [diff] [blame] | 965 | i915_reset_gen7_sol_offsets(struct drm_device *dev, |
| 966 | struct intel_ring_buffer *ring) |
| 967 | { |
| 968 | drm_i915_private_t *dev_priv = dev->dev_private; |
| 969 | int ret, i; |
| 970 | |
| 971 | if (!IS_GEN7(dev) || ring != &dev_priv->ring[RCS]) |
| 972 | return 0; |
| 973 | |
| 974 | ret = intel_ring_begin(ring, 4 * 3); |
| 975 | if (ret) |
| 976 | return ret; |
| 977 | |
| 978 | for (i = 0; i < 4; i++) { |
| 979 | intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1)); |
| 980 | intel_ring_emit(ring, GEN7_SO_WRITE_OFFSET(i)); |
| 981 | intel_ring_emit(ring, 0); |
| 982 | } |
| 983 | |
| 984 | intel_ring_advance(ring); |
| 985 | |
| 986 | return 0; |
| 987 | } |
| 988 | |
| 989 | static int |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 990 | i915_gem_do_execbuffer(struct drm_device *dev, void *data, |
| 991 | struct drm_file *file, |
| 992 | struct drm_i915_gem_execbuffer2 *args, |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 993 | struct drm_i915_gem_exec_object2 *exec) |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 994 | { |
| 995 | drm_i915_private_t *dev_priv = dev->dev_private; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 996 | struct eb_vmas *eb; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 997 | struct drm_i915_gem_object *batch_obj; |
| 998 | struct drm_clip_rect *cliprects = NULL; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 999 | struct intel_ring_buffer *ring; |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1000 | struct i915_hw_context *ctx; |
| 1001 | struct i915_address_space *vm; |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 1002 | const u32 ctx_id = i915_execbuffer2_get_context_id(*args); |
Ben Widawsky | 7e0d96b | 2013-12-06 14:11:26 -0800 | [diff] [blame] | 1003 | u32 exec_start = args->batch_start_offset, exec_len; |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 1004 | u32 mask, flags; |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 1005 | int ret, mode, i; |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 1006 | bool need_relocs; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1007 | |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 1008 | if (!i915_gem_check_execbuffer(args)) |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 1009 | return -EINVAL; |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 1010 | |
| 1011 | ret = validate_exec_list(exec, args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1012 | if (ret) |
| 1013 | return ret; |
| 1014 | |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame] | 1015 | flags = 0; |
| 1016 | if (args->flags & I915_EXEC_SECURE) { |
| 1017 | if (!file->is_master || !capable(CAP_SYS_ADMIN)) |
| 1018 | return -EPERM; |
| 1019 | |
| 1020 | flags |= I915_DISPATCH_SECURE; |
| 1021 | } |
Daniel Vetter | b45305f | 2012-12-17 16:21:27 +0100 | [diff] [blame] | 1022 | if (args->flags & I915_EXEC_IS_PINNED) |
| 1023 | flags |= I915_DISPATCH_PINNED; |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame] | 1024 | |
Ben Widawsky | ca01b12 | 2013-12-06 14:11:00 -0800 | [diff] [blame] | 1025 | if ((args->flags & I915_EXEC_RING_MASK) > I915_NUM_RINGS) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1026 | DRM_DEBUG("execbuf with unknown ring: %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1027 | (int)(args->flags & I915_EXEC_RING_MASK)); |
| 1028 | return -EINVAL; |
| 1029 | } |
Ben Widawsky | ca01b12 | 2013-12-06 14:11:00 -0800 | [diff] [blame] | 1030 | |
| 1031 | if ((args->flags & I915_EXEC_RING_MASK) == I915_EXEC_DEFAULT) |
| 1032 | ring = &dev_priv->ring[RCS]; |
| 1033 | else |
| 1034 | ring = &dev_priv->ring[(args->flags & I915_EXEC_RING_MASK) - 1]; |
| 1035 | |
Chris Wilson | a15817c | 2012-05-11 14:29:31 +0100 | [diff] [blame] | 1036 | if (!intel_ring_initialized(ring)) { |
| 1037 | DRM_DEBUG("execbuf with invalid ring: %d\n", |
| 1038 | (int)(args->flags & I915_EXEC_RING_MASK)); |
| 1039 | return -EINVAL; |
| 1040 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1041 | |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 1042 | mode = args->flags & I915_EXEC_CONSTANTS_MASK; |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 1043 | mask = I915_EXEC_CONSTANTS_MASK; |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 1044 | switch (mode) { |
| 1045 | case I915_EXEC_CONSTANTS_REL_GENERAL: |
| 1046 | case I915_EXEC_CONSTANTS_ABSOLUTE: |
| 1047 | case I915_EXEC_CONSTANTS_REL_SURFACE: |
| 1048 | if (ring == &dev_priv->ring[RCS] && |
| 1049 | mode != dev_priv->relative_constants_mode) { |
| 1050 | if (INTEL_INFO(dev)->gen < 4) |
| 1051 | return -EINVAL; |
| 1052 | |
| 1053 | if (INTEL_INFO(dev)->gen > 5 && |
| 1054 | mode == I915_EXEC_CONSTANTS_REL_SURFACE) |
| 1055 | return -EINVAL; |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 1056 | |
| 1057 | /* The HW changed the meaning on this bit on gen6 */ |
| 1058 | if (INTEL_INFO(dev)->gen >= 6) |
| 1059 | mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE; |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 1060 | } |
| 1061 | break; |
| 1062 | default: |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1063 | DRM_DEBUG("execbuf with unknown constants: %d\n", mode); |
Chris Wilson | 72bfa19 | 2010-12-19 11:42:05 +0000 | [diff] [blame] | 1064 | return -EINVAL; |
| 1065 | } |
| 1066 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1067 | if (args->buffer_count < 1) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1068 | DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1069 | return -EINVAL; |
| 1070 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1071 | |
| 1072 | if (args->num_cliprects != 0) { |
Chris Wilson | 1ec14ad | 2010-12-04 11:30:53 +0000 | [diff] [blame] | 1073 | if (ring != &dev_priv->ring[RCS]) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1074 | DRM_DEBUG("clip rectangles are only valid with the render ring\n"); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1075 | return -EINVAL; |
| 1076 | } |
| 1077 | |
Daniel Vetter | 6ebebc9 | 2012-04-26 23:28:11 +0200 | [diff] [blame] | 1078 | if (INTEL_INFO(dev)->gen >= 5) { |
| 1079 | DRM_DEBUG("clip rectangles are only valid on pre-gen5\n"); |
| 1080 | return -EINVAL; |
| 1081 | } |
| 1082 | |
Xi Wang | 44afb3a | 2012-04-23 04:06:42 -0400 | [diff] [blame] | 1083 | if (args->num_cliprects > UINT_MAX / sizeof(*cliprects)) { |
| 1084 | DRM_DEBUG("execbuf with %u cliprects\n", |
| 1085 | args->num_cliprects); |
| 1086 | return -EINVAL; |
| 1087 | } |
Daniel Vetter | 5e13a0c | 2012-05-08 13:39:59 +0200 | [diff] [blame] | 1088 | |
Daniel Vetter | a1e2265 | 2013-09-21 00:35:38 +0200 | [diff] [blame] | 1089 | cliprects = kcalloc(args->num_cliprects, |
| 1090 | sizeof(*cliprects), |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1091 | GFP_KERNEL); |
| 1092 | if (cliprects == NULL) { |
| 1093 | ret = -ENOMEM; |
| 1094 | goto pre_mutex_err; |
| 1095 | } |
| 1096 | |
Chris Wilson | 432e58e | 2010-11-25 19:32:06 +0000 | [diff] [blame] | 1097 | if (copy_from_user(cliprects, |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 1098 | to_user_ptr(args->cliprects_ptr), |
| 1099 | sizeof(*cliprects)*args->num_cliprects)) { |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1100 | ret = -EFAULT; |
| 1101 | goto pre_mutex_err; |
| 1102 | } |
| 1103 | } |
| 1104 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1105 | ret = i915_mutex_lock_interruptible(dev); |
| 1106 | if (ret) |
| 1107 | goto pre_mutex_err; |
| 1108 | |
Daniel Vetter | db1b76c | 2013-07-09 16:51:37 +0200 | [diff] [blame] | 1109 | if (dev_priv->ums.mm_suspended) { |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1110 | mutex_unlock(&dev->struct_mutex); |
| 1111 | ret = -EBUSY; |
| 1112 | goto pre_mutex_err; |
| 1113 | } |
| 1114 | |
Daniel Vetter | 7c9c4b8 | 2013-12-18 16:37:49 +0100 | [diff] [blame] | 1115 | ctx = i915_gem_validate_context(dev, file, ring, ctx_id); |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1116 | if (IS_ERR_OR_NULL(ctx)) { |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 1117 | mutex_unlock(&dev->struct_mutex); |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1118 | ret = PTR_ERR(ctx); |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 1119 | goto pre_mutex_err; |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1120 | } |
| 1121 | |
| 1122 | i915_gem_context_reference(ctx); |
| 1123 | |
Ben Widawsky | 7e0d96b | 2013-12-06 14:11:26 -0800 | [diff] [blame] | 1124 | vm = ctx->vm; |
| 1125 | if (!USES_FULL_PPGTT(dev)) |
| 1126 | vm = &dev_priv->gtt.base; |
Mika Kuoppala | d299cce | 2013-11-26 16:14:33 +0200 | [diff] [blame] | 1127 | |
Ben Widawsky | 17601cbc | 2013-11-25 09:54:38 -0800 | [diff] [blame] | 1128 | eb = eb_create(args); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 1129 | if (eb == NULL) { |
| 1130 | mutex_unlock(&dev->struct_mutex); |
| 1131 | ret = -ENOMEM; |
| 1132 | goto pre_mutex_err; |
| 1133 | } |
| 1134 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1135 | /* Look up object handles */ |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 1136 | ret = eb_lookup_vmas(eb, exec, args, vm, file); |
Chris Wilson | 3b96eff | 2013-01-08 10:53:14 +0000 | [diff] [blame] | 1137 | if (ret) |
| 1138 | goto err; |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1139 | |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 1140 | /* take note of the batch buffer before we might reorder the lists */ |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 1141 | batch_obj = list_entry(eb->vmas.prev, struct i915_vma, exec_list)->obj; |
Chris Wilson | 6fe4f14 | 2011-01-10 17:35:37 +0000 | [diff] [blame] | 1142 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1143 | /* Move the objects en-masse into the GTT, evicting if necessary. */ |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 1144 | need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0; |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 1145 | ret = i915_gem_execbuffer_reserve(ring, &eb->vmas, &need_relocs); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1146 | if (ret) |
| 1147 | goto err; |
| 1148 | |
| 1149 | /* The objects are in their final locations, apply the relocations. */ |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 1150 | if (need_relocs) |
Ben Widawsky | 17601cbc | 2013-11-25 09:54:38 -0800 | [diff] [blame] | 1151 | ret = i915_gem_execbuffer_relocate(eb); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1152 | if (ret) { |
| 1153 | if (ret == -EFAULT) { |
Daniel Vetter | ed5982e | 2013-01-17 22:23:36 +0100 | [diff] [blame] | 1154 | ret = i915_gem_execbuffer_relocate_slow(dev, args, file, ring, |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 1155 | eb, exec); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1156 | BUG_ON(!mutex_is_locked(&dev->struct_mutex)); |
| 1157 | } |
| 1158 | if (ret) |
| 1159 | goto err; |
| 1160 | } |
| 1161 | |
| 1162 | /* Set the pending read domains for the batch buffer to COMMAND */ |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1163 | if (batch_obj->base.pending_write_domain) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1164 | DRM_DEBUG("Attempting to use self-modifying batch buffer\n"); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1165 | ret = -EINVAL; |
| 1166 | goto err; |
| 1167 | } |
| 1168 | batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND; |
| 1169 | |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame] | 1170 | /* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure |
| 1171 | * batch" bit. Hence we need to pin secure batches into the global gtt. |
Ben Widawsky | 28cf541 | 2013-11-02 21:07:26 -0700 | [diff] [blame] | 1172 | * hsw should have this fixed, but bdw mucks it up again. */ |
Ben Widawsky | 6f65e29 | 2013-12-06 14:10:56 -0800 | [diff] [blame] | 1173 | if (flags & I915_DISPATCH_SECURE && |
| 1174 | !batch_obj->has_global_gtt_mapping) { |
| 1175 | /* When we have multiple VMs, we'll need to make sure that we |
| 1176 | * allocate space first */ |
| 1177 | struct i915_vma *vma = i915_gem_obj_to_ggtt(batch_obj); |
| 1178 | BUG_ON(!vma); |
| 1179 | vma->bind_vma(vma, batch_obj->cache_level, GLOBAL_BIND); |
| 1180 | } |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame] | 1181 | |
Ben Widawsky | 7e0d96b | 2013-12-06 14:11:26 -0800 | [diff] [blame] | 1182 | if (flags & I915_DISPATCH_SECURE) |
| 1183 | exec_start += i915_gem_obj_ggtt_offset(batch_obj); |
| 1184 | else |
| 1185 | exec_start += i915_gem_obj_offset(batch_obj, vm); |
| 1186 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 1187 | ret = i915_gem_execbuffer_move_to_gpu(ring, &eb->vmas); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1188 | if (ret) |
| 1189 | goto err; |
| 1190 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1191 | ret = i915_switch_context(ring, file, ctx); |
Eric Anholt | 0da5cec | 2012-07-23 12:33:55 -0700 | [diff] [blame] | 1192 | if (ret) |
| 1193 | goto err; |
| 1194 | |
Ben Widawsky | e2971bd | 2011-12-12 19:21:57 -0800 | [diff] [blame] | 1195 | if (ring == &dev_priv->ring[RCS] && |
| 1196 | mode != dev_priv->relative_constants_mode) { |
| 1197 | ret = intel_ring_begin(ring, 4); |
| 1198 | if (ret) |
| 1199 | goto err; |
| 1200 | |
| 1201 | intel_ring_emit(ring, MI_NOOP); |
| 1202 | intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1)); |
| 1203 | intel_ring_emit(ring, INSTPM); |
Ben Widawsky | 84f9f93 | 2011-12-12 19:21:58 -0800 | [diff] [blame] | 1204 | intel_ring_emit(ring, mask << 16 | mode); |
Ben Widawsky | e2971bd | 2011-12-12 19:21:57 -0800 | [diff] [blame] | 1205 | intel_ring_advance(ring); |
| 1206 | |
| 1207 | dev_priv->relative_constants_mode = mode; |
| 1208 | } |
| 1209 | |
Eric Anholt | ae662d3 | 2012-01-03 09:23:29 -0800 | [diff] [blame] | 1210 | if (args->flags & I915_EXEC_GEN7_SOL_RESET) { |
| 1211 | ret = i915_reset_gen7_sol_offsets(dev, ring); |
| 1212 | if (ret) |
| 1213 | goto err; |
| 1214 | } |
| 1215 | |
Ben Widawsky | 7e0d96b | 2013-12-06 14:11:26 -0800 | [diff] [blame] | 1216 | |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1217 | exec_len = args->batch_len; |
| 1218 | if (cliprects) { |
| 1219 | for (i = 0; i < args->num_cliprects; i++) { |
| 1220 | ret = i915_emit_box(dev, &cliprects[i], |
| 1221 | args->DR1, args->DR4); |
| 1222 | if (ret) |
| 1223 | goto err; |
| 1224 | |
| 1225 | ret = ring->dispatch_execbuffer(ring, |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame] | 1226 | exec_start, exec_len, |
| 1227 | flags); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1228 | if (ret) |
| 1229 | goto err; |
| 1230 | } |
| 1231 | } else { |
Chris Wilson | d7d4eed | 2012-10-17 12:09:54 +0100 | [diff] [blame] | 1232 | ret = ring->dispatch_execbuffer(ring, |
| 1233 | exec_start, exec_len, |
| 1234 | flags); |
Chris Wilson | c4e7a41 | 2010-11-30 14:10:25 +0000 | [diff] [blame] | 1235 | if (ret) |
| 1236 | goto err; |
| 1237 | } |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1238 | |
Chris Wilson | 9d773091 | 2012-11-27 16:22:52 +0000 | [diff] [blame] | 1239 | trace_i915_gem_ring_dispatch(ring, intel_ring_get_seqno(ring), flags); |
| 1240 | |
Ben Widawsky | 27173f1 | 2013-08-14 11:38:36 +0200 | [diff] [blame] | 1241 | i915_gem_execbuffer_move_to_active(&eb->vmas, ring); |
Mika Kuoppala | 7d736f4 | 2013-06-12 15:01:39 +0300 | [diff] [blame] | 1242 | i915_gem_execbuffer_retire_commands(dev, file, ring, batch_obj); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1243 | |
| 1244 | err: |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1245 | /* the request owns the ref now */ |
| 1246 | i915_gem_context_unreference(ctx); |
Chris Wilson | 67731b8 | 2010-12-08 10:38:14 +0000 | [diff] [blame] | 1247 | eb_destroy(eb); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1248 | |
| 1249 | mutex_unlock(&dev->struct_mutex); |
| 1250 | |
| 1251 | pre_mutex_err: |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1252 | kfree(cliprects); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1253 | return ret; |
| 1254 | } |
| 1255 | |
| 1256 | /* |
| 1257 | * Legacy execbuffer just creates an exec2 list from the original exec object |
| 1258 | * list array and passes it to the real function. |
| 1259 | */ |
| 1260 | int |
| 1261 | i915_gem_execbuffer(struct drm_device *dev, void *data, |
| 1262 | struct drm_file *file) |
| 1263 | { |
| 1264 | struct drm_i915_gem_execbuffer *args = data; |
| 1265 | struct drm_i915_gem_execbuffer2 exec2; |
| 1266 | struct drm_i915_gem_exec_object *exec_list = NULL; |
| 1267 | struct drm_i915_gem_exec_object2 *exec2_list = NULL; |
| 1268 | int ret, i; |
| 1269 | |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1270 | if (args->buffer_count < 1) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1271 | DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1272 | return -EINVAL; |
| 1273 | } |
| 1274 | |
| 1275 | /* Copy in the exec list from userland */ |
| 1276 | exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count); |
| 1277 | exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count); |
| 1278 | if (exec_list == NULL || exec2_list == NULL) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1279 | DRM_DEBUG("Failed to allocate exec list for %d buffers\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1280 | args->buffer_count); |
| 1281 | drm_free_large(exec_list); |
| 1282 | drm_free_large(exec2_list); |
| 1283 | return -ENOMEM; |
| 1284 | } |
| 1285 | ret = copy_from_user(exec_list, |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 1286 | to_user_ptr(args->buffers_ptr), |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1287 | sizeof(*exec_list) * args->buffer_count); |
| 1288 | if (ret != 0) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1289 | DRM_DEBUG("copy %d exec entries failed %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1290 | args->buffer_count, ret); |
| 1291 | drm_free_large(exec_list); |
| 1292 | drm_free_large(exec2_list); |
| 1293 | return -EFAULT; |
| 1294 | } |
| 1295 | |
| 1296 | for (i = 0; i < args->buffer_count; i++) { |
| 1297 | exec2_list[i].handle = exec_list[i].handle; |
| 1298 | exec2_list[i].relocation_count = exec_list[i].relocation_count; |
| 1299 | exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr; |
| 1300 | exec2_list[i].alignment = exec_list[i].alignment; |
| 1301 | exec2_list[i].offset = exec_list[i].offset; |
| 1302 | if (INTEL_INFO(dev)->gen < 4) |
| 1303 | exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE; |
| 1304 | else |
| 1305 | exec2_list[i].flags = 0; |
| 1306 | } |
| 1307 | |
| 1308 | exec2.buffers_ptr = args->buffers_ptr; |
| 1309 | exec2.buffer_count = args->buffer_count; |
| 1310 | exec2.batch_start_offset = args->batch_start_offset; |
| 1311 | exec2.batch_len = args->batch_len; |
| 1312 | exec2.DR1 = args->DR1; |
| 1313 | exec2.DR4 = args->DR4; |
| 1314 | exec2.num_cliprects = args->num_cliprects; |
| 1315 | exec2.cliprects_ptr = args->cliprects_ptr; |
| 1316 | exec2.flags = I915_EXEC_RENDER; |
Ben Widawsky | 6e0a69d | 2012-06-04 14:42:55 -0700 | [diff] [blame] | 1317 | i915_execbuffer2_set_context_id(exec2, 0); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1318 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1319 | ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1320 | if (!ret) { |
| 1321 | /* Copy the new buffer offsets back to the user's exec list. */ |
| 1322 | for (i = 0; i < args->buffer_count; i++) |
| 1323 | exec_list[i].offset = exec2_list[i].offset; |
| 1324 | /* ... and back out to userspace */ |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 1325 | ret = copy_to_user(to_user_ptr(args->buffers_ptr), |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1326 | exec_list, |
| 1327 | sizeof(*exec_list) * args->buffer_count); |
| 1328 | if (ret) { |
| 1329 | ret = -EFAULT; |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1330 | DRM_DEBUG("failed to copy %d exec entries " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1331 | "back to user (%d)\n", |
| 1332 | args->buffer_count, ret); |
| 1333 | } |
| 1334 | } |
| 1335 | |
| 1336 | drm_free_large(exec_list); |
| 1337 | drm_free_large(exec2_list); |
| 1338 | return ret; |
| 1339 | } |
| 1340 | |
| 1341 | int |
| 1342 | i915_gem_execbuffer2(struct drm_device *dev, void *data, |
| 1343 | struct drm_file *file) |
| 1344 | { |
| 1345 | struct drm_i915_gem_execbuffer2 *args = data; |
| 1346 | struct drm_i915_gem_exec_object2 *exec2_list = NULL; |
| 1347 | int ret; |
| 1348 | |
Xi Wang | ed8cd3b | 2012-04-23 04:06:41 -0400 | [diff] [blame] | 1349 | if (args->buffer_count < 1 || |
| 1350 | args->buffer_count > UINT_MAX / sizeof(*exec2_list)) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1351 | DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1352 | return -EINVAL; |
| 1353 | } |
| 1354 | |
Chris Wilson | 8408c28 | 2011-02-21 12:54:48 +0000 | [diff] [blame] | 1355 | exec2_list = kmalloc(sizeof(*exec2_list)*args->buffer_count, |
Chris Wilson | 419fa72 | 2013-01-08 10:53:13 +0000 | [diff] [blame] | 1356 | GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY); |
Chris Wilson | 8408c28 | 2011-02-21 12:54:48 +0000 | [diff] [blame] | 1357 | if (exec2_list == NULL) |
| 1358 | exec2_list = drm_malloc_ab(sizeof(*exec2_list), |
| 1359 | args->buffer_count); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1360 | if (exec2_list == NULL) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1361 | DRM_DEBUG("Failed to allocate exec list for %d buffers\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1362 | args->buffer_count); |
| 1363 | return -ENOMEM; |
| 1364 | } |
| 1365 | ret = copy_from_user(exec2_list, |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 1366 | to_user_ptr(args->buffers_ptr), |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1367 | sizeof(*exec2_list) * args->buffer_count); |
| 1368 | if (ret != 0) { |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1369 | DRM_DEBUG("copy %d exec entries failed %d\n", |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1370 | args->buffer_count, ret); |
| 1371 | drm_free_large(exec2_list); |
| 1372 | return -EFAULT; |
| 1373 | } |
| 1374 | |
Ben Widawsky | 41bde55 | 2013-12-06 14:11:21 -0800 | [diff] [blame] | 1375 | ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list); |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1376 | if (!ret) { |
| 1377 | /* Copy the new buffer offsets back to the user's exec list. */ |
Ville Syrjälä | 2bb4629 | 2013-02-22 16:12:51 +0200 | [diff] [blame] | 1378 | ret = copy_to_user(to_user_ptr(args->buffers_ptr), |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1379 | exec2_list, |
| 1380 | sizeof(*exec2_list) * args->buffer_count); |
| 1381 | if (ret) { |
| 1382 | ret = -EFAULT; |
Daniel Vetter | ff24019 | 2012-01-31 21:08:14 +0100 | [diff] [blame] | 1383 | DRM_DEBUG("failed to copy %d exec entries " |
Chris Wilson | 54cf91d | 2010-11-25 18:00:26 +0000 | [diff] [blame] | 1384 | "back to user (%d)\n", |
| 1385 | args->buffer_count, ret); |
| 1386 | } |
| 1387 | } |
| 1388 | |
| 1389 | drm_free_large(exec2_list); |
| 1390 | return ret; |
| 1391 | } |