blob: 732630d76b76d5ea2a0bc3850f0847bc5ed70e43 [file] [log] [blame]
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001/*
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Nicolas Geoffraye5038322014-07-04 09:41:32 +010017#include "builder.h"
18
Mathieu Chartierc7853442015-03-27 14:35:38 -070019#include "art_field-inl.h"
Andreas Gamped881df52014-11-24 23:28:39 -080020#include "base/logging.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010021#include "class_linker.h"
Jeff Hao848f70a2014-01-15 13:49:50 -080022#include "dex/verified_method.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000023#include "dex_file-inl.h"
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +000024#include "dex_instruction-inl.h"
Roland Levillain4c0eb422015-04-24 16:43:49 +010025#include "dex/verified_method.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010026#include "driver/compiler_driver-inl.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000027#include "driver/compiler_options.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010028#include "mirror/class_loader.h"
29#include "mirror/dex_cache.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000030#include "nodes.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000031#include "primitive.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010032#include "scoped_thread_state_change.h"
33#include "thread.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000034
35namespace art {
36
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010037/**
38 * Helper class to add HTemporary instructions. This class is used when
39 * converting a DEX instruction to multiple HInstruction, and where those
40 * instructions do not die at the following instruction, but instead spans
41 * multiple instructions.
42 */
43class Temporaries : public ValueObject {
44 public:
Calin Juravlef97f9fb2014-11-11 15:38:19 +000045 explicit Temporaries(HGraph* graph) : graph_(graph), index_(0) {}
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010046
47 void Add(HInstruction* instruction) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +000048 HInstruction* temp = new (graph_->GetArena()) HTemporary(index_);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010049 instruction->GetBlock()->AddInstruction(temp);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000050
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010051 DCHECK(temp->GetPrevious() == instruction);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000052
53 size_t offset;
54 if (instruction->GetType() == Primitive::kPrimLong
55 || instruction->GetType() == Primitive::kPrimDouble) {
56 offset = 2;
57 } else {
58 offset = 1;
59 }
60 index_ += offset;
61
62 graph_->UpdateTemporariesVRegSlots(index_);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010063 }
64
65 private:
66 HGraph* const graph_;
67
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010068 // Current index in the temporary stack, updated by `Add`.
69 size_t index_;
70};
71
Andreas Gamped881df52014-11-24 23:28:39 -080072class SwitchTable : public ValueObject {
73 public:
74 SwitchTable(const Instruction& instruction, uint32_t dex_pc, bool sparse)
75 : instruction_(instruction), dex_pc_(dex_pc), sparse_(sparse) {
76 int32_t table_offset = instruction.VRegB_31t();
77 const uint16_t* table = reinterpret_cast<const uint16_t*>(&instruction) + table_offset;
78 if (sparse) {
79 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kSparseSwitchSignature));
80 } else {
81 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kPackedSwitchSignature));
82 }
83 num_entries_ = table[1];
84 values_ = reinterpret_cast<const int32_t*>(&table[2]);
85 }
86
87 uint16_t GetNumEntries() const {
88 return num_entries_;
89 }
90
Andreas Gampee4d4d322014-12-04 09:09:57 -080091 void CheckIndex(size_t index) const {
92 if (sparse_) {
93 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
94 DCHECK_LT(index, 2 * static_cast<size_t>(num_entries_));
95 } else {
96 // In a packed table, we have the starting key and num_entries_ values.
97 DCHECK_LT(index, 1 + static_cast<size_t>(num_entries_));
98 }
99 }
100
Andreas Gamped881df52014-11-24 23:28:39 -0800101 int32_t GetEntryAt(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800102 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800103 return values_[index];
104 }
105
106 uint32_t GetDexPcForIndex(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800107 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800108 return dex_pc_ +
109 (reinterpret_cast<const int16_t*>(values_ + index) -
110 reinterpret_cast<const int16_t*>(&instruction_));
111 }
112
Andreas Gampee4d4d322014-12-04 09:09:57 -0800113 // Index of the first value in the table.
114 size_t GetFirstValueIndex() const {
115 if (sparse_) {
116 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
117 return num_entries_;
118 } else {
119 // In a packed table, we have the starting key and num_entries_ values.
120 return 1;
121 }
122 }
123
Andreas Gamped881df52014-11-24 23:28:39 -0800124 private:
125 const Instruction& instruction_;
126 const uint32_t dex_pc_;
127
128 // Whether this is a sparse-switch table (or a packed-switch one).
129 const bool sparse_;
130
131 // This can't be const as it needs to be computed off of the given instruction, and complicated
132 // expressions in the initializer list seemed very ugly.
133 uint16_t num_entries_;
134
135 const int32_t* values_;
136
137 DISALLOW_COPY_AND_ASSIGN(SwitchTable);
138};
139
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100140void HGraphBuilder::InitializeLocals(uint16_t count) {
141 graph_->SetNumberOfVRegs(count);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000142 locals_.SetSize(count);
143 for (int i = 0; i < count; i++) {
144 HLocal* local = new (arena_) HLocal(i);
145 entry_block_->AddInstruction(local);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000146 locals_.Put(i, local);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000147 }
148}
149
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000150void HGraphBuilder::InitializeParameters(uint16_t number_of_parameters) {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100151 // dex_compilation_unit_ is null only when unit testing.
152 if (dex_compilation_unit_ == nullptr) {
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000153 return;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100154 }
155
156 graph_->SetNumberOfInVRegs(number_of_parameters);
157 const char* shorty = dex_compilation_unit_->GetShorty();
158 int locals_index = locals_.Size() - number_of_parameters;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100159 int parameter_index = 0;
160
161 if (!dex_compilation_unit_->IsStatic()) {
162 // Add the implicit 'this' argument, not expressed in the signature.
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100163 HParameterValue* parameter =
Calin Juravle10e244f2015-01-26 18:54:32 +0000164 new (arena_) HParameterValue(parameter_index++, Primitive::kPrimNot, true);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100165 entry_block_->AddInstruction(parameter);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100166 HLocal* local = GetLocalAt(locals_index++);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100167 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100168 number_of_parameters--;
169 }
170
171 uint32_t pos = 1;
172 for (int i = 0; i < number_of_parameters; i++) {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100173 HParameterValue* parameter =
174 new (arena_) HParameterValue(parameter_index++, Primitive::GetType(shorty[pos++]));
175 entry_block_->AddInstruction(parameter);
176 HLocal* local = GetLocalAt(locals_index++);
177 // Store the parameter value in the local that the dex code will use
178 // to reference that parameter.
179 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter));
180 bool is_wide = (parameter->GetType() == Primitive::kPrimLong)
181 || (parameter->GetType() == Primitive::kPrimDouble);
182 if (is_wide) {
183 i++;
184 locals_index++;
185 parameter_index++;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100186 }
187 }
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100188}
189
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100190template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000191void HGraphBuilder::If_22t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000192 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000193 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
194 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
195 DCHECK(branch_target != nullptr);
196 DCHECK(fallthrough_target != nullptr);
197 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100198 HInstruction* first = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
199 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
Dave Allison20dfc792014-06-16 20:44:29 -0700200 T* comparison = new (arena_) T(first, second);
201 current_block_->AddInstruction(comparison);
202 HInstruction* ifinst = new (arena_) HIf(comparison);
203 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000204 current_block_->AddSuccessor(branch_target);
205 current_block_->AddSuccessor(fallthrough_target);
Dave Allison20dfc792014-06-16 20:44:29 -0700206 current_block_ = nullptr;
207}
208
209template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000210void HGraphBuilder::If_21t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000211 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000212 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
213 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
214 DCHECK(branch_target != nullptr);
215 DCHECK(fallthrough_target != nullptr);
216 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700217 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
David Brazdil8d5b8b22015-03-24 10:51:52 +0000218 T* comparison = new (arena_) T(value, graph_->GetIntConstant(0));
Dave Allison20dfc792014-06-16 20:44:29 -0700219 current_block_->AddInstruction(comparison);
220 HInstruction* ifinst = new (arena_) HIf(comparison);
221 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000222 current_block_->AddSuccessor(branch_target);
223 current_block_->AddSuccessor(fallthrough_target);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100224 current_block_ = nullptr;
225}
226
Calin Juravle48c2b032014-12-09 18:11:36 +0000227void HGraphBuilder::MaybeRecordStat(MethodCompilationStat compilation_stat) {
228 if (compilation_stats_ != nullptr) {
229 compilation_stats_->RecordStat(compilation_stat);
230 }
231}
232
David Brazdil1b498722015-03-31 11:37:18 +0100233bool HGraphBuilder::SkipCompilation(const DexFile::CodeItem& code_item,
Calin Juravle48c2b032014-12-09 18:11:36 +0000234 size_t number_of_branches) {
235 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000236 CompilerOptions::CompilerFilter compiler_filter = compiler_options.GetCompilerFilter();
237 if (compiler_filter == CompilerOptions::kEverything) {
238 return false;
239 }
240
David Brazdil1b498722015-03-31 11:37:18 +0100241 if (compiler_options.IsHugeMethod(code_item.insns_size_in_code_units_)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000242 VLOG(compiler) << "Skip compilation of huge method "
243 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100244 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000245 MaybeRecordStat(MethodCompilationStat::kNotCompiledHugeMethod);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000246 return true;
247 }
248
249 // If it's large and contains no branches, it's likely to be machine generated initialization.
David Brazdil1b498722015-03-31 11:37:18 +0100250 if (compiler_options.IsLargeMethod(code_item.insns_size_in_code_units_)
251 && (number_of_branches == 0)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000252 VLOG(compiler) << "Skip compilation of large method with no branch "
253 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100254 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000255 MaybeRecordStat(MethodCompilationStat::kNotCompiledLargeMethodNoBranches);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000256 return true;
257 }
258
259 return false;
260}
261
David Brazdilfc6a86a2015-06-26 10:33:45 +0000262bool HGraphBuilder::IsBlockInPcRange(HBasicBlock* block,
263 uint32_t dex_pc_start,
264 uint32_t dex_pc_end) {
265 uint32_t dex_pc = block->GetDexPc();
266 return block != entry_block_
267 && block != exit_block_
268 && dex_pc >= dex_pc_start
269 && dex_pc < dex_pc_end;
270}
271
272void HGraphBuilder::CreateBlocksForTryCatch(const DexFile::CodeItem& code_item) {
273 if (code_item.tries_size_ == 0) {
274 return;
275 }
276
277 // Create branch targets at the start/end of the TryItem range. These are
278 // places where the program might fall through into/out of the a block and
279 // where TryBoundary instructions will be inserted later. Other edges which
280 // enter/exit the try blocks are a result of branches/switches.
281 for (size_t idx = 0; idx < code_item.tries_size_; ++idx) {
282 const DexFile::TryItem* try_item = DexFile::GetTryItems(code_item, idx);
283 uint32_t dex_pc_start = try_item->start_addr_;
284 uint32_t dex_pc_end = dex_pc_start + try_item->insn_count_;
285 FindOrCreateBlockStartingAt(dex_pc_start);
286 if (dex_pc_end < code_item.insns_size_in_code_units_) {
287 // TODO: Do not create block if the last instruction cannot fall through.
288 FindOrCreateBlockStartingAt(dex_pc_end);
289 } else {
290 // The TryItem spans until the very end of the CodeItem (or beyond if
291 // invalid) and therefore cannot have any code afterwards.
292 }
293 }
294
295 // Create branch targets for exception handlers.
296 const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(code_item, 0);
297 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr);
298 for (uint32_t idx = 0; idx < handlers_size; ++idx) {
299 CatchHandlerIterator iterator(handlers_ptr);
300 for (; iterator.HasNext(); iterator.Next()) {
301 uint32_t address = iterator.GetHandlerAddress();
302 HBasicBlock* block = FindOrCreateBlockStartingAt(address);
303 block->SetIsCatchBlock();
304 }
305 handlers_ptr = iterator.EndDataPointer();
306 }
307}
308
David Brazdil56e1acc2015-06-30 15:41:36 +0100309void HGraphBuilder::SplitTryBoundaryEdge(HBasicBlock* predecessor,
310 HBasicBlock* successor,
311 HTryBoundary::BoundaryKind kind,
312 const DexFile::CodeItem& code_item,
313 const DexFile::TryItem& try_item) {
314 // Split the edge with a single TryBoundary instruction.
315 HTryBoundary* try_boundary = new (arena_) HTryBoundary(kind);
316 HBasicBlock* try_entry_block = graph_->SplitEdge(predecessor, successor);
317 try_entry_block->AddInstruction(try_boundary);
318
319 // Link the TryBoundary to the handlers of `try_item`.
320 for (CatchHandlerIterator it(code_item, try_item); it.HasNext(); it.Next()) {
321 try_boundary->AddExceptionHandler(FindBlockStartingAt(it.GetHandlerAddress()));
322 }
323}
324
David Brazdilfc6a86a2015-06-26 10:33:45 +0000325void HGraphBuilder::InsertTryBoundaryBlocks(const DexFile::CodeItem& code_item) {
326 if (code_item.tries_size_ == 0) {
327 return;
328 }
329
David Brazdil281a6322015-07-03 10:34:57 +0100330 // Iterate over all blocks, find those covered by some TryItem and:
331 // (a) split edges which enter/exit the try range,
332 // (b) create TryBoundary instructions in the new blocks,
333 // (c) link the new blocks to corresponding exception handlers.
334 // We cannot iterate only over blocks in `branch_targets_` because switch-case
335 // blocks share the same dex_pc.
336 for (size_t block_id = 1, e = graph_->GetBlocks().Size(); block_id < e; ++block_id) {
337 HBasicBlock* try_block = graph_->GetBlocks().Get(block_id);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000338
David Brazdil281a6322015-07-03 10:34:57 +0100339 // Iteration starts from 1 to skip the entry block.
340 DCHECK_NE(try_block, entry_block_);
341 // Exit block has not yet been added to the graph at this point.
342 DCHECK_NE(try_block, exit_block_);
343 // TryBoundary blocks are added at the end of the list and not iterated over.
344 DCHECK(!try_block->IsSingleTryBoundary());
David Brazdilfc6a86a2015-06-26 10:33:45 +0000345
David Brazdil281a6322015-07-03 10:34:57 +0100346 // Find the TryItem for this block.
347 int32_t try_item_idx = DexFile::FindTryItem(code_item, try_block->GetDexPc());
348 if (try_item_idx == -1) {
349 continue;
350 }
351 const DexFile::TryItem& try_item = *DexFile::GetTryItems(code_item, try_item_idx);
352 uint32_t try_start = try_item.start_addr_;
353 uint32_t try_end = try_start + try_item.insn_count_;
354
355 if (try_block->IsCatchBlock()) {
356 // Catch blocks are always considered an entry point into the TryItem in
357 // order to avoid splitting exceptional edges (they might not have been
358 // created yet). We separate the move-exception (if present) from the
359 // rest of the block and insert a TryBoundary after it, creating a
360 // landing pad for the exceptional edges.
361 HInstruction* first_insn = try_block->GetFirstInstruction();
362 HInstruction* split_position = nullptr;
363 if (first_insn->IsLoadException()) {
364 // Catch block starts with a LoadException. Split the block after the
365 // StoreLocal that must come after the load.
366 DCHECK(first_insn->GetNext()->IsStoreLocal());
367 split_position = first_insn->GetNext()->GetNext();
David Brazdil56e1acc2015-06-30 15:41:36 +0100368 } else {
David Brazdil281a6322015-07-03 10:34:57 +0100369 // Catch block does not obtain the exception. Split at the beginning
370 // to create an empty catch block.
371 split_position = first_insn;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000372 }
David Brazdil281a6322015-07-03 10:34:57 +0100373 DCHECK(split_position != nullptr);
374 HBasicBlock* catch_block = try_block;
375 try_block = catch_block->SplitBefore(split_position);
376 SplitTryBoundaryEdge(catch_block, try_block, HTryBoundary::kEntry, code_item, try_item);
377 } else {
378 // For non-catch blocks, find predecessors which are not covered by the
379 // same TryItem range. Such edges enter the try block and will have
380 // a TryBoundary inserted.
381 for (size_t i = 0; i < try_block->GetPredecessors().Size(); ++i) {
382 HBasicBlock* predecessor = try_block->GetPredecessors().Get(i);
383 if (predecessor->IsSingleTryBoundary()) {
384 // The edge was already split because of an exit from a neighbouring
385 // TryItem. We split it again and insert an entry point.
David Brazdil56e1acc2015-06-30 15:41:36 +0100386 if (kIsDebugBuild) {
David Brazdil281a6322015-07-03 10:34:57 +0100387 HTryBoundary* last_insn = predecessor->GetLastInstruction()->AsTryBoundary();
388 DCHECK(!last_insn->IsEntry());
389 DCHECK_EQ(last_insn->GetNormalFlowSuccessor(), try_block);
390 DCHECK(try_block->IsFirstIndexOfPredecessor(predecessor, i));
391 DCHECK(!IsBlockInPcRange(predecessor->GetSinglePredecessor(), try_start, try_end));
David Brazdil56e1acc2015-06-30 15:41:36 +0100392 }
David Brazdil281a6322015-07-03 10:34:57 +0100393 } else if (!IsBlockInPcRange(predecessor, try_start, try_end)) {
394 // This is an entry point into the TryItem and the edge has not been
395 // split yet. That means that `predecessor` is not in a TryItem, or
396 // it is in a different TryItem and we happened to iterate over this
397 // block first. We split the edge and insert an entry point.
David Brazdilfc6a86a2015-06-26 10:33:45 +0000398 } else {
399 // Not an edge on the boundary of the try block.
400 continue;
401 }
David Brazdil281a6322015-07-03 10:34:57 +0100402 SplitTryBoundaryEdge(predecessor, try_block, HTryBoundary::kEntry, code_item, try_item);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000403 }
404 }
David Brazdil281a6322015-07-03 10:34:57 +0100405
406 // Find successors which are not covered by the same TryItem range. Such
407 // edges exit the try block and will have a TryBoundary inserted.
408 for (size_t i = 0; i < try_block->GetSuccessors().Size(); ++i) {
409 HBasicBlock* successor = try_block->GetSuccessors().Get(i);
410 if (successor->IsCatchBlock()) {
411 // A catch block is always considered an entry point into its TryItem.
412 // We therefore assume this is an exit point, regardless of whether
413 // the catch block is in a different TryItem or not.
414 } else if (successor->IsSingleTryBoundary()) {
415 // The edge was already split because of an entry into a neighbouring
416 // TryItem. We split it again and insert an exit.
417 if (kIsDebugBuild) {
418 HTryBoundary* last_insn = successor->GetLastInstruction()->AsTryBoundary();
419 DCHECK_EQ(try_block, successor->GetSinglePredecessor());
420 DCHECK(last_insn->IsEntry());
421 DCHECK(!IsBlockInPcRange(last_insn->GetNormalFlowSuccessor(), try_start, try_end));
422 }
423 } else if (!IsBlockInPcRange(successor, try_start, try_end)) {
424 // This is an exit out of the TryItem and the edge has not been split
425 // yet. That means that either `successor` is not in a TryItem, or it
426 // is in a different TryItem and we happened to iterate over this
427 // block first. We split the edge and insert an exit.
428 HInstruction* last_instruction = try_block->GetLastInstruction();
429 if (last_instruction->IsReturn() || last_instruction->IsReturnVoid()) {
430 DCHECK_EQ(successor, exit_block_);
431 // Control flow exits the try block with a Return(Void). Because
432 // splitting the edge would invalidate the invariant that Return
433 // always jumps to Exit, we move the Return outside the try block.
434 successor = try_block->SplitBefore(last_instruction);
435 }
436 } else {
437 // Not an edge on the boundary of the try block.
438 continue;
439 }
440 SplitTryBoundaryEdge(try_block, successor, HTryBoundary::kExit, code_item, try_item);
441 }
David Brazdilfc6a86a2015-06-26 10:33:45 +0000442 }
443}
444
David Brazdil5e8b1372015-01-23 14:39:08 +0000445bool HGraphBuilder::BuildGraph(const DexFile::CodeItem& code_item) {
446 DCHECK(graph_->GetBlocks().IsEmpty());
447
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000448 const uint16_t* code_ptr = code_item.insns_;
449 const uint16_t* code_end = code_item.insns_ + code_item.insns_size_in_code_units_;
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +0100450 code_start_ = code_ptr;
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000451
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000452 // Setup the graph with the entry block and exit block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100453 entry_block_ = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000454 graph_->AddBlock(entry_block_);
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100455 exit_block_ = new (arena_) HBasicBlock(graph_, kNoDexPc);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000456 graph_->SetEntryBlock(entry_block_);
457 graph_->SetExitBlock(exit_block_);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000458
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000459 InitializeLocals(code_item.registers_size_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000460 graph_->SetMaximumNumberOfOutVRegs(code_item.outs_size_);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000461
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000462 // Compute the number of dex instructions, blocks, and branches. We will
463 // check these values against limits given to the compiler.
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000464 size_t number_of_branches = 0;
465
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000466 // To avoid splitting blocks, we compute ahead of time the instructions that
467 // start a new block, and create these blocks.
Calin Juravle702d2602015-04-30 19:28:21 +0100468 if (!ComputeBranchTargets(code_ptr, code_end, &number_of_branches)) {
469 MaybeRecordStat(MethodCompilationStat::kNotCompiledBranchOutsideMethodCode);
470 return false;
471 }
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000472
473 // Note that the compiler driver is null when unit testing.
David Brazdil1b498722015-03-31 11:37:18 +0100474 if ((compiler_driver_ != nullptr) && SkipCompilation(code_item, number_of_branches)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000475 return false;
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000476 }
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000477
David Brazdilfc6a86a2015-06-26 10:33:45 +0000478 CreateBlocksForTryCatch(code_item);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +0000479
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000480 InitializeParameters(code_item.ins_size_);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100481
Calin Juravle225ff812014-11-13 16:46:39 +0000482 size_t dex_pc = 0;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000483 while (code_ptr < code_end) {
Calin Juravle225ff812014-11-13 16:46:39 +0000484 // Update the current block if dex_pc starts a new block.
485 MaybeUpdateCurrentBlock(dex_pc);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000486 const Instruction& instruction = *Instruction::At(code_ptr);
Calin Juravle48c2b032014-12-09 18:11:36 +0000487 if (!AnalyzeDexInstruction(instruction, dex_pc)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000488 return false;
Calin Juravle48c2b032014-12-09 18:11:36 +0000489 }
Calin Juravle225ff812014-11-13 16:46:39 +0000490 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000491 code_ptr += instruction.SizeInCodeUnits();
492 }
493
David Brazdilfc6a86a2015-06-26 10:33:45 +0000494 // Add Exit to the exit block.
David Brazdil3e187382015-06-26 09:59:52 +0000495 exit_block_->AddInstruction(new (arena_) HExit());
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000496 // Add the suspend check to the entry block.
497 entry_block_->AddInstruction(new (arena_) HSuspendCheck(0));
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000498 entry_block_->AddInstruction(new (arena_) HGoto());
David Brazdil5e8b1372015-01-23 14:39:08 +0000499
David Brazdilfc6a86a2015-06-26 10:33:45 +0000500 // Iterate over blocks covered by TryItems and insert TryBoundaries at entry
501 // and exit points. This requires all control-flow instructions and
502 // non-exceptional edges to have been created.
503 InsertTryBoundaryBlocks(code_item);
504
505 // Add the exit block at the end to give it the highest id.
506 graph_->AddBlock(exit_block_);
David Brazdil5e8b1372015-01-23 14:39:08 +0000507 return true;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000508}
509
David Brazdilfc6a86a2015-06-26 10:33:45 +0000510void HGraphBuilder::MaybeUpdateCurrentBlock(size_t dex_pc) {
511 HBasicBlock* block = FindBlockStartingAt(dex_pc);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000512 if (block == nullptr) {
513 return;
514 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000515
516 if (current_block_ != nullptr) {
517 // Branching instructions clear current_block, so we know
518 // the last instruction of the current block is not a branching
519 // instruction. We add an unconditional goto to the found block.
520 current_block_->AddInstruction(new (arena_) HGoto());
521 current_block_->AddSuccessor(block);
522 }
523 graph_->AddBlock(block);
524 current_block_ = block;
525}
526
Calin Juravle702d2602015-04-30 19:28:21 +0100527bool HGraphBuilder::ComputeBranchTargets(const uint16_t* code_ptr,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000528 const uint16_t* code_end,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000529 size_t* number_of_branches) {
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000530 branch_targets_.SetSize(code_end - code_ptr);
531
532 // Create the first block for the dex instructions, single successor of the entry block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100533 HBasicBlock* block = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000534 branch_targets_.Put(0, block);
535 entry_block_->AddSuccessor(block);
536
537 // Iterate over all instructions and find branching instructions. Create blocks for
538 // the locations these instructions branch to.
Andreas Gamped881df52014-11-24 23:28:39 -0800539 uint32_t dex_pc = 0;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000540 while (code_ptr < code_end) {
541 const Instruction& instruction = *Instruction::At(code_ptr);
542 if (instruction.IsBranch()) {
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000543 (*number_of_branches)++;
Calin Juravle225ff812014-11-13 16:46:39 +0000544 int32_t target = instruction.GetTargetOffset() + dex_pc;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000545 // Create a block for the target instruction.
David Brazdilfc6a86a2015-06-26 10:33:45 +0000546 FindOrCreateBlockStartingAt(target);
547
Calin Juravle225ff812014-11-13 16:46:39 +0000548 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000549 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100550
David Brazdilfe659462015-06-24 14:23:56 +0100551 if (instruction.CanFlowThrough()) {
552 if (code_ptr >= code_end) {
Calin Juravle702d2602015-04-30 19:28:21 +0100553 // In the normal case we should never hit this but someone can artificially forge a dex
554 // file to fall-through out the method code. In this case we bail out compilation.
555 return false;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000556 } else {
557 FindOrCreateBlockStartingAt(dex_pc);
Calin Juravle702d2602015-04-30 19:28:21 +0100558 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000559 }
Andreas Gampee4d4d322014-12-04 09:09:57 -0800560 } else if (instruction.IsSwitch()) {
561 SwitchTable table(instruction, dex_pc, instruction.Opcode() == Instruction::SPARSE_SWITCH);
Andreas Gamped881df52014-11-24 23:28:39 -0800562
563 uint16_t num_entries = table.GetNumEntries();
564
Andreas Gampee4d4d322014-12-04 09:09:57 -0800565 // In a packed-switch, the entry at index 0 is the starting key. In a sparse-switch, the
566 // entry at index 0 is the first key, and values are after *all* keys.
567 size_t offset = table.GetFirstValueIndex();
568
569 // Use a larger loop counter type to avoid overflow issues.
570 for (size_t i = 0; i < num_entries; ++i) {
Andreas Gamped881df52014-11-24 23:28:39 -0800571 // The target of the case.
Andreas Gampee4d4d322014-12-04 09:09:57 -0800572 uint32_t target = dex_pc + table.GetEntryAt(i + offset);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000573 FindOrCreateBlockStartingAt(target);
Andreas Gamped881df52014-11-24 23:28:39 -0800574
David Brazdil281a6322015-07-03 10:34:57 +0100575 // Create a block for the switch-case logic. The block gets the dex_pc
576 // of the SWITCH instruction because it is part of its semantics.
577 block = new (arena_) HBasicBlock(graph_, dex_pc);
578 branch_targets_.Put(table.GetDexPcForIndex(i), block);
Andreas Gamped881df52014-11-24 23:28:39 -0800579 }
580
581 // Fall-through. Add a block if there is more code afterwards.
582 dex_pc += instruction.SizeInCodeUnits();
583 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100584 if (code_ptr >= code_end) {
585 // In the normal case we should never hit this but someone can artificially forge a dex
586 // file to fall-through out the method code. In this case we bail out compilation.
587 // (A switch can fall-through so we don't need to check CanFlowThrough().)
588 return false;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000589 } else {
590 FindOrCreateBlockStartingAt(dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -0800591 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000592 } else {
593 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle225ff812014-11-13 16:46:39 +0000594 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000595 }
596 }
Calin Juravle702d2602015-04-30 19:28:21 +0100597 return true;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000598}
599
David Brazdilfc6a86a2015-06-26 10:33:45 +0000600HBasicBlock* HGraphBuilder::FindBlockStartingAt(int32_t dex_pc) const {
601 DCHECK_GE(dex_pc, 0);
602 DCHECK_LT(static_cast<size_t>(dex_pc), branch_targets_.Size());
603 return branch_targets_.Get(dex_pc);
604}
605
606HBasicBlock* HGraphBuilder::FindOrCreateBlockStartingAt(int32_t dex_pc) {
607 HBasicBlock* block = FindBlockStartingAt(dex_pc);
608 if (block == nullptr) {
609 block = new (arena_) HBasicBlock(graph_, dex_pc);
610 branch_targets_.Put(dex_pc, block);
611 }
612 return block;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000613}
614
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100615template<typename T>
Roland Levillain88cb1752014-10-20 16:36:47 +0100616void HGraphBuilder::Unop_12x(const Instruction& instruction, Primitive::Type type) {
617 HInstruction* first = LoadLocal(instruction.VRegB(), type);
618 current_block_->AddInstruction(new (arena_) T(type, first));
619 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
620}
621
Roland Levillaindff1f282014-11-05 14:15:05 +0000622void HGraphBuilder::Conversion_12x(const Instruction& instruction,
623 Primitive::Type input_type,
Roland Levillain624279f2014-12-04 11:54:28 +0000624 Primitive::Type result_type,
625 uint32_t dex_pc) {
Roland Levillaindff1f282014-11-05 14:15:05 +0000626 HInstruction* first = LoadLocal(instruction.VRegB(), input_type);
Roland Levillain624279f2014-12-04 11:54:28 +0000627 current_block_->AddInstruction(new (arena_) HTypeConversion(result_type, first, dex_pc));
Roland Levillaindff1f282014-11-05 14:15:05 +0000628 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
629}
630
Roland Levillain88cb1752014-10-20 16:36:47 +0100631template<typename T>
Nicolas Geoffray412f10c2014-06-19 10:00:34 +0100632void HGraphBuilder::Binop_23x(const Instruction& instruction, Primitive::Type type) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100633 HInstruction* first = LoadLocal(instruction.VRegB(), type);
634 HInstruction* second = LoadLocal(instruction.VRegC(), type);
635 current_block_->AddInstruction(new (arena_) T(type, first, second));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100636 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
637}
638
639template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000640void HGraphBuilder::Binop_23x(const Instruction& instruction,
641 Primitive::Type type,
642 uint32_t dex_pc) {
643 HInstruction* first = LoadLocal(instruction.VRegB(), type);
644 HInstruction* second = LoadLocal(instruction.VRegC(), type);
645 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
646 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
647}
648
649template<typename T>
Calin Juravle9aec02f2014-11-18 23:06:35 +0000650void HGraphBuilder::Binop_23x_shift(const Instruction& instruction,
651 Primitive::Type type) {
652 HInstruction* first = LoadLocal(instruction.VRegB(), type);
653 HInstruction* second = LoadLocal(instruction.VRegC(), Primitive::kPrimInt);
654 current_block_->AddInstruction(new (arena_) T(type, first, second));
655 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
656}
657
Calin Juravleddb7df22014-11-25 20:56:51 +0000658void HGraphBuilder::Binop_23x_cmp(const Instruction& instruction,
659 Primitive::Type type,
Alexey Frunze4dda3372015-06-01 18:31:49 -0700660 HCompare::Bias bias,
661 uint32_t dex_pc) {
Calin Juravleddb7df22014-11-25 20:56:51 +0000662 HInstruction* first = LoadLocal(instruction.VRegB(), type);
663 HInstruction* second = LoadLocal(instruction.VRegC(), type);
Alexey Frunze4dda3372015-06-01 18:31:49 -0700664 current_block_->AddInstruction(new (arena_) HCompare(type, first, second, bias, dex_pc));
Calin Juravleddb7df22014-11-25 20:56:51 +0000665 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
666}
667
Calin Juravle9aec02f2014-11-18 23:06:35 +0000668template<typename T>
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100669void HGraphBuilder::Binop_12x(const Instruction& instruction, Primitive::Type type) {
670 HInstruction* first = LoadLocal(instruction.VRegA(), type);
671 HInstruction* second = LoadLocal(instruction.VRegB(), type);
672 current_block_->AddInstruction(new (arena_) T(type, first, second));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100673 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
674}
675
676template<typename T>
Calin Juravle9aec02f2014-11-18 23:06:35 +0000677void HGraphBuilder::Binop_12x_shift(const Instruction& instruction, Primitive::Type type) {
678 HInstruction* first = LoadLocal(instruction.VRegA(), type);
679 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
680 current_block_->AddInstruction(new (arena_) T(type, first, second));
681 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
682}
683
684template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000685void HGraphBuilder::Binop_12x(const Instruction& instruction,
686 Primitive::Type type,
687 uint32_t dex_pc) {
688 HInstruction* first = LoadLocal(instruction.VRegA(), type);
689 HInstruction* second = LoadLocal(instruction.VRegB(), type);
690 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
691 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
692}
693
694template<typename T>
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100695void HGraphBuilder::Binop_22s(const Instruction& instruction, bool reverse) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100696 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
David Brazdil8d5b8b22015-03-24 10:51:52 +0000697 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22s());
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100698 if (reverse) {
699 std::swap(first, second);
700 }
701 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second));
702 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
703}
704
705template<typename T>
706void HGraphBuilder::Binop_22b(const Instruction& instruction, bool reverse) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100707 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
David Brazdil8d5b8b22015-03-24 10:51:52 +0000708 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22b());
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100709 if (reverse) {
710 std::swap(first, second);
711 }
712 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second));
713 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
714}
715
Calin Juravle0c25d102015-04-20 14:49:09 +0100716static bool RequiresConstructorBarrier(const DexCompilationUnit* cu, const CompilerDriver& driver) {
Calin Juravle27df7582015-04-17 19:12:31 +0100717 Thread* self = Thread::Current();
Calin Juravle0c25d102015-04-20 14:49:09 +0100718 return cu->IsConstructor()
719 && driver.RequiresConstructorBarrier(self, cu->GetDexFile(), cu->GetClassDefIndex());
Calin Juravle27df7582015-04-17 19:12:31 +0100720}
721
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100722void HGraphBuilder::BuildReturn(const Instruction& instruction, Primitive::Type type) {
723 if (type == Primitive::kPrimVoid) {
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100724 if (graph_->ShouldGenerateConstructorBarrier()) {
725 // The compilation unit is null during testing.
726 if (dex_compilation_unit_ != nullptr) {
727 DCHECK(RequiresConstructorBarrier(dex_compilation_unit_, *compiler_driver_))
728 << "Inconsistent use of ShouldGenerateConstructorBarrier. Should not generate a barrier.";
729 }
Calin Juravle27df7582015-04-17 19:12:31 +0100730 current_block_->AddInstruction(new (arena_) HMemoryBarrier(kStoreStore));
731 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100732 current_block_->AddInstruction(new (arena_) HReturnVoid());
733 } else {
734 HInstruction* value = LoadLocal(instruction.VRegA(), type);
735 current_block_->AddInstruction(new (arena_) HReturn(value));
736 }
737 current_block_->AddSuccessor(exit_block_);
738 current_block_ = nullptr;
739}
740
741bool HGraphBuilder::BuildInvoke(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +0000742 uint32_t dex_pc,
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100743 uint32_t method_idx,
744 uint32_t number_of_vreg_arguments,
745 bool is_range,
746 uint32_t* args,
747 uint32_t register_index) {
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100748 Instruction::Code opcode = instruction.Opcode();
749 InvokeType invoke_type;
750 switch (opcode) {
751 case Instruction::INVOKE_STATIC:
752 case Instruction::INVOKE_STATIC_RANGE:
753 invoke_type = kStatic;
754 break;
755 case Instruction::INVOKE_DIRECT:
756 case Instruction::INVOKE_DIRECT_RANGE:
757 invoke_type = kDirect;
758 break;
759 case Instruction::INVOKE_VIRTUAL:
760 case Instruction::INVOKE_VIRTUAL_RANGE:
761 invoke_type = kVirtual;
762 break;
763 case Instruction::INVOKE_INTERFACE:
764 case Instruction::INVOKE_INTERFACE_RANGE:
765 invoke_type = kInterface;
766 break;
767 case Instruction::INVOKE_SUPER_RANGE:
768 case Instruction::INVOKE_SUPER:
769 invoke_type = kSuper;
770 break;
771 default:
772 LOG(FATAL) << "Unexpected invoke op: " << opcode;
773 return false;
774 }
775
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100776 const DexFile::MethodId& method_id = dex_file_->GetMethodId(method_idx);
777 const DexFile::ProtoId& proto_id = dex_file_->GetProtoId(method_id.proto_idx_);
778 const char* descriptor = dex_file_->StringDataByIdx(proto_id.shorty_idx_);
779 Primitive::Type return_type = Primitive::GetType(descriptor[0]);
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100780 bool is_instance_call = invoke_type != kStatic;
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100781 // Remove the return type from the 'proto'.
782 size_t number_of_arguments = strlen(descriptor) - 1;
783 if (is_instance_call) {
784 // One extra argument for 'this'.
785 ++number_of_arguments;
786 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100787
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000788 MethodReference target_method(dex_file_, method_idx);
789 uintptr_t direct_code;
790 uintptr_t direct_method;
791 int table_index;
792 InvokeType optimized_invoke_type = invoke_type;
Nicolas Geoffray52839d12014-11-07 17:47:25 +0000793
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000794 if (!compiler_driver_->ComputeInvokeInfo(dex_compilation_unit_, dex_pc, true, true,
795 &optimized_invoke_type, &target_method, &table_index,
796 &direct_code, &direct_method)) {
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100797 VLOG(compiler) << "Did not compile "
798 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
Calin Juravle48c2b032014-12-09 18:11:36 +0000799 << " because a method call could not be resolved";
800 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedMethod);
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000801 return false;
802 }
803 DCHECK(optimized_invoke_type != kSuper);
804
Roland Levillain4c0eb422015-04-24 16:43:49 +0100805 // By default, consider that the called method implicitly requires
806 // an initialization check of its declaring method.
807 HInvokeStaticOrDirect::ClinitCheckRequirement clinit_check_requirement =
808 HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit;
809 // Potential class initialization check, in the case of a static method call.
810 HClinitCheck* clinit_check = nullptr;
Jeff Hao848f70a2014-01-15 13:49:50 -0800811 // Replace calls to String.<init> with StringFactory.
812 int32_t string_init_offset = 0;
813 bool is_string_init = compiler_driver_->IsStringInit(method_idx, dex_file_, &string_init_offset);
814 if (is_string_init) {
815 return_type = Primitive::kPrimNot;
816 is_instance_call = false;
817 number_of_arguments--;
818 invoke_type = kStatic;
819 optimized_invoke_type = kStatic;
820 }
Roland Levillain4c0eb422015-04-24 16:43:49 +0100821
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000822 HInvoke* invoke = nullptr;
Roland Levillain4c0eb422015-04-24 16:43:49 +0100823
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000824 if (optimized_invoke_type == kVirtual) {
825 invoke = new (arena_) HInvokeVirtual(
Andreas Gampe71fb52f2014-12-29 17:43:08 -0800826 arena_, number_of_arguments, return_type, dex_pc, method_idx, table_index);
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000827 } else if (optimized_invoke_type == kInterface) {
828 invoke = new (arena_) HInvokeInterface(
829 arena_, number_of_arguments, return_type, dex_pc, method_idx, table_index);
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100830 } else {
Calin Juravlec7c8fe22014-12-02 11:42:34 +0000831 DCHECK(optimized_invoke_type == kDirect || optimized_invoke_type == kStatic);
832 // Sharpening to kDirect only works if we compile PIC.
833 DCHECK((optimized_invoke_type == invoke_type) || (optimized_invoke_type != kDirect)
834 || compiler_driver_->GetCompilerOptions().GetCompilePic());
Nicolas Geoffray1cf95282014-12-12 19:22:03 +0000835 bool is_recursive =
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100836 (target_method.dex_method_index == outer_compilation_unit_->GetDexMethodIndex())
837 && (target_method.dex_file == outer_compilation_unit_->GetDexFile());
Roland Levillain4c0eb422015-04-24 16:43:49 +0100838
Jeff Haocad65422015-06-18 21:16:08 -0700839 if (optimized_invoke_type == kStatic && !is_string_init) {
Roland Levillain4c0eb422015-04-24 16:43:49 +0100840 ScopedObjectAccess soa(Thread::Current());
841 StackHandleScope<4> hs(soa.Self());
842 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
843 dex_compilation_unit_->GetClassLinker()->FindDexCache(
844 *dex_compilation_unit_->GetDexFile())));
845 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
846 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
Mathieu Chartiere401d142015-04-22 13:56:20 -0700847 ArtMethod* resolved_method = compiler_driver_->ResolveMethod(
848 soa, dex_cache, class_loader, dex_compilation_unit_, method_idx, optimized_invoke_type);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100849
850 if (resolved_method == nullptr) {
851 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedMethod);
852 return false;
853 }
854
855 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
856 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
857 outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file)));
Nicolas Geoffrayafd06412015-06-20 22:44:47 +0100858 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Roland Levillain4c0eb422015-04-24 16:43:49 +0100859
860 // The index at which the method's class is stored in the DexCache's type array.
861 uint32_t storage_index = DexFile::kDexNoIndex;
Nicolas Geoffrayafd06412015-06-20 22:44:47 +0100862 bool is_outer_class = (resolved_method->GetDeclaringClass() == outer_class.Get());
863 if (is_outer_class) {
864 storage_index = outer_class->GetDexTypeIndex();
Roland Levillain4c0eb422015-04-24 16:43:49 +0100865 } else if (outer_dex_cache.Get() == dex_cache.Get()) {
866 // Get `storage_index` from IsClassOfStaticMethodAvailableToReferrer.
867 compiler_driver_->IsClassOfStaticMethodAvailableToReferrer(outer_dex_cache.Get(),
Nicolas Geoffrayafd06412015-06-20 22:44:47 +0100868 GetCompilingClass(),
Roland Levillain4c0eb422015-04-24 16:43:49 +0100869 resolved_method,
870 method_idx,
871 &storage_index);
872 }
873
Nicolas Geoffrayb783b402015-06-22 11:06:43 +0100874 if (!outer_class->IsInterface()
875 && outer_class->IsSubClass(resolved_method->GetDeclaringClass())) {
Nicolas Geoffrayafd06412015-06-20 22:44:47 +0100876 // If the outer class is the declaring class or a subclass
Roland Levillain5f02c6c2015-04-24 19:14:22 +0100877 // of the declaring class, no class initialization is needed
878 // before the static method call.
Nicolas Geoffrayafd06412015-06-20 22:44:47 +0100879 // Note that in case of inlining, we do not need to add clinit checks
880 // to calls that satisfy this subclass check with any inlined methods. This
881 // will be detected by the optimization passes.
Roland Levillain4c0eb422015-04-24 16:43:49 +0100882 clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
883 } else if (storage_index != DexFile::kDexNoIndex) {
884 // If the method's class type index is available, check
885 // whether we should add an explicit class initialization
886 // check for its declaring class before the static method call.
887
888 // TODO: find out why this check is needed.
889 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
890 *outer_compilation_unit_->GetDexFile(), storage_index);
891 bool is_initialized =
892 resolved_method->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
893
894 if (is_initialized) {
895 clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
896 } else {
897 clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit;
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +0100898 HLoadClass* load_class = new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +0100899 graph_->GetCurrentMethod(),
900 storage_index,
901 *dex_compilation_unit_->GetDexFile(),
Nicolas Geoffrayafd06412015-06-20 22:44:47 +0100902 is_outer_class,
Nicolas Geoffray76b1e172015-05-27 17:18:33 +0100903 dex_pc);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100904 current_block_->AddInstruction(load_class);
905 clinit_check = new (arena_) HClinitCheck(load_class, dex_pc);
906 current_block_->AddInstruction(clinit_check);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100907 }
908 }
909 }
910
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100911 invoke = new (arena_) HInvokeStaticOrDirect(arena_,
912 number_of_arguments,
913 return_type,
914 dex_pc,
915 target_method.dex_method_index,
916 is_recursive,
917 string_init_offset,
918 invoke_type,
919 optimized_invoke_type,
920 clinit_check_requirement);
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +0100921 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100922
923 size_t start_index = 0;
Calin Juravlef97f9fb2014-11-11 15:38:19 +0000924 Temporaries temps(graph_);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100925 if (is_instance_call) {
926 HInstruction* arg = LoadLocal(is_range ? register_index : args[0], Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +0000927 HNullCheck* null_check = new (arena_) HNullCheck(arg, dex_pc);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +0100928 current_block_->AddInstruction(null_check);
929 temps.Add(null_check);
930 invoke->SetArgumentAt(0, null_check);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100931 start_index = 1;
932 }
933
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100934 uint32_t descriptor_index = 1; // Skip the return type.
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100935 uint32_t argument_index = start_index;
Jeff Hao848f70a2014-01-15 13:49:50 -0800936 if (is_string_init) {
937 start_index = 1;
938 }
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100939 for (size_t i = start_index;
940 // Make sure we don't go over the expected arguments or over the number of
941 // dex registers given. If the instruction was seen as dead by the verifier,
942 // it hasn't been properly checked.
943 (i < number_of_vreg_arguments) && (argument_index < number_of_arguments);
944 i++, argument_index++) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100945 Primitive::Type type = Primitive::GetType(descriptor[descriptor_index++]);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100946 bool is_wide = (type == Primitive::kPrimLong) || (type == Primitive::kPrimDouble);
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100947 if (!is_range
948 && is_wide
949 && ((i + 1 == number_of_vreg_arguments) || (args[i] + 1 != args[i + 1]))) {
950 // Longs and doubles should be in pairs, that is, sequential registers. The verifier should
951 // reject any class where this is violated. However, the verifier only does these checks
952 // on non trivially dead instructions, so we just bailout the compilation.
953 VLOG(compiler) << "Did not compile "
954 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
955 << " because of non-sequential dex register pair in wide argument";
956 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
957 return false;
958 }
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100959 HInstruction* arg = LoadLocal(is_range ? register_index + i : args[i], type);
960 invoke->SetArgumentAt(argument_index, arg);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100961 if (is_wide) {
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +0100962 i++;
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100963 }
964 }
Nicolas Geoffray2e335252015-06-18 11:11:27 +0100965
966 if (argument_index != number_of_arguments) {
967 VLOG(compiler) << "Did not compile "
968 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
969 << " because of wrong number of arguments in invoke instruction";
970 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
971 return false;
972 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100973
Nicolas Geoffray38207af2015-06-01 15:46:22 +0100974 if (invoke->IsInvokeStaticOrDirect()) {
975 invoke->SetArgumentAt(argument_index, graph_->GetCurrentMethod());
976 argument_index++;
977 }
978
Roland Levillain4c0eb422015-04-24 16:43:49 +0100979 if (clinit_check_requirement == HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit) {
980 // Add the class initialization check as last input of `invoke`.
981 DCHECK(clinit_check != nullptr);
Roland Levillain3e3d7332015-04-28 11:00:54 +0100982 invoke->SetArgumentAt(argument_index, clinit_check);
Roland Levillain4c0eb422015-04-24 16:43:49 +0100983 }
984
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100985 current_block_->AddInstruction(invoke);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +0100986 latest_result_ = invoke;
Jeff Hao848f70a2014-01-15 13:49:50 -0800987
988 // Add move-result for StringFactory method.
989 if (is_string_init) {
990 uint32_t orig_this_reg = is_range ? register_index : args[0];
Nicolas Geoffrayaa919202015-06-21 18:57:02 +0100991 UpdateLocal(orig_this_reg, invoke);
Jeff Hao848f70a2014-01-15 13:49:50 -0800992 const VerifiedMethod* verified_method =
993 compiler_driver_->GetVerifiedMethod(dex_file_, dex_compilation_unit_->GetDexMethodIndex());
994 if (verified_method == nullptr) {
995 LOG(WARNING) << "No verified method for method calling String.<init>: "
996 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_);
997 return false;
998 }
999 const SafeMap<uint32_t, std::set<uint32_t>>& string_init_map =
1000 verified_method->GetStringInitPcRegMap();
1001 auto map_it = string_init_map.find(dex_pc);
1002 if (map_it != string_init_map.end()) {
1003 std::set<uint32_t> reg_set = map_it->second;
1004 for (auto set_it = reg_set.begin(); set_it != reg_set.end(); ++set_it) {
Nicolas Geoffrayaa919202015-06-21 18:57:02 +01001005 HInstruction* load_local = LoadLocal(orig_this_reg, Primitive::kPrimNot);
1006 UpdateLocal(*set_it, load_local);
Jeff Hao848f70a2014-01-15 13:49:50 -08001007 }
1008 }
Jeff Hao848f70a2014-01-15 13:49:50 -08001009 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001010 return true;
1011}
1012
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001013bool HGraphBuilder::BuildInstanceFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001014 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001015 bool is_put) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001016 uint32_t source_or_dest_reg = instruction.VRegA_22c();
1017 uint32_t obj_reg = instruction.VRegB_22c();
1018 uint16_t field_index = instruction.VRegC_22c();
1019
1020 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -07001021 ArtField* resolved_field =
1022 compiler_driver_->ComputeInstanceFieldInfo(field_index, dex_compilation_unit_, is_put, soa);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001023
Mathieu Chartierc7853442015-03-27 14:35:38 -07001024 if (resolved_field == nullptr) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001025 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001026 return false;
1027 }
Calin Juravle52c48962014-12-16 17:02:57 +00001028
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001029 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001030
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001031 HInstruction* object = LoadLocal(obj_reg, Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00001032 current_block_->AddInstruction(new (arena_) HNullCheck(object, dex_pc));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001033 if (is_put) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001034 Temporaries temps(graph_);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001035 HInstruction* null_check = current_block_->GetLastInstruction();
1036 // We need one temporary for the null check.
1037 temps.Add(null_check);
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001038 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001039 current_block_->AddInstruction(new (arena_) HInstanceFieldSet(
1040 null_check,
1041 value,
Nicolas Geoffray39468442014-09-02 15:17:15 +01001042 field_type,
Calin Juravle52c48962014-12-16 17:02:57 +00001043 resolved_field->GetOffset(),
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001044 resolved_field->IsVolatile(),
1045 field_index,
1046 *dex_file_));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001047 } else {
1048 current_block_->AddInstruction(new (arena_) HInstanceFieldGet(
1049 current_block_->GetLastInstruction(),
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001050 field_type,
Calin Juravle52c48962014-12-16 17:02:57 +00001051 resolved_field->GetOffset(),
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001052 resolved_field->IsVolatile(),
1053 field_index,
1054 *dex_file_));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001055
1056 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1057 }
1058 return true;
1059}
1060
Nicolas Geoffray30451742015-06-19 13:32:41 +01001061static mirror::Class* GetClassFrom(CompilerDriver* driver,
1062 const DexCompilationUnit& compilation_unit) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001063 ScopedObjectAccess soa(Thread::Current());
1064 StackHandleScope<2> hs(soa.Self());
Nicolas Geoffray30451742015-06-19 13:32:41 +01001065 const DexFile& dex_file = *compilation_unit.GetDexFile();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001066 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
Nicolas Geoffray30451742015-06-19 13:32:41 +01001067 soa.Decode<mirror::ClassLoader*>(compilation_unit.GetClassLoader())));
1068 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
1069 compilation_unit.GetClassLinker()->FindDexCache(dex_file)));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001070
Nicolas Geoffray30451742015-06-19 13:32:41 +01001071 return driver->ResolveCompilingMethodsClass(soa, dex_cache, class_loader, &compilation_unit);
1072}
1073
1074mirror::Class* HGraphBuilder::GetOutermostCompilingClass() const {
1075 return GetClassFrom(compiler_driver_, *outer_compilation_unit_);
1076}
1077
1078mirror::Class* HGraphBuilder::GetCompilingClass() const {
1079 return GetClassFrom(compiler_driver_, *dex_compilation_unit_);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001080}
1081
1082bool HGraphBuilder::IsOutermostCompilingClass(uint16_t type_index) const {
1083 ScopedObjectAccess soa(Thread::Current());
1084 StackHandleScope<4> hs(soa.Self());
1085 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
1086 dex_compilation_unit_->GetClassLinker()->FindDexCache(*dex_compilation_unit_->GetDexFile())));
1087 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1088 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
1089 Handle<mirror::Class> cls(hs.NewHandle(compiler_driver_->ResolveClass(
1090 soa, dex_cache, class_loader, type_index, dex_compilation_unit_)));
Nicolas Geoffrayafd06412015-06-20 22:44:47 +01001091 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001092
Nicolas Geoffrayafd06412015-06-20 22:44:47 +01001093 return outer_class.Get() == cls.Get();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001094}
1095
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001096bool HGraphBuilder::BuildStaticFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001097 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001098 bool is_put) {
1099 uint32_t source_or_dest_reg = instruction.VRegA_21c();
1100 uint16_t field_index = instruction.VRegB_21c();
1101
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001102 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -07001103 StackHandleScope<4> hs(soa.Self());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001104 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
1105 dex_compilation_unit_->GetClassLinker()->FindDexCache(*dex_compilation_unit_->GetDexFile())));
1106 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1107 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
Mathieu Chartierc7853442015-03-27 14:35:38 -07001108 ArtField* resolved_field = compiler_driver_->ResolveField(
1109 soa, dex_cache, class_loader, dex_compilation_unit_, field_index, true);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001110
Mathieu Chartierc7853442015-03-27 14:35:38 -07001111 if (resolved_field == nullptr) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001112 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001113 return false;
1114 }
1115
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001116 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
1117 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
1118 outer_compilation_unit_->GetClassLinker()->FindDexCache(outer_dex_file)));
Nicolas Geoffray30451742015-06-19 13:32:41 +01001119 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001120
1121 // The index at which the field's class is stored in the DexCache's type array.
1122 uint32_t storage_index;
Nicolas Geoffray30451742015-06-19 13:32:41 +01001123 bool is_outer_class = (outer_class.Get() == resolved_field->GetDeclaringClass());
1124 if (is_outer_class) {
1125 storage_index = outer_class->GetDexTypeIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001126 } else if (outer_dex_cache.Get() != dex_cache.Get()) {
Roland Levillain4c0eb422015-04-24 16:43:49 +01001127 // The compiler driver cannot currently understand multiple dex caches involved. Just bailout.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001128 return false;
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001129 } else {
1130 std::pair<bool, bool> pair = compiler_driver_->IsFastStaticField(
1131 outer_dex_cache.Get(),
Nicolas Geoffray30451742015-06-19 13:32:41 +01001132 GetCompilingClass(),
Mathieu Chartierc7853442015-03-27 14:35:38 -07001133 resolved_field,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001134 field_index,
1135 &storage_index);
1136 bool can_easily_access = is_put ? pair.second : pair.first;
1137 if (!can_easily_access) {
1138 return false;
1139 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001140 }
1141
1142 // TODO: find out why this check is needed.
1143 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
Nicolas Geoffray6a816cf2015-03-24 16:17:56 +00001144 *outer_compilation_unit_->GetDexFile(), storage_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001145 bool is_initialized = resolved_field->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001146
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001147 HLoadClass* constant = new (arena_) HLoadClass(graph_->GetCurrentMethod(),
1148 storage_index,
1149 *dex_compilation_unit_->GetDexFile(),
Nicolas Geoffray30451742015-06-19 13:32:41 +01001150 is_outer_class,
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001151 dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001152 current_block_->AddInstruction(constant);
1153
1154 HInstruction* cls = constant;
Nicolas Geoffray30451742015-06-19 13:32:41 +01001155 if (!is_initialized && !is_outer_class) {
Calin Juravle225ff812014-11-13 16:46:39 +00001156 cls = new (arena_) HClinitCheck(constant, dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001157 current_block_->AddInstruction(cls);
1158 }
1159
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001160 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001161 if (is_put) {
1162 // We need to keep the class alive before loading the value.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001163 Temporaries temps(graph_);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001164 temps.Add(cls);
1165 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
1166 DCHECK_EQ(value->GetType(), field_type);
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001167 current_block_->AddInstruction(new (arena_) HStaticFieldSet(cls,
1168 value,
1169 field_type,
1170 resolved_field->GetOffset(),
1171 resolved_field->IsVolatile(),
1172 field_index,
1173 *dex_file_));
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001174 } else {
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001175 current_block_->AddInstruction(new (arena_) HStaticFieldGet(cls,
1176 field_type,
1177 resolved_field->GetOffset(),
1178 resolved_field->IsVolatile(),
1179 field_index,
1180 *dex_file_));
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001181 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1182 }
1183 return true;
1184}
1185
Calin Juravlebacfec32014-11-14 15:54:36 +00001186void HGraphBuilder::BuildCheckedDivRem(uint16_t out_vreg,
1187 uint16_t first_vreg,
1188 int64_t second_vreg_or_constant,
1189 uint32_t dex_pc,
1190 Primitive::Type type,
1191 bool second_is_constant,
1192 bool isDiv) {
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001193 DCHECK(type == Primitive::kPrimInt || type == Primitive::kPrimLong);
Calin Juravled0d48522014-11-04 16:40:20 +00001194
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001195 HInstruction* first = LoadLocal(first_vreg, type);
1196 HInstruction* second = nullptr;
1197 if (second_is_constant) {
1198 if (type == Primitive::kPrimInt) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001199 second = graph_->GetIntConstant(second_vreg_or_constant);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001200 } else {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001201 second = graph_->GetLongConstant(second_vreg_or_constant);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001202 }
1203 } else {
1204 second = LoadLocal(second_vreg_or_constant, type);
1205 }
1206
1207 if (!second_is_constant
1208 || (type == Primitive::kPrimInt && second->AsIntConstant()->GetValue() == 0)
1209 || (type == Primitive::kPrimLong && second->AsLongConstant()->GetValue() == 0)) {
1210 second = new (arena_) HDivZeroCheck(second, dex_pc);
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001211 Temporaries temps(graph_);
Calin Juravled0d48522014-11-04 16:40:20 +00001212 current_block_->AddInstruction(second);
1213 temps.Add(current_block_->GetLastInstruction());
1214 }
1215
Calin Juravlebacfec32014-11-14 15:54:36 +00001216 if (isDiv) {
1217 current_block_->AddInstruction(new (arena_) HDiv(type, first, second, dex_pc));
1218 } else {
1219 current_block_->AddInstruction(new (arena_) HRem(type, first, second, dex_pc));
1220 }
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001221 UpdateLocal(out_vreg, current_block_->GetLastInstruction());
Calin Juravled0d48522014-11-04 16:40:20 +00001222}
1223
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001224void HGraphBuilder::BuildArrayAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001225 uint32_t dex_pc,
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001226 bool is_put,
1227 Primitive::Type anticipated_type) {
1228 uint8_t source_or_dest_reg = instruction.VRegA_23x();
1229 uint8_t array_reg = instruction.VRegB_23x();
1230 uint8_t index_reg = instruction.VRegC_23x();
1231
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001232 // We need one temporary for the null check, one for the index, and one for the length.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001233 Temporaries temps(graph_);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001234
1235 HInstruction* object = LoadLocal(array_reg, Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00001236 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001237 current_block_->AddInstruction(object);
1238 temps.Add(object);
1239
1240 HInstruction* length = new (arena_) HArrayLength(object);
1241 current_block_->AddInstruction(length);
1242 temps.Add(length);
1243 HInstruction* index = LoadLocal(index_reg, Primitive::kPrimInt);
Calin Juravle225ff812014-11-13 16:46:39 +00001244 index = new (arena_) HBoundsCheck(index, length, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001245 current_block_->AddInstruction(index);
1246 temps.Add(index);
1247 if (is_put) {
1248 HInstruction* value = LoadLocal(source_or_dest_reg, anticipated_type);
1249 // TODO: Insert a type check node if the type is Object.
Nicolas Geoffray39468442014-09-02 15:17:15 +01001250 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001251 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001252 } else {
1253 current_block_->AddInstruction(new (arena_) HArrayGet(object, index, anticipated_type));
1254 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1255 }
Mark Mendell1152c922015-04-24 17:06:35 -04001256 graph_->SetHasBoundsChecks(true);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001257}
1258
Calin Juravle225ff812014-11-13 16:46:39 +00001259void HGraphBuilder::BuildFilledNewArray(uint32_t dex_pc,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001260 uint32_t type_index,
1261 uint32_t number_of_vreg_arguments,
1262 bool is_range,
1263 uint32_t* args,
1264 uint32_t register_index) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001265 HInstruction* length = graph_->GetIntConstant(number_of_vreg_arguments);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001266 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
1267 ? kQuickAllocArrayWithAccessCheck
1268 : kQuickAllocArray;
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001269 HInstruction* object = new (arena_) HNewArray(length,
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01001270 graph_->GetCurrentMethod(),
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001271 dex_pc,
1272 type_index,
1273 *dex_compilation_unit_->GetDexFile(),
1274 entrypoint);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001275 current_block_->AddInstruction(object);
1276
1277 const char* descriptor = dex_file_->StringByTypeIdx(type_index);
1278 DCHECK_EQ(descriptor[0], '[') << descriptor;
1279 char primitive = descriptor[1];
1280 DCHECK(primitive == 'I'
1281 || primitive == 'L'
1282 || primitive == '[') << descriptor;
1283 bool is_reference_array = (primitive == 'L') || (primitive == '[');
1284 Primitive::Type type = is_reference_array ? Primitive::kPrimNot : Primitive::kPrimInt;
1285
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001286 Temporaries temps(graph_);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001287 temps.Add(object);
1288 for (size_t i = 0; i < number_of_vreg_arguments; ++i) {
1289 HInstruction* value = LoadLocal(is_range ? register_index + i : args[i], type);
David Brazdil8d5b8b22015-03-24 10:51:52 +00001290 HInstruction* index = graph_->GetIntConstant(i);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001291 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001292 new (arena_) HArraySet(object, index, value, type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001293 }
1294 latest_result_ = object;
1295}
1296
1297template <typename T>
1298void HGraphBuilder::BuildFillArrayData(HInstruction* object,
1299 const T* data,
1300 uint32_t element_count,
1301 Primitive::Type anticipated_type,
Calin Juravle225ff812014-11-13 16:46:39 +00001302 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001303 for (uint32_t i = 0; i < element_count; ++i) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001304 HInstruction* index = graph_->GetIntConstant(i);
1305 HInstruction* value = graph_->GetIntConstant(data[i]);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001306 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001307 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001308 }
1309}
1310
Calin Juravle225ff812014-11-13 16:46:39 +00001311void HGraphBuilder::BuildFillArrayData(const Instruction& instruction, uint32_t dex_pc) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001312 Temporaries temps(graph_);
Calin Juravled0d48522014-11-04 16:40:20 +00001313 HInstruction* array = LoadLocal(instruction.VRegA_31t(), Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00001314 HNullCheck* null_check = new (arena_) HNullCheck(array, dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001315 current_block_->AddInstruction(null_check);
1316 temps.Add(null_check);
1317
1318 HInstruction* length = new (arena_) HArrayLength(null_check);
1319 current_block_->AddInstruction(length);
1320
Calin Juravle225ff812014-11-13 16:46:39 +00001321 int32_t payload_offset = instruction.VRegB_31t() + dex_pc;
Calin Juravled0d48522014-11-04 16:40:20 +00001322 const Instruction::ArrayDataPayload* payload =
1323 reinterpret_cast<const Instruction::ArrayDataPayload*>(code_start_ + payload_offset);
1324 const uint8_t* data = payload->data;
1325 uint32_t element_count = payload->element_count;
1326
1327 // Implementation of this DEX instruction seems to be that the bounds check is
1328 // done before doing any stores.
David Brazdil8d5b8b22015-03-24 10:51:52 +00001329 HInstruction* last_index = graph_->GetIntConstant(payload->element_count - 1);
Calin Juravle225ff812014-11-13 16:46:39 +00001330 current_block_->AddInstruction(new (arena_) HBoundsCheck(last_index, length, dex_pc));
Calin Juravled0d48522014-11-04 16:40:20 +00001331
1332 switch (payload->element_width) {
1333 case 1:
1334 BuildFillArrayData(null_check,
1335 reinterpret_cast<const int8_t*>(data),
1336 element_count,
1337 Primitive::kPrimByte,
Calin Juravle225ff812014-11-13 16:46:39 +00001338 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001339 break;
1340 case 2:
1341 BuildFillArrayData(null_check,
1342 reinterpret_cast<const int16_t*>(data),
1343 element_count,
1344 Primitive::kPrimShort,
Calin Juravle225ff812014-11-13 16:46:39 +00001345 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001346 break;
1347 case 4:
1348 BuildFillArrayData(null_check,
1349 reinterpret_cast<const int32_t*>(data),
1350 element_count,
1351 Primitive::kPrimInt,
Calin Juravle225ff812014-11-13 16:46:39 +00001352 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001353 break;
1354 case 8:
1355 BuildFillWideArrayData(null_check,
1356 reinterpret_cast<const int64_t*>(data),
1357 element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001358 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001359 break;
1360 default:
1361 LOG(FATAL) << "Unknown element width for " << payload->element_width;
1362 }
Mark Mendell1152c922015-04-24 17:06:35 -04001363 graph_->SetHasBoundsChecks(true);
Calin Juravled0d48522014-11-04 16:40:20 +00001364}
1365
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001366void HGraphBuilder::BuildFillWideArrayData(HInstruction* object,
Nicolas Geoffray8d6ae522014-10-23 18:32:13 +01001367 const int64_t* data,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001368 uint32_t element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001369 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001370 for (uint32_t i = 0; i < element_count; ++i) {
David Brazdil8d5b8b22015-03-24 10:51:52 +00001371 HInstruction* index = graph_->GetIntConstant(i);
1372 HInstruction* value = graph_->GetLongConstant(data[i]);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001373 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001374 object, index, value, Primitive::kPrimLong, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001375 }
1376}
1377
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001378bool HGraphBuilder::BuildTypeCheck(const Instruction& instruction,
1379 uint8_t destination,
1380 uint8_t reference,
1381 uint16_t type_index,
Calin Juravle225ff812014-11-13 16:46:39 +00001382 uint32_t dex_pc) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001383 bool type_known_final;
1384 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001385 // `CanAccessTypeWithoutChecks` will tell whether the method being
1386 // built is trying to access its own class, so that the generated
1387 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001388 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001389 bool dont_use_is_referrers_class;
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001390 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
1391 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001392 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001393 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001394 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001395 return false;
1396 }
1397 HInstruction* object = LoadLocal(reference, Primitive::kPrimNot);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001398 HLoadClass* cls = new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001399 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01001400 type_index,
1401 *dex_compilation_unit_->GetDexFile(),
1402 IsOutermostCompilingClass(type_index),
1403 dex_pc);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001404 current_block_->AddInstruction(cls);
1405 // The class needs a temporary before being used by the type check.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001406 Temporaries temps(graph_);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001407 temps.Add(cls);
1408 if (instruction.Opcode() == Instruction::INSTANCE_OF) {
1409 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001410 new (arena_) HInstanceOf(object, cls, type_known_final, dex_pc));
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001411 UpdateLocal(destination, current_block_->GetLastInstruction());
1412 } else {
1413 DCHECK_EQ(instruction.Opcode(), Instruction::CHECK_CAST);
1414 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001415 new (arena_) HCheckCast(object, cls, type_known_final, dex_pc));
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001416 }
1417 return true;
1418}
1419
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001420bool HGraphBuilder::NeedsAccessCheck(uint32_t type_index) const {
1421 return !compiler_driver_->CanAccessInstantiableTypeWithoutChecks(
1422 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index);
1423}
1424
Calin Juravle48c2b032014-12-09 18:11:36 +00001425void HGraphBuilder::BuildPackedSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001426 // Verifier guarantees that the payload for PackedSwitch contains:
1427 // (a) number of entries (may be zero)
1428 // (b) first and lowest switch case value (entry 0, always present)
1429 // (c) list of target pcs (entries 1 <= i <= N)
Andreas Gamped881df52014-11-24 23:28:39 -08001430 SwitchTable table(instruction, dex_pc, false);
1431
1432 // Value to test against.
1433 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
1434
David Brazdil2ef645b2015-06-17 18:20:52 +01001435 // Retrieve number of entries.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001436 uint16_t num_entries = table.GetNumEntries();
David Brazdil2ef645b2015-06-17 18:20:52 +01001437 if (num_entries == 0) {
1438 return;
1439 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001440
Andreas Gamped881df52014-11-24 23:28:39 -08001441 // Chained cmp-and-branch, starting from starting_key.
1442 int32_t starting_key = table.GetEntryAt(0);
1443
Andreas Gamped881df52014-11-24 23:28:39 -08001444 for (size_t i = 1; i <= num_entries; i++) {
Andreas Gampee4d4d322014-12-04 09:09:57 -08001445 BuildSwitchCaseHelper(instruction, i, i == num_entries, table, value, starting_key + i - 1,
1446 table.GetEntryAt(i), dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08001447 }
Andreas Gamped881df52014-11-24 23:28:39 -08001448}
1449
Calin Juravle48c2b032014-12-09 18:11:36 +00001450void HGraphBuilder::BuildSparseSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001451 // Verifier guarantees that the payload for SparseSwitch contains:
1452 // (a) number of entries (may be zero)
1453 // (b) sorted key values (entries 0 <= i < N)
1454 // (c) target pcs corresponding to the switch values (entries N <= i < 2*N)
Andreas Gampee4d4d322014-12-04 09:09:57 -08001455 SwitchTable table(instruction, dex_pc, true);
1456
1457 // Value to test against.
1458 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
1459
1460 uint16_t num_entries = table.GetNumEntries();
Andreas Gampee4d4d322014-12-04 09:09:57 -08001461
1462 for (size_t i = 0; i < num_entries; i++) {
1463 BuildSwitchCaseHelper(instruction, i, i == static_cast<size_t>(num_entries) - 1, table, value,
1464 table.GetEntryAt(i), table.GetEntryAt(i + num_entries), dex_pc);
1465 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001466}
1467
1468void HGraphBuilder::BuildSwitchCaseHelper(const Instruction& instruction, size_t index,
1469 bool is_last_case, const SwitchTable& table,
1470 HInstruction* value, int32_t case_value_int,
1471 int32_t target_offset, uint32_t dex_pc) {
David Brazdil852eaff2015-02-02 15:23:05 +00001472 HBasicBlock* case_target = FindBlockStartingAt(dex_pc + target_offset);
1473 DCHECK(case_target != nullptr);
1474 PotentiallyAddSuspendCheck(case_target, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001475
1476 // The current case's value.
David Brazdil8d5b8b22015-03-24 10:51:52 +00001477 HInstruction* this_case_value = graph_->GetIntConstant(case_value_int);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001478
1479 // Compare value and this_case_value.
1480 HEqual* comparison = new (arena_) HEqual(value, this_case_value);
1481 current_block_->AddInstruction(comparison);
1482 HInstruction* ifinst = new (arena_) HIf(comparison);
1483 current_block_->AddInstruction(ifinst);
1484
1485 // Case hit: use the target offset to determine where to go.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001486 current_block_->AddSuccessor(case_target);
1487
1488 // Case miss: go to the next case (or default fall-through).
1489 // When there is a next case, we use the block stored with the table offset representing this
1490 // case (that is where we registered them in ComputeBranchTargets).
1491 // When there is no next case, we use the following instruction.
1492 // TODO: Find a good way to peel the last iteration to avoid conditional, but still have re-use.
1493 if (!is_last_case) {
1494 HBasicBlock* next_case_target = FindBlockStartingAt(table.GetDexPcForIndex(index));
1495 DCHECK(next_case_target != nullptr);
1496 current_block_->AddSuccessor(next_case_target);
1497
1498 // Need to manually add the block, as there is no dex-pc transition for the cases.
1499 graph_->AddBlock(next_case_target);
1500
1501 current_block_ = next_case_target;
1502 } else {
1503 HBasicBlock* default_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
1504 DCHECK(default_target != nullptr);
1505 current_block_->AddSuccessor(default_target);
1506 current_block_ = nullptr;
1507 }
1508}
1509
David Brazdil852eaff2015-02-02 15:23:05 +00001510void HGraphBuilder::PotentiallyAddSuspendCheck(HBasicBlock* target, uint32_t dex_pc) {
1511 int32_t target_offset = target->GetDexPc() - dex_pc;
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001512 if (target_offset <= 0) {
David Brazdil852eaff2015-02-02 15:23:05 +00001513 // DX generates back edges to the first encountered return. We can save
1514 // time of later passes by not adding redundant suspend checks.
David Brazdil2fd6aa52015-02-02 18:58:27 +00001515 HInstruction* last_in_target = target->GetLastInstruction();
1516 if (last_in_target != nullptr &&
1517 (last_in_target->IsReturn() || last_in_target->IsReturnVoid())) {
1518 return;
David Brazdil852eaff2015-02-02 15:23:05 +00001519 }
1520
1521 // Add a suspend check to backward branches which may potentially loop. We
1522 // can remove them after we recognize loops in the graph.
Calin Juravle225ff812014-11-13 16:46:39 +00001523 current_block_->AddInstruction(new (arena_) HSuspendCheck(dex_pc));
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001524 }
1525}
1526
Calin Juravle225ff812014-11-13 16:46:39 +00001527bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001528 if (current_block_ == nullptr) {
1529 return true; // Dead code
1530 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001531
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001532 switch (instruction.Opcode()) {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001533 case Instruction::CONST_4: {
1534 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001535 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_11n());
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001536 UpdateLocal(register_index, constant);
1537 break;
1538 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001539
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001540 case Instruction::CONST_16: {
1541 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001542 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21s());
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001543 UpdateLocal(register_index, constant);
1544 break;
1545 }
1546
Dave Allison20dfc792014-06-16 20:44:29 -07001547 case Instruction::CONST: {
1548 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001549 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_31i());
Dave Allison20dfc792014-06-16 20:44:29 -07001550 UpdateLocal(register_index, constant);
1551 break;
1552 }
1553
1554 case Instruction::CONST_HIGH16: {
1555 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001556 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21h() << 16);
Dave Allison20dfc792014-06-16 20:44:29 -07001557 UpdateLocal(register_index, constant);
1558 break;
1559 }
1560
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001561 case Instruction::CONST_WIDE_16: {
1562 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001563 // Get 16 bits of constant value, sign extended to 64 bits.
1564 int64_t value = instruction.VRegB_21s();
1565 value <<= 48;
1566 value >>= 48;
David Brazdil8d5b8b22015-03-24 10:51:52 +00001567 HLongConstant* constant = graph_->GetLongConstant(value);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001568 UpdateLocal(register_index, constant);
1569 break;
1570 }
1571
1572 case Instruction::CONST_WIDE_32: {
1573 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001574 // Get 32 bits of constant value, sign extended to 64 bits.
1575 int64_t value = instruction.VRegB_31i();
1576 value <<= 32;
1577 value >>= 32;
David Brazdil8d5b8b22015-03-24 10:51:52 +00001578 HLongConstant* constant = graph_->GetLongConstant(value);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001579 UpdateLocal(register_index, constant);
1580 break;
1581 }
1582
1583 case Instruction::CONST_WIDE: {
1584 int32_t register_index = instruction.VRegA();
David Brazdil8d5b8b22015-03-24 10:51:52 +00001585 HLongConstant* constant = graph_->GetLongConstant(instruction.VRegB_51l());
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001586 UpdateLocal(register_index, constant);
1587 break;
1588 }
1589
Dave Allison20dfc792014-06-16 20:44:29 -07001590 case Instruction::CONST_WIDE_HIGH16: {
1591 int32_t register_index = instruction.VRegA();
1592 int64_t value = static_cast<int64_t>(instruction.VRegB_21h()) << 48;
David Brazdil8d5b8b22015-03-24 10:51:52 +00001593 HLongConstant* constant = graph_->GetLongConstant(value);
Dave Allison20dfc792014-06-16 20:44:29 -07001594 UpdateLocal(register_index, constant);
1595 break;
1596 }
1597
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001598 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001599 case Instruction::MOVE:
1600 case Instruction::MOVE_FROM16:
1601 case Instruction::MOVE_16: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001602 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001603 UpdateLocal(instruction.VRegA(), value);
1604 break;
1605 }
1606
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001607 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001608 case Instruction::MOVE_WIDE:
1609 case Instruction::MOVE_WIDE_FROM16:
1610 case Instruction::MOVE_WIDE_16: {
1611 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimLong);
1612 UpdateLocal(instruction.VRegA(), value);
1613 break;
1614 }
1615
1616 case Instruction::MOVE_OBJECT:
1617 case Instruction::MOVE_OBJECT_16:
1618 case Instruction::MOVE_OBJECT_FROM16: {
1619 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimNot);
1620 UpdateLocal(instruction.VRegA(), value);
1621 break;
1622 }
1623
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001624 case Instruction::RETURN_VOID: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001625 BuildReturn(instruction, Primitive::kPrimVoid);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001626 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001627 }
1628
Dave Allison20dfc792014-06-16 20:44:29 -07001629#define IF_XX(comparison, cond) \
Calin Juravle225ff812014-11-13 16:46:39 +00001630 case Instruction::IF_##cond: If_22t<comparison>(instruction, dex_pc); break; \
1631 case Instruction::IF_##cond##Z: If_21t<comparison>(instruction, dex_pc); break
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001632
Dave Allison20dfc792014-06-16 20:44:29 -07001633 IF_XX(HEqual, EQ);
1634 IF_XX(HNotEqual, NE);
1635 IF_XX(HLessThan, LT);
1636 IF_XX(HLessThanOrEqual, LE);
1637 IF_XX(HGreaterThan, GT);
1638 IF_XX(HGreaterThanOrEqual, GE);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001639
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001640 case Instruction::GOTO:
1641 case Instruction::GOTO_16:
1642 case Instruction::GOTO_32: {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001643 int32_t offset = instruction.GetTargetOffset();
Calin Juravle225ff812014-11-13 16:46:39 +00001644 HBasicBlock* target = FindBlockStartingAt(offset + dex_pc);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001645 DCHECK(target != nullptr);
David Brazdil852eaff2015-02-02 15:23:05 +00001646 PotentiallyAddSuspendCheck(target, dex_pc);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001647 current_block_->AddInstruction(new (arena_) HGoto());
1648 current_block_->AddSuccessor(target);
1649 current_block_ = nullptr;
1650 break;
1651 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001652
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001653 case Instruction::RETURN: {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001654 BuildReturn(instruction, return_type_);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001655 break;
1656 }
1657
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001658 case Instruction::RETURN_OBJECT: {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001659 BuildReturn(instruction, return_type_);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001660 break;
1661 }
1662
1663 case Instruction::RETURN_WIDE: {
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001664 BuildReturn(instruction, return_type_);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001665 break;
1666 }
1667
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001668 case Instruction::INVOKE_DIRECT:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001669 case Instruction::INVOKE_INTERFACE:
1670 case Instruction::INVOKE_STATIC:
1671 case Instruction::INVOKE_SUPER:
1672 case Instruction::INVOKE_VIRTUAL: {
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +00001673 uint32_t method_idx = instruction.VRegB_35c();
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001674 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001675 uint32_t args[5];
Ian Rogers29a26482014-05-02 15:27:29 -07001676 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00001677 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001678 number_of_vreg_arguments, false, args, -1)) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001679 return false;
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001680 }
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001681 break;
1682 }
1683
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001684 case Instruction::INVOKE_DIRECT_RANGE:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001685 case Instruction::INVOKE_INTERFACE_RANGE:
1686 case Instruction::INVOKE_STATIC_RANGE:
1687 case Instruction::INVOKE_SUPER_RANGE:
1688 case Instruction::INVOKE_VIRTUAL_RANGE: {
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001689 uint32_t method_idx = instruction.VRegB_3rc();
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001690 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
1691 uint32_t register_index = instruction.VRegC();
Calin Juravle225ff812014-11-13 16:46:39 +00001692 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001693 number_of_vreg_arguments, true, nullptr, register_index)) {
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001694 return false;
1695 }
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +00001696 break;
1697 }
1698
Roland Levillain88cb1752014-10-20 16:36:47 +01001699 case Instruction::NEG_INT: {
1700 Unop_12x<HNeg>(instruction, Primitive::kPrimInt);
1701 break;
1702 }
1703
Roland Levillain2e07b4f2014-10-23 18:12:09 +01001704 case Instruction::NEG_LONG: {
1705 Unop_12x<HNeg>(instruction, Primitive::kPrimLong);
1706 break;
1707 }
1708
Roland Levillain3dbcb382014-10-28 17:30:07 +00001709 case Instruction::NEG_FLOAT: {
1710 Unop_12x<HNeg>(instruction, Primitive::kPrimFloat);
1711 break;
1712 }
1713
1714 case Instruction::NEG_DOUBLE: {
1715 Unop_12x<HNeg>(instruction, Primitive::kPrimDouble);
1716 break;
1717 }
1718
Roland Levillain1cc5f2512014-10-22 18:06:21 +01001719 case Instruction::NOT_INT: {
1720 Unop_12x<HNot>(instruction, Primitive::kPrimInt);
1721 break;
1722 }
1723
Roland Levillain70566432014-10-24 16:20:17 +01001724 case Instruction::NOT_LONG: {
1725 Unop_12x<HNot>(instruction, Primitive::kPrimLong);
1726 break;
1727 }
1728
Roland Levillaindff1f282014-11-05 14:15:05 +00001729 case Instruction::INT_TO_LONG: {
Roland Levillain624279f2014-12-04 11:54:28 +00001730 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimLong, dex_pc);
Roland Levillaindff1f282014-11-05 14:15:05 +00001731 break;
1732 }
1733
Roland Levillaincff13742014-11-17 14:32:17 +00001734 case Instruction::INT_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001735 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimFloat, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00001736 break;
1737 }
1738
1739 case Instruction::INT_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00001740 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimDouble, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00001741 break;
1742 }
1743
Roland Levillain946e1432014-11-11 17:35:19 +00001744 case Instruction::LONG_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001745 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimInt, dex_pc);
Roland Levillain946e1432014-11-11 17:35:19 +00001746 break;
1747 }
1748
Roland Levillain6d0e4832014-11-27 18:31:21 +00001749 case Instruction::LONG_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001750 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimFloat, dex_pc);
Roland Levillain6d0e4832014-11-27 18:31:21 +00001751 break;
1752 }
1753
Roland Levillain647b9ed2014-11-27 12:06:00 +00001754 case Instruction::LONG_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00001755 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimDouble, dex_pc);
Roland Levillain647b9ed2014-11-27 12:06:00 +00001756 break;
1757 }
1758
Roland Levillain3f8f9362014-12-02 17:45:01 +00001759 case Instruction::FLOAT_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001760 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimInt, dex_pc);
1761 break;
1762 }
1763
1764 case Instruction::FLOAT_TO_LONG: {
1765 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimLong, dex_pc);
Roland Levillain3f8f9362014-12-02 17:45:01 +00001766 break;
1767 }
1768
Roland Levillain8964e2b2014-12-04 12:10:50 +00001769 case Instruction::FLOAT_TO_DOUBLE: {
1770 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimDouble, dex_pc);
1771 break;
1772 }
1773
Roland Levillain4c0b61f2014-12-05 12:06:01 +00001774 case Instruction::DOUBLE_TO_INT: {
1775 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimInt, dex_pc);
1776 break;
1777 }
1778
1779 case Instruction::DOUBLE_TO_LONG: {
1780 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimLong, dex_pc);
1781 break;
1782 }
1783
Roland Levillain8964e2b2014-12-04 12:10:50 +00001784 case Instruction::DOUBLE_TO_FLOAT: {
1785 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimFloat, dex_pc);
1786 break;
1787 }
1788
Roland Levillain51d3fc42014-11-13 14:11:42 +00001789 case Instruction::INT_TO_BYTE: {
Roland Levillain624279f2014-12-04 11:54:28 +00001790 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimByte, dex_pc);
Roland Levillain51d3fc42014-11-13 14:11:42 +00001791 break;
1792 }
1793
Roland Levillain01a8d712014-11-14 16:27:39 +00001794 case Instruction::INT_TO_SHORT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001795 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimShort, dex_pc);
Roland Levillain01a8d712014-11-14 16:27:39 +00001796 break;
1797 }
1798
Roland Levillain981e4542014-11-14 11:47:14 +00001799 case Instruction::INT_TO_CHAR: {
Roland Levillain624279f2014-12-04 11:54:28 +00001800 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimChar, dex_pc);
Roland Levillain981e4542014-11-14 11:47:14 +00001801 break;
1802 }
1803
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001804 case Instruction::ADD_INT: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001805 Binop_23x<HAdd>(instruction, Primitive::kPrimInt);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001806 break;
1807 }
1808
1809 case Instruction::ADD_LONG: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001810 Binop_23x<HAdd>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001811 break;
1812 }
1813
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001814 case Instruction::ADD_DOUBLE: {
1815 Binop_23x<HAdd>(instruction, Primitive::kPrimDouble);
1816 break;
1817 }
1818
1819 case Instruction::ADD_FLOAT: {
1820 Binop_23x<HAdd>(instruction, Primitive::kPrimFloat);
1821 break;
1822 }
1823
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001824 case Instruction::SUB_INT: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001825 Binop_23x<HSub>(instruction, Primitive::kPrimInt);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001826 break;
1827 }
1828
1829 case Instruction::SUB_LONG: {
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01001830 Binop_23x<HSub>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001831 break;
1832 }
1833
Calin Juravle096cc022014-10-23 17:01:13 +01001834 case Instruction::SUB_FLOAT: {
1835 Binop_23x<HSub>(instruction, Primitive::kPrimFloat);
1836 break;
1837 }
1838
1839 case Instruction::SUB_DOUBLE: {
1840 Binop_23x<HSub>(instruction, Primitive::kPrimDouble);
1841 break;
1842 }
1843
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001844 case Instruction::ADD_INT_2ADDR: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001845 Binop_12x<HAdd>(instruction, Primitive::kPrimInt);
1846 break;
1847 }
1848
Calin Juravle34bacdf2014-10-07 20:23:36 +01001849 case Instruction::MUL_INT: {
1850 Binop_23x<HMul>(instruction, Primitive::kPrimInt);
1851 break;
1852 }
1853
1854 case Instruction::MUL_LONG: {
1855 Binop_23x<HMul>(instruction, Primitive::kPrimLong);
1856 break;
1857 }
1858
Calin Juravleb5bfa962014-10-21 18:02:24 +01001859 case Instruction::MUL_FLOAT: {
1860 Binop_23x<HMul>(instruction, Primitive::kPrimFloat);
1861 break;
1862 }
1863
1864 case Instruction::MUL_DOUBLE: {
1865 Binop_23x<HMul>(instruction, Primitive::kPrimDouble);
1866 break;
1867 }
1868
Calin Juravled0d48522014-11-04 16:40:20 +00001869 case Instruction::DIV_INT: {
Calin Juravlebacfec32014-11-14 15:54:36 +00001870 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1871 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravled0d48522014-11-04 16:40:20 +00001872 break;
1873 }
1874
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001875 case Instruction::DIV_LONG: {
Calin Juravlebacfec32014-11-14 15:54:36 +00001876 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1877 dex_pc, Primitive::kPrimLong, false, true);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001878 break;
1879 }
1880
Calin Juravle7c4954d2014-10-28 16:57:40 +00001881 case Instruction::DIV_FLOAT: {
Calin Juravle225ff812014-11-13 16:46:39 +00001882 Binop_23x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00001883 break;
1884 }
1885
1886 case Instruction::DIV_DOUBLE: {
Calin Juravle225ff812014-11-13 16:46:39 +00001887 Binop_23x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00001888 break;
1889 }
1890
Calin Juravlebacfec32014-11-14 15:54:36 +00001891 case Instruction::REM_INT: {
1892 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1893 dex_pc, Primitive::kPrimInt, false, false);
1894 break;
1895 }
1896
1897 case Instruction::REM_LONG: {
1898 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
1899 dex_pc, Primitive::kPrimLong, false, false);
1900 break;
1901 }
1902
Calin Juravled2ec87d2014-12-08 14:24:46 +00001903 case Instruction::REM_FLOAT: {
1904 Binop_23x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
1905 break;
1906 }
1907
1908 case Instruction::REM_DOUBLE: {
1909 Binop_23x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
1910 break;
1911 }
1912
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001913 case Instruction::AND_INT: {
1914 Binop_23x<HAnd>(instruction, Primitive::kPrimInt);
1915 break;
1916 }
1917
1918 case Instruction::AND_LONG: {
1919 Binop_23x<HAnd>(instruction, Primitive::kPrimLong);
1920 break;
1921 }
1922
Calin Juravle9aec02f2014-11-18 23:06:35 +00001923 case Instruction::SHL_INT: {
1924 Binop_23x_shift<HShl>(instruction, Primitive::kPrimInt);
1925 break;
1926 }
1927
1928 case Instruction::SHL_LONG: {
1929 Binop_23x_shift<HShl>(instruction, Primitive::kPrimLong);
1930 break;
1931 }
1932
1933 case Instruction::SHR_INT: {
1934 Binop_23x_shift<HShr>(instruction, Primitive::kPrimInt);
1935 break;
1936 }
1937
1938 case Instruction::SHR_LONG: {
1939 Binop_23x_shift<HShr>(instruction, Primitive::kPrimLong);
1940 break;
1941 }
1942
1943 case Instruction::USHR_INT: {
1944 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimInt);
1945 break;
1946 }
1947
1948 case Instruction::USHR_LONG: {
1949 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimLong);
1950 break;
1951 }
1952
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00001953 case Instruction::OR_INT: {
1954 Binop_23x<HOr>(instruction, Primitive::kPrimInt);
1955 break;
1956 }
1957
1958 case Instruction::OR_LONG: {
1959 Binop_23x<HOr>(instruction, Primitive::kPrimLong);
1960 break;
1961 }
1962
1963 case Instruction::XOR_INT: {
1964 Binop_23x<HXor>(instruction, Primitive::kPrimInt);
1965 break;
1966 }
1967
1968 case Instruction::XOR_LONG: {
1969 Binop_23x<HXor>(instruction, Primitive::kPrimLong);
1970 break;
1971 }
1972
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001973 case Instruction::ADD_LONG_2ADDR: {
1974 Binop_12x<HAdd>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001975 break;
1976 }
1977
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001978 case Instruction::ADD_DOUBLE_2ADDR: {
1979 Binop_12x<HAdd>(instruction, Primitive::kPrimDouble);
1980 break;
1981 }
1982
1983 case Instruction::ADD_FLOAT_2ADDR: {
1984 Binop_12x<HAdd>(instruction, Primitive::kPrimFloat);
1985 break;
1986 }
1987
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001988 case Instruction::SUB_INT_2ADDR: {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001989 Binop_12x<HSub>(instruction, Primitive::kPrimInt);
1990 break;
1991 }
1992
1993 case Instruction::SUB_LONG_2ADDR: {
1994 Binop_12x<HSub>(instruction, Primitive::kPrimLong);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00001995 break;
1996 }
1997
Calin Juravle096cc022014-10-23 17:01:13 +01001998 case Instruction::SUB_FLOAT_2ADDR: {
1999 Binop_12x<HSub>(instruction, Primitive::kPrimFloat);
2000 break;
2001 }
2002
2003 case Instruction::SUB_DOUBLE_2ADDR: {
2004 Binop_12x<HSub>(instruction, Primitive::kPrimDouble);
2005 break;
2006 }
2007
Calin Juravle34bacdf2014-10-07 20:23:36 +01002008 case Instruction::MUL_INT_2ADDR: {
2009 Binop_12x<HMul>(instruction, Primitive::kPrimInt);
2010 break;
2011 }
2012
2013 case Instruction::MUL_LONG_2ADDR: {
2014 Binop_12x<HMul>(instruction, Primitive::kPrimLong);
2015 break;
2016 }
2017
Calin Juravleb5bfa962014-10-21 18:02:24 +01002018 case Instruction::MUL_FLOAT_2ADDR: {
2019 Binop_12x<HMul>(instruction, Primitive::kPrimFloat);
2020 break;
2021 }
2022
2023 case Instruction::MUL_DOUBLE_2ADDR: {
2024 Binop_12x<HMul>(instruction, Primitive::kPrimDouble);
2025 break;
2026 }
2027
Calin Juravle865fc882014-11-06 17:09:03 +00002028 case Instruction::DIV_INT_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002029 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2030 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravle865fc882014-11-06 17:09:03 +00002031 break;
2032 }
2033
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002034 case Instruction::DIV_LONG_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002035 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2036 dex_pc, Primitive::kPrimLong, false, true);
2037 break;
2038 }
2039
2040 case Instruction::REM_INT_2ADDR: {
2041 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2042 dex_pc, Primitive::kPrimInt, false, false);
2043 break;
2044 }
2045
2046 case Instruction::REM_LONG_2ADDR: {
2047 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2048 dex_pc, Primitive::kPrimLong, false, false);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002049 break;
2050 }
2051
Calin Juravled2ec87d2014-12-08 14:24:46 +00002052 case Instruction::REM_FLOAT_2ADDR: {
2053 Binop_12x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2054 break;
2055 }
2056
2057 case Instruction::REM_DOUBLE_2ADDR: {
2058 Binop_12x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2059 break;
2060 }
2061
Calin Juravle9aec02f2014-11-18 23:06:35 +00002062 case Instruction::SHL_INT_2ADDR: {
2063 Binop_12x_shift<HShl>(instruction, Primitive::kPrimInt);
2064 break;
2065 }
2066
2067 case Instruction::SHL_LONG_2ADDR: {
2068 Binop_12x_shift<HShl>(instruction, Primitive::kPrimLong);
2069 break;
2070 }
2071
2072 case Instruction::SHR_INT_2ADDR: {
2073 Binop_12x_shift<HShr>(instruction, Primitive::kPrimInt);
2074 break;
2075 }
2076
2077 case Instruction::SHR_LONG_2ADDR: {
2078 Binop_12x_shift<HShr>(instruction, Primitive::kPrimLong);
2079 break;
2080 }
2081
2082 case Instruction::USHR_INT_2ADDR: {
2083 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimInt);
2084 break;
2085 }
2086
2087 case Instruction::USHR_LONG_2ADDR: {
2088 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimLong);
2089 break;
2090 }
2091
Calin Juravle7c4954d2014-10-28 16:57:40 +00002092 case Instruction::DIV_FLOAT_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00002093 Binop_12x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002094 break;
2095 }
2096
2097 case Instruction::DIV_DOUBLE_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00002098 Binop_12x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002099 break;
2100 }
2101
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002102 case Instruction::AND_INT_2ADDR: {
2103 Binop_12x<HAnd>(instruction, Primitive::kPrimInt);
2104 break;
2105 }
2106
2107 case Instruction::AND_LONG_2ADDR: {
2108 Binop_12x<HAnd>(instruction, Primitive::kPrimLong);
2109 break;
2110 }
2111
2112 case Instruction::OR_INT_2ADDR: {
2113 Binop_12x<HOr>(instruction, Primitive::kPrimInt);
2114 break;
2115 }
2116
2117 case Instruction::OR_LONG_2ADDR: {
2118 Binop_12x<HOr>(instruction, Primitive::kPrimLong);
2119 break;
2120 }
2121
2122 case Instruction::XOR_INT_2ADDR: {
2123 Binop_12x<HXor>(instruction, Primitive::kPrimInt);
2124 break;
2125 }
2126
2127 case Instruction::XOR_LONG_2ADDR: {
2128 Binop_12x<HXor>(instruction, Primitive::kPrimLong);
2129 break;
2130 }
2131
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002132 case Instruction::ADD_INT_LIT16: {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002133 Binop_22s<HAdd>(instruction, false);
2134 break;
2135 }
2136
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002137 case Instruction::AND_INT_LIT16: {
2138 Binop_22s<HAnd>(instruction, false);
2139 break;
2140 }
2141
2142 case Instruction::OR_INT_LIT16: {
2143 Binop_22s<HOr>(instruction, false);
2144 break;
2145 }
2146
2147 case Instruction::XOR_INT_LIT16: {
2148 Binop_22s<HXor>(instruction, false);
2149 break;
2150 }
2151
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002152 case Instruction::RSUB_INT: {
2153 Binop_22s<HSub>(instruction, true);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002154 break;
2155 }
2156
Calin Juravle34bacdf2014-10-07 20:23:36 +01002157 case Instruction::MUL_INT_LIT16: {
2158 Binop_22s<HMul>(instruction, false);
2159 break;
2160 }
2161
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002162 case Instruction::ADD_INT_LIT8: {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002163 Binop_22b<HAdd>(instruction, false);
2164 break;
2165 }
2166
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002167 case Instruction::AND_INT_LIT8: {
2168 Binop_22b<HAnd>(instruction, false);
2169 break;
2170 }
2171
2172 case Instruction::OR_INT_LIT8: {
2173 Binop_22b<HOr>(instruction, false);
2174 break;
2175 }
2176
2177 case Instruction::XOR_INT_LIT8: {
2178 Binop_22b<HXor>(instruction, false);
2179 break;
2180 }
2181
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002182 case Instruction::RSUB_INT_LIT8: {
2183 Binop_22b<HSub>(instruction, true);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002184 break;
2185 }
2186
Calin Juravle34bacdf2014-10-07 20:23:36 +01002187 case Instruction::MUL_INT_LIT8: {
2188 Binop_22b<HMul>(instruction, false);
2189 break;
2190 }
2191
Calin Juravled0d48522014-11-04 16:40:20 +00002192 case Instruction::DIV_INT_LIT16:
2193 case Instruction::DIV_INT_LIT8: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002194 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2195 dex_pc, Primitive::kPrimInt, true, true);
2196 break;
2197 }
2198
2199 case Instruction::REM_INT_LIT16:
2200 case Instruction::REM_INT_LIT8: {
2201 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2202 dex_pc, Primitive::kPrimInt, true, false);
Calin Juravled0d48522014-11-04 16:40:20 +00002203 break;
2204 }
2205
Calin Juravle9aec02f2014-11-18 23:06:35 +00002206 case Instruction::SHL_INT_LIT8: {
2207 Binop_22b<HShl>(instruction, false);
2208 break;
2209 }
2210
2211 case Instruction::SHR_INT_LIT8: {
2212 Binop_22b<HShr>(instruction, false);
2213 break;
2214 }
2215
2216 case Instruction::USHR_INT_LIT8: {
2217 Binop_22b<HUShr>(instruction, false);
2218 break;
2219 }
2220
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002221 case Instruction::NEW_INSTANCE: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002222 uint16_t type_index = instruction.VRegB_21c();
Jeff Hao848f70a2014-01-15 13:49:50 -08002223 if (compiler_driver_->IsStringTypeIndex(type_index, dex_file_)) {
2224 // Turn new-instance of string into a const 0.
2225 int32_t register_index = instruction.VRegA();
2226 HNullConstant* constant = graph_->GetNullConstant();
2227 UpdateLocal(register_index, constant);
2228 } else {
2229 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2230 ? kQuickAllocObjectWithAccessCheck
2231 : kQuickAllocObject;
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002232
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002233 current_block_->AddInstruction(new (arena_) HNewInstance(
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002234 graph_->GetCurrentMethod(),
2235 dex_pc,
2236 type_index,
2237 *dex_compilation_unit_->GetDexFile(),
2238 entrypoint));
Jeff Hao848f70a2014-01-15 13:49:50 -08002239 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
2240 }
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002241 break;
2242 }
2243
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002244 case Instruction::NEW_ARRAY: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002245 uint16_t type_index = instruction.VRegC_22c();
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002246 HInstruction* length = LoadLocal(instruction.VRegB_22c(), Primitive::kPrimInt);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002247 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2248 ? kQuickAllocArrayWithAccessCheck
2249 : kQuickAllocArray;
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002250 current_block_->AddInstruction(new (arena_) HNewArray(length,
2251 graph_->GetCurrentMethod(),
2252 dex_pc,
2253 type_index,
2254 *dex_compilation_unit_->GetDexFile(),
2255 entrypoint));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002256 UpdateLocal(instruction.VRegA_22c(), current_block_->GetLastInstruction());
2257 break;
2258 }
2259
2260 case Instruction::FILLED_NEW_ARRAY: {
2261 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
2262 uint32_t type_index = instruction.VRegB_35c();
2263 uint32_t args[5];
2264 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00002265 BuildFilledNewArray(dex_pc, type_index, number_of_vreg_arguments, false, args, 0);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002266 break;
2267 }
2268
2269 case Instruction::FILLED_NEW_ARRAY_RANGE: {
2270 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
2271 uint32_t type_index = instruction.VRegB_3rc();
2272 uint32_t register_index = instruction.VRegC_3rc();
2273 BuildFilledNewArray(
Calin Juravle225ff812014-11-13 16:46:39 +00002274 dex_pc, type_index, number_of_vreg_arguments, true, nullptr, register_index);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002275 break;
2276 }
2277
2278 case Instruction::FILL_ARRAY_DATA: {
Calin Juravle225ff812014-11-13 16:46:39 +00002279 BuildFillArrayData(instruction, dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002280 break;
2281 }
2282
Nicolas Geoffrayddb311f2014-05-16 09:28:54 +01002283 case Instruction::MOVE_RESULT:
Dave Allison20dfc792014-06-16 20:44:29 -07002284 case Instruction::MOVE_RESULT_WIDE:
David Brazdilfc6a86a2015-06-26 10:33:45 +00002285 case Instruction::MOVE_RESULT_OBJECT: {
Nicolas Geoffray1efcc222015-06-24 12:41:20 +01002286 if (latest_result_ == nullptr) {
2287 // Only dead code can lead to this situation, where the verifier
2288 // does not reject the method.
2289 } else {
David Brazdilfc6a86a2015-06-26 10:33:45 +00002290 // An Invoke/FilledNewArray and its MoveResult could have landed in
2291 // different blocks if there was a try/catch block boundary between
2292 // them. For Invoke, we insert a StoreLocal after the instruction. For
2293 // FilledNewArray, the local needs to be updated after the array was
2294 // filled, otherwise we might overwrite an input vreg.
2295 HStoreLocal* update_local =
2296 new (arena_) HStoreLocal(GetLocalAt(instruction.VRegA()), latest_result_);
2297 HBasicBlock* block = latest_result_->GetBlock();
2298 if (block == current_block_) {
2299 // MoveResult and the previous instruction are in the same block.
2300 current_block_->AddInstruction(update_local);
2301 } else {
2302 // The two instructions are in different blocks. Insert the MoveResult
2303 // before the final control-flow instruction of the previous block.
2304 DCHECK(block->EndsWithControlFlowInstruction());
2305 DCHECK(current_block_->GetInstructions().IsEmpty());
2306 block->InsertInstructionBefore(update_local, block->GetLastInstruction());
2307 }
Nicolas Geoffray1efcc222015-06-24 12:41:20 +01002308 latest_result_ = nullptr;
2309 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002310 break;
David Brazdilfc6a86a2015-06-26 10:33:45 +00002311 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002312
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002313 case Instruction::CMP_LONG: {
Alexey Frunze4dda3372015-06-01 18:31:49 -07002314 Binop_23x_cmp(instruction, Primitive::kPrimLong, HCompare::kNoBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002315 break;
2316 }
2317
2318 case Instruction::CMPG_FLOAT: {
Alexey Frunze4dda3372015-06-01 18:31:49 -07002319 Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kGtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002320 break;
2321 }
2322
2323 case Instruction::CMPG_DOUBLE: {
Alexey Frunze4dda3372015-06-01 18:31:49 -07002324 Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kGtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002325 break;
2326 }
2327
2328 case Instruction::CMPL_FLOAT: {
Alexey Frunze4dda3372015-06-01 18:31:49 -07002329 Binop_23x_cmp(instruction, Primitive::kPrimFloat, HCompare::kLtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002330 break;
2331 }
2332
2333 case Instruction::CMPL_DOUBLE: {
Alexey Frunze4dda3372015-06-01 18:31:49 -07002334 Binop_23x_cmp(instruction, Primitive::kPrimDouble, HCompare::kLtBias, dex_pc);
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002335 break;
2336 }
2337
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00002338 case Instruction::NOP:
2339 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00002340
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002341 case Instruction::IGET:
2342 case Instruction::IGET_WIDE:
2343 case Instruction::IGET_OBJECT:
2344 case Instruction::IGET_BOOLEAN:
2345 case Instruction::IGET_BYTE:
2346 case Instruction::IGET_CHAR:
2347 case Instruction::IGET_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002348 if (!BuildInstanceFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002349 return false;
2350 }
2351 break;
2352 }
2353
2354 case Instruction::IPUT:
2355 case Instruction::IPUT_WIDE:
2356 case Instruction::IPUT_OBJECT:
2357 case Instruction::IPUT_BOOLEAN:
2358 case Instruction::IPUT_BYTE:
2359 case Instruction::IPUT_CHAR:
2360 case Instruction::IPUT_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002361 if (!BuildInstanceFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002362 return false;
2363 }
2364 break;
2365 }
2366
2367 case Instruction::SGET:
2368 case Instruction::SGET_WIDE:
2369 case Instruction::SGET_OBJECT:
2370 case Instruction::SGET_BOOLEAN:
2371 case Instruction::SGET_BYTE:
2372 case Instruction::SGET_CHAR:
2373 case Instruction::SGET_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002374 if (!BuildStaticFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002375 return false;
2376 }
2377 break;
2378 }
2379
2380 case Instruction::SPUT:
2381 case Instruction::SPUT_WIDE:
2382 case Instruction::SPUT_OBJECT:
2383 case Instruction::SPUT_BOOLEAN:
2384 case Instruction::SPUT_BYTE:
2385 case Instruction::SPUT_CHAR:
2386 case Instruction::SPUT_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002387 if (!BuildStaticFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002388 return false;
2389 }
2390 break;
2391 }
2392
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002393#define ARRAY_XX(kind, anticipated_type) \
2394 case Instruction::AGET##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002395 BuildArrayAccess(instruction, dex_pc, false, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002396 break; \
2397 } \
2398 case Instruction::APUT##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002399 BuildArrayAccess(instruction, dex_pc, true, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002400 break; \
2401 }
2402
2403 ARRAY_XX(, Primitive::kPrimInt);
2404 ARRAY_XX(_WIDE, Primitive::kPrimLong);
2405 ARRAY_XX(_OBJECT, Primitive::kPrimNot);
2406 ARRAY_XX(_BOOLEAN, Primitive::kPrimBoolean);
2407 ARRAY_XX(_BYTE, Primitive::kPrimByte);
2408 ARRAY_XX(_CHAR, Primitive::kPrimChar);
2409 ARRAY_XX(_SHORT, Primitive::kPrimShort);
2410
Nicolas Geoffray39468442014-09-02 15:17:15 +01002411 case Instruction::ARRAY_LENGTH: {
2412 HInstruction* object = LoadLocal(instruction.VRegB_12x(), Primitive::kPrimNot);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002413 // No need for a temporary for the null check, it is the only input of the following
2414 // instruction.
Calin Juravle225ff812014-11-13 16:46:39 +00002415 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002416 current_block_->AddInstruction(object);
Nicolas Geoffray39468442014-09-02 15:17:15 +01002417 current_block_->AddInstruction(new (arena_) HArrayLength(object));
2418 UpdateLocal(instruction.VRegA_12x(), current_block_->GetLastInstruction());
2419 break;
2420 }
2421
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002422 case Instruction::CONST_STRING: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002423 current_block_->AddInstruction(
2424 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_21c(), dex_pc));
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002425 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction());
2426 break;
2427 }
2428
2429 case Instruction::CONST_STRING_JUMBO: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002430 current_block_->AddInstruction(
2431 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_31c(), dex_pc));
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002432 UpdateLocal(instruction.VRegA_31c(), current_block_->GetLastInstruction());
2433 break;
2434 }
2435
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002436 case Instruction::CONST_CLASS: {
2437 uint16_t type_index = instruction.VRegB_21c();
2438 bool type_known_final;
2439 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002440 bool dont_use_is_referrers_class;
2441 // `CanAccessTypeWithoutChecks` will tell whether the method being
2442 // built is trying to access its own class, so that the generated
2443 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002444 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002445 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
2446 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002447 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002448 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00002449 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002450 return false;
2451 }
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002452 current_block_->AddInstruction(new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01002453 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002454 type_index,
2455 *dex_compilation_unit_->GetDexFile(),
2456 IsOutermostCompilingClass(type_index),
2457 dex_pc));
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002458 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction());
2459 break;
2460 }
2461
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002462 case Instruction::MOVE_EXCEPTION: {
2463 current_block_->AddInstruction(new (arena_) HLoadException());
2464 UpdateLocal(instruction.VRegA_11x(), current_block_->GetLastInstruction());
2465 break;
2466 }
2467
2468 case Instruction::THROW: {
2469 HInstruction* exception = LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot);
Calin Juravle225ff812014-11-13 16:46:39 +00002470 current_block_->AddInstruction(new (arena_) HThrow(exception, dex_pc));
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002471 // A throw instruction must branch to the exit block.
2472 current_block_->AddSuccessor(exit_block_);
2473 // We finished building this block. Set the current block to null to avoid
2474 // adding dead instructions to it.
2475 current_block_ = nullptr;
2476 break;
2477 }
2478
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002479 case Instruction::INSTANCE_OF: {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002480 uint8_t destination = instruction.VRegA_22c();
2481 uint8_t reference = instruction.VRegB_22c();
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002482 uint16_t type_index = instruction.VRegC_22c();
Calin Juravle225ff812014-11-13 16:46:39 +00002483 if (!BuildTypeCheck(instruction, destination, reference, type_index, dex_pc)) {
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002484 return false;
2485 }
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002486 break;
2487 }
2488
2489 case Instruction::CHECK_CAST: {
2490 uint8_t reference = instruction.VRegA_21c();
2491 uint16_t type_index = instruction.VRegB_21c();
Calin Juravle225ff812014-11-13 16:46:39 +00002492 if (!BuildTypeCheck(instruction, -1, reference, type_index, dex_pc)) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002493 return false;
2494 }
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002495 break;
2496 }
2497
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002498 case Instruction::MONITOR_ENTER: {
2499 current_block_->AddInstruction(new (arena_) HMonitorOperation(
2500 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot),
2501 HMonitorOperation::kEnter,
Calin Juravle225ff812014-11-13 16:46:39 +00002502 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002503 break;
2504 }
2505
2506 case Instruction::MONITOR_EXIT: {
2507 current_block_->AddInstruction(new (arena_) HMonitorOperation(
2508 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot),
2509 HMonitorOperation::kExit,
Calin Juravle225ff812014-11-13 16:46:39 +00002510 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002511 break;
2512 }
2513
Andreas Gamped881df52014-11-24 23:28:39 -08002514 case Instruction::PACKED_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002515 BuildPackedSwitch(instruction, dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08002516 break;
2517 }
2518
Andreas Gampee4d4d322014-12-04 09:09:57 -08002519 case Instruction::SPARSE_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002520 BuildSparseSwitch(instruction, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08002521 break;
2522 }
2523
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002524 default:
Calin Juravle48c2b032014-12-09 18:11:36 +00002525 VLOG(compiler) << "Did not compile "
2526 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
2527 << " because of unhandled instruction "
2528 << instruction.Name();
2529 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnhandledInstruction);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002530 return false;
2531 }
2532 return true;
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00002533} // NOLINT(readability/fn_size)
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002534
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002535HLocal* HGraphBuilder::GetLocalAt(int register_index) const {
2536 return locals_.Get(register_index);
2537}
2538
2539void HGraphBuilder::UpdateLocal(int register_index, HInstruction* instruction) const {
2540 HLocal* local = GetLocalAt(register_index);
2541 current_block_->AddInstruction(new (arena_) HStoreLocal(local, instruction));
2542}
2543
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002544HInstruction* HGraphBuilder::LoadLocal(int register_index, Primitive::Type type) const {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002545 HLocal* local = GetLocalAt(register_index);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002546 current_block_->AddInstruction(new (arena_) HLoadLocal(local, type));
Nicolas Geoffray787c3072014-03-17 10:20:19 +00002547 return current_block_->GetLastInstruction();
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002548}
2549
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002550} // namespace art