blob: 7b807d56b7c5fea216c09ed38bfe748b58530df9 [file] [log] [blame]
Colin Cross1f7f3bd2016-07-27 10:12:38 -07001bootstrap_go_package {
2 name: "soong-art",
3 pkgPath: "android/soong/art",
4 deps: [
5 "blueprint",
6 "blueprint-pathtools",
Colin Cross84b69332017-11-01 14:23:17 -07007 "blueprint-proptools",
Colin Cross1f7f3bd2016-07-27 10:12:38 -07008 "soong",
9 "soong-android",
Alex Lightda948ce2018-12-06 17:05:41 +000010 "soong-apex",
Colin Cross1f7f3bd2016-07-27 10:12:38 -070011 "soong-cc",
12 ],
13 srcs: [
14 "art.go",
15 "codegen.go",
16 "makevars.go",
17 ],
18 pluginFor: ["soong_build"],
19}
20
Andreas Gampe896583e2018-06-15 13:31:58 -070021art_clang_tidy_errors = [
Andreas Gampedfcd82c2018-10-16 20:22:37 -070022 "android-cloexec-dup",
23 "android-cloexec-open",
Andreas Gampe6cd83902018-10-03 20:03:03 -070024 "bugprone-argument-comment",
Andreas Gampe322c0892018-09-18 13:50:29 -070025 "bugprone-lambda-function-name",
26 "bugprone-unused-raii", // Protect scoped things like MutexLock.
Andreas Gampeafaf7f82018-10-16 11:32:38 -070027 "bugprone-unused-return-value",
Andreas Gampe322c0892018-09-18 13:50:29 -070028 "bugprone-virtual-near-miss",
Andreas Gampe8351aac2018-09-10 12:37:49 -070029 "modernize-use-bool-literals",
Andreas Gampe322c0892018-09-18 13:50:29 -070030 "modernize-use-nullptr",
Andreas Gampec55bb392018-09-21 00:02:02 +000031 "modernize-use-using",
Andreas Gampe322c0892018-09-18 13:50:29 -070032 "performance-faster-string-find",
Andreas Gampe6f4cf6e2018-06-19 17:10:48 -070033 "performance-for-range-copy",
Andreas Gampe322c0892018-09-18 13:50:29 -070034 "performance-implicit-conversion-in-loop",
Andreas Gampe44b31742018-10-01 19:30:57 -070035 "performance-noexcept-move-constructor",
Andreas Gampe6f4cf6e2018-06-19 17:10:48 -070036 "performance-unnecessary-copy-initialization",
37 "performance-unnecessary-value-param",
Andreas Gampebd39d142018-07-19 11:14:42 -070038 "misc-unused-using-decls",
Andreas Gampe896583e2018-06-15 13:31:58 -070039]
Andreas Gampe896583e2018-06-15 13:31:58 -070040
41art_clang_tidy_disabled = [
42 "-google-default-arguments",
43 // We have local stores that are only used for debug checks.
44 "-clang-analyzer-deadcode.DeadStores",
45 // We are OK with some static globals and that they can, in theory, throw.
46 "-cert-err58-cpp",
47 // We have lots of C-style variadic functions, and are OK with them. JNI ensures
48 // that working around this warning would be extra-painful.
49 "-cert-dcl50-cpp",
Andreas Gampe322c0892018-09-18 13:50:29 -070050 // "Modernization" we don't agree with.
51 "-modernize-use-auto",
52 "-modernize-return-braced-init-list",
53 "-modernize-use-default-member-init",
54 "-modernize-pass-by-value",
Andreas Gampe896583e2018-06-15 13:31:58 -070055]
56
Colin Cross1f7f3bd2016-07-27 10:12:38 -070057art_global_defaults {
58 // Additional flags are computed by art.go
59
60 name: "art_defaults",
Colin Cross1f7f3bd2016-07-27 10:12:38 -070061 cflags: [
Colin Cross1f7f3bd2016-07-27 10:12:38 -070062 // Base set of cflags used by all things ART.
63 "-fno-rtti",
64 "-ggdb3",
65 "-Wall",
66 "-Werror",
67 "-Wextra",
68 "-Wstrict-aliasing",
69 "-fstrict-aliasing",
70 "-Wunreachable-code",
71 "-Wredundant-decls",
72 "-Wshadow",
73 "-Wunused",
74 "-fvisibility=protected",
75
76 // Warn about thread safety violations with clang.
77 "-Wthread-safety",
78 "-Wthread-safety-negative",
79
80 // Warn if switch fallthroughs aren't annotated.
81 "-Wimplicit-fallthrough",
82
83 // Enable float equality warnings.
84 "-Wfloat-equal",
85
86 // Enable warning of converting ints to void*.
87 "-Wint-to-void-pointer-cast",
88
89 // Enable warning of wrong unused annotations.
90 "-Wused-but-marked-unused",
91
92 // Enable warning for deprecated language features.
93 "-Wdeprecated",
94
95 // Enable warning for unreachable break & return.
96 "-Wunreachable-code-break",
97 "-Wunreachable-code-return",
98
David Srbecky56de89a2018-10-01 15:32:20 +010099 // Disable warning for use of offsetof on non-standard layout type.
100 // We use it to implement OFFSETOF_MEMBER - see macros.h.
101 "-Wno-invalid-offsetof",
102
Yi Kong39402542019-03-24 02:47:16 -0700103 // Enable inconsistent-missing-override warning. This warning is disabled by default in
104 // Android.
105 "-Winconsistent-missing-override",
106
David Sehrae3bcac2017-02-03 15:19:00 -0800107 // Enable thread annotations for std::mutex, etc.
108 "-D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS",
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700109 ],
110
111 target: {
112 android: {
113 cflags: [
114 "-DART_TARGET",
115
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700116 // To use oprofile_android --callgraph, uncomment this and recompile with
117 // mmma -j art
118 // "-fno-omit-frame-pointer",
119 // "-marm",
120 // "-mapcs",
121 ],
122 include_dirs: [
123 // We optimize Thread::Current() with a direct TLS access. This requires access to a
124 // private Bionic header.
125 "bionic/libc/private",
126 ],
127 },
Dan Willemsen057f1e42017-10-03 14:11:48 -0700128 linux: {
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700129 cflags: [
130 // Enable missing-noreturn only on non-Mac. As lots of things are not implemented for
131 // Apple, it's a pain.
132 "-Wmissing-noreturn",
133 ],
134 },
David Srbeckyd53f6062019-03-22 14:55:21 +0000135 darwin: {
136 enabled: false,
137 },
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700138 host: {
139 cflags: [
140 // Bug: 15446488. We don't omit the frame pointer to work around
141 // clang/libunwind bugs that cause SEGVs in run-test-004-ThreadStress.
142 "-fno-omit-frame-pointer",
Aart Bikf6052572017-07-20 16:47:45 -0700143 // The build assumes that all our x86/x86_64 hosts (such as buildbots and developer
144 // desktops) support at least sse4.2/popcount. This firstly implies that the ART
145 // runtime binary itself may exploit these features. Secondly, this implies that
146 // the ART runtime passes these feature flags to dex2oat and JIT by calling the
147 // method InstructionSetFeatures::FromCppDefines(). Since invoking dex2oat directly
148 // does not pick up these flags, cross-compiling from a x86/x86_64 host to a
149 // x86/x86_64 target should not be affected.
150 "-msse4.2",
151 "-mpopcnt",
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700152 ],
153 },
154 },
155
156 codegen: {
157 arm: {
158 cflags: ["-DART_ENABLE_CODEGEN_arm"],
159 },
160 arm64: {
161 cflags: ["-DART_ENABLE_CODEGEN_arm64"],
162 },
163 mips: {
164 cflags: ["-DART_ENABLE_CODEGEN_mips"],
165 },
166 mips64: {
167 cflags: ["-DART_ENABLE_CODEGEN_mips64"],
168 },
169 x86: {
170 cflags: ["-DART_ENABLE_CODEGEN_x86"],
171 },
172 x86_64: {
173 cflags: ["-DART_ENABLE_CODEGEN_x86_64"],
174 },
175 },
176
177 include_dirs: [
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700178 "external/vixl/src",
Andreas Gampe27bd4dd2017-08-23 11:27:08 -0700179 ],
Andreas Gampe61501212016-11-03 16:48:51 -0700180
Andreas Gampe896583e2018-06-15 13:31:58 -0700181 tidy_checks: art_clang_tidy_errors + art_clang_tidy_disabled,
Nikita Ioffe08417352019-03-28 12:47:38 +0000182 tidy_checks_as_errors: art_clang_tidy_errors,
George Burgess IV7fb46652017-06-16 15:35:33 -0700183
184 tidy_flags: [
185 // The static analyzer treats DCHECK as always enabled; we sometimes get
186 // false positives when we use DCHECKs with code that relies on NDEBUG.
187 "-extra-arg=-UNDEBUG",
George Burgess IVdd8aa322017-06-21 16:34:35 -0700188 // clang-tidy complains about functions like:
189 // void foo() { CHECK(kIsFooEnabled); /* do foo... */ }
190 // not being marked noreturn if kIsFooEnabled is false.
191 "-extra-arg=-Wno-missing-noreturn",
Andreas Gampe020020f2018-07-10 12:34:23 -0700192 // Because tidy doesn't like our flow checks for compile-time configuration and thinks that
193 // the following code is dead (it is, but not for all configurations), disable unreachable
194 // code detection in Clang for tidy builds. It is still on for regular build steps, so we
195 // will still get the "real" errors.
196 "-extra-arg=-Wno-unreachable-code",
George Burgess IV7fb46652017-06-16 15:35:33 -0700197 ],
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700198}
199
Colin Crossbe332ed2016-09-21 13:23:53 -0700200art_debug_defaults {
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700201 name: "art_debug_defaults",
202 cflags: [
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700203 "-DDYNAMIC_ANNOTATIONS_ENABLED=1",
204 "-DVIXL_DEBUG",
205 "-UNDEBUG",
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700206 ],
207 asflags: [
208 "-UNDEBUG",
209 ],
Colin Crossc5644062016-08-30 15:41:08 -0700210 target: {
211 // This has to be duplicated for android and host to make sure it
212 // comes after the -Wframe-larger-than warnings inserted by art.go
213 // target-specific properties
214 android: {
215 cflags: ["-Wno-frame-larger-than="],
216 },
217 host: {
218 cflags: ["-Wno-frame-larger-than="],
219 },
220 },
Colin Cross1f7f3bd2016-07-27 10:12:38 -0700221}