blob: 0922b428178a4c4a8fc7fa4619cedf7593cce292 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Andreas Gampe85f1c572018-11-21 13:52:48 -080021#include "base/logging.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000022#include "builder.h"
23#include "class_linker.h"
Vladimir Markob4eb1b12018-05-24 11:09:38 +010024#include "class_root.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000025#include "constant_folding.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010026#include "data_type-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000027#include "dead_code_elimination.h"
Andreas Gampeb95c74b2017-04-20 19:43:21 -070028#include "dex/inline_method_analyser.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000029#include "dex/verification_results.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070030#include "dex/verified_method.h"
Calin Juravleec748352015-07-29 13:52:12 +010031#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000032#include "driver/dex_compilation_unit.h"
33#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010034#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000035#include "jit/jit.h"
36#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000037#include "mirror/class_loader.h"
38#include "mirror/dex_cache.h"
Andreas Gampe52ecb652018-10-24 15:18:21 -070039#include "mirror/object_array-alloc-inl.h"
40#include "mirror/object_array-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000041#include "nodes.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010042#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070043#include "register_allocator_linear_scan.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070044#include "scoped_thread_state_change-inl.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010045#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000046#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000047#include "ssa_phi_elimination.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000048#include "thread.h"
49
50namespace art {
51
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000052// Instruction limit to control memory.
53static constexpr size_t kMaximumNumberOfTotalInstructions = 1024;
54
55// Maximum number of instructions for considering a method small,
56// which we will always try to inline if the other non-instruction limits
57// are not reached.
58static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000059
60// Limit the number of dex registers that we accumulate while inlining
61// to avoid creating large amount of nested environments.
Nicolas Geoffrayf81621e2017-06-07 13:18:03 +010062static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000063
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000064// Limit recursive call inlining, which do not benefit from too
65// much inlining compared to code locality.
66static constexpr size_t kMaximumNumberOfRecursiveCalls = 4;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070067
Calin Juravlee2492d42017-03-20 11:42:13 -070068// Controls the use of inline caches in AOT mode.
Calin Juravle8af70892017-03-28 15:31:44 -070069static constexpr bool kUseAOTInlineCaches = true;
Calin Juravlee2492d42017-03-20 11:42:13 -070070
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000071// We check for line numbers to make sure the DepthString implementation
72// aligns the output nicely.
73#define LOG_INTERNAL(msg) \
74 static_assert(__LINE__ > 10, "Unhandled line number"); \
75 static_assert(__LINE__ < 10000, "Unhandled line number"); \
76 VLOG(compiler) << DepthString(__LINE__) << msg
77
78#define LOG_TRY() LOG_INTERNAL("Try inlinining call: ")
79#define LOG_NOTE() LOG_INTERNAL("Note: ")
80#define LOG_SUCCESS() LOG_INTERNAL("Success: ")
Igor Murashkin1e065a52017-08-09 13:20:34 -070081#define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ")
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +000082#define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ")
83
84std::string HInliner::DepthString(int line) const {
85 std::string value;
86 // Indent according to the inlining depth.
87 size_t count = depth_;
88 // Line numbers get printed in the log, so add a space if the log's line is less
89 // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright.
90 if (!kIsTargetBuild) {
91 if (line < 100) {
92 value += " ";
93 }
94 if (line < 1000) {
95 value += " ";
96 }
97 // Safeguard if this file reaches more than 10000 lines.
98 DCHECK_LT(line, 10000);
99 }
100 for (size_t i = 0; i < count; ++i) {
101 value += " ";
102 }
103 return value;
104}
105
106static size_t CountNumberOfInstructions(HGraph* graph) {
107 size_t number_of_instructions = 0;
108 for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) {
109 for (HInstructionIterator instr_it(block->GetInstructions());
110 !instr_it.Done();
111 instr_it.Advance()) {
112 ++number_of_instructions;
113 }
114 }
115 return number_of_instructions;
116}
117
118void HInliner::UpdateInliningBudget() {
119 if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) {
120 // Always try to inline small methods.
121 inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod;
122 } else {
123 inlining_budget_ = std::max(
124 kMaximumNumberOfInstructionsForSmallMethod,
125 kMaximumNumberOfTotalInstructions - total_number_of_instructions_);
126 }
127}
128
Aart Bik24773202018-04-26 10:28:51 -0700129bool HInliner::Run() {
Vladimir Marko213ee2d2018-06-22 11:56:34 +0100130 if (codegen_->GetCompilerOptions().GetInlineMaxCodeUnits() == 0) {
Aart Bik24773202018-04-26 10:28:51 -0700131 // Inlining effectively disabled.
132 return false;
133 } else if (graph_->IsDebuggable()) {
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000134 // For simplicity, we currently never inline when the graph is debuggable. This avoids
135 // doing some logic in the runtime to discover if a method could have been inlined.
Aart Bik24773202018-04-26 10:28:51 -0700136 return false;
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +0000137 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000138
Aart Bik24773202018-04-26 10:28:51 -0700139 bool didInline = false;
140
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000141 // Initialize the number of instructions for the method being compiled. Recursive calls
142 // to HInliner::Run have already updated the instruction count.
143 if (outermost_graph_ == graph_) {
144 total_number_of_instructions_ = CountNumberOfInstructions(graph_);
145 }
146
147 UpdateInliningBudget();
148 DCHECK_NE(total_number_of_instructions_, 0u);
149 DCHECK_NE(inlining_budget_, 0u);
150
Roland Levillain6c3af162017-04-27 11:18:56 +0100151 // If we're compiling with a core image (which is only used for
152 // test purposes), honor inlining directives in method names:
Roland Levillain6c3af162017-04-27 11:18:56 +0100153 // - if a method's name contains the substring "$noinline$", do not
Vladimir Marko6be1dbd2018-11-13 13:09:51 +0000154 // inline that method;
155 // - if a method's name contains the substring "$inline$", ensure
156 // that this method is actually inlined.
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000157 // We limit the latter to AOT compilation, as the JIT may or may not inline
Nicolas Geoffray08490b82017-07-18 12:58:10 +0100158 // depending on the state of classes at runtime.
Vladimir Marko6be1dbd2018-11-13 13:09:51 +0000159 const bool honor_noinline_directives = codegen_->GetCompilerOptions().CompilingWithCoreImage();
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000160 const bool honor_inline_directives =
161 honor_noinline_directives && Runtime::Current()->IsAotCompiler();
Roland Levillain6c3af162017-04-27 11:18:56 +0100162
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000163 // Keep a copy of all blocks when starting the visit.
164 ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder();
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100165 DCHECK(!blocks.empty());
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +0000166 // Because we are changing the graph when inlining,
167 // we just iterate over the blocks of the outer method.
168 // This avoids doing the inlining work again on the inlined blocks.
169 for (HBasicBlock* block : blocks) {
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000170 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
171 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100172 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -0700173 // As long as the call is not intrinsified, it is worth trying to inline.
174 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000175 if (honor_noinline_directives) {
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000176 // Debugging case: directives in method names control or assert on inlining.
177 std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod(
Andreas Gampe3db70682018-12-26 15:12:03 -0800178 call->GetDexMethodIndex(), /* with_signature= */ false);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000179 // Tests prevent inlining by having $noinline$ in their method names.
180 if (callee_name.find("$noinline$") == std::string::npos) {
Aart Bik24773202018-04-26 10:28:51 -0700181 if (TryInline(call)) {
182 didInline = true;
Aart Bik54e45c52018-04-27 13:57:21 -0700183 } else if (honor_inline_directives) {
Nicolas Geoffray1949baf2017-10-17 12:14:53 +0000184 bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos);
185 CHECK(!should_have_inlined) << "Could not inline " << callee_name;
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000186 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000187 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100188 } else {
Vladimir Markobe0c7cf2018-03-19 13:40:56 +0000189 DCHECK(!honor_inline_directives);
Nicolas Geoffrayb703d182017-02-14 18:05:28 +0000190 // Normal case: try to inline.
Aart Bik24773202018-04-26 10:28:51 -0700191 if (TryInline(call)) {
192 didInline = true;
193 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000194 }
195 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000196 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000197 }
198 }
Aart Bik24773202018-04-26 10:28:51 -0700199
200 return didInline;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000201}
202
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100203static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700204 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100205 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
206}
207
208/**
209 * Given the `resolved_method` looked up in the dex cache, try to find
210 * the actual runtime target of an interface or virtual call.
211 * Return nullptr if the runtime target cannot be proven.
212 */
213static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700214 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100215 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
216 // No need to lookup further, the resolved method will be the target.
217 return resolved_method;
218 }
219
220 HInstruction* receiver = invoke->InputAt(0);
221 if (receiver->IsNullCheck()) {
222 // Due to multiple levels of inlining within the same pass, it might be that
223 // null check does not have the reference type of the actual receiver.
224 receiver = receiver->InputAt(0);
225 }
226 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000227 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
228 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100229 // We currently only support inlining with known receivers.
230 // TODO: Remove this check, we should be able to inline final methods
231 // on unknown receivers.
232 return nullptr;
233 } else if (info.GetTypeHandle()->IsInterface()) {
234 // Statically knowing that the receiver has an interface type cannot
235 // help us find what is the target method.
236 return nullptr;
237 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
238 // The method that we're trying to call is not in the receiver's class or super classes.
239 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000240 } else if (info.GetTypeHandle()->IsErroneous()) {
241 // If the type is erroneous, do not go further, as we are going to query the vtable or
242 // imt table, that we can only safely do on non-erroneous classes.
243 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100244 }
245
246 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700247 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100248 if (invoke->IsInvokeInterface()) {
249 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
250 resolved_method, pointer_size);
251 } else {
252 DCHECK(invoke->IsInvokeVirtual());
253 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
254 resolved_method, pointer_size);
255 }
256
257 if (resolved_method == nullptr) {
258 // The information we had on the receiver was not enough to find
259 // the target method. Since we check above the exact type of the receiver,
260 // the only reason this can happen is an IncompatibleClassChangeError.
261 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700262 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100263 // The information we had on the receiver was not enough to find
264 // the target method. Since we check above the exact type of the receiver,
265 // the only reason this can happen is an IncompatibleClassChangeError.
266 return nullptr;
267 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
268 // A final method has to be the target method.
269 return resolved_method;
270 } else if (info.IsExact()) {
271 // If we found a method and the receiver's concrete type is statically
272 // known, we know for sure the target.
273 return resolved_method;
274 } else {
275 // Even if we did find a method, the receiver type was not enough to
276 // statically find the runtime target.
277 return nullptr;
278 }
279}
280
281static uint32_t FindMethodIndexIn(ArtMethod* method,
282 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000283 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700284 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100285 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100286 return method->GetDexMethodIndex();
287 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000288 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100289 }
290}
291
Vladimir Marko423bebb2019-03-26 15:17:21 +0000292static dex::TypeIndex FindClassIndexIn(ObjPtr<mirror::Class> cls,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000293 const DexCompilationUnit& compilation_unit)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700294 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000295 const DexFile& dex_file = *compilation_unit.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800296 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100297 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700298 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000299 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800300 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700301 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100302 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100303 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000304 DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000305 index = cls->GetDexTypeIndex();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100306 } else {
307 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000308 // We cannot guarantee the entry will resolve to the same class,
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100309 // as there may be different class loaders. So only return the index if it's
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000310 // the right class already resolved with the class loader.
311 if (index.IsValid()) {
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000312 ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000313 index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get());
314 if (resolved != cls) {
315 index = dex::TypeIndex::Invalid();
316 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100317 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100318 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000319
320 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100321}
322
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000323class ScopedProfilingInfoInlineUse {
324 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000325 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
326 : method_(method),
327 self_(self),
328 // Fetch the profiling info ahead of using it. If it's null when fetching,
329 // we should not call JitCodeCache::DoneInlining.
330 profiling_info_(
331 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000332 }
333
334 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000335 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700336 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000337 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
338 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
339 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000340 }
341
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000342 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
343
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000344 private:
345 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000346 Thread* const self_;
347 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000348};
349
Calin Juravle13439f02017-02-21 01:17:21 -0800350HInliner::InlineCacheType HInliner::GetInlineCacheType(
351 const Handle<mirror::ObjectArray<mirror::Class>>& classes)
352 REQUIRES_SHARED(Locks::mutator_lock_) {
353 uint8_t number_of_types = 0;
354 for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) {
355 if (classes->Get(number_of_types) == nullptr) {
356 break;
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000357 }
358 }
Calin Juravle13439f02017-02-21 01:17:21 -0800359
360 if (number_of_types == 0) {
361 return kInlineCacheUninitialized;
362 } else if (number_of_types == 1) {
363 return kInlineCacheMonomorphic;
364 } else if (number_of_types == InlineCache::kIndividualCacheSize) {
365 return kInlineCacheMegamorphic;
366 } else {
367 return kInlineCachePolymorphic;
368 }
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000369}
370
Vladimir Marko423bebb2019-03-26 15:17:21 +0000371static ObjPtr<mirror::Class> GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000372 REQUIRES_SHARED(Locks::mutator_lock_) {
373 DCHECK(classes->Get(0) != nullptr);
374 return classes->Get(0);
375}
376
Mingyao Yang063fc772016-08-02 11:02:54 -0700377ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
378 if (!resolved_method->HasSingleImplementation()) {
379 return nullptr;
380 }
381 if (Runtime::Current()->IsAotCompiler()) {
382 // No CHA-based devirtulization for AOT compiler (yet).
383 return nullptr;
384 }
Nicolas Geoffray141b63c2019-02-27 14:28:46 +0000385 if (Runtime::Current()->IsZygote()) {
386 // No CHA-based devirtulization for Zygote, as it compiles with
387 // offline information.
388 return nullptr;
389 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700390 if (outermost_graph_->IsCompilingOsr()) {
391 // We do not support HDeoptimize in OSR methods.
392 return nullptr;
393 }
Mingyao Yange8fcd012017-01-20 10:43:30 -0800394 PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000395 ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size);
396 if (single_impl == nullptr) {
397 return nullptr;
398 }
399 if (single_impl->IsProxyMethod()) {
400 // Proxy method is a generic invoker that's not worth
401 // devirtualizing/inlining. It also causes issues when the proxy
402 // method is in another dex file if we try to rewrite invoke-interface to
403 // invoke-virtual because a proxy method doesn't have a real dex file.
404 return nullptr;
405 }
Nicolas Geoffray8e33e842017-04-03 16:55:16 +0100406 if (!single_impl->GetDeclaringClass()->IsResolved()) {
407 // There's a race with the class loading, which updates the CHA info
408 // before setting the class to resolved. So we just bail for this
409 // rare occurence.
410 return nullptr;
411 }
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +0000412 return single_impl;
Mingyao Yang063fc772016-08-02 11:02:54 -0700413}
414
Vladimir Marko2afaff72018-11-30 17:01:50 +0000415static bool IsMethodUnverified(const CompilerOptions& compiler_options, ArtMethod* method)
David Sehr0225f8e2018-01-31 08:52:24 +0000416 REQUIRES_SHARED(Locks::mutator_lock_) {
Aart Bik2c148f02018-02-02 14:30:35 -0800417 if (!method->GetDeclaringClass()->IsVerified()) {
418 if (Runtime::Current()->UseJitCompilation()) {
419 // We're at runtime, we know this is cold code if the class
420 // is not verified, so don't bother analyzing.
421 return true;
422 }
423 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Vladimir Marko2afaff72018-11-30 17:01:50 +0000424 if (!compiler_options.IsMethodVerifiedWithoutFailures(method->GetDexMethodIndex(),
425 class_def_idx,
426 *method->GetDexFile())) {
Aart Bik2c148f02018-02-02 14:30:35 -0800427 // Method has soft or hard failures, don't analyze.
428 return true;
429 }
430 }
431 return false;
432}
433
Vladimir Marko2afaff72018-11-30 17:01:50 +0000434static bool AlwaysThrows(const CompilerOptions& compiler_options, ArtMethod* method)
Aart Bik2c148f02018-02-02 14:30:35 -0800435 REQUIRES_SHARED(Locks::mutator_lock_) {
436 DCHECK(method != nullptr);
437 // Skip non-compilable and unverified methods.
Vladimir Marko2afaff72018-11-30 17:01:50 +0000438 if (!method->IsCompilable() || IsMethodUnverified(compiler_options, method)) {
Aart Bik2c148f02018-02-02 14:30:35 -0800439 return false;
440 }
Aart Bika8b8e9b2018-01-09 11:01:02 -0800441 // Skip native methods, methods with try blocks, and methods that are too large.
Aart Bik2c148f02018-02-02 14:30:35 -0800442 CodeItemDataAccessor accessor(method->DexInstructionData());
Aart Bika8b8e9b2018-01-09 11:01:02 -0800443 if (!accessor.HasCodeItem() ||
444 accessor.TriesSize() != 0 ||
445 accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) {
446 return false;
447 }
448 // Scan for exits.
449 bool throw_seen = false;
450 for (const DexInstructionPcPair& pair : accessor) {
451 switch (pair.Inst().Opcode()) {
452 case Instruction::RETURN:
453 case Instruction::RETURN_VOID:
454 case Instruction::RETURN_WIDE:
455 case Instruction::RETURN_OBJECT:
456 case Instruction::RETURN_VOID_NO_BARRIER:
457 return false; // found regular control flow back
458 case Instruction::THROW:
459 throw_seen = true;
460 break;
461 default:
462 break;
463 }
464 }
465 return throw_seen;
466}
467
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700468bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000469 if (invoke_instruction->IsInvokeUnresolved() ||
Orion Hodson4c8e12e2018-05-18 08:33:20 +0100470 invoke_instruction->IsInvokePolymorphic() ||
471 invoke_instruction->IsInvokeCustom()) {
472 return false; // Don't bother to move further if we know the method is unresolved or the
473 // invocation is polymorphic (invoke-{polymorphic,custom}).
Calin Juravle175dc732015-08-25 15:42:32 +0100474 }
475
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000476 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100477 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000478 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000479 LOG_TRY() << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000480
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100481 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100482 if (resolved_method == nullptr) {
483 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
484 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000485 LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method";
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100486 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000487 }
488 ArtMethod* actual_method = nullptr;
489
490 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800491 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000492 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100493 // Check if we can statically find the method.
494 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000495 }
496
Mingyao Yang063fc772016-08-02 11:02:54 -0700497 bool cha_devirtualize = false;
498 if (actual_method == nullptr) {
499 ArtMethod* method = TryCHADevirtualization(resolved_method);
500 if (method != nullptr) {
501 cha_devirtualize = true;
502 actual_method = method;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000503 LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod();
Mingyao Yang063fc772016-08-02 11:02:54 -0700504 }
505 }
506
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100507 if (actual_method != nullptr) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800508 // Single target.
Mingyao Yang063fc772016-08-02 11:02:54 -0700509 bool result = TryInlineAndReplace(invoke_instruction,
510 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000511 ReferenceTypeInfo::CreateInvalid(),
Andreas Gampe3db70682018-12-26 15:12:03 -0800512 /* do_rtp= */ true,
Mingyao Yang063fc772016-08-02 11:02:54 -0700513 cha_devirtualize);
Aart Bikd4e328f2018-01-16 14:14:34 -0800514 if (result) {
515 // Successfully inlined.
516 if (!invoke_instruction->IsInvokeStaticOrDirect()) {
517 if (cha_devirtualize) {
518 // Add dependency due to devirtualization. We've assumed resolved_method
519 // has single implementation.
520 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
521 MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline);
522 } else {
523 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface);
524 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700525 }
Vladimir Marko2afaff72018-11-30 17:01:50 +0000526 } else if (!cha_devirtualize && AlwaysThrows(codegen_->GetCompilerOptions(), actual_method)) {
Aart Bikd4e328f2018-01-16 14:14:34 -0800527 // Set always throws property for non-inlined method call with single target
528 // (unless it was obtained through CHA, because that would imply we have
529 // to add the CHA dependency, which seems not worth it).
530 invoke_instruction->SetAlwaysThrows(true);
Calin Juravle69158982016-03-16 11:53:41 +0000531 }
532 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100533 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800534 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100535
Calin Juravle13439f02017-02-21 01:17:21 -0800536 // Try using inline caches.
537 return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method);
538}
539
540static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder(
541 const DexCompilationUnit& compilation_unit,
542 StackHandleScope<1>* hs)
543 REQUIRES_SHARED(Locks::mutator_lock_) {
544 Thread* self = Thread::Current();
545 ClassLinker* class_linker = compilation_unit.GetClassLinker();
546 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle(
547 mirror::ObjectArray<mirror::Class>::Alloc(
548 self,
Vladimir Markob4eb1b12018-05-24 11:09:38 +0100549 GetClassRoot<mirror::ObjectArray<mirror::Class>>(class_linker),
Calin Juravle13439f02017-02-21 01:17:21 -0800550 InlineCache::kIndividualCacheSize));
551 if (inline_cache == nullptr) {
552 // We got an OOME. Just clear the exception, and don't inline.
553 DCHECK(self->IsExceptionPending());
554 self->ClearException();
555 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
556 }
557 return inline_cache;
558}
559
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700560bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() {
561 // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and
562 // do not generate a deopt.
563 //
564 // For AOT:
565 // Generating a deopt does not ensure that we will actually capture the new types;
566 // and the danger is that we could be stuck in a loop with "forever" deoptimizations.
567 // Take for example the following scenario:
568 // - we capture the inline cache in one run
569 // - the next run, we deoptimize because we miss a type check, but the method
570 // never becomes hot again
571 // In this case, the inline cache will not be updated in the profile and the AOT code
572 // will keep deoptimizing.
573 // Another scenario is if we use profile compilation for a process which is not allowed
574 // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the
575 // rest of the lifetime.
576 // TODO(calin):
577 // This is a compromise because we will most likely never update the inline cache
578 // in the profile (unless there's another reason to deopt). So we might be stuck with
579 // a sub-optimal inline cache.
580 // We could be smarter when capturing inline caches to mitigate this.
581 // (e.g. by having different thresholds for new and old methods).
582 //
583 // For OSR:
584 // We may come from the interpreter and it may have seen different receiver types.
585 return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr();
586}
Calin Juravle13439f02017-02-21 01:17:21 -0800587bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file,
588 HInvoke* invoke_instruction,
589 ArtMethod* resolved_method)
590 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee2492d42017-03-20 11:42:13 -0700591 if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) {
592 return false;
593 }
594
Calin Juravle13439f02017-02-21 01:17:21 -0800595 StackHandleScope<1> hs(Thread::Current());
596 Handle<mirror::ObjectArray<mirror::Class>> inline_cache;
Nicolas Geoffrayde1b2a22019-02-27 09:10:57 +0000597 // The Zygote JIT compiles based on a profile, so we shouldn't use runtime inline caches
598 // for it.
599 InlineCacheType inline_cache_type =
600 (Runtime::Current()->IsAotCompiler() || Runtime::Current()->IsZygote())
601 ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache)
602 : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache);
Calin Juravle13439f02017-02-21 01:17:21 -0800603
604 switch (inline_cache_type) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000605 case kInlineCacheNoData: {
606 LOG_FAIL_NO_STAT()
Nicolas Geoffrayd2f13ba2019-06-04 16:48:58 +0100607 << "No inline cache information for call to "
608 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex());
Calin Juravle13439f02017-02-21 01:17:21 -0800609 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000610 }
Calin Juravle13439f02017-02-21 01:17:21 -0800611
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000612 case kInlineCacheUninitialized: {
613 LOG_FAIL_NO_STAT()
614 << "Interface or virtual call to "
615 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
616 << " is not hit and not inlined";
617 return false;
618 }
619
620 case kInlineCacheMonomorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000621 MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall);
Calin Juravleaf44e6c2017-05-23 14:24:55 -0700622 if (UseOnlyPolymorphicInliningWithNoDeopt()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800623 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000624 } else {
Calin Juravle13439f02017-02-21 01:17:21 -0800625 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000626 }
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000627 }
Calin Juravle13439f02017-02-21 01:17:21 -0800628
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000629 case kInlineCachePolymorphic: {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000630 MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800631 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000632 }
Calin Juravle13439f02017-02-21 01:17:21 -0800633
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000634 case kInlineCacheMegamorphic: {
635 LOG_FAIL_NO_STAT()
636 << "Interface or virtual call to "
637 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
638 << " is megamorphic and not inlined";
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000639 MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall);
Calin Juravle13439f02017-02-21 01:17:21 -0800640 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000641 }
Calin Juravle13439f02017-02-21 01:17:21 -0800642
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000643 case kInlineCacheMissingTypes: {
644 LOG_FAIL_NO_STAT()
645 << "Interface or virtual call to "
646 << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex())
647 << " is missing types and not inlined";
Calin Juravle13439f02017-02-21 01:17:21 -0800648 return false;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000649 }
Calin Juravle13439f02017-02-21 01:17:21 -0800650 }
651 UNREACHABLE();
652}
653
654HInliner::InlineCacheType HInliner::GetInlineCacheJIT(
655 HInvoke* invoke_instruction,
656 StackHandleScope<1>* hs,
657 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
658 REQUIRES_SHARED(Locks::mutator_lock_) {
659 DCHECK(Runtime::Current()->UseJitCompilation());
660
661 ArtMethod* caller = graph_->GetArtMethod();
662 // Under JIT, we should always know the caller.
663 DCHECK(caller != nullptr);
664 ScopedProfilingInfoInlineUse spiis(caller, Thread::Current());
665 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
666
667 if (profiling_info == nullptr) {
668 return kInlineCacheNoData;
669 }
670
671 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
672 if (inline_cache->Get() == nullptr) {
673 // We can't extract any data if we failed to allocate;
674 return kInlineCacheNoData;
675 } else {
676 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
677 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
678 *inline_cache);
679 return GetInlineCacheType(*inline_cache);
680 }
681}
682
683HInliner::InlineCacheType HInliner::GetInlineCacheAOT(
684 const DexFile& caller_dex_file,
685 HInvoke* invoke_instruction,
686 StackHandleScope<1>* hs,
687 /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache)
688 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Marko1a2a5cd2018-11-07 15:39:48 +0000689 const ProfileCompilationInfo* pci = codegen_->GetCompilerOptions().GetProfileCompilationInfo();
Calin Juravle13439f02017-02-21 01:17:21 -0800690 if (pci == nullptr) {
691 return kInlineCacheNoData;
692 }
693
Calin Juravlecc3171a2017-05-19 16:47:53 -0700694 std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile =
695 pci->GetMethod(caller_dex_file.GetLocation(),
696 caller_dex_file.GetLocationChecksum(),
697 caller_compilation_unit_.GetDexMethodIndex());
698 if (offline_profile == nullptr) {
Calin Juravle13439f02017-02-21 01:17:21 -0800699 return kInlineCacheNoData; // no profile information for this invocation.
700 }
701
702 *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs);
703 if (inline_cache == nullptr) {
704 // We can't extract any data if we failed to allocate;
705 return kInlineCacheNoData;
706 } else {
707 return ExtractClassesFromOfflineProfile(invoke_instruction,
Calin Juravlecc3171a2017-05-19 16:47:53 -0700708 *(offline_profile.get()),
Calin Juravle13439f02017-02-21 01:17:21 -0800709 *inline_cache);
710 }
711}
712
713HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile(
714 const HInvoke* invoke_instruction,
715 const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile,
716 /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache)
717 REQUIRES_SHARED(Locks::mutator_lock_) {
Calin Juravlee6f87cc2017-05-24 17:41:05 -0700718 const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc());
719 if (it == offline_profile.inline_caches->end()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800720 return kInlineCacheUninitialized;
721 }
722
723 const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second;
724
725 if (dex_pc_data.is_missing_types) {
726 return kInlineCacheMissingTypes;
727 }
728 if (dex_pc_data.is_megamorphic) {
729 return kInlineCacheMegamorphic;
730 }
731
732 DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize);
733 Thread* self = Thread::Current();
734 // We need to resolve the class relative to the containing dex file.
735 // So first, build a mapping from the index of dex file in the profile to
736 // its dex cache. This will avoid repeating the lookup when walking over
737 // the inline cache types.
738 std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache(
739 offline_profile.dex_references.size());
740 for (size_t i = 0; i < offline_profile.dex_references.size(); i++) {
741 bool found = false;
Vladimir Marko213ee2d2018-06-22 11:56:34 +0100742 for (const DexFile* dex_file : codegen_->GetCompilerOptions().GetDexFilesForOatFile()) {
Calin Juravle13439f02017-02-21 01:17:21 -0800743 if (offline_profile.dex_references[i].MatchesDex(dex_file)) {
744 dex_profile_index_to_dex_cache[i] =
745 caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file);
746 found = true;
747 }
748 }
749 if (!found) {
750 VLOG(compiler) << "Could not find profiled dex file: "
Calin Juravle4ba700a2019-09-16 15:45:17 -0700751 << offline_profile.dex_references[i].profile_key;
Calin Juravle13439f02017-02-21 01:17:21 -0800752 return kInlineCacheMissingTypes;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100753 }
754 }
755
Calin Juravle13439f02017-02-21 01:17:21 -0800756 // Walk over the classes and resolve them. If we cannot find a type we return
757 // kInlineCacheMissingTypes.
758 int ic_index = 0;
759 for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) {
760 ObjPtr<mirror::DexCache> dex_cache =
761 dex_profile_index_to_dex_cache[class_ref.dex_profile_index];
762 DCHECK(dex_cache != nullptr);
Calin Juravle08556882017-05-26 16:40:45 -0700763
764 if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) {
765 VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index
766 << "is invalid in location" << dex_cache->GetDexFile()->GetLocation();
767 return kInlineCacheNoData;
768 }
Vladimir Marko666ee3d2017-12-11 18:37:36 +0000769 ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000770 class_ref.type_index,
771 dex_cache,
772 caller_compilation_unit_.GetClassLoader().Get());
Calin Juravle13439f02017-02-21 01:17:21 -0800773 if (clazz != nullptr) {
774 inline_cache->Set(ic_index++, clazz);
775 } else {
776 VLOG(compiler) << "Could not resolve class from inline cache in AOT mode "
777 << caller_compilation_unit_.GetDexFile()->PrettyMethod(
778 invoke_instruction->GetDexMethodIndex()) << " : "
779 << caller_compilation_unit_
780 .GetDexFile()->StringByTypeIdx(class_ref.type_index);
781 return kInlineCacheMissingTypes;
782 }
783 }
784 return GetInlineCacheType(inline_cache);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100785}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000786
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000787HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
788 HInstruction* receiver,
789 uint32_t dex_pc) const {
Vladimir Markob4eb1b12018-05-24 11:09:38 +0100790 ArtField* field = GetClassRoot<mirror::Object>(class_linker)->GetInstanceField(0);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000791 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Vladimir Markoca6fff82017-10-03 14:49:14 +0100792 HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000793 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000794 field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100795 DataType::Type::kReference,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000796 field->GetOffset(),
797 field->IsVolatile(),
798 field->GetDexFieldIndex(),
799 field->GetDeclaringClass()->GetDexClassDefIndex(),
800 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000801 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000802 // The class of a field is effectively final, and does not have any memory dependencies.
803 result->SetSideEffects(SideEffects::None());
804 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000805}
806
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000807static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass,
808 ArtMethod* resolved_method,
809 HInstruction* invoke_instruction,
810 PointerSize pointer_size)
811 REQUIRES_SHARED(Locks::mutator_lock_) {
812 if (Runtime::Current()->IsAotCompiler()) {
813 // We can get unrelated types when working with profiles (corruption,
814 // systme updates, or anyone can write to it). So first check if the class
815 // actually implements the declaring class of the method that is being
816 // called in bytecode.
817 // Note: the lookup methods used below require to have assignable types.
818 if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) {
819 return nullptr;
820 }
821 }
822
823 if (invoke_instruction->IsInvokeInterface()) {
824 resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size);
825 } else {
826 DCHECK(invoke_instruction->IsInvokeVirtual());
827 resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size);
828 }
829 DCHECK(resolved_method != nullptr);
830 return resolved_method;
831}
832
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100833bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
834 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000835 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000836 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
837 << invoke_instruction->DebugName();
838
Andreas Gampea5b09a62016-11-17 15:21:22 -0800839 dex::TypeIndex class_index = FindClassIndexIn(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000840 GetMonomorphicType(classes), caller_compilation_unit_);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800841 if (!class_index.IsValid()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000842 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000843 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
844 << " from inline cache is not inlined because its class is not"
845 << " accessible to the caller";
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100846 return false;
847 }
848
849 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700850 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000851 Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes));
852 resolved_method = ResolveMethodFromInlineCache(
853 monomorphic_type, resolved_method, invoke_instruction, pointer_size);
854
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000855 LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod();
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +0000856 if (resolved_method == nullptr) {
857 // Bogus AOT profile, bail.
858 DCHECK(Runtime::Current()->IsAotCompiler());
859 return false;
860 }
861
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100862 HInstruction* receiver = invoke_instruction->InputAt(0);
863 HInstruction* cursor = invoke_instruction->GetPrevious();
864 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang063fc772016-08-02 11:02:54 -0700865 if (!TryInlineAndReplace(invoke_instruction,
866 resolved_method,
Andreas Gampe3db70682018-12-26 15:12:03 -0800867 ReferenceTypeInfo::Create(monomorphic_type, /* is_exact= */ true),
868 /* do_rtp= */ false,
869 /* cha_devirtualize= */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100870 return false;
871 }
872
873 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000874 AddTypeGuard(receiver,
875 cursor,
876 bb_cursor,
877 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000878 monomorphic_type,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000879 invoke_instruction,
Andreas Gampe3db70682018-12-26 15:12:03 -0800880 /* with_deoptimization= */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100881
882 // Run type propagation to get the guard typed, and eventually propagate the
883 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000884 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000885 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +0000886 outer_compilation_unit_.GetDexCache(),
887 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -0800888 /* is_first_run= */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100889 rtp_fixup.Run();
890
Vladimir Markocd09e1f2017-11-24 15:02:40 +0000891 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100892 return true;
893}
894
Mingyao Yang063fc772016-08-02 11:02:54 -0700895void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
896 uint32_t dex_pc,
897 HInstruction* cursor,
898 HBasicBlock* bb_cursor) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100899 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator())
900 HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc);
901 HInstruction* compare = new (graph_->GetAllocator()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700902 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Vladimir Markoca6fff82017-10-03 14:49:14 +0100903 HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize(
904 graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700905
906 if (cursor != nullptr) {
907 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
908 } else {
909 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
910 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800911 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
912 bb_cursor->InsertInstructionAfter(deopt, compare);
913
914 // Add receiver as input to aid CHA guard optimization later.
915 deopt_flag->AddInput(invoke_instruction->InputAt(0));
916 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700917 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800918 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700919}
920
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000921HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
922 HInstruction* cursor,
923 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800924 dex::TypeIndex class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +0000925 Handle<mirror::Class> klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000926 HInstruction* invoke_instruction,
927 bool with_deoptimization) {
928 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
929 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
930 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000931 if (cursor != nullptr) {
932 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
933 } else {
934 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
935 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000936
937 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Calin Juravle07f01df2017-04-28 19:58:01 -0700938 bool is_referrer;
939 ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod();
940 if (outermost_art_method == nullptr) {
941 DCHECK(Runtime::Current()->IsAotCompiler());
942 // We are in AOT mode and we don't have an ART method to determine
943 // if the inlined method belongs to the referrer. Assume it doesn't.
944 is_referrer = false;
945 } else {
946 is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass();
947 }
948
Nicolas Geoffray56876342016-12-16 16:09:08 +0000949 // Note that we will just compare the classes, so we don't need Java semantics access checks.
950 // Note that the type index and the dex file are relative to the method this type guard is
951 // inlined into.
Vladimir Markoca6fff82017-10-03 14:49:14 +0100952 HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(),
953 class_index,
954 caller_dex_file,
955 klass,
956 is_referrer,
957 invoke_instruction->GetDexPc(),
Andreas Gampe3db70682018-12-26 15:12:03 -0800958 /* needs_access_check= */ false);
Nicolas Geoffrayc4aa82c2017-03-06 14:38:52 +0000959 HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind(
Vladimir Markobb089b62018-06-28 17:30:16 +0100960 load_class, codegen_, caller_compilation_unit_);
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000961 DCHECK(kind != HLoadClass::LoadKind::kInvalid)
962 << "We should always be able to reference a class for inline caches";
Vladimir Marko28e012a2017-12-07 11:22:59 +0000963 // Load kind must be set before inserting the instruction into the graph.
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000964 load_class->SetLoadKind(kind);
Vladimir Marko28e012a2017-12-07 11:22:59 +0000965 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Calin Juravle13439f02017-02-21 01:17:21 -0800966 // In AOT mode, we will most likely load the class from BSS, which will involve a call
967 // to the runtime. In this case, the load instruction will need an environment so copy
968 // it from the invoke instruction.
969 if (load_class->NeedsEnvironment()) {
970 DCHECK(Runtime::Current()->IsAotCompiler());
971 load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
972 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000973
Vladimir Markoca6fff82017-10-03 14:49:14 +0100974 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000975 bb_cursor->InsertInstructionAfter(compare, load_class);
976 if (with_deoptimization) {
Vladimir Markoca6fff82017-10-03 14:49:14 +0100977 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
978 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000979 compare,
980 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +0100981 Runtime::Current()->IsAotCompiler()
982 ? DeoptimizationKind::kAotInlineCache
983 : DeoptimizationKind::kJitInlineCache,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000984 invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000985 bb_cursor->InsertInstructionAfter(deoptimize, compare);
986 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +0000987 DCHECK_EQ(invoke_instruction->InputAt(0), receiver);
988 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
989 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000990 }
991 return compare;
992}
993
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000994bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100995 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000996 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000997 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
998 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000999
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001000 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001001 return true;
1002 }
1003
1004 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001005 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001006
1007 bool all_targets_inlined = true;
1008 bool one_target_inlined = false;
1009 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001010 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001011 break;
1012 }
1013 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001014
1015 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001016 method = ResolveMethodFromInlineCache(
1017 handle, resolved_method, invoke_instruction, pointer_size);
1018 if (method == nullptr) {
1019 DCHECK(Runtime::Current()->IsAotCompiler());
1020 // AOT profile is bogus. This loop expects to iterate over all entries,
1021 // so just just continue.
1022 all_targets_inlined = false;
1023 continue;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001024 }
1025
1026 HInstruction* receiver = invoke_instruction->InputAt(0);
1027 HInstruction* cursor = invoke_instruction->GetPrevious();
1028 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1029
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001030 dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001031 HInstruction* return_replacement = nullptr;
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001032 LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod();
Andreas Gampea5b09a62016-11-17 15:21:22 -08001033 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001034 !TryBuildAndInline(invoke_instruction,
1035 method,
Andreas Gampe3db70682018-12-26 15:12:03 -08001036 ReferenceTypeInfo::Create(handle, /* is_exact= */ true),
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001037 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001038 all_targets_inlined = false;
1039 } else {
1040 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001041
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001042 LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
1043 << " has inlined " << ArtMethod::PrettyMethod(method);
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001044
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001045 // If we have inlined all targets before, and this receiver is the last seen,
1046 // we deoptimize instead of keeping the original invoke instruction.
Calin Juravleaf44e6c2017-05-23 14:24:55 -07001047 bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() &&
1048 all_targets_inlined &&
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001049 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001050 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001051
Nicolas Geoffray56876342016-12-16 16:09:08 +00001052 HInstruction* compare = AddTypeGuard(receiver,
1053 cursor,
1054 bb_cursor,
1055 class_index,
Nicolas Geoffray5247c082017-01-13 14:17:29 +00001056 handle,
Nicolas Geoffray56876342016-12-16 16:09:08 +00001057 invoke_instruction,
1058 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001059 if (deoptimize) {
1060 if (return_replacement != nullptr) {
1061 invoke_instruction->ReplaceWith(return_replacement);
1062 }
1063 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1064 // Because the inline cache data can be populated concurrently, we force the end of the
Nicolas Geoffray4c0b4bc2017-03-17 13:08:26 +00001065 // iteration. Otherwise, we could see a new receiver type.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001066 break;
1067 } else {
1068 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1069 }
1070 }
1071 }
1072
1073 if (!one_target_inlined) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001074 LOG_FAIL_NO_STAT()
1075 << "Call to " << ArtMethod::PrettyMethod(resolved_method)
1076 << " from inline cache is not inlined because none"
1077 << " of its targets could be inlined";
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001078 return false;
1079 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001080
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001081 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001082
1083 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001084 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001085 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001086 outer_compilation_unit_.GetDexCache(),
1087 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001088 /* is_first_run= */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001089 rtp_fixup.Run();
1090 return true;
1091}
1092
1093void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
1094 HInstruction* return_replacement,
1095 HInstruction* invoke_instruction) {
1096 uint32_t dex_pc = invoke_instruction->GetDexPc();
1097 HBasicBlock* cursor_block = compare->GetBlock();
1098 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001099 ArenaAllocator* allocator = graph_->GetAllocator();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001100
1101 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
1102 // and the returned block is the start of the then branch (that could contain multiple blocks).
1103 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
1104
1105 // Split the block containing the invoke before and after the invoke. The returned block
1106 // of the split before will contain the invoke and will be the otherwise branch of
1107 // the diamond. The returned block of the split after will be the merge block
1108 // of the diamond.
1109 HBasicBlock* end_then = invoke_instruction->GetBlock();
1110 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
1111 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
1112
1113 // If the methods we are inlining return a value, we create a phi in the merge block
1114 // that will have the `invoke_instruction and the `return_replacement` as inputs.
1115 if (return_replacement != nullptr) {
1116 HPhi* phi = new (allocator) HPhi(
1117 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
1118 merge->AddPhi(phi);
1119 invoke_instruction->ReplaceWith(phi);
1120 phi->AddInput(return_replacement);
1121 phi->AddInput(invoke_instruction);
1122 }
1123
1124 // Add the control flow instructions.
1125 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
1126 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
1127 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
1128
1129 // Add the newly created blocks to the graph.
1130 graph_->AddBlock(then);
1131 graph_->AddBlock(otherwise);
1132 graph_->AddBlock(merge);
1133
1134 // Set up successor (and implictly predecessor) relations.
1135 cursor_block->AddSuccessor(otherwise);
1136 cursor_block->AddSuccessor(then);
1137 end_then->AddSuccessor(merge);
1138 otherwise->AddSuccessor(merge);
1139
1140 // Set up dominance information.
1141 then->SetDominator(cursor_block);
1142 cursor_block->AddDominatedBlock(then);
1143 otherwise->SetDominator(cursor_block);
1144 cursor_block->AddDominatedBlock(otherwise);
1145 merge->SetDominator(cursor_block);
1146 cursor_block->AddDominatedBlock(merge);
1147
1148 // Update the revert post order.
1149 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
1150 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
1151 graph_->reverse_post_order_[++index] = then;
1152 index = IndexOfElement(graph_->reverse_post_order_, end_then);
1153 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
1154 graph_->reverse_post_order_[++index] = otherwise;
1155 graph_->reverse_post_order_[++index] = merge;
1156
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001157
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001158 graph_->UpdateLoopAndTryInformationOfNewBlock(
Andreas Gampe3db70682018-12-26 15:12:03 -08001159 then, original_invoke_block, /* replace_if_back_edge= */ false);
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001160 graph_->UpdateLoopAndTryInformationOfNewBlock(
Andreas Gampe3db70682018-12-26 15:12:03 -08001161 otherwise, original_invoke_block, /* replace_if_back_edge= */ false);
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +00001162
1163 // In case the original invoke location was a back edge, we need to update
1164 // the loop to now have the merge block as a back edge.
1165 graph_->UpdateLoopAndTryInformationOfNewBlock(
Andreas Gampe3db70682018-12-26 15:12:03 -08001166 merge, original_invoke_block, /* replace_if_back_edge= */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +00001167}
1168
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001169bool HInliner::TryInlinePolymorphicCallToSameTarget(
1170 HInvoke* invoke_instruction,
1171 ArtMethod* resolved_method,
1172 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001173 // This optimization only works under JIT for now.
Calin Juravle13439f02017-02-21 01:17:21 -08001174 if (!Runtime::Current()->UseJitCompilation()) {
1175 return false;
1176 }
1177
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001178 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -07001179 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001180
1181 DCHECK(resolved_method != nullptr);
1182 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001183 size_t method_index = invoke_instruction->IsInvokeVirtual()
1184 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
1185 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
1186
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001187 // Check whether we are actually calling the same method among
1188 // the different types seen.
1189 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001190 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001191 break;
1192 }
1193 ArtMethod* new_method = nullptr;
1194 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001195 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +00001196 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001197 if (new_method->IsRuntimeMethod()) {
1198 // Bail out as soon as we see a conflict trampoline in one of the target's
1199 // interface table.
1200 return false;
1201 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001202 } else {
1203 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +00001204 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001205 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001206 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001207 if (actual_method == nullptr) {
1208 actual_method = new_method;
1209 } else if (actual_method != new_method) {
1210 // Different methods, bailout.
1211 return false;
1212 }
1213 }
1214
1215 HInstruction* receiver = invoke_instruction->InputAt(0);
1216 HInstruction* cursor = invoke_instruction->GetPrevious();
1217 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
1218
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001219 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001220 if (!TryBuildAndInline(invoke_instruction,
1221 actual_method,
1222 ReferenceTypeInfo::CreateInvalid(),
1223 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001224 return false;
1225 }
1226
1227 // We successfully inlined, now add a guard.
1228 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
1229 class_linker, receiver, invoke_instruction->GetDexPc());
1230
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001231 DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
1232 ? DataType::Type::kInt64
1233 : DataType::Type::kInt32;
Vladimir Markoca6fff82017-10-03 14:49:14 +01001234 HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001235 receiver_class,
1236 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +00001237 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
1238 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +00001239 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001240 invoke_instruction->GetDexPc());
1241
1242 HConstant* constant;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001243 if (type == DataType::Type::kInt64) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001244 constant = graph_->GetLongConstant(
1245 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1246 } else {
1247 constant = graph_->GetIntConstant(
1248 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
1249 }
1250
Vladimir Markoca6fff82017-10-03 14:49:14 +01001251 HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001252 if (cursor != nullptr) {
1253 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
1254 } else {
1255 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
1256 }
1257 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
1258 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001259
1260 if (outermost_graph_->IsCompilingOsr()) {
1261 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
1262 } else {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001263 HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize(
1264 graph_->GetAllocator(),
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001265 compare,
1266 receiver,
Nicolas Geoffray4e92c3c2017-05-08 09:34:26 +01001267 DeoptimizationKind::kJitSameTarget,
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001268 invoke_instruction->GetDexPc());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001269 bb_cursor->InsertInstructionAfter(deoptimize, compare);
1270 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1271 if (return_replacement != nullptr) {
1272 invoke_instruction->ReplaceWith(return_replacement);
1273 }
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001274 receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize);
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +01001275 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray6f8e2c92017-03-23 14:37:26 +00001276 deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo());
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001277 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001278
1279 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +00001280 ReferenceTypePropagation rtp_fixup(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001281 outer_compilation_unit_.GetClassLoader(),
Vladimir Marko456307a2016-04-19 14:12:13 +00001282 outer_compilation_unit_.GetDexCache(),
1283 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001284 /* is_first_run= */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001285 rtp_fixup.Run();
1286
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001287 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001288
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001289 LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +00001290 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001291}
1292
Mingyao Yang063fc772016-08-02 11:02:54 -07001293bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
1294 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001295 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -07001296 bool do_rtp,
1297 bool cha_devirtualize) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001298 DCHECK(!invoke_instruction->IsIntrinsic());
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001299 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -07001300 uint32_t dex_pc = invoke_instruction->GetDexPc();
1301 HInstruction* cursor = invoke_instruction->GetPrevious();
1302 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001303 bool should_remove_invoke_instruction = false;
1304
1305 // If invoke_instruction is devirtualized to a different method, give intrinsics
1306 // another chance before we try to inline it.
Nicolas Geoffray76d4bb0f32018-09-21 12:58:45 +01001307 if (invoke_instruction->GetResolvedMethod() != method && method->IsIntrinsic()) {
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001308 MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized);
1309 if (invoke_instruction->IsInvokeInterface()) {
1310 // We don't intrinsify an invoke-interface directly.
1311 // Replace the invoke-interface with an invoke-virtual.
1312 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1313 graph_->GetAllocator(),
1314 invoke_instruction->GetNumberOfArguments(),
1315 invoke_instruction->GetType(),
1316 invoke_instruction->GetDexPc(),
1317 invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index.
1318 method,
1319 method->GetMethodIndex());
Nicolas Geoffray76d4bb0f32018-09-21 12:58:45 +01001320 DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone);
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001321 HInputsRef inputs = invoke_instruction->GetInputs();
1322 for (size_t index = 0; index != inputs.size(); ++index) {
1323 new_invoke->SetArgumentAt(index, inputs[index]);
1324 }
1325 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1326 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
1327 if (invoke_instruction->GetType() == DataType::Type::kReference) {
1328 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1329 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001330 return_replacement = new_invoke;
1331 // invoke_instruction is replaced with new_invoke.
1332 should_remove_invoke_instruction = true;
1333 } else {
Nicolas Geoffray76d4bb0f32018-09-21 12:58:45 +01001334 invoke_instruction->SetResolvedMethod(method);
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001335 }
1336 } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001337 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001338 DCHECK(!method->IsProxyMethod());
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001339 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
1340 // better than an invoke-interface because:
1341 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
1342 // 2) We will not go to the conflict trampoline with an invoke-virtual.
1343 // TODO: Consider sharpening once it is not dependent on the compiler driver.
Nicolas Geoffray18ea1c92017-03-27 08:00:18 +00001344
1345 if (method->IsDefault() && !method->IsCopied()) {
1346 // Changing to invoke-virtual cannot be done on an original default method
1347 // since it's not in any vtable. Devirtualization by exact type/inline-cache
1348 // always uses a method in the iftable which is never an original default
1349 // method.
1350 // On the other hand, inlining an original default method by CHA is fine.
1351 DCHECK(cha_devirtualize);
1352 return false;
1353 }
1354
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001355 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001356 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001357 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Andreas Gampee2abbc62017-09-15 11:59:26 -07001358 if (dex_method_index == dex::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001359 return false;
1360 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001361 HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual(
1362 graph_->GetAllocator(),
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001363 invoke_instruction->GetNumberOfArguments(),
1364 invoke_instruction->GetType(),
1365 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001366 dex_method_index,
1367 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001368 method->GetMethodIndex());
1369 HInputsRef inputs = invoke_instruction->GetInputs();
1370 for (size_t index = 0; index != inputs.size(); ++index) {
1371 new_invoke->SetArgumentAt(index, inputs[index]);
1372 }
1373 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
1374 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001375 if (invoke_instruction->GetType() == DataType::Type::kReference) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001376 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
1377 }
1378 return_replacement = new_invoke;
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001379 // invoke_instruction is replaced with new_invoke.
1380 should_remove_invoke_instruction = true;
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +00001381 } else {
1382 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
1383 // compiler driver.
1384 return false;
1385 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001386 } else {
1387 // invoke_instruction is inlined.
1388 should_remove_invoke_instruction = true;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001389 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001390
Mingyao Yang063fc772016-08-02 11:02:54 -07001391 if (cha_devirtualize) {
1392 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
1393 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001394 if (return_replacement != nullptr) {
1395 invoke_instruction->ReplaceWith(return_replacement);
1396 }
Mingyao Yang6b1aebe2017-11-27 15:39:04 -08001397 if (should_remove_invoke_instruction) {
1398 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
1399 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001400 FixUpReturnReferenceType(method, return_replacement);
1401 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
1402 // Actual return value has a more specific type than the method's declared
1403 // return type. Run RTP again on the outer graph to propagate it.
1404 ReferenceTypePropagation(graph_,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001405 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001406 outer_compilation_unit_.GetDexCache(),
1407 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001408 /* is_first_run= */ false).Run();
David Brazdil94ab38f2016-06-21 17:48:19 +01001409 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001410 return true;
1411}
1412
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001413size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const {
1414 const HInliner* current = this;
1415 size_t count = 0;
1416 do {
1417 if (current->graph_->GetArtMethod() == method) {
1418 ++count;
1419 }
1420 current = current->parent_;
1421 } while (current != nullptr);
1422 return count;
1423}
1424
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001425static inline bool MayInline(const CompilerOptions& compiler_options,
1426 const DexFile& inlined_from,
1427 const DexFile& inlined_into) {
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001428 // We're not allowed to inline across dex files if we're the no-inline-from dex file.
1429 if (!IsSameDexFile(inlined_from, inlined_into) &&
1430 ContainsElement(compiler_options.GetNoInlineFromDexFile(), &inlined_from)) {
1431 return false;
1432 }
1433
1434 return true;
1435}
1436
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001437bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
1438 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001439 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001440 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001441 if (method->IsProxyMethod()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001442 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001443 << "Method " << method->PrettyMethod()
1444 << " is not inlined because of unimplemented inline support for proxy methods.";
1445 return false;
1446 }
1447
1448 if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001449 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001450 << "Method "
1451 << method->PrettyMethod()
1452 << " is not inlined because it has reached its recursive call budget.";
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001453 return false;
1454 }
1455
Jeff Haodcdc85b2015-12-04 14:06:18 -08001456 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
1457 // dex file here (though the transitivity of an inline chain would allow checking the calller).
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001458 if (!MayInline(codegen_->GetCompilerOptions(),
1459 *method->GetDexFile(),
1460 *outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001461 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001462 LOG_SUCCESS() << "Successfully replaced pattern of invoke "
1463 << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001464 MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001465 return true;
1466 }
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001467 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001468 << "Won't inline " << method->PrettyMethod() << " in "
1469 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
1470 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
1471 << method->GetDexFile()->GetLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001472 return false;
1473 }
1474
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001475 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
1476
David Sehr0225f8e2018-01-31 08:52:24 +00001477 CodeItemDataAccessor accessor(method->DexInstructionData());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001478
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001479 if (!accessor.HasCodeItem()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001480 LOG_FAIL_NO_STAT()
1481 << "Method " << method->PrettyMethod() << " is not inlined because it is native";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001482 return false;
1483 }
1484
Vladimir Marko213ee2d2018-06-22 11:56:34 +01001485 size_t inline_max_code_units = codegen_->GetCompilerOptions().GetInlineMaxCodeUnits();
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001486 if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001487 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001488 << "Method " << method->PrettyMethod()
1489 << " is not inlined because its code item is too big: "
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001490 << accessor.InsnsSizeInCodeUnits()
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001491 << " > "
1492 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001493 return false;
1494 }
1495
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001496 if (accessor.TriesSize() != 0) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001497 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001498 << "Method " << method->PrettyMethod() << " is not inlined because of try block";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001499 return false;
1500 }
1501
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001502 if (!method->IsCompilable()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001503 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001504 << "Method " << method->PrettyMethod()
1505 << " has soft failures un-handled by the compiler, so it cannot be inlined";
Aart Bik897df032018-02-07 13:29:11 -08001506 return false;
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001507 }
1508
Vladimir Marko2afaff72018-11-30 17:01:50 +00001509 if (IsMethodUnverified(codegen_->GetCompilerOptions(), method)) {
Aart Bik2c148f02018-02-02 14:30:35 -08001510 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified)
1511 << "Method " << method->PrettyMethod()
1512 << " couldn't be verified, so it cannot be inlined";
1513 return false;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001514 }
1515
Roland Levillain4c0eb422015-04-24 16:43:49 +01001516 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1517 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1518 // Case of a static method that cannot be inlined because it implicitly
1519 // requires an initialization check of its declaring class.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001520 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
1521 << "Method " << method->PrettyMethod()
1522 << " is not inlined because it is static and requires a clinit"
1523 << " check that cannot be emitted due to Dex cache limitations";
Roland Levillain4c0eb422015-04-24 16:43:49 +01001524 return false;
1525 }
1526
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001527 if (!TryBuildAndInlineHelper(
1528 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001529 return false;
1530 }
1531
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001532 LOG_SUCCESS() << method->PrettyMethod();
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001533 MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001534 return true;
1535}
1536
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001537static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1538 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001539 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001540 size_t input_index = 0;
1541 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1542 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001543 if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001544 ++i;
1545 DCHECK_NE(i, arg_vreg_index);
1546 }
1547 }
1548 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1549 return invoke_instruction->InputAt(input_index);
1550}
1551
1552// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1553bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1554 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001555 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001556 InlineMethod inline_method;
1557 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1558 return false;
1559 }
1560
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001561 switch (inline_method.opcode) {
1562 case kInlineOpNop:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001563 DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001564 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001565 break;
1566 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001567 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1568 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001569 break;
1570 case kInlineOpNonWideConst:
1571 if (resolved_method->GetShorty()[0] == 'L') {
1572 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001573 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001574 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001575 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001576 }
1577 break;
1578 case kInlineOpIGet: {
1579 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1580 if (data.method_is_static || data.object_arg != 0u) {
1581 // TODO: Needs null check.
1582 return false;
1583 }
1584 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001585 HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001586 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1587 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1588 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001589 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001590 break;
1591 }
1592 case kInlineOpIPut: {
1593 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1594 if (data.method_is_static || data.object_arg != 0u) {
1595 // TODO: Needs null check.
1596 return false;
1597 }
1598 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1599 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001600 HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001601 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1602 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1603 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1604 if (data.return_arg_plus1 != 0u) {
1605 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001606 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001607 }
1608 break;
1609 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001610 case kInlineOpConstructor: {
1611 const InlineConstructorData& data = inline_method.d.constructor_data;
1612 // Get the indexes to arrays for easier processing.
1613 uint16_t iput_field_indexes[] = {
1614 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1615 };
1616 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1617 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1618 // Count valid field indexes.
1619 size_t number_of_iputs = 0u;
1620 while (number_of_iputs != arraysize(iput_field_indexes) &&
1621 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1622 // Check that there are no duplicate valid field indexes.
1623 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1624 iput_field_indexes + arraysize(iput_field_indexes),
1625 iput_field_indexes[number_of_iputs]));
1626 ++number_of_iputs;
1627 }
1628 // Check that there are no valid field indexes in the rest of the array.
1629 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1630 iput_field_indexes + arraysize(iput_field_indexes),
1631 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1632
1633 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
Andreas Gampe3db70682018-12-26 15:12:03 -08001634 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction,
1635 /* arg_vreg_index= */ 0u);
Vladimir Marko354efa62016-02-04 19:46:56 +00001636 bool needs_constructor_barrier = false;
1637 for (size_t i = 0; i != number_of_iputs; ++i) {
1638 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001639 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001640 uint16_t field_index = iput_field_indexes[i];
Vladimir Markof44d36c2017-03-14 14:18:46 +00001641 bool is_final;
1642 HInstanceFieldSet* iput =
1643 CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final);
Vladimir Marko354efa62016-02-04 19:46:56 +00001644 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1645
1646 // Check whether the field is final. If it is, we need to add a barrier.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001647 if (is_final) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001648 needs_constructor_barrier = true;
1649 }
1650 }
1651 }
1652 if (needs_constructor_barrier) {
Vladimir Marko1a2a5cd2018-11-07 15:39:48 +00001653 // See DexCompilationUnit::RequiresConstructorBarrier for more details.
Igor Murashkind01745e2017-04-05 16:40:31 -07001654 DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence";
1655
1656 HConstructorFence* constructor_fence =
Vladimir Markoca6fff82017-10-03 14:49:14 +01001657 new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator());
Igor Murashkind01745e2017-04-05 16:40:31 -07001658 invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence,
1659 invoke_instruction);
Vladimir Marko354efa62016-02-04 19:46:56 +00001660 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001661 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001662 break;
1663 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001664 default:
1665 LOG(FATAL) << "UNREACHABLE";
1666 UNREACHABLE();
1667 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001668 return true;
1669}
1670
Vladimir Markof44d36c2017-03-14 14:18:46 +00001671HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index,
1672 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001673 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001674 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001675 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1676 ArtField* resolved_field =
Andreas Gampe3db70682018-12-26 15:12:03 -08001677 class_linker->LookupResolvedField(field_index, referrer, /* is_static= */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001678 DCHECK(resolved_field != nullptr);
Vladimir Markoca6fff82017-10-03 14:49:14 +01001679 HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001680 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001681 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001682 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001683 resolved_field->GetOffset(),
1684 resolved_field->IsVolatile(),
1685 field_index,
1686 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001687 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001688 // Read barrier generates a runtime call in slow path and we need a valid
1689 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
Andreas Gampe3db70682018-12-26 15:12:03 -08001690 /* dex_pc= */ 0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001691 if (iget->GetType() == DataType::Type::kReference) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001692 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
Vladimir Markof44d36c2017-03-14 14:18:46 +00001693 Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache());
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001694 ReferenceTypePropagation rtp(graph_,
1695 outer_compilation_unit_.GetClassLoader(),
1696 dex_cache,
1697 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001698 /* is_first_run= */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001699 rtp.Visit(iget);
1700 }
1701 return iget;
1702}
1703
Vladimir Markof44d36c2017-03-14 14:18:46 +00001704HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index,
1705 ArtMethod* referrer,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001706 HInstruction* obj,
Vladimir Markof44d36c2017-03-14 14:18:46 +00001707 HInstruction* value,
1708 bool* is_final)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001709 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markof44d36c2017-03-14 14:18:46 +00001710 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1711 ArtField* resolved_field =
Andreas Gampe3db70682018-12-26 15:12:03 -08001712 class_linker->LookupResolvedField(field_index, referrer, /* is_static= */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001713 DCHECK(resolved_field != nullptr);
Vladimir Markof44d36c2017-03-14 14:18:46 +00001714 if (is_final != nullptr) {
1715 // This information is needed only for constructors.
1716 DCHECK(referrer->IsConstructor());
1717 *is_final = resolved_field->IsFinal();
1718 }
Vladimir Markoca6fff82017-10-03 14:49:14 +01001719 HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet(
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001720 obj,
1721 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001722 resolved_field,
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001723 DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001724 resolved_field->GetOffset(),
1725 resolved_field->IsVolatile(),
1726 field_index,
1727 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Markof44d36c2017-03-14 14:18:46 +00001728 *referrer->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001729 // Read barrier generates a runtime call in slow path and we need a valid
1730 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
Andreas Gampe3db70682018-12-26 15:12:03 -08001731 /* dex_pc= */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001732 return iput;
1733}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001734
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001735template <typename T>
Vladimir Markoc524e9e2019-03-26 10:54:50 +00001736static inline Handle<T> NewHandleIfDifferent(ObjPtr<T> object,
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001737 Handle<T> hint,
1738 VariableSizedHandleScope* handles)
1739 REQUIRES_SHARED(Locks::mutator_lock_) {
1740 return (object != hint.Get()) ? handles->NewHandle(object) : hint;
1741}
1742
Vladimir Marko6be1dbd2018-11-13 13:09:51 +00001743static bool CanEncodeInlinedMethodInStackMap(const DexFile& caller_dex_file, ArtMethod* callee)
1744 REQUIRES_SHARED(Locks::mutator_lock_) {
1745 if (!Runtime::Current()->IsAotCompiler()) {
1746 // JIT can always encode methods in stack maps.
1747 return true;
1748 }
1749 if (IsSameDexFile(caller_dex_file, *callee->GetDexFile())) {
1750 return true;
1751 }
1752 // TODO(ngeoffray): Support more AOT cases for inlining:
1753 // - methods in multidex
1754 // - methods in boot image for on-device non-PIC compilation.
1755 return false;
1756}
1757
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001758bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1759 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001760 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001761 bool same_dex_file,
1762 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001763 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001764 ScopedObjectAccess soa(Thread::Current());
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08001765 const dex::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001766 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1767 uint32_t method_index = resolved_method->GetDexMethodIndex();
David Sehr0225f8e2018-01-31 08:52:24 +00001768 CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo());
Calin Juravle2e768302015-07-28 14:41:11 +00001769 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Vladimir Markob1d0ee12017-04-20 19:50:32 +01001770 Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(),
1771 caller_compilation_unit_.GetDexCache(),
1772 handles_);
1773 Handle<mirror::ClassLoader> class_loader =
1774 NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(),
1775 caller_compilation_unit_.GetClassLoader(),
1776 handles_);
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001777
Vladimir Markoa2c211c2018-11-01 09:50:52 +00001778 Handle<mirror::Class> compiling_class = handles_->NewHandle(resolved_method->GetDeclaringClass());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001779 DexCompilationUnit dex_compilation_unit(
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001780 class_loader,
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001781 class_linker,
1782 callee_dex_file,
1783 code_item,
1784 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1785 method_index,
1786 resolved_method->GetAccessFlags(),
Andreas Gampe3db70682018-12-26 15:12:03 -08001787 /* verified_method= */ nullptr,
Vladimir Markoa2c211c2018-11-01 09:50:52 +00001788 dex_cache,
1789 compiling_class);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001790
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001791 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001792 if (invoke_type == kInterface) {
1793 // We have statically resolved the dispatch. To please the class linker
1794 // at runtime, we change this call as if it was a virtual call.
1795 invoke_type = kVirtual;
1796 }
David Brazdil3f523062016-02-29 16:53:33 +00001797
Hans Boehm206348c2018-12-05 11:11:33 -08001798 bool caller_dead_reference_safe = graph_->IsDeadReferenceSafe();
1799 const dex::ClassDef& callee_class = resolved_method->GetClassDef();
1800 // MethodContainsRSensitiveAccess is currently slow, but HasDeadReferenceSafeAnnotation()
1801 // is currently rarely true.
1802 bool callee_dead_reference_safe =
1803 annotations::HasDeadReferenceSafeAnnotation(callee_dex_file, callee_class)
1804 && !annotations::MethodContainsRSensitiveAccess(callee_dex_file, callee_class, method_index);
1805
David Brazdil3f523062016-02-29 16:53:33 +00001806 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Vladimir Markoca6fff82017-10-03 14:49:14 +01001807 HGraph* callee_graph = new (graph_->GetAllocator()) HGraph(
1808 graph_->GetAllocator(),
1809 graph_->GetArenaStack(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001810 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001811 method_index,
Vladimir Markoa0431112018-06-25 09:32:54 +01001812 codegen_->GetCompilerOptions().GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001813 invoke_type,
Hans Boehm206348c2018-12-05 11:11:33 -08001814 callee_dead_reference_safe,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001815 graph_->IsDebuggable(),
Andreas Gampe3db70682018-12-26 15:12:03 -08001816 /* osr= */ false,
Nicolas Geoffraya48c3df2019-06-27 13:11:12 +00001817 /* is_shared_jit_code= */ graph_->IsCompilingForSharedJitCode(),
1818 /* start_instruction_id= */ caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001819 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001820
Vladimir Marko438709f2017-02-23 18:56:13 +00001821 // When they are needed, allocate `inline_stats_` on the Arena instead
Roland Levillaina8013fd2016-04-04 15:34:31 +01001822 // of on the stack, as Clang might produce a stack frame too large
1823 // for this function, that would not fit the requirements of the
1824 // `-Wframe-larger-than` option.
Vladimir Marko438709f2017-02-23 18:56:13 +00001825 if (stats_ != nullptr) {
1826 // Reuse one object for all inline attempts from this caller to keep Arena memory usage low.
1827 if (inline_stats_ == nullptr) {
Vladimir Markoca6fff82017-10-03 14:49:14 +01001828 void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc);
Vladimir Marko438709f2017-02-23 18:56:13 +00001829 inline_stats_ = new (storage) OptimizingCompilerStats;
1830 } else {
1831 inline_stats_->Reset();
1832 }
1833 }
David Brazdil5e8b1372015-01-23 14:39:08 +00001834 HGraphBuilder builder(callee_graph,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08001835 code_item_accessor,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001836 &dex_compilation_unit,
1837 &outer_compilation_unit_,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +00001838 codegen_,
Vladimir Marko438709f2017-02-23 18:56:13 +00001839 inline_stats_,
Nicolas Geoffray8eaa8e52017-11-13 17:47:50 +00001840 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001841 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001842
David Brazdildee58d62016-04-07 09:54:26 +00001843 if (builder.BuildGraph() != kAnalysisSuccess) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001844 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001845 << "Method " << callee_dex_file.PrettyMethod(method_index)
1846 << " could not be built, so cannot be inlined";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001847 return false;
1848 }
1849
Vladimir Markoa0431112018-06-25 09:32:54 +01001850 if (!RegisterAllocator::CanAllocateRegistersFor(
1851 *callee_graph, codegen_->GetCompilerOptions().GetInstructionSet())) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001852 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001853 << "Method " << callee_dex_file.PrettyMethod(method_index)
1854 << " cannot be inlined because of the register allocator";
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001855 return false;
1856 }
1857
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001858 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001859 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001860 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1861 !instructions.Done();
1862 instructions.Advance()) {
1863 HInstruction* current = instructions.Current();
1864 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001865 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001866 if (argument->IsNullConstant()) {
1867 current->ReplaceWith(callee_graph->GetNullConstant());
1868 } else if (argument->IsIntConstant()) {
1869 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1870 } else if (argument->IsLongConstant()) {
1871 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1872 } else if (argument->IsFloatConstant()) {
1873 current->ReplaceWith(
1874 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1875 } else if (argument->IsDoubleConstant()) {
1876 current->ReplaceWith(
1877 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01001878 } else if (argument->GetType() == DataType::Type::kReference) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001879 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1880 run_rtp = true;
1881 current->SetReferenceTypeInfo(receiver_type);
1882 } else {
1883 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1884 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001885 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1886 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001887 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001888 }
1889 }
1890
David Brazdil94ab38f2016-06-21 17:48:19 +01001891 // We have replaced formal arguments with actual arguments. If actual types
1892 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001893 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001894 ReferenceTypePropagation(callee_graph,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001895 outer_compilation_unit_.GetClassLoader(),
David Brazdil94ab38f2016-06-21 17:48:19 +01001896 dex_compilation_unit.GetDexCache(),
1897 handles_,
Andreas Gampe3db70682018-12-26 15:12:03 -08001898 /* is_first_run= */ false).Run();
David Brazdil94ab38f2016-06-21 17:48:19 +01001899 }
1900
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001901 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001902
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001903 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1904 if (exit_block == nullptr) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001905 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001906 << "Method " << callee_dex_file.PrettyMethod(method_index)
1907 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001908 return false;
1909 }
1910
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001911 bool has_one_return = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001912 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1913 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001914 if (invoke_instruction->GetBlock()->IsTryBlock()) {
1915 // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001916 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001917 << "Method " << callee_dex_file.PrettyMethod(method_index)
1918 << " could not be inlined because one branch always throws and"
1919 << " caller is in a try/catch block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001920 return false;
1921 } else if (graph_->GetExitBlock() == nullptr) {
1922 // TODO(ngeoffray): Support adding HExit in the caller graph.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001923 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001924 << "Method " << callee_dex_file.PrettyMethod(method_index)
1925 << " could not be inlined because one branch always throws and"
1926 << " caller does not have an exit block";
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001927 return false;
Nicolas Geoffray1eede6a2017-03-02 16:14:53 +00001928 } else if (graph_->HasIrreducibleLoops()) {
1929 // TODO(ngeoffray): Support re-computing loop information to graphs with
1930 // irreducible loops?
1931 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1932 << " could not be inlined because one branch always throws and"
1933 << " caller has irreducible loops";
1934 return false;
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001935 }
1936 } else {
1937 has_one_return = true;
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001938 }
1939 }
Nicolas Geoffrayfdb7d632017-02-08 15:07:18 +00001940
1941 if (!has_one_return) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001942 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001943 << "Method " << callee_dex_file.PrettyMethod(method_index)
1944 << " could not be inlined because it always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001945 return false;
1946 }
1947
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001948 size_t number_of_instructions = 0;
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001949 // Skip the entry block, it does not contain instructions that prevent inlining.
1950 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001951 if (block->IsLoopHeader()) {
1952 if (block->GetLoopInformation()->IsIrreducible()) {
1953 // Don't inline methods with irreducible loops, they could prevent some
1954 // optimizations to run.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001955 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001956 << "Method " << callee_dex_file.PrettyMethod(method_index)
1957 << " could not be inlined because it contains an irreducible loop";
David Sehrc757dec2016-11-04 15:48:34 -07001958 return false;
1959 }
1960 if (!block->GetLoopInformation()->HasExitEdge()) {
1961 // Don't inline methods with loops without exit, since they cause the
1962 // loop information to be computed incorrectly when updating after
1963 // inlining.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001964 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001965 << "Method " << callee_dex_file.PrettyMethod(method_index)
1966 << " could not be inlined because it contains a loop with no exit";
David Sehrc757dec2016-11-04 15:48:34 -07001967 return false;
1968 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001969 }
1970
1971 for (HInstructionIterator instr_it(block->GetInstructions());
1972 !instr_it.Done();
1973 instr_it.Advance()) {
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001974 if (++number_of_instructions >= inlining_budget_) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001975 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001976 << "Method " << callee_dex_file.PrettyMethod(method_index)
1977 << " is not inlined because the outer method has reached"
1978 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001979 return false;
1980 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001981 HInstruction* current = instr_it.Current();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001982 if (current->NeedsEnvironment() &&
1983 (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001984 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001985 << "Method " << callee_dex_file.PrettyMethod(method_index)
1986 << " is not inlined because its caller has reached"
1987 << " its environment budget limit.";
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001988 return false;
1989 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001990
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001991 if (current->NeedsEnvironment() &&
1992 !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(),
1993 resolved_method)) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00001994 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00001995 << "Method " << callee_dex_file.PrettyMethod(method_index)
1996 << " could not be inlined because " << current->DebugName()
1997 << " needs an environment, is in a different dex file"
1998 << ", and cannot be encoded in the stack maps.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001999 return false;
2000 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002001
Vladimir Markodc151b22015-10-15 18:02:30 +01002002 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Vladimir Markocd09e1f2017-11-24 15:02:40 +00002003 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002004 << "Method " << callee_dex_file.PrettyMethod(method_index)
2005 << " could not be inlined because " << current->DebugName()
2006 << " it is in a different dex file and requires access to the dex cache";
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002007 return false;
2008 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00002009
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00002010 if (current->IsUnresolvedStaticFieldGet() ||
2011 current->IsUnresolvedInstanceFieldGet() ||
2012 current->IsUnresolvedStaticFieldSet() ||
2013 current->IsUnresolvedInstanceFieldSet()) {
2014 // Entrypoint for unresolved fields does not handle inlined frames.
Vladimir Markocd09e1f2017-11-24 15:02:40 +00002015 LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint)
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002016 << "Method " << callee_dex_file.PrettyMethod(method_index)
2017 << " could not be inlined because it is using an unresolved"
2018 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00002019 return false;
2020 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002021 }
2022 }
David Brazdil3f523062016-02-29 16:53:33 +00002023 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
2024 << "No instructions can be added to the outer graph while inner graph is being built";
2025
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002026 // Inline the callee graph inside the caller graph.
David Brazdil3f523062016-02-29 16:53:33 +00002027 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
2028 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00002029 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002030 // Update our budget for other inlining attempts in `caller_graph`.
2031 total_number_of_instructions_ += number_of_instructions;
2032 UpdateInliningBudget();
David Brazdil3f523062016-02-29 16:53:33 +00002033
2034 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
2035 << "No instructions can be added to the inner graph during inlining into the outer graph";
2036
Vladimir Marko438709f2017-02-23 18:56:13 +00002037 if (stats_ != nullptr) {
2038 DCHECK(inline_stats_ != nullptr);
2039 inline_stats_->AddTo(stats_);
2040 }
2041
Hans Boehm206348c2018-12-05 11:11:33 -08002042 if (caller_dead_reference_safe && !callee_dead_reference_safe) {
2043 // Caller was dead reference safe, but is not anymore, since we inlined dead
2044 // reference unsafe code. Prior transformations remain valid, since they did not
2045 // affect the inlined code.
2046 graph_->MarkDeadReferenceUnsafe();
2047 }
2048
Vladimir Markobe10e8e2016-01-22 12:09:44 +00002049 return true;
2050}
Calin Juravle2e768302015-07-28 14:41:11 +00002051
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002052void HInliner::RunOptimizations(HGraph* callee_graph,
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08002053 const dex::CodeItem* code_item,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002054 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01002055 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
2056 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Vladimir Marko438709f2017-02-23 18:56:13 +00002057 HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner");
Andreas Gampeca620d72016-11-08 08:09:33 -08002058 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Vladimir Markobb089b62018-06-28 17:30:16 +01002059 InstructionSimplifier simplify(callee_graph, codegen_, inline_stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002060
2061 HOptimization* optimizations[] = {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002062 &simplify,
2063 &fold,
2064 &dce,
2065 };
2066
2067 for (size_t i = 0; i < arraysize(optimizations); ++i) {
2068 HOptimization* optimization = optimizations[i];
2069 optimization->Run();
2070 }
2071
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002072 // Bail early for pathological cases on the environment (for example recursive calls,
2073 // or too large environment).
2074 if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) {
2075 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2076 << " will not be inlined because the outer method has reached"
2077 << " its environment budget limit.";
2078 return;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002079 }
2080
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002081 // Bail early if we know we already are over the limit.
2082 size_t number_of_instructions = CountNumberOfInstructions(callee_graph);
2083 if (number_of_instructions > inlining_budget_) {
2084 LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod()
2085 << " will not be inlined because the outer method has reached"
2086 << " its instruction budget limit. " << number_of_instructions;
2087 return;
2088 }
2089
Mathieu Chartier698ebbc2018-01-05 11:00:42 -08002090 CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item);
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002091 HInliner inliner(callee_graph,
2092 outermost_graph_,
2093 codegen_,
2094 outer_compilation_unit_,
2095 dex_compilation_unit,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002096 handles_,
2097 inline_stats_,
Mathieu Chartier808c7a52017-12-15 11:19:33 -08002098 total_number_of_dex_registers_ + accessor.RegistersSize(),
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +00002099 total_number_of_instructions_ + number_of_instructions,
2100 this,
2101 depth_ + 1);
2102 inliner.Run();
Roland Levillaina3aef2e2016-04-06 17:45:58 +01002103}
2104
David Brazdil94ab38f2016-06-21 17:48:19 +01002105static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
2106 bool declared_can_be_null,
2107 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07002108 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002109 if (declared_can_be_null && !actual_obj->CanBeNull()) {
2110 return true;
2111 }
2112
2113 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
2114 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00002115 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01002116}
2117
Vladimir Markob45528c2017-07-27 14:14:28 +01002118ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002119 return ReferenceTypePropagation::IsAdmissible(klass)
2120 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
2121 : graph_->GetInexactObjectRti();
2122}
2123
2124bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
2125 // If this is an instance call, test whether the type of the `this` argument
2126 // is more specific than the class which declares the method.
2127 if (!resolved_method->IsStatic()) {
2128 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
Andreas Gampe3db70682018-12-26 15:12:03 -08002129 /* declared_can_be_null= */ false,
David Brazdil94ab38f2016-06-21 17:48:19 +01002130 invoke_instruction->InputAt(0u))) {
2131 return true;
2132 }
2133 }
2134
David Brazdil94ab38f2016-06-21 17:48:19 +01002135 // Iterate over the list of parameter types and test whether any of the
2136 // actual inputs has a more specific reference type than the type declared in
2137 // the signature.
Andreas Gampe3f1dcd32018-12-28 09:39:56 -08002138 const dex::TypeList* param_list = resolved_method->GetParameterTypeList();
David Brazdil94ab38f2016-06-21 17:48:19 +01002139 for (size_t param_idx = 0,
2140 input_idx = resolved_method->IsStatic() ? 0 : 1,
2141 e = (param_list == nullptr ? 0 : param_list->Size());
2142 param_idx < e;
2143 ++param_idx, ++input_idx) {
2144 HInstruction* input = invoke_instruction->InputAt(input_idx);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002145 if (input->GetType() == DataType::Type::kReference) {
Vladimir Markob45528c2017-07-27 14:14:28 +01002146 ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex(
2147 param_list->GetTypeItem(param_idx).type_idx_);
David Brazdil94ab38f2016-06-21 17:48:19 +01002148 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
Andreas Gampe3db70682018-12-26 15:12:03 -08002149 /* declared_can_be_null= */ true,
David Brazdil94ab38f2016-06-21 17:48:19 +01002150 input)) {
2151 return true;
2152 }
2153 }
2154 }
2155
2156 return false;
2157}
2158
2159bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
2160 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08002161 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00002162 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002163 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil94ab38f2016-06-21 17:48:19 +01002164 // Test if the return type is a refinement of the declared return type.
2165 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
Andreas Gampe3db70682018-12-26 15:12:03 -08002166 /* declared_can_be_null= */ true,
David Brazdil94ab38f2016-06-21 17:48:19 +01002167 return_replacement)) {
2168 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002169 } else if (return_replacement->IsInstanceFieldGet()) {
2170 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002171 if (field_get->GetFieldInfo().GetField() ==
Vladimir Markob4eb1b12018-05-24 11:09:38 +01002172 GetClassRoot<mirror::Object>()->GetInstanceField(0)) {
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00002173 return true;
2174 }
David Brazdil94ab38f2016-06-21 17:48:19 +01002175 }
2176 } else if (return_replacement->IsInstanceOf()) {
2177 // Inlining InstanceOf into an If may put a tighter bound on reference types.
2178 return true;
2179 }
2180 }
2181
2182 return false;
2183}
2184
2185void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
2186 HInstruction* return_replacement) {
2187 if (return_replacement != nullptr) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +01002188 if (return_replacement->GetType() == DataType::Type::kReference) {
David Brazdil4833f5a2015-12-16 10:37:39 +00002189 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
2190 // Make sure that we have a valid type for the return. We may get an invalid one when
2191 // we inline invokes with multiple branches and create a Phi for the result.
2192 // TODO: we could be more precise by merging the phi inputs but that requires
2193 // some functionality from the reference type propagation.
2194 DCHECK(return_replacement->IsPhi());
Vladimir Markob45528c2017-07-27 14:14:28 +01002195 ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType();
David Brazdil94ab38f2016-06-21 17:48:19 +01002196 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01002197 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00002198 }
Calin Juravle2e768302015-07-28 14:41:11 +00002199 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002200}
2201
2202} // namespace art