blob: abe0aa0249cbf0574f26703c531bd2b0abc999a5 [file] [log] [blame]
Elliott Hughes8daa0922011-09-11 13:46:25 -07001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "mutex.h"
18
19#include <errno.h>
Ian Rogersc604d732012-10-14 16:09:54 -070020#include <sys/time.h>
Elliott Hughes8daa0922011-09-11 13:46:25 -070021
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -070022#include "atomic.h"
Elliott Hughes07ed66b2012-12-12 18:34:25 -080023#include "base/logging.h"
Ian Rogers693ff612013-02-01 10:56:12 -080024#include "mutex-inl.h"
Elliott Hughes6b355752012-01-13 16:49:08 -080025#include "runtime.h"
Ian Rogersc604d732012-10-14 16:09:54 -070026#include "scoped_thread_state_change.h"
Ian Rogers04d7aa92013-03-16 14:29:17 -070027#include "thread-inl.h"
Elliott Hughesffb465f2012-03-01 18:46:05 -080028#include "utils.h"
Elliott Hughes8daa0922011-09-11 13:46:25 -070029
30namespace art {
31
Ian Rogers719d1a32014-03-06 12:13:39 -080032Mutex* Locks::abort_lock_ = nullptr;
Andreas Gampe74240812014-04-17 10:35:09 -070033Mutex* Locks::allocated_monitor_ids_lock_ = nullptr;
Chao-ying Fu9e369312014-05-21 11:20:52 -070034Mutex* Locks::allocated_thread_ids_lock_ = nullptr;
Ian Rogers719d1a32014-03-06 12:13:39 -080035Mutex* Locks::breakpoint_lock_ = nullptr;
Ian Rogers719d1a32014-03-06 12:13:39 -080036ReaderWriterMutex* Locks::classlinker_classes_lock_ = nullptr;
37ReaderWriterMutex* Locks::heap_bitmap_lock_ = nullptr;
Ian Rogers68d8b422014-07-17 11:09:10 -070038Mutex* Locks::jni_libraries_lock_ = nullptr;
Ian Rogers719d1a32014-03-06 12:13:39 -080039Mutex* Locks::logging_lock_ = nullptr;
Hiroshi Yamauchi3eed93d2014-06-04 11:43:59 -070040Mutex* Locks::mem_maps_lock_ = nullptr;
Chao-ying Fu9e369312014-05-21 11:20:52 -070041Mutex* Locks::modify_ldt_lock_ = nullptr;
Ian Rogers719d1a32014-03-06 12:13:39 -080042ReaderWriterMutex* Locks::mutator_lock_ = nullptr;
43Mutex* Locks::runtime_shutdown_lock_ = nullptr;
44Mutex* Locks::thread_list_lock_ = nullptr;
Ian Rogersf3d874c2014-07-17 18:52:42 -070045Mutex* Locks::thread_list_suspend_thread_lock_ = nullptr;
Ian Rogers719d1a32014-03-06 12:13:39 -080046Mutex* Locks::thread_suspend_count_lock_ = nullptr;
47Mutex* Locks::trace_lock_ = nullptr;
48Mutex* Locks::profiler_lock_ = nullptr;
49Mutex* Locks::unexpected_signal_lock_ = nullptr;
50Mutex* Locks::intern_table_lock_ = nullptr;
51
52struct AllMutexData {
53 // A guard for all_mutexes_ that's not a mutex (Mutexes must CAS to acquire and busy wait).
54 Atomic<const BaseMutex*> all_mutexes_guard;
55 // All created mutexes guarded by all_mutexes_guard_.
56 std::set<BaseMutex*>* all_mutexes;
57 AllMutexData() : all_mutexes(NULL) {}
58};
59static struct AllMutexData gAllMutexData[kAllMutexDataSize];
60
Ian Rogersc604d732012-10-14 16:09:54 -070061#if ART_USE_FUTEXES
62static bool ComputeRelativeTimeSpec(timespec* result_ts, const timespec& lhs, const timespec& rhs) {
Brian Carlstromfb6996f2013-07-18 18:21:14 -070063 const int32_t one_sec = 1000 * 1000 * 1000; // one second in nanoseconds.
Ian Rogersc604d732012-10-14 16:09:54 -070064 result_ts->tv_sec = lhs.tv_sec - rhs.tv_sec;
65 result_ts->tv_nsec = lhs.tv_nsec - rhs.tv_nsec;
66 if (result_ts->tv_nsec < 0) {
67 result_ts->tv_sec--;
68 result_ts->tv_nsec += one_sec;
69 } else if (result_ts->tv_nsec > one_sec) {
70 result_ts->tv_sec++;
71 result_ts->tv_nsec -= one_sec;
72 }
73 return result_ts->tv_sec < 0;
74}
75#endif
76
Ian Rogers56edc432013-01-18 16:51:51 -080077class ScopedAllMutexesLock {
78 public:
Brian Carlstrom93ba8932013-07-17 21:31:49 -070079 explicit ScopedAllMutexesLock(const BaseMutex* mutex) : mutex_(mutex) {
Ian Rogers3e5cf302014-05-20 16:40:37 -070080 while (!gAllMutexData->all_mutexes_guard.CompareExchangeWeakAcquire(0, mutex)) {
Ian Rogers56edc432013-01-18 16:51:51 -080081 NanoSleep(100);
82 }
83 }
84 ~ScopedAllMutexesLock() {
Ian Rogers3e5cf302014-05-20 16:40:37 -070085 while (!gAllMutexData->all_mutexes_guard.CompareExchangeWeakRelease(mutex_, 0)) {
Ian Rogers56edc432013-01-18 16:51:51 -080086 NanoSleep(100);
87 }
88 }
89 private:
90 const BaseMutex* const mutex_;
91};
Ian Rogers56edc432013-01-18 16:51:51 -080092
93BaseMutex::BaseMutex(const char* name, LockLevel level) : level_(level), name_(name) {
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -070094 if (kLogLockContentions) {
95 ScopedAllMutexesLock mu(this);
Ian Rogersd9c4fc92013-10-01 19:45:43 -070096 std::set<BaseMutex*>** all_mutexes_ptr = &gAllMutexData->all_mutexes;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -070097 if (*all_mutexes_ptr == NULL) {
98 // We leak the global set of all mutexes to avoid ordering issues in global variable
99 // construction/destruction.
100 *all_mutexes_ptr = new std::set<BaseMutex*>();
101 }
102 (*all_mutexes_ptr)->insert(this);
Ian Rogers56edc432013-01-18 16:51:51 -0800103 }
Ian Rogers56edc432013-01-18 16:51:51 -0800104}
105
106BaseMutex::~BaseMutex() {
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700107 if (kLogLockContentions) {
108 ScopedAllMutexesLock mu(this);
Ian Rogersd9c4fc92013-10-01 19:45:43 -0700109 gAllMutexData->all_mutexes->erase(this);
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700110 }
Ian Rogers56edc432013-01-18 16:51:51 -0800111}
112
113void BaseMutex::DumpAll(std::ostream& os) {
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700114 if (kLogLockContentions) {
115 os << "Mutex logging:\n";
116 ScopedAllMutexesLock mu(reinterpret_cast<const BaseMutex*>(-1));
Ian Rogersd9c4fc92013-10-01 19:45:43 -0700117 std::set<BaseMutex*>* all_mutexes = gAllMutexData->all_mutexes;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700118 if (all_mutexes == NULL) {
119 // No mutexes have been created yet during at startup.
120 return;
121 }
122 typedef std::set<BaseMutex*>::const_iterator It;
Ian Rogersd9c4fc92013-10-01 19:45:43 -0700123 os << "(Contended)\n";
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700124 for (It it = all_mutexes->begin(); it != all_mutexes->end(); ++it) {
125 BaseMutex* mutex = *it;
126 if (mutex->HasEverContended()) {
127 mutex->Dump(os);
128 os << "\n";
129 }
130 }
131 os << "(Never contented)\n";
132 for (It it = all_mutexes->begin(); it != all_mutexes->end(); ++it) {
133 BaseMutex* mutex = *it;
134 if (!mutex->HasEverContended()) {
135 mutex->Dump(os);
136 os << "\n";
137 }
138 }
Ian Rogers56edc432013-01-18 16:51:51 -0800139 }
Ian Rogers56edc432013-01-18 16:51:51 -0800140}
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700141
Ian Rogers81d425b2012-09-27 16:03:43 -0700142void BaseMutex::CheckSafeToWait(Thread* self) {
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700143 if (self == NULL) {
144 CheckUnattachedThread(level_);
145 return;
146 }
Ian Rogers25fd14b2012-09-05 10:56:38 -0700147 if (kDebugLocking) {
Ian Rogersd9c4fc92013-10-01 19:45:43 -0700148 CHECK(self->GetHeldMutex(level_) == this || level_ == kMonitorLock)
149 << "Waiting on unacquired mutex: " << name_;
Ian Rogers25fd14b2012-09-05 10:56:38 -0700150 bool bad_mutexes_held = false;
Elliott Hughes0f827162013-02-26 12:12:58 -0800151 for (int i = kLockLevelCount - 1; i >= 0; --i) {
Ian Rogers25fd14b2012-09-05 10:56:38 -0700152 if (i != level_) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700153 BaseMutex* held_mutex = self->GetHeldMutex(static_cast<LockLevel>(i));
Ian Rogersf3d874c2014-07-17 18:52:42 -0700154 // We expect waits to happen while holding the thread list suspend thread lock.
155 if (held_mutex != NULL && i != kThreadListSuspendThreadLock) {
Elliott Hughes0f827162013-02-26 12:12:58 -0800156 LOG(ERROR) << "Holding \"" << held_mutex->name_ << "\" "
157 << "(level " << LockLevel(i) << ") while performing wait on "
158 << "\"" << name_ << "\" (level " << level_ << ")";
Ian Rogers25fd14b2012-09-05 10:56:38 -0700159 bad_mutexes_held = true;
160 }
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700161 }
162 }
Ian Rogers25fd14b2012-09-05 10:56:38 -0700163 CHECK(!bad_mutexes_held);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700164 }
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700165}
166
Ian Rogers37f3c962014-07-17 11:25:30 -0700167void BaseMutex::ContentionLogData::AddToWaitTime(uint64_t value) {
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700168 if (kLogLockContentions) {
169 // Atomically add value to wait_time.
Ian Rogers37f3c962014-07-17 11:25:30 -0700170 wait_time.FetchAndAddSequentiallyConsistent(value);
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700171 }
172}
173
Brian Carlstrom0de79852013-07-25 22:29:58 -0700174void BaseMutex::RecordContention(uint64_t blocked_tid,
175 uint64_t owner_tid,
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700176 uint64_t nano_time_blocked) {
177 if (kLogLockContentions) {
Ian Rogers3e5cf302014-05-20 16:40:37 -0700178 ContentionLogData* data = contention_log_data_;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700179 ++(data->contention_count);
180 data->AddToWaitTime(nano_time_blocked);
181 ContentionLogEntry* log = data->contention_log;
182 // This code is intentionally racy as it is only used for diagnostics.
Ian Rogers3e5cf302014-05-20 16:40:37 -0700183 uint32_t slot = data->cur_content_log_entry.LoadRelaxed();
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700184 if (log[slot].blocked_tid == blocked_tid &&
185 log[slot].owner_tid == blocked_tid) {
186 ++log[slot].count;
187 } else {
188 uint32_t new_slot;
189 do {
Ian Rogers3e5cf302014-05-20 16:40:37 -0700190 slot = data->cur_content_log_entry.LoadRelaxed();
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700191 new_slot = (slot + 1) % kContentionLogSize;
Ian Rogers3e5cf302014-05-20 16:40:37 -0700192 } while (!data->cur_content_log_entry.CompareExchangeWeakRelaxed(slot, new_slot));
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700193 log[new_slot].blocked_tid = blocked_tid;
194 log[new_slot].owner_tid = owner_tid;
Ian Rogers3e5cf302014-05-20 16:40:37 -0700195 log[new_slot].count.StoreRelaxed(1);
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700196 }
Ian Rogers56edc432013-01-18 16:51:51 -0800197 }
Ian Rogers56edc432013-01-18 16:51:51 -0800198}
199
Ian Rogers56edc432013-01-18 16:51:51 -0800200void BaseMutex::DumpContention(std::ostream& os) const {
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700201 if (kLogLockContentions) {
Ian Rogers3e5cf302014-05-20 16:40:37 -0700202 const ContentionLogData* data = contention_log_data_;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700203 const ContentionLogEntry* log = data->contention_log;
Ian Rogers37f3c962014-07-17 11:25:30 -0700204 uint64_t wait_time = data->wait_time.LoadRelaxed();
Ian Rogers3e5cf302014-05-20 16:40:37 -0700205 uint32_t contention_count = data->contention_count.LoadRelaxed();
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700206 if (contention_count == 0) {
207 os << "never contended";
208 } else {
209 os << "contended " << contention_count
Mathieu Chartier73d1e172014-04-11 17:53:48 -0700210 << " total wait of contender " << PrettyDuration(wait_time)
211 << " average " << PrettyDuration(wait_time / contention_count);
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700212 SafeMap<uint64_t, size_t> most_common_blocker;
213 SafeMap<uint64_t, size_t> most_common_blocked;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700214 for (size_t i = 0; i < kContentionLogSize; ++i) {
215 uint64_t blocked_tid = log[i].blocked_tid;
216 uint64_t owner_tid = log[i].owner_tid;
Ian Rogers3e5cf302014-05-20 16:40:37 -0700217 uint32_t count = log[i].count.LoadRelaxed();
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700218 if (count > 0) {
Mathieu Chartier73d1e172014-04-11 17:53:48 -0700219 auto it = most_common_blocked.find(blocked_tid);
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700220 if (it != most_common_blocked.end()) {
221 most_common_blocked.Overwrite(blocked_tid, it->second + count);
222 } else {
223 most_common_blocked.Put(blocked_tid, count);
224 }
225 it = most_common_blocker.find(owner_tid);
226 if (it != most_common_blocker.end()) {
227 most_common_blocker.Overwrite(owner_tid, it->second + count);
228 } else {
229 most_common_blocker.Put(owner_tid, count);
230 }
Ian Rogers56edc432013-01-18 16:51:51 -0800231 }
232 }
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700233 uint64_t max_tid = 0;
234 size_t max_tid_count = 0;
Mathieu Chartier73d1e172014-04-11 17:53:48 -0700235 for (const auto& pair : most_common_blocked) {
236 if (pair.second > max_tid_count) {
237 max_tid = pair.first;
238 max_tid_count = pair.second;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700239 }
Ian Rogers56edc432013-01-18 16:51:51 -0800240 }
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700241 if (max_tid != 0) {
242 os << " sample shows most blocked tid=" << max_tid;
Ian Rogers56edc432013-01-18 16:51:51 -0800243 }
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700244 max_tid = 0;
245 max_tid_count = 0;
Mathieu Chartier73d1e172014-04-11 17:53:48 -0700246 for (const auto& pair : most_common_blocker) {
247 if (pair.second > max_tid_count) {
248 max_tid = pair.first;
249 max_tid_count = pair.second;
Hiroshi Yamauchi1afde132013-08-06 17:09:30 -0700250 }
251 }
252 if (max_tid != 0) {
253 os << " sample shows tid=" << max_tid << " owning during this time";
254 }
Ian Rogers56edc432013-01-18 16:51:51 -0800255 }
256 }
Ian Rogers56edc432013-01-18 16:51:51 -0800257}
258
259
Ian Rogers81d425b2012-09-27 16:03:43 -0700260Mutex::Mutex(const char* name, LockLevel level, bool recursive)
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700261 : BaseMutex(name, level), recursive_(recursive), recursion_count_(0) {
Ian Rogersc604d732012-10-14 16:09:54 -0700262#if ART_USE_FUTEXES
Ian Rogersc7190692014-07-08 23:50:26 -0700263 DCHECK_EQ(0, state_.LoadRelaxed());
Ian Rogers3e5cf302014-05-20 16:40:37 -0700264 DCHECK_EQ(0, num_contenders_.LoadRelaxed());
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700265#else
Ian Rogersc5f17732014-06-05 20:48:42 -0700266 CHECK_MUTEX_CALL(pthread_mutex_init, (&mutex_, nullptr));
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700267#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700268 exclusive_owner_ = 0;
Elliott Hughes8daa0922011-09-11 13:46:25 -0700269}
270
271Mutex::~Mutex() {
Ian Rogersc604d732012-10-14 16:09:54 -0700272#if ART_USE_FUTEXES
Ian Rogersc7190692014-07-08 23:50:26 -0700273 if (state_.LoadRelaxed() != 0) {
Ian Rogersc604d732012-10-14 16:09:54 -0700274 Runtime* runtime = Runtime::Current();
Mathieu Chartier590fee92013-09-13 13:46:47 -0700275 bool shutting_down = runtime == nullptr || runtime->IsShuttingDown(Thread::Current());
Ian Rogersc604d732012-10-14 16:09:54 -0700276 LOG(shutting_down ? WARNING : FATAL) << "destroying mutex with owner: " << exclusive_owner_;
277 } else {
278 CHECK_EQ(exclusive_owner_, 0U) << "unexpectedly found an owner on unlocked mutex " << name_;
Ian Rogersc7190692014-07-08 23:50:26 -0700279 CHECK_EQ(num_contenders_.LoadSequentiallyConsistent(), 0)
Ian Rogers3e5cf302014-05-20 16:40:37 -0700280 << "unexpectedly found a contender on mutex " << name_;
Ian Rogersc604d732012-10-14 16:09:54 -0700281 }
282#else
Elliott Hughese62934d2012-04-09 11:24:29 -0700283 // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread
284 // may still be using locks.
Elliott Hughes6b355752012-01-13 16:49:08 -0800285 int rc = pthread_mutex_destroy(&mutex_);
286 if (rc != 0) {
287 errno = rc;
Elliott Hughesb3bd5f02012-03-08 21:05:27 -0800288 // TODO: should we just not log at all if shutting down? this could be the logging mutex!
Ian Rogers50b35e22012-10-04 10:09:15 -0700289 MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_);
Ian Rogers120f1c72012-09-28 17:17:10 -0700290 Runtime* runtime = Runtime::Current();
Mathieu Chartier34e82932013-11-12 18:22:47 -0800291 bool shutting_down = (runtime == NULL) || runtime->IsShuttingDownLocked();
Elliott Hughes6b355752012-01-13 16:49:08 -0800292 PLOG(shutting_down ? WARNING : FATAL) << "pthread_mutex_destroy failed for " << name_;
293 }
Ian Rogersc604d732012-10-14 16:09:54 -0700294#endif
Elliott Hughes8daa0922011-09-11 13:46:25 -0700295}
296
Ian Rogers81d425b2012-09-27 16:03:43 -0700297void Mutex::ExclusiveLock(Thread* self) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700298 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers25fd14b2012-09-05 10:56:38 -0700299 if (kDebugLocking && !recursive_) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700300 AssertNotHeld(self);
Ian Rogers25fd14b2012-09-05 10:56:38 -0700301 }
Ian Rogers81d425b2012-09-27 16:03:43 -0700302 if (!recursive_ || !IsExclusiveHeld(self)) {
Ian Rogersc604d732012-10-14 16:09:54 -0700303#if ART_USE_FUTEXES
304 bool done = false;
305 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700306 int32_t cur_state = state_.LoadRelaxed();
Hiroshi Yamauchi967a0ad2013-09-10 16:24:21 -0700307 if (LIKELY(cur_state == 0)) {
Ian Rogersc7190692014-07-08 23:50:26 -0700308 // Change state from 0 to 1 and impose load/store ordering appropriate for lock acquisition.
309 done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, 1 /* new state */);
Ian Rogersc604d732012-10-14 16:09:54 -0700310 } else {
311 // Failed to acquire, hang up.
Hiroshi Yamauchib3733082013-08-12 17:28:49 -0700312 ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid());
Ian Rogersb122a4b2013-11-19 18:00:50 -0800313 num_contenders_++;
Ian Rogersc7190692014-07-08 23:50:26 -0700314 if (futex(state_.Address(), FUTEX_WAIT, 1, NULL, NULL, 0) != 0) {
Brian Carlstrom0de79852013-07-25 22:29:58 -0700315 // EAGAIN and EINTR both indicate a spurious failure, try again from the beginning.
316 // We don't use TEMP_FAILURE_RETRY so we can intentionally retry to acquire the lock.
317 if ((errno != EAGAIN) && (errno != EINTR)) {
Ian Rogersc604d732012-10-14 16:09:54 -0700318 PLOG(FATAL) << "futex wait failed for " << name_;
319 }
320 }
Ian Rogersb122a4b2013-11-19 18:00:50 -0800321 num_contenders_--;
Ian Rogersc604d732012-10-14 16:09:54 -0700322 }
Brian Carlstromdf629502013-07-17 22:39:56 -0700323 } while (!done);
Ian Rogersc7190692014-07-08 23:50:26 -0700324 DCHECK_EQ(state_.LoadRelaxed(), 1);
Ian Rogersc604d732012-10-14 16:09:54 -0700325#else
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700326 CHECK_MUTEX_CALL(pthread_mutex_lock, (&mutex_));
Ian Rogersc604d732012-10-14 16:09:54 -0700327#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700328 DCHECK_EQ(exclusive_owner_, 0U);
329 exclusive_owner_ = SafeGetTid(self);
Ian Rogers81d425b2012-09-27 16:03:43 -0700330 RegisterAsLocked(self);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700331 }
332 recursion_count_++;
Ian Rogers25fd14b2012-09-05 10:56:38 -0700333 if (kDebugLocking) {
334 CHECK(recursion_count_ == 1 || recursive_) << "Unexpected recursion count on mutex: "
335 << name_ << " " << recursion_count_;
Ian Rogers81d425b2012-09-27 16:03:43 -0700336 AssertHeld(self);
Ian Rogers25fd14b2012-09-05 10:56:38 -0700337 }
Elliott Hughes8daa0922011-09-11 13:46:25 -0700338}
339
Ian Rogers81d425b2012-09-27 16:03:43 -0700340bool Mutex::ExclusiveTryLock(Thread* self) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700341 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers25fd14b2012-09-05 10:56:38 -0700342 if (kDebugLocking && !recursive_) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700343 AssertNotHeld(self);
Ian Rogers25fd14b2012-09-05 10:56:38 -0700344 }
Ian Rogers81d425b2012-09-27 16:03:43 -0700345 if (!recursive_ || !IsExclusiveHeld(self)) {
Ian Rogersc604d732012-10-14 16:09:54 -0700346#if ART_USE_FUTEXES
347 bool done = false;
348 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700349 int32_t cur_state = state_.LoadRelaxed();
Ian Rogersc604d732012-10-14 16:09:54 -0700350 if (cur_state == 0) {
Ian Rogersc7190692014-07-08 23:50:26 -0700351 // Change state from 0 to 1 and impose load/store ordering appropriate for lock acquisition.
352 done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, 1 /* new state */);
Ian Rogersc604d732012-10-14 16:09:54 -0700353 } else {
354 return false;
355 }
Brian Carlstromdf629502013-07-17 22:39:56 -0700356 } while (!done);
Ian Rogersc7190692014-07-08 23:50:26 -0700357 DCHECK_EQ(state_.LoadRelaxed(), 1);
Ian Rogersc604d732012-10-14 16:09:54 -0700358#else
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700359 int result = pthread_mutex_trylock(&mutex_);
360 if (result == EBUSY) {
361 return false;
362 }
363 if (result != 0) {
364 errno = result;
365 PLOG(FATAL) << "pthread_mutex_trylock failed for " << name_;
366 }
Ian Rogersc604d732012-10-14 16:09:54 -0700367#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700368 DCHECK_EQ(exclusive_owner_, 0U);
369 exclusive_owner_ = SafeGetTid(self);
Ian Rogers81d425b2012-09-27 16:03:43 -0700370 RegisterAsLocked(self);
Elliott Hughes8daa0922011-09-11 13:46:25 -0700371 }
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700372 recursion_count_++;
Ian Rogers25fd14b2012-09-05 10:56:38 -0700373 if (kDebugLocking) {
374 CHECK(recursion_count_ == 1 || recursive_) << "Unexpected recursion count on mutex: "
375 << name_ << " " << recursion_count_;
Ian Rogers81d425b2012-09-27 16:03:43 -0700376 AssertHeld(self);
Ian Rogers25fd14b2012-09-05 10:56:38 -0700377 }
Elliott Hughes8daa0922011-09-11 13:46:25 -0700378 return true;
379}
380
Ian Rogers81d425b2012-09-27 16:03:43 -0700381void Mutex::ExclusiveUnlock(Thread* self) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700382 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers81d425b2012-09-27 16:03:43 -0700383 AssertHeld(self);
Ian Rogersc5f17732014-06-05 20:48:42 -0700384 DCHECK_NE(exclusive_owner_, 0U);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700385 recursion_count_--;
386 if (!recursive_ || recursion_count_ == 0) {
Ian Rogers25fd14b2012-09-05 10:56:38 -0700387 if (kDebugLocking) {
388 CHECK(recursion_count_ == 0 || recursive_) << "Unexpected recursion count on mutex: "
389 << name_ << " " << recursion_count_;
390 }
Ian Rogers81d425b2012-09-27 16:03:43 -0700391 RegisterAsUnlocked(self);
Ian Rogersc604d732012-10-14 16:09:54 -0700392#if ART_USE_FUTEXES
Ian Rogersc5f17732014-06-05 20:48:42 -0700393 bool done = false;
394 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700395 int32_t cur_state = state_.LoadRelaxed();
Ian Rogersc5f17732014-06-05 20:48:42 -0700396 if (LIKELY(cur_state == 1)) {
Ian Rogersc5f17732014-06-05 20:48:42 -0700397 // We're no longer the owner.
398 exclusive_owner_ = 0;
Ian Rogersc7190692014-07-08 23:50:26 -0700399 // Change state to 0 and impose load/store ordering appropriate for lock release.
400 // Note, the relaxed loads below musn't reorder before the CompareExchange.
401 // TODO: the ordering here is non-trivial as state is split across 3 fields, fix by placing
402 // a status bit into the state on contention.
403 done = state_.CompareExchangeWeakSequentiallyConsistent(cur_state, 0 /* new state */);
Ian Rogersc5f17732014-06-05 20:48:42 -0700404 if (LIKELY(done)) { // Spurious fail?
Ian Rogersc7190692014-07-08 23:50:26 -0700405 // Wake a contender.
Ian Rogersc5f17732014-06-05 20:48:42 -0700406 if (UNLIKELY(num_contenders_.LoadRelaxed() > 0)) {
Ian Rogersc7190692014-07-08 23:50:26 -0700407 futex(state_.Address(), FUTEX_WAKE, 1, NULL, NULL, 0);
Ian Rogersc5f17732014-06-05 20:48:42 -0700408 }
409 }
410 } else {
411 // Logging acquires the logging lock, avoid infinite recursion in that case.
412 if (this != Locks::logging_lock_) {
413 LOG(FATAL) << "Unexpected state_ in unlock " << cur_state << " for " << name_;
414 } else {
415 LogMessageData data(__FILE__, __LINE__, INTERNAL_FATAL, -1);
416 LogMessage::LogLine(data, StringPrintf("Unexpected state_ %d in unlock for %s",
417 cur_state, name_).c_str());
418 _exit(1);
Ian Rogersc604d732012-10-14 16:09:54 -0700419 }
420 }
Ian Rogersc5f17732014-06-05 20:48:42 -0700421 } while (!done);
Ian Rogersc604d732012-10-14 16:09:54 -0700422#else
Ian Rogersc5f17732014-06-05 20:48:42 -0700423 exclusive_owner_ = 0;
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700424 CHECK_MUTEX_CALL(pthread_mutex_unlock, (&mutex_));
Ian Rogersc604d732012-10-14 16:09:54 -0700425#endif
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700426 }
Elliott Hughes8daa0922011-09-11 13:46:25 -0700427}
428
Ian Rogers56edc432013-01-18 16:51:51 -0800429void Mutex::Dump(std::ostream& os) const {
430 os << (recursive_ ? "recursive " : "non-recursive ")
431 << name_
432 << " level=" << static_cast<int>(level_)
433 << " rec=" << recursion_count_
434 << " owner=" << GetExclusiveOwnerTid() << " ";
435 DumpContention(os);
Ian Rogers01ae5802012-09-28 16:14:01 -0700436}
437
438std::ostream& operator<<(std::ostream& os, const Mutex& mu) {
Ian Rogers56edc432013-01-18 16:51:51 -0800439 mu.Dump(os);
440 return os;
Ian Rogers01ae5802012-09-28 16:14:01 -0700441}
442
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700443ReaderWriterMutex::ReaderWriterMutex(const char* name, LockLevel level)
444 : BaseMutex(name, level)
Ian Rogers81d425b2012-09-27 16:03:43 -0700445#if ART_USE_FUTEXES
Ian Rogersc5f17732014-06-05 20:48:42 -0700446 , state_(0), num_pending_readers_(0), num_pending_writers_(0)
Ian Rogers81d425b2012-09-27 16:03:43 -0700447#endif
Brian Carlstrom7934ac22013-07-26 10:54:15 -0700448{ // NOLINT(whitespace/braces)
Ian Rogers81d425b2012-09-27 16:03:43 -0700449#if !ART_USE_FUTEXES
Ian Rogersc5f17732014-06-05 20:48:42 -0700450 CHECK_MUTEX_CALL(pthread_rwlock_init, (&rwlock_, nullptr));
Ian Rogers81d425b2012-09-27 16:03:43 -0700451#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700452 exclusive_owner_ = 0;
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700453}
454
455ReaderWriterMutex::~ReaderWriterMutex() {
Ian Rogers81d425b2012-09-27 16:03:43 -0700456#if ART_USE_FUTEXES
Ian Rogersc7190692014-07-08 23:50:26 -0700457 CHECK_EQ(state_.LoadRelaxed(), 0);
Ian Rogers81d425b2012-09-27 16:03:43 -0700458 CHECK_EQ(exclusive_owner_, 0U);
Ian Rogersc7190692014-07-08 23:50:26 -0700459 CHECK_EQ(num_pending_readers_.LoadRelaxed(), 0);
Ian Rogers3e5cf302014-05-20 16:40:37 -0700460 CHECK_EQ(num_pending_writers_.LoadRelaxed(), 0);
Ian Rogers81d425b2012-09-27 16:03:43 -0700461#else
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700462 // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread
463 // may still be using locks.
464 int rc = pthread_rwlock_destroy(&rwlock_);
465 if (rc != 0) {
466 errno = rc;
467 // TODO: should we just not log at all if shutting down? this could be the logging mutex!
Ian Rogers50b35e22012-10-04 10:09:15 -0700468 MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_);
Ian Rogers120f1c72012-09-28 17:17:10 -0700469 Runtime* runtime = Runtime::Current();
Mathieu Chartier34e82932013-11-12 18:22:47 -0800470 bool shutting_down = runtime == NULL || runtime->IsShuttingDownLocked();
Ian Rogers120f1c72012-09-28 17:17:10 -0700471 PLOG(shutting_down ? WARNING : FATAL) << "pthread_rwlock_destroy failed for " << name_;
Brian Carlstromcd74c4b2012-01-23 13:21:00 -0800472 }
Ian Rogers81d425b2012-09-27 16:03:43 -0700473#endif
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700474}
475
Ian Rogers81d425b2012-09-27 16:03:43 -0700476void ReaderWriterMutex::ExclusiveLock(Thread* self) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700477 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers81d425b2012-09-27 16:03:43 -0700478 AssertNotExclusiveHeld(self);
479#if ART_USE_FUTEXES
480 bool done = false;
481 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700482 int32_t cur_state = state_.LoadRelaxed();
Hiroshi Yamauchi967a0ad2013-09-10 16:24:21 -0700483 if (LIKELY(cur_state == 0)) {
Ian Rogersc7190692014-07-08 23:50:26 -0700484 // Change state from 0 to -1 and impose load/store ordering appropriate for lock acquisition.
485 done = state_.CompareExchangeWeakAcquire(0 /* cur_state*/, -1 /* new state */);
Ian Rogers81d425b2012-09-27 16:03:43 -0700486 } else {
487 // Failed to acquire, hang up.
Hiroshi Yamauchib3733082013-08-12 17:28:49 -0700488 ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid());
Ian Rogersc7190692014-07-08 23:50:26 -0700489 ++num_pending_writers_;
490 if (futex(state_.Address(), FUTEX_WAIT, cur_state, NULL, NULL, 0) != 0) {
Brian Carlstrom0de79852013-07-25 22:29:58 -0700491 // EAGAIN and EINTR both indicate a spurious failure, try again from the beginning.
492 // We don't use TEMP_FAILURE_RETRY so we can intentionally retry to acquire the lock.
493 if ((errno != EAGAIN) && (errno != EINTR)) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700494 PLOG(FATAL) << "futex wait failed for " << name_;
495 }
496 }
Ian Rogersc7190692014-07-08 23:50:26 -0700497 --num_pending_writers_;
Ian Rogers81d425b2012-09-27 16:03:43 -0700498 }
Brian Carlstromdf629502013-07-17 22:39:56 -0700499 } while (!done);
Ian Rogersc7190692014-07-08 23:50:26 -0700500 DCHECK_EQ(state_.LoadRelaxed(), -1);
Ian Rogers81d425b2012-09-27 16:03:43 -0700501#else
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700502 CHECK_MUTEX_CALL(pthread_rwlock_wrlock, (&rwlock_));
Ian Rogers81d425b2012-09-27 16:03:43 -0700503#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700504 DCHECK_EQ(exclusive_owner_, 0U);
505 exclusive_owner_ = SafeGetTid(self);
Ian Rogers81d425b2012-09-27 16:03:43 -0700506 RegisterAsLocked(self);
507 AssertExclusiveHeld(self);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700508}
509
Ian Rogers81d425b2012-09-27 16:03:43 -0700510void ReaderWriterMutex::ExclusiveUnlock(Thread* self) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700511 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers81d425b2012-09-27 16:03:43 -0700512 AssertExclusiveHeld(self);
513 RegisterAsUnlocked(self);
Ian Rogersc5f17732014-06-05 20:48:42 -0700514 DCHECK_NE(exclusive_owner_, 0U);
Ian Rogers81d425b2012-09-27 16:03:43 -0700515#if ART_USE_FUTEXES
516 bool done = false;
517 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700518 int32_t cur_state = state_.LoadRelaxed();
Hiroshi Yamauchi967a0ad2013-09-10 16:24:21 -0700519 if (LIKELY(cur_state == -1)) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700520 // We're no longer the owner.
521 exclusive_owner_ = 0;
Ian Rogersc7190692014-07-08 23:50:26 -0700522 // Change state from -1 to 0 and impose load/store ordering appropriate for lock release.
523 // Note, the relaxed loads below musn't reorder before the CompareExchange.
524 // TODO: the ordering here is non-trivial as state is split across 3 fields, fix by placing
525 // a status bit into the state on contention.
526 done = state_.CompareExchangeWeakSequentiallyConsistent(-1 /* cur_state*/, 0 /* new state */);
527 if (LIKELY(done)) { // Weak CAS may fail spuriously.
Ian Rogers81d425b2012-09-27 16:03:43 -0700528 // Wake any waiters.
Ian Rogersc7190692014-07-08 23:50:26 -0700529 if (UNLIKELY(num_pending_readers_.LoadRelaxed() > 0 ||
530 num_pending_writers_.LoadRelaxed() > 0)) {
531 futex(state_.Address(), FUTEX_WAKE, -1, NULL, NULL, 0);
Ian Rogers81d425b2012-09-27 16:03:43 -0700532 }
533 }
534 } else {
535 LOG(FATAL) << "Unexpected state_:" << cur_state << " for " << name_;
536 }
Brian Carlstromdf629502013-07-17 22:39:56 -0700537 } while (!done);
Ian Rogers81d425b2012-09-27 16:03:43 -0700538#else
Ian Rogersc5f17732014-06-05 20:48:42 -0700539 exclusive_owner_ = 0;
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700540 CHECK_MUTEX_CALL(pthread_rwlock_unlock, (&rwlock_));
Ian Rogers81d425b2012-09-27 16:03:43 -0700541#endif
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700542}
543
Ian Rogers66aee5c2012-08-15 17:17:47 -0700544#if HAVE_TIMED_RWLOCK
Ian Rogersc604d732012-10-14 16:09:54 -0700545bool ReaderWriterMutex::ExclusiveLockWithTimeout(Thread* self, int64_t ms, int32_t ns) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700546 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers81d425b2012-09-27 16:03:43 -0700547#if ART_USE_FUTEXES
548 bool done = false;
Ian Rogersc604d732012-10-14 16:09:54 -0700549 timespec end_abs_ts;
Ian Rogers5bd97c42012-11-27 02:38:26 -0800550 InitTimeSpec(true, CLOCK_REALTIME, ms, ns, &end_abs_ts);
Ian Rogers81d425b2012-09-27 16:03:43 -0700551 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700552 int32_t cur_state = state_.LoadRelaxed();
Ian Rogers81d425b2012-09-27 16:03:43 -0700553 if (cur_state == 0) {
Ian Rogersc7190692014-07-08 23:50:26 -0700554 // Change state from 0 to -1 and impose load/store ordering appropriate for lock acquisition.
555 done = state_.CompareExchangeWeakAcquire(0 /* cur_state */, -1 /* new state */);
Ian Rogers81d425b2012-09-27 16:03:43 -0700556 } else {
557 // Failed to acquire, hang up.
Ian Rogersc604d732012-10-14 16:09:54 -0700558 timespec now_abs_ts;
Ian Rogers5bd97c42012-11-27 02:38:26 -0800559 InitTimeSpec(true, CLOCK_REALTIME, 0, 0, &now_abs_ts);
Ian Rogersc604d732012-10-14 16:09:54 -0700560 timespec rel_ts;
561 if (ComputeRelativeTimeSpec(&rel_ts, end_abs_ts, now_abs_ts)) {
562 return false; // Timed out.
563 }
Hiroshi Yamauchib3733082013-08-12 17:28:49 -0700564 ScopedContentionRecorder scr(this, SafeGetTid(self), GetExclusiveOwnerTid());
Ian Rogersc7190692014-07-08 23:50:26 -0700565 ++num_pending_writers_;
566 if (futex(state_.Address(), FUTEX_WAIT, cur_state, &rel_ts, NULL, 0) != 0) {
Ian Rogers81d425b2012-09-27 16:03:43 -0700567 if (errno == ETIMEDOUT) {
Ian Rogersc7190692014-07-08 23:50:26 -0700568 --num_pending_writers_;
Ian Rogersc604d732012-10-14 16:09:54 -0700569 return false; // Timed out.
Brian Carlstrom0de79852013-07-25 22:29:58 -0700570 } else if ((errno != EAGAIN) && (errno != EINTR)) {
571 // EAGAIN and EINTR both indicate a spurious failure,
572 // recompute the relative time out from now and try again.
573 // We don't use TEMP_FAILURE_RETRY so we can recompute rel_ts;
Ian Rogers81d425b2012-09-27 16:03:43 -0700574 PLOG(FATAL) << "timed futex wait failed for " << name_;
575 }
576 }
Ian Rogersc7190692014-07-08 23:50:26 -0700577 --num_pending_writers_;
Ian Rogers81d425b2012-09-27 16:03:43 -0700578 }
Brian Carlstromdf629502013-07-17 22:39:56 -0700579 } while (!done);
Ian Rogers81d425b2012-09-27 16:03:43 -0700580#else
Ian Rogersc604d732012-10-14 16:09:54 -0700581 timespec ts;
Brian Carlstrombcc29262012-11-02 11:36:03 -0700582 InitTimeSpec(true, CLOCK_REALTIME, ms, ns, &ts);
Ian Rogersc604d732012-10-14 16:09:54 -0700583 int result = pthread_rwlock_timedwrlock(&rwlock_, &ts);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700584 if (result == ETIMEDOUT) {
585 return false;
586 }
587 if (result != 0) {
588 errno = result;
Ian Rogersa5acfd32012-08-15 11:50:10 -0700589 PLOG(FATAL) << "pthread_rwlock_timedwrlock failed for " << name_;
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700590 }
Ian Rogers81d425b2012-09-27 16:03:43 -0700591#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700592 exclusive_owner_ = SafeGetTid(self);
Ian Rogers81d425b2012-09-27 16:03:43 -0700593 RegisterAsLocked(self);
594 AssertSharedHeld(self);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700595 return true;
596}
Ian Rogers66aee5c2012-08-15 17:17:47 -0700597#endif
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700598
Ian Rogers81d425b2012-09-27 16:03:43 -0700599bool ReaderWriterMutex::SharedTryLock(Thread* self) {
Ian Rogers01ae5802012-09-28 16:14:01 -0700600 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers81d425b2012-09-27 16:03:43 -0700601#if ART_USE_FUTEXES
602 bool done = false;
603 do {
Ian Rogersc7190692014-07-08 23:50:26 -0700604 int32_t cur_state = state_.LoadRelaxed();
Ian Rogers81d425b2012-09-27 16:03:43 -0700605 if (cur_state >= 0) {
Ian Rogersc7190692014-07-08 23:50:26 -0700606 // Add as an extra reader and impose load/store ordering appropriate for lock acquisition.
607 done = state_.CompareExchangeWeakAcquire(cur_state, cur_state + 1);
Ian Rogers81d425b2012-09-27 16:03:43 -0700608 } else {
609 // Owner holds it exclusively.
610 return false;
611 }
Brian Carlstromdf629502013-07-17 22:39:56 -0700612 } while (!done);
Ian Rogers81d425b2012-09-27 16:03:43 -0700613#else
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700614 int result = pthread_rwlock_tryrdlock(&rwlock_);
615 if (result == EBUSY) {
616 return false;
617 }
618 if (result != 0) {
619 errno = result;
620 PLOG(FATAL) << "pthread_mutex_trylock failed for " << name_;
621 }
Ian Rogers81d425b2012-09-27 16:03:43 -0700622#endif
623 RegisterAsLocked(self);
624 AssertSharedHeld(self);
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700625 return true;
626}
627
Ian Rogers81d425b2012-09-27 16:03:43 -0700628bool ReaderWriterMutex::IsSharedHeld(const Thread* self) const {
Ian Rogers01ae5802012-09-28 16:14:01 -0700629 DCHECK(self == NULL || self == Thread::Current());
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700630 bool result;
631 if (UNLIKELY(self == NULL)) { // Handle unattached threads.
Ian Rogers01ae5802012-09-28 16:14:01 -0700632 result = IsExclusiveHeld(self); // TODO: a better best effort here.
Ian Rogers00f7d0e2012-07-19 15:28:27 -0700633 } else {
634 result = (self->GetHeldMutex(level_) == this);
635 }
636 return result;
637}
638
Ian Rogers56edc432013-01-18 16:51:51 -0800639void ReaderWriterMutex::Dump(std::ostream& os) const {
640 os << name_
641 << " level=" << static_cast<int>(level_)
642 << " owner=" << GetExclusiveOwnerTid() << " ";
643 DumpContention(os);
Ian Rogers01ae5802012-09-28 16:14:01 -0700644}
645
646std::ostream& operator<<(std::ostream& os, const ReaderWriterMutex& mu) {
Ian Rogers56edc432013-01-18 16:51:51 -0800647 mu.Dump(os);
648 return os;
Ian Rogers01ae5802012-09-28 16:14:01 -0700649}
650
Ian Rogers23055dc2013-04-18 16:29:16 -0700651ConditionVariable::ConditionVariable(const char* name, Mutex& guard)
Ian Rogersc604d732012-10-14 16:09:54 -0700652 : name_(name), guard_(guard) {
653#if ART_USE_FUTEXES
Ian Rogers3e5cf302014-05-20 16:40:37 -0700654 DCHECK_EQ(0, sequence_.LoadRelaxed());
Ian Rogersc604d732012-10-14 16:09:54 -0700655 num_waiters_ = 0;
Ian Rogersc604d732012-10-14 16:09:54 -0700656#else
Narayan Kamath51b71022014-03-04 11:57:09 +0000657 pthread_condattr_t cond_attrs;
Ian Rogersc5f17732014-06-05 20:48:42 -0700658 CHECK_MUTEX_CALL(pthread_condattr_init, (&cond_attrs));
Narayan Kamath51b71022014-03-04 11:57:09 +0000659#if !defined(__APPLE__)
660 // Apple doesn't have CLOCK_MONOTONIC or pthread_condattr_setclock.
661 CHECK_MUTEX_CALL(pthread_condattr_setclock(&cond_attrs, CLOCK_MONOTONIC));
662#endif
663 CHECK_MUTEX_CALL(pthread_cond_init, (&cond_, &cond_attrs));
Ian Rogersc604d732012-10-14 16:09:54 -0700664#endif
Elliott Hughes5f791332011-09-15 17:45:30 -0700665}
666
667ConditionVariable::~ConditionVariable() {
Ian Rogers5bd97c42012-11-27 02:38:26 -0800668#if ART_USE_FUTEXES
669 if (num_waiters_!= 0) {
Ian Rogers5bd97c42012-11-27 02:38:26 -0800670 Runtime* runtime = Runtime::Current();
Mathieu Chartier590fee92013-09-13 13:46:47 -0700671 bool shutting_down = runtime == nullptr || runtime->IsShuttingDown(Thread::Current());
Ian Rogersd45f2012012-11-28 11:46:23 -0800672 LOG(shutting_down ? WARNING : FATAL) << "ConditionVariable::~ConditionVariable for " << name_
673 << " called with " << num_waiters_ << " waiters.";
Ian Rogers5bd97c42012-11-27 02:38:26 -0800674 }
675#else
Elliott Hughese62934d2012-04-09 11:24:29 -0700676 // We can't use CHECK_MUTEX_CALL here because on shutdown a suspended daemon thread
677 // may still be using condition variables.
678 int rc = pthread_cond_destroy(&cond_);
679 if (rc != 0) {
680 errno = rc;
Ian Rogers50b35e22012-10-04 10:09:15 -0700681 MutexLock mu(Thread::Current(), *Locks::runtime_shutdown_lock_);
Ian Rogers120f1c72012-09-28 17:17:10 -0700682 Runtime* runtime = Runtime::Current();
Mathieu Chartier34e82932013-11-12 18:22:47 -0800683 bool shutting_down = (runtime == NULL) || runtime->IsShuttingDownLocked();
Elliott Hughese62934d2012-04-09 11:24:29 -0700684 PLOG(shutting_down ? WARNING : FATAL) << "pthread_cond_destroy failed for " << name_;
685 }
Ian Rogersc604d732012-10-14 16:09:54 -0700686#endif
Elliott Hughes5f791332011-09-15 17:45:30 -0700687}
688
Ian Rogersc604d732012-10-14 16:09:54 -0700689void ConditionVariable::Broadcast(Thread* self) {
690 DCHECK(self == NULL || self == Thread::Current());
691 // TODO: enable below, there's a race in thread creation that causes false failures currently.
692 // guard_.AssertExclusiveHeld(self);
Mathieu Chartiere46cd752012-10-31 16:56:18 -0700693 DCHECK_EQ(guard_.GetExclusiveOwnerTid(), SafeGetTid(self));
Ian Rogersc604d732012-10-14 16:09:54 -0700694#if ART_USE_FUTEXES
Ian Rogersd45f2012012-11-28 11:46:23 -0800695 if (num_waiters_ > 0) {
Ian Rogersb122a4b2013-11-19 18:00:50 -0800696 sequence_++; // Indicate the broadcast occurred.
Ian Rogersc604d732012-10-14 16:09:54 -0700697 bool done = false;
698 do {
Ian Rogers3e5cf302014-05-20 16:40:37 -0700699 int32_t cur_sequence = sequence_.LoadRelaxed();
Ian Rogersd45f2012012-11-28 11:46:23 -0800700 // Requeue waiters onto mutex. The waiter holds the contender count on the mutex high ensuring
701 // mutex unlocks will awaken the requeued waiter thread.
Ian Rogersb122a4b2013-11-19 18:00:50 -0800702 done = futex(sequence_.Address(), FUTEX_CMP_REQUEUE, 0,
Ian Rogers5bd97c42012-11-27 02:38:26 -0800703 reinterpret_cast<const timespec*>(std::numeric_limits<int32_t>::max()),
Ian Rogersc7190692014-07-08 23:50:26 -0700704 guard_.state_.Address(), cur_sequence) != -1;
Ian Rogers5bd97c42012-11-27 02:38:26 -0800705 if (!done) {
706 if (errno != EAGAIN) {
707 PLOG(FATAL) << "futex cmp requeue failed for " << name_;
708 }
Ian Rogers5bd97c42012-11-27 02:38:26 -0800709 }
Ian Rogersc604d732012-10-14 16:09:54 -0700710 } while (!done);
711 }
712#else
Elliott Hughes5f791332011-09-15 17:45:30 -0700713 CHECK_MUTEX_CALL(pthread_cond_broadcast, (&cond_));
Ian Rogersc604d732012-10-14 16:09:54 -0700714#endif
Elliott Hughes5f791332011-09-15 17:45:30 -0700715}
716
Ian Rogersc604d732012-10-14 16:09:54 -0700717void ConditionVariable::Signal(Thread* self) {
718 DCHECK(self == NULL || self == Thread::Current());
719 guard_.AssertExclusiveHeld(self);
720#if ART_USE_FUTEXES
Ian Rogersd45f2012012-11-28 11:46:23 -0800721 if (num_waiters_ > 0) {
Ian Rogersb122a4b2013-11-19 18:00:50 -0800722 sequence_++; // Indicate a signal occurred.
Ian Rogersc604d732012-10-14 16:09:54 -0700723 // Futex wake 1 waiter who will then come and in contend on mutex. It'd be nice to requeue them
724 // to avoid this, however, requeueing can only move all waiters.
Ian Rogersb122a4b2013-11-19 18:00:50 -0800725 int num_woken = futex(sequence_.Address(), FUTEX_WAKE, 1, NULL, NULL, 0);
Ian Rogersd45f2012012-11-28 11:46:23 -0800726 // Check something was woken or else we changed sequence_ before they had chance to wait.
Ian Rogers5bd97c42012-11-27 02:38:26 -0800727 CHECK((num_woken == 0) || (num_woken == 1));
Ian Rogersc604d732012-10-14 16:09:54 -0700728 }
729#else
Elliott Hughes5f791332011-09-15 17:45:30 -0700730 CHECK_MUTEX_CALL(pthread_cond_signal, (&cond_));
Ian Rogersc604d732012-10-14 16:09:54 -0700731#endif
Elliott Hughes5f791332011-09-15 17:45:30 -0700732}
733
Ian Rogersc604d732012-10-14 16:09:54 -0700734void ConditionVariable::Wait(Thread* self) {
Ian Rogers1d54e732013-05-02 21:10:01 -0700735 guard_.CheckSafeToWait(self);
736 WaitHoldingLocks(self);
737}
738
739void ConditionVariable::WaitHoldingLocks(Thread* self) {
Ian Rogersc604d732012-10-14 16:09:54 -0700740 DCHECK(self == NULL || self == Thread::Current());
741 guard_.AssertExclusiveHeld(self);
Ian Rogersc604d732012-10-14 16:09:54 -0700742 unsigned int old_recursion_count = guard_.recursion_count_;
743#if ART_USE_FUTEXES
Ian Rogersc604d732012-10-14 16:09:54 -0700744 num_waiters_++;
Ian Rogersd45f2012012-11-28 11:46:23 -0800745 // Ensure the Mutex is contended so that requeued threads are awoken.
Ian Rogersb122a4b2013-11-19 18:00:50 -0800746 guard_.num_contenders_++;
Ian Rogersc604d732012-10-14 16:09:54 -0700747 guard_.recursion_count_ = 1;
Ian Rogers3e5cf302014-05-20 16:40:37 -0700748 int32_t cur_sequence = sequence_.LoadRelaxed();
Ian Rogersc604d732012-10-14 16:09:54 -0700749 guard_.ExclusiveUnlock(self);
Ian Rogersb122a4b2013-11-19 18:00:50 -0800750 if (futex(sequence_.Address(), FUTEX_WAIT, cur_sequence, NULL, NULL, 0) != 0) {
Ian Rogersd45f2012012-11-28 11:46:23 -0800751 // Futex failed, check it is an expected error.
752 // EAGAIN == EWOULDBLK, so we let the caller try again.
753 // EINTR implies a signal was sent to this thread.
754 if ((errno != EINTR) && (errno != EAGAIN)) {
Ian Rogersc604d732012-10-14 16:09:54 -0700755 PLOG(FATAL) << "futex wait failed for " << name_;
756 }
757 }
758 guard_.ExclusiveLock(self);
Ian Rogersd45f2012012-11-28 11:46:23 -0800759 CHECK_GE(num_waiters_, 0);
Ian Rogersc604d732012-10-14 16:09:54 -0700760 num_waiters_--;
Ian Rogersd45f2012012-11-28 11:46:23 -0800761 // We awoke and so no longer require awakes from the guard_'s unlock.
Ian Rogers3e5cf302014-05-20 16:40:37 -0700762 CHECK_GE(guard_.num_contenders_.LoadRelaxed(), 0);
Ian Rogersb122a4b2013-11-19 18:00:50 -0800763 guard_.num_contenders_--;
Ian Rogersc604d732012-10-14 16:09:54 -0700764#else
Ian Rogersc5f17732014-06-05 20:48:42 -0700765 uint64_t old_owner = guard_.exclusive_owner_;
766 guard_.exclusive_owner_ = 0;
Ian Rogersc604d732012-10-14 16:09:54 -0700767 guard_.recursion_count_ = 0;
768 CHECK_MUTEX_CALL(pthread_cond_wait, (&cond_, &guard_.mutex_));
Ian Rogersc5f17732014-06-05 20:48:42 -0700769 guard_.exclusive_owner_ = old_owner;
Ian Rogersc604d732012-10-14 16:09:54 -0700770#endif
771 guard_.recursion_count_ = old_recursion_count;
Elliott Hughes5f791332011-09-15 17:45:30 -0700772}
773
Ian Rogersc604d732012-10-14 16:09:54 -0700774void ConditionVariable::TimedWait(Thread* self, int64_t ms, int32_t ns) {
775 DCHECK(self == NULL || self == Thread::Current());
776 guard_.AssertExclusiveHeld(self);
Ian Rogers1d54e732013-05-02 21:10:01 -0700777 guard_.CheckSafeToWait(self);
Ian Rogersc604d732012-10-14 16:09:54 -0700778 unsigned int old_recursion_count = guard_.recursion_count_;
779#if ART_USE_FUTEXES
Ian Rogersc604d732012-10-14 16:09:54 -0700780 timespec rel_ts;
Ian Rogers5bd97c42012-11-27 02:38:26 -0800781 InitTimeSpec(false, CLOCK_REALTIME, ms, ns, &rel_ts);
Ian Rogersc604d732012-10-14 16:09:54 -0700782 num_waiters_++;
Ian Rogersd45f2012012-11-28 11:46:23 -0800783 // Ensure the Mutex is contended so that requeued threads are awoken.
Ian Rogersb122a4b2013-11-19 18:00:50 -0800784 guard_.num_contenders_++;
Ian Rogersc604d732012-10-14 16:09:54 -0700785 guard_.recursion_count_ = 1;
Ian Rogers3e5cf302014-05-20 16:40:37 -0700786 int32_t cur_sequence = sequence_.LoadRelaxed();
Ian Rogersc604d732012-10-14 16:09:54 -0700787 guard_.ExclusiveUnlock(self);
Ian Rogersb122a4b2013-11-19 18:00:50 -0800788 if (futex(sequence_.Address(), FUTEX_WAIT, cur_sequence, &rel_ts, NULL, 0) != 0) {
Ian Rogersc604d732012-10-14 16:09:54 -0700789 if (errno == ETIMEDOUT) {
Ian Rogersd45f2012012-11-28 11:46:23 -0800790 // Timed out we're done.
Brian Carlstrom0de79852013-07-25 22:29:58 -0700791 } else if ((errno == EAGAIN) || (errno == EINTR)) {
Ian Rogersd45f2012012-11-28 11:46:23 -0800792 // A signal or ConditionVariable::Signal/Broadcast has come in.
Ian Rogersc604d732012-10-14 16:09:54 -0700793 } else {
794 PLOG(FATAL) << "timed futex wait failed for " << name_;
795 }
796 }
797 guard_.ExclusiveLock(self);
Ian Rogersd45f2012012-11-28 11:46:23 -0800798 CHECK_GE(num_waiters_, 0);
Ian Rogersc604d732012-10-14 16:09:54 -0700799 num_waiters_--;
Ian Rogersd45f2012012-11-28 11:46:23 -0800800 // We awoke and so no longer require awakes from the guard_'s unlock.
Ian Rogers3e5cf302014-05-20 16:40:37 -0700801 CHECK_GE(guard_.num_contenders_.LoadRelaxed(), 0);
Ian Rogersb122a4b2013-11-19 18:00:50 -0800802 guard_.num_contenders_--;
Ian Rogersc604d732012-10-14 16:09:54 -0700803#else
Narayan Kamath51b71022014-03-04 11:57:09 +0000804#if !defined(__APPLE__)
Ian Rogersc604d732012-10-14 16:09:54 -0700805 int clock = CLOCK_MONOTONIC;
Elliott Hughes5f791332011-09-15 17:45:30 -0700806#else
Ian Rogersc604d732012-10-14 16:09:54 -0700807 int clock = CLOCK_REALTIME;
Elliott Hughes5f791332011-09-15 17:45:30 -0700808#endif
Ian Rogersc5f17732014-06-05 20:48:42 -0700809 uint64_t old_owner = guard_.exclusive_owner_;
810 guard_.exclusive_owner_ = 0;
Ian Rogersc604d732012-10-14 16:09:54 -0700811 guard_.recursion_count_ = 0;
812 timespec ts;
Brian Carlstrombcc29262012-11-02 11:36:03 -0700813 InitTimeSpec(true, clock, ms, ns, &ts);
Narayan Kamath51b71022014-03-04 11:57:09 +0000814 int rc = TEMP_FAILURE_RETRY(pthread_cond_timedwait(&cond_, &guard_.mutex_, &ts));
Elliott Hughes5f791332011-09-15 17:45:30 -0700815 if (rc != 0 && rc != ETIMEDOUT) {
816 errno = rc;
817 PLOG(FATAL) << "TimedWait failed for " << name_;
818 }
Ian Rogersc5f17732014-06-05 20:48:42 -0700819 guard_.exclusive_owner_ = old_owner;
Ian Rogersc604d732012-10-14 16:09:54 -0700820#endif
821 guard_.recursion_count_ = old_recursion_count;
Elliott Hughes5f791332011-09-15 17:45:30 -0700822}
823
Ian Rogers719d1a32014-03-06 12:13:39 -0800824void Locks::Init() {
825 if (logging_lock_ != nullptr) {
826 // Already initialized.
Nicolas Geoffray7f0a6d62014-05-26 14:01:46 +0100827 if (kRuntimeISA == kX86 || kRuntimeISA == kX86_64) {
Chao-ying Fu9e369312014-05-21 11:20:52 -0700828 DCHECK(modify_ldt_lock_ != nullptr);
829 } else {
830 DCHECK(modify_ldt_lock_ == nullptr);
831 }
Ian Rogers719d1a32014-03-06 12:13:39 -0800832 DCHECK(abort_lock_ != nullptr);
Andreas Gampe74240812014-04-17 10:35:09 -0700833 DCHECK(allocated_monitor_ids_lock_ != nullptr);
Chao-ying Fu9e369312014-05-21 11:20:52 -0700834 DCHECK(allocated_thread_ids_lock_ != nullptr);
Ian Rogers719d1a32014-03-06 12:13:39 -0800835 DCHECK(breakpoint_lock_ != nullptr);
Ian Rogers719d1a32014-03-06 12:13:39 -0800836 DCHECK(classlinker_classes_lock_ != nullptr);
837 DCHECK(heap_bitmap_lock_ != nullptr);
Ian Rogers68d8b422014-07-17 11:09:10 -0700838 DCHECK(jni_libraries_lock_ != nullptr);
Ian Rogers719d1a32014-03-06 12:13:39 -0800839 DCHECK(logging_lock_ != nullptr);
840 DCHECK(mutator_lock_ != nullptr);
841 DCHECK(thread_list_lock_ != nullptr);
Ian Rogersf3d874c2014-07-17 18:52:42 -0700842 DCHECK(thread_list_suspend_thread_lock_ != nullptr);
Ian Rogers719d1a32014-03-06 12:13:39 -0800843 DCHECK(thread_suspend_count_lock_ != nullptr);
844 DCHECK(trace_lock_ != nullptr);
845 DCHECK(profiler_lock_ != nullptr);
846 DCHECK(unexpected_signal_lock_ != nullptr);
847 DCHECK(intern_table_lock_ != nullptr);
848 } else {
Chao-ying Fu9e369312014-05-21 11:20:52 -0700849 // Create global locks in level order from highest lock level to lowest.
Ian Rogersf3d874c2014-07-17 18:52:42 -0700850 LockLevel current_lock_level = kThreadListSuspendThreadLock;
851 DCHECK(thread_list_suspend_thread_lock_ == nullptr);
852 thread_list_suspend_thread_lock_ =
853 new Mutex("thread list suspend thread by .. lock", current_lock_level);
Ian Rogers719d1a32014-03-06 12:13:39 -0800854
Chao-ying Fu9e369312014-05-21 11:20:52 -0700855 #define UPDATE_CURRENT_LOCK_LEVEL(new_level) \
Ian Rogersf3d874c2014-07-17 18:52:42 -0700856 DCHECK_LT(new_level, current_lock_level); \
857 current_lock_level = new_level;
858
859 UPDATE_CURRENT_LOCK_LEVEL(kMutatorLock);
860 DCHECK(mutator_lock_ == nullptr);
861 mutator_lock_ = new ReaderWriterMutex("mutator lock", current_lock_level);
Chao-ying Fu9e369312014-05-21 11:20:52 -0700862
863 UPDATE_CURRENT_LOCK_LEVEL(kHeapBitmapLock);
864 DCHECK(heap_bitmap_lock_ == nullptr);
865 heap_bitmap_lock_ = new ReaderWriterMutex("heap bitmap lock", current_lock_level);
866
867 UPDATE_CURRENT_LOCK_LEVEL(kRuntimeShutdownLock);
868 DCHECK(runtime_shutdown_lock_ == nullptr);
869 runtime_shutdown_lock_ = new Mutex("runtime shutdown lock", current_lock_level);
870
871 UPDATE_CURRENT_LOCK_LEVEL(kProfilerLock);
872 DCHECK(profiler_lock_ == nullptr);
873 profiler_lock_ = new Mutex("profiler lock", current_lock_level);
874
875 UPDATE_CURRENT_LOCK_LEVEL(kTraceLock);
876 DCHECK(trace_lock_ == nullptr);
877 trace_lock_ = new Mutex("trace lock", current_lock_level);
878
879 UPDATE_CURRENT_LOCK_LEVEL(kThreadListLock);
880 DCHECK(thread_list_lock_ == nullptr);
881 thread_list_lock_ = new Mutex("thread list lock", current_lock_level);
882
Ian Rogers68d8b422014-07-17 11:09:10 -0700883 UPDATE_CURRENT_LOCK_LEVEL(kJniLoadLibraryLock);
884 DCHECK(jni_libraries_lock_ == nullptr);
885 jni_libraries_lock_ = new Mutex("JNI shared libraries map lock", current_lock_level);
886
Chao-ying Fu9e369312014-05-21 11:20:52 -0700887 UPDATE_CURRENT_LOCK_LEVEL(kBreakpointLock);
Ian Rogers719d1a32014-03-06 12:13:39 -0800888 DCHECK(breakpoint_lock_ == nullptr);
Chao-ying Fu9e369312014-05-21 11:20:52 -0700889 breakpoint_lock_ = new Mutex("breakpoint lock", current_lock_level);
890
891 UPDATE_CURRENT_LOCK_LEVEL(kClassLinkerClassesLock);
Ian Rogers719d1a32014-03-06 12:13:39 -0800892 DCHECK(classlinker_classes_lock_ == nullptr);
893 classlinker_classes_lock_ = new ReaderWriterMutex("ClassLinker classes lock",
Chao-ying Fu9e369312014-05-21 11:20:52 -0700894 current_lock_level);
895
Andreas Gampe74240812014-04-17 10:35:09 -0700896 UPDATE_CURRENT_LOCK_LEVEL(kMonitorPoolLock);
897 DCHECK(allocated_monitor_ids_lock_ == nullptr);
898 allocated_monitor_ids_lock_ = new Mutex("allocated monitor ids lock", current_lock_level);
899
Chao-ying Fu9e369312014-05-21 11:20:52 -0700900 UPDATE_CURRENT_LOCK_LEVEL(kAllocatedThreadIdsLock);
901 DCHECK(allocated_thread_ids_lock_ == nullptr);
902 allocated_thread_ids_lock_ = new Mutex("allocated thread ids lock", current_lock_level);
903
Nicolas Geoffray7f0a6d62014-05-26 14:01:46 +0100904 if (kRuntimeISA == kX86 || kRuntimeISA == kX86_64) {
Chao-ying Fu9e369312014-05-21 11:20:52 -0700905 UPDATE_CURRENT_LOCK_LEVEL(kModifyLdtLock);
906 DCHECK(modify_ldt_lock_ == nullptr);
907 modify_ldt_lock_ = new Mutex("modify_ldt lock", current_lock_level);
908 }
909
910 UPDATE_CURRENT_LOCK_LEVEL(kInternTableLock);
Ian Rogers719d1a32014-03-06 12:13:39 -0800911 DCHECK(intern_table_lock_ == nullptr);
Chao-ying Fu9e369312014-05-21 11:20:52 -0700912 intern_table_lock_ = new Mutex("InternTable lock", current_lock_level);
913
914
915 UPDATE_CURRENT_LOCK_LEVEL(kAbortLock);
916 DCHECK(abort_lock_ == nullptr);
917 abort_lock_ = new Mutex("abort lock", current_lock_level, true);
918
919 UPDATE_CURRENT_LOCK_LEVEL(kThreadSuspendCountLock);
920 DCHECK(thread_suspend_count_lock_ == nullptr);
921 thread_suspend_count_lock_ = new Mutex("thread suspend count lock", current_lock_level);
922
923 UPDATE_CURRENT_LOCK_LEVEL(kUnexpectedSignalLock);
924 DCHECK(unexpected_signal_lock_ == nullptr);
925 unexpected_signal_lock_ = new Mutex("unexpected signal lock", current_lock_level, true);
926
Hiroshi Yamauchi3eed93d2014-06-04 11:43:59 -0700927 UPDATE_CURRENT_LOCK_LEVEL(kMemMapsLock);
928 DCHECK(mem_maps_lock_ == nullptr);
929 mem_maps_lock_ = new Mutex("mem maps lock", current_lock_level);
930
Chao-ying Fu9e369312014-05-21 11:20:52 -0700931 UPDATE_CURRENT_LOCK_LEVEL(kLoggingLock);
932 DCHECK(logging_lock_ == nullptr);
933 logging_lock_ = new Mutex("logging lock", current_lock_level, true);
934
935 #undef UPDATE_CURRENT_LOCK_LEVEL
Ian Rogers719d1a32014-03-06 12:13:39 -0800936 }
937}
938
939
Elliott Hughese62934d2012-04-09 11:24:29 -0700940} // namespace art