blob: d22b301585b48a06f1471a845a7d04e922c5a2bb [file] [log] [blame]
Andreas Gampee1459ae2016-06-29 09:36:30 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Igor Murashkin5573c372017-11-16 13:34:30 -080017#include <regex>
Andreas Gampe7adeda82016-07-25 08:27:35 -070018#include <sstream>
Andreas Gampee1459ae2016-06-29 09:36:30 -070019#include <string>
20#include <vector>
Andreas Gampee1459ae2016-06-29 09:36:30 -070021
Andreas Gampe46ee31b2016-12-14 10:11:49 -080022#include <sys/wait.h>
23#include <unistd.h>
24
Andreas Gampe57943812017-12-06 21:39:13 -080025#include <android-base/logging.h>
26#include <android-base/stringprintf.h>
Andreas Gampe46ee31b2016-12-14 10:11:49 -080027
Andreas Gampee1459ae2016-06-29 09:36:30 -070028#include "common_runtime_test.h"
29
Andreas Gampee1459ae2016-06-29 09:36:30 -070030#include "base/macros.h"
Andreas Gampeb486a982017-06-01 13:45:54 -070031#include "base/mutex-inl.h"
David Sehrc431b9d2018-03-02 12:01:51 -080032#include "base/utils.h"
David Sehr013fd802018-01-11 22:55:24 -080033#include "dex/art_dex_file_loader.h"
Mathieu Chartier05f90d12018-02-07 13:47:17 -080034#include "dex/base64_test_util.h"
David Sehr312f3b22018-03-19 08:39:26 -070035#include "dex/bytecode_utils.h"
Mathieu Chartier2242ef12018-07-23 18:14:13 -070036#include "dex/class_accessor-inl.h"
David Sehr9e734c72018-01-04 17:56:19 -080037#include "dex/code_item_accessors-inl.h"
38#include "dex/dex_file-inl.h"
39#include "dex/dex_file_loader.h"
Andreas Gampee1459ae2016-06-29 09:36:30 -070040#include "dex2oat_environment_test.h"
Andreas Gampef7882972017-03-20 16:35:24 -070041#include "dex2oat_return_codes.h"
Andreas Gampee15b9b12018-10-29 12:54:27 -070042#include "gc_root-inl.h"
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -070043#include "intern_table-inl.h"
Andreas Gampe67f02822016-06-24 21:05:23 -070044#include "oat.h"
45#include "oat_file.h"
David Sehr82d046e2018-04-23 08:14:19 -070046#include "profile/profile_compilation_info.h"
Mathieu Chartier792111c2018-02-15 13:02:15 -080047#include "vdex_file.h"
48#include "ziparchive/zip_writer.h"
Andreas Gampee1459ae2016-06-29 09:36:30 -070049
Andreas Gampee1459ae2016-06-29 09:36:30 -070050namespace art {
51
Mathieu Chartierea650f32017-05-24 12:04:13 -070052static constexpr size_t kMaxMethodIds = 65535;
Mathieu Chartier9e050df2017-08-09 10:05:47 -070053static constexpr bool kDebugArgs = false;
Mathieu Chartier02129102017-12-22 11:04:01 -080054static const char* kDisableCompactDex = "--compact-dex-level=none";
Mathieu Chartierea650f32017-05-24 12:04:13 -070055
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080056using android::base::StringPrintf;
57
Andreas Gampee1459ae2016-06-29 09:36:30 -070058class Dex2oatTest : public Dex2oatEnvironmentTest {
59 public:
Roland Levillainf73caca2018-08-24 17:19:07 +010060 void TearDown() override {
Andreas Gampee1459ae2016-06-29 09:36:30 -070061 Dex2oatEnvironmentTest::TearDown();
62
63 output_ = "";
64 error_msg_ = "";
65 success_ = false;
66 }
67
68 protected:
Mathieu Chartier9e050df2017-08-09 10:05:47 -070069 int GenerateOdexForTestWithStatus(const std::vector<std::string>& dex_locations,
Andreas Gampef7882972017-03-20 16:35:24 -070070 const std::string& odex_location,
71 CompilerFilter::Filter filter,
72 std::string* error_msg,
73 const std::vector<std::string>& extra_args = {},
74 bool use_fd = false) {
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080075 std::unique_ptr<File> oat_file;
Andreas Gampee1459ae2016-06-29 09:36:30 -070076 std::vector<std::string> args;
Mathieu Chartier9e050df2017-08-09 10:05:47 -070077 // Add dex file args.
78 for (const std::string& dex_location : dex_locations) {
79 args.push_back("--dex-file=" + dex_location);
80 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080081 if (use_fd) {
82 oat_file.reset(OS::CreateEmptyFile(odex_location.c_str()));
83 CHECK(oat_file != nullptr) << odex_location;
84 args.push_back("--oat-fd=" + std::to_string(oat_file->Fd()));
Mathieu Chartier046854b2017-03-01 17:16:22 -080085 args.push_back("--oat-location=" + odex_location);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080086 } else {
87 args.push_back("--oat-file=" + odex_location);
88 }
Andreas Gampee1459ae2016-06-29 09:36:30 -070089 args.push_back("--compiler-filter=" + CompilerFilter::NameOfFilter(filter));
90 args.push_back("--runtime-arg");
91 args.push_back("-Xnorelocate");
92
93 args.insert(args.end(), extra_args.begin(), extra_args.end());
94
Andreas Gampef7882972017-03-20 16:35:24 -070095 int status = Dex2Oat(args, error_msg);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080096 if (oat_file != nullptr) {
Andreas Gampef7882972017-03-20 16:35:24 -070097 CHECK_EQ(oat_file->FlushClose(), 0) << "Could not flush and close oat file";
Mathieu Chartier8bc343b2017-03-01 15:20:30 -080098 }
Andreas Gampef7882972017-03-20 16:35:24 -070099 return status;
100 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700101
Andreas Gampe641a4732017-08-24 13:21:35 -0700102 void GenerateOdexForTest(
103 const std::string& dex_location,
104 const std::string& odex_location,
105 CompilerFilter::Filter filter,
106 const std::vector<std::string>& extra_args = {},
107 bool expect_success = true,
108 bool use_fd = false) {
109 GenerateOdexForTest(dex_location,
110 odex_location,
111 filter,
112 extra_args,
113 expect_success,
114 use_fd,
115 [](const OatFile&) {});
116 }
117
Andreas Gampe80ddf272018-01-11 09:41:00 -0800118 bool test_accepts_odex_file_on_failure = false;
119
Andreas Gampe641a4732017-08-24 13:21:35 -0700120 template <typename T>
121 void GenerateOdexForTest(
122 const std::string& dex_location,
123 const std::string& odex_location,
124 CompilerFilter::Filter filter,
125 const std::vector<std::string>& extra_args,
126 bool expect_success,
127 bool use_fd,
128 T check_oat) {
Andreas Gampef7882972017-03-20 16:35:24 -0700129 std::string error_msg;
Mathieu Chartier9e050df2017-08-09 10:05:47 -0700130 int status = GenerateOdexForTestWithStatus({dex_location},
Andreas Gampef7882972017-03-20 16:35:24 -0700131 odex_location,
132 filter,
133 &error_msg,
134 extra_args,
135 use_fd);
Andreas Gampe80ddf272018-01-11 09:41:00 -0800136 bool success = (WIFEXITED(status) && WEXITSTATUS(status) == 0);
Andreas Gampee1459ae2016-06-29 09:36:30 -0700137 if (expect_success) {
Andreas Gampe2e8a2562017-01-18 20:39:02 -0800138 ASSERT_TRUE(success) << error_msg << std::endl << output_;
Andreas Gampee1459ae2016-06-29 09:36:30 -0700139
140 // Verify the odex file was generated as expected.
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100141 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100142 odex_location.c_str(),
Andreas Gampee1459ae2016-06-29 09:36:30 -0700143 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100144 /*executable=*/ false,
145 /*low_4gb=*/ false,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700146 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100147 /*reservation=*/ nullptr,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700148 &error_msg));
149 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
150
151 CheckFilter(filter, odex_file->GetCompilerFilter());
Calin Juravle1ce70852017-06-28 10:59:03 -0700152 check_oat(*(odex_file.get()));
Andreas Gampee1459ae2016-06-29 09:36:30 -0700153 } else {
154 ASSERT_FALSE(success) << output_;
155
156 error_msg_ = error_msg;
157
Andreas Gampe80ddf272018-01-11 09:41:00 -0800158 if (!test_accepts_odex_file_on_failure) {
159 // Verify there's no loadable odex file.
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100160 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100161 odex_location.c_str(),
Andreas Gampe80ddf272018-01-11 09:41:00 -0800162 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100163 /*executable=*/ false,
164 /*low_4gb=*/ false,
Andreas Gampe80ddf272018-01-11 09:41:00 -0800165 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100166 /*reservation=*/ nullptr,
Andreas Gampe80ddf272018-01-11 09:41:00 -0800167 &error_msg));
168 ASSERT_TRUE(odex_file.get() == nullptr);
169 }
Andreas Gampee1459ae2016-06-29 09:36:30 -0700170 }
171 }
172
Calin Juravle1ccf6132017-08-02 17:46:53 -0700173 // Check the input compiler filter against the generated oat file's filter. May be overridden
Andreas Gampee1459ae2016-06-29 09:36:30 -0700174 // in subclasses when equality is not expected.
175 virtual void CheckFilter(CompilerFilter::Filter expected, CompilerFilter::Filter actual) {
176 EXPECT_EQ(expected, actual);
177 }
178
Andreas Gampef7882972017-03-20 16:35:24 -0700179 int Dex2Oat(const std::vector<std::string>& dex2oat_args, std::string* error_msg) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700180 Runtime* runtime = Runtime::Current();
181
182 const std::vector<gc::space::ImageSpace*>& image_spaces =
183 runtime->GetHeap()->GetBootImageSpaces();
184 if (image_spaces.empty()) {
185 *error_msg = "No image location found for Dex2Oat.";
186 return false;
187 }
188 std::string image_location = image_spaces[0]->GetImageLocation();
189
190 std::vector<std::string> argv;
191 argv.push_back(runtime->GetCompilerExecutable());
Calin Juravle1ccf6132017-08-02 17:46:53 -0700192
Nicolas Geoffray433b79a2017-01-30 20:54:45 +0000193 if (runtime->IsJavaDebuggable()) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700194 argv.push_back("--debuggable");
195 }
196 runtime->AddCurrentRuntimeFeaturesAsDex2OatArguments(&argv);
197
198 if (!runtime->IsVerificationEnabled()) {
Nicolas Geoffray49cda062017-04-21 13:08:25 +0100199 argv.push_back("--compiler-filter=assume-verified");
Andreas Gampee1459ae2016-06-29 09:36:30 -0700200 }
201
202 if (runtime->MustRelocateIfPossible()) {
203 argv.push_back("--runtime-arg");
204 argv.push_back("-Xrelocate");
205 } else {
206 argv.push_back("--runtime-arg");
207 argv.push_back("-Xnorelocate");
208 }
209
210 if (!kIsTargetBuild) {
211 argv.push_back("--host");
212 }
213
214 argv.push_back("--boot-image=" + image_location);
215
216 std::vector<std::string> compiler_options = runtime->GetCompilerOptions();
217 argv.insert(argv.end(), compiler_options.begin(), compiler_options.end());
218
219 argv.insert(argv.end(), dex2oat_args.begin(), dex2oat_args.end());
220
221 // We must set --android-root.
222 const char* android_root = getenv("ANDROID_ROOT");
223 CHECK(android_root != nullptr);
224 argv.push_back("--android-root=" + std::string(android_root));
225
Mathieu Chartier9e050df2017-08-09 10:05:47 -0700226 if (kDebugArgs) {
227 std::string all_args;
228 for (const std::string& arg : argv) {
229 all_args += arg + " ";
230 }
231 LOG(ERROR) << all_args;
232 }
233
Andreas Gampe38aa0b52018-07-10 23:26:55 -0700234 // We need dex2oat to actually log things.
235 auto post_fork_fn = []() { return setenv("ANDROID_LOG_TAGS", "*:d", 1) == 0; };
236 ForkAndExecResult res = ForkAndExec(argv, post_fork_fn, &output_);
237 if (res.stage != ForkAndExecResult::kFinished) {
238 *error_msg = strerror(errno);
239 return -1;
Nicolas Geoffray56fe0f02016-06-30 15:07:46 +0100240 }
Andreas Gampe38aa0b52018-07-10 23:26:55 -0700241 success_ = res.StandardSuccess();
242 return res.status_code;
Andreas Gampee1459ae2016-06-29 09:36:30 -0700243 }
244
245 std::string output_ = "";
246 std::string error_msg_ = "";
247 bool success_ = false;
248};
249
250class Dex2oatSwapTest : public Dex2oatTest {
251 protected:
252 void RunTest(bool use_fd, bool expect_use, const std::vector<std::string>& extra_args = {}) {
253 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
254 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
255
Andreas Gampe7adeda82016-07-25 08:27:35 -0700256 Copy(GetTestDexFileName(), dex_location);
Andreas Gampee1459ae2016-06-29 09:36:30 -0700257
258 std::vector<std::string> copy(extra_args);
259
260 std::unique_ptr<ScratchFile> sf;
261 if (use_fd) {
262 sf.reset(new ScratchFile());
Andreas Gampe46ee31b2016-12-14 10:11:49 -0800263 copy.push_back(android::base::StringPrintf("--swap-fd=%d", sf->GetFd()));
Andreas Gampee1459ae2016-06-29 09:36:30 -0700264 } else {
265 std::string swap_location = GetOdexDir() + "/Dex2OatSwapTest.odex.swap";
266 copy.push_back("--swap-file=" + swap_location);
267 }
268 GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed, copy);
269
270 CheckValidity();
271 ASSERT_TRUE(success_);
272 CheckResult(expect_use);
273 }
274
Andreas Gampe7adeda82016-07-25 08:27:35 -0700275 virtual std::string GetTestDexFileName() {
Vladimir Marko15357702017-02-09 10:37:31 +0000276 return Dex2oatEnvironmentTest::GetTestDexFileName("VerifierDeps");
Andreas Gampe7adeda82016-07-25 08:27:35 -0700277 }
278
279 virtual void CheckResult(bool expect_use) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700280 if (kIsTargetBuild) {
281 CheckTargetResult(expect_use);
282 } else {
283 CheckHostResult(expect_use);
284 }
285 }
286
Andreas Gampe7adeda82016-07-25 08:27:35 -0700287 virtual void CheckTargetResult(bool expect_use ATTRIBUTE_UNUSED) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700288 // TODO: Ignore for now, as we won't capture any output (it goes to the logcat). We may do
289 // something for variants with file descriptor where we can control the lifetime of
290 // the swap file and thus take a look at it.
291 }
292
Andreas Gampe7adeda82016-07-25 08:27:35 -0700293 virtual void CheckHostResult(bool expect_use) {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700294 if (!kIsTargetBuild) {
295 if (expect_use) {
296 EXPECT_NE(output_.find("Large app, accepted running with swap."), std::string::npos)
297 << output_;
298 } else {
299 EXPECT_EQ(output_.find("Large app, accepted running with swap."), std::string::npos)
300 << output_;
301 }
302 }
303 }
304
305 // Check whether the dex2oat run was really successful.
Andreas Gampe7adeda82016-07-25 08:27:35 -0700306 virtual void CheckValidity() {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700307 if (kIsTargetBuild) {
308 CheckTargetValidity();
309 } else {
310 CheckHostValidity();
311 }
312 }
313
Andreas Gampe7adeda82016-07-25 08:27:35 -0700314 virtual void CheckTargetValidity() {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700315 // TODO: Ignore for now, as we won't capture any output (it goes to the logcat). We may do
316 // something for variants with file descriptor where we can control the lifetime of
317 // the swap file and thus take a look at it.
318 }
319
320 // On the host, we can get the dex2oat output. Here, look for "dex2oat took."
Andreas Gampe7adeda82016-07-25 08:27:35 -0700321 virtual void CheckHostValidity() {
Andreas Gampee1459ae2016-06-29 09:36:30 -0700322 EXPECT_NE(output_.find("dex2oat took"), std::string::npos) << output_;
323 }
324};
325
326TEST_F(Dex2oatSwapTest, DoNotUseSwapDefaultSingleSmall) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100327 RunTest(/*use_fd=*/ false, /*expect_use=*/ false);
328 RunTest(/*use_fd=*/ true, /*expect_use=*/ false);
Andreas Gampee1459ae2016-06-29 09:36:30 -0700329}
330
331TEST_F(Dex2oatSwapTest, DoNotUseSwapSingle) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100332 RunTest(/*use_fd=*/ false, /*expect_use=*/ false, { "--swap-dex-size-threshold=0" });
333 RunTest(/*use_fd=*/ true, /*expect_use=*/ false, { "--swap-dex-size-threshold=0" });
Andreas Gampee1459ae2016-06-29 09:36:30 -0700334}
335
336TEST_F(Dex2oatSwapTest, DoNotUseSwapSmall) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100337 RunTest(/*use_fd=*/ false, /*expect_use=*/ false, { "--swap-dex-count-threshold=0" });
338 RunTest(/*use_fd=*/ true, /*expect_use=*/ false, { "--swap-dex-count-threshold=0" });
Andreas Gampee1459ae2016-06-29 09:36:30 -0700339}
340
341TEST_F(Dex2oatSwapTest, DoUseSwapSingleSmall) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100342 RunTest(/*use_fd=*/ false,
343 /*expect_use=*/ true,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700344 { "--swap-dex-size-threshold=0", "--swap-dex-count-threshold=0" });
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100345 RunTest(/*use_fd=*/ true,
346 /*expect_use=*/ true,
Andreas Gampee1459ae2016-06-29 09:36:30 -0700347 { "--swap-dex-size-threshold=0", "--swap-dex-count-threshold=0" });
348}
349
Andreas Gampe7adeda82016-07-25 08:27:35 -0700350class Dex2oatSwapUseTest : public Dex2oatSwapTest {
351 protected:
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100352 void CheckHostResult(bool expect_use) override {
Andreas Gampe7adeda82016-07-25 08:27:35 -0700353 if (!kIsTargetBuild) {
354 if (expect_use) {
355 EXPECT_NE(output_.find("Large app, accepted running with swap."), std::string::npos)
356 << output_;
357 } else {
358 EXPECT_EQ(output_.find("Large app, accepted running with swap."), std::string::npos)
359 << output_;
360 }
361 }
362 }
363
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100364 std::string GetTestDexFileName() override {
Andreas Gampe7adeda82016-07-25 08:27:35 -0700365 // Use Statics as it has a handful of functions.
366 return CommonRuntimeTest::GetTestDexFileName("Statics");
367 }
368
369 void GrabResult1() {
370 if (!kIsTargetBuild) {
371 native_alloc_1_ = ParseNativeAlloc();
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100372 swap_1_ = ParseSwap(/*expected=*/ false);
Andreas Gampe7adeda82016-07-25 08:27:35 -0700373 } else {
374 native_alloc_1_ = std::numeric_limits<size_t>::max();
375 swap_1_ = 0;
376 }
377 }
378
379 void GrabResult2() {
380 if (!kIsTargetBuild) {
381 native_alloc_2_ = ParseNativeAlloc();
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100382 swap_2_ = ParseSwap(/*expected=*/ true);
Andreas Gampe7adeda82016-07-25 08:27:35 -0700383 } else {
384 native_alloc_2_ = 0;
385 swap_2_ = std::numeric_limits<size_t>::max();
386 }
387 }
388
389 private:
390 size_t ParseNativeAlloc() {
391 std::regex native_alloc_regex("dex2oat took.*native alloc=[^ ]+ \\(([0-9]+)B\\)");
392 std::smatch native_alloc_match;
393 bool found = std::regex_search(output_, native_alloc_match, native_alloc_regex);
394 if (!found) {
395 EXPECT_TRUE(found);
396 return 0;
397 }
398 if (native_alloc_match.size() != 2U) {
399 EXPECT_EQ(native_alloc_match.size(), 2U);
400 return 0;
401 }
402
403 std::istringstream stream(native_alloc_match[1].str());
404 size_t value;
405 stream >> value;
406
407 return value;
408 }
409
410 size_t ParseSwap(bool expected) {
411 std::regex swap_regex("dex2oat took[^\\n]+swap=[^ ]+ \\(([0-9]+)B\\)");
412 std::smatch swap_match;
413 bool found = std::regex_search(output_, swap_match, swap_regex);
414 if (found != expected) {
415 EXPECT_EQ(expected, found);
416 return 0;
417 }
418
419 if (!found) {
420 return 0;
421 }
422
423 if (swap_match.size() != 2U) {
424 EXPECT_EQ(swap_match.size(), 2U);
425 return 0;
426 }
427
428 std::istringstream stream(swap_match[1].str());
429 size_t value;
430 stream >> value;
431
432 return value;
433 }
434
435 protected:
436 size_t native_alloc_1_;
437 size_t native_alloc_2_;
438
439 size_t swap_1_;
440 size_t swap_2_;
441};
442
443TEST_F(Dex2oatSwapUseTest, CheckSwapUsage) {
Roland Levillain05e34f42018-05-24 13:19:05 +0000444 // Native memory usage isn't correctly tracked when running under ASan.
445 TEST_DISABLED_FOR_MEMORY_TOOL();
Andreas Gampef4a67fd2017-05-04 09:55:36 -0700446
Vladimir Marko57070da2017-02-14 16:16:30 +0000447 // The `native_alloc_2_ >= native_alloc_1_` assertion below may not
Roland Levillain19772bf2017-02-16 11:28:10 +0000448 // hold true on some x86 systems; disable this test while we
449 // investigate (b/29259363).
450 TEST_DISABLED_FOR_X86();
Vladimir Marko57070da2017-02-14 16:16:30 +0000451
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100452 RunTest(/*use_fd=*/ false,
453 /*expect_use=*/ false);
Andreas Gampe7adeda82016-07-25 08:27:35 -0700454 GrabResult1();
455 std::string output_1 = output_;
456
457 output_ = "";
458
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100459 RunTest(/*use_fd=*/ false,
460 /*expect_use=*/ true,
Andreas Gampe7adeda82016-07-25 08:27:35 -0700461 { "--swap-dex-size-threshold=0", "--swap-dex-count-threshold=0" });
462 GrabResult2();
463 std::string output_2 = output_;
464
465 if (native_alloc_2_ >= native_alloc_1_ || swap_1_ >= swap_2_) {
466 EXPECT_LT(native_alloc_2_, native_alloc_1_);
467 EXPECT_LT(swap_1_, swap_2_);
468
469 LOG(ERROR) << output_1;
470 LOG(ERROR) << output_2;
471 }
472}
473
Andreas Gampe67f02822016-06-24 21:05:23 -0700474class Dex2oatVeryLargeTest : public Dex2oatTest {
475 protected:
476 void CheckFilter(CompilerFilter::Filter input ATTRIBUTE_UNUSED,
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100477 CompilerFilter::Filter result ATTRIBUTE_UNUSED) override {
Andreas Gampe67f02822016-06-24 21:05:23 -0700478 // Ignore, we'll do our own checks.
479 }
480
481 void RunTest(CompilerFilter::Filter filter,
482 bool expect_large,
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700483 bool expect_downgrade,
Andreas Gampe67f02822016-06-24 21:05:23 -0700484 const std::vector<std::string>& extra_args = {}) {
485 std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
486 std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700487 std::string app_image_file = GetScratchDir() + "/Test.art";
Andreas Gampe67f02822016-06-24 21:05:23 -0700488
489 Copy(GetDexSrc1(), dex_location);
490
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700491 std::vector<std::string> new_args(extra_args);
492 new_args.push_back("--app-image-file=" + app_image_file);
493 GenerateOdexForTest(dex_location, odex_location, filter, new_args);
Andreas Gampe67f02822016-06-24 21:05:23 -0700494
495 CheckValidity();
496 ASSERT_TRUE(success_);
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700497 CheckResult(dex_location,
498 odex_location,
499 app_image_file,
500 filter,
501 expect_large,
502 expect_downgrade);
Andreas Gampe67f02822016-06-24 21:05:23 -0700503 }
504
505 void CheckResult(const std::string& dex_location,
506 const std::string& odex_location,
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700507 const std::string& app_image_file,
Andreas Gampe67f02822016-06-24 21:05:23 -0700508 CompilerFilter::Filter filter,
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700509 bool expect_large,
510 bool expect_downgrade) {
511 if (expect_downgrade) {
512 EXPECT_TRUE(expect_large);
513 }
Andreas Gampe67f02822016-06-24 21:05:23 -0700514 // Host/target independent checks.
515 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100516 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100517 odex_location.c_str(),
Andreas Gampe67f02822016-06-24 21:05:23 -0700518 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100519 /*executable=*/ false,
520 /*low_4gb=*/ false,
Andreas Gampe67f02822016-06-24 21:05:23 -0700521 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100522 /*reservation=*/ nullptr,
Andreas Gampe67f02822016-06-24 21:05:23 -0700523 &error_msg));
524 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700525 EXPECT_GT(app_image_file.length(), 0u);
526 std::unique_ptr<File> file(OS::OpenFileForReading(app_image_file.c_str()));
Andreas Gampe67f02822016-06-24 21:05:23 -0700527 if (expect_large) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700528 // Note: we cannot check the following
529 // EXPECT_FALSE(CompilerFilter::IsAotCompilationEnabled(odex_file->GetCompilerFilter()));
Andreas Gampe67f02822016-06-24 21:05:23 -0700530 // The reason is that the filter override currently happens when the dex files are
531 // loaded in dex2oat, which is after the oat file has been started. Thus, the header
532 // store cannot be changed, and the original filter is set in stone.
533
534 for (const OatDexFile* oat_dex_file : odex_file->GetOatDexFiles()) {
535 std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg);
536 ASSERT_TRUE(dex_file != nullptr);
537 uint32_t class_def_count = dex_file->NumClassDefs();
538 ASSERT_LT(class_def_count, std::numeric_limits<uint16_t>::max());
539 for (uint16_t class_def_index = 0; class_def_index < class_def_count; ++class_def_index) {
540 OatFile::OatClass oat_class = oat_dex_file->GetOatClass(class_def_index);
541 EXPECT_EQ(oat_class.GetType(), OatClassType::kOatClassNoneCompiled);
542 }
543 }
544
545 // If the input filter was "below," it should have been used.
Nicolas Geoffray49cda062017-04-21 13:08:25 +0100546 if (!CompilerFilter::IsAsGoodAs(CompilerFilter::kExtract, filter)) {
Andreas Gampe67f02822016-06-24 21:05:23 -0700547 EXPECT_EQ(odex_file->GetCompilerFilter(), filter);
548 }
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700549
550 // If expect large, make sure the app image isn't generated or is empty.
551 if (file != nullptr) {
552 EXPECT_EQ(file->GetLength(), 0u);
553 }
Andreas Gampe67f02822016-06-24 21:05:23 -0700554 } else {
555 EXPECT_EQ(odex_file->GetCompilerFilter(), filter);
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700556 ASSERT_TRUE(file != nullptr) << app_image_file;
557 EXPECT_GT(file->GetLength(), 0u);
Andreas Gampe67f02822016-06-24 21:05:23 -0700558 }
559
560 // Host/target dependent checks.
561 if (kIsTargetBuild) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700562 CheckTargetResult(expect_downgrade);
Andreas Gampe67f02822016-06-24 21:05:23 -0700563 } else {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700564 CheckHostResult(expect_downgrade);
Andreas Gampe67f02822016-06-24 21:05:23 -0700565 }
566 }
567
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700568 void CheckTargetResult(bool expect_downgrade ATTRIBUTE_UNUSED) {
Andreas Gampe67f02822016-06-24 21:05:23 -0700569 // TODO: Ignore for now. May do something for fd things.
570 }
571
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700572 void CheckHostResult(bool expect_downgrade) {
Andreas Gampe67f02822016-06-24 21:05:23 -0700573 if (!kIsTargetBuild) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700574 if (expect_downgrade) {
575 EXPECT_NE(output_.find("Very large app, downgrading to"), std::string::npos) << output_;
Andreas Gampe67f02822016-06-24 21:05:23 -0700576 } else {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700577 EXPECT_EQ(output_.find("Very large app, downgrading to"), std::string::npos) << output_;
Andreas Gampe67f02822016-06-24 21:05:23 -0700578 }
579 }
580 }
581
582 // Check whether the dex2oat run was really successful.
583 void CheckValidity() {
584 if (kIsTargetBuild) {
585 CheckTargetValidity();
586 } else {
587 CheckHostValidity();
588 }
589 }
590
591 void CheckTargetValidity() {
592 // TODO: Ignore for now.
593 }
594
595 // On the host, we can get the dex2oat output. Here, look for "dex2oat took."
596 void CheckHostValidity() {
597 EXPECT_NE(output_.find("dex2oat took"), std::string::npos) << output_;
598 }
599};
600
601TEST_F(Dex2oatVeryLargeTest, DontUseVeryLarge) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700602 RunTest(CompilerFilter::kAssumeVerified, false, false);
603 RunTest(CompilerFilter::kExtract, false, false);
604 RunTest(CompilerFilter::kQuicken, false, false);
605 RunTest(CompilerFilter::kSpeed, false, false);
Andreas Gampe67f02822016-06-24 21:05:23 -0700606
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700607 RunTest(CompilerFilter::kAssumeVerified, false, false, { "--very-large-app-threshold=10000000" });
608 RunTest(CompilerFilter::kExtract, false, false, { "--very-large-app-threshold=10000000" });
609 RunTest(CompilerFilter::kQuicken, false, false, { "--very-large-app-threshold=10000000" });
610 RunTest(CompilerFilter::kSpeed, false, false, { "--very-large-app-threshold=10000000" });
Andreas Gampe67f02822016-06-24 21:05:23 -0700611}
612
613TEST_F(Dex2oatVeryLargeTest, UseVeryLarge) {
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700614 RunTest(CompilerFilter::kAssumeVerified, true, false, { "--very-large-app-threshold=100" });
615 RunTest(CompilerFilter::kExtract, true, false, { "--very-large-app-threshold=100" });
616 RunTest(CompilerFilter::kQuicken, true, true, { "--very-large-app-threshold=100" });
617 RunTest(CompilerFilter::kSpeed, true, true, { "--very-large-app-threshold=100" });
Andreas Gampe67f02822016-06-24 21:05:23 -0700618}
619
Mathieu Chartier97ab5e32017-02-22 13:35:44 -0800620// Regressin test for b/35665292.
621TEST_F(Dex2oatVeryLargeTest, SpeedProfileNoProfile) {
622 // Test that dex2oat doesn't crash with speed-profile but no input profile.
Mathieu Chartier8cce65a2017-08-17 00:06:39 -0700623 RunTest(CompilerFilter::kSpeedProfile, false, false);
Mathieu Chartier97ab5e32017-02-22 13:35:44 -0800624}
625
Jeff Hao608f2ce2016-10-19 11:17:11 -0700626class Dex2oatLayoutTest : public Dex2oatTest {
627 protected:
628 void CheckFilter(CompilerFilter::Filter input ATTRIBUTE_UNUSED,
Roland Levillainbbc6e7e2018-08-24 16:58:47 +0100629 CompilerFilter::Filter result ATTRIBUTE_UNUSED) override {
Jeff Hao608f2ce2016-10-19 11:17:11 -0700630 // Ignore, we'll do our own checks.
631 }
632
Jeff Hao41fba6a2016-11-28 11:53:33 -0800633 // Emits a profile with a single dex file with the given location and a single class index of 1.
634 void GenerateProfile(const std::string& test_profile,
635 const std::string& dex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800636 size_t num_classes,
Jeff Hao41fba6a2016-11-28 11:53:33 -0800637 uint32_t checksum) {
Andreas Gampedfcd82c2018-10-16 20:22:37 -0700638 int profile_test_fd = open(test_profile.c_str(),
639 O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
640 0644);
Jeff Hao41fba6a2016-11-28 11:53:33 -0800641 CHECK_GE(profile_test_fd, 0);
642
643 ProfileCompilationInfo info;
644 std::string profile_key = ProfileCompilationInfo::GetProfileDexFileKey(dex_location);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800645 for (size_t i = 0; i < num_classes; ++i) {
Mathieu Chartierea650f32017-05-24 12:04:13 -0700646 info.AddClassIndex(profile_key, checksum, dex::TypeIndex(1 + i), kMaxMethodIds);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800647 }
Jeff Hao41fba6a2016-11-28 11:53:33 -0800648 bool result = info.Save(profile_test_fd);
649 close(profile_test_fd);
650 ASSERT_TRUE(result);
651 }
652
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800653 void CompileProfileOdex(const std::string& dex_location,
654 const std::string& odex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800655 const std::string& app_image_file_name,
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800656 bool use_fd,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800657 size_t num_profile_classes,
Nicolas Geoffray97fa9922017-03-09 13:13:25 +0000658 const std::vector<std::string>& extra_args = {},
659 bool expect_success = true) {
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800660 const std::string profile_location = GetScratchDir() + "/primary.prof";
Jeff Hao41fba6a2016-11-28 11:53:33 -0800661 const char* location = dex_location.c_str();
662 std::string error_msg;
663 std::vector<std::unique_ptr<const DexFile>> dex_files;
David Sehr013fd802018-01-11 22:55:24 -0800664 const ArtDexFileLoader dex_file_loader;
665 ASSERT_TRUE(dex_file_loader.Open(
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100666 location, location, /*verify=*/ true, /*verify_checksum=*/ true, &error_msg, &dex_files));
Jeff Hao41fba6a2016-11-28 11:53:33 -0800667 EXPECT_EQ(dex_files.size(), 1U);
668 std::unique_ptr<const DexFile>& dex_file = dex_files[0];
Mathieu Chartier046854b2017-03-01 17:16:22 -0800669 GenerateProfile(profile_location,
670 dex_location,
671 num_profile_classes,
672 dex_file->GetLocationChecksum());
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800673 std::vector<std::string> copy(extra_args);
674 copy.push_back("--profile-file=" + profile_location);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800675 std::unique_ptr<File> app_image_file;
676 if (!app_image_file_name.empty()) {
677 if (use_fd) {
678 app_image_file.reset(OS::CreateEmptyFile(app_image_file_name.c_str()));
679 copy.push_back("--app-image-fd=" + std::to_string(app_image_file->Fd()));
680 } else {
681 copy.push_back("--app-image-file=" + app_image_file_name);
682 }
683 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800684 GenerateOdexForTest(dex_location,
685 odex_location,
686 CompilerFilter::kSpeedProfile,
687 copy,
Nicolas Geoffray97fa9922017-03-09 13:13:25 +0000688 expect_success,
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800689 use_fd);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800690 if (app_image_file != nullptr) {
691 ASSERT_EQ(app_image_file->FlushCloseOrErase(), 0) << "Could not flush and close art file";
692 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800693 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700694
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100695 uint64_t GetImageObjectSectionSize(const std::string& image_file_name) {
Mathieu Chartier046854b2017-03-01 17:16:22 -0800696 EXPECT_FALSE(image_file_name.empty());
697 std::unique_ptr<File> file(OS::OpenFileForReading(image_file_name.c_str()));
698 CHECK(file != nullptr);
699 ImageHeader image_header;
700 const bool success = file->ReadFully(&image_header, sizeof(image_header));
701 CHECK(success);
702 CHECK(image_header.IsValid());
703 ReaderMutexLock mu(Thread::Current(), *Locks::mutator_lock_);
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100704 return image_header.GetObjectsSection().Size();
Mathieu Chartier046854b2017-03-01 17:16:22 -0800705 }
706
707 void RunTest(bool app_image) {
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800708 std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
709 std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
Mathieu Chartier046854b2017-03-01 17:16:22 -0800710 std::string app_image_file = app_image ? (GetOdexDir() + "/DexOdexNoOat.art"): "";
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800711 Copy(GetDexSrc2(), dex_location);
712
Mathieu Chartier046854b2017-03-01 17:16:22 -0800713 uint64_t image_file_empty_profile = 0;
714 if (app_image) {
715 CompileProfileOdex(dex_location,
716 odex_location,
717 app_image_file,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100718 /*use_fd=*/ false,
719 /*num_profile_classes=*/ 0);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800720 CheckValidity();
721 ASSERT_TRUE(success_);
722 // Don't check the result since CheckResult relies on the class being in the profile.
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100723 image_file_empty_profile = GetImageObjectSectionSize(app_image_file);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800724 EXPECT_GT(image_file_empty_profile, 0u);
725 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700726
Mathieu Chartier046854b2017-03-01 17:16:22 -0800727 // Small profile.
728 CompileProfileOdex(dex_location,
729 odex_location,
730 app_image_file,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100731 /*use_fd=*/ false,
732 /*num_profile_classes=*/ 1);
Jeff Hao608f2ce2016-10-19 11:17:11 -0700733 CheckValidity();
734 ASSERT_TRUE(success_);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800735 CheckResult(dex_location, odex_location, app_image_file);
736
737 if (app_image) {
738 // Test that the profile made a difference by adding more classes.
Vladimir Marko6cfbdbc2017-07-25 13:26:39 +0100739 const uint64_t image_file_small_profile = GetImageObjectSectionSize(app_image_file);
740 ASSERT_LT(image_file_empty_profile, image_file_small_profile);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800741 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700742 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800743
744 void RunTestVDex() {
745 std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
746 std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
747 std::string vdex_location = GetOdexDir() + "/DexOdexNoOat.vdex";
Mathieu Chartier046854b2017-03-01 17:16:22 -0800748 std::string app_image_file_name = GetOdexDir() + "/DexOdexNoOat.art";
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800749 Copy(GetDexSrc2(), dex_location);
750
751 std::unique_ptr<File> vdex_file1(OS::CreateEmptyFile(vdex_location.c_str()));
752 CHECK(vdex_file1 != nullptr) << vdex_location;
753 ScratchFile vdex_file2;
754 {
755 std::string input_vdex = "--input-vdex-fd=-1";
756 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
757 CompileProfileOdex(dex_location,
758 odex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800759 app_image_file_name,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100760 /*use_fd=*/ true,
761 /*num_profile_classes=*/ 1,
Mathieu Chartierf1609832018-01-31 03:09:56 -0800762 { input_vdex, output_vdex });
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800763 EXPECT_GT(vdex_file1->GetLength(), 0u);
764 }
765 {
Nicolas Geoffray97fa9922017-03-09 13:13:25 +0000766 // Test that vdex and dexlayout fail gracefully.
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800767 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_file1->Fd());
768 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file2.GetFd());
769 CompileProfileOdex(dex_location,
770 odex_location,
Mathieu Chartier046854b2017-03-01 17:16:22 -0800771 app_image_file_name,
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100772 /*use_fd=*/ true,
773 /*num_profile_classes=*/ 1,
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800774 { input_vdex, output_vdex },
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100775 /*expect_success=*/ true);
Nicolas Geoffray4e868fa2017-04-21 17:16:44 +0100776 EXPECT_GT(vdex_file2.GetFile()->GetLength(), 0u);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800777 }
778 ASSERT_EQ(vdex_file1->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
779 CheckValidity();
Nicolas Geoffray4e868fa2017-04-21 17:16:44 +0100780 ASSERT_TRUE(success_);
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800781 }
782
Mathieu Chartier046854b2017-03-01 17:16:22 -0800783 void CheckResult(const std::string& dex_location,
784 const std::string& odex_location,
785 const std::string& app_image_file_name) {
Jeff Hao608f2ce2016-10-19 11:17:11 -0700786 // Host/target independent checks.
787 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100788 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100789 odex_location.c_str(),
Jeff Hao608f2ce2016-10-19 11:17:11 -0700790 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100791 /*executable=*/ false,
792 /*low_4gb=*/ false,
Jeff Hao608f2ce2016-10-19 11:17:11 -0700793 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100794 /*reservation=*/ nullptr,
Jeff Hao608f2ce2016-10-19 11:17:11 -0700795 &error_msg));
796 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
797
Jeff Hao042e8982016-10-19 11:17:11 -0700798 const char* location = dex_location.c_str();
799 std::vector<std::unique_ptr<const DexFile>> dex_files;
David Sehr013fd802018-01-11 22:55:24 -0800800 const ArtDexFileLoader dex_file_loader;
801 ASSERT_TRUE(dex_file_loader.Open(
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100802 location, location, /*verify=*/ true, /*verify_checksum=*/ true, &error_msg, &dex_files));
Jeff Hao042e8982016-10-19 11:17:11 -0700803 EXPECT_EQ(dex_files.size(), 1U);
804 std::unique_ptr<const DexFile>& old_dex_file = dex_files[0];
805
Jeff Hao608f2ce2016-10-19 11:17:11 -0700806 for (const OatDexFile* oat_dex_file : odex_file->GetOatDexFiles()) {
Jeff Hao042e8982016-10-19 11:17:11 -0700807 std::unique_ptr<const DexFile> new_dex_file = oat_dex_file->OpenDexFile(&error_msg);
808 ASSERT_TRUE(new_dex_file != nullptr);
809 uint32_t class_def_count = new_dex_file->NumClassDefs();
Jeff Hao608f2ce2016-10-19 11:17:11 -0700810 ASSERT_LT(class_def_count, std::numeric_limits<uint16_t>::max());
Jeff Hao042e8982016-10-19 11:17:11 -0700811 ASSERT_GE(class_def_count, 2U);
812
Mathieu Chartier24066ec2017-10-21 16:01:08 -0700813 // Make sure the indexes stay the same.
Jeff Hao042e8982016-10-19 11:17:11 -0700814 std::string old_class0 = old_dex_file->PrettyType(old_dex_file->GetClassDef(0).class_idx_);
815 std::string old_class1 = old_dex_file->PrettyType(old_dex_file->GetClassDef(1).class_idx_);
816 std::string new_class0 = new_dex_file->PrettyType(new_dex_file->GetClassDef(0).class_idx_);
817 std::string new_class1 = new_dex_file->PrettyType(new_dex_file->GetClassDef(1).class_idx_);
Mathieu Chartier24066ec2017-10-21 16:01:08 -0700818 EXPECT_EQ(old_class0, new_class0);
819 EXPECT_EQ(old_class1, new_class1);
Jeff Hao608f2ce2016-10-19 11:17:11 -0700820 }
821
Jeff Haoc155b052017-01-17 17:43:29 -0800822 EXPECT_EQ(odex_file->GetCompilerFilter(), CompilerFilter::kSpeedProfile);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800823
824 if (!app_image_file_name.empty()) {
825 // Go peek at the image header to make sure it was large enough to contain the class.
826 std::unique_ptr<File> file(OS::OpenFileForReading(app_image_file_name.c_str()));
827 ImageHeader image_header;
828 bool success = file->ReadFully(&image_header, sizeof(image_header));
829 ASSERT_TRUE(success);
830 ASSERT_TRUE(image_header.IsValid());
Vladimir Markocd87c3e2017-09-05 13:11:57 +0100831 EXPECT_GT(image_header.GetObjectsSection().Size(), 0u);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800832 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700833 }
834
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800835 // Check whether the dex2oat run was really successful.
836 void CheckValidity() {
837 if (kIsTargetBuild) {
838 CheckTargetValidity();
839 } else {
840 CheckHostValidity();
Jeff Hao608f2ce2016-10-19 11:17:11 -0700841 }
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800842 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700843
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800844 void CheckTargetValidity() {
845 // TODO: Ignore for now.
846 }
Jeff Hao608f2ce2016-10-19 11:17:11 -0700847
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800848 // On the host, we can get the dex2oat output. Here, look for "dex2oat took."
849 void CheckHostValidity() {
850 EXPECT_NE(output_.find("dex2oat took"), std::string::npos) << output_;
851 }
852};
Jeff Hao608f2ce2016-10-19 11:17:11 -0700853
854TEST_F(Dex2oatLayoutTest, TestLayout) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100855 RunTest(/*app_image=*/ false);
Mathieu Chartier046854b2017-03-01 17:16:22 -0800856}
857
858TEST_F(Dex2oatLayoutTest, TestLayoutAppImage) {
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100859 RunTest(/*app_image=*/ true);
Jeff Hao608f2ce2016-10-19 11:17:11 -0700860}
861
Mathieu Chartier8bc343b2017-03-01 15:20:30 -0800862TEST_F(Dex2oatLayoutTest, TestVdexLayout) {
863 RunTestVDex();
864}
865
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100866class Dex2oatUnquickenTest : public Dex2oatTest {
867 protected:
868 void RunUnquickenMultiDex() {
869 std::string dex_location = GetScratchDir() + "/UnquickenMultiDex.jar";
870 std::string odex_location = GetOdexDir() + "/UnquickenMultiDex.odex";
871 std::string vdex_location = GetOdexDir() + "/UnquickenMultiDex.vdex";
872 Copy(GetTestDexFileName("MultiDex"), dex_location);
873
874 std::unique_ptr<File> vdex_file1(OS::CreateEmptyFile(vdex_location.c_str()));
875 CHECK(vdex_file1 != nullptr) << vdex_location;
876 // Quicken the dex file into a vdex file.
877 {
878 std::string input_vdex = "--input-vdex-fd=-1";
879 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
880 GenerateOdexForTest(dex_location,
881 odex_location,
882 CompilerFilter::kQuicken,
Mathieu Chartierf1609832018-01-31 03:09:56 -0800883 { input_vdex, output_vdex },
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100884 /*expect_success=*/ true,
885 /*use_fd=*/ true);
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100886 EXPECT_GT(vdex_file1->GetLength(), 0u);
887 }
888 // Unquicken by running the verify compiler filter on the vdex file.
889 {
890 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_file1->Fd());
891 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
892 GenerateOdexForTest(dex_location,
893 odex_location,
894 CompilerFilter::kVerify,
Mathieu Chartier02129102017-12-22 11:04:01 -0800895 { input_vdex, output_vdex, kDisableCompactDex },
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100896 /*expect_success=*/ true,
897 /*use_fd=*/ true);
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100898 }
899 ASSERT_EQ(vdex_file1->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
900 CheckResult(dex_location, odex_location);
901 ASSERT_TRUE(success_);
902 }
903
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800904 void RunUnquickenMultiDexCDex() {
905 std::string dex_location = GetScratchDir() + "/UnquickenMultiDex.jar";
906 std::string odex_location = GetOdexDir() + "/UnquickenMultiDex.odex";
907 std::string odex_location2 = GetOdexDir() + "/UnquickenMultiDex2.odex";
908 std::string vdex_location = GetOdexDir() + "/UnquickenMultiDex.vdex";
909 std::string vdex_location2 = GetOdexDir() + "/UnquickenMultiDex2.vdex";
910 Copy(GetTestDexFileName("MultiDex"), dex_location);
911
912 std::unique_ptr<File> vdex_file1(OS::CreateEmptyFile(vdex_location.c_str()));
913 std::unique_ptr<File> vdex_file2(OS::CreateEmptyFile(vdex_location2.c_str()));
914 CHECK(vdex_file1 != nullptr) << vdex_location;
915 CHECK(vdex_file2 != nullptr) << vdex_location2;
916
917 // Quicken the dex file into a vdex file.
918 {
919 std::string input_vdex = "--input-vdex-fd=-1";
920 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file1->Fd());
921 GenerateOdexForTest(dex_location,
922 odex_location,
923 CompilerFilter::kQuicken,
924 { input_vdex, output_vdex, "--compact-dex-level=fast"},
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100925 /*expect_success=*/ true,
926 /*use_fd=*/ true);
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800927 EXPECT_GT(vdex_file1->GetLength(), 0u);
928 }
929
930 // Unquicken by running the verify compiler filter on the vdex file.
931 {
932 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_file1->Fd());
933 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_file2->Fd());
934 GenerateOdexForTest(dex_location,
935 odex_location2,
936 CompilerFilter::kVerify,
937 { input_vdex, output_vdex, "--compact-dex-level=none"},
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100938 /*expect_success=*/ true,
939 /*use_fd=*/ true);
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800940 }
941 ASSERT_EQ(vdex_file1->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
942 ASSERT_EQ(vdex_file2->FlushCloseOrErase(), 0) << "Could not flush and close vdex file";
943 CheckResult(dex_location, odex_location2);
944 ASSERT_TRUE(success_);
945 }
946
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100947 void CheckResult(const std::string& dex_location, const std::string& odex_location) {
948 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100949 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +0100950 odex_location.c_str(),
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100951 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100952 /*executable=*/ false,
953 /*low_4gb=*/ false,
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100954 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +0100955 /*reservation=*/ nullptr,
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100956 &error_msg));
957 ASSERT_TRUE(odex_file.get() != nullptr) << error_msg;
958 ASSERT_GE(odex_file->GetOatDexFiles().size(), 1u);
959
960 // Iterate over the dex files and ensure there is no quickened instruction.
961 for (const OatDexFile* oat_dex_file : odex_file->GetOatDexFiles()) {
962 std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg);
Mathieu Chartier2242ef12018-07-23 18:14:13 -0700963 for (ClassAccessor accessor : dex_file->GetClasses()) {
964 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
965 for (const DexInstructionPcPair& inst : method.GetInstructions()) {
966 ASSERT_FALSE(inst->IsQuickened()) << inst->Opcode() << " " << output_;
Nicolas Geoffrayb02ba932017-07-13 15:53:54 +0100967 }
968 }
969 }
970 }
971 }
972};
973
974TEST_F(Dex2oatUnquickenTest, UnquickenMultiDex) {
975 RunUnquickenMultiDex();
976}
977
Mathieu Chartierd27923c2018-02-08 21:00:03 -0800978TEST_F(Dex2oatUnquickenTest, UnquickenMultiDexCDex) {
979 RunUnquickenMultiDexCDex();
980}
981
Andreas Gampe2e8a2562017-01-18 20:39:02 -0800982class Dex2oatWatchdogTest : public Dex2oatTest {
983 protected:
984 void RunTest(bool expect_success, const std::vector<std::string>& extra_args = {}) {
985 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
986 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
987
988 Copy(GetTestDexFileName(), dex_location);
989
990 std::vector<std::string> copy(extra_args);
991
992 std::string swap_location = GetOdexDir() + "/Dex2OatSwapTest.odex.swap";
993 copy.push_back("--swap-file=" + swap_location);
Andreas Gampe22fa3762017-10-23 20:58:12 -0700994 copy.push_back("-j512"); // Excessive idle threads just slow down dex2oat.
Andreas Gampe2e8a2562017-01-18 20:39:02 -0800995 GenerateOdexForTest(dex_location,
996 odex_location,
997 CompilerFilter::kSpeed,
998 copy,
999 expect_success);
1000 }
1001
1002 std::string GetTestDexFileName() {
1003 return GetDexSrc1();
1004 }
1005};
1006
1007TEST_F(Dex2oatWatchdogTest, TestWatchdogOK) {
1008 // Check with default.
1009 RunTest(true);
1010
1011 // Check with ten minutes.
1012 RunTest(true, { "--watchdog-timeout=600000" });
1013}
1014
1015TEST_F(Dex2oatWatchdogTest, TestWatchdogTrigger) {
Andreas Gampe80ddf272018-01-11 09:41:00 -08001016 // The watchdog is independent of dex2oat and will not delete intermediates. It is possible
1017 // that the compilation succeeds and the file is completely written by the time the watchdog
1018 // kills dex2oat (but the dex2oat threads must have been scheduled pretty badly).
1019 test_accepts_odex_file_on_failure = true;
1020
Andreas Gampe2e8a2562017-01-18 20:39:02 -08001021 // Check with ten milliseconds.
1022 RunTest(false, { "--watchdog-timeout=10" });
1023}
1024
Andreas Gampef7882972017-03-20 16:35:24 -07001025class Dex2oatReturnCodeTest : public Dex2oatTest {
1026 protected:
1027 int RunTest(const std::vector<std::string>& extra_args = {}) {
1028 std::string dex_location = GetScratchDir() + "/Dex2OatSwapTest.jar";
1029 std::string odex_location = GetOdexDir() + "/Dex2OatSwapTest.odex";
1030
1031 Copy(GetTestDexFileName(), dex_location);
1032
1033 std::string error_msg;
Mathieu Chartier9e050df2017-08-09 10:05:47 -07001034 return GenerateOdexForTestWithStatus({dex_location},
Andreas Gampef7882972017-03-20 16:35:24 -07001035 odex_location,
1036 CompilerFilter::kSpeed,
1037 &error_msg,
1038 extra_args);
1039 }
1040
1041 std::string GetTestDexFileName() {
1042 return GetDexSrc1();
1043 }
1044};
1045
1046TEST_F(Dex2oatReturnCodeTest, TestCreateRuntime) {
Andreas Gampefd80b172017-04-26 22:25:31 -07001047 TEST_DISABLED_FOR_MEMORY_TOOL(); // b/19100793
Andreas Gampef7882972017-03-20 16:35:24 -07001048 int status = RunTest({ "--boot-image=/this/does/not/exist/yolo.oat" });
1049 EXPECT_EQ(static_cast<int>(dex2oat::ReturnCode::kCreateRuntime), WEXITSTATUS(status)) << output_;
1050}
1051
Calin Juravle1ce70852017-06-28 10:59:03 -07001052class Dex2oatClassLoaderContextTest : public Dex2oatTest {
1053 protected:
1054 void RunTest(const char* class_loader_context,
1055 const char* expected_classpath_key,
1056 bool expected_success,
1057 bool use_second_source = false) {
1058 std::string dex_location = GetUsedDexLocation();
1059 std::string odex_location = GetUsedOatLocation();
1060
1061 Copy(use_second_source ? GetDexSrc2() : GetDexSrc1(), dex_location);
1062
1063 std::string error_msg;
1064 std::vector<std::string> extra_args;
1065 if (class_loader_context != nullptr) {
1066 extra_args.push_back(std::string("--class-loader-context=") + class_loader_context);
1067 }
1068 auto check_oat = [expected_classpath_key](const OatFile& oat_file) {
1069 ASSERT_TRUE(expected_classpath_key != nullptr);
1070 const char* classpath = oat_file.GetOatHeader().GetStoreValueByKey(OatHeader::kClassPathKey);
1071 ASSERT_TRUE(classpath != nullptr);
1072 ASSERT_STREQ(expected_classpath_key, classpath);
1073 };
1074
1075 GenerateOdexForTest(dex_location,
1076 odex_location,
1077 CompilerFilter::kQuicken,
1078 extra_args,
1079 expected_success,
1080 /*use_fd*/ false,
1081 check_oat);
1082 }
1083
1084 std::string GetUsedDexLocation() {
1085 return GetScratchDir() + "/Context.jar";
1086 }
1087
1088 std::string GetUsedOatLocation() {
1089 return GetOdexDir() + "/Context.odex";
1090 }
1091
Calin Juravle7b0648a2017-07-07 18:40:50 -07001092 const char* kEmptyClassPathKey = "PCL[]";
Calin Juravle1ce70852017-06-28 10:59:03 -07001093};
1094
1095TEST_F(Dex2oatClassLoaderContextTest, InvalidContext) {
1096 RunTest("Invalid[]", /*expected_classpath_key*/ nullptr, /*expected_success*/ false);
1097}
1098
1099TEST_F(Dex2oatClassLoaderContextTest, EmptyContext) {
1100 RunTest("PCL[]", kEmptyClassPathKey, /*expected_success*/ true);
1101}
1102
1103TEST_F(Dex2oatClassLoaderContextTest, SpecialContext) {
1104 RunTest(OatFile::kSpecialSharedLibrary,
1105 OatFile::kSpecialSharedLibrary,
1106 /*expected_success*/ true);
1107}
1108
1109TEST_F(Dex2oatClassLoaderContextTest, ContextWithTheSourceDexFiles) {
1110 std::string context = "PCL[" + GetUsedDexLocation() + "]";
1111 RunTest(context.c_str(), kEmptyClassPathKey, /*expected_success*/ true);
1112}
1113
1114TEST_F(Dex2oatClassLoaderContextTest, ContextWithOtherDexFiles) {
1115 std::vector<std::unique_ptr<const DexFile>> dex_files = OpenTestDexFiles("Nested");
Calin Juravle1ce70852017-06-28 10:59:03 -07001116
1117 std::string context = "PCL[" + dex_files[0]->GetLocation() + "]";
Calin Juravle7b0648a2017-07-07 18:40:50 -07001118 std::string expected_classpath_key = "PCL[" +
1119 dex_files[0]->GetLocation() + "*" + std::to_string(dex_files[0]->GetLocationChecksum()) + "]";
Calin Juravle1ce70852017-06-28 10:59:03 -07001120 RunTest(context.c_str(), expected_classpath_key.c_str(), true);
1121}
1122
1123TEST_F(Dex2oatClassLoaderContextTest, ContextWithStrippedDexFiles) {
1124 std::string stripped_classpath = GetScratchDir() + "/stripped_classpath.jar";
1125 Copy(GetStrippedDexSrc1(), stripped_classpath);
1126
1127 std::string context = "PCL[" + stripped_classpath + "]";
1128 // Expect an empty context because stripped dex files cannot be open.
Calin Juravle7b0648a2017-07-07 18:40:50 -07001129 RunTest(context.c_str(), kEmptyClassPathKey , /*expected_success*/ true);
Calin Juravle1ce70852017-06-28 10:59:03 -07001130}
1131
1132TEST_F(Dex2oatClassLoaderContextTest, ContextWithStrippedDexFilesBackedByOdex) {
1133 std::string stripped_classpath = GetScratchDir() + "/stripped_classpath.jar";
1134 std::string odex_for_classpath = GetOdexDir() + "/stripped_classpath.odex";
1135
1136 Copy(GetDexSrc1(), stripped_classpath);
1137
1138 GenerateOdexForTest(stripped_classpath,
1139 odex_for_classpath,
1140 CompilerFilter::kQuicken,
1141 {},
1142 true);
1143
1144 // Strip the dex file
1145 Copy(GetStrippedDexSrc1(), stripped_classpath);
1146
1147 std::string context = "PCL[" + stripped_classpath + "]";
Calin Juravle7b0648a2017-07-07 18:40:50 -07001148 std::string expected_classpath_key;
Calin Juravle1ce70852017-06-28 10:59:03 -07001149 {
1150 // Open the oat file to get the expected classpath.
Nicolas Geoffray29742602017-12-14 10:09:03 +00001151 OatFileAssistant oat_file_assistant(stripped_classpath.c_str(), kRuntimeISA, false, false);
Calin Juravle1ce70852017-06-28 10:59:03 -07001152 std::unique_ptr<OatFile> oat_file(oat_file_assistant.GetBestOatFile());
1153 std::vector<std::unique_ptr<const DexFile>> oat_dex_files =
1154 OatFileAssistant::LoadDexFiles(*oat_file, stripped_classpath.c_str());
Calin Juravle7b0648a2017-07-07 18:40:50 -07001155 expected_classpath_key = "PCL[";
1156 for (size_t i = 0; i < oat_dex_files.size(); i++) {
1157 if (i > 0) {
1158 expected_classpath_key + ":";
1159 }
1160 expected_classpath_key += oat_dex_files[i]->GetLocation() + "*" +
1161 std::to_string(oat_dex_files[i]->GetLocationChecksum());
1162 }
1163 expected_classpath_key += "]";
Calin Juravle1ce70852017-06-28 10:59:03 -07001164 }
1165
1166 RunTest(context.c_str(),
Calin Juravle7b0648a2017-07-07 18:40:50 -07001167 expected_classpath_key.c_str(),
Calin Juravle1ce70852017-06-28 10:59:03 -07001168 /*expected_success*/ true,
1169 /*use_second_source*/ true);
1170}
1171
1172TEST_F(Dex2oatClassLoaderContextTest, ContextWithNotExistentDexFiles) {
1173 std::string context = "PCL[does_not_exists.dex]";
1174 // Expect an empty context because stripped dex files cannot be open.
1175 RunTest(context.c_str(), kEmptyClassPathKey, /*expected_success*/ true);
1176}
1177
Calin Juravlec79470d2017-07-12 17:37:42 -07001178TEST_F(Dex2oatClassLoaderContextTest, ChainContext) {
1179 std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Nested");
1180 std::vector<std::unique_ptr<const DexFile>> dex_files2 = OpenTestDexFiles("MultiDex");
1181
1182 std::string context = "PCL[" + GetTestDexFileName("Nested") + "];" +
1183 "DLC[" + GetTestDexFileName("MultiDex") + "]";
1184 std::string expected_classpath_key = "PCL[" + CreateClassPathWithChecksums(dex_files1) + "];" +
1185 "DLC[" + CreateClassPathWithChecksums(dex_files2) + "]";
1186
1187 RunTest(context.c_str(), expected_classpath_key.c_str(), true);
1188}
1189
Mathieu Chartier9e050df2017-08-09 10:05:47 -07001190class Dex2oatDeterminism : public Dex2oatTest {};
1191
1192TEST_F(Dex2oatDeterminism, UnloadCompile) {
1193 if (!kUseReadBarrier &&
1194 gc::kCollectorTypeDefault != gc::kCollectorTypeCMS &&
1195 gc::kCollectorTypeDefault != gc::kCollectorTypeMS) {
1196 LOG(INFO) << "Test requires determinism support.";
1197 return;
1198 }
1199 Runtime* const runtime = Runtime::Current();
1200 std::string out_dir = GetScratchDir();
1201 const std::string base_oat_name = out_dir + "/base.oat";
1202 const std::string base_vdex_name = out_dir + "/base.vdex";
1203 const std::string unload_oat_name = out_dir + "/unload.oat";
1204 const std::string unload_vdex_name = out_dir + "/unload.vdex";
1205 const std::string no_unload_oat_name = out_dir + "/nounload.oat";
1206 const std::string no_unload_vdex_name = out_dir + "/nounload.vdex";
1207 const std::string app_image_name = out_dir + "/unload.art";
1208 std::string error_msg;
1209 const std::vector<gc::space::ImageSpace*>& spaces = runtime->GetHeap()->GetBootImageSpaces();
1210 ASSERT_GT(spaces.size(), 0u);
1211 const std::string image_location = spaces[0]->GetImageLocation();
1212 // Without passing in an app image, it will unload in between compilations.
1213 const int res = GenerateOdexForTestWithStatus(
1214 GetLibCoreDexFileNames(),
1215 base_oat_name,
1216 CompilerFilter::Filter::kQuicken,
1217 &error_msg,
1218 {"--force-determinism", "--avoid-storing-invocation"});
1219 EXPECT_EQ(res, 0);
1220 Copy(base_oat_name, unload_oat_name);
1221 Copy(base_vdex_name, unload_vdex_name);
1222 std::unique_ptr<File> unload_oat(OS::OpenFileForReading(unload_oat_name.c_str()));
1223 std::unique_ptr<File> unload_vdex(OS::OpenFileForReading(unload_vdex_name.c_str()));
1224 ASSERT_TRUE(unload_oat != nullptr);
1225 ASSERT_TRUE(unload_vdex != nullptr);
1226 EXPECT_GT(unload_oat->GetLength(), 0u);
1227 EXPECT_GT(unload_vdex->GetLength(), 0u);
1228 // Regenerate with an app image to disable the dex2oat unloading and verify that the output is
1229 // the same.
1230 const int res2 = GenerateOdexForTestWithStatus(
1231 GetLibCoreDexFileNames(),
1232 base_oat_name,
1233 CompilerFilter::Filter::kQuicken,
1234 &error_msg,
1235 {"--force-determinism", "--avoid-storing-invocation", "--app-image-file=" + app_image_name});
1236 EXPECT_EQ(res2, 0);
1237 Copy(base_oat_name, no_unload_oat_name);
1238 Copy(base_vdex_name, no_unload_vdex_name);
1239 std::unique_ptr<File> no_unload_oat(OS::OpenFileForReading(no_unload_oat_name.c_str()));
1240 std::unique_ptr<File> no_unload_vdex(OS::OpenFileForReading(no_unload_vdex_name.c_str()));
1241 ASSERT_TRUE(no_unload_oat != nullptr);
1242 ASSERT_TRUE(no_unload_vdex != nullptr);
1243 EXPECT_GT(no_unload_oat->GetLength(), 0u);
1244 EXPECT_GT(no_unload_vdex->GetLength(), 0u);
1245 // Verify that both of the files are the same (odex and vdex).
1246 EXPECT_EQ(unload_oat->GetLength(), no_unload_oat->GetLength());
1247 EXPECT_EQ(unload_vdex->GetLength(), no_unload_vdex->GetLength());
1248 EXPECT_EQ(unload_oat->Compare(no_unload_oat.get()), 0)
1249 << unload_oat_name << " " << no_unload_oat_name;
1250 EXPECT_EQ(unload_vdex->Compare(no_unload_vdex.get()), 0)
1251 << unload_vdex_name << " " << no_unload_vdex_name;
1252 // App image file.
1253 std::unique_ptr<File> app_image_file(OS::OpenFileForReading(app_image_name.c_str()));
1254 ASSERT_TRUE(app_image_file != nullptr);
1255 EXPECT_GT(app_image_file->GetLength(), 0u);
1256}
1257
Mathieu Chartier120aa282017-08-05 16:03:03 -07001258// Test that dexlayout section info is correctly written to the oat file for profile based
1259// compilation.
1260TEST_F(Dex2oatTest, LayoutSections) {
1261 using Hotness = ProfileCompilationInfo::MethodHotness;
1262 std::unique_ptr<const DexFile> dex(OpenTestDexFile("ManyMethods"));
1263 ScratchFile profile_file;
1264 // We can only layout method indices with code items, figure out which ones have this property
1265 // first.
1266 std::vector<uint16_t> methods;
1267 {
1268 const DexFile::TypeId* type_id = dex->FindTypeId("LManyMethods;");
1269 dex::TypeIndex type_idx = dex->GetIndexForTypeId(*type_id);
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001270 ClassAccessor accessor(*dex, *dex->FindClassDef(type_idx));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001271 std::set<size_t> code_item_offsets;
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001272 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1273 const uint16_t method_idx = method.GetIndex();
1274 const size_t code_item_offset = method.GetCodeItemOffset();
Mathieu Chartier120aa282017-08-05 16:03:03 -07001275 if (code_item_offsets.insert(code_item_offset).second) {
1276 // Unique code item, add the method index.
1277 methods.push_back(method_idx);
1278 }
1279 }
Mathieu Chartier120aa282017-08-05 16:03:03 -07001280 }
1281 ASSERT_GE(methods.size(), 8u);
1282 std::vector<uint16_t> hot_methods = {methods[1], methods[3], methods[5]};
1283 std::vector<uint16_t> startup_methods = {methods[1], methods[2], methods[7]};
1284 std::vector<uint16_t> post_methods = {methods[0], methods[2], methods[6]};
1285 // Here, we build the profile from the method lists.
1286 ProfileCompilationInfo info;
1287 info.AddMethodsForDex(
1288 static_cast<Hotness::Flag>(Hotness::kFlagHot | Hotness::kFlagStartup),
1289 dex.get(),
1290 hot_methods.begin(),
1291 hot_methods.end());
1292 info.AddMethodsForDex(
1293 Hotness::kFlagStartup,
1294 dex.get(),
1295 startup_methods.begin(),
1296 startup_methods.end());
1297 info.AddMethodsForDex(
1298 Hotness::kFlagPostStartup,
1299 dex.get(),
1300 post_methods.begin(),
1301 post_methods.end());
1302 for (uint16_t id : hot_methods) {
1303 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsHot());
1304 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsStartup());
1305 }
1306 for (uint16_t id : startup_methods) {
1307 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsStartup());
1308 }
1309 for (uint16_t id : post_methods) {
1310 EXPECT_TRUE(info.GetMethodHotness(MethodReference(dex.get(), id)).IsPostStartup());
1311 }
1312 // Save the profile since we want to use it with dex2oat to produce an oat file.
1313 ASSERT_TRUE(info.Save(profile_file.GetFd()));
1314 // Generate a profile based odex.
1315 const std::string dir = GetScratchDir();
1316 const std::string oat_filename = dir + "/base.oat";
1317 const std::string vdex_filename = dir + "/base.vdex";
1318 std::string error_msg;
1319 const int res = GenerateOdexForTestWithStatus(
1320 {dex->GetLocation()},
1321 oat_filename,
1322 CompilerFilter::Filter::kQuicken,
1323 &error_msg,
1324 {"--profile-file=" + profile_file.GetFilename()});
1325 EXPECT_EQ(res, 0);
1326
1327 // Open our generated oat file.
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001328 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001329 oat_filename.c_str(),
Mathieu Chartier120aa282017-08-05 16:03:03 -07001330 oat_filename.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001331 /*executable=*/ false,
1332 /*low_4gb=*/ false,
Mathieu Chartier120aa282017-08-05 16:03:03 -07001333 dex->GetLocation().c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001334 /*reservation=*/ nullptr,
Mathieu Chartier120aa282017-08-05 16:03:03 -07001335 &error_msg));
1336 ASSERT_TRUE(odex_file != nullptr);
1337 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
1338 ASSERT_EQ(oat_dex_files.size(), 1u);
1339 // Check that the code sections match what we expect.
1340 for (const OatDexFile* oat_dex : oat_dex_files) {
1341 const DexLayoutSections* const sections = oat_dex->GetDexLayoutSections();
1342 // Testing of logging the sections.
1343 ASSERT_TRUE(sections != nullptr);
1344 LOG(INFO) << *sections;
1345
1346 // Load the sections into temporary variables for convenience.
1347 const DexLayoutSection& code_section =
1348 sections->sections_[static_cast<size_t>(DexLayoutSections::SectionType::kSectionTypeCode)];
1349 const DexLayoutSection::Subsection& section_hot_code =
1350 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeHot)];
1351 const DexLayoutSection::Subsection& section_sometimes_used =
1352 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeSometimesUsed)];
1353 const DexLayoutSection::Subsection& section_startup_only =
1354 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeStartupOnly)];
1355 const DexLayoutSection::Subsection& section_unused =
1356 code_section.parts_[static_cast<size_t>(LayoutType::kLayoutTypeUnused)];
1357
1358 // All the sections should be non-empty.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001359 EXPECT_GT(section_hot_code.Size(), 0u);
1360 EXPECT_GT(section_sometimes_used.Size(), 0u);
1361 EXPECT_GT(section_startup_only.Size(), 0u);
1362 EXPECT_GT(section_unused.Size(), 0u);
Mathieu Chartier120aa282017-08-05 16:03:03 -07001363
1364 // Open the dex file since we need to peek at the code items to verify the layout matches what
1365 // we expect.
1366 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1367 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1368 const DexFile::TypeId* type_id = dex_file->FindTypeId("LManyMethods;");
1369 ASSERT_TRUE(type_id != nullptr);
1370 dex::TypeIndex type_idx = dex_file->GetIndexForTypeId(*type_id);
1371 const DexFile::ClassDef* class_def = dex_file->FindClassDef(type_idx);
1372 ASSERT_TRUE(class_def != nullptr);
1373
1374 // Count how many code items are for each category, there should be at least one per category.
1375 size_t hot_count = 0;
1376 size_t post_startup_count = 0;
1377 size_t startup_count = 0;
1378 size_t unused_count = 0;
1379 // Visit all of the methdos of the main class and cross reference the method indices to their
1380 // corresponding code item offsets to verify the layout.
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001381 ClassAccessor accessor(*dex_file, *class_def);
1382 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1383 const size_t method_idx = method.GetIndex();
1384 const size_t code_item_offset = method.GetCodeItemOffset();
Mathieu Chartier120aa282017-08-05 16:03:03 -07001385 const bool is_hot = ContainsElement(hot_methods, method_idx);
1386 const bool is_startup = ContainsElement(startup_methods, method_idx);
1387 const bool is_post_startup = ContainsElement(post_methods, method_idx);
1388 if (is_hot) {
1389 // Hot is highest precedence, check that the hot methods are in the hot section.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001390 EXPECT_TRUE(section_hot_code.Contains(code_item_offset));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001391 ++hot_count;
1392 } else if (is_post_startup) {
1393 // Post startup is sometimes used section.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001394 EXPECT_TRUE(section_sometimes_used.Contains(code_item_offset));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001395 ++post_startup_count;
1396 } else if (is_startup) {
1397 // Startup at this point means not hot or post startup, these must be startup only then.
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001398 EXPECT_TRUE(section_startup_only.Contains(code_item_offset));
Mathieu Chartier120aa282017-08-05 16:03:03 -07001399 ++startup_count;
1400 } else {
Mathieu Chartier3e0c5172017-11-12 12:58:40 -08001401 if (section_unused.Contains(code_item_offset)) {
Alan Leung9595fd32017-10-17 17:08:19 -07001402 // If no flags are set, the method should be unused ...
1403 ++unused_count;
1404 } else {
1405 // or this method is part of the last code item and the end is 4 byte aligned.
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001406 for (const ClassAccessor::Method& method2 : accessor.GetMethods()) {
1407 EXPECT_LE(method2.GetCodeItemOffset(), code_item_offset);
Alan Leung9595fd32017-10-17 17:08:19 -07001408 }
1409 uint32_t code_item_size = dex_file->FindCodeItemOffset(*class_def, method_idx);
1410 EXPECT_EQ((code_item_offset + code_item_size) % 4, 0u);
1411 }
Mathieu Chartier120aa282017-08-05 16:03:03 -07001412 }
1413 }
Mathieu Chartier120aa282017-08-05 16:03:03 -07001414 EXPECT_GT(hot_count, 0u);
1415 EXPECT_GT(post_startup_count, 0u);
1416 EXPECT_GT(startup_count, 0u);
1417 EXPECT_GT(unused_count, 0u);
1418 }
1419}
1420
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001421// Test that generating compact dex works.
1422TEST_F(Dex2oatTest, GenerateCompactDex) {
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001423 // Generate a compact dex based odex.
1424 const std::string dir = GetScratchDir();
1425 const std::string oat_filename = dir + "/base.oat";
1426 const std::string vdex_filename = dir + "/base.vdex";
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001427 const std::string dex_location = GetTestDexFileName("MultiDex");
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001428 std::string error_msg;
1429 const int res = GenerateOdexForTestWithStatus(
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001430 { dex_location },
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001431 oat_filename,
1432 CompilerFilter::Filter::kQuicken,
1433 &error_msg,
1434 {"--compact-dex-level=fast"});
1435 EXPECT_EQ(res, 0);
1436 // Open our generated oat file.
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001437 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001438 oat_filename.c_str(),
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001439 oat_filename.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001440 /*executable=*/ false,
1441 /*low_4gb=*/ false,
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001442 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001443 /*reservation=*/ nullptr,
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001444 &error_msg));
1445 ASSERT_TRUE(odex_file != nullptr);
1446 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001447 ASSERT_GT(oat_dex_files.size(), 1u);
1448 // Check that each dex is a compact dex file.
1449 std::vector<std::unique_ptr<const CompactDexFile>> compact_dex_files;
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001450 for (const OatDexFile* oat_dex : oat_dex_files) {
1451 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1452 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1453 ASSERT_TRUE(dex_file->IsCompactDexFile());
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001454 compact_dex_files.push_back(
1455 std::unique_ptr<const CompactDexFile>(dex_file.release()->AsCompactDexFile()));
1456 }
1457 for (const std::unique_ptr<const CompactDexFile>& dex_file : compact_dex_files) {
1458 // Test that every code item is in the owned section.
1459 const CompactDexFile::Header& header = dex_file->GetHeader();
1460 EXPECT_LE(header.OwnedDataBegin(), header.OwnedDataEnd());
1461 EXPECT_LE(header.OwnedDataBegin(), header.data_size_);
1462 EXPECT_LE(header.OwnedDataEnd(), header.data_size_);
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001463 for (ClassAccessor accessor : dex_file->GetClasses()) {
1464 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1465 if (method.GetCodeItemOffset() != 0u) {
1466 ASSERT_GE(method.GetCodeItemOffset(), header.OwnedDataBegin());
1467 ASSERT_LT(method.GetCodeItemOffset(), header.OwnedDataEnd());
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001468 }
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001469 }
Mathieu Chartierc17b7d82018-03-14 14:00:04 -07001470 }
1471 // Test that the owned sections don't overlap.
1472 for (const std::unique_ptr<const CompactDexFile>& other_dex : compact_dex_files) {
1473 if (dex_file != other_dex) {
1474 ASSERT_TRUE(
1475 (dex_file->GetHeader().OwnedDataBegin() >= other_dex->GetHeader().OwnedDataEnd()) ||
1476 (dex_file->GetHeader().OwnedDataEnd() <= other_dex->GetHeader().OwnedDataBegin()));
1477 }
1478 }
Mathieu Chartier603ccab2017-10-20 14:34:28 -07001479 }
1480}
1481
Andreas Gampef39208f2017-10-19 15:06:59 -07001482class Dex2oatVerifierAbort : public Dex2oatTest {};
1483
1484TEST_F(Dex2oatVerifierAbort, HardFail) {
1485 // Use VerifierDeps as it has hard-failing classes.
1486 std::unique_ptr<const DexFile> dex(OpenTestDexFile("VerifierDeps"));
1487 std::string out_dir = GetScratchDir();
1488 const std::string base_oat_name = out_dir + "/base.oat";
1489 std::string error_msg;
1490 const int res_fail = GenerateOdexForTestWithStatus(
1491 {dex->GetLocation()},
1492 base_oat_name,
1493 CompilerFilter::Filter::kQuicken,
1494 &error_msg,
1495 {"--abort-on-hard-verifier-error"});
1496 EXPECT_NE(0, res_fail);
1497
1498 const int res_no_fail = GenerateOdexForTestWithStatus(
1499 {dex->GetLocation()},
1500 base_oat_name,
1501 CompilerFilter::Filter::kQuicken,
1502 &error_msg,
1503 {"--no-abort-on-hard-verifier-error"});
1504 EXPECT_EQ(0, res_no_fail);
1505}
1506
1507TEST_F(Dex2oatVerifierAbort, SoftFail) {
1508 // Use VerifierDepsMulti as it has hard-failing classes.
1509 std::unique_ptr<const DexFile> dex(OpenTestDexFile("VerifierDepsMulti"));
1510 std::string out_dir = GetScratchDir();
1511 const std::string base_oat_name = out_dir + "/base.oat";
1512 std::string error_msg;
1513 const int res_fail = GenerateOdexForTestWithStatus(
1514 {dex->GetLocation()},
1515 base_oat_name,
1516 CompilerFilter::Filter::kQuicken,
1517 &error_msg,
1518 {"--abort-on-soft-verifier-error"});
1519 EXPECT_NE(0, res_fail);
1520
1521 const int res_no_fail = GenerateOdexForTestWithStatus(
1522 {dex->GetLocation()},
1523 base_oat_name,
1524 CompilerFilter::Filter::kQuicken,
1525 &error_msg,
1526 {"--no-abort-on-soft-verifier-error"});
1527 EXPECT_EQ(0, res_no_fail);
1528}
1529
Andreas Gampecac31ad2017-11-06 20:01:17 -08001530class Dex2oatDedupeCode : public Dex2oatTest {};
1531
1532TEST_F(Dex2oatDedupeCode, DedupeTest) {
1533 // Use MyClassNatives. It has lots of native methods that will produce deduplicate-able code.
1534 std::unique_ptr<const DexFile> dex(OpenTestDexFile("MyClassNatives"));
1535 std::string out_dir = GetScratchDir();
1536 const std::string base_oat_name = out_dir + "/base.oat";
1537 size_t no_dedupe_size = 0;
1538 GenerateOdexForTest(dex->GetLocation(),
1539 base_oat_name,
1540 CompilerFilter::Filter::kSpeed,
1541 { "--deduplicate-code=false" },
1542 true, // expect_success
1543 false, // use_fd
1544 [&no_dedupe_size](const OatFile& o) {
1545 no_dedupe_size = o.Size();
1546 });
1547
1548 size_t dedupe_size = 0;
1549 GenerateOdexForTest(dex->GetLocation(),
1550 base_oat_name,
1551 CompilerFilter::Filter::kSpeed,
1552 { "--deduplicate-code=true" },
1553 true, // expect_success
1554 false, // use_fd
1555 [&dedupe_size](const OatFile& o) {
1556 dedupe_size = o.Size();
1557 });
1558
1559 EXPECT_LT(dedupe_size, no_dedupe_size);
1560}
1561
Nicolas Geoffrayf3075272018-01-08 12:41:19 +00001562TEST_F(Dex2oatTest, UncompressedTest) {
1563 std::unique_ptr<const DexFile> dex(OpenTestDexFile("MainUncompressed"));
1564 std::string out_dir = GetScratchDir();
1565 const std::string base_oat_name = out_dir + "/base.oat";
1566 GenerateOdexForTest(dex->GetLocation(),
1567 base_oat_name,
1568 CompilerFilter::Filter::kQuicken,
1569 { },
1570 true, // expect_success
1571 false, // use_fd
1572 [](const OatFile& o) {
1573 CHECK(!o.ContainsDexCode());
1574 });
1575}
1576
Mathieu Chartier700a9852018-02-06 18:27:38 -08001577TEST_F(Dex2oatTest, EmptyUncompressedDexTest) {
1578 std::string out_dir = GetScratchDir();
1579 const std::string base_oat_name = out_dir + "/base.oat";
1580 std::string error_msg;
1581 int status = GenerateOdexForTestWithStatus(
1582 { GetTestDexFileName("MainEmptyUncompressed") },
1583 base_oat_name,
1584 CompilerFilter::Filter::kQuicken,
1585 &error_msg,
1586 { },
1587 /*use_fd*/ false);
1588 // Expect to fail with code 1 and not SIGSEGV or SIGABRT.
1589 ASSERT_TRUE(WIFEXITED(status));
1590 ASSERT_EQ(WEXITSTATUS(status), 1) << error_msg;
1591}
1592
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001593// Dex file that has duplicate methods have different code items and debug info.
1594static const char kDuplicateMethodInputDex[] =
1595 "ZGV4CjAzOQDEy8VPdj4qHpgPYFWtLCtOykfFP4kB8tGYDAAAcAAAAHhWNBIAAAAAAAAAANALAABI"
1596 "AAAAcAAAAA4AAACQAQAABQAAAMgBAAANAAAABAIAABkAAABsAgAABAAAADQDAADgCAAAuAMAADgI"
1597 "AABCCAAASggAAE8IAABcCAAAaggAAHkIAACICAAAlggAAKQIAACyCAAAwAgAAM4IAADcCAAA6ggA"
1598 "APgIAAD7CAAA/wgAABcJAAAuCQAARQkAAFQJAAB4CQAAmAkAALsJAADSCQAA5gkAAPoJAAAVCgAA"
1599 "KQoAADsKAABCCgAASgoAAFIKAABbCgAAZAoAAGwKAAB0CgAAfAoAAIQKAACMCgAAlAoAAJwKAACk"
1600 "CgAArQoAALcKAADACgAAwwoAAMcKAADcCgAA6QoAAPEKAAD3CgAA/QoAAAMLAAAJCwAAEAsAABcL"
1601 "AAAdCwAAIwsAACkLAAAvCwAANQsAADsLAABBCwAARwsAAE0LAABSCwAAWwsAAF4LAABoCwAAbwsA"
1602 "ABEAAAASAAAAEwAAABQAAAAVAAAAFgAAABcAAAAYAAAAGQAAABoAAAAbAAAAHAAAAC4AAAAwAAAA"
1603 "DwAAAAkAAAAAAAAAEAAAAAoAAACoBwAALgAAAAwAAAAAAAAALwAAAAwAAACoBwAALwAAAAwAAACw"
1604 "BwAAAgAJADUAAAACAAkANgAAAAIACQA3AAAAAgAJADgAAAACAAkAOQAAAAIACQA6AAAAAgAJADsA"
1605 "AAACAAkAPAAAAAIACQA9AAAAAgAJAD4AAAACAAkAPwAAAAIACQBAAAAACwAHAEIAAAAAAAIAAQAA"
1606 "AAAAAwAeAAAAAQACAAEAAAABAAMAHgAAAAIAAgAAAAAAAgACAAEAAAADAAIAAQAAAAMAAgAfAAAA"
1607 "AwACACAAAAADAAIAIQAAAAMAAgAiAAAAAwACACMAAAADAAIAJAAAAAMAAgAlAAAAAwACACYAAAAD"
1608 "AAIAJwAAAAMAAgAoAAAAAwACACkAAAADAAIAKgAAAAMABAA0AAAABwADAEMAAAAIAAIAAQAAAAoA"
1609 "AgABAAAACgABADIAAAAKAAAARQAAAAAAAAAAAAAACAAAAAAAAAAdAAAAaAcAALYHAAAAAAAAAQAA"
1610 "AAAAAAAIAAAAAAAAAB0AAAB4BwAAxAcAAAAAAAACAAAAAAAAAAgAAAAAAAAAHQAAAIgHAADSBwAA"
1611 "AAAAAAMAAAAAAAAACAAAAAAAAAAdAAAAmAcAAPoHAAAAAAAAAAAAAAEAAAAAAAAArAYAADEAAAAa"
1612 "AAMAaQAAABoABABpAAEAGgAHAGkABAAaAAgAaQAFABoACQBpAAYAGgAKAGkABwAaAAsAaQAIABoA"
1613 "DABpAAkAGgANAGkACgAaAA4AaQALABoABQBpAAIAGgAGAGkAAwAOAAAAAQABAAEAAACSBgAABAAA"
1614 "AHAQFQAAAA4ABAABAAIAAACWBgAAFwAAAGIADAAiAQoAcBAWAAEAGgICAG4gFwAhAG4gFwAxAG4Q"
1615 "GAABAAwBbiAUABAADgAAAAEAAQABAAAAngYAAAQAAABwEBUAAAAOAAIAAQACAAAAogYAAAYAAABi"
1616 "AAwAbiAUABAADgABAAEAAQAAAKgGAAAEAAAAcBAVAAAADgABAAEAAQAAALsGAAAEAAAAcBAVAAAA"
1617 "DgABAAAAAQAAAL8GAAAGAAAAYgAAAHEQAwAAAA4AAQAAAAEAAADEBgAABgAAAGIAAQBxEAMAAAAO"
1618 "AAEAAAABAAAA8QYAAAYAAABiAAIAcRABAAAADgABAAAAAQAAAPYGAAAGAAAAYgADAHEQAwAAAA4A"
1619 "AQAAAAEAAADJBgAABgAAAGIABABxEAMAAAAOAAEAAAABAAAAzgYAAAYAAABiAAEAcRADAAAADgAB"
1620 "AAAAAQAAANMGAAAGAAAAYgAGAHEQAwAAAA4AAQAAAAEAAADYBgAABgAAAGIABwBxEAMAAAAOAAEA"
1621 "AAABAAAA3QYAAAYAAABiAAgAcRABAAAADgABAAAAAQAAAOIGAAAGAAAAYgAJAHEQAwAAAA4AAQAA"
1622 "AAEAAADnBgAABgAAAGIACgBxEAMAAAAOAAEAAAABAAAA7AYAAAYAAABiAAsAcRABAAAADgABAAEA"
1623 "AAAAAPsGAAAlAAAAcQAHAAAAcQAIAAAAcQALAAAAcQAMAAAAcQANAAAAcQAOAAAAcQAPAAAAcQAQ"
1624 "AAAAcQARAAAAcQASAAAAcQAJAAAAcQAKAAAADgAnAA4AKQFFDgEWDwAhAA4AIwFFDloAEgAOABMA"
1625 "DktLS0tLS0tLS0tLABEADgAuAA5aADIADloANgAOWgA6AA5aAD4ADloAQgAOWgBGAA5aAEoADloA"
1626 "TgAOWgBSAA5aAFYADloAWgAOWgBeATQOPDw8PDw8PDw8PDw8AAIEAUYYAwIFAjEECEEXLAIFAjEE"
1627 "CEEXKwIFAjEECEEXLQIGAUYcAxgAGAEYAgAAAAIAAAAMBwAAEgcAAAIAAAAMBwAAGwcAAAIAAAAM"
1628 "BwAAJAcAAAEAAAAtBwAAPAcAAAAAAAAAAAAAAAAAAEgHAAAAAAAAAAAAAAAAAABUBwAAAAAAAAAA"
1629 "AAAAAAAAYAcAAAAAAAAAAAAAAAAAAAEAAAAJAAAAAQAAAA0AAAACAACAgASsCAEIxAgAAAIAAoCA"
1630 "BIQJAQicCQwAAgAACQEJAQkBCQEJAQkBCQEJAQkBCQEJAQkEiIAEuAcBgIAEuAkAAA4ABoCABNAJ"
1631 "AQnoCQAJhAoACaAKAAm8CgAJ2AoACfQKAAmQCwAJrAsACcgLAAnkCwAJgAwACZwMAAm4DAg8Y2xp"
1632 "bml0PgAGPGluaXQ+AANBQUEAC0hlbGxvIFdvcmxkAAxIZWxsbyBXb3JsZDEADUhlbGxvIFdvcmxk"
1633 "MTAADUhlbGxvIFdvcmxkMTEADEhlbGxvIFdvcmxkMgAMSGVsbG8gV29ybGQzAAxIZWxsbyBXb3Js"
1634 "ZDQADEhlbGxvIFdvcmxkNQAMSGVsbG8gV29ybGQ2AAxIZWxsbyBXb3JsZDcADEhlbGxvIFdvcmxk"
1635 "OAAMSGVsbG8gV29ybGQ5AAFMAAJMTAAWTE1hbnlNZXRob2RzJFByaW50ZXIyOwAVTE1hbnlNZXRo"
1636 "b2RzJFByaW50ZXI7ABVMTWFueU1ldGhvZHMkU3RyaW5nczsADUxNYW55TWV0aG9kczsAIkxkYWx2"
1637 "aWsvYW5ub3RhdGlvbi9FbmNsb3NpbmdDbGFzczsAHkxkYWx2aWsvYW5ub3RhdGlvbi9Jbm5lckNs"
1638 "YXNzOwAhTGRhbHZpay9hbm5vdGF0aW9uL01lbWJlckNsYXNzZXM7ABVMamF2YS9pby9QcmludFN0"
1639 "cmVhbTsAEkxqYXZhL2xhbmcvT2JqZWN0OwASTGphdmEvbGFuZy9TdHJpbmc7ABlMamF2YS9sYW5n"
1640 "L1N0cmluZ0J1aWxkZXI7ABJMamF2YS9sYW5nL1N5c3RlbTsAEE1hbnlNZXRob2RzLmphdmEABVBy"
1641 "aW50AAZQcmludDAABlByaW50MQAHUHJpbnQxMAAHUHJpbnQxMQAGUHJpbnQyAAZQcmludDMABlBy"
1642 "aW50NAAGUHJpbnQ1AAZQcmludDYABlByaW50NwAGUHJpbnQ4AAZQcmludDkAB1ByaW50ZXIACFBy"
1643 "aW50ZXIyAAdTdHJpbmdzAAFWAAJWTAATW0xqYXZhL2xhbmcvU3RyaW5nOwALYWNjZXNzRmxhZ3MA"
1644 "BmFwcGVuZAAEYXJncwAEbWFpbgAEbXNnMAAEbXNnMQAFbXNnMTAABW1zZzExAARtc2cyAARtc2cz"
1645 "AARtc2c0AARtc2c1AARtc2c2AARtc2c3AARtc2c4AARtc2c5AARuYW1lAANvdXQAB3ByaW50bG4A"
1646 "AXMACHRvU3RyaW5nAAV2YWx1ZQBffn5EOHsibWluLWFwaSI6MTAwMDAsInNoYS0xIjoiZmViODZj"
1647 "MDA2ZWZhY2YxZDc5ODRiODVlMTc5MGZlZjdhNzY3YWViYyIsInZlcnNpb24iOiJ2MS4xLjUtZGV2"
1648 "In0AEAAAAAAAAAABAAAAAAAAAAEAAABIAAAAcAAAAAIAAAAOAAAAkAEAAAMAAAAFAAAAyAEAAAQA"
1649 "AAANAAAABAIAAAUAAAAZAAAAbAIAAAYAAAAEAAAANAMAAAEgAAAUAAAAuAMAAAMgAAAUAAAAkgYA"
1650 "AAQgAAAFAAAADAcAAAMQAAAEAAAAOQcAAAYgAAAEAAAAaAcAAAEQAAACAAAAqAcAAAAgAAAEAAAA"
1651 "tgcAAAIgAABIAAAAOAgAAAAQAAABAAAA0AsAAAAAAAA=";
1652
1653static void WriteBase64ToFile(const char* base64, File* file) {
1654 // Decode base64.
1655 CHECK(base64 != nullptr);
1656 size_t length;
1657 std::unique_ptr<uint8_t[]> bytes(DecodeBase64(base64, &length));
1658 CHECK(bytes != nullptr);
1659 if (!file->WriteFully(bytes.get(), length)) {
1660 PLOG(FATAL) << "Failed to write base64 as file";
1661 }
1662}
1663
1664TEST_F(Dex2oatTest, CompactDexGenerationFailure) {
1665 ScratchFile temp_dex;
1666 WriteBase64ToFile(kDuplicateMethodInputDex, temp_dex.GetFile());
1667 std::string out_dir = GetScratchDir();
1668 const std::string oat_filename = out_dir + "/base.oat";
1669 // The dex won't pass the method verifier, only use the verify filter.
1670 GenerateOdexForTest(temp_dex.GetFilename(),
1671 oat_filename,
1672 CompilerFilter::Filter::kVerify,
1673 { },
1674 true, // expect_success
1675 false, // use_fd
1676 [](const OatFile& o) {
1677 CHECK(o.ContainsDexCode());
1678 });
1679 // Open our generated oat file.
1680 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001681 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001682 oat_filename.c_str(),
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001683 oat_filename.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001684 /*executable=*/ false,
1685 /*low_4gb=*/ false,
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001686 temp_dex.GetFilename().c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001687 /*reservation=*/ nullptr,
Mathieu Chartier05f90d12018-02-07 13:47:17 -08001688 &error_msg));
1689 ASSERT_TRUE(odex_file != nullptr);
1690 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
1691 ASSERT_EQ(oat_dex_files.size(), 1u);
1692 // The dexes should have failed to convert to compact dex.
1693 for (const OatDexFile* oat_dex : oat_dex_files) {
1694 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1695 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1696 ASSERT_TRUE(!dex_file->IsCompactDexFile());
1697 }
1698}
1699
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001700TEST_F(Dex2oatTest, CompactDexGenerationFailureMultiDex) {
1701 // Create a multidex file with only one dex that gets rejected for cdex conversion.
1702 ScratchFile apk_file;
1703 {
Andreas Gampedfcd82c2018-10-16 20:22:37 -07001704 FILE* file = fdopen(DupCloexec(apk_file.GetFd()), "w+b");
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001705 ZipWriter writer(file);
1706 // Add vdex to zip.
1707 writer.StartEntry("classes.dex", ZipWriter::kCompress);
1708 size_t length = 0u;
1709 std::unique_ptr<uint8_t[]> bytes(DecodeBase64(kDuplicateMethodInputDex, &length));
1710 ASSERT_GE(writer.WriteBytes(&bytes[0], length), 0);
1711 writer.FinishEntry();
1712 writer.StartEntry("classes2.dex", ZipWriter::kCompress);
1713 std::unique_ptr<const DexFile> dex(OpenTestDexFile("ManyMethods"));
1714 ASSERT_GE(writer.WriteBytes(dex->Begin(), dex->Size()), 0);
1715 writer.FinishEntry();
1716 writer.Finish();
1717 ASSERT_EQ(apk_file.GetFile()->Flush(), 0);
1718 }
Andreas Gampebc802de2018-06-20 17:24:11 -07001719 const std::string& dex_location = apk_file.GetFilename();
Mathieu Chartiercda83be2018-03-01 23:55:55 -08001720 const std::string odex_location = GetOdexDir() + "/output.odex";
1721 GenerateOdexForTest(dex_location,
1722 odex_location,
1723 CompilerFilter::kQuicken,
1724 { "--compact-dex-level=fast" },
1725 true);
1726}
1727
Andreas Gampe25419b52018-02-08 21:30:26 -08001728TEST_F(Dex2oatTest, StderrLoggerOutput) {
1729 std::string dex_location = GetScratchDir() + "/Dex2OatStderrLoggerTest.jar";
1730 std::string odex_location = GetOdexDir() + "/Dex2OatStderrLoggerTest.odex";
1731
1732 // Test file doesn't matter.
1733 Copy(GetDexSrc1(), dex_location);
1734
1735 GenerateOdexForTest(dex_location,
1736 odex_location,
1737 CompilerFilter::kQuicken,
1738 { "--runtime-arg", "-Xuse-stderr-logger" },
1739 true);
1740 // Look for some random part of dex2oat logging. With the stderr logger this should be captured,
1741 // even on device.
1742 EXPECT_NE(std::string::npos, output_.find("dex2oat took"));
1743}
1744
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001745TEST_F(Dex2oatTest, VerifyCompilationReason) {
1746 std::string dex_location = GetScratchDir() + "/Dex2OatCompilationReason.jar";
1747 std::string odex_location = GetOdexDir() + "/Dex2OatCompilationReason.odex";
1748
1749 // Test file doesn't matter.
1750 Copy(GetDexSrc1(), dex_location);
1751
1752 GenerateOdexForTest(dex_location,
1753 odex_location,
1754 CompilerFilter::kVerify,
1755 { "--compilation-reason=install" },
1756 true);
1757 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001758 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001759 odex_location.c_str(),
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001760 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001761 /*executable=*/ false,
1762 /*low_4gb=*/ false,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001763 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001764 /*reservation=*/ nullptr,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001765 &error_msg));
1766 ASSERT_TRUE(odex_file != nullptr);
1767 ASSERT_STREQ("install", odex_file->GetCompilationReason());
1768}
1769
1770TEST_F(Dex2oatTest, VerifyNoCompilationReason) {
1771 std::string dex_location = GetScratchDir() + "/Dex2OatNoCompilationReason.jar";
1772 std::string odex_location = GetOdexDir() + "/Dex2OatNoCompilationReason.odex";
1773
1774 // Test file doesn't matter.
1775 Copy(GetDexSrc1(), dex_location);
1776
1777 GenerateOdexForTest(dex_location,
1778 odex_location,
1779 CompilerFilter::kVerify,
1780 {},
1781 true);
1782 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001783 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001784 odex_location.c_str(),
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001785 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001786 /*executable=*/ false,
1787 /*low_4gb=*/ false,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001788 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001789 /*reservation=*/ nullptr,
Calin Juravle0e09dfc2018-02-12 19:01:09 -08001790 &error_msg));
1791 ASSERT_TRUE(odex_file != nullptr);
1792 ASSERT_EQ(nullptr, odex_file->GetCompilationReason());
1793}
1794
Mathieu Chartier792111c2018-02-15 13:02:15 -08001795TEST_F(Dex2oatTest, DontExtract) {
1796 std::unique_ptr<const DexFile> dex(OpenTestDexFile("ManyMethods"));
1797 std::string error_msg;
1798 const std::string out_dir = GetScratchDir();
1799 const std::string dex_location = dex->GetLocation();
1800 const std::string odex_location = out_dir + "/base.oat";
1801 const std::string vdex_location = out_dir + "/base.vdex";
1802 GenerateOdexForTest(dex_location,
1803 odex_location,
1804 CompilerFilter::Filter::kVerify,
1805 { "--copy-dex-files=false" },
1806 true, // expect_success
1807 false, // use_fd
1808 [](const OatFile&) {
1809 });
1810 {
1811 // Check the vdex doesn't have dex.
1812 std::unique_ptr<VdexFile> vdex(VdexFile::Open(vdex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001813 /*writable=*/ false,
1814 /*low_4gb=*/ false,
1815 /*unquicken=*/ false,
Mathieu Chartier792111c2018-02-15 13:02:15 -08001816 &error_msg));
1817 ASSERT_TRUE(vdex != nullptr);
Nicolas Geoffray3a293552018-03-02 10:52:16 +00001818 EXPECT_FALSE(vdex->HasDexSection()) << output_;
Mathieu Chartier792111c2018-02-15 13:02:15 -08001819 }
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001820 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01001821 odex_location.c_str(),
Mathieu Chartier792111c2018-02-15 13:02:15 -08001822 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001823 /*executable=*/ false,
1824 /*low_4gb=*/ false,
Mathieu Chartier792111c2018-02-15 13:02:15 -08001825 dex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001826 /*reservation=*/ nullptr,
Mathieu Chartier792111c2018-02-15 13:02:15 -08001827 &error_msg));
1828 ASSERT_TRUE(odex_file != nullptr) << dex_location;
1829 std::vector<const OatDexFile*> oat_dex_files = odex_file->GetOatDexFiles();
1830 ASSERT_EQ(oat_dex_files.size(), 1u);
1831 // Verify that the oat file can still open the dex files.
1832 for (const OatDexFile* oat_dex : oat_dex_files) {
1833 std::unique_ptr<const DexFile> dex_file(oat_dex->OpenDexFile(&error_msg));
1834 ASSERT_TRUE(dex_file != nullptr) << error_msg;
1835 }
1836 // Create a dm file and use it to verify.
1837 // Add produced artifacts to a zip file that doesn't contain the classes.dex.
1838 ScratchFile dm_file;
1839 {
1840 std::unique_ptr<File> vdex_file(OS::OpenFileForReading(vdex_location.c_str()));
1841 ASSERT_TRUE(vdex_file != nullptr);
1842 ASSERT_GT(vdex_file->GetLength(), 0u);
Andreas Gampedfcd82c2018-10-16 20:22:37 -07001843 FILE* file = fdopen(DupCloexec(dm_file.GetFd()), "w+b");
Mathieu Chartier792111c2018-02-15 13:02:15 -08001844 ZipWriter writer(file);
1845 auto write_all_bytes = [&](File* file) {
1846 std::unique_ptr<uint8_t[]> bytes(new uint8_t[file->GetLength()]);
1847 ASSERT_TRUE(file->ReadFully(&bytes[0], file->GetLength()));
1848 ASSERT_GE(writer.WriteBytes(&bytes[0], file->GetLength()), 0);
1849 };
1850 // Add vdex to zip.
1851 writer.StartEntry(VdexFile::kVdexNameInDmFile, ZipWriter::kCompress);
1852 write_all_bytes(vdex_file.get());
1853 writer.FinishEntry();
1854 writer.Finish();
1855 ASSERT_EQ(dm_file.GetFile()->Flush(), 0);
1856 }
1857
Mathieu Chartier2eabc612018-05-25 14:31:16 -07001858 auto generate_and_check = [&](CompilerFilter::Filter filter) {
1859 GenerateOdexForTest(dex_location,
1860 odex_location,
1861 filter,
1862 { "--dump-timings",
1863 "--dm-file=" + dm_file.GetFilename(),
1864 // Pass -Xuse-stderr-logger have dex2oat output in output_ on target.
1865 "--runtime-arg",
1866 "-Xuse-stderr-logger" },
1867 true, // expect_success
1868 false, // use_fd
1869 [](const OatFile& o) {
1870 CHECK(o.ContainsDexCode());
1871 });
1872 // Check the output for "Fast verify", this is printed from --dump-timings.
1873 std::istringstream iss(output_);
1874 std::string line;
1875 bool found_fast_verify = false;
1876 const std::string kFastVerifyString = "Fast Verify";
1877 while (std::getline(iss, line) && !found_fast_verify) {
1878 found_fast_verify = found_fast_verify || line.find(kFastVerifyString) != std::string::npos;
1879 }
1880 EXPECT_TRUE(found_fast_verify) << "Expected to find " << kFastVerifyString << "\n" << output_;
1881 };
1882
Mathieu Chartier792111c2018-02-15 13:02:15 -08001883 // Generate a quickened dex by using the input dm file to verify.
Mathieu Chartier2eabc612018-05-25 14:31:16 -07001884 generate_and_check(CompilerFilter::Filter::kQuicken);
1885 // Use verify compiler filter to sanity check that FastVerify works for that filter too.
1886 generate_and_check(CompilerFilter::Filter::kVerify);
Mathieu Chartier792111c2018-02-15 13:02:15 -08001887}
1888
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001889// Test that dex files with quickened opcodes aren't dequickened.
1890TEST_F(Dex2oatTest, QuickenedInput) {
1891 std::string error_msg;
1892 ScratchFile temp_dex;
1893 MutateDexFile(temp_dex.GetFile(), GetTestDexFileName("ManyMethods"), [] (DexFile* dex) {
1894 bool mutated_successfully = false;
1895 // Change the dex instructions to make an opcode that spans past the end of the code item.
Mathieu Chartier2242ef12018-07-23 18:14:13 -07001896 for (ClassAccessor accessor : dex->GetClasses()) {
1897 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
1898 CodeItemInstructionAccessor instructions = method.GetInstructions();
1899 // Make a quickened instruction that doesn't run past the end of the code item.
1900 if (instructions.InsnsSizeInCodeUnits() > 2) {
1901 const_cast<Instruction&>(instructions.InstructionAt(0)).SetOpcode(
1902 Instruction::IGET_BYTE_QUICK);
1903 mutated_successfully = true;
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001904 }
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001905 }
1906 }
1907 CHECK(mutated_successfully)
1908 << "Failed to find candidate code item with only one code unit in last instruction.";
1909 });
1910
Andreas Gampebc802de2018-06-20 17:24:11 -07001911 const std::string& dex_location = temp_dex.GetFilename();
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001912 std::string odex_location = GetOdexDir() + "/quickened.odex";
1913 std::string vdex_location = GetOdexDir() + "/quickened.vdex";
1914 std::unique_ptr<File> vdex_output(OS::CreateEmptyFile(vdex_location.c_str()));
1915 // Quicken the dex
1916 {
1917 std::string input_vdex = "--input-vdex-fd=-1";
1918 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_output->Fd());
1919 GenerateOdexForTest(dex_location,
1920 odex_location,
1921 CompilerFilter::kQuicken,
1922 // Disable cdex since we want to compare against the original dex file
1923 // after unquickening.
1924 { input_vdex, output_vdex, kDisableCompactDex },
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001925 /*expect_success=*/ true,
1926 /*use_fd=*/ true);
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001927 }
1928 // Unquicken by running the verify compiler filter on the vdex file and verify it matches.
1929 std::string odex_location2 = GetOdexDir() + "/unquickened.odex";
1930 std::string vdex_location2 = GetOdexDir() + "/unquickened.vdex";
1931 std::unique_ptr<File> vdex_unquickened(OS::CreateEmptyFile(vdex_location2.c_str()));
1932 {
1933 std::string input_vdex = StringPrintf("--input-vdex-fd=%d", vdex_output->Fd());
1934 std::string output_vdex = StringPrintf("--output-vdex-fd=%d", vdex_unquickened->Fd());
1935 GenerateOdexForTest(dex_location,
1936 odex_location2,
1937 CompilerFilter::kVerify,
1938 // Disable cdex to avoid needing to write out the shared section.
1939 { input_vdex, output_vdex, kDisableCompactDex },
Vladimir Markof4efa9e2018-10-17 14:12:45 +01001940 /*expect_success=*/ true,
1941 /*use_fd=*/ true);
Mathieu Chartier2daa1342018-02-20 16:19:28 -08001942 }
1943 ASSERT_EQ(vdex_unquickened->Flush(), 0) << "Could not flush and close vdex file";
1944 ASSERT_TRUE(success_);
1945 {
1946 // Check that hte vdex has one dex and compare it to the original one.
1947 std::unique_ptr<VdexFile> vdex(VdexFile::Open(vdex_location2.c_str(),
1948 /*writable*/ false,
1949 /*low_4gb*/ false,
1950 /*unquicken*/ false,
1951 &error_msg));
1952 std::vector<std::unique_ptr<const DexFile>> dex_files;
1953 bool result = vdex->OpenAllDexFiles(&dex_files, &error_msg);
1954 ASSERT_TRUE(result) << error_msg;
1955 ASSERT_EQ(dex_files.size(), 1u) << error_msg;
1956 ScratchFile temp;
1957 ASSERT_TRUE(temp.GetFile()->WriteFully(dex_files[0]->Begin(), dex_files[0]->Size()));
1958 ASSERT_EQ(temp.GetFile()->Flush(), 0) << "Could not flush extracted dex";
1959 EXPECT_EQ(temp.GetFile()->Compare(temp_dex.GetFile()), 0);
1960 }
1961 ASSERT_EQ(vdex_output->FlushCloseOrErase(), 0) << "Could not flush and close";
1962 ASSERT_EQ(vdex_unquickened->FlushCloseOrErase(), 0) << "Could not flush and close";
1963}
1964
Mathieu Chartierd45863a2018-03-21 18:16:36 -07001965// Test that compact dex generation with invalid dex files doesn't crash dex2oat. b/75970654
1966TEST_F(Dex2oatTest, CompactDexInvalidSource) {
1967 ScratchFile invalid_dex;
1968 {
Andreas Gampedfcd82c2018-10-16 20:22:37 -07001969 FILE* file = fdopen(DupCloexec(invalid_dex.GetFd()), "w+b");
Mathieu Chartierd45863a2018-03-21 18:16:36 -07001970 ZipWriter writer(file);
1971 writer.StartEntry("classes.dex", ZipWriter::kAlign32);
1972 DexFile::Header header = {};
1973 StandardDexFile::WriteMagic(header.magic_);
1974 StandardDexFile::WriteCurrentVersion(header.magic_);
1975 header.file_size_ = 4 * KB;
1976 header.data_size_ = 4 * KB;
1977 header.data_off_ = 10 * MB;
1978 header.map_off_ = 10 * MB;
1979 header.class_defs_off_ = 10 * MB;
1980 header.class_defs_size_ = 10000;
1981 ASSERT_GE(writer.WriteBytes(&header, sizeof(header)), 0);
1982 writer.FinishEntry();
1983 writer.Finish();
1984 ASSERT_EQ(invalid_dex.GetFile()->Flush(), 0);
1985 }
Andreas Gampebc802de2018-06-20 17:24:11 -07001986 const std::string& dex_location = invalid_dex.GetFilename();
Mathieu Chartierd45863a2018-03-21 18:16:36 -07001987 const std::string odex_location = GetOdexDir() + "/output.odex";
1988 std::string error_msg;
1989 int status = GenerateOdexForTestWithStatus(
1990 {dex_location},
1991 odex_location,
1992 CompilerFilter::kQuicken,
1993 &error_msg,
1994 { "--compact-dex-level=fast" });
1995 ASSERT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) != 0) << status << " " << output_;
1996}
1997
Mathieu Chartier14e7bad2018-03-22 14:33:20 -07001998// Test that dex2oat with a CompactDex file in the APK fails.
1999TEST_F(Dex2oatTest, CompactDexInZip) {
2000 CompactDexFile::Header header = {};
2001 CompactDexFile::WriteMagic(header.magic_);
2002 CompactDexFile::WriteCurrentVersion(header.magic_);
2003 header.file_size_ = sizeof(CompactDexFile::Header);
2004 header.data_off_ = 10 * MB;
2005 header.map_off_ = 10 * MB;
2006 header.class_defs_off_ = 10 * MB;
2007 header.class_defs_size_ = 10000;
2008 // Create a zip containing the invalid dex.
2009 ScratchFile invalid_dex_zip;
2010 {
Andreas Gampedfcd82c2018-10-16 20:22:37 -07002011 FILE* file = fdopen(DupCloexec(invalid_dex_zip.GetFd()), "w+b");
Mathieu Chartier14e7bad2018-03-22 14:33:20 -07002012 ZipWriter writer(file);
2013 writer.StartEntry("classes.dex", ZipWriter::kCompress);
2014 ASSERT_GE(writer.WriteBytes(&header, sizeof(header)), 0);
2015 writer.FinishEntry();
2016 writer.Finish();
2017 ASSERT_EQ(invalid_dex_zip.GetFile()->Flush(), 0);
2018 }
2019 // Create the dex file directly.
2020 ScratchFile invalid_dex;
2021 {
2022 ASSERT_GE(invalid_dex.GetFile()->WriteFully(&header, sizeof(header)), 0);
2023 ASSERT_EQ(invalid_dex.GetFile()->Flush(), 0);
2024 }
2025 std::string error_msg;
2026 int status = 0u;
2027
2028 status = GenerateOdexForTestWithStatus(
2029 { invalid_dex_zip.GetFilename() },
2030 GetOdexDir() + "/output_apk.odex",
2031 CompilerFilter::kQuicken,
2032 &error_msg,
2033 { "--compact-dex-level=fast" });
2034 ASSERT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) != 0) << status << " " << output_;
2035
2036 status = GenerateOdexForTestWithStatus(
2037 { invalid_dex.GetFilename() },
2038 GetOdexDir() + "/output.odex",
2039 CompilerFilter::kQuicken,
2040 &error_msg,
2041 { "--compact-dex-level=fast" });
2042 ASSERT_TRUE(WIFEXITED(status) && WEXITSTATUS(status) != 0) << status << " " << output_;
2043}
2044
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002045TEST_F(Dex2oatTest, AppImageNoProfile) {
2046 ScratchFile app_image_file;
2047 const std::string out_dir = GetScratchDir();
2048 const std::string odex_location = out_dir + "/base.odex";
2049 GenerateOdexForTest(GetTestDexFileName("ManyMethods"),
2050 odex_location,
2051 CompilerFilter::Filter::kSpeedProfile,
2052 { "--app-image-fd=" + std::to_string(app_image_file.GetFd()) },
2053 true, // expect_success
2054 false, // use_fd
2055 [](const OatFile&) {});
2056 // Open our generated oat file.
2057 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002058 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Nicolas Geoffray30025092018-04-19 14:43:29 +01002059 odex_location.c_str(),
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002060 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002061 /*executable=*/ false,
2062 /*low_4gb=*/ false,
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002063 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002064 /*reservation=*/ nullptr,
Mathieu Chartierf85b3db2018-04-02 18:16:21 -07002065 &error_msg));
2066 ASSERT_TRUE(odex_file != nullptr);
2067 ImageHeader header = {};
2068 ASSERT_TRUE(app_image_file.GetFile()->PreadFully(
2069 reinterpret_cast<void*>(&header),
2070 sizeof(header),
2071 /*offset*/ 0u)) << app_image_file.GetFile()->GetLength();
2072 EXPECT_GT(header.GetImageSection(ImageHeader::kSectionObjects).Size(), 0u);
2073 EXPECT_EQ(header.GetImageSection(ImageHeader::kSectionArtMethods).Size(), 0u);
2074 EXPECT_EQ(header.GetImageSection(ImageHeader::kSectionArtFields).Size(), 0u);
2075}
2076
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002077TEST_F(Dex2oatTest, AppImageResolveStrings) {
2078 using Hotness = ProfileCompilationInfo::MethodHotness;
2079 // Create a profile with the startup method marked.
2080 ScratchFile profile_file;
2081 std::vector<uint16_t> methods;
Mathieu Chartier22752772018-10-18 14:18:59 -07002082 std::vector<dex::TypeIndex> classes;
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002083 std::unique_ptr<const DexFile> dex(OpenTestDexFile("StringLiterals"));
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002084 {
Mathieu Chartier22752772018-10-18 14:18:59 -07002085 for (ClassAccessor accessor : dex->GetClasses()) {
2086 if (accessor.GetDescriptor() == std::string("LStringLiterals$StartupClass;")) {
2087 classes.push_back(accessor.GetClassIdx());
2088 }
2089 for (const ClassAccessor::Method& method : accessor.GetMethods()) {
2090 std::string method_name(dex->GetMethodName(dex->GetMethodId(method.GetIndex())));
2091 if (method_name == "startUpMethod") {
2092 methods.push_back(method.GetIndex());
2093 }
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002094 }
2095 }
Mathieu Chartier22752772018-10-18 14:18:59 -07002096 ASSERT_GT(classes.size(), 0u);
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002097 ASSERT_GT(methods.size(), 0u);
2098 // Here, we build the profile from the method lists.
2099 ProfileCompilationInfo info;
Mathieu Chartier22752772018-10-18 14:18:59 -07002100 info.AddClassesForDex(dex.get(), classes.begin(), classes.end());
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002101 info.AddMethodsForDex(Hotness::kFlagStartup, dex.get(), methods.begin(), methods.end());
2102 // Save the profile since we want to use it with dex2oat to produce an oat file.
2103 ASSERT_TRUE(info.Save(profile_file.GetFd()));
2104 }
2105 const std::string out_dir = GetScratchDir();
2106 const std::string odex_location = out_dir + "/base.odex";
2107 const std::string app_image_location = out_dir + "/base.art";
2108 GenerateOdexForTest(GetTestDexFileName("StringLiterals"),
2109 odex_location,
2110 CompilerFilter::Filter::kSpeedProfile,
2111 { "--app-image-file=" + app_image_location,
2112 "--resolve-startup-const-strings=true",
2113 "--profile-file=" + profile_file.GetFilename()},
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002114 /*expect_success=*/ true,
2115 /*use_fd=*/ false,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002116 [](const OatFile&) {});
2117 // Open our generated oat file.
2118 std::string error_msg;
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002119 std::unique_ptr<OatFile> odex_file(OatFile::Open(/*zip_fd=*/ -1,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002120 odex_location.c_str(),
2121 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002122 /*executable=*/ false,
2123 /*low_4gb=*/ false,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002124 odex_location.c_str(),
Vladimir Markof4efa9e2018-10-17 14:12:45 +01002125 /*reservation=*/ nullptr,
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002126 &error_msg));
2127 ASSERT_TRUE(odex_file != nullptr);
2128 // Check the strings in the app image intern table only contain the "startup" strigs.
2129 {
2130 ScopedObjectAccess soa(Thread::Current());
2131 std::unique_ptr<gc::space::ImageSpace> space =
2132 gc::space::ImageSpace::CreateFromAppImage(app_image_location.c_str(),
2133 odex_file.get(),
2134 &error_msg);
2135 ASSERT_TRUE(space != nullptr) << error_msg;
2136 std::set<std::string> seen;
2137 InternTable intern_table;
2138 intern_table.AddImageStringsToTable(space.get(), [&](InternTable::UnorderedSet& interns)
2139 REQUIRES_SHARED(Locks::mutator_lock_) {
2140 for (const GcRoot<mirror::String>& str : interns) {
2141 seen.insert(str.Read()->ToModifiedUtf8());
2142 }
2143 });
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002144 // Ensure that the dex cache has a preresolved string array.
2145 std::set<std::string> preresolved_seen;
2146 bool saw_dexcache = false;
2147 space->GetLiveBitmap()->VisitAllMarked(
2148 [&](mirror::Object* obj) REQUIRES_SHARED(Locks::mutator_lock_) {
2149 if (obj->IsDexCache<kVerifyNone>()) {
2150 ObjPtr<mirror::DexCache> dex_cache = obj->AsDexCache();
2151 GcRoot<mirror::String>* preresolved_strings = dex_cache->GetPreResolvedStrings();
2152 ASSERT_EQ(dex->NumStringIds(), dex_cache->NumPreResolvedStrings());
2153 for (size_t i = 0; i < dex_cache->NumPreResolvedStrings(); ++i) {
2154 ObjPtr<mirror::String> string = preresolved_strings[i].Read<kWithoutReadBarrier>();
2155 if (string != nullptr) {
2156 preresolved_seen.insert(string->ToModifiedUtf8());
2157 }
2158 }
2159 saw_dexcache = true;
2160 }
2161 });
2162 ASSERT_TRUE(saw_dexcache);
2163 // Everything in the preresolved array should also be in the intern table.
2164 for (const std::string& str : preresolved_seen) {
2165 EXPECT_TRUE(seen.find(str) != seen.end());
2166 }
Mathieu Chartier22752772018-10-18 14:18:59 -07002167 // Normal methods
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002168 EXPECT_TRUE(preresolved_seen.find("Loading ") != preresolved_seen.end());
2169 EXPECT_TRUE(preresolved_seen.find("Starting up") != preresolved_seen.end());
2170 EXPECT_TRUE(preresolved_seen.find("abcd.apk") != preresolved_seen.end());
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002171 EXPECT_TRUE(seen.find("Unexpected error") == seen.end());
2172 EXPECT_TRUE(seen.find("Shutting down!") == seen.end());
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002173 EXPECT_TRUE(preresolved_seen.find("Unexpected error") == preresolved_seen.end());
2174 EXPECT_TRUE(preresolved_seen.find("Shutting down!") == preresolved_seen.end());
Mathieu Chartier22752772018-10-18 14:18:59 -07002175 // Classes initializers
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002176 EXPECT_TRUE(preresolved_seen.find("Startup init") != preresolved_seen.end());
Mathieu Chartier22752772018-10-18 14:18:59 -07002177 EXPECT_TRUE(seen.find("Other class init") == seen.end());
Mathieu Chartier1ca718e2018-10-23 12:55:34 -07002178 EXPECT_TRUE(preresolved_seen.find("Other class init") == preresolved_seen.end());
2179 // Expect the sets match.
2180 EXPECT_GE(seen.size(), preresolved_seen.size());
Mathieu Chartier8cc418e2018-10-31 10:54:30 -07002181
2182 // Verify what strings are marked as boot image.
2183 std::set<std::string> boot_image_strings;
2184 std::set<std::string> app_image_strings;
2185
2186 MutexLock mu(Thread::Current(), *Locks::intern_table_lock_);
2187 intern_table.VisitInterns([&](const GcRoot<mirror::String>& root)
2188 REQUIRES_SHARED(Locks::mutator_lock_) {
2189 boot_image_strings.insert(root.Read()->ToModifiedUtf8());
2190 }, /*visit_boot_images=*/true, /*visit_non_boot_images=*/false);
2191 intern_table.VisitInterns([&](const GcRoot<mirror::String>& root)
2192 REQUIRES_SHARED(Locks::mutator_lock_) {
2193 app_image_strings.insert(root.Read()->ToModifiedUtf8());
2194 }, /*visit_boot_images=*/false, /*visit_non_boot_images=*/true);
2195 EXPECT_EQ(boot_image_strings.size(), 0u);
2196 EXPECT_TRUE(app_image_strings == seen);
Mathieu Chartiercd0f38f2018-10-15 09:44:35 -07002197 }
2198}
2199
2200
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002201TEST_F(Dex2oatClassLoaderContextTest, StoredClassLoaderContext) {
Mathieu Chartierc4440772018-04-16 14:40:56 -07002202 std::vector<std::unique_ptr<const DexFile>> dex_files = OpenTestDexFiles("MultiDex");
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002203 const std::string out_dir = GetScratchDir();
2204 const std::string odex_location = out_dir + "/base.odex";
Mathieu Chartierc4440772018-04-16 14:40:56 -07002205 const std::string valid_context = "PCL[" + dex_files[0]->GetLocation() + "]";
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002206 const std::string stored_context = "PCL[/system/not_real_lib.jar]";
Mathieu Chartierc4440772018-04-16 14:40:56 -07002207 std::string expected_stored_context = "PCL[";
2208 size_t index = 1;
2209 for (const std::unique_ptr<const DexFile>& dex_file : dex_files) {
2210 const bool is_first = index == 1u;
2211 if (!is_first) {
2212 expected_stored_context += ":";
2213 }
2214 expected_stored_context += "/system/not_real_lib.jar";
2215 if (!is_first) {
2216 expected_stored_context += "!classes" + std::to_string(index) + ".dex";
2217 }
2218 expected_stored_context += "*" + std::to_string(dex_file->GetLocationChecksum());
2219 ++index;
2220 }
2221 expected_stored_context += + "]";
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002222 // The class path should not be valid and should fail being stored.
2223 GenerateOdexForTest(GetTestDexFileName("ManyMethods"),
2224 odex_location,
2225 CompilerFilter::Filter::kQuicken,
2226 { "--class-loader-context=" + stored_context },
2227 true, // expect_success
2228 false, // use_fd
2229 [&](const OatFile& oat_file) {
Mathieu Chartierc4440772018-04-16 14:40:56 -07002230 EXPECT_NE(oat_file.GetClassLoaderContext(), stored_context) << output_;
2231 EXPECT_NE(oat_file.GetClassLoaderContext(), valid_context) << output_;
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002232 });
2233 // The stored context should match what we expect even though it's invalid.
2234 GenerateOdexForTest(GetTestDexFileName("ManyMethods"),
2235 odex_location,
2236 CompilerFilter::Filter::kQuicken,
2237 { "--class-loader-context=" + valid_context,
2238 "--stored-class-loader-context=" + stored_context },
2239 true, // expect_success
2240 false, // use_fd
2241 [&](const OatFile& oat_file) {
Mathieu Chartierc4440772018-04-16 14:40:56 -07002242 EXPECT_EQ(oat_file.GetClassLoaderContext(), expected_stored_context) << output_;
Mathieu Chartierf5abfc42018-03-23 21:51:54 -07002243 });
2244}
2245
Andreas Gampee1459ae2016-06-29 09:36:30 -07002246} // namespace art