blob: f78b39f648f4653eef19265ddf347312a796a7b1 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000402static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
403 bool is_taken;
404 switch (opcode) {
405 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
406 case Instruction::IF_NE: is_taken = (src1 != src2); break;
407 case Instruction::IF_LT: is_taken = (src1 < src2); break;
408 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
409 case Instruction::IF_GT: is_taken = (src1 > src2); break;
410 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
411 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
412 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
413 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
414 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
415 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
416 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
417 default:
418 LOG(FATAL) << "Unexpected opcode " << opcode;
419 UNREACHABLE();
420 }
421 return is_taken;
422}
423
buzbee311ca162013-02-28 15:56:43 -0800424/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700425bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800426 if (bb->block_type == kDead) {
427 return true;
428 }
Ningsheng Jiana262f772014-11-25 16:48:07 +0800429 // Currently multiply-accumulate backend supports are only available on arm32 and arm64.
430 if (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2) {
431 MultiplyAddOpt(bb);
432 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100433 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100434 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100435 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700436 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800437 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100438 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100439 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
440 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100441 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
442 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800443 }
buzbee311ca162013-02-28 15:56:43 -0800444 while (bb != NULL) {
445 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
446 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800447 if (use_lvn) {
448 local_valnum->GetValueNumber(mir);
449 }
buzbee311ca162013-02-28 15:56:43 -0800450 // Look for interesting opcodes, skip otherwise
451 Instruction::Code opcode = mir->dalvikInsn.opcode;
452 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000453 case Instruction::IF_EQ:
454 case Instruction::IF_NE:
455 case Instruction::IF_LT:
456 case Instruction::IF_GE:
457 case Instruction::IF_GT:
458 case Instruction::IF_LE:
459 if (!IsConst(mir->ssa_rep->uses[1])) {
460 break;
461 }
462 FALLTHROUGH_INTENDED;
463 case Instruction::IF_EQZ:
464 case Instruction::IF_NEZ:
465 case Instruction::IF_LTZ:
466 case Instruction::IF_GEZ:
467 case Instruction::IF_GTZ:
468 case Instruction::IF_LEZ:
469 // Result known at compile time?
470 if (IsConst(mir->ssa_rep->uses[0])) {
471 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
472 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
473 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
474 if (is_taken) {
475 // Replace with GOTO.
476 bb->fall_through = NullBasicBlockId;
477 mir->dalvikInsn.opcode = Instruction::GOTO;
478 mir->dalvikInsn.vA =
479 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
480 } else {
481 // Make NOP.
482 bb->taken = NullBasicBlockId;
483 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
484 }
485 mir->ssa_rep->num_uses = 0;
486 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
487 successor_to_unlink->ErasePredecessor(bb->id);
488 if (successor_to_unlink->predecessors.empty()) {
489 successor_to_unlink->KillUnreachable(this);
490 }
491 }
492 break;
buzbee311ca162013-02-28 15:56:43 -0800493 case Instruction::CMPL_FLOAT:
494 case Instruction::CMPL_DOUBLE:
495 case Instruction::CMPG_FLOAT:
496 case Instruction::CMPG_DOUBLE:
497 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700498 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800499 // Bitcode doesn't allow this optimization.
500 break;
501 }
502 if (mir->next != NULL) {
503 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800504 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700505 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800506 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
507 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000508 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700509 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800510 case Instruction::CMPL_FLOAT:
511 mir_next->dalvikInsn.opcode =
512 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
513 break;
514 case Instruction::CMPL_DOUBLE:
515 mir_next->dalvikInsn.opcode =
516 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
517 break;
518 case Instruction::CMPG_FLOAT:
519 mir_next->dalvikInsn.opcode =
520 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
521 break;
522 case Instruction::CMPG_DOUBLE:
523 mir_next->dalvikInsn.opcode =
524 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
525 break;
526 case Instruction::CMP_LONG:
527 mir_next->dalvikInsn.opcode =
528 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
529 break;
530 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
531 }
532 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Zheng Xub218c852014-12-08 18:18:01 +0800533 // Clear use count of temp VR.
534 use_counts_[mir->ssa_rep->defs[0]] = 0;
535 raw_use_counts_[mir->ssa_rep->defs[0]] = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700536 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800537 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
538 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
539 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
540 mir_next->ssa_rep->num_defs = 0;
541 mir->ssa_rep->num_uses = 0;
542 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700543 // Copy in the decoded instruction information for potential SSA re-creation.
544 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
545 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800546 }
547 }
548 break;
buzbee311ca162013-02-28 15:56:43 -0800549 default:
550 break;
551 }
552 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800553 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800554 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000555 if (!cu_->compiler->IsPortable() &&
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100556 (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
557 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000558 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700559 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800560 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700561 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
562 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800563
buzbee0d829482013-10-11 15:24:55 -0700564 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800565 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700566 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
567 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800568
569 /*
570 * In the select pattern, the taken edge goes to a block that unconditionally
571 * transfers to the rejoin block and the fall_though edge goes to a block that
572 * unconditionally falls through to the rejoin block.
573 */
574 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
575 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
576 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000577 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800578 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100579
580 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800581 // Are the block bodies something we can handle?
582 if ((ft->first_mir_insn == ft->last_mir_insn) &&
583 (tk->first_mir_insn != tk->last_mir_insn) &&
584 (tk->first_mir_insn->next == tk->last_mir_insn) &&
585 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
586 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
587 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
588 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
589 // Almost there. Are the instructions targeting the same vreg?
590 MIR* if_true = tk->first_mir_insn;
591 MIR* if_false = ft->first_mir_insn;
592 // It's possible that the target of the select isn't used - skip those (rare) cases.
593 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
594 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
595 /*
596 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
597 * Phi node in the merge block and delete it (while using the SSA name
598 * of the merge as the target of the SELECT. Delete both taken and
599 * fallthrough blocks, and set fallthrough to merge block.
600 * NOTE: not updating other dataflow info (no longer used at this point).
601 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
602 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000603 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800604 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
605 bool const_form = (SelectKind(if_true) == kSelectConst);
606 if ((SelectKind(if_true) == kSelectMove)) {
607 if (IsConst(if_true->ssa_rep->uses[0]) &&
608 IsConst(if_false->ssa_rep->uses[0])) {
609 const_form = true;
610 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
611 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
612 }
613 }
614 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800615 /*
616 * TODO: If both constants are the same value, then instead of generating
617 * a select, we should simply generate a const bytecode. This should be
618 * considered after inlining which can lead to CFG of this form.
619 */
buzbee311ca162013-02-28 15:56:43 -0800620 // "true" set val in vB
621 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
622 // "false" set val in vC
623 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
624 } else {
625 DCHECK_EQ(SelectKind(if_true), kSelectMove);
626 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700627 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000628 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800629 src_ssa[0] = mir->ssa_rep->uses[0];
630 src_ssa[1] = if_true->ssa_rep->uses[0];
631 src_ssa[2] = if_false->ssa_rep->uses[0];
632 mir->ssa_rep->uses = src_ssa;
633 mir->ssa_rep->num_uses = 3;
634 }
635 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700636 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000637 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700638 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000639 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800640 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700641 // Match type of uses to def.
642 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700643 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000644 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700645 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
646 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
647 }
buzbee311ca162013-02-28 15:56:43 -0800648 /*
649 * There is usually a Phi node in the join block for our two cases. If the
650 * Phi node only contains our two cases as input, we will use the result
651 * SSA name of the Phi node as our select result and delete the Phi. If
652 * the Phi node has more than two operands, we will arbitrarily use the SSA
653 * name of the "true" path, delete the SSA name of the "false" path from the
654 * Phi node (and fix up the incoming arc list).
655 */
656 if (phi->ssa_rep->num_uses == 2) {
657 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
658 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
659 } else {
660 int dead_def = if_false->ssa_rep->defs[0];
661 int live_def = if_true->ssa_rep->defs[0];
662 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700663 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800664 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
665 if (phi->ssa_rep->uses[i] == live_def) {
666 incoming[i] = bb->id;
667 }
668 }
669 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
670 if (phi->ssa_rep->uses[i] == dead_def) {
671 int last_slot = phi->ssa_rep->num_uses - 1;
672 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
673 incoming[i] = incoming[last_slot];
674 }
675 }
676 }
677 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700678 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800679 tk->block_type = kDead;
680 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
681 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
682 }
683 }
684 }
685 }
686 }
687 }
buzbee1da1e2f2013-11-15 13:37:01 -0800688 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800689 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100690 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100691 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
692 }
buzbee311ca162013-02-28 15:56:43 -0800693
buzbee311ca162013-02-28 15:56:43 -0800694 return true;
695}
696
buzbee311ca162013-02-28 15:56:43 -0800697/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700698void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700699 if (bb->data_flow_info != NULL) {
700 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
701 if (mir->ssa_rep == NULL) {
702 continue;
buzbee311ca162013-02-28 15:56:43 -0800703 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700704 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700705 if (df_attributes & DF_HAS_NULL_CHKS) {
706 checkstats_->null_checks++;
707 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
708 checkstats_->null_checks_eliminated++;
709 }
710 }
711 if (df_attributes & DF_HAS_RANGE_CHKS) {
712 checkstats_->range_checks++;
713 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
714 checkstats_->range_checks_eliminated++;
715 }
buzbee311ca162013-02-28 15:56:43 -0800716 }
717 }
718 }
buzbee311ca162013-02-28 15:56:43 -0800719}
720
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700721/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700722bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700723 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800724 if (!bb->explicit_throw) {
725 return false;
726 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700727
728 // If we visited it, we are done.
729 if (bb->visited) {
730 return false;
731 }
732 bb->visited = true;
733
buzbee311ca162013-02-28 15:56:43 -0800734 BasicBlock* walker = bb;
735 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700736 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800737 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
738 break;
739 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100740 DCHECK(!walker->predecessors.empty());
741 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700742
743 // If we visited the predecessor, we are done.
744 if (prev->visited) {
745 return false;
746 }
747 prev->visited = true;
748
buzbee311ca162013-02-28 15:56:43 -0800749 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700750 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700751 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800752 break;
753 }
buzbee0d829482013-10-11 15:24:55 -0700754 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700755 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800756 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
757 switch (opcode) {
758 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
759 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
760 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
761 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
762 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
763 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
764 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
765 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
766 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
767 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
768 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
769 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
770 default: LOG(FATAL) << "Unexpected opcode " << opcode;
771 }
772 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700773 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800774 prev->taken = prev->fall_through;
775 prev->fall_through = t_bb;
776 break;
777 }
778 walker = prev;
779 }
780 return false;
781}
782
783/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700784void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800785 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100786 while ((bb->block_type == kDalvikByteCode) &&
787 (bb->last_mir_insn != nullptr) &&
788 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
789 MIR* mir = bb->last_mir_insn;
790 DCHECK(bb->first_mir_insn != nullptr);
791
792 // Grab the attributes from the paired opcode.
793 MIR* throw_insn = mir->meta.throw_insn;
794 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
795
796 // Don't combine if the throw_insn can still throw NPE.
797 if ((df_attributes & DF_HAS_NULL_CHKS) != 0 &&
798 (throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) == 0) {
799 break;
800 }
801 // Now whitelist specific instructions.
802 bool ok = false;
803 if ((df_attributes & DF_IFIELD) != 0) {
804 // Combine only if fast, otherwise weird things can happen.
805 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600806 ok = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
Vladimir Marko312eb252014-10-07 15:01:57 +0100807 } else if ((df_attributes & DF_SFIELD) != 0) {
808 // Combine only if fast, otherwise weird things can happen.
809 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600810 bool fast = ((df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut());
Vladimir Marko312eb252014-10-07 15:01:57 +0100811 // Don't combine if the SGET/SPUT can call <clinit>().
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100812 bool clinit = !field_info.IsClassInitialized() &&
813 (throw_insn->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0;
Vladimir Marko312eb252014-10-07 15:01:57 +0100814 ok = fast && !clinit;
815 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
816 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
817 DCHECK_NE(throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK, 0);
818 ok = ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
819 } else if ((throw_insn->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
820 // We can encounter a non-throwing insn here thanks to inlining or other optimizations.
821 ok = true;
822 } else if (throw_insn->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
823 throw_insn->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
824 static_cast<int>(throw_insn->dalvikInsn.opcode) == kMirOpNullCheck) {
825 // No more checks for these (null check was processed above).
826 ok = true;
827 }
828 if (!ok) {
buzbee311ca162013-02-28 15:56:43 -0800829 break;
830 }
831
buzbee311ca162013-02-28 15:56:43 -0800832 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700833 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800834 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100835 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700836
837 // Now move instructions from bb_next to bb. Start off with doing a sanity check
838 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800839 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700840 // Now move all instructions (throw instruction to last one) from bb_next to bb.
841 MIR* last_to_move = bb_next->last_mir_insn;
842 bb_next->RemoveMIRList(throw_insn, last_to_move);
843 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
844 // The kMirOpCheck instruction is not needed anymore.
845 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
846 bb->RemoveMIR(mir);
847
Vladimir Marko312eb252014-10-07 15:01:57 +0100848 // Before we overwrite successors, remove their predecessor links to bb.
849 bb_next->ErasePredecessor(bb->id);
850 if (bb->taken != NullBasicBlockId) {
851 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
852 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
853 // bb->taken will be overwritten below.
854 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
855 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
856 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
857 bb_taken->predecessors.clear();
858 bb_taken->block_type = kDead;
859 DCHECK(bb_taken->data_flow_info == nullptr);
860 } else {
861 DCHECK_EQ(bb->successor_block_list_type, kCatch);
862 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
863 if (succ_info->block != NullBasicBlockId) {
864 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
865 DCHECK(succ_bb->catch_entry);
866 succ_bb->ErasePredecessor(bb->id);
867 if (succ_bb->predecessors.empty()) {
868 succ_bb->KillUnreachable(this);
869 }
870 }
871 }
872 }
buzbee311ca162013-02-28 15:56:43 -0800873 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700874 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100875 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100876 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800877 // Use the ending block linkage from the next block
878 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100879 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800880 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100881 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800882 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900883 * If lower-half of pair of blocks to combine contained
884 * a return or a conditional branch or an explicit throw,
885 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800886 */
887 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900888 bb->conditional_branch = bb_next->conditional_branch;
889 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100890 // Merge the use_lvn flag.
891 bb->use_lvn |= bb_next->use_lvn;
892
893 // Kill the unused block.
894 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800895
896 /*
897 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
898 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100899 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800900 */
901
Vladimir Marko312eb252014-10-07 15:01:57 +0100902 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800903 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100904 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700905 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100906 // Update predecessors in children.
907 ChildBlockIterator iter(bb, this);
908 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
909 child->UpdatePredecessor(bb_next->id, bb->id);
910 }
911
912 // DFS orders are not up to date anymore.
913 dfs_orders_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800914
915 // Now, loop back and see if we can keep going
916 }
buzbee311ca162013-02-28 15:56:43 -0800917}
918
Vladimir Marko67c72b82014-10-09 12:26:10 +0100919bool MIRGraph::EliminateNullChecksGate() {
920 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
921 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
922 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000923 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100924
Vladimir Marko67c72b82014-10-09 12:26:10 +0100925 DCHECK(temp_scoped_alloc_.get() == nullptr);
926 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700927 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000928 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
929 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
930 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100931 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000932 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700933
934 // reset MIR_MARK
935 AllNodesIterator iter(this);
936 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
937 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
938 mir->optimization_flags &= ~MIR_MARK;
939 }
940 }
941
Vladimir Marko67c72b82014-10-09 12:26:10 +0100942 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000943}
944
buzbee1da1e2f2013-11-15 13:37:01 -0800945/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100946 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800947 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100948bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100949 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
950 // Ignore the kExitBlock as well.
951 DCHECK(bb->first_mir_insn == nullptr);
952 return false;
953 }
buzbee311ca162013-02-28 15:56:43 -0800954
Vladimir Markof585e542014-11-21 13:41:32 +0000955 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100956 /*
957 * Set initial state. Catch blocks don't need any special treatment.
958 */
959 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100960 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100961 // Assume all ins are objects.
962 for (uint16_t in_reg = GetFirstInVR();
963 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100964 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100965 }
966 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100967 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100968 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100969 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100970 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100971 } else {
972 DCHECK_EQ(bb->block_type, kDalvikByteCode);
973 // Starting state is union of all incoming arcs.
974 bool copied_first = false;
975 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000976 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100977 continue;
978 }
979 BasicBlock* pred_bb = GetBasicBlock(pred_id);
980 DCHECK(pred_bb != nullptr);
981 MIR* null_check_insn = nullptr;
982 if (pred_bb->block_type == kDalvikByteCode) {
983 // Check to see if predecessor had an explicit null-check.
984 MIR* last_insn = pred_bb->last_mir_insn;
985 if (last_insn != nullptr) {
986 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
987 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
988 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
989 // Remember the null check insn if there's no other predecessor requiring null check.
990 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
991 null_check_insn = last_insn;
992 }
buzbee1da1e2f2013-11-15 13:37:01 -0800993 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700994 }
995 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100996 if (!copied_first) {
997 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000998 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100999 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001000 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001001 }
1002 if (null_check_insn != nullptr) {
1003 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +01001004 }
1005 }
1006 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -08001007 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001008 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +01001009 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -08001010
1011 // Walk through the instruction in the block, updating as necessary
1012 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -07001013 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -08001014
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -07001015 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
1016 // The algorithm was written in a phi agnostic way.
1017 continue;
1018 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001019
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001020 // Might need a null check?
1021 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001022 int src_vreg;
1023 if (df_attributes & DF_NULL_CHK_OUT0) {
1024 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
1025 src_vreg = mir->dalvikInsn.vC;
1026 } else if (df_attributes & DF_NULL_CHK_B) {
1027 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1028 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001029 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001030 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1031 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1032 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001033 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001034 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001035 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001036 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001037 } else {
1038 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001039 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001040 // Mark src_vreg as null-checked.
1041 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001042 }
1043 }
1044
1045 if ((df_attributes & DF_A_WIDE) ||
1046 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1047 continue;
1048 }
1049
1050 /*
1051 * First, mark all object definitions as requiring null check.
1052 * Note: we can't tell if a CONST definition might be used as an object, so treat
1053 * them all as object definitions.
1054 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001055 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001056 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001057 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001058 }
1059
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001060 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001061 if (df_attributes & DF_NON_NULL_DST) {
1062 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001063 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1064 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001065 }
1066
buzbee311ca162013-02-28 15:56:43 -08001067 // Mark non-null returns from invoke-style NEW*
1068 if (df_attributes & DF_NON_NULL_RET) {
1069 MIR* next_mir = mir->next;
1070 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001071 if (UNLIKELY(next_mir == nullptr)) {
1072 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1073 // target, so the MOVE_RESULT cannot be broken away into another block.
1074 LOG(WARNING) << "Unexpected end of block following new";
1075 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1076 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001077 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001078 // Mark as null checked.
1079 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001080 }
1081 }
1082
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001083 // Propagate null check state on register copies.
1084 if (df_attributes & DF_NULL_TRANSFER_0) {
1085 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1086 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1087 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001088 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001089 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001090 }
1091 }
buzbee311ca162013-02-28 15:56:43 -08001092 }
1093
1094 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001095 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001096 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001097 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001098 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001099 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001100 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001101 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001102 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1103 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001104 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001105 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001106 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1107 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001108 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001109 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001110}
1111
Vladimir Marko67c72b82014-10-09 12:26:10 +01001112void MIRGraph::EliminateNullChecksEnd() {
1113 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001114 temp_.nce.num_vregs = 0u;
1115 temp_.nce.work_vregs_to_check = nullptr;
1116 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001117 DCHECK(temp_scoped_alloc_.get() != nullptr);
1118 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001119
1120 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001121 AllNodesIterator iter(this);
1122 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1123 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001124 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001125 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001126 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001127 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001128 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1129 }
1130 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001131}
1132
1133/*
1134 * Perform type and size inference for a basic block.
1135 */
1136bool MIRGraph::InferTypes(BasicBlock* bb) {
1137 if (bb->data_flow_info == nullptr) return false;
1138
1139 bool infer_changed = false;
1140 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1141 if (mir->ssa_rep == NULL) {
1142 continue;
1143 }
1144
1145 // Propagate type info.
1146 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1147 }
1148
1149 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001150}
1151
1152bool MIRGraph::EliminateClassInitChecksGate() {
1153 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001154 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001155 return false;
1156 }
1157
Vladimir Markobfea9c22014-01-17 17:49:33 +00001158 DCHECK(temp_scoped_alloc_.get() == nullptr);
1159 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1160
1161 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001162 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001163 temp_.cice.indexes = static_cast<uint16_t*>(
1164 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1165 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001166
1167 uint32_t unique_class_count = 0u;
1168 {
1169 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1170 // ScopedArenaAllocator.
1171
1172 // Embed the map value in the entry to save space.
1173 struct MapEntry {
1174 // Map key: the class identified by the declaring dex file and type index.
1175 const DexFile* declaring_dex_file;
1176 uint16_t declaring_class_idx;
1177 // Map value: index into bit vectors of classes requiring initialization checks.
1178 uint16_t index;
1179 };
1180 struct MapEntryComparator {
1181 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1182 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1183 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1184 }
1185 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1186 }
1187 };
1188
Vladimir Markobfea9c22014-01-17 17:49:33 +00001189 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001190 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1191 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001192
1193 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1194 AllNodesIterator iter(this);
1195 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001196 if (bb->block_type == kDalvikByteCode) {
1197 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001198 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001199 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001200 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001201 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1202 MapEntry entry = {
1203 // Treat unresolved fields as if each had its own class.
1204 field_info.IsResolved() ? field_info.DeclaringDexFile()
1205 : nullptr,
1206 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1207 : field_info.FieldIndex(),
1208 static_cast<uint16_t>(class_to_index_map.size())
1209 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001210 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001211 // Using offset/2 for index into temp_.cice.indexes.
1212 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001213 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001214 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001215 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1216 DCHECK(method_info.IsStatic());
1217 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1218 MapEntry entry = {
1219 method_info.DeclaringDexFile(),
1220 method_info.DeclaringClassIndex(),
1221 static_cast<uint16_t>(class_to_index_map.size())
1222 };
1223 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001224 // Using offset/2 for index into temp_.cice.indexes.
1225 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001226 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001227 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001228 }
1229 }
1230 }
1231 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1232 }
1233
1234 if (unique_class_count == 0u) {
1235 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001236 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001237 temp_scoped_alloc_.reset();
1238 return false;
1239 }
1240
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001241 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001242 temp_.cice.num_class_bits = 2u * unique_class_count;
1243 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1244 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1245 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001246 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001247 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1248 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001249 return true;
1250}
1251
1252/*
1253 * Eliminate unnecessary class initialization checks for a basic block.
1254 */
1255bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1256 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001257 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1258 // Ignore the kExitBlock as well.
1259 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001260 return false;
1261 }
1262
1263 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001264 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001265 */
Vladimir Markof585e542014-11-21 13:41:32 +00001266 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001267 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001268 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001269 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001270 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001271 // Starting state is union of all incoming arcs.
1272 bool copied_first = false;
1273 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001274 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001275 continue;
1276 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001277 if (!copied_first) {
1278 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001279 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001280 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001281 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001282 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001283 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001284 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001285 }
1286 // At this point, classes_to_check shows which classes need clinit checks.
1287
1288 // Walk through the instruction in the block, updating as necessary
1289 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001290 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001291 if (index != 0xffffu) {
1292 bool check_initialization = false;
1293 bool check_dex_cache = false;
1294
1295 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1296 // Dex instructions with width 1 can have the same offset/2.
1297
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001298 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001299 check_initialization = true;
1300 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001301 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001302 check_initialization = true;
1303 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1304 }
1305
1306 if (check_dex_cache) {
1307 uint32_t check_dex_cache_index = 2u * index + 1u;
1308 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1309 // Eliminate the class init check.
1310 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1311 } else {
1312 // Do the class init check.
1313 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1314 }
1315 classes_to_check->ClearBit(check_dex_cache_index);
1316 }
1317 if (check_initialization) {
1318 uint32_t check_clinit_index = 2u * index;
1319 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1320 // Eliminate the class init check.
1321 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1322 } else {
1323 // Do the class init check.
1324 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001325 }
1326 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001327 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001328 }
1329 }
1330 }
1331
1332 // Did anything change?
1333 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001334 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001335 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001336 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001337 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001338 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001339 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001340 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1341 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001342 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001343 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001344 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1345 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001346 }
1347 return changed;
1348}
1349
1350void MIRGraph::EliminateClassInitChecksEnd() {
1351 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001352 temp_.cice.num_class_bits = 0u;
1353 temp_.cice.work_classes_to_check = nullptr;
1354 temp_.cice.ending_classes_to_check_matrix = nullptr;
1355 DCHECK(temp_.cice.indexes != nullptr);
1356 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001357 DCHECK(temp_scoped_alloc_.get() != nullptr);
1358 temp_scoped_alloc_.reset();
1359}
1360
Vladimir Marko95a05972014-05-30 10:01:32 +01001361bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001362 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001363 return false;
1364 }
1365
1366 DCHECK(temp_scoped_alloc_ == nullptr);
1367 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001368 temp_.gvn.ifield_ids_ =
1369 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1370 temp_.gvn.sfield_ids_ =
1371 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001372 DCHECK(temp_.gvn.gvn == nullptr);
1373 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1374 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001375 return true;
1376}
1377
1378bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001379 DCHECK(temp_.gvn.gvn != nullptr);
1380 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001381 if (lvn != nullptr) {
1382 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1383 lvn->GetValueNumber(mir);
1384 }
1385 }
Vladimir Markof585e542014-11-21 13:41:32 +00001386 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001387 return change;
1388}
1389
1390void MIRGraph::ApplyGlobalValueNumberingEnd() {
1391 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001392 DCHECK(temp_.gvn.gvn != nullptr);
1393 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001394 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001395 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001396 TopologicalSortIterator iter(this);
1397 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1398 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001399 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001400 if (lvn != nullptr) {
1401 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1402 lvn->GetValueNumber(mir);
1403 }
Vladimir Markof585e542014-11-21 13:41:32 +00001404 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001405 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001406 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001407 }
1408 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001409 // GVN was successful, running the LVN would be useless.
1410 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001411 } else {
1412 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1413 }
1414
Vladimir Markof585e542014-11-21 13:41:32 +00001415 delete temp_.gvn.gvn;
1416 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001417 temp_.gvn.ifield_ids_ = nullptr;
1418 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001419 DCHECK(temp_scoped_alloc_ != nullptr);
1420 temp_scoped_alloc_.reset();
1421}
1422
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001423void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1424 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001425 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1426 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001427 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1428 return;
1429 }
1430
1431 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1432 MethodReference target = method_info.GetTargetMethod();
1433 DexCompilationUnit inlined_unit(
1434 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1435 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1436 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001437 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1438 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001439 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1440 DCHECK(inlined_field_info.IsResolved());
1441
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001442 uint32_t field_info_index = ifield_lowering_infos_.size();
1443 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001444 temp_.smi.processed_indexes->SetBit(method_index);
1445 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001446 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1447}
1448
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001449bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001450 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001451 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001452 return false;
1453 }
1454 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1455 // This isn't the Quick compiler.
1456 return false;
1457 }
1458 return true;
1459}
1460
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001461void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001462 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1463 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1464
1465 DCHECK(temp_scoped_alloc_.get() == nullptr);
1466 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001467 temp_.smi.num_indexes = method_lowering_infos_.size();
1468 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1469 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1470 temp_.smi.processed_indexes->ClearAllBits();
1471 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1472 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001473}
1474
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001475void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001476 if (bb->block_type != kDalvikByteCode) {
1477 return;
1478 }
1479 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001480 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001481 continue;
1482 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001483 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001484 continue;
1485 }
1486 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1487 if (!method_info.FastPath()) {
1488 continue;
1489 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001490
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001491 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001492 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001493 continue;
1494 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001495
1496 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001497 bool needs_clinit = !method_info.IsClassInitialized() &&
1498 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001499 if (needs_clinit) {
1500 continue;
1501 }
1502 }
1503
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001504 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1505 MethodReference target = method_info.GetTargetMethod();
1506 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1507 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001508 if (cu_->verbose || cu_->print_pass) {
1509 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1510 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1511 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1512 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001513 }
1514 }
1515 }
1516}
1517
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001518void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001519 // Clean up temporaries.
1520 DCHECK(temp_.smi.lowering_infos != nullptr);
1521 temp_.smi.lowering_infos = nullptr;
1522 temp_.smi.num_indexes = 0u;
1523 DCHECK(temp_.smi.processed_indexes != nullptr);
1524 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001525 DCHECK(temp_scoped_alloc_.get() != nullptr);
1526 temp_scoped_alloc_.reset();
1527}
1528
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001529void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001530 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001531 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001532 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001533 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001534 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1535 CountChecks(bb);
1536 }
1537 if (stats->null_checks > 0) {
1538 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1539 float checks = static_cast<float>(stats->null_checks);
1540 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1541 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1542 << (eliminated/checks) * 100.0 << "%";
1543 }
1544 if (stats->range_checks > 0) {
1545 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1546 float checks = static_cast<float>(stats->range_checks);
1547 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1548 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1549 << (eliminated/checks) * 100.0 << "%";
1550 }
1551}
1552
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001553bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001554 if (bb->visited) return false;
1555 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1556 || (bb->block_type == kExitBlock))) {
1557 // Ignore special blocks
1558 bb->visited = true;
1559 return false;
1560 }
1561 // Must be head of extended basic block.
1562 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001563 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001564 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001565 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001566 // Visit blocks strictly dominated by this head.
1567 while (bb != NULL) {
1568 bb->visited = true;
1569 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001570 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001571 bb = NextDominatedBlock(bb);
1572 }
buzbee1da1e2f2013-11-15 13:37:01 -08001573 if (terminated_by_return || do_local_value_numbering) {
1574 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001575 bb = start_bb;
1576 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001577 bb->use_lvn = do_local_value_numbering;
1578 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001579 bb = NextDominatedBlock(bb);
1580 }
1581 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001582 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001583}
1584
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001585void MIRGraph::BasicBlockOptimization() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001586 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1587 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1588 temp_.gvn.ifield_ids_ =
1589 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1590 temp_.gvn.sfield_ids_ =
1591 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1592 }
1593
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001594 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1595 ClearAllVisitedFlags();
1596 PreOrderDfsIterator iter2(this);
1597 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1598 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001599 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001600 // Perform extended basic block optimizations.
1601 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1602 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1603 }
1604 } else {
1605 PreOrderDfsIterator iter(this);
1606 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1607 BasicBlockOpt(bb);
1608 }
buzbee311ca162013-02-28 15:56:43 -08001609 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001610
1611 // Clean up after LVN.
1612 temp_.gvn.ifield_ids_ = nullptr;
1613 temp_.gvn.sfield_ids_ = nullptr;
1614 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001615}
1616
Vladimir Marko8b858e12014-11-27 14:52:37 +00001617bool MIRGraph::EliminateSuspendChecksGate() {
1618 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1619 GetMaxNestedLoops() == 0u || // Nothing to do.
1620 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1621 // Exclude 32 as well to keep bit shifts well-defined.
1622 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1623 return false;
1624 }
1625 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1626 temp_.sce.inliner =
1627 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1628 }
1629 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1630 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1631 return true;
1632}
1633
1634bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1635 if (bb->block_type != kDalvikByteCode) {
1636 return false;
1637 }
1638 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1639 if (bb->nesting_depth == 0u) {
1640 // Out of loops.
1641 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1642 return false;
1643 }
1644 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1645 bool found_invoke = false;
1646 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1647 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1648 (temp_.sce.inliner == nullptr ||
1649 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1650 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1651 found_invoke = true;
1652 break;
1653 }
1654 }
1655 if (!found_invoke) {
1656 // Intersect suspend checks from predecessors.
1657 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1658 uint32_t pred_mask_union = 0u;
1659 for (BasicBlockId pred_id : bb->predecessors) {
1660 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1661 if (pred_topo_idx < bb_topo_idx) {
1662 // Determine the loop depth of the predecessors relative to this block.
1663 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1664 while (pred_loop_depth != 0u &&
1665 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1666 --pred_loop_depth;
1667 }
1668 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1669 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1670 // Intersect pred_mask bits in suspend_checks_in_loops with
1671 // suspend_checks_in_loops_[pred_id].
1672 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1673 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1674 pred_mask_union |= pred_mask;
1675 }
1676 }
1677 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1678 pred_mask_union);
1679 suspend_checks_in_loops &= pred_mask_union;
1680 }
1681 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1682 if (suspend_checks_in_loops == 0u) {
1683 return false;
1684 }
1685 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1686 if (bb->taken != NullBasicBlockId) {
1687 DCHECK(bb->last_mir_insn != nullptr);
1688 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1689 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1690 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1691 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1692 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1693 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1694 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1695 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1696 }
1697 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1698 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1699 MIR* mir = NewMIR();
1700 mir->dalvikInsn.opcode = Instruction::GOTO;
1701 mir->dalvikInsn.vA = 0; // Branch offset.
1702 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1703 mir->m_unit_index = current_method_;
1704 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1705 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1706 bb->AppendMIR(mir);
1707 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1708 }
1709 return true;
1710}
1711
1712void MIRGraph::EliminateSuspendChecksEnd() {
1713 temp_.sce.inliner = nullptr;
1714}
1715
Ningsheng Jiana262f772014-11-25 16:48:07 +08001716bool MIRGraph::CanThrow(MIR* mir) {
1717 if ((mir->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
1718 return false;
1719 }
1720 const int opt_flags = mir->optimization_flags;
1721 uint64_t df_attributes = GetDataFlowAttributes(mir);
1722
1723 if (((df_attributes & DF_HAS_NULL_CHKS) != 0) && ((opt_flags & MIR_IGNORE_NULL_CHECK) == 0)) {
1724 return true;
1725 }
1726 if ((df_attributes & DF_IFIELD) != 0) {
1727 // The IGET/IPUT family.
1728 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(mir);
1729 bool fast = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
1730 // Already processed null check above.
1731 if (fast) {
1732 return false;
1733 }
1734 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
1735 // The AGET/APUT family.
1736 // Already processed null check above.
1737 if ((opt_flags & MIR_IGNORE_RANGE_CHECK) != 0) {
1738 return false;
1739 }
1740 } else if ((df_attributes & DF_SFIELD) != 0) {
1741 // The SGET/SPUT family.
1742 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
1743 bool fast = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
1744 bool is_class_initialized = field_info.IsClassInitialized() ||
1745 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) != 0);
1746 if (fast && is_class_initialized) {
1747 return false;
1748 }
1749 }
1750 return true;
1751}
1752
1753bool MIRGraph::HasAntiDependency(MIR* first, MIR* second) {
1754 DCHECK(first->ssa_rep != nullptr);
1755 DCHECK(second->ssa_rep != nullptr);
1756 if ((second->ssa_rep->num_defs > 0) && (first->ssa_rep->num_uses > 0)) {
1757 int vreg0 = SRegToVReg(second->ssa_rep->defs[0]);
1758 int vreg1 = (second->ssa_rep->num_defs == 2) ?
1759 SRegToVReg(second->ssa_rep->defs[1]) : INVALID_VREG;
1760 for (int i = 0; i < first->ssa_rep->num_uses; i++) {
1761 int32_t use = SRegToVReg(first->ssa_rep->uses[i]);
1762 if (use == vreg0 || use == vreg1) {
1763 return true;
1764 }
1765 }
1766 }
1767 return false;
1768}
1769
1770void MIRGraph::CombineMultiplyAdd(MIR* mul_mir, MIR* add_mir, bool mul_is_first_addend,
1771 bool is_wide, bool is_sub) {
1772 if (is_wide) {
1773 if (is_sub) {
1774 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubLong);
1775 } else {
1776 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddLong);
1777 }
1778 } else {
1779 if (is_sub) {
1780 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMsubInt);
1781 } else {
1782 add_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpMaddInt);
1783 }
1784 }
1785 add_mir->ssa_rep->num_uses = is_wide ? 6 : 3;
1786 int32_t addend0 = INVALID_SREG;
1787 int32_t addend1 = INVALID_SREG;
1788 if (is_wide) {
1789 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[2] : add_mir->ssa_rep->uses[0];
1790 addend1 = mul_is_first_addend ? add_mir->ssa_rep->uses[3] : add_mir->ssa_rep->uses[1];
1791 } else {
1792 addend0 = mul_is_first_addend ? add_mir->ssa_rep->uses[1] : add_mir->ssa_rep->uses[0];
1793 }
1794
1795 AllocateSSAUseData(add_mir, add_mir->ssa_rep->num_uses);
1796 add_mir->ssa_rep->uses[0] = mul_mir->ssa_rep->uses[0];
1797 add_mir->ssa_rep->uses[1] = mul_mir->ssa_rep->uses[1];
1798 // Clear the original multiply product ssa use count, as it is not used anymore.
1799 raw_use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1800 use_counts_[mul_mir->ssa_rep->defs[0]] = 0;
1801 if (is_wide) {
1802 DCHECK_EQ(add_mir->ssa_rep->num_uses, 6);
1803 add_mir->ssa_rep->uses[2] = mul_mir->ssa_rep->uses[2];
1804 add_mir->ssa_rep->uses[3] = mul_mir->ssa_rep->uses[3];
1805 add_mir->ssa_rep->uses[4] = addend0;
1806 add_mir->ssa_rep->uses[5] = addend1;
1807 raw_use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1808 use_counts_[mul_mir->ssa_rep->defs[1]] = 0;
1809 } else {
1810 DCHECK_EQ(add_mir->ssa_rep->num_uses, 3);
1811 add_mir->ssa_rep->uses[2] = addend0;
1812 }
1813 // Copy in the decoded instruction information.
1814 add_mir->dalvikInsn.vB = SRegToVReg(add_mir->ssa_rep->uses[0]);
1815 if (is_wide) {
1816 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[2]);
1817 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[4]);
1818 } else {
1819 add_mir->dalvikInsn.vC = SRegToVReg(add_mir->ssa_rep->uses[1]);
1820 add_mir->dalvikInsn.arg[0] = SRegToVReg(add_mir->ssa_rep->uses[2]);
1821 }
1822 // Original multiply MIR is set to Nop.
1823 mul_mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
1824}
1825
1826void MIRGraph::MultiplyAddOpt(BasicBlock* bb) {
1827 if (bb->block_type == kDead) {
1828 return;
1829 }
1830 ScopedArenaAllocator allocator(&cu_->arena_stack);
1831 ScopedArenaSafeMap<uint32_t, MIR*> ssa_mul_map(std::less<uint32_t>(), allocator.Adapter());
1832 ScopedArenaSafeMap<uint32_t, MIR*>::iterator map_it;
1833 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1834 Instruction::Code opcode = mir->dalvikInsn.opcode;
1835 bool is_sub = true;
1836 bool is_candidate_multiply = false;
1837 switch (opcode) {
1838 case Instruction::MUL_INT:
1839 case Instruction::MUL_INT_2ADDR:
1840 is_candidate_multiply = true;
1841 break;
1842 case Instruction::MUL_LONG:
1843 case Instruction::MUL_LONG_2ADDR:
1844 if (cu_->target64) {
1845 is_candidate_multiply = true;
1846 }
1847 break;
1848 case Instruction::ADD_INT:
1849 case Instruction::ADD_INT_2ADDR:
1850 is_sub = false;
1851 FALLTHROUGH_INTENDED;
1852 case Instruction::SUB_INT:
1853 case Instruction::SUB_INT_2ADDR:
1854 if (((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end()) && !is_sub) {
1855 // a*b+c
1856 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1857 false /* is_wide */, false /* is_sub */);
1858 ssa_mul_map.erase(mir->ssa_rep->uses[0]);
1859 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[1])) != ssa_mul_map.end()) {
1860 // c+a*b or c-a*b
1861 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1862 false /* is_wide */, is_sub);
1863 ssa_mul_map.erase(map_it);
1864 }
1865 break;
1866 case Instruction::ADD_LONG:
1867 case Instruction::ADD_LONG_2ADDR:
1868 is_sub = false;
1869 FALLTHROUGH_INTENDED;
1870 case Instruction::SUB_LONG:
1871 case Instruction::SUB_LONG_2ADDR:
1872 if (!cu_->target64) {
1873 break;
1874 }
1875 if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[0])) != ssa_mul_map.end() && !is_sub) {
1876 // a*b+c
1877 CombineMultiplyAdd(map_it->second, mir, true /* product is the first addend */,
1878 true /* is_wide */, false /* is_sub */);
1879 ssa_mul_map.erase(map_it);
1880 } else if ((map_it = ssa_mul_map.find(mir->ssa_rep->uses[2])) != ssa_mul_map.end()) {
1881 // c+a*b or c-a*b
1882 CombineMultiplyAdd(map_it->second, mir, false /* product is the second addend */,
1883 true /* is_wide */, is_sub);
1884 ssa_mul_map.erase(map_it);
1885 }
1886 break;
1887 default:
1888 if (!ssa_mul_map.empty() && CanThrow(mir)) {
1889 // Should not combine multiply and add MIRs across potential exception.
1890 ssa_mul_map.clear();
1891 }
1892 break;
1893 }
1894
1895 // Exclude the case when an MIR writes a vreg which is previous candidate multiply MIR's uses.
1896 // It is because that current RA may allocate the same physical register to them. For this
1897 // kind of cases, the multiplier has been updated, we should not use updated value to the
1898 // multiply-add insn.
1899 if (ssa_mul_map.size() > 0) {
1900 for (auto it = ssa_mul_map.begin(); it != ssa_mul_map.end();) {
1901 MIR* mul = it->second;
1902 if (HasAntiDependency(mul, mir)) {
1903 it = ssa_mul_map.erase(it);
1904 } else {
1905 ++it;
1906 }
1907 }
1908 }
1909
1910 if (is_candidate_multiply &&
1911 (GetRawUseCount(mir->ssa_rep->defs[0]) == 1) && (mir->next != nullptr)) {
1912 ssa_mul_map.Put(mir->ssa_rep->defs[0], mir);
1913 }
1914 }
1915}
1916
buzbee311ca162013-02-28 15:56:43 -08001917} // namespace art