Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2012 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Brian Carlstrom | fc0e321 | 2013-07-17 14:40:12 -0700 | [diff] [blame] | 17 | #ifndef ART_RUNTIME_SCOPED_THREAD_STATE_CHANGE_H_ |
| 18 | #define ART_RUNTIME_SCOPED_THREAD_STATE_CHANGE_H_ |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 19 | |
Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 20 | #include "base/casts.h" |
Ian Rogers | 576ca0c | 2014-06-06 15:58:22 -0700 | [diff] [blame] | 21 | #include "jni_internal-inl.h" |
Ian Rogers | 693ff61 | 2013-02-01 10:56:12 -0800 | [diff] [blame] | 22 | #include "thread-inl.h" |
Mathieu Chartier | 4e30541 | 2014-02-19 10:54:44 -0800 | [diff] [blame] | 23 | #include "verify_object.h" |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 24 | |
| 25 | namespace art { |
| 26 | |
| 27 | // Scoped change into and out of a particular state. Handles Runnable transitions that require |
| 28 | // more complicated suspension checking. The subclasses ScopedObjectAccessUnchecked and |
Mathieu Chartier | eb8167a | 2014-05-07 15:43:14 -0700 | [diff] [blame] | 29 | // ScopedObjectAccess are used to handle the change into Runnable to Get direct access to objects, |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 30 | // the unchecked variant doesn't aid annotalysis. |
| 31 | class ScopedThreadStateChange { |
| 32 | public: |
| 33 | ScopedThreadStateChange(Thread* self, ThreadState new_thread_state) |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 34 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 35 | : self_(self), thread_state_(new_thread_state), expected_has_no_thread_(false) { |
Ian Rogers | c0fa3ad | 2013-02-05 00:11:55 -0800 | [diff] [blame] | 36 | if (UNLIKELY(self_ == NULL)) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 37 | // Value chosen arbitrarily and won't be used in the destructor since thread_ == NULL. |
| 38 | old_thread_state_ = kTerminated; |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 39 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 40 | CHECK(runtime == NULL || !runtime->IsStarted() || runtime->IsShuttingDown(self_)); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 41 | } else { |
Ian Rogers | 22f454c | 2012-09-08 11:06:29 -0700 | [diff] [blame] | 42 | DCHECK_EQ(self, Thread::Current()); |
| 43 | // Read state without locks, ok as state is effectively thread local and we're not interested |
| 44 | // in the suspend count (this will be handled in the runnable transitions). |
Ian Rogers | 474b6da | 2012-09-25 00:20:38 -0700 | [diff] [blame] | 45 | old_thread_state_ = self->GetState(); |
Mathieu Chartier | 92b7889 | 2014-04-24 16:14:43 -0700 | [diff] [blame] | 46 | if (old_thread_state_ != new_thread_state) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 47 | if (new_thread_state == kRunnable) { |
| 48 | self_->TransitionFromSuspendedToRunnable(); |
Mathieu Chartier | 92b7889 | 2014-04-24 16:14:43 -0700 | [diff] [blame] | 49 | } else if (old_thread_state_ == kRunnable) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 50 | self_->TransitionFromRunnableToSuspended(new_thread_state); |
Mathieu Chartier | 92b7889 | 2014-04-24 16:14:43 -0700 | [diff] [blame] | 51 | } else { |
| 52 | // A suspended transition to another effectively suspended transition, ok to use Unsafe. |
| 53 | self_->SetState(new_thread_state); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 54 | } |
| 55 | } |
| 56 | } |
| 57 | } |
| 58 | |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 59 | ~ScopedThreadStateChange() LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE { |
Ian Rogers | c0fa3ad | 2013-02-05 00:11:55 -0800 | [diff] [blame] | 60 | if (UNLIKELY(self_ == NULL)) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 61 | if (!expected_has_no_thread_) { |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 62 | Runtime* runtime = Runtime::Current(); |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 63 | bool shutting_down = (runtime == NULL) || runtime->IsShuttingDown(nullptr); |
Ian Rogers | 120f1c7 | 2012-09-28 17:17:10 -0700 | [diff] [blame] | 64 | CHECK(shutting_down); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 65 | } |
| 66 | } else { |
| 67 | if (old_thread_state_ != thread_state_) { |
| 68 | if (old_thread_state_ == kRunnable) { |
| 69 | self_->TransitionFromSuspendedToRunnable(); |
| 70 | } else if (thread_state_ == kRunnable) { |
| 71 | self_->TransitionFromRunnableToSuspended(old_thread_state_); |
| 72 | } else { |
Ian Rogers | 22f454c | 2012-09-08 11:06:29 -0700 | [diff] [blame] | 73 | // A suspended transition to another effectively suspended transition, ok to use Unsafe. |
Ian Rogers | 474b6da | 2012-09-25 00:20:38 -0700 | [diff] [blame] | 74 | self_->SetState(old_thread_state_); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 75 | } |
| 76 | } |
| 77 | } |
| 78 | } |
| 79 | |
| 80 | Thread* Self() const { |
| 81 | return self_; |
| 82 | } |
| 83 | |
| 84 | protected: |
| 85 | // Constructor used by ScopedJniThreadState for an unattached thread that has access to the VM*. |
| 86 | ScopedThreadStateChange() |
| 87 | : self_(NULL), thread_state_(kTerminated), old_thread_state_(kTerminated), |
| 88 | expected_has_no_thread_(true) {} |
| 89 | |
| 90 | Thread* const self_; |
| 91 | const ThreadState thread_state_; |
| 92 | |
| 93 | private: |
| 94 | ThreadState old_thread_state_; |
| 95 | const bool expected_has_no_thread_; |
| 96 | |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 97 | friend class ScopedObjectAccessUnchecked; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 98 | DISALLOW_COPY_AND_ASSIGN(ScopedThreadStateChange); |
| 99 | }; |
| 100 | |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 101 | // Assumes we are already runnable. |
| 102 | class ScopedObjectAccessAlreadyRunnable { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 103 | public: |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 104 | Thread* Self() const { |
| 105 | return self_; |
Ian Rogers | c0fa3ad | 2013-02-05 00:11:55 -0800 | [diff] [blame] | 106 | } |
| 107 | |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 108 | JNIEnvExt* Env() const { |
| 109 | return env_; |
| 110 | } |
| 111 | |
| 112 | JavaVMExt* Vm() const { |
| 113 | return vm_; |
| 114 | } |
| 115 | |
| 116 | /* |
| 117 | * Add a local reference for an object to the indirect reference table associated with the |
| 118 | * current stack frame. When the native function returns, the reference will be discarded. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 119 | * |
Elliott Hughes | 9dcd45c | 2013-07-29 14:40:52 -0700 | [diff] [blame] | 120 | * We need to allow the same reference to be added multiple times, and cope with NULL. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 121 | * |
Elliott Hughes | 9dcd45c | 2013-07-29 14:40:52 -0700 | [diff] [blame] | 122 | * This will be called on otherwise unreferenced objects. We cannot do GC allocations here, and |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 123 | * it's best if we don't grab a mutex. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 124 | */ |
| 125 | template<typename T> |
Ian Rogers | 2dd0e2c | 2013-01-24 12:42:14 -0800 | [diff] [blame] | 126 | T AddLocalReference(mirror::Object* obj) const SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 1eb512d | 2013-10-18 15:42:20 -0700 | [diff] [blame] | 127 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 128 | DCHECK(IsRunnable()); // Don't work with raw objects in non-runnable states. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 129 | if (obj == NULL) { |
| 130 | return NULL; |
| 131 | } |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 132 | DCHECK_NE((reinterpret_cast<uintptr_t>(obj) & 0xffff0000), 0xebad0000); |
Ian Rogers | 987560f | 2014-04-22 11:42:59 -0700 | [diff] [blame] | 133 | return Env()->AddLocalReference<T>(obj); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 134 | } |
| 135 | |
| 136 | template<typename T> |
| 137 | T Decode(jobject obj) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 138 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 139 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 140 | DCHECK(IsRunnable()); // Don't work with raw objects in non-runnable states. |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 141 | return down_cast<T>(Self()->DecodeJObject(obj)); |
| 142 | } |
| 143 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 144 | mirror::ArtField* DecodeField(jfieldID fid) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 145 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 146 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 147 | DCHECK(IsRunnable()); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 148 | CHECK(!kMovingFields); |
Hiroshi Yamauchi | ea2e1bd | 2014-06-18 13:47:35 -0700 | [diff] [blame] | 149 | mirror::ArtField* field = reinterpret_cast<mirror::ArtField*>(fid); |
| 150 | return ReadBarrier::BarrierForRoot<mirror::ArtField, kWithReadBarrier>(&field); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 151 | } |
| 152 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 153 | jfieldID EncodeField(mirror::ArtField* field) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 154 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 155 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 156 | DCHECK(IsRunnable()); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 157 | CHECK(!kMovingFields); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 158 | return reinterpret_cast<jfieldID>(field); |
| 159 | } |
| 160 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 161 | mirror::ArtMethod* DecodeMethod(jmethodID mid) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 162 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 163 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 164 | DCHECK(IsRunnable()); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 165 | CHECK(!kMovingMethods); |
Hiroshi Yamauchi | ea2e1bd | 2014-06-18 13:47:35 -0700 | [diff] [blame] | 166 | mirror::ArtMethod* method = reinterpret_cast<mirror::ArtMethod*>(mid); |
| 167 | return ReadBarrier::BarrierForRoot<mirror::ArtMethod, kWithReadBarrier>(&method); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 168 | } |
| 169 | |
Brian Carlstrom | ea46f95 | 2013-07-30 01:26:50 -0700 | [diff] [blame] | 170 | jmethodID EncodeMethod(mirror::ArtMethod* method) const |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 171 | SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) { |
Ian Rogers | 81d425b | 2012-09-27 16:03:43 -0700 | [diff] [blame] | 172 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 173 | DCHECK(IsRunnable()); // Don't work with raw objects in non-runnable states. |
Mathieu Chartier | 590fee9 | 2013-09-13 13:46:47 -0700 | [diff] [blame] | 174 | CHECK(!kMovingMethods); |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 175 | return reinterpret_cast<jmethodID>(method); |
| 176 | } |
| 177 | |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 178 | bool IsRunnable() const { |
| 179 | return self_->GetState() == kRunnable; |
| 180 | } |
| 181 | |
| 182 | protected: |
| 183 | explicit ScopedObjectAccessAlreadyRunnable(JNIEnv* env) |
| 184 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
| 185 | : self_(ThreadForEnv(env)), env_(down_cast<JNIEnvExt*>(env)), vm_(env_->vm) { |
| 186 | } |
| 187 | |
| 188 | explicit ScopedObjectAccessAlreadyRunnable(Thread* self) |
| 189 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
| 190 | : self_(self), env_(down_cast<JNIEnvExt*>(self->GetJniEnv())), |
| 191 | vm_(env_ != nullptr ? env_->vm : nullptr) { |
| 192 | } |
| 193 | |
| 194 | // Used when we want a scoped JNI thread state but have no thread/JNIEnv. Consequently doesn't |
| 195 | // change into Runnable or acquire a share on the mutator_lock_. |
| 196 | explicit ScopedObjectAccessAlreadyRunnable(JavaVM* vm) |
| 197 | : self_(nullptr), env_(nullptr), vm_(down_cast<JavaVMExt*>(vm)) {} |
| 198 | |
| 199 | // Here purely to force inlining. |
| 200 | ~ScopedObjectAccessAlreadyRunnable() ALWAYS_INLINE { |
| 201 | } |
| 202 | |
| 203 | // Self thread, can be null. |
| 204 | Thread* const self_; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 205 | // The full JNIEnv. |
| 206 | JNIEnvExt* const env_; |
| 207 | // The full JavaVM. |
| 208 | JavaVMExt* const vm_; |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 209 | }; |
| 210 | |
| 211 | // Entry/exit processing for transitions from Native to Runnable (ie within JNI functions). |
| 212 | // |
| 213 | // This class performs the necessary thread state switching to and from Runnable and lets us |
| 214 | // amortize the cost of working out the current thread. Additionally it lets us check (and repair) |
| 215 | // apps that are using a JNIEnv on the wrong thread. The class also decodes and encodes Objects |
| 216 | // into jobjects via methods of this class. Performing this here enforces the Runnable thread state |
| 217 | // for use of Object, thereby inhibiting the Object being modified by GC whilst native or VM code |
| 218 | // is also manipulating the Object. |
| 219 | // |
| 220 | // The destructor transitions back to the previous thread state, typically Native. In this state |
| 221 | // GC and thread suspension may occur. |
| 222 | // |
| 223 | // For annotalysis the subclass ScopedObjectAccess (below) makes it explicit that a shared of |
| 224 | // the mutator_lock_ will be acquired on construction. |
| 225 | class ScopedObjectAccessUnchecked : public ScopedObjectAccessAlreadyRunnable { |
| 226 | public: |
| 227 | explicit ScopedObjectAccessUnchecked(JNIEnv* env) |
| 228 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
| 229 | : ScopedObjectAccessAlreadyRunnable(env), tsc_(Self(), kRunnable) { |
| 230 | Self()->VerifyStack(); |
| 231 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
| 232 | } |
| 233 | |
| 234 | explicit ScopedObjectAccessUnchecked(Thread* self) |
| 235 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) ALWAYS_INLINE |
| 236 | : ScopedObjectAccessAlreadyRunnable(self), tsc_(self, kRunnable) { |
| 237 | Self()->VerifyStack(); |
| 238 | Locks::mutator_lock_->AssertSharedHeld(Self()); |
| 239 | } |
| 240 | |
| 241 | // Used when we want a scoped JNI thread state but have no thread/JNIEnv. Consequently doesn't |
| 242 | // change into Runnable or acquire a share on the mutator_lock_. |
| 243 | explicit ScopedObjectAccessUnchecked(JavaVM* vm) ALWAYS_INLINE |
| 244 | : ScopedObjectAccessAlreadyRunnable(vm), tsc_() {} |
| 245 | |
| 246 | private: |
| 247 | // The scoped thread state change makes sure that we are runnable and restores the thread state |
| 248 | // in the destructor. |
| 249 | const ScopedThreadStateChange tsc_; |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 250 | |
| 251 | DISALLOW_COPY_AND_ASSIGN(ScopedObjectAccessUnchecked); |
| 252 | }; |
| 253 | |
| 254 | // Annotalysis helping variant of the above. |
| 255 | class ScopedObjectAccess : public ScopedObjectAccessUnchecked { |
| 256 | public: |
| 257 | explicit ScopedObjectAccess(JNIEnv* env) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 258 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 259 | SHARED_LOCK_FUNCTION(Locks::mutator_lock_) ALWAYS_INLINE |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 260 | : ScopedObjectAccessUnchecked(env) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 261 | } |
| 262 | |
| 263 | explicit ScopedObjectAccess(Thread* self) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 264 | LOCKS_EXCLUDED(Locks::thread_suspend_count_lock_) |
Mathieu Chartier | 2b7c4d1 | 2014-05-19 10:52:16 -0700 | [diff] [blame] | 265 | SHARED_LOCK_FUNCTION(Locks::mutator_lock_) ALWAYS_INLINE |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 266 | : ScopedObjectAccessUnchecked(self) { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 267 | } |
| 268 | |
Ian Rogers | 1ffa32f | 2013-02-05 18:29:08 -0800 | [diff] [blame] | 269 | ~ScopedObjectAccess() UNLOCK_FUNCTION(Locks::mutator_lock_) ALWAYS_INLINE { |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 270 | // Base class will release share of lock. Invoked after this destructor. |
| 271 | } |
| 272 | |
| 273 | private: |
| 274 | // TODO: remove this constructor. It is used by check JNI's ScopedCheck to make it believe that |
| 275 | // routines operating with just a VM are sound, they are not, but when you have just a VM |
| 276 | // you cannot call the unsound routines. |
| 277 | explicit ScopedObjectAccess(JavaVM* vm) |
Ian Rogers | b726dcb | 2012-09-05 08:57:23 -0700 | [diff] [blame] | 278 | SHARED_LOCK_FUNCTION(Locks::mutator_lock_) |
Ian Rogers | 00f7d0e | 2012-07-19 15:28:27 -0700 | [diff] [blame] | 279 | : ScopedObjectAccessUnchecked(vm) {} |
| 280 | |
| 281 | friend class ScopedCheck; |
| 282 | DISALLOW_COPY_AND_ASSIGN(ScopedObjectAccess); |
| 283 | }; |
| 284 | |
| 285 | } // namespace art |
| 286 | |
Brian Carlstrom | fc0e321 | 2013-07-17 14:40:12 -0700 | [diff] [blame] | 287 | #endif // ART_RUNTIME_SCOPED_THREAD_STATE_CHANGE_H_ |