Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 1 | ############################################## |
| 2 | ## Perform configuration steps for sanitizers. |
| 3 | ############################################## |
| 4 | |
Dan Albert | 27ccb75 | 2015-04-16 16:21:02 -0700 | [diff] [blame] | 5 | my_sanitize := $(strip $(LOCAL_SANITIZE)) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 6 | |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 7 | # SANITIZE_HOST is only in effect if the module is already using clang (host |
| 8 | # modules that haven't set `LOCAL_CLANG := false` and device modules that |
| 9 | # have set `LOCAL_CLANG := true`. |
| 10 | my_global_sanitize := |
| 11 | ifeq ($(my_clang),true) |
| 12 | ifdef LOCAL_IS_HOST_MODULE |
| 13 | my_global_sanitize := $(strip $(SANITIZE_HOST)) |
| 14 | |
| 15 | # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address. |
| 16 | my_global_sanitize := $(subst true,address,$(my_global_sanitize)) |
| 17 | else |
| 18 | my_global_sanitize := $(strip $(SANITIZE_TARGET)) |
| 19 | endif |
| 20 | endif |
| 21 | |
| 22 | # The sanitizer specified by the environment wins over the module. |
| 23 | ifneq ($(my_global_sanitize),) |
| 24 | my_sanitize := $(my_global_sanitize) |
| 25 | endif |
| 26 | |
Andreas Gampe | cd25740 | 2016-06-20 17:36:49 -0700 | [diff] [blame^] | 27 | # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden). |
| 28 | SANITIZE_ARCH ?= 32 64 |
| 29 | ifeq ($(filter $(SANITIZE_ARCH),$(my_32_64_bit_suffix)),) |
| 30 | my_sanitize := |
| 31 | endif |
| 32 | |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 33 | # Don't apply sanitizers to NDK code. |
| 34 | ifdef LOCAL_SDK_VERSION |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 35 | my_sanitize := |
Dan Albert | 27ccb75 | 2015-04-16 16:21:02 -0700 | [diff] [blame] | 36 | endif |
| 37 | |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 38 | # Never always wins. |
| 39 | ifeq ($(LOCAL_SANITIZE),never) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 40 | my_sanitize := |
| 41 | endif |
| 42 | |
Evgenii Stepanov | 4282366 | 2016-05-12 13:07:17 -0700 | [diff] [blame] | 43 | my_nosanitize = $(strip $(LOCAL_NOSANITIZE)) |
| 44 | ifneq ($(my_nosanitize),) |
| 45 | my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize)) |
| 46 | endif |
| 47 | |
Dan Albert | a6311b7 | 2015-07-30 10:17:33 -0700 | [diff] [blame] | 48 | # TSAN is not supported on 32-bit architectures. For non-multilib cases, make |
| 49 | # its use an error. For multilib cases, don't use it for the 32-bit case. |
| 50 | ifneq ($(filter thread,$(my_sanitize)),) |
| 51 | ifeq ($(my_32_64_bit_suffix),32) |
| 52 | ifeq ($(my_module_multilib),both) |
| 53 | my_sanitize := $(filter-out thread,$(my_sanitize)) |
| 54 | else |
| 55 | $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.) |
| 56 | endif |
| 57 | endif |
| 58 | endif |
| 59 | |
Evgenii Stepanov | 5adfcb1 | 2015-06-25 16:38:25 -0700 | [diff] [blame] | 60 | # Undefined symbols can occur if a non-sanitized library links |
| 61 | # sanitized static libraries. That's OK, because the executable |
| 62 | # always depends on the ASan runtime library, which defines these |
| 63 | # symbols. |
| 64 | ifneq ($(strip $(SANITIZE_TARGET)),) |
| 65 | ifndef LOCAL_IS_HOST_MODULE |
| 66 | ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES) |
| 67 | ifeq ($(my_sanitize),) |
| 68 | my_allow_undefined_symbols := true |
| 69 | endif |
| 70 | endif |
Evgenii Stepanov | 4b396e4 | 2015-07-20 16:32:53 -0700 | [diff] [blame] | 71 | # Workaround for a bug in AddressSanitizer that breaks stack unwinding. |
| 72 | # https://code.google.com/p/address-sanitizer/issues/detail?id=387 |
| 73 | # Revert when external/compiler-rt is updated past r236014. |
| 74 | LOCAL_PACK_MODULE_RELOCATIONS := false |
Evgenii Stepanov | 5adfcb1 | 2015-06-25 16:38:25 -0700 | [diff] [blame] | 75 | endif |
| 76 | endif |
| 77 | |
Dan Albert | 94b5791 | 2015-04-17 09:48:33 -0700 | [diff] [blame] | 78 | # Sanitizers can only be used with clang. |
| 79 | ifneq ($(my_clang),true) |
| 80 | ifneq ($(my_sanitize),) |
| 81 | $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of sanitizers requires LOCAL_CLANG := true) |
| 82 | endif |
| 83 | endif |
| 84 | |
Dan Albert | b5b2ffe | 2015-04-16 18:07:07 -0700 | [diff] [blame] | 85 | ifneq ($(filter default-ub,$(my_sanitize)),) |
| 86 | my_sanitize := $(CLANG_DEFAULT_UB_CHECKS) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 87 | endif |
| 88 | |
Ivan Krasin | 74b32b8 | 2015-09-18 11:54:43 -0700 | [diff] [blame] | 89 | ifneq ($(filter coverage,$(my_sanitize)),) |
| 90 | ifeq ($(filter address,$(my_sanitize)),) |
| 91 | $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of 'coverage' also requires 'address') |
| 92 | endif |
| 93 | my_cflags += -fsanitize-coverage=edge,indirect-calls,8bit-counters,trace-cmp |
| 94 | my_sanitize := $(filter-out coverage,$(my_sanitize)) |
| 95 | endif |
| 96 | |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 97 | ifneq ($(my_sanitize),) |
Stephen Hines | e8119e9 | 2015-11-09 16:32:11 -0800 | [diff] [blame] | 98 | fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize)) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 99 | my_cflags += -fsanitize=$(fsanitize_arg) |
| 100 | |
| 101 | ifdef LOCAL_IS_HOST_MODULE |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 102 | my_cflags += -fno-sanitize-recover=all |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 103 | my_ldflags += -fsanitize=$(fsanitize_arg) |
Dan Albert | 2922411 | 2015-08-13 17:25:10 -0700 | [diff] [blame] | 104 | my_ldlibs += -lrt -ldl |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 105 | else |
Stephen Hines | e8119e9 | 2015-11-09 16:32:11 -0800 | [diff] [blame] | 106 | ifeq ($(filter address,$(my_sanitize)),) |
| 107 | my_cflags += -fsanitize-trap=all |
| 108 | my_cflags += -ftrap-function=abort |
| 109 | endif |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 110 | my_shared_libraries += libdl |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 111 | endif |
| 112 | endif |
| 113 | |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 114 | # If local or global modules need ASAN, add linker flags. |
| 115 | ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),) |
Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 116 | my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS) |
| 117 | ifdef LOCAL_IS_HOST_MODULE |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 118 | # -nodefaultlibs (provided with libc++) prevents the driver from linking |
| 119 | # libraries needed with -fsanitize=address. http://b/18650275 (WAI) |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 120 | my_ldlibs += -lm -lpthread |
Dan Albert | 1f0d530 | 2015-04-28 14:55:50 -0700 | [diff] [blame] | 121 | my_ldflags += -Wl,--no-as-needed |
Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 122 | else |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 123 | # Add asan libraries unless LOCAL_MODULE is the asan library. |
Evgenii Stepanov | f0b15e1 | 2015-04-24 16:34:47 -0700 | [diff] [blame] | 124 | # ASan runtime library must be the first in the link order. |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 125 | ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY))) |
| 126 | my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \ |
| 127 | $(my_shared_libraries) |
| 128 | endif |
| 129 | ifeq (,$(filter $(LOCAL_MODULE),$(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES))) |
| 130 | my_static_libraries += $(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES) |
| 131 | endif |
| 132 | |
| 133 | # Do not add unnecessary dependency in shared libraries. |
| 134 | ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES) |
| 135 | my_ldflags += -Wl,--as-needed |
| 136 | endif |
Ying Wang | a05e222 | 2015-08-17 16:13:24 -0700 | [diff] [blame] | 137 | |
Evgenii Stepanov | 8f5e67a | 2015-07-10 18:06:51 -0700 | [diff] [blame] | 138 | my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER) |
Ying Wang | a05e222 | 2015-08-17 16:13:24 -0700 | [diff] [blame] | 139 | # Make sure linker_asan get installed. |
| 140 | $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 141 | endif |
| 142 | endif |
| 143 | |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 144 | # If local module needs ASAN, add compiler flags. |
| 145 | ifneq ($(filter address,$(my_sanitize)),) |
| 146 | # Frame pointer based unwinder in ASan requires ARM frame setup. |
| 147 | LOCAL_ARM_MODE := arm |
| 148 | my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS) |
| 149 | ifndef LOCAL_IS_HOST_MODULE |
| 150 | my_cflags += -mllvm -asan-globals=0 |
| 151 | endif |
| 152 | endif |
| 153 | |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 154 | ifneq ($(filter undefined,$(my_sanitize)),) |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 155 | ifndef LOCAL_IS_HOST_MODULE |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 156 | $(error ubsan is not yet supported on the target) |
Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 157 | endif |
| 158 | endif |
Dan Albert | 4111d48 | 2015-04-16 18:08:44 -0700 | [diff] [blame] | 159 | |
Dan Albert | 9f17655 | 2015-04-28 11:26:45 -0700 | [diff] [blame] | 160 | ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),) |
| 161 | recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)), |
Dan Albert | 4111d48 | 2015-04-16 18:08:44 -0700 | [diff] [blame] | 162 | my_cflags += -fsanitize-recover=$(recover_arg) |
| 163 | endif |