Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES2.cpp: Validation functions for OpenGL ES 2.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame^] | 9 | #include "libANGLE/validationES2.h" |
| 10 | #include "libANGLE/validationES.h" |
| 11 | #include "libANGLE/Context.h" |
| 12 | #include "libANGLE/Texture.h" |
| 13 | #include "libANGLE/Framebuffer.h" |
| 14 | #include "libANGLE/Renderbuffer.h" |
| 15 | #include "libANGLE/formatutils.h" |
| 16 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 17 | |
| 18 | #include "common/mathutil.h" |
| 19 | #include "common/utilities.h" |
| 20 | |
| 21 | namespace gl |
| 22 | { |
| 23 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 24 | static bool ValidateSubImageParams2D(Context *context, bool compressed, GLsizei width, GLsizei height, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | GLint xoffset, GLint yoffset, GLint level, GLenum format, GLenum type, |
| 26 | gl::Texture2D *texture) |
| 27 | { |
| 28 | if (!texture) |
| 29 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 30 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 31 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 32 | } |
| 33 | |
| 34 | if (compressed != texture->isCompressed(level)) |
| 35 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 36 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 37 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 38 | } |
| 39 | |
| 40 | if (format != GL_NONE) |
| 41 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 42 | if (gl::GetFormatTypeInfo(format, type).internalFormat != texture->getInternalFormat(level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 43 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 44 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 45 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 46 | } |
| 47 | } |
| 48 | |
| 49 | if (compressed) |
| 50 | { |
Geoff Lang | a836e48 | 2014-04-28 10:08:27 -0400 | [diff] [blame] | 51 | if ((width % 4 != 0 && width != texture->getWidth(level)) || |
| 52 | (height % 4 != 0 && height != texture->getHeight(level))) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 53 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 54 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 55 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 56 | } |
| 57 | } |
| 58 | |
| 59 | if (xoffset + width > texture->getWidth(level) || |
| 60 | yoffset + height > texture->getHeight(level)) |
| 61 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 62 | context->recordError(Error(GL_INVALID_VALUE)); |
| 63 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 64 | } |
| 65 | |
| 66 | return true; |
| 67 | } |
| 68 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 69 | static bool ValidateSubImageParamsCube(Context *context, bool compressed, GLsizei width, GLsizei height, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 70 | GLint xoffset, GLint yoffset, GLenum target, GLint level, GLenum format, GLenum type, |
| 71 | gl::TextureCubeMap *texture) |
| 72 | { |
| 73 | if (!texture) |
| 74 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 75 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 76 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 77 | } |
| 78 | |
| 79 | if (compressed != texture->isCompressed(target, level)) |
| 80 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 81 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 82 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 83 | } |
| 84 | |
| 85 | if (format != GL_NONE) |
| 86 | { |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 87 | if (gl::GetFormatTypeInfo(format, type).internalFormat != texture->getInternalFormat(target, level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 88 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 89 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 90 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 91 | } |
| 92 | } |
| 93 | |
| 94 | if (compressed) |
| 95 | { |
| 96 | if ((width % 4 != 0 && width != texture->getWidth(target, 0)) || |
| 97 | (height % 4 != 0 && height != texture->getHeight(target, 0))) |
| 98 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 99 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 100 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 101 | } |
| 102 | } |
| 103 | |
| 104 | if (xoffset + width > texture->getWidth(target, level) || |
| 105 | yoffset + height > texture->getHeight(target, level)) |
| 106 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 107 | context->recordError(Error(GL_INVALID_VALUE)); |
| 108 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 109 | } |
| 110 | |
| 111 | return true; |
| 112 | } |
| 113 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 114 | bool ValidateES2TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 115 | GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, |
| 116 | GLint border, GLenum format, GLenum type, const GLvoid *pixels) |
| 117 | { |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 118 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 119 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 120 | context->recordError(Error(GL_INVALID_ENUM)); |
| 121 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 122 | } |
| 123 | |
Geoff Lang | ce63569 | 2013-09-24 13:56:32 -0400 | [diff] [blame] | 124 | if (!ValidImageSize(context, target, level, width, height, 1)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 125 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 126 | context->recordError(Error(GL_INVALID_VALUE)); |
| 127 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 128 | } |
| 129 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 130 | if (level < 0 || xoffset < 0 || |
| 131 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 132 | std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 133 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 134 | context->recordError(Error(GL_INVALID_VALUE)); |
| 135 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 136 | } |
| 137 | |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 138 | if (!isSubImage && !isCompressed && internalformat != format) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 139 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 140 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 141 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 142 | } |
| 143 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 144 | const gl::Caps &caps = context->getCaps(); |
| 145 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 146 | gl::Texture *texture = NULL; |
| 147 | bool textureCompressed = false; |
| 148 | GLenum textureInternalFormat = GL_NONE; |
| 149 | GLint textureLevelWidth = 0; |
| 150 | GLint textureLevelHeight = 0; |
| 151 | switch (target) |
| 152 | { |
| 153 | case GL_TEXTURE_2D: |
| 154 | { |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 155 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 156 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 157 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 158 | context->recordError(Error(GL_INVALID_VALUE)); |
| 159 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 160 | } |
| 161 | |
| 162 | gl::Texture2D *tex2d = context->getTexture2D(); |
| 163 | if (tex2d) |
| 164 | { |
| 165 | textureCompressed = tex2d->isCompressed(level); |
| 166 | textureInternalFormat = tex2d->getInternalFormat(level); |
| 167 | textureLevelWidth = tex2d->getWidth(level); |
| 168 | textureLevelHeight = tex2d->getHeight(level); |
| 169 | texture = tex2d; |
| 170 | } |
| 171 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 172 | if (isSubImage && !ValidateSubImageParams2D(context, isCompressed, width, height, xoffset, yoffset, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 173 | level, format, type, tex2d)) |
| 174 | { |
| 175 | return false; |
| 176 | } |
| 177 | |
| 178 | texture = tex2d; |
| 179 | } |
| 180 | break; |
| 181 | |
| 182 | case GL_TEXTURE_CUBE_MAP_POSITIVE_X: |
| 183 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_X: |
| 184 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Y: |
| 185 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y: |
| 186 | case GL_TEXTURE_CUBE_MAP_POSITIVE_Z: |
| 187 | case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z: |
| 188 | { |
| 189 | if (!isSubImage && width != height) |
| 190 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 191 | context->recordError(Error(GL_INVALID_VALUE)); |
| 192 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 193 | } |
| 194 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 195 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level) || |
| 196 | static_cast<GLuint>(height) > (caps.maxCubeMapTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 197 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 198 | context->recordError(Error(GL_INVALID_VALUE)); |
| 199 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 200 | } |
| 201 | |
| 202 | gl::TextureCubeMap *texCube = context->getTextureCubeMap(); |
| 203 | if (texCube) |
| 204 | { |
| 205 | textureCompressed = texCube->isCompressed(target, level); |
| 206 | textureInternalFormat = texCube->getInternalFormat(target, level); |
| 207 | textureLevelWidth = texCube->getWidth(target, level); |
| 208 | textureLevelHeight = texCube->getHeight(target, level); |
| 209 | texture = texCube; |
| 210 | } |
| 211 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 212 | if (isSubImage && !ValidateSubImageParamsCube(context, isCompressed, width, height, xoffset, yoffset, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 213 | target, level, format, type, texCube)) |
| 214 | { |
| 215 | return false; |
| 216 | } |
| 217 | } |
| 218 | break; |
| 219 | |
| 220 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 221 | context->recordError(Error(GL_INVALID_ENUM)); |
| 222 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 223 | } |
| 224 | |
| 225 | if (!texture) |
| 226 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 227 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 228 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 229 | } |
| 230 | |
| 231 | if (!isSubImage && texture->isImmutable()) |
| 232 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 233 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 234 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 235 | } |
| 236 | |
| 237 | // Verify zero border |
| 238 | if (border != 0) |
| 239 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 240 | context->recordError(Error(GL_INVALID_VALUE)); |
| 241 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 242 | } |
| 243 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 244 | GLenum actualInternalFormat = isSubImage ? textureInternalFormat : internalformat; |
| 245 | if (isCompressed) |
| 246 | { |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 247 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
| 248 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 249 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 250 | return false; |
Geoff Lang | d4f180b | 2013-09-24 13:57:44 -0400 | [diff] [blame] | 251 | } |
| 252 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 253 | switch (actualInternalFormat) |
| 254 | { |
| 255 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 256 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 257 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 258 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 259 | context->recordError(Error(GL_INVALID_ENUM)); |
| 260 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 261 | } |
| 262 | break; |
| 263 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 264 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 265 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 266 | context->recordError(Error(GL_INVALID_ENUM)); |
| 267 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 268 | } |
| 269 | break; |
| 270 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 271 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 272 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 273 | context->recordError(Error(GL_INVALID_ENUM)); |
| 274 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 275 | } |
| 276 | break; |
| 277 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 278 | context->recordError(Error(GL_INVALID_ENUM)); |
| 279 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 280 | } |
| 281 | } |
| 282 | else |
| 283 | { |
| 284 | // validate <type> by itself (used as secondary key below) |
| 285 | switch (type) |
| 286 | { |
| 287 | case GL_UNSIGNED_BYTE: |
| 288 | case GL_UNSIGNED_SHORT_5_6_5: |
| 289 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 290 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 291 | case GL_UNSIGNED_SHORT: |
| 292 | case GL_UNSIGNED_INT: |
| 293 | case GL_UNSIGNED_INT_24_8_OES: |
| 294 | case GL_HALF_FLOAT_OES: |
| 295 | case GL_FLOAT: |
| 296 | break; |
| 297 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 298 | context->recordError(Error(GL_INVALID_ENUM)); |
| 299 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 300 | } |
| 301 | |
| 302 | // validate <format> + <type> combinations |
| 303 | // - invalid <format> -> sets INVALID_ENUM |
| 304 | // - invalid <format>+<type> combination -> sets INVALID_OPERATION |
| 305 | switch (format) |
| 306 | { |
| 307 | case GL_ALPHA: |
| 308 | case GL_LUMINANCE: |
| 309 | case GL_LUMINANCE_ALPHA: |
| 310 | switch (type) |
| 311 | { |
| 312 | case GL_UNSIGNED_BYTE: |
| 313 | case GL_FLOAT: |
| 314 | case GL_HALF_FLOAT_OES: |
| 315 | break; |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 316 | default: |
| 317 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 318 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 319 | } |
| 320 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 321 | case GL_RED: |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 322 | case GL_RG: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 323 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 324 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 325 | context->recordError(Error(GL_INVALID_ENUM)); |
| 326 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 327 | } |
| 328 | switch (type) |
| 329 | { |
| 330 | case GL_UNSIGNED_BYTE: |
| 331 | case GL_FLOAT: |
| 332 | case GL_HALF_FLOAT_OES: |
| 333 | break; |
| 334 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 335 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 336 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 337 | } |
| 338 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 339 | case GL_RGB: |
| 340 | switch (type) |
| 341 | { |
| 342 | case GL_UNSIGNED_BYTE: |
| 343 | case GL_UNSIGNED_SHORT_5_6_5: |
| 344 | case GL_FLOAT: |
| 345 | case GL_HALF_FLOAT_OES: |
| 346 | break; |
| 347 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 348 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 349 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 350 | } |
| 351 | break; |
| 352 | case GL_RGBA: |
| 353 | switch (type) |
| 354 | { |
| 355 | case GL_UNSIGNED_BYTE: |
| 356 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 357 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 358 | case GL_FLOAT: |
| 359 | case GL_HALF_FLOAT_OES: |
| 360 | break; |
| 361 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 362 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 363 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 364 | } |
| 365 | break; |
| 366 | case GL_BGRA_EXT: |
| 367 | switch (type) |
| 368 | { |
| 369 | case GL_UNSIGNED_BYTE: |
| 370 | break; |
| 371 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 372 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 373 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 374 | } |
| 375 | break; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 376 | case GL_SRGB_EXT: |
| 377 | case GL_SRGB_ALPHA_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 378 | if (!context->getExtensions().sRGB) |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 379 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 380 | context->recordError(Error(GL_INVALID_ENUM)); |
| 381 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 382 | } |
| 383 | switch (type) |
| 384 | { |
| 385 | case GL_UNSIGNED_BYTE: |
| 386 | break; |
| 387 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 388 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 389 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 390 | } |
| 391 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 392 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: // error cases for compressed textures are handled below |
| 393 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 394 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 395 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
| 396 | break; |
| 397 | case GL_DEPTH_COMPONENT: |
| 398 | switch (type) |
| 399 | { |
| 400 | case GL_UNSIGNED_SHORT: |
| 401 | case GL_UNSIGNED_INT: |
| 402 | break; |
| 403 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 404 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 405 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 406 | } |
| 407 | break; |
| 408 | case GL_DEPTH_STENCIL_OES: |
| 409 | switch (type) |
| 410 | { |
| 411 | case GL_UNSIGNED_INT_24_8_OES: |
| 412 | break; |
| 413 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 414 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 415 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 416 | } |
| 417 | break; |
| 418 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 419 | context->recordError(Error(GL_INVALID_ENUM)); |
| 420 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 421 | } |
| 422 | |
| 423 | switch (format) |
| 424 | { |
| 425 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 426 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 427 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 428 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 429 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 430 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 431 | } |
| 432 | else |
| 433 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 434 | context->recordError(Error(GL_INVALID_ENUM)); |
| 435 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 436 | } |
| 437 | break; |
| 438 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 439 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 440 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 441 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 442 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 443 | } |
| 444 | else |
| 445 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 446 | context->recordError(Error(GL_INVALID_ENUM)); |
| 447 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 448 | } |
| 449 | break; |
| 450 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 451 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 452 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 453 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 454 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 455 | } |
| 456 | else |
| 457 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 458 | context->recordError(Error(GL_INVALID_ENUM)); |
| 459 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 460 | } |
| 461 | break; |
| 462 | case GL_DEPTH_COMPONENT: |
| 463 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 464 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 465 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 466 | context->recordError(Error(GL_INVALID_VALUE)); |
| 467 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 468 | } |
| 469 | if (target != GL_TEXTURE_2D) |
| 470 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 471 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 472 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 473 | } |
| 474 | // OES_depth_texture supports loading depth data and multiple levels, |
| 475 | // but ANGLE_depth_texture does not |
| 476 | if (pixels != NULL || level != 0) |
| 477 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 478 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 479 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 480 | } |
| 481 | break; |
| 482 | default: |
| 483 | break; |
| 484 | } |
| 485 | |
| 486 | if (type == GL_FLOAT) |
| 487 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 488 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 489 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 490 | context->recordError(Error(GL_INVALID_ENUM)); |
| 491 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 492 | } |
| 493 | } |
| 494 | else if (type == GL_HALF_FLOAT_OES) |
| 495 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 496 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 497 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 498 | context->recordError(Error(GL_INVALID_ENUM)); |
| 499 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 500 | } |
| 501 | } |
| 502 | } |
| 503 | |
| 504 | return true; |
| 505 | } |
| 506 | |
| 507 | |
| 508 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 509 | bool ValidateES2CopyTexImageParameters(Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 510 | GLint xoffset, GLint yoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 511 | GLint border) |
| 512 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 513 | GLenum textureInternalFormat = GL_NONE; |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 514 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 515 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 516 | xoffset, yoffset, 0, x, y, width, height, border, &textureInternalFormat)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 517 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 518 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 519 | } |
| 520 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 521 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 522 | GLenum colorbufferFormat = framebuffer->getReadColorbuffer()->getInternalFormat(); |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 523 | GLenum textureFormat = gl::GetInternalFormatInfo(textureInternalFormat).format; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 524 | |
| 525 | // [OpenGL ES 2.0.24] table 3.9 |
| 526 | if (isSubImage) |
| 527 | { |
| 528 | switch (textureFormat) |
| 529 | { |
| 530 | case GL_ALPHA: |
| 531 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 532 | colorbufferFormat != GL_RGBA4 && |
| 533 | colorbufferFormat != GL_RGB5_A1 && |
| 534 | colorbufferFormat != GL_RGBA8_OES) |
| 535 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 536 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 537 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 538 | } |
| 539 | break; |
| 540 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 541 | if (colorbufferFormat != GL_R8_EXT && |
| 542 | colorbufferFormat != GL_RG8_EXT && |
| 543 | colorbufferFormat != GL_RGB565 && |
| 544 | colorbufferFormat != GL_RGB8_OES && |
| 545 | colorbufferFormat != GL_RGBA4 && |
| 546 | colorbufferFormat != GL_RGB5_A1 && |
| 547 | colorbufferFormat != GL_RGBA8_OES) |
| 548 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 549 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 550 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 551 | } |
| 552 | break; |
| 553 | case GL_RED_EXT: |
| 554 | if (colorbufferFormat != GL_R8_EXT && |
| 555 | colorbufferFormat != GL_RG8_EXT && |
| 556 | colorbufferFormat != GL_RGB565 && |
| 557 | colorbufferFormat != GL_RGB8_OES && |
| 558 | colorbufferFormat != GL_RGBA4 && |
| 559 | colorbufferFormat != GL_RGB5_A1 && |
| 560 | colorbufferFormat != GL_RGBA8_OES) |
| 561 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 562 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 563 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 564 | } |
| 565 | break; |
| 566 | case GL_RG_EXT: |
| 567 | if (colorbufferFormat != GL_RG8_EXT && |
| 568 | colorbufferFormat != GL_RGB565 && |
| 569 | colorbufferFormat != GL_RGB8_OES && |
| 570 | colorbufferFormat != GL_RGBA4 && |
| 571 | colorbufferFormat != GL_RGB5_A1 && |
| 572 | colorbufferFormat != GL_RGBA8_OES) |
| 573 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 574 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 575 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 576 | } |
| 577 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 578 | case GL_RGB: |
| 579 | if (colorbufferFormat != GL_RGB565 && |
| 580 | colorbufferFormat != GL_RGB8_OES && |
| 581 | colorbufferFormat != GL_RGBA4 && |
| 582 | colorbufferFormat != GL_RGB5_A1 && |
| 583 | colorbufferFormat != GL_RGBA8_OES) |
| 584 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 585 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 586 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 587 | } |
| 588 | break; |
| 589 | case GL_LUMINANCE_ALPHA: |
| 590 | case GL_RGBA: |
| 591 | if (colorbufferFormat != GL_RGBA4 && |
| 592 | colorbufferFormat != GL_RGB5_A1 && |
| 593 | colorbufferFormat != GL_RGBA8_OES) |
| 594 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 595 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 596 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 597 | } |
| 598 | break; |
| 599 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 600 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 601 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 602 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 603 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 604 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 605 | case GL_DEPTH_COMPONENT: |
| 606 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 607 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 608 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 609 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 610 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 611 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 612 | } |
| 613 | } |
| 614 | else |
| 615 | { |
| 616 | switch (internalformat) |
| 617 | { |
| 618 | case GL_ALPHA: |
| 619 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 620 | colorbufferFormat != GL_RGBA4 && |
| 621 | colorbufferFormat != GL_RGB5_A1 && |
| 622 | colorbufferFormat != GL_BGRA8_EXT && |
| 623 | colorbufferFormat != GL_RGBA8_OES) |
| 624 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 625 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 626 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 627 | } |
| 628 | break; |
| 629 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 630 | if (colorbufferFormat != GL_R8_EXT && |
| 631 | colorbufferFormat != GL_RG8_EXT && |
| 632 | colorbufferFormat != GL_RGB565 && |
| 633 | colorbufferFormat != GL_RGB8_OES && |
| 634 | colorbufferFormat != GL_RGBA4 && |
| 635 | colorbufferFormat != GL_RGB5_A1 && |
| 636 | colorbufferFormat != GL_BGRA8_EXT && |
| 637 | colorbufferFormat != GL_RGBA8_OES) |
| 638 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 639 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 640 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 641 | } |
| 642 | break; |
| 643 | case GL_RED_EXT: |
| 644 | if (colorbufferFormat != GL_R8_EXT && |
| 645 | colorbufferFormat != GL_RG8_EXT && |
| 646 | colorbufferFormat != GL_RGB565 && |
| 647 | colorbufferFormat != GL_RGB8_OES && |
| 648 | colorbufferFormat != GL_RGBA4 && |
| 649 | colorbufferFormat != GL_RGB5_A1 && |
| 650 | colorbufferFormat != GL_BGRA8_EXT && |
| 651 | colorbufferFormat != GL_RGBA8_OES) |
| 652 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 653 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 654 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 655 | } |
| 656 | break; |
| 657 | case GL_RG_EXT: |
| 658 | if (colorbufferFormat != GL_RG8_EXT && |
| 659 | colorbufferFormat != GL_RGB565 && |
| 660 | colorbufferFormat != GL_RGB8_OES && |
| 661 | colorbufferFormat != GL_RGBA4 && |
| 662 | colorbufferFormat != GL_RGB5_A1 && |
| 663 | colorbufferFormat != GL_BGRA8_EXT && |
| 664 | colorbufferFormat != GL_RGBA8_OES) |
| 665 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 666 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 667 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 668 | } |
| 669 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 670 | case GL_RGB: |
| 671 | if (colorbufferFormat != GL_RGB565 && |
| 672 | colorbufferFormat != GL_RGB8_OES && |
| 673 | colorbufferFormat != GL_RGBA4 && |
| 674 | colorbufferFormat != GL_RGB5_A1 && |
| 675 | colorbufferFormat != GL_BGRA8_EXT && |
| 676 | colorbufferFormat != GL_RGBA8_OES) |
| 677 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 678 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 679 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 680 | } |
| 681 | break; |
| 682 | case GL_LUMINANCE_ALPHA: |
| 683 | case GL_RGBA: |
| 684 | if (colorbufferFormat != GL_RGBA4 && |
| 685 | colorbufferFormat != GL_RGB5_A1 && |
| 686 | colorbufferFormat != GL_BGRA8_EXT && |
| 687 | colorbufferFormat != GL_RGBA8_OES) |
| 688 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 689 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 690 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 691 | } |
| 692 | break; |
| 693 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 694 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 695 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 696 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 697 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 698 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 699 | } |
| 700 | else |
| 701 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 702 | context->recordError(Error(GL_INVALID_ENUM)); |
| 703 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 704 | } |
| 705 | break; |
| 706 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 707 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 708 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 709 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 710 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 711 | } |
| 712 | else |
| 713 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 714 | context->recordError(Error(GL_INVALID_ENUM)); |
| 715 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 716 | } |
| 717 | break; |
| 718 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 719 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 720 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 721 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 722 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 723 | } |
| 724 | else |
| 725 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 726 | context->recordError(Error(GL_INVALID_ENUM)); |
| 727 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 728 | } |
| 729 | break; |
| 730 | case GL_DEPTH_COMPONENT: |
| 731 | case GL_DEPTH_COMPONENT16: |
| 732 | case GL_DEPTH_COMPONENT32_OES: |
| 733 | case GL_DEPTH_STENCIL_OES: |
| 734 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 735 | if (context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 736 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 737 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 738 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 739 | } |
| 740 | else |
| 741 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 742 | context->recordError(Error(GL_INVALID_ENUM)); |
| 743 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 744 | } |
| 745 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 746 | context->recordError(Error(GL_INVALID_ENUM)); |
| 747 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 748 | } |
| 749 | } |
| 750 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 751 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 752 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 753 | } |
| 754 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 755 | bool ValidateES2TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 756 | GLsizei width, GLsizei height) |
| 757 | { |
| 758 | if (target != GL_TEXTURE_2D && target != GL_TEXTURE_CUBE_MAP) |
| 759 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 760 | context->recordError(Error(GL_INVALID_ENUM)); |
| 761 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 762 | } |
| 763 | |
| 764 | if (width < 1 || height < 1 || levels < 1) |
| 765 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 766 | context->recordError(Error(GL_INVALID_VALUE)); |
| 767 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 768 | } |
| 769 | |
| 770 | if (target == GL_TEXTURE_CUBE_MAP && width != height) |
| 771 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 772 | context->recordError(Error(GL_INVALID_VALUE)); |
| 773 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 774 | } |
| 775 | |
| 776 | if (levels != 1 && levels != gl::log2(std::max(width, height)) + 1) |
| 777 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 778 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 779 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 780 | } |
| 781 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 782 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 783 | if (formatInfo.format == GL_NONE || formatInfo.type == GL_NONE) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 784 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 785 | context->recordError(Error(GL_INVALID_ENUM)); |
| 786 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 787 | } |
| 788 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 789 | const gl::Caps &caps = context->getCaps(); |
| 790 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 791 | switch (target) |
| 792 | { |
| 793 | case GL_TEXTURE_2D: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 794 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 795 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 796 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 797 | context->recordError(Error(GL_INVALID_VALUE)); |
| 798 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 799 | } |
| 800 | break; |
| 801 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 802 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize || |
| 803 | static_cast<GLuint>(height) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 804 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 805 | context->recordError(Error(GL_INVALID_VALUE)); |
| 806 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 807 | } |
| 808 | break; |
| 809 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 810 | context->recordError(Error(GL_INVALID_ENUM)); |
| 811 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 812 | } |
| 813 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 814 | if (levels != 1 && !context->getExtensions().textureNPOT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 815 | { |
| 816 | if (!gl::isPow2(width) || !gl::isPow2(height)) |
| 817 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 818 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 819 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 820 | } |
| 821 | } |
| 822 | |
| 823 | switch (internalformat) |
| 824 | { |
| 825 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 826 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 827 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 828 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 829 | context->recordError(Error(GL_INVALID_ENUM)); |
| 830 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 831 | } |
| 832 | break; |
| 833 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 834 | if (!context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 835 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 836 | context->recordError(Error(GL_INVALID_ENUM)); |
| 837 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 838 | } |
| 839 | break; |
| 840 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 841 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 842 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 843 | context->recordError(Error(GL_INVALID_ENUM)); |
| 844 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 845 | } |
| 846 | break; |
| 847 | case GL_RGBA32F_EXT: |
| 848 | case GL_RGB32F_EXT: |
| 849 | case GL_ALPHA32F_EXT: |
| 850 | case GL_LUMINANCE32F_EXT: |
| 851 | case GL_LUMINANCE_ALPHA32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 852 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 853 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 854 | context->recordError(Error(GL_INVALID_ENUM)); |
| 855 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 856 | } |
| 857 | break; |
| 858 | case GL_RGBA16F_EXT: |
| 859 | case GL_RGB16F_EXT: |
| 860 | case GL_ALPHA16F_EXT: |
| 861 | case GL_LUMINANCE16F_EXT: |
| 862 | case GL_LUMINANCE_ALPHA16F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 863 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 864 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 865 | context->recordError(Error(GL_INVALID_ENUM)); |
| 866 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 867 | } |
| 868 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 869 | case GL_R8_EXT: |
| 870 | case GL_RG8_EXT: |
| 871 | case GL_R16F_EXT: |
| 872 | case GL_RG16F_EXT: |
| 873 | case GL_R32F_EXT: |
| 874 | case GL_RG32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 875 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 876 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 877 | context->recordError(Error(GL_INVALID_ENUM)); |
| 878 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 879 | } |
| 880 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 881 | case GL_DEPTH_COMPONENT16: |
| 882 | case GL_DEPTH_COMPONENT32_OES: |
| 883 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 884 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 885 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 886 | context->recordError(Error(GL_INVALID_ENUM)); |
| 887 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 888 | } |
| 889 | if (target != GL_TEXTURE_2D) |
| 890 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 891 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 892 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 893 | } |
| 894 | // ANGLE_depth_texture only supports 1-level textures |
| 895 | if (levels != 1) |
| 896 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 897 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 898 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 899 | } |
| 900 | break; |
| 901 | default: |
| 902 | break; |
| 903 | } |
| 904 | |
| 905 | gl::Texture *texture = NULL; |
| 906 | switch(target) |
| 907 | { |
| 908 | case GL_TEXTURE_2D: |
| 909 | texture = context->getTexture2D(); |
| 910 | break; |
| 911 | case GL_TEXTURE_CUBE_MAP: |
| 912 | texture = context->getTextureCubeMap(); |
| 913 | break; |
| 914 | default: |
| 915 | UNREACHABLE(); |
| 916 | } |
| 917 | |
| 918 | if (!texture || texture->id() == 0) |
| 919 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 920 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 921 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 922 | } |
| 923 | |
| 924 | if (texture->isImmutable()) |
| 925 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 926 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 927 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 928 | } |
| 929 | |
| 930 | return true; |
| 931 | } |
| 932 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 933 | // check for combinations of format and type that are valid for ReadPixels |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 934 | bool ValidES2ReadFormatType(Context *context, GLenum format, GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 935 | { |
| 936 | switch (format) |
| 937 | { |
| 938 | case GL_RGBA: |
| 939 | switch (type) |
| 940 | { |
| 941 | case GL_UNSIGNED_BYTE: |
| 942 | break; |
| 943 | default: |
| 944 | return false; |
| 945 | } |
| 946 | break; |
| 947 | case GL_BGRA_EXT: |
| 948 | switch (type) |
| 949 | { |
| 950 | case GL_UNSIGNED_BYTE: |
| 951 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 952 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 953 | break; |
| 954 | default: |
| 955 | return false; |
| 956 | } |
| 957 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 958 | case GL_RG_EXT: |
| 959 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 960 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 961 | { |
| 962 | return false; |
| 963 | } |
| 964 | switch (type) |
| 965 | { |
| 966 | case GL_UNSIGNED_BYTE: |
| 967 | break; |
| 968 | default: |
| 969 | return false; |
| 970 | } |
| 971 | break; |
| 972 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 973 | default: |
| 974 | return false; |
| 975 | } |
| 976 | return true; |
| 977 | } |
| 978 | |
| 979 | } |