blob: f932a34c1c4c49a03891b3543618d3a8e9daf15c [file] [log] [blame]
Jamie Madillfa05f602015-05-07 13:47:11 -04001//
2// Copyright 2015 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
Jamie Madill1fbc59f2016-02-24 15:25:51 -05006// Framebuffer tests:
7// Various tests related for Frambuffers.
8//
Jamie Madillfa05f602015-05-07 13:47:11 -04009
Brandon Jones9fc87332017-12-13 15:46:52 -080010#include "platform/WorkaroundsD3D.h"
Corentin Wallezd3970de2015-05-14 11:07:48 -040011#include "test_utils/ANGLETest.h"
JiangYizhou461d9a32017-01-04 16:37:26 +080012#include "test_utils/gl_raii.h"
Geoff Langb6a673a2014-06-05 14:19:16 -040013
Jamie Madillfa05f602015-05-07 13:47:11 -040014using namespace angle;
Austin Kinross18b931d2014-09-29 12:58:31 -070015
Geoff Lang857c09d2017-05-16 15:55:04 -040016namespace
17{
18
19void ExpectFramebufferCompleteOrUnsupported(GLenum binding)
20{
21 GLenum status = glCheckFramebufferStatus(binding);
22 EXPECT_TRUE(status == GL_FRAMEBUFFER_COMPLETE || status == GL_FRAMEBUFFER_UNSUPPORTED);
23}
24
25} // anonymous namespace
26
Geoff Langb6a673a2014-06-05 14:19:16 -040027class FramebufferFormatsTest : public ANGLETest
28{
Jamie Madillfa05f602015-05-07 13:47:11 -040029 protected:
Jamie Madill3215b202015-12-15 16:41:39 -050030 FramebufferFormatsTest() : mFramebuffer(0), mTexture(0), mRenderbuffer(0), mProgram(0)
Geoff Langb6a673a2014-06-05 14:19:16 -040031 {
32 setWindowWidth(128);
33 setWindowHeight(128);
34 setConfigRedBits(8);
35 setConfigGreenBits(8);
36 setConfigBlueBits(8);
37 setConfigAlphaBits(8);
38 }
39
40 void checkBitCount(GLuint fbo, GLenum channel, GLint minBits)
41 {
42 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
43
44 GLint bits = 0;
45 glGetIntegerv(channel, &bits);
46
47 if (minBits == 0)
48 {
49 EXPECT_EQ(minBits, bits);
50 }
51 else
52 {
53 EXPECT_GE(bits, minBits);
54 }
55 }
56
Jamie Madill1fbc59f2016-02-24 15:25:51 -050057 void testBitCounts(GLuint fbo,
58 GLint minRedBits,
59 GLint minGreenBits,
60 GLint minBlueBits,
61 GLint minAlphaBits,
62 GLint minDepthBits,
63 GLint minStencilBits)
Geoff Langb6a673a2014-06-05 14:19:16 -040064 {
65 checkBitCount(fbo, GL_RED_BITS, minRedBits);
66 checkBitCount(fbo, GL_GREEN_BITS, minGreenBits);
67 checkBitCount(fbo, GL_BLUE_BITS, minBlueBits);
68 checkBitCount(fbo, GL_ALPHA_BITS, minAlphaBits);
69 checkBitCount(fbo, GL_DEPTH_BITS, minDepthBits);
70 checkBitCount(fbo, GL_STENCIL_BITS, minStencilBits);
71 }
72
Jamie Madill1fbc59f2016-02-24 15:25:51 -050073 void testTextureFormat(GLenum internalFormat,
74 GLint minRedBits,
75 GLint minGreenBits,
76 GLint minBlueBits,
Geoff Langb6a673a2014-06-05 14:19:16 -040077 GLint minAlphaBits)
78 {
Jamie Madill3215b202015-12-15 16:41:39 -050079 glGenTextures(1, &mTexture);
80 glBindTexture(GL_TEXTURE_2D, mTexture);
Geoff Langc4e93662017-05-01 10:45:59 -040081
82 if (getClientMajorVersion() >= 3)
83 {
84 glTexStorage2D(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
85 }
86 else
87 {
88 glTexStorage2DEXT(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
89 }
Geoff Langb6a673a2014-06-05 14:19:16 -040090
Jamie Madill3215b202015-12-15 16:41:39 -050091 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, mTexture, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040092
Jamie Madill3215b202015-12-15 16:41:39 -050093 testBitCounts(mFramebuffer, minRedBits, minGreenBits, minBlueBits, minAlphaBits, 0, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040094 }
95
Jamie Madill1fbc59f2016-02-24 15:25:51 -050096 void testRenderbufferMultisampleFormat(int minESVersion,
97 GLenum attachmentType,
98 GLenum internalFormat)
Corentin Walleze0902642014-11-04 12:32:15 -080099 {
Martin Radev1be913c2016-07-11 17:59:16 +0300100 int clientVersion = getClientMajorVersion();
Jamie Madillfa05f602015-05-07 13:47:11 -0400101 if (clientVersion < minESVersion)
Corentin Walleze0902642014-11-04 12:32:15 -0800102 {
103 return;
104 }
105
106 // Check that multisample is supported with at least two samples (minimum required is 1)
107 bool supports2Samples = false;
108
Jamie Madillfa05f602015-05-07 13:47:11 -0400109 if (clientVersion == 2)
Corentin Walleze0902642014-11-04 12:32:15 -0800110 {
111 if (extensionEnabled("ANGLE_framebuffer_multisample"))
112 {
113 int maxSamples;
114 glGetIntegerv(GL_MAX_SAMPLES_ANGLE, &maxSamples);
115 supports2Samples = maxSamples >= 2;
116 }
117 }
118 else
119 {
Jamie Madillfa05f602015-05-07 13:47:11 -0400120 assert(clientVersion >= 3);
Corentin Walleze0902642014-11-04 12:32:15 -0800121 int maxSamples;
122 glGetIntegerv(GL_MAX_SAMPLES, &maxSamples);
123 supports2Samples = maxSamples >= 2;
124 }
125
126 if (!supports2Samples)
127 {
128 return;
129 }
130
Jamie Madill3215b202015-12-15 16:41:39 -0500131 glGenRenderbuffers(1, &mRenderbuffer);
132 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800133
134 EXPECT_GL_NO_ERROR();
135 glRenderbufferStorageMultisampleANGLE(GL_RENDERBUFFER, 2, internalFormat, 128, 128);
136 EXPECT_GL_NO_ERROR();
Jamie Madill3215b202015-12-15 16:41:39 -0500137 glFramebufferRenderbuffer(GL_FRAMEBUFFER, attachmentType, GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800138 EXPECT_GL_NO_ERROR();
Corentin Walleze0902642014-11-04 12:32:15 -0800139 }
140
Olli Etuahobc21e182016-02-23 16:04:57 +0200141 void testZeroHeightRenderbuffer()
142 {
143 glGenRenderbuffers(1, &mRenderbuffer);
144 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
145 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 0);
146 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
147 mRenderbuffer);
148 EXPECT_GL_NO_ERROR();
149 }
150
Jamie Madill3215b202015-12-15 16:41:39 -0500151 void SetUp() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400152 {
153 ANGLETest::SetUp();
Jamie Madill3215b202015-12-15 16:41:39 -0500154
155 glGenFramebuffers(1, &mFramebuffer);
156 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
Geoff Langb6a673a2014-06-05 14:19:16 -0400157 }
158
Jamie Madill3215b202015-12-15 16:41:39 -0500159 void TearDown() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400160 {
161 ANGLETest::TearDown();
Jamie Madill3215b202015-12-15 16:41:39 -0500162
163 if (mTexture != 0)
164 {
165 glDeleteTextures(1, &mTexture);
166 mTexture = 0;
167 }
168
169 if (mRenderbuffer != 0)
170 {
171 glDeleteRenderbuffers(1, &mRenderbuffer);
172 mRenderbuffer = 0;
173 }
174
175 if (mFramebuffer != 0)
176 {
177 glDeleteFramebuffers(1, &mFramebuffer);
178 mFramebuffer = 0;
179 }
180
181 if (mProgram != 0)
182 {
183 glDeleteProgram(mProgram);
184 mProgram = 0;
185 }
Geoff Langb6a673a2014-06-05 14:19:16 -0400186 }
Jamie Madill3215b202015-12-15 16:41:39 -0500187
188 GLuint mFramebuffer;
189 GLuint mTexture;
190 GLuint mRenderbuffer;
191 GLuint mProgram;
Geoff Langb6a673a2014-06-05 14:19:16 -0400192};
193
Jamie Madillfa05f602015-05-07 13:47:11 -0400194TEST_P(FramebufferFormatsTest, RGBA4)
Geoff Langb6a673a2014-06-05 14:19:16 -0400195{
Yunchao He9550c602018-02-13 14:47:05 +0800196 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400197
Geoff Langb6a673a2014-06-05 14:19:16 -0400198 testTextureFormat(GL_RGBA4, 4, 4, 4, 4);
199}
200
Jamie Madillfa05f602015-05-07 13:47:11 -0400201TEST_P(FramebufferFormatsTest, RGB565)
Geoff Langb6a673a2014-06-05 14:19:16 -0400202{
Yunchao He9550c602018-02-13 14:47:05 +0800203 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400204
Geoff Langb6a673a2014-06-05 14:19:16 -0400205 testTextureFormat(GL_RGB565, 5, 6, 5, 0);
206}
207
Jamie Madillfa05f602015-05-07 13:47:11 -0400208TEST_P(FramebufferFormatsTest, RGB8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400209{
Yunchao He9550c602018-02-13 14:47:05 +0800210 ANGLE_SKIP_TEST_IF(
211 getClientMajorVersion() < 3 &&
212 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400213
Geoff Langb6a673a2014-06-05 14:19:16 -0400214 testTextureFormat(GL_RGB8_OES, 8, 8, 8, 0);
215}
216
Jamie Madillfa05f602015-05-07 13:47:11 -0400217TEST_P(FramebufferFormatsTest, BGRA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400218{
Yunchao He9550c602018-02-13 14:47:05 +0800219 ANGLE_SKIP_TEST_IF(
220 !extensionEnabled("GL_EXT_texture_format_BGRA8888") ||
221 (getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400222
Geoff Langb6a673a2014-06-05 14:19:16 -0400223 testTextureFormat(GL_BGRA8_EXT, 8, 8, 8, 8);
224}
225
Jamie Madillfa05f602015-05-07 13:47:11 -0400226TEST_P(FramebufferFormatsTest, RGBA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400227{
Yunchao He9550c602018-02-13 14:47:05 +0800228 ANGLE_SKIP_TEST_IF(
229 getClientMajorVersion() < 3 &&
230 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400231
Geoff Langb6a673a2014-06-05 14:19:16 -0400232 testTextureFormat(GL_RGBA8_OES, 8, 8, 8, 8);
233}
234
Jamie Madillfa05f602015-05-07 13:47:11 -0400235TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH16)
Corentin Walleze0902642014-11-04 12:32:15 -0800236{
237 testRenderbufferMultisampleFormat(2, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT16);
238}
239
Jamie Madillfa05f602015-05-07 13:47:11 -0400240TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24)
Corentin Walleze0902642014-11-04 12:32:15 -0800241{
242 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT24);
243}
244
Jamie Madillfa05f602015-05-07 13:47:11 -0400245TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F)
Corentin Walleze0902642014-11-04 12:32:15 -0800246{
Yunchao He9550c602018-02-13 14:47:05 +0800247 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400248
Corentin Walleze0902642014-11-04 12:32:15 -0800249 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT32F);
250}
251
Jamie Madillfa05f602015-05-07 13:47:11 -0400252TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800253{
254 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH24_STENCIL8);
255}
256
Jamie Madillfa05f602015-05-07 13:47:11 -0400257TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800258{
Yunchao He9550c602018-02-13 14:47:05 +0800259 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400260
Corentin Walleze0902642014-11-04 12:32:15 -0800261 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH32F_STENCIL8);
262}
263
Jamie Madillfa05f602015-05-07 13:47:11 -0400264TEST_P(FramebufferFormatsTest, RenderbufferMultisample_STENCIL_INDEX8)
Corentin Walleze0902642014-11-04 12:32:15 -0800265{
Geoff Langf34d1db2015-05-20 14:10:46 -0400266 // TODO(geofflang): Figure out how to support GLSTENCIL_INDEX8 on desktop GL
Yunchao He9550c602018-02-13 14:47:05 +0800267 ANGLE_SKIP_TEST_IF(IsDesktopOpenGL());
Geoff Langf34d1db2015-05-20 14:10:46 -0400268
Corentin Walleze0902642014-11-04 12:32:15 -0800269 testRenderbufferMultisampleFormat(2, GL_STENCIL_ATTACHMENT, GL_STENCIL_INDEX8);
270}
Jamie Madillfa05f602015-05-07 13:47:11 -0400271
Jamie Madill3215b202015-12-15 16:41:39 -0500272// Test that binding an incomplete cube map is rejected by ANGLE.
273TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
274{
275 // First make a complete CubeMap.
276 glGenTextures(1, &mTexture);
277 glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);
278 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
279 nullptr);
280 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
281 nullptr);
282 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
283 nullptr);
284 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
285 nullptr);
286 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
287 nullptr);
288 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
289 nullptr);
290 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
291 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
292
293 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
294 mTexture, 0);
295
296 // Verify the framebuffer is complete.
297 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
298
299 // Make the CubeMap cube-incomplete.
300 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 16, 16, 0, GL_RGBA, GL_UNSIGNED_BYTE,
301 nullptr);
302
303 // Verify the framebuffer is incomplete.
304 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
305 glCheckFramebufferStatus(GL_FRAMEBUFFER));
306
307 // Verify drawing with the incomplete framebuffer produces a GL error
308 const std::string &vs = "attribute vec4 position; void main() { gl_Position = position; }";
309 const std::string &ps = "void main() { gl_FragColor = vec4(1, 0, 0, 1); }";
310 mProgram = CompileProgram(vs, ps);
311 ASSERT_NE(0u, mProgram);
312 drawQuad(mProgram, "position", 0.5f);
313 ASSERT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
314}
315
Olli Etuahobc21e182016-02-23 16:04:57 +0200316// Test that a renderbuffer with zero height but nonzero width is handled without crashes/asserts.
317TEST_P(FramebufferFormatsTest, ZeroHeightRenderbuffer)
318{
Yunchao He9550c602018-02-13 14:47:05 +0800319 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Olli Etuahobc21e182016-02-23 16:04:57 +0200320
321 testZeroHeightRenderbuffer();
322}
323
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500324// Use this to select which configurations (e.g. which renderer, which GLES major version) these
325// tests should be run against.
Geoff Lange0cc2a42016-01-20 10:58:17 -0500326ANGLE_INSTANTIATE_TEST(FramebufferFormatsTest,
327 ES2_D3D9(),
328 ES2_D3D11(),
329 ES3_D3D11(),
330 ES2_OPENGL(),
331 ES3_OPENGL(),
332 ES2_OPENGLES(),
333 ES3_OPENGLES());
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500334
Corentin Wallez57e6d502016-12-09 14:46:39 -0500335class FramebufferTest_ES3 : public ANGLETest
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500336{
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500337};
338
339// Covers invalidating an incomplete framebuffer. This should be a no-op, but should not error.
Corentin Wallez57e6d502016-12-09 14:46:39 -0500340TEST_P(FramebufferTest_ES3, InvalidateIncomplete)
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500341{
Geoff Lang857c09d2017-05-16 15:55:04 -0400342 GLFramebuffer framebuffer;
343 GLRenderbuffer renderbuffer;
344
345 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
346 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
347 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, renderbuffer);
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500348 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
349 glCheckFramebufferStatus(GL_FRAMEBUFFER));
350
351 std::vector<GLenum> attachments;
352 attachments.push_back(GL_COLOR_ATTACHMENT0);
353
354 glInvalidateFramebuffer(GL_FRAMEBUFFER, 1, attachments.data());
355 EXPECT_GL_NO_ERROR();
356}
357
Corentin Wallez57e6d502016-12-09 14:46:39 -0500358// Test that the framebuffer state tracking robustly handles a depth-only attachment being set
359// as a depth-stencil attachment. It is equivalent to detaching the depth-stencil attachment.
360TEST_P(FramebufferTest_ES3, DepthOnlyAsDepthStencil)
361{
Geoff Lang857c09d2017-05-16 15:55:04 -0400362 GLFramebuffer framebuffer;
363 GLRenderbuffer renderbuffer;
364
365 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
366 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500367 glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, 4, 4);
368
369 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_RENDERBUFFER,
Geoff Lang857c09d2017-05-16 15:55:04 -0400370 renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500371 EXPECT_GLENUM_NE(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
372}
373
Geoff Lang857c09d2017-05-16 15:55:04 -0400374// Test that the framebuffer correctly returns that it is not complete if invalid texture mip levels
375// are bound
376TEST_P(FramebufferTest_ES3, TextureAttachmentMipLevels)
377{
378 GLFramebuffer framebuffer;
379 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
380
381 GLTexture texture;
382 glBindTexture(GL_TEXTURE_2D, texture);
383
384 // Create a complete mip chain in mips 1 to 3
385 glTexImage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
386 glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
387 glTexImage2D(GL_TEXTURE_2D, 3, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
388
389 // Create another complete mip chain in mips 4 to 5
390 glTexImage2D(GL_TEXTURE_2D, 4, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
391 glTexImage2D(GL_TEXTURE_2D, 5, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
392
393 // Create a non-complete mip chain in mip 6
394 glTexImage2D(GL_TEXTURE_2D, 6, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
395
396 // Incomplete, mipLevel != baseLevel and texture is not mip complete
397 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
398 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
399 glCheckFramebufferStatus(GL_FRAMEBUFFER));
400
401 // Complete, mipLevel == baseLevel
402 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 1);
403 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
404
405 // Complete, mipLevel != baseLevel but texture is now mip complete
406 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 2);
407 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
408 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 3);
409 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
410
411 // Incomplete, attached level below the base level
412 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 2);
413 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
414 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
415 glCheckFramebufferStatus(GL_FRAMEBUFFER));
416
417 // Incomplete, attached level is beyond effective max level
418 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 4);
419 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
420 glCheckFramebufferStatus(GL_FRAMEBUFFER));
421
422 // Complete, mipLevel == baseLevel
423 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 4);
424 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
425
426 // Complete, mipLevel != baseLevel but texture is now mip complete
427 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 5);
428 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
429
430 // Complete, mipLevel == baseLevel
431 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 6);
432 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 6);
433 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
434}
435
Martin Radevd178aa42017-07-13 14:03:22 +0300436// Test that passing an attachment COLOR_ATTACHMENTm where m is equal to MAX_COLOR_ATTACHMENTS
437// generates an INVALID_OPERATION.
438// OpenGL ES Version 3.0.5 (November 3, 2016), 4.4.2.4 Attaching Texture Images to a Framebuffer, p.
439// 208
440TEST_P(FramebufferTest_ES3, ColorAttachmentIndexOutOfBounds)
441{
442 GLFramebuffer framebuffer;
443 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
444
445 GLint maxColorAttachments = 0;
446 glGetIntegerv(GL_MAX_COLOR_ATTACHMENTS, &maxColorAttachments);
447 GLenum attachment = static_cast<GLenum>(maxColorAttachments + GL_COLOR_ATTACHMENT0);
448
449 GLTexture texture;
450 glBindTexture(GL_TEXTURE_2D, texture.get());
451 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA32F, 1, 1);
452 glFramebufferTexture2D(GL_FRAMEBUFFER, attachment, GL_TEXTURE_2D, texture.get(), 0);
453 EXPECT_GL_ERROR(GL_INVALID_OPERATION);
454}
455
Jamie Madilla0016b72017-07-14 14:30:46 -0400456// Check that depth-only attachments report the correct number of samples.
457TEST_P(FramebufferTest_ES3, MultisampleDepthOnly)
458{
459 GLRenderbuffer renderbuffer;
460 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
461 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_DEPTH_COMPONENT24, 32, 32);
462
463 GLFramebuffer framebuffer;
464 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
465 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, renderbuffer);
466 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
467 EXPECT_GL_NO_ERROR();
468
469 GLint samples = 0;
470 glGetIntegerv(GL_SAMPLES, &samples);
471 EXPECT_GL_NO_ERROR();
472 EXPECT_GE(samples, 2);
473}
474
Jeff Gilbert8f8edd62017-10-31 14:26:30 -0700475// Check that we only compare width and height of attachments, not depth.
476TEST_P(FramebufferTest_ES3, AttachmentWith3DLayers)
477{
478 GLTexture texA;
479 glBindTexture(GL_TEXTURE_2D, texA);
480 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
481
482 GLTexture texB;
483 glBindTexture(GL_TEXTURE_3D, texB);
484 glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, 4, 4, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
485
486 GLFramebuffer framebuffer;
487 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
488 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texA, 0);
489 glFramebufferTextureLayer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, texB, 0, 0);
490 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
491 EXPECT_GL_NO_ERROR();
492}
493
Corentin Wallez57e6d502016-12-09 14:46:39 -0500494ANGLE_INSTANTIATE_TEST(FramebufferTest_ES3, ES3_D3D11(), ES3_OPENGL(), ES3_OPENGLES());
JiangYizhou461d9a32017-01-04 16:37:26 +0800495
496class FramebufferTest_ES31 : public ANGLETest
497{
JiangYizhou511937d2017-08-03 15:41:29 +0800498 protected:
499 void validateSamplePass(GLuint &query, GLuint &passedCount, GLint width, GLint height)
500 {
501 glUniform2i(0, width - 1, height - 1);
502 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
503 glDrawArrays(GL_TRIANGLES, 0, 6);
504 glEndQuery(GL_ANY_SAMPLES_PASSED);
505 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
506 EXPECT_GT(static_cast<GLint>(passedCount), 0);
507
508 glUniform2i(0, width - 1, height);
509 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
510 glDrawArrays(GL_TRIANGLES, 0, 6);
511 glEndQuery(GL_ANY_SAMPLES_PASSED);
512 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
513 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
514
515 glUniform2i(0, width, height - 1);
516 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
517 glDrawArrays(GL_TRIANGLES, 0, 6);
518 glEndQuery(GL_ANY_SAMPLES_PASSED);
519 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
520 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
521 }
JiangYizhou461d9a32017-01-04 16:37:26 +0800522};
523
524// Test that without attachment, if either the value of FRAMEBUFFER_DEFAULT_WIDTH or
525// FRAMEBUFFER_DEFAULT_HEIGHT parameters is zero, the framebuffer is incomplete.
526TEST_P(FramebufferTest_ES31, IncompleteMissingAttachmentDefaultParam)
527{
528 GLFramebuffer mFramebuffer;
529 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
530
531 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
532 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
533 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
534
535 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
536 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
537 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
538 glCheckFramebufferStatus(GL_FRAMEBUFFER));
539
540 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
541 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
542 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
543 glCheckFramebufferStatus(GL_FRAMEBUFFER));
544
545 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
546 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
547 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
548 glCheckFramebufferStatus(GL_FRAMEBUFFER));
549
550 ASSERT_GL_NO_ERROR();
551}
552
553// Test that the sample count of a mix of texture and renderbuffer should be same.
554TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountMix)
555{
556 GLFramebuffer mFramebuffer;
557 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
558
559 GLTexture mTexture;
560 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
561 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
562
563 GLRenderbuffer mRenderbuffer;
564 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
565 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_RGBA8, 1, 1);
566 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
567 mTexture.get(), 0);
568 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
569 mRenderbuffer.get());
570 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
571 glCheckFramebufferStatus(GL_FRAMEBUFFER));
572
573 ASSERT_GL_NO_ERROR();
574}
575
576// Test that the sample count of texture attachments should be same.
577TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountTex)
578{
579 GLFramebuffer mFramebuffer;
580 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
581
582 GLTexture mTextures[2];
583 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
584 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
585 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
586 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 2, GL_RGBA8, 1, 1, true);
587 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
588 mTextures[0].get(), 0);
589 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
590 mTextures[1].get(), 0);
591 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
592 glCheckFramebufferStatus(GL_FRAMEBUFFER));
593
594 ASSERT_GL_NO_ERROR();
595}
596
597// Test that if the attached images are a mix of renderbuffers and textures, the value of
598// TEXTURE_FIXED_SAMPLE_LOCATIONS must be TRUE for all attached textures.
599TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsMix)
600{
601 GLFramebuffer mFramebuffer;
602 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
603
604 GLTexture mTexture;
605 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
606 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
607
608 GLRenderbuffer mRenderbuffer;
609 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
610 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 1, GL_RGBA8, 1, 1);
611 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
612 mTexture.get(), 0);
613 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
614 mRenderbuffer.get());
615 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
616 glCheckFramebufferStatus(GL_FRAMEBUFFER));
617
618 ASSERT_GL_NO_ERROR();
619}
620
621// Test that the value of TEXTURE_FIXED_SAMPLE_LOCATIONS is the same for all attached textures.
622TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsTex)
623{
624 GLFramebuffer mFramebuffer;
625 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
626
627 GLTexture mTextures[2];
628 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
629 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
630 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
631 mTextures[0].get(), 0);
632 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
633 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGB8, 1, 1, true);
634 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
635 mTextures[1].get(), 0);
636 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
637 glCheckFramebufferStatus(GL_FRAMEBUFFER));
638
639 ASSERT_GL_NO_ERROR();
640}
641
JiangYizhou511937d2017-08-03 15:41:29 +0800642// If there are no attachments, rendering will be limited to a rectangle having a lower left of
643// (0, 0) and an upper right of(width, height), where width and height are the framebuffer
644// object's default width and height.
JiangYizhou3db40722017-08-28 17:59:13 +0800645TEST_P(FramebufferTest_ES31, RenderingLimitToDefaultFBOSizeWithNoAttachments)
JiangYizhou511937d2017-08-03 15:41:29 +0800646{
Yuly Novikov98f9f532017-11-15 19:16:19 -0500647 // anglebug.com/2253
648 ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
649
JiangYizhou10d41392017-12-18 18:13:36 +0800650 const std::string &vertexShader1 =
651 R"(#version 310 es
652 in layout(location = 0) highp vec2 a_position;
653 void main()
654 {
655 gl_Position = vec4(a_position, 0.0, 1.0);
656 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800657
JiangYizhou10d41392017-12-18 18:13:36 +0800658 const std::string &fragShader1 =
659 R"(#version 310 es
660 uniform layout(location = 0) highp ivec2 u_expectedSize;
661 out layout(location = 5) mediump vec4 f_color;
662 void main()
663 {
664 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
665 f_color = vec4(1.0, 0.5, 0.25, 1.0);
666 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800667
JiangYizhou10d41392017-12-18 18:13:36 +0800668 const std::string &vertexShader2 =
669 R"(#version 310 es
670 in layout(location = 0) highp vec2 a_position;
671 void main()
672 {
673 gl_Position = vec4(a_position, 0.0, 1.0);
674 })";
675
676 const std::string &fragShader2 =
677 R"(#version 310 es
678 uniform layout(location = 0) highp ivec2 u_expectedSize;
679 out layout(location = 2) mediump vec4 f_color;
680 void main()
681 {
682 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
683 f_color = vec4(1.0, 0.5, 0.25, 1.0);
684 })";
685
686 GLuint program1 = CompileProgram(vertexShader1, fragShader1);
687 ASSERT_NE(program1, 0u);
688
689 GLuint program2 = CompileProgram(vertexShader2, fragShader2);
690 ASSERT_NE(program2, 0u);
691
692 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800693
694 GLFramebuffer mFramebuffer;
695 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, mFramebuffer);
696 GLuint defaultWidth = 1;
697 GLuint defaultHeight = 1;
698
699 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, defaultWidth);
700 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, defaultHeight);
701 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
702
703 const float data[] = {
704 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f,
705 };
706
707 GLuint vertexArray = 0;
708 GLuint vertexBuffer = 0;
709 GLuint query = 0;
710 GLuint passedCount = 0;
711
712 glGenQueries(1, &query);
713 glGenVertexArrays(1, &vertexArray);
714 glBindVertexArray(vertexArray);
715
716 glGenBuffers(1, &vertexBuffer);
717 glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
718 glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);
719
720 glEnableVertexAttribArray(0);
721 glVertexAttribPointer(0, 2, GL_FLOAT, false, 0, 0);
JiangYizhou38d92b52017-09-13 13:47:52 +0800722 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou511937d2017-08-03 15:41:29 +0800723
724 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
725
JiangYizhou10d41392017-12-18 18:13:36 +0800726 glUseProgram(program2);
727 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
728
729 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800730 // If fbo has attachments, the rendering size should be the same as its attachment.
731 GLTexture mTexture;
732 GLuint width = 2;
733 GLuint height = 2;
734 glBindTexture(GL_TEXTURE_2D, mTexture.get());
735 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, width, height);
JiangYizhou38d92b52017-09-13 13:47:52 +0800736
737 const GLenum bufs[] = {GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_COLOR_ATTACHMENT5};
738
739 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, GL_TEXTURE_2D, mTexture.get(),
JiangYizhou511937d2017-08-03 15:41:29 +0800740 0);
741 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou38d92b52017-09-13 13:47:52 +0800742 glDrawBuffers(6, bufs);
JiangYizhou511937d2017-08-03 15:41:29 +0800743
744 validateSamplePass(query, passedCount, width, height);
745
746 // If fbo's attachment has been removed, the rendering size should be the same as framebuffer
747 // default size.
JiangYizhou38d92b52017-09-13 13:47:52 +0800748 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, 0, 0, 0);
JiangYizhou511937d2017-08-03 15:41:29 +0800749 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
750
751 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
752
753 glDisableVertexAttribArray(0);
754 glBindBuffer(GL_ARRAY_BUFFER, 0);
755 glBindVertexArray(0);
756 glDeleteBuffers(1, &vertexBuffer);
757 glDeleteVertexArrays(1, &vertexArray);
758
759 ASSERT_GL_NO_ERROR();
760}
761
762ANGLE_INSTANTIATE_TEST(FramebufferTest_ES31, ES31_D3D11(), ES31_OPENGL(), ES31_OPENGLES());
Brandon Jones9fc87332017-12-13 15:46:52 -0800763
764class AddDummyTextureNoRenderTargetTest : public ANGLETest
765{
766 public:
767 AddDummyTextureNoRenderTargetTest()
768 {
769 setWindowWidth(512);
770 setWindowHeight(512);
771 setConfigRedBits(8);
772 setConfigGreenBits(8);
773 setConfigBlueBits(8);
774 setConfigAlphaBits(8);
775 }
776
777 void overrideWorkaroundsD3D(WorkaroundsD3D *workarounds) override
778 {
779 workarounds->addDummyTextureNoRenderTarget = true;
780 }
781};
782
783// Test to verify workaround succeeds when no program outputs exist http://anglebug.com/2283
784TEST_P(AddDummyTextureNoRenderTargetTest, NoProgramOutputWorkaround)
785{
786 const std::string &vShader = "void main() {}";
787 const std::string &fShader = "void main() {}";
788
789 ANGLE_GL_PROGRAM(drawProgram, vShader, fShader);
790
791 glUseProgram(drawProgram);
792
793 glDrawArrays(GL_TRIANGLES, 0, 6);
794
795 ASSERT_GL_NO_ERROR();
796}
797
798ANGLE_INSTANTIATE_TEST(AddDummyTextureNoRenderTargetTest, ES2_D3D11());