blob: 5eedecfc9b5e9fe2a6c89c43f24be5f93c4b4d89 [file] [log] [blame]
Jamie Madillfa05f602015-05-07 13:47:11 -04001//
2// Copyright 2015 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
Jamie Madill1fbc59f2016-02-24 15:25:51 -05006// Framebuffer tests:
7// Various tests related for Frambuffers.
8//
Jamie Madillfa05f602015-05-07 13:47:11 -04009
Brandon Jones9fc87332017-12-13 15:46:52 -080010#include "platform/WorkaroundsD3D.h"
Corentin Wallezd3970de2015-05-14 11:07:48 -040011#include "test_utils/ANGLETest.h"
JiangYizhou461d9a32017-01-04 16:37:26 +080012#include "test_utils/gl_raii.h"
Geoff Langb6a673a2014-06-05 14:19:16 -040013
Jamie Madillfa05f602015-05-07 13:47:11 -040014using namespace angle;
Austin Kinross18b931d2014-09-29 12:58:31 -070015
Geoff Lang857c09d2017-05-16 15:55:04 -040016namespace
17{
18
19void ExpectFramebufferCompleteOrUnsupported(GLenum binding)
20{
21 GLenum status = glCheckFramebufferStatus(binding);
22 EXPECT_TRUE(status == GL_FRAMEBUFFER_COMPLETE || status == GL_FRAMEBUFFER_UNSUPPORTED);
23}
24
25} // anonymous namespace
26
Geoff Langb6a673a2014-06-05 14:19:16 -040027class FramebufferFormatsTest : public ANGLETest
28{
Jamie Madillfa05f602015-05-07 13:47:11 -040029 protected:
Jamie Madill3215b202015-12-15 16:41:39 -050030 FramebufferFormatsTest() : mFramebuffer(0), mTexture(0), mRenderbuffer(0), mProgram(0)
Geoff Langb6a673a2014-06-05 14:19:16 -040031 {
32 setWindowWidth(128);
33 setWindowHeight(128);
34 setConfigRedBits(8);
35 setConfigGreenBits(8);
36 setConfigBlueBits(8);
37 setConfigAlphaBits(8);
38 }
39
40 void checkBitCount(GLuint fbo, GLenum channel, GLint minBits)
41 {
42 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
43
44 GLint bits = 0;
45 glGetIntegerv(channel, &bits);
46
47 if (minBits == 0)
48 {
49 EXPECT_EQ(minBits, bits);
50 }
51 else
52 {
53 EXPECT_GE(bits, minBits);
54 }
55 }
56
Jamie Madill1fbc59f2016-02-24 15:25:51 -050057 void testBitCounts(GLuint fbo,
58 GLint minRedBits,
59 GLint minGreenBits,
60 GLint minBlueBits,
61 GLint minAlphaBits,
62 GLint minDepthBits,
63 GLint minStencilBits)
Geoff Langb6a673a2014-06-05 14:19:16 -040064 {
65 checkBitCount(fbo, GL_RED_BITS, minRedBits);
66 checkBitCount(fbo, GL_GREEN_BITS, minGreenBits);
67 checkBitCount(fbo, GL_BLUE_BITS, minBlueBits);
68 checkBitCount(fbo, GL_ALPHA_BITS, minAlphaBits);
69 checkBitCount(fbo, GL_DEPTH_BITS, minDepthBits);
70 checkBitCount(fbo, GL_STENCIL_BITS, minStencilBits);
71 }
72
Jamie Madill1fbc59f2016-02-24 15:25:51 -050073 void testTextureFormat(GLenum internalFormat,
74 GLint minRedBits,
75 GLint minGreenBits,
76 GLint minBlueBits,
Geoff Langb6a673a2014-06-05 14:19:16 -040077 GLint minAlphaBits)
78 {
Jamie Madill3215b202015-12-15 16:41:39 -050079 glGenTextures(1, &mTexture);
80 glBindTexture(GL_TEXTURE_2D, mTexture);
Geoff Langc4e93662017-05-01 10:45:59 -040081
82 if (getClientMajorVersion() >= 3)
83 {
84 glTexStorage2D(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
85 }
86 else
87 {
88 glTexStorage2DEXT(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
89 }
Geoff Langb6a673a2014-06-05 14:19:16 -040090
Jamie Madill3215b202015-12-15 16:41:39 -050091 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, mTexture, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040092
Jamie Madill3215b202015-12-15 16:41:39 -050093 testBitCounts(mFramebuffer, minRedBits, minGreenBits, minBlueBits, minAlphaBits, 0, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040094 }
95
Jamie Madill1fbc59f2016-02-24 15:25:51 -050096 void testRenderbufferMultisampleFormat(int minESVersion,
97 GLenum attachmentType,
98 GLenum internalFormat)
Corentin Walleze0902642014-11-04 12:32:15 -080099 {
Martin Radev1be913c2016-07-11 17:59:16 +0300100 int clientVersion = getClientMajorVersion();
Jamie Madillfa05f602015-05-07 13:47:11 -0400101 if (clientVersion < minESVersion)
Corentin Walleze0902642014-11-04 12:32:15 -0800102 {
103 return;
104 }
105
106 // Check that multisample is supported with at least two samples (minimum required is 1)
107 bool supports2Samples = false;
108
Jamie Madillfa05f602015-05-07 13:47:11 -0400109 if (clientVersion == 2)
Corentin Walleze0902642014-11-04 12:32:15 -0800110 {
111 if (extensionEnabled("ANGLE_framebuffer_multisample"))
112 {
113 int maxSamples;
114 glGetIntegerv(GL_MAX_SAMPLES_ANGLE, &maxSamples);
115 supports2Samples = maxSamples >= 2;
116 }
117 }
118 else
119 {
Jamie Madillfa05f602015-05-07 13:47:11 -0400120 assert(clientVersion >= 3);
Corentin Walleze0902642014-11-04 12:32:15 -0800121 int maxSamples;
122 glGetIntegerv(GL_MAX_SAMPLES, &maxSamples);
123 supports2Samples = maxSamples >= 2;
124 }
125
126 if (!supports2Samples)
127 {
128 return;
129 }
130
Jamie Madill3215b202015-12-15 16:41:39 -0500131 glGenRenderbuffers(1, &mRenderbuffer);
132 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800133
134 EXPECT_GL_NO_ERROR();
135 glRenderbufferStorageMultisampleANGLE(GL_RENDERBUFFER, 2, internalFormat, 128, 128);
136 EXPECT_GL_NO_ERROR();
Jamie Madill3215b202015-12-15 16:41:39 -0500137 glFramebufferRenderbuffer(GL_FRAMEBUFFER, attachmentType, GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800138 EXPECT_GL_NO_ERROR();
Corentin Walleze0902642014-11-04 12:32:15 -0800139 }
140
Olli Etuahobc21e182016-02-23 16:04:57 +0200141 void testZeroHeightRenderbuffer()
142 {
143 glGenRenderbuffers(1, &mRenderbuffer);
144 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
145 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 0);
146 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
147 mRenderbuffer);
148 EXPECT_GL_NO_ERROR();
149 }
150
Jamie Madill3215b202015-12-15 16:41:39 -0500151 void SetUp() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400152 {
153 ANGLETest::SetUp();
Jamie Madill3215b202015-12-15 16:41:39 -0500154
155 glGenFramebuffers(1, &mFramebuffer);
156 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
Geoff Langb6a673a2014-06-05 14:19:16 -0400157 }
158
Jamie Madill3215b202015-12-15 16:41:39 -0500159 void TearDown() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400160 {
161 ANGLETest::TearDown();
Jamie Madill3215b202015-12-15 16:41:39 -0500162
163 if (mTexture != 0)
164 {
165 glDeleteTextures(1, &mTexture);
166 mTexture = 0;
167 }
168
169 if (mRenderbuffer != 0)
170 {
171 glDeleteRenderbuffers(1, &mRenderbuffer);
172 mRenderbuffer = 0;
173 }
174
175 if (mFramebuffer != 0)
176 {
177 glDeleteFramebuffers(1, &mFramebuffer);
178 mFramebuffer = 0;
179 }
180
181 if (mProgram != 0)
182 {
183 glDeleteProgram(mProgram);
184 mProgram = 0;
185 }
Geoff Langb6a673a2014-06-05 14:19:16 -0400186 }
Jamie Madill3215b202015-12-15 16:41:39 -0500187
188 GLuint mFramebuffer;
189 GLuint mTexture;
190 GLuint mRenderbuffer;
191 GLuint mProgram;
Geoff Langb6a673a2014-06-05 14:19:16 -0400192};
193
Jamie Madillfa05f602015-05-07 13:47:11 -0400194TEST_P(FramebufferFormatsTest, RGBA4)
Geoff Langb6a673a2014-06-05 14:19:16 -0400195{
Yunchao He9550c602018-02-13 14:47:05 +0800196 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400197
Geoff Langb6a673a2014-06-05 14:19:16 -0400198 testTextureFormat(GL_RGBA4, 4, 4, 4, 4);
199}
200
Jamie Madillfa05f602015-05-07 13:47:11 -0400201TEST_P(FramebufferFormatsTest, RGB565)
Geoff Langb6a673a2014-06-05 14:19:16 -0400202{
Yunchao He9550c602018-02-13 14:47:05 +0800203 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400204
Geoff Langb6a673a2014-06-05 14:19:16 -0400205 testTextureFormat(GL_RGB565, 5, 6, 5, 0);
206}
207
Jamie Madillfa05f602015-05-07 13:47:11 -0400208TEST_P(FramebufferFormatsTest, RGB8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400209{
Yunchao He9550c602018-02-13 14:47:05 +0800210 ANGLE_SKIP_TEST_IF(
211 getClientMajorVersion() < 3 &&
212 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400213
Geoff Langb6a673a2014-06-05 14:19:16 -0400214 testTextureFormat(GL_RGB8_OES, 8, 8, 8, 0);
215}
216
Jamie Madillfa05f602015-05-07 13:47:11 -0400217TEST_P(FramebufferFormatsTest, BGRA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400218{
Yunchao He9550c602018-02-13 14:47:05 +0800219 ANGLE_SKIP_TEST_IF(
220 !extensionEnabled("GL_EXT_texture_format_BGRA8888") ||
221 (getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400222
Geoff Langb6a673a2014-06-05 14:19:16 -0400223 testTextureFormat(GL_BGRA8_EXT, 8, 8, 8, 8);
224}
225
Jamie Madillfa05f602015-05-07 13:47:11 -0400226TEST_P(FramebufferFormatsTest, RGBA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400227{
Yunchao He9550c602018-02-13 14:47:05 +0800228 ANGLE_SKIP_TEST_IF(
229 getClientMajorVersion() < 3 &&
230 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400231
Geoff Langb6a673a2014-06-05 14:19:16 -0400232 testTextureFormat(GL_RGBA8_OES, 8, 8, 8, 8);
233}
234
Jamie Madillfa05f602015-05-07 13:47:11 -0400235TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH16)
Corentin Walleze0902642014-11-04 12:32:15 -0800236{
237 testRenderbufferMultisampleFormat(2, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT16);
238}
239
Jamie Madillfa05f602015-05-07 13:47:11 -0400240TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24)
Corentin Walleze0902642014-11-04 12:32:15 -0800241{
242 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT24);
243}
244
Jamie Madillfa05f602015-05-07 13:47:11 -0400245TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F)
Corentin Walleze0902642014-11-04 12:32:15 -0800246{
Yunchao He9550c602018-02-13 14:47:05 +0800247 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400248
Corentin Walleze0902642014-11-04 12:32:15 -0800249 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT32F);
250}
251
Jamie Madillfa05f602015-05-07 13:47:11 -0400252TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800253{
254 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH24_STENCIL8);
255}
256
Jamie Madillfa05f602015-05-07 13:47:11 -0400257TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800258{
Yunchao He9550c602018-02-13 14:47:05 +0800259 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400260
Corentin Walleze0902642014-11-04 12:32:15 -0800261 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH32F_STENCIL8);
262}
263
Jamie Madillfa05f602015-05-07 13:47:11 -0400264TEST_P(FramebufferFormatsTest, RenderbufferMultisample_STENCIL_INDEX8)
Corentin Walleze0902642014-11-04 12:32:15 -0800265{
Geoff Langf34d1db2015-05-20 14:10:46 -0400266 // TODO(geofflang): Figure out how to support GLSTENCIL_INDEX8 on desktop GL
Yunchao He9550c602018-02-13 14:47:05 +0800267 ANGLE_SKIP_TEST_IF(IsDesktopOpenGL());
Geoff Langf34d1db2015-05-20 14:10:46 -0400268
Corentin Walleze0902642014-11-04 12:32:15 -0800269 testRenderbufferMultisampleFormat(2, GL_STENCIL_ATTACHMENT, GL_STENCIL_INDEX8);
270}
Jamie Madillfa05f602015-05-07 13:47:11 -0400271
Jamie Madill3215b202015-12-15 16:41:39 -0500272// Test that binding an incomplete cube map is rejected by ANGLE.
273TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
274{
Luc Ferronfa7503c2018-05-08 11:25:06 -0400275 // TODO(jmadill): Handle cube textures. http://anglebug.com/2470
276 ANGLE_SKIP_TEST_IF(IsVulkan());
277
Jamie Madill3215b202015-12-15 16:41:39 -0500278 // First make a complete CubeMap.
279 glGenTextures(1, &mTexture);
280 glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);
281 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
282 nullptr);
283 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
284 nullptr);
285 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
286 nullptr);
287 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
288 nullptr);
289 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
290 nullptr);
291 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
292 nullptr);
293 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
294 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
295
296 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
297 mTexture, 0);
298
299 // Verify the framebuffer is complete.
300 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
301
302 // Make the CubeMap cube-incomplete.
303 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 16, 16, 0, GL_RGBA, GL_UNSIGNED_BYTE,
304 nullptr);
305
306 // Verify the framebuffer is incomplete.
307 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
308 glCheckFramebufferStatus(GL_FRAMEBUFFER));
309
310 // Verify drawing with the incomplete framebuffer produces a GL error
Olli Etuaho5804dc82018-04-13 14:11:46 +0300311 mProgram = CompileProgram(essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
Jamie Madill3215b202015-12-15 16:41:39 -0500312 ASSERT_NE(0u, mProgram);
Olli Etuaho5804dc82018-04-13 14:11:46 +0300313 drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
Jamie Madill3215b202015-12-15 16:41:39 -0500314 ASSERT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
315}
316
Olli Etuahobc21e182016-02-23 16:04:57 +0200317// Test that a renderbuffer with zero height but nonzero width is handled without crashes/asserts.
318TEST_P(FramebufferFormatsTest, ZeroHeightRenderbuffer)
319{
Yunchao He9550c602018-02-13 14:47:05 +0800320 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Olli Etuahobc21e182016-02-23 16:04:57 +0200321
322 testZeroHeightRenderbuffer();
323}
324
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500325// Use this to select which configurations (e.g. which renderer, which GLES major version) these
326// tests should be run against.
Geoff Lange0cc2a42016-01-20 10:58:17 -0500327ANGLE_INSTANTIATE_TEST(FramebufferFormatsTest,
Luc Ferronfa7503c2018-05-08 11:25:06 -0400328 ES2_VULKAN(),
Geoff Lange0cc2a42016-01-20 10:58:17 -0500329 ES2_D3D9(),
330 ES2_D3D11(),
331 ES3_D3D11(),
332 ES2_OPENGL(),
333 ES3_OPENGL(),
334 ES2_OPENGLES(),
335 ES3_OPENGLES());
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500336
Corentin Wallez57e6d502016-12-09 14:46:39 -0500337class FramebufferTest_ES3 : public ANGLETest
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500338{
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500339};
340
341// Covers invalidating an incomplete framebuffer. This should be a no-op, but should not error.
Corentin Wallez57e6d502016-12-09 14:46:39 -0500342TEST_P(FramebufferTest_ES3, InvalidateIncomplete)
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500343{
Geoff Lang857c09d2017-05-16 15:55:04 -0400344 GLFramebuffer framebuffer;
345 GLRenderbuffer renderbuffer;
346
347 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
348 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
349 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, renderbuffer);
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500350 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
351 glCheckFramebufferStatus(GL_FRAMEBUFFER));
352
353 std::vector<GLenum> attachments;
354 attachments.push_back(GL_COLOR_ATTACHMENT0);
355
356 glInvalidateFramebuffer(GL_FRAMEBUFFER, 1, attachments.data());
357 EXPECT_GL_NO_ERROR();
358}
359
Corentin Wallez57e6d502016-12-09 14:46:39 -0500360// Test that the framebuffer state tracking robustly handles a depth-only attachment being set
361// as a depth-stencil attachment. It is equivalent to detaching the depth-stencil attachment.
362TEST_P(FramebufferTest_ES3, DepthOnlyAsDepthStencil)
363{
Geoff Lang857c09d2017-05-16 15:55:04 -0400364 GLFramebuffer framebuffer;
365 GLRenderbuffer renderbuffer;
366
367 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
368 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500369 glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, 4, 4);
370
371 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_RENDERBUFFER,
Geoff Lang857c09d2017-05-16 15:55:04 -0400372 renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500373 EXPECT_GLENUM_NE(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
374}
375
Geoff Lang857c09d2017-05-16 15:55:04 -0400376// Test that the framebuffer correctly returns that it is not complete if invalid texture mip levels
377// are bound
378TEST_P(FramebufferTest_ES3, TextureAttachmentMipLevels)
379{
380 GLFramebuffer framebuffer;
381 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
382
383 GLTexture texture;
384 glBindTexture(GL_TEXTURE_2D, texture);
385
386 // Create a complete mip chain in mips 1 to 3
387 glTexImage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
388 glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
389 glTexImage2D(GL_TEXTURE_2D, 3, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
390
391 // Create another complete mip chain in mips 4 to 5
392 glTexImage2D(GL_TEXTURE_2D, 4, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
393 glTexImage2D(GL_TEXTURE_2D, 5, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
394
395 // Create a non-complete mip chain in mip 6
396 glTexImage2D(GL_TEXTURE_2D, 6, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
397
398 // Incomplete, mipLevel != baseLevel and texture is not mip complete
399 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
400 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
401 glCheckFramebufferStatus(GL_FRAMEBUFFER));
402
403 // Complete, mipLevel == baseLevel
404 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 1);
405 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
406
407 // Complete, mipLevel != baseLevel but texture is now mip complete
408 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 2);
409 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
410 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 3);
411 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
412
413 // Incomplete, attached level below the base level
414 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 2);
415 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
416 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
417 glCheckFramebufferStatus(GL_FRAMEBUFFER));
418
419 // Incomplete, attached level is beyond effective max level
420 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 4);
421 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
422 glCheckFramebufferStatus(GL_FRAMEBUFFER));
423
424 // Complete, mipLevel == baseLevel
425 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 4);
426 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
427
428 // Complete, mipLevel != baseLevel but texture is now mip complete
429 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 5);
430 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
431
432 // Complete, mipLevel == baseLevel
433 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 6);
434 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 6);
435 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
436}
437
Martin Radevd178aa42017-07-13 14:03:22 +0300438// Test that passing an attachment COLOR_ATTACHMENTm where m is equal to MAX_COLOR_ATTACHMENTS
439// generates an INVALID_OPERATION.
440// OpenGL ES Version 3.0.5 (November 3, 2016), 4.4.2.4 Attaching Texture Images to a Framebuffer, p.
441// 208
442TEST_P(FramebufferTest_ES3, ColorAttachmentIndexOutOfBounds)
443{
444 GLFramebuffer framebuffer;
445 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
446
447 GLint maxColorAttachments = 0;
448 glGetIntegerv(GL_MAX_COLOR_ATTACHMENTS, &maxColorAttachments);
449 GLenum attachment = static_cast<GLenum>(maxColorAttachments + GL_COLOR_ATTACHMENT0);
450
451 GLTexture texture;
452 glBindTexture(GL_TEXTURE_2D, texture.get());
453 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA32F, 1, 1);
454 glFramebufferTexture2D(GL_FRAMEBUFFER, attachment, GL_TEXTURE_2D, texture.get(), 0);
455 EXPECT_GL_ERROR(GL_INVALID_OPERATION);
456}
457
Jamie Madilla0016b72017-07-14 14:30:46 -0400458// Check that depth-only attachments report the correct number of samples.
459TEST_P(FramebufferTest_ES3, MultisampleDepthOnly)
460{
461 GLRenderbuffer renderbuffer;
462 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
463 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_DEPTH_COMPONENT24, 32, 32);
464
465 GLFramebuffer framebuffer;
466 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
467 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, renderbuffer);
468 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
469 EXPECT_GL_NO_ERROR();
470
471 GLint samples = 0;
472 glGetIntegerv(GL_SAMPLES, &samples);
473 EXPECT_GL_NO_ERROR();
474 EXPECT_GE(samples, 2);
475}
476
Jeff Gilbert8f8edd62017-10-31 14:26:30 -0700477// Check that we only compare width and height of attachments, not depth.
478TEST_P(FramebufferTest_ES3, AttachmentWith3DLayers)
479{
480 GLTexture texA;
481 glBindTexture(GL_TEXTURE_2D, texA);
482 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
483
484 GLTexture texB;
485 glBindTexture(GL_TEXTURE_3D, texB);
486 glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, 4, 4, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
487
488 GLFramebuffer framebuffer;
489 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
490 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texA, 0);
491 glFramebufferTextureLayer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, texB, 0, 0);
492 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
493 EXPECT_GL_NO_ERROR();
494}
495
Corentin Wallez57e6d502016-12-09 14:46:39 -0500496ANGLE_INSTANTIATE_TEST(FramebufferTest_ES3, ES3_D3D11(), ES3_OPENGL(), ES3_OPENGLES());
JiangYizhou461d9a32017-01-04 16:37:26 +0800497
498class FramebufferTest_ES31 : public ANGLETest
499{
JiangYizhou511937d2017-08-03 15:41:29 +0800500 protected:
501 void validateSamplePass(GLuint &query, GLuint &passedCount, GLint width, GLint height)
502 {
503 glUniform2i(0, width - 1, height - 1);
504 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
505 glDrawArrays(GL_TRIANGLES, 0, 6);
506 glEndQuery(GL_ANY_SAMPLES_PASSED);
507 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
508 EXPECT_GT(static_cast<GLint>(passedCount), 0);
509
510 glUniform2i(0, width - 1, height);
511 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
512 glDrawArrays(GL_TRIANGLES, 0, 6);
513 glEndQuery(GL_ANY_SAMPLES_PASSED);
514 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
515 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
516
517 glUniform2i(0, width, height - 1);
518 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
519 glDrawArrays(GL_TRIANGLES, 0, 6);
520 glEndQuery(GL_ANY_SAMPLES_PASSED);
521 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
522 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
523 }
JiangYizhou461d9a32017-01-04 16:37:26 +0800524};
525
526// Test that without attachment, if either the value of FRAMEBUFFER_DEFAULT_WIDTH or
527// FRAMEBUFFER_DEFAULT_HEIGHT parameters is zero, the framebuffer is incomplete.
528TEST_P(FramebufferTest_ES31, IncompleteMissingAttachmentDefaultParam)
529{
530 GLFramebuffer mFramebuffer;
531 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
532
533 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
534 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
535 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
536
537 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
538 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
539 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
540 glCheckFramebufferStatus(GL_FRAMEBUFFER));
541
542 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
543 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
544 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
545 glCheckFramebufferStatus(GL_FRAMEBUFFER));
546
547 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
548 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
549 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
550 glCheckFramebufferStatus(GL_FRAMEBUFFER));
551
552 ASSERT_GL_NO_ERROR();
553}
554
555// Test that the sample count of a mix of texture and renderbuffer should be same.
556TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountMix)
557{
558 GLFramebuffer mFramebuffer;
559 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
560
561 GLTexture mTexture;
562 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
563 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
564
565 GLRenderbuffer mRenderbuffer;
566 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
567 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_RGBA8, 1, 1);
568 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
569 mTexture.get(), 0);
570 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
571 mRenderbuffer.get());
572 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
573 glCheckFramebufferStatus(GL_FRAMEBUFFER));
574
575 ASSERT_GL_NO_ERROR();
576}
577
578// Test that the sample count of texture attachments should be same.
579TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountTex)
580{
581 GLFramebuffer mFramebuffer;
582 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
583
584 GLTexture mTextures[2];
585 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
586 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
587 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
588 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 2, GL_RGBA8, 1, 1, true);
589 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
590 mTextures[0].get(), 0);
591 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
592 mTextures[1].get(), 0);
593 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
594 glCheckFramebufferStatus(GL_FRAMEBUFFER));
595
596 ASSERT_GL_NO_ERROR();
597}
598
599// Test that if the attached images are a mix of renderbuffers and textures, the value of
600// TEXTURE_FIXED_SAMPLE_LOCATIONS must be TRUE for all attached textures.
601TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsMix)
602{
603 GLFramebuffer mFramebuffer;
604 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
605
606 GLTexture mTexture;
607 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
608 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
609
610 GLRenderbuffer mRenderbuffer;
611 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
612 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 1, GL_RGBA8, 1, 1);
613 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
614 mTexture.get(), 0);
615 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
616 mRenderbuffer.get());
617 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
618 glCheckFramebufferStatus(GL_FRAMEBUFFER));
619
620 ASSERT_GL_NO_ERROR();
621}
622
623// Test that the value of TEXTURE_FIXED_SAMPLE_LOCATIONS is the same for all attached textures.
624TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsTex)
625{
626 GLFramebuffer mFramebuffer;
627 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
628
629 GLTexture mTextures[2];
630 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
631 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
632 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
633 mTextures[0].get(), 0);
634 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
635 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGB8, 1, 1, true);
636 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
637 mTextures[1].get(), 0);
638 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
639 glCheckFramebufferStatus(GL_FRAMEBUFFER));
640
641 ASSERT_GL_NO_ERROR();
642}
643
JiangYizhou511937d2017-08-03 15:41:29 +0800644// If there are no attachments, rendering will be limited to a rectangle having a lower left of
645// (0, 0) and an upper right of(width, height), where width and height are the framebuffer
646// object's default width and height.
JiangYizhou3db40722017-08-28 17:59:13 +0800647TEST_P(FramebufferTest_ES31, RenderingLimitToDefaultFBOSizeWithNoAttachments)
JiangYizhou511937d2017-08-03 15:41:29 +0800648{
Yuly Novikov98f9f532017-11-15 19:16:19 -0500649 // anglebug.com/2253
650 ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
651
JiangYizhou10d41392017-12-18 18:13:36 +0800652 const std::string &vertexShader1 =
653 R"(#version 310 es
654 in layout(location = 0) highp vec2 a_position;
655 void main()
656 {
657 gl_Position = vec4(a_position, 0.0, 1.0);
658 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800659
JiangYizhou10d41392017-12-18 18:13:36 +0800660 const std::string &fragShader1 =
661 R"(#version 310 es
662 uniform layout(location = 0) highp ivec2 u_expectedSize;
663 out layout(location = 5) mediump vec4 f_color;
664 void main()
665 {
666 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
667 f_color = vec4(1.0, 0.5, 0.25, 1.0);
668 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800669
JiangYizhou10d41392017-12-18 18:13:36 +0800670 const std::string &vertexShader2 =
671 R"(#version 310 es
672 in layout(location = 0) highp vec2 a_position;
673 void main()
674 {
675 gl_Position = vec4(a_position, 0.0, 1.0);
676 })";
677
678 const std::string &fragShader2 =
679 R"(#version 310 es
680 uniform layout(location = 0) highp ivec2 u_expectedSize;
681 out layout(location = 2) mediump vec4 f_color;
682 void main()
683 {
684 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
685 f_color = vec4(1.0, 0.5, 0.25, 1.0);
686 })";
687
688 GLuint program1 = CompileProgram(vertexShader1, fragShader1);
689 ASSERT_NE(program1, 0u);
690
691 GLuint program2 = CompileProgram(vertexShader2, fragShader2);
692 ASSERT_NE(program2, 0u);
693
694 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800695
696 GLFramebuffer mFramebuffer;
697 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, mFramebuffer);
698 GLuint defaultWidth = 1;
699 GLuint defaultHeight = 1;
700
701 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, defaultWidth);
702 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, defaultHeight);
703 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
704
705 const float data[] = {
706 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f,
707 };
708
709 GLuint vertexArray = 0;
710 GLuint vertexBuffer = 0;
711 GLuint query = 0;
712 GLuint passedCount = 0;
713
714 glGenQueries(1, &query);
715 glGenVertexArrays(1, &vertexArray);
716 glBindVertexArray(vertexArray);
717
718 glGenBuffers(1, &vertexBuffer);
719 glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
720 glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);
721
722 glEnableVertexAttribArray(0);
723 glVertexAttribPointer(0, 2, GL_FLOAT, false, 0, 0);
JiangYizhou38d92b52017-09-13 13:47:52 +0800724 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou511937d2017-08-03 15:41:29 +0800725
726 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
727
JiangYizhou10d41392017-12-18 18:13:36 +0800728 glUseProgram(program2);
729 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
730
731 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800732 // If fbo has attachments, the rendering size should be the same as its attachment.
733 GLTexture mTexture;
734 GLuint width = 2;
735 GLuint height = 2;
736 glBindTexture(GL_TEXTURE_2D, mTexture.get());
737 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, width, height);
JiangYizhou38d92b52017-09-13 13:47:52 +0800738
739 const GLenum bufs[] = {GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_COLOR_ATTACHMENT5};
740
741 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, GL_TEXTURE_2D, mTexture.get(),
JiangYizhou511937d2017-08-03 15:41:29 +0800742 0);
743 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou38d92b52017-09-13 13:47:52 +0800744 glDrawBuffers(6, bufs);
JiangYizhou511937d2017-08-03 15:41:29 +0800745
746 validateSamplePass(query, passedCount, width, height);
747
748 // If fbo's attachment has been removed, the rendering size should be the same as framebuffer
749 // default size.
JiangYizhou38d92b52017-09-13 13:47:52 +0800750 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, 0, 0, 0);
JiangYizhou511937d2017-08-03 15:41:29 +0800751 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
752
753 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
754
755 glDisableVertexAttribArray(0);
756 glBindBuffer(GL_ARRAY_BUFFER, 0);
757 glBindVertexArray(0);
758 glDeleteBuffers(1, &vertexBuffer);
759 glDeleteVertexArrays(1, &vertexArray);
760
761 ASSERT_GL_NO_ERROR();
762}
763
764ANGLE_INSTANTIATE_TEST(FramebufferTest_ES31, ES31_D3D11(), ES31_OPENGL(), ES31_OPENGLES());
Brandon Jones9fc87332017-12-13 15:46:52 -0800765
766class AddDummyTextureNoRenderTargetTest : public ANGLETest
767{
768 public:
769 AddDummyTextureNoRenderTargetTest()
770 {
771 setWindowWidth(512);
772 setWindowHeight(512);
773 setConfigRedBits(8);
774 setConfigGreenBits(8);
775 setConfigBlueBits(8);
776 setConfigAlphaBits(8);
777 }
778
779 void overrideWorkaroundsD3D(WorkaroundsD3D *workarounds) override
780 {
781 workarounds->addDummyTextureNoRenderTarget = true;
782 }
783};
784
785// Test to verify workaround succeeds when no program outputs exist http://anglebug.com/2283
786TEST_P(AddDummyTextureNoRenderTargetTest, NoProgramOutputWorkaround)
787{
788 const std::string &vShader = "void main() {}";
789 const std::string &fShader = "void main() {}";
790
791 ANGLE_GL_PROGRAM(drawProgram, vShader, fShader);
792
793 glUseProgram(drawProgram);
794
795 glDrawArrays(GL_TRIANGLES, 0, 6);
796
797 ASSERT_GL_NO_ERROR();
798}
799
800ANGLE_INSTANTIATE_TEST(AddDummyTextureNoRenderTargetTest, ES2_D3D11());