daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 12 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 13 | #include "compiler/translator/Cache.h" |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 14 | #include "compiler/translator/glslang.h" |
| 15 | #include "compiler/translator/ValidateSwitch.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 16 | #include "compiler/translator/ValidateGlobalInitializer.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 17 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 18 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 19 | namespace sh |
| 20 | { |
| 21 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 22 | /////////////////////////////////////////////////////////////////////// |
| 23 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 24 | // Sub- vector and matrix fields |
| 25 | // |
| 26 | //////////////////////////////////////////////////////////////////////// |
| 27 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 28 | namespace |
| 29 | { |
| 30 | |
| 31 | const int kWebGLMaxStructNesting = 4; |
| 32 | |
| 33 | bool ContainsSampler(const TType &type) |
| 34 | { |
| 35 | if (IsSampler(type.getBasicType())) |
| 36 | return true; |
| 37 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 38 | if (type.getBasicType() == EbtStruct) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 39 | { |
| 40 | const TFieldList &fields = type.getStruct()->fields(); |
| 41 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 42 | { |
| 43 | if (ContainsSampler(*fields[i]->type())) |
| 44 | return true; |
| 45 | } |
| 46 | } |
| 47 | |
| 48 | return false; |
| 49 | } |
| 50 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 51 | // Get a token from an image argument to use as an error message token. |
| 52 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 53 | { |
| 54 | ASSERT(IsImage(imageNode->getBasicType())); |
| 55 | while (imageNode->getAsBinaryNode() && |
| 56 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 57 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 58 | { |
| 59 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 60 | } |
| 61 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 62 | if (imageSymbol) |
| 63 | { |
| 64 | return imageSymbol->getSymbol().c_str(); |
| 65 | } |
| 66 | return "image"; |
| 67 | } |
| 68 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 69 | } // namespace |
| 70 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 71 | TParseContext::TParseContext(TSymbolTable &symt, |
| 72 | TExtensionBehavior &ext, |
| 73 | sh::GLenum type, |
| 74 | ShShaderSpec spec, |
| 75 | ShCompileOptions options, |
| 76 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 77 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 78 | const ShBuiltInResources &resources) |
| 79 | : intermediate(), |
| 80 | symbolTable(symt), |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 81 | mDeferredNonEmptyDeclarationErrorCheck(false), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 82 | mShaderType(type), |
| 83 | mShaderSpec(spec), |
| 84 | mCompileOptions(options), |
| 85 | mShaderVersion(100), |
| 86 | mTreeRoot(nullptr), |
| 87 | mLoopNestingLevel(0), |
| 88 | mStructNestingLevel(0), |
| 89 | mSwitchNestingLevel(0), |
| 90 | mCurrentFunctionType(nullptr), |
| 91 | mFunctionReturnsValue(false), |
| 92 | mChecksPrecisionErrors(checksPrecErrors), |
| 93 | mFragmentPrecisionHighOnESSL1(false), |
| 94 | mDefaultMatrixPacking(EmpColumnMajor), |
| 95 | mDefaultBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 96 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 97 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 98 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 99 | mShaderVersion, |
| 100 | mShaderType, |
| 101 | resources.WEBGL_debug_shader_precision == 1), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 102 | mPreprocessor(mDiagnostics, &mDirectiveHandler, pp::PreprocessorSettings()), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 103 | mScanner(nullptr), |
| 104 | mUsesFragData(false), |
| 105 | mUsesFragColor(false), |
| 106 | mUsesSecondaryOutputs(false), |
| 107 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 108 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 109 | mMultiviewAvailable(resources.OVR_multiview == 1), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 110 | mComputeShaderLocalSizeDeclared(false), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 111 | mNumViews(-1), |
| 112 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 113 | mMaxImageUnits(resources.MaxImageUnits), |
| 114 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 115 | mMaxUniformLocations(resources.MaxUniformLocations), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 116 | mDeclaringFunction(false) |
| 117 | { |
| 118 | mComputeShaderLocalSize.fill(-1); |
| 119 | } |
| 120 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 121 | // |
| 122 | // Look at a '.' field selector string and change it into offsets |
| 123 | // for a vector. |
| 124 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 125 | bool TParseContext::parseVectorFields(const TString &compString, |
| 126 | int vecSize, |
| 127 | TVectorFields &fields, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 128 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 129 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 130 | fields.num = (int)compString.size(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 131 | if (fields.num > 4) |
| 132 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 133 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 134 | return false; |
| 135 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 136 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 137 | enum |
| 138 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 139 | exyzw, |
| 140 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 141 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 142 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 143 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 144 | for (int i = 0; i < fields.num; ++i) |
| 145 | { |
| 146 | switch (compString[i]) |
| 147 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 148 | case 'x': |
| 149 | fields.offsets[i] = 0; |
| 150 | fieldSet[i] = exyzw; |
| 151 | break; |
| 152 | case 'r': |
| 153 | fields.offsets[i] = 0; |
| 154 | fieldSet[i] = ergba; |
| 155 | break; |
| 156 | case 's': |
| 157 | fields.offsets[i] = 0; |
| 158 | fieldSet[i] = estpq; |
| 159 | break; |
| 160 | case 'y': |
| 161 | fields.offsets[i] = 1; |
| 162 | fieldSet[i] = exyzw; |
| 163 | break; |
| 164 | case 'g': |
| 165 | fields.offsets[i] = 1; |
| 166 | fieldSet[i] = ergba; |
| 167 | break; |
| 168 | case 't': |
| 169 | fields.offsets[i] = 1; |
| 170 | fieldSet[i] = estpq; |
| 171 | break; |
| 172 | case 'z': |
| 173 | fields.offsets[i] = 2; |
| 174 | fieldSet[i] = exyzw; |
| 175 | break; |
| 176 | case 'b': |
| 177 | fields.offsets[i] = 2; |
| 178 | fieldSet[i] = ergba; |
| 179 | break; |
| 180 | case 'p': |
| 181 | fields.offsets[i] = 2; |
| 182 | fieldSet[i] = estpq; |
| 183 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 184 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 185 | case 'w': |
| 186 | fields.offsets[i] = 3; |
| 187 | fieldSet[i] = exyzw; |
| 188 | break; |
| 189 | case 'a': |
| 190 | fields.offsets[i] = 3; |
| 191 | fieldSet[i] = ergba; |
| 192 | break; |
| 193 | case 'q': |
| 194 | fields.offsets[i] = 3; |
| 195 | fieldSet[i] = estpq; |
| 196 | break; |
| 197 | default: |
| 198 | error(line, "illegal vector field selection", compString.c_str()); |
| 199 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 200 | } |
| 201 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 202 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 203 | for (int i = 0; i < fields.num; ++i) |
| 204 | { |
| 205 | if (fields.offsets[i] >= vecSize) |
| 206 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 207 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 208 | return false; |
| 209 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 210 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 211 | if (i > 0) |
| 212 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 213 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 214 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 215 | error(line, "illegal - vector component fields not from the same set", |
| 216 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 217 | return false; |
| 218 | } |
| 219 | } |
| 220 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 221 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 222 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 223 | } |
| 224 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 225 | /////////////////////////////////////////////////////////////////////// |
| 226 | // |
| 227 | // Errors |
| 228 | // |
| 229 | //////////////////////////////////////////////////////////////////////// |
| 230 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 231 | // |
| 232 | // Used by flex/bison to output all syntax and parsing errors. |
| 233 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 234 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 235 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 236 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 237 | } |
| 238 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 239 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 240 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 241 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 242 | } |
| 243 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 244 | void TParseContext::outOfRangeError(bool isError, |
| 245 | const TSourceLoc &loc, |
| 246 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 247 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 248 | { |
| 249 | if (isError) |
| 250 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 251 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 252 | } |
| 253 | else |
| 254 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 255 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 256 | } |
| 257 | } |
| 258 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 259 | // |
| 260 | // Same error message for all places assignments don't work. |
| 261 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 262 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 263 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 264 | std::stringstream reasonStream; |
| 265 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 266 | std::string reason = reasonStream.str(); |
| 267 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 268 | } |
| 269 | |
| 270 | // |
| 271 | // Same error message for all places unary operations don't work. |
| 272 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 273 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 274 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 275 | std::stringstream reasonStream; |
| 276 | reasonStream << "wrong operand type - no operation '" << op |
| 277 | << "' exists that takes an operand of type " << operand |
| 278 | << " (or there is no acceptable conversion)"; |
| 279 | std::string reason = reasonStream.str(); |
| 280 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 281 | } |
| 282 | |
| 283 | // |
| 284 | // Same error message for all binary operations don't work. |
| 285 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 286 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 287 | const char *op, |
| 288 | TString left, |
| 289 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 290 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 291 | std::stringstream reasonStream; |
| 292 | reasonStream << "wrong operand types - no operation '" << op |
| 293 | << "' exists that takes a left-hand operand of type '" << left |
| 294 | << "' and a right operand of type '" << right |
| 295 | << "' (or there is no acceptable conversion)"; |
| 296 | std::string reason = reasonStream.str(); |
| 297 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 298 | } |
| 299 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 300 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 301 | TPrecision precision, |
| 302 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 303 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 304 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 305 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 306 | |
| 307 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 308 | { |
| 309 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 310 | } |
| 311 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 312 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 313 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 314 | switch (type) |
| 315 | { |
| 316 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 317 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 318 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 319 | case EbtInt: |
| 320 | case EbtUInt: |
| 321 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 322 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 323 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 324 | default: |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 325 | if (IsOpaqueType(type)) |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 326 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 327 | error(line, "No precision specified", getBasicString(type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 328 | return; |
| 329 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 330 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 331 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 332 | } |
| 333 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 334 | // Both test and if necessary, spit out an error, to see if the node is really |
| 335 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 336 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 337 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 338 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 339 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 340 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 341 | |
| 342 | if (swizzleNode) |
| 343 | { |
| 344 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 345 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 346 | { |
| 347 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 348 | return false; |
| 349 | } |
| 350 | return ok; |
| 351 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 352 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 353 | if (binaryNode) |
| 354 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 355 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 356 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 357 | case EOpIndexDirect: |
| 358 | case EOpIndexIndirect: |
| 359 | case EOpIndexDirectStruct: |
| 360 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 361 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 362 | default: |
| 363 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 364 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 365 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 366 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 367 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 368 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 369 | std::string message; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 370 | switch (node->getQualifier()) |
| 371 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 372 | case EvqConst: |
| 373 | message = "can't modify a const"; |
| 374 | break; |
| 375 | case EvqConstReadOnly: |
| 376 | message = "can't modify a const"; |
| 377 | break; |
| 378 | case EvqAttribute: |
| 379 | message = "can't modify an attribute"; |
| 380 | break; |
| 381 | case EvqFragmentIn: |
| 382 | message = "can't modify an input"; |
| 383 | break; |
| 384 | case EvqVertexIn: |
| 385 | message = "can't modify an input"; |
| 386 | break; |
| 387 | case EvqUniform: |
| 388 | message = "can't modify a uniform"; |
| 389 | break; |
| 390 | case EvqVaryingIn: |
| 391 | message = "can't modify a varying"; |
| 392 | break; |
| 393 | case EvqFragCoord: |
| 394 | message = "can't modify gl_FragCoord"; |
| 395 | break; |
| 396 | case EvqFrontFacing: |
| 397 | message = "can't modify gl_FrontFacing"; |
| 398 | break; |
| 399 | case EvqPointCoord: |
| 400 | message = "can't modify gl_PointCoord"; |
| 401 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 402 | case EvqNumWorkGroups: |
| 403 | message = "can't modify gl_NumWorkGroups"; |
| 404 | break; |
| 405 | case EvqWorkGroupSize: |
| 406 | message = "can't modify gl_WorkGroupSize"; |
| 407 | break; |
| 408 | case EvqWorkGroupID: |
| 409 | message = "can't modify gl_WorkGroupID"; |
| 410 | break; |
| 411 | case EvqLocalInvocationID: |
| 412 | message = "can't modify gl_LocalInvocationID"; |
| 413 | break; |
| 414 | case EvqGlobalInvocationID: |
| 415 | message = "can't modify gl_GlobalInvocationID"; |
| 416 | break; |
| 417 | case EvqLocalInvocationIndex: |
| 418 | message = "can't modify gl_LocalInvocationIndex"; |
| 419 | break; |
Olli Etuaho | 7142f6c | 2017-05-05 17:07:26 +0300 | [diff] [blame] | 420 | case EvqViewIDOVR: |
| 421 | message = "can't modify gl_ViewID_OVR"; |
| 422 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 423 | case EvqComputeIn: |
| 424 | message = "can't modify work group size variable"; |
| 425 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 426 | default: |
| 427 | // |
| 428 | // Type that can't be written to? |
| 429 | // |
| 430 | if (node->getBasicType() == EbtVoid) |
| 431 | { |
| 432 | message = "can't modify void"; |
| 433 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 434 | if (IsOpaqueType(node->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 435 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 436 | message = "can't modify a variable with type "; |
| 437 | message += getBasicString(node->getBasicType()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 438 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 439 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 440 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 441 | if (message.empty() && binaryNode == 0 && symNode == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 442 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 443 | error(line, "l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 444 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 445 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 446 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 447 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 448 | // |
| 449 | // Everything else is okay, no error. |
| 450 | // |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 451 | if (message.empty()) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 452 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 453 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 454 | // |
| 455 | // If we get here, we have an error and a message. |
| 456 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 457 | if (symNode) |
| 458 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 459 | const char *symbol = symNode->getSymbol().c_str(); |
| 460 | std::stringstream reasonStream; |
| 461 | reasonStream << "l-value required (" << message << " \"" << symbol << "\")"; |
| 462 | std::string reason = reasonStream.str(); |
| 463 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 464 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 465 | else |
| 466 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 467 | std::stringstream reasonStream; |
| 468 | reasonStream << "l-value required (" << message << ")"; |
| 469 | std::string reason = reasonStream.str(); |
| 470 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 471 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 472 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 473 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 474 | } |
| 475 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 476 | // Both test, and if necessary spit out an error, to see if the node is really |
| 477 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 478 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 479 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 480 | if (node->getQualifier() != EvqConst) |
| 481 | { |
| 482 | error(node->getLine(), "constant expression required", ""); |
| 483 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 484 | } |
| 485 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 486 | // Both test, and if necessary spit out an error, to see if the node is really |
| 487 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 488 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 489 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 490 | if (!node->isScalarInt()) |
| 491 | { |
| 492 | error(node->getLine(), "integer expression required", token); |
| 493 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 494 | } |
| 495 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 496 | // Both test, and if necessary spit out an error, to see if we are currently |
| 497 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 498 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 499 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 500 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 501 | { |
| 502 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 503 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 504 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 505 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 506 | } |
| 507 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 508 | // For now, keep it simple: if it starts "gl_", it's reserved, independent |
| 509 | // of scope. Except, if the symbol table is at the built-in push-level, |
| 510 | // which is when we are parsing built-ins. |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 511 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a |
| 512 | // webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 513 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 514 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 515 | static const char *reservedErrMsg = "reserved built-in name"; |
| 516 | if (!symbolTable.atBuiltInLevel()) |
| 517 | { |
| 518 | if (identifier.compare(0, 3, "gl_") == 0) |
| 519 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 520 | error(line, reservedErrMsg, "gl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 521 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 522 | } |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 523 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 524 | { |
| 525 | if (identifier.compare(0, 6, "webgl_") == 0) |
| 526 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 527 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 528 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 529 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 530 | if (identifier.compare(0, 7, "_webgl_") == 0) |
| 531 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 532 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 533 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 534 | } |
| 535 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 536 | if (identifier.find("__") != TString::npos) |
| 537 | { |
| 538 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 539 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 540 | "possible future keywords", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 541 | identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 542 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 543 | } |
| 544 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 545 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 546 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 547 | } |
| 548 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 549 | // Make sure there is enough data provided to the constructor to build |
| 550 | // something of the type of the constructor. Also returns the type of |
| 551 | // the constructor. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 552 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 553 | const TIntermSequence *arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 554 | TOperator op, |
| 555 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 556 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 557 | bool constructingMatrix = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 558 | switch (op) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 559 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 560 | case EOpConstructMat2: |
| 561 | case EOpConstructMat2x3: |
| 562 | case EOpConstructMat2x4: |
| 563 | case EOpConstructMat3x2: |
| 564 | case EOpConstructMat3: |
| 565 | case EOpConstructMat3x4: |
| 566 | case EOpConstructMat4x2: |
| 567 | case EOpConstructMat4x3: |
| 568 | case EOpConstructMat4: |
| 569 | constructingMatrix = true; |
| 570 | break; |
| 571 | default: |
| 572 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 573 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 574 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 575 | // |
| 576 | // Note: It's okay to have too many components available, but not okay to have unused |
| 577 | // arguments. 'full' will go to true when enough args have been seen. If we loop |
| 578 | // again, there is an extra argument, so 'overfull' will become true. |
| 579 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 580 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 581 | size_t size = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 582 | bool full = false; |
| 583 | bool overFull = false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 584 | bool matrixInMatrix = false; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 585 | bool arrayArg = false; |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 586 | for (TIntermNode *arg : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 587 | { |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 588 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 589 | size += argTyped->getType().getObjectSize(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 590 | |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 591 | if (constructingMatrix && argTyped->getType().isMatrix()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 592 | matrixInMatrix = true; |
| 593 | if (full) |
| 594 | overFull = true; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 595 | if (op != EOpConstructStruct && !type.isArray() && size >= type.getObjectSize()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 596 | full = true; |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 597 | if (argTyped->getType().isArray()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 598 | arrayArg = true; |
| 599 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 600 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 601 | if (type.isArray()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 602 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 603 | // The size of an unsized constructor should already have been determined. |
| 604 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 605 | if (static_cast<size_t>(type.getArraySize()) != arguments->size()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 606 | { |
| 607 | error(line, "array constructor needs one argument per array element", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 608 | return false; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 609 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 610 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 611 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 612 | if (arrayArg && op != EOpConstructStruct) |
| 613 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 614 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 615 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 616 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 617 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 618 | if (matrixInMatrix && !type.isArray()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 619 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 620 | if (arguments->size() != 1) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 621 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 622 | error(line, "constructing matrix from matrix can only take one argument", |
| 623 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 624 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 625 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 626 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 627 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 628 | if (overFull) |
| 629 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 630 | error(line, "too many arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 631 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 632 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 633 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 634 | if (op == EOpConstructStruct && !type.isArray() && |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 635 | type.getStruct()->fields().size() != arguments->size()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 636 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 637 | error(line, |
| 638 | "Number of constructor parameters does not match the number of structure fields", |
| 639 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 640 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 641 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 642 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 643 | if (!type.isMatrix() || !matrixInMatrix) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 644 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 645 | if ((op != EOpConstructStruct && size != 1 && size < type.getObjectSize()) || |
| 646 | (op == EOpConstructStruct && size < type.getObjectSize())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 647 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 648 | error(line, "not enough data provided for construction", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 649 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 650 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 651 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 652 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 653 | if (arguments->empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 654 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 655 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 656 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 657 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 658 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 659 | for (TIntermNode *const &argNode : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 660 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 661 | TIntermTyped *argTyped = argNode->getAsTyped(); |
| 662 | ASSERT(argTyped != nullptr); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 663 | if (op != EOpConstructStruct && IsOpaqueType(argTyped->getBasicType())) |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 664 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 665 | std::string reason("cannot convert a variable with type "); |
| 666 | reason += getBasicString(argTyped->getBasicType()); |
| 667 | error(line, reason.c_str(), "constructor"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 668 | return false; |
| 669 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 670 | if (argTyped->getBasicType() == EbtVoid) |
| 671 | { |
| 672 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 673 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 674 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 675 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 676 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 677 | if (type.isArray()) |
| 678 | { |
| 679 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 680 | // the array. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 681 | for (TIntermNode *const &argNode : *arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 682 | { |
| 683 | const TType &argType = argNode->getAsTyped()->getType(); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 684 | // It has already been checked that the argument is not an array, but we can arrive |
| 685 | // here due to prior error conditions. |
| 686 | if (argType.isArray()) |
| 687 | { |
| 688 | return false; |
| 689 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 690 | if (!argType.sameElementType(type)) |
| 691 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 692 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 693 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 694 | } |
| 695 | } |
| 696 | } |
| 697 | else if (op == EOpConstructStruct) |
| 698 | { |
| 699 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 700 | |
| 701 | for (size_t i = 0; i < fields.size(); i++) |
| 702 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 703 | if (i >= arguments->size() || |
| 704 | (*arguments)[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 705 | { |
| 706 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 707 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 708 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 709 | } |
| 710 | } |
| 711 | } |
| 712 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 713 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 714 | } |
| 715 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 716 | // This function checks to see if a void variable has been declared and raise an error message for |
| 717 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 718 | // |
| 719 | // returns true in case of an error |
| 720 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 721 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 722 | const TString &identifier, |
| 723 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 724 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 725 | if (type == EbtVoid) |
| 726 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 727 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 728 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 729 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 730 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 731 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 732 | } |
| 733 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 734 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 735 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 736 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 737 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 738 | if (type->getBasicType() != EbtBool || type->isArray() || type->isMatrix() || type->isVector()) |
| 739 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 740 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 741 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 742 | } |
| 743 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 744 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 745 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 746 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 747 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 748 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 749 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 750 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 751 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 752 | } |
| 753 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 754 | bool TParseContext::checkIsNotOpaqueType(const TSourceLoc &line, |
| 755 | const TTypeSpecifierNonArray &pType, |
| 756 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 757 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 758 | if (pType.type == EbtStruct) |
| 759 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 760 | if (ContainsSampler(*pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 761 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 762 | std::stringstream reasonStream; |
| 763 | reasonStream << reason << " (structure contains a sampler)"; |
| 764 | std::string reasonStr = reasonStream.str(); |
| 765 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 766 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 767 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 768 | // only samplers need to be checked from structs, since other opaque types can't be struct |
| 769 | // members. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 770 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 771 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 772 | else if (IsOpaqueType(pType.type)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 773 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 774 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 775 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 776 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 777 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 778 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 779 | } |
| 780 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 781 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 782 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 783 | { |
| 784 | if (pType.layoutQualifier.location != -1) |
| 785 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 786 | error(line, "location must only be specified for a single input or output variable", |
| 787 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 788 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 789 | } |
| 790 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 791 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 792 | const TLayoutQualifier &layoutQualifier) |
| 793 | { |
| 794 | if (layoutQualifier.location != -1) |
| 795 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 796 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 797 | if (mShaderVersion >= 310) |
| 798 | { |
| 799 | errorMsg = |
| 800 | "invalid layout qualifier: only valid on program inputs, outputs, and uniforms"; |
| 801 | } |
| 802 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 803 | } |
| 804 | } |
| 805 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 806 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 807 | TQualifier qualifier, |
| 808 | const TType &type) |
| 809 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 810 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 811 | if (IsOpaqueType(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 812 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 813 | error(line, "opaque types cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 814 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 815 | } |
| 816 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 817 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 818 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 819 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 820 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 821 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 822 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 823 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 824 | // fold as array size. |
| 825 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 826 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 827 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 828 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 829 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 830 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 831 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 832 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 833 | if (constant->getBasicType() == EbtUInt) |
| 834 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 835 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 836 | } |
| 837 | else |
| 838 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 839 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 840 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 841 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 842 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 843 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 844 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 845 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 846 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 847 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 848 | } |
| 849 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 850 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 851 | { |
| 852 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 853 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 854 | } |
| 855 | |
| 856 | // The size of arrays is restricted here to prevent issues further down the |
| 857 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 858 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 859 | const unsigned int sizeLimit = 65536; |
| 860 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 861 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 862 | { |
| 863 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 864 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 865 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 866 | |
| 867 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 868 | } |
| 869 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 870 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 871 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 872 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 873 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 874 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 875 | (elementQualifier.qualifier == EvqVertexIn) || |
| 876 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 877 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 878 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 879 | TType(elementQualifier).getQualifierString()); |
| 880 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 881 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 882 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 883 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 884 | } |
| 885 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 886 | // See if this element type can be formed into an array. |
| 887 | bool TParseContext::checkIsValidTypeForArray(const TSourceLoc &line, const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 888 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 889 | // |
| 890 | // Can the type be an array? |
| 891 | // |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 892 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 893 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 894 | error(line, "cannot declare arrays of arrays", |
| 895 | TType(elementType).getCompleteString().c_str()); |
| 896 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 897 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 898 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 899 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 900 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 901 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 902 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 903 | { |
| 904 | error(line, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 905 | TType(elementType).getCompleteString().c_str()); |
| 906 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 907 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 908 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 909 | return true; |
| 910 | } |
| 911 | |
| 912 | // Check if this qualified element type can be formed into an array. |
| 913 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 914 | const TPublicType &elementType) |
| 915 | { |
| 916 | if (checkIsValidTypeForArray(indexLocation, elementType)) |
| 917 | { |
| 918 | return checkIsValidQualifierForArray(indexLocation, elementType); |
| 919 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 920 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 921 | } |
| 922 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 923 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 924 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 925 | const TString &identifier, |
| 926 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 927 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 928 | ASSERT(type != nullptr); |
| 929 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 930 | { |
| 931 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 932 | type->qualifier = EvqTemporary; |
| 933 | |
| 934 | // Generate informative error messages for ESSL1. |
| 935 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 936 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 937 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 938 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 939 | "structures containing arrays may not be declared constant since they cannot be " |
| 940 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 941 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 942 | } |
| 943 | else |
| 944 | { |
| 945 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 946 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 947 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 948 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 949 | if (type->isUnsizedArray()) |
| 950 | { |
| 951 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 952 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 953 | } |
| 954 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 955 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 956 | // and update the symbol table. |
| 957 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 958 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 959 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 960 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 961 | const TString &identifier, |
| 962 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 963 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 964 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 965 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 966 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 967 | checkBindingIsValid(line, type); |
| 968 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 969 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 970 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 971 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 972 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 973 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 974 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 975 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 976 | if (static_cast<int>(type.getArraySize()) == maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 977 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 978 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 979 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 980 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 981 | } |
| 982 | } |
| 983 | else |
| 984 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 985 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 986 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 987 | return false; |
| 988 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 989 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 990 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 991 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 992 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 993 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 994 | (*variable) = new TVariable(&identifier, type); |
| 995 | if (!symbolTable.declare(*variable)) |
| 996 | { |
| 997 | error(line, "redefinition", identifier.c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 998 | *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 999 | return false; |
| 1000 | } |
| 1001 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1002 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1003 | return false; |
| 1004 | |
| 1005 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1006 | } |
| 1007 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1008 | void TParseContext::checkIsParameterQualifierValid( |
| 1009 | const TSourceLoc &line, |
| 1010 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1011 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1012 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1013 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1014 | |
| 1015 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1016 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1017 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1018 | } |
| 1019 | |
| 1020 | if (!IsImage(type->getBasicType())) |
| 1021 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1022 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1023 | } |
| 1024 | else |
| 1025 | { |
| 1026 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1027 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1028 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1029 | type->setQualifier(typeQualifier.qualifier); |
| 1030 | |
| 1031 | if (typeQualifier.precision != EbpUndefined) |
| 1032 | { |
| 1033 | type->setPrecision(typeQualifier.precision); |
| 1034 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1035 | } |
| 1036 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1037 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1038 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1039 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1040 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1041 | if (iter == extBehavior.end()) |
| 1042 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1043 | error(line, "extension is not supported", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1044 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1045 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 1046 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1047 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 1048 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1049 | // TODO(oetuaho@nvidia.com): This is slightly hacky. Might be better if symbols could be |
| 1050 | // associated with more than one extension. |
| 1051 | if (extension == "GL_OVR_multiview") |
| 1052 | { |
| 1053 | return checkCanUseExtension(line, "GL_OVR_multiview2"); |
| 1054 | } |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1055 | error(line, "extension is disabled", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1056 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1057 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1058 | if (iter->second == EBhWarn) |
| 1059 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1060 | warning(line, "extension is being used", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1061 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1062 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1063 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1064 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1065 | } |
| 1066 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1067 | // ESSL 3.00.6 section 4.8 Empty Declarations: "The combinations of qualifiers that cause |
| 1068 | // compile-time or link-time errors are the same whether or not the declaration is empty". |
| 1069 | // This function implements all the checks that are done on qualifiers regardless of if the |
| 1070 | // declaration is empty. |
| 1071 | void TParseContext::declarationQualifierErrorCheck(const sh::TQualifier qualifier, |
| 1072 | const sh::TLayoutQualifier &layoutQualifier, |
| 1073 | const TSourceLoc &location) |
| 1074 | { |
| 1075 | if (qualifier == EvqShared && !layoutQualifier.isEmpty()) |
| 1076 | { |
| 1077 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1078 | } |
| 1079 | |
| 1080 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1081 | { |
| 1082 | error(location, "layout qualifier only valid for interface blocks", |
| 1083 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
| 1084 | return; |
| 1085 | } |
| 1086 | |
| 1087 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1088 | { |
| 1089 | error(location, "layout qualifier only valid for interface blocks", |
| 1090 | getBlockStorageString(layoutQualifier.blockStorage)); |
| 1091 | return; |
| 1092 | } |
| 1093 | |
| 1094 | if (qualifier == EvqFragmentOut) |
| 1095 | { |
| 1096 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1097 | { |
| 1098 | error(location, "invalid layout qualifier combination", "yuv"); |
| 1099 | return; |
| 1100 | } |
| 1101 | } |
| 1102 | else |
| 1103 | { |
| 1104 | checkYuvIsNotSpecified(location, layoutQualifier.yuv); |
| 1105 | } |
| 1106 | |
| 1107 | bool canHaveLocation = qualifier == EvqVertexIn || qualifier == EvqFragmentOut; |
| 1108 | if (mShaderVersion >= 310 && qualifier == EvqUniform) |
| 1109 | { |
| 1110 | canHaveLocation = true; |
| 1111 | // We're not checking whether the uniform location is in range here since that depends on |
| 1112 | // the type of the variable. |
| 1113 | // The type can only be fully determined for non-empty declarations. |
| 1114 | } |
| 1115 | if (!canHaveLocation) |
| 1116 | { |
| 1117 | checkLocationIsNotSpecified(location, layoutQualifier); |
| 1118 | } |
| 1119 | } |
| 1120 | |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1121 | void TParseContext::emptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1122 | const TSourceLoc &location) |
| 1123 | { |
| 1124 | if (publicType.isUnsizedArray()) |
| 1125 | { |
| 1126 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1127 | // error. It is assumed that this applies to empty declarations as well. |
| 1128 | error(location, "empty array declaration needs to specify a size", ""); |
| 1129 | } |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1130 | } |
| 1131 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1132 | // These checks are done for all declarations that are non-empty. They're done for non-empty |
| 1133 | // declarations starting a declarator list, and declarators that follow an empty declaration. |
| 1134 | void TParseContext::nonEmptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1135 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1136 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1137 | switch (publicType.qualifier) |
| 1138 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1139 | case EvqVaryingIn: |
| 1140 | case EvqVaryingOut: |
| 1141 | case EvqAttribute: |
| 1142 | case EvqVertexIn: |
| 1143 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1144 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1145 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1146 | { |
| 1147 | error(identifierLocation, "cannot be used with a structure", |
| 1148 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1149 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1150 | } |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1151 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1152 | default: |
| 1153 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1154 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1155 | std::string reason(getBasicString(publicType.getBasicType())); |
| 1156 | reason += "s must be uniform"; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1157 | if (publicType.qualifier != EvqUniform && |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1158 | !checkIsNotOpaqueType(identifierLocation, publicType.typeSpecifierNonArray, reason.c_str())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1159 | { |
| 1160 | return; |
| 1161 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1162 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1163 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1164 | publicType.qualifier != EvqConst) && |
| 1165 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1166 | { |
| 1167 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1168 | getQualifierString(publicType.qualifier)); |
| 1169 | return; |
| 1170 | } |
| 1171 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1172 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1173 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1174 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1175 | // But invalid shaders may still reach here with an unsized array declaration. |
| 1176 | if (!publicType.isUnsizedArray()) |
| 1177 | { |
| 1178 | TType type(publicType); |
| 1179 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1180 | publicType.layoutQualifier); |
| 1181 | } |
| 1182 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1183 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1184 | // check for layout qualifier issues |
| 1185 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1186 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1187 | if (IsImage(publicType.getBasicType())) |
| 1188 | { |
| 1189 | |
| 1190 | switch (layoutQualifier.imageInternalFormat) |
| 1191 | { |
| 1192 | case EiifRGBA32F: |
| 1193 | case EiifRGBA16F: |
| 1194 | case EiifR32F: |
| 1195 | case EiifRGBA8: |
| 1196 | case EiifRGBA8_SNORM: |
| 1197 | if (!IsFloatImage(publicType.getBasicType())) |
| 1198 | { |
| 1199 | error(identifierLocation, |
| 1200 | "internal image format requires a floating image type", |
| 1201 | getBasicString(publicType.getBasicType())); |
| 1202 | return; |
| 1203 | } |
| 1204 | break; |
| 1205 | case EiifRGBA32I: |
| 1206 | case EiifRGBA16I: |
| 1207 | case EiifRGBA8I: |
| 1208 | case EiifR32I: |
| 1209 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1210 | { |
| 1211 | error(identifierLocation, |
| 1212 | "internal image format requires an integer image type", |
| 1213 | getBasicString(publicType.getBasicType())); |
| 1214 | return; |
| 1215 | } |
| 1216 | break; |
| 1217 | case EiifRGBA32UI: |
| 1218 | case EiifRGBA16UI: |
| 1219 | case EiifRGBA8UI: |
| 1220 | case EiifR32UI: |
| 1221 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1222 | { |
| 1223 | error(identifierLocation, |
| 1224 | "internal image format requires an unsigned image type", |
| 1225 | getBasicString(publicType.getBasicType())); |
| 1226 | return; |
| 1227 | } |
| 1228 | break; |
| 1229 | case EiifUnspecified: |
| 1230 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1231 | return; |
| 1232 | default: |
| 1233 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1234 | return; |
| 1235 | } |
| 1236 | |
| 1237 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1238 | switch (layoutQualifier.imageInternalFormat) |
| 1239 | { |
| 1240 | case EiifR32F: |
| 1241 | case EiifR32I: |
| 1242 | case EiifR32UI: |
| 1243 | break; |
| 1244 | default: |
| 1245 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1246 | { |
| 1247 | error(identifierLocation, "layout qualifier", |
| 1248 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1249 | "image variables must be qualified readonly and/or writeonly"); |
| 1250 | return; |
| 1251 | } |
| 1252 | break; |
| 1253 | } |
| 1254 | } |
| 1255 | else |
| 1256 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1257 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1258 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1259 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1260 | } |
| 1261 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1262 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1263 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1264 | { |
| 1265 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
| 1266 | int arraySize = type.isArray() ? type.getArraySize() : 1; |
| 1267 | if (IsImage(type.getBasicType())) |
| 1268 | { |
| 1269 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1270 | } |
| 1271 | else if (IsSampler(type.getBasicType())) |
| 1272 | { |
| 1273 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1274 | } |
| 1275 | else |
| 1276 | { |
| 1277 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1278 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1279 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1280 | } |
| 1281 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1282 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1283 | const TString &layoutQualifierName, |
| 1284 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1285 | { |
| 1286 | |
| 1287 | if (mShaderVersion < versionRequired) |
| 1288 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1289 | error(location, "invalid layout qualifier: not supported", layoutQualifierName.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1290 | } |
| 1291 | } |
| 1292 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1293 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1294 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1295 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1296 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1297 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1298 | { |
| 1299 | if (localSize[i] != -1) |
| 1300 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1301 | error(location, |
| 1302 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1303 | "global layout declaration", |
| 1304 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1305 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1306 | } |
| 1307 | } |
| 1308 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1309 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1310 | } |
| 1311 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1312 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1313 | TLayoutImageInternalFormat internalFormat) |
| 1314 | { |
| 1315 | if (internalFormat != EiifUnspecified) |
| 1316 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1317 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1318 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1319 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1320 | } |
| 1321 | |
| 1322 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1323 | { |
| 1324 | if (binding != -1) |
| 1325 | { |
| 1326 | error(location, |
| 1327 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1328 | "binding"); |
| 1329 | } |
| 1330 | } |
| 1331 | |
| 1332 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, int binding, int arraySize) |
| 1333 | { |
| 1334 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1335 | if (binding >= 0 && binding + arraySize > mMaxImageUnits) |
| 1336 | { |
| 1337 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1338 | } |
| 1339 | } |
| 1340 | |
| 1341 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1342 | int binding, |
| 1343 | int arraySize) |
| 1344 | { |
| 1345 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1346 | if (binding >= 0 && binding + arraySize > mMaxCombinedTextureImageUnits) |
| 1347 | { |
| 1348 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1349 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1350 | } |
| 1351 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1352 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1353 | int objectLocationCount, |
| 1354 | const TLayoutQualifier &layoutQualifier) |
| 1355 | { |
| 1356 | int loc = layoutQualifier.location; |
| 1357 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1358 | { |
| 1359 | error(location, "Uniform location out of range", "location"); |
| 1360 | } |
| 1361 | } |
| 1362 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1363 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1364 | { |
| 1365 | if (yuv != false) |
| 1366 | { |
| 1367 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1368 | } |
| 1369 | } |
| 1370 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1371 | void TParseContext::functionCallLValueErrorCheck(const TFunction *fnCandidate, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1372 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1373 | { |
| 1374 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1375 | { |
| 1376 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
| 1377 | if (qual == EvqOut || qual == EvqInOut) |
| 1378 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1379 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1380 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1381 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1382 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1383 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 1384 | fnCall->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1385 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1386 | } |
| 1387 | } |
| 1388 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1389 | } |
| 1390 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1391 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1392 | const TQualifier qualifier, |
| 1393 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1394 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1395 | if (!invariant) |
| 1396 | return; |
| 1397 | |
| 1398 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1399 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1400 | // input variables in the fragment shader can be also qualified as invariant |
| 1401 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1402 | { |
| 1403 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1404 | } |
| 1405 | } |
| 1406 | else |
| 1407 | { |
| 1408 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1409 | { |
| 1410 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1411 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1412 | } |
| 1413 | } |
| 1414 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1415 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1416 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1417 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1418 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1419 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1420 | } |
| 1421 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1422 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1423 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1424 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1425 | } |
| 1426 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1427 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1428 | const char *extName, |
| 1429 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1430 | { |
| 1431 | pp::SourceLocation srcLoc; |
| 1432 | srcLoc.file = loc.first_file; |
| 1433 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1434 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1435 | } |
| 1436 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1437 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1438 | const char *name, |
| 1439 | const char *value, |
| 1440 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1441 | { |
| 1442 | pp::SourceLocation srcLoc; |
| 1443 | srcLoc.file = loc.first_file; |
| 1444 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1445 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1446 | } |
| 1447 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1448 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1449 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1450 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1451 | for (size_t i = 0u; i < result.size(); ++i) |
| 1452 | { |
| 1453 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1454 | { |
| 1455 | result[i] = 1; |
| 1456 | } |
| 1457 | else |
| 1458 | { |
| 1459 | result[i] = mComputeShaderLocalSize[i]; |
| 1460 | } |
| 1461 | } |
| 1462 | return result; |
| 1463 | } |
| 1464 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1465 | ///////////////////////////////////////////////////////////////////////////////// |
| 1466 | // |
| 1467 | // Non-Errors. |
| 1468 | // |
| 1469 | ///////////////////////////////////////////////////////////////////////////////// |
| 1470 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1471 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1472 | const TString *name, |
| 1473 | const TSymbol *symbol) |
| 1474 | { |
Yunchao He | d7297bf | 2017-04-19 15:27:10 +0800 | [diff] [blame] | 1475 | const TVariable *variable = nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1476 | |
| 1477 | if (!symbol) |
| 1478 | { |
| 1479 | error(location, "undeclared identifier", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1480 | } |
| 1481 | else if (!symbol->isVariable()) |
| 1482 | { |
| 1483 | error(location, "variable expected", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1484 | } |
| 1485 | else |
| 1486 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1487 | variable = static_cast<const TVariable *>(symbol); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1488 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1489 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1490 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1491 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1492 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1493 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1494 | |
| 1495 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1496 | TQualifier qualifier = variable->getType().getQualifier(); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1497 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1498 | { |
| 1499 | mUsesFragData = true; |
| 1500 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1501 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1502 | { |
| 1503 | mUsesFragColor = true; |
| 1504 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1505 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1506 | { |
| 1507 | mUsesSecondaryOutputs = true; |
| 1508 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1509 | |
| 1510 | // This validation is not quite correct - it's only an error to write to |
| 1511 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1512 | // be rewarded for reading from undefined varaibles, return an error |
| 1513 | // if they are both referenced, rather than assigned. |
| 1514 | if (mUsesFragData && mUsesFragColor) |
| 1515 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1516 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1517 | if (mUsesSecondaryOutputs) |
| 1518 | { |
| 1519 | errorMessage = |
| 1520 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1521 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1522 | } |
| 1523 | error(location, errorMessage, name->c_str()); |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1524 | } |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 1525 | |
| 1526 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1527 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1528 | qualifier == EvqWorkGroupSize) |
| 1529 | { |
| 1530 | error(location, |
| 1531 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1532 | "gl_WorkGroupSize"); |
| 1533 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1534 | } |
| 1535 | |
| 1536 | if (!variable) |
| 1537 | { |
| 1538 | TType type(EbtFloat, EbpUndefined); |
| 1539 | TVariable *fakeVariable = new TVariable(name, type); |
| 1540 | symbolTable.declare(fakeVariable); |
| 1541 | variable = fakeVariable; |
| 1542 | } |
| 1543 | |
| 1544 | return variable; |
| 1545 | } |
| 1546 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1547 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1548 | const TString *name, |
| 1549 | const TSymbol *symbol) |
| 1550 | { |
| 1551 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1552 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1553 | if (variable->getType().getQualifier() == EvqViewIDOVR && IsWebGLBasedSpec(mShaderSpec) && |
| 1554 | mShaderType == GL_FRAGMENT_SHADER && !isExtensionEnabled("GL_OVR_multiview2")) |
| 1555 | { |
| 1556 | // WEBGL_multiview spec |
| 1557 | error(location, "Need to enable OVR_multiview2 to use gl_ViewID_OVR in fragment shader", |
| 1558 | "gl_ViewID_OVR"); |
| 1559 | } |
| 1560 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1561 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1562 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1563 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1564 | return intermediate.addConstantUnion(constArray, variable->getType(), location); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1565 | } |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1566 | else if (variable->getType().getQualifier() == EvqWorkGroupSize && |
| 1567 | mComputeShaderLocalSizeDeclared) |
| 1568 | { |
| 1569 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1570 | // needs to be added to the AST as a constant and not as a symbol. |
| 1571 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1572 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1573 | for (size_t i = 0; i < 3; ++i) |
| 1574 | { |
| 1575 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1576 | } |
| 1577 | |
| 1578 | ASSERT(variable->getType().getBasicType() == EbtUInt); |
| 1579 | ASSERT(variable->getType().getObjectSize() == 3); |
| 1580 | |
| 1581 | TType type(variable->getType()); |
| 1582 | type.setQualifier(EvqConst); |
| 1583 | return intermediate.addConstantUnion(constArray, type, location); |
| 1584 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1585 | else |
| 1586 | { |
| 1587 | return intermediate.addSymbol(variable->getUniqueId(), variable->getName(), |
| 1588 | variable->getType(), location); |
| 1589 | } |
| 1590 | } |
| 1591 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1592 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1593 | // Initializers show up in several places in the grammar. Have one set of |
| 1594 | // code to handle them here. |
| 1595 | // |
Jamie Madill | 3b5c2da | 2014-08-19 15:23:32 -0400 | [diff] [blame] | 1596 | // Returns true on error, false if no error |
| 1597 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1598 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1599 | const TString &identifier, |
| 1600 | const TPublicType &pType, |
| 1601 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1602 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1603 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1604 | ASSERT(initNode != nullptr); |
| 1605 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1606 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1607 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1608 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1609 | if (type.isUnsizedArray()) |
| 1610 | { |
Olli Etuaho | 02bd82c | 2016-11-03 10:29:43 +0000 | [diff] [blame] | 1611 | // We have not checked yet whether the initializer actually is an array or not. |
| 1612 | if (initializer->isArray()) |
| 1613 | { |
| 1614 | type.setArraySize(initializer->getArraySize()); |
| 1615 | } |
| 1616 | else |
| 1617 | { |
| 1618 | // Having a non-array initializer for an unsized array will result in an error later, |
| 1619 | // so we don't generate an error message here. |
| 1620 | type.setArraySize(1u); |
| 1621 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1622 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1623 | if (!declareVariable(line, identifier, type, &variable)) |
| 1624 | { |
| 1625 | return true; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1626 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1627 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1628 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1629 | if (symbolTable.atGlobalLevel() && |
| 1630 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1631 | { |
| 1632 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1633 | // we want to steer developers towards only using constant expressions. |
| 1634 | error(line, "global variable initializers must be constant expressions", "="); |
| 1635 | return true; |
| 1636 | } |
| 1637 | if (globalInitWarning) |
| 1638 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1639 | warning( |
| 1640 | line, |
| 1641 | "global variable initializers should be constant expressions " |
| 1642 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1643 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1644 | } |
| 1645 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1646 | // |
| 1647 | // identifier must be of type constant, a global, or a temporary |
| 1648 | // |
| 1649 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1650 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1651 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1652 | error(line, " cannot initialize this type of qualifier ", |
| 1653 | variable->getType().getQualifierString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1654 | return true; |
| 1655 | } |
| 1656 | // |
| 1657 | // test for and propagate constant |
| 1658 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1659 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1660 | if (qualifier == EvqConst) |
| 1661 | { |
| 1662 | if (qualifier != initializer->getType().getQualifier()) |
| 1663 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1664 | std::stringstream reasonStream; |
| 1665 | reasonStream << "assigning non-constant to '" << variable->getType().getCompleteString() |
| 1666 | << "'"; |
| 1667 | std::string reason = reasonStream.str(); |
| 1668 | error(line, reason.c_str(), "="); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1669 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1670 | return true; |
| 1671 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1672 | if (type != initializer->getType()) |
| 1673 | { |
| 1674 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1675 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1676 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1677 | return true; |
| 1678 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1679 | |
| 1680 | // Save the constant folded value to the variable if possible. For example array |
| 1681 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1682 | // in the shader is avoided. |
| 1683 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1684 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1685 | if (initializer->getAsConstantUnion()) |
| 1686 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1687 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1688 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1689 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1690 | } |
| 1691 | else if (initializer->getAsSymbolNode()) |
| 1692 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1693 | const TSymbol *symbol = |
| 1694 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1695 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1696 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1697 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1698 | if (constArray) |
| 1699 | { |
| 1700 | variable->shareConstPointer(constArray); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1701 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1702 | return false; |
| 1703 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1704 | } |
| 1705 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1706 | |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1707 | TIntermSymbol *intermSymbol = intermediate.addSymbol( |
| 1708 | variable->getUniqueId(), variable->getName(), variable->getType(), line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1709 | *initNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1710 | if (*initNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1711 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1712 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
| 1713 | return true; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1714 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1715 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1716 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1717 | } |
| 1718 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 1719 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 1720 | { |
| 1721 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 1722 | typeSpecifier->getBasicType()); |
| 1723 | |
| 1724 | if (mShaderVersion < 300 && typeSpecifier->array) |
| 1725 | { |
| 1726 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 1727 | typeSpecifier->clearArrayness(); |
| 1728 | } |
| 1729 | } |
| 1730 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1731 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1732 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1733 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1734 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1735 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1736 | TPublicType returnType = typeSpecifier; |
| 1737 | returnType.qualifier = typeQualifier.qualifier; |
| 1738 | returnType.invariant = typeQualifier.invariant; |
| 1739 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1740 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1741 | returnType.precision = typeSpecifier.precision; |
| 1742 | |
| 1743 | if (typeQualifier.precision != EbpUndefined) |
| 1744 | { |
| 1745 | returnType.precision = typeQualifier.precision; |
| 1746 | } |
| 1747 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1748 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 1749 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1750 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1751 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 1752 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1753 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1754 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1755 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1756 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1757 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1758 | if (typeSpecifier.array) |
| 1759 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1760 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1761 | returnType.clearArrayness(); |
| 1762 | } |
| 1763 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1764 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1765 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1766 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1767 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1768 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1769 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1770 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1771 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1772 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1773 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1774 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1775 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1776 | } |
| 1777 | } |
| 1778 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1779 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1780 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1781 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1782 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1783 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1784 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 1785 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1786 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1787 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 1788 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1789 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1790 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1791 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1792 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1793 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1794 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1795 | } |
| 1796 | |
| 1797 | return returnType; |
| 1798 | } |
| 1799 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1800 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 1801 | const TPublicType &type, |
| 1802 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1803 | { |
| 1804 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1805 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1806 | { |
| 1807 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1808 | } |
| 1809 | |
| 1810 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 1811 | switch (qualifier) |
| 1812 | { |
| 1813 | case EvqVertexIn: |
| 1814 | // ESSL 3.00 section 4.3.4 |
| 1815 | if (type.array) |
| 1816 | { |
| 1817 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1818 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1819 | // Vertex inputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1820 | return; |
| 1821 | case EvqFragmentOut: |
| 1822 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1823 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1824 | { |
| 1825 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1826 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1827 | // Fragment outputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1828 | return; |
| 1829 | default: |
| 1830 | break; |
| 1831 | } |
| 1832 | |
| 1833 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 1834 | // restrictions. |
| 1835 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1836 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 1837 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1838 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 1839 | { |
| 1840 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 1841 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1842 | } |
| 1843 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1844 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1845 | { |
| 1846 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 1847 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 1848 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 1849 | if (type.array) |
| 1850 | { |
| 1851 | error(qualifierLocation, "cannot be an array of structures", |
| 1852 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1853 | } |
| 1854 | if (type.isStructureContainingArrays()) |
| 1855 | { |
| 1856 | error(qualifierLocation, "cannot be a structure containing an array", |
| 1857 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1858 | } |
| 1859 | if (type.isStructureContainingType(EbtStruct)) |
| 1860 | { |
| 1861 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 1862 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1863 | } |
| 1864 | if (type.isStructureContainingType(EbtBool)) |
| 1865 | { |
| 1866 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 1867 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1868 | } |
| 1869 | } |
| 1870 | } |
| 1871 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1872 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 1873 | { |
| 1874 | if (qualifier.getType() == QtStorage) |
| 1875 | { |
| 1876 | const TStorageQualifierWrapper &storageQualifier = |
| 1877 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 1878 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 1879 | !symbolTable.atGlobalLevel()) |
| 1880 | { |
| 1881 | error(storageQualifier.getLine(), |
| 1882 | "Local variables can only use the const storage qualifier.", |
| 1883 | storageQualifier.getQualifierString().c_str()); |
| 1884 | } |
| 1885 | } |
| 1886 | } |
| 1887 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1888 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1889 | const TSourceLoc &location) |
| 1890 | { |
| 1891 | if (memoryQualifier.readonly) |
| 1892 | { |
| 1893 | error(location, "Only allowed with images.", "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1894 | } |
| 1895 | if (memoryQualifier.writeonly) |
| 1896 | { |
| 1897 | error(location, "Only allowed with images.", "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1898 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1899 | if (memoryQualifier.coherent) |
| 1900 | { |
| 1901 | error(location, "Only allowed with images.", "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1902 | } |
| 1903 | if (memoryQualifier.restrictQualifier) |
| 1904 | { |
| 1905 | error(location, "Only allowed with images.", "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1906 | } |
| 1907 | if (memoryQualifier.volatileQualifier) |
| 1908 | { |
| 1909 | error(location, "Only allowed with images.", "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1910 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1911 | } |
| 1912 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1913 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 1914 | TPublicType &publicType, |
| 1915 | const TSourceLoc &identifierOrTypeLocation, |
| 1916 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1917 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1918 | TType type(publicType); |
| 1919 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 1920 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 1921 | { |
| 1922 | TQualifier qualifier = type.getQualifier(); |
| 1923 | |
| 1924 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 1925 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 1926 | // affected variable declarations: |
| 1927 | // |
| 1928 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 1929 | // elsewhere, in TranslatorGLSL.) |
| 1930 | // |
| 1931 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 1932 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 1933 | // the way this is currently implemented we have to enable this compiler option before |
| 1934 | // parsing the shader and determining the shading language version it uses. If this were |
| 1935 | // implemented as a post-pass, the workaround could be more targeted. |
| 1936 | // |
| 1937 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 1938 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 1939 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 1940 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 1941 | { |
| 1942 | type.setInvariant(true); |
| 1943 | } |
| 1944 | } |
| 1945 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1946 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 1947 | identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1948 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1949 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1950 | mDeferredNonEmptyDeclarationErrorCheck = emptyDeclaration; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1951 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1952 | TIntermSymbol *symbol = nullptr; |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1953 | if (emptyDeclaration) |
| 1954 | { |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1955 | emptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1956 | // In most cases we don't need to create a symbol node for an empty declaration. |
| 1957 | // But if the empty declaration is declaring a struct type, the symbol node will store that. |
| 1958 | if (type.getBasicType() == EbtStruct) |
| 1959 | { |
| 1960 | symbol = intermediate.addSymbol(0, "", type, identifierOrTypeLocation); |
| 1961 | } |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1962 | } |
| 1963 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1964 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1965 | nonEmptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1966 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1967 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1968 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1969 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1970 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1971 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1972 | if (variable) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1973 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1974 | symbol = intermediate.addSymbol(variable->getUniqueId(), identifier, type, |
| 1975 | identifierOrTypeLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1976 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1977 | } |
| 1978 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1979 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1980 | declaration->setLine(identifierOrTypeLocation); |
| 1981 | if (symbol) |
| 1982 | { |
| 1983 | declaration->appendDeclarator(symbol); |
| 1984 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1985 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1986 | } |
| 1987 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1988 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 1989 | const TSourceLoc &identifierLocation, |
| 1990 | const TString &identifier, |
| 1991 | const TSourceLoc &indexLocation, |
| 1992 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1993 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1994 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1995 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1996 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 1997 | identifierLocation); |
| 1998 | |
| 1999 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2000 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2001 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2002 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2003 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2004 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2005 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2006 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2007 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2008 | // Make the type an array even if size check failed. |
| 2009 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2010 | arrayType.setArraySize(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2011 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2012 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2013 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2014 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2015 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2016 | declaration->setLine(identifierLocation); |
| 2017 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2018 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2019 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2020 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2021 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2022 | declaration->appendDeclarator(symbol); |
| 2023 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2024 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2025 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2026 | } |
| 2027 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2028 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2029 | const TSourceLoc &identifierLocation, |
| 2030 | const TString &identifier, |
| 2031 | const TSourceLoc &initLocation, |
| 2032 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2033 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2034 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2035 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2036 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2037 | identifierLocation); |
| 2038 | |
| 2039 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2040 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2041 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2042 | declaration->setLine(identifierLocation); |
| 2043 | |
| 2044 | TIntermBinary *initNode = nullptr; |
| 2045 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2046 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2047 | if (initNode) |
| 2048 | { |
| 2049 | declaration->appendDeclarator(initNode); |
| 2050 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2051 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2052 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2053 | } |
| 2054 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2055 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2056 | TPublicType &publicType, |
| 2057 | const TSourceLoc &identifierLocation, |
| 2058 | const TString &identifier, |
| 2059 | const TSourceLoc &indexLocation, |
| 2060 | TIntermTyped *indexExpression, |
| 2061 | const TSourceLoc &initLocation, |
| 2062 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2063 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2064 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2065 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2066 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2067 | identifierLocation); |
| 2068 | |
| 2069 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2070 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2071 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2072 | |
| 2073 | TPublicType arrayType(publicType); |
| 2074 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2075 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2076 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2077 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2078 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2079 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2080 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2081 | } |
| 2082 | // Make the type an array even if size check failed. |
| 2083 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2084 | arrayType.setArraySize(size); |
| 2085 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2086 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2087 | declaration->setLine(identifierLocation); |
| 2088 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2089 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2090 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2091 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2092 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2093 | if (initNode) |
| 2094 | { |
| 2095 | declaration->appendDeclarator(initNode); |
| 2096 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2097 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2098 | |
| 2099 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2100 | } |
| 2101 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2102 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2103 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2104 | const TSourceLoc &identifierLoc, |
| 2105 | const TString *identifier, |
| 2106 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2107 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2108 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2109 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2110 | if (!typeQualifier.invariant) |
| 2111 | { |
| 2112 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 2113 | return nullptr; |
| 2114 | } |
| 2115 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2116 | { |
| 2117 | return nullptr; |
| 2118 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2119 | if (!symbol) |
| 2120 | { |
| 2121 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2122 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2123 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2124 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2125 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2126 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2127 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2128 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2129 | if (typeQualifier.precision != EbpUndefined) |
| 2130 | { |
| 2131 | error(identifierLoc, "invariant declaration specifies precision", |
| 2132 | getPrecisionString(typeQualifier.precision)); |
| 2133 | } |
| 2134 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2135 | { |
| 2136 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2137 | } |
| 2138 | |
| 2139 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
| 2140 | ASSERT(variable); |
| 2141 | const TType &type = variable->getType(); |
| 2142 | |
| 2143 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2144 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2145 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2146 | |
| 2147 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 2148 | |
| 2149 | TIntermSymbol *intermSymbol = |
| 2150 | intermediate.addSymbol(variable->getUniqueId(), *identifier, type, identifierLoc); |
| 2151 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2152 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2153 | } |
| 2154 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2155 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2156 | const TSourceLoc &identifierLocation, |
| 2157 | const TString &identifier, |
| 2158 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2159 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2160 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2161 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2162 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2163 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2164 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2165 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2166 | } |
| 2167 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2168 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2169 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2170 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2171 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2172 | TVariable *variable = nullptr; |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2173 | TType type(publicType); |
| 2174 | declareVariable(identifierLocation, identifier, type, &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2175 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2176 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierLocation); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2177 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2178 | { |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2179 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2180 | declarationOut->appendDeclarator(symbol); |
| 2181 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2182 | } |
| 2183 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2184 | void TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 2185 | const TSourceLoc &identifierLocation, |
| 2186 | const TString &identifier, |
| 2187 | const TSourceLoc &arrayLocation, |
| 2188 | TIntermTyped *indexExpression, |
| 2189 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2190 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2191 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2192 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2193 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2194 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2195 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2196 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2197 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2198 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2199 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2200 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2201 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2202 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2203 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2204 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2205 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2206 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 693c9aa | 2015-04-07 17:50:36 +0300 | [diff] [blame] | 2207 | arrayType.setArraySize(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2208 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2209 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2210 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2211 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2212 | TIntermSymbol *symbol = |
| 2213 | intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2214 | if (variable && symbol) |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2215 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2216 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2217 | declarationOut->appendDeclarator(symbol); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2218 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2219 | } |
| 2220 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2221 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2222 | const TSourceLoc &identifierLocation, |
| 2223 | const TString &identifier, |
| 2224 | const TSourceLoc &initLocation, |
| 2225 | TIntermTyped *initializer, |
| 2226 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2227 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2228 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2229 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2230 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2231 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2232 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2233 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2234 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2235 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2236 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2237 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2238 | TIntermBinary *initNode = nullptr; |
| 2239 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2240 | { |
| 2241 | // |
| 2242 | // build the intermediate representation |
| 2243 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2244 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2245 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2246 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2247 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2248 | } |
| 2249 | } |
| 2250 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2251 | void TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
| 2252 | const TSourceLoc &identifierLocation, |
| 2253 | const TString &identifier, |
| 2254 | const TSourceLoc &indexLocation, |
| 2255 | TIntermTyped *indexExpression, |
| 2256 | const TSourceLoc &initLocation, |
| 2257 | TIntermTyped *initializer, |
| 2258 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2259 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2260 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2261 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2262 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2263 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2264 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2265 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2266 | } |
| 2267 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2268 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2269 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2270 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2271 | |
| 2272 | TPublicType arrayType(publicType); |
| 2273 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2274 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2275 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2276 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2277 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2278 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2279 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2280 | } |
| 2281 | // Make the type an array even if size check failed. |
| 2282 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2283 | arrayType.setArraySize(size); |
| 2284 | |
| 2285 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2286 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2287 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2288 | { |
| 2289 | if (initNode) |
| 2290 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2291 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2292 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2293 | } |
| 2294 | } |
| 2295 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2296 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2297 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2298 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2299 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2300 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2301 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2302 | typeQualifier.line); |
| 2303 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2304 | // It should never be the case, but some strange parser errors can send us here. |
| 2305 | if (layoutQualifier.isEmpty()) |
| 2306 | { |
| 2307 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2308 | return; |
| 2309 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2310 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2311 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2312 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2313 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2314 | return; |
| 2315 | } |
| 2316 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2317 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 2318 | |
| 2319 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2320 | |
| 2321 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2322 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2323 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 2324 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2325 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2326 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2327 | if (mComputeShaderLocalSizeDeclared && |
| 2328 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 2329 | { |
| 2330 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 2331 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2332 | return; |
| 2333 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2334 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2335 | if (mShaderVersion < 310) |
| 2336 | { |
| 2337 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2338 | return; |
| 2339 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2340 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2341 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2342 | { |
| 2343 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2344 | return; |
| 2345 | } |
| 2346 | |
| 2347 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 2348 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 2349 | |
| 2350 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 2351 | maxComputeWorkGroupSize->getConstPointer(); |
| 2352 | |
| 2353 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 2354 | { |
| 2355 | if (layoutQualifier.localSize[i] != -1) |
| 2356 | { |
| 2357 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 2358 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 2359 | if (mComputeShaderLocalSize[i] < 1 || |
| 2360 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 2361 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2362 | std::stringstream reasonStream; |
| 2363 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 2364 | << maxComputeWorkGroupSizeValue; |
| 2365 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2366 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2367 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2368 | return; |
| 2369 | } |
| 2370 | } |
| 2371 | } |
| 2372 | |
| 2373 | mComputeShaderLocalSizeDeclared = true; |
| 2374 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2375 | else if (mMultiviewAvailable && |
| 2376 | (isExtensionEnabled("GL_OVR_multiview") || isExtensionEnabled("GL_OVR_multiview2")) && |
| 2377 | typeQualifier.qualifier == EvqVertexIn) |
| 2378 | { |
| 2379 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 2380 | // specification. |
| 2381 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 2382 | { |
| 2383 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 2384 | "layout"); |
| 2385 | return; |
| 2386 | } |
| 2387 | |
| 2388 | if (layoutQualifier.numViews == -1) |
| 2389 | { |
| 2390 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 2391 | return; |
| 2392 | } |
| 2393 | |
| 2394 | if (layoutQualifier.numViews > mMaxNumViews) |
| 2395 | { |
| 2396 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 2397 | "layout"); |
| 2398 | return; |
| 2399 | } |
| 2400 | |
| 2401 | mNumViews = layoutQualifier.numViews; |
| 2402 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2403 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2404 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2405 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2406 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2407 | return; |
| 2408 | } |
| 2409 | |
| 2410 | if (typeQualifier.qualifier != EvqUniform) |
| 2411 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2412 | error(typeQualifier.line, "invalid qualifier: global layout must be uniform", |
| 2413 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2414 | return; |
| 2415 | } |
| 2416 | |
| 2417 | if (mShaderVersion < 300) |
| 2418 | { |
| 2419 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 2420 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2421 | return; |
| 2422 | } |
| 2423 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2424 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2425 | |
| 2426 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 2427 | { |
| 2428 | mDefaultMatrixPacking = layoutQualifier.matrixPacking; |
| 2429 | } |
| 2430 | |
| 2431 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 2432 | { |
| 2433 | mDefaultBlockStorage = layoutQualifier.blockStorage; |
| 2434 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2435 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2436 | } |
| 2437 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2438 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 2439 | const TFunction &function, |
| 2440 | const TSourceLoc &location, |
| 2441 | bool insertParametersToSymbolTable) |
| 2442 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 2443 | TIntermFunctionPrototype *prototype = |
| 2444 | new TIntermFunctionPrototype(function.getReturnType(), TSymbolUniqueId(function)); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2445 | // TODO(oetuaho@nvidia.com): Instead of converting the function information here, the node could |
| 2446 | // point to the data that already exists in the symbol table. |
| 2447 | prototype->getFunctionSymbolInfo()->setFromFunction(function); |
| 2448 | prototype->setLine(location); |
| 2449 | |
| 2450 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 2451 | { |
| 2452 | const TConstParameter ¶m = function.getParam(i); |
| 2453 | |
| 2454 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 2455 | // be used for unused args). |
| 2456 | if (param.name != nullptr) |
| 2457 | { |
| 2458 | TVariable *variable = new TVariable(param.name, *param.type); |
| 2459 | |
| 2460 | // Insert the parameter in the symbol table. |
| 2461 | if (insertParametersToSymbolTable && !symbolTable.declare(variable)) |
| 2462 | { |
| 2463 | error(location, "redefinition", variable->getName().c_str()); |
| 2464 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2465 | continue; |
| 2466 | } |
| 2467 | TIntermSymbol *symbol = intermediate.addSymbol( |
| 2468 | variable->getUniqueId(), variable->getName(), variable->getType(), location); |
| 2469 | prototype->appendParameter(symbol); |
| 2470 | } |
| 2471 | else |
| 2472 | { |
| 2473 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2474 | } |
| 2475 | } |
| 2476 | return prototype; |
| 2477 | } |
| 2478 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 2479 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 2480 | const TFunction &parsedFunction, |
| 2481 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2482 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2483 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 2484 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 2485 | // function is declared multiple times. |
| 2486 | TFunction *function = static_cast<TFunction *>( |
| 2487 | symbolTable.find(parsedFunction.getMangledName(), getShaderVersion())); |
| 2488 | if (function->hasPrototypeDeclaration() && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2489 | { |
| 2490 | // ESSL 1.00.17 section 4.2.7. |
| 2491 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 2492 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2493 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2494 | function->setHasPrototypeDeclaration(); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2495 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2496 | TIntermFunctionPrototype *prototype = |
| 2497 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2498 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2499 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2500 | |
| 2501 | if (!symbolTable.atGlobalLevel()) |
| 2502 | { |
| 2503 | // ESSL 3.00.4 section 4.2.4. |
| 2504 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2505 | } |
| 2506 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2507 | return prototype; |
| 2508 | } |
| 2509 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2510 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2511 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2512 | TIntermBlock *functionBody, |
| 2513 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2514 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2515 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2516 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 2517 | { |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2518 | error(location, "function does not return a value:", |
| 2519 | functionPrototype->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2520 | } |
| 2521 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2522 | if (functionBody == nullptr) |
| 2523 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2524 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2525 | functionBody->setLine(location); |
| 2526 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2527 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2528 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2529 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2530 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2531 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2532 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2533 | } |
| 2534 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2535 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
| 2536 | TFunction **function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2537 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2538 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2539 | ASSERT(function); |
| 2540 | ASSERT(*function); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2541 | const TSymbol *builtIn = |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2542 | symbolTable.findBuiltIn((*function)->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2543 | |
| 2544 | if (builtIn) |
| 2545 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2546 | error(location, "built-in functions cannot be redefined", (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2547 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2548 | else |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2549 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2550 | TFunction *prevDec = static_cast<TFunction *>( |
| 2551 | symbolTable.find((*function)->getMangledName(), getShaderVersion())); |
| 2552 | |
| 2553 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function as it |
| 2554 | // would have just been put in the symbol table. Otherwise, we're looking up an earlier |
| 2555 | // occurance. |
| 2556 | if (*function != prevDec) |
| 2557 | { |
| 2558 | // Swap the parameters of the previous declaration to the parameters of the function |
| 2559 | // definition (parameter names may differ). |
| 2560 | prevDec->swapParameters(**function); |
| 2561 | |
| 2562 | // The function definition will share the same symbol as any previous declaration. |
| 2563 | *function = prevDec; |
| 2564 | } |
| 2565 | |
| 2566 | if ((*function)->isDefined()) |
| 2567 | { |
| 2568 | error(location, "function already has a body", (*function)->getName().c_str()); |
| 2569 | } |
| 2570 | |
| 2571 | (*function)->setDefined(); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2572 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2573 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2574 | // Remember the return type for later checking for return statements. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2575 | mCurrentFunctionType = &((*function)->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2576 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2577 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2578 | *prototypeOut = createPrototypeNodeFromFunction(**function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2579 | setLoopNestingLevel(0); |
| 2580 | } |
| 2581 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2582 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2583 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2584 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2585 | // We don't know at this point whether this is a function definition or a prototype. |
| 2586 | // The definition production code will check for redefinitions. |
| 2587 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2588 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2589 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 2590 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2591 | // |
| 2592 | TFunction *prevDec = |
| 2593 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2594 | |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2595 | if (getShaderVersion() >= 300 && |
| 2596 | symbolTable.hasUnmangledBuiltInForShaderVersion(function->getName().c_str(), |
| 2597 | getShaderVersion())) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2598 | { |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2599 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as functions. |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2600 | // Therefore overloading or redefining builtin functions is an error. |
| 2601 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 2602 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2603 | } |
| 2604 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2605 | { |
| 2606 | if (prevDec->getReturnType() != function->getReturnType()) |
| 2607 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2608 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2609 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2610 | } |
| 2611 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 2612 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2613 | if (prevDec->getParam(i).type->getQualifier() != |
| 2614 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2615 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2616 | error(location, |
| 2617 | "function must have the same parameter qualifiers in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2618 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2619 | } |
| 2620 | } |
| 2621 | } |
| 2622 | |
| 2623 | // |
| 2624 | // Check for previously declared variables using the same name. |
| 2625 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2626 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2627 | if (prevSym) |
| 2628 | { |
| 2629 | if (!prevSym->isFunction()) |
| 2630 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2631 | error(location, "redefinition of a function", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2632 | } |
| 2633 | } |
| 2634 | else |
| 2635 | { |
| 2636 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2637 | symbolTable.getOuterLevel()->insertUnmangled(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2638 | } |
| 2639 | |
| 2640 | // We're at the inner scope level of the function's arguments and body statement. |
| 2641 | // Add the function prototype to the surrounding scope instead. |
| 2642 | symbolTable.getOuterLevel()->insert(function); |
| 2643 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 2644 | // Raise error message if main function takes any parameters or return anything other than void |
| 2645 | if (function->getName() == "main") |
| 2646 | { |
| 2647 | if (function->getParamCount() > 0) |
| 2648 | { |
| 2649 | error(location, "function cannot take any parameter(s)", "main"); |
| 2650 | } |
| 2651 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 2652 | { |
| 2653 | error(location, "main function cannot return a value", |
| 2654 | function->getReturnType().getBasicString()); |
| 2655 | } |
| 2656 | } |
| 2657 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2658 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2659 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 2660 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2661 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 2662 | // |
| 2663 | return function; |
| 2664 | } |
| 2665 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2666 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 2667 | const TString *name, |
| 2668 | const TSourceLoc &location) |
| 2669 | { |
| 2670 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 2671 | { |
| 2672 | error(location, "no qualifiers allowed for function return", |
| 2673 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2674 | } |
| 2675 | if (!type.layoutQualifier.isEmpty()) |
| 2676 | { |
| 2677 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2678 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2679 | // make sure an opaque type is not involved as well... |
| 2680 | std::string reason(getBasicString(type.getBasicType())); |
| 2681 | reason += "s can't be function return values"; |
| 2682 | checkIsNotOpaqueType(location, type.typeSpecifierNonArray, reason.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2683 | if (mShaderVersion < 300) |
| 2684 | { |
| 2685 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 2686 | // return values in ESSL 1.00. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2687 | ASSERT(type.arraySize == 0 || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2688 | |
| 2689 | if (type.isStructureContainingArrays()) |
| 2690 | { |
| 2691 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 2692 | error(location, "structures containing arrays can't be function return values", |
| 2693 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2694 | } |
| 2695 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2696 | |
| 2697 | // Add the function as a prototype after parsing it (we do not support recursion) |
| 2698 | return new TFunction(name, new TType(type)); |
| 2699 | } |
| 2700 | |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2701 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicTypeIn) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2702 | { |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2703 | TPublicType publicType = publicTypeIn; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2704 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2705 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2706 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 2707 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2708 | } |
| 2709 | |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2710 | TOperator op = EOpNull; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2711 | if (publicType.getUserDef()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2712 | { |
| 2713 | op = EOpConstructStruct; |
| 2714 | } |
| 2715 | else |
| 2716 | { |
Geoff Lang | 156d719 | 2016-07-21 16:11:00 -0400 | [diff] [blame] | 2717 | op = sh::TypeToConstructorOperator(TType(publicType)); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2718 | if (op == EOpNull) |
| 2719 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2720 | error(publicType.getLine(), "cannot construct this type", |
| 2721 | getBasicString(publicType.getBasicType())); |
| 2722 | publicType.setBasicType(EbtFloat); |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2723 | op = EOpConstructFloat; |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2724 | } |
| 2725 | } |
| 2726 | |
Dmitry Skiba | 7f17a50 | 2015-06-22 15:08:39 -0700 | [diff] [blame] | 2727 | const TType *type = new TType(publicType); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2728 | return new TFunction(nullptr, type, op); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2729 | } |
| 2730 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2731 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 2732 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2733 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2734 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2735 | // |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2736 | TIntermTyped *TParseContext::addConstructor(TIntermSequence *arguments, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2737 | TOperator op, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2738 | TType type, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2739 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2740 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2741 | if (type.isUnsizedArray()) |
| 2742 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2743 | if (arguments->empty()) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 2744 | { |
| 2745 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 2746 | type.setArraySize(1u); |
| 2747 | return TIntermTyped::CreateZero(type); |
| 2748 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2749 | type.setArraySize(static_cast<unsigned int>(arguments->size())); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2750 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2751 | |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2752 | if (!checkConstructorArguments(line, arguments, op, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2753 | { |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2754 | return TIntermTyped::CreateZero(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2755 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2756 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 2757 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2758 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2759 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2760 | TIntermTyped *constConstructor = |
| 2761 | intermediate.foldAggregateBuiltIn(constructorNode, mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2762 | if (constConstructor) |
| 2763 | { |
| 2764 | return constConstructor; |
| 2765 | } |
| 2766 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2767 | return constructorNode; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2768 | } |
| 2769 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2770 | // |
| 2771 | // Interface/uniform blocks |
| 2772 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2773 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2774 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2775 | const TSourceLoc &nameLine, |
| 2776 | const TString &blockName, |
| 2777 | TFieldList *fieldList, |
| 2778 | const TString *instanceName, |
| 2779 | const TSourceLoc &instanceLine, |
| 2780 | TIntermTyped *arrayIndex, |
| 2781 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2782 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2783 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2784 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2785 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2786 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2787 | if (typeQualifier.qualifier != EvqUniform) |
| 2788 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2789 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform", |
| 2790 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2791 | } |
| 2792 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2793 | if (typeQualifier.invariant) |
| 2794 | { |
| 2795 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 2796 | } |
| 2797 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2798 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 2799 | |
| 2800 | // TODO(oetuaho): Remove this and support binding for blocks. |
| 2801 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2802 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2803 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 2804 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2805 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2806 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2807 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2808 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 2809 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2810 | blockLayoutQualifier.matrixPacking = mDefaultMatrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2811 | } |
| 2812 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2813 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 2814 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2815 | blockLayoutQualifier.blockStorage = mDefaultBlockStorage; |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2816 | } |
| 2817 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2818 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2819 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2820 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 2821 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2822 | TSymbol *blockNameSymbol = new TInterfaceBlockName(&blockName); |
| 2823 | if (!symbolTable.declare(blockNameSymbol)) |
| 2824 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2825 | error(nameLine, "redefinition of an interface block name", blockName.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2826 | } |
| 2827 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2828 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2829 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2830 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2831 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2832 | TType *fieldType = field->type(); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2833 | if (IsOpaqueType(fieldType->getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2834 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 2835 | std::string reason("unsupported type - "); |
| 2836 | reason += fieldType->getBasicString(); |
| 2837 | reason += " types are not allowed in interface blocks"; |
| 2838 | error(field->line(), reason.c_str(), fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2839 | } |
| 2840 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2841 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2842 | switch (qualifier) |
| 2843 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2844 | case EvqGlobal: |
| 2845 | case EvqUniform: |
| 2846 | break; |
| 2847 | default: |
| 2848 | error(field->line(), "invalid qualifier on interface block member", |
| 2849 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2850 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2851 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2852 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2853 | if (fieldType->isInvariant()) |
| 2854 | { |
| 2855 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 2856 | } |
| 2857 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2858 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2859 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2860 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2861 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2862 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2863 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2864 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 2865 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2866 | } |
| 2867 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2868 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2869 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2870 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2871 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2872 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2873 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2874 | warning(field->line(), |
| 2875 | "extraneous layout qualifier: only has an effect on matrix types", |
| 2876 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2877 | } |
| 2878 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2879 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2880 | } |
| 2881 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2882 | // add array index |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2883 | unsigned int arraySize = 0; |
| 2884 | if (arrayIndex != nullptr) |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2885 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2886 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2887 | } |
| 2888 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2889 | TInterfaceBlock *interfaceBlock = |
| 2890 | new TInterfaceBlock(&blockName, fieldList, instanceName, arraySize, blockLayoutQualifier); |
| 2891 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier, |
| 2892 | arraySize); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2893 | |
| 2894 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2895 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2896 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2897 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2898 | { |
| 2899 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2900 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2901 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2902 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2903 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2904 | |
| 2905 | // set parent pointer of the field variable |
| 2906 | fieldType->setInterfaceBlock(interfaceBlock); |
| 2907 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2908 | TVariable *fieldVariable = new TVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2909 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 2910 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2911 | if (!symbolTable.declare(fieldVariable)) |
| 2912 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2913 | error(field->line(), "redefinition of an interface block member name", |
| 2914 | field->name().c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2915 | } |
| 2916 | } |
| 2917 | } |
| 2918 | else |
| 2919 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2920 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 2921 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2922 | // add a symbol for this interface block |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2923 | TVariable *instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2924 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2925 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2926 | if (!symbolTable.declare(instanceTypeDef)) |
| 2927 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2928 | error(instanceLine, "redefinition of an interface block instance name", |
| 2929 | instanceName->c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2930 | } |
| 2931 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2932 | symbolId = instanceTypeDef->getUniqueId(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2933 | symbolName = instanceTypeDef->getName(); |
| 2934 | } |
| 2935 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2936 | TIntermSymbol *blockSymbol = |
| 2937 | intermediate.addSymbol(symbolId, symbolName, interfaceBlockType, typeQualifier.line); |
| 2938 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2939 | declaration->appendDeclarator(blockSymbol); |
| 2940 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2941 | |
| 2942 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2943 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2944 | } |
| 2945 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2946 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2947 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2948 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2949 | |
| 2950 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2951 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2952 | if (mStructNestingLevel > 1) |
| 2953 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2954 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2955 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2956 | } |
| 2957 | |
| 2958 | void TParseContext::exitStructDeclaration() |
| 2959 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2960 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2961 | } |
| 2962 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2963 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2964 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 2965 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2966 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2967 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2968 | } |
| 2969 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2970 | if (field.type()->getBasicType() != EbtStruct) |
| 2971 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2972 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2973 | } |
| 2974 | |
| 2975 | // We're already inside a structure definition at this point, so add |
| 2976 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2977 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 2978 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2979 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2980 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 2981 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2982 | std::string reason = reasonStream.str(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2983 | error(line, reason.c_str(), field.name().c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2984 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2985 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2986 | } |
| 2987 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 2988 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2989 | // Parse an array index expression |
| 2990 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2991 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 2992 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2993 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2994 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2995 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 2996 | { |
| 2997 | if (baseExpression->getAsSymbolNode()) |
| 2998 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2999 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 3000 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3001 | } |
| 3002 | else |
| 3003 | { |
| 3004 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 3005 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3006 | |
| 3007 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 3008 | unionArray->setFConst(0.0f); |
| 3009 | return intermediate.addConstantUnion(unionArray, TType(EbtFloat, EbpHigh, EvqConst), |
| 3010 | location); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3011 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 3012 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 3013 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 3014 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3015 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 3016 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 3017 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 3018 | // index is a constant expression. |
| 3019 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 3020 | { |
| 3021 | if (baseExpression->isInterfaceBlock()) |
| 3022 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3023 | error(location, |
| 3024 | "array indexes for interface blocks arrays must be constant integral expressions", |
| 3025 | "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3026 | } |
| 3027 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 3028 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3029 | error(location, |
| 3030 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3031 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3032 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3033 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3034 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3035 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3036 | } |
| 3037 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3038 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3039 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3040 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3041 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3042 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3043 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3044 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3045 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3046 | int index = indexConstantUnion->getIConst(0); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3047 | |
| 3048 | int safeIndex = -1; |
| 3049 | |
| 3050 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3051 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3052 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3053 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3054 | if (mShaderSpec == SH_WEBGL2_SPEC) |
| 3055 | { |
| 3056 | // Error has been already generated if index is not const. |
| 3057 | if (indexExpression->getQualifier() == EvqConst) |
| 3058 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3059 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3060 | } |
| 3061 | safeIndex = 0; |
| 3062 | } |
| 3063 | else if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
| 3064 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3065 | outOfRangeError(outOfRangeIndexIsError, location, |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3066 | "array index for gl_FragData must be zero when " |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3067 | "GL_EXT_draw_buffers is disabled", |
| 3068 | "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3069 | safeIndex = 0; |
| 3070 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3071 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3072 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 3073 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3074 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3075 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3076 | baseExpression->getArraySize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3077 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3078 | } |
| 3079 | } |
| 3080 | else if (baseExpression->isMatrix()) |
| 3081 | { |
| 3082 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3083 | baseExpression->getType().getCols(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3084 | "matrix field selection out of range"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3085 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3086 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3087 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3088 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3089 | baseExpression->getType().getNominalSize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3090 | "vector field selection out of range"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3091 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3092 | |
| 3093 | ASSERT(safeIndex >= 0); |
| 3094 | // Data of constant unions can't be changed, because it may be shared with other |
| 3095 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 3096 | // sanitized object. |
| 3097 | if (safeIndex != index) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3098 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3099 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 3100 | safeConstantUnion->setIConst(safeIndex); |
| 3101 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3102 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3103 | |
| 3104 | return intermediate.addIndex(EOpIndexDirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3105 | mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3106 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3107 | else |
| 3108 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3109 | return intermediate.addIndex(EOpIndexIndirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3110 | mDiagnostics); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3111 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3112 | } |
| 3113 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3114 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 3115 | const TSourceLoc &location, |
| 3116 | int index, |
| 3117 | int arraySize, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3118 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3119 | { |
| 3120 | if (index >= arraySize || index < 0) |
| 3121 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3122 | std::stringstream reasonStream; |
| 3123 | reasonStream << reason << " '" << index << "'"; |
| 3124 | std::string token = reasonStream.str(); |
| 3125 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3126 | if (index < 0) |
| 3127 | { |
| 3128 | return 0; |
| 3129 | } |
| 3130 | else |
| 3131 | { |
| 3132 | return arraySize - 1; |
| 3133 | } |
| 3134 | } |
| 3135 | return index; |
| 3136 | } |
| 3137 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3138 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 3139 | const TSourceLoc &dotLocation, |
| 3140 | const TString &fieldString, |
| 3141 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3142 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3143 | if (baseExpression->isArray()) |
| 3144 | { |
| 3145 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3146 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3147 | } |
| 3148 | |
| 3149 | if (baseExpression->isVector()) |
| 3150 | { |
| 3151 | TVectorFields fields; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3152 | if (!parseVectorFields(fieldString, baseExpression->getNominalSize(), fields, |
| 3153 | fieldLocation)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3154 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3155 | fields.num = 1; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3156 | fields.offsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3157 | } |
| 3158 | |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 3159 | return TIntermediate::AddSwizzle(baseExpression, fields, dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3160 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3161 | else if (baseExpression->getBasicType() == EbtStruct) |
| 3162 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3163 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3164 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3165 | { |
| 3166 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3167 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3168 | } |
| 3169 | else |
| 3170 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3171 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3172 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3173 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3174 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3175 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3176 | { |
| 3177 | fieldFound = true; |
| 3178 | break; |
| 3179 | } |
| 3180 | } |
| 3181 | if (fieldFound) |
| 3182 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3183 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3184 | index->setLine(fieldLocation); |
| 3185 | return intermediate.addIndex(EOpIndexDirectStruct, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3186 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3187 | } |
| 3188 | else |
| 3189 | { |
| 3190 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3191 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3192 | } |
| 3193 | } |
| 3194 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3195 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3196 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3197 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3198 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3199 | { |
| 3200 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3201 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3202 | } |
| 3203 | else |
| 3204 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3205 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3206 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3207 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3208 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3209 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3210 | { |
| 3211 | fieldFound = true; |
| 3212 | break; |
| 3213 | } |
| 3214 | } |
| 3215 | if (fieldFound) |
| 3216 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3217 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3218 | index->setLine(fieldLocation); |
| 3219 | return intermediate.addIndex(EOpIndexDirectInterfaceBlock, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3220 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3221 | } |
| 3222 | else |
| 3223 | { |
| 3224 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3225 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3226 | } |
| 3227 | } |
| 3228 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3229 | else |
| 3230 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3231 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3232 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3233 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3234 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3235 | } |
| 3236 | else |
| 3237 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3238 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3239 | " field selection requires structure, vector, or interface block on left hand " |
| 3240 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3241 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3242 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3243 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3244 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3245 | } |
| 3246 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3247 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3248 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3249 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3250 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3251 | |
| 3252 | if (qualifierType == "shared") |
| 3253 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3254 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3255 | { |
| 3256 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 3257 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3258 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3259 | } |
| 3260 | else if (qualifierType == "packed") |
| 3261 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3262 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3263 | { |
| 3264 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 3265 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3266 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3267 | } |
| 3268 | else if (qualifierType == "std140") |
| 3269 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3270 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3271 | } |
| 3272 | else if (qualifierType == "row_major") |
| 3273 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3274 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3275 | } |
| 3276 | else if (qualifierType == "column_major") |
| 3277 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3278 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3279 | } |
| 3280 | else if (qualifierType == "location") |
| 3281 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3282 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
| 3283 | qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3284 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3285 | else if (qualifierType == "yuv" && isExtensionEnabled("GL_EXT_YUV_target") && |
| 3286 | mShaderType == GL_FRAGMENT_SHADER) |
| 3287 | { |
| 3288 | qualifier.yuv = true; |
| 3289 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3290 | else if (qualifierType == "rgba32f") |
| 3291 | { |
| 3292 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3293 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 3294 | } |
| 3295 | else if (qualifierType == "rgba16f") |
| 3296 | { |
| 3297 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3298 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 3299 | } |
| 3300 | else if (qualifierType == "r32f") |
| 3301 | { |
| 3302 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3303 | qualifier.imageInternalFormat = EiifR32F; |
| 3304 | } |
| 3305 | else if (qualifierType == "rgba8") |
| 3306 | { |
| 3307 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3308 | qualifier.imageInternalFormat = EiifRGBA8; |
| 3309 | } |
| 3310 | else if (qualifierType == "rgba8_snorm") |
| 3311 | { |
| 3312 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3313 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 3314 | } |
| 3315 | else if (qualifierType == "rgba32i") |
| 3316 | { |
| 3317 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3318 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 3319 | } |
| 3320 | else if (qualifierType == "rgba16i") |
| 3321 | { |
| 3322 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3323 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 3324 | } |
| 3325 | else if (qualifierType == "rgba8i") |
| 3326 | { |
| 3327 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3328 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 3329 | } |
| 3330 | else if (qualifierType == "r32i") |
| 3331 | { |
| 3332 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3333 | qualifier.imageInternalFormat = EiifR32I; |
| 3334 | } |
| 3335 | else if (qualifierType == "rgba32ui") |
| 3336 | { |
| 3337 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3338 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 3339 | } |
| 3340 | else if (qualifierType == "rgba16ui") |
| 3341 | { |
| 3342 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3343 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 3344 | } |
| 3345 | else if (qualifierType == "rgba8ui") |
| 3346 | { |
| 3347 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3348 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 3349 | } |
| 3350 | else if (qualifierType == "r32ui") |
| 3351 | { |
| 3352 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3353 | qualifier.imageInternalFormat = EiifR32UI; |
| 3354 | } |
| 3355 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3356 | else |
| 3357 | { |
| 3358 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3359 | } |
| 3360 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3361 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3362 | } |
| 3363 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3364 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 3365 | const TSourceLoc &qualifierTypeLine, |
| 3366 | int intValue, |
| 3367 | const TSourceLoc &intValueLine, |
| 3368 | const std::string &intValueString, |
| 3369 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3370 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3371 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3372 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3373 | if (intValue < 1) |
| 3374 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3375 | std::stringstream reasonStream; |
| 3376 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 3377 | std::string reason = reasonStream.str(); |
| 3378 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3379 | } |
| 3380 | (*localSize)[index] = intValue; |
| 3381 | } |
| 3382 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3383 | void TParseContext::parseNumViews(int intValue, |
| 3384 | const TSourceLoc &intValueLine, |
| 3385 | const std::string &intValueString, |
| 3386 | int *numViews) |
| 3387 | { |
| 3388 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 3389 | // specification. |
| 3390 | if (intValue < 1) |
| 3391 | { |
| 3392 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 3393 | } |
| 3394 | *numViews = intValue; |
| 3395 | } |
| 3396 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3397 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3398 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3399 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3400 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3401 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3402 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3403 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3404 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3405 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3406 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3407 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 3408 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3409 | if (intValue < 0) |
| 3410 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3411 | error(intValueLine, "out of range: location must be non-negative", |
| 3412 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3413 | } |
| 3414 | else |
| 3415 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3416 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 3417 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3418 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3419 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3420 | else if (qualifierType == "binding") |
| 3421 | { |
| 3422 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3423 | if (intValue < 0) |
| 3424 | { |
| 3425 | error(intValueLine, "out of range: binding must be non-negative", |
| 3426 | intValueString.c_str()); |
| 3427 | } |
| 3428 | else |
| 3429 | { |
| 3430 | qualifier.binding = intValue; |
| 3431 | } |
| 3432 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3433 | else if (qualifierType == "local_size_x") |
| 3434 | { |
| 3435 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 3436 | &qualifier.localSize); |
| 3437 | } |
| 3438 | else if (qualifierType == "local_size_y") |
| 3439 | { |
| 3440 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 3441 | &qualifier.localSize); |
| 3442 | } |
| 3443 | else if (qualifierType == "local_size_z") |
| 3444 | { |
| 3445 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 3446 | &qualifier.localSize); |
| 3447 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3448 | else if (qualifierType == "num_views" && mMultiviewAvailable && |
| 3449 | (isExtensionEnabled("GL_OVR_multiview") || isExtensionEnabled("GL_OVR_multiview2")) && |
| 3450 | mShaderType == GL_VERTEX_SHADER) |
| 3451 | { |
| 3452 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 3453 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3454 | else |
| 3455 | { |
| 3456 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3457 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3458 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3459 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3460 | } |
| 3461 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 3462 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 3463 | { |
| 3464 | return new TTypeQualifierBuilder( |
| 3465 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 3466 | mShaderVersion); |
| 3467 | } |
| 3468 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3469 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3470 | TLayoutQualifier rightQualifier, |
| 3471 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3472 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3473 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3474 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3475 | } |
| 3476 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3477 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 3478 | const TFieldList *newlyAddedFields, |
| 3479 | const TSourceLoc &location) |
| 3480 | { |
| 3481 | for (TField *field : *newlyAddedFields) |
| 3482 | { |
| 3483 | for (TField *oldField : *processedFields) |
| 3484 | { |
| 3485 | if (oldField->name() == field->name()) |
| 3486 | { |
| 3487 | error(location, "duplicate field name in structure", field->name().c_str()); |
| 3488 | } |
| 3489 | } |
| 3490 | processedFields->push_back(field); |
| 3491 | } |
| 3492 | return processedFields; |
| 3493 | } |
| 3494 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3495 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 3496 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3497 | TPublicType *typeSpecifier, |
| 3498 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3499 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3500 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3501 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3502 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 3503 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3504 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3505 | typeSpecifier->invariant = typeQualifier.invariant; |
| 3506 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3507 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3508 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3509 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3510 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3511 | } |
| 3512 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3513 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
| 3514 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3515 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3516 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 3517 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3518 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3519 | checkIsNonVoid(typeSpecifier.getLine(), (*fieldList)[0]->name(), typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3520 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3521 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3522 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3523 | for (unsigned int i = 0; i < fieldList->size(); ++i) |
| 3524 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3525 | // |
| 3526 | // Careful not to replace already known aspects of type, like array-ness |
| 3527 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3528 | TType *type = (*fieldList)[i]->type(); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3529 | type->setBasicType(typeSpecifier.getBasicType()); |
| 3530 | type->setPrimarySize(typeSpecifier.getPrimarySize()); |
| 3531 | type->setSecondarySize(typeSpecifier.getSecondarySize()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3532 | type->setPrecision(typeSpecifier.precision); |
| 3533 | type->setQualifier(typeSpecifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3534 | type->setLayoutQualifier(typeSpecifier.layoutQualifier); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3535 | type->setMemoryQualifier(typeSpecifier.memoryQualifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3536 | type->setInvariant(typeSpecifier.invariant); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3537 | |
| 3538 | // don't allow arrays of arrays |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3539 | if (type->isArray()) |
| 3540 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3541 | checkIsValidTypeForArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3542 | } |
| 3543 | if (typeSpecifier.array) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3544 | type->setArraySize(static_cast<unsigned int>(typeSpecifier.arraySize)); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3545 | if (typeSpecifier.getUserDef()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3546 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3547 | type->setStruct(typeSpecifier.getUserDef()->getStruct()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3548 | } |
| 3549 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3550 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*fieldList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3551 | } |
| 3552 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3553 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3554 | } |
| 3555 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3556 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 3557 | const TSourceLoc &nameLine, |
| 3558 | const TString *structName, |
| 3559 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3560 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3561 | TStructure *structure = new TStructure(structName, fieldList); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3562 | TType *structureType = new TType(structure); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3563 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3564 | // Store a bool in the struct if we're at global scope, to allow us to |
| 3565 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3566 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 3567 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3568 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3569 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3570 | checkIsNotReserved(nameLine, *structName); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3571 | TVariable *userTypeDef = new TVariable(structName, *structureType, true); |
| 3572 | if (!symbolTable.declare(userTypeDef)) |
| 3573 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3574 | error(nameLine, "redefinition of a struct", structName->c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3575 | } |
| 3576 | } |
| 3577 | |
| 3578 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3579 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3580 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3581 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3582 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3583 | switch (qualifier) |
| 3584 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3585 | case EvqGlobal: |
| 3586 | case EvqTemporary: |
| 3587 | break; |
| 3588 | default: |
| 3589 | error(field.line(), "invalid qualifier on struct member", |
| 3590 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3591 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3592 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3593 | if (field.type()->isInvariant()) |
| 3594 | { |
| 3595 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 3596 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3597 | if (IsImage(field.type()->getBasicType())) |
| 3598 | { |
| 3599 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 3600 | } |
| 3601 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3602 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 3603 | |
| 3604 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3605 | |
| 3606 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3607 | } |
| 3608 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3609 | TTypeSpecifierNonArray typeSpecifierNonArray; |
| 3610 | typeSpecifierNonArray.initialize(EbtStruct, structLine); |
| 3611 | typeSpecifierNonArray.userDef = structureType; |
| 3612 | typeSpecifierNonArray.isStructSpecifier = true; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3613 | exitStructDeclaration(); |
| 3614 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3615 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3616 | } |
| 3617 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3618 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3619 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3620 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3621 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3622 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3623 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3624 | init->isVector()) |
| 3625 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3626 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 3627 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3628 | return nullptr; |
| 3629 | } |
| 3630 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3631 | if (statementList) |
| 3632 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3633 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3634 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3635 | return nullptr; |
| 3636 | } |
| 3637 | } |
| 3638 | |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3639 | TIntermSwitch *node = intermediate.addSwitch(init, statementList, loc); |
| 3640 | if (node == nullptr) |
| 3641 | { |
| 3642 | error(loc, "erroneous switch statement", "switch"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3643 | return nullptr; |
| 3644 | } |
| 3645 | return node; |
| 3646 | } |
| 3647 | |
| 3648 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 3649 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3650 | if (mSwitchNestingLevel == 0) |
| 3651 | { |
| 3652 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3653 | return nullptr; |
| 3654 | } |
| 3655 | if (condition == nullptr) |
| 3656 | { |
| 3657 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3658 | return nullptr; |
| 3659 | } |
| 3660 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3661 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3662 | { |
| 3663 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3664 | } |
| 3665 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3666 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 3667 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 3668 | // fold in case labels. |
| 3669 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3670 | { |
| 3671 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3672 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3673 | TIntermCase *node = intermediate.addCase(condition, loc); |
| 3674 | if (node == nullptr) |
| 3675 | { |
| 3676 | error(loc, "erroneous case statement", "case"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3677 | return nullptr; |
| 3678 | } |
| 3679 | return node; |
| 3680 | } |
| 3681 | |
| 3682 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 3683 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3684 | if (mSwitchNestingLevel == 0) |
| 3685 | { |
| 3686 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3687 | return nullptr; |
| 3688 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3689 | TIntermCase *node = intermediate.addCase(nullptr, loc); |
| 3690 | if (node == nullptr) |
| 3691 | { |
| 3692 | error(loc, "erroneous default statement", "default"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3693 | return nullptr; |
| 3694 | } |
| 3695 | return node; |
| 3696 | } |
| 3697 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3698 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 3699 | TIntermTyped *child, |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3700 | const TSourceLoc &loc) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3701 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3702 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3703 | |
| 3704 | switch (op) |
| 3705 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3706 | case EOpLogicalNot: |
| 3707 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 3708 | child->isVector()) |
| 3709 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3710 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3711 | return nullptr; |
| 3712 | } |
| 3713 | break; |
| 3714 | case EOpBitwiseNot: |
| 3715 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 3716 | child->isMatrix() || child->isArray()) |
| 3717 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3718 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3719 | return nullptr; |
| 3720 | } |
| 3721 | break; |
| 3722 | case EOpPostIncrement: |
| 3723 | case EOpPreIncrement: |
| 3724 | case EOpPostDecrement: |
| 3725 | case EOpPreDecrement: |
| 3726 | case EOpNegative: |
| 3727 | case EOpPositive: |
| 3728 | if (child->getBasicType() == EbtStruct || child->getBasicType() == EbtBool || |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3729 | child->isArray() || IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3730 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3731 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3732 | return nullptr; |
| 3733 | } |
| 3734 | // Operators for built-ins are already type checked against their prototype. |
| 3735 | default: |
| 3736 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3737 | } |
| 3738 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3739 | TIntermUnary *node = new TIntermUnary(op, child); |
| 3740 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3741 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3742 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3743 | if (foldedNode) |
| 3744 | return foldedNode; |
| 3745 | |
| 3746 | return node; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3747 | } |
| 3748 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3749 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 3750 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3751 | TIntermTyped *node = createUnaryMath(op, child, loc); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3752 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3753 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3754 | return child; |
| 3755 | } |
| 3756 | return node; |
| 3757 | } |
| 3758 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3759 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 3760 | TIntermTyped *child, |
| 3761 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3762 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3763 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3764 | return addUnaryMath(op, child, loc); |
| 3765 | } |
| 3766 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3767 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 3768 | TIntermTyped *left, |
| 3769 | TIntermTyped *right, |
| 3770 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3771 | { |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 3772 | // Check opaque types are not allowed to be operands in expressions other than array indexing |
| 3773 | // and structure member selection. |
| 3774 | if (IsOpaqueType(left->getBasicType()) || IsOpaqueType(right->getBasicType())) |
| 3775 | { |
| 3776 | switch (op) |
| 3777 | { |
| 3778 | case EOpIndexDirect: |
| 3779 | case EOpIndexIndirect: |
| 3780 | break; |
| 3781 | case EOpIndexDirectStruct: |
| 3782 | UNREACHABLE(); |
| 3783 | |
| 3784 | default: |
| 3785 | error(loc, "Invalid operation for variables with an opaque type", |
| 3786 | GetOperatorString(op)); |
| 3787 | return false; |
| 3788 | } |
| 3789 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3790 | |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3791 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 3792 | { |
| 3793 | switch (op) |
| 3794 | { |
| 3795 | case EOpIndexDirectStruct: |
| 3796 | ASSERT(left->getType().getStruct()); |
| 3797 | break; |
| 3798 | case EOpEqual: |
| 3799 | case EOpNotEqual: |
| 3800 | case EOpAssign: |
| 3801 | case EOpInitialize: |
| 3802 | if (left->getType() != right->getType()) |
| 3803 | { |
| 3804 | return false; |
| 3805 | } |
| 3806 | break; |
| 3807 | default: |
| 3808 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 3809 | return false; |
| 3810 | } |
| 3811 | } |
| 3812 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3813 | if (left->isArray() || right->isArray()) |
| 3814 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3815 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3816 | { |
| 3817 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3818 | return false; |
| 3819 | } |
| 3820 | |
| 3821 | if (left->isArray() != right->isArray()) |
| 3822 | { |
| 3823 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 3824 | return false; |
| 3825 | } |
| 3826 | |
| 3827 | switch (op) |
| 3828 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3829 | case EOpEqual: |
| 3830 | case EOpNotEqual: |
| 3831 | case EOpAssign: |
| 3832 | case EOpInitialize: |
| 3833 | break; |
| 3834 | default: |
| 3835 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3836 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3837 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 3838 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3839 | if (left->getArraySize() != right->getArraySize()) |
| 3840 | { |
| 3841 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 3842 | return false; |
| 3843 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3844 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3845 | |
| 3846 | // Check ops which require integer / ivec parameters |
| 3847 | bool isBitShift = false; |
| 3848 | switch (op) |
| 3849 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3850 | case EOpBitShiftLeft: |
| 3851 | case EOpBitShiftRight: |
| 3852 | case EOpBitShiftLeftAssign: |
| 3853 | case EOpBitShiftRightAssign: |
| 3854 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 3855 | // check that the basic type is an integer type. |
| 3856 | isBitShift = true; |
| 3857 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 3858 | { |
| 3859 | return false; |
| 3860 | } |
| 3861 | break; |
| 3862 | case EOpBitwiseAnd: |
| 3863 | case EOpBitwiseXor: |
| 3864 | case EOpBitwiseOr: |
| 3865 | case EOpBitwiseAndAssign: |
| 3866 | case EOpBitwiseXorAssign: |
| 3867 | case EOpBitwiseOrAssign: |
| 3868 | // It is enough to check the type of only one operand, since later it |
| 3869 | // is checked that the operand types match. |
| 3870 | if (!IsInteger(left->getBasicType())) |
| 3871 | { |
| 3872 | return false; |
| 3873 | } |
| 3874 | break; |
| 3875 | default: |
| 3876 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3877 | } |
| 3878 | |
| 3879 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 3880 | // So the basic type should usually match. |
| 3881 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 3882 | { |
| 3883 | return false; |
| 3884 | } |
| 3885 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3886 | // Check that: |
| 3887 | // 1. Type sizes match exactly on ops that require that. |
| 3888 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 3889 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3890 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3891 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3892 | case EOpAssign: |
| 3893 | case EOpInitialize: |
| 3894 | case EOpEqual: |
| 3895 | case EOpNotEqual: |
| 3896 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 3897 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 3898 | { |
| 3899 | error(loc, "undefined operation for structs containing arrays", |
| 3900 | GetOperatorString(op)); |
| 3901 | return false; |
| 3902 | } |
| 3903 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 3904 | // we interpret the spec so that this extends to structs containing samplers, |
| 3905 | // similarly to ESSL 1.00 spec. |
| 3906 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 3907 | left->getType().isStructureContainingSamplers()) |
| 3908 | { |
| 3909 | error(loc, "undefined operation for structs containing samplers", |
| 3910 | GetOperatorString(op)); |
| 3911 | return false; |
| 3912 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3913 | |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3914 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 3915 | (left->getSecondarySize() != right->getSecondarySize())) |
| 3916 | { |
| 3917 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 3918 | return false; |
| 3919 | } |
| 3920 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3921 | case EOpLessThan: |
| 3922 | case EOpGreaterThan: |
| 3923 | case EOpLessThanEqual: |
| 3924 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3925 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3926 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3927 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3928 | return false; |
| 3929 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3930 | break; |
| 3931 | case EOpAdd: |
| 3932 | case EOpSub: |
| 3933 | case EOpDiv: |
| 3934 | case EOpIMod: |
| 3935 | case EOpBitShiftLeft: |
| 3936 | case EOpBitShiftRight: |
| 3937 | case EOpBitwiseAnd: |
| 3938 | case EOpBitwiseXor: |
| 3939 | case EOpBitwiseOr: |
| 3940 | case EOpAddAssign: |
| 3941 | case EOpSubAssign: |
| 3942 | case EOpDivAssign: |
| 3943 | case EOpIModAssign: |
| 3944 | case EOpBitShiftLeftAssign: |
| 3945 | case EOpBitShiftRightAssign: |
| 3946 | case EOpBitwiseAndAssign: |
| 3947 | case EOpBitwiseXorAssign: |
| 3948 | case EOpBitwiseOrAssign: |
| 3949 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 3950 | { |
| 3951 | return false; |
| 3952 | } |
| 3953 | |
| 3954 | // Are the sizes compatible? |
| 3955 | if (left->getNominalSize() != right->getNominalSize() || |
| 3956 | left->getSecondarySize() != right->getSecondarySize()) |
| 3957 | { |
| 3958 | // If the nominal sizes of operands do not match: |
| 3959 | // One of them must be a scalar. |
| 3960 | if (!left->isScalar() && !right->isScalar()) |
| 3961 | return false; |
| 3962 | |
| 3963 | // In the case of compound assignment other than multiply-assign, |
| 3964 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 3965 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 3966 | // vector either. |
| 3967 | if (!right->isScalar() && |
| 3968 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 3969 | return false; |
| 3970 | } |
| 3971 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3972 | default: |
| 3973 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3974 | } |
| 3975 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3976 | return true; |
| 3977 | } |
| 3978 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3979 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 3980 | const TType &left, |
| 3981 | const TType &right) |
| 3982 | { |
| 3983 | switch (op) |
| 3984 | { |
| 3985 | case EOpMul: |
| 3986 | case EOpMulAssign: |
| 3987 | return left.getNominalSize() == right.getNominalSize() && |
| 3988 | left.getSecondarySize() == right.getSecondarySize(); |
| 3989 | case EOpVectorTimesScalar: |
| 3990 | return true; |
| 3991 | case EOpVectorTimesScalarAssign: |
| 3992 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 3993 | return left.isVector() && !right.isVector(); |
| 3994 | case EOpVectorTimesMatrix: |
| 3995 | return left.getNominalSize() == right.getRows(); |
| 3996 | case EOpVectorTimesMatrixAssign: |
| 3997 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 3998 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 3999 | left.getNominalSize() == right.getCols(); |
| 4000 | case EOpMatrixTimesVector: |
| 4001 | return left.getCols() == right.getNominalSize(); |
| 4002 | case EOpMatrixTimesScalar: |
| 4003 | return true; |
| 4004 | case EOpMatrixTimesScalarAssign: |
| 4005 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 4006 | return !right.isVector(); |
| 4007 | case EOpMatrixTimesMatrix: |
| 4008 | return left.getCols() == right.getRows(); |
| 4009 | case EOpMatrixTimesMatrixAssign: |
| 4010 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 4011 | // We need to check two things: |
| 4012 | // 1. The matrix multiplication step is valid. |
| 4013 | // 2. The result will have the same number of columns as the lvalue. |
| 4014 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 4015 | |
| 4016 | default: |
| 4017 | UNREACHABLE(); |
| 4018 | return false; |
| 4019 | } |
| 4020 | } |
| 4021 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4022 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 4023 | TIntermTyped *left, |
| 4024 | TIntermTyped *right, |
| 4025 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4026 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4027 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4028 | return nullptr; |
| 4029 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4030 | switch (op) |
| 4031 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4032 | case EOpEqual: |
| 4033 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4034 | case EOpLessThan: |
| 4035 | case EOpGreaterThan: |
| 4036 | case EOpLessThanEqual: |
| 4037 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4038 | break; |
| 4039 | case EOpLogicalOr: |
| 4040 | case EOpLogicalXor: |
| 4041 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4042 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4043 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4044 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4045 | { |
| 4046 | return nullptr; |
| 4047 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4048 | // Basic types matching should have been already checked. |
| 4049 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4050 | break; |
| 4051 | case EOpAdd: |
| 4052 | case EOpSub: |
| 4053 | case EOpDiv: |
| 4054 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4055 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4056 | !right->getType().getStruct()); |
| 4057 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4058 | { |
| 4059 | return nullptr; |
| 4060 | } |
| 4061 | break; |
| 4062 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4063 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4064 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4065 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4066 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4067 | { |
| 4068 | return nullptr; |
| 4069 | } |
| 4070 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4071 | default: |
| 4072 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4073 | } |
| 4074 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4075 | if (op == EOpMul) |
| 4076 | { |
| 4077 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 4078 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4079 | { |
| 4080 | return nullptr; |
| 4081 | } |
| 4082 | } |
| 4083 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4084 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4085 | node->setLine(loc); |
| 4086 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4087 | // See if we can fold constants. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4088 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4089 | if (foldedNode) |
| 4090 | return foldedNode; |
| 4091 | |
| 4092 | return node; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4093 | } |
| 4094 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4095 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 4096 | TIntermTyped *left, |
| 4097 | TIntermTyped *right, |
| 4098 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4099 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4100 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4101 | if (node == 0) |
| 4102 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4103 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4104 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4105 | return left; |
| 4106 | } |
| 4107 | return node; |
| 4108 | } |
| 4109 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4110 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 4111 | TIntermTyped *left, |
| 4112 | TIntermTyped *right, |
| 4113 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4114 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4115 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4116 | if (node == 0) |
| 4117 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4118 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4119 | right->getCompleteString()); |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 4120 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4121 | unionArray->setBConst(false); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4122 | return intermediate.addConstantUnion(unionArray, TType(EbtBool, EbpUndefined, EvqConst), |
| 4123 | loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4124 | } |
| 4125 | return node; |
| 4126 | } |
| 4127 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 4128 | TIntermBinary *TParseContext::createAssign(TOperator op, |
| 4129 | TIntermTyped *left, |
| 4130 | TIntermTyped *right, |
| 4131 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4132 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4133 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4134 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4135 | if (op == EOpMulAssign) |
| 4136 | { |
| 4137 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 4138 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4139 | { |
| 4140 | return nullptr; |
| 4141 | } |
| 4142 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4143 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4144 | node->setLine(loc); |
| 4145 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4146 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4147 | } |
| 4148 | return nullptr; |
| 4149 | } |
| 4150 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4151 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 4152 | TIntermTyped *left, |
| 4153 | TIntermTyped *right, |
| 4154 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4155 | { |
| 4156 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 4157 | if (node == nullptr) |
| 4158 | { |
| 4159 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4160 | return left; |
| 4161 | } |
| 4162 | return node; |
| 4163 | } |
| 4164 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4165 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 4166 | TIntermTyped *right, |
| 4167 | const TSourceLoc &loc) |
| 4168 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4169 | // WebGL2 section 5.26, the following results in an error: |
| 4170 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4171 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 4172 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 4173 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 4174 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4175 | { |
| 4176 | error(loc, |
| 4177 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 4178 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4179 | } |
| 4180 | |
Olli Etuaho | 4db7ded | 2016-10-13 12:23:11 +0100 | [diff] [blame] | 4181 | return TIntermediate::AddComma(left, right, loc, mShaderVersion); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4182 | } |
| 4183 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4184 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 4185 | { |
| 4186 | switch (op) |
| 4187 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4188 | case EOpContinue: |
| 4189 | if (mLoopNestingLevel <= 0) |
| 4190 | { |
| 4191 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4192 | } |
| 4193 | break; |
| 4194 | case EOpBreak: |
| 4195 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 4196 | { |
| 4197 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4198 | } |
| 4199 | break; |
| 4200 | case EOpReturn: |
| 4201 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 4202 | { |
| 4203 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4204 | } |
| 4205 | break; |
| 4206 | default: |
| 4207 | // No checks for discard |
| 4208 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4209 | } |
| 4210 | return intermediate.addBranch(op, loc); |
| 4211 | } |
| 4212 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4213 | TIntermBranch *TParseContext::addBranch(TOperator op, |
| 4214 | TIntermTyped *returnValue, |
| 4215 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4216 | { |
| 4217 | ASSERT(op == EOpReturn); |
| 4218 | mFunctionReturnsValue = true; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4219 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4220 | { |
| 4221 | error(loc, "void function cannot return a value", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4222 | } |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4223 | else if (*mCurrentFunctionType != returnValue->getType()) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4224 | { |
| 4225 | error(loc, "function return is not matching type:", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4226 | } |
| 4227 | return intermediate.addBranch(op, returnValue, loc); |
| 4228 | } |
| 4229 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4230 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 4231 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4232 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4233 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4234 | TIntermNode *offset = nullptr; |
| 4235 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4236 | if (name == "texelFetchOffset" || name == "textureLodOffset" || |
| 4237 | name == "textureProjLodOffset" || name == "textureGradOffset" || |
| 4238 | name == "textureProjGradOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4239 | { |
| 4240 | offset = arguments->back(); |
| 4241 | } |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4242 | else if (name == "textureOffset" || name == "textureProjOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4243 | { |
| 4244 | // A bias parameter might follow the offset parameter. |
| 4245 | ASSERT(arguments->size() >= 3); |
| 4246 | offset = (*arguments)[2]; |
| 4247 | } |
| 4248 | if (offset != nullptr) |
| 4249 | { |
| 4250 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 4251 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 4252 | { |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4253 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4254 | name.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4255 | } |
| 4256 | else |
| 4257 | { |
| 4258 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 4259 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 4260 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 4261 | for (size_t i = 0u; i < size; ++i) |
| 4262 | { |
| 4263 | int offsetValue = values[i].getIConst(); |
| 4264 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 4265 | { |
| 4266 | std::stringstream tokenStream; |
| 4267 | tokenStream << offsetValue; |
| 4268 | std::string token = tokenStream.str(); |
| 4269 | error(offset->getLine(), "Texture offset value out of valid range", |
| 4270 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4271 | } |
| 4272 | } |
| 4273 | } |
| 4274 | } |
| 4275 | } |
| 4276 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4277 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 4278 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 4279 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4280 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4281 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
| 4282 | |
| 4283 | if (name.compare(0, 5, "image") == 0) |
| 4284 | { |
| 4285 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4286 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4287 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4288 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4289 | |
| 4290 | if (name.compare(5, 5, "Store") == 0) |
| 4291 | { |
| 4292 | if (memoryQualifier.readonly) |
| 4293 | { |
| 4294 | error(imageNode->getLine(), |
| 4295 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4296 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4297 | } |
| 4298 | } |
| 4299 | else if (name.compare(5, 4, "Load") == 0) |
| 4300 | { |
| 4301 | if (memoryQualifier.writeonly) |
| 4302 | { |
| 4303 | error(imageNode->getLine(), |
| 4304 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4305 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4306 | } |
| 4307 | } |
| 4308 | } |
| 4309 | } |
| 4310 | |
| 4311 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 4312 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 4313 | const TFunction *functionDefinition, |
| 4314 | const TIntermAggregate *functionCall) |
| 4315 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4316 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4317 | |
| 4318 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 4319 | |
| 4320 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 4321 | |
| 4322 | for (size_t i = 0; i < arguments.size(); ++i) |
| 4323 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4324 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 4325 | const TType &functionArgumentType = typedArgument->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4326 | const TType &functionParameterType = *functionDefinition->getParam(i).type; |
| 4327 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 4328 | |
| 4329 | if (IsImage(functionArgumentType.getBasicType())) |
| 4330 | { |
| 4331 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 4332 | functionArgumentType.getMemoryQualifier(); |
| 4333 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 4334 | functionParameterType.getMemoryQualifier(); |
| 4335 | if (functionArgumentMemoryQualifier.readonly && |
| 4336 | !functionParameterMemoryQualifier.readonly) |
| 4337 | { |
| 4338 | error(functionCall->getLine(), |
| 4339 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4340 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4341 | } |
| 4342 | |
| 4343 | if (functionArgumentMemoryQualifier.writeonly && |
| 4344 | !functionParameterMemoryQualifier.writeonly) |
| 4345 | { |
| 4346 | error(functionCall->getLine(), |
| 4347 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4348 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4349 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4350 | |
| 4351 | if (functionArgumentMemoryQualifier.coherent && |
| 4352 | !functionParameterMemoryQualifier.coherent) |
| 4353 | { |
| 4354 | error(functionCall->getLine(), |
| 4355 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4356 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4357 | } |
| 4358 | |
| 4359 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 4360 | !functionParameterMemoryQualifier.volatileQualifier) |
| 4361 | { |
| 4362 | error(functionCall->getLine(), |
| 4363 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4364 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4365 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4366 | } |
| 4367 | } |
| 4368 | } |
| 4369 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4370 | TIntermSequence *TParseContext::createEmptyArgumentsList() |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4371 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4372 | return new TIntermSequence(); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4373 | } |
| 4374 | |
| 4375 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4376 | TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4377 | TIntermNode *thisNode, |
| 4378 | const TSourceLoc &loc) |
| 4379 | { |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4380 | if (thisNode != nullptr) |
| 4381 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4382 | return addMethod(fnCall, arguments, thisNode, loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4383 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4384 | |
| 4385 | TOperator op = fnCall->getBuiltInOp(); |
| 4386 | if (op != EOpNull) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4387 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4388 | return addConstructor(arguments, op, fnCall->getReturnType(), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4389 | } |
| 4390 | else |
| 4391 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4392 | return addNonConstructorFunctionCall(fnCall, arguments, loc); |
| 4393 | } |
| 4394 | } |
| 4395 | |
| 4396 | TIntermTyped *TParseContext::addMethod(TFunction *fnCall, |
| 4397 | TIntermSequence *arguments, |
| 4398 | TIntermNode *thisNode, |
| 4399 | const TSourceLoc &loc) |
| 4400 | { |
| 4401 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 4402 | int arraySize = 0; |
| 4403 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 4404 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 4405 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 4406 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
| 4407 | // So accessing fnCall->getName() below is safe. |
| 4408 | if (fnCall->getName() != "length") |
| 4409 | { |
| 4410 | error(loc, "invalid method", fnCall->getName().c_str()); |
| 4411 | } |
| 4412 | else if (!arguments->empty()) |
| 4413 | { |
| 4414 | error(loc, "method takes no parameters", "length"); |
| 4415 | } |
| 4416 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 4417 | { |
| 4418 | error(loc, "length can only be called on arrays", "length"); |
| 4419 | } |
| 4420 | else |
| 4421 | { |
| 4422 | arraySize = typedThis->getArraySize(); |
| 4423 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4424 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4425 | // This code path can be hit with expressions like these: |
| 4426 | // (a = b).length() |
| 4427 | // (func()).length() |
| 4428 | // (int[3](0, 1, 2)).length() |
| 4429 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 4430 | // expression. |
| 4431 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 4432 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 4433 | // length method applied". |
| 4434 | error(loc, "length can only be called on array names, not on array expressions", |
| 4435 | "length"); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4436 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4437 | } |
| 4438 | unionArray->setIConst(arraySize); |
| 4439 | return intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), loc); |
| 4440 | } |
| 4441 | |
| 4442 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunction *fnCall, |
| 4443 | TIntermSequence *arguments, |
| 4444 | const TSourceLoc &loc) |
| 4445 | { |
| 4446 | // First find by unmangled name to check whether the function name has been |
| 4447 | // hidden by a variable name or struct typename. |
| 4448 | // If a function is found, check for one with a matching argument list. |
| 4449 | bool builtIn; |
| 4450 | const TSymbol *symbol = symbolTable.find(fnCall->getName(), mShaderVersion, &builtIn); |
| 4451 | if (symbol != nullptr && !symbol->isFunction()) |
| 4452 | { |
| 4453 | error(loc, "function name expected", fnCall->getName().c_str()); |
| 4454 | } |
| 4455 | else |
| 4456 | { |
| 4457 | symbol = symbolTable.find(TFunction::GetMangledNameFromCall(fnCall->getName(), *arguments), |
| 4458 | mShaderVersion, &builtIn); |
| 4459 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4460 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4461 | error(loc, "no matching overloaded function found", fnCall->getName().c_str()); |
| 4462 | } |
| 4463 | else |
| 4464 | { |
| 4465 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4466 | // |
| 4467 | // A declared function. |
| 4468 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 4469 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4470 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4471 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4472 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4473 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4474 | if (builtIn && op != EOpNull) |
| 4475 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4476 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4477 | if (fnCandidate->getParamCount() == 1) |
| 4478 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4479 | // Treat it like a built-in unary operator. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4480 | TIntermNode *unaryParamNode = arguments->front(); |
| 4481 | TIntermTyped *callNode = createUnaryMath(op, unaryParamNode->getAsTyped(), loc); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4482 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4483 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4484 | } |
| 4485 | else |
| 4486 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4487 | TIntermAggregate *callNode = |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4488 | TIntermAggregate::Create(fnCandidate->getReturnType(), op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4489 | callNode->setLine(loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4490 | |
| 4491 | // Some built-in functions have out parameters too. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4492 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4493 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4494 | // See if we can constant fold a built-in. Note that this may be possible even |
| 4495 | // if it is not const-qualified. |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4496 | TIntermTyped *foldedNode = |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4497 | intermediate.foldAggregateBuiltIn(callNode, mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4498 | if (foldedNode) |
| 4499 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4500 | return foldedNode; |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4501 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4502 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4503 | } |
| 4504 | } |
| 4505 | else |
| 4506 | { |
| 4507 | // This is a real function call |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4508 | TIntermAggregate *callNode = nullptr; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4509 | |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4510 | // If builtIn == false, the function is user defined - could be an overloaded |
| 4511 | // built-in as well. |
| 4512 | // if builtIn == true, it's a builtIn function with no op associated with it. |
| 4513 | // This needs to happen after the function info including name is set. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4514 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4515 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4516 | callNode = TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4517 | checkTextureOffsetConst(callNode); |
| 4518 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4519 | } |
| 4520 | else |
| 4521 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4522 | callNode = TIntermAggregate::CreateFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4523 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4524 | } |
| 4525 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4526 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4527 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4528 | callNode->setLine(loc); |
| 4529 | |
| 4530 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4531 | } |
| 4532 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4533 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4534 | |
| 4535 | // Error message was already written. Put on a dummy node for error recovery. |
| 4536 | return TIntermTyped::CreateZero(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4537 | } |
| 4538 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4539 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4540 | TIntermTyped *trueExpression, |
| 4541 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4542 | const TSourceLoc &loc) |
| 4543 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4544 | checkIsScalarBool(loc, cond); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4545 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4546 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4547 | { |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4548 | binaryOpError(loc, ":", trueExpression->getCompleteString(), |
| 4549 | falseExpression->getCompleteString()); |
| 4550 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4551 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 4552 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 4553 | { |
| 4554 | // ESSL 1.00 section 4.1.7 |
| 4555 | // ESSL 3.00 section 4.1.7 |
| 4556 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 4557 | // Note that structs containing opaque types don't need to be checked as structs are |
| 4558 | // forbidden below. |
| 4559 | error(loc, "ternary operator is not allowed for opaque types", ":"); |
| 4560 | return falseExpression; |
| 4561 | } |
| 4562 | |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4563 | // ESSL1 sections 5.2 and 5.7: |
| 4564 | // ESSL3 section 5.7: |
| 4565 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4566 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4567 | { |
| 4568 | error(loc, "ternary operator is not allowed for structures or arrays", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4569 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4570 | } |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4571 | // WebGL2 section 5.26, the following results in an error: |
| 4572 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4573 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4574 | { |
| 4575 | error(loc, "ternary operator is not allowed for void", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4576 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4577 | } |
| 4578 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4579 | return TIntermediate::AddTernarySelection(cond, trueExpression, falseExpression, loc); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4580 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4581 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4582 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4583 | // Parse an array of strings using yyparse. |
| 4584 | // |
| 4585 | // Returns 0 for success. |
| 4586 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4587 | int PaParseStrings(size_t count, |
| 4588 | const char *const string[], |
| 4589 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4590 | TParseContext *context) |
| 4591 | { |
Yunchao He | 4f28544 | 2017-04-21 12:15:49 +0800 | [diff] [blame] | 4592 | if ((count == 0) || (string == nullptr)) |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4593 | return 1; |
| 4594 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4595 | if (glslang_initialize(context)) |
| 4596 | return 1; |
| 4597 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 4598 | int error = glslang_scan(count, string, length, context); |
| 4599 | if (!error) |
| 4600 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4601 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 4602 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 4603 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 4604 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4605 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 4606 | |
| 4607 | } // namespace sh |