daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 12 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 13 | #include "compiler/translator/Cache.h" |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 14 | #include "compiler/translator/glslang.h" |
| 15 | #include "compiler/translator/ValidateSwitch.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 16 | #include "compiler/translator/ValidateGlobalInitializer.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 17 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 18 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 19 | namespace sh |
| 20 | { |
| 21 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 22 | /////////////////////////////////////////////////////////////////////// |
| 23 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 24 | // Sub- vector and matrix fields |
| 25 | // |
| 26 | //////////////////////////////////////////////////////////////////////// |
| 27 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 28 | namespace |
| 29 | { |
| 30 | |
| 31 | const int kWebGLMaxStructNesting = 4; |
| 32 | |
| 33 | bool ContainsSampler(const TType &type) |
| 34 | { |
| 35 | if (IsSampler(type.getBasicType())) |
| 36 | return true; |
| 37 | |
| 38 | if (type.getBasicType() == EbtStruct || type.isInterfaceBlock()) |
| 39 | { |
| 40 | const TFieldList &fields = type.getStruct()->fields(); |
| 41 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 42 | { |
| 43 | if (ContainsSampler(*fields[i]->type())) |
| 44 | return true; |
| 45 | } |
| 46 | } |
| 47 | |
| 48 | return false; |
| 49 | } |
| 50 | |
| 51 | bool ContainsImage(const TType &type) |
| 52 | { |
| 53 | if (IsImage(type.getBasicType())) |
| 54 | return true; |
| 55 | |
| 56 | if (type.getBasicType() == EbtStruct || type.isInterfaceBlock()) |
| 57 | { |
| 58 | const TFieldList &fields = type.getStruct()->fields(); |
| 59 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 60 | { |
| 61 | if (ContainsImage(*fields[i]->type())) |
| 62 | return true; |
| 63 | } |
| 64 | } |
| 65 | |
| 66 | return false; |
| 67 | } |
| 68 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 69 | // Get a token from an image argument to use as an error message token. |
| 70 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 71 | { |
| 72 | ASSERT(IsImage(imageNode->getBasicType())); |
| 73 | while (imageNode->getAsBinaryNode() && |
| 74 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 75 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 76 | { |
| 77 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 78 | } |
| 79 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 80 | if (imageSymbol) |
| 81 | { |
| 82 | return imageSymbol->getSymbol().c_str(); |
| 83 | } |
| 84 | return "image"; |
| 85 | } |
| 86 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 87 | } // namespace |
| 88 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 89 | TParseContext::TParseContext(TSymbolTable &symt, |
| 90 | TExtensionBehavior &ext, |
| 91 | sh::GLenum type, |
| 92 | ShShaderSpec spec, |
| 93 | ShCompileOptions options, |
| 94 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 95 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 96 | const ShBuiltInResources &resources) |
| 97 | : intermediate(), |
| 98 | symbolTable(symt), |
| 99 | mDeferredSingleDeclarationErrorCheck(false), |
| 100 | mShaderType(type), |
| 101 | mShaderSpec(spec), |
| 102 | mCompileOptions(options), |
| 103 | mShaderVersion(100), |
| 104 | mTreeRoot(nullptr), |
| 105 | mLoopNestingLevel(0), |
| 106 | mStructNestingLevel(0), |
| 107 | mSwitchNestingLevel(0), |
| 108 | mCurrentFunctionType(nullptr), |
| 109 | mFunctionReturnsValue(false), |
| 110 | mChecksPrecisionErrors(checksPrecErrors), |
| 111 | mFragmentPrecisionHighOnESSL1(false), |
| 112 | mDefaultMatrixPacking(EmpColumnMajor), |
| 113 | mDefaultBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 114 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 115 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 116 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 117 | mShaderVersion, |
| 118 | mShaderType, |
| 119 | resources.WEBGL_debug_shader_precision == 1), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 120 | mPreprocessor(mDiagnostics, &mDirectiveHandler, pp::PreprocessorSettings()), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 121 | mScanner(nullptr), |
| 122 | mUsesFragData(false), |
| 123 | mUsesFragColor(false), |
| 124 | mUsesSecondaryOutputs(false), |
| 125 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 126 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 127 | mMultiviewAvailable(resources.OVR_multiview == 1), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 128 | mComputeShaderLocalSizeDeclared(false), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 129 | mNumViews(-1), |
| 130 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 131 | mMaxImageUnits(resources.MaxImageUnits), |
| 132 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 133 | mMaxUniformLocations(resources.MaxUniformLocations), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 134 | mDeclaringFunction(false) |
| 135 | { |
| 136 | mComputeShaderLocalSize.fill(-1); |
| 137 | } |
| 138 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 139 | // |
| 140 | // Look at a '.' field selector string and change it into offsets |
| 141 | // for a vector. |
| 142 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 143 | bool TParseContext::parseVectorFields(const TString &compString, |
| 144 | int vecSize, |
| 145 | TVectorFields &fields, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 146 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 147 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 148 | fields.num = (int)compString.size(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 149 | if (fields.num > 4) |
| 150 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 151 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 152 | return false; |
| 153 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 154 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 155 | enum |
| 156 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 157 | exyzw, |
| 158 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 159 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 160 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 161 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 162 | for (int i = 0; i < fields.num; ++i) |
| 163 | { |
| 164 | switch (compString[i]) |
| 165 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 166 | case 'x': |
| 167 | fields.offsets[i] = 0; |
| 168 | fieldSet[i] = exyzw; |
| 169 | break; |
| 170 | case 'r': |
| 171 | fields.offsets[i] = 0; |
| 172 | fieldSet[i] = ergba; |
| 173 | break; |
| 174 | case 's': |
| 175 | fields.offsets[i] = 0; |
| 176 | fieldSet[i] = estpq; |
| 177 | break; |
| 178 | case 'y': |
| 179 | fields.offsets[i] = 1; |
| 180 | fieldSet[i] = exyzw; |
| 181 | break; |
| 182 | case 'g': |
| 183 | fields.offsets[i] = 1; |
| 184 | fieldSet[i] = ergba; |
| 185 | break; |
| 186 | case 't': |
| 187 | fields.offsets[i] = 1; |
| 188 | fieldSet[i] = estpq; |
| 189 | break; |
| 190 | case 'z': |
| 191 | fields.offsets[i] = 2; |
| 192 | fieldSet[i] = exyzw; |
| 193 | break; |
| 194 | case 'b': |
| 195 | fields.offsets[i] = 2; |
| 196 | fieldSet[i] = ergba; |
| 197 | break; |
| 198 | case 'p': |
| 199 | fields.offsets[i] = 2; |
| 200 | fieldSet[i] = estpq; |
| 201 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 202 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 203 | case 'w': |
| 204 | fields.offsets[i] = 3; |
| 205 | fieldSet[i] = exyzw; |
| 206 | break; |
| 207 | case 'a': |
| 208 | fields.offsets[i] = 3; |
| 209 | fieldSet[i] = ergba; |
| 210 | break; |
| 211 | case 'q': |
| 212 | fields.offsets[i] = 3; |
| 213 | fieldSet[i] = estpq; |
| 214 | break; |
| 215 | default: |
| 216 | error(line, "illegal vector field selection", compString.c_str()); |
| 217 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 218 | } |
| 219 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 220 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 221 | for (int i = 0; i < fields.num; ++i) |
| 222 | { |
| 223 | if (fields.offsets[i] >= vecSize) |
| 224 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 225 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 226 | return false; |
| 227 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 228 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 229 | if (i > 0) |
| 230 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 231 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 232 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 233 | error(line, "illegal - vector component fields not from the same set", |
| 234 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 235 | return false; |
| 236 | } |
| 237 | } |
| 238 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 239 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 240 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 241 | } |
| 242 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 243 | /////////////////////////////////////////////////////////////////////// |
| 244 | // |
| 245 | // Errors |
| 246 | // |
| 247 | //////////////////////////////////////////////////////////////////////// |
| 248 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 249 | // |
| 250 | // Used by flex/bison to output all syntax and parsing errors. |
| 251 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 252 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 253 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 254 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 255 | } |
| 256 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 257 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 258 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 259 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 260 | } |
| 261 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 262 | void TParseContext::outOfRangeError(bool isError, |
| 263 | const TSourceLoc &loc, |
| 264 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 265 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 266 | { |
| 267 | if (isError) |
| 268 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 269 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 270 | } |
| 271 | else |
| 272 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 273 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 274 | } |
| 275 | } |
| 276 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 277 | // |
| 278 | // Same error message for all places assignments don't work. |
| 279 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 280 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 281 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 282 | std::stringstream reasonStream; |
| 283 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 284 | std::string reason = reasonStream.str(); |
| 285 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 286 | } |
| 287 | |
| 288 | // |
| 289 | // Same error message for all places unary operations don't work. |
| 290 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 291 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 292 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 293 | std::stringstream reasonStream; |
| 294 | reasonStream << "wrong operand type - no operation '" << op |
| 295 | << "' exists that takes an operand of type " << operand |
| 296 | << " (or there is no acceptable conversion)"; |
| 297 | std::string reason = reasonStream.str(); |
| 298 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 299 | } |
| 300 | |
| 301 | // |
| 302 | // Same error message for all binary operations don't work. |
| 303 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 304 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 305 | const char *op, |
| 306 | TString left, |
| 307 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 308 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 309 | std::stringstream reasonStream; |
| 310 | reasonStream << "wrong operand types - no operation '" << op |
| 311 | << "' exists that takes a left-hand operand of type '" << left |
| 312 | << "' and a right operand of type '" << right |
| 313 | << "' (or there is no acceptable conversion)"; |
| 314 | std::string reason = reasonStream.str(); |
| 315 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 316 | } |
| 317 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 318 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 319 | TPrecision precision, |
| 320 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 321 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 322 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 323 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 324 | |
| 325 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 326 | { |
| 327 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 328 | } |
| 329 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 330 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 331 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 332 | switch (type) |
| 333 | { |
| 334 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 335 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 336 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 337 | case EbtInt: |
| 338 | case EbtUInt: |
| 339 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 340 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 341 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 342 | default: |
| 343 | if (IsSampler(type)) |
| 344 | { |
| 345 | error(line, "No precision specified (sampler)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 346 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 347 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 348 | if (IsImage(type)) |
| 349 | { |
| 350 | error(line, "No precision specified (image)", ""); |
| 351 | return; |
| 352 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 353 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 354 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 355 | } |
| 356 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 357 | // Both test and if necessary, spit out an error, to see if the node is really |
| 358 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 359 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 360 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 361 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 362 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 363 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 364 | |
| 365 | if (swizzleNode) |
| 366 | { |
| 367 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 368 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 369 | { |
| 370 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 371 | return false; |
| 372 | } |
| 373 | return ok; |
| 374 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 375 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 376 | if (binaryNode) |
| 377 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 378 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 379 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 380 | case EOpIndexDirect: |
| 381 | case EOpIndexIndirect: |
| 382 | case EOpIndexDirectStruct: |
| 383 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 384 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 385 | default: |
| 386 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 387 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 388 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 389 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 390 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 391 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 392 | const char *message = 0; |
| 393 | switch (node->getQualifier()) |
| 394 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 395 | case EvqConst: |
| 396 | message = "can't modify a const"; |
| 397 | break; |
| 398 | case EvqConstReadOnly: |
| 399 | message = "can't modify a const"; |
| 400 | break; |
| 401 | case EvqAttribute: |
| 402 | message = "can't modify an attribute"; |
| 403 | break; |
| 404 | case EvqFragmentIn: |
| 405 | message = "can't modify an input"; |
| 406 | break; |
| 407 | case EvqVertexIn: |
| 408 | message = "can't modify an input"; |
| 409 | break; |
| 410 | case EvqUniform: |
| 411 | message = "can't modify a uniform"; |
| 412 | break; |
| 413 | case EvqVaryingIn: |
| 414 | message = "can't modify a varying"; |
| 415 | break; |
| 416 | case EvqFragCoord: |
| 417 | message = "can't modify gl_FragCoord"; |
| 418 | break; |
| 419 | case EvqFrontFacing: |
| 420 | message = "can't modify gl_FrontFacing"; |
| 421 | break; |
| 422 | case EvqPointCoord: |
| 423 | message = "can't modify gl_PointCoord"; |
| 424 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 425 | case EvqNumWorkGroups: |
| 426 | message = "can't modify gl_NumWorkGroups"; |
| 427 | break; |
| 428 | case EvqWorkGroupSize: |
| 429 | message = "can't modify gl_WorkGroupSize"; |
| 430 | break; |
| 431 | case EvqWorkGroupID: |
| 432 | message = "can't modify gl_WorkGroupID"; |
| 433 | break; |
| 434 | case EvqLocalInvocationID: |
| 435 | message = "can't modify gl_LocalInvocationID"; |
| 436 | break; |
| 437 | case EvqGlobalInvocationID: |
| 438 | message = "can't modify gl_GlobalInvocationID"; |
| 439 | break; |
| 440 | case EvqLocalInvocationIndex: |
| 441 | message = "can't modify gl_LocalInvocationIndex"; |
| 442 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 443 | case EvqComputeIn: |
| 444 | message = "can't modify work group size variable"; |
| 445 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 446 | default: |
| 447 | // |
| 448 | // Type that can't be written to? |
| 449 | // |
| 450 | if (node->getBasicType() == EbtVoid) |
| 451 | { |
| 452 | message = "can't modify void"; |
| 453 | } |
| 454 | if (IsSampler(node->getBasicType())) |
| 455 | { |
| 456 | message = "can't modify a sampler"; |
| 457 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 458 | if (IsImage(node->getBasicType())) |
| 459 | { |
| 460 | message = "can't modify an image"; |
| 461 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 462 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 463 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 464 | if (message == 0 && binaryNode == 0 && symNode == 0) |
| 465 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 466 | error(line, "l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 467 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 468 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 469 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 470 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 471 | // |
| 472 | // Everything else is okay, no error. |
| 473 | // |
| 474 | if (message == 0) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 475 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 476 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 477 | // |
| 478 | // If we get here, we have an error and a message. |
| 479 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 480 | if (symNode) |
| 481 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 482 | const char *symbol = symNode->getSymbol().c_str(); |
| 483 | std::stringstream reasonStream; |
| 484 | reasonStream << "l-value required (" << message << " \"" << symbol << "\")"; |
| 485 | std::string reason = reasonStream.str(); |
| 486 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 487 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 488 | else |
| 489 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 490 | std::stringstream reasonStream; |
| 491 | reasonStream << "l-value required (" << message << ")"; |
| 492 | std::string reason = reasonStream.str(); |
| 493 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 494 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 495 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 496 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 497 | } |
| 498 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 499 | // Both test, and if necessary spit out an error, to see if the node is really |
| 500 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 501 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 502 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 503 | if (node->getQualifier() != EvqConst) |
| 504 | { |
| 505 | error(node->getLine(), "constant expression required", ""); |
| 506 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 507 | } |
| 508 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 509 | // Both test, and if necessary spit out an error, to see if the node is really |
| 510 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 511 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 512 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 513 | if (!node->isScalarInt()) |
| 514 | { |
| 515 | error(node->getLine(), "integer expression required", token); |
| 516 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 517 | } |
| 518 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 519 | // Both test, and if necessary spit out an error, to see if we are currently |
| 520 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 521 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 522 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 523 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 524 | { |
| 525 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 526 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 527 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 528 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 529 | } |
| 530 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 531 | // For now, keep it simple: if it starts "gl_", it's reserved, independent |
| 532 | // of scope. Except, if the symbol table is at the built-in push-level, |
| 533 | // which is when we are parsing built-ins. |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 534 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a |
| 535 | // webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 536 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 537 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 538 | static const char *reservedErrMsg = "reserved built-in name"; |
| 539 | if (!symbolTable.atBuiltInLevel()) |
| 540 | { |
| 541 | if (identifier.compare(0, 3, "gl_") == 0) |
| 542 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 543 | error(line, reservedErrMsg, "gl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 544 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 545 | } |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 546 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 547 | { |
| 548 | if (identifier.compare(0, 6, "webgl_") == 0) |
| 549 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 550 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 551 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 552 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 553 | if (identifier.compare(0, 7, "_webgl_") == 0) |
| 554 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 555 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 556 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 557 | } |
| 558 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 559 | if (identifier.find("__") != TString::npos) |
| 560 | { |
| 561 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 562 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 563 | "possible future keywords", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 564 | identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 565 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 566 | } |
| 567 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 568 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 569 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 570 | } |
| 571 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 572 | // Make sure there is enough data provided to the constructor to build |
| 573 | // something of the type of the constructor. Also returns the type of |
| 574 | // the constructor. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 575 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 576 | const TIntermSequence *arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 577 | TOperator op, |
| 578 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 579 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 580 | bool constructingMatrix = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 581 | switch (op) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 582 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 583 | case EOpConstructMat2: |
| 584 | case EOpConstructMat2x3: |
| 585 | case EOpConstructMat2x4: |
| 586 | case EOpConstructMat3x2: |
| 587 | case EOpConstructMat3: |
| 588 | case EOpConstructMat3x4: |
| 589 | case EOpConstructMat4x2: |
| 590 | case EOpConstructMat4x3: |
| 591 | case EOpConstructMat4: |
| 592 | constructingMatrix = true; |
| 593 | break; |
| 594 | default: |
| 595 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 596 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 597 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 598 | // |
| 599 | // Note: It's okay to have too many components available, but not okay to have unused |
| 600 | // arguments. 'full' will go to true when enough args have been seen. If we loop |
| 601 | // again, there is an extra argument, so 'overfull' will become true. |
| 602 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 603 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 604 | size_t size = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 605 | bool full = false; |
| 606 | bool overFull = false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 607 | bool matrixInMatrix = false; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 608 | bool arrayArg = false; |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 609 | for (TIntermNode *arg : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 610 | { |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 611 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 612 | size += argTyped->getType().getObjectSize(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 613 | |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 614 | if (constructingMatrix && argTyped->getType().isMatrix()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 615 | matrixInMatrix = true; |
| 616 | if (full) |
| 617 | overFull = true; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 618 | if (op != EOpConstructStruct && !type.isArray() && size >= type.getObjectSize()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 619 | full = true; |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 620 | if (argTyped->getType().isArray()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 621 | arrayArg = true; |
| 622 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 623 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 624 | if (type.isArray()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 625 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 626 | // The size of an unsized constructor should already have been determined. |
| 627 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 628 | if (static_cast<size_t>(type.getArraySize()) != arguments->size()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 629 | { |
| 630 | error(line, "array constructor needs one argument per array element", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 631 | return false; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 632 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 633 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 634 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 635 | if (arrayArg && op != EOpConstructStruct) |
| 636 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 637 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 638 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 639 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 640 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 641 | if (matrixInMatrix && !type.isArray()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 642 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 643 | if (arguments->size() != 1) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 644 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 645 | error(line, "constructing matrix from matrix can only take one argument", |
| 646 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 647 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 648 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 649 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 650 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 651 | if (overFull) |
| 652 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 653 | error(line, "too many arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 654 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 655 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 656 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 657 | if (op == EOpConstructStruct && !type.isArray() && |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 658 | type.getStruct()->fields().size() != arguments->size()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 659 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 660 | error(line, |
| 661 | "Number of constructor parameters does not match the number of structure fields", |
| 662 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 663 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 664 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 665 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 666 | if (!type.isMatrix() || !matrixInMatrix) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 667 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 668 | if ((op != EOpConstructStruct && size != 1 && size < type.getObjectSize()) || |
| 669 | (op == EOpConstructStruct && size < type.getObjectSize())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 670 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 671 | error(line, "not enough data provided for construction", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 672 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 673 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 674 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 675 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 676 | if (arguments->empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 677 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 678 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 679 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 680 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 681 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 682 | for (TIntermNode *const &argNode : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 683 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 684 | TIntermTyped *argTyped = argNode->getAsTyped(); |
| 685 | ASSERT(argTyped != nullptr); |
| 686 | if (op != EOpConstructStruct && IsSampler(argTyped->getBasicType())) |
| 687 | { |
| 688 | error(line, "cannot convert a sampler", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 689 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 690 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 691 | if (op != EOpConstructStruct && IsImage(argTyped->getBasicType())) |
| 692 | { |
| 693 | error(line, "cannot convert an image", "constructor"); |
| 694 | return false; |
| 695 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 696 | if (argTyped->getBasicType() == EbtVoid) |
| 697 | { |
| 698 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 699 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 700 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 701 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 702 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 703 | if (type.isArray()) |
| 704 | { |
| 705 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 706 | // the array. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 707 | for (TIntermNode *const &argNode : *arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 708 | { |
| 709 | const TType &argType = argNode->getAsTyped()->getType(); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 710 | // It has already been checked that the argument is not an array, but we can arrive |
| 711 | // here due to prior error conditions. |
| 712 | if (argType.isArray()) |
| 713 | { |
| 714 | return false; |
| 715 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 716 | if (!argType.sameElementType(type)) |
| 717 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 718 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 719 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 720 | } |
| 721 | } |
| 722 | } |
| 723 | else if (op == EOpConstructStruct) |
| 724 | { |
| 725 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 726 | |
| 727 | for (size_t i = 0; i < fields.size(); i++) |
| 728 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 729 | if (i >= arguments->size() || |
| 730 | (*arguments)[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 731 | { |
| 732 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 733 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 734 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 735 | } |
| 736 | } |
| 737 | } |
| 738 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 739 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 740 | } |
| 741 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 742 | // This function checks to see if a void variable has been declared and raise an error message for |
| 743 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 744 | // |
| 745 | // returns true in case of an error |
| 746 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 747 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 748 | const TString &identifier, |
| 749 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 750 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 751 | if (type == EbtVoid) |
| 752 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 753 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 754 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 755 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 756 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 757 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 758 | } |
| 759 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 760 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 761 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 762 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 763 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 764 | if (type->getBasicType() != EbtBool || type->isArray() || type->isMatrix() || type->isVector()) |
| 765 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 766 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 767 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 768 | } |
| 769 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 770 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 771 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 772 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 773 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 774 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 775 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 776 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 777 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 778 | } |
| 779 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 780 | bool TParseContext::checkIsNotSampler(const TSourceLoc &line, |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 781 | const TTypeSpecifierNonArray &pType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 782 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 783 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 784 | if (pType.type == EbtStruct) |
| 785 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 786 | if (ContainsSampler(*pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 787 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 788 | std::stringstream reasonStream; |
| 789 | reasonStream << reason << " (structure contains a sampler)"; |
| 790 | std::string reasonStr = reasonStream.str(); |
| 791 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 792 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 793 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 794 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 795 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 796 | } |
| 797 | else if (IsSampler(pType.type)) |
| 798 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 799 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 800 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 801 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 802 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 803 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 804 | } |
| 805 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 806 | bool TParseContext::checkIsNotImage(const TSourceLoc &line, |
| 807 | const TTypeSpecifierNonArray &pType, |
| 808 | const char *reason) |
| 809 | { |
| 810 | if (pType.type == EbtStruct) |
| 811 | { |
| 812 | if (ContainsImage(*pType.userDef)) |
| 813 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 814 | std::stringstream reasonStream; |
| 815 | reasonStream << reason << " (structure contains an image)"; |
| 816 | std::string reasonStr = reasonStream.str(); |
| 817 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 818 | |
| 819 | return false; |
| 820 | } |
| 821 | |
| 822 | return true; |
| 823 | } |
| 824 | else if (IsImage(pType.type)) |
| 825 | { |
| 826 | error(line, reason, getBasicString(pType.type)); |
| 827 | |
| 828 | return false; |
| 829 | } |
| 830 | |
| 831 | return true; |
| 832 | } |
| 833 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 834 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 835 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 836 | { |
| 837 | if (pType.layoutQualifier.location != -1) |
| 838 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 839 | error(line, "location must only be specified for a single input or output variable", |
| 840 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 841 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 842 | } |
| 843 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 844 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 845 | const TLayoutQualifier &layoutQualifier) |
| 846 | { |
| 847 | if (layoutQualifier.location != -1) |
| 848 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 849 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 850 | if (mShaderVersion >= 310) |
| 851 | { |
| 852 | errorMsg = |
| 853 | "invalid layout qualifier: only valid on program inputs, outputs, and uniforms"; |
| 854 | } |
| 855 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 856 | } |
| 857 | } |
| 858 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 859 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 860 | TQualifier qualifier, |
| 861 | const TType &type) |
| 862 | { |
| 863 | checkOutParameterIsNotSampler(line, qualifier, type); |
| 864 | checkOutParameterIsNotImage(line, qualifier, type); |
| 865 | } |
| 866 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 867 | void TParseContext::checkOutParameterIsNotSampler(const TSourceLoc &line, |
| 868 | TQualifier qualifier, |
| 869 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 870 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 871 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
| 872 | if (IsSampler(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 873 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 874 | error(line, "samplers cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 875 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 876 | } |
| 877 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 878 | void TParseContext::checkOutParameterIsNotImage(const TSourceLoc &line, |
| 879 | TQualifier qualifier, |
| 880 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 881 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 882 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
| 883 | if (IsImage(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 884 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 885 | error(line, "images cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 886 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 887 | } |
| 888 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 889 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 890 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 891 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 892 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 893 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 894 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 895 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 896 | // fold as array size. |
| 897 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 898 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 899 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 900 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 901 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 902 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 903 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 904 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 905 | if (constant->getBasicType() == EbtUInt) |
| 906 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 907 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 908 | } |
| 909 | else |
| 910 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 911 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 912 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 913 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 914 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 915 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 916 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 917 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 918 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 919 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 920 | } |
| 921 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 922 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 923 | { |
| 924 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 925 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 926 | } |
| 927 | |
| 928 | // The size of arrays is restricted here to prevent issues further down the |
| 929 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 930 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 931 | const unsigned int sizeLimit = 65536; |
| 932 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 933 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 934 | { |
| 935 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 936 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 937 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 938 | |
| 939 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 940 | } |
| 941 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 942 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 943 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 944 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 945 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 946 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 947 | (elementQualifier.qualifier == EvqVertexIn) || |
| 948 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 949 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 950 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 951 | TType(elementQualifier).getQualifierString()); |
| 952 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 953 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 954 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 955 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 956 | } |
| 957 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 958 | // See if this element type can be formed into an array. |
| 959 | bool TParseContext::checkIsValidTypeForArray(const TSourceLoc &line, const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 960 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 961 | // |
| 962 | // Can the type be an array? |
| 963 | // |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 964 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 965 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 966 | error(line, "cannot declare arrays of arrays", |
| 967 | TType(elementType).getCompleteString().c_str()); |
| 968 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 969 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 970 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 971 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 972 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 973 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 974 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 975 | { |
| 976 | error(line, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 977 | TType(elementType).getCompleteString().c_str()); |
| 978 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 979 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 980 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 981 | return true; |
| 982 | } |
| 983 | |
| 984 | // Check if this qualified element type can be formed into an array. |
| 985 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 986 | const TPublicType &elementType) |
| 987 | { |
| 988 | if (checkIsValidTypeForArray(indexLocation, elementType)) |
| 989 | { |
| 990 | return checkIsValidQualifierForArray(indexLocation, elementType); |
| 991 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 992 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 993 | } |
| 994 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 995 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 996 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 997 | const TString &identifier, |
| 998 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 999 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1000 | ASSERT(type != nullptr); |
| 1001 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1002 | { |
| 1003 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1004 | type->qualifier = EvqTemporary; |
| 1005 | |
| 1006 | // Generate informative error messages for ESSL1. |
| 1007 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1008 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1009 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1010 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1011 | "structures containing arrays may not be declared constant since they cannot be " |
| 1012 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1013 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1014 | } |
| 1015 | else |
| 1016 | { |
| 1017 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 1018 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1019 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1020 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1021 | if (type->isUnsizedArray()) |
| 1022 | { |
| 1023 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1024 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1025 | } |
| 1026 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1027 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1028 | // and update the symbol table. |
| 1029 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1030 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1031 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1032 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 1033 | const TString &identifier, |
| 1034 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1035 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1036 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1037 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1038 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1039 | checkBindingIsValid(line, type); |
| 1040 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1041 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1042 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1043 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 1044 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 1045 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1046 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 1047 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1048 | if (static_cast<int>(type.getArraySize()) == maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1049 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1050 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1051 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1052 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1053 | } |
| 1054 | } |
| 1055 | else |
| 1056 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1057 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 1058 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1059 | return false; |
| 1060 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1061 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1062 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1063 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1064 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1065 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1066 | (*variable) = new TVariable(&identifier, type); |
| 1067 | if (!symbolTable.declare(*variable)) |
| 1068 | { |
| 1069 | error(line, "redefinition", identifier.c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 1070 | *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1071 | return false; |
| 1072 | } |
| 1073 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1074 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1075 | return false; |
| 1076 | |
| 1077 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1078 | } |
| 1079 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1080 | void TParseContext::checkIsParameterQualifierValid( |
| 1081 | const TSourceLoc &line, |
| 1082 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1083 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1084 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1085 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1086 | |
| 1087 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1088 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1089 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1090 | } |
| 1091 | |
| 1092 | if (!IsImage(type->getBasicType())) |
| 1093 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1094 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1095 | } |
| 1096 | else |
| 1097 | { |
| 1098 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1099 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1100 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1101 | type->setQualifier(typeQualifier.qualifier); |
| 1102 | |
| 1103 | if (typeQualifier.precision != EbpUndefined) |
| 1104 | { |
| 1105 | type->setPrecision(typeQualifier.precision); |
| 1106 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1107 | } |
| 1108 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1109 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1110 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1111 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1112 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1113 | if (iter == extBehavior.end()) |
| 1114 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1115 | error(line, "extension is not supported", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1116 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1117 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 1118 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1119 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 1120 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1121 | // TODO(oetuaho@nvidia.com): This is slightly hacky. Might be better if symbols could be |
| 1122 | // associated with more than one extension. |
| 1123 | if (extension == "GL_OVR_multiview") |
| 1124 | { |
| 1125 | return checkCanUseExtension(line, "GL_OVR_multiview2"); |
| 1126 | } |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1127 | error(line, "extension is disabled", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1128 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1129 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1130 | if (iter->second == EBhWarn) |
| 1131 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1132 | warning(line, "extension is being used", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1133 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1134 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1135 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1136 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1137 | } |
| 1138 | |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1139 | void TParseContext::emptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1140 | const TSourceLoc &location) |
| 1141 | { |
| 1142 | if (publicType.isUnsizedArray()) |
| 1143 | { |
| 1144 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1145 | // error. It is assumed that this applies to empty declarations as well. |
| 1146 | error(location, "empty array declaration needs to specify a size", ""); |
| 1147 | } |
| 1148 | if (publicType.qualifier == EvqShared && !publicType.layoutQualifier.isEmpty()) |
| 1149 | { |
| 1150 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1151 | } |
| 1152 | } |
| 1153 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1154 | // These checks are common for all declarations starting a declarator list, and declarators that |
| 1155 | // follow an empty declaration. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1156 | void TParseContext::singleDeclarationErrorCheck(const TPublicType &publicType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1157 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1158 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1159 | switch (publicType.qualifier) |
| 1160 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1161 | case EvqVaryingIn: |
| 1162 | case EvqVaryingOut: |
| 1163 | case EvqAttribute: |
| 1164 | case EvqVertexIn: |
| 1165 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1166 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1167 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1168 | { |
| 1169 | error(identifierLocation, "cannot be used with a structure", |
| 1170 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1171 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1172 | } |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1173 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1174 | default: |
| 1175 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1176 | } |
| 1177 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1178 | if (publicType.qualifier != EvqUniform && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1179 | !checkIsNotSampler(identifierLocation, publicType.typeSpecifierNonArray, |
| 1180 | "samplers must be uniform")) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1181 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1182 | return; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1183 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1184 | if (publicType.qualifier != EvqUniform && |
| 1185 | !checkIsNotImage(identifierLocation, publicType.typeSpecifierNonArray, |
| 1186 | "images must be uniform")) |
| 1187 | { |
| 1188 | return; |
| 1189 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1190 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1191 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1192 | publicType.qualifier != EvqConst) && |
| 1193 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1194 | { |
| 1195 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1196 | getQualifierString(publicType.qualifier)); |
| 1197 | return; |
| 1198 | } |
| 1199 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1200 | // check for layout qualifier issues |
| 1201 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
| 1202 | |
| 1203 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1204 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1205 | error(identifierLocation, "layout qualifier only valid for interface blocks", |
| 1206 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1207 | return; |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1208 | } |
| 1209 | |
| 1210 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1211 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1212 | error(identifierLocation, "layout qualifier only valid for interface blocks", |
| 1213 | getBlockStorageString(layoutQualifier.blockStorage)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1214 | return; |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1215 | } |
| 1216 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1217 | bool canHaveLocation = |
| 1218 | publicType.qualifier == EvqVertexIn || publicType.qualifier == EvqFragmentOut; |
| 1219 | |
| 1220 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1221 | { |
| 1222 | canHaveLocation = true; |
| 1223 | |
| 1224 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1225 | // But invalid shaders may still reach here with an unsized array declaration. |
| 1226 | if (!publicType.isUnsizedArray()) |
| 1227 | { |
| 1228 | TType type(publicType); |
| 1229 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1230 | publicType.layoutQualifier); |
| 1231 | } |
| 1232 | } |
| 1233 | if (!canHaveLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1234 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1235 | checkLocationIsNotSpecified(identifierLocation, publicType.layoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1236 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1237 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1238 | if (publicType.qualifier == EvqFragmentOut) |
| 1239 | { |
| 1240 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1241 | { |
| 1242 | error(identifierLocation, "invalid layout qualifier combination", "yuv"); |
| 1243 | return; |
| 1244 | } |
| 1245 | } |
| 1246 | else |
| 1247 | { |
| 1248 | checkYuvIsNotSpecified(identifierLocation, layoutQualifier.yuv); |
| 1249 | } |
| 1250 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1251 | if (IsImage(publicType.getBasicType())) |
| 1252 | { |
| 1253 | |
| 1254 | switch (layoutQualifier.imageInternalFormat) |
| 1255 | { |
| 1256 | case EiifRGBA32F: |
| 1257 | case EiifRGBA16F: |
| 1258 | case EiifR32F: |
| 1259 | case EiifRGBA8: |
| 1260 | case EiifRGBA8_SNORM: |
| 1261 | if (!IsFloatImage(publicType.getBasicType())) |
| 1262 | { |
| 1263 | error(identifierLocation, |
| 1264 | "internal image format requires a floating image type", |
| 1265 | getBasicString(publicType.getBasicType())); |
| 1266 | return; |
| 1267 | } |
| 1268 | break; |
| 1269 | case EiifRGBA32I: |
| 1270 | case EiifRGBA16I: |
| 1271 | case EiifRGBA8I: |
| 1272 | case EiifR32I: |
| 1273 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1274 | { |
| 1275 | error(identifierLocation, |
| 1276 | "internal image format requires an integer image type", |
| 1277 | getBasicString(publicType.getBasicType())); |
| 1278 | return; |
| 1279 | } |
| 1280 | break; |
| 1281 | case EiifRGBA32UI: |
| 1282 | case EiifRGBA16UI: |
| 1283 | case EiifRGBA8UI: |
| 1284 | case EiifR32UI: |
| 1285 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1286 | { |
| 1287 | error(identifierLocation, |
| 1288 | "internal image format requires an unsigned image type", |
| 1289 | getBasicString(publicType.getBasicType())); |
| 1290 | return; |
| 1291 | } |
| 1292 | break; |
| 1293 | case EiifUnspecified: |
| 1294 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1295 | return; |
| 1296 | default: |
| 1297 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1298 | return; |
| 1299 | } |
| 1300 | |
| 1301 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1302 | switch (layoutQualifier.imageInternalFormat) |
| 1303 | { |
| 1304 | case EiifR32F: |
| 1305 | case EiifR32I: |
| 1306 | case EiifR32UI: |
| 1307 | break; |
| 1308 | default: |
| 1309 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1310 | { |
| 1311 | error(identifierLocation, "layout qualifier", |
| 1312 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1313 | "image variables must be qualified readonly and/or writeonly"); |
| 1314 | return; |
| 1315 | } |
| 1316 | break; |
| 1317 | } |
| 1318 | } |
| 1319 | else |
| 1320 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1321 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1322 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1323 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1324 | } |
| 1325 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1326 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1327 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1328 | { |
| 1329 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
| 1330 | int arraySize = type.isArray() ? type.getArraySize() : 1; |
| 1331 | if (IsImage(type.getBasicType())) |
| 1332 | { |
| 1333 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1334 | } |
| 1335 | else if (IsSampler(type.getBasicType())) |
| 1336 | { |
| 1337 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, arraySize); |
| 1338 | } |
| 1339 | else |
| 1340 | { |
| 1341 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1342 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1343 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1344 | } |
| 1345 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1346 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1347 | const TString &layoutQualifierName, |
| 1348 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1349 | { |
| 1350 | |
| 1351 | if (mShaderVersion < versionRequired) |
| 1352 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1353 | error(location, "invalid layout qualifier: not supported", layoutQualifierName.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1354 | } |
| 1355 | } |
| 1356 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1357 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1358 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1359 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1360 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1361 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1362 | { |
| 1363 | if (localSize[i] != -1) |
| 1364 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1365 | error(location, |
| 1366 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1367 | "global layout declaration", |
| 1368 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1369 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1370 | } |
| 1371 | } |
| 1372 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1373 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1374 | } |
| 1375 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1376 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1377 | TLayoutImageInternalFormat internalFormat) |
| 1378 | { |
| 1379 | if (internalFormat != EiifUnspecified) |
| 1380 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1381 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1382 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1383 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1384 | } |
| 1385 | |
| 1386 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1387 | { |
| 1388 | if (binding != -1) |
| 1389 | { |
| 1390 | error(location, |
| 1391 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1392 | "binding"); |
| 1393 | } |
| 1394 | } |
| 1395 | |
| 1396 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, int binding, int arraySize) |
| 1397 | { |
| 1398 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1399 | if (binding >= 0 && binding + arraySize > mMaxImageUnits) |
| 1400 | { |
| 1401 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1402 | } |
| 1403 | } |
| 1404 | |
| 1405 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1406 | int binding, |
| 1407 | int arraySize) |
| 1408 | { |
| 1409 | // Expects arraySize to be 1 when setting binding for only a single variable. |
| 1410 | if (binding >= 0 && binding + arraySize > mMaxCombinedTextureImageUnits) |
| 1411 | { |
| 1412 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1413 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1414 | } |
| 1415 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1416 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1417 | int objectLocationCount, |
| 1418 | const TLayoutQualifier &layoutQualifier) |
| 1419 | { |
| 1420 | int loc = layoutQualifier.location; |
| 1421 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1422 | { |
| 1423 | error(location, "Uniform location out of range", "location"); |
| 1424 | } |
| 1425 | } |
| 1426 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1427 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1428 | { |
| 1429 | if (yuv != false) |
| 1430 | { |
| 1431 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1432 | } |
| 1433 | } |
| 1434 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1435 | void TParseContext::functionCallLValueErrorCheck(const TFunction *fnCandidate, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1436 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1437 | { |
| 1438 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1439 | { |
| 1440 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
| 1441 | if (qual == EvqOut || qual == EvqInOut) |
| 1442 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1443 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1444 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1445 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1446 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1447 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 1448 | fnCall->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1449 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1450 | } |
| 1451 | } |
| 1452 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1453 | } |
| 1454 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1455 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1456 | const TQualifier qualifier, |
| 1457 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1458 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1459 | if (!invariant) |
| 1460 | return; |
| 1461 | |
| 1462 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1463 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1464 | // input variables in the fragment shader can be also qualified as invariant |
| 1465 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1466 | { |
| 1467 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1468 | } |
| 1469 | } |
| 1470 | else |
| 1471 | { |
| 1472 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1473 | { |
| 1474 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1475 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1476 | } |
| 1477 | } |
| 1478 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1479 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1480 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1481 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1482 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1483 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1484 | } |
| 1485 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1486 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1487 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1488 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1489 | } |
| 1490 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1491 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1492 | const char *extName, |
| 1493 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1494 | { |
| 1495 | pp::SourceLocation srcLoc; |
| 1496 | srcLoc.file = loc.first_file; |
| 1497 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1498 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1499 | } |
| 1500 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1501 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1502 | const char *name, |
| 1503 | const char *value, |
| 1504 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1505 | { |
| 1506 | pp::SourceLocation srcLoc; |
| 1507 | srcLoc.file = loc.first_file; |
| 1508 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1509 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1510 | } |
| 1511 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1512 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1513 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1514 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1515 | for (size_t i = 0u; i < result.size(); ++i) |
| 1516 | { |
| 1517 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1518 | { |
| 1519 | result[i] = 1; |
| 1520 | } |
| 1521 | else |
| 1522 | { |
| 1523 | result[i] = mComputeShaderLocalSize[i]; |
| 1524 | } |
| 1525 | } |
| 1526 | return result; |
| 1527 | } |
| 1528 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1529 | ///////////////////////////////////////////////////////////////////////////////// |
| 1530 | // |
| 1531 | // Non-Errors. |
| 1532 | // |
| 1533 | ///////////////////////////////////////////////////////////////////////////////// |
| 1534 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1535 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1536 | const TString *name, |
| 1537 | const TSymbol *symbol) |
| 1538 | { |
Yunchao He | d7297bf | 2017-04-19 15:27:10 +0800 | [diff] [blame^] | 1539 | const TVariable *variable = nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1540 | |
| 1541 | if (!symbol) |
| 1542 | { |
| 1543 | error(location, "undeclared identifier", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1544 | } |
| 1545 | else if (!symbol->isVariable()) |
| 1546 | { |
| 1547 | error(location, "variable expected", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1548 | } |
| 1549 | else |
| 1550 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1551 | variable = static_cast<const TVariable *>(symbol); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1552 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1553 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1554 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1555 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1556 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1557 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1558 | |
| 1559 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1560 | TQualifier qualifier = variable->getType().getQualifier(); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1561 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1562 | { |
| 1563 | mUsesFragData = true; |
| 1564 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1565 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1566 | { |
| 1567 | mUsesFragColor = true; |
| 1568 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1569 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1570 | { |
| 1571 | mUsesSecondaryOutputs = true; |
| 1572 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1573 | |
| 1574 | // This validation is not quite correct - it's only an error to write to |
| 1575 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1576 | // be rewarded for reading from undefined varaibles, return an error |
| 1577 | // if they are both referenced, rather than assigned. |
| 1578 | if (mUsesFragData && mUsesFragColor) |
| 1579 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1580 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1581 | if (mUsesSecondaryOutputs) |
| 1582 | { |
| 1583 | errorMessage = |
| 1584 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1585 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1586 | } |
| 1587 | error(location, errorMessage, name->c_str()); |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1588 | } |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 1589 | |
| 1590 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1591 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1592 | qualifier == EvqWorkGroupSize) |
| 1593 | { |
| 1594 | error(location, |
| 1595 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1596 | "gl_WorkGroupSize"); |
| 1597 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1598 | } |
| 1599 | |
| 1600 | if (!variable) |
| 1601 | { |
| 1602 | TType type(EbtFloat, EbpUndefined); |
| 1603 | TVariable *fakeVariable = new TVariable(name, type); |
| 1604 | symbolTable.declare(fakeVariable); |
| 1605 | variable = fakeVariable; |
| 1606 | } |
| 1607 | |
| 1608 | return variable; |
| 1609 | } |
| 1610 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1611 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1612 | const TString *name, |
| 1613 | const TSymbol *symbol) |
| 1614 | { |
| 1615 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1616 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1617 | if (variable->getType().getQualifier() == EvqViewIDOVR && IsWebGLBasedSpec(mShaderSpec) && |
| 1618 | mShaderType == GL_FRAGMENT_SHADER && !isExtensionEnabled("GL_OVR_multiview2")) |
| 1619 | { |
| 1620 | // WEBGL_multiview spec |
| 1621 | error(location, "Need to enable OVR_multiview2 to use gl_ViewID_OVR in fragment shader", |
| 1622 | "gl_ViewID_OVR"); |
| 1623 | } |
| 1624 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1625 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1626 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1627 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1628 | return intermediate.addConstantUnion(constArray, variable->getType(), location); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1629 | } |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1630 | else if (variable->getType().getQualifier() == EvqWorkGroupSize && |
| 1631 | mComputeShaderLocalSizeDeclared) |
| 1632 | { |
| 1633 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1634 | // needs to be added to the AST as a constant and not as a symbol. |
| 1635 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1636 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1637 | for (size_t i = 0; i < 3; ++i) |
| 1638 | { |
| 1639 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1640 | } |
| 1641 | |
| 1642 | ASSERT(variable->getType().getBasicType() == EbtUInt); |
| 1643 | ASSERT(variable->getType().getObjectSize() == 3); |
| 1644 | |
| 1645 | TType type(variable->getType()); |
| 1646 | type.setQualifier(EvqConst); |
| 1647 | return intermediate.addConstantUnion(constArray, type, location); |
| 1648 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1649 | else |
| 1650 | { |
| 1651 | return intermediate.addSymbol(variable->getUniqueId(), variable->getName(), |
| 1652 | variable->getType(), location); |
| 1653 | } |
| 1654 | } |
| 1655 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1656 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1657 | // Initializers show up in several places in the grammar. Have one set of |
| 1658 | // code to handle them here. |
| 1659 | // |
Jamie Madill | 3b5c2da | 2014-08-19 15:23:32 -0400 | [diff] [blame] | 1660 | // Returns true on error, false if no error |
| 1661 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1662 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1663 | const TString &identifier, |
| 1664 | const TPublicType &pType, |
| 1665 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1666 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1667 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1668 | ASSERT(initNode != nullptr); |
| 1669 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1670 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1671 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1672 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1673 | if (type.isUnsizedArray()) |
| 1674 | { |
Olli Etuaho | 02bd82c | 2016-11-03 10:29:43 +0000 | [diff] [blame] | 1675 | // We have not checked yet whether the initializer actually is an array or not. |
| 1676 | if (initializer->isArray()) |
| 1677 | { |
| 1678 | type.setArraySize(initializer->getArraySize()); |
| 1679 | } |
| 1680 | else |
| 1681 | { |
| 1682 | // Having a non-array initializer for an unsized array will result in an error later, |
| 1683 | // so we don't generate an error message here. |
| 1684 | type.setArraySize(1u); |
| 1685 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1686 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1687 | if (!declareVariable(line, identifier, type, &variable)) |
| 1688 | { |
| 1689 | return true; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1690 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1691 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1692 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1693 | if (symbolTable.atGlobalLevel() && |
| 1694 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1695 | { |
| 1696 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1697 | // we want to steer developers towards only using constant expressions. |
| 1698 | error(line, "global variable initializers must be constant expressions", "="); |
| 1699 | return true; |
| 1700 | } |
| 1701 | if (globalInitWarning) |
| 1702 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1703 | warning( |
| 1704 | line, |
| 1705 | "global variable initializers should be constant expressions " |
| 1706 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1707 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1708 | } |
| 1709 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1710 | // |
| 1711 | // identifier must be of type constant, a global, or a temporary |
| 1712 | // |
| 1713 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1714 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1715 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1716 | error(line, " cannot initialize this type of qualifier ", |
| 1717 | variable->getType().getQualifierString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1718 | return true; |
| 1719 | } |
| 1720 | // |
| 1721 | // test for and propagate constant |
| 1722 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1723 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1724 | if (qualifier == EvqConst) |
| 1725 | { |
| 1726 | if (qualifier != initializer->getType().getQualifier()) |
| 1727 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1728 | std::stringstream reasonStream; |
| 1729 | reasonStream << "assigning non-constant to '" << variable->getType().getCompleteString() |
| 1730 | << "'"; |
| 1731 | std::string reason = reasonStream.str(); |
| 1732 | error(line, reason.c_str(), "="); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1733 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1734 | return true; |
| 1735 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1736 | if (type != initializer->getType()) |
| 1737 | { |
| 1738 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1739 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1740 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1741 | return true; |
| 1742 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1743 | |
| 1744 | // Save the constant folded value to the variable if possible. For example array |
| 1745 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1746 | // in the shader is avoided. |
| 1747 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1748 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1749 | if (initializer->getAsConstantUnion()) |
| 1750 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1751 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1752 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1753 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1754 | } |
| 1755 | else if (initializer->getAsSymbolNode()) |
| 1756 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1757 | const TSymbol *symbol = |
| 1758 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1759 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1760 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1761 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1762 | if (constArray) |
| 1763 | { |
| 1764 | variable->shareConstPointer(constArray); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1765 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1766 | return false; |
| 1767 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1768 | } |
| 1769 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1770 | |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1771 | TIntermSymbol *intermSymbol = intermediate.addSymbol( |
| 1772 | variable->getUniqueId(), variable->getName(), variable->getType(), line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1773 | *initNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1774 | if (*initNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1775 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1776 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
| 1777 | return true; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1778 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1779 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1780 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1781 | } |
| 1782 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 1783 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 1784 | { |
| 1785 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 1786 | typeSpecifier->getBasicType()); |
| 1787 | |
| 1788 | if (mShaderVersion < 300 && typeSpecifier->array) |
| 1789 | { |
| 1790 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 1791 | typeSpecifier->clearArrayness(); |
| 1792 | } |
| 1793 | } |
| 1794 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1795 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1796 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1797 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1798 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1799 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1800 | TPublicType returnType = typeSpecifier; |
| 1801 | returnType.qualifier = typeQualifier.qualifier; |
| 1802 | returnType.invariant = typeQualifier.invariant; |
| 1803 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1804 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1805 | returnType.precision = typeSpecifier.precision; |
| 1806 | |
| 1807 | if (typeQualifier.precision != EbpUndefined) |
| 1808 | { |
| 1809 | returnType.precision = typeQualifier.precision; |
| 1810 | } |
| 1811 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1812 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 1813 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1814 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1815 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 1816 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1817 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1818 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1819 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1820 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1821 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1822 | if (typeSpecifier.array) |
| 1823 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1824 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1825 | returnType.clearArrayness(); |
| 1826 | } |
| 1827 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1828 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1829 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1830 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1831 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1832 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1833 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1834 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1835 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1836 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1837 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1838 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1839 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1840 | } |
| 1841 | } |
| 1842 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1843 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1844 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1845 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1846 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1847 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1848 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 1849 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1850 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1851 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 1852 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1853 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1854 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1855 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1856 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1857 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1858 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1859 | } |
| 1860 | |
| 1861 | return returnType; |
| 1862 | } |
| 1863 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1864 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 1865 | const TPublicType &type, |
| 1866 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1867 | { |
| 1868 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1869 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1870 | { |
| 1871 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1872 | } |
| 1873 | |
| 1874 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 1875 | switch (qualifier) |
| 1876 | { |
| 1877 | case EvqVertexIn: |
| 1878 | // ESSL 3.00 section 4.3.4 |
| 1879 | if (type.array) |
| 1880 | { |
| 1881 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1882 | } |
| 1883 | // Vertex inputs with a struct type are disallowed in singleDeclarationErrorCheck |
| 1884 | return; |
| 1885 | case EvqFragmentOut: |
| 1886 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1887 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1888 | { |
| 1889 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1890 | } |
| 1891 | // Fragment outputs with a struct type are disallowed in singleDeclarationErrorCheck |
| 1892 | return; |
| 1893 | default: |
| 1894 | break; |
| 1895 | } |
| 1896 | |
| 1897 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 1898 | // restrictions. |
| 1899 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1900 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 1901 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1902 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 1903 | { |
| 1904 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 1905 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1906 | } |
| 1907 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1908 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1909 | { |
| 1910 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 1911 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 1912 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 1913 | if (type.array) |
| 1914 | { |
| 1915 | error(qualifierLocation, "cannot be an array of structures", |
| 1916 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1917 | } |
| 1918 | if (type.isStructureContainingArrays()) |
| 1919 | { |
| 1920 | error(qualifierLocation, "cannot be a structure containing an array", |
| 1921 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1922 | } |
| 1923 | if (type.isStructureContainingType(EbtStruct)) |
| 1924 | { |
| 1925 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 1926 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1927 | } |
| 1928 | if (type.isStructureContainingType(EbtBool)) |
| 1929 | { |
| 1930 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 1931 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1932 | } |
| 1933 | } |
| 1934 | } |
| 1935 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1936 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 1937 | { |
| 1938 | if (qualifier.getType() == QtStorage) |
| 1939 | { |
| 1940 | const TStorageQualifierWrapper &storageQualifier = |
| 1941 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 1942 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 1943 | !symbolTable.atGlobalLevel()) |
| 1944 | { |
| 1945 | error(storageQualifier.getLine(), |
| 1946 | "Local variables can only use the const storage qualifier.", |
| 1947 | storageQualifier.getQualifierString().c_str()); |
| 1948 | } |
| 1949 | } |
| 1950 | } |
| 1951 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1952 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1953 | const TSourceLoc &location) |
| 1954 | { |
| 1955 | if (memoryQualifier.readonly) |
| 1956 | { |
| 1957 | error(location, "Only allowed with images.", "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1958 | } |
| 1959 | if (memoryQualifier.writeonly) |
| 1960 | { |
| 1961 | error(location, "Only allowed with images.", "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1962 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1963 | if (memoryQualifier.coherent) |
| 1964 | { |
| 1965 | error(location, "Only allowed with images.", "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1966 | } |
| 1967 | if (memoryQualifier.restrictQualifier) |
| 1968 | { |
| 1969 | error(location, "Only allowed with images.", "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1970 | } |
| 1971 | if (memoryQualifier.volatileQualifier) |
| 1972 | { |
| 1973 | error(location, "Only allowed with images.", "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 1974 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1975 | } |
| 1976 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1977 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 1978 | TPublicType &publicType, |
| 1979 | const TSourceLoc &identifierOrTypeLocation, |
| 1980 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1981 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1982 | TType type(publicType); |
| 1983 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 1984 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 1985 | { |
| 1986 | TQualifier qualifier = type.getQualifier(); |
| 1987 | |
| 1988 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 1989 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 1990 | // affected variable declarations: |
| 1991 | // |
| 1992 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 1993 | // elsewhere, in TranslatorGLSL.) |
| 1994 | // |
| 1995 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 1996 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 1997 | // the way this is currently implemented we have to enable this compiler option before |
| 1998 | // parsing the shader and determining the shading language version it uses. If this were |
| 1999 | // implemented as a post-pass, the workaround could be more targeted. |
| 2000 | // |
| 2001 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 2002 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 2003 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 2004 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 2005 | { |
| 2006 | type.setInvariant(true); |
| 2007 | } |
| 2008 | } |
| 2009 | |
| 2010 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2011 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2012 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2013 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2014 | mDeferredSingleDeclarationErrorCheck = emptyDeclaration; |
| 2015 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2016 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2017 | declaration->setLine(identifierOrTypeLocation); |
| 2018 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2019 | if (emptyDeclaration) |
| 2020 | { |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 2021 | emptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2022 | } |
| 2023 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2024 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2025 | singleDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2026 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2027 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2028 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2029 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2030 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2031 | |
| 2032 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2033 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2034 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2035 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2036 | } |
| 2037 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2038 | // We append the symbol even if the declaration is empty, mainly because of struct declarations |
| 2039 | // that may just declare a type. |
| 2040 | declaration->appendDeclarator(symbol); |
| 2041 | |
| 2042 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2043 | } |
| 2044 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2045 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 2046 | const TSourceLoc &identifierLocation, |
| 2047 | const TString &identifier, |
| 2048 | const TSourceLoc &indexLocation, |
| 2049 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2050 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2051 | mDeferredSingleDeclarationErrorCheck = false; |
| 2052 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2053 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2054 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2055 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2056 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2057 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2058 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2059 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2060 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2061 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2062 | // Make the type an array even if size check failed. |
| 2063 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2064 | arrayType.setArraySize(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2065 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2066 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2067 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2068 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2069 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2070 | declaration->setLine(identifierLocation); |
| 2071 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2072 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2073 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2074 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2075 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2076 | declaration->appendDeclarator(symbol); |
| 2077 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2078 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2079 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2080 | } |
| 2081 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2082 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2083 | const TSourceLoc &identifierLocation, |
| 2084 | const TString &identifier, |
| 2085 | const TSourceLoc &initLocation, |
| 2086 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2087 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2088 | mDeferredSingleDeclarationErrorCheck = false; |
| 2089 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2090 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2091 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2092 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2093 | declaration->setLine(identifierLocation); |
| 2094 | |
| 2095 | TIntermBinary *initNode = nullptr; |
| 2096 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2097 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2098 | if (initNode) |
| 2099 | { |
| 2100 | declaration->appendDeclarator(initNode); |
| 2101 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2102 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2103 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2104 | } |
| 2105 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2106 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2107 | TPublicType &publicType, |
| 2108 | const TSourceLoc &identifierLocation, |
| 2109 | const TString &identifier, |
| 2110 | const TSourceLoc &indexLocation, |
| 2111 | TIntermTyped *indexExpression, |
| 2112 | const TSourceLoc &initLocation, |
| 2113 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2114 | { |
| 2115 | mDeferredSingleDeclarationErrorCheck = false; |
| 2116 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2117 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2118 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2119 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2120 | |
| 2121 | TPublicType arrayType(publicType); |
| 2122 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2123 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2124 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2125 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2126 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2127 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2128 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2129 | } |
| 2130 | // Make the type an array even if size check failed. |
| 2131 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2132 | arrayType.setArraySize(size); |
| 2133 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2134 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2135 | declaration->setLine(identifierLocation); |
| 2136 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2137 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2138 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2139 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2140 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2141 | if (initNode) |
| 2142 | { |
| 2143 | declaration->appendDeclarator(initNode); |
| 2144 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2145 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2146 | |
| 2147 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2148 | } |
| 2149 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2150 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2151 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2152 | const TSourceLoc &identifierLoc, |
| 2153 | const TString *identifier, |
| 2154 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2155 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2156 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2157 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2158 | if (!typeQualifier.invariant) |
| 2159 | { |
| 2160 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 2161 | return nullptr; |
| 2162 | } |
| 2163 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2164 | { |
| 2165 | return nullptr; |
| 2166 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2167 | if (!symbol) |
| 2168 | { |
| 2169 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2170 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2171 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2172 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2173 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2174 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2175 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2176 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2177 | if (typeQualifier.precision != EbpUndefined) |
| 2178 | { |
| 2179 | error(identifierLoc, "invariant declaration specifies precision", |
| 2180 | getPrecisionString(typeQualifier.precision)); |
| 2181 | } |
| 2182 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2183 | { |
| 2184 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2185 | } |
| 2186 | |
| 2187 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
| 2188 | ASSERT(variable); |
| 2189 | const TType &type = variable->getType(); |
| 2190 | |
| 2191 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2192 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2193 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2194 | |
| 2195 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 2196 | |
| 2197 | TIntermSymbol *intermSymbol = |
| 2198 | intermediate.addSymbol(variable->getUniqueId(), *identifier, type, identifierLoc); |
| 2199 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2200 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2201 | } |
| 2202 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2203 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2204 | const TSourceLoc &identifierLocation, |
| 2205 | const TString &identifier, |
| 2206 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2207 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2208 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2209 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2210 | if (mDeferredSingleDeclarationErrorCheck) |
| 2211 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2212 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2213 | mDeferredSingleDeclarationErrorCheck = false; |
| 2214 | } |
| 2215 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2216 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2217 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2218 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2219 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2220 | TVariable *variable = nullptr; |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2221 | TType type(publicType); |
| 2222 | declareVariable(identifierLocation, identifier, type, &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2223 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2224 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierLocation); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2225 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2226 | { |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2227 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2228 | declarationOut->appendDeclarator(symbol); |
| 2229 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2230 | } |
| 2231 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2232 | void TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 2233 | const TSourceLoc &identifierLocation, |
| 2234 | const TString &identifier, |
| 2235 | const TSourceLoc &arrayLocation, |
| 2236 | TIntermTyped *indexExpression, |
| 2237 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2238 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2239 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2240 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2241 | if (mDeferredSingleDeclarationErrorCheck) |
| 2242 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2243 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2244 | mDeferredSingleDeclarationErrorCheck = false; |
| 2245 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2246 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2247 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2248 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2249 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2250 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2251 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2252 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2253 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2254 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 693c9aa | 2015-04-07 17:50:36 +0300 | [diff] [blame] | 2255 | arrayType.setArraySize(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2256 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2257 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2258 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2259 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2260 | TIntermSymbol *symbol = |
| 2261 | intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2262 | if (variable && symbol) |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2263 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2264 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2265 | declarationOut->appendDeclarator(symbol); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2266 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2267 | } |
| 2268 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2269 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2270 | const TSourceLoc &identifierLocation, |
| 2271 | const TString &identifier, |
| 2272 | const TSourceLoc &initLocation, |
| 2273 | TIntermTyped *initializer, |
| 2274 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2275 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2276 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2277 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2278 | if (mDeferredSingleDeclarationErrorCheck) |
| 2279 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2280 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2281 | mDeferredSingleDeclarationErrorCheck = false; |
| 2282 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2283 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2284 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2285 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2286 | TIntermBinary *initNode = nullptr; |
| 2287 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2288 | { |
| 2289 | // |
| 2290 | // build the intermediate representation |
| 2291 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2292 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2293 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2294 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2295 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2296 | } |
| 2297 | } |
| 2298 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2299 | void TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
| 2300 | const TSourceLoc &identifierLocation, |
| 2301 | const TString &identifier, |
| 2302 | const TSourceLoc &indexLocation, |
| 2303 | TIntermTyped *indexExpression, |
| 2304 | const TSourceLoc &initLocation, |
| 2305 | TIntermTyped *initializer, |
| 2306 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2307 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2308 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2309 | // not performed. |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2310 | if (mDeferredSingleDeclarationErrorCheck) |
| 2311 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2312 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2313 | mDeferredSingleDeclarationErrorCheck = false; |
| 2314 | } |
| 2315 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2316 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2317 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2318 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2319 | |
| 2320 | TPublicType arrayType(publicType); |
| 2321 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2322 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2323 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2324 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2325 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2326 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2327 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2328 | } |
| 2329 | // Make the type an array even if size check failed. |
| 2330 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2331 | arrayType.setArraySize(size); |
| 2332 | |
| 2333 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2334 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2335 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2336 | { |
| 2337 | if (initNode) |
| 2338 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2339 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2340 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2341 | } |
| 2342 | } |
| 2343 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2344 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2345 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2346 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2347 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2348 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2349 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2350 | typeQualifier.line); |
| 2351 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2352 | // It should never be the case, but some strange parser errors can send us here. |
| 2353 | if (layoutQualifier.isEmpty()) |
| 2354 | { |
| 2355 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2356 | return; |
| 2357 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2358 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2359 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2360 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2361 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2362 | return; |
| 2363 | } |
| 2364 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2365 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 2366 | |
| 2367 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2368 | |
| 2369 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2370 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2371 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 2372 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2373 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2374 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2375 | if (mComputeShaderLocalSizeDeclared && |
| 2376 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 2377 | { |
| 2378 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 2379 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2380 | return; |
| 2381 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2382 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2383 | if (mShaderVersion < 310) |
| 2384 | { |
| 2385 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2386 | return; |
| 2387 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2388 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2389 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2390 | { |
| 2391 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2392 | return; |
| 2393 | } |
| 2394 | |
| 2395 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 2396 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 2397 | |
| 2398 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 2399 | maxComputeWorkGroupSize->getConstPointer(); |
| 2400 | |
| 2401 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 2402 | { |
| 2403 | if (layoutQualifier.localSize[i] != -1) |
| 2404 | { |
| 2405 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 2406 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 2407 | if (mComputeShaderLocalSize[i] < 1 || |
| 2408 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 2409 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2410 | std::stringstream reasonStream; |
| 2411 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 2412 | << maxComputeWorkGroupSizeValue; |
| 2413 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2414 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2415 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2416 | return; |
| 2417 | } |
| 2418 | } |
| 2419 | } |
| 2420 | |
| 2421 | mComputeShaderLocalSizeDeclared = true; |
| 2422 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2423 | else if (mMultiviewAvailable && |
| 2424 | (isExtensionEnabled("GL_OVR_multiview") || isExtensionEnabled("GL_OVR_multiview2")) && |
| 2425 | typeQualifier.qualifier == EvqVertexIn) |
| 2426 | { |
| 2427 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 2428 | // specification. |
| 2429 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 2430 | { |
| 2431 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 2432 | "layout"); |
| 2433 | return; |
| 2434 | } |
| 2435 | |
| 2436 | if (layoutQualifier.numViews == -1) |
| 2437 | { |
| 2438 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 2439 | return; |
| 2440 | } |
| 2441 | |
| 2442 | if (layoutQualifier.numViews > mMaxNumViews) |
| 2443 | { |
| 2444 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 2445 | "layout"); |
| 2446 | return; |
| 2447 | } |
| 2448 | |
| 2449 | mNumViews = layoutQualifier.numViews; |
| 2450 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2451 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2452 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2453 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2454 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2455 | return; |
| 2456 | } |
| 2457 | |
| 2458 | if (typeQualifier.qualifier != EvqUniform) |
| 2459 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2460 | error(typeQualifier.line, "invalid qualifier: global layout must be uniform", |
| 2461 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2462 | return; |
| 2463 | } |
| 2464 | |
| 2465 | if (mShaderVersion < 300) |
| 2466 | { |
| 2467 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 2468 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2469 | return; |
| 2470 | } |
| 2471 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2472 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2473 | |
| 2474 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 2475 | { |
| 2476 | mDefaultMatrixPacking = layoutQualifier.matrixPacking; |
| 2477 | } |
| 2478 | |
| 2479 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 2480 | { |
| 2481 | mDefaultBlockStorage = layoutQualifier.blockStorage; |
| 2482 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2483 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2484 | } |
| 2485 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2486 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 2487 | const TFunction &function, |
| 2488 | const TSourceLoc &location, |
| 2489 | bool insertParametersToSymbolTable) |
| 2490 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 2491 | TIntermFunctionPrototype *prototype = |
| 2492 | new TIntermFunctionPrototype(function.getReturnType(), TSymbolUniqueId(function)); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2493 | // TODO(oetuaho@nvidia.com): Instead of converting the function information here, the node could |
| 2494 | // point to the data that already exists in the symbol table. |
| 2495 | prototype->getFunctionSymbolInfo()->setFromFunction(function); |
| 2496 | prototype->setLine(location); |
| 2497 | |
| 2498 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 2499 | { |
| 2500 | const TConstParameter ¶m = function.getParam(i); |
| 2501 | |
| 2502 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 2503 | // be used for unused args). |
| 2504 | if (param.name != nullptr) |
| 2505 | { |
| 2506 | TVariable *variable = new TVariable(param.name, *param.type); |
| 2507 | |
| 2508 | // Insert the parameter in the symbol table. |
| 2509 | if (insertParametersToSymbolTable && !symbolTable.declare(variable)) |
| 2510 | { |
| 2511 | error(location, "redefinition", variable->getName().c_str()); |
| 2512 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2513 | continue; |
| 2514 | } |
| 2515 | TIntermSymbol *symbol = intermediate.addSymbol( |
| 2516 | variable->getUniqueId(), variable->getName(), variable->getType(), location); |
| 2517 | prototype->appendParameter(symbol); |
| 2518 | } |
| 2519 | else |
| 2520 | { |
| 2521 | prototype->appendParameter(intermediate.addSymbol(0, "", *param.type, location)); |
| 2522 | } |
| 2523 | } |
| 2524 | return prototype; |
| 2525 | } |
| 2526 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 2527 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 2528 | const TFunction &parsedFunction, |
| 2529 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2530 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2531 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 2532 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 2533 | // function is declared multiple times. |
| 2534 | TFunction *function = static_cast<TFunction *>( |
| 2535 | symbolTable.find(parsedFunction.getMangledName(), getShaderVersion())); |
| 2536 | if (function->hasPrototypeDeclaration() && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2537 | { |
| 2538 | // ESSL 1.00.17 section 4.2.7. |
| 2539 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 2540 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2541 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2542 | function->setHasPrototypeDeclaration(); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2543 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2544 | TIntermFunctionPrototype *prototype = |
| 2545 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2546 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2547 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2548 | |
| 2549 | if (!symbolTable.atGlobalLevel()) |
| 2550 | { |
| 2551 | // ESSL 3.00.4 section 4.2.4. |
| 2552 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2553 | } |
| 2554 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2555 | return prototype; |
| 2556 | } |
| 2557 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2558 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2559 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2560 | TIntermBlock *functionBody, |
| 2561 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2562 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2563 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2564 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 2565 | { |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2566 | error(location, "function does not return a value:", |
| 2567 | functionPrototype->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2568 | } |
| 2569 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2570 | if (functionBody == nullptr) |
| 2571 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2572 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2573 | functionBody->setLine(location); |
| 2574 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2575 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2576 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2577 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2578 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2579 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2580 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2581 | } |
| 2582 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2583 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
| 2584 | TFunction **function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2585 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2586 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2587 | ASSERT(function); |
| 2588 | ASSERT(*function); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2589 | const TSymbol *builtIn = |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2590 | symbolTable.findBuiltIn((*function)->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2591 | |
| 2592 | if (builtIn) |
| 2593 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2594 | error(location, "built-in functions cannot be redefined", (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2595 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2596 | else |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2597 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2598 | TFunction *prevDec = static_cast<TFunction *>( |
| 2599 | symbolTable.find((*function)->getMangledName(), getShaderVersion())); |
| 2600 | |
| 2601 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function as it |
| 2602 | // would have just been put in the symbol table. Otherwise, we're looking up an earlier |
| 2603 | // occurance. |
| 2604 | if (*function != prevDec) |
| 2605 | { |
| 2606 | // Swap the parameters of the previous declaration to the parameters of the function |
| 2607 | // definition (parameter names may differ). |
| 2608 | prevDec->swapParameters(**function); |
| 2609 | |
| 2610 | // The function definition will share the same symbol as any previous declaration. |
| 2611 | *function = prevDec; |
| 2612 | } |
| 2613 | |
| 2614 | if ((*function)->isDefined()) |
| 2615 | { |
| 2616 | error(location, "function already has a body", (*function)->getName().c_str()); |
| 2617 | } |
| 2618 | |
| 2619 | (*function)->setDefined(); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2620 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2621 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2622 | // Remember the return type for later checking for return statements. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2623 | mCurrentFunctionType = &((*function)->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2624 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2625 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 2626 | *prototypeOut = createPrototypeNodeFromFunction(**function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2627 | setLoopNestingLevel(0); |
| 2628 | } |
| 2629 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2630 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2631 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2632 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2633 | // We don't know at this point whether this is a function definition or a prototype. |
| 2634 | // The definition production code will check for redefinitions. |
| 2635 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2636 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2637 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 2638 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2639 | // |
| 2640 | TFunction *prevDec = |
| 2641 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2642 | |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2643 | if (getShaderVersion() >= 300 && |
| 2644 | symbolTable.hasUnmangledBuiltInForShaderVersion(function->getName().c_str(), |
| 2645 | getShaderVersion())) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2646 | { |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 2647 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as functions. |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2648 | // Therefore overloading or redefining builtin functions is an error. |
| 2649 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 2650 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2651 | } |
| 2652 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2653 | { |
| 2654 | if (prevDec->getReturnType() != function->getReturnType()) |
| 2655 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2656 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2657 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2658 | } |
| 2659 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 2660 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2661 | if (prevDec->getParam(i).type->getQualifier() != |
| 2662 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2663 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2664 | error(location, |
| 2665 | "function must have the same parameter qualifiers in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2666 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2667 | } |
| 2668 | } |
| 2669 | } |
| 2670 | |
| 2671 | // |
| 2672 | // Check for previously declared variables using the same name. |
| 2673 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2674 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2675 | if (prevSym) |
| 2676 | { |
| 2677 | if (!prevSym->isFunction()) |
| 2678 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2679 | error(location, "redefinition of a function", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2680 | } |
| 2681 | } |
| 2682 | else |
| 2683 | { |
| 2684 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2685 | symbolTable.getOuterLevel()->insertUnmangled(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2686 | } |
| 2687 | |
| 2688 | // We're at the inner scope level of the function's arguments and body statement. |
| 2689 | // Add the function prototype to the surrounding scope instead. |
| 2690 | symbolTable.getOuterLevel()->insert(function); |
| 2691 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 2692 | // Raise error message if main function takes any parameters or return anything other than void |
| 2693 | if (function->getName() == "main") |
| 2694 | { |
| 2695 | if (function->getParamCount() > 0) |
| 2696 | { |
| 2697 | error(location, "function cannot take any parameter(s)", "main"); |
| 2698 | } |
| 2699 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 2700 | { |
| 2701 | error(location, "main function cannot return a value", |
| 2702 | function->getReturnType().getBasicString()); |
| 2703 | } |
| 2704 | } |
| 2705 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2706 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2707 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 2708 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2709 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 2710 | // |
| 2711 | return function; |
| 2712 | } |
| 2713 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2714 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 2715 | const TString *name, |
| 2716 | const TSourceLoc &location) |
| 2717 | { |
| 2718 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 2719 | { |
| 2720 | error(location, "no qualifiers allowed for function return", |
| 2721 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2722 | } |
| 2723 | if (!type.layoutQualifier.isEmpty()) |
| 2724 | { |
| 2725 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2726 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2727 | // make sure a sampler or an image is not involved as well... |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2728 | checkIsNotSampler(location, type.typeSpecifierNonArray, |
| 2729 | "samplers can't be function return values"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2730 | checkIsNotImage(location, type.typeSpecifierNonArray, "images can't be function return values"); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2731 | if (mShaderVersion < 300) |
| 2732 | { |
| 2733 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 2734 | // return values in ESSL 1.00. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2735 | ASSERT(type.arraySize == 0 || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2736 | |
| 2737 | if (type.isStructureContainingArrays()) |
| 2738 | { |
| 2739 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 2740 | error(location, "structures containing arrays can't be function return values", |
| 2741 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2742 | } |
| 2743 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2744 | |
| 2745 | // Add the function as a prototype after parsing it (we do not support recursion) |
| 2746 | return new TFunction(name, new TType(type)); |
| 2747 | } |
| 2748 | |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2749 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicTypeIn) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2750 | { |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2751 | TPublicType publicType = publicTypeIn; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2752 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2753 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2754 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 2755 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2756 | } |
| 2757 | |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2758 | TOperator op = EOpNull; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2759 | if (publicType.getUserDef()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2760 | { |
| 2761 | op = EOpConstructStruct; |
| 2762 | } |
| 2763 | else |
| 2764 | { |
Geoff Lang | 156d719 | 2016-07-21 16:11:00 -0400 | [diff] [blame] | 2765 | op = sh::TypeToConstructorOperator(TType(publicType)); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2766 | if (op == EOpNull) |
| 2767 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2768 | error(publicType.getLine(), "cannot construct this type", |
| 2769 | getBasicString(publicType.getBasicType())); |
| 2770 | publicType.setBasicType(EbtFloat); |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2771 | op = EOpConstructFloat; |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2772 | } |
| 2773 | } |
| 2774 | |
Dmitry Skiba | 7f17a50 | 2015-06-22 15:08:39 -0700 | [diff] [blame] | 2775 | const TType *type = new TType(publicType); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2776 | return new TFunction(nullptr, type, op); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2777 | } |
| 2778 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2779 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 2780 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2781 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2782 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2783 | // |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2784 | TIntermTyped *TParseContext::addConstructor(TIntermSequence *arguments, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2785 | TOperator op, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2786 | TType type, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2787 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2788 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2789 | if (type.isUnsizedArray()) |
| 2790 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2791 | if (arguments->empty()) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 2792 | { |
| 2793 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 2794 | type.setArraySize(1u); |
| 2795 | return TIntermTyped::CreateZero(type); |
| 2796 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2797 | type.setArraySize(static_cast<unsigned int>(arguments->size())); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2798 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2799 | |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2800 | if (!checkConstructorArguments(line, arguments, op, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2801 | { |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 2802 | return TIntermTyped::CreateZero(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2803 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2804 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 2805 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2806 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2807 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2808 | TIntermTyped *constConstructor = |
| 2809 | intermediate.foldAggregateBuiltIn(constructorNode, mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2810 | if (constConstructor) |
| 2811 | { |
| 2812 | return constConstructor; |
| 2813 | } |
| 2814 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 2815 | return constructorNode; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2816 | } |
| 2817 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2818 | // |
| 2819 | // Interface/uniform blocks |
| 2820 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2821 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2822 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2823 | const TSourceLoc &nameLine, |
| 2824 | const TString &blockName, |
| 2825 | TFieldList *fieldList, |
| 2826 | const TString *instanceName, |
| 2827 | const TSourceLoc &instanceLine, |
| 2828 | TIntermTyped *arrayIndex, |
| 2829 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2830 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2831 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2832 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2833 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2834 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2835 | if (typeQualifier.qualifier != EvqUniform) |
| 2836 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2837 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform", |
| 2838 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2839 | } |
| 2840 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2841 | if (typeQualifier.invariant) |
| 2842 | { |
| 2843 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 2844 | } |
| 2845 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2846 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 2847 | |
| 2848 | // TODO(oetuaho): Remove this and support binding for blocks. |
| 2849 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2850 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2851 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 2852 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2853 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2854 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2855 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2856 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 2857 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2858 | blockLayoutQualifier.matrixPacking = mDefaultMatrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2859 | } |
| 2860 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2861 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 2862 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2863 | blockLayoutQualifier.blockStorage = mDefaultBlockStorage; |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2864 | } |
| 2865 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2866 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2867 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2868 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 2869 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2870 | TSymbol *blockNameSymbol = new TInterfaceBlockName(&blockName); |
| 2871 | if (!symbolTable.declare(blockNameSymbol)) |
| 2872 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2873 | error(nameLine, "redefinition of an interface block name", blockName.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2874 | } |
| 2875 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2876 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2877 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2878 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2879 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2880 | TType *fieldType = field->type(); |
| 2881 | if (IsSampler(fieldType->getBasicType())) |
| 2882 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2883 | error(field->line(), |
| 2884 | "unsupported type - sampler types are not allowed in interface blocks", |
| 2885 | fieldType->getBasicString()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2886 | } |
| 2887 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2888 | if (IsImage(fieldType->getBasicType())) |
| 2889 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2890 | error(field->line(), |
| 2891 | "unsupported type - image types are not allowed in interface blocks", |
| 2892 | fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2893 | } |
| 2894 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2895 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2896 | switch (qualifier) |
| 2897 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2898 | case EvqGlobal: |
| 2899 | case EvqUniform: |
| 2900 | break; |
| 2901 | default: |
| 2902 | error(field->line(), "invalid qualifier on interface block member", |
| 2903 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2904 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2905 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2906 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2907 | if (fieldType->isInvariant()) |
| 2908 | { |
| 2909 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 2910 | } |
| 2911 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2912 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2913 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2914 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2915 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2916 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2917 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2918 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 2919 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2920 | } |
| 2921 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2922 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2923 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2924 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2925 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2926 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2927 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2928 | warning(field->line(), |
| 2929 | "extraneous layout qualifier: only has an effect on matrix types", |
| 2930 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2931 | } |
| 2932 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2933 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2934 | } |
| 2935 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2936 | // add array index |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2937 | unsigned int arraySize = 0; |
| 2938 | if (arrayIndex != nullptr) |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2939 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2940 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2941 | } |
| 2942 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2943 | TInterfaceBlock *interfaceBlock = |
| 2944 | new TInterfaceBlock(&blockName, fieldList, instanceName, arraySize, blockLayoutQualifier); |
| 2945 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier, |
| 2946 | arraySize); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2947 | |
| 2948 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2949 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2950 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2951 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2952 | { |
| 2953 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2954 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2955 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2956 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2957 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2958 | |
| 2959 | // set parent pointer of the field variable |
| 2960 | fieldType->setInterfaceBlock(interfaceBlock); |
| 2961 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2962 | TVariable *fieldVariable = new TVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2963 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 2964 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2965 | if (!symbolTable.declare(fieldVariable)) |
| 2966 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2967 | error(field->line(), "redefinition of an interface block member name", |
| 2968 | field->name().c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2969 | } |
| 2970 | } |
| 2971 | } |
| 2972 | else |
| 2973 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2974 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 2975 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2976 | // add a symbol for this interface block |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2977 | TVariable *instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2978 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2979 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2980 | if (!symbolTable.declare(instanceTypeDef)) |
| 2981 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2982 | error(instanceLine, "redefinition of an interface block instance name", |
| 2983 | instanceName->c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2984 | } |
| 2985 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2986 | symbolId = instanceTypeDef->getUniqueId(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2987 | symbolName = instanceTypeDef->getName(); |
| 2988 | } |
| 2989 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2990 | TIntermSymbol *blockSymbol = |
| 2991 | intermediate.addSymbol(symbolId, symbolName, interfaceBlockType, typeQualifier.line); |
| 2992 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2993 | declaration->appendDeclarator(blockSymbol); |
| 2994 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2995 | |
| 2996 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2997 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2998 | } |
| 2999 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 3000 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3001 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3002 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3003 | |
| 3004 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3005 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3006 | if (mStructNestingLevel > 1) |
| 3007 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3008 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3009 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3010 | } |
| 3011 | |
| 3012 | void TParseContext::exitStructDeclaration() |
| 3013 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3014 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3015 | } |
| 3016 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3017 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3018 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3019 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3020 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3021 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3022 | } |
| 3023 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3024 | if (field.type()->getBasicType() != EbtStruct) |
| 3025 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3026 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3027 | } |
| 3028 | |
| 3029 | // We're already inside a structure definition at this point, so add |
| 3030 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3031 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 3032 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3033 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3034 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 3035 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3036 | std::string reason = reasonStream.str(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3037 | error(line, reason.c_str(), field.name().c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3038 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3039 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3040 | } |
| 3041 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3042 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3043 | // Parse an array index expression |
| 3044 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3045 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 3046 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3047 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3048 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3049 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 3050 | { |
| 3051 | if (baseExpression->getAsSymbolNode()) |
| 3052 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3053 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 3054 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3055 | } |
| 3056 | else |
| 3057 | { |
| 3058 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 3059 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3060 | |
| 3061 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 3062 | unionArray->setFConst(0.0f); |
| 3063 | return intermediate.addConstantUnion(unionArray, TType(EbtFloat, EbpHigh, EvqConst), |
| 3064 | location); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3065 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 3066 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 3067 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 3068 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3069 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 3070 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 3071 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 3072 | // index is a constant expression. |
| 3073 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 3074 | { |
| 3075 | if (baseExpression->isInterfaceBlock()) |
| 3076 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3077 | error(location, |
| 3078 | "array indexes for interface blocks arrays must be constant integral expressions", |
| 3079 | "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3080 | } |
| 3081 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 3082 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3083 | error(location, |
| 3084 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3085 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3086 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3087 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3088 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3089 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3090 | } |
| 3091 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3092 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3093 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3094 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3095 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3096 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3097 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3098 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3099 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3100 | int index = indexConstantUnion->getIConst(0); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3101 | |
| 3102 | int safeIndex = -1; |
| 3103 | |
| 3104 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3105 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3106 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3107 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3108 | if (mShaderSpec == SH_WEBGL2_SPEC) |
| 3109 | { |
| 3110 | // Error has been already generated if index is not const. |
| 3111 | if (indexExpression->getQualifier() == EvqConst) |
| 3112 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3113 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3114 | } |
| 3115 | safeIndex = 0; |
| 3116 | } |
| 3117 | else if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
| 3118 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3119 | outOfRangeError(outOfRangeIndexIsError, location, |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3120 | "array index for gl_FragData must be zero when " |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3121 | "GL_EXT_draw_buffers is disabled", |
| 3122 | "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3123 | safeIndex = 0; |
| 3124 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3125 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3126 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 3127 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3128 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3129 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3130 | baseExpression->getArraySize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3131 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3132 | } |
| 3133 | } |
| 3134 | else if (baseExpression->isMatrix()) |
| 3135 | { |
| 3136 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3137 | baseExpression->getType().getCols(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3138 | "matrix field selection out of range"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3139 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3140 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3141 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3142 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3143 | baseExpression->getType().getNominalSize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3144 | "vector field selection out of range"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3145 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3146 | |
| 3147 | ASSERT(safeIndex >= 0); |
| 3148 | // Data of constant unions can't be changed, because it may be shared with other |
| 3149 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 3150 | // sanitized object. |
| 3151 | if (safeIndex != index) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3152 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3153 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 3154 | safeConstantUnion->setIConst(safeIndex); |
| 3155 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3156 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3157 | |
| 3158 | return intermediate.addIndex(EOpIndexDirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3159 | mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3160 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3161 | else |
| 3162 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3163 | return intermediate.addIndex(EOpIndexIndirect, baseExpression, indexExpression, location, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3164 | mDiagnostics); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3165 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3166 | } |
| 3167 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3168 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 3169 | const TSourceLoc &location, |
| 3170 | int index, |
| 3171 | int arraySize, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3172 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3173 | { |
| 3174 | if (index >= arraySize || index < 0) |
| 3175 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3176 | std::stringstream reasonStream; |
| 3177 | reasonStream << reason << " '" << index << "'"; |
| 3178 | std::string token = reasonStream.str(); |
| 3179 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3180 | if (index < 0) |
| 3181 | { |
| 3182 | return 0; |
| 3183 | } |
| 3184 | else |
| 3185 | { |
| 3186 | return arraySize - 1; |
| 3187 | } |
| 3188 | } |
| 3189 | return index; |
| 3190 | } |
| 3191 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3192 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 3193 | const TSourceLoc &dotLocation, |
| 3194 | const TString &fieldString, |
| 3195 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3196 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3197 | if (baseExpression->isArray()) |
| 3198 | { |
| 3199 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3200 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3201 | } |
| 3202 | |
| 3203 | if (baseExpression->isVector()) |
| 3204 | { |
| 3205 | TVectorFields fields; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3206 | if (!parseVectorFields(fieldString, baseExpression->getNominalSize(), fields, |
| 3207 | fieldLocation)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3208 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3209 | fields.num = 1; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3210 | fields.offsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3211 | } |
| 3212 | |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 3213 | return TIntermediate::AddSwizzle(baseExpression, fields, dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3214 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3215 | else if (baseExpression->getBasicType() == EbtStruct) |
| 3216 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3217 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3218 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3219 | { |
| 3220 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3221 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3222 | } |
| 3223 | else |
| 3224 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3225 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3226 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3227 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3228 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3229 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3230 | { |
| 3231 | fieldFound = true; |
| 3232 | break; |
| 3233 | } |
| 3234 | } |
| 3235 | if (fieldFound) |
| 3236 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3237 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3238 | index->setLine(fieldLocation); |
| 3239 | return intermediate.addIndex(EOpIndexDirectStruct, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3240 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3241 | } |
| 3242 | else |
| 3243 | { |
| 3244 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3245 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3246 | } |
| 3247 | } |
| 3248 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3249 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3250 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3251 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3252 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3253 | { |
| 3254 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3255 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3256 | } |
| 3257 | else |
| 3258 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3259 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3260 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3261 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3262 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3263 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3264 | { |
| 3265 | fieldFound = true; |
| 3266 | break; |
| 3267 | } |
| 3268 | } |
| 3269 | if (fieldFound) |
| 3270 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3271 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3272 | index->setLine(fieldLocation); |
| 3273 | return intermediate.addIndex(EOpIndexDirectInterfaceBlock, baseExpression, index, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3274 | dotLocation, mDiagnostics); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3275 | } |
| 3276 | else |
| 3277 | { |
| 3278 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3279 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3280 | } |
| 3281 | } |
| 3282 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3283 | else |
| 3284 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3285 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3286 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3287 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3288 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3289 | } |
| 3290 | else |
| 3291 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3292 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3293 | " field selection requires structure, vector, or interface block on left hand " |
| 3294 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3295 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3296 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3297 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3298 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3299 | } |
| 3300 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3301 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3302 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3303 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3304 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3305 | |
| 3306 | if (qualifierType == "shared") |
| 3307 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3308 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3309 | { |
| 3310 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 3311 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3312 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3313 | } |
| 3314 | else if (qualifierType == "packed") |
| 3315 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3316 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3317 | { |
| 3318 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 3319 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3320 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3321 | } |
| 3322 | else if (qualifierType == "std140") |
| 3323 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3324 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3325 | } |
| 3326 | else if (qualifierType == "row_major") |
| 3327 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3328 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3329 | } |
| 3330 | else if (qualifierType == "column_major") |
| 3331 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3332 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3333 | } |
| 3334 | else if (qualifierType == "location") |
| 3335 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3336 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
| 3337 | qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3338 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3339 | else if (qualifierType == "yuv" && isExtensionEnabled("GL_EXT_YUV_target") && |
| 3340 | mShaderType == GL_FRAGMENT_SHADER) |
| 3341 | { |
| 3342 | qualifier.yuv = true; |
| 3343 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3344 | else if (qualifierType == "rgba32f") |
| 3345 | { |
| 3346 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3347 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 3348 | } |
| 3349 | else if (qualifierType == "rgba16f") |
| 3350 | { |
| 3351 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3352 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 3353 | } |
| 3354 | else if (qualifierType == "r32f") |
| 3355 | { |
| 3356 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3357 | qualifier.imageInternalFormat = EiifR32F; |
| 3358 | } |
| 3359 | else if (qualifierType == "rgba8") |
| 3360 | { |
| 3361 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3362 | qualifier.imageInternalFormat = EiifRGBA8; |
| 3363 | } |
| 3364 | else if (qualifierType == "rgba8_snorm") |
| 3365 | { |
| 3366 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3367 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 3368 | } |
| 3369 | else if (qualifierType == "rgba32i") |
| 3370 | { |
| 3371 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3372 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 3373 | } |
| 3374 | else if (qualifierType == "rgba16i") |
| 3375 | { |
| 3376 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3377 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 3378 | } |
| 3379 | else if (qualifierType == "rgba8i") |
| 3380 | { |
| 3381 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3382 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 3383 | } |
| 3384 | else if (qualifierType == "r32i") |
| 3385 | { |
| 3386 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3387 | qualifier.imageInternalFormat = EiifR32I; |
| 3388 | } |
| 3389 | else if (qualifierType == "rgba32ui") |
| 3390 | { |
| 3391 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3392 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 3393 | } |
| 3394 | else if (qualifierType == "rgba16ui") |
| 3395 | { |
| 3396 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3397 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 3398 | } |
| 3399 | else if (qualifierType == "rgba8ui") |
| 3400 | { |
| 3401 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3402 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 3403 | } |
| 3404 | else if (qualifierType == "r32ui") |
| 3405 | { |
| 3406 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3407 | qualifier.imageInternalFormat = EiifR32UI; |
| 3408 | } |
| 3409 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3410 | else |
| 3411 | { |
| 3412 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3413 | } |
| 3414 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3415 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3416 | } |
| 3417 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3418 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 3419 | const TSourceLoc &qualifierTypeLine, |
| 3420 | int intValue, |
| 3421 | const TSourceLoc &intValueLine, |
| 3422 | const std::string &intValueString, |
| 3423 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3424 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3425 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3426 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3427 | if (intValue < 1) |
| 3428 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3429 | std::stringstream reasonStream; |
| 3430 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 3431 | std::string reason = reasonStream.str(); |
| 3432 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3433 | } |
| 3434 | (*localSize)[index] = intValue; |
| 3435 | } |
| 3436 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3437 | void TParseContext::parseNumViews(int intValue, |
| 3438 | const TSourceLoc &intValueLine, |
| 3439 | const std::string &intValueString, |
| 3440 | int *numViews) |
| 3441 | { |
| 3442 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 3443 | // specification. |
| 3444 | if (intValue < 1) |
| 3445 | { |
| 3446 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 3447 | } |
| 3448 | *numViews = intValue; |
| 3449 | } |
| 3450 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3451 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3452 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3453 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3454 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3455 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3456 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3457 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3458 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3459 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3460 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3461 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 3462 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3463 | if (intValue < 0) |
| 3464 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3465 | error(intValueLine, "out of range: location must be non-negative", |
| 3466 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3467 | } |
| 3468 | else |
| 3469 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 3470 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 3471 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3472 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3473 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3474 | else if (qualifierType == "binding") |
| 3475 | { |
| 3476 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3477 | if (intValue < 0) |
| 3478 | { |
| 3479 | error(intValueLine, "out of range: binding must be non-negative", |
| 3480 | intValueString.c_str()); |
| 3481 | } |
| 3482 | else |
| 3483 | { |
| 3484 | qualifier.binding = intValue; |
| 3485 | } |
| 3486 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3487 | else if (qualifierType == "local_size_x") |
| 3488 | { |
| 3489 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 3490 | &qualifier.localSize); |
| 3491 | } |
| 3492 | else if (qualifierType == "local_size_y") |
| 3493 | { |
| 3494 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 3495 | &qualifier.localSize); |
| 3496 | } |
| 3497 | else if (qualifierType == "local_size_z") |
| 3498 | { |
| 3499 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 3500 | &qualifier.localSize); |
| 3501 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3502 | else if (qualifierType == "num_views" && mMultiviewAvailable && |
| 3503 | (isExtensionEnabled("GL_OVR_multiview") || isExtensionEnabled("GL_OVR_multiview2")) && |
| 3504 | mShaderType == GL_VERTEX_SHADER) |
| 3505 | { |
| 3506 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 3507 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3508 | else |
| 3509 | { |
| 3510 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3511 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3512 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3513 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3514 | } |
| 3515 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 3516 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 3517 | { |
| 3518 | return new TTypeQualifierBuilder( |
| 3519 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 3520 | mShaderVersion); |
| 3521 | } |
| 3522 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3523 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3524 | TLayoutQualifier rightQualifier, |
| 3525 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3526 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3527 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3528 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3529 | } |
| 3530 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3531 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 3532 | const TFieldList *newlyAddedFields, |
| 3533 | const TSourceLoc &location) |
| 3534 | { |
| 3535 | for (TField *field : *newlyAddedFields) |
| 3536 | { |
| 3537 | for (TField *oldField : *processedFields) |
| 3538 | { |
| 3539 | if (oldField->name() == field->name()) |
| 3540 | { |
| 3541 | error(location, "duplicate field name in structure", field->name().c_str()); |
| 3542 | } |
| 3543 | } |
| 3544 | processedFields->push_back(field); |
| 3545 | } |
| 3546 | return processedFields; |
| 3547 | } |
| 3548 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3549 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 3550 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3551 | TPublicType *typeSpecifier, |
| 3552 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3553 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3554 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3555 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3556 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 3557 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3558 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3559 | typeSpecifier->invariant = typeQualifier.invariant; |
| 3560 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3561 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3562 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3563 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3564 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3565 | } |
| 3566 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3567 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
| 3568 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3569 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3570 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 3571 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3572 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3573 | checkIsNonVoid(typeSpecifier.getLine(), (*fieldList)[0]->name(), typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3574 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3575 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3576 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3577 | for (unsigned int i = 0; i < fieldList->size(); ++i) |
| 3578 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3579 | // |
| 3580 | // Careful not to replace already known aspects of type, like array-ness |
| 3581 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3582 | TType *type = (*fieldList)[i]->type(); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3583 | type->setBasicType(typeSpecifier.getBasicType()); |
| 3584 | type->setPrimarySize(typeSpecifier.getPrimarySize()); |
| 3585 | type->setSecondarySize(typeSpecifier.getSecondarySize()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3586 | type->setPrecision(typeSpecifier.precision); |
| 3587 | type->setQualifier(typeSpecifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3588 | type->setLayoutQualifier(typeSpecifier.layoutQualifier); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3589 | type->setMemoryQualifier(typeSpecifier.memoryQualifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3590 | type->setInvariant(typeSpecifier.invariant); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3591 | |
| 3592 | // don't allow arrays of arrays |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3593 | if (type->isArray()) |
| 3594 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3595 | checkIsValidTypeForArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3596 | } |
| 3597 | if (typeSpecifier.array) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3598 | type->setArraySize(static_cast<unsigned int>(typeSpecifier.arraySize)); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3599 | if (typeSpecifier.getUserDef()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3600 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3601 | type->setStruct(typeSpecifier.getUserDef()->getStruct()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3602 | } |
| 3603 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3604 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*fieldList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3605 | } |
| 3606 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3607 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3608 | } |
| 3609 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3610 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 3611 | const TSourceLoc &nameLine, |
| 3612 | const TString *structName, |
| 3613 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3614 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3615 | TStructure *structure = new TStructure(structName, fieldList); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3616 | TType *structureType = new TType(structure); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3617 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3618 | // Store a bool in the struct if we're at global scope, to allow us to |
| 3619 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3620 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 3621 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3622 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3623 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3624 | checkIsNotReserved(nameLine, *structName); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3625 | TVariable *userTypeDef = new TVariable(structName, *structureType, true); |
| 3626 | if (!symbolTable.declare(userTypeDef)) |
| 3627 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3628 | error(nameLine, "redefinition of a struct", structName->c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3629 | } |
| 3630 | } |
| 3631 | |
| 3632 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3633 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3634 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3635 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3636 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3637 | switch (qualifier) |
| 3638 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3639 | case EvqGlobal: |
| 3640 | case EvqTemporary: |
| 3641 | break; |
| 3642 | default: |
| 3643 | error(field.line(), "invalid qualifier on struct member", |
| 3644 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3645 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3646 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3647 | if (field.type()->isInvariant()) |
| 3648 | { |
| 3649 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 3650 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3651 | if (IsImage(field.type()->getBasicType())) |
| 3652 | { |
| 3653 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 3654 | } |
| 3655 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3656 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 3657 | |
| 3658 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3659 | |
| 3660 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3661 | } |
| 3662 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3663 | TTypeSpecifierNonArray typeSpecifierNonArray; |
| 3664 | typeSpecifierNonArray.initialize(EbtStruct, structLine); |
| 3665 | typeSpecifierNonArray.userDef = structureType; |
| 3666 | typeSpecifierNonArray.isStructSpecifier = true; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3667 | exitStructDeclaration(); |
| 3668 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3669 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3670 | } |
| 3671 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3672 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3673 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3674 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3675 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3676 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3677 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3678 | init->isVector()) |
| 3679 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3680 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 3681 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3682 | return nullptr; |
| 3683 | } |
| 3684 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3685 | if (statementList) |
| 3686 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3687 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3688 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3689 | return nullptr; |
| 3690 | } |
| 3691 | } |
| 3692 | |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3693 | TIntermSwitch *node = intermediate.addSwitch(init, statementList, loc); |
| 3694 | if (node == nullptr) |
| 3695 | { |
| 3696 | error(loc, "erroneous switch statement", "switch"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3697 | return nullptr; |
| 3698 | } |
| 3699 | return node; |
| 3700 | } |
| 3701 | |
| 3702 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 3703 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3704 | if (mSwitchNestingLevel == 0) |
| 3705 | { |
| 3706 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3707 | return nullptr; |
| 3708 | } |
| 3709 | if (condition == nullptr) |
| 3710 | { |
| 3711 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3712 | return nullptr; |
| 3713 | } |
| 3714 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3715 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3716 | { |
| 3717 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3718 | } |
| 3719 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3720 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 3721 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 3722 | // fold in case labels. |
| 3723 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3724 | { |
| 3725 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3726 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3727 | TIntermCase *node = intermediate.addCase(condition, loc); |
| 3728 | if (node == nullptr) |
| 3729 | { |
| 3730 | error(loc, "erroneous case statement", "case"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3731 | return nullptr; |
| 3732 | } |
| 3733 | return node; |
| 3734 | } |
| 3735 | |
| 3736 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 3737 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3738 | if (mSwitchNestingLevel == 0) |
| 3739 | { |
| 3740 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3741 | return nullptr; |
| 3742 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3743 | TIntermCase *node = intermediate.addCase(nullptr, loc); |
| 3744 | if (node == nullptr) |
| 3745 | { |
| 3746 | error(loc, "erroneous default statement", "default"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3747 | return nullptr; |
| 3748 | } |
| 3749 | return node; |
| 3750 | } |
| 3751 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3752 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 3753 | TIntermTyped *child, |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3754 | const TSourceLoc &loc) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3755 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3756 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3757 | |
| 3758 | switch (op) |
| 3759 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3760 | case EOpLogicalNot: |
| 3761 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 3762 | child->isVector()) |
| 3763 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3764 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3765 | return nullptr; |
| 3766 | } |
| 3767 | break; |
| 3768 | case EOpBitwiseNot: |
| 3769 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 3770 | child->isMatrix() || child->isArray()) |
| 3771 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3772 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3773 | return nullptr; |
| 3774 | } |
| 3775 | break; |
| 3776 | case EOpPostIncrement: |
| 3777 | case EOpPreIncrement: |
| 3778 | case EOpPostDecrement: |
| 3779 | case EOpPreDecrement: |
| 3780 | case EOpNegative: |
| 3781 | case EOpPositive: |
| 3782 | if (child->getBasicType() == EbtStruct || child->getBasicType() == EbtBool || |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3783 | child->isArray() || IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3784 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3785 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3786 | return nullptr; |
| 3787 | } |
| 3788 | // Operators for built-ins are already type checked against their prototype. |
| 3789 | default: |
| 3790 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3791 | } |
| 3792 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3793 | TIntermUnary *node = new TIntermUnary(op, child); |
| 3794 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3795 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3796 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3797 | if (foldedNode) |
| 3798 | return foldedNode; |
| 3799 | |
| 3800 | return node; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3801 | } |
| 3802 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3803 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 3804 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 3805 | TIntermTyped *node = createUnaryMath(op, child, loc); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3806 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3807 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3808 | return child; |
| 3809 | } |
| 3810 | return node; |
| 3811 | } |
| 3812 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3813 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 3814 | TIntermTyped *child, |
| 3815 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3816 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3817 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3818 | return addUnaryMath(op, child, loc); |
| 3819 | } |
| 3820 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3821 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 3822 | TIntermTyped *left, |
| 3823 | TIntermTyped *right, |
| 3824 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3825 | { |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3826 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 3827 | { |
| 3828 | switch (op) |
| 3829 | { |
| 3830 | case EOpIndexDirectStruct: |
| 3831 | ASSERT(left->getType().getStruct()); |
| 3832 | break; |
| 3833 | case EOpEqual: |
| 3834 | case EOpNotEqual: |
| 3835 | case EOpAssign: |
| 3836 | case EOpInitialize: |
| 3837 | if (left->getType() != right->getType()) |
| 3838 | { |
| 3839 | return false; |
| 3840 | } |
| 3841 | break; |
| 3842 | default: |
| 3843 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 3844 | return false; |
| 3845 | } |
| 3846 | } |
| 3847 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3848 | if (left->isArray() || right->isArray()) |
| 3849 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3850 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3851 | { |
| 3852 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3853 | return false; |
| 3854 | } |
| 3855 | |
| 3856 | if (left->isArray() != right->isArray()) |
| 3857 | { |
| 3858 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 3859 | return false; |
| 3860 | } |
| 3861 | |
| 3862 | switch (op) |
| 3863 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3864 | case EOpEqual: |
| 3865 | case EOpNotEqual: |
| 3866 | case EOpAssign: |
| 3867 | case EOpInitialize: |
| 3868 | break; |
| 3869 | default: |
| 3870 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3871 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3872 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 3873 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3874 | if (left->getArraySize() != right->getArraySize()) |
| 3875 | { |
| 3876 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 3877 | return false; |
| 3878 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3879 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3880 | |
| 3881 | // Check ops which require integer / ivec parameters |
| 3882 | bool isBitShift = false; |
| 3883 | switch (op) |
| 3884 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3885 | case EOpBitShiftLeft: |
| 3886 | case EOpBitShiftRight: |
| 3887 | case EOpBitShiftLeftAssign: |
| 3888 | case EOpBitShiftRightAssign: |
| 3889 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 3890 | // check that the basic type is an integer type. |
| 3891 | isBitShift = true; |
| 3892 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 3893 | { |
| 3894 | return false; |
| 3895 | } |
| 3896 | break; |
| 3897 | case EOpBitwiseAnd: |
| 3898 | case EOpBitwiseXor: |
| 3899 | case EOpBitwiseOr: |
| 3900 | case EOpBitwiseAndAssign: |
| 3901 | case EOpBitwiseXorAssign: |
| 3902 | case EOpBitwiseOrAssign: |
| 3903 | // It is enough to check the type of only one operand, since later it |
| 3904 | // is checked that the operand types match. |
| 3905 | if (!IsInteger(left->getBasicType())) |
| 3906 | { |
| 3907 | return false; |
| 3908 | } |
| 3909 | break; |
| 3910 | default: |
| 3911 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3912 | } |
| 3913 | |
| 3914 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 3915 | // So the basic type should usually match. |
| 3916 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 3917 | { |
| 3918 | return false; |
| 3919 | } |
| 3920 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3921 | // Check that: |
| 3922 | // 1. Type sizes match exactly on ops that require that. |
| 3923 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 3924 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3925 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3926 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3927 | case EOpAssign: |
| 3928 | case EOpInitialize: |
| 3929 | case EOpEqual: |
| 3930 | case EOpNotEqual: |
| 3931 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 3932 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 3933 | { |
| 3934 | error(loc, "undefined operation for structs containing arrays", |
| 3935 | GetOperatorString(op)); |
| 3936 | return false; |
| 3937 | } |
| 3938 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 3939 | // we interpret the spec so that this extends to structs containing samplers, |
| 3940 | // similarly to ESSL 1.00 spec. |
| 3941 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 3942 | left->getType().isStructureContainingSamplers()) |
| 3943 | { |
| 3944 | error(loc, "undefined operation for structs containing samplers", |
| 3945 | GetOperatorString(op)); |
| 3946 | return false; |
| 3947 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3948 | |
| 3949 | if ((op == EOpAssign || op == EOpInitialize) && |
| 3950 | left->getType().isStructureContainingImages()) |
| 3951 | { |
| 3952 | error(loc, "undefined operation for structs containing images", |
| 3953 | GetOperatorString(op)); |
| 3954 | return false; |
| 3955 | } |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3956 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 3957 | (left->getSecondarySize() != right->getSecondarySize())) |
| 3958 | { |
| 3959 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 3960 | return false; |
| 3961 | } |
| 3962 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3963 | case EOpLessThan: |
| 3964 | case EOpGreaterThan: |
| 3965 | case EOpLessThanEqual: |
| 3966 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3967 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3968 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 3969 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3970 | return false; |
| 3971 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3972 | break; |
| 3973 | case EOpAdd: |
| 3974 | case EOpSub: |
| 3975 | case EOpDiv: |
| 3976 | case EOpIMod: |
| 3977 | case EOpBitShiftLeft: |
| 3978 | case EOpBitShiftRight: |
| 3979 | case EOpBitwiseAnd: |
| 3980 | case EOpBitwiseXor: |
| 3981 | case EOpBitwiseOr: |
| 3982 | case EOpAddAssign: |
| 3983 | case EOpSubAssign: |
| 3984 | case EOpDivAssign: |
| 3985 | case EOpIModAssign: |
| 3986 | case EOpBitShiftLeftAssign: |
| 3987 | case EOpBitShiftRightAssign: |
| 3988 | case EOpBitwiseAndAssign: |
| 3989 | case EOpBitwiseXorAssign: |
| 3990 | case EOpBitwiseOrAssign: |
| 3991 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 3992 | { |
| 3993 | return false; |
| 3994 | } |
| 3995 | |
| 3996 | // Are the sizes compatible? |
| 3997 | if (left->getNominalSize() != right->getNominalSize() || |
| 3998 | left->getSecondarySize() != right->getSecondarySize()) |
| 3999 | { |
| 4000 | // If the nominal sizes of operands do not match: |
| 4001 | // One of them must be a scalar. |
| 4002 | if (!left->isScalar() && !right->isScalar()) |
| 4003 | return false; |
| 4004 | |
| 4005 | // In the case of compound assignment other than multiply-assign, |
| 4006 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 4007 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 4008 | // vector either. |
| 4009 | if (!right->isScalar() && |
| 4010 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 4011 | return false; |
| 4012 | } |
| 4013 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4014 | default: |
| 4015 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4016 | } |
| 4017 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4018 | return true; |
| 4019 | } |
| 4020 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4021 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 4022 | const TType &left, |
| 4023 | const TType &right) |
| 4024 | { |
| 4025 | switch (op) |
| 4026 | { |
| 4027 | case EOpMul: |
| 4028 | case EOpMulAssign: |
| 4029 | return left.getNominalSize() == right.getNominalSize() && |
| 4030 | left.getSecondarySize() == right.getSecondarySize(); |
| 4031 | case EOpVectorTimesScalar: |
| 4032 | return true; |
| 4033 | case EOpVectorTimesScalarAssign: |
| 4034 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 4035 | return left.isVector() && !right.isVector(); |
| 4036 | case EOpVectorTimesMatrix: |
| 4037 | return left.getNominalSize() == right.getRows(); |
| 4038 | case EOpVectorTimesMatrixAssign: |
| 4039 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 4040 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 4041 | left.getNominalSize() == right.getCols(); |
| 4042 | case EOpMatrixTimesVector: |
| 4043 | return left.getCols() == right.getNominalSize(); |
| 4044 | case EOpMatrixTimesScalar: |
| 4045 | return true; |
| 4046 | case EOpMatrixTimesScalarAssign: |
| 4047 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 4048 | return !right.isVector(); |
| 4049 | case EOpMatrixTimesMatrix: |
| 4050 | return left.getCols() == right.getRows(); |
| 4051 | case EOpMatrixTimesMatrixAssign: |
| 4052 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 4053 | // We need to check two things: |
| 4054 | // 1. The matrix multiplication step is valid. |
| 4055 | // 2. The result will have the same number of columns as the lvalue. |
| 4056 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 4057 | |
| 4058 | default: |
| 4059 | UNREACHABLE(); |
| 4060 | return false; |
| 4061 | } |
| 4062 | } |
| 4063 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4064 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 4065 | TIntermTyped *left, |
| 4066 | TIntermTyped *right, |
| 4067 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4068 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4069 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4070 | return nullptr; |
| 4071 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4072 | switch (op) |
| 4073 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4074 | case EOpEqual: |
| 4075 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4076 | case EOpLessThan: |
| 4077 | case EOpGreaterThan: |
| 4078 | case EOpLessThanEqual: |
| 4079 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4080 | break; |
| 4081 | case EOpLogicalOr: |
| 4082 | case EOpLogicalXor: |
| 4083 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4084 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4085 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4086 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4087 | { |
| 4088 | return nullptr; |
| 4089 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 4090 | // Basic types matching should have been already checked. |
| 4091 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4092 | break; |
| 4093 | case EOpAdd: |
| 4094 | case EOpSub: |
| 4095 | case EOpDiv: |
| 4096 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4097 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4098 | !right->getType().getStruct()); |
| 4099 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4100 | { |
| 4101 | return nullptr; |
| 4102 | } |
| 4103 | break; |
| 4104 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4105 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 4106 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4107 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4108 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4109 | { |
| 4110 | return nullptr; |
| 4111 | } |
| 4112 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4113 | default: |
| 4114 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4115 | } |
| 4116 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4117 | if (op == EOpMul) |
| 4118 | { |
| 4119 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 4120 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4121 | { |
| 4122 | return nullptr; |
| 4123 | } |
| 4124 | } |
| 4125 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4126 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4127 | node->setLine(loc); |
| 4128 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4129 | // See if we can fold constants. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4130 | TIntermTyped *foldedNode = node->fold(mDiagnostics); |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4131 | if (foldedNode) |
| 4132 | return foldedNode; |
| 4133 | |
| 4134 | return node; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4135 | } |
| 4136 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4137 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 4138 | TIntermTyped *left, |
| 4139 | TIntermTyped *right, |
| 4140 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4141 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4142 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4143 | if (node == 0) |
| 4144 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4145 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4146 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4147 | return left; |
| 4148 | } |
| 4149 | return node; |
| 4150 | } |
| 4151 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4152 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 4153 | TIntermTyped *left, |
| 4154 | TIntermTyped *right, |
| 4155 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4156 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 4157 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4158 | if (node == 0) |
| 4159 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4160 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 4161 | right->getCompleteString()); |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 4162 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4163 | unionArray->setBConst(false); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4164 | return intermediate.addConstantUnion(unionArray, TType(EbtBool, EbpUndefined, EvqConst), |
| 4165 | loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4166 | } |
| 4167 | return node; |
| 4168 | } |
| 4169 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 4170 | TIntermBinary *TParseContext::createAssign(TOperator op, |
| 4171 | TIntermTyped *left, |
| 4172 | TIntermTyped *right, |
| 4173 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4174 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4175 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4176 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4177 | if (op == EOpMulAssign) |
| 4178 | { |
| 4179 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 4180 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 4181 | { |
| 4182 | return nullptr; |
| 4183 | } |
| 4184 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4185 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 4186 | node->setLine(loc); |
| 4187 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 4188 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4189 | } |
| 4190 | return nullptr; |
| 4191 | } |
| 4192 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4193 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 4194 | TIntermTyped *left, |
| 4195 | TIntermTyped *right, |
| 4196 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4197 | { |
| 4198 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 4199 | if (node == nullptr) |
| 4200 | { |
| 4201 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4202 | return left; |
| 4203 | } |
| 4204 | return node; |
| 4205 | } |
| 4206 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4207 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 4208 | TIntermTyped *right, |
| 4209 | const TSourceLoc &loc) |
| 4210 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4211 | // WebGL2 section 5.26, the following results in an error: |
| 4212 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4213 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 4214 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 4215 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 4216 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4217 | { |
| 4218 | error(loc, |
| 4219 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 4220 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4221 | } |
| 4222 | |
Olli Etuaho | 4db7ded | 2016-10-13 12:23:11 +0100 | [diff] [blame] | 4223 | return TIntermediate::AddComma(left, right, loc, mShaderVersion); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 4224 | } |
| 4225 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4226 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 4227 | { |
| 4228 | switch (op) |
| 4229 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4230 | case EOpContinue: |
| 4231 | if (mLoopNestingLevel <= 0) |
| 4232 | { |
| 4233 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4234 | } |
| 4235 | break; |
| 4236 | case EOpBreak: |
| 4237 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 4238 | { |
| 4239 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4240 | } |
| 4241 | break; |
| 4242 | case EOpReturn: |
| 4243 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 4244 | { |
| 4245 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4246 | } |
| 4247 | break; |
| 4248 | default: |
| 4249 | // No checks for discard |
| 4250 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4251 | } |
| 4252 | return intermediate.addBranch(op, loc); |
| 4253 | } |
| 4254 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4255 | TIntermBranch *TParseContext::addBranch(TOperator op, |
| 4256 | TIntermTyped *returnValue, |
| 4257 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4258 | { |
| 4259 | ASSERT(op == EOpReturn); |
| 4260 | mFunctionReturnsValue = true; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4261 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4262 | { |
| 4263 | error(loc, "void function cannot return a value", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4264 | } |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4265 | else if (*mCurrentFunctionType != returnValue->getType()) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4266 | { |
| 4267 | error(loc, "function return is not matching type:", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4268 | } |
| 4269 | return intermediate.addBranch(op, returnValue, loc); |
| 4270 | } |
| 4271 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4272 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 4273 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4274 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4275 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4276 | TIntermNode *offset = nullptr; |
| 4277 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4278 | if (name == "texelFetchOffset" || name == "textureLodOffset" || |
| 4279 | name == "textureProjLodOffset" || name == "textureGradOffset" || |
| 4280 | name == "textureProjGradOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4281 | { |
| 4282 | offset = arguments->back(); |
| 4283 | } |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4284 | else if (name == "textureOffset" || name == "textureProjOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4285 | { |
| 4286 | // A bias parameter might follow the offset parameter. |
| 4287 | ASSERT(arguments->size() >= 3); |
| 4288 | offset = (*arguments)[2]; |
| 4289 | } |
| 4290 | if (offset != nullptr) |
| 4291 | { |
| 4292 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 4293 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 4294 | { |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4295 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 4296 | name.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4297 | } |
| 4298 | else |
| 4299 | { |
| 4300 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 4301 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 4302 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 4303 | for (size_t i = 0u; i < size; ++i) |
| 4304 | { |
| 4305 | int offsetValue = values[i].getIConst(); |
| 4306 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 4307 | { |
| 4308 | std::stringstream tokenStream; |
| 4309 | tokenStream << offsetValue; |
| 4310 | std::string token = tokenStream.str(); |
| 4311 | error(offset->getLine(), "Texture offset value out of valid range", |
| 4312 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4313 | } |
| 4314 | } |
| 4315 | } |
| 4316 | } |
| 4317 | } |
| 4318 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4319 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 4320 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 4321 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4322 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4323 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
| 4324 | |
| 4325 | if (name.compare(0, 5, "image") == 0) |
| 4326 | { |
| 4327 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4328 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4329 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4330 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4331 | |
| 4332 | if (name.compare(5, 5, "Store") == 0) |
| 4333 | { |
| 4334 | if (memoryQualifier.readonly) |
| 4335 | { |
| 4336 | error(imageNode->getLine(), |
| 4337 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4338 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4339 | } |
| 4340 | } |
| 4341 | else if (name.compare(5, 4, "Load") == 0) |
| 4342 | { |
| 4343 | if (memoryQualifier.writeonly) |
| 4344 | { |
| 4345 | error(imageNode->getLine(), |
| 4346 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4347 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4348 | } |
| 4349 | } |
| 4350 | } |
| 4351 | } |
| 4352 | |
| 4353 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 4354 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 4355 | const TFunction *functionDefinition, |
| 4356 | const TIntermAggregate *functionCall) |
| 4357 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4358 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4359 | |
| 4360 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 4361 | |
| 4362 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 4363 | |
| 4364 | for (size_t i = 0; i < arguments.size(); ++i) |
| 4365 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4366 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 4367 | const TType &functionArgumentType = typedArgument->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4368 | const TType &functionParameterType = *functionDefinition->getParam(i).type; |
| 4369 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 4370 | |
| 4371 | if (IsImage(functionArgumentType.getBasicType())) |
| 4372 | { |
| 4373 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 4374 | functionArgumentType.getMemoryQualifier(); |
| 4375 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 4376 | functionParameterType.getMemoryQualifier(); |
| 4377 | if (functionArgumentMemoryQualifier.readonly && |
| 4378 | !functionParameterMemoryQualifier.readonly) |
| 4379 | { |
| 4380 | error(functionCall->getLine(), |
| 4381 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4382 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4383 | } |
| 4384 | |
| 4385 | if (functionArgumentMemoryQualifier.writeonly && |
| 4386 | !functionParameterMemoryQualifier.writeonly) |
| 4387 | { |
| 4388 | error(functionCall->getLine(), |
| 4389 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4390 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4391 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4392 | |
| 4393 | if (functionArgumentMemoryQualifier.coherent && |
| 4394 | !functionParameterMemoryQualifier.coherent) |
| 4395 | { |
| 4396 | error(functionCall->getLine(), |
| 4397 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4398 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4399 | } |
| 4400 | |
| 4401 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 4402 | !functionParameterMemoryQualifier.volatileQualifier) |
| 4403 | { |
| 4404 | error(functionCall->getLine(), |
| 4405 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 4406 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 4407 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4408 | } |
| 4409 | } |
| 4410 | } |
| 4411 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4412 | TIntermSequence *TParseContext::createEmptyArgumentsList() |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4413 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4414 | return new TIntermSequence(); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4415 | } |
| 4416 | |
| 4417 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4418 | TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4419 | TIntermNode *thisNode, |
| 4420 | const TSourceLoc &loc) |
| 4421 | { |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4422 | if (thisNode != nullptr) |
| 4423 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4424 | return addMethod(fnCall, arguments, thisNode, loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4425 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4426 | |
| 4427 | TOperator op = fnCall->getBuiltInOp(); |
| 4428 | if (op != EOpNull) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4429 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4430 | return addConstructor(arguments, op, fnCall->getReturnType(), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4431 | } |
| 4432 | else |
| 4433 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4434 | return addNonConstructorFunctionCall(fnCall, arguments, loc); |
| 4435 | } |
| 4436 | } |
| 4437 | |
| 4438 | TIntermTyped *TParseContext::addMethod(TFunction *fnCall, |
| 4439 | TIntermSequence *arguments, |
| 4440 | TIntermNode *thisNode, |
| 4441 | const TSourceLoc &loc) |
| 4442 | { |
| 4443 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 4444 | int arraySize = 0; |
| 4445 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 4446 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 4447 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 4448 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
| 4449 | // So accessing fnCall->getName() below is safe. |
| 4450 | if (fnCall->getName() != "length") |
| 4451 | { |
| 4452 | error(loc, "invalid method", fnCall->getName().c_str()); |
| 4453 | } |
| 4454 | else if (!arguments->empty()) |
| 4455 | { |
| 4456 | error(loc, "method takes no parameters", "length"); |
| 4457 | } |
| 4458 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 4459 | { |
| 4460 | error(loc, "length can only be called on arrays", "length"); |
| 4461 | } |
| 4462 | else |
| 4463 | { |
| 4464 | arraySize = typedThis->getArraySize(); |
| 4465 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4466 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4467 | // This code path can be hit with expressions like these: |
| 4468 | // (a = b).length() |
| 4469 | // (func()).length() |
| 4470 | // (int[3](0, 1, 2)).length() |
| 4471 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 4472 | // expression. |
| 4473 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 4474 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 4475 | // length method applied". |
| 4476 | error(loc, "length can only be called on array names, not on array expressions", |
| 4477 | "length"); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 4478 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4479 | } |
| 4480 | unionArray->setIConst(arraySize); |
| 4481 | return intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), loc); |
| 4482 | } |
| 4483 | |
| 4484 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunction *fnCall, |
| 4485 | TIntermSequence *arguments, |
| 4486 | const TSourceLoc &loc) |
| 4487 | { |
| 4488 | // First find by unmangled name to check whether the function name has been |
| 4489 | // hidden by a variable name or struct typename. |
| 4490 | // If a function is found, check for one with a matching argument list. |
| 4491 | bool builtIn; |
| 4492 | const TSymbol *symbol = symbolTable.find(fnCall->getName(), mShaderVersion, &builtIn); |
| 4493 | if (symbol != nullptr && !symbol->isFunction()) |
| 4494 | { |
| 4495 | error(loc, "function name expected", fnCall->getName().c_str()); |
| 4496 | } |
| 4497 | else |
| 4498 | { |
| 4499 | symbol = symbolTable.find(TFunction::GetMangledNameFromCall(fnCall->getName(), *arguments), |
| 4500 | mShaderVersion, &builtIn); |
| 4501 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4502 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4503 | error(loc, "no matching overloaded function found", fnCall->getName().c_str()); |
| 4504 | } |
| 4505 | else |
| 4506 | { |
| 4507 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4508 | // |
| 4509 | // A declared function. |
| 4510 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 4511 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4512 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4513 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4514 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4515 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4516 | if (builtIn && op != EOpNull) |
| 4517 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4518 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4519 | if (fnCandidate->getParamCount() == 1) |
| 4520 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4521 | // Treat it like a built-in unary operator. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4522 | TIntermNode *unaryParamNode = arguments->front(); |
| 4523 | TIntermTyped *callNode = createUnaryMath(op, unaryParamNode->getAsTyped(), loc); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4524 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4525 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4526 | } |
| 4527 | else |
| 4528 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4529 | TIntermAggregate *callNode = |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4530 | TIntermAggregate::Create(fnCandidate->getReturnType(), op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4531 | callNode->setLine(loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4532 | |
| 4533 | // Some built-in functions have out parameters too. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4534 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4535 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4536 | // See if we can constant fold a built-in. Note that this may be possible even |
| 4537 | // if it is not const-qualified. |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4538 | TIntermTyped *foldedNode = |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4539 | intermediate.foldAggregateBuiltIn(callNode, mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4540 | if (foldedNode) |
| 4541 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4542 | return foldedNode; |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4543 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4544 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4545 | } |
| 4546 | } |
| 4547 | else |
| 4548 | { |
| 4549 | // This is a real function call |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4550 | TIntermAggregate *callNode = nullptr; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4551 | |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 4552 | // If builtIn == false, the function is user defined - could be an overloaded |
| 4553 | // built-in as well. |
| 4554 | // if builtIn == true, it's a builtIn function with no op associated with it. |
| 4555 | // This needs to happen after the function info including name is set. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4556 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4557 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4558 | callNode = TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4559 | checkTextureOffsetConst(callNode); |
| 4560 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4561 | } |
| 4562 | else |
| 4563 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 4564 | callNode = TIntermAggregate::CreateFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4565 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4566 | } |
| 4567 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4568 | functionCallLValueErrorCheck(fnCandidate, callNode); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4569 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4570 | callNode->setLine(loc); |
| 4571 | |
| 4572 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4573 | } |
| 4574 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4575 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 4576 | |
| 4577 | // Error message was already written. Put on a dummy node for error recovery. |
| 4578 | return TIntermTyped::CreateZero(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4579 | } |
| 4580 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4581 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4582 | TIntermTyped *trueExpression, |
| 4583 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4584 | const TSourceLoc &loc) |
| 4585 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4586 | checkIsScalarBool(loc, cond); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4587 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4588 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4589 | { |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4590 | binaryOpError(loc, ":", trueExpression->getCompleteString(), |
| 4591 | falseExpression->getCompleteString()); |
| 4592 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4593 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 4594 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 4595 | { |
| 4596 | // ESSL 1.00 section 4.1.7 |
| 4597 | // ESSL 3.00 section 4.1.7 |
| 4598 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 4599 | // Note that structs containing opaque types don't need to be checked as structs are |
| 4600 | // forbidden below. |
| 4601 | error(loc, "ternary operator is not allowed for opaque types", ":"); |
| 4602 | return falseExpression; |
| 4603 | } |
| 4604 | |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4605 | // ESSL1 sections 5.2 and 5.7: |
| 4606 | // ESSL3 section 5.7: |
| 4607 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4608 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4609 | { |
| 4610 | error(loc, "ternary operator is not allowed for structures or arrays", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4611 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4612 | } |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4613 | // WebGL2 section 5.26, the following results in an error: |
| 4614 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4615 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4616 | { |
| 4617 | error(loc, "ternary operator is not allowed for void", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4618 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4619 | } |
| 4620 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4621 | return TIntermediate::AddTernarySelection(cond, trueExpression, falseExpression, loc); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4622 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4623 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4624 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4625 | // Parse an array of strings using yyparse. |
| 4626 | // |
| 4627 | // Returns 0 for success. |
| 4628 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4629 | int PaParseStrings(size_t count, |
| 4630 | const char *const string[], |
| 4631 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4632 | TParseContext *context) |
| 4633 | { |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4634 | if ((count == 0) || (string == NULL)) |
| 4635 | return 1; |
| 4636 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4637 | if (glslang_initialize(context)) |
| 4638 | return 1; |
| 4639 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 4640 | int error = glslang_scan(count, string, length, context); |
| 4641 | if (!error) |
| 4642 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4643 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 4644 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 4645 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 4646 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4647 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 4648 | |
| 4649 | } // namespace sh |