blob: b0dc66a5c7c72e6e1cfde6dd2e25c780b34bd629 [file] [log] [blame]
Jamie Madillfa05f602015-05-07 13:47:11 -04001//
2// Copyright 2015 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
Jamie Madill1fbc59f2016-02-24 15:25:51 -05006// Framebuffer tests:
7// Various tests related for Frambuffers.
8//
Jamie Madillfa05f602015-05-07 13:47:11 -04009
Brandon Jones9fc87332017-12-13 15:46:52 -080010#include "platform/WorkaroundsD3D.h"
Corentin Wallezd3970de2015-05-14 11:07:48 -040011#include "test_utils/ANGLETest.h"
JiangYizhou461d9a32017-01-04 16:37:26 +080012#include "test_utils/gl_raii.h"
Geoff Langb6a673a2014-06-05 14:19:16 -040013
Jamie Madillfa05f602015-05-07 13:47:11 -040014using namespace angle;
Austin Kinross18b931d2014-09-29 12:58:31 -070015
Geoff Lang857c09d2017-05-16 15:55:04 -040016namespace
17{
18
19void ExpectFramebufferCompleteOrUnsupported(GLenum binding)
20{
21 GLenum status = glCheckFramebufferStatus(binding);
22 EXPECT_TRUE(status == GL_FRAMEBUFFER_COMPLETE || status == GL_FRAMEBUFFER_UNSUPPORTED);
23}
24
25} // anonymous namespace
26
Geoff Langb6a673a2014-06-05 14:19:16 -040027class FramebufferFormatsTest : public ANGLETest
28{
Jamie Madillfa05f602015-05-07 13:47:11 -040029 protected:
Jamie Madill3215b202015-12-15 16:41:39 -050030 FramebufferFormatsTest() : mFramebuffer(0), mTexture(0), mRenderbuffer(0), mProgram(0)
Geoff Langb6a673a2014-06-05 14:19:16 -040031 {
32 setWindowWidth(128);
33 setWindowHeight(128);
34 setConfigRedBits(8);
35 setConfigGreenBits(8);
36 setConfigBlueBits(8);
37 setConfigAlphaBits(8);
38 }
39
40 void checkBitCount(GLuint fbo, GLenum channel, GLint minBits)
41 {
42 glBindFramebuffer(GL_FRAMEBUFFER, fbo);
43
44 GLint bits = 0;
45 glGetIntegerv(channel, &bits);
46
47 if (minBits == 0)
48 {
49 EXPECT_EQ(minBits, bits);
50 }
51 else
52 {
53 EXPECT_GE(bits, minBits);
54 }
55 }
56
Jamie Madill1fbc59f2016-02-24 15:25:51 -050057 void testBitCounts(GLuint fbo,
58 GLint minRedBits,
59 GLint minGreenBits,
60 GLint minBlueBits,
61 GLint minAlphaBits,
62 GLint minDepthBits,
63 GLint minStencilBits)
Geoff Langb6a673a2014-06-05 14:19:16 -040064 {
65 checkBitCount(fbo, GL_RED_BITS, minRedBits);
66 checkBitCount(fbo, GL_GREEN_BITS, minGreenBits);
67 checkBitCount(fbo, GL_BLUE_BITS, minBlueBits);
68 checkBitCount(fbo, GL_ALPHA_BITS, minAlphaBits);
69 checkBitCount(fbo, GL_DEPTH_BITS, minDepthBits);
70 checkBitCount(fbo, GL_STENCIL_BITS, minStencilBits);
71 }
72
Jamie Madill1fbc59f2016-02-24 15:25:51 -050073 void testTextureFormat(GLenum internalFormat,
74 GLint minRedBits,
75 GLint minGreenBits,
76 GLint minBlueBits,
Geoff Langb6a673a2014-06-05 14:19:16 -040077 GLint minAlphaBits)
78 {
Jamie Madill3215b202015-12-15 16:41:39 -050079 glGenTextures(1, &mTexture);
80 glBindTexture(GL_TEXTURE_2D, mTexture);
Geoff Langc4e93662017-05-01 10:45:59 -040081
82 if (getClientMajorVersion() >= 3)
83 {
84 glTexStorage2D(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
85 }
86 else
87 {
88 glTexStorage2DEXT(GL_TEXTURE_2D, 1, internalFormat, 1, 1);
89 }
Geoff Langb6a673a2014-06-05 14:19:16 -040090
Jamie Madill3215b202015-12-15 16:41:39 -050091 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, mTexture, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040092
Jamie Madill3215b202015-12-15 16:41:39 -050093 testBitCounts(mFramebuffer, minRedBits, minGreenBits, minBlueBits, minAlphaBits, 0, 0);
Geoff Langb6a673a2014-06-05 14:19:16 -040094 }
95
Jamie Madill1fbc59f2016-02-24 15:25:51 -050096 void testRenderbufferMultisampleFormat(int minESVersion,
97 GLenum attachmentType,
98 GLenum internalFormat)
Corentin Walleze0902642014-11-04 12:32:15 -080099 {
Martin Radev1be913c2016-07-11 17:59:16 +0300100 int clientVersion = getClientMajorVersion();
Jamie Madillfa05f602015-05-07 13:47:11 -0400101 if (clientVersion < minESVersion)
Corentin Walleze0902642014-11-04 12:32:15 -0800102 {
103 return;
104 }
105
106 // Check that multisample is supported with at least two samples (minimum required is 1)
107 bool supports2Samples = false;
108
Jamie Madillfa05f602015-05-07 13:47:11 -0400109 if (clientVersion == 2)
Corentin Walleze0902642014-11-04 12:32:15 -0800110 {
111 if (extensionEnabled("ANGLE_framebuffer_multisample"))
112 {
113 int maxSamples;
114 glGetIntegerv(GL_MAX_SAMPLES_ANGLE, &maxSamples);
115 supports2Samples = maxSamples >= 2;
116 }
117 }
118 else
119 {
Jamie Madillfa05f602015-05-07 13:47:11 -0400120 assert(clientVersion >= 3);
Corentin Walleze0902642014-11-04 12:32:15 -0800121 int maxSamples;
122 glGetIntegerv(GL_MAX_SAMPLES, &maxSamples);
123 supports2Samples = maxSamples >= 2;
124 }
125
126 if (!supports2Samples)
127 {
128 return;
129 }
130
Jamie Madill3215b202015-12-15 16:41:39 -0500131 glGenRenderbuffers(1, &mRenderbuffer);
132 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800133
134 EXPECT_GL_NO_ERROR();
135 glRenderbufferStorageMultisampleANGLE(GL_RENDERBUFFER, 2, internalFormat, 128, 128);
136 EXPECT_GL_NO_ERROR();
Jamie Madill3215b202015-12-15 16:41:39 -0500137 glFramebufferRenderbuffer(GL_FRAMEBUFFER, attachmentType, GL_RENDERBUFFER, mRenderbuffer);
Corentin Walleze0902642014-11-04 12:32:15 -0800138 EXPECT_GL_NO_ERROR();
Corentin Walleze0902642014-11-04 12:32:15 -0800139 }
140
Olli Etuahobc21e182016-02-23 16:04:57 +0200141 void testZeroHeightRenderbuffer()
142 {
143 glGenRenderbuffers(1, &mRenderbuffer);
144 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer);
145 glRenderbufferStorage(GL_RENDERBUFFER, GL_RGBA8, 1, 0);
146 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER,
147 mRenderbuffer);
148 EXPECT_GL_NO_ERROR();
149 }
150
Jamie Madill3215b202015-12-15 16:41:39 -0500151 void SetUp() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400152 {
153 ANGLETest::SetUp();
Jamie Madill3215b202015-12-15 16:41:39 -0500154
155 glGenFramebuffers(1, &mFramebuffer);
156 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer);
Geoff Langb6a673a2014-06-05 14:19:16 -0400157 }
158
Jamie Madill3215b202015-12-15 16:41:39 -0500159 void TearDown() override
Geoff Langb6a673a2014-06-05 14:19:16 -0400160 {
161 ANGLETest::TearDown();
Jamie Madill3215b202015-12-15 16:41:39 -0500162
163 if (mTexture != 0)
164 {
165 glDeleteTextures(1, &mTexture);
166 mTexture = 0;
167 }
168
169 if (mRenderbuffer != 0)
170 {
171 glDeleteRenderbuffers(1, &mRenderbuffer);
172 mRenderbuffer = 0;
173 }
174
175 if (mFramebuffer != 0)
176 {
177 glDeleteFramebuffers(1, &mFramebuffer);
178 mFramebuffer = 0;
179 }
180
181 if (mProgram != 0)
182 {
183 glDeleteProgram(mProgram);
184 mProgram = 0;
185 }
Geoff Langb6a673a2014-06-05 14:19:16 -0400186 }
Jamie Madill3215b202015-12-15 16:41:39 -0500187
188 GLuint mFramebuffer;
189 GLuint mTexture;
190 GLuint mRenderbuffer;
191 GLuint mProgram;
Geoff Langb6a673a2014-06-05 14:19:16 -0400192};
193
Jamie Madillfa05f602015-05-07 13:47:11 -0400194TEST_P(FramebufferFormatsTest, RGBA4)
Geoff Langb6a673a2014-06-05 14:19:16 -0400195{
Yunchao He9550c602018-02-13 14:47:05 +0800196 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400197
Geoff Langb6a673a2014-06-05 14:19:16 -0400198 testTextureFormat(GL_RGBA4, 4, 4, 4, 4);
199}
200
Jamie Madillfa05f602015-05-07 13:47:11 -0400201TEST_P(FramebufferFormatsTest, RGB565)
Geoff Langb6a673a2014-06-05 14:19:16 -0400202{
Yunchao He9550c602018-02-13 14:47:05 +0800203 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage"));
Geoff Langc4e93662017-05-01 10:45:59 -0400204
Geoff Langb6a673a2014-06-05 14:19:16 -0400205 testTextureFormat(GL_RGB565, 5, 6, 5, 0);
206}
207
Jamie Madillfa05f602015-05-07 13:47:11 -0400208TEST_P(FramebufferFormatsTest, RGB8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400209{
Yunchao He9550c602018-02-13 14:47:05 +0800210 ANGLE_SKIP_TEST_IF(
211 getClientMajorVersion() < 3 &&
212 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400213
Geoff Langb6a673a2014-06-05 14:19:16 -0400214 testTextureFormat(GL_RGB8_OES, 8, 8, 8, 0);
215}
216
Jamie Madillfa05f602015-05-07 13:47:11 -0400217TEST_P(FramebufferFormatsTest, BGRA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400218{
Yunchao He9550c602018-02-13 14:47:05 +0800219 ANGLE_SKIP_TEST_IF(
220 !extensionEnabled("GL_EXT_texture_format_BGRA8888") ||
221 (getClientMajorVersion() < 3 && !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400222
Geoff Langb6a673a2014-06-05 14:19:16 -0400223 testTextureFormat(GL_BGRA8_EXT, 8, 8, 8, 8);
224}
225
Jamie Madillfa05f602015-05-07 13:47:11 -0400226TEST_P(FramebufferFormatsTest, RGBA8)
Geoff Langb6a673a2014-06-05 14:19:16 -0400227{
Yunchao He9550c602018-02-13 14:47:05 +0800228 ANGLE_SKIP_TEST_IF(
229 getClientMajorVersion() < 3 &&
230 (!extensionEnabled("GL_OES_rgb8_rgba8") || !extensionEnabled("GL_EXT_texture_storage")));
Geoff Langf34d1db2015-05-20 14:10:46 -0400231
Geoff Langb6a673a2014-06-05 14:19:16 -0400232 testTextureFormat(GL_RGBA8_OES, 8, 8, 8, 8);
233}
234
Jamie Madillfa05f602015-05-07 13:47:11 -0400235TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH16)
Corentin Walleze0902642014-11-04 12:32:15 -0800236{
237 testRenderbufferMultisampleFormat(2, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT16);
238}
239
Jamie Madillfa05f602015-05-07 13:47:11 -0400240TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24)
Corentin Walleze0902642014-11-04 12:32:15 -0800241{
242 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT24);
243}
244
Jamie Madillfa05f602015-05-07 13:47:11 -0400245TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F)
Corentin Walleze0902642014-11-04 12:32:15 -0800246{
Yunchao He9550c602018-02-13 14:47:05 +0800247 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400248
Corentin Walleze0902642014-11-04 12:32:15 -0800249 testRenderbufferMultisampleFormat(3, GL_DEPTH_ATTACHMENT, GL_DEPTH_COMPONENT32F);
250}
251
Jamie Madillfa05f602015-05-07 13:47:11 -0400252TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH24_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800253{
254 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH24_STENCIL8);
255}
256
Jamie Madillfa05f602015-05-07 13:47:11 -0400257TEST_P(FramebufferFormatsTest, RenderbufferMultisample_DEPTH32F_STENCIL8)
Corentin Walleze0902642014-11-04 12:32:15 -0800258{
Yunchao He9550c602018-02-13 14:47:05 +0800259 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Geoff Langf34d1db2015-05-20 14:10:46 -0400260
Corentin Walleze0902642014-11-04 12:32:15 -0800261 testRenderbufferMultisampleFormat(3, GL_DEPTH_STENCIL_ATTACHMENT, GL_DEPTH32F_STENCIL8);
262}
263
Jamie Madillfa05f602015-05-07 13:47:11 -0400264TEST_P(FramebufferFormatsTest, RenderbufferMultisample_STENCIL_INDEX8)
Corentin Walleze0902642014-11-04 12:32:15 -0800265{
Geoff Langf34d1db2015-05-20 14:10:46 -0400266 // TODO(geofflang): Figure out how to support GLSTENCIL_INDEX8 on desktop GL
Yunchao He9550c602018-02-13 14:47:05 +0800267 ANGLE_SKIP_TEST_IF(IsDesktopOpenGL());
Geoff Langf34d1db2015-05-20 14:10:46 -0400268
Corentin Walleze0902642014-11-04 12:32:15 -0800269 testRenderbufferMultisampleFormat(2, GL_STENCIL_ATTACHMENT, GL_STENCIL_INDEX8);
270}
Jamie Madillfa05f602015-05-07 13:47:11 -0400271
Jamie Madill3215b202015-12-15 16:41:39 -0500272// Test that binding an incomplete cube map is rejected by ANGLE.
273TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
274{
Luc Ferronfa7503c2018-05-08 11:25:06 -0400275 // TODO(jmadill): Handle cube textures. http://anglebug.com/2470
276 ANGLE_SKIP_TEST_IF(IsVulkan());
277
Jamie Madill3215b202015-12-15 16:41:39 -0500278 // First make a complete CubeMap.
279 glGenTextures(1, &mTexture);
280 glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);
281 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
282 nullptr);
283 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
284 nullptr);
285 glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
286 nullptr);
287 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
288 nullptr);
289 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
290 nullptr);
291 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 8, 8, 0, GL_RGBA, GL_UNSIGNED_BYTE,
292 nullptr);
293 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
294 glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
295
296 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_CUBE_MAP_POSITIVE_X,
297 mTexture, 0);
298
299 // Verify the framebuffer is complete.
300 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
301
302 // Make the CubeMap cube-incomplete.
303 glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 16, 16, 0, GL_RGBA, GL_UNSIGNED_BYTE,
304 nullptr);
305
306 // Verify the framebuffer is incomplete.
307 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
308 glCheckFramebufferStatus(GL_FRAMEBUFFER));
309
310 // Verify drawing with the incomplete framebuffer produces a GL error
Olli Etuaho5804dc82018-04-13 14:11:46 +0300311 mProgram = CompileProgram(essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
Jamie Madill3215b202015-12-15 16:41:39 -0500312 ASSERT_NE(0u, mProgram);
Olli Etuaho5804dc82018-04-13 14:11:46 +0300313 drawQuad(mProgram, essl1_shaders::PositionAttrib(), 0.5f);
Jamie Madill3215b202015-12-15 16:41:39 -0500314 ASSERT_GL_ERROR(GL_INVALID_FRAMEBUFFER_OPERATION);
315}
316
Olli Etuahobc21e182016-02-23 16:04:57 +0200317// Test that a renderbuffer with zero height but nonzero width is handled without crashes/asserts.
318TEST_P(FramebufferFormatsTest, ZeroHeightRenderbuffer)
319{
Yunchao He9550c602018-02-13 14:47:05 +0800320 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
Olli Etuahobc21e182016-02-23 16:04:57 +0200321
322 testZeroHeightRenderbuffer();
323}
324
Geoff Lang9bf86f02018-07-26 11:46:34 -0400325// Test to cover a bug where the read framebuffer affects the completeness of the draw framebuffer.
326TEST_P(FramebufferFormatsTest, ReadDrawCompleteness)
327{
328 ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3);
329
330 GLTexture incompleteTexture;
331 glBindTexture(GL_TEXTURE_2D, incompleteTexture);
332
333 GLFramebuffer incompleteFBO;
334 glBindFramebuffer(GL_FRAMEBUFFER, incompleteFBO);
335 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, incompleteTexture,
336 0);
337 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
338 glCheckFramebufferStatus(GL_FRAMEBUFFER));
339
340 GLTexture completeTexture;
341 glBindTexture(GL_TEXTURE_2D, completeTexture);
342 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, getWindowWidth(), getWindowHeight());
343
344 GLFramebuffer completeFBO;
345 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, completeFBO);
346 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,
347 completeTexture, 0);
348
349 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
350 glCheckFramebufferStatus(GL_READ_FRAMEBUFFER));
351 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_DRAW_FRAMEBUFFER));
352
353 ASSERT_GL_NO_ERROR();
354
355 // Simple draw program.
356 ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
357
358 drawQuad(program, essl1_shaders::PositionAttrib(), 0.5f, 1.0f, true);
359 EXPECT_GL_NO_ERROR();
360
361 glBindFramebuffer(GL_READ_FRAMEBUFFER, completeFBO);
362 EXPECT_PIXEL_COLOR_EQ(0, 0, GLColor::red);
363}
364
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500365// Use this to select which configurations (e.g. which renderer, which GLES major version) these
366// tests should be run against.
Geoff Lange0cc2a42016-01-20 10:58:17 -0500367ANGLE_INSTANTIATE_TEST(FramebufferFormatsTest,
Luc Ferronfa7503c2018-05-08 11:25:06 -0400368 ES2_VULKAN(),
Geoff Lange0cc2a42016-01-20 10:58:17 -0500369 ES2_D3D9(),
370 ES2_D3D11(),
371 ES3_D3D11(),
372 ES2_OPENGL(),
373 ES3_OPENGL(),
374 ES2_OPENGLES(),
375 ES3_OPENGLES());
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500376
Corentin Wallez57e6d502016-12-09 14:46:39 -0500377class FramebufferTest_ES3 : public ANGLETest
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500378{
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500379};
380
381// Covers invalidating an incomplete framebuffer. This should be a no-op, but should not error.
Corentin Wallez57e6d502016-12-09 14:46:39 -0500382TEST_P(FramebufferTest_ES3, InvalidateIncomplete)
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500383{
Geoff Lang857c09d2017-05-16 15:55:04 -0400384 GLFramebuffer framebuffer;
385 GLRenderbuffer renderbuffer;
386
387 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
388 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
389 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_RENDERBUFFER, renderbuffer);
Jamie Madill1fbc59f2016-02-24 15:25:51 -0500390 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
391 glCheckFramebufferStatus(GL_FRAMEBUFFER));
392
393 std::vector<GLenum> attachments;
394 attachments.push_back(GL_COLOR_ATTACHMENT0);
395
396 glInvalidateFramebuffer(GL_FRAMEBUFFER, 1, attachments.data());
397 EXPECT_GL_NO_ERROR();
398}
399
Corentin Wallez57e6d502016-12-09 14:46:39 -0500400// Test that the framebuffer state tracking robustly handles a depth-only attachment being set
401// as a depth-stencil attachment. It is equivalent to detaching the depth-stencil attachment.
402TEST_P(FramebufferTest_ES3, DepthOnlyAsDepthStencil)
403{
Geoff Lang857c09d2017-05-16 15:55:04 -0400404 GLFramebuffer framebuffer;
405 GLRenderbuffer renderbuffer;
406
407 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
408 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500409 glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT16, 4, 4);
410
411 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_RENDERBUFFER,
Geoff Lang857c09d2017-05-16 15:55:04 -0400412 renderbuffer);
Corentin Wallez57e6d502016-12-09 14:46:39 -0500413 EXPECT_GLENUM_NE(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
414}
415
Geoff Lang857c09d2017-05-16 15:55:04 -0400416// Test that the framebuffer correctly returns that it is not complete if invalid texture mip levels
417// are bound
418TEST_P(FramebufferTest_ES3, TextureAttachmentMipLevels)
419{
420 GLFramebuffer framebuffer;
421 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
422
423 GLTexture texture;
424 glBindTexture(GL_TEXTURE_2D, texture);
425
426 // Create a complete mip chain in mips 1 to 3
427 glTexImage2D(GL_TEXTURE_2D, 1, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
428 glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
429 glTexImage2D(GL_TEXTURE_2D, 3, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
430
431 // Create another complete mip chain in mips 4 to 5
432 glTexImage2D(GL_TEXTURE_2D, 4, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
433 glTexImage2D(GL_TEXTURE_2D, 5, GL_RGBA8, 1, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
434
435 // Create a non-complete mip chain in mip 6
436 glTexImage2D(GL_TEXTURE_2D, 6, GL_RGBA8, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
437
438 // Incomplete, mipLevel != baseLevel and texture is not mip complete
439 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
440 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
441 glCheckFramebufferStatus(GL_FRAMEBUFFER));
442
443 // Complete, mipLevel == baseLevel
444 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 1);
445 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
446
447 // Complete, mipLevel != baseLevel but texture is now mip complete
448 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 2);
449 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
450 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 3);
451 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
452
453 // Incomplete, attached level below the base level
454 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 2);
455 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 1);
456 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
457 glCheckFramebufferStatus(GL_FRAMEBUFFER));
458
459 // Incomplete, attached level is beyond effective max level
460 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 4);
461 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT,
462 glCheckFramebufferStatus(GL_FRAMEBUFFER));
463
464 // Complete, mipLevel == baseLevel
465 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 4);
466 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
467
468 // Complete, mipLevel != baseLevel but texture is now mip complete
469 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 5);
470 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
471
472 // Complete, mipLevel == baseLevel
473 glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 6);
474 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 6);
475 ExpectFramebufferCompleteOrUnsupported(GL_FRAMEBUFFER);
476}
477
Martin Radevd178aa42017-07-13 14:03:22 +0300478// Test that passing an attachment COLOR_ATTACHMENTm where m is equal to MAX_COLOR_ATTACHMENTS
479// generates an INVALID_OPERATION.
480// OpenGL ES Version 3.0.5 (November 3, 2016), 4.4.2.4 Attaching Texture Images to a Framebuffer, p.
481// 208
482TEST_P(FramebufferTest_ES3, ColorAttachmentIndexOutOfBounds)
483{
484 GLFramebuffer framebuffer;
485 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer.get());
486
487 GLint maxColorAttachments = 0;
488 glGetIntegerv(GL_MAX_COLOR_ATTACHMENTS, &maxColorAttachments);
489 GLenum attachment = static_cast<GLenum>(maxColorAttachments + GL_COLOR_ATTACHMENT0);
490
491 GLTexture texture;
492 glBindTexture(GL_TEXTURE_2D, texture.get());
493 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA32F, 1, 1);
494 glFramebufferTexture2D(GL_FRAMEBUFFER, attachment, GL_TEXTURE_2D, texture.get(), 0);
495 EXPECT_GL_ERROR(GL_INVALID_OPERATION);
496}
497
Jamie Madilla0016b72017-07-14 14:30:46 -0400498// Check that depth-only attachments report the correct number of samples.
499TEST_P(FramebufferTest_ES3, MultisampleDepthOnly)
500{
501 GLRenderbuffer renderbuffer;
502 glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
503 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_DEPTH_COMPONENT24, 32, 32);
504
505 GLFramebuffer framebuffer;
506 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
507 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, renderbuffer);
508 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
509 EXPECT_GL_NO_ERROR();
510
511 GLint samples = 0;
512 glGetIntegerv(GL_SAMPLES, &samples);
513 EXPECT_GL_NO_ERROR();
514 EXPECT_GE(samples, 2);
515}
516
Jeff Gilbert8f8edd62017-10-31 14:26:30 -0700517// Check that we only compare width and height of attachments, not depth.
518TEST_P(FramebufferTest_ES3, AttachmentWith3DLayers)
519{
520 GLTexture texA;
521 glBindTexture(GL_TEXTURE_2D, texA);
522 glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
523
524 GLTexture texB;
525 glBindTexture(GL_TEXTURE_3D, texB);
526 glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA8, 4, 4, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
527
528 GLFramebuffer framebuffer;
529 glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
530 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texA, 0);
531 glFramebufferTextureLayer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, texB, 0, 0);
532 ASSERT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
533 EXPECT_GL_NO_ERROR();
534}
535
Corentin Wallez57e6d502016-12-09 14:46:39 -0500536ANGLE_INSTANTIATE_TEST(FramebufferTest_ES3, ES3_D3D11(), ES3_OPENGL(), ES3_OPENGLES());
JiangYizhou461d9a32017-01-04 16:37:26 +0800537
538class FramebufferTest_ES31 : public ANGLETest
539{
JiangYizhou511937d2017-08-03 15:41:29 +0800540 protected:
541 void validateSamplePass(GLuint &query, GLuint &passedCount, GLint width, GLint height)
542 {
543 glUniform2i(0, width - 1, height - 1);
544 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
545 glDrawArrays(GL_TRIANGLES, 0, 6);
546 glEndQuery(GL_ANY_SAMPLES_PASSED);
547 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
548 EXPECT_GT(static_cast<GLint>(passedCount), 0);
549
550 glUniform2i(0, width - 1, height);
551 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
552 glDrawArrays(GL_TRIANGLES, 0, 6);
553 glEndQuery(GL_ANY_SAMPLES_PASSED);
554 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
555 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
556
557 glUniform2i(0, width, height - 1);
558 glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
559 glDrawArrays(GL_TRIANGLES, 0, 6);
560 glEndQuery(GL_ANY_SAMPLES_PASSED);
561 glGetQueryObjectuiv(query, GL_QUERY_RESULT, &passedCount);
562 EXPECT_EQ(static_cast<GLint>(passedCount), 0);
563 }
JiangYizhou461d9a32017-01-04 16:37:26 +0800564};
565
566// Test that without attachment, if either the value of FRAMEBUFFER_DEFAULT_WIDTH or
567// FRAMEBUFFER_DEFAULT_HEIGHT parameters is zero, the framebuffer is incomplete.
568TEST_P(FramebufferTest_ES31, IncompleteMissingAttachmentDefaultParam)
569{
570 GLFramebuffer mFramebuffer;
571 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
572
573 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
574 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
575 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
576
577 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
578 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
579 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
580 glCheckFramebufferStatus(GL_FRAMEBUFFER));
581
582 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 1);
583 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 0);
584 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
585 glCheckFramebufferStatus(GL_FRAMEBUFFER));
586
587 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, 0);
588 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, 1);
589 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT,
590 glCheckFramebufferStatus(GL_FRAMEBUFFER));
591
592 ASSERT_GL_NO_ERROR();
593}
594
595// Test that the sample count of a mix of texture and renderbuffer should be same.
596TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountMix)
597{
598 GLFramebuffer mFramebuffer;
599 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
600
601 GLTexture mTexture;
602 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
603 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
604
605 GLRenderbuffer mRenderbuffer;
606 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
607 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 2, GL_RGBA8, 1, 1);
608 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
609 mTexture.get(), 0);
610 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
611 mRenderbuffer.get());
612 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
613 glCheckFramebufferStatus(GL_FRAMEBUFFER));
614
615 ASSERT_GL_NO_ERROR();
616}
617
618// Test that the sample count of texture attachments should be same.
619TEST_P(FramebufferTest_ES31, IncompleteMultisampleSampleCountTex)
620{
621 GLFramebuffer mFramebuffer;
622 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
623
624 GLTexture mTextures[2];
625 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
626 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, true);
627 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
628 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 2, GL_RGBA8, 1, 1, true);
629 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
630 mTextures[0].get(), 0);
631 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
632 mTextures[1].get(), 0);
633 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
634 glCheckFramebufferStatus(GL_FRAMEBUFFER));
635
636 ASSERT_GL_NO_ERROR();
637}
638
639// Test that if the attached images are a mix of renderbuffers and textures, the value of
640// TEXTURE_FIXED_SAMPLE_LOCATIONS must be TRUE for all attached textures.
641TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsMix)
642{
643 GLFramebuffer mFramebuffer;
644 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
645
646 GLTexture mTexture;
647 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTexture.get());
648 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
649
650 GLRenderbuffer mRenderbuffer;
651 glBindRenderbuffer(GL_RENDERBUFFER, mRenderbuffer.get());
652 glRenderbufferStorageMultisample(GL_RENDERBUFFER, 1, GL_RGBA8, 1, 1);
653 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
654 mTexture.get(), 0);
655 glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_RENDERBUFFER,
656 mRenderbuffer.get());
657 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
658 glCheckFramebufferStatus(GL_FRAMEBUFFER));
659
660 ASSERT_GL_NO_ERROR();
661}
662
663// Test that the value of TEXTURE_FIXED_SAMPLE_LOCATIONS is the same for all attached textures.
664TEST_P(FramebufferTest_ES31, IncompleteMultisampleFixedSampleLocationsTex)
665{
666 GLFramebuffer mFramebuffer;
667 glBindFramebuffer(GL_FRAMEBUFFER, mFramebuffer.get());
668
669 GLTexture mTextures[2];
670 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[0].get());
671 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGBA8, 1, 1, false);
672 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D_MULTISAMPLE,
673 mTextures[0].get(), 0);
674 glBindTexture(GL_TEXTURE_2D_MULTISAMPLE, mTextures[1].get());
675 glTexStorage2DMultisample(GL_TEXTURE_2D_MULTISAMPLE, 1, GL_RGB8, 1, 1, true);
676 glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT1, GL_TEXTURE_2D_MULTISAMPLE,
677 mTextures[1].get(), 0);
678 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE,
679 glCheckFramebufferStatus(GL_FRAMEBUFFER));
680
681 ASSERT_GL_NO_ERROR();
682}
683
JiangYizhou511937d2017-08-03 15:41:29 +0800684// If there are no attachments, rendering will be limited to a rectangle having a lower left of
685// (0, 0) and an upper right of(width, height), where width and height are the framebuffer
686// object's default width and height.
JiangYizhou3db40722017-08-28 17:59:13 +0800687TEST_P(FramebufferTest_ES31, RenderingLimitToDefaultFBOSizeWithNoAttachments)
JiangYizhou511937d2017-08-03 15:41:29 +0800688{
Yuly Novikov98f9f532017-11-15 19:16:19 -0500689 // anglebug.com/2253
690 ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
691
JiangYizhou10d41392017-12-18 18:13:36 +0800692 const std::string &vertexShader1 =
693 R"(#version 310 es
694 in layout(location = 0) highp vec2 a_position;
695 void main()
696 {
697 gl_Position = vec4(a_position, 0.0, 1.0);
698 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800699
JiangYizhou10d41392017-12-18 18:13:36 +0800700 const std::string &fragShader1 =
701 R"(#version 310 es
702 uniform layout(location = 0) highp ivec2 u_expectedSize;
703 out layout(location = 5) mediump vec4 f_color;
704 void main()
705 {
706 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
707 f_color = vec4(1.0, 0.5, 0.25, 1.0);
708 })";
JiangYizhou511937d2017-08-03 15:41:29 +0800709
JiangYizhou10d41392017-12-18 18:13:36 +0800710 const std::string &vertexShader2 =
711 R"(#version 310 es
712 in layout(location = 0) highp vec2 a_position;
713 void main()
714 {
715 gl_Position = vec4(a_position, 0.0, 1.0);
716 })";
717
718 const std::string &fragShader2 =
719 R"(#version 310 es
720 uniform layout(location = 0) highp ivec2 u_expectedSize;
721 out layout(location = 2) mediump vec4 f_color;
722 void main()
723 {
724 if (ivec2(gl_FragCoord.xy) != u_expectedSize) discard;
725 f_color = vec4(1.0, 0.5, 0.25, 1.0);
726 })";
727
728 GLuint program1 = CompileProgram(vertexShader1, fragShader1);
729 ASSERT_NE(program1, 0u);
730
731 GLuint program2 = CompileProgram(vertexShader2, fragShader2);
732 ASSERT_NE(program2, 0u);
733
734 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800735
736 GLFramebuffer mFramebuffer;
737 glBindFramebuffer(GL_DRAW_FRAMEBUFFER, mFramebuffer);
738 GLuint defaultWidth = 1;
739 GLuint defaultHeight = 1;
740
741 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_WIDTH, defaultWidth);
742 glFramebufferParameteri(GL_FRAMEBUFFER, GL_FRAMEBUFFER_DEFAULT_HEIGHT, defaultHeight);
743 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
744
745 const float data[] = {
746 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f,
747 };
748
749 GLuint vertexArray = 0;
750 GLuint vertexBuffer = 0;
751 GLuint query = 0;
752 GLuint passedCount = 0;
753
754 glGenQueries(1, &query);
755 glGenVertexArrays(1, &vertexArray);
756 glBindVertexArray(vertexArray);
757
758 glGenBuffers(1, &vertexBuffer);
759 glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
760 glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);
761
762 glEnableVertexAttribArray(0);
763 glVertexAttribPointer(0, 2, GL_FLOAT, false, 0, 0);
JiangYizhou38d92b52017-09-13 13:47:52 +0800764 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou511937d2017-08-03 15:41:29 +0800765
766 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
767
JiangYizhou10d41392017-12-18 18:13:36 +0800768 glUseProgram(program2);
769 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
770
771 glUseProgram(program1);
JiangYizhou511937d2017-08-03 15:41:29 +0800772 // If fbo has attachments, the rendering size should be the same as its attachment.
773 GLTexture mTexture;
774 GLuint width = 2;
775 GLuint height = 2;
776 glBindTexture(GL_TEXTURE_2D, mTexture.get());
777 glTexStorage2D(GL_TEXTURE_2D, 1, GL_RGBA8, width, height);
JiangYizhou38d92b52017-09-13 13:47:52 +0800778
779 const GLenum bufs[] = {GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_NONE, GL_COLOR_ATTACHMENT5};
780
781 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, GL_TEXTURE_2D, mTexture.get(),
JiangYizhou511937d2017-08-03 15:41:29 +0800782 0);
783 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
JiangYizhou38d92b52017-09-13 13:47:52 +0800784 glDrawBuffers(6, bufs);
JiangYizhou511937d2017-08-03 15:41:29 +0800785
786 validateSamplePass(query, passedCount, width, height);
787
788 // If fbo's attachment has been removed, the rendering size should be the same as framebuffer
789 // default size.
JiangYizhou38d92b52017-09-13 13:47:52 +0800790 glFramebufferTexture2D(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT5, 0, 0, 0);
JiangYizhou511937d2017-08-03 15:41:29 +0800791 EXPECT_GLENUM_EQ(GL_FRAMEBUFFER_COMPLETE, glCheckFramebufferStatus(GL_FRAMEBUFFER));
792
793 validateSamplePass(query, passedCount, defaultWidth, defaultHeight);
794
795 glDisableVertexAttribArray(0);
796 glBindBuffer(GL_ARRAY_BUFFER, 0);
797 glBindVertexArray(0);
798 glDeleteBuffers(1, &vertexBuffer);
799 glDeleteVertexArrays(1, &vertexArray);
800
801 ASSERT_GL_NO_ERROR();
802}
803
804ANGLE_INSTANTIATE_TEST(FramebufferTest_ES31, ES31_D3D11(), ES31_OPENGL(), ES31_OPENGLES());
Brandon Jones9fc87332017-12-13 15:46:52 -0800805
806class AddDummyTextureNoRenderTargetTest : public ANGLETest
807{
808 public:
809 AddDummyTextureNoRenderTargetTest()
810 {
811 setWindowWidth(512);
812 setWindowHeight(512);
813 setConfigRedBits(8);
814 setConfigGreenBits(8);
815 setConfigBlueBits(8);
816 setConfigAlphaBits(8);
817 }
818
819 void overrideWorkaroundsD3D(WorkaroundsD3D *workarounds) override
820 {
821 workarounds->addDummyTextureNoRenderTarget = true;
822 }
823};
824
825// Test to verify workaround succeeds when no program outputs exist http://anglebug.com/2283
826TEST_P(AddDummyTextureNoRenderTargetTest, NoProgramOutputWorkaround)
827{
828 const std::string &vShader = "void main() {}";
829 const std::string &fShader = "void main() {}";
830
831 ANGLE_GL_PROGRAM(drawProgram, vShader, fShader);
832
833 glUseProgram(drawProgram);
834
835 glDrawArrays(GL_TRIANGLES, 0, 6);
836
837 ASSERT_GL_NO_ERROR();
838}
839
840ANGLE_INSTANTIATE_TEST(AddDummyTextureNoRenderTargetTest, ES2_D3D11());