blob: 89e072646b13169d32118f8d1e803103622bb9ba [file] [log] [blame]
Stefan Bodewig4aea7b22011-08-07 07:56:19 +00001<?xml version="1.0"?>
2<!--
3 Licensed to the Apache Software Foundation (ASF) under one or more
4 contributor license agreements. See the NOTICE file distributed with
5 this work for additional information regarding copyright ownership.
6 The ASF licenses this file to You under the Apache License, Version 2.0
7 (the "License"); you may not use this file except in compliance with
8 the License. You may obtain a copy of the License at
9
10 http://www.apache.org/licenses/LICENSE-2.0
11
12 Unless required by applicable law or agreed to in writing, software
13 distributed under the License is distributed on an "AS IS" BASIS,
14 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15 See the License for the specific language governing permissions and
16 limitations under the License.
17-->
18
19<!--
20 This file contains some false positive bugs detected by findbugs. Their
21 false positive nature has been analyzed individually and they have been
22 put here to instruct findbugs it must ignore them.
23-->
24<FindBugsFilter>
25
26 <!-- Reason: References to System.out/err == -->
27 <Match>
28 <Class name="org.apache.commons.compress.archivers.Lister" />
29 <Or>
30 <Method name="main" />
31 <Method name="usage" />
32 </Or>
33 <Bug pattern="NP_ALWAYS_NULL" />
34 </Match>
35 <Match>
36 <Class name="org.apache.commons.compress.archivers.zip.ZipFile" />
37 <Method name="finalize" />
38 <Bug pattern="NP_ALWAYS_NULL" />
39 </Match>
Stefan Bodewig34e93902011-08-16 04:04:07 +000040 <Match>
41 <Class name="org.apache.commons.compress.archivers.dump.DumpArchiveUtil" />
42 <Method name="dumpBlock" />
43 <Bug pattern="NP_ALWAYS_NULL" />
44 </Match>
Stefan Bodewig4aea7b22011-08-07 07:56:19 +000045
46 <!-- Reason: fallthrough is intended -->
47 <Match>
48 <Class name="org.apache.commons.compress.archivers.zip.ExtraFieldUtils" />
49 <Method name="parse" />
50 <Bug pattern="SF_SWITCH_FALLTHROUGH" />
51 </Match>
52
53 <!-- Reason: fields unused as documented -->
54 <Match>
55 <Class name="org.apache.commons.compress.archivers.jar.JarArchiveEntry" />
56 <Or>
57 <Field name="certificates"/>
58 <Field name="manifestAttributes"/>
59 </Or>
60 <Bug pattern="UWF_NULL_FIELD" />
61 </Match>
Stefan Bodewig34e93902011-08-16 04:04:07 +000062 <Match>
63 <Class name="org.apache.commons.compress.archivers.dump.DumpArchiveEntry" />
64 <Field name="summary"/>
65 <Bug pattern="UWF_NULL_FIELD" />
66 </Match>
Stefan Bodewig4aea7b22011-08-07 07:56:19 +000067
68 <!-- Reason: exception in close swallowed in order to re-throw original -->
69 <Match>
70 <Class name="org.apache.commons.compress.archivers.zip.ZipFile" />
71 <Method name="&lt;init&gt;" />
72 <Bug pattern="DE_MIGHT_IGNORE" />
73 </Match>
Stefan Bodewig2a879452011-09-15 11:46:02 +000074 <Match>
75 <Class name="org.apache.commons.compress.compressors.pack200.Pack200CompressorOutputStream" />
76 <Method name="finish" />
77 <Bug pattern="DE_MIGHT_IGNORE" />
78 </Match>
Stefan Bodewig4aea7b22011-08-07 07:56:19 +000079
Stefan Bodewigb64aa8a2011-08-14 05:39:53 +000080 <!-- Reason: skip(Long.MAX_VALUE) called to drain stream completely,
81 the class overrides skip to ensure it reads the full amount
82 until EOF is reached -->
83 <Match>
84 <Class name="org.apache.commons.compress.archivers.zip.ZipArchiveInputStream" />
85 <Method name="closeEntry" />
86 <Bug pattern="SR_NOT_CHECKED" />
87 </Match>
88
Stefan Bodewig615cda32011-09-14 15:13:14 +000089 <!-- Reason: trying to delete a temporary file that has deleteOnExit set
90 anyway -->
91 <Match>
92 <Class name="org.apache.commons.compress.compressors.pack200.Pack200Utils" />
93 <Method name="normalize" />
94 <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
95 </Match>
96 <Match>
97 <Class name="org.apache.commons.compress.compressors.pack200.TempFileCachingStreamBridge$1" />
98 <Method name="close" />
99 <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
100 </Match>
101
102 <!-- Reason: It is the Pack200*Stream that's going to close it. -->
103 <Match>
104 <Class name="org.apache.commons.compress.compressors.pack200.TempFileCachingStreamBridge$1" />
105 <Method name="&lt;init&gt;" />
106 <Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
107 </Match>
108
Stefan Bodewig4aea7b22011-08-07 07:56:19 +0000109</FindBugsFilter>