Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 1 | //== NullDerefChecker.cpp - Null dereference checker ------------*- C++ -*--==// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
Argyrios Kyrtzidis | d2592a3 | 2010-12-22 18:53:44 +0000 | [diff] [blame] | 10 | // This defines NullDerefChecker, a builtin check in ExprEngine that performs |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 11 | // checks for null pointers at loads and stores. |
| 12 | // |
| 13 | //===----------------------------------------------------------------------===// |
| 14 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 15 | #include "ClangSACheckers.h" |
Benjamin Kramer | c35fb7d | 2012-01-28 12:06:22 +0000 | [diff] [blame] | 16 | #include "clang/AST/ExprObjC.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 17 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 18 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 19 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Benjamin Kramer | 8fe83e1 | 2012-02-04 13:45:25 +0000 | [diff] [blame] | 21 | #include "llvm/ADT/SmallString.h" |
Benjamin Kramer | a93d0f2 | 2012-12-01 17:12:56 +0000 | [diff] [blame] | 22 | #include "llvm/Support/raw_ostream.h" |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 23 | |
| 24 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 25 | using namespace ento; |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 26 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 27 | namespace { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 28 | class DereferenceChecker |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 29 | : public Checker< check::Location, |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 30 | check::Bind, |
| 31 | EventDispatcher<ImplicitNullDerefEvent> > { |
Dylan Noblesmith | 6f42b62 | 2012-02-05 02:12:40 +0000 | [diff] [blame] | 32 | mutable OwningPtr<BuiltinBug> BT_null; |
| 33 | mutable OwningPtr<BuiltinBug> BT_undef; |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 34 | |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 35 | void reportBug(ProgramStateRef State, const Stmt *S, CheckerContext &C, |
| 36 | bool IsBind = false) const; |
| 37 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 38 | public: |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 39 | void checkLocation(SVal location, bool isLoad, const Stmt* S, |
| 40 | CheckerContext &C) const; |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 41 | void checkBind(SVal L, SVal V, const Stmt *S, CheckerContext &C) const; |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 42 | |
Anna Zaks | 9bc1e6d | 2012-09-05 22:31:49 +0000 | [diff] [blame] | 43 | static void AddDerefSource(raw_ostream &os, |
Chris Lattner | 5f9e272 | 2011-07-23 10:55:15 +0000 | [diff] [blame] | 44 | SmallVectorImpl<SourceRange> &Ranges, |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 45 | const Expr *Ex, const ProgramState *state, |
| 46 | const LocationContext *LCtx, |
| 47 | bool loadedFrom = false); |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 48 | }; |
| 49 | } // end anonymous namespace |
| 50 | |
Anna Zaks | 9bc1e6d | 2012-09-05 22:31:49 +0000 | [diff] [blame] | 51 | void |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 52 | DereferenceChecker::AddDerefSource(raw_ostream &os, |
| 53 | SmallVectorImpl<SourceRange> &Ranges, |
| 54 | const Expr *Ex, |
| 55 | const ProgramState *state, |
| 56 | const LocationContext *LCtx, |
| 57 | bool loadedFrom) { |
John McCall | f6a1648 | 2010-12-04 03:47:34 +0000 | [diff] [blame] | 58 | Ex = Ex->IgnoreParenLValueCasts(); |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 59 | switch (Ex->getStmtClass()) { |
| 60 | default: |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 61 | break; |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 62 | case Stmt::DeclRefExprClass: { |
| 63 | const DeclRefExpr *DR = cast<DeclRefExpr>(Ex); |
| 64 | if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { |
| 65 | os << " (" << (loadedFrom ? "loaded from" : "from") |
| 66 | << " variable '" << VD->getName() << "')"; |
| 67 | Ranges.push_back(DR->getSourceRange()); |
| 68 | } |
Ted Kremenek | 76aadc3 | 2012-03-09 01:13:14 +0000 | [diff] [blame] | 69 | break; |
Ted Kremenek | 646c3c3 | 2010-10-26 00:06:13 +0000 | [diff] [blame] | 70 | } |
| 71 | case Stmt::MemberExprClass: { |
| 72 | const MemberExpr *ME = cast<MemberExpr>(Ex); |
| 73 | os << " (" << (loadedFrom ? "loaded from" : "via") |
| 74 | << " field '" << ME->getMemberNameInfo() << "')"; |
| 75 | SourceLocation L = ME->getMemberLoc(); |
| 76 | Ranges.push_back(SourceRange(L, L)); |
| 77 | break; |
| 78 | } |
| 79 | } |
| 80 | } |
| 81 | |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 82 | void DereferenceChecker::reportBug(ProgramStateRef State, const Stmt *S, |
| 83 | CheckerContext &C, bool IsBind) const { |
| 84 | // Generate an error node. |
| 85 | ExplodedNode *N = C.generateSink(State); |
| 86 | if (!N) |
| 87 | return; |
| 88 | |
| 89 | // We know that 'location' cannot be non-null. This is what |
| 90 | // we call an "explicit" null dereference. |
| 91 | if (!BT_null) |
| 92 | BT_null.reset(new BuiltinBug("Dereference of null pointer")); |
| 93 | |
| 94 | SmallString<100> buf; |
Jordan Rose | 991bcb4 | 2012-09-22 01:24:38 +0000 | [diff] [blame] | 95 | llvm::raw_svector_ostream os(buf); |
| 96 | |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 97 | SmallVector<SourceRange, 2> Ranges; |
| 98 | |
| 99 | // Walk through lvalue casts to get the original expression |
| 100 | // that syntactically caused the load. |
| 101 | if (const Expr *expr = dyn_cast<Expr>(S)) |
| 102 | S = expr->IgnoreParenLValueCasts(); |
| 103 | |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 104 | if (IsBind) { |
| 105 | if (const BinaryOperator *BO = dyn_cast<BinaryOperator>(S)) { |
| 106 | if (BO->isAssignmentOp()) |
| 107 | S = BO->getRHS(); |
| 108 | } else if (const DeclStmt *DS = dyn_cast<DeclStmt>(S)) { |
| 109 | assert(DS->isSingleDecl() && "We process decls one by one"); |
| 110 | if (const VarDecl *VD = dyn_cast<VarDecl>(DS->getSingleDecl())) |
| 111 | if (const Expr *Init = VD->getAnyInitializer()) |
| 112 | S = Init; |
| 113 | } |
| 114 | } |
| 115 | |
| 116 | switch (S->getStmtClass()) { |
| 117 | case Stmt::ArraySubscriptExprClass: { |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 118 | os << "Array access"; |
| 119 | const ArraySubscriptExpr *AE = cast<ArraySubscriptExpr>(S); |
Anna Zaks | 9bc1e6d | 2012-09-05 22:31:49 +0000 | [diff] [blame] | 120 | AddDerefSource(os, Ranges, AE->getBase()->IgnoreParenCasts(), |
| 121 | State.getPtr(), N->getLocationContext()); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 122 | os << " results in a null pointer dereference"; |
| 123 | break; |
| 124 | } |
| 125 | case Stmt::UnaryOperatorClass: { |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 126 | os << "Dereference of null pointer"; |
| 127 | const UnaryOperator *U = cast<UnaryOperator>(S); |
Anna Zaks | 9bc1e6d | 2012-09-05 22:31:49 +0000 | [diff] [blame] | 128 | AddDerefSource(os, Ranges, U->getSubExpr()->IgnoreParens(), |
| 129 | State.getPtr(), N->getLocationContext(), true); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 130 | break; |
| 131 | } |
| 132 | case Stmt::MemberExprClass: { |
| 133 | const MemberExpr *M = cast<MemberExpr>(S); |
Anna Zaks | 9b925ac | 2012-09-05 23:41:54 +0000 | [diff] [blame] | 134 | if (M->isArrow() || bugreporter::isDeclRefExprToReference(M->getBase())) { |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 135 | os << "Access to field '" << M->getMemberNameInfo() |
| 136 | << "' results in a dereference of a null pointer"; |
Anna Zaks | 9bc1e6d | 2012-09-05 22:31:49 +0000 | [diff] [blame] | 137 | AddDerefSource(os, Ranges, M->getBase()->IgnoreParenCasts(), |
| 138 | State.getPtr(), N->getLocationContext(), true); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 139 | } |
| 140 | break; |
| 141 | } |
| 142 | case Stmt::ObjCIvarRefExprClass: { |
| 143 | const ObjCIvarRefExpr *IV = cast<ObjCIvarRefExpr>(S); |
Jordan Rose | 991bcb4 | 2012-09-22 01:24:38 +0000 | [diff] [blame] | 144 | os << "Access to instance variable '" << *IV->getDecl() |
| 145 | << "' results in a dereference of a null pointer"; |
| 146 | AddDerefSource(os, Ranges, IV->getBase()->IgnoreParenCasts(), |
| 147 | State.getPtr(), N->getLocationContext(), true); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 148 | break; |
| 149 | } |
| 150 | default: |
| 151 | break; |
| 152 | } |
| 153 | |
Jordan Rose | 991bcb4 | 2012-09-22 01:24:38 +0000 | [diff] [blame] | 154 | os.flush(); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 155 | BugReport *report = |
| 156 | new BugReport(*BT_null, |
| 157 | buf.empty() ? BT_null->getDescription() : buf.str(), |
| 158 | N); |
| 159 | |
Jordan Rose | a1f81bb | 2012-08-28 00:50:51 +0000 | [diff] [blame] | 160 | bugreporter::trackNullOrUndefValue(N, bugreporter::GetDerefExpr(N), *report); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 161 | |
| 162 | for (SmallVectorImpl<SourceRange>::iterator |
| 163 | I = Ranges.begin(), E = Ranges.end(); I!=E; ++I) |
| 164 | report->addRange(*I); |
| 165 | |
Jordan Rose | 785950e | 2012-11-02 01:53:40 +0000 | [diff] [blame] | 166 | C.emitReport(report); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 167 | } |
| 168 | |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 169 | void DereferenceChecker::checkLocation(SVal l, bool isLoad, const Stmt* S, |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 170 | CheckerContext &C) const { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 171 | // Check for dereference of an undefined value. |
| 172 | if (l.isUndef()) { |
Ted Kremenek | d048c6e | 2010-12-20 21:19:09 +0000 | [diff] [blame] | 173 | if (ExplodedNode *N = C.generateSink()) { |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 174 | if (!BT_undef) |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 175 | BT_undef.reset(new BuiltinBug("Dereference of undefined pointer value")); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 176 | |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 177 | BugReport *report = |
| 178 | new BugReport(*BT_undef, BT_undef->getDescription(), N); |
Jordan Rose | a1f81bb | 2012-08-28 00:50:51 +0000 | [diff] [blame] | 179 | bugreporter::trackNullOrUndefValue(N, bugreporter::GetDerefExpr(N), |
| 180 | *report); |
Jordan Rose | 785950e | 2012-11-02 01:53:40 +0000 | [diff] [blame] | 181 | C.emitReport(report); |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 182 | } |
| 183 | return; |
| 184 | } |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 185 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 186 | DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(l); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 187 | |
| 188 | // Check for null dereferences. |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 189 | if (!isa<Loc>(location)) |
| 190 | return; |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 191 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 192 | ProgramStateRef state = C.getState(); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 193 | |
Ted Kremenek | 8bef823 | 2012-01-26 21:29:00 +0000 | [diff] [blame] | 194 | ProgramStateRef notNullState, nullState; |
Ted Kremenek | 28f47b9 | 2010-12-01 22:16:56 +0000 | [diff] [blame] | 195 | llvm::tie(notNullState, nullState) = state->assume(location); |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 196 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 197 | // The explicit NULL case. |
| 198 | if (nullState) { |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 199 | if (!notNullState) { |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 200 | reportBug(nullState, S, C); |
Ted Kremenek | 78d722f | 2009-11-21 01:50:48 +0000 | [diff] [blame] | 201 | return; |
| 202 | } |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 203 | |
| 204 | // Otherwise, we have the case where the location could either be |
| 205 | // null or not-null. Record the error node as an "implicit" null |
| 206 | // dereference. |
| 207 | if (ExplodedNode *N = C.generateSink(nullState)) { |
| 208 | ImplicitNullDerefEvent event = { l, isLoad, N, &C.getBugReporter() }; |
| 209 | dispatchEvent(event); |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 210 | } |
| 211 | } |
Ted Kremenek | 452b84d | 2010-03-23 01:11:38 +0000 | [diff] [blame] | 212 | |
Ted Kremenek | b4b817d | 2009-11-11 03:26:34 +0000 | [diff] [blame] | 213 | // From this point forward, we know that the location is not null. |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 214 | C.addTransition(notNullState); |
Ted Kremenek | bc3a021 | 2009-10-30 17:24:47 +0000 | [diff] [blame] | 215 | } |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 216 | |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 217 | void DereferenceChecker::checkBind(SVal L, SVal V, const Stmt *S, |
| 218 | CheckerContext &C) const { |
Jordan Rose | 522f46f | 2012-08-04 00:25:30 +0000 | [diff] [blame] | 219 | // If we're binding to a reference, check if the value is known to be null. |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 220 | if (V.isUndef()) |
| 221 | return; |
| 222 | |
| 223 | const MemRegion *MR = L.getAsRegion(); |
| 224 | const TypedValueRegion *TVR = dyn_cast_or_null<TypedValueRegion>(MR); |
| 225 | if (!TVR) |
| 226 | return; |
| 227 | |
| 228 | if (!TVR->getValueType()->isReferenceType()) |
| 229 | return; |
| 230 | |
| 231 | ProgramStateRef State = C.getState(); |
| 232 | |
| 233 | ProgramStateRef StNonNull, StNull; |
| 234 | llvm::tie(StNonNull, StNull) = State->assume(cast<DefinedOrUnknownSVal>(V)); |
| 235 | |
| 236 | if (StNull) { |
| 237 | if (!StNonNull) { |
| 238 | reportBug(StNull, S, C, /*isBind=*/true); |
| 239 | return; |
| 240 | } |
| 241 | |
| 242 | // At this point the value could be either null or non-null. |
| 243 | // Record this as an "implicit" null dereference. |
| 244 | if (ExplodedNode *N = C.generateSink(StNull)) { |
| 245 | ImplicitNullDerefEvent event = { V, /*isLoad=*/true, N, |
| 246 | &C.getBugReporter() }; |
| 247 | dispatchEvent(event); |
| 248 | } |
| 249 | } |
| 250 | |
Jordan Rose | 522f46f | 2012-08-04 00:25:30 +0000 | [diff] [blame] | 251 | // Unlike a regular null dereference, initializing a reference with a |
| 252 | // dereferenced null pointer does not actually cause a runtime exception in |
| 253 | // Clang's implementation of references. |
| 254 | // |
| 255 | // int &r = *p; // safe?? |
| 256 | // if (p != NULL) return; // uh-oh |
| 257 | // r = 5; // trap here |
| 258 | // |
| 259 | // The standard says this is invalid as soon as we try to create a "null |
| 260 | // reference" (there is no such thing), but turning this into an assumption |
| 261 | // that 'p' is never null will not match our actual runtime behavior. |
| 262 | // So we do not record this assumption, allowing us to warn on the last line |
| 263 | // of this example. |
| 264 | // |
| 265 | // We do need to add a transition because we may have generated a sink for |
| 266 | // the "implicit" null dereference. |
| 267 | C.addTransition(State, this); |
Jordan Rose | 9f3b9d5 | 2012-08-02 21:33:42 +0000 | [diff] [blame] | 268 | } |
| 269 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 270 | void ento::registerDereferenceChecker(CheckerManager &mgr) { |
| 271 | mgr.registerChecker<DereferenceChecker>(); |
| 272 | } |