| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Mesa 3-D graphics library |
| Brian | a3c3bc9 | 2007-08-20 12:55:34 +0100 | [diff] [blame] | 3 | * Version: 7.1 |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 4 | * |
| Brian | 37ece4d | 2007-07-08 09:20:42 -0600 | [diff] [blame] | 5 | * Copyright (C) 1999-2007 Brian Paul All Rights Reserved. |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 6 | * |
| 7 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 8 | * copy of this software and associated documentation files (the "Software"), |
| 9 | * to deal in the Software without restriction, including without limitation |
| 10 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 11 | * and/or sell copies of the Software, and to permit persons to whom the |
| 12 | * Software is furnished to do so, subject to the following conditions: |
| 13 | * |
| 14 | * The above copyright notice and this permission notice shall be included |
| 15 | * in all copies or substantial portions of the Software. |
| 16 | * |
| 17 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS |
| 18 | * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 19 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 20 | * BRIAN PAUL BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN |
| 21 | * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN |
| 22 | * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
| 23 | */ |
| 24 | |
| 25 | #include "glheader.h" |
| Brian Paul | 8446d1b | 2001-01-02 21:40:57 +0000 | [diff] [blame] | 26 | #include "api_validate.h" |
| Brian Paul | 434ec3a | 2009-08-12 13:46:16 -0600 | [diff] [blame] | 27 | #include "bufferobj.h" |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 28 | #include "context.h" |
| Brian Paul | 3c63452 | 2002-10-24 23:57:19 +0000 | [diff] [blame] | 29 | #include "imports.h" |
| Vinson Lee | 6bf0ac0 | 2010-11-06 21:13:40 -0700 | [diff] [blame] | 30 | #include "mfeatures.h" |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 31 | #include "mtypes.h" |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 32 | #include "vbo/vbo.h" |
| Keith Whitwell | 58e9917 | 2001-01-05 02:26:48 +0000 | [diff] [blame] | 33 | |
| Brian Paul | bb1fb2a | 2009-05-06 12:37:10 -0600 | [diff] [blame] | 34 | |
| 35 | /** |
| 36 | * \return number of bytes in array [count] of type. |
| 37 | */ |
| 38 | static GLsizei |
| 39 | index_bytes(GLenum type, GLsizei count) |
| 40 | { |
| 41 | if (type == GL_UNSIGNED_INT) { |
| 42 | return count * sizeof(GLuint); |
| 43 | } |
| 44 | else if (type == GL_UNSIGNED_BYTE) { |
| 45 | return count * sizeof(GLubyte); |
| 46 | } |
| 47 | else { |
| 48 | ASSERT(type == GL_UNSIGNED_SHORT); |
| 49 | return count * sizeof(GLushort); |
| 50 | } |
| 51 | } |
| 52 | |
| 53 | |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 54 | /** |
| Brian Paul | e5d29eb | 2009-09-21 14:07:35 -0600 | [diff] [blame] | 55 | * Find the max index in the given element/index buffer |
| 56 | */ |
| 57 | GLuint |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 58 | _mesa_max_buffer_index(struct gl_context *ctx, GLuint count, GLenum type, |
| Brian Paul | e5d29eb | 2009-09-21 14:07:35 -0600 | [diff] [blame] | 59 | const void *indices, |
| 60 | struct gl_buffer_object *elementBuf) |
| 61 | { |
| 62 | const GLubyte *map = NULL; |
| 63 | GLuint max = 0; |
| 64 | GLuint i; |
| 65 | |
| 66 | if (_mesa_is_bufferobj(elementBuf)) { |
| 67 | /* elements are in a user-defined buffer object. need to map it */ |
| Ian Romanick | 28249bd | 2011-08-21 18:34:27 -0700 | [diff] [blame] | 68 | map = ctx->Driver.MapBufferRange(ctx, 0, elementBuf->Size, |
| 69 | GL_MAP_READ_BIT, elementBuf); |
| Brian Paul | e5d29eb | 2009-09-21 14:07:35 -0600 | [diff] [blame] | 70 | /* Actual address is the sum of pointers */ |
| 71 | indices = (const GLvoid *) ADD_POINTERS(map, (const GLubyte *) indices); |
| 72 | } |
| 73 | |
| 74 | if (type == GL_UNSIGNED_INT) { |
| 75 | for (i = 0; i < count; i++) |
| 76 | if (((GLuint *) indices)[i] > max) |
| 77 | max = ((GLuint *) indices)[i]; |
| 78 | } |
| 79 | else if (type == GL_UNSIGNED_SHORT) { |
| 80 | for (i = 0; i < count; i++) |
| 81 | if (((GLushort *) indices)[i] > max) |
| 82 | max = ((GLushort *) indices)[i]; |
| 83 | } |
| 84 | else { |
| 85 | ASSERT(type == GL_UNSIGNED_BYTE); |
| 86 | for (i = 0; i < count; i++) |
| 87 | if (((GLubyte *) indices)[i] > max) |
| 88 | max = ((GLubyte *) indices)[i]; |
| 89 | } |
| 90 | |
| 91 | if (map) { |
| Ian Romanick | 56f0c00 | 2011-08-21 16:59:30 -0700 | [diff] [blame] | 92 | ctx->Driver.UnmapBuffer(ctx, elementBuf); |
| Brian Paul | e5d29eb | 2009-09-21 14:07:35 -0600 | [diff] [blame] | 93 | } |
| 94 | |
| 95 | return max; |
| 96 | } |
| 97 | |
| 98 | |
| 99 | /** |
| Brian Paul | b6e5600 | 2009-08-14 10:48:31 -0600 | [diff] [blame] | 100 | * Check if OK to draw arrays/elements. |
| Brian Paul | 88af3f8 | 2009-05-06 12:27:38 -0600 | [diff] [blame] | 101 | */ |
| Alan Hourihane | 263b96e | 2009-01-15 11:51:39 +0000 | [diff] [blame] | 102 | static GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 103 | check_valid_to_render(struct gl_context *ctx, const char *function) |
| Alan Hourihane | 263b96e | 2009-01-15 11:51:39 +0000 | [diff] [blame] | 104 | { |
| Brian Paul | b6e5600 | 2009-08-14 10:48:31 -0600 | [diff] [blame] | 105 | if (!_mesa_valid_to_render(ctx, function)) { |
| Alan Hourihane | 263b96e | 2009-01-15 11:51:39 +0000 | [diff] [blame] | 106 | return GL_FALSE; |
| 107 | } |
| 108 | |
| Kristian Høgsberg | f67b020 | 2010-05-24 10:01:38 -0400 | [diff] [blame] | 109 | switch (ctx->API) { |
| Brian Paul | 97dd2dd | 2009-03-02 12:27:16 -0700 | [diff] [blame] | 110 | #if FEATURE_es2_glsl |
| Kristian Høgsberg | f67b020 | 2010-05-24 10:01:38 -0400 | [diff] [blame] | 111 | case API_OPENGLES2: |
| 112 | /* For ES2, we can draw if any vertex array is enabled (and we |
| 113 | * should always have a vertex program/shader). */ |
| 114 | if (ctx->Array.ArrayObj->_Enabled == 0x0 || !ctx->VertexProgram._Current) |
| 115 | return GL_FALSE; |
| 116 | break; |
| Brian Paul | 97dd2dd | 2009-03-02 12:27:16 -0700 | [diff] [blame] | 117 | #endif |
| Alan Hourihane | 263b96e | 2009-01-15 11:51:39 +0000 | [diff] [blame] | 118 | |
| Brian Paul | 43bdabd | 2011-05-18 16:19:06 -0600 | [diff] [blame] | 119 | #if FEATURE_ES1 |
| Kristian Høgsberg | f67b020 | 2010-05-24 10:01:38 -0400 | [diff] [blame] | 120 | case API_OPENGLES: |
| Brian Paul | 43bdabd | 2011-05-18 16:19:06 -0600 | [diff] [blame] | 121 | /* For OpenGL ES, only draw if we have vertex positions |
| 122 | */ |
| Mathias Fröhlich | 762c976 | 2011-10-31 22:23:51 +0100 | [diff] [blame] | 123 | if (!ctx->Array.ArrayObj->VertexAttrib[VERT_ATTRIB_POS].Enabled) |
| Kristian Høgsberg | f67b020 | 2010-05-24 10:01:38 -0400 | [diff] [blame] | 124 | return GL_FALSE; |
| 125 | break; |
| 126 | #endif |
| 127 | |
| Brian Paul | 43bdabd | 2011-05-18 16:19:06 -0600 | [diff] [blame] | 128 | #if FEATURE_GL |
| 129 | case API_OPENGL: |
| 130 | { |
| 131 | const struct gl_shader_program *vsProg = |
| 132 | ctx->Shader.CurrentVertexProgram; |
| 133 | GLboolean haveVertexShader = (vsProg && vsProg->LinkStatus); |
| 134 | GLboolean haveVertexProgram = ctx->VertexProgram._Enabled; |
| 135 | if (haveVertexShader || haveVertexProgram) { |
| 136 | /* Draw regardless of whether or not we have any vertex arrays. |
| 137 | * (Ex: could draw a point using a constant vertex pos) |
| 138 | */ |
| 139 | return GL_TRUE; |
| 140 | } |
| 141 | else { |
| 142 | /* Draw if we have vertex positions (GL_VERTEX_ARRAY or generic |
| 143 | * array [0]). |
| 144 | */ |
| Mathias Fröhlich | 762c976 | 2011-10-31 22:23:51 +0100 | [diff] [blame] | 145 | return (ctx->Array.ArrayObj->VertexAttrib[VERT_ATTRIB_POS].Enabled || |
| 146 | ctx->Array.ArrayObj->VertexAttrib[VERT_ATTRIB_GENERIC0].Enabled); |
| Brian Paul | 43bdabd | 2011-05-18 16:19:06 -0600 | [diff] [blame] | 147 | } |
| 148 | } |
| 149 | break; |
| 150 | #endif |
| 151 | |
| Kristian Høgsberg | f67b020 | 2010-05-24 10:01:38 -0400 | [diff] [blame] | 152 | default: |
| 153 | ASSERT_NO_FEATURE(); |
| 154 | } |
| 155 | |
| Alan Hourihane | 263b96e | 2009-01-15 11:51:39 +0000 | [diff] [blame] | 156 | return GL_TRUE; |
| 157 | } |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 158 | |
| Brian Paul | e9968eb | 2010-03-05 12:32:32 -0700 | [diff] [blame] | 159 | |
| 160 | /** |
| 161 | * Do bounds checking on array element indexes. Check that the vertices |
| 162 | * pointed to by the indices don't lie outside buffer object bounds. |
| 163 | * \return GL_TRUE if OK, GL_FALSE if any indexed vertex goes is out of bounds |
| 164 | */ |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 165 | static GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 166 | check_index_bounds(struct gl_context *ctx, GLsizei count, GLenum type, |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 167 | const GLvoid *indices, GLint basevertex) |
| 168 | { |
| 169 | struct _mesa_prim prim; |
| 170 | struct _mesa_index_buffer ib; |
| 171 | GLuint min, max; |
| 172 | |
| 173 | /* Only the X Server needs to do this -- otherwise, accessing outside |
| 174 | * array/BO bounds allows application termination. |
| 175 | */ |
| 176 | if (!ctx->Const.CheckArrayBounds) |
| 177 | return GL_TRUE; |
| 178 | |
| 179 | memset(&prim, 0, sizeof(prim)); |
| 180 | prim.count = count; |
| 181 | |
| 182 | memset(&ib, 0, sizeof(ib)); |
| 183 | ib.type = type; |
| 184 | ib.ptr = indices; |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 185 | ib.obj = ctx->Array.ArrayObj->ElementArrayBufferObj; |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 186 | |
| 187 | vbo_get_minmax_index(ctx, &prim, &ib, &min, &max); |
| 188 | |
| Michel Dänzer | 391b396 | 2010-03-05 00:15:40 +0100 | [diff] [blame] | 189 | if ((int)(min + basevertex) < 0 || |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 190 | max + basevertex > ctx->Array.ArrayObj->_MaxElement) { |
| 191 | /* the max element is out of bounds of one or more enabled arrays */ |
| Brian Paul | e9968eb | 2010-03-05 12:32:32 -0700 | [diff] [blame] | 192 | _mesa_warning(ctx, "glDrawElements() index=%u is out of bounds (max=%u)", |
| 193 | max, ctx->Array.ArrayObj->_MaxElement); |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 194 | return GL_FALSE; |
| 195 | } |
| 196 | |
| 197 | return GL_TRUE; |
| 198 | } |
| Brian Paul | 88af3f8 | 2009-05-06 12:27:38 -0600 | [diff] [blame] | 199 | |
| Brian Paul | e9968eb | 2010-03-05 12:32:32 -0700 | [diff] [blame] | 200 | |
| Brian Paul | 88af3f8 | 2009-05-06 12:27:38 -0600 | [diff] [blame] | 201 | /** |
| Brian Paul | 0e6646d | 2011-09-21 08:22:07 -0600 | [diff] [blame] | 202 | * Is 'mode' a valid value for glBegin(), glDrawArrays(), glDrawElements(), |
| 203 | * etc? The set of legal values depends on whether geometry shaders/programs |
| 204 | * are supported. |
| 205 | */ |
| 206 | GLboolean |
| 207 | _mesa_valid_prim_mode(const struct gl_context *ctx, GLenum mode) |
| 208 | { |
| 209 | if (ctx->Extensions.ARB_geometry_shader4 && |
| 210 | mode > GL_TRIANGLE_STRIP_ADJACENCY_ARB) { |
| 211 | return GL_FALSE; |
| 212 | } |
| 213 | else if (mode > GL_POLYGON) { |
| 214 | return GL_FALSE; |
| 215 | } |
| 216 | else { |
| 217 | return GL_TRUE; |
| 218 | } |
| 219 | } |
| 220 | |
| 221 | |
| 222 | /** |
| Brian Paul | 88af3f8 | 2009-05-06 12:27:38 -0600 | [diff] [blame] | 223 | * Error checking for glDrawElements(). Includes parameter checking |
| 224 | * and VBO bounds checking. |
| 225 | * \return GL_TRUE if OK to render, GL_FALSE if error found |
| 226 | */ |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 227 | GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 228 | _mesa_validate_DrawElements(struct gl_context *ctx, |
| Gareth Hughes | 22144ab | 2001-03-12 00:48:37 +0000 | [diff] [blame] | 229 | GLenum mode, GLsizei count, GLenum type, |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 230 | const GLvoid *indices, GLint basevertex) |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 231 | { |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 232 | ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 233 | |
| 234 | if (count <= 0) { |
| 235 | if (count < 0) |
| Brian Paul | 0883634 | 2001-03-03 20:33:27 +0000 | [diff] [blame] | 236 | _mesa_error(ctx, GL_INVALID_VALUE, "glDrawElements(count)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 237 | return GL_FALSE; |
| 238 | } |
| 239 | |
| Brian Paul | 0e6646d | 2011-09-21 08:22:07 -0600 | [diff] [blame] | 240 | if (!_mesa_valid_prim_mode(ctx, mode)) { |
| Brian Paul | a2b9bad | 2003-11-10 19:08:37 +0000 | [diff] [blame] | 241 | _mesa_error(ctx, GL_INVALID_ENUM, "glDrawElements(mode)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 242 | return GL_FALSE; |
| 243 | } |
| 244 | |
| Gareth Hughes | 22144ab | 2001-03-12 00:48:37 +0000 | [diff] [blame] | 245 | if (type != GL_UNSIGNED_INT && |
| 246 | type != GL_UNSIGNED_BYTE && |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 247 | type != GL_UNSIGNED_SHORT) |
| 248 | { |
| Brian Paul | 0883634 | 2001-03-03 20:33:27 +0000 | [diff] [blame] | 249 | _mesa_error(ctx, GL_INVALID_ENUM, "glDrawElements(type)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 250 | return GL_FALSE; |
| 251 | } |
| 252 | |
| Brian Paul | a48b0a5 | 2009-08-14 10:41:03 -0600 | [diff] [blame] | 253 | if (!check_valid_to_render(ctx, "glDrawElements")) |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 254 | return GL_FALSE; |
| 255 | |
| Brian Paul | 03e29a5 | 2003-12-04 03:16:27 +0000 | [diff] [blame] | 256 | /* Vertex buffer object tests */ |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 257 | if (_mesa_is_bufferobj(ctx->Array.ArrayObj->ElementArrayBufferObj)) { |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 258 | /* use indices in the buffer object */ |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 259 | /* make sure count doesn't go outside buffer bounds */ |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 260 | if (index_bytes(type, count) > ctx->Array.ArrayObj->ElementArrayBufferObj->Size) { |
| Brian Paul | 03e29a5 | 2003-12-04 03:16:27 +0000 | [diff] [blame] | 261 | _mesa_warning(ctx, "glDrawElements index out of buffer bounds"); |
| 262 | return GL_FALSE; |
| 263 | } |
| Brian Paul | 03e29a5 | 2003-12-04 03:16:27 +0000 | [diff] [blame] | 264 | } |
| Brian | 37ece4d | 2007-07-08 09:20:42 -0600 | [diff] [blame] | 265 | else { |
| 266 | /* not using a VBO */ |
| 267 | if (!indices) |
| 268 | return GL_FALSE; |
| 269 | } |
| Brian Paul | 03e29a5 | 2003-12-04 03:16:27 +0000 | [diff] [blame] | 270 | |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 271 | if (!check_index_bounds(ctx, count, type, indices, basevertex)) |
| 272 | return GL_FALSE; |
| Xiang, Haihao | 2394d20 | 2007-07-30 23:50:52 +0800 | [diff] [blame] | 273 | |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 274 | return GL_TRUE; |
| 275 | } |
| 276 | |
| Brian Paul | 88af3f8 | 2009-05-06 12:27:38 -0600 | [diff] [blame] | 277 | |
| 278 | /** |
| 279 | * Error checking for glDrawRangeElements(). Includes parameter checking |
| 280 | * and VBO bounds checking. |
| 281 | * \return GL_TRUE if OK to render, GL_FALSE if error found |
| 282 | */ |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 283 | GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 284 | _mesa_validate_DrawRangeElements(struct gl_context *ctx, GLenum mode, |
| Gareth Hughes | 22144ab | 2001-03-12 00:48:37 +0000 | [diff] [blame] | 285 | GLuint start, GLuint end, |
| 286 | GLsizei count, GLenum type, |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 287 | const GLvoid *indices, GLint basevertex) |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 288 | { |
| Gareth Hughes | 22144ab | 2001-03-12 00:48:37 +0000 | [diff] [blame] | 289 | ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 290 | |
| 291 | if (count <= 0) { |
| 292 | if (count < 0) |
| Brian Paul | a2b9bad | 2003-11-10 19:08:37 +0000 | [diff] [blame] | 293 | _mesa_error(ctx, GL_INVALID_VALUE, "glDrawRangeElements(count)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 294 | return GL_FALSE; |
| 295 | } |
| 296 | |
| Brian Paul | 0e6646d | 2011-09-21 08:22:07 -0600 | [diff] [blame] | 297 | if (!_mesa_valid_prim_mode(ctx, mode)) { |
| Brian Paul | a2b9bad | 2003-11-10 19:08:37 +0000 | [diff] [blame] | 298 | _mesa_error(ctx, GL_INVALID_ENUM, "glDrawRangeElements(mode)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 299 | return GL_FALSE; |
| 300 | } |
| 301 | |
| 302 | if (end < start) { |
| Brian Paul | 0883634 | 2001-03-03 20:33:27 +0000 | [diff] [blame] | 303 | _mesa_error(ctx, GL_INVALID_VALUE, "glDrawRangeElements(end<start)"); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 304 | return GL_FALSE; |
| 305 | } |
| 306 | |
| Gareth Hughes | 22144ab | 2001-03-12 00:48:37 +0000 | [diff] [blame] | 307 | if (type != GL_UNSIGNED_INT && |
| 308 | type != GL_UNSIGNED_BYTE && |
| Brian Paul | 61bac60 | 2002-04-21 21:04:46 +0000 | [diff] [blame] | 309 | type != GL_UNSIGNED_SHORT) { |
| Brian Paul | a2b9bad | 2003-11-10 19:08:37 +0000 | [diff] [blame] | 310 | _mesa_error(ctx, GL_INVALID_ENUM, "glDrawRangeElements(type)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 311 | return GL_FALSE; |
| 312 | } |
| 313 | |
| Brian Paul | a48b0a5 | 2009-08-14 10:41:03 -0600 | [diff] [blame] | 314 | if (!check_valid_to_render(ctx, "glDrawRangeElements")) |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 315 | return GL_FALSE; |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 316 | |
| Brian | 37ece4d | 2007-07-08 09:20:42 -0600 | [diff] [blame] | 317 | /* Vertex buffer object tests */ |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 318 | if (_mesa_is_bufferobj(ctx->Array.ArrayObj->ElementArrayBufferObj)) { |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 319 | /* use indices in the buffer object */ |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 320 | /* make sure count doesn't go outside buffer bounds */ |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 321 | if (index_bytes(type, count) > ctx->Array.ArrayObj->ElementArrayBufferObj->Size) { |
| Brian | ef5935b | 2007-09-23 13:56:46 -0600 | [diff] [blame] | 322 | _mesa_warning(ctx, "glDrawRangeElements index out of buffer bounds"); |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 323 | return GL_FALSE; |
| 324 | } |
| Brian | 37ece4d | 2007-07-08 09:20:42 -0600 | [diff] [blame] | 325 | } |
| 326 | else { |
| Brian | d8c6719 | 2007-08-20 13:12:20 +0100 | [diff] [blame] | 327 | /* not using a VBO */ |
| Brian | 37ece4d | 2007-07-08 09:20:42 -0600 | [diff] [blame] | 328 | if (!indices) |
| 329 | return GL_FALSE; |
| 330 | } |
| 331 | |
| Eric Anholt | 92d7ed8 | 2009-08-27 10:09:24 -0700 | [diff] [blame] | 332 | if (!check_index_bounds(ctx, count, type, indices, basevertex)) |
| 333 | return GL_FALSE; |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 334 | |
| Brian Paul | c5b1e81 | 2003-10-22 22:59:07 +0000 | [diff] [blame] | 335 | return GL_TRUE; |
| 336 | } |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 337 | |
| Brian Paul | c5b1e81 | 2003-10-22 22:59:07 +0000 | [diff] [blame] | 338 | |
| 339 | /** |
| 340 | * Called from the tnl module to error check the function parameters and |
| 341 | * verify that we really can draw something. |
| Brian Paul | 88af3f8 | 2009-05-06 12:27:38 -0600 | [diff] [blame] | 342 | * \return GL_TRUE if OK to render, GL_FALSE if error found |
| Brian Paul | c5b1e81 | 2003-10-22 22:59:07 +0000 | [diff] [blame] | 343 | */ |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 344 | GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 345 | _mesa_validate_DrawArrays(struct gl_context *ctx, |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 346 | GLenum mode, GLint start, GLsizei count) |
| 347 | { |
| Gareth Hughes | 22144ab | 2001-03-12 00:48:37 +0000 | [diff] [blame] | 348 | ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 349 | |
| Brian | 5cb2034 | 2007-10-31 09:38:51 -0600 | [diff] [blame] | 350 | if (count <= 0) { |
| 351 | if (count < 0) |
| 352 | _mesa_error(ctx, GL_INVALID_VALUE, "glDrawArrays(count)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 353 | return GL_FALSE; |
| 354 | } |
| 355 | |
| Brian Paul | 0e6646d | 2011-09-21 08:22:07 -0600 | [diff] [blame] | 356 | if (!_mesa_valid_prim_mode(ctx, mode)) { |
| Brian Paul | 0883634 | 2001-03-03 20:33:27 +0000 | [diff] [blame] | 357 | _mesa_error(ctx, GL_INVALID_ENUM, "glDrawArrays(mode)" ); |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 358 | return GL_FALSE; |
| 359 | } |
| 360 | |
| Brian Paul | a48b0a5 | 2009-08-14 10:41:03 -0600 | [diff] [blame] | 361 | if (!check_valid_to_render(ctx, "glDrawArrays")) |
| Brian Paul | a2b9bad | 2003-11-10 19:08:37 +0000 | [diff] [blame] | 362 | return GL_FALSE; |
| 363 | |
| 364 | if (ctx->Const.CheckArrayBounds) { |
| Brian Paul | a185bcb | 2009-05-14 13:24:24 -0600 | [diff] [blame] | 365 | if (start + count > (GLint) ctx->Array.ArrayObj->_MaxElement) |
| Brian Paul | c5b1e81 | 2003-10-22 22:59:07 +0000 | [diff] [blame] | 366 | return GL_FALSE; |
| 367 | } |
| Brian Paul | c5b1e81 | 2003-10-22 22:59:07 +0000 | [diff] [blame] | 368 | |
| 369 | return GL_TRUE; |
| Keith Whitwell | cab974c | 2000-12-26 05:09:27 +0000 | [diff] [blame] | 370 | } |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 371 | |
| 372 | |
| 373 | GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 374 | _mesa_validate_DrawArraysInstanced(struct gl_context *ctx, GLenum mode, GLint first, |
| Brian Paul | 72f2551 | 2011-01-17 09:33:47 -0700 | [diff] [blame] | 375 | GLsizei count, GLsizei numInstances) |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 376 | { |
| 377 | ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE); |
| 378 | |
| 379 | if (count <= 0) { |
| 380 | if (count < 0) |
| 381 | _mesa_error(ctx, GL_INVALID_VALUE, |
| 382 | "glDrawArraysInstanced(count=%d)", count); |
| 383 | return GL_FALSE; |
| 384 | } |
| 385 | |
| Brian Paul | 0e6646d | 2011-09-21 08:22:07 -0600 | [diff] [blame] | 386 | if (!_mesa_valid_prim_mode(ctx, mode)) { |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 387 | _mesa_error(ctx, GL_INVALID_ENUM, |
| 388 | "glDrawArraysInstanced(mode=0x%x)", mode); |
| 389 | return GL_FALSE; |
| 390 | } |
| 391 | |
| Brian Paul | 72f2551 | 2011-01-17 09:33:47 -0700 | [diff] [blame] | 392 | if (numInstances <= 0) { |
| 393 | if (numInstances < 0) |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 394 | _mesa_error(ctx, GL_INVALID_VALUE, |
| Brian Paul | 72f2551 | 2011-01-17 09:33:47 -0700 | [diff] [blame] | 395 | "glDrawArraysInstanced(numInstances=%d)", numInstances); |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 396 | return GL_FALSE; |
| 397 | } |
| 398 | |
| 399 | if (!check_valid_to_render(ctx, "glDrawArraysInstanced(invalid to render)")) |
| 400 | return GL_FALSE; |
| 401 | |
| 402 | if (ctx->CompileFlag) { |
| 403 | _mesa_error(ctx, GL_INVALID_OPERATION, |
| 404 | "glDrawArraysInstanced(display list"); |
| 405 | return GL_FALSE; |
| 406 | } |
| 407 | |
| 408 | if (ctx->Const.CheckArrayBounds) { |
| 409 | if (first + count > (GLint) ctx->Array.ArrayObj->_MaxElement) |
| 410 | return GL_FALSE; |
| 411 | } |
| 412 | |
| 413 | return GL_TRUE; |
| 414 | } |
| 415 | |
| 416 | |
| 417 | GLboolean |
| Kristian Høgsberg | f9995b3 | 2010-10-12 12:26:10 -0400 | [diff] [blame] | 418 | _mesa_validate_DrawElementsInstanced(struct gl_context *ctx, |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 419 | GLenum mode, GLsizei count, GLenum type, |
| Pierre-Eric Pelloux-Prayer | 09201cc | 2011-05-31 13:33:54 +0200 | [diff] [blame] | 420 | const GLvoid *indices, GLsizei numInstances, |
| 421 | GLint basevertex) |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 422 | { |
| 423 | ASSERT_OUTSIDE_BEGIN_END_WITH_RETVAL(ctx, GL_FALSE); |
| 424 | |
| 425 | if (count <= 0) { |
| 426 | if (count < 0) |
| 427 | _mesa_error(ctx, GL_INVALID_VALUE, |
| 428 | "glDrawElementsInstanced(count=%d)", count); |
| 429 | return GL_FALSE; |
| 430 | } |
| 431 | |
| Brian Paul | 0e6646d | 2011-09-21 08:22:07 -0600 | [diff] [blame] | 432 | if (!_mesa_valid_prim_mode(ctx, mode)) { |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 433 | _mesa_error(ctx, GL_INVALID_ENUM, |
| 434 | "glDrawElementsInstanced(mode = 0x%x)", mode); |
| 435 | return GL_FALSE; |
| 436 | } |
| 437 | |
| 438 | if (type != GL_UNSIGNED_INT && |
| 439 | type != GL_UNSIGNED_BYTE && |
| 440 | type != GL_UNSIGNED_SHORT) { |
| 441 | _mesa_error(ctx, GL_INVALID_ENUM, |
| 442 | "glDrawElementsInstanced(type=0x%x)", type); |
| 443 | return GL_FALSE; |
| 444 | } |
| 445 | |
| Brian Paul | 72f2551 | 2011-01-17 09:33:47 -0700 | [diff] [blame] | 446 | if (numInstances <= 0) { |
| 447 | if (numInstances < 0) |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 448 | _mesa_error(ctx, GL_INVALID_VALUE, |
| Brian Paul | 72f2551 | 2011-01-17 09:33:47 -0700 | [diff] [blame] | 449 | "glDrawElementsInstanced(numInstances=%d)", numInstances); |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 450 | return GL_FALSE; |
| 451 | } |
| 452 | |
| 453 | if (!check_valid_to_render(ctx, "glDrawElementsInstanced")) |
| 454 | return GL_FALSE; |
| 455 | |
| 456 | /* Vertex buffer object tests */ |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 457 | if (_mesa_is_bufferobj(ctx->Array.ArrayObj->ElementArrayBufferObj)) { |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 458 | /* use indices in the buffer object */ |
| 459 | /* make sure count doesn't go outside buffer bounds */ |
| Yuanhan Liu | a0a5bd4 | 2011-11-23 15:59:06 +0800 | [diff] [blame] | 460 | if (index_bytes(type, count) > ctx->Array.ArrayObj->ElementArrayBufferObj->Size) { |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 461 | _mesa_warning(ctx, |
| 462 | "glDrawElementsInstanced index out of buffer bounds"); |
| 463 | return GL_FALSE; |
| 464 | } |
| 465 | } |
| 466 | else { |
| 467 | /* not using a VBO */ |
| 468 | if (!indices) |
| 469 | return GL_FALSE; |
| 470 | } |
| 471 | |
| Pierre-Eric Pelloux-Prayer | 09201cc | 2011-05-31 13:33:54 +0200 | [diff] [blame] | 472 | if (!check_index_bounds(ctx, count, type, indices, basevertex)) |
| Brian Paul | cf3193a | 2010-04-04 18:18:28 -0600 | [diff] [blame] | 473 | return GL_FALSE; |
| 474 | |
| 475 | return GL_TRUE; |
| 476 | } |