blob: 3b78f97fb7afae7c0d764ac4ef966b440f68484f [file] [log] [blame]
Jorge Lucangeli Obesa6b034d2012-08-07 15:29:20 -07001/* Copyright (c) 2012 The Chromium OS Authors. All rights reserved.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07002 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07004 */
5
Jorge Lucangeli Obes960b56b2017-11-17 11:49:58 -05006#include <errno.h>
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -07007#include <stdio.h>
8#include <stdlib.h>
9#include <string.h>
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070010
11#include "syscall_filter.h"
12
Jorge Lucangeli Obesa6b034d2012-08-07 15:29:20 -070013#include "util.h"
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -070014
Jorge Lucangeli Obes3dc257c2016-11-01 12:25:04 -040015/* clang-format off */
Jorge Lucangeli Obesa6b034d2012-08-07 15:29:20 -070016#define ONE_INSTR 1
17#define TWO_INSTRS 2
Luis Hector Chavez7624e712017-08-28 19:30:59 -070018
19#define compiler_warn(_state, _msg, ...) \
20 warn("%s: %s(%zd): " _msg, __func__, (_state)->filename, \
21 (_state)->line_number, ## __VA_ARGS__)
22
23#define compiler_pwarn(_state, _msg, ...) \
24 compiler_warn(_state, _msg ": %m", ## __VA_ARGS__)
Jorge Lucangeli Obes3dc257c2016-11-01 12:25:04 -040025/* clang-format on */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -070026
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -040027int seccomp_can_softfail(void)
Jorge Lucangeli Obes7b2e29c2016-08-04 12:21:03 -040028{
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -040029#if defined(USE_SECCOMP_SOFTFAIL)
Jeff Vander Stoep1022fc32016-08-28 12:24:55 -070030 return 1;
Jorge Lucangeli Obes7b2e29c2016-08-04 12:21:03 -040031#endif
32 return 0;
33}
34
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070035int str_to_op(const char *op_str)
36{
37 if (!strcmp(op_str, "==")) {
38 return EQ;
39 } else if (!strcmp(op_str, "!=")) {
40 return NE;
Luis Hector Chavez1c937832018-07-21 22:45:47 -070041 } else if (!strcmp(op_str, "<")) {
42 return LT;
43 } else if (!strcmp(op_str, "<=")) {
44 return LE;
45 } else if (!strcmp(op_str, ">")) {
46 return GT;
47 } else if (!strcmp(op_str, ">=")) {
48 return GE;
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -080049 } else if (!strcmp(op_str, "&")) {
50 return SET;
Jorge Lucangeli Obesfd6f8e32016-10-12 11:19:28 -040051 } else if (!strcmp(op_str, "in")) {
52 return IN;
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070053 } else {
54 return 0;
55 }
56}
57
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070058struct sock_filter *new_instr_buf(size_t count)
59{
60 struct sock_filter *buf = calloc(count, sizeof(struct sock_filter));
61 if (!buf)
Jorge Lucangeli Obes224e4272012-08-02 14:31:39 -070062 die("could not allocate BPF instruction buffer");
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070063
64 return buf;
65}
66
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -040067struct filter_block *new_filter_block(void)
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -070068{
69 struct filter_block *block = calloc(1, sizeof(struct filter_block));
70 if (!block)
71 die("could not allocate BPF filter block");
72
73 block->instrs = NULL;
74 block->last = block->next = NULL;
75
76 return block;
77}
78
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -040079void append_filter_block(struct filter_block *head, struct sock_filter *instrs,
80 size_t len)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070081{
82 struct filter_block *new_last;
83
84 /*
85 * If |head| has no filter assigned yet,
86 * we don't create a new node.
87 */
88 if (head->instrs == NULL) {
89 new_last = head;
90 } else {
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -070091 new_last = new_filter_block();
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -070092 if (head->next != NULL) {
93 head->last->next = new_last;
94 head->last = new_last;
95 } else {
96 head->last = head->next = new_last;
97 }
98 head->total_len += len;
99 }
100
101 new_last->instrs = instrs;
102 new_last->total_len = new_last->len = len;
103 new_last->last = new_last->next = NULL;
104}
105
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700106void extend_filter_block_list(struct filter_block *list,
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400107 struct filter_block *another)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700108{
109 if (list->last != NULL) {
110 list->last->next = another;
111 list->last = another->last;
112 } else {
113 list->next = another;
114 list->last = another->last;
115 }
116 list->total_len += another->total_len;
117}
118
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700119void append_ret_kill(struct filter_block *head)
120{
121 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
122 set_bpf_ret_kill(filter);
123 append_filter_block(head, filter, ONE_INSTR);
124}
125
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700126void append_ret_trap(struct filter_block *head)
127{
128 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
129 set_bpf_ret_trap(filter);
130 append_filter_block(head, filter, ONE_INSTR);
131}
132
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700133void append_ret_errno(struct filter_block *head, int errno_val)
134{
135 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
136 set_bpf_ret_errno(filter, errno_val);
137 append_filter_block(head, filter, ONE_INSTR);
138}
139
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400140void append_ret_log(struct filter_block *head)
141{
142 struct sock_filter *filter = new_instr_buf(ONE_INSTR);
143 set_bpf_ret_log(filter);
144 append_filter_block(head, filter, ONE_INSTR);
145}
146
Jorge Lucangeli Obesc8b21e12014-06-13 14:26:16 -0700147void append_allow_syscall(struct filter_block *head, int nr)
148{
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700149 struct sock_filter *filter = new_instr_buf(ALLOW_SYSCALL_LEN);
150 size_t len = bpf_allow_syscall(filter, nr);
151 if (len != ALLOW_SYSCALL_LEN)
152 die("error building syscall number comparison");
153
154 append_filter_block(head, filter, len);
155}
156
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400157void allow_logging_syscalls(struct filter_block *head)
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700158{
159 unsigned int i;
Kees Cook03b2af22014-12-18 17:11:13 -0800160 for (i = 0; i < log_syscalls_len; i++) {
161 warn("allowing syscall: %s", log_syscalls[i]);
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700162 append_allow_syscall(head, lookup_syscall(log_syscalls[i]));
Kees Cook03b2af22014-12-18 17:11:13 -0800163 }
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700164}
165
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700166unsigned int get_label_id(struct bpf_labels *labels, const char *label_str)
167{
168 int label_id = bpf_label_id(labels, label_str);
169 if (label_id < 0)
Jorge Lucangeli Obes224e4272012-08-02 14:31:39 -0700170 die("could not allocate BPF label string");
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700171 return label_id;
172}
173
174unsigned int group_end_lbl(struct bpf_labels *labels, int nr, int idx)
175{
176 char lbl_str[MAX_BPF_LABEL_LEN];
177 snprintf(lbl_str, MAX_BPF_LABEL_LEN, "%d_%d_end", nr, idx);
178 return get_label_id(labels, lbl_str);
179}
180
181unsigned int success_lbl(struct bpf_labels *labels, int nr)
182{
183 char lbl_str[MAX_BPF_LABEL_LEN];
184 snprintf(lbl_str, MAX_BPF_LABEL_LEN, "%d_success", nr);
185 return get_label_id(labels, lbl_str);
186}
187
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400188int is_implicit_relative_path(const char *filename)
189{
190 return filename[0] != '/' && (filename[0] != '.' || filename[1] != '/');
191}
192
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700193int compile_atom(struct parser_state *state, struct filter_block *head,
194 char *atom, struct bpf_labels *labels, int nr, int grp_idx)
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800195{
196 /* Splits the atom. */
Luis Hector Chavez95582e72017-09-05 09:13:25 -0700197 char *atom_ptr = NULL;
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800198 char *argidx_str = strtok_r(atom, " ", &atom_ptr);
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400199 if (argidx_str == NULL) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700200 compiler_warn(state, "empty atom");
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400201 return -1;
202 }
203
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800204 char *operator_str = strtok_r(NULL, " ", &atom_ptr);
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400205 if (operator_str == NULL) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700206 compiler_warn(state, "invalid atom '%s'", argidx_str);
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400207 return -1;
208 }
209
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800210 char *constant_str = strtok_r(NULL, " ", &atom_ptr);
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400211 if (constant_str == NULL) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700212 compiler_warn(state, "invalid atom '%s %s'", argidx_str,
213 operator_str);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800214 return -1;
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400215 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800216
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400217 /* Checks that there are no extra tokens. */
218 const char *extra = strtok_r(NULL, " ", &atom_ptr);
219 if (extra != NULL) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700220 compiler_warn(state, "extra token '%s'", extra);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800221 return -1;
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400222 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800223
224 if (strncmp(argidx_str, "arg", 3)) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700225 compiler_warn(state, "invalid argument token '%s'", argidx_str);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800226 return -1;
227 }
228
229 char *argidx_ptr;
230 long int argidx = strtol(argidx_str + 3, &argidx_ptr, 10);
231 /*
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400232 * Checks that an actual argument index was parsed,
233 * and that there was nothing left after the index.
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800234 */
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400235 if (argidx_ptr == argidx_str + 3 || *argidx_ptr != '\0') {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700236 compiler_warn(state, "invalid argument index '%s'",
237 argidx_str + 3);
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400238 return -1;
239 }
240
241 int op = str_to_op(operator_str);
242 if (op < MIN_OPERATOR) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700243 compiler_warn(state, "invalid operator '%s'", operator_str);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800244 return -1;
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400245 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800246
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700247 char *constant_str_ptr;
248 long int c = parse_constant(constant_str, &constant_str_ptr);
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400249 if (constant_str_ptr == constant_str) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700250 compiler_warn(state, "invalid constant '%s'", constant_str);
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700251 return -1;
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400252 }
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700253
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800254 /*
255 * Looks up the label for the end of the AND statement
256 * this atom belongs to.
257 */
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400258 unsigned int id = group_end_lbl(labels, nr, grp_idx);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800259
260 /*
261 * Builds a BPF comparison between a syscall argument
262 * and a constant.
263 * The comparison lives inside an AND statement.
264 * If the comparison succeeds, we continue
265 * to the next comparison.
266 * If this comparison fails, the whole AND statement
267 * will fail, so we jump to the end of this AND statement.
268 */
269 struct sock_filter *comp_block;
270 size_t len = bpf_arg_comp(&comp_block, op, argidx, c, id);
271 if (len == 0)
272 return -1;
273
274 append_filter_block(head, comp_block, len);
275 return 0;
276}
277
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700278int compile_errno(struct parser_state *state, struct filter_block *head,
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400279 char *ret_errno, enum block_action action)
Jorge Lucangeli Obesc8b21e12014-06-13 14:26:16 -0700280{
Kees Cookddb79702017-04-12 16:36:45 -0700281 char *errno_ptr = NULL;
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800282
283 /* Splits the 'return' keyword and the actual errno value. */
284 char *ret_str = strtok_r(ret_errno, " ", &errno_ptr);
Luis Hector Chavez52f3dd72017-09-01 19:14:22 -0700285 if (!ret_str || strncmp(ret_str, "return", strlen("return")))
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800286 return -1;
287
288 char *errno_val_str = strtok_r(NULL, " ", &errno_ptr);
289
290 if (errno_val_str) {
291 char *errno_val_ptr;
Luis Hector Chavez40b25742013-09-22 19:44:06 -0700292 int errno_val = parse_constant(errno_val_str, &errno_val_ptr);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800293 /* Checks to see if we parsed an actual errno. */
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400294 if (errno_val_ptr == errno_val_str || errno_val == -1) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700295 compiler_warn(state, "invalid errno value '%s'",
296 errno_val_ptr);
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800297 return -1;
Jorge Lucangeli Obes53895402016-10-18 12:02:58 -0400298 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800299
300 append_ret_errno(head, errno_val);
301 } else {
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400302 switch (action) {
303 case ACTION_RET_KILL:
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700304 append_ret_kill(head);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400305 break;
306 case ACTION_RET_TRAP:
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700307 append_ret_trap(head);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400308 break;
309 case ACTION_RET_LOG:
310 compiler_warn(state, "invalid action: ACTION_RET_LOG");
311 return -1;
312 }
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800313 }
314 return 0;
315}
316
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700317struct filter_block *compile_policy_line(struct parser_state *state, int nr,
318 const char *policy_line,
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400319 unsigned int entry_lbl_id,
320 struct bpf_labels *labels,
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400321 enum block_action action)
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700322{
323 /*
324 * |policy_line| should be an expression of the form:
325 * "arg0 == 3 && arg1 == 5 || arg0 == 0x8"
326 *
327 * This is, an expression in DNF (disjunctive normal form);
328 * a disjunction ('||') of one or more conjunctions ('&&')
329 * of one or more atoms.
330 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700331 * Atoms are of the form "arg{DNUM} {OP} {NUM}"
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700332 * where:
333 * - DNUM is a decimal number.
Jorge Lucangeli Obes21c3ab12016-10-12 18:37:37 -0400334 * - OP is an operator: ==, !=, & (flags set), or 'in' (inclusion).
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800335 * - NUM is an octal, decimal, or hexadecimal number.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700336 *
337 * When the syscall arguments make the expression true,
338 * the syscall is allowed. If not, the process is killed.
339 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700340 * To block a syscall without killing the process,
341 * |policy_line| can be of the form:
342 * "return <errno>"
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700343 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700344 * This "return {NUM}" policy line will block the syscall,
345 * make it return -1 and set |errno| to NUM.
346 *
347 * A regular policy line can also include a "return <errno>" clause,
348 * separated by a semicolon (';'):
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700349 * "arg0 == 3 && arg1 == 5 || arg0 == 0x8; return {NUM}"
350 *
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700351 * If the syscall arguments don't make the expression true,
352 * the syscall will be blocked as above instead of killing the process.
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700353 */
354
355 size_t len = 0;
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400356 int grp_idx = 0;
357
358 /* Checks for empty policy lines. */
359 if (strlen(policy_line) == 0) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700360 compiler_warn(state, "empty policy line");
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400361 return NULL;
362 }
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700363
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700364 /* We will modify |policy_line|, so let's make a copy. */
Mike Frysingercf48b442018-08-07 01:59:51 -0400365 char *line = strdup(policy_line);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700366 if (!line)
367 return NULL;
368
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700369 /*
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700370 * We build the filter section as a collection of smaller
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700371 * "filter blocks" linked together in a singly-linked list.
372 */
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700373 struct filter_block *head = new_filter_block();
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700374
375 /*
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700376 * Filter sections begin with a label where the main filter
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700377 * will jump after checking the syscall number.
378 */
379 struct sock_filter *entry_label = new_instr_buf(ONE_INSTR);
380 set_bpf_lbl(entry_label, entry_lbl_id);
381 append_filter_block(head, entry_label, ONE_INSTR);
382
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700383 /* Checks whether we're unconditionally blocking this syscall. */
384 if (strncmp(line, "return", strlen("return")) == 0) {
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400385 if (compile_errno(state, head, line, action) < 0) {
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400386 free_block_list(head);
387 free(line);
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700388 return NULL;
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400389 }
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700390 free(line);
391 return head;
392 }
393
394 /* Splits the optional "return <errno>" part. */
395 char *line_ptr;
396 char *arg_filter = strtok_r(line, ";", &line_ptr);
397 char *ret_errno = strtok_r(NULL, ";", &line_ptr);
398
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700399 /*
400 * Splits the policy line by '||' into conjunctions and each conjunction
401 * by '&&' into atoms.
402 */
Jorge Lucangeli Obes66cfc142012-11-30 15:42:52 -0800403 char *arg_filter_str = arg_filter;
404 char *group;
405 while ((group = tokenize(&arg_filter_str, "||")) != NULL) {
406 char *group_str = group;
407 char *comp;
408 while ((comp = tokenize(&group_str, "&&")) != NULL) {
409 /* Compiles each atom into a BPF block. */
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700410 if (compile_atom(state, head, comp, labels, nr,
411 grp_idx) < 0) {
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400412 free_block_list(head);
413 free(line);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700414 return NULL;
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400415 }
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700416 }
417 /*
418 * If the AND statement succeeds, we're done,
419 * so jump to SUCCESS line.
420 */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700421 unsigned int id = success_lbl(labels, nr);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700422 struct sock_filter *group_end_block = new_instr_buf(TWO_INSTRS);
423 len = set_bpf_jump_lbl(group_end_block, id);
424 /*
425 * The end of each AND statement falls after the
426 * jump to SUCCESS.
427 */
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400428 id = group_end_lbl(labels, nr, grp_idx++);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700429 len += set_bpf_lbl(group_end_block + len, id);
430 append_filter_block(head, group_end_block, len);
431 }
432
433 /*
434 * If no AND statements succeed, we end up here,
435 * because we never jumped to SUCCESS.
436 * If we have to return an errno, do it,
437 * otherwise just kill the task.
438 */
439 if (ret_errno) {
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400440 if (compile_errno(state, head, ret_errno, action) < 0) {
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400441 free_block_list(head);
442 free(line);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700443 return NULL;
Jorge Lucangeli Obes1a122b82016-11-01 11:59:33 -0400444 }
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700445 } else {
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400446 switch (action) {
447 case ACTION_RET_KILL:
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700448 append_ret_kill(head);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400449 break;
450 case ACTION_RET_TRAP:
Jennifer Pullmanc0bfae02016-05-26 17:00:36 -0700451 append_ret_trap(head);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400452 break;
453 case ACTION_RET_LOG:
454 append_ret_log(head);
455 break;
456 }
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700457 }
458
459 /*
460 * Every time the filter succeeds we jump to a predefined SUCCESS
461 * label. Add that label and BPF RET_ALLOW code now.
462 */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700463 unsigned int id = success_lbl(labels, nr);
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700464 struct sock_filter *success_block = new_instr_buf(TWO_INSTRS);
465 len = set_bpf_lbl(success_block, id);
466 len += set_bpf_ret_allow(success_block + len);
467 append_filter_block(head, success_block, len);
468
469 free(line);
470 return head;
471}
472
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700473int parse_include_statement(struct parser_state *state, char *policy_line,
474 unsigned int include_level,
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400475 const char **ret_filename)
476{
477 if (strncmp("@include", policy_line, strlen("@include")) != 0) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700478 compiler_warn(state, "invalid statement '%s'", policy_line);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400479 return -1;
480 }
481
482 if (policy_line[strlen("@include")] != ' ') {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700483 compiler_warn(state, "invalid include statement '%s'",
484 policy_line);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400485 return -1;
486 }
487
488 /*
489 * Disallow nested includes: only the initial policy file can have
490 * @include statements.
491 * Nested includes are not currently necessary and make the policy
492 * harder to understand.
493 */
494 if (include_level > 0) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700495 compiler_warn(state, "@include statement nested too deep");
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400496 return -1;
497 }
498
499 char *statement = policy_line;
500 /* Discard "@include" token. */
501 (void)strsep(&statement, " ");
502
503 /*
504 * compile_filter() below receives a FILE*, so it's not trivial to open
505 * included files relative to the initial policy filename.
506 * To avoid mistakes, force the included file path to be absolute
507 * (start with '/'), or to explicitly load the file relative to CWD by
508 * using './'.
509 */
510 const char *filename = statement;
511 if (is_implicit_relative_path(filename)) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700512 compiler_warn(
513 state,
514 "implicit relative path '%s' not supported, use './%s'",
515 filename, filename);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400516 return -1;
517 }
518
519 *ret_filename = filename;
520 return 0;
521}
522
Mike Frysinger29c72342019-03-15 01:39:31 -0400523/*
524 * This is like getline() but supports line wrapping with \.
525 */
526static ssize_t getmultiline(char **lineptr, size_t *n, FILE *stream)
527{
528 ssize_t ret = getline(lineptr, n, stream);
529 if (ret < 0)
530 return ret;
531
532 char *line = *lineptr;
533 /* Eat the newline to make processing below easier. */
534 if (ret > 0 && line[ret - 1] == '\n')
535 line[--ret] = '\0';
536
537 /* If the line doesn't end in a backslash, we're done. */
538 if (ret <= 0 || line[ret - 1] != '\\')
539 return ret;
540
541 /* This line ends in a backslash. Get the nextline. */
542 line[--ret] = '\0';
543 size_t next_n = 0;
544 char *next_line = NULL;
545 ssize_t next_ret = getmultiline(&next_line, &next_n, stream);
546 if (next_ret == -1) {
547 free(next_line);
548 /* We couldn't fully read the line, so return an error. */
549 return -1;
550 }
551
552 /* Merge the lines. */
553 *n = ret + next_ret + 2;
554 line = realloc(line, *n);
555 line[ret] = ' ';
556 memcpy(&line[ret + 1], next_line, next_ret + 1);
557 free(next_line);
558 *lineptr = line;
Mike Frysingere4c69652019-06-26 04:33:17 -0400559 return *n - 1;
Mike Frysinger29c72342019-03-15 01:39:31 -0400560}
561
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700562int compile_file(const char *filename, FILE *policy_file,
563 struct filter_block *head, struct filter_block **arg_blocks,
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400564 struct bpf_labels *labels,
565 const struct filter_options *filteropts,
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400566 unsigned int include_level)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700567{
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700568 /* clang-format off */
569 struct parser_state state = {
570 .filename = filename,
571 .line_number = 0,
572 };
573 /* clang-format on */
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400574 /*
575 * Loop through all the lines in the policy file.
576 * Build a jump table for the syscall number.
577 * If the policy line has an arg filter, build the arg filter
578 * as well.
579 * Chain the filter sections together and dump them into
580 * the final buffer at the end.
581 */
582 char *line = NULL;
583 size_t len = 0;
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400584 int ret = 0;
585
Mike Frysinger29c72342019-03-15 01:39:31 -0400586 while (getmultiline(&line, &len, policy_file) != -1) {
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400587 char *policy_line = line;
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400588 policy_line = strip(policy_line);
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400589
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700590 state.line_number++;
591
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400592 /* Allow comments and empty lines. */
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400593 if (*policy_line == '#' || *policy_line == '\0') {
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400594 /* Reuse |line| in the next getline() call. */
595 continue;
596 }
597
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400598 /* Allow @include statements. */
599 if (*policy_line == '@') {
600 const char *filename = NULL;
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700601 if (parse_include_statement(&state, policy_line,
602 include_level,
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400603 &filename) != 0) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700604 compiler_warn(
605 &state,
606 "failed to parse include statement");
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400607 ret = -1;
608 goto free_line;
609 }
610
611 FILE *included_file = fopen(filename, "re");
612 if (included_file == NULL) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700613 compiler_pwarn(&state, "fopen('%s') failed",
614 filename);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400615 ret = -1;
616 goto free_line;
617 }
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700618 if (compile_file(filename, included_file, head,
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400619 arg_blocks, labels, filteropts,
Zach Reiznere9260512019-02-27 18:06:34 -0800620 include_level + 1) == -1) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700621 compiler_warn(&state, "'@include %s' failed",
622 filename);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400623 fclose(included_file);
624 ret = -1;
625 goto free_line;
626 }
627 fclose(included_file);
628 continue;
629 }
630
631 /*
632 * If it's not a comment, or an empty line, or an @include
633 * statement, treat |policy_line| as a regular policy line.
634 */
635 char *syscall_name = strsep(&policy_line, ":");
lhchavezd0b40702017-09-01 04:17:41 +0000636 if (policy_line == NULL) {
637 warn("compile_file: malformed policy line, missing "
638 "':'");
639 ret = -1;
640 goto free_line;
641 }
642
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400643 policy_line = strip(policy_line);
644 if (*policy_line == '\0') {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700645 compiler_warn(&state, "empty policy line");
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400646 ret = -1;
647 goto free_line;
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400648 }
649
Jorge Lucangeli Obesc4992572017-04-28 10:49:01 -0400650 syscall_name = strip(syscall_name);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400651 int nr = lookup_syscall(syscall_name);
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400652 if (nr < 0) {
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700653 compiler_warn(&state, "nonexistent syscall '%s'",
654 syscall_name);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400655 if (filteropts->allow_logging) {
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400656 /*
657 * If we're logging failures, assume we're in a
658 * debugging case and continue.
659 * This is not super risky because an invalid
660 * syscall name is likely caused by a typo or by
661 * leftover lines from a different architecture.
662 * In either case, not including a policy line
663 * is equivalent to killing the process if the
664 * syscall is made, so there's no added attack
665 * surface.
666 */
667 /* Reuse |line| in the next getline() call. */
668 continue;
669 }
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400670 ret = -1;
671 goto free_line;
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400672 }
673
674 /*
675 * For each syscall, add either a simple ALLOW,
676 * or an arg filter block.
677 */
678 if (strcmp(policy_line, "1") == 0) {
679 /* Add simple ALLOW. */
680 append_allow_syscall(head, nr);
681 } else {
682 /*
683 * Create and jump to the label that will hold
684 * the arg filter block.
685 */
686 unsigned int id = bpf_label_id(labels, syscall_name);
687 struct sock_filter *nr_comp =
688 new_instr_buf(ALLOW_SYSCALL_LEN);
689 bpf_allow_syscall_args(nr_comp, nr, id);
690 append_filter_block(head, nr_comp, ALLOW_SYSCALL_LEN);
691
692 /* Build the arg filter block. */
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400693 struct filter_block *block =
694 compile_policy_line(&state, nr, policy_line, id,
695 labels, filteropts->action);
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400696
697 if (!block) {
698 if (*arg_blocks) {
699 free_block_list(*arg_blocks);
lhchavezd38280c2017-09-01 14:00:05 +0000700 *arg_blocks = NULL;
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400701 }
Jorge Lucangeli Obes32201f82019-06-12 14:45:06 -0400702 warn("could not allocate filter block");
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400703 ret = -1;
704 goto free_line;
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400705 }
706
707 if (*arg_blocks) {
708 extend_filter_block_list(*arg_blocks, block);
709 } else {
710 *arg_blocks = block;
711 }
712 }
713 /* Reuse |line| in the next getline() call. */
714 }
Jorge Lucangeli Obes960b56b2017-11-17 11:49:58 -0500715 /* getline(3) returned -1. This can mean EOF or the below errors. */
716 if (errno == EINVAL || errno == ENOMEM) {
717 if (*arg_blocks) {
718 free_block_list(*arg_blocks);
719 *arg_blocks = NULL;
720 }
Jorge Lucangeli Obes32201f82019-06-12 14:45:06 -0400721 warn("getmultiline() failed");
Jorge Lucangeli Obes960b56b2017-11-17 11:49:58 -0500722 ret = -1;
723 }
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400724
725free_line:
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400726 free(line);
Jorge Lucangeli Obesbce4ccb2017-03-20 13:38:43 -0400727 return ret;
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400728}
729
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700730int compile_filter(const char *filename, FILE *initial_file,
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400731 struct sock_fprog *prog,
732 const struct filter_options *filteropts)
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400733{
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700734 int ret = 0;
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700735 struct bpf_labels labels;
736 labels.count = 0;
737
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400738 if (!initial_file) {
739 warn("compile_filter: |initial_file| is NULL");
Jorge Lucangeli Obes6135db92012-07-27 13:37:30 -0700740 return -1;
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400741 }
Jorge Lucangeli Obes6135db92012-07-27 13:37:30 -0700742
Jorge Lucangeli Obesd96baf42013-03-26 15:11:30 -0700743 struct filter_block *head = new_filter_block();
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700744 struct filter_block *arg_blocks = NULL;
745
746 /* Start filter by validating arch. */
747 struct sock_filter *valid_arch = new_instr_buf(ARCH_VALIDATION_LEN);
748 size_t len = bpf_validate_arch(valid_arch);
749 append_filter_block(head, valid_arch, len);
750
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700751 /* Load syscall number. */
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700752 struct sock_filter *load_nr = new_instr_buf(ONE_INSTR);
753 len = bpf_load_syscall_nr(load_nr);
754 append_filter_block(head, load_nr, len);
755
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400756 /*
757 * On kernels without SECCOMP_RET_LOG, Minijail can attempt to write the
758 * first failing syscall to syslog(3). In order for syslog(3) to work,
759 * some syscalls need to be unconditionally allowed.
760 */
761 if (filteropts->allow_syscalls_for_logging)
Jorge Lucangeli Obes713f6fb2016-10-03 13:03:25 -0400762 allow_logging_syscalls(head);
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700763
Luis Hector Chavez7624e712017-08-28 19:30:59 -0700764 if (compile_file(filename, initial_file, head, &arg_blocks, &labels,
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400765 filteropts, 0 /* include_level */) != 0) {
Jorge Lucangeli Obes45932a52017-03-15 17:02:58 -0400766 warn("compile_filter: compile_file() failed");
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700767 ret = -1;
768 goto free_filter;
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700769 }
770
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700771 /*
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400772 * If none of the syscalls match, either fall through to LOG, TRAP, or
773 * KILL.
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700774 */
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400775 switch (filteropts->action) {
776 case ACTION_RET_KILL:
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700777 append_ret_kill(head);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400778 break;
779 case ACTION_RET_TRAP:
Jorge Lucangeli Obesbda833c2012-07-31 16:25:56 -0700780 append_ret_trap(head);
Jorge Lucangeli Obese1a86892019-06-10 16:17:03 -0400781 break;
782 case ACTION_RET_LOG:
783 if (filteropts->allow_logging) {
784 append_ret_log(head);
785 } else {
786 warn("compile_filter: cannot use RET_LOG without "
787 "allowing logging");
788 ret = -1;
789 goto free_filter;
790 }
791 break;
792 default:
793 warn("compile_filter: invalid log action %d",
794 filteropts->action);
795 ret = -1;
796 goto free_filter;
797 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700798
799 /* Allocate the final buffer, now that we know its size. */
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400800 size_t final_filter_len =
801 head->total_len + (arg_blocks ? arg_blocks->total_len : 0);
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700802 if (final_filter_len > BPF_MAXINSNS) {
803 ret = -1;
804 goto free_filter;
805 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700806
807 struct sock_filter *final_filter =
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400808 calloc(final_filter_len, sizeof(struct sock_filter));
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700809
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700810 if (flatten_block_list(head, final_filter, 0, final_filter_len) < 0) {
811 free(final_filter);
812 ret = -1;
813 goto free_filter;
814 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700815
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400816 if (flatten_block_list(arg_blocks, final_filter, head->total_len,
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700817 final_filter_len) < 0) {
818 free(final_filter);
819 ret = -1;
820 goto free_filter;
821 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700822
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700823 if (bpf_resolve_jumps(&labels, final_filter, final_filter_len) < 0) {
824 free(final_filter);
825 ret = -1;
826 goto free_filter;
827 }
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700828
829 prog->filter = final_filter;
830 prog->len = final_filter_len;
Luis Hector Chavez1a87c8a2017-09-02 13:18:31 -0700831
832free_filter:
833 free_block_list(head);
834 free_block_list(arg_blocks);
835 free_label_strings(&labels);
836 return ret;
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700837}
838
839int flatten_block_list(struct filter_block *head, struct sock_filter *filter,
Jorge Lucangeli Obes565e9782016-08-05 11:03:19 -0400840 size_t index, size_t cap)
Jorge Lucangeli Obesd4467262012-03-23 16:19:59 -0700841{
842 size_t _index = index;
843
844 struct filter_block *curr;
845 size_t i;
846
847 for (curr = head; curr; curr = curr->next) {
848 for (i = 0; i < curr->len; i++) {
849 if (_index >= cap)
850 return -1;
851 filter[_index++] = curr->instrs[i];
852 }
853 }
854 return 0;
855}
856
Jorge Lucangeli Obesfc8ab532012-03-20 10:14:31 -0700857void free_block_list(struct filter_block *head)
858{
859 struct filter_block *current, *prev;
860
861 current = head;
862 while (current) {
863 free(current->instrs);
864 prev = current;
865 current = current->next;
866 free(prev);
867 }
868}