blob: 3e121b5617a1e826c1b6e5b9b20a39c2758f0747 [file] [log] [blame]
David Tolnay7db73692019-10-20 14:51:12 -04001use crate::syntax::atom::Atom::{self, *};
David Tolnayd763f4c2020-04-22 16:09:19 -07002use crate::syntax::{
David Tolnay0b368ae2020-04-22 17:55:02 -07003 error, ident, Api, ExternFn, ExternType, Lang, Receiver, Ref, Slice, Struct, Ty1, Type, Types,
David Tolnayd763f4c2020-04-22 16:09:19 -07004};
David Tolnay09462ac2020-03-20 14:58:41 -07005use proc_macro2::{Delimiter, Group, Ident, TokenStream};
David Tolnaya420f012020-03-25 17:55:56 -07006use quote::{quote, ToTokens};
7use std::fmt::Display;
David Tolnay7db73692019-10-20 14:51:12 -04008use syn::{Error, Result};
9
David Tolnay26a2a1d2020-03-25 17:26:43 -070010struct Check<'a> {
11 apis: &'a [Api],
12 types: &'a Types<'a>,
13 errors: &'a mut Vec<Error>,
14}
15
David Tolnay7db73692019-10-20 14:51:12 -040016pub(crate) fn typecheck(apis: &[Api], types: &Types) -> Result<()> {
David Tolnay26a2a1d2020-03-25 17:26:43 -070017 let mut errors = Vec::new();
18 let mut cx = Check {
19 apis,
20 types,
21 errors: &mut errors,
22 };
23 do_typecheck(&mut cx);
24 combine_errors(errors)
25}
David Tolnay7db73692019-10-20 14:51:12 -040026
David Tolnay26a2a1d2020-03-25 17:26:43 -070027fn do_typecheck(cx: &mut Check) {
28 for ty in cx.types {
David Tolnay7db73692019-10-20 14:51:12 -040029 match ty {
David Tolnay26a2a1d2020-03-25 17:26:43 -070030 Type::Ident(ident) => check_type_ident(cx, ident),
31 Type::RustBox(ptr) => check_type_box(cx, ptr),
David Tolnayc6d891e2020-04-25 12:06:34 -070032 Type::RustVec(ty) => check_type_rust_vec(cx, ty),
David Tolnay26a2a1d2020-03-25 17:26:43 -070033 Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr),
David Tolnayfff4c8a2020-04-25 11:45:20 -070034 Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr),
David Tolnay26a2a1d2020-03-25 17:26:43 -070035 Type::Ref(ty) => check_type_ref(cx, ty),
David Tolnayeebe9b72020-04-14 16:32:18 -070036 Type::Slice(ty) => check_type_slice(cx, ty),
David Tolnay7db73692019-10-20 14:51:12 -040037 _ => {}
38 }
39 }
40
David Tolnay26a2a1d2020-03-25 17:26:43 -070041 for api in cx.apis {
David Tolnay7db73692019-10-20 14:51:12 -040042 match api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070043 Api::Struct(strct) => check_api_struct(cx, strct),
David Tolnay0b368ae2020-04-22 17:55:02 -070044 Api::CxxType(ty) | Api::RustType(ty) => check_api_type(cx, ty),
David Tolnay26a2a1d2020-03-25 17:26:43 -070045 Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn),
David Tolnay7db73692019-10-20 14:51:12 -040046 _ => {}
47 }
48 }
49
David Tolnay26a2a1d2020-03-25 17:26:43 -070050 for api in cx.apis {
David Tolnay7db73692019-10-20 14:51:12 -040051 if let Api::CxxFunction(efn) = api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070052 check_mut_return_restriction(cx, efn);
David Tolnay7db73692019-10-20 14:51:12 -040053 }
54 if let Api::CxxFunction(efn) | Api::RustFunction(efn) = api {
David Tolnay26a2a1d2020-03-25 17:26:43 -070055 check_multiple_arg_lifetimes(cx, efn);
David Tolnay7db73692019-10-20 14:51:12 -040056 }
57 }
58
David Tolnay26a2a1d2020-03-25 17:26:43 -070059 ident::check_all(cx.apis, cx.errors);
David Tolnay7db73692019-10-20 14:51:12 -040060}
61
David Tolnaya420f012020-03-25 17:55:56 -070062impl Check<'_> {
63 fn error(&mut self, sp: impl ToTokens, msg: impl Display) {
64 self.errors.push(Error::new_spanned(sp, msg));
65 }
66}
67
David Tolnay26a2a1d2020-03-25 17:26:43 -070068fn check_type_ident(cx: &mut Check, ident: &Ident) {
David Tolnayd4e68302020-03-25 12:04:17 -070069 if Atom::from(ident).is_none()
David Tolnay26a2a1d2020-03-25 17:26:43 -070070 && !cx.types.structs.contains_key(ident)
71 && !cx.types.cxx.contains(ident)
72 && !cx.types.rust.contains(ident)
David Tolnayd4e68302020-03-25 12:04:17 -070073 {
David Tolnaya420f012020-03-25 17:55:56 -070074 cx.error(ident, "unsupported type");
David Tolnayd4e68302020-03-25 12:04:17 -070075 }
76}
77
David Tolnay26a2a1d2020-03-25 17:26:43 -070078fn check_type_box(cx: &mut Check, ptr: &Ty1) {
David Tolnayd4e68302020-03-25 12:04:17 -070079 if let Type::Ident(ident) = &ptr.inner {
David Tolnay26a2a1d2020-03-25 17:26:43 -070080 if cx.types.cxx.contains(ident) {
David Tolnaya420f012020-03-25 17:55:56 -070081 cx.error(ptr, error::BOX_CXX_TYPE.msg);
David Tolnayd4e68302020-03-25 12:04:17 -070082 }
David Tolnaya420f012020-03-25 17:55:56 -070083
David Tolnayd4e68302020-03-25 12:04:17 -070084 if Atom::from(ident).is_none() {
85 return;
86 }
87 }
David Tolnaya420f012020-03-25 17:55:56 -070088
89 cx.error(ptr, "unsupported target type of Box");
David Tolnayd4e68302020-03-25 12:04:17 -070090}
91
David Tolnayc6d891e2020-04-25 12:06:34 -070092fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) {
93 if let Type::Ident(ident) = &ty.inner {
94 if cx.types.cxx.contains(ident) {
95 cx.error(ty, "Rust Vec containing C++ type is not supported yet");
Myron Ahneba35cf2020-02-05 19:41:51 +070096 return;
David Tolnayc6d891e2020-04-25 12:06:34 -070097 }
98
99 match Atom::from(ident) {
David Tolnay6bd63de2020-04-25 12:20:09 -0700100 None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8)
101 | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return,
102 Some(Bool) | Some(RustString) => { /* todo */ }
103 Some(CxxString) => {}
Myron Ahneba35cf2020-02-05 19:41:51 +0700104 }
105 }
106
David Tolnayc6d891e2020-04-25 12:06:34 -0700107 cx.error(ty, "unsupported element type of Vec");
Myron Ahneba35cf2020-02-05 19:41:51 +0700108}
109
David Tolnay26a2a1d2020-03-25 17:26:43 -0700110fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) {
David Tolnayd4e68302020-03-25 12:04:17 -0700111 if let Type::Ident(ident) = &ptr.inner {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700112 if cx.types.rust.contains(ident) {
David Tolnaya420f012020-03-25 17:55:56 -0700113 cx.error(ptr, "unique_ptr of a Rust type is not supported yet");
David Tolnayd4e68302020-03-25 12:04:17 -0700114 }
David Tolnaya420f012020-03-25 17:55:56 -0700115
David Tolnayd4e68302020-03-25 12:04:17 -0700116 match Atom::from(ident) {
117 None | Some(CxxString) => return,
118 _ => {}
119 }
David Tolnay4377a9e2020-04-24 15:20:26 -0700120 } else if let Type::CxxVector(_) = &ptr.inner {
Myron Ahneba35cf2020-02-05 19:41:51 +0700121 return;
David Tolnayd4e68302020-03-25 12:04:17 -0700122 }
David Tolnaya420f012020-03-25 17:55:56 -0700123
124 cx.error(ptr, "unsupported unique_ptr target type");
David Tolnayd4e68302020-03-25 12:04:17 -0700125}
126
David Tolnayfff4c8a2020-04-25 11:45:20 -0700127fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) {
Myron Ahneba35cf2020-02-05 19:41:51 +0700128 if let Type::Ident(ident) = &ptr.inner {
129 if cx.types.rust.contains(ident) {
David Tolnayc0faaf62020-04-25 12:18:38 -0700130 cx.error(
131 ptr,
132 "C++ vector containing a Rust type is not supported yet",
133 );
Myron Ahneba35cf2020-02-05 19:41:51 +0700134 }
135
136 match Atom::from(ident) {
David Tolnay6bd63de2020-04-25 12:20:09 -0700137 None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8)
138 | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return,
139 Some(CxxString) => { /* todo */ }
140 Some(Bool) | Some(RustString) => {}
Myron Ahneba35cf2020-02-05 19:41:51 +0700141 }
142 }
David Tolnayc0faaf62020-04-25 12:18:38 -0700143
Myron Ahneba35cf2020-02-05 19:41:51 +0700144 cx.error(ptr, "unsupported vector target type");
145}
146
David Tolnay26a2a1d2020-03-25 17:26:43 -0700147fn check_type_ref(cx: &mut Check, ty: &Ref) {
David Tolnayd763f4c2020-04-22 16:09:19 -0700148 if ty.lifetime.is_some() {
149 cx.error(ty, "references with explicit lifetimes are not supported");
150 }
151
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700152 match ty.inner {
153 Type::Fn(_) | Type::Void(_) => {}
David Tolnay776fd892020-04-28 13:38:21 -0700154 Type::Ref(_) => {
155 cx.error(ty, "C++ does not allow references to references");
156 return;
157 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700158 _ => return,
David Tolnayd4e68302020-03-25 12:04:17 -0700159 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700160
161 cx.error(ty, "unsupported reference type");
David Tolnayd4e68302020-03-25 12:04:17 -0700162}
163
David Tolnayeebe9b72020-04-14 16:32:18 -0700164fn check_type_slice(cx: &mut Check, ty: &Slice) {
165 cx.error(ty, "only &[u8] is supported so far, not other slice types");
166}
167
David Tolnay26a2a1d2020-03-25 17:26:43 -0700168fn check_api_struct(cx: &mut Check, strct: &Struct) {
David Tolnay0b368ae2020-04-22 17:55:02 -0700169 check_reserved_name(cx, &strct.ident);
170
David Tolnayd4e68302020-03-25 12:04:17 -0700171 if strct.fields.is_empty() {
David Tolnaya420f012020-03-25 17:55:56 -0700172 let span = span_for_struct_error(strct);
173 cx.error(span, "structs without any fields are not supported");
David Tolnayd4e68302020-03-25 12:04:17 -0700174 }
David Tolnaya420f012020-03-25 17:55:56 -0700175
David Tolnayd4e68302020-03-25 12:04:17 -0700176 for field in &strct.fields {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700177 if is_unsized(cx, &field.ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700178 let desc = describe(cx, &field.ty);
179 let msg = format!("using {} by value is not supported", desc);
180 cx.error(field, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700181 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700182 if let Type::Fn(_) = field.ty {
183 cx.error(
184 field,
185 "function pointers in a struct field are not implemented yet",
186 );
187 }
David Tolnayd4e68302020-03-25 12:04:17 -0700188 }
189}
190
David Tolnay0b368ae2020-04-22 17:55:02 -0700191fn check_api_type(cx: &mut Check, ty: &ExternType) {
192 check_reserved_name(cx, &ty.ident);
193}
194
David Tolnay26a2a1d2020-03-25 17:26:43 -0700195fn check_api_fn(cx: &mut Check, efn: &ExternFn) {
David Tolnayd763f4c2020-04-22 16:09:19 -0700196 if let Some(receiver) = &efn.receiver {
David Tolnaya1f29c42020-04-22 18:01:38 -0700197 let ref span = span_for_receiver_error(receiver);
198
199 if receiver.ty == "Self" {
200 let mutability = match receiver.mutability {
201 Some(_) => "mut ",
202 None => "",
203 };
204 let msg = format!(
205 "unnamed receiver type is only allowed if the surrounding \
206 extern block contains exactly one extern type; \
207 use `self: &{mutability}TheType`",
208 mutability = mutability,
209 );
210 cx.error(span, msg);
211 } else if !cx.types.structs.contains_key(&receiver.ty)
David Tolnay8b60bf12020-04-22 16:52:19 -0700212 && !cx.types.cxx.contains(&receiver.ty)
213 && !cx.types.rust.contains(&receiver.ty)
214 {
David Tolnay8b60bf12020-04-22 16:52:19 -0700215 cx.error(span, "unrecognized receiver type");
216 }
217
David Tolnayd763f4c2020-04-22 16:09:19 -0700218 if receiver.lifetime.is_some() {
David Tolnayd763f4c2020-04-22 16:09:19 -0700219 cx.error(span, "references with explicit lifetimes are not supported");
220 }
221 }
222
David Tolnayd4e68302020-03-25 12:04:17 -0700223 for arg in &efn.args {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700224 if is_unsized(cx, &arg.ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700225 let desc = describe(cx, &arg.ty);
226 let msg = format!("passing {} by value is not supported", desc);
227 cx.error(arg, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700228 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700229 if let Type::Fn(_) = arg.ty {
David Tolnay75dca2e2020-03-25 20:17:52 -0700230 if efn.lang == Lang::Rust {
231 cx.error(
232 arg,
233 "passing a function pointer from C++ to Rust is not implemented yet",
234 );
235 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700236 }
David Tolnayd4e68302020-03-25 12:04:17 -0700237 }
David Tolnaya420f012020-03-25 17:55:56 -0700238
David Tolnayd4e68302020-03-25 12:04:17 -0700239 if let Some(ty) = &efn.ret {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700240 if is_unsized(cx, ty) {
David Tolnaya420f012020-03-25 17:55:56 -0700241 let desc = describe(cx, ty);
242 let msg = format!("returning {} by value is not supported", desc);
243 cx.error(ty, msg);
David Tolnayd4e68302020-03-25 12:04:17 -0700244 }
David Tolnayd7e1f1e2020-03-18 21:06:37 -0700245 if let Type::Fn(_) = ty {
246 cx.error(ty, "returning a function pointer is not implemented yet");
247 }
David Tolnayd4e68302020-03-25 12:04:17 -0700248 }
David Tolnay7db73692019-10-20 14:51:12 -0400249}
250
David Tolnay26a2a1d2020-03-25 17:26:43 -0700251fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) {
David Tolnay7db73692019-10-20 14:51:12 -0400252 match &efn.ret {
253 Some(Type::Ref(ty)) if ty.mutability.is_some() => {}
David Tolnay26a2a1d2020-03-25 17:26:43 -0700254 _ => return,
David Tolnay7db73692019-10-20 14:51:12 -0400255 }
256
257 for arg in &efn.args {
258 if let Type::Ref(ty) = &arg.ty {
259 if ty.mutability.is_some() {
David Tolnay26a2a1d2020-03-25 17:26:43 -0700260 return;
David Tolnay7db73692019-10-20 14:51:12 -0400261 }
262 }
263 }
264
David Tolnaya420f012020-03-25 17:55:56 -0700265 cx.error(
David Tolnay7db73692019-10-20 14:51:12 -0400266 efn,
267 "&mut return type is not allowed unless there is a &mut argument",
David Tolnaya420f012020-03-25 17:55:56 -0700268 );
David Tolnay7db73692019-10-20 14:51:12 -0400269}
270
David Tolnay26a2a1d2020-03-25 17:26:43 -0700271fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) {
David Tolnay7db73692019-10-20 14:51:12 -0400272 match &efn.ret {
273 Some(Type::Ref(_)) => {}
David Tolnay26a2a1d2020-03-25 17:26:43 -0700274 _ => return,
David Tolnay7db73692019-10-20 14:51:12 -0400275 }
276
277 let mut reference_args = 0;
278 for arg in &efn.args {
279 if let Type::Ref(_) = &arg.ty {
280 reference_args += 1;
281 }
282 }
283
Joel Galenson3d4f6122020-04-07 15:54:05 -0700284 if efn.receiver.is_some() {
285 reference_args += 1;
286 }
287
David Tolnay26a2a1d2020-03-25 17:26:43 -0700288 if reference_args != 1 {
David Tolnaya420f012020-03-25 17:55:56 -0700289 cx.error(
David Tolnay7db73692019-10-20 14:51:12 -0400290 efn,
291 "functions that return a reference must take exactly one input reference",
David Tolnaya420f012020-03-25 17:55:56 -0700292 );
David Tolnay7db73692019-10-20 14:51:12 -0400293 }
294}
295
David Tolnay0b368ae2020-04-22 17:55:02 -0700296fn check_reserved_name(cx: &mut Check, ident: &Ident) {
David Tolnay99c93d82020-04-25 14:07:44 -0700297 if ident == "Box"
298 || ident == "UniquePtr"
299 || ident == "Vec"
300 || ident == "CxxVector"
301 || Atom::from(ident).is_some()
302 {
David Tolnay0b368ae2020-04-22 17:55:02 -0700303 cx.error(ident, "reserved name");
304 }
305}
306
David Tolnay26a2a1d2020-03-25 17:26:43 -0700307fn is_unsized(cx: &mut Check, ty: &Type) -> bool {
David Tolnayd4e68302020-03-25 12:04:17 -0700308 let ident = match ty {
309 Type::Ident(ident) => ident,
David Tolnaye70303c2020-04-25 15:02:37 -0700310 Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true,
David Tolnayd4e68302020-03-25 12:04:17 -0700311 _ => return false,
312 };
David Tolnay26a2a1d2020-03-25 17:26:43 -0700313 ident == CxxString || cx.types.cxx.contains(ident) || cx.types.rust.contains(ident)
314}
315
David Tolnaya420f012020-03-25 17:55:56 -0700316fn span_for_struct_error(strct: &Struct) -> TokenStream {
317 let struct_token = strct.struct_token;
318 let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new());
319 brace_token.set_span(strct.brace_token.span);
320 quote!(#struct_token #brace_token)
321}
322
David Tolnayd763f4c2020-04-22 16:09:19 -0700323fn span_for_receiver_error(receiver: &Receiver) -> TokenStream {
324 let ampersand = receiver.ampersand;
325 let lifetime = &receiver.lifetime;
326 let mutability = receiver.mutability;
327 if receiver.shorthand {
328 let var = receiver.var;
329 quote!(#ampersand #lifetime #mutability #var)
330 } else {
331 let ty = &receiver.ty;
332 quote!(#ampersand #lifetime #mutability #ty)
333 }
334}
335
David Tolnay26a2a1d2020-03-25 17:26:43 -0700336fn combine_errors(errors: Vec<Error>) -> Result<()> {
337 let mut iter = errors.into_iter();
338 let mut all_errors = match iter.next() {
339 Some(err) => err,
340 None => return Ok(()),
341 };
342 for err in iter {
343 all_errors.combine(err);
344 }
345 Err(all_errors)
David Tolnayd4e68302020-03-25 12:04:17 -0700346}
347
David Tolnaya420f012020-03-25 17:55:56 -0700348fn describe(cx: &mut Check, ty: &Type) -> String {
David Tolnay7db73692019-10-20 14:51:12 -0400349 match ty {
350 Type::Ident(ident) => {
David Tolnaya420f012020-03-25 17:55:56 -0700351 if cx.types.structs.contains_key(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400352 "struct".to_owned()
David Tolnaya420f012020-03-25 17:55:56 -0700353 } else if cx.types.cxx.contains(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400354 "C++ type".to_owned()
David Tolnaya420f012020-03-25 17:55:56 -0700355 } else if cx.types.rust.contains(ident) {
David Tolnay7db73692019-10-20 14:51:12 -0400356 "opaque Rust type".to_owned()
357 } else if Atom::from(ident) == Some(CxxString) {
358 "C++ string".to_owned()
359 } else {
360 ident.to_string()
361 }
362 }
363 Type::RustBox(_) => "Box".to_owned(),
Myron Ahneba35cf2020-02-05 19:41:51 +0700364 Type::RustVec(_) => "Vec".to_owned(),
David Tolnay7db73692019-10-20 14:51:12 -0400365 Type::UniquePtr(_) => "unique_ptr".to_owned(),
366 Type::Ref(_) => "reference".to_owned(),
367 Type::Str(_) => "&str".to_owned(),
David Tolnayfa85fce2020-04-25 15:03:25 -0700368 Type::CxxVector(_) => "C++ vector".to_owned(),
Adrian Taylorf5dd5522020-04-13 16:50:14 -0700369 Type::Slice(_) => "slice".to_owned(),
370 Type::SliceRefU8(_) => "&[u8]".to_owned(),
David Tolnay417305a2020-03-18 13:54:00 -0700371 Type::Fn(_) => "function pointer".to_owned(),
David Tolnay2fb14e92020-03-15 23:11:38 -0700372 Type::Void(_) => "()".to_owned(),
David Tolnay7db73692019-10-20 14:51:12 -0400373 }
374}