| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 1 | use crate::syntax::atom::Atom::{self, *}; |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 2 | use crate::syntax::namespace::Namespace; |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame^] | 3 | use crate::syntax::report::Errors; |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 4 | use crate::syntax::{ |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 5 | error, ident, Api, Enum, ExternFn, ExternType, Lang, Receiver, Ref, Slice, Struct, Ty1, Type, |
| 6 | Types, |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 7 | }; |
| David Tolnay | 09462ac | 2020-03-20 14:58:41 -0700 | [diff] [blame] | 8 | use proc_macro2::{Delimiter, Group, Ident, TokenStream}; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 9 | use quote::{quote, ToTokens}; |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 10 | use std::collections::HashSet; |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 11 | use std::fmt::Display; |
| David Tolnay | 8adb223 | 2020-05-01 10:14:27 -0700 | [diff] [blame] | 12 | use std::u32; |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame^] | 13 | use syn::Result; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 14 | |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 15 | pub(crate) struct Check<'a> { |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 16 | namespace: &'a Namespace, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 17 | apis: &'a [Api], |
| 18 | types: &'a Types<'a>, |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame^] | 19 | errors: &'a mut Errors, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 20 | } |
| 21 | |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 22 | pub(crate) fn typecheck(namespace: &Namespace, apis: &[Api], types: &Types) -> Result<()> { |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame^] | 23 | let mut errors = Errors::new(); |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 24 | let mut cx = Check { |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 25 | namespace, |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 26 | apis, |
| 27 | types, |
| 28 | errors: &mut errors, |
| 29 | }; |
| 30 | do_typecheck(&mut cx); |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame^] | 31 | errors.propagate() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 32 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 33 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 34 | fn do_typecheck(cx: &mut Check) { |
| David Tolnay | 6b6423e | 2020-04-30 20:46:24 -0700 | [diff] [blame] | 35 | ident::check_all(cx, cx.namespace, cx.apis); |
| David Tolnay | 9dcb833 | 2020-04-30 20:37:33 -0700 | [diff] [blame] | 36 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 37 | for ty in cx.types { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 38 | match ty { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 39 | Type::Ident(ident) => check_type_ident(cx, ident), |
| 40 | Type::RustBox(ptr) => check_type_box(cx, ptr), |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 41 | Type::RustVec(ty) => check_type_rust_vec(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 42 | Type::UniquePtr(ptr) => check_type_unique_ptr(cx, ptr), |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 43 | Type::CxxVector(ptr) => check_type_cxx_vector(cx, ptr), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 44 | Type::Ref(ty) => check_type_ref(cx, ty), |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 45 | Type::Slice(ty) => check_type_slice(cx, ty), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 46 | _ => {} |
| 47 | } |
| 48 | } |
| 49 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 50 | for api in cx.apis { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 51 | match api { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 52 | Api::Struct(strct) => check_api_struct(cx, strct), |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 53 | Api::Enum(enm) => check_api_enum(cx, enm), |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 54 | Api::CxxType(ty) | Api::RustType(ty) => check_api_type(cx, ty), |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 55 | Api::CxxFunction(efn) | Api::RustFunction(efn) => check_api_fn(cx, efn), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 56 | _ => {} |
| 57 | } |
| 58 | } |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 59 | } |
| 60 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 61 | impl Check<'_> { |
| David Tolnay | a83301c | 2020-04-30 20:32:37 -0700 | [diff] [blame] | 62 | pub(crate) fn error(&mut self, sp: impl ToTokens, msg: impl Display) { |
| David Tolnay | df344a8 | 2020-05-03 23:23:18 -0700 | [diff] [blame^] | 63 | self.errors.error(sp, msg); |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 64 | } |
| 65 | } |
| 66 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 67 | fn check_type_ident(cx: &mut Check, ident: &Ident) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 68 | if Atom::from(ident).is_none() |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 69 | && !cx.types.structs.contains_key(ident) |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 70 | && !cx.types.enums.contains_key(ident) |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 71 | && !cx.types.cxx.contains(ident) |
| 72 | && !cx.types.rust.contains(ident) |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 73 | { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 74 | cx.error(ident, "unsupported type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 75 | } |
| 76 | } |
| 77 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 78 | fn check_type_box(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 79 | if let Type::Ident(ident) = &ptr.inner { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 80 | if cx.types.cxx.contains(ident) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 81 | cx.error(ptr, error::BOX_CXX_TYPE.msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 82 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 83 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 84 | if Atom::from(ident).is_none() { |
| 85 | return; |
| 86 | } |
| 87 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 88 | |
| 89 | cx.error(ptr, "unsupported target type of Box"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 90 | } |
| 91 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 92 | fn check_type_rust_vec(cx: &mut Check, ty: &Ty1) { |
| 93 | if let Type::Ident(ident) = &ty.inner { |
| 94 | if cx.types.cxx.contains(ident) { |
| 95 | cx.error(ty, "Rust Vec containing C++ type is not supported yet"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 96 | return; |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 97 | } |
| 98 | |
| 99 | match Atom::from(ident) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 100 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| 101 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return, |
| 102 | Some(Bool) | Some(RustString) => { /* todo */ } |
| 103 | Some(CxxString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 104 | } |
| 105 | } |
| 106 | |
| David Tolnay | c6d891e | 2020-04-25 12:06:34 -0700 | [diff] [blame] | 107 | cx.error(ty, "unsupported element type of Vec"); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 108 | } |
| 109 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 110 | fn check_type_unique_ptr(cx: &mut Check, ptr: &Ty1) { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 111 | if let Type::Ident(ident) = &ptr.inner { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 112 | if cx.types.rust.contains(ident) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 113 | cx.error(ptr, "unique_ptr of a Rust type is not supported yet"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 114 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 115 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 116 | match Atom::from(ident) { |
| 117 | None | Some(CxxString) => return, |
| 118 | _ => {} |
| 119 | } |
| David Tolnay | 4377a9e | 2020-04-24 15:20:26 -0700 | [diff] [blame] | 120 | } else if let Type::CxxVector(_) = &ptr.inner { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 121 | return; |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 122 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 123 | |
| 124 | cx.error(ptr, "unsupported unique_ptr target type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 125 | } |
| 126 | |
| David Tolnay | fff4c8a | 2020-04-25 11:45:20 -0700 | [diff] [blame] | 127 | fn check_type_cxx_vector(cx: &mut Check, ptr: &Ty1) { |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 128 | if let Type::Ident(ident) = &ptr.inner { |
| 129 | if cx.types.rust.contains(ident) { |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 130 | cx.error( |
| 131 | ptr, |
| 132 | "C++ vector containing a Rust type is not supported yet", |
| 133 | ); |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 134 | } |
| 135 | |
| 136 | match Atom::from(ident) { |
| David Tolnay | 6bd63de | 2020-04-25 12:20:09 -0700 | [diff] [blame] | 137 | None | Some(U8) | Some(U16) | Some(U32) | Some(U64) | Some(Usize) | Some(I8) |
| 138 | | Some(I16) | Some(I32) | Some(I64) | Some(Isize) | Some(F32) | Some(F64) => return, |
| 139 | Some(CxxString) => { /* todo */ } |
| 140 | Some(Bool) | Some(RustString) => {} |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 141 | } |
| 142 | } |
| David Tolnay | c0faaf6 | 2020-04-25 12:18:38 -0700 | [diff] [blame] | 143 | |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 144 | cx.error(ptr, "unsupported vector target type"); |
| 145 | } |
| 146 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 147 | fn check_type_ref(cx: &mut Check, ty: &Ref) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 148 | if ty.lifetime.is_some() { |
| 149 | cx.error(ty, "references with explicit lifetimes are not supported"); |
| 150 | } |
| 151 | |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 152 | match ty.inner { |
| 153 | Type::Fn(_) | Type::Void(_) => {} |
| David Tolnay | 776fd89 | 2020-04-28 13:38:21 -0700 | [diff] [blame] | 154 | Type::Ref(_) => { |
| 155 | cx.error(ty, "C++ does not allow references to references"); |
| 156 | return; |
| 157 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 158 | _ => return, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 159 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 160 | |
| 161 | cx.error(ty, "unsupported reference type"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 162 | } |
| 163 | |
| David Tolnay | eebe9b7 | 2020-04-14 16:32:18 -0700 | [diff] [blame] | 164 | fn check_type_slice(cx: &mut Check, ty: &Slice) { |
| 165 | cx.error(ty, "only &[u8] is supported so far, not other slice types"); |
| 166 | } |
| 167 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 168 | fn check_api_struct(cx: &mut Check, strct: &Struct) { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 169 | check_reserved_name(cx, &strct.ident); |
| 170 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 171 | if strct.fields.is_empty() { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 172 | let span = span_for_struct_error(strct); |
| 173 | cx.error(span, "structs without any fields are not supported"); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 174 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 175 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 176 | for field in &strct.fields { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 177 | if is_unsized(cx, &field.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 178 | let desc = describe(cx, &field.ty); |
| 179 | let msg = format!("using {} by value is not supported", desc); |
| 180 | cx.error(field, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 181 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 182 | if let Type::Fn(_) = field.ty { |
| 183 | cx.error( |
| 184 | field, |
| 185 | "function pointers in a struct field are not implemented yet", |
| 186 | ); |
| 187 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 188 | } |
| 189 | } |
| 190 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 191 | fn check_api_enum(cx: &mut Check, enm: &Enum) { |
| 192 | check_reserved_name(cx, &enm.ident); |
| 193 | |
| 194 | if enm.variants.is_empty() { |
| 195 | let span = span_for_enum_error(enm); |
| 196 | cx.error(span, "enums without any variants are not supported"); |
| 197 | } |
| 198 | |
| 199 | let mut discriminants = HashSet::new(); |
| Joel Galenson | 04fa096 | 2020-05-01 10:00:31 -0700 | [diff] [blame] | 200 | enm.variants |
| 201 | .iter() |
| 202 | .fold(None, |prev_discriminant, variant| { |
| 203 | if variant.discriminant.is_none() && prev_discriminant.unwrap_or(0) == u32::MAX { |
| 204 | let msg = format!("overflowed on value after {}", prev_discriminant.unwrap()); |
| 205 | cx.error(span_for_enum_error(enm), msg); |
| 206 | return None; |
| 207 | } |
| 208 | let discriminant = variant |
| 209 | .discriminant |
| 210 | .unwrap_or_else(|| prev_discriminant.map_or(0, |n| n + 1)); |
| 211 | if !discriminants.insert(discriminant) { |
| 212 | let msg = format!("discriminant value `{}` already exists", discriminant); |
| 213 | cx.error(span_for_enum_error(enm), msg); |
| 214 | } |
| 215 | Some(discriminant) |
| 216 | }); |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 217 | } |
| 218 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 219 | fn check_api_type(cx: &mut Check, ty: &ExternType) { |
| 220 | check_reserved_name(cx, &ty.ident); |
| 221 | } |
| 222 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 223 | fn check_api_fn(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 224 | if let Some(receiver) = &efn.receiver { |
| David Tolnay | a1f29c4 | 2020-04-22 18:01:38 -0700 | [diff] [blame] | 225 | let ref span = span_for_receiver_error(receiver); |
| 226 | |
| 227 | if receiver.ty == "Self" { |
| 228 | let mutability = match receiver.mutability { |
| 229 | Some(_) => "mut ", |
| 230 | None => "", |
| 231 | }; |
| 232 | let msg = format!( |
| 233 | "unnamed receiver type is only allowed if the surrounding \ |
| 234 | extern block contains exactly one extern type; \ |
| 235 | use `self: &{mutability}TheType`", |
| 236 | mutability = mutability, |
| 237 | ); |
| 238 | cx.error(span, msg); |
| 239 | } else if !cx.types.structs.contains_key(&receiver.ty) |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 240 | && !cx.types.cxx.contains(&receiver.ty) |
| 241 | && !cx.types.rust.contains(&receiver.ty) |
| 242 | { |
| David Tolnay | 8b60bf1 | 2020-04-22 16:52:19 -0700 | [diff] [blame] | 243 | cx.error(span, "unrecognized receiver type"); |
| 244 | } |
| 245 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 246 | if receiver.lifetime.is_some() { |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 247 | cx.error(span, "references with explicit lifetimes are not supported"); |
| 248 | } |
| 249 | } |
| 250 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 251 | for arg in &efn.args { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 252 | if is_unsized(cx, &arg.ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 253 | let desc = describe(cx, &arg.ty); |
| 254 | let msg = format!("passing {} by value is not supported", desc); |
| 255 | cx.error(arg, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 256 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 257 | if let Type::Fn(_) = arg.ty { |
| David Tolnay | 75dca2e | 2020-03-25 20:17:52 -0700 | [diff] [blame] | 258 | if efn.lang == Lang::Rust { |
| 259 | cx.error( |
| 260 | arg, |
| 261 | "passing a function pointer from C++ to Rust is not implemented yet", |
| 262 | ); |
| 263 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 264 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 265 | } |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 266 | |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 267 | if let Some(ty) = &efn.ret { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 268 | if is_unsized(cx, ty) { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 269 | let desc = describe(cx, ty); |
| 270 | let msg = format!("returning {} by value is not supported", desc); |
| 271 | cx.error(ty, msg); |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 272 | } |
| David Tolnay | d7e1f1e | 2020-03-18 21:06:37 -0700 | [diff] [blame] | 273 | if let Type::Fn(_) = ty { |
| 274 | cx.error(ty, "returning a function pointer is not implemented yet"); |
| 275 | } |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 276 | } |
| David Tolnay | 96a826b | 2020-05-04 00:17:12 -0700 | [diff] [blame] | 277 | |
| 278 | if efn.lang == Lang::Cxx { |
| 279 | check_mut_return_restriction(cx, efn); |
| 280 | } |
| 281 | |
| 282 | check_multiple_arg_lifetimes(cx, efn); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 283 | } |
| 284 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 285 | fn check_mut_return_restriction(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 286 | match &efn.ret { |
| 287 | Some(Type::Ref(ty)) if ty.mutability.is_some() => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 288 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 289 | } |
| 290 | |
| 291 | for arg in &efn.args { |
| 292 | if let Type::Ref(ty) = &arg.ty { |
| 293 | if ty.mutability.is_some() { |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 294 | return; |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 295 | } |
| 296 | } |
| 297 | } |
| 298 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 299 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 300 | efn, |
| 301 | "&mut return type is not allowed unless there is a &mut argument", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 302 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 303 | } |
| 304 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 305 | fn check_multiple_arg_lifetimes(cx: &mut Check, efn: &ExternFn) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 306 | match &efn.ret { |
| 307 | Some(Type::Ref(_)) => {} |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 308 | _ => return, |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 309 | } |
| 310 | |
| 311 | let mut reference_args = 0; |
| 312 | for arg in &efn.args { |
| 313 | if let Type::Ref(_) = &arg.ty { |
| 314 | reference_args += 1; |
| 315 | } |
| 316 | } |
| 317 | |
| Joel Galenson | 3d4f612 | 2020-04-07 15:54:05 -0700 | [diff] [blame] | 318 | if efn.receiver.is_some() { |
| 319 | reference_args += 1; |
| 320 | } |
| 321 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 322 | if reference_args != 1 { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 323 | cx.error( |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 324 | efn, |
| 325 | "functions that return a reference must take exactly one input reference", |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 326 | ); |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 327 | } |
| 328 | } |
| 329 | |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 330 | fn check_reserved_name(cx: &mut Check, ident: &Ident) { |
| David Tolnay | 99c93d8 | 2020-04-25 14:07:44 -0700 | [diff] [blame] | 331 | if ident == "Box" |
| 332 | || ident == "UniquePtr" |
| 333 | || ident == "Vec" |
| 334 | || ident == "CxxVector" |
| 335 | || Atom::from(ident).is_some() |
| 336 | { |
| David Tolnay | 0b368ae | 2020-04-22 17:55:02 -0700 | [diff] [blame] | 337 | cx.error(ident, "reserved name"); |
| 338 | } |
| 339 | } |
| 340 | |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 341 | fn is_unsized(cx: &mut Check, ty: &Type) -> bool { |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 342 | let ident = match ty { |
| 343 | Type::Ident(ident) => ident, |
| David Tolnay | e70303c | 2020-04-25 15:02:37 -0700 | [diff] [blame] | 344 | Type::CxxVector(_) | Type::Slice(_) | Type::Void(_) => return true, |
| David Tolnay | d4e6830 | 2020-03-25 12:04:17 -0700 | [diff] [blame] | 345 | _ => return false, |
| 346 | }; |
| David Tolnay | 26a2a1d | 2020-03-25 17:26:43 -0700 | [diff] [blame] | 347 | ident == CxxString || cx.types.cxx.contains(ident) || cx.types.rust.contains(ident) |
| 348 | } |
| 349 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 350 | fn span_for_struct_error(strct: &Struct) -> TokenStream { |
| 351 | let struct_token = strct.struct_token; |
| 352 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 353 | brace_token.set_span(strct.brace_token.span); |
| 354 | quote!(#struct_token #brace_token) |
| 355 | } |
| 356 | |
| Joel Galenson | c03402a | 2020-04-23 17:31:09 -0700 | [diff] [blame] | 357 | fn span_for_enum_error(enm: &Enum) -> TokenStream { |
| 358 | let enum_token = enm.enum_token; |
| 359 | let mut brace_token = Group::new(Delimiter::Brace, TokenStream::new()); |
| 360 | brace_token.set_span(enm.brace_token.span); |
| 361 | quote!(#enum_token #brace_token) |
| 362 | } |
| 363 | |
| David Tolnay | d763f4c | 2020-04-22 16:09:19 -0700 | [diff] [blame] | 364 | fn span_for_receiver_error(receiver: &Receiver) -> TokenStream { |
| 365 | let ampersand = receiver.ampersand; |
| 366 | let lifetime = &receiver.lifetime; |
| 367 | let mutability = receiver.mutability; |
| 368 | if receiver.shorthand { |
| 369 | let var = receiver.var; |
| 370 | quote!(#ampersand #lifetime #mutability #var) |
| 371 | } else { |
| 372 | let ty = &receiver.ty; |
| 373 | quote!(#ampersand #lifetime #mutability #ty) |
| 374 | } |
| 375 | } |
| 376 | |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 377 | fn describe(cx: &mut Check, ty: &Type) -> String { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 378 | match ty { |
| 379 | Type::Ident(ident) => { |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 380 | if cx.types.structs.contains_key(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 381 | "struct".to_owned() |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 382 | } else if cx.types.cxx.contains(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 383 | "C++ type".to_owned() |
| David Tolnay | a420f01 | 2020-03-25 17:55:56 -0700 | [diff] [blame] | 384 | } else if cx.types.rust.contains(ident) { |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 385 | "opaque Rust type".to_owned() |
| 386 | } else if Atom::from(ident) == Some(CxxString) { |
| 387 | "C++ string".to_owned() |
| 388 | } else { |
| 389 | ident.to_string() |
| 390 | } |
| 391 | } |
| 392 | Type::RustBox(_) => "Box".to_owned(), |
| Myron Ahn | eba35cf | 2020-02-05 19:41:51 +0700 | [diff] [blame] | 393 | Type::RustVec(_) => "Vec".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 394 | Type::UniquePtr(_) => "unique_ptr".to_owned(), |
| 395 | Type::Ref(_) => "reference".to_owned(), |
| 396 | Type::Str(_) => "&str".to_owned(), |
| David Tolnay | fa85fce | 2020-04-25 15:03:25 -0700 | [diff] [blame] | 397 | Type::CxxVector(_) => "C++ vector".to_owned(), |
| Adrian Taylor | f5dd552 | 2020-04-13 16:50:14 -0700 | [diff] [blame] | 398 | Type::Slice(_) => "slice".to_owned(), |
| 399 | Type::SliceRefU8(_) => "&[u8]".to_owned(), |
| David Tolnay | 417305a | 2020-03-18 13:54:00 -0700 | [diff] [blame] | 400 | Type::Fn(_) => "function pointer".to_owned(), |
| David Tolnay | 2fb14e9 | 2020-03-15 23:11:38 -0700 | [diff] [blame] | 401 | Type::Void(_) => "()".to_owned(), |
| David Tolnay | 7db7369 | 2019-10-20 14:51:12 -0400 | [diff] [blame] | 402 | } |
| 403 | } |