blob: 2ba4b45a9fda9bcb7a94663275328021638a874c [file] [log] [blame]
mtklein7fbfbbe2016-07-21 12:25:45 -07001# Copyright 2016 Google Inc.
2#
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
John Rosasco24cbdab2019-09-25 14:14:35 -07006if (is_fuchsia) {
Robert Phillipsc919f972019-11-18 11:01:05 -05007 import("//build/fuchsia/sdk.gni")
John Rosasco24cbdab2019-09-25 14:14:35 -07008}
9
mtklein7fbfbbe2016-07-21 12:25:45 -070010declare_args() {
Kevin Lubick2677a9a2017-03-28 15:45:41 -040011 extra_asmflags = []
Mike Klein121563e2016-10-04 17:09:13 -040012 extra_cflags = []
13 extra_cflags_c = []
14 extra_cflags_cc = []
15 extra_ldflags = []
mtkleincab0bb72016-08-26 13:43:19 -070016
Herb Derby76073c12016-12-08 19:00:40 -050017 malloc = ""
Mike Klein29cb9f92020-06-19 16:25:12 -050018 werror = false
Herb Derbyc65eb342019-10-18 14:29:09 -040019 xcode_sysroot = ""
mtklein7fbfbbe2016-07-21 12:25:45 -070020}
Mike Klein82364ba2016-10-24 16:49:15 -040021
Herb Derbyc65eb342019-10-18 14:29:09 -040022if (is_ios && xcode_sysroot == "") {
Matthew Leibowitz3150ec62017-03-14 16:22:32 -040023 if (is_tvos) {
24 sdk = "appletvos"
25 if (target_cpu == "x86" || target_cpu == "x64") {
26 sdk = "appletvsimulator"
27 }
28 } else {
29 sdk = "iphoneos"
30 if (target_cpu == "x86" || target_cpu == "x64") {
31 sdk = "iphonesimulator"
32 }
Mike Klein7a5e0f32017-03-13 09:25:33 -070033 }
Herb Derbyc65eb342019-10-18 14:29:09 -040034 xcode_sysroot = exec_script("find_xcode_sysroot.py", [ sdk ], "trim string")
35}
36
37# If building for mac on a mac then lookup all the system includes so that goma and the clang
38# shipped with chrome can find them. When the gn_to_bp.py tool is run, then the host_os != mac.
39# In this case leave the xcode_sysroot empty, and the cc/c++ that come with XCode will be able to
40# find needed include paths.
41if (is_mac && host_os == "mac" && xcode_sysroot == "") {
42 xcode_sysroot =
43 exec_script("find_xcode_sysroot.py", [ "macosx" ], "trim string")
Mike Klein7d302882016-11-03 14:06:31 -040044}
45
mtkleinb9be9792016-09-16 14:44:18 -070046config("default") {
47 asmflags = []
48 cflags = []
49 cflags_c = []
50 cflags_cc = []
51 defines = []
52 ldflags = []
Herb Derby76073c12016-12-08 19:00:40 -050053 libs = []
mtkleinb9be9792016-09-16 14:44:18 -070054
Mike Kleinba201ae2019-04-23 07:38:07 -050055 if (werror) {
56 if (is_win) {
57 cflags += [ "/WX" ]
58 } else {
59 cflags += [ "-Werror" ]
60 }
61 }
62
Mike Klein28abea52020-02-19 09:17:51 -060063 # Disable warnings about unknown attributes.
64 # (These unknown attribute warnings are on by default, so we don't make
65 # disabling them part of :warnings, as some targets remove :warnings.)
66 if (is_win && !is_clang) {
67 cflags += [ "/wd5030" ]
68 } else {
69 cflags += [ "-Wno-attributes" ]
70 }
71
John Rosasco24cbdab2019-09-25 14:14:35 -070072 if (is_fuchsia && using_fuchsia_sdk) {
Robert Phillipsc919f972019-11-18 11:01:05 -050073 ldflags += [
74 "-v",
75 "--sysroot=" + rebase_path("$fuchsia_sdk_path/arch/$target_cpu/sysroot"),
76 ]
77 cflags += [ "--sysroot=" +
78 rebase_path("$fuchsia_sdk_path/arch/$target_cpu/sysroot") ]
John Rosasco24cbdab2019-09-25 14:14:35 -070079 if (target_cpu == "x64") {
80 target_triple = "--target=x86_64-${target_os}"
81 } else if (target_cpu == "arm64") {
82 target_triple = "--target=aarch64-unknown-${target_os}"
83 } else {
84 print("Unknown target CPU for Fuchsia target build.")
85 assert(false)
86 }
87 ldflags += [ target_triple ]
88 cflags += [ target_triple ]
89 asmflags += [ target_triple ]
90 }
91
mtkleinb9be9792016-09-16 14:44:18 -070092 if (is_win) {
Mike Kleinda8a6e12019-04-17 08:18:10 -050093 if (is_clang && target_cpu == "arm64") {
94 cflags += [ "--target=arm64-windows" ]
95 }
mtkleinb9be9792016-09-16 14:44:18 -070096 cflags += [
herbb6318bf2016-09-16 13:29:57 -070097 "/bigobj", # Some of our files are bigger than the regular limits.
Ben Wagnere6b274e2017-01-03 17:09:59 -050098 "/utf-8", # Set Source and Executable character sets to UTF-8.
herbb6318bf2016-09-16 13:29:57 -070099 ]
Brian Salomon8283fa42019-11-07 10:42:41 -0500100 cflags_cc += [ "/std:c++17" ]
mtkleinb9be9792016-09-16 14:44:18 -0700101 defines += [
Mike Kleinc7165c22016-10-12 23:58:06 -0400102 "_CRT_SECURE_NO_WARNINGS", # Disables warnings about sscanf().
103 "_HAS_EXCEPTIONS=0", # Disables exceptions in MSVC STL.
mtkleinb9be9792016-09-16 14:44:18 -0700104 "WIN32_LEAN_AND_MEAN",
105 "NOMINMAX",
herbb6318bf2016-09-16 13:29:57 -0700106 ]
Mike Klein98adfa82017-07-31 15:46:47 -0400107
Hal Canaryf72728e2019-07-10 11:24:52 -0400108 _include_dirs = [
109 "$win_vc/Tools/MSVC/$win_toolchain_version/include",
Brian Osman5f872622017-12-06 15:21:44 -0500110 "$win_sdk/Include/$win_sdk_version/shared",
111 "$win_sdk/Include/$win_sdk_version/ucrt",
112 "$win_sdk/Include/$win_sdk_version/um",
113 "$win_sdk/Include/$win_sdk_version/winrt",
114 ]
115
Mike Klein98adfa82017-07-31 15:46:47 -0400116 if (is_clang) {
117 foreach(dir, _include_dirs) {
118 cflags += [
119 "-imsvc",
120 dir,
121 ]
122 }
123 } else {
124 include_dirs = _include_dirs
125 }
126
Brian Osman5f872622017-12-06 15:21:44 -0500127 lib_dirs = [
128 "$win_sdk/Lib/$win_sdk_version/ucrt/$target_cpu",
129 "$win_sdk/Lib/$win_sdk_version/um/$target_cpu",
Hal Canaryf72728e2019-07-10 11:24:52 -0400130 "$win_vc/Tools/MSVC/$win_toolchain_version/lib/$target_cpu",
Brian Osman5f872622017-12-06 15:21:44 -0500131 ]
mtkleinb9be9792016-09-16 14:44:18 -0700132 } else {
Shachar Langbeheim07c4e1d2019-12-16 10:46:52 +0200133 cflags += [
134 "-fstrict-aliasing",
135 "-fPIC",
Mike Kleined800352020-08-04 12:06:23 -0500136 "-fvisibility=hidden",
Shachar Langbeheim07c4e1d2019-12-16 10:46:52 +0200137 ]
Mike Kleined800352020-08-04 12:06:23 -0500138 cflags_cc += [
139 "-std=c++17",
140 "-fvisibility-inlines-hidden",
141 ]
mtkleinb9be9792016-09-16 14:44:18 -0700142 }
herbb6318bf2016-09-16 13:29:57 -0700143
mtkleinb9be9792016-09-16 14:44:18 -0700144 if (current_cpu == "arm") {
145 cflags += [
146 "-march=armv7-a",
147 "-mfpu=neon",
148 "-mthumb",
149 ]
Mike Klein4d4b3aa2018-03-21 13:07:35 -0400150 } else if (current_cpu == "x86" && !is_win) {
mtkleinb9be9792016-09-16 14:44:18 -0700151 asmflags += [ "-m32" ]
152 cflags += [
153 "-m32",
154 "-msse2",
155 "-mfpmath=sse",
156 ]
157 ldflags += [ "-m32" ]
158 }
herbb6318bf2016-09-16 13:29:57 -0700159
Herb Derby76073c12016-12-08 19:00:40 -0500160 if (malloc != "" && !is_win) {
161 cflags += [
162 "-fno-builtin-malloc",
163 "-fno-builtin-calloc",
164 "-fno-builtin-realloc",
165 "-fno-builtin-free",
166 ]
167 libs += [ malloc ]
168 }
169
Hal Canarya0834042018-06-01 20:22:25 +0000170 if (is_android) {
Mike Kleina957ac92020-11-12 08:33:07 -0600171 cflags += [ "--sysroot=$ndk/toolchains/llvm/prebuilt/$ndk_host/sysroot" ]
Mike Klein5b52c522019-07-03 10:44:21 -0500172 ldflags += [ "-static-libstdc++" ]
mtklein2b3c2a32016-09-08 08:39:34 -0700173 }
mtklein7fbfbbe2016-07-21 12:25:45 -0700174
Mike Klein7d302882016-11-03 14:06:31 -0400175 if (is_ios) {
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500176 if (target_cpu == "arm") {
Mike Kleina1397882020-08-25 10:03:03 -0500177 _arch_flags = [
178 "-arch",
179 "armv7",
180 ]
181 } else if (target_cpu == "arm64") {
182 _arch_flags = [
183 "-arch",
184 "arm64",
185 "-arch",
186 "arm64e",
187 ]
Mike Klein7a5e0f32017-03-13 09:25:33 -0700188 } else if (target_cpu == "x86") {
Mike Kleina1397882020-08-25 10:03:03 -0500189 _arch_flags = [
190 "-arch",
191 "i386",
192 ]
Mike Klein7a5e0f32017-03-13 09:25:33 -0700193 } else if (target_cpu == "x64") {
Mike Kleina1397882020-08-25 10:03:03 -0500194 _arch_flags = [
195 "-arch",
196 "x86_64",
197 ]
198 } else {
199 _arch_flags = [
200 "-arch",
201 target_cpu,
202 ]
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500203 }
Mike Kleina1397882020-08-25 10:03:03 -0500204
Mike Klein4fe2b152017-02-17 15:36:01 -0500205 asmflags += [
Mike Kleina1397882020-08-25 10:03:03 -0500206 "-isysroot",
207 xcode_sysroot,
208 ] + _arch_flags
Mike Klein7d302882016-11-03 14:06:31 -0400209 cflags += [
Mike Kleina1397882020-08-25 10:03:03 -0500210 "-isysroot",
211 xcode_sysroot,
212 ] + _arch_flags
Brian Salomon8283fa42019-11-07 10:42:41 -0500213 cflags_cc += [
214 "-stdlib=libc++",
215 "-fno-aligned-allocation",
216 ]
Mike Klein7d302882016-11-03 14:06:31 -0400217 ldflags += [
Mike Kleina1397882020-08-25 10:03:03 -0500218 "-isysroot",
219 xcode_sysroot,
220 "-stdlib=libc++",
221 ] + _arch_flags
Herb Derby76073c12016-12-08 19:00:40 -0500222 libs += [ "objc" ]
Jim Van Verth2d366272020-11-18 15:44:04 -0500223 if (ios_min_target != "") {
224 cflags += [ "-miphoneos-version-min=$ios_min_target" ]
225 asmflags += [ "-miphoneos-version-min=$ios_min_target" ]
226 ldflags += [ "-miphoneos-version-min=$ios_min_target" ]
227 }
Mike Klein7d302882016-11-03 14:06:31 -0400228 }
229
mtkleinb9be9792016-09-16 14:44:18 -0700230 if (is_linux) {
Herb Derby76073c12016-12-08 19:00:40 -0500231 libs += [ "pthread" ]
mtkleinb9be9792016-09-16 14:44:18 -0700232 }
Herb Derbyc65eb342019-10-18 14:29:09 -0400233
Mike Klein15f46c32017-12-07 12:48:57 -0500234 if (is_mac) {
Herb Derbyc65eb342019-10-18 14:29:09 -0400235 # If there was a xcode_sysroot set in args or calculated then use it, else don't set anything
236 # because the XCode cc/c++ already know all this stuff.
237 if (xcode_sysroot != "") {
238 asmflags += [
239 "-isysroot",
240 xcode_sysroot,
241 ]
242 cflags += [
243 "-isysroot",
244 xcode_sysroot,
245 ]
246 ldflags += [
247 "-isysroot",
248 xcode_sysroot,
249 ]
250 }
251
Mike Klein15f46c32017-12-07 12:48:57 -0500252 # Disable linker warnings. They're usually just annoyances like,
253 # ld: warning: text-based stub file
254 # /System/Library/Frameworks/foo.framework/foo.tbd and library file
255 # /System/Library/Frameworks/foo.framework/foo are out of sync.
256 # Falling back to library file for linking.
257 ldflags += [ "-Wl,-w" ]
Herb Derby7e581792020-10-20 12:35:51 -0400258
259 # As of 11/2020, gn is an x86 binary and defaults the host_cpu to x86_64.
260 # This allows you to build arm64 mac binaries by setting target_cpu = "arm64"
261 if (current_cpu == "arm64") {
262 asmflags += [
263 "-target",
264 "arm64-apple-macos11",
265 ]
266 cflags += [
267 "-target",
268 "arm64-apple-macos11",
269 ]
270 ldflags += [
271 "-target",
272 "arm64-apple-macos11",
273 ]
274 }
Mike Klein15f46c32017-12-07 12:48:57 -0500275 }
mtkleinb9be9792016-09-16 14:44:18 -0700276
Brian Osman50ea3c02019-02-04 10:01:53 -0500277 if (sanitize != "" && sanitize != "MSVC") {
mtkleinb9be9792016-09-16 14:44:18 -0700278 # You can either pass the sanitizers directly, e.g. "address,undefined",
279 # or pass one of the couple common aliases used by the bots.
280 sanitizers = sanitize
Kevin Lubickd0950402018-03-20 10:10:58 -0400281
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500282 if (sanitize == "ASAN") {
Ben Wagner314d7c22018-01-03 11:04:30 -0500283 # ASAN implicitly runs all UBSAN checks also.
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500284 sanitizers = "undefined,address"
Kevin Lubick4f0f9332018-01-12 14:31:48 -0500285
Mike Klein02046a72018-08-10 12:25:12 -0400286 if (is_android) {
287 # TODO(mtklein): work out UBSAN link errors
288 sanitizers = "address"
Kevin Lubick4f0f9332018-01-12 14:31:48 -0500289 }
mtkleinb9be9792016-09-16 14:44:18 -0700290 } else if (sanitize == "TSAN") {
291 sanitizers = "thread"
292 } else if (sanitize == "MSAN") {
293 sanitizers = "memory"
294 }
295
Mike Kleind26b3e22020-07-24 12:16:50 -0500296 _suppressions = rebase_path("../tools/xsan.supp")
Mike Klein475c5e92018-08-08 10:23:17 -0400297
mtkleinb9be9792016-09-16 14:44:18 -0700298 cflags += [
Mike Klein02046a72018-08-10 12:25:12 -0400299 "-fsanitize=$sanitizers",
mtkleinb9be9792016-09-16 14:44:18 -0700300 "-fno-sanitize-recover=$sanitizers",
Mike Kleind26b3e22020-07-24 12:16:50 -0500301 "-fsanitize-blacklist=$_suppressions",
mtkleinb9be9792016-09-16 14:44:18 -0700302 ]
Mike Kleincdb0e8f2019-12-18 14:25:50 -0600303
Mike Klein94c4f412018-08-09 17:24:45 -0400304 if (is_win) {
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500305 cflags += [
Mike Kleind26b3e22020-07-24 12:16:50 -0500306 "/FI$_suppressions",
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500307
308 # On Release builds, we get strange warnings about string literals.
309 "/GF-",
310 ]
311
312 assert(clang_win != "")
313 libs += [ "$clang_win/lib/clang/$clang_win_version/lib/windows/clang_rt.asan-x86_64.lib" ]
Mike Klein94c4f412018-08-09 17:24:45 -0400314 } else {
315 cflags += [
Mike Kleind26b3e22020-07-24 12:16:50 -0500316 "-include$_suppressions",
Mike Klein94c4f412018-08-09 17:24:45 -0400317 "-fno-omit-frame-pointer",
318 ]
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500319
320 ldflags += [ "-fsanitize=$sanitizers" ]
Kevin Lubick5798c9f2018-02-15 09:45:58 -0500321 }
Mike Klein94c4f412018-08-09 17:24:45 -0400322
Kevin Lubick5798c9f2018-02-15 09:45:58 -0500323 if (is_linux) {
Kevin Lubick43bd2592018-02-15 09:03:44 -0500324 cflags_cc += [ "-stdlib=libc++" ]
325 ldflags += [ "-stdlib=libc++" ]
Kevin Lubick3cda39f2018-02-01 12:09:55 -0500326 }
Mike Klein02046a72018-08-10 12:25:12 -0400327
mtkleinb9be9792016-09-16 14:44:18 -0700328 if (sanitizers == "memory") {
329 cflags += [ "-fsanitize-memory-track-origins" ]
mtkleinb9be9792016-09-16 14:44:18 -0700330 }
Brian Salomon8283fa42019-11-07 10:42:41 -0500331 if (sanitizers == "safe-stack") {
332 cflags_cc += [ "-fno-aligned-allocation" ]
333 }
mtkleinb9be9792016-09-16 14:44:18 -0700334 }
335}
336
Mike Kleinc0c05222020-01-31 11:07:51 -0600337# See skia:9731.
338config("recover_pointer_overflow") {
339 cflags = [ "-fsanitize-recover=pointer-overflow" ]
340}
341
Mike Klein6e55fef2016-10-26 11:41:47 -0400342config("no_exceptions") {
Mike Klein228276d2017-08-16 13:20:20 +0000343 # Exceptions are disabled by default on Windows. (Use /EHsc to enable them.)
Mike Klein6e55fef2016-10-26 11:41:47 -0400344 if (!is_win) {
345 cflags_cc = [ "-fno-exceptions" ]
346 }
347}
348
Mike Kleinc7165c22016-10-12 23:58:06 -0400349config("warnings") {
350 cflags = []
351 cflags_cc = []
Mike Klein43c25262016-10-20 10:17:47 -0400352 cflags_objc = []
Greg Daniel6b7e0e22017-07-12 16:21:09 -0400353 cflags_objcc = []
Mike Kleinc7165c22016-10-12 23:58:06 -0400354 if (is_win) {
355 cflags += [
356 "/W3", # Turn on lots of warnings.
357
358 # Disable a bunch of warnings:
359 "/wd4244", # conversion from 'float' to 'int', possible loss of data
360 "/wd4267", # conversion from 'size_t' to 'int', possible loss of data
Mike Kleina01c6b02020-04-01 13:47:34 -0500361 "/wd4800", # forcing value to bool 'true' or 'false' (performance
362 # warning)
Mike Kleinc7165c22016-10-12 23:58:06 -0400363
364 # Probably only triggers when /EHsc is enabled.
365 "/wd4291", # no matching operator delete found;
Mike Kleina01c6b02020-04-01 13:47:34 -0500366 # memory will not be freed if initialization throws an
367 # exception
Brian Osmaneec1e9e2019-04-10 16:22:15 -0400368
369 # These only show up in shared builds:
Mike Kleina01c6b02020-04-01 13:47:34 -0500370 "/wd4251", # class 'type' needs to have dll-interface to be used by
371 # clients of class 'type2'
372 "/wd4275", # non dll-interface class 'base' used as base for
373 # dll-interface class 'derived'
Brian Salomon8283fa42019-11-07 10:42:41 -0500374
375 # It'd be nice to fix these and turn this on:
Mike Kleina01c6b02020-04-01 13:47:34 -0500376 "/wd5041", # out-of-line definition for constexpr static data member is
377 # not needed and is deprecated in C++17
Mike Kleindc976a92020-04-30 06:45:25 -0500378
379 # warning C4996: 'std::result_of_t': warning STL4014: std::result_of and std::result_of_t are
380 # deprecated in C++17. They are superseded by std::invoke_result and std::invoke_result_t.
381 "/wd4996",
Mike Kleinc7165c22016-10-12 23:58:06 -0400382 ]
383 } else {
384 cflags += [
385 "-Wall",
386 "-Wextra",
387 "-Winit-self",
388 "-Wpointer-arith",
389 "-Wsign-compare",
390 "-Wvla",
391
392 "-Wno-deprecated-declarations",
Mike Kleindb402ca2016-12-13 12:46:05 -0500393 "-Wno-maybe-uninitialized",
Mike Klein90b027a2020-09-02 09:09:11 -0500394 "-Wno-psabi",
Mike Kleinc7165c22016-10-12 23:58:06 -0400395 ]
Ben Wagnerf8a131d2018-03-13 16:56:43 -0400396 cflags_cc += [
397 "-Wnon-virtual-dtor",
398 "-Wno-noexcept-type",
Ben Wagner7363af82020-03-27 14:29:38 -0400399 "-Wno-redundant-move", #TODO: gcc conflict with return-std-move-in-c++11
Ben Wagnerf8a131d2018-03-13 16:56:43 -0400400 ]
Chris Dalton1ef80942017-12-04 12:01:30 -0700401 }
Mike Kleinc7165c22016-10-12 23:58:06 -0400402
Chris Dalton1ef80942017-12-04 12:01:30 -0700403 if (is_clang) {
404 cflags += [
Mike Kleinb7b2da82019-02-28 08:47:44 -0600405 "-fcolor-diagnostics",
Chris Dalton1ef80942017-12-04 12:01:30 -0700406 "-Weverything",
Mike Kleina01c6b02020-04-01 13:47:34 -0500407 "-Wno-unknown-warning-option", # Let older Clangs ignore newer Clangs'
408 # warnings.
Chris Dalton1ef80942017-12-04 12:01:30 -0700409 ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400410
Chris Dalton1ef80942017-12-04 12:01:30 -0700411 if (target_cpu == "arm" && is_ios) {
412 # Clang seems to think new/malloc will only be 4-byte aligned on 32-bit iOS.
413 # We're pretty sure it's actually 8-byte alignment.
414 cflags += [ "-Wno-over-aligned" ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400415 }
Mike Klein04282792018-01-08 18:23:32 -0500416 if (target_cpu == "x86" && is_android) {
417 # Clang seems to think new/malloc will only be 4-byte aligned on 32-bit x86 Android builds.
418 # We're pretty sure it's actually 8-byte alignment. See OverAlignedTest.cpp for more info.
419 cflags += [ "-Wno-over-aligned" ]
420 }
Chris Dalton1ef80942017-12-04 12:01:30 -0700421
422 # Shouldn't be necessary for local builds. With distributed Windows builds, files may lose
423 # their case during copy, causing case-sensitivity mismatch on remote machines.
424 cflags += [
425 "-Wno-nonportable-include-path",
426 "-Wno-nonportable-system-include-path",
427 ]
428
429 # TODO: These would all be really great warnings to turn on.
430 cflags += [
431 "-Wno-cast-align",
432 "-Wno-cast-qual",
Chris Dalton1ef80942017-12-04 12:01:30 -0700433 "-Wno-conversion",
434 "-Wno-disabled-macro-expansion",
435 "-Wno-documentation",
436 "-Wno-documentation-unknown-command",
437 "-Wno-double-promotion",
438 "-Wno-exit-time-destructors", # TODO: OK outside libskia
Chris Dalton1ef80942017-12-04 12:01:30 -0700439 "-Wno-float-equal",
440 "-Wno-format-nonliteral",
441 "-Wno-global-constructors", # TODO: OK outside libskia
Chris Dalton1ef80942017-12-04 12:01:30 -0700442 "-Wno-missing-prototypes",
443 "-Wno-missing-variable-declarations",
444 "-Wno-pedantic",
445 "-Wno-reserved-id-macro",
446 "-Wno-shadow",
447 "-Wno-shift-sign-overflow",
Chris Dalton1ef80942017-12-04 12:01:30 -0700448 "-Wno-signed-enum-bitfield",
449 "-Wno-switch-enum",
450 "-Wno-undef",
451 "-Wno-unreachable-code",
452 "-Wno-unreachable-code-break",
453 "-Wno-unreachable-code-return",
454 "-Wno-unused-macros",
455 "-Wno-unused-member-function",
456 "-Wno-unused-template",
457 "-Wno-zero-as-null-pointer-constant",
Herb Derbya1b7be62019-05-09 16:59:18 -0400458 "-Wno-thread-safety-negative",
Mike Kleinfdd542f2020-06-02 11:41:55 -0500459 "-Wno-non-c-typedef-for-linkage", # Dawn, not Skia per se.
Chris Dalton1ef80942017-12-04 12:01:30 -0700460 ]
461 cflags_cc += [
462 "-Wno-abstract-vbase-init",
463 "-Wno-weak-vtables",
464 ]
465
Mike Klein89c909e2020-06-01 15:50:19 -0500466 # Turn back on after -Wno-conversion.
467 # This only affects public headers... see :warnings_except_public_headers.
468 cflags += [ "-Wsign-conversion" ]
469
Chris Dalton1ef80942017-12-04 12:01:30 -0700470 # We are unlikely to want to fix these.
471 cflags += [
472 "-Wno-covered-switch-default",
473 "-Wno-deprecated",
Chris Dalton1ef80942017-12-04 12:01:30 -0700474 "-Wno-missing-noreturn",
475 "-Wno-old-style-cast",
476 "-Wno-padded",
Chris Daltond1ec4102017-12-04 13:31:21 -0700477 "-Wno-newline-eof",
Chris Dalton1ef80942017-12-04 12:01:30 -0700478 ]
479 cflags_cc += [
480 "-Wno-c++98-compat",
481 "-Wno-c++98-compat-pedantic",
482 "-Wno-undefined-func-template",
483 ]
484 cflags_objc += [
485 "-Wno-direct-ivar-access",
486 "-Wno-objc-interface-ivars",
487 ]
488 cflags_objcc += [
489 "-Wno-direct-ivar-access",
490 "-Wno-objcc-interface-ivars",
491 ]
Ben Wagner833313b2020-03-23 17:22:24 -0400492
493 # Wno-deprecated turns off the whole group, but also has its own warnings like
494 # out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated]
495 # but we would like others. Created from clang/include/clang/Basic/DiagnosticGroups.td
496 cflags += [
497 "-Wdeprecated-anon-enum-enum-conversion",
498 "-Wdeprecated-array-compare",
499 "-Wdeprecated-attributes",
500 "-Wdeprecated-comma-subscript",
501 "-Wdeprecated-copy",
Ben Wagner7345d882020-03-27 11:28:03 -0400502
John Stiles3744b2a2020-11-04 15:23:31 +0000503 #"-Wdeprecated-copy-dtor",
Ben Wagner833313b2020-03-23 17:22:24 -0400504 #"-Wdeprecated-declarations",
505 "-Wdeprecated-dynamic-exception-spec",
506 "-Wdeprecated-enum-compare",
507 "-Wdeprecated-enum-compare-conditional",
508 "-Wdeprecated-enum-enum-conversion",
509 "-Wdeprecated-enum-float-conversion",
510 "-Wdeprecated-increment-bool",
511 "-Wdeprecated-register",
512 "-Wdeprecated-this-capture",
513 "-Wdeprecated-volatile",
514 "-Wdeprecated-writable-str",
515 ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400516 }
517}
Mike Klein50500ad2016-11-16 12:13:44 -0500518config("warnings_except_public_headers") {
Chris Dalton1ef80942017-12-04 12:01:30 -0700519 if (!is_win || is_clang) {
Mike Klein89c909e2020-06-01 15:50:19 -0500520 cflags = [
521 "-Wno-sign-conversion",
522 "-Wno-unused-parameter",
523 ]
Mike Klein50500ad2016-11-16 12:13:44 -0500524 }
525}
Mike Kleinc7165c22016-10-12 23:58:06 -0400526
Mike Klein121563e2016-10-04 17:09:13 -0400527config("extra_flags") {
Kevin Lubick2677a9a2017-03-28 15:45:41 -0400528 asmflags = extra_asmflags
Mike Klein121563e2016-10-04 17:09:13 -0400529 cflags = extra_cflags
530 cflags_c = extra_cflags_c
531 cflags_cc = extra_cflags_cc
532 ldflags = extra_ldflags
533}
534
mtkleinb9be9792016-09-16 14:44:18 -0700535config("debug_symbols") {
536 # It's annoying to wait for full debug symbols to push over
537 # to Android devices. -gline-tables-only is a lot slimmer.
538 if (is_android) {
Mike Klein1b4602b2017-08-30 10:23:01 -0400539 cflags = [
540 "-gline-tables-only",
541 "-funwind-tables", # Helps make in-process backtraces fuller.
542 ]
Mike Kleincc300a12016-10-12 16:25:27 -0400543 } else if (is_win) {
Mike Klein67a86d52017-12-15 07:34:27 -0500544 cflags = [ "/Z7" ]
Brian Osman7142ae52018-12-12 16:32:35 -0500545 if (is_clang) {
Eric Boren56bf8ce2019-02-07 13:05:06 -0500546 cflags += [ "-gcodeview-ghash" ]
Mike Kleincae020a2018-12-23 10:25:44 -0500547 ldflags = [ "/DEBUG:GHASH" ]
Brian Osman7142ae52018-12-12 16:32:35 -0500548 } else {
Mike Kleina6e0c2b2018-12-10 08:48:03 -0500549 ldflags = [ "/DEBUG:FASTLINK" ]
Brian Osman0ab56842018-09-13 15:46:02 -0400550 }
Mike Kleincc300a12016-10-12 16:25:27 -0400551 } else {
mtkleinb9be9792016-09-16 14:44:18 -0700552 cflags = [ "-g" ]
553 }
554}
555
556config("no_rtti") {
557 if (sanitize != "ASAN") { # -fsanitize=vptr requires RTTI
Mike Kleincc300a12016-10-12 16:25:27 -0400558 if (is_win) {
559 cflags_cc = [ "/GR-" ]
560 } else {
mtkleinb9be9792016-09-16 14:44:18 -0700561 cflags_cc = [ "-fno-rtti" ]
562 }
563 }
564}
565
Mike Klein7ea977b2018-09-19 13:44:43 -0400566config("optimize") {
Mike Kleincc300a12016-10-12 16:25:27 -0400567 if (is_win) {
Mike Klein916ca1d2016-10-20 13:34:18 -0400568 cflags = [
569 "/O2",
570 "/Zc:inline",
571 ]
Mike Klein90a381f2016-10-20 13:52:38 -0400572 ldflags = [
573 "/OPT:ICF",
574 "/OPT:REF",
575 ]
Mike Kleincc300a12016-10-12 16:25:27 -0400576 } else {
Mike Klein13daa4f2019-06-20 10:08:55 -0500577 cflags = [ "-O3" ]
Mike Kleinbd9be4d2017-02-10 07:59:39 -0500578 if (is_mac || is_ios) {
579 ldflags = [ "-dead_strip" ]
580 } else {
Mike Klein13daa4f2019-06-20 10:08:55 -0500581 cflags += [
582 "-fdata-sections",
583 "-ffunction-sections",
584 ]
Mike Kleinbd9be4d2017-02-10 07:59:39 -0500585 ldflags = [ "-Wl,--gc-sections" ]
586 }
Kevin Lubickebf648e2017-09-21 13:45:16 -0400587 if (target_cpu == "wasm") {
588 # The compiler asks us to add an optimization flag to both cflags
589 # and ldflags to cut down on the local variables,
590 # for performance reasons.
591 # The "linking" step is the conversion to javascript.
592 ldflags += [ "-O3" ]
593 }
herbb6318bf2016-09-16 13:29:57 -0700594 }
Mike Klein7ea977b2018-09-19 13:44:43 -0400595}
596
597config("NDEBUG") {
mtkleinb9be9792016-09-16 14:44:18 -0700598 defines = [ "NDEBUG" ]
mtklein7fbfbbe2016-07-21 12:25:45 -0700599}
600
601config("executable") {
Mike Kleinc5875fb2016-12-06 10:46:02 -0500602 if (is_android) {
Mike Klein1b4602b2017-08-30 10:23:01 -0400603 ldflags = [
604 "-pie",
605 "-rdynamic",
606 ]
Mike Kleinc5875fb2016-12-06 10:46:02 -0500607 } else if (is_mac) {
mtklein7fbfbbe2016-07-21 12:25:45 -0700608 ldflags = [ "-Wl,-rpath,@loader_path/." ]
609 } else if (is_linux) {
mtkleina846c722016-09-15 10:44:15 -0700610 ldflags = [
611 "-rdynamic",
612 "-Wl,-rpath,\$ORIGIN",
613 ]
Mike Klein4b6b5032016-11-06 11:54:19 -0500614 } else if (is_win) {
615 ldflags = [
616 "/SUBSYSTEM:CONSOLE", # Quiet "no subsystem specified; CONSOLE assumed".
Mike Kleina01c6b02020-04-01 13:47:34 -0500617 "/INCREMENTAL:NO", # Quiet warnings about failing to incrementally link
618 # by never trying to.
Mike Klein4b6b5032016-11-06 11:54:19 -0500619 ]
mtklein7fbfbbe2016-07-21 12:25:45 -0700620 }
621}