mtklein | 7fbfbbe | 2016-07-21 12:25:45 -0700 | [diff] [blame] | 1 | # Copyright 2016 Google Inc. |
| 2 | # |
| 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | declare_args() { |
Kevin Lubick | 2677a9a | 2017-03-28 15:45:41 -0400 | [diff] [blame] | 7 | extra_asmflags = [] |
Mike Klein | 121563e | 2016-10-04 17:09:13 -0400 | [diff] [blame] | 8 | extra_cflags = [] |
| 9 | extra_cflags_c = [] |
| 10 | extra_cflags_cc = [] |
| 11 | extra_ldflags = [] |
mtklein | cab0bb7 | 2016-08-26 13:43:19 -0700 | [diff] [blame] | 12 | |
Herb Derby | 76073c1 | 2016-12-08 19:00:40 -0500 | [diff] [blame] | 13 | malloc = "" |
mtklein | 7fbfbbe | 2016-07-21 12:25:45 -0700 | [diff] [blame] | 14 | } |
Mike Klein | 82364ba | 2016-10-24 16:49:15 -0400 | [diff] [blame] | 15 | |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 16 | if (is_ios) { |
Matthew Leibowitz | 3150ec6 | 2017-03-14 16:22:32 -0400 | [diff] [blame] | 17 | if (is_tvos) { |
| 18 | sdk = "appletvos" |
| 19 | if (target_cpu == "x86" || target_cpu == "x64") { |
| 20 | sdk = "appletvsimulator" |
| 21 | } |
| 22 | } else { |
| 23 | sdk = "iphoneos" |
| 24 | if (target_cpu == "x86" || target_cpu == "x64") { |
| 25 | sdk = "iphonesimulator" |
| 26 | } |
Mike Klein | 7a5e0f3 | 2017-03-13 09:25:33 -0700 | [diff] [blame] | 27 | } |
| 28 | ios_sysroot = exec_script("find_ios_sysroot.py", [ sdk ], "trim string") |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 29 | } |
| 30 | |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 31 | config("default") { |
| 32 | asmflags = [] |
| 33 | cflags = [] |
| 34 | cflags_c = [] |
| 35 | cflags_cc = [] |
| 36 | defines = [] |
| 37 | ldflags = [] |
Herb Derby | 76073c1 | 2016-12-08 19:00:40 -0500 | [diff] [blame] | 38 | libs = [] |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 39 | |
| 40 | if (is_win) { |
| 41 | cflags += [ |
| 42 | "/FS", # Preserve previous PDB behavior. |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 43 | "/bigobj", # Some of our files are bigger than the regular limits. |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 44 | "/WX", # Treat warnings as errors. |
Ben Wagner | e6b274e | 2017-01-03 17:09:59 -0500 | [diff] [blame] | 45 | "/utf-8", # Set Source and Executable character sets to UTF-8. |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 46 | ] |
Mike Klein | a91ec58 | 2017-07-31 16:35:17 -0400 | [diff] [blame] | 47 | if (is_clang) { |
| 48 | cflags += [ "-fms-compatibility-version=19" ] # 2015 |
| 49 | } |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 50 | defines += [ |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 51 | "_CRT_SECURE_NO_WARNINGS", # Disables warnings about sscanf(). |
| 52 | "_HAS_EXCEPTIONS=0", # Disables exceptions in MSVC STL. |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 53 | "WIN32_LEAN_AND_MEAN", |
| 54 | "NOMINMAX", |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 55 | ] |
Mike Klein | 98adfa8 | 2017-07-31 15:46:47 -0400 | [diff] [blame] | 56 | |
Brian Osman | d34c4a3 | 2017-12-06 13:26:38 -0500 | [diff] [blame] | 57 | if (msvc == 2015) { |
Ravi Mistry | f5ab269 | 2017-12-06 21:51:23 +0000 | [diff] [blame^] | 58 | _include_dirs = [ |
| 59 | "$windk/VC/include", |
Brian Osman | 6da1d32 | 2017-12-06 15:21:44 -0500 | [diff] [blame] | 60 | |
Ravi Mistry | f5ab269 | 2017-12-06 21:51:23 +0000 | [diff] [blame^] | 61 | # For local builds. |
| 62 | "$windk/../Windows Kits/8.1/Include/shared", |
| 63 | "$windk/../Windows Kits/10/Include/10.0.10150.0/ucrt", |
| 64 | "$windk/../Windows Kits/8.1/Include/um", |
| 65 | "$windk/../Windows Kits/8.1/Include/winrt", |
| 66 | |
| 67 | # For builds using win_toolchain asset (currently 2015). |
| 68 | "$windk/win_sdk/Include/10.0.14393.0/shared", |
| 69 | "$windk/win_sdk/Include/10.0.14393.0/ucrt", |
| 70 | "$windk/win_sdk/Include/10.0.14393.0/um", |
| 71 | "$windk/win_sdk/Include/10.0.14393.0/winrt", |
| 72 | ] |
| 73 | } else { |
| 74 | # 2017 |
| 75 | _include_dirs = [ |
| 76 | "$windk/VC/Tools/MSVC/$win_toolchain_version/include", |
| 77 | |
| 78 | # For local builds. |
| 79 | "$windk/../../../Windows Kits/10/Include/10.0.14393.0/shared", |
| 80 | "$windk/../../../Windows Kits/10/Include/10.0.14393.0/ucrt", |
| 81 | "$windk/../../../Windows Kits/10/Include/10.0.14393.0/um", |
| 82 | "$windk/../../../Windows Kits/10/Include/10.0.14393.0/winrt", |
| 83 | ] |
| 84 | } |
Mike Klein | 98adfa8 | 2017-07-31 15:46:47 -0400 | [diff] [blame] | 85 | if (is_clang) { |
| 86 | foreach(dir, _include_dirs) { |
| 87 | cflags += [ |
| 88 | "-imsvc", |
| 89 | dir, |
| 90 | ] |
| 91 | } |
| 92 | } else { |
| 93 | include_dirs = _include_dirs |
| 94 | } |
| 95 | |
Brian Osman | d34c4a3 | 2017-12-06 13:26:38 -0500 | [diff] [blame] | 96 | if (msvc == 2015) { |
Ravi Mistry | f5ab269 | 2017-12-06 21:51:23 +0000 | [diff] [blame^] | 97 | lib_dirs = [ |
| 98 | # For local builds. |
| 99 | "$windk/../Windows Kits/10/Lib/10.0.10150.0/ucrt/$target_cpu", |
| 100 | "$windk/../Windows Kits/8.1/Lib/winv6.3/um/$target_cpu", |
| 101 | |
| 102 | # For builds using win_toolchain asset (currently 2015). |
| 103 | "$windk/win_sdk/Lib/10.0.14393.0/ucrt/$target_cpu", |
| 104 | "$windk/win_sdk/Lib/10.0.14393.0/um/$target_cpu", |
| 105 | ] |
| 106 | |
Brian Osman | d34c4a3 | 2017-12-06 13:26:38 -0500 | [diff] [blame] | 107 | if (target_cpu == "x86") { |
| 108 | lib_dirs += [ "$windk/VC/lib" ] |
| 109 | } else { |
| 110 | lib_dirs += [ "$windk/VC/lib/amd64" ] |
| 111 | } |
Ravi Mistry | f5ab269 | 2017-12-06 21:51:23 +0000 | [diff] [blame^] | 112 | } else { |
| 113 | # 2017 |
| 114 | lib_dirs = [ |
| 115 | "$windk/VC/Tools/MSVC/$win_toolchain_version/lib/$target_cpu", |
| 116 | |
| 117 | # For local builds. |
| 118 | "$windk/../../../Windows Kits/10/Lib/10.0.14393.0/ucrt/$target_cpu", |
| 119 | "$windk/../../../Windows Kits/10/Lib/10.0.14393.0/um/$target_cpu", |
| 120 | ] |
Mike Klein | 0bc5a76 | 2016-10-12 22:42:55 -0400 | [diff] [blame] | 121 | } |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 122 | } else { |
| 123 | cflags += [ |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 124 | "-fstrict-aliasing", |
| 125 | "-fPIC", |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 126 | "-Werror", |
mtklein | 2b3c2a3 | 2016-09-08 08:39:34 -0700 | [diff] [blame] | 127 | ] |
Mike Klein | 28f5b77 | 2017-04-06 23:04:42 -0400 | [diff] [blame] | 128 | cflags_cc += [ "-std=c++11" ] |
Mike Klein | eec23d1 | 2017-03-26 20:11:48 -0400 | [diff] [blame] | 129 | |
| 130 | # The main idea is to slim the exported API, but these flags also improve link time on Mac. |
| 131 | # These would make stack traces worse on Linux, so we don't just set them willy-nilly. |
Mike Klein | 8cb6648 | 2017-03-28 14:16:22 -0400 | [diff] [blame] | 132 | if (is_component_build || is_ios || is_mac) { |
Mike Klein | eec23d1 | 2017-03-26 20:11:48 -0400 | [diff] [blame] | 133 | cflags += [ "-fvisibility=hidden" ] |
| 134 | cflags_cc += [ "-fvisibility-inlines-hidden" ] |
| 135 | } |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 136 | } |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 137 | |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 138 | if (current_cpu == "arm") { |
| 139 | cflags += [ |
| 140 | "-march=armv7-a", |
| 141 | "-mfpu=neon", |
| 142 | "-mthumb", |
| 143 | ] |
Mike Klein | 5d8cf29 | 2016-10-12 19:36:09 -0400 | [diff] [blame] | 144 | } else if (current_cpu == "x86" && !is_win) { |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 145 | asmflags += [ "-m32" ] |
| 146 | cflags += [ |
| 147 | "-m32", |
| 148 | "-msse2", |
| 149 | "-mfpmath=sse", |
| 150 | ] |
| 151 | ldflags += [ "-m32" ] |
| 152 | } |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 153 | |
Herb Derby | 76073c1 | 2016-12-08 19:00:40 -0500 | [diff] [blame] | 154 | if (malloc != "" && !is_win) { |
| 155 | cflags += [ |
| 156 | "-fno-builtin-malloc", |
| 157 | "-fno-builtin-calloc", |
| 158 | "-fno-builtin-realloc", |
| 159 | "-fno-builtin-free", |
| 160 | ] |
| 161 | libs += [ malloc ] |
| 162 | } |
| 163 | |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 164 | if (is_android) { |
Derek Sollenberger | 19b2a56 | 2017-06-27 11:55:05 -0400 | [diff] [blame] | 165 | asmflags += [ "--target=$ndk_target" ] |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 166 | cflags += [ |
Derek Sollenberger | 19b2a56 | 2017-06-27 11:55:05 -0400 | [diff] [blame] | 167 | "--sysroot=$ndk/sysroot", |
| 168 | "-isystem$ndk/sysroot/usr/include/$ndk_target", |
| 169 | "-D__ANDROID_API__=$ndk_api", |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 170 | "--target=$ndk_target", |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 171 | ] |
| 172 | cflags_cc += [ |
| 173 | "-isystem$ndk/sources/android/support/include", |
Mike Klein | b7ce80b | 2016-12-14 13:17:53 -0500 | [diff] [blame] | 174 | "-isystem$ndk/sources/cxx-stl/gnu-libstdc++/4.9/include", |
| 175 | "-isystem$ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/$ndk_stdlib/include", |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 176 | ] |
| 177 | ldflags += [ |
| 178 | "--sysroot=$ndk/platforms/$ndk_platform", |
| 179 | "--target=$ndk_target", |
| 180 | "-B$ndk/toolchains/$ndk_gccdir-4.9/prebuilt/$ndk_host/$ndk_target/bin", |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 181 | ] |
| 182 | lib_dirs = [ |
Mike Klein | b7ce80b | 2016-12-14 13:17:53 -0500 | [diff] [blame] | 183 | "$ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/$ndk_stdlib", |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 184 | "$ndk/toolchains/$ndk_gccdir-4.9/prebuilt/$ndk_host/lib/gcc/$ndk_target/4.9.x", |
| 185 | ] |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 186 | |
Mike Klein | b7ce80b | 2016-12-14 13:17:53 -0500 | [diff] [blame] | 187 | libs += [ "gnustl_static" ] |
mtklein | 2b3c2a3 | 2016-09-08 08:39:34 -0700 | [diff] [blame] | 188 | } |
mtklein | 7fbfbbe | 2016-07-21 12:25:45 -0700 | [diff] [blame] | 189 | |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 190 | if (is_ios) { |
Mike Klein | b48fd3c | 2017-01-23 11:58:53 -0500 | [diff] [blame] | 191 | _target = target_cpu |
| 192 | if (target_cpu == "arm") { |
| 193 | _target = "armv7" |
Mike Klein | 7a5e0f3 | 2017-03-13 09:25:33 -0700 | [diff] [blame] | 194 | } else if (target_cpu == "x86") { |
| 195 | _target = "i386" |
| 196 | } else if (target_cpu == "x64") { |
| 197 | _target = "x86_64" |
Mike Klein | b48fd3c | 2017-01-23 11:58:53 -0500 | [diff] [blame] | 198 | } |
Mike Klein | 4fe2b15 | 2017-02-17 15:36:01 -0500 | [diff] [blame] | 199 | asmflags += [ |
| 200 | "-isysroot", |
| 201 | ios_sysroot, |
| 202 | "-arch", |
| 203 | _target, |
| 204 | ] |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 205 | cflags += [ |
Mike Klein | 6749af4 | 2016-11-07 15:38:48 -0500 | [diff] [blame] | 206 | "-isysroot", |
| 207 | ios_sysroot, |
| 208 | "-arch", |
Mike Klein | b48fd3c | 2017-01-23 11:58:53 -0500 | [diff] [blame] | 209 | _target, |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 210 | ] |
| 211 | cflags_cc += [ "-stdlib=libc++" ] |
| 212 | ldflags += [ |
Mike Klein | 6749af4 | 2016-11-07 15:38:48 -0500 | [diff] [blame] | 213 | "-isysroot", |
| 214 | ios_sysroot, |
| 215 | "-arch", |
Mike Klein | b48fd3c | 2017-01-23 11:58:53 -0500 | [diff] [blame] | 216 | _target, |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 217 | "-stdlib=libc++", |
| 218 | ] |
Herb Derby | 76073c1 | 2016-12-08 19:00:40 -0500 | [diff] [blame] | 219 | libs += [ "objc" ] |
Mike Klein | 7d30288 | 2016-11-03 14:06:31 -0400 | [diff] [blame] | 220 | } |
| 221 | |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 222 | if (is_linux) { |
Herb Derby | 76073c1 | 2016-12-08 19:00:40 -0500 | [diff] [blame] | 223 | libs += [ "pthread" ] |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 224 | } |
| 225 | |
| 226 | if (sanitize != "") { |
| 227 | # You can either pass the sanitizers directly, e.g. "address,undefined", |
| 228 | # or pass one of the couple common aliases used by the bots. |
| 229 | sanitizers = sanitize |
| 230 | if (sanitize == "ASAN") { |
Ben Wagner | bee6cac | 2017-12-04 11:15:58 -0500 | [diff] [blame] | 231 | sanitizers = "address,bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr" |
Mike Klein | e4781e9 | 2017-09-28 11:42:28 -0400 | [diff] [blame] | 232 | if (!is_mac) { |
Mike Klein | 46d6c68 | 2017-10-05 11:22:09 -0400 | [diff] [blame] | 233 | sanitizers += ",function" # Not supported on Mac. |
| 234 | } |
| 235 | if (!is_debug) { |
| 236 | sanitizers += ",object-size" # No-op with somewhat annoying warning at -O0. |
Mike Klein | e4781e9 | 2017-09-28 11:42:28 -0400 | [diff] [blame] | 237 | } |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 238 | } else if (sanitize == "TSAN") { |
| 239 | sanitizers = "thread" |
| 240 | } else if (sanitize == "MSAN") { |
| 241 | sanitizers = "memory" |
| 242 | } |
| 243 | |
| 244 | cflags += [ |
| 245 | "-fsanitize=$sanitizers", |
| 246 | "-fno-sanitize-recover=$sanitizers", |
| 247 | "-fsanitize-blacklist=" + rebase_path("../tools/xsan.blacklist"), |
| 248 | ] |
| 249 | ldflags += [ "-fsanitize=$sanitizers" ] |
| 250 | if (sanitizers == "memory") { |
| 251 | cflags += [ "-fsanitize-memory-track-origins" ] |
| 252 | cflags_cc += [ "-stdlib=libc++" ] |
| 253 | ldflags += [ "-stdlib=libc++" ] |
| 254 | } |
| 255 | } |
| 256 | } |
| 257 | |
Mike Klein | 6e55fef | 2016-10-26 11:41:47 -0400 | [diff] [blame] | 258 | config("no_exceptions") { |
Mike Klein | 228276d | 2017-08-16 13:20:20 +0000 | [diff] [blame] | 259 | # Exceptions are disabled by default on Windows. (Use /EHsc to enable them.) |
Mike Klein | 6e55fef | 2016-10-26 11:41:47 -0400 | [diff] [blame] | 260 | if (!is_win) { |
| 261 | cflags_cc = [ "-fno-exceptions" ] |
| 262 | } |
| 263 | } |
| 264 | |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 265 | config("warnings") { |
| 266 | cflags = [] |
| 267 | cflags_cc = [] |
Mike Klein | 43c2526 | 2016-10-20 10:17:47 -0400 | [diff] [blame] | 268 | cflags_objc = [] |
Greg Daniel | 6b7e0e2 | 2017-07-12 16:21:09 -0400 | [diff] [blame] | 269 | cflags_objcc = [] |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 270 | if (is_win) { |
| 271 | cflags += [ |
| 272 | "/W3", # Turn on lots of warnings. |
| 273 | |
| 274 | # Disable a bunch of warnings: |
| 275 | "/wd4244", # conversion from 'float' to 'int', possible loss of data |
| 276 | "/wd4267", # conversion from 'size_t' to 'int', possible loss of data |
| 277 | "/wd4800", # forcing value to bool 'true' or 'false' (performance warning) |
| 278 | |
| 279 | # Probably only triggers when /EHsc is enabled. |
| 280 | "/wd4291", # no matching operator delete found; |
| 281 | # memory will not be freed if initialization throws an exception |
| 282 | ] |
| 283 | } else { |
| 284 | cflags += [ |
| 285 | "-Wall", |
| 286 | "-Wextra", |
| 287 | "-Winit-self", |
| 288 | "-Wpointer-arith", |
| 289 | "-Wsign-compare", |
| 290 | "-Wvla", |
| 291 | |
| 292 | "-Wno-deprecated-declarations", |
Mike Klein | db402ca | 2016-12-13 12:46:05 -0500 | [diff] [blame] | 293 | "-Wno-maybe-uninitialized", |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 294 | ] |
| 295 | cflags_cc += [ "-Wnon-virtual-dtor" ] |
Chris Dalton | 1ef8094 | 2017-12-04 12:01:30 -0700 | [diff] [blame] | 296 | } |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 297 | |
Chris Dalton | 1ef8094 | 2017-12-04 12:01:30 -0700 | [diff] [blame] | 298 | if (is_clang) { |
| 299 | cflags += [ |
| 300 | "-Weverything", |
| 301 | "-Wno-unknown-warning-option", # Let older Clangs ignore newer Clangs' warnings. |
| 302 | ] |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 303 | |
Chris Dalton | 1ef8094 | 2017-12-04 12:01:30 -0700 | [diff] [blame] | 304 | if (target_cpu == "arm" && is_ios) { |
| 305 | # Clang seems to think new/malloc will only be 4-byte aligned on 32-bit iOS. |
| 306 | # We're pretty sure it's actually 8-byte alignment. |
| 307 | cflags += [ "-Wno-over-aligned" ] |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 308 | } |
Chris Dalton | 1ef8094 | 2017-12-04 12:01:30 -0700 | [diff] [blame] | 309 | |
| 310 | # Shouldn't be necessary for local builds. With distributed Windows builds, files may lose |
| 311 | # their case during copy, causing case-sensitivity mismatch on remote machines. |
| 312 | cflags += [ |
| 313 | "-Wno-nonportable-include-path", |
| 314 | "-Wno-nonportable-system-include-path", |
| 315 | ] |
| 316 | |
| 317 | # TODO: These would all be really great warnings to turn on. |
| 318 | cflags += [ |
| 319 | "-Wno-cast-align", |
| 320 | "-Wno-cast-qual", |
| 321 | "-Wno-conditional-uninitialized", |
| 322 | "-Wno-conversion", |
| 323 | "-Wno-disabled-macro-expansion", |
| 324 | "-Wno-documentation", |
| 325 | "-Wno-documentation-unknown-command", |
| 326 | "-Wno-double-promotion", |
| 327 | "-Wno-exit-time-destructors", # TODO: OK outside libskia |
| 328 | "-Wno-float-conversion", |
| 329 | "-Wno-float-equal", |
| 330 | "-Wno-format-nonliteral", |
| 331 | "-Wno-global-constructors", # TODO: OK outside libskia |
| 332 | "-Wno-gnu-zero-variadic-macro-arguments", |
| 333 | "-Wno-missing-prototypes", |
| 334 | "-Wno-missing-variable-declarations", |
| 335 | "-Wno-pedantic", |
| 336 | "-Wno-reserved-id-macro", |
| 337 | "-Wno-shadow", |
| 338 | "-Wno-shift-sign-overflow", |
| 339 | "-Wno-sign-conversion", |
| 340 | "-Wno-signed-enum-bitfield", |
| 341 | "-Wno-switch-enum", |
| 342 | "-Wno-undef", |
| 343 | "-Wno-unreachable-code", |
| 344 | "-Wno-unreachable-code-break", |
| 345 | "-Wno-unreachable-code-return", |
| 346 | "-Wno-unused-macros", |
| 347 | "-Wno-unused-member-function", |
| 348 | "-Wno-unused-template", |
| 349 | "-Wno-zero-as-null-pointer-constant", |
| 350 | ] |
| 351 | cflags_cc += [ |
| 352 | "-Wno-abstract-vbase-init", |
| 353 | "-Wno-weak-vtables", |
| 354 | ] |
| 355 | |
| 356 | # We are unlikely to want to fix these. |
| 357 | cflags += [ |
| 358 | "-Wno-covered-switch-default", |
| 359 | "-Wno-deprecated", |
| 360 | "-Wno-implicit-fallthrough", |
| 361 | "-Wno-missing-noreturn", |
| 362 | "-Wno-old-style-cast", |
| 363 | "-Wno-padded", |
Chris Dalton | d1ec410 | 2017-12-04 13:31:21 -0700 | [diff] [blame] | 364 | "-Wno-newline-eof", |
Chris Dalton | 1ef8094 | 2017-12-04 12:01:30 -0700 | [diff] [blame] | 365 | ] |
| 366 | cflags_cc += [ |
| 367 | "-Wno-c++98-compat", |
| 368 | "-Wno-c++98-compat-pedantic", |
| 369 | "-Wno-undefined-func-template", |
| 370 | ] |
| 371 | cflags_objc += [ |
| 372 | "-Wno-direct-ivar-access", |
| 373 | "-Wno-objc-interface-ivars", |
| 374 | ] |
| 375 | cflags_objcc += [ |
| 376 | "-Wno-direct-ivar-access", |
| 377 | "-Wno-objcc-interface-ivars", |
| 378 | ] |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 379 | } |
| 380 | } |
Mike Klein | 50500ad | 2016-11-16 12:13:44 -0500 | [diff] [blame] | 381 | config("warnings_except_public_headers") { |
Chris Dalton | 1ef8094 | 2017-12-04 12:01:30 -0700 | [diff] [blame] | 382 | if (!is_win || is_clang) { |
Mike Klein | 50500ad | 2016-11-16 12:13:44 -0500 | [diff] [blame] | 383 | cflags = [ "-Wno-unused-parameter" ] |
| 384 | } |
| 385 | } |
Mike Klein | c7165c2 | 2016-10-12 23:58:06 -0400 | [diff] [blame] | 386 | |
Mike Klein | 121563e | 2016-10-04 17:09:13 -0400 | [diff] [blame] | 387 | config("extra_flags") { |
Kevin Lubick | 2677a9a | 2017-03-28 15:45:41 -0400 | [diff] [blame] | 388 | asmflags = extra_asmflags |
Mike Klein | 121563e | 2016-10-04 17:09:13 -0400 | [diff] [blame] | 389 | cflags = extra_cflags |
| 390 | cflags_c = extra_cflags_c |
| 391 | cflags_cc = extra_cflags_cc |
| 392 | ldflags = extra_ldflags |
| 393 | } |
| 394 | |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 395 | config("debug_symbols") { |
| 396 | # It's annoying to wait for full debug symbols to push over |
| 397 | # to Android devices. -gline-tables-only is a lot slimmer. |
| 398 | if (is_android) { |
Mike Klein | 1b4602b | 2017-08-30 10:23:01 -0400 | [diff] [blame] | 399 | cflags = [ |
| 400 | "-gline-tables-only", |
| 401 | "-funwind-tables", # Helps make in-process backtraces fuller. |
| 402 | ] |
Mike Klein | cc300a1 | 2016-10-12 16:25:27 -0400 | [diff] [blame] | 403 | } else if (is_win) { |
| 404 | cflags = [ "/Zi" ] |
Mike Klein | 5286d6c | 2016-10-13 13:19:25 -0400 | [diff] [blame] | 405 | ldflags = [ "/DEBUG" ] |
Mike Klein | cc300a1 | 2016-10-12 16:25:27 -0400 | [diff] [blame] | 406 | } else { |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 407 | cflags = [ "-g" ] |
| 408 | } |
| 409 | } |
| 410 | |
| 411 | config("no_rtti") { |
| 412 | if (sanitize != "ASAN") { # -fsanitize=vptr requires RTTI |
Mike Klein | cc300a1 | 2016-10-12 16:25:27 -0400 | [diff] [blame] | 413 | if (is_win) { |
| 414 | cflags_cc = [ "/GR-" ] |
| 415 | } else { |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 416 | cflags_cc = [ "-fno-rtti" ] |
| 417 | } |
| 418 | } |
| 419 | } |
| 420 | |
| 421 | config("release") { |
Mike Klein | cc300a1 | 2016-10-12 16:25:27 -0400 | [diff] [blame] | 422 | if (is_win) { |
Mike Klein | 916ca1d | 2016-10-20 13:34:18 -0400 | [diff] [blame] | 423 | cflags = [ |
| 424 | "/O2", |
| 425 | "/Zc:inline", |
Mike Klein | 8ffb260 | 2016-10-20 15:45:02 -0400 | [diff] [blame] | 426 | "/GS-", |
Mike Klein | 916ca1d | 2016-10-20 13:34:18 -0400 | [diff] [blame] | 427 | ] |
Mike Klein | 90a381f | 2016-10-20 13:52:38 -0400 | [diff] [blame] | 428 | ldflags = [ |
| 429 | "/OPT:ICF", |
| 430 | "/OPT:REF", |
| 431 | ] |
Mike Klein | cc300a1 | 2016-10-12 16:25:27 -0400 | [diff] [blame] | 432 | } else { |
Mike Klein | 0bcfeac | 2016-10-19 22:24:10 -0400 | [diff] [blame] | 433 | cflags = [ |
| 434 | "-O3", |
Mike Klein | bd9be4d | 2017-02-10 07:59:39 -0500 | [diff] [blame] | 435 | "-fdata-sections", |
| 436 | "-ffunction-sections", |
Mike Klein | 0bcfeac | 2016-10-19 22:24:10 -0400 | [diff] [blame] | 437 | ] |
Mike Klein | bd9be4d | 2017-02-10 07:59:39 -0500 | [diff] [blame] | 438 | if (is_mac || is_ios) { |
| 439 | ldflags = [ "-dead_strip" ] |
| 440 | } else { |
| 441 | ldflags = [ "-Wl,--gc-sections" ] |
| 442 | } |
Kevin Lubick | ebf648e | 2017-09-21 13:45:16 -0400 | [diff] [blame] | 443 | if (target_cpu == "wasm") { |
| 444 | # The compiler asks us to add an optimization flag to both cflags |
| 445 | # and ldflags to cut down on the local variables, |
| 446 | # for performance reasons. |
| 447 | # The "linking" step is the conversion to javascript. |
| 448 | ldflags += [ "-O3" ] |
| 449 | } |
herb | b6318bf | 2016-09-16 13:29:57 -0700 | [diff] [blame] | 450 | } |
mtklein | b9be979 | 2016-09-16 14:44:18 -0700 | [diff] [blame] | 451 | defines = [ "NDEBUG" ] |
mtklein | 7fbfbbe | 2016-07-21 12:25:45 -0700 | [diff] [blame] | 452 | } |
| 453 | |
| 454 | config("executable") { |
Mike Klein | c5875fb | 2016-12-06 10:46:02 -0500 | [diff] [blame] | 455 | if (is_android) { |
Mike Klein | 1b4602b | 2017-08-30 10:23:01 -0400 | [diff] [blame] | 456 | ldflags = [ |
| 457 | "-pie", |
| 458 | "-rdynamic", |
| 459 | ] |
Mike Klein | c5875fb | 2016-12-06 10:46:02 -0500 | [diff] [blame] | 460 | } else if (is_mac) { |
mtklein | 7fbfbbe | 2016-07-21 12:25:45 -0700 | [diff] [blame] | 461 | ldflags = [ "-Wl,-rpath,@loader_path/." ] |
| 462 | } else if (is_linux) { |
mtklein | a846c72 | 2016-09-15 10:44:15 -0700 | [diff] [blame] | 463 | ldflags = [ |
| 464 | "-rdynamic", |
| 465 | "-Wl,-rpath,\$ORIGIN", |
| 466 | ] |
Mike Klein | 4b6b503 | 2016-11-06 11:54:19 -0500 | [diff] [blame] | 467 | } else if (is_win) { |
| 468 | ldflags = [ |
| 469 | "/SUBSYSTEM:CONSOLE", # Quiet "no subsystem specified; CONSOLE assumed". |
| 470 | "/INCREMENTAL:NO", # Quiet warnings about failing to incrementally link by never trying to. |
| 471 | ] |
mtklein | 7fbfbbe | 2016-07-21 12:25:45 -0700 | [diff] [blame] | 472 | } |
| 473 | } |