blob: 248a2f6301cdd2e7d6c009a7e8f743a29851856e [file] [log] [blame]
Fyodor Kupolov74876572015-02-23 17:14:45 -08001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License
15 */
16
17package com.android.server.pm;
18
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080019import android.annotation.Nullable;
Fyodor Kupolova627c092015-05-05 18:44:39 -070020import android.content.Context;
Fyodor Kupolov74876572015-02-23 17:14:45 -080021import android.content.pm.ApplicationInfo;
22import android.content.pm.PackageParser;
Nicolas Geoffray972b39e2018-11-15 12:59:52 +000023import android.content.pm.SharedLibraryInfo;
Calin Juravle6ae39fc2018-01-19 20:32:47 -080024import android.content.pm.dex.ArtManager;
Calin Juravlecc651942018-02-01 17:20:51 +000025import android.content.pm.dex.DexMetadataHelper;
Calin Juravleadbadd52017-03-28 18:19:15 -070026import android.os.FileUtils;
Fyodor Kupolova627c092015-05-05 18:44:39 -070027import android.os.PowerManager;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070028import android.os.SystemClock;
Nicolas Geoffray20a894e2017-09-08 13:01:40 +010029import android.os.SystemProperties;
Fyodor Kupolov74876572015-02-23 17:14:45 -080030import android.os.UserHandle;
Fyodor Kupolova627c092015-05-05 18:44:39 -070031import android.os.WorkSource;
Fyodor Kupolov74876572015-02-23 17:14:45 -080032import android.util.Log;
33import android.util.Slog;
34
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080035import com.android.internal.annotations.GuardedBy;
Narayan Kamath88eea9e2016-05-02 14:44:31 +010036import com.android.internal.util.IndentingPrintWriter;
Jeff Sharkey740f5232016-12-09 14:31:26 -070037import com.android.server.pm.Installer.InstallerException;
Calin Juravle0610dd12018-07-20 15:51:17 -070038import com.android.server.pm.dex.ArtManagerService;
Victor Hsieh785d6182018-04-19 14:26:28 -070039import com.android.server.pm.dex.DexManager;
Calin Juravle1d0e83d2017-07-17 15:12:01 -070040import com.android.server.pm.dex.DexoptOptions;
Calin Juravle19da1cf2017-07-12 18:52:49 -070041import com.android.server.pm.dex.DexoptUtils;
Calin Juravlef1ff36f2017-07-22 12:33:41 -070042import com.android.server.pm.dex.PackageDexUsage;
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -070043
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080044import java.io.File;
Fyodor Kupolov74876572015-02-23 17:14:45 -080045import java.io.IOException;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080046import java.util.ArrayList;
Calin Juravle4c2b9552017-08-10 17:23:00 -070047import java.util.Arrays;
Fyodor Kupolov74876572015-02-23 17:14:45 -080048import java.util.List;
Calin Juravle41a57a62017-08-06 19:20:19 -070049import java.util.Map;
Fyodor Kupolov74876572015-02-23 17:14:45 -080050
51import dalvik.system.DexFile;
Fyodor Kupolov74876572015-02-23 17:14:45 -080052
David Brazdildf1c7dc2018-10-26 16:23:59 +010053import static android.content.pm.ApplicationInfo.HIDDEN_API_ENFORCEMENT_DISABLED;
Mathew Inwoode3299532018-02-22 13:19:53 +000054
Todd Kennedyfa54ab72015-09-25 07:46:12 -070055import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE;
56import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE;
Andreas Gampebdd30d82016-03-20 11:32:11 -070057import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED;
Todd Kennedyfa54ab72015-09-25 07:46:12 -070058import static com.android.server.pm.Installer.DEXOPT_PUBLIC;
Calin Juravlec22c30e2017-01-16 19:18:48 -080059import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX;
60import static com.android.server.pm.Installer.DEXOPT_FORCE;
61import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE;
62import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE;
David Sehr2118ec42017-10-25 14:28:29 -070063import static com.android.server.pm.Installer.DEXOPT_IDLE_BACKGROUND_JOB;
David Brazdilf7e31c02018-02-13 17:04:26 +000064import static com.android.server.pm.Installer.DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartierfa3e9762018-03-06 18:28:22 -080065import static com.android.server.pm.Installer.DEXOPT_GENERATE_COMPACT_DEX;
Mathieu Chartiera9c34332018-03-12 17:11:07 -070066import static com.android.server.pm.Installer.DEXOPT_GENERATE_APP_IMAGE;
Fyodor Kupolov74876572015-02-23 17:14:45 -080067import static com.android.server.pm.InstructionSets.getAppDexInstructionSets;
68import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080069
Fyodor Kupolov28f28552017-05-02 12:11:02 -070070import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT;
Nicolas Geoffrayb0818e82017-05-05 10:23:19 +010071
Calin Juravle4bc8f4d2018-02-12 12:00:44 -080072import static com.android.server.pm.PackageManagerServiceCompilerMapping.getReasonName;
73
Nicolas Geoffrayd093b202017-05-03 13:11:58 +010074import static dalvik.system.DexFile.getSafeModeCompilerFilter;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -080075import static dalvik.system.DexFile.isProfileGuidedCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -080076
77/**
78 * Helper class for running dexopt command on packages.
79 */
Calin Juravlec22c30e2017-01-16 19:18:48 -080080public class PackageDexOptimizer {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -080081 private static final String TAG = "PackageManager.DexOptimizer";
82 static final String OAT_DIR_NAME = "oat";
83 // TODO b/19550105 Remove error codes and use exceptions
Calin Juravlec22c30e2017-01-16 19:18:48 -080084 public static final int DEX_OPT_SKIPPED = 0;
85 public static final int DEX_OPT_PERFORMED = 1;
86 public static final int DEX_OPT_FAILED = -1;
Fyodor Kupolov28f28552017-05-02 12:11:02 -070087 // One minute over PM WATCHDOG_TIMEOUT
88 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60;
Fyodor Kupolov74876572015-02-23 17:14:45 -080089
Fyodor Kupolov28f28552017-05-02 12:11:02 -070090 @GuardedBy("mInstallLock")
Andreas Gampea8908752015-11-10 08:58:14 -080091 private final Installer mInstaller;
92 private final Object mInstallLock;
Fyodor Kupolov74876572015-02-23 17:14:45 -080093
Fyodor Kupolov28f28552017-05-02 12:11:02 -070094 @GuardedBy("mInstallLock")
Fyodor Kupolova627c092015-05-05 18:44:39 -070095 private final PowerManager.WakeLock mDexoptWakeLock;
96 private volatile boolean mSystemReady;
97
Andreas Gampea8908752015-11-10 08:58:14 -080098 PackageDexOptimizer(Installer installer, Object installLock, Context context,
99 String wakeLockTag) {
100 this.mInstaller = installer;
101 this.mInstallLock = installLock;
102
103 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE);
104 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag);
105 }
106
107 protected PackageDexOptimizer(PackageDexOptimizer from) {
108 this.mInstaller = from.mInstaller;
109 this.mInstallLock = from.mInstallLock;
110 this.mDexoptWakeLock = from.mDexoptWakeLock;
111 this.mSystemReady = from.mSystemReady;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800112 }
113
Calin Juravledb4a79a2015-12-23 18:55:08 +0200114 static boolean canOptimizePackage(PackageParser.Package pkg) {
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100115 // We do not dexopt a package with no code.
116 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) {
117 return false;
118 }
119
Nicolas Geoffray20a894e2017-09-08 13:01:40 +0100120 return true;
Calin Juravledb4a79a2015-12-23 18:55:08 +0200121 }
122
Fyodor Kupolov74876572015-02-23 17:14:45 -0800123 /**
124 * Performs dexopt on all code paths and libraries of the specified package for specified
125 * instruction sets.
126 *
Andreas Gampea8908752015-11-10 08:58:14 -0800127 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are
128 * synchronized on {@link #mInstallLock}.
Fyodor Kupolov74876572015-02-23 17:14:45 -0800129 */
Nicolas Geoffraya7f44ba2019-02-26 21:40:59 +0000130 int performDexOpt(PackageParser.Package pkg,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700131 String[] instructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700132 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800133 if (pkg.applicationInfo.uid == -1) {
134 throw new IllegalArgumentException("Dexopt for " + pkg.packageName
135 + " has invalid uid.");
136 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800137 if (!canOptimizePackage(pkg)) {
138 return DEX_OPT_SKIPPED;
139 }
Andreas Gampea8908752015-11-10 08:58:14 -0800140 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700141 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700142 try {
Nicolas Geoffraya7f44ba2019-02-26 21:40:59 +0000143 return performDexOptLI(pkg, instructionSets,
Calin Juravle3b74c412017-08-03 19:48:37 -0700144 packageStats, packageUseInfo, options);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700145 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700146 releaseWakeLockLI(acquireTime);
Fyodor Kupolova627c092015-05-05 18:44:39 -0700147 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800148 }
149 }
150
Andreas Gampea8908752015-11-10 08:58:14 -0800151 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800152 * Performs dexopt on all code paths of the given package.
153 * It assumes the install lock is held.
154 */
155 @GuardedBy("mInstallLock")
Nicolas Geoffray972b39e2018-11-15 12:59:52 +0000156 private int performDexOptLI(PackageParser.Package pkg,
Calin Juravle1d0e83d2017-07-17 15:12:01 -0700157 String[] targetInstructionSets, CompilerStats.PackageStats packageStats,
Calin Juravle3b74c412017-08-03 19:48:37 -0700158 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) {
Nicolas Geoffraya7f44ba2019-02-26 21:40:59 +0000159 final List<SharedLibraryInfo> sharedLibraries = pkg.usesLibraryInfos;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800160 final String[] instructionSets = targetInstructionSets != null ?
161 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo);
162 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
Jeff Hao5def5e52017-04-19 14:42:16 -0700163 final List<String> paths = pkg.getAllCodePaths();
Jeff Sharkeya73e1652017-11-15 19:07:14 -0700164
165 int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid);
166 if (sharedGid == -1) {
167 Slog.wtf(TAG, "Well this is awkward; package " + pkg.applicationInfo.name + " had UID "
168 + pkg.applicationInfo.uid, new Throwable());
169 sharedGid = android.os.Process.NOBODY_UID;
170 }
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800171
Calin Juravle19da1cf2017-07-12 18:52:49 -0700172 // Get the class loader context dependencies.
173 // For each code path in the package, this array contains the class loader context that
174 // needs to be passed to dexopt in order to ensure correct optimizations.
Calin Juravleda098152017-09-01 17:30:01 -0700175 boolean[] pathsWithCode = new boolean[paths.size()];
176 pathsWithCode[0] = (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) != 0;
177 for (int i = 1; i < paths.size(); i++) {
178 pathsWithCode[i] = (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) != 0;
179 }
Calin Juravle19da1cf2017-07-12 18:52:49 -0700180 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts(
Calin Juravleda098152017-09-01 17:30:01 -0700181 pkg.applicationInfo, sharedLibraries, pathsWithCode);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800182
Calin Juravle4c2b9552017-08-10 17:23:00 -0700183 // Sanity check that we do not call dexopt with inconsistent data.
184 if (paths.size() != classLoaderContexts.length) {
185 String[] splitCodePaths = pkg.applicationInfo.getSplitCodePaths();
186 throw new IllegalStateException("Inconsistent information "
187 + "between PackageParser.Package and its ApplicationInfo. "
188 + "pkg.getAllCodePaths=" + paths
189 + " pkg.applicationInfo.getBaseCodePath=" + pkg.applicationInfo.getBaseCodePath()
190 + " pkg.applicationInfo.getSplitCodePaths="
191 + (splitCodePaths == null ? "null" : Arrays.toString(splitCodePaths)));
192 }
193
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800194 int result = DEX_OPT_SKIPPED;
Jeff Hao5def5e52017-04-19 14:42:16 -0700195 for (int i = 0; i < paths.size(); i++) {
196 // Skip paths that have no code.
Calin Juravleda098152017-09-01 17:30:01 -0700197 if (!pathsWithCode[i]) {
Jeff Hao5def5e52017-04-19 14:42:16 -0700198 continue;
199 }
Calin Juravleda098152017-09-01 17:30:01 -0700200 if (classLoaderContexts[i] == null) {
201 throw new IllegalStateException("Inconsistent information in the "
202 + "package structure. A split is marked to contain code "
203 + "but has no dependency listed. Index=" + i + " path=" + paths.get(i));
204 }
205
Jeff Hao5def5e52017-04-19 14:42:16 -0700206 // Append shared libraries with split dependencies for this split.
207 String path = paths.get(i);
Calin Juravleb6f844d2017-07-17 15:23:21 -0700208 if (options.getSplitName() != null) {
209 // We are asked to compile only a specific split. Check that the current path is
210 // what we are looking for.
211 if (!options.getSplitName().equals(new File(path).getName())) {
212 continue;
213 }
214 }
215
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800216 String profileName = ArtManager.getProfileName(i == 0 ? null : pkg.splitNames[i - 1]);
217
Calin Juravlecc651942018-02-01 17:20:51 +0000218 String dexMetadataPath = null;
219 if (options.isDexoptInstallWithDexMetadata()) {
220 File dexMetadataFile = DexMetadataHelper.findDexMetadataForFile(new File(path));
221 dexMetadataPath = dexMetadataFile == null
222 ? null : dexMetadataFile.getAbsolutePath();
223 }
224
Calin Juravle3b74c412017-08-03 19:48:37 -0700225 final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary()
Calin Juravle52a452c2017-08-04 01:42:17 -0700226 || packageUseInfo.isUsedByOtherApps(path);
Calin Juravle3b74c412017-08-03 19:48:37 -0700227 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo,
228 options.getCompilerFilter(), isUsedByOtherApps);
229 final boolean profileUpdated = options.isCheckForProfileUpdates() &&
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800230 isProfileUpdated(pkg, sharedGid, profileName, compilerFilter);
Calin Juravle3b74c412017-08-03 19:48:37 -0700231
232 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct
233 // flags.
Andreas Gampec041c332017-11-01 17:05:53 -0700234 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options);
Calin Juravle3b74c412017-08-03 19:48:37 -0700235
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800236 for (String dexCodeIsa : dexCodeInstructionSets) {
Calin Juravle19da1cf2017-07-12 18:52:49 -0700237 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter,
238 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800239 packageStats, options.isDowngrade(), profileName, dexMetadataPath,
240 options.getCompilationReason());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800241 // The end result is:
242 // - FAILED if any path failed,
243 // - PERFORMED if at least one path needed compilation,
244 // - SKIPPED when all paths are up to date
245 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) {
246 result = newResult;
247 }
248 }
249 }
250 return result;
251 }
252
253 /**
254 * Performs dexopt on the {@code path} belonging to the package {@code pkg}.
255 *
256 * @return
257 * DEX_OPT_FAILED if there was any exception during dexopt
258 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
259 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed.
260 */
261 @GuardedBy("mInstallLock")
262 private int dexOptPath(PackageParser.Package pkg, String path, String isa,
Calin Juravle576e6c02017-09-12 00:58:33 -0700263 String compilerFilter, boolean profileUpdated, String classLoaderContext,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800264 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800265 String profileName, String dexMetadataPath, int compilationReason) {
Calin Juravle576e6c02017-09-12 00:58:33 -0700266 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext,
267 profileUpdated, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800268 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) {
269 return DEX_OPT_SKIPPED;
270 }
271
272 // TODO(calin): there's no need to try to create the oat dir over and over again,
273 // especially since it involve an extra installd call. We should create
274 // if (if supported) on the fly during the dexopt call.
275 String oatDir = createOatDirIfSupported(pkg, isa);
276
277 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path
278 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa
279 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
Calin Juravle576e6c02017-09-12 00:58:33 -0700280 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir
281 + " classLoaderContext=" + classLoaderContext);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800282
283 try {
284 long startTime = System.currentTimeMillis();
285
Shubham Ajmera246dccf2017-05-24 17:46:36 -0700286 // TODO: Consider adding 2 different APIs for primary and secondary dexopt.
287 // installd only uses downgrade flag for secondary dex files and ignores it for
288 // primary dex files.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800289 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags,
Calin Juravle576e6c02017-09-12 00:58:33 -0700290 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo,
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800291 false /* downgrade*/, pkg.applicationInfo.targetSdkVersion,
Calin Juravle0610dd12018-07-20 15:51:17 -0700292 profileName, dexMetadataPath,
293 getAugmentedReasonName(compilationReason, dexMetadataPath != null));
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800294
295 if (packageStats != null) {
296 long endTime = System.currentTimeMillis();
297 packageStats.setCompileTime(path, (int)(endTime - startTime));
298 }
299 return DEX_OPT_PERFORMED;
300 } catch (InstallerException e) {
301 Slog.w(TAG, "Failed to dexopt", e);
302 return DEX_OPT_FAILED;
303 }
304 }
305
Calin Juravle0610dd12018-07-20 15:51:17 -0700306 private String getAugmentedReasonName(int compilationReason, boolean useDexMetadata) {
307 String annotation = useDexMetadata
308 ? ArtManagerService.DEXOPT_REASON_WITH_DEX_METADATA_ANNOTATION : "";
309 return getReasonName(compilationReason) + annotation;
310 }
311
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800312 /**
Calin Juravlec22c30e2017-01-16 19:18:48 -0800313 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}.
314 *
315 * @return
316 * DEX_OPT_FAILED if there was any exception during dexopt
317 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path.
318 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file
319 * didn't need an update. That's because at the moment we don't get more than success/failure
320 * from installd.
321 *
322 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than
323 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though
324 * that seems wasteful.
325 */
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700326 public int dexOptSecondaryDexPath(ApplicationInfo info, String path,
327 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
Calin Juravlec6540da2017-11-15 16:28:01 -0800328 if (info.uid == -1) {
329 throw new IllegalArgumentException("Dexopt for path " + path + " has invalid uid.");
330 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800331 synchronized (mInstallLock) {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700332 final long acquireTime = acquireWakeLockLI(info.uid);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800333 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700334 return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800335 } finally {
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700336 releaseWakeLockLI(acquireTime);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800337 }
338 }
339 }
340
341 @GuardedBy("mInstallLock")
Fyodor Kupolov28f28552017-05-02 12:11:02 -0700342 private long acquireWakeLockLI(final int uid) {
343 // During boot the system doesn't need to instantiate and obtain a wake lock.
344 // PowerManager might not be ready, but that doesn't mean that we can't proceed with
345 // dexopt.
346 if (!mSystemReady) {
347 return -1;
348 }
349 mDexoptWakeLock.setWorkSource(new WorkSource(uid));
350 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS);
351 return SystemClock.elapsedRealtime();
352 }
353
354 @GuardedBy("mInstallLock")
355 private void releaseWakeLockLI(final long acquireTime) {
356 if (acquireTime < 0) {
357 return;
358 }
359 try {
360 if (mDexoptWakeLock.isHeld()) {
361 mDexoptWakeLock.release();
362 }
363 final long duration = SystemClock.elapsedRealtime() - acquireTime;
364 if (duration >= WAKELOCK_TIMEOUT_MS) {
365 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag()
366 + " time out. Operation took " + duration + " ms. Thread: "
367 + Thread.currentThread().getName());
368 }
369 } catch (Exception e) {
370 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e);
371 }
372 }
373
374 @GuardedBy("mInstallLock")
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700375 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path,
376 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) {
377 if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) {
378 // We are asked to optimize only the dex files used by other apps and this is not
379 // on of them: skip it.
380 return DEX_OPT_SKIPPED;
381 }
382
383 String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(),
384 dexUseInfo.isUsedByOtherApps());
Calin Juravleefb1c942017-04-04 20:31:44 -0700385 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags.
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100386 // Secondary dex files are currently not compiled at boot.
Andreas Gampec041c332017-11-01 17:05:53 -0700387 int dexoptFlags = getDexFlags(info, compilerFilter, options) | DEXOPT_SECONDARY_DEX;
Calin Juravlec22c30e2017-01-16 19:18:48 -0800388 // Check the app storage and add the appropriate flags.
Calin Juravleadbadd52017-03-28 18:19:15 -0700389 if (info.deviceProtectedDataDir != null &&
390 FileUtils.contains(info.deviceProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800391 dexoptFlags |= DEXOPT_STORAGE_DE;
Calin Juravleadbadd52017-03-28 18:19:15 -0700392 } else if (info.credentialProtectedDataDir != null &&
393 FileUtils.contains(info.credentialProtectedDataDir, path)) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800394 dexoptFlags |= DEXOPT_STORAGE_CE;
395 } else {
396 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName);
397 return DEX_OPT_FAILED;
398 }
Nicolas Geoffraybab4c2c2018-12-20 09:47:00 +0000399 String classLoaderContext = null;
David Brazdil22217f62018-12-18 13:43:55 +0000400 if (dexUseInfo.isUnknownClassLoaderContext() || dexUseInfo.isVariableClassLoaderContext()) {
Nicolas Geoffraybab4c2c2018-12-20 09:47:00 +0000401 // If we have an unknown (not yet set), or a variable class loader chain. Just extract
402 // the dex file.
403 compilerFilter = "extract";
David Brazdil22217f62018-12-18 13:43:55 +0000404 } else {
405 classLoaderContext = dexUseInfo.getClassLoaderContext();
406 }
407
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800408 int reason = options.getCompilationReason();
Nicolas Geoffraybab4c2c2018-12-20 09:47:00 +0000409 Log.d(TAG, "Running dexopt on: " + path
410 + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas()
411 + " reason=" + getReasonName(reason)
412 + " dexoptFlags=" + printDexoptFlags(dexoptFlags)
413 + " target-filter=" + compilerFilter
414 + " class-loader-context=" + classLoaderContext);
415
Calin Juravlec22c30e2017-01-16 19:18:48 -0800416 try {
Calin Juravlef1ff36f2017-07-22 12:33:41 -0700417 for (String isa : dexUseInfo.getLoaderIsas()) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800418 // Reuse the same dexopt path as for the primary apks. We don't need all the
419 // arguments as some (dexopNeeded and oatDir) will be computed by installd because
420 // system server cannot read untrusted app content.
421 // TODO(calin): maybe add a separate call.
422 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0,
423 /*oatDir*/ null, dexoptFlags,
Nick Kralevich005f9592018-08-14 11:11:02 -0700424 compilerFilter, info.volumeUuid, classLoaderContext, info.seInfo,
Calin Juravlecc651942018-02-01 17:20:51 +0000425 options.isDowngrade(), info.targetSdkVersion, /*profileName*/ null,
Calin Juravle4bc8f4d2018-02-12 12:00:44 -0800426 /*dexMetadataPath*/ null, getReasonName(reason));
Calin Juravlec22c30e2017-01-16 19:18:48 -0800427 }
428
429 return DEX_OPT_PERFORMED;
430 } catch (InstallerException e) {
431 Slog.w(TAG, "Failed to dexopt", e);
432 return DEX_OPT_FAILED;
433 }
434 }
435
436 /**
Andreas Gampea8908752015-11-10 08:58:14 -0800437 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to
438 * optimize or not (and in what way).
439 */
440 protected int adjustDexoptNeeded(int dexoptNeeded) {
441 return dexoptNeeded;
442 }
443
444 /**
445 * Adjust the given dexopt flags that will be passed to the installer.
446 */
447 protected int adjustDexoptFlags(int dexoptFlags) {
448 return dexoptFlags;
449 }
450
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100451 /**
452 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}.
453 */
Calin Juravle41a57a62017-08-06 19:20:19 -0700454 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg,
455 PackageDexUsage.PackageUseInfo useInfo) {
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100456 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo);
457 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets);
458
459 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly();
460
Calin Juravle41a57a62017-08-06 19:20:19 -0700461 for (String path : paths) {
462 pw.println("path: " + path);
463 pw.increaseIndent();
464
465 for (String isa : dexCodeInstructionSets) {
Calin Juravle41a57a62017-08-06 19:20:19 -0700466 try {
Calin Juravle7fc0f632018-03-30 12:38:59 -0700467 DexFile.OptimizationInfo info = DexFile.getDexFileOptimizationInfo(path, isa);
468 pw.println(isa + ": [status=" + info.getStatus()
469 +"] [reason=" + info.getReason() + "]");
Calin Juravle41a57a62017-08-06 19:20:19 -0700470 } catch (IOException ioe) {
Calin Juravleab49fc42018-03-28 19:00:18 -0700471 pw.println(isa + ": [Exception]: " + ioe.getMessage());
Calin Juravle41a57a62017-08-06 19:20:19 -0700472 }
Calin Juravle41a57a62017-08-06 19:20:19 -0700473 }
474
475 if (useInfo.isUsedByOtherApps(path)) {
Calin Juravle94837e32017-09-26 13:23:00 -0700476 pw.println("used by other apps: " + useInfo.getLoadingPackages(path));
Calin Juravle41a57a62017-08-06 19:20:19 -0700477 }
478
479 Map<String, PackageDexUsage.DexUseInfo> dexUseInfoMap = useInfo.getDexUseInfoMap();
480
481 if (!dexUseInfoMap.isEmpty()) {
482 pw.println("known secondary dex files:");
483 pw.increaseIndent();
484 for (Map.Entry<String, PackageDexUsage.DexUseInfo> e : dexUseInfoMap.entrySet()) {
485 String dex = e.getKey();
486 PackageDexUsage.DexUseInfo dexUseInfo = e.getValue();
487 pw.println(dex);
488 pw.increaseIndent();
Calin Juravlecf722222017-09-18 17:40:48 -0700489 // TODO(calin): get the status of the oat file (needs installd call)
Calin Juravle41a57a62017-08-06 19:20:19 -0700490 pw.println("class loader context: " + dexUseInfo.getClassLoaderContext());
491 if (dexUseInfo.isUsedByOtherApps()) {
Calin Juravle94837e32017-09-26 13:23:00 -0700492 pw.println("used by other apps: " + dexUseInfo.getLoadingPackages());
Calin Juravle41a57a62017-08-06 19:20:19 -0700493 }
494 pw.decreaseIndent();
495 }
496 pw.decreaseIndent();
497 }
498 pw.decreaseIndent();
Narayan Kamath88eea9e2016-05-02 14:44:31 +0100499 }
500 }
501
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800502 /**
503 * Returns the compiler filter that should be used to optimize the package code.
504 * The target filter will be updated if the package code is used by other apps
505 * or if it has the safe mode flag set.
506 */
Calin Juravlec22c30e2017-01-16 19:18:48 -0800507 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter,
508 boolean isUsedByOtherApps) {
509 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800510 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0;
Victor Hsieh785d6182018-04-19 14:26:28 -0700511 // When a priv app is configured to run out of box, only verify it.
512 if (info.isPrivilegedApp() && DexManager.isPackageSelectedToRunOob(info.packageName)) {
513 return "verify";
Nicolas Geoffray11d21a292018-01-24 14:07:14 +0000514 }
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700515 if (vmSafeMode) {
Nicolas Geoffrayd093b202017-05-03 13:11:58 +0100516 return getSafeModeCompilerFilter(targetCompilerFilter);
Mathieu Chartier41e4a372016-09-02 16:36:42 -0700517 }
518
Calin Juravlec22c30e2017-01-16 19:18:48 -0800519 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) {
Calin Juravlef53201f2017-09-15 11:09:29 -0700520 // If the dex files is used by other apps, apply the shared filter.
521 return PackageManagerServiceCompilerMapping.getCompilerFilterForReason(
522 PackageManagerService.REASON_SHARED);
Andreas Gampebdd30d82016-03-20 11:32:11 -0700523 }
524
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800525 return targetCompilerFilter;
Fyodor Kupolov74876572015-02-23 17:14:45 -0800526 }
527
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800528 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800529 * Computes the dex flags that needs to be pass to installd for the given package and compiler
530 * filter.
531 */
Nicolas Geoffray3b4359a2017-05-25 13:53:22 +0100532 private int getDexFlags(PackageParser.Package pkg, String compilerFilter,
Andreas Gampec041c332017-11-01 17:05:53 -0700533 DexoptOptions options) {
534 return getDexFlags(pkg.applicationInfo, compilerFilter, options);
Calin Juravlec22c30e2017-01-16 19:18:48 -0800535 }
536
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700537 private boolean isAppImageEnabled() {
538 return SystemProperties.get("dalvik.vm.appimageformat", "").length() > 0;
539 }
540
Andreas Gampec041c332017-11-01 17:05:53 -0700541 private int getDexFlags(ApplicationInfo info, String compilerFilter, DexoptOptions options) {
Calin Juravlec22c30e2017-01-16 19:18:48 -0800542 int flags = info.flags;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800543 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0;
Calin Juravleff3e4a12018-02-01 17:23:13 +0000544 // Profile guide compiled oat files should not be public unles they are based
545 // on profiles from dex metadata archives.
546 // The flag isDexoptInstallWithDexMetadata applies only on installs when we know that
547 // the user does not have an existing profile.
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800548 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter);
Calin Juravleff3e4a12018-02-01 17:23:13 +0000549 boolean isPublic = !info.isForwardLocked() &&
550 (!isProfileGuidedFilter || options.isDexoptInstallWithDexMetadata());
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800551 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0;
David Brazdilf7e31c02018-02-13 17:04:26 +0000552 // Some apps are executed with restrictions on hidden API usage. If this app is one
553 // of them, pass a flag to dexopt to enable the same restrictions during compilation.
Mathew Inwoode3299532018-02-22 13:19:53 +0000554 // TODO we should pass the actual flag value to dexopt, rather than assuming blacklist
David Brazdildf1c7dc2018-10-26 16:23:59 +0100555 int hiddenApiFlag = info.getHiddenApiEnforcementPolicy() == HIDDEN_API_ENFORCEMENT_DISABLED
Mathew Inwoode3299532018-02-22 13:19:53 +0000556 ? 0
557 : DEXOPT_ENABLE_HIDDEN_API_CHECKS;
Mathieu Chartiera6d43e42018-03-08 13:11:40 -0800558 // Avoid generating CompactDex for modes that are latency critical.
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800559 final int compilationReason = options.getCompilationReason();
560 boolean generateCompactDex = true;
561 switch (compilationReason) {
562 case PackageManagerService.REASON_FIRST_BOOT:
563 case PackageManagerService.REASON_BOOT:
564 case PackageManagerService.REASON_INSTALL:
565 generateCompactDex = false;
566 }
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700567 // Use app images only if it is enabled and we are compiling
568 // profile-guided (so the app image doesn't conservatively contain all classes).
569 // If the app didn't request for the splits to be loaded in isolation or if it does not
570 // declare inter-split dependencies, then all the splits will be loaded in the base
571 // apk class loader (in the order of their definition, otherwise disable app images
572 // because they are unsupported for multiple class loaders. b/7269679
573 boolean generateAppImage = isProfileGuidedFilter && (info.splitDependencies == null ||
574 !info.requestsIsolatedSplitLoading()) && isAppImageEnabled();
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800575 int dexFlags =
576 (isPublic ? DEXOPT_PUBLIC : 0)
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800577 | (debuggable ? DEXOPT_DEBUGGABLE : 0)
578 | profileFlag
Andreas Gampec041c332017-11-01 17:05:53 -0700579 | (options.isBootComplete() ? DEXOPT_BOOTCOMPLETE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000580 | (options.isDexoptIdleBackgroundJob() ? DEXOPT_IDLE_BACKGROUND_JOB : 0)
Mathieu Chartierfa3e9762018-03-06 18:28:22 -0800581 | (generateCompactDex ? DEXOPT_GENERATE_COMPACT_DEX : 0)
Mathieu Chartiera9c34332018-03-12 17:11:07 -0700582 | (generateAppImage ? DEXOPT_GENERATE_APP_IMAGE : 0)
David Brazdil464ed3d2018-01-18 15:25:18 +0000583 | hiddenApiFlag;
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800584 return adjustDexoptFlags(dexFlags);
585 }
586
587 /**
588 * Assesses if there's a need to perform dexopt on {@code path} for the given
589 * configuration (isa, compiler filter, profile).
590 */
591 private int getDexoptNeeded(String path, String isa, String compilerFilter,
Calin Juravle576e6c02017-09-12 00:58:33 -0700592 String classLoaderContext, boolean newProfile, boolean downgrade) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800593 int dexoptNeeded;
594 try {
Calin Juravle576e6c02017-09-12 00:58:33 -0700595 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext,
596 newProfile, downgrade);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800597 } catch (IOException ioe) {
598 Slog.w(TAG, "IOException reading apk: " + path, ioe);
599 return DEX_OPT_FAILED;
600 }
601 return adjustDexoptNeeded(dexoptNeeded);
602 }
603
604 /**
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800605 * Checks if there is an update on the profile information of the {@code pkg}.
606 * If the compiler filter is not profile guided the method returns false.
607 *
608 * Note that this is a "destructive" operation with side effects. Under the hood the
609 * current profile and the reference profile will be merged and subsequent calls
610 * may return a different result.
611 */
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800612 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String profileName,
613 String compilerFilter) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800614 // Check if we are allowed to merge and if the compiler filter is profile guided.
615 if (!isProfileGuidedCompilerFilter(compilerFilter)) {
616 return false;
617 }
618 // Merge profiles. It returns whether or not there was an updated in the profile info.
619 try {
Calin Juravle6ae39fc2018-01-19 20:32:47 -0800620 return mInstaller.mergeProfiles(uid, pkg.packageName, profileName);
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800621 } catch (InstallerException e) {
622 Slog.w(TAG, "Failed to merge profiles", e);
623 }
624 return false;
625 }
626
627 /**
628 * Creates oat dir for the specified package if needed and supported.
629 * In certain cases oat directory
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800630 * <strong>cannot</strong> be created:
631 * <ul>
632 * <li>{@code pkg} is a system app, which is not updated.</li>
633 * <li>Package location is not a directory, i.e. monolithic install.</li>
634 * </ul>
635 *
Richard Uhler7b08b352015-03-25 16:25:57 -0700636 * @return Absolute path to the oat directory or null, if oat directory
637 * cannot be created.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800638 */
639 @Nullable
Todd Kennedy27c24fb2015-09-17 16:49:25 -0700640 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) {
Fyodor Kupolovebcac162015-09-09 15:56:45 -0700641 if (!pkg.canHaveOatDir()) {
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800642 return null;
643 }
644 File codePath = new File(pkg.codePath);
645 if (codePath.isDirectory()) {
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800646 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for
647 // cluster packages). It seems that the logic for the folder creation is
648 // split between installd and here.
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800649 File oatDir = getOatDir(codePath);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700650 try {
Andreas Gampea8908752015-11-10 08:58:14 -0800651 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet);
Jeff Sharkeyfdeeeea2016-01-11 17:34:24 -0700652 } catch (InstallerException e) {
653 Slog.w(TAG, "Failed to create oat dir", e);
654 return null;
655 }
Richard Uhler7b08b352015-03-25 16:25:57 -0700656 return oatDir.getAbsolutePath();
Fyodor Kupolovb94c1652015-03-03 12:25:30 -0800657 }
658 return null;
659 }
660
661 static File getOatDir(File codePath) {
662 return new File(codePath, OAT_DIR_NAME);
663 }
664
Fyodor Kupolova627c092015-05-05 18:44:39 -0700665 void systemReady() {
666 mSystemReady = true;
667 }
Andreas Gampea8908752015-11-10 08:58:14 -0800668
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800669 private String printDexoptFlags(int flags) {
670 ArrayList<String> flagsList = new ArrayList<>();
671
672 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) {
673 flagsList.add("boot_complete");
674 }
675 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) {
676 flagsList.add("debuggable");
677 }
678 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) {
679 flagsList.add("profile_guided");
680 }
681 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) {
682 flagsList.add("public");
683 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800684 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) {
685 flagsList.add("secondary");
686 }
687 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) {
688 flagsList.add("force");
689 }
690 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) {
691 flagsList.add("storage_ce");
692 }
693 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) {
694 flagsList.add("storage_de");
695 }
David Sehr2118ec42017-10-25 14:28:29 -0700696 if ((flags & DEXOPT_IDLE_BACKGROUND_JOB) == DEXOPT_IDLE_BACKGROUND_JOB) {
697 flagsList.add("idle_background_job");
698 }
David Brazdilf7e31c02018-02-13 17:04:26 +0000699 if ((flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) == DEXOPT_ENABLE_HIDDEN_API_CHECKS) {
700 flagsList.add("enable_hidden_api_checks");
David Brazdil464ed3d2018-01-18 15:25:18 +0000701 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800702
Calin Juravle2d4b6ad72017-01-04 13:22:14 -0800703 return String.join(",", flagsList);
704 }
705
Andreas Gampea8908752015-11-10 08:58:14 -0800706 /**
707 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a
708 * dexopt path.
709 */
710 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer {
711
712 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock,
713 Context context, String wakeLockTag) {
714 super(installer, installLock, context, wakeLockTag);
715 }
716
717 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) {
718 super(from);
719 }
720
721 @Override
Andreas Gampea8908752015-11-10 08:58:14 -0800722 protected int adjustDexoptNeeded(int dexoptNeeded) {
Nicolas Geoffray96d12a92017-05-03 11:51:53 +0100723 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) {
724 // Ensure compilation by pretending a compiler filter change on the
725 // apk/odex location (the reason for the '-'. A positive value means
726 // the 'oat' location).
727 return -DexFile.DEX2OAT_FOR_FILTER;
728 }
729 return dexoptNeeded;
Andreas Gampea8908752015-11-10 08:58:14 -0800730 }
Calin Juravlec22c30e2017-01-16 19:18:48 -0800731
732 @Override
733 protected int adjustDexoptFlags(int flags) {
734 // Add DEXOPT_FORCE flag to signal installd that it should force compilation
735 // and discard dexoptanalyzer result.
736 return flags | DEXOPT_FORCE;
737 }
Andreas Gampea8908752015-11-10 08:58:14 -0800738 }
Fyodor Kupolov74876572015-02-23 17:14:45 -0800739}