Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2011 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include <stdlib.h> |
| 18 | #include <string.h> |
| 19 | |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 20 | #include <android-base/logging.h> |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 21 | #include <android-base/scopeguard.h> |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 22 | #include <gtest/gtest.h> |
| 23 | |
Jeff Sharkey | f3e30b9 | 2016-12-09 17:06:57 -0700 | [diff] [blame] | 24 | #include "InstalldNativeService.h" |
Jeff Sharkey | 725ae2b | 2018-09-28 10:07:14 -0600 | [diff] [blame] | 25 | #include "MatchExtensionGen.h" |
Jeff Sharkey | f3e30b9 | 2016-12-09 17:06:57 -0700 | [diff] [blame] | 26 | #include "globals.h" |
| 27 | #include "utils.h" |
Jeff Sharkey | 1980380 | 2015-04-07 12:44:51 -0700 | [diff] [blame] | 28 | |
| 29 | #undef LOG_TAG |
| 30 | #define LOG_TAG "utils_test" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 31 | |
| 32 | #define TEST_DATA_DIR "/data/" |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 33 | #define TEST_ROOT_DIR "/system/" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 34 | #define TEST_APP_DIR "/data/app/" |
| 35 | #define TEST_APP_PRIVATE_DIR "/data/app-private/" |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 36 | #define TEST_APP_EPHEMERAL_DIR "/data/app-ephemeral/" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 37 | #define TEST_ASEC_DIR "/mnt/asec/" |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 38 | #define TEST_EXPAND_DIR "/mnt/expand/00000000-0000-0000-0000-000000000000/" |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 39 | |
| 40 | #define TEST_SYSTEM_DIR1 "/system/app/" |
| 41 | #define TEST_SYSTEM_DIR2 "/vendor/app/" |
| 42 | |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 43 | #define TEST_PROFILE_DIR "/data/misc/profiles" |
| 44 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 45 | namespace android { |
Andreas Gampe | 02d0de5 | 2015-11-11 20:43:16 -0800 | [diff] [blame] | 46 | namespace installd { |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 47 | |
| 48 | class UtilsTest : public testing::Test { |
| 49 | protected: |
| 50 | virtual void SetUp() { |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 51 | setenv("ANDROID_LOG_TAGS", "*:v", 1); |
| 52 | android::base::InitLogging(nullptr); |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 53 | |
Jeff Sharkey | c1149c9 | 2017-09-21 14:51:09 -0600 | [diff] [blame] | 54 | init_globals_from_data_and_root(TEST_DATA_DIR, TEST_ROOT_DIR); |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 55 | } |
| 56 | |
| 57 | virtual void TearDown() { |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 58 | } |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 59 | |
| 60 | std::string create_too_long_path(const std::string& seed) { |
| 61 | std::string result = seed; |
| 62 | for (size_t i = seed.size(); i < PKG_PATH_MAX; i++) { |
| 63 | result += "a"; |
| 64 | } |
| 65 | return result; |
| 66 | } |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 67 | }; |
| 68 | |
| 69 | TEST_F(UtilsTest, IsValidApkPath_BadPrefix) { |
| 70 | // Bad prefixes directories |
| 71 | const char *badprefix1 = "/etc/passwd"; |
| 72 | EXPECT_EQ(-1, validate_apk_path(badprefix1)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 73 | << badprefix1 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 74 | |
| 75 | const char *badprefix2 = "../.." TEST_APP_DIR "../../../blah"; |
| 76 | EXPECT_EQ(-1, validate_apk_path(badprefix2)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 77 | << badprefix2 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 78 | |
| 79 | const char *badprefix3 = "init.rc"; |
| 80 | EXPECT_EQ(-1, validate_apk_path(badprefix3)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 81 | << badprefix3 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 82 | |
| 83 | const char *badprefix4 = "/init.rc"; |
| 84 | EXPECT_EQ(-1, validate_apk_path(badprefix4)) |
Jeff Sharkey | 871a8f2 | 2017-02-21 18:30:28 -0700 | [diff] [blame] | 85 | << badprefix4 << " should not be allowed as a valid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 86 | } |
| 87 | |
| 88 | TEST_F(UtilsTest, IsValidApkPath_Internal) { |
| 89 | // Internal directories |
| 90 | const char *internal1 = TEST_APP_DIR "example.apk"; |
| 91 | EXPECT_EQ(0, validate_apk_path(internal1)) |
| 92 | << internal1 << " should be allowed as a valid path"; |
| 93 | |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 94 | // b/16888084 |
| 95 | const char *path2 = TEST_APP_DIR "example.com/example.apk"; |
| 96 | EXPECT_EQ(0, validate_apk_path(path2)) |
| 97 | << path2 << " should be allowed as a valid path"; |
| 98 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 99 | const char *badint1 = TEST_APP_DIR "../example.apk"; |
| 100 | EXPECT_EQ(-1, validate_apk_path(badint1)) |
| 101 | << badint1 << " should be rejected as a invalid path"; |
| 102 | |
| 103 | const char *badint2 = TEST_APP_DIR "/../example.apk"; |
| 104 | EXPECT_EQ(-1, validate_apk_path(badint2)) |
| 105 | << badint2 << " should be rejected as a invalid path"; |
| 106 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 107 | // Should not have more than two sub directories |
| 108 | const char *bad_path3 = TEST_APP_DIR "random/example.com/subdir/pkg.apk"; |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 109 | EXPECT_EQ(-1, validate_apk_path(bad_path3)) |
| 110 | << bad_path3 << " should be rejected as a invalid path"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 111 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 112 | const char *bad_path4 = TEST_APP_DIR "random/example.com/subdir/pkg.apk"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 113 | EXPECT_EQ(-1, validate_apk_path(bad_path4)) |
| 114 | << bad_path4 << " should be rejected as a invalid path"; |
| 115 | |
| 116 | const char *bad_path5 = TEST_APP_DIR "example.com1/../example.com2/pkg.apk"; |
| 117 | EXPECT_EQ(-1, validate_apk_path(bad_path5)) |
| 118 | << bad_path5 << " should be rejected as a invalid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 119 | } |
| 120 | |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 121 | TEST_F(UtilsTest, IsValidApkPath_TopDir) { |
| 122 | EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/com.example")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 123 | EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/random/com.example")); |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 124 | EXPECT_EQ(0, validate_apk_path(TEST_EXPAND_DIR "app/com.example")); |
| 125 | EXPECT_EQ(-1, validate_apk_path(TEST_DATA_DIR "data/com.example")); |
| 126 | EXPECT_EQ(-1, validate_apk_path(TEST_EXPAND_DIR "data/com.example")); |
| 127 | } |
| 128 | |
| 129 | TEST_F(UtilsTest, IsValidApkPath_TopFile) { |
| 130 | EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/com.example/base.apk")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 131 | EXPECT_EQ(0, validate_apk_path(TEST_DATA_DIR "app/random/com.example/base.apk")); |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 132 | EXPECT_EQ(0, validate_apk_path(TEST_EXPAND_DIR "app/com.example/base.apk")); |
| 133 | EXPECT_EQ(-1, validate_apk_path(TEST_DATA_DIR "data/com.example/base.apk")); |
| 134 | EXPECT_EQ(-1, validate_apk_path(TEST_EXPAND_DIR "data/com.example/base.apk")); |
| 135 | } |
| 136 | |
| 137 | TEST_F(UtilsTest, IsValidApkPath_OatDir) { |
| 138 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/com.example/oat")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 139 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/random/com.example/oat")); |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 140 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_EXPAND_DIR "app/com.example/oat")); |
| 141 | EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_DATA_DIR "data/com.example/oat")); |
| 142 | EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_EXPAND_DIR "data/com.example/oat")); |
| 143 | } |
| 144 | |
| 145 | TEST_F(UtilsTest, IsValidApkPath_OatDirDir) { |
| 146 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/com.example/oat/arm64")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 147 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/random/com.example/oat/arm64")); |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 148 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_EXPAND_DIR "app/com.example/oat/arm64")); |
| 149 | EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_DATA_DIR "data/com.example/oat/arm64")); |
| 150 | EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_EXPAND_DIR "data/com.example/oat/arm64")); |
| 151 | } |
| 152 | |
| 153 | TEST_F(UtilsTest, IsValidApkPath_OatDirDirFile) { |
| 154 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/com.example/oat/arm64/base.odex")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 155 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_DATA_DIR "app/random/com.example/oat/arm64/base.odex")); |
Jeff Sharkey | 8fa803a | 2018-04-09 18:46:45 -0600 | [diff] [blame] | 156 | EXPECT_EQ(0, validate_apk_path_subdirs(TEST_EXPAND_DIR "app/com.example/oat/arm64/base.odex")); |
| 157 | EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_DATA_DIR "data/com.example/oat/arm64/base.odex")); |
| 158 | EXPECT_EQ(-1, validate_apk_path_subdirs(TEST_EXPAND_DIR "data/com.example/oat/arm64/base.odex")); |
| 159 | } |
| 160 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 161 | TEST_F(UtilsTest, IsValidApkPath_Private) { |
| 162 | // Internal directories |
| 163 | const char *private1 = TEST_APP_PRIVATE_DIR "example.apk"; |
| 164 | EXPECT_EQ(0, validate_apk_path(private1)) |
| 165 | << private1 << " should be allowed as a valid path"; |
| 166 | |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 167 | // b/16888084 |
| 168 | const char *path2 = TEST_APP_DIR "example.com/example.apk"; |
| 169 | EXPECT_EQ(0, validate_apk_path(path2)) |
| 170 | << path2 << " should be allowed as a valid path"; |
| 171 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 172 | const char *path3 = TEST_APP_DIR "random/example.com/example.apk"; |
| 173 | EXPECT_EQ(0, validate_apk_path(path3)) |
| 174 | << path3 << " should be allowed as a valid path"; |
| 175 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 176 | const char *badpriv1 = TEST_APP_PRIVATE_DIR "../example.apk"; |
| 177 | EXPECT_EQ(-1, validate_apk_path(badpriv1)) |
| 178 | << badpriv1 << " should be rejected as a invalid path"; |
| 179 | |
| 180 | const char *badpriv2 = TEST_APP_PRIVATE_DIR "/../example.apk"; |
| 181 | EXPECT_EQ(-1, validate_apk_path(badpriv2)) |
| 182 | << badpriv2 << " should be rejected as a invalid path"; |
| 183 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 184 | // Only one or two subdir should be allowed. |
| 185 | const char *bad_path3 = TEST_APP_PRIVATE_DIR "random/example.com/subdir/pkg.apk"; |
Calin Juravle | fd88ff2 | 2014-08-15 15:45:51 +0100 | [diff] [blame] | 186 | EXPECT_EQ(-1, validate_apk_path(bad_path3)) |
| 187 | << bad_path3 << " should be rejected as a invalid path"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 188 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 189 | const char *bad_path4 = TEST_APP_PRIVATE_DIR "random/example.com/subdir/../pkg.apk"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 190 | EXPECT_EQ(-1, validate_apk_path(bad_path4)) |
| 191 | << bad_path4 << " should be rejected as a invalid path"; |
| 192 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 193 | const char *bad_path5 = TEST_APP_PRIVATE_DIR "random/example.com1/../example.com2/pkg.apk"; |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 194 | EXPECT_EQ(-1, validate_apk_path(bad_path5)) |
| 195 | << bad_path5 << " should be rejected as a invalid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 196 | } |
| 197 | |
| 198 | |
| 199 | TEST_F(UtilsTest, IsValidApkPath_AsecGood1) { |
| 200 | const char *asec1 = TEST_ASEC_DIR "example.apk"; |
| 201 | EXPECT_EQ(0, validate_apk_path(asec1)) |
| 202 | << asec1 << " should be allowed as a valid path"; |
| 203 | } |
| 204 | |
| 205 | TEST_F(UtilsTest, IsValidApkPath_AsecGood2) { |
| 206 | const char *asec2 = TEST_ASEC_DIR "com.example.asec/pkg.apk"; |
| 207 | EXPECT_EQ(0, validate_apk_path(asec2)) |
| 208 | << asec2 << " should be allowed as a valid path"; |
| 209 | } |
| 210 | |
| 211 | TEST_F(UtilsTest, IsValidApkPath_EscapeFail) { |
| 212 | const char *badasec1 = TEST_ASEC_DIR "../example.apk"; |
| 213 | EXPECT_EQ(-1, validate_apk_path(badasec1)) |
| 214 | << badasec1 << " should be rejected as a invalid path"; |
| 215 | } |
| 216 | |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 217 | TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeFail) { |
| 218 | const char *badasec3 = TEST_ASEC_DIR "com.example.asec/../../../pkg.apk"; |
| 219 | EXPECT_EQ(-1, validate_apk_path(badasec3)) |
| 220 | << badasec3 << " should be rejected as a invalid path"; |
| 221 | } |
| 222 | |
| 223 | TEST_F(UtilsTest, IsValidApkPath_SlashEscapeFail) { |
| 224 | const char *badasec4 = TEST_ASEC_DIR "/../example.apk"; |
| 225 | EXPECT_EQ(-1, validate_apk_path(badasec4)) |
| 226 | << badasec4 << " should be rejected as a invalid path"; |
| 227 | } |
| 228 | |
| 229 | TEST_F(UtilsTest, IsValidApkPath_CrazyDirFail) { |
| 230 | const char *badasec5 = TEST_ASEC_DIR ".//../.."; |
| 231 | EXPECT_EQ(-1, validate_apk_path(badasec5)) |
| 232 | << badasec5 << " should be rejected as a invalid path"; |
| 233 | } |
| 234 | |
| 235 | TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeSingleFail) { |
| 236 | const char *badasec6 = TEST_ASEC_DIR "com.example.asec/../pkg.apk"; |
| 237 | EXPECT_EQ(-1, validate_apk_path(badasec6)) |
| 238 | << badasec6 << " should be rejected as a invalid path"; |
| 239 | } |
| 240 | |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 241 | TEST_F(UtilsTest, IsValidApkPath_TwoSubdir) { |
| 242 | const char *badasec7 = TEST_ASEC_DIR "random/com.example.asec/pkg.apk"; |
| 243 | EXPECT_EQ(0, validate_apk_path(badasec7)) |
| 244 | << badasec7 << " should be allowed as a valid path"; |
| 245 | } |
| 246 | |
| 247 | TEST_F(UtilsTest, IsValidApkPath_ThreeSubdirFail) { |
| 248 | const char *badasec8 = TEST_ASEC_DIR "random/com.example.asec/subdir/pkg.apk"; |
| 249 | EXPECT_EQ(-1, validate_apk_path(badasec8)) |
| 250 | << badasec8 << " should be rejcted as an invalid path"; |
Mike Lockwood | 94afecf | 2012-10-24 10:45:23 -0700 | [diff] [blame] | 251 | } |
| 252 | |
| 253 | TEST_F(UtilsTest, CheckSystemApp_Dir1) { |
| 254 | const char *sysapp1 = TEST_SYSTEM_DIR1 "Voice.apk"; |
| 255 | EXPECT_EQ(0, validate_system_app_path(sysapp1)) |
| 256 | << sysapp1 << " should be allowed as a system path"; |
| 257 | } |
| 258 | |
| 259 | TEST_F(UtilsTest, CheckSystemApp_Dir2) { |
| 260 | const char *sysapp2 = TEST_SYSTEM_DIR2 "com.example.myapp.apk"; |
| 261 | EXPECT_EQ(0, validate_system_app_path(sysapp2)) |
| 262 | << sysapp2 << " should be allowed as a system path"; |
| 263 | } |
| 264 | |
| 265 | TEST_F(UtilsTest, CheckSystemApp_EscapeFail) { |
| 266 | const char *badapp1 = TEST_SYSTEM_DIR1 "../com.example.apk"; |
| 267 | EXPECT_EQ(-1, validate_system_app_path(badapp1)) |
| 268 | << badapp1 << " should be rejected not a system path"; |
| 269 | } |
| 270 | |
| 271 | TEST_F(UtilsTest, CheckSystemApp_DoubleEscapeFail) { |
| 272 | const char *badapp2 = TEST_SYSTEM_DIR2 "/../../com.example.apk"; |
| 273 | EXPECT_EQ(-1, validate_system_app_path(badapp2)) |
| 274 | << badapp2 << " should be rejected not a system path"; |
| 275 | } |
| 276 | |
| 277 | TEST_F(UtilsTest, CheckSystemApp_BadPathEscapeFail) { |
| 278 | const char *badapp3 = TEST_APP_DIR "/../../com.example.apk"; |
| 279 | EXPECT_EQ(-1, validate_system_app_path(badapp3)) |
| 280 | << badapp3 << " should be rejected not a system path"; |
| 281 | } |
| 282 | |
Calin Juravle | c597b6d | 2014-08-19 17:43:05 +0100 | [diff] [blame] | 283 | TEST_F(UtilsTest, CheckSystemApp_Subdir) { |
| 284 | const char *sysapp = TEST_SYSTEM_DIR1 "com.example/com.example.apk"; |
| 285 | EXPECT_EQ(0, validate_system_app_path(sysapp)) |
| 286 | << sysapp << " should be allowed as a system path"; |
| 287 | |
| 288 | const char *badapp = TEST_SYSTEM_DIR1 "com.example/subdir/com.example.apk"; |
| 289 | EXPECT_EQ(-1, validate_system_app_path(badapp)) |
| 290 | << badapp << " should be rejected not a system path"; |
| 291 | |
| 292 | const char *badapp1 = TEST_SYSTEM_DIR1 "com.example/subdir/../com.example.apk"; |
| 293 | EXPECT_EQ(-1, validate_system_app_path(badapp1)) |
| 294 | << badapp1 << " should be rejected not a system path"; |
| 295 | |
| 296 | const char *badapp2 = TEST_SYSTEM_DIR1 "com.example1/../com.example2/com.example.apk"; |
| 297 | EXPECT_EQ(-1, validate_system_app_path(badapp2)) |
| 298 | << badapp2 << " should be rejected not a system path"; |
| 299 | } |
| 300 | |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 301 | TEST_F(UtilsTest, CreateDataPath) { |
| 302 | EXPECT_EQ("/data", create_data_path(nullptr)); |
| 303 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b", |
| 304 | create_data_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b")); |
| 305 | } |
| 306 | |
Jeff Sharkey | d792118 | 2015-04-30 15:58:19 -0700 | [diff] [blame] | 307 | TEST_F(UtilsTest, CreateDataAppPath) { |
| 308 | EXPECT_EQ("/data/app", create_data_app_path(nullptr)); |
| 309 | |
| 310 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/app", |
| 311 | create_data_app_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b")); |
| 312 | } |
| 313 | |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 314 | TEST_F(UtilsTest, CreateDataUserPath) { |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 315 | EXPECT_EQ("/data/data", create_data_user_ce_path(nullptr, 0)); |
| 316 | EXPECT_EQ("/data/user/10", create_data_user_ce_path(nullptr, 10)); |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 317 | |
| 318 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/0", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 319 | create_data_user_ce_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0)); |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 320 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/10", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 321 | create_data_user_ce_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10)); |
Jeff Sharkey | 41ea424 | 2015-04-09 11:34:03 -0700 | [diff] [blame] | 322 | } |
| 323 | |
| 324 | TEST_F(UtilsTest, CreateDataMediaPath) { |
| 325 | EXPECT_EQ("/data/media/0", create_data_media_path(nullptr, 0)); |
| 326 | EXPECT_EQ("/data/media/10", create_data_media_path(nullptr, 10)); |
| 327 | |
| 328 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/media/0", |
| 329 | create_data_media_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0)); |
| 330 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/media/10", |
| 331 | create_data_media_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10)); |
| 332 | } |
| 333 | |
Jeff Sharkey | d792118 | 2015-04-30 15:58:19 -0700 | [diff] [blame] | 334 | TEST_F(UtilsTest, CreateDataUserPackagePath) { |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 335 | EXPECT_EQ("/data/data/com.example", create_data_user_ce_package_path(nullptr, 0, "com.example")); |
| 336 | EXPECT_EQ("/data/user/10/com.example", create_data_user_ce_package_path(nullptr, 10, "com.example")); |
Jeff Sharkey | c03de09 | 2015-04-07 18:14:05 -0700 | [diff] [blame] | 337 | |
| 338 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/0/com.example", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 339 | create_data_user_ce_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, "com.example")); |
Jeff Sharkey | c03de09 | 2015-04-07 18:14:05 -0700 | [diff] [blame] | 340 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/user/10/com.example", |
Jeff Sharkey | 2f720f7 | 2016-04-10 20:51:40 -0600 | [diff] [blame] | 341 | create_data_user_ce_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 10, "com.example")); |
Jeff Sharkey | c03de09 | 2015-04-07 18:14:05 -0700 | [diff] [blame] | 342 | } |
| 343 | |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 344 | TEST_F(UtilsTest, IsValidPackageName) { |
Jeff Sharkey | ab7ac8d | 2017-03-08 12:39:46 -0700 | [diff] [blame] | 345 | EXPECT_EQ(true, is_valid_package_name("android")); |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 346 | EXPECT_EQ(true, is_valid_package_name("com.example")); |
| 347 | EXPECT_EQ(true, is_valid_package_name("com.example-1")); |
| 348 | EXPECT_EQ(true, is_valid_package_name("com.example-1024")); |
| 349 | EXPECT_EQ(true, is_valid_package_name("com.example.foo---KiJFj4a_tePVw95pSrjg==")); |
| 350 | EXPECT_EQ(true, is_valid_package_name("really_LONG.a1234.package_name")); |
| 351 | |
| 352 | EXPECT_EQ(false, is_valid_package_name("1234.package")); |
| 353 | EXPECT_EQ(false, is_valid_package_name("com.1234.package")); |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 354 | EXPECT_EQ(false, is_valid_package_name("")); |
| 355 | EXPECT_EQ(false, is_valid_package_name(".")); |
Jeff Sharkey | ab7ac8d | 2017-03-08 12:39:46 -0700 | [diff] [blame] | 356 | EXPECT_EQ(false, is_valid_package_name("..")); |
| 357 | EXPECT_EQ(false, is_valid_package_name("../")); |
Jeff Sharkey | 367ace2 | 2017-03-07 22:12:03 -0700 | [diff] [blame] | 358 | EXPECT_EQ(false, is_valid_package_name("com.example/../com.evil/")); |
| 359 | EXPECT_EQ(false, is_valid_package_name("com.example-1/../com.evil/")); |
| 360 | EXPECT_EQ(false, is_valid_package_name("/com.evil")); |
| 361 | } |
| 362 | |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 363 | TEST_F(UtilsTest, CreateDataUserProfilePath) { |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 364 | EXPECT_EQ("/data/misc/profiles/cur/0", create_primary_cur_profile_dir_path(0)); |
| 365 | EXPECT_EQ("/data/misc/profiles/cur/1", create_primary_cur_profile_dir_path(1)); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 366 | } |
| 367 | |
| 368 | TEST_F(UtilsTest, CreateDataUserProfilePackagePath) { |
| 369 | EXPECT_EQ("/data/misc/profiles/cur/0/com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 370 | create_primary_current_profile_package_dir_path(0, "com.example")); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 371 | EXPECT_EQ("/data/misc/profiles/cur/1/com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 372 | create_primary_current_profile_package_dir_path(1, "com.example")); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 373 | } |
| 374 | |
| 375 | TEST_F(UtilsTest, CreateDataRefProfilePath) { |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 376 | EXPECT_EQ("/data/misc/profiles/ref", create_primary_ref_profile_dir_path()); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 377 | } |
| 378 | |
| 379 | TEST_F(UtilsTest, CreateDataRefProfilePackagePath) { |
| 380 | EXPECT_EQ("/data/misc/profiles/ref/com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 381 | create_primary_reference_profile_package_dir_path("com.example")); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 382 | } |
| 383 | |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 384 | TEST_F(UtilsTest, CreatePrimaryCurrentProfile) { |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 385 | std::string expected_base = |
Calin Juravle | a40b6e3 | 2017-04-12 18:20:44 -0700 | [diff] [blame] | 386 | create_primary_current_profile_package_dir_path(0, "com.example") + "/primary.prof"; |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 387 | EXPECT_EQ(expected_base, |
| 388 | create_current_profile_path(/*user*/0, "com.example", "primary.prof", |
| 389 | /*is_secondary*/false)); |
| 390 | |
| 391 | std::string expected_split = |
| 392 | create_primary_current_profile_package_dir_path(0, "com.example") + "/split.prof"; |
| 393 | EXPECT_EQ(expected_split, |
| 394 | create_current_profile_path(/*user*/0, "com.example", "split.prof", |
| 395 | /*is_secondary*/false)); |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 396 | } |
| 397 | |
| 398 | TEST_F(UtilsTest, CreatePrimaryReferenceProfile) { |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 399 | std::string expected_base = |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 400 | create_primary_reference_profile_package_dir_path("com.example") + "/primary.prof"; |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 401 | EXPECT_EQ(expected_base, |
| 402 | create_reference_profile_path("com.example", "primary.prof", /*is_secondary*/false)); |
| 403 | |
| 404 | std::string expected_split = |
| 405 | create_primary_reference_profile_package_dir_path("com.example") + "/split.prof"; |
| 406 | EXPECT_EQ(expected_split, |
| 407 | create_reference_profile_path("com.example", "split.prof", /*is_secondary*/false)); |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 408 | } |
| 409 | |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 410 | TEST_F(UtilsTest, CreateProfileSnapshot) { |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 411 | std::string expected_base = |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 412 | create_primary_reference_profile_package_dir_path("com.example") + "/primary.prof.snapshot"; |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 413 | EXPECT_EQ(expected_base, create_snapshot_profile_path("com.example", "primary.prof")); |
| 414 | |
| 415 | std::string expected_split = |
| 416 | create_primary_reference_profile_package_dir_path("com.example") + "/split.prof.snapshot"; |
| 417 | EXPECT_EQ(expected_split, create_snapshot_profile_path("com.example", "split.prof")); |
Calin Juravle | 2959173 | 2017-11-20 17:46:19 -0800 | [diff] [blame] | 418 | } |
| 419 | |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 420 | TEST_F(UtilsTest, CreateSecondaryCurrentProfile) { |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 421 | EXPECT_EQ("/data/user/0/com.example/oat/secondary.dex.cur.prof", |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 422 | create_current_profile_path(/*user*/0, "com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 423 | "/data/user/0/com.example/secondary.dex", /*is_secondary*/true)); |
| 424 | } |
| 425 | |
| 426 | TEST_F(UtilsTest, CreateSecondaryReferenceProfile) { |
| 427 | EXPECT_EQ("/data/user/0/com.example/oat/secondary.dex.prof", |
Calin Juravle | cfcd6aa | 2018-01-18 20:23:17 -0800 | [diff] [blame] | 428 | create_reference_profile_path("com.example", |
Calin Juravle | 114f081 | 2017-03-08 19:05:07 -0800 | [diff] [blame] | 429 | "/data/user/0/com.example/secondary.dex", /*is_secondary*/true)); |
Calin Juravle | 76268c5 | 2017-03-09 13:19:42 -0800 | [diff] [blame] | 430 | } |
| 431 | |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 432 | static void pass_secondary_dex_validation(const std::string& package_name, |
| 433 | const std::string& dex_path, int uid, int storage_flag) { |
| 434 | EXPECT_TRUE(validate_secondary_dex_path(package_name, dex_path, /*volume_uuid*/ nullptr, uid, |
| 435 | storage_flag)) |
| 436 | << dex_path << " should be allowed as a valid secondary dex path"; |
| 437 | } |
| 438 | |
| 439 | static void fail_secondary_dex_validation(const std::string& package_name, |
| 440 | const std::string& dex_path, int uid, int storage_flag) { |
| 441 | EXPECT_FALSE(validate_secondary_dex_path(package_name, dex_path, /*volume_uuid*/ nullptr, uid, |
| 442 | storage_flag)) |
| 443 | << dex_path << " should not be allowed as a valid secondary dex path"; |
| 444 | } |
| 445 | |
| 446 | TEST_F(UtilsTest, ValidateSecondaryDexFilesPath) { |
| 447 | std::string package_name = "com.test.app"; |
| 448 | std::string app_dir_ce_user_0 = "/data/data/" + package_name; |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 449 | std::string app_dir_ce_user_0_link = "/data/user/0/" + package_name; |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 450 | std::string app_dir_ce_user_10 = "/data/user/10/" + package_name; |
| 451 | |
| 452 | std::string app_dir_de_user_0 = "/data/user_de/0/" + package_name; |
| 453 | std::string app_dir_de_user_10 = "/data/user_de/10/" + package_name; |
| 454 | |
| 455 | EXPECT_EQ(app_dir_ce_user_0, |
| 456 | create_data_user_ce_package_path(nullptr, 0, package_name.c_str())); |
| 457 | EXPECT_EQ(app_dir_ce_user_10, |
| 458 | create_data_user_ce_package_path(nullptr, 10, package_name.c_str())); |
| 459 | |
| 460 | EXPECT_EQ(app_dir_de_user_0, |
| 461 | create_data_user_de_package_path(nullptr, 0, package_name.c_str())); |
| 462 | EXPECT_EQ(app_dir_de_user_10, |
| 463 | create_data_user_de_package_path(nullptr, 10, package_name.c_str())); |
| 464 | |
| 465 | uid_t app_uid_for_user_0 = multiuser_get_uid(/*user_id*/0, /*app_id*/ 1234); |
| 466 | uid_t app_uid_for_user_10 = multiuser_get_uid(/*user_id*/10, /*app_id*/ 1234); |
| 467 | |
| 468 | // Standard path for user 0 on CE storage. |
| 469 | pass_secondary_dex_validation( |
| 470 | package_name, app_dir_ce_user_0 + "/ce0.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
Calin Juravle | 7d76546 | 2017-09-04 15:57:10 -0700 | [diff] [blame] | 471 | pass_secondary_dex_validation( |
| 472 | package_name, app_dir_ce_user_0_link + "/ce0.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
Calin Juravle | 3760ad3 | 2017-07-27 16:31:55 -0700 | [diff] [blame] | 473 | // Standard path for user 10 on CE storage. |
| 474 | pass_secondary_dex_validation( |
| 475 | package_name, app_dir_ce_user_10 + "/ce10.dex", app_uid_for_user_10, FLAG_STORAGE_CE); |
| 476 | |
| 477 | // Standard path for user 0 on DE storage. |
| 478 | pass_secondary_dex_validation( |
| 479 | package_name, app_dir_de_user_0 + "/de0.dex", app_uid_for_user_0, FLAG_STORAGE_DE); |
| 480 | // Standard path for user 10 on DE storage. |
| 481 | pass_secondary_dex_validation( |
| 482 | package_name, app_dir_de_user_10 + "/de0.dex", app_uid_for_user_10, FLAG_STORAGE_DE); |
| 483 | |
| 484 | // Dex path for user 0 accessed from user 10. |
| 485 | fail_secondary_dex_validation( |
| 486 | package_name, app_dir_ce_user_0 + "/path0_from10.dex", |
| 487 | app_uid_for_user_10, FLAG_STORAGE_CE); |
| 488 | |
| 489 | // Dex path for CE storage accessed with DE. |
| 490 | fail_secondary_dex_validation( |
| 491 | package_name, app_dir_ce_user_0 + "/ce_from_de.dex", app_uid_for_user_0, FLAG_STORAGE_DE); |
| 492 | |
| 493 | // Dex path for DE storage accessed with CE. |
| 494 | fail_secondary_dex_validation( |
| 495 | package_name, app_dir_de_user_0 + "/de_from_ce.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
| 496 | |
| 497 | // Location which does not start with '/'. |
| 498 | fail_secondary_dex_validation( |
| 499 | package_name, "without_slash.dex", app_uid_for_user_10, FLAG_STORAGE_DE); |
| 500 | |
| 501 | // The dex file is not in the specified package directory. |
| 502 | fail_secondary_dex_validation( |
| 503 | "another.package", app_dir_ce_user_0 + "/for_another_package.dex", |
| 504 | app_uid_for_user_0, FLAG_STORAGE_DE); |
| 505 | |
| 506 | // The dex path contains indirect directories. |
| 507 | fail_secondary_dex_validation( |
| 508 | package_name, app_dir_ce_user_0 + "/1/../foo.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
| 509 | fail_secondary_dex_validation( |
| 510 | package_name, app_dir_ce_user_0 + "/1/./foo.dex", app_uid_for_user_0, FLAG_STORAGE_CE); |
| 511 | |
| 512 | // Super long path. |
| 513 | std::string too_long = create_too_long_path("too_long_"); |
| 514 | fail_secondary_dex_validation( |
| 515 | package_name, app_dir_ce_user_10 + "/" + too_long, app_uid_for_user_10, FLAG_STORAGE_CE); |
| 516 | } |
| 517 | |
Jeff Sharkey | 172fac0 | 2017-10-06 13:09:46 -0600 | [diff] [blame] | 518 | TEST_F(UtilsTest, ValidateApkPath) { |
| 519 | EXPECT_EQ(0, validate_apk_path("/data/app/com.example")); |
| 520 | EXPECT_EQ(0, validate_apk_path("/data/app/com.example/file")); |
| 521 | EXPECT_EQ(0, validate_apk_path("/data/app/com.example//file")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 522 | EXPECT_EQ(0, validate_apk_path("/data/app/random/com.example/")); |
| 523 | EXPECT_EQ(0, validate_apk_path("/data/app/random/com.example/file")); |
Jeff Sharkey | 172fac0 | 2017-10-06 13:09:46 -0600 | [diff] [blame] | 524 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/file")); |
| 525 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir//file")); |
| 526 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/dir/file")); |
| 527 | EXPECT_NE(0, validate_apk_path("/data/app/com.example/dir/dir/dir//file")); |
| 528 | } |
| 529 | |
| 530 | TEST_F(UtilsTest, ValidateApkPathSubdirs) { |
| 531 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example")); |
| 532 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/file")); |
| 533 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example//file")); |
| 534 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/")); |
| 535 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/file")); |
| 536 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/file")); |
| 537 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir//file")); |
Songchun Fan | 2955609 | 2020-01-23 14:51:45 -0800 | [diff] [blame] | 538 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/file")); |
| 539 | EXPECT_EQ(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir//file")); |
| 540 | EXPECT_NE(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/dir/file")); |
| 541 | EXPECT_NE(0, validate_apk_path_subdirs("/data/app/com.example/dir/dir/dir/dir//file")); |
Jeff Sharkey | 172fac0 | 2017-10-06 13:09:46 -0600 | [diff] [blame] | 542 | } |
| 543 | |
Jeff Sharkey | 725ae2b | 2018-09-28 10:07:14 -0600 | [diff] [blame] | 544 | TEST_F(UtilsTest, MatchExtension_Valid) { |
| 545 | EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("mpg")); |
| 546 | EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("mpeg")); |
| 547 | EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("mPeG")); |
| 548 | EXPECT_EQ(AID_MEDIA_VIDEO, MatchExtension("MPEG")); |
| 549 | } |
| 550 | |
| 551 | TEST_F(UtilsTest, MatchExtension_Invalid) { |
| 552 | EXPECT_EQ(0, MatchExtension("log")); |
| 553 | EXPECT_EQ(0, MatchExtension("3amp")); |
| 554 | EXPECT_EQ(0, MatchExtension("fpe")); |
| 555 | EXPECT_EQ(0, MatchExtension("docx")); |
| 556 | } |
| 557 | |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 558 | TEST_F(UtilsTest, TestRollbackPaths) { |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 559 | EXPECT_EQ("/data/misc_ce/0/rollback/239/com.foo", |
| 560 | create_data_misc_ce_rollback_package_path(nullptr, 0, 239, "com.foo")); |
| 561 | EXPECT_EQ("/data/misc_ce/10/rollback/37/com.foo", |
| 562 | create_data_misc_ce_rollback_package_path(nullptr, 10, 37, "com.foo")); |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 563 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 564 | EXPECT_EQ("/data/misc_de/0/rollback/73/com.foo", |
| 565 | create_data_misc_de_rollback_package_path(nullptr, 0, 73, "com.foo")); |
| 566 | EXPECT_EQ("/data/misc_de/10/rollback/13/com.foo", |
| 567 | create_data_misc_de_rollback_package_path(nullptr, 10, 13, "com.foo")); |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 568 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 569 | EXPECT_EQ("/data/misc_ce/0/rollback/57", |
| 570 | create_data_misc_ce_rollback_path(nullptr, 0, 57)); |
| 571 | EXPECT_EQ("/data/misc_ce/10/rollback/1543", |
| 572 | create_data_misc_ce_rollback_path(nullptr, 10, 1543)); |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 573 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 574 | EXPECT_EQ("/data/misc_de/0/rollback/43", |
| 575 | create_data_misc_de_rollback_path(nullptr, 0, 43)); |
| 576 | EXPECT_EQ("/data/misc_de/10/rollback/41", |
| 577 | create_data_misc_de_rollback_path(nullptr, 10, 41)); |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 578 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 579 | EXPECT_EQ("/data/misc_ce/0/rollback/17/com.foo", |
| 580 | create_data_misc_ce_rollback_package_path(nullptr, 0, 17, "com.foo", 0)); |
| 581 | EXPECT_EQ("/data/misc_ce/0/rollback/19/com.foo", |
| 582 | create_data_misc_ce_rollback_package_path(nullptr, 0, 19, "com.foo", 239)); |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 583 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 584 | auto rollback_ce_path = create_data_misc_ce_rollback_path(nullptr, 0, 53); |
| 585 | auto rollback_ce_package_path = create_data_misc_ce_rollback_package_path(nullptr, 0, 53, |
| 586 | "com.foo"); |
| 587 | auto deleter = [&rollback_ce_path]() { |
| 588 | delete_dir_contents_and_dir(rollback_ce_path, true /* ignore_if_missing */); |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 589 | }; |
| 590 | auto scope_guard = android::base::make_scope_guard(deleter); |
| 591 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 592 | EXPECT_NE(-1, mkdir(rollback_ce_path.c_str(), 700)); |
| 593 | EXPECT_NE(-1, mkdir(rollback_ce_package_path.c_str(), 700)); |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 594 | |
| 595 | ino_t ce_data_inode; |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 596 | EXPECT_EQ(0, get_path_inode(rollback_ce_package_path, &ce_data_inode)); |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 597 | |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 598 | EXPECT_EQ("/data/misc_ce/0/rollback/53/com.foo", |
| 599 | create_data_misc_ce_rollback_package_path(nullptr, 0, 53, "com.foo", ce_data_inode)); |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 600 | // Check that path defined by inode is picked even if it's not the same as |
| 601 | // the fallback one. |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 602 | EXPECT_EQ("/data/misc_ce/0/rollback/53/com.foo", |
| 603 | create_data_misc_ce_rollback_package_path(nullptr, 0, 53, "com.bar", ce_data_inode)); |
Nikita Ioffe | 8755f79 | 2019-01-25 13:54:43 +0000 | [diff] [blame] | 604 | |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 605 | // These last couple of cases are never exercised in production because we |
| 606 | // only snapshot apps in the primary data partition. Exercise them here for |
| 607 | // the sake of completeness. |
Nikita Ioffe | ad5da1e | 2019-02-04 11:06:37 +0000 | [diff] [blame] | 608 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/misc_ce/0/rollback/7/com.example", |
| 609 | create_data_misc_ce_rollback_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, 7, |
| 610 | "com.example")); |
| 611 | EXPECT_EQ("/mnt/expand/57f8f4bc-abf4-655f-bf67-946fc0f9f25b/misc_de/0/rollback/11/com.example", |
| 612 | create_data_misc_de_rollback_package_path("57f8f4bc-abf4-655f-bf67-946fc0f9f25b", 0, 11, |
| 613 | "com.example")); |
| 614 | } |
| 615 | |
| 616 | TEST_F(UtilsTest, TestCreateDirIfNeeded) { |
| 617 | system("mkdir -p /data/local/tmp/user/0"); |
| 618 | |
| 619 | auto deleter = [&]() { |
| 620 | delete_dir_contents_and_dir("/data/local/tmp/user/0", true /* ignore_if_missing */); |
| 621 | }; |
| 622 | auto scope_guard = android::base::make_scope_guard(deleter); |
| 623 | |
| 624 | // Create folder and check it's permissions. |
| 625 | ASSERT_EQ(0, create_dir_if_needed("/data/local/tmp/user/0/foo", 0700)); |
| 626 | struct stat st; |
| 627 | ASSERT_EQ(0, stat("/data/local/tmp/user/0/foo", &st)); |
| 628 | ASSERT_EQ(0700, st.st_mode & ALLPERMS); |
| 629 | |
| 630 | // Check that create_dir_if_needed is no-op if folder already exists with |
| 631 | // correct permissions. |
| 632 | ASSERT_EQ(0, create_dir_if_needed("/data/local/tmp/user/0/foo", 0700)); |
| 633 | |
| 634 | // Check -1 is returned if folder exists but with different permissions. |
| 635 | ASSERT_EQ(-1, create_dir_if_needed("/data/local/tmp/user/0/foo", 0750)); |
| 636 | |
| 637 | // Check that call fails if parent doesn't exist. |
| 638 | ASSERT_NE(0, create_dir_if_needed("/data/local/tmp/user/0/bar/baz", 0700)); |
Narayan Kamath | dfdfb79 | 2019-01-14 15:21:52 +0000 | [diff] [blame] | 639 | } |
| 640 | |
Andreas Gampe | 02d0de5 | 2015-11-11 20:43:16 -0800 | [diff] [blame] | 641 | } // namespace installd |
| 642 | } // namespace android |