| commit | 778c986f85ffb3e91ccf3bf0382372853888fd07 | [log] [tgz] |
|---|---|---|
| author | Paul Stewart <pstew@chromium.org> | Thu Jul 30 10:17:42 2015 -0700 |
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | Sat Aug 01 02:52:24 2015 +0000 |
| tree | 49b04bd65268d31fcabac6e804c5c7e05ce4f337 | |
| parent | 6597087dbbcdfab1f145fe1b8c8fad4df0874e99 [diff] |
shill: Service: Prefer Online to Connected This change allows services that are online but still executing portal detection to remain non-default while portal detection is still being executed. This eliminates network disruptions when higher priority technologies are attached to networks that do not supply upstream connectivity. For example, if connected to a working WiFi, and Ethernet is attached, connectivity will not be switched until portal detection completes successfully. Before this change, Ethernet would become default temporarily until it was discovered that we were in portal mode. The upside of this change is large (due to the length of time it takes to fail portal detection) and the downside is small (successful portal detection usually does not take long). BUG=chromium:515570 TEST=Unit tests + manual -- connect to WiFi, then attach TEST=Ethernet to a router with no upstream connectivity. Change-Id: I4a6eab276400e6e945cc8cba94b10425aefc2770 Reviewed-on: https://chromium-review.googlesource.com/289812 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>