Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "shill/vpn_driver.h" |
| 6 | |
| 7 | #include <base/stl_util.h> |
Ben Chan | a0ddf46 | 2014-02-06 11:32:42 -0800 | [diff] [blame] | 8 | #include <base/strings/string_number_conversions.h> |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 9 | #include <chromeos/dbus/service_constants.h> |
| 10 | #include <gmock/gmock.h> |
| 11 | #include <gtest/gtest.h> |
| 12 | |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 13 | #include "shill/event_dispatcher.h" |
| 14 | #include "shill/glib.h" |
| 15 | #include "shill/mock_connection.h" |
| 16 | #include "shill/mock_device_info.h" |
| 17 | #include "shill/mock_glib.h" |
| 18 | #include "shill/mock_manager.h" |
| 19 | #include "shill/mock_metrics.h" |
| 20 | #include "shill/mock_service.h" |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 21 | #include "shill/mock_store.h" |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 22 | #include "shill/nice_mock_control.h" |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 23 | #include "shill/property_store.h" |
| 24 | |
| 25 | using std::string; |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 26 | using std::vector; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 27 | using testing::_; |
| 28 | using testing::AnyNumber; |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 29 | using testing::NiceMock; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 30 | using testing::Return; |
| 31 | using testing::SetArgumentPointee; |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 32 | using testing::StrictMock; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 33 | using testing::Test; |
| 34 | |
| 35 | namespace shill { |
| 36 | |
| 37 | namespace { |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 38 | |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 39 | const char kVPNHostProperty[] = "VPN.Host"; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 40 | const char kOTPProperty[] = "VPN.OTP"; |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 41 | const char kPINProperty[] = "VPN.PIN"; |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 42 | const char kPSKProperty[] = "VPN.PSK"; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 43 | const char kPasswordProperty[] = "VPN.Password"; |
| 44 | const char kPortProperty[] = "VPN.Port"; |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 45 | |
| 46 | const char kPIN[] = "5555"; |
| 47 | const char kPassword[] = "random-password"; |
| 48 | const char kPort[] = "1234"; |
| 49 | const char kStorageID[] = "vpn_service_id"; |
| 50 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 51 | } // namespace |
| 52 | |
| 53 | class VPNDriverUnderTest : public VPNDriver { |
| 54 | public: |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 55 | VPNDriverUnderTest(EventDispatcher *dispatcher, Manager *manager); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 56 | virtual ~VPNDriverUnderTest() {} |
| 57 | |
| 58 | // Inherited from VPNDriver. |
| 59 | MOCK_METHOD2(ClaimInterface, bool(const string &link_name, |
| 60 | int interface_index)); |
| 61 | MOCK_METHOD2(Connect, void(const VPNServiceRefPtr &service, Error *error)); |
| 62 | MOCK_METHOD0(Disconnect, void()); |
Darin Petkov | 5eb0542 | 2012-05-11 15:45:25 +0200 | [diff] [blame] | 63 | MOCK_METHOD0(OnConnectionDisconnected, void()); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 64 | MOCK_CONST_METHOD0(GetProviderType, string()); |
| 65 | |
| 66 | private: |
| 67 | static const Property kProperties[]; |
| 68 | |
| 69 | DISALLOW_COPY_AND_ASSIGN(VPNDriverUnderTest); |
| 70 | }; |
| 71 | |
| 72 | // static |
| 73 | const VPNDriverUnderTest::Property VPNDriverUnderTest::kProperties[] = { |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 74 | { kEapCaCertPemProperty, Property::kArray }, |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 75 | { kVPNHostProperty, 0 }, |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 76 | { kL2tpIpsecCaCertPemProperty, Property::kArray }, |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 77 | { kOTPProperty, Property::kEphemeral }, |
| 78 | { kPINProperty, Property::kWriteOnly }, |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 79 | { kPSKProperty, Property::kCredential }, |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 80 | { kPasswordProperty, Property::kCredential }, |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 81 | { kPortProperty, 0 }, |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 82 | { kProviderTypeProperty, 0 }, |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 83 | }; |
| 84 | |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 85 | VPNDriverUnderTest::VPNDriverUnderTest( |
| 86 | EventDispatcher *dispatcher, Manager *manager) |
| 87 | : VPNDriver(dispatcher, manager, kProperties, arraysize(kProperties)) {} |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 88 | |
| 89 | class VPNDriverTest : public Test { |
| 90 | public: |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 91 | VPNDriverTest() |
| 92 | : device_info_(&control_, &dispatcher_, &metrics_, &manager_), |
Thieu Le | 6c1e3bb | 2013-02-06 15:20:35 -0800 | [diff] [blame] | 93 | metrics_(&dispatcher_), |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 94 | manager_(&control_, &dispatcher_, &metrics_, &glib_), |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 95 | driver_(&dispatcher_, &manager_) {} |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 96 | |
| 97 | virtual ~VPNDriverTest() {} |
| 98 | |
| 99 | protected: |
Darin Petkov | 0cd0d1e | 2013-02-11 12:49:10 +0100 | [diff] [blame] | 100 | EventDispatcher *dispatcher() { return driver_.dispatcher_; } |
| 101 | void set_dispatcher(EventDispatcher *dispatcher) { |
| 102 | driver_.dispatcher_ = dispatcher; |
| 103 | } |
| 104 | |
| 105 | const base::CancelableClosure &connect_timeout_callback() { |
| 106 | return driver_.connect_timeout_callback_; |
| 107 | } |
| 108 | |
| 109 | bool IsConnectTimeoutStarted() { return driver_.IsConnectTimeoutStarted(); } |
| 110 | int connect_timeout_seconds() { return driver_.connect_timeout_seconds(); } |
| 111 | |
| 112 | void StartConnectTimeout(int timeout_seconds) { |
| 113 | driver_.StartConnectTimeout(timeout_seconds); |
| 114 | } |
| 115 | |
| 116 | void StopConnectTimeout() { driver_.StopConnectTimeout(); } |
| 117 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 118 | void SetArg(const string &arg, const string &value) { |
| 119 | driver_.args()->SetString(arg, value); |
| 120 | } |
| 121 | |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 122 | void SetArgArray(const string &arg, const vector<string> &value) { |
| 123 | driver_.args()->SetStrings(arg, value); |
| 124 | } |
| 125 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 126 | KeyValueStore *GetArgs() { return driver_.args(); } |
| 127 | |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 128 | bool GetProviderPropertyString(const PropertyStore &store, |
| 129 | const string &key, |
| 130 | string *value); |
| 131 | |
| 132 | bool GetProviderPropertyStrings(const PropertyStore &store, |
| 133 | const string &key, |
| 134 | vector<string> *value); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 135 | |
Darin Petkov | 0e9735d | 2012-04-24 12:33:45 +0200 | [diff] [blame] | 136 | NiceMockControl control_; |
| 137 | NiceMock<MockDeviceInfo> device_info_; |
| 138 | EventDispatcher dispatcher_; |
| 139 | MockMetrics metrics_; |
| 140 | MockGLib glib_; |
| 141 | MockManager manager_; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 142 | VPNDriverUnderTest driver_; |
| 143 | }; |
| 144 | |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 145 | bool VPNDriverTest::GetProviderPropertyString(const PropertyStore &store, |
| 146 | const string &key, |
| 147 | string *value) { |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 148 | KeyValueStore provider_properties; |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 149 | Error error; |
| 150 | EXPECT_TRUE(store.GetKeyValueStoreProperty( |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 151 | kProviderProperty, &provider_properties, &error)); |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 152 | if (!provider_properties.ContainsString(key)) { |
| 153 | return false; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 154 | } |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 155 | if (value != NULL) { |
| 156 | *value = provider_properties.GetString(key); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 157 | } |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 158 | return true; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 159 | } |
| 160 | |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 161 | bool VPNDriverTest::GetProviderPropertyStrings(const PropertyStore &store, |
| 162 | const string &key, |
| 163 | vector<string> *value) { |
| 164 | KeyValueStore provider_properties; |
| 165 | Error error; |
| 166 | EXPECT_TRUE(store.GetKeyValueStoreProperty( |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 167 | kProviderProperty, &provider_properties, &error)); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 168 | if (!provider_properties.ContainsStrings(key)) { |
| 169 | return false; |
| 170 | } |
| 171 | if (value != NULL) { |
| 172 | *value = provider_properties.GetStrings(key); |
| 173 | } |
| 174 | return true; |
| 175 | } |
| 176 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 177 | TEST_F(VPNDriverTest, Load) { |
| 178 | MockStore storage; |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 179 | GetArgs()->SetString(kVPNHostProperty, "1.2.3.4"); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 180 | GetArgs()->SetString(kPSKProperty, "1234"); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 181 | GetArgs()->SetStrings(kL2tpIpsecCaCertPemProperty, |
| 182 | vector<string>{ "cleared-cert0", "cleared-cert1" }); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 183 | EXPECT_CALL(storage, GetString(kStorageID, _, _)) |
| 184 | .WillRepeatedly(Return(false)); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 185 | EXPECT_CALL(storage, GetStringList(kStorageID, _, _)) |
| 186 | .WillRepeatedly(Return(false)); |
| 187 | EXPECT_CALL(storage, GetString(_, kEapCaCertPemProperty, _)).Times(0); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 188 | EXPECT_CALL(storage, GetString(_, kOTPProperty, _)).Times(0); |
| 189 | EXPECT_CALL(storage, GetCryptedString(_, kOTPProperty, _)).Times(0); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 190 | EXPECT_CALL(storage, GetStringList(_, kOTPProperty, _)).Times(0); |
| 191 | vector<string> kCaCerts{ "cert0", "cert1" }; |
| 192 | EXPECT_CALL(storage, GetStringList(kStorageID, kEapCaCertPemProperty, _)) |
| 193 | .WillOnce(DoAll(SetArgumentPointee<2>(kCaCerts), Return(true))); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 194 | EXPECT_CALL(storage, GetString(kStorageID, kPortProperty, _)) |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 195 | .WillOnce(DoAll(SetArgumentPointee<2>(string(kPort)), Return(true))); |
| 196 | EXPECT_CALL(storage, GetString(kStorageID, kPINProperty, _)) |
| 197 | .WillOnce(DoAll(SetArgumentPointee<2>(string(kPIN)), Return(true))); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 198 | EXPECT_CALL(storage, GetCryptedString(kStorageID, kPSKProperty, _)) |
| 199 | .WillOnce(Return(false)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 200 | EXPECT_CALL(storage, GetCryptedString(kStorageID, kPasswordProperty, _)) |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 201 | .WillOnce(DoAll(SetArgumentPointee<2>(string(kPassword)), Return(true))); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 202 | EXPECT_TRUE(driver_.Load(&storage, kStorageID)); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 203 | EXPECT_TRUE(GetArgs()->ContainsStrings(kEapCaCertPemProperty)); |
| 204 | if (GetArgs()->ContainsStrings(kEapCaCertPemProperty)) { |
| 205 | EXPECT_EQ(kCaCerts, GetArgs()->GetStrings(kEapCaCertPemProperty)); |
| 206 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 207 | EXPECT_EQ(kPort, GetArgs()->LookupString(kPortProperty, "")); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 208 | EXPECT_EQ(kPIN, GetArgs()->LookupString(kPINProperty, "")); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 209 | EXPECT_EQ(kPassword, GetArgs()->LookupString(kPasswordProperty, "")); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 210 | |
| 211 | // Properties missing from the persistent store should be deleted. |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 212 | EXPECT_FALSE(GetArgs()->ContainsString(kVPNHostProperty)); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 213 | EXPECT_FALSE(GetArgs()->ContainsStrings(kL2tpIpsecCaCertPemProperty)); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 214 | EXPECT_FALSE(GetArgs()->ContainsString(kPSKProperty)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 215 | } |
| 216 | |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 217 | TEST_F(VPNDriverTest, Save) { |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 218 | SetArg(kProviderTypeProperty, ""); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 219 | SetArg(kPINProperty, kPIN); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 220 | SetArg(kPortProperty, kPort); |
| 221 | SetArg(kPasswordProperty, kPassword); |
| 222 | SetArg(kOTPProperty, "987654"); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 223 | const vector<string> kCaCerts{ "cert0", "cert1" }; |
| 224 | SetArgArray(kEapCaCertPemProperty, kCaCerts); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 225 | MockStore storage; |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 226 | EXPECT_CALL(storage, |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 227 | SetStringList(kStorageID, kEapCaCertPemProperty, kCaCerts)) |
| 228 | .WillOnce(Return(true)); |
| 229 | EXPECT_CALL(storage, |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 230 | SetString(kStorageID, kProviderTypeProperty, "")) |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 231 | .WillOnce(Return(true)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 232 | EXPECT_CALL(storage, SetString(kStorageID, kPortProperty, kPort)) |
| 233 | .WillOnce(Return(true)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 234 | EXPECT_CALL(storage, SetString(kStorageID, kPINProperty, kPIN)) |
| 235 | .WillOnce(Return(true)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 236 | EXPECT_CALL(storage, |
| 237 | SetCryptedString(kStorageID, kPasswordProperty, kPassword)) |
| 238 | .WillOnce(Return(true)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 239 | EXPECT_CALL(storage, SetCryptedString(_, kOTPProperty, _)).Times(0); |
| 240 | EXPECT_CALL(storage, SetString(_, kOTPProperty, _)).Times(0); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 241 | EXPECT_CALL(storage, SetString(_, kEapCaCertPemProperty, _)).Times(0); |
| 242 | EXPECT_CALL(storage, DeleteKey(kStorageID, kEapCaCertPemProperty)).Times(0); |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 243 | EXPECT_CALL(storage, DeleteKey(kStorageID, kProviderTypeProperty)) |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 244 | .Times(0); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 245 | EXPECT_CALL(storage, DeleteKey(kStorageID, kL2tpIpsecCaCertPemProperty)); |
| 246 | EXPECT_CALL(storage, DeleteKey(kStorageID, kPSKProperty)); |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 247 | EXPECT_CALL(storage, DeleteKey(kStorageID, kVPNHostProperty)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 248 | EXPECT_TRUE(driver_.Save(&storage, kStorageID, true)); |
| 249 | } |
| 250 | |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 251 | TEST_F(VPNDriverTest, SaveNoCredentials) { |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 252 | SetArg(kPasswordProperty, kPassword); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 253 | SetArg(kPSKProperty, ""); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 254 | MockStore storage; |
| 255 | EXPECT_CALL(storage, SetString(_, kPasswordProperty, _)).Times(0); |
| 256 | EXPECT_CALL(storage, SetCryptedString(_, kPasswordProperty, _)).Times(0); |
| 257 | EXPECT_CALL(storage, DeleteKey(kStorageID, _)).Times(AnyNumber()); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 258 | EXPECT_CALL(storage, DeleteKey(kStorageID, kPasswordProperty)); |
| 259 | EXPECT_CALL(storage, DeleteKey(kStorageID, kPSKProperty)); |
| 260 | EXPECT_CALL(storage, DeleteKey(kStorageID, kEapCaCertPemProperty)); |
| 261 | EXPECT_CALL(storage, DeleteKey(kStorageID, kL2tpIpsecCaCertPemProperty)); |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 262 | EXPECT_TRUE(driver_.Save(&storage, kStorageID, false)); |
| 263 | } |
| 264 | |
| 265 | TEST_F(VPNDriverTest, UnloadCredentials) { |
| 266 | SetArg(kOTPProperty, "654321"); |
| 267 | SetArg(kPasswordProperty, kPassword); |
| 268 | SetArg(kPortProperty, kPort); |
| 269 | driver_.UnloadCredentials(); |
| 270 | EXPECT_FALSE(GetArgs()->ContainsString(kOTPProperty)); |
| 271 | EXPECT_FALSE(GetArgs()->ContainsString(kPasswordProperty)); |
| 272 | EXPECT_EQ(kPort, GetArgs()->LookupString(kPortProperty, "")); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 273 | } |
| 274 | |
| 275 | TEST_F(VPNDriverTest, InitPropertyStore) { |
| 276 | // Figure out if the store is actually hooked up to the driver argument |
| 277 | // KeyValueStore. |
| 278 | PropertyStore store; |
| 279 | driver_.InitPropertyStore(&store); |
| 280 | |
| 281 | // An un-set property should not be readable. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 282 | { |
| 283 | Error error; |
| 284 | EXPECT_FALSE(store.GetStringProperty(kPortProperty, NULL, &error)); |
| 285 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 286 | } |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 287 | { |
| 288 | Error error; |
| 289 | EXPECT_FALSE(store.GetStringsProperty(kEapCaCertPemProperty, NULL, &error)); |
| 290 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 291 | } |
| 292 | EXPECT_FALSE(GetProviderPropertyString(store, kPortProperty, NULL)); |
| 293 | EXPECT_FALSE(GetProviderPropertyStrings(store, kEapCaCertPemProperty, NULL)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 294 | |
Darin Petkov | 4e02ba2 | 2013-04-02 13:44:08 +0200 | [diff] [blame] | 295 | const string kProviderType = "boo"; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 296 | SetArg(kPortProperty, kPort); |
| 297 | SetArg(kPasswordProperty, kPassword); |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 298 | SetArg(kProviderTypeProperty, kProviderType); |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 299 | SetArg(kVPNHostProperty, ""); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 300 | const vector<string> kCaCerts{ "cert1" }; |
| 301 | SetArgArray(kEapCaCertPemProperty, kCaCerts); |
| 302 | SetArgArray(kL2tpIpsecCaCertPemProperty, vector<string>()); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 303 | |
| 304 | // We should not be able to read a property out of the driver args using the |
| 305 | // key to the args directly. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 306 | { |
| 307 | Error error; |
| 308 | EXPECT_FALSE(store.GetStringProperty(kPortProperty, NULL, &error)); |
| 309 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 310 | } |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 311 | { |
| 312 | Error error; |
| 313 | EXPECT_FALSE(store.GetStringsProperty(kEapCaCertPemProperty, NULL, &error)); |
| 314 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 315 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 316 | |
| 317 | // We should instead be able to find it within the "Provider" stringmap. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 318 | { |
| 319 | string value; |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 320 | EXPECT_TRUE(GetProviderPropertyString(store, kPortProperty, &value)); |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 321 | EXPECT_EQ(kPort, value); |
| 322 | } |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 323 | { |
| 324 | vector<string> value; |
| 325 | EXPECT_TRUE(GetProviderPropertyStrings(store, kEapCaCertPemProperty, |
| 326 | &value)); |
| 327 | EXPECT_EQ(kCaCerts, value); |
| 328 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 329 | |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 330 | // We should be able to read empty properties from the "Provider" stringmap. |
| 331 | { |
| 332 | string value; |
Ben Chan | 56bc880 | 2013-09-19 23:54:51 -0700 | [diff] [blame] | 333 | EXPECT_TRUE(GetProviderPropertyString(store, kVPNHostProperty, &value)); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 334 | EXPECT_TRUE(value.empty()); |
| 335 | } |
| 336 | { |
| 337 | vector<string> value; |
| 338 | EXPECT_TRUE(GetProviderPropertyStrings(store, kL2tpIpsecCaCertPemProperty, |
| 339 | &value)); |
Darin Petkov | 4e9066f | 2012-06-11 13:17:06 +0200 | [diff] [blame] | 340 | EXPECT_TRUE(value.empty()); |
| 341 | } |
| 342 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 343 | // Properties that start with the prefix "Provider." should be mapped to the |
| 344 | // name in the Properties dict with the prefix removed. |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 345 | { |
| 346 | string value; |
Ben Chan | 7372878 | 2013-09-20 13:40:54 -0700 | [diff] [blame] | 347 | EXPECT_TRUE(GetProviderPropertyString(store, kTypeProperty, |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 348 | &value)); |
Darin Petkov | 4e02ba2 | 2013-04-02 13:44:08 +0200 | [diff] [blame] | 349 | EXPECT_EQ(kProviderType, value); |
Paul Stewart | e6e8e49 | 2013-01-17 11:00:50 -0800 | [diff] [blame] | 350 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 351 | |
Paul Stewart | 8e7e459 | 2012-04-29 09:47:48 -0700 | [diff] [blame] | 352 | // If we clear a property, we should no longer be able to find it. |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 353 | { |
| 354 | Error error; |
| 355 | EXPECT_TRUE(store.ClearProperty(kPortProperty, &error)); |
| 356 | EXPECT_TRUE(error.IsSuccess()); |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 357 | EXPECT_FALSE(GetProviderPropertyString(store, kPortProperty, NULL)); |
| 358 | } |
| 359 | { |
| 360 | Error error; |
| 361 | EXPECT_TRUE(store.ClearProperty(kEapCaCertPemProperty, &error)); |
| 362 | EXPECT_TRUE(error.IsSuccess()); |
| 363 | EXPECT_FALSE(GetProviderPropertyStrings(store, kEapCaCertPemProperty, |
| 364 | NULL)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 365 | } |
| 366 | |
| 367 | // A second attempt to clear this property should return an error. |
| 368 | { |
| 369 | Error error; |
| 370 | EXPECT_FALSE(store.ClearProperty(kPortProperty, &error)); |
| 371 | EXPECT_EQ(Error::kNotFound, error.type()); |
| 372 | } |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 373 | { |
| 374 | Error error; |
| 375 | EXPECT_FALSE(store.ClearProperty(kEapCaCertPemProperty, &error)); |
| 376 | EXPECT_EQ(Error::kNotFound, error.type()); |
| 377 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 378 | |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 379 | // Test write only properties. |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 380 | EXPECT_FALSE(GetProviderPropertyString(store, kPINProperty, NULL)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 381 | |
| 382 | // Write properties to the driver args using the PropertyStore interface. |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 383 | { |
| 384 | const string kValue = "some-value"; |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 385 | Error error; |
Darin Petkov | cb71529 | 2012-04-25 13:04:37 +0200 | [diff] [blame] | 386 | EXPECT_TRUE(store.SetStringProperty(kPINProperty, kValue, &error)); |
| 387 | EXPECT_EQ(kValue, GetArgs()->GetString(kPINProperty)); |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 388 | } |
Paul Stewart | df4e3c9 | 2013-06-13 17:50:30 -0700 | [diff] [blame] | 389 | { |
| 390 | const vector<string> kValue{ "some-value" }; |
| 391 | Error error; |
| 392 | EXPECT_TRUE(store.SetStringsProperty(kEapCaCertPemProperty, kValue, |
| 393 | &error)); |
| 394 | EXPECT_EQ(kValue, GetArgs()->GetStrings(kEapCaCertPemProperty)); |
| 395 | } |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 396 | } |
| 397 | |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 398 | TEST_F(VPNDriverTest, ConnectTimeout) { |
Darin Petkov | 0cd0d1e | 2013-02-11 12:49:10 +0100 | [diff] [blame] | 399 | EXPECT_EQ(&dispatcher_, dispatcher()); |
| 400 | EXPECT_TRUE(connect_timeout_callback().IsCancelled()); |
| 401 | EXPECT_FALSE(IsConnectTimeoutStarted()); |
| 402 | StartConnectTimeout(0); |
| 403 | EXPECT_FALSE(connect_timeout_callback().IsCancelled()); |
| 404 | EXPECT_TRUE(IsConnectTimeoutStarted()); |
| 405 | set_dispatcher(NULL); |
| 406 | StartConnectTimeout(0); // Expect no crash. |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 407 | dispatcher_.DispatchPendingEvents(); |
Darin Petkov | 0cd0d1e | 2013-02-11 12:49:10 +0100 | [diff] [blame] | 408 | EXPECT_TRUE(connect_timeout_callback().IsCancelled()); |
| 409 | EXPECT_FALSE(IsConnectTimeoutStarted()); |
| 410 | } |
| 411 | |
| 412 | TEST_F(VPNDriverTest, StartStopConnectTimeout) { |
| 413 | EXPECT_FALSE(IsConnectTimeoutStarted()); |
| 414 | EXPECT_EQ(0, connect_timeout_seconds()); |
| 415 | const int kTimeout = 123; |
| 416 | StartConnectTimeout(kTimeout); |
| 417 | EXPECT_TRUE(IsConnectTimeoutStarted()); |
| 418 | EXPECT_EQ(kTimeout, connect_timeout_seconds()); |
| 419 | StartConnectTimeout(kTimeout - 20); |
| 420 | EXPECT_EQ(kTimeout, connect_timeout_seconds()); |
| 421 | StopConnectTimeout(); |
| 422 | EXPECT_FALSE(IsConnectTimeoutStarted()); |
| 423 | EXPECT_EQ(0, connect_timeout_seconds()); |
Darin Petkov | 602303f | 2012-06-06 12:15:59 +0200 | [diff] [blame] | 424 | } |
| 425 | |
Darin Petkov | b451d6e | 2012-04-23 11:56:41 +0200 | [diff] [blame] | 426 | } // namespace shill |