Darin Petkov | 41c0e0a | 2012-01-09 16:38:53 +0100 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Jason Glasgow | 82f9ab3 | 2012-04-04 14:27:19 -0400 | [diff] [blame] | 5 | #include "shill/modem.h" |
| 6 | |
Darin Petkov | 6f9eaa3 | 2011-08-09 15:26:44 -0700 | [diff] [blame] | 7 | #include <vector> |
| 8 | |
mukesh agrawal | 9da0777 | 2013-05-15 14:15:17 -0700 | [diff] [blame] | 9 | #include <base/stringprintf.h> |
Chris Masone | 626719f | 2011-08-18 16:58:48 -0700 | [diff] [blame] | 10 | #include <gmock/gmock.h> |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 11 | #include <gtest/gtest.h> |
| 12 | #include <mm/mm-modem.h> |
| 13 | #include <net/if.h> |
| 14 | #include <sys/ioctl.h> |
| 15 | |
| 16 | #include "shill/cellular.h" |
Darin Petkov | 721ac93 | 2011-11-16 15:43:09 +0100 | [diff] [blame] | 17 | #include "shill/cellular_capability_gsm.h" |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 18 | #include "shill/dbus_property_matchers.h" |
Paul Stewart | 26b327e | 2011-10-19 11:38:09 -0700 | [diff] [blame] | 19 | #include "shill/event_dispatcher.h" |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 20 | #include "shill/manager.h" |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 21 | #include "shill/mock_cellular.h" |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 22 | #include "shill/mock_dbus_properties_proxy.h" |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 23 | #include "shill/mock_device_info.h" |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 24 | #include "shill/mock_modem.h" |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 25 | #include "shill/mock_modem_info.h" |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 26 | #include "shill/mock_rtnl_handler.h" |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 27 | #include "shill/proxy_factory.h" |
| 28 | #include "shill/rtnl_handler.h" |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 29 | |
| 30 | using std::string; |
Darin Petkov | 6f9eaa3 | 2011-08-09 15:26:44 -0700 | [diff] [blame] | 31 | using std::vector; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 32 | using testing::_; |
mukesh agrawal | 12533ad | 2013-08-01 15:43:23 -0700 | [diff] [blame] | 33 | using testing::AnyNumber; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 34 | using testing::DoAll; |
| 35 | using testing::Return; |
Chris Masone | 626719f | 2011-08-18 16:58:48 -0700 | [diff] [blame] | 36 | using testing::SetArgumentPointee; |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 37 | using testing::StrEq; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 38 | using testing::StrictMock; |
| 39 | using testing::Test; |
| 40 | |
| 41 | namespace shill { |
| 42 | |
| 43 | namespace { |
| 44 | |
| 45 | const int kTestInterfaceIndex = 5; |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 46 | const char kLinkName[] = "usb0"; |
| 47 | const char kOwner[] = ":1.18"; |
Jason Glasgow | a585fc3 | 2012-06-06 11:04:09 -0400 | [diff] [blame] | 48 | const char kService[] = "org.chromium.ModemManager"; |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 49 | const char kPath[] = "/org/chromium/ModemManager/Gobi/0"; |
| 50 | const unsigned char kAddress[] = {0x00, 0x01, 0x02, 0x03, 0x04, 0x05}; |
| 51 | const char kAddressAsString[] = "000102030405"; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 52 | |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 53 | } // namespace |
| 54 | |
| 55 | class ModemTest : public Test { |
| 56 | public: |
| 57 | ModemTest() |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 58 | : modem_info_(NULL, &dispatcher_, NULL, NULL, NULL), |
| 59 | device_info_(modem_info_.control_interface(), modem_info_.dispatcher(), |
| 60 | modem_info_.metrics(), modem_info_.manager()), |
Darin Petkov | 3b29233 | 2011-07-28 14:17:24 -0700 | [diff] [blame] | 61 | proxy_(new MockDBusPropertiesProxy()), |
| 62 | proxy_factory_(this), |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 63 | modem_( |
| 64 | new StrictModem( |
| 65 | kOwner, |
Jason Glasgow | a585fc3 | 2012-06-06 11:04:09 -0400 | [diff] [blame] | 66 | kService, |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 67 | kPath, |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 68 | &modem_info_)) {} |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 69 | virtual void SetUp(); |
| 70 | virtual void TearDown(); |
| 71 | |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 72 | void ReplaceSingletons() { |
| 73 | modem_->rtnl_handler_ = &rtnl_handler_; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 74 | } |
| 75 | |
| 76 | protected: |
| 77 | class TestProxyFactory : public ProxyFactory { |
| 78 | public: |
Paul Stewart | 7355ce1 | 2011-09-02 10:47:01 -0700 | [diff] [blame] | 79 | explicit TestProxyFactory(ModemTest *test) : test_(test) {} |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 80 | |
| 81 | virtual DBusPropertiesProxyInterface *CreateDBusPropertiesProxy( |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 82 | const string &/*path*/, |
| 83 | const string &/*service*/) { |
Darin Petkov | 3b29233 | 2011-07-28 14:17:24 -0700 | [diff] [blame] | 84 | return test_->proxy_.release(); |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 85 | } |
| 86 | |
| 87 | private: |
Darin Petkov | 3b29233 | 2011-07-28 14:17:24 -0700 | [diff] [blame] | 88 | ModemTest *test_; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 89 | }; |
| 90 | |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 91 | EventDispatcher dispatcher_; |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 92 | MockModemInfo modem_info_; |
| 93 | MockDeviceInfo device_info_; |
Darin Petkov | 3b29233 | 2011-07-28 14:17:24 -0700 | [diff] [blame] | 94 | scoped_ptr<MockDBusPropertiesProxy> proxy_; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 95 | TestProxyFactory proxy_factory_; |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 96 | scoped_ptr<StrictModem> modem_; |
| 97 | MockRTNLHandler rtnl_handler_; |
| 98 | ByteString expected_address_; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 99 | }; |
| 100 | |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 101 | void ModemTest::SetUp() { |
Jason Glasgow | e908949 | 2012-02-23 17:57:37 -0500 | [diff] [blame] | 102 | EXPECT_EQ(kOwner, modem_->owner_); |
Jason Glasgow | a585fc3 | 2012-06-06 11:04:09 -0400 | [diff] [blame] | 103 | EXPECT_EQ(kService, modem_->service_); |
Jason Glasgow | e908949 | 2012-02-23 17:57:37 -0500 | [diff] [blame] | 104 | EXPECT_EQ(kPath, modem_->path_); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 105 | ReplaceSingletons(); |
| 106 | expected_address_ = ByteString(kAddress, arraysize(kAddress)); |
| 107 | |
| 108 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(kLinkName)). |
| 109 | WillRepeatedly(Return(kTestInterfaceIndex)); |
| 110 | |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 111 | EXPECT_CALL(*modem_info_.mock_manager(), device_info()) |
| 112 | .WillRepeatedly(Return(&device_info_)); |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 113 | } |
| 114 | |
| 115 | void ModemTest::TearDown() { |
Jason Glasgow | e908949 | 2012-02-23 17:57:37 -0500 | [diff] [blame] | 116 | modem_.reset(); |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 117 | } |
| 118 | |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 119 | TEST_F(ModemTest, PendingDevicePropertiesAndCreate) { |
| 120 | static const char kSentinel[] = "sentinel"; |
| 121 | static const uint32 kSentinelValue = 17; |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 122 | |
Ben Chan | 876efd3 | 2012-09-28 15:25:13 -0700 | [diff] [blame] | 123 | DBusInterfaceToProperties properties; |
| 124 | properties[MM_MODEM_INTERFACE][kSentinel].writer().append_uint32( |
| 125 | kSentinelValue); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 126 | |
| 127 | EXPECT_CALL(*modem_, GetLinkName(_, _)).WillRepeatedly(DoAll( |
| 128 | SetArgumentPointee<1>(string(kLinkName)), |
| 129 | Return(true))); |
| 130 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(StrEq(kLinkName))). |
| 131 | WillRepeatedly(Return(kTestInterfaceIndex)); |
| 132 | |
| 133 | // The first time we call CreateDeviceFromModemProperties, |
| 134 | // GetMACAddress will fail. |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 135 | EXPECT_CALL(device_info_, GetMACAddress(kTestInterfaceIndex, _)). |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 136 | WillOnce(Return(false)); |
Jason Glasgow | 4c0724a | 2012-04-17 15:47:40 -0400 | [diff] [blame] | 137 | EXPECT_CALL(*modem_, GetModemInterface()). |
| 138 | WillRepeatedly(Return(MM_MODEM_INTERFACE)); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 139 | modem_->CreateDeviceFromModemProperties(properties); |
Jason Glasgow | e908949 | 2012-02-23 17:57:37 -0500 | [diff] [blame] | 140 | EXPECT_FALSE(modem_->device_.get()); |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 141 | |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 142 | // On the second time, we allow GetMACAddress to succeed. Now we |
| 143 | // expect a device to be built |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 144 | EXPECT_CALL(device_info_, GetMACAddress(kTestInterfaceIndex, _)). |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 145 | WillOnce(DoAll(SetArgumentPointee<1>(expected_address_), |
| 146 | Return(true))); |
| 147 | |
| 148 | // modem will take ownership |
Darin Petkov | a0a0efe | 2012-06-27 12:50:01 +0200 | [diff] [blame] | 149 | MockCellular *cellular = new MockCellular( |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 150 | &modem_info_, |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 151 | kLinkName, |
| 152 | kAddressAsString, |
| 153 | kTestInterfaceIndex, |
Ben Chan | 3ecdf82 | 2012-08-06 12:29:23 -0700 | [diff] [blame] | 154 | Cellular::kTypeCDMA, |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 155 | kOwner, |
Jason Glasgow | a585fc3 | 2012-06-06 11:04:09 -0400 | [diff] [blame] | 156 | kService, |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 157 | kPath, |
Ben Chan | 3ecdf82 | 2012-08-06 12:29:23 -0700 | [diff] [blame] | 158 | ProxyFactory::GetInstance()); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 159 | |
| 160 | EXPECT_CALL(*modem_, |
| 161 | ConstructCellular(StrEq(kLinkName), |
| 162 | StrEq(kAddressAsString), |
| 163 | kTestInterfaceIndex)). |
| 164 | WillOnce(Return(cellular)); |
| 165 | |
Jason Glasgow | 4c0724a | 2012-04-17 15:47:40 -0400 | [diff] [blame] | 166 | EXPECT_CALL(*cellular, OnDBusPropertiesChanged( |
| 167 | _, |
| 168 | HasDBusPropertyWithValueU32(kSentinel, kSentinelValue), |
| 169 | _)); |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 170 | EXPECT_CALL(device_info_, RegisterDevice(_)); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 171 | modem_->OnDeviceInfoAvailable(kLinkName); |
| 172 | |
| 173 | EXPECT_TRUE(modem_->device_.get()); |
Darin Petkov | a0a0efe | 2012-06-27 12:50:01 +0200 | [diff] [blame] | 174 | |
mukesh agrawal | 9da0777 | 2013-05-15 14:15:17 -0700 | [diff] [blame] | 175 | // Add expectations for the eventual |modem_| destruction. |
Darin Petkov | a0a0efe | 2012-06-27 12:50:01 +0200 | [diff] [blame] | 176 | EXPECT_CALL(*cellular, DestroyService()); |
Prathmesh Prabhu | 27526f1 | 2013-03-25 19:42:18 -0700 | [diff] [blame] | 177 | EXPECT_CALL(device_info_, DeregisterDevice(_)); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 178 | } |
| 179 | |
| 180 | TEST_F(ModemTest, EarlyDeviceProperties) { |
| 181 | // OnDeviceInfoAvailable called before |
| 182 | // CreateDeviceFromModemProperties: Do nothing |
| 183 | modem_->OnDeviceInfoAvailable(kLinkName); |
| 184 | EXPECT_FALSE(modem_->device_.get()); |
| 185 | } |
| 186 | |
| 187 | TEST_F(ModemTest, CreateDeviceEarlyFailures) { |
Ben Chan | 876efd3 | 2012-09-28 15:25:13 -0700 | [diff] [blame] | 188 | DBusInterfaceToProperties properties; |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 189 | |
| 190 | EXPECT_CALL(*modem_, ConstructCellular(_, _, _)).Times(0); |
Ben Chan | 876efd3 | 2012-09-28 15:25:13 -0700 | [diff] [blame] | 191 | EXPECT_CALL(*modem_, GetModemInterface()). |
| 192 | WillRepeatedly(Return(MM_MODEM_INTERFACE)); |
| 193 | |
| 194 | // No modem interface properties: no device created |
| 195 | modem_->CreateDeviceFromModemProperties(properties); |
| 196 | EXPECT_FALSE(modem_->device_.get()); |
| 197 | |
| 198 | properties[MM_MODEM_INTERFACE] = DBusPropertiesMap(); |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 199 | |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 200 | // Link name, but no ifindex: no device created |
| 201 | EXPECT_CALL(*modem_, GetLinkName(_, _)).WillOnce(DoAll( |
| 202 | SetArgumentPointee<1>(string(kLinkName)), |
| 203 | Return(true))); |
| 204 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(StrEq(kLinkName))).WillOnce( |
| 205 | Return(-1)); |
| 206 | modem_->CreateDeviceFromModemProperties(properties); |
Jason Glasgow | e908949 | 2012-02-23 17:57:37 -0500 | [diff] [blame] | 207 | EXPECT_FALSE(modem_->device_.get()); |
mukesh agrawal | 12533ad | 2013-08-01 15:43:23 -0700 | [diff] [blame] | 208 | |
| 209 | // The params are good, but the device is blacklisted. |
| 210 | EXPECT_CALL(*modem_, GetLinkName(_, _)).WillOnce(DoAll( |
| 211 | SetArgumentPointee<1>(string(kLinkName)), |
| 212 | Return(true))); |
| 213 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(StrEq(kLinkName))) |
| 214 | .WillOnce(Return(kTestInterfaceIndex)); |
| 215 | EXPECT_CALL(device_info_, GetMACAddress(kTestInterfaceIndex, _)) |
| 216 | .WillOnce(DoAll(SetArgumentPointee<1>(expected_address_), |
| 217 | Return(true))); |
| 218 | EXPECT_CALL(device_info_, IsDeviceBlackListed(kLinkName)) |
| 219 | .WillRepeatedly(Return(true)); |
| 220 | modem_->CreateDeviceFromModemProperties(properties); |
| 221 | EXPECT_FALSE(modem_->device_.get()); |
| 222 | |
| 223 | // No link name: see CreateDevicePPP. |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 224 | } |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 225 | |
mukesh agrawal | 9da0777 | 2013-05-15 14:15:17 -0700 | [diff] [blame] | 226 | TEST_F(ModemTest, CreateDevicePPP) { |
| 227 | DBusInterfaceToProperties properties; |
| 228 | properties[MM_MODEM_INTERFACE] = DBusPropertiesMap(); |
| 229 | |
| 230 | string dev_name( |
| 231 | base::StringPrintf(Modem::kFakeDevNameFormat, Modem::fake_dev_serial_)); |
| 232 | |
| 233 | // |modem_| will take ownership. |
| 234 | MockCellular *cellular = new MockCellular( |
| 235 | &modem_info_, |
| 236 | dev_name, |
| 237 | Modem::kFakeDevAddress, |
| 238 | Modem::kFakeDevInterfaceIndex, |
| 239 | Cellular::kTypeUniversal, |
| 240 | kOwner, |
| 241 | kService, |
| 242 | kPath, |
| 243 | ProxyFactory::GetInstance()); |
| 244 | |
| 245 | EXPECT_CALL(*modem_, GetModemInterface()). |
| 246 | WillRepeatedly(Return(MM_MODEM_INTERFACE)); |
| 247 | // No link name: assumed to be a PPP dongle. |
| 248 | EXPECT_CALL(*modem_, GetLinkName(_, _)).WillOnce(Return(false)); |
| 249 | EXPECT_CALL(*modem_, |
| 250 | ConstructCellular(dev_name, |
| 251 | StrEq(Modem::kFakeDevAddress), |
| 252 | Modem::kFakeDevInterfaceIndex)). |
| 253 | WillOnce(Return(cellular)); |
| 254 | EXPECT_CALL(device_info_, RegisterDevice(_)); |
| 255 | |
| 256 | modem_->CreateDeviceFromModemProperties(properties); |
| 257 | EXPECT_TRUE(modem_->device_.get()); |
| 258 | |
| 259 | // Add expectations for the eventual |modem_| destruction. |
| 260 | EXPECT_CALL(*cellular, DestroyService()); |
| 261 | EXPECT_CALL(device_info_, DeregisterDevice(_)); |
| 262 | } |
| 263 | |
mukesh agrawal | 12533ad | 2013-08-01 15:43:23 -0700 | [diff] [blame] | 264 | TEST_F(ModemTest, GetDeviceParams) { |
| 265 | string mac_address; |
| 266 | int interface_index = 2; |
| 267 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(_)).WillOnce(Return(-1)); |
| 268 | EXPECT_CALL(device_info_, GetMACAddress(_, _)).Times(AnyNumber()) |
| 269 | .WillRepeatedly(Return(false)); |
| 270 | EXPECT_FALSE(modem_->GetDeviceParams(&mac_address, &interface_index)); |
| 271 | EXPECT_EQ(-1, interface_index); |
| 272 | |
| 273 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(_)).WillOnce(Return(-2)); |
| 274 | EXPECT_CALL(device_info_, GetMACAddress(_, _)).Times(AnyNumber()) |
| 275 | .WillRepeatedly(Return(false)); |
| 276 | EXPECT_FALSE(modem_->GetDeviceParams(&mac_address, &interface_index)); |
| 277 | EXPECT_EQ(-2, interface_index); |
| 278 | |
| 279 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(_)).WillOnce(Return(1)); |
| 280 | EXPECT_CALL(device_info_, GetMACAddress(_, _)).WillOnce(Return(false)); |
| 281 | EXPECT_FALSE(modem_->GetDeviceParams(&mac_address, &interface_index)); |
| 282 | EXPECT_EQ(1, interface_index); |
| 283 | |
| 284 | EXPECT_CALL(rtnl_handler_, GetInterfaceIndex(_)).WillOnce(Return(2)); |
| 285 | EXPECT_CALL(device_info_, GetMACAddress(2, _)). |
| 286 | WillOnce(DoAll(SetArgumentPointee<1>(expected_address_), |
| 287 | Return(true))); |
| 288 | EXPECT_TRUE(modem_->GetDeviceParams(&mac_address, &interface_index)); |
| 289 | EXPECT_EQ(2, interface_index); |
| 290 | EXPECT_EQ(kAddressAsString, mac_address); |
| 291 | |
| 292 | } |
| 293 | |
David Rochberg | fa1d31d | 2012-03-20 10:38:07 -0400 | [diff] [blame] | 294 | TEST_F(ModemTest, RejectPPPModem) { |
| 295 | // TODO(rochberg): Port this to ModemClassic |
Darin Petkov | e0a312e | 2011-07-20 13:45:28 -0700 | [diff] [blame] | 296 | } |
| 297 | |
| 298 | } // namespace shill |