mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Chris Masone | 8a7b8be | 2011-07-22 12:43:37 -0700 | [diff] [blame] | 5 | #include "shill/dhcp_config.h" |
| 6 | |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 7 | #include <base/bind.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 8 | #include <base/file_util.h> |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 9 | #include <base/scoped_temp_dir.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 10 | #include <base/stringprintf.h> |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 11 | #include <chromeos/dbus/service_constants.h> |
Chris Masone | 8a7b8be | 2011-07-22 12:43:37 -0700 | [diff] [blame] | 12 | #include <gtest/gtest.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 13 | |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 14 | #include "shill/dbus_adaptor.h" |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 15 | #include "shill/dhcp_provider.h" |
Paul Stewart | 26b327e | 2011-10-19 11:38:09 -0700 | [diff] [blame] | 16 | #include "shill/event_dispatcher.h" |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 17 | #include "shill/mock_control.h" |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 18 | #include "shill/mock_dhcp_proxy.h" |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 19 | #include "shill/mock_glib.h" |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 20 | #include "shill/property_store_unittest.h" |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 21 | #include "shill/proxy_factory.h" |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 22 | |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 23 | using base::Bind; |
| 24 | using base::Unretained; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 25 | using std::string; |
| 26 | using std::vector; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 27 | using testing::_; |
| 28 | using testing::Return; |
| 29 | using testing::SetArgumentPointee; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 30 | using testing::Test; |
| 31 | |
| 32 | namespace shill { |
| 33 | |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 34 | namespace { |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 35 | const char kDeviceName[] = "eth0"; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 36 | const char kHostName[] = "hostname"; |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 37 | const char kLeaseFileSuffix[] = "leasefilesuffix"; |
| 38 | const bool kArpGateway = true; |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 39 | } // namespace {} |
| 40 | |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 41 | class DHCPConfigTest : public PropertyStoreTest { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 42 | public: |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 43 | DHCPConfigTest() |
Darin Petkov | f65e928 | 2011-06-21 14:29:56 -0700 | [diff] [blame] | 44 | : proxy_(new MockDHCPProxy()), |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 45 | proxy_factory_(this), |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 46 | config_(new DHCPConfig(&control_, |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 47 | dispatcher(), |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 48 | DHCPProvider::GetInstance(), |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 49 | kDeviceName, |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 50 | kHostName, |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 51 | kLeaseFileSuffix, |
| 52 | kArpGateway, |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 53 | glib())) {} |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 54 | |
| 55 | virtual void SetUp() { |
Darin Petkov | ab565bb | 2011-10-06 02:55:51 -0700 | [diff] [blame] | 56 | config_->proxy_factory_ = &proxy_factory_; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 57 | } |
| 58 | |
| 59 | virtual void TearDown() { |
Darin Petkov | ab565bb | 2011-10-06 02:55:51 -0700 | [diff] [blame] | 60 | config_->proxy_factory_ = NULL; |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 61 | } |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 62 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 63 | DHCPConfigRefPtr CreateRunningConfig(const string &hostname, |
| 64 | const string &lease_suffix, |
| 65 | bool arp_gateway); |
| 66 | void StopRunningConfigAndExpect(DHCPConfigRefPtr config, |
| 67 | bool lease_file_exists); |
| 68 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 69 | protected: |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 70 | class TestProxyFactory : public ProxyFactory { |
| 71 | public: |
Paul Stewart | 7355ce1 | 2011-09-02 10:47:01 -0700 | [diff] [blame] | 72 | explicit TestProxyFactory(DHCPConfigTest *test) : test_(test) {} |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 73 | |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 74 | virtual DHCPProxyInterface *CreateDHCPProxy(const string &/*service*/) { |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 75 | return test_->proxy_.release(); |
| 76 | } |
| 77 | |
| 78 | private: |
| 79 | DHCPConfigTest *test_; |
| 80 | }; |
| 81 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 82 | static const int kPID; |
| 83 | static const unsigned int kTag; |
| 84 | |
| 85 | FilePath lease_file_; |
| 86 | FilePath pid_file_; |
| 87 | ScopedTempDir temp_dir_; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 88 | scoped_ptr<MockDHCPProxy> proxy_; |
| 89 | TestProxyFactory proxy_factory_; |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 90 | MockControl control_; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 91 | DHCPConfigRefPtr config_; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 92 | }; |
| 93 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 94 | const int DHCPConfigTest::kPID = 123456; |
| 95 | const unsigned int DHCPConfigTest::kTag = 77; |
| 96 | |
| 97 | DHCPConfigRefPtr DHCPConfigTest::CreateRunningConfig(const string &hostname, |
| 98 | const string &lease_suffix, |
| 99 | bool arp_gateway) { |
| 100 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 101 | dispatcher(), |
| 102 | DHCPProvider::GetInstance(), |
| 103 | kDeviceName, |
| 104 | hostname, |
| 105 | lease_suffix, |
| 106 | arp_gateway, |
| 107 | glib())); |
| 108 | EXPECT_CALL(*glib(), SpawnAsync(_, _, _, _, _, _, _, _)) |
| 109 | .WillOnce(DoAll(SetArgumentPointee<6>(kPID), Return(true))); |
| 110 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID, _, _)).WillOnce(Return(kTag)); |
| 111 | EXPECT_TRUE(config->Start()); |
| 112 | EXPECT_EQ(kPID, config->pid_); |
| 113 | EXPECT_EQ(config.get(), DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 114 | EXPECT_EQ(kTag, config->child_watch_tag_); |
| 115 | |
| 116 | EXPECT_TRUE(temp_dir_.CreateUniqueTempDir()); |
| 117 | config->root_ = temp_dir_.path(); |
| 118 | FilePath varrun = temp_dir_.path().Append("var/run"); |
| 119 | EXPECT_TRUE(file_util::CreateDirectory(varrun)); |
| 120 | pid_file_ = varrun.Append(base::StringPrintf("dhcpcd-%s.pid", kDeviceName)); |
| 121 | FilePath varlib = temp_dir_.path().Append("var/lib/dhcpcd"); |
| 122 | EXPECT_TRUE(file_util::CreateDirectory(varlib)); |
| 123 | lease_file_ = |
| 124 | varlib.Append(base::StringPrintf("dhcpcd-%s.lease", kDeviceName)); |
| 125 | EXPECT_EQ(0, file_util::WriteFile(pid_file_, "", 0)); |
| 126 | EXPECT_EQ(0, file_util::WriteFile(lease_file_, "", 0)); |
| 127 | EXPECT_TRUE(file_util::PathExists(pid_file_)); |
| 128 | EXPECT_TRUE(file_util::PathExists(lease_file_)); |
| 129 | |
| 130 | return config; |
| 131 | } |
| 132 | |
| 133 | void DHCPConfigTest::StopRunningConfigAndExpect(DHCPConfigRefPtr config, |
| 134 | bool lease_file_exists) { |
| 135 | EXPECT_CALL(*glib(), SpawnClosePID(kPID)).Times(1); |
| 136 | DHCPConfig::ChildWatchCallback(kPID, 0, config.get()); |
| 137 | EXPECT_EQ(NULL, DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 138 | |
| 139 | EXPECT_FALSE(file_util::PathExists(pid_file_)); |
| 140 | EXPECT_EQ(lease_file_exists, file_util::PathExists(lease_file_)); |
| 141 | } |
| 142 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 143 | TEST_F(DHCPConfigTest, GetIPv4AddressString) { |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 144 | EXPECT_EQ("255.255.255.255", config_->GetIPv4AddressString(0xffffffff)); |
| 145 | EXPECT_EQ("0.0.0.0", config_->GetIPv4AddressString(0)); |
| 146 | EXPECT_EQ("1.2.3.4", config_->GetIPv4AddressString(0x04030201)); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 147 | } |
| 148 | |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 149 | TEST_F(DHCPConfigTest, InitProxy) { |
| 150 | static const char kService[] = ":1.200"; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 151 | EXPECT_TRUE(proxy_.get()); |
| 152 | EXPECT_FALSE(config_->proxy_.get()); |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 153 | config_->InitProxy(kService); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 154 | EXPECT_FALSE(proxy_.get()); |
| 155 | EXPECT_TRUE(config_->proxy_.get()); |
| 156 | |
| 157 | config_->InitProxy(kService); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 158 | } |
| 159 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 160 | TEST_F(DHCPConfigTest, ParseConfiguration) { |
| 161 | DHCPConfig::Configuration conf; |
| 162 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 163 | 0x01020304); |
| 164 | conf[DHCPConfig::kConfigurationKeySubnetCIDR].writer().append_byte( |
| 165 | 16); |
| 166 | conf[DHCPConfig::kConfigurationKeyBroadcastAddress].writer().append_uint32( |
| 167 | 0x10203040); |
| 168 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 169 | vector<unsigned int> routers; |
| 170 | routers.push_back(0x02040608); |
| 171 | routers.push_back(0x03050709); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 172 | DBus::MessageIter writer = |
| 173 | conf[DHCPConfig::kConfigurationKeyRouters].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 174 | writer << routers; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 175 | } |
| 176 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 177 | vector<unsigned int> dns; |
| 178 | dns.push_back(0x09070503); |
| 179 | dns.push_back(0x08060402); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 180 | DBus::MessageIter writer = conf[DHCPConfig::kConfigurationKeyDNS].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 181 | writer << dns; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 182 | } |
| 183 | conf[DHCPConfig::kConfigurationKeyDomainName].writer().append_string( |
| 184 | "domain-name"); |
| 185 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 186 | vector<string> search; |
| 187 | search.push_back("foo.com"); |
| 188 | search.push_back("bar.com"); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 189 | DBus::MessageIter writer = |
| 190 | conf[DHCPConfig::kConfigurationKeyDomainSearch].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 191 | writer << search; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 192 | } |
| 193 | conf[DHCPConfig::kConfigurationKeyMTU].writer().append_uint16(600); |
| 194 | conf["UnknownKey"] = DBus::Variant(); |
| 195 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 196 | IPConfig::Properties properties; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 197 | ASSERT_TRUE(config_->ParseConfiguration(conf, &properties)); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 198 | EXPECT_EQ("4.3.2.1", properties.address); |
Paul Stewart | 48100b0 | 2012-03-19 07:53:52 -0700 | [diff] [blame] | 199 | EXPECT_EQ(16, properties.subnet_prefix); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 200 | EXPECT_EQ("64.48.32.16", properties.broadcast_address); |
| 201 | EXPECT_EQ("8.6.4.2", properties.gateway); |
| 202 | ASSERT_EQ(2, properties.dns_servers.size()); |
| 203 | EXPECT_EQ("3.5.7.9", properties.dns_servers[0]); |
| 204 | EXPECT_EQ("2.4.6.8", properties.dns_servers[1]); |
| 205 | EXPECT_EQ("domain-name", properties.domain_name); |
| 206 | ASSERT_EQ(2, properties.domain_search.size()); |
| 207 | EXPECT_EQ("foo.com", properties.domain_search[0]); |
| 208 | EXPECT_EQ("bar.com", properties.domain_search[1]); |
| 209 | EXPECT_EQ(600, properties.mtu); |
| 210 | } |
| 211 | |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 212 | TEST_F(DHCPConfigTest, StartFail) { |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 213 | EXPECT_CALL(*glib(), SpawnAsync(_, _, _, _, _, _, _, _)) |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 214 | .WillOnce(Return(false)); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 215 | EXPECT_CALL(*glib(), ChildWatchAdd(_, _, _)).Times(0); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 216 | EXPECT_FALSE(config_->Start()); |
| 217 | EXPECT_EQ(0, config_->pid_); |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 218 | } |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 219 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 220 | MATCHER_P3(IsDHCPCDArgs, has_hostname, has_arp_gateway, has_lease_suffix, "") { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 221 | if (string(arg[0]) != "/sbin/dhcpcd" || |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 222 | string(arg[1]) != "-B") { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 223 | return false; |
| 224 | } |
| 225 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 226 | int end_offset = 2; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 227 | if (has_hostname) { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 228 | if (string(arg[end_offset]) != "-h" || |
| 229 | string(arg[end_offset + 1]) != kHostName) { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 230 | return false; |
| 231 | } |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 232 | end_offset += 2; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 233 | } |
| 234 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 235 | if (has_arp_gateway) { |
| 236 | if (string(arg[end_offset]) != "-R") |
| 237 | return false; |
| 238 | ++end_offset; |
| 239 | } |
| 240 | |
| 241 | string device_arg = has_lease_suffix ? |
| 242 | string(kDeviceName) + "=" + string(kLeaseFileSuffix) : kDeviceName; |
| 243 | return string(arg[end_offset]) == device_arg && arg[end_offset + 1] == NULL; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 244 | } |
| 245 | |
| 246 | TEST_F(DHCPConfigTest, StartWithHostname) { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 247 | EXPECT_CALL(*glib(), |
| 248 | SpawnAsync(_, IsDHCPCDArgs(true, true, true), _, _, _, _, _, _)) |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 249 | .WillOnce(Return(false)); |
| 250 | EXPECT_FALSE(config_->Start()); |
| 251 | } |
| 252 | |
| 253 | TEST_F(DHCPConfigTest, StartWithoutHostname) { |
| 254 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 255 | dispatcher(), |
| 256 | DHCPProvider::GetInstance(), |
| 257 | kDeviceName, |
| 258 | "", |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 259 | kLeaseFileSuffix, |
| 260 | kArpGateway, |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 261 | glib())); |
| 262 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 263 | EXPECT_CALL(*glib(), |
| 264 | SpawnAsync(_, IsDHCPCDArgs(false, true, true), _, _, _, _, _, _)) |
| 265 | .WillOnce(Return(false)); |
| 266 | EXPECT_FALSE(config->Start()); |
| 267 | } |
| 268 | |
| 269 | TEST_F(DHCPConfigTest, StartWithoutArpGateway) { |
| 270 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 271 | dispatcher(), |
| 272 | DHCPProvider::GetInstance(), |
| 273 | kDeviceName, |
| 274 | kHostName, |
| 275 | kLeaseFileSuffix, |
| 276 | false, |
| 277 | glib())); |
| 278 | |
| 279 | EXPECT_CALL(*glib(), |
| 280 | SpawnAsync(_, IsDHCPCDArgs(true, false, true), _, _, _, _, _, _)) |
| 281 | .WillOnce(Return(false)); |
| 282 | EXPECT_FALSE(config->Start()); |
| 283 | } |
| 284 | |
| 285 | TEST_F(DHCPConfigTest, StartWithoutLeaseSuffix) { |
| 286 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 287 | dispatcher(), |
| 288 | DHCPProvider::GetInstance(), |
| 289 | kDeviceName, |
| 290 | kHostName, |
| 291 | kDeviceName, |
| 292 | kArpGateway, |
| 293 | glib())); |
| 294 | |
| 295 | EXPECT_CALL(*glib(), |
| 296 | SpawnAsync(_, IsDHCPCDArgs(true, true, false), _, _, _, _, _, _)) |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 297 | .WillOnce(Return(false)); |
| 298 | EXPECT_FALSE(config->Start()); |
| 299 | } |
| 300 | |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 301 | namespace { |
| 302 | |
| 303 | class UpdateCallbackTest { |
| 304 | public: |
| 305 | UpdateCallbackTest(const string &message, |
Chris Masone | 2b10554 | 2011-06-22 10:58:09 -0700 | [diff] [blame] | 306 | const IPConfigRefPtr &ipconfig, |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 307 | bool success) |
| 308 | : message_(message), |
| 309 | ipconfig_(ipconfig), |
| 310 | success_(success), |
| 311 | called_(false) {} |
| 312 | |
Chris Masone | 2b10554 | 2011-06-22 10:58:09 -0700 | [diff] [blame] | 313 | void Callback(const IPConfigRefPtr &ipconfig, bool success) { |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 314 | called_ = true; |
| 315 | EXPECT_EQ(ipconfig_.get(), ipconfig.get()) << message_; |
| 316 | EXPECT_EQ(success_, success) << message_; |
| 317 | } |
| 318 | |
| 319 | bool called() const { return called_; } |
| 320 | |
| 321 | private: |
| 322 | const string message_; |
| 323 | IPConfigRefPtr ipconfig_; |
| 324 | bool success_; |
| 325 | bool called_; |
| 326 | }; |
| 327 | |
| 328 | } // namespace {} |
| 329 | |
| 330 | TEST_F(DHCPConfigTest, ProcessEventSignalFail) { |
| 331 | DHCPConfig::Configuration conf; |
| 332 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 333 | 0x01020304); |
| 334 | UpdateCallbackTest callback_test(DHCPConfig::kReasonFail, config_, false); |
| 335 | config_->RegisterUpdateCallback( |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 336 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 337 | config_->ProcessEventSignal(DHCPConfig::kReasonFail, conf); |
| 338 | EXPECT_TRUE(callback_test.called()); |
| 339 | EXPECT_TRUE(config_->properties().address.empty()); |
| 340 | } |
| 341 | |
| 342 | TEST_F(DHCPConfigTest, ProcessEventSignalSuccess) { |
| 343 | static const char * const kReasons[] = { |
| 344 | DHCPConfig::kReasonBound, |
| 345 | DHCPConfig::kReasonRebind, |
| 346 | DHCPConfig::kReasonReboot, |
| 347 | DHCPConfig::kReasonRenew |
| 348 | }; |
| 349 | for (size_t r = 0; r < arraysize(kReasons); r++) { |
| 350 | DHCPConfig::Configuration conf; |
| 351 | string message = string(kReasons[r]) + " failed"; |
| 352 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32(r); |
| 353 | UpdateCallbackTest callback_test(message, config_, true); |
| 354 | config_->RegisterUpdateCallback( |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 355 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 356 | config_->ProcessEventSignal(kReasons[r], conf); |
| 357 | EXPECT_TRUE(callback_test.called()) << message; |
Paul Stewart | 8322440 | 2011-11-30 14:52:30 -0800 | [diff] [blame] | 358 | EXPECT_EQ(base::StringPrintf("%zu.0.0.0", r), config_->properties().address) |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 359 | << message; |
| 360 | } |
| 361 | } |
| 362 | |
| 363 | TEST_F(DHCPConfigTest, ProcessEventSignalUnknown) { |
| 364 | DHCPConfig::Configuration conf; |
| 365 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 366 | 0x01020304); |
| 367 | static const char kReasonUnknown[] = "UNKNOWN_REASON"; |
| 368 | UpdateCallbackTest callback_test(kReasonUnknown, config_, false); |
| 369 | config_->RegisterUpdateCallback( |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 370 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 371 | config_->ProcessEventSignal(kReasonUnknown, conf); |
| 372 | EXPECT_FALSE(callback_test.called()); |
| 373 | EXPECT_TRUE(config_->properties().address.empty()); |
| 374 | } |
| 375 | |
| 376 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 377 | TEST_F(DHCPConfigTest, ReleaseIP) { |
| 378 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 379 | EXPECT_CALL(*proxy_, Release(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 380 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 381 | EXPECT_TRUE(config_->ReleaseIP()); |
| 382 | config_->pid_ = 0; |
| 383 | } |
| 384 | |
| 385 | TEST_F(DHCPConfigTest, RenewIP) { |
| 386 | config_->pid_ = 456; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 387 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 388 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 389 | EXPECT_TRUE(config_->RenewIP()); |
| 390 | config_->pid_ = 0; |
| 391 | } |
| 392 | |
| 393 | TEST_F(DHCPConfigTest, RequestIP) { |
| 394 | config_->pid_ = 567; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 395 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 396 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 397 | EXPECT_TRUE(config_->RenewIP()); |
| 398 | config_->pid_ = 0; |
| 399 | } |
| 400 | |
| 401 | TEST_F(DHCPConfigTest, Restart) { |
| 402 | const int kPID1 = 1 << 17; // Ensure unknown positive PID. |
| 403 | const int kPID2 = 987; |
| 404 | const unsigned int kTag1 = 11; |
| 405 | const unsigned int kTag2 = 22; |
| 406 | config_->pid_ = kPID1; |
| 407 | config_->child_watch_tag_ = kTag1; |
| 408 | DHCPProvider::GetInstance()->BindPID(kPID1, config_); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 409 | EXPECT_CALL(*glib(), SourceRemove(kTag1)).WillOnce(Return(true)); |
| 410 | EXPECT_CALL(*glib(), SpawnClosePID(kPID1)).Times(1); |
| 411 | EXPECT_CALL(*glib(), SpawnAsync(_, _, _, _, _, _, _, _)) |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 412 | .WillOnce(DoAll(SetArgumentPointee<6>(kPID2), Return(true))); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 413 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID2, _, _)).WillOnce(Return(kTag2)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 414 | EXPECT_TRUE(config_->Restart()); |
| 415 | EXPECT_EQ(kPID2, config_->pid_); |
| 416 | EXPECT_EQ(config_.get(), DHCPProvider::GetInstance()->GetConfig(kPID2).get()); |
| 417 | EXPECT_EQ(kTag2, config_->child_watch_tag_); |
| 418 | DHCPProvider::GetInstance()->UnbindPID(kPID2); |
| 419 | config_->pid_ = 0; |
| 420 | config_->child_watch_tag_ = 0; |
| 421 | } |
| 422 | |
| 423 | TEST_F(DHCPConfigTest, RestartNoClient) { |
| 424 | const int kPID = 777; |
| 425 | const unsigned int kTag = 66; |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 426 | EXPECT_CALL(*glib(), SourceRemove(_)).Times(0); |
| 427 | EXPECT_CALL(*glib(), SpawnClosePID(_)).Times(0); |
| 428 | EXPECT_CALL(*glib(), SpawnAsync(_, _, _, _, _, _, _, _)) |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 429 | .WillOnce(DoAll(SetArgumentPointee<6>(kPID), Return(true))); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 430 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID, _, _)).WillOnce(Return(kTag)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 431 | EXPECT_TRUE(config_->Restart()); |
| 432 | EXPECT_EQ(kPID, config_->pid_); |
| 433 | EXPECT_EQ(config_.get(), DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 434 | EXPECT_EQ(kTag, config_->child_watch_tag_); |
| 435 | DHCPProvider::GetInstance()->UnbindPID(kPID); |
| 436 | config_->pid_ = 0; |
| 437 | config_->child_watch_tag_ = 0; |
| 438 | } |
| 439 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 440 | TEST_F(DHCPConfigTest, StartSuccessEphemeral) { |
| 441 | DHCPConfigRefPtr config = |
| 442 | CreateRunningConfig(kHostName, kDeviceName, kArpGateway); |
| 443 | StopRunningConfigAndExpect(config, false); |
| 444 | } |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 445 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame^] | 446 | TEST_F(DHCPConfigTest, StartSuccessPersistent) { |
| 447 | DHCPConfigRefPtr config = |
| 448 | CreateRunningConfig(kHostName, kLeaseFileSuffix, kArpGateway); |
| 449 | StopRunningConfigAndExpect(config, true); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 450 | } |
| 451 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 452 | TEST_F(DHCPConfigTest, Stop) { |
| 453 | // Ensure no crashes. |
| 454 | const int kPID = 1 << 17; // Ensure unknown positive PID. |
| 455 | config_->Stop(); |
| 456 | config_->pid_ = kPID; |
| 457 | config_->Stop(); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 458 | EXPECT_CALL(*glib(), SpawnClosePID(kPID)).Times(1); // Invoked by destructor. |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 459 | } |
| 460 | |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 461 | TEST_F(DHCPConfigTest, SetProperty) { |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 462 | ::DBus::Error error; |
| 463 | // Ensure that an attempt to write a R/O property returns InvalidArgs error. |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 464 | EXPECT_FALSE(DBusAdaptor::SetProperty(config_->mutable_store(), |
| 465 | flimflam::kAddressProperty, |
| 466 | PropertyStoreTest::kStringV, |
| 467 | &error)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 468 | EXPECT_EQ(invalid_args(), error.name()); |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 469 | } |
| 470 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 471 | } // namespace shill |