blob: 8b9cde76b79ad66fd4261921a257fede5db416d1 [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Christopher Wiley90be4e32015-10-20 14:55:25 -070017#include <memory>
Christopher Wiley12e894a2016-01-29 11:55:07 -080018#include <set>
19#include <string>
Christopher Wiley90be4e32015-10-20 14:55:25 -070020#include <vector>
21
Christopher Wileyec31a052016-01-25 07:28:51 -080022#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090023#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070024#include <gtest/gtest.h>
25
26#include "aidl.h"
Steven Moreland49585242019-12-18 16:06:49 -080027#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070028#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070029#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090030#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090031#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070034
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090035using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070036using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080037using android::base::StringPrintf;
Christopher Wiley12e894a2016-01-29 11:55:07 -080038using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using std::string;
40using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070042using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090043using testing::internal::CaptureStderr;
44using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045
46namespace android {
47namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070048namespace {
49
50const char kExpectedDepFileContents[] =
51R"(place/for/output/p/IFoo.java : \
52 p/IFoo.aidl
53
54p/IFoo.aidl :
55)";
56
Dan Willemsen93298ee2016-11-10 23:55:55 -080057const char kExpectedNinjaDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60)";
61
Jiyong Parkdf202122019-09-30 20:48:35 +090062const char kExpectedParcelableDeclarationDepFileContents[] =
63 R"( : \
64 p/Foo.aidl
65
66p/Foo.aidl :
67)";
68
69const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080070 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070071 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
Jiyong Parkd4e73c82019-07-24 21:39:15 +090076const char kExpectedJavaParcelableOutputContests[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090077 R"(/*
78 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090079 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080080@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081public class Rect implements android.os.Parcelable
82{
83 // Comment
84
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080085 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090086 public int x = 5;
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
89 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000090 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090091
92 public android.os.ParcelFileDescriptor fd;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090093 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
94 @Override
95 public Rect createFromParcel(android.os.Parcel _aidl_source) {
96 Rect _aidl_out = new Rect();
97 _aidl_out.readFromParcel(_aidl_source);
98 return _aidl_out;
99 }
100 @Override
101 public Rect[] newArray(int _aidl_size) {
102 return new Rect[_aidl_size];
103 }
104 };
105 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
106 {
107 int _aidl_start_pos = _aidl_parcel.dataPosition();
108 _aidl_parcel.writeInt(0);
109 _aidl_parcel.writeInt(x);
110 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900111 if ((fd!=null)) {
112 _aidl_parcel.writeInt(1);
113 fd.writeToParcel(_aidl_parcel, 0);
114 }
115 else {
116 _aidl_parcel.writeInt(0);
117 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900118 int _aidl_end_pos = _aidl_parcel.dataPosition();
119 _aidl_parcel.setDataPosition(_aidl_start_pos);
120 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
121 _aidl_parcel.setDataPosition(_aidl_end_pos);
122 }
123 public final void readFromParcel(android.os.Parcel _aidl_parcel)
124 {
125 int _aidl_start_pos = _aidl_parcel.dataPosition();
126 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900127 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900128 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900129 x = _aidl_parcel.readInt();
130 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
131 y = _aidl_parcel.readInt();
132 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900133 if ((0!=_aidl_parcel.readInt())) {
134 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
135 }
136 else {
137 fd = null;
138 }
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900140 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900141 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
142 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
143 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900144 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
145 }
146 }
147 @Override public int describeContents()
148 {
Jeongik Cha372a8c82018-12-12 16:31:11 +0900149 return 0;
150 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900151}
152)";
153
Devin Moore2f2077a2020-08-28 11:27:53 -0700154// clang-format off
155const char kExpectedCppHeaderOutput[] =
156 R"(#pragma once
157
158#include <binder/IBinder.h>
159#include <binder/IInterface.h>
160#include <binder/Status.h>
161#include <optional>
162#include <utils/String16.h>
163#include <utils/StrongPointer.h>
164#include <vector>
165
166class IFoo : public ::android::IInterface {
167public:
168 DECLARE_META_INTERFACE(Foo)
169 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
170}; // class IFoo
171class IFooDefault : public IFoo {
172public:
173 ::android::IBinder* onAsBinder() override {
174 return nullptr;
175 }
176 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
177 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
178 }
179}; // class IFooDefault
180)";
181// clang-format on
182
Christopher Wileyf8136192016-04-12 14:19:35 -0700183} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700186 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900187 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
188 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700189 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900191 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700192 args.emplace_back("aidl");
193 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700194 for (const string& s : additional_arguments) {
195 args.emplace_back(s);
196 }
197 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900198 args.emplace_back("--preprocessed=" + f);
199 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700200 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900201 args.emplace_back("--include=" + i);
202 }
203 args.emplace_back(path);
204 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900205 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900206 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700207 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900208 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900209
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700210 if (error != nullptr) {
211 *error = actual_error;
212 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900213
214 if (actual_error != AidlError::OK) {
215 return nullptr;
216 }
217
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900218 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900219 EXPECT_EQ(1ul, defined_types.size());
220
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900221 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700222 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700223
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224 Options::Language GetLanguage() { return GetParam(); }
225
Christopher Wiley0522cd52015-10-28 15:39:44 -0700226 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800227 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900228 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900229 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700230};
231
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
233// tests with each of the supported languages as a parameter.
234INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
235 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700236 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700237 [](const testing::TestParamInfo<Options::Language>& info) {
238 return Options::LanguageToString(info.param);
239 });
240
241TEST_P(AidlTest, AcceptMissingPackage) {
242 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, EndsInSingleLineComment) {
246 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700247}
248
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000249TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
250 const string expected_stderr =
251 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
252 const std::string file_contents = "package a; interface IBar {}";
253 CaptureStderr();
254 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
255 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
256}
257
258TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
259 const string expected_stderr =
260 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
261 const std::string file_contents = "package a; interface Bar {}";
262 CaptureStderr();
263 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
264 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
265}
266
267TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
268 const string expected_stderr =
269 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
270 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
274}
275
276TEST_P(AidlTest, EnumRequiresCorrectPath) {
277 const string expected_stderr =
278 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
279 const std::string file_contents = "package a; enum Bar { A, }";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
283}
284
Devin Moore7b8d5c92020-03-17 14:14:08 -0700285TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900286 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700287 io_delegate_.SetFileContents("bar/IBar.aidl",
288 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700289 const string path = "foo/IFoo.aidl";
290 const string contents =
291 "package foo;\n"
292 "import bar.IBar;\n"
293 "interface IFoo { void f(in IBar[] input); }";
294 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700297 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700298}
299
Devin Moore7b8d5c92020-03-17 14:14:08 -0700300TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700301 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700302 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900303}
Devin Moore097a3ab2020-03-11 16:08:44 -0700304
Jiyong Park40782d02020-07-24 19:17:43 +0900305TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700306 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
307 const string expected_ibinder_stderr =
308 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
309 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900312}
313
Jiyong Park40782d02020-07-24 19:17:43 +0900314TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
316 const string expected_stderr =
317 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700318 CaptureStderr();
319 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900321}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322
Jiyong Park40782d02020-07-24 19:17:43 +0900323TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700324 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900325 const string expected_stderr =
326 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700330}
331
Devin Moore7b8d5c92020-03-17 14:14:08 -0700332TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700333 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
334 const string expected_stderr =
335 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700339}
340
Devin Moore7b8d5c92020-03-17 14:14:08 -0700341TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
343 const string expected_stderr =
344 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
345 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800348}
349
Devin Moore2f2077a2020-08-28 11:27:53 -0700350TEST_P(AidlTest, AcceptNullableList) {
351 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
352 const string expected_stderr = "";
353 CaptureStderr();
354 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string method = "package a; interface IFoo { void f(int a, int a); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700365}
366
Jeongik Cha13066da2020-08-06 15:43:19 +0900367TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
368 const string method = "package a; parcelable Foo { int a; String a; }";
369 const string expected_stderr =
370 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
371 CaptureStderr();
372 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700377 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
378 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
379 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700380 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 AidlError error;
386 const string method = "package a; @nullable interface IFoo { int f(); }";
387 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800388 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900389 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Devin Moore7b8d5c92020-03-17 14:14:08 -0700396TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700397 AidlError error;
398 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
399 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800400 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900401 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700402 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700403 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700404 EXPECT_EQ(expected_stderr, GetCapturedStderr());
405 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800406}
407
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700409 AidlError error;
410 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
411 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000412 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900413 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900414 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700415 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
418 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800419}
420
Devin Moore7b8d5c92020-03-17 14:14:08 -0700421TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700422 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000423 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700424 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000425 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900426 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700427 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700428 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000429 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700430 EXPECT_EQ(expected_stderr, GetCapturedStderr());
431 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800432}
433
Jiyong Park40782d02020-07-24 19:17:43 +0900434TEST_P(AidlTest, ParsesNonNullableAnnotation) {
435 auto parse_result =
436 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
437 ASSERT_NE(nullptr, parse_result);
438 const AidlInterface* interface = parse_result->AsInterface();
439 ASSERT_NE(nullptr, interface);
440 ASSERT_FALSE(interface->GetMethods().empty());
441 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900445 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
446 typenames_, GetLanguage());
447 ASSERT_NE(nullptr, parse_result);
448 const AidlInterface* interface = parse_result->AsInterface();
449 ASSERT_NE(nullptr, interface);
450 ASSERT_FALSE(interface->GetMethods().empty());
451 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
452}
453
454TEST_P(AidlTest, ParsesNonUtf8Annotations) {
455 auto parse_result =
456 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
457 ASSERT_NE(nullptr, parse_result);
458 const AidlInterface* interface = parse_result->AsInterface();
459 ASSERT_NE(nullptr, interface);
460 ASSERT_FALSE(interface->GetMethods().empty());
461 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800462}
463
Devin Moore7b8d5c92020-03-17 14:14:08 -0700464TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900465 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
466 typenames_, GetLanguage());
467 ASSERT_NE(nullptr, parse_result);
468 const AidlInterface* interface = parse_result->AsInterface();
469 ASSERT_NE(nullptr, interface);
470 ASSERT_FALSE(interface->GetMethods().empty());
471 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700476 const string expected_stderr =
477 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
478 "\"vintf\"'\n"
479 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
480 "--structured\n";
481 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700482 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700483 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700485 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700486}
487
Devin Moore7b8d5c92020-03-17 14:14:08 -0700488TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700489 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700490 const string expected_stderr =
491 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
492 "--structured\n";
493 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700494 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700495 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700496 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700497 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700501 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700502 const string expected_stderr =
503 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
504 "\"vintf\"'\n";
505 CaptureStderr();
506 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700507 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700509 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510}
511
Devin Moore7b8d5c92020-03-17 14:14:08 -0700512TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700513 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700514 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
515 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700516 ASSERT_EQ(AidlError::OK, error);
517 ASSERT_NE(nullptr, parse_result);
518 const AidlInterface* interface = parse_result->AsInterface();
519 ASSERT_NE(nullptr, interface);
520 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521}
522
Jeongik Cha64783ed2019-06-07 18:30:54 +0900523TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
524 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900525 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
526 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900527 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700528 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900529 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900530 "a/Foo.aidl",
531 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900532
533 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900534 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700535 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900536 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700537 "Parcelable must be defined in AIDL directly.\n";
538 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900539 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700541
542 CaptureStderr();
543 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900545}
546
Jiyong Park43113fb2020-07-20 16:26:19 +0900547TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
548 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
549 @JavaDebug parcelable IFoo { int a; float b; })");
550 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
551 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
552
553 string java_out;
554 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
555 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
556
557 // Other backends shouldn't be bothered
558 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
559 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
560
561 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
562 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
563}
564
565TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
566 {
567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
571 const std::string expected_stderr =
572 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900573 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
574 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
576 }
577
578 {
579 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
580 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
581 CaptureStderr();
582 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
583 const std::string expected_stderr =
584 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
585 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
586 EXPECT_EQ(expected_stderr, GetCapturedStderr());
587 }
588}
589
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900590TEST_P(AidlTest, ParseDescriptorAnnotation) {
591 AidlError error;
592 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
593 typenames_, GetLanguage(), &error, {"--structured"});
594 ASSERT_EQ(AidlError::OK, error);
595 ASSERT_NE(nullptr, parse_result);
596 const AidlInterface* interface = parse_result->AsInterface();
597 ASSERT_NE(nullptr, interface);
598 ASSERT_EQ("IBar", interface->GetDescriptor());
599}
600
Jiyong Park40782d02020-07-24 19:17:43 +0900601TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700602 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700603 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900604}
605
606TEST_P(AidlTest, AcceptsOnewayInterface) {
607 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700608 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700609}
Christopher Wileyef140932015-11-03 09:29:19 -0800610
Devin Moore7b8d5c92020-03-17 14:14:08 -0700611TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700612 const string oneway_method =
613 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700614 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100615}
616
Steven Moreland65297cc2020-04-20 20:17:36 -0700617TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
618 const string oneway_method =
619 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
620 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
621 ASSERT_NE(nullptr, defined);
622 const AidlInterface* iface = defined->AsInterface();
623 ASSERT_NE(nullptr, iface);
624
625 const auto& methods = iface->GetMethods();
626 ASSERT_EQ(1u, methods.size());
627 const auto& method = methods[0];
628 const AidlTypeSpecifier& ret_type = method->GetType();
629
630 // TODO(b/151102494): these annotations should be on the method
631 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
632 ASSERT_TRUE(ret_type.IsHide());
633}
634
Devin Moore7b8d5c92020-03-17 14:14:08 -0700635TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100636 string foo_interface =
637 "package a; /* foo */ interface IFoo {"
638 " /* i */ int i();"
639 " /* j */ @nullable String j();"
640 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
641
Devin Moore7b8d5c92020-03-17 14:14:08 -0700642 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100643 EXPECT_NE(nullptr, parse_result);
644 EXPECT_EQ("/* foo */", parse_result->GetComments());
645
646 const AidlInterface* interface = parse_result->AsInterface();
647 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
648 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
649 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
650}
651
Christopher Wileyef140932015-11-03 09:29:19 -0800652TEST_F(AidlTest, ParsesPreprocessedFile) {
653 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
654 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700655 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900656 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700657 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
658 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800659}
660
661TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
662 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
663 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900664
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700665 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900666 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700667 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
668 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800669}
670
Devin Moore7b8d5c92020-03-17 14:14:08 -0700671TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800672 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
673 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
674 "interface IBar {}");
675 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900676 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900677 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700678 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800679 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900680
Christopher Wiley41544372015-11-03 14:52:29 -0800681 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700682 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
683 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800684 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700685 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900686 ambiguous_type.Resolve(typenames_);
687 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800688}
689
Jiyong Park8f6ec462020-01-19 20:52:47 +0900690// Special case of PreferImportToPreprocessed. Imported type should be preferred
691// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700692TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900693 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
694 io_delegate_.SetFileContents("one/IBar.aidl",
695 "package one; "
696 "interface IBar {}");
697 preprocessed_files_.push_back("preprocessed");
698 import_paths_.emplace("");
699 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700700 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900701 EXPECT_NE(nullptr, parse_result);
702
703 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700704 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
705 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900706 // But if we request just "IBar" we should get our imported one.
707 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
708 ambiguous_type.Resolve(typenames_);
709 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
710}
711
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800712TEST_F(AidlTest, WritePreprocessedFile) {
713 io_delegate_.SetFileContents("p/Outer.aidl",
714 "package p; parcelable Outer.Inner;");
715 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
716 "interface IBar {}");
717
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900718 vector<string> args {
719 "aidl",
720 "--preprocess",
721 "preprocessed",
722 "p/Outer.aidl",
723 "one/IBar.aidl"};
724 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800725 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
726
727 string output;
728 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
729 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
730}
731
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900732TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100733 io_delegate_.SetFileContents(
734 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800735 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100736 "parcelable Rect {\n"
737 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800738 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100739 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800740 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100741 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100742 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
743 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100744 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900745 " ParcelFileDescriptor fd;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100746 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900747
748 vector<string> args{"aidl", "Rect.aidl"};
749 Options options = Options::From(args);
750 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
751
752 string output;
753 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900754 EXPECT_EQ(kExpectedJavaParcelableOutputContests, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900755}
756
Devin Moore2f2077a2020-08-28 11:27:53 -0700757TEST_F(AidlTest, CppHeaderIncludes) {
758 io_delegate_.SetFileContents("IFoo.aidl",
759 "interface IFoo {\n"
760 " @nullable List<String> foo();\n"
761 "}");
762
763 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
764 Options options = Options::From(args);
765 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
766 std::vector<std::string> empty;
767 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
768 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
769 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
770
771 // Make sure the optional and String16.h includes are added
772 string output;
773 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
774 EXPECT_EQ(kExpectedCppHeaderOutput, output);
775}
776
Devin Moore7b8d5c92020-03-17 14:14:08 -0700777TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700778 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800779 io_delegate_.SetFileContents("p/Outer.aidl",
780 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900781 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700782 CaptureStderr();
783 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
784 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700785 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700786 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800787}
788
Devin Moore7b8d5c92020-03-17 14:14:08 -0700789TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800790 io_delegate_.SetFileContents("preprocessed",
791 "parcelable p.Outer.Inner;");
792 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900793 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700794 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800795 // TODO(wiley): This should actually return nullptr because we require
796 // the outer class name. However, for legacy reasons,
797 // this behavior must be maintained. b/17415692
798 EXPECT_NE(nullptr, parse_result);
799}
800
Christopher Wiley632801d2015-11-05 14:15:49 -0800801TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700802 const string expected_foo_stderr =
803 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
804 "Declared parcelables should be in their own file and/or cannot be used with --structured "
805 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700806 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
807
Christopher Wiley632801d2015-11-05 14:15:49 -0800808 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700809 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700810 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900811 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700812 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900813
Steven Morelande2c64b42018-09-18 15:06:37 -0700814 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900815 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700816 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900817 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700818 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700819
Devin Moore097a3ab2020-03-11 16:08:44 -0700820 const string expected_bar_stderr =
821 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
822 "Declared parcelables should be in their own file and/or cannot be used with --structured "
823 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700824 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
825
Jiyong Parkda8c6932019-08-12 19:56:08 +0900826 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700827 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700828 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900829 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700830 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700831 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700832 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700833 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700834 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800835}
836
Devin Moore7b8d5c92020-03-17 14:14:08 -0700837TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700838 const string expected_stderr =
839 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
840 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700841 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
842 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700843 AidlError error;
844 CaptureStderr();
845 EXPECT_EQ(
846 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700847 Parse("p/IFoo.aidl",
848 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700849 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700850 EXPECT_EQ(expected_stderr, GetCapturedStderr());
851 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700852}
853
Devin Moore7b8d5c92020-03-17 14:14:08 -0700854TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700855 AidlError error;
856 const string expected_stderr =
857 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
858 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900859 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
860 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700861 interface IFoo {
862 const String DUPLICATED = "d";
863 const int DUPLICATED = 1;
864 }
865 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700866 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
868 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700869}
870
Devin Moore7b8d5c92020-03-17 14:14:08 -0700871TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700872 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700873 const string expected_stderr =
874 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700875 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700876 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
877 R"(package p;
878 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700879 parcelable IBar {}
880 parcelable StructuredParcelable {}
881 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900882 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700883 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700884 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700885 // Parse success is important for clear error handling even if the cases aren't
886 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700887 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700888}
889
Devin Moore7b8d5c92020-03-17 14:14:08 -0700890TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700891 AidlError error;
892 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
893 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700894 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700895 EXPECT_EQ(expected_stderr, GetCapturedStderr());
896 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700897}
898
Steven Morelandf9e922f2020-07-08 21:15:27 +0000899TEST_P(AidlTest, FailOnEmptyListWithComma) {
900 AidlError error;
901 const string expected_stderr =
902 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
903 CaptureStderr();
904 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
905 typenames_, GetLanguage(), &error));
906 EXPECT_EQ(expected_stderr, GetCapturedStderr());
907 EXPECT_EQ(AidlError::PARSE_ERROR, error);
908}
909
Devin Moore7b8d5c92020-03-17 14:14:08 -0700910TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700911 AidlError error;
912 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700913 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700914 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900915 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
916 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700917 interface IFoo {
918 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
919 }
920 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700921 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700922 EXPECT_EQ(expected_stderr, GetCapturedStderr());
923 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700924}
925
Jiyong Park18132182020-06-08 20:24:40 +0900926TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
927 AidlError error;
928 const string expected_stderr =
929 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
930 "cpp_header (which can also be used as an identifier)\n";
931 CaptureStderr();
932 // Notice the trailing dot(.) in the name, which isn't a correct name
933 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
934 GetLanguage(), &error));
935 EXPECT_EQ(expected_stderr, GetCapturedStderr());
936 EXPECT_EQ(AidlError::PARSE_ERROR, error);
937}
938
939TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
940 AidlError error;
941 const string expected_stderr =
942 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
943 "cpp_header (which can also be used as an identifier)\n";
944 CaptureStderr();
945 // Notice the trailing dot(.) in the package name
946 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
947 GetLanguage(), &error));
948 EXPECT_EQ(expected_stderr, GetCapturedStderr());
949 EXPECT_EQ(AidlError::PARSE_ERROR, error);
950}
951
Devin Moore7b8d5c92020-03-17 14:14:08 -0700952TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700953 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700954 auto parse_result = Parse("p/IFoo.aidl",
955 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700956 interface IFoo {
957 const int POSITIVE_HEX_VALUE = 0xf5;
958 }
959 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700960 typenames_, GetLanguage(), &error);
961 EXPECT_NE(nullptr, parse_result);
962 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700963 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700964 const auto& cpp_constants = interface->GetConstantDeclarations();
965 EXPECT_EQ((size_t)1, cpp_constants.size());
966 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700967 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700968 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700969}
970
Devin Moore7b8d5c92020-03-17 14:14:08 -0700971TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700973 auto parse_result = Parse("p/IFoo.aidl",
974 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700975 interface IFoo {
976 const int NEGATIVE_HEX_VALUE = 0xffffffff;
977 }
978 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700979 typenames_, GetLanguage(), &error);
980 ASSERT_NE(nullptr, parse_result);
981 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700982 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700983 const auto& cpp_constants = interface->GetConstantDeclarations();
984 EXPECT_EQ((size_t)1, cpp_constants.size());
985 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700986 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700987 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700988}
989
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -0700991 io_delegate_.SetFileContents(
992 "p/Outer.aidl",
993 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +0900994 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -0700995 const string input_path = "p/IFoo.aidl";
996 const string input = "package p; import p.Outer; interface IFoo"
997 " { Outer.Inner get(); }";
998
Devin Moore7b8d5c92020-03-17 14:14:08 -0700999 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1000 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001001
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001002 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001003 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001004 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1005 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001006}
1007
Devin Moore7b8d5c92020-03-17 14:14:08 -07001008TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001009 io_delegate_.SetFileContents(
1010 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001011 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001012 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001013 const string input_path = "p/IFoo.aidl";
1014 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001015 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1016 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001017 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001018 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1019 native_type.Resolve(typenames_);
1020
1021 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1022 // C++ understands C++ specific stuff
1023 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1024 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001025 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001026 EXPECT_EQ(1u, headers.size());
1027 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001028}
1029
Christopher Wileyf8136192016-04-12 14:19:35 -07001030TEST_F(AidlTest, WritesCorrectDependencyFile) {
1031 // While the in tree build system always gives us an output file name,
1032 // other android tools take advantage of our ability to infer the intended
1033 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001034 vector<string> args = {
1035 "aidl",
1036 "-d dep/file/path",
1037 "-o place/for/output",
1038 "p/IFoo.aidl"};
1039 Options options = Options::From(args);
1040 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001041 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001042 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001043 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001044 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1045}
1046
Dan Willemsen93298ee2016-11-10 23:55:55 -08001047TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1048 // While the in tree build system always gives us an output file name,
1049 // other android tools take advantage of our ability to infer the intended
1050 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001051 vector<string> args = {
1052 "aidl",
1053 "-d dep/file/path",
1054 "--ninja",
1055 "-o place/for/output",
1056 "p/IFoo.aidl"};
1057 Options options = Options::From(args);
1058 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001059 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001060 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001061 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001062 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1063}
1064
Jiyong Parkdf202122019-09-30 20:48:35 +09001065TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001066 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1067 // this by calling aidl with every .aidl file it finds, then parsing the
1068 // generated dependency files. Those that reference .java output files are
1069 // for interfaces and those that do not are parcelables. However, for both
1070 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001071 vector<string> args = {
1072 "aidl",
1073 "-o place/for/output",
1074 "-d dep/file/path",
1075 "p/Foo.aidl"};
1076 Options options = Options::From(args);
1077 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001078 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001079 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001080 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001081 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1082}
1083
1084TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1085 vector<string> args = {
1086 "aidl",
1087 "--structured",
1088 "-o place/for/output",
1089 "-d dep/file/path",
1090 "p/Foo.aidl"};
1091 Options options = Options::From(args);
1092 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1093 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1094 string actual_dep_file_contents;
1095 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1096 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001097}
1098
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001099TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1100 vector<string> args = {
1101 "aidl",
1102 "--lang=java",
1103 "-o place/for/output",
1104 "p/Foo.aidl"};
1105 Options options = Options::From(args);
1106 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1107 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1108 string output_file_contents;
1109 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1110}
1111
Jeongik Cha08ca2182019-11-21 14:01:13 +09001112// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001113TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001114 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001115 "package a; interface IFoo {\n"
1116 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001117 string expected_stderr;
1118 switch (GetLanguage()) {
1119 case Options::Language::CPP:
1120 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001121 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001122 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1123 "String and IBinder.\n";
1124 break;
1125 case Options::Language::JAVA:
1126 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001127 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001128 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1129 "String, IBinder, and ParcelFileDescriptor.\n";
1130 break;
1131 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001132 case Options::Language::RUST:
1133 expected_stderr =
1134 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1135 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001136 default:
1137 AIDL_FATAL(AIDL_LOCATION_HERE)
1138 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1139 }
1140 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001141 AidlTypenames tn1;
1142 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001143 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001144
1145 string primitive_parcelable =
1146 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001147 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001148 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001149 AidlTypenames tn2;
1150 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001151 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001152}
1153
Devin Moore21b26772020-08-26 16:37:56 -07001154TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001155 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001156 const string list_array_parcelable =
1157 "package a; parcelable Foo {\n"
1158 " List[] lists; }";
1159 CaptureStderr();
1160 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1161 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1162}
1163
Jiyong Parkf8d53612020-05-04 14:06:13 +09001164TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1165 AidlError error;
1166 string expected_stderr =
1167 "ERROR: a/IFoo.aidl:2.7-11: "
1168 "Encountered an untyped List or Map. The use of untyped List/Map is "
1169 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1170 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1171 if (GetLanguage() != Options::Language::JAVA) {
1172 expected_stderr =
1173 "ERROR: a/IFoo.aidl:2.1-7: "
1174 "Currently, only the Java backend supports non-generic List.\n";
1175 }
1176
1177 const string primitive_interface =
1178 "package a; interface IFoo {\n"
1179 " List foo(); }";
1180 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001181 AidlTypenames tn1;
1182 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001183 {"--structured"}));
1184 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001185
1186 string primitive_parcelable =
1187 "package a; parcelable IFoo {\n"
1188 " List foo;}";
1189 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001190 AidlTypenames tn2;
1191 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001192 {"--structured"}));
1193 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1194}
1195
Jeongik Cha225519b2020-08-29 01:55:32 +09001196TEST_P(AidlTest, ExtensionTest) {
1197 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001198 string extendable_parcelable =
1199 "package a; parcelable Data {\n"
1200 " ParcelableHolder extension;\n"
1201 " ParcelableHolder extension2;\n"
1202 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001203 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1204 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1205 EXPECT_EQ(
1206 "ERROR: a/Data.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1207 "yet.\n",
1208 GetCapturedStderr());
1209 } else {
1210 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1211 EXPECT_EQ("", GetCapturedStderr());
1212 }
1213}
1214TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1215 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001216 string parcelableholder_return_interface =
1217 "package a; interface IFoo {\n"
1218 " ParcelableHolder foo();\n"
1219 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001220 EXPECT_EQ(nullptr,
1221 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001222
Jeongik Cha225519b2020-08-29 01:55:32 +09001223 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1224 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001225 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001226 "ERROR: a/IFoo.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1227 "yet.\n",
1228 GetCapturedStderr());
1229 return;
1230 }
1231 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1232 GetCapturedStderr());
1233}
1234
1235TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1236 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001237 string extendable_parcelable_arg_interface =
1238 "package a; interface IFoo {\n"
1239 " void foo(in ParcelableHolder ph);\n"
1240 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001241 EXPECT_EQ(nullptr,
1242 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1243
1244 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1245 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001246 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001247 "ERROR: a/IFoo.aidl:2.14-31: The NDK and Rust backend does not support ParcelableHolder "
1248 "yet.\n",
1249 GetCapturedStderr());
1250 return;
1251 }
1252 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1253 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001254}
1255
Jiyong Park02da7422018-07-16 16:00:26 +09001256TEST_F(AidlTest, ApiDump) {
1257 io_delegate_.SetFileContents(
1258 "foo/bar/IFoo.aidl",
1259 "package foo.bar;\n"
1260 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001261 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001262 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001263 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001264 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1265 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1266 " IFoo foo3(IFoo foo);\n"
1267 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001268 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001269 " const int A = 1;\n"
1270 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001271 "}\n");
1272 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1273 "package foo.bar;\n"
1274 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001275 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001276 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001277 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001278 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001279 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001280 " int y;\n"
1281 " IFoo foo;\n"
1282 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001283 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001284 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001285 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001286 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001287 "}\n");
1288 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001289 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1290 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001291 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001292 bool result = dump_api(options, io_delegate_);
1293 ASSERT_TRUE(result);
1294 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001295 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001296 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001297/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001298interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001299 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001300 int foo(out int[] a, String b, boolean c, inout List<String> d);
1301 int foo2(@utf8InCpp String x, inout List<String> y);
1302 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1303 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001304 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001305 const int A = 1;
1306 const String STR = "Hello";
1307}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001308)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001309
Jiyong Parke59c3682018-09-11 23:10:25 +09001310 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001311 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001312/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001313parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001314 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001315 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001316 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001317 int y;
1318 foo.bar.IFoo foo;
1319 List<foo.bar.IFoo> a;
1320 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001321 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001322 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001323}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001324)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001325}
1326
Jiyong Parked65bf42018-08-28 15:43:27 +09001327TEST_F(AidlTest, ApiDumpWithManualIds) {
1328 io_delegate_.SetFileContents(
1329 "foo/bar/IFoo.aidl",
1330 "package foo.bar;\n"
1331 "interface IFoo {\n"
1332 " int foo() = 1;\n"
1333 " int bar() = 2;\n"
1334 " int baz() = 10;\n"
1335 "}\n");
1336
Jiyong Parke59c3682018-09-11 23:10:25 +09001337 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001338 Options options = Options::From(args);
1339 bool result = dump_api(options, io_delegate_);
1340 ASSERT_TRUE(result);
1341 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001342 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001343 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001344interface IFoo {
1345 int foo() = 1;
1346 int bar() = 2;
1347 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001348}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001349)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001350}
1351
1352TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001353 const string expected_stderr =
1354 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1355 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001356 io_delegate_.SetFileContents(
1357 "foo/bar/IFoo.aidl",
1358 "package foo.bar;\n"
1359 "interface IFoo {\n"
1360 " int foo() = 1;\n"
1361 " int bar();\n"
1362 " int baz() = 10;\n"
1363 "}\n");
1364
Jiyong Parke59c3682018-09-11 23:10:25 +09001365 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001366 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001367 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001368 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001369 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001370}
1371
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001372TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001373 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001374 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1375 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001376 const string expected_map_stderr =
1377 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001378 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1379 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001380 "package p; interface IFoo {"
1381 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001382 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001383 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001384 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001385
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001386 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001387 "package p; interface IFoo {"
1388 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001389 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001390 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001391 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001392}
1393
Jeongik Chae48d9942020-01-02 17:39:00 +09001394TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001395 const string expected_stderr =
1396 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001397 Options options = Options::From("aidl -I p p/IFoo.aidl");
1398 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1399
1400 io_delegate_.SetFileContents("p/IFoo.aidl",
1401 "package p; interface IFoo {"
1402 "Map<String, Bar> foo();}");
1403 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1404
1405 io_delegate_.SetFileContents("p/IFoo.aidl",
1406 "package p; interface IFoo {"
1407 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001408 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001409 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001410 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001411
1412 io_delegate_.SetFileContents("p/IFoo.aidl",
1413 "package p; interface IFoo {"
1414 "Map<String, String> foo();}");
1415 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1416
1417 io_delegate_.SetFileContents("p/IFoo.aidl",
1418 "package p; interface IFoo {"
1419 "Map<String, ParcelFileDescriptor> foo();}");
1420 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1421}
1422
Jeongik Chadf76dc72019-11-28 00:08:47 +09001423TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001424 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001425 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1426 io_delegate_.SetFileContents(options.InputFiles().front(),
1427 "package p; interface IFoo {"
1428 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001429 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001430 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001431 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001432}
1433
1434TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1435 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1436 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001437 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001438 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001439 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1440 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001441
1442 Options options = Options::From("aidl -I p p/IFoo.aidl");
1443 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1444 io_delegate_.SetFileContents("p/IFoo.aidl",
1445 "package p; interface IFoo {"
1446 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001447 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001448 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001449 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001450 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001451 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001452 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001453 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1454 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001455 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1456 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1457 io_delegate_.SetFileContents("p/IFoo.aidl",
1458 "package p; interface IFoo {"
1459 "Bar<String, ParcelFileDescriptor> foo();}");
1460 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001461
1462 io_delegate_.SetFileContents("p/IFoo.aidl",
1463 "package p; interface IFoo {"
1464 "Bar<int, long> foo();}");
1465
1466 io_delegate_.SetFileContents("p/IFoo.aidl",
1467 "package p; interface IFoo {"
1468 "Bar<int[], long[]> foo();}");
1469
1470 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001471}
1472
Jeongik Cha0e426012019-07-29 15:57:02 +09001473TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1474 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001475 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1476 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001477 for (const auto& rawOption : rawOptions) {
1478 string expected_stderr =
1479 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001480 Options options = Options::From(rawOption);
1481 io_delegate_.SetFileContents(options.InputFiles().front(),
1482 "package foo.bar;\n"
1483 "interface IFoo1 { int foo(); }\n"
1484 "interface IFoo2 { int foo(); }\n"
1485 "parcelable Data1 { int a; int b;}\n"
1486 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001487 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001488 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001489 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001490
Jeongik Cha0e426012019-07-29 15:57:02 +09001491 io_delegate_.SetFileContents(options.InputFiles().front(),
1492 "package foo.bar;\n"
1493 "interface IFoo1 { int foo(); }\n"
1494 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001495 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001496 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001497 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001498
Devin Moore5de18ed2020-04-02 13:52:29 -07001499 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001500 io_delegate_.SetFileContents(options.InputFiles().front(),
1501 "package foo.bar;\n"
1502 "parcelable Data1 { int a; int b;}\n"
1503 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001504 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001505 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001506 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001507 }
1508}
1509
Devin Moorebdba2a82020-03-31 15:19:02 -07001510TEST_P(AidlTest, FailParseOnEmptyFile) {
1511 const string contents = "";
1512 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1513 CaptureStderr();
1514 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1515 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1516}
1517
Jiyong Parkb034bf02018-07-30 17:44:33 +09001518TEST_F(AidlTest, MultipleInputFiles) {
1519 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001520 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001521
1522 io_delegate_.SetFileContents(options.InputFiles().at(0),
1523 "package foo.bar;\n"
1524 "import foo.bar.Data;\n"
1525 "interface IFoo { Data getData(); }\n");
1526
1527 io_delegate_.SetFileContents(options.InputFiles().at(1),
1528 "package foo.bar;\n"
1529 "import foo.bar.IFoo;\n"
1530 "parcelable Data { IFoo foo; }\n");
1531
1532 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1533
1534 string content;
1535 for (const auto file : {
1536 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1537 content.clear();
1538 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1539 EXPECT_FALSE(content.empty());
1540 }
1541}
1542
1543TEST_F(AidlTest, MultipleInputFilesCpp) {
1544 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001545 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001546
1547 io_delegate_.SetFileContents(options.InputFiles().at(0),
1548 "package foo.bar;\n"
1549 "import foo.bar.Data;\n"
1550 "interface IFoo { Data getData(); }\n");
1551
1552 io_delegate_.SetFileContents(options.InputFiles().at(1),
1553 "package foo.bar;\n"
1554 "import foo.bar.IFoo;\n"
1555 "parcelable Data { IFoo foo; }\n");
1556
1557 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1558
1559 string content;
1560 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001561 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001562 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1563 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1564 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1565 content.clear();
1566 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1567 EXPECT_FALSE(content.empty());
1568 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001569}
1570
Andrei Homescub62afd92020-05-11 19:24:59 -07001571TEST_F(AidlTest, MultipleInputFilesRust) {
1572 Options options =
1573 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1574
1575 io_delegate_.SetFileContents(options.InputFiles().at(0),
1576 "package foo.bar;\n"
1577 "import foo.bar.Data;\n"
1578 "interface IFoo { Data getData(); }\n");
1579
1580 io_delegate_.SetFileContents(options.InputFiles().at(1),
1581 "package foo.bar;\n"
1582 "import foo.bar.IFoo;\n"
1583 "parcelable Data { IFoo foo; }\n");
1584
1585 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1586
1587 string content;
1588 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1589 content.clear();
1590 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1591 EXPECT_FALSE(content.empty());
1592 }
1593}
1594
Devin Moore097a3ab2020-03-11 16:08:44 -07001595TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1596 const string expected_stderr =
1597 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001598 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1599 // int getInterfaceVersion() is one of the meta transactions
1600 io_delegate_.SetFileContents(options.InputFiles().front(),
1601 "package p; interface IFoo {"
1602 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001603 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001604 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001605 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1606}
Jiyong Park309668e2018-07-28 16:55:44 +09001607
Devin Moore097a3ab2020-03-11 16:08:44 -07001608TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1609 // boolean getInterfaceVersion() is not a meta transaction, but should be
1610 // prevented because return type is not part of a method signature
1611 const string expected_stderr =
1612 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1613 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001614 io_delegate_.SetFileContents(options.InputFiles().front(),
1615 "package p; interface IFoo {"
1616 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001617 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001618 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001619 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1620}
Jiyong Park309668e2018-07-28 16:55:44 +09001621
Devin Moore097a3ab2020-03-11 16:08:44 -07001622TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001623 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001624 const string expected_stderr =
1625 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1626 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001627 io_delegate_.SetFileContents(options.InputFiles().front(),
1628 "package p; interface IFoo {"
1629 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001630 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001631 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001632 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001633
1634 // this is not a meta interface method as it differs type arguments
1635 io_delegate_.SetFileContents(options.InputFiles().front(),
1636 "package p; interface IFoo {"
1637 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001638 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001639}
1640
Daniel Norman85aed542019-08-21 12:01:14 -07001641TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001642 Options options = Options::From("aidl --checkapi old new");
1643 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1644 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1645 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1646 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1647
1648 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1649}
1650
Jiyong Park3656c3c2018-08-01 20:02:01 +09001651TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001652 Options options = Options::From("aidl --checkapi old new");
1653 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1654 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001655
1656 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1657}
1658
Daniel Norman85aed542019-08-21 12:01:14 -07001659class AidlTestCompatibleChanges : public AidlTest {
1660 protected:
1661 Options options_ = Options::From("aidl --checkapi old new");
1662};
1663
1664TEST_F(AidlTestCompatibleChanges, NewType) {
1665 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1666 "package p;"
1667 "interface IFoo {"
1668 " void foo(int a);"
1669 "}");
1670 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1671 "package p;"
1672 "interface IFoo {"
1673 " void foo(int a);"
1674 "}");
1675 io_delegate_.SetFileContents("new/p/IBar.aidl",
1676 "package p;"
1677 "interface IBar {"
1678 " void bar();"
1679 "}");
1680 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1681}
1682
1683TEST_F(AidlTestCompatibleChanges, NewMethod) {
1684 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1685 "package p;"
1686 "interface IFoo {"
1687 " void foo(int a);"
1688 "}");
1689 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1690 "package p;"
1691 "interface IFoo {"
1692 " void foo(int a);"
1693 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001694 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001695 "}");
1696 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1697}
1698
1699TEST_F(AidlTestCompatibleChanges, NewField) {
1700 io_delegate_.SetFileContents("old/p/Data.aidl",
1701 "package p;"
1702 "parcelable Data {"
1703 " int foo;"
1704 "}");
1705 io_delegate_.SetFileContents("new/p/Data.aidl",
1706 "package p;"
1707 "parcelable Data {"
1708 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001709 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001710 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001711 "}");
1712 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1713}
1714
1715TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1716 io_delegate_.SetFileContents("old/p/Enum.aidl",
1717 "package p;"
1718 "enum Enum {"
1719 " FOO = 1,"
1720 "}");
1721 io_delegate_.SetFileContents("new/p/Enum.aidl",
1722 "package p;"
1723 "enum Enum {"
1724 " FOO = 1,"
1725 " BAR = 2,"
1726 "}");
1727 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1728}
1729
1730TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1731 io_delegate_.SetFileContents("old/p/Enum.aidl",
1732 "package p;"
1733 "enum Enum {"
1734 " FOO = 1,"
1735 " BAR = 2,"
1736 "}");
1737 io_delegate_.SetFileContents("new/p/Enum.aidl",
1738 "package p;"
1739 "enum Enum {"
1740 " BAR = 2,"
1741 " FOO = 1,"
1742 "}");
1743 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1744}
1745
1746TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001747 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1748 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001749 "interface IFoo {"
1750 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001751 "}");
1752 io_delegate_.SetFileContents("old/p/Data.aidl",
1753 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001754 "parcelable Data {"
1755 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001756 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001757 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1758 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001759 "interface IFoo {"
1760 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001761 "}");
1762 io_delegate_.SetFileContents("new/p/Data.aidl",
1763 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001764 "parcelable Data {"
1765 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001766 "}");
1767 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1768 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001769 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001770 " void foo(int a);"
1771 "}");
1772 io_delegate_.SetFileContents("new/q/Data.aidl",
1773 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001774 "parcelable Data {"
1775 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001776 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001777 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1778}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001779
Daniel Norman85aed542019-08-21 12:01:14 -07001780TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1781 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1782 "package p;"
1783 "interface IFoo {"
1784 " void foo(int a);"
1785 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001786 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1787 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001788 "interface IFoo {"
1789 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001790 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001791 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1792}
Jiyong Parke59c3682018-09-11 23:10:25 +09001793
Daniel Norman85aed542019-08-21 12:01:14 -07001794TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001795 io_delegate_.SetFileContents("old/p/I.aidl",
1796 "package p; interface I {"
1797 "const int A = 1; }");
1798 io_delegate_.SetFileContents("new/p/I.aidl",
1799 "package p ; interface I {"
1800 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001801 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1802}
Jiyong Parka428d212018-08-29 22:26:30 +09001803
Daniel Norman85aed542019-08-21 12:01:14 -07001804TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001805 io_delegate_.SetFileContents("old/p/I.aidl",
1806 "package p; interface I {"
1807 "const int A = 1; const int B = 2;}");
1808 io_delegate_.SetFileContents("new/p/I.aidl",
1809 "package p ; interface I {"
1810 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001811 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001812}
1813
Daniel Norman85aed542019-08-21 12:01:14 -07001814class AidlTestIncompatibleChanges : public AidlTest {
1815 protected:
1816 Options options_ = Options::From("aidl --checkapi old new");
1817};
1818
1819TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001820 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001821 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1822 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001823 "interface IFoo {"
1824 " void foo(in String[] str);"
1825 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001826 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001827 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001828 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001829 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001830}
1831
1832TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001833 const string expected_stderr =
1834 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001835 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1836 "package p;"
1837 "interface IFoo {"
1838 " void foo(in String[] str);"
1839 " void bar(@utf8InCpp String str);"
1840 "}");
1841 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1842 "package p;"
1843 "interface IFoo {"
1844 " void foo(in String[] str);"
1845 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001846 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001847 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001848 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001849}
1850
Jiyong Parkf8d53612020-05-04 14:06:13 +09001851TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1852 const string expected_stderr =
1853 "ERROR: new/p/IFoo.aidl:1.61-65: "
1854 "Encountered an untyped List or Map. The use of untyped List/Map is "
1855 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1856 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1857 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1858 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1859 "package p;"
1860 "interface IFoo {"
1861 " void foo(in String[] str);"
1862 "}");
1863 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1864 "package p;"
1865 "interface IFoo {"
1866 " void foo(in String[] str);"
1867 " void bar(in List arg);"
1868 "}");
1869 CaptureStderr();
1870 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1871 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1872}
1873
1874TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1875 const string expected_stderr =
1876 "ERROR: new/p/Data.aidl:1.54-59: "
1877 "Encountered an untyped List or Map. The use of untyped List/Map is "
1878 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1879 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1880 "ERROR: new/p/Data.aidl: Failed to read.\n";
1881 io_delegate_.SetFileContents("old/p/Data.aidl",
1882 "package p;"
1883 "parcelable Data {"
1884 " int foo;"
1885 "}");
1886 io_delegate_.SetFileContents("new/p/Data.aidl",
1887 "package p;"
1888 "parcelable Data {"
1889 " int foo;"
1890 " @nullable List list;"
1891 "}");
1892 CaptureStderr();
1893 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1894 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1895}
1896
Daniel Norman85aed542019-08-21 12:01:14 -07001897TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001898 const string expected_stderr =
1899 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001900 io_delegate_.SetFileContents("old/p/Data.aidl",
1901 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001902 "parcelable Data {"
1903 " int foo;"
1904 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001905 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001906 io_delegate_.SetFileContents("new/p/Data.aidl",
1907 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001908 "parcelable Data {"
1909 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001910 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001911 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001912 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001913 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001914}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001915
Daniel Norman85aed542019-08-21 12:01:14 -07001916TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001917 const string expected_stderr =
1918 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001919 io_delegate_.SetFileContents("old/p/Enum.aidl",
1920 "package p;"
1921 "enum Enum {"
1922 " FOO = 1,"
1923 " BAR = 2,"
1924 "}");
1925 io_delegate_.SetFileContents("new/p/Enum.aidl",
1926 "package p;"
1927 "enum Enum {"
1928 " BAR = 2,"
1929 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001930 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001931 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001932 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001933}
1934
1935TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001936 const string expected_stderr =
1937 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001938 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1939 "package p;"
1940 "interface IFoo {"
1941 " void foo(in String[] str);"
1942 " void bar(@utf8InCpp String str);"
1943 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001944 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1945 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001946 "interface IFoo {"
1947 " void foo(in String[] str);"
1948 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001949 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001950 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001951 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001952 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001953}
1954
Daniel Norman85aed542019-08-21 12:01:14 -07001955TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001956 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001957 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1958 "package p;"
1959 "interface IFoo {"
1960 " void foo(in String[] str);"
1961 " void bar(@utf8InCpp String str);"
1962 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001963 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
1964 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001965 "interface IFoo2 {"
1966 " void foo(in String[] str);"
1967 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001968 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001969 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001970 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001972}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001973
Daniel Norman85aed542019-08-21 12:01:14 -07001974TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001975 const string expected_stderr =
1976 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001977 io_delegate_.SetFileContents("old/p/Enum.aidl",
1978 "package p;"
1979 "enum Enum {"
1980 " FOO = 1,"
1981 " BAR = 2,"
1982 "}");
1983 io_delegate_.SetFileContents("new/p/Enum.aidl",
1984 "package p;"
1985 "enum Enum {"
1986 " FOO = 3,"
1987 " BAR = 2,"
1988 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001989 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001990 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001991 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001992}
1993
1994TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001995 const string expected_stderr =
1996 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
1997 "from 0 to 1.\n"
1998 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
1999 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002000 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2001 "package p;"
2002 "interface IFoo {"
2003 " void foo(in String[] str);"
2004 " void bar(@utf8InCpp String str);"
2005 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002006 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2007 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002008 "interface IFoo {"
2009 " void bar(@utf8InCpp String str);"
2010 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002011 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002012 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002013 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002014 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002015}
2016
2017TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002018 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002019 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2020 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002021 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002022 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002023 "parcelable Data {"
2024 " int foo;"
2025 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002026 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002027 io_delegate_.SetFileContents("new/p/Data.aidl",
2028 "package p;"
2029 "parcelable Data {"
2030 " int bar;"
2031 " int foo;"
2032 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002033 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002034 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002035 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002036}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002037
Daniel Norman85aed542019-08-21 12:01:14 -07002038TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002039 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002040 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002041 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002042 "interface IFoo {"
2043 " void foo(in String[] str);"
2044 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002045 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002046 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2047 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002048 "interface IFoo {"
2049 " void foo(out String[] str);"
2050 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002051 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002052 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002053 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002055}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002056
Daniel Norman85aed542019-08-21 12:01:14 -07002057TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002058 const string expected_stderr =
2059 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002060 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2061 "package p;"
2062 "interface IFoo {"
2063 " void foo(in String[] str);"
2064 " void bar(@utf8InCpp String str);"
2065 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002066 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2067 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002068 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002069 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002070 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002071 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002072 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002073 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002074 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002075}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002076
Daniel Norman85aed542019-08-21 12:01:14 -07002077TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002078 const string expected_stderr =
2079 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002080 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2081 "package p;"
2082 "interface IFoo {"
2083 " void foo(in String[] str);"
2084 " void bar(@utf8InCpp String str);"
2085 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002086 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2087 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002088 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002089 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002090 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002091 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002092 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002093 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002094 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002095}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002096
Devin Mooredb7ac512020-08-07 11:17:36 -07002097TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2098 const string expected_stderr =
2099 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2100 io_delegate_.SetFileContents("old/p/Foo.aidl",
2101 "package p;"
2102 "parcelable Foo {"
2103 " int A;"
2104 "}");
2105 io_delegate_.SetFileContents("new/p/Foo.aidl",
2106 "package p;"
2107 "@JavaOnlyStableParcelable parcelable Foo {"
2108 " int A;"
2109 "}");
2110 CaptureStderr();
2111 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2112 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2113}
2114
2115TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2116 const string expected_stderr =
2117 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2118 io_delegate_.SetFileContents("old/p/Foo.aidl",
2119 "package p;"
2120 "@JavaOnlyStableParcelable parcelable Foo {"
2121 " int A;"
2122 "}");
2123 io_delegate_.SetFileContents("new/p/Foo.aidl",
2124 "package p;"
2125 "parcelable Foo {"
2126 " int A;"
2127 "}");
2128 CaptureStderr();
2129 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2130 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2131}
2132
Daniel Norman85aed542019-08-21 12:01:14 -07002133TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002134 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002135 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2136 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002137 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002138 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002139 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002140 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002141}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002142
Daniel Norman85aed542019-08-21 12:01:14 -07002143TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002144 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002145 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2146 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002147 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002148 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002149 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002150}
Jiyong Parka428d212018-08-29 22:26:30 +09002151
Daniel Norman85aed542019-08-21 12:01:14 -07002152TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002153 const string expected_stderr =
2154 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002155 io_delegate_.SetFileContents("old/p/I.aidl",
2156 "package p; interface I {"
2157 "const int A = 1; const int B = 2;}");
2158 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002159 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002160 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002161 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002162}
Jiyong Parka428d212018-08-29 22:26:30 +09002163
Daniel Norman85aed542019-08-21 12:01:14 -07002164TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002165 const string expected_stderr =
2166 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002167 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2168 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002169 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002170 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002171 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002172}
2173
Devin Moorec7e47a32020-08-07 10:55:25 -07002174TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2175 const string expected_stderr =
2176 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2177 "This is an incompatible change for FixedSize types.\n";
2178 io_delegate_.SetFileContents("old/p/Foo.aidl",
2179 "package p; @FixedSize parcelable Foo { int A = 1; }");
2180 io_delegate_.SetFileContents("new/p/Foo.aidl",
2181 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2182 CaptureStderr();
2183 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2184 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2185}
2186
2187TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2188 const string expected_stderr =
2189 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2190 io_delegate_.SetFileContents("old/p/Foo.aidl",
2191 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2192 io_delegate_.SetFileContents("new/p/Foo.aidl",
2193 "package p; @FixedSize parcelable Foo { int A = 1; }");
2194 CaptureStderr();
2195 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2196 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2197}
2198
2199TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2200 const string expected_stderr =
2201 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2202 "a.\n"
2203 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2204 "b.\n"
2205 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2206 "c.\n"
2207 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2208 "d.\n"
2209 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2210 "e.\n"
2211 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2212 "f.\n";
2213
2214 io_delegate_.SetFileContents("Foo.aidl",
2215 "@FixedSize parcelable Foo { "
2216 " int[] a;"
2217 " Bar b;"
2218 " String c;"
2219 " ParcelFileDescriptor d;"
2220 " IBinder e;"
2221 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002222 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002223 "}");
2224 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2225 Options options =
2226 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2227
2228 CaptureStderr();
2229 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2230 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2231}
2232
2233TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2234 const string expected_stderr = "";
2235
2236 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2237 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2238 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2239 Options options =
2240 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2241
2242 CaptureStderr();
2243 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2244 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2245}
2246
Jiyong Park8c380532018-08-30 14:55:26 +09002247TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002248 const string expected_stderr =
2249 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2250 "dir1/q/IBar.aidl\n"
2251 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002252 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002253 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2254 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2255 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2256 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2257
Devin Moore097a3ab2020-03-11 16:08:44 -07002258 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002259 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002260 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002261}
2262
Jiyong Parked65bf42018-08-28 15:43:27 +09002263TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002264 const string expected_stderr =
2265 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2266 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002267 Options options = Options::From("aidl --checkapi old new");
2268 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2269 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002270
2271 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2272
Jiyong Parke59c3682018-09-11 23:10:25 +09002273 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002274 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002275 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002276 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002277}
2278
Jiyong Parke05195e2018-10-08 18:24:23 +09002279TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2280 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2281 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002282 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002283
2284 // use without import
2285 io_delegate_.SetFileContents("p/IFoo.aidl",
2286 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2287 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2288 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002289 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002290
Devin Moore7b8d5c92020-03-17 14:14:08 -07002291 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002292 io_delegate_.SetFileContents(
2293 "p/IFoo.aidl",
2294 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2295 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2296 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002297 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002298
2299 // use with import (as before)
2300 io_delegate_.SetFileContents("p/IFoo.aidl",
2301 "package p;"
2302 "import android.os.ParcelFileDescriptor;"
2303 "interface IFoo{"
2304 " void foo(in ParcelFileDescriptor fd);"
2305 "}");
2306 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2307 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002308 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002309}
Jiyong Parked65bf42018-08-28 15:43:27 +09002310
Jiyong Park3633b722019-04-11 15:38:26 +09002311TEST_F(AidlTest, ManualIds) {
2312 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2313 io_delegate_.SetFileContents("IFoo.aidl",
2314 "interface IFoo {\n"
2315 " void foo() = 0;\n"
2316 " void bar() = 1;\n"
2317 "}");
2318 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2319}
2320
2321TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2322 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2323 io_delegate_.SetFileContents("IFoo.aidl",
2324 "interface IFoo {\n"
2325 " void foo() = 0;\n"
2326 " void bar() = 1;\n"
2327 "}");
2328 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2329}
2330
2331TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002332 const string expected_stderr =
2333 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002334 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2335 io_delegate_.SetFileContents("IFoo.aidl",
2336 "interface IFoo {\n"
2337 " void foo() = 3;\n"
2338 " void bar() = 3;\n"
2339 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002340 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002341 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002342 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002343}
2344
2345TEST_F(AidlTest, FailOnOutOfRangeIds) {
2346 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002347 const string expected_stderr =
2348 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2349 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002350 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2351 io_delegate_.SetFileContents("IFoo.aidl",
2352 "interface IFoo {\n"
2353 " void foo() = 3;\n"
2354 " void bar() = 16777115;\n"
2355 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002356 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002357 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002358 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002359}
2360
2361TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002362 const string expected_stderr =
2363 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002364 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2365 io_delegate_.SetFileContents("IFoo.aidl",
2366 "interface IFoo {\n"
2367 " void foo() = 3;\n"
2368 " void bar();\n"
2369 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002370 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002371 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002372 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002373}
2374
Jiyong Parkc6816252019-07-08 08:12:28 +09002375TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2376 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2377 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2378 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2379 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2380}
2381
2382TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002383 const string expected_stderr =
2384 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2385 "dir/IBar.aidl\n"
2386 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002387 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002388
Jiyong Parkc6816252019-07-08 08:12:28 +09002389 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2390 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2391 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2392 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002393 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002394 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002395 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002396}
2397
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002398TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2399 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2400 "package a.b;\n"
2401 "import a.b.IBar;\n"
2402 "import a.b.IQux;\n"
2403 "interface IFoo { IQux foo(); }\n");
2404 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2405 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2406
2407 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2408 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2409
2410 string output;
2411 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2412 // IBar was imported but wasn't used. include is not expected.
2413 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2414 // IBar was imported and used. include is expected.
2415 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2416}
2417
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002418TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002419 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
2420 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2421 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002422 interface IFoo {
2423 @JavaPassthrough(annotation="@com.android.Bob")
2424 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002425 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002426 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002427
2428 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
2429 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2430
2431 string java_out;
2432 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002433 // type-decl-level annotations with newline at the end
2434 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2435 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2436 // member-decl-level annotations with newline at the end
2437 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2438 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2439 // inline annotations with space at the end
2440 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002441
2442 // Other backends shouldn't be bothered
2443 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
2444 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2445
2446 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
2447 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002448
2449 Options rust_options = Options::From("aidl --lang=rust -o out a/IFoo.aidl");
2450 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002451}
2452
Andrei Homescue61feb52020-08-18 15:44:24 -07002453TEST_F(AidlTest, ParseRustDerive) {
2454 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2455 @RustDerive(Clone=true, Copy=false)
2456 parcelable Foo {
2457 int a;
2458 })");
2459
2460 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2461 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2462
2463 string rust_out;
2464 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2465 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2466
2467 // Other backends shouldn't be bothered
2468 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2469 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2470
2471 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2472 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2473
2474 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2475 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2476}
2477
Jiyong Park56f73d72019-06-11 12:20:28 +09002478class AidlOutputPathTest : public AidlTest {
2479 protected:
2480 void SetUp() override {
2481 AidlTest::SetUp();
2482 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2483 }
2484
2485 void Test(const Options& options, const std::string expected_output_path) {
2486 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2487 // check the existence
2488 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2489 }
2490};
2491
2492TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2493 // <out_dir> / <package_name> / <type_name>.java
2494 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2495}
2496
2497TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2498 // when output file is explicitly set, it is always respected. -o option is
2499 // ignored.
2500 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2501}
2502
2503TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2504 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2505}
2506
2507TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2508 // output is the same as the input file except for the suffix
2509 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2510}
2511
Devin Moore7b8d5c92020-03-17 14:14:08 -07002512TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002513 AidlError error;
2514 const string expected_stderr =
2515 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2516 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002517 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2518 R"(package p;
2519 interface IFoo {
2520 const int int32_max_oob = 2147483650;
2521 }
2522 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002523 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002524 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2525 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002526}
2527
Devin Moore7b8d5c92020-03-17 14:14:08 -07002528TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002529 AidlError error;
2530 const string expected_stderr =
2531 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2532 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002533 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2534 R"(package p;
2535 interface IFoo {
2536 const int int32_min_oob = -2147483650;
2537 }
2538 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002539 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2541 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002542}
2543
Devin Moore7b8d5c92020-03-17 14:14:08 -07002544TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002545 AidlError error;
2546 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002547 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002548 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002549 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2550 R"(package p;
2551 interface IFoo {
2552 const long int64_max_oob = 21474836509999999999999999;
2553 }
2554 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002555 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002556 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2557 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002558}
2559
Devin Moore7b8d5c92020-03-17 14:14:08 -07002560TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002561 AidlError error;
2562 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002563 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002564 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002565 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2566 R"(package p;
2567 interface IFoo {
2568 const long int64_min_oob = -21474836509999999999999999;
2569 }
2570 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002571 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002572 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2573 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002574}
2575
Devin Moore7b8d5c92020-03-17 14:14:08 -07002576TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002577 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002578 const string expected_stderr =
2579 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2580 "literal: byte\n"
2581 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2582 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002583 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2584 R"(package p;
2585 @Backing(type="byte")
2586 enum TestEnum {
2587 FOO = 127,
2588 BAR,
2589 }
2590 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002591 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002592 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002593 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002594}
2595
Devin Mooredecaf292020-04-30 09:16:40 -07002596TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2597 AidlError error;
2598 const string expected_stderr =
2599 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2600 "be one of: type\n"
2601 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2602 "be one of: type\n";
2603 CaptureStderr();
2604 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2605 R"(package p;
2606 @Backing(foo="byte")
2607 enum TestEnum {
2608 FOO = 1,
2609 BAR,
2610 }
2611 )",
2612 typenames_, GetLanguage(), &error));
2613 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2614 EXPECT_EQ(AidlError::BAD_TYPE, error);
2615}
2616
Jeongik Chad0a10272020-08-06 16:33:36 +09002617TEST_P(AidlTest, SupportJavaOnlyImmutableAnnotation) {
2618 io_delegate_.SetFileContents("Foo.aidl",
2619 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2620 "Map<String, Baz> d; Bar[] e; }");
2621 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2622 io_delegate_.SetFileContents("Baz.aidl",
2623 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002624 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2625 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2626}
2627
Jeongik Chad0a10272020-08-06 16:33:36 +09002628TEST_P(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
2629 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002630 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2631 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2632 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2633}
2634
2635TEST_P(AidlTest, ImmtuableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002636 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002637 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2638 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2639 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2640}
2641
2642TEST_P(AidlTest, ImmtuableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002643 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002644 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2645 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2646 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2647}
2648
Jeongik Cha91180252020-07-31 15:43:11 +09002649TEST_P(AidlTest, ImmtuableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002650 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002651 Options options = Options::From("aidl --lang=java Foo.aidl");
2652 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002653 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002654 "capitalizing the first letter\n";
2655 CaptureStderr();
2656 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2657 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2658}
Devin Moore53fc99c2020-08-12 08:07:52 -07002659
2660TEST_P(AidlTest, GenericStructuredParcelable) {
2661 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
2662 Options options =
2663 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2664 const string expected_stderr = "";
2665 CaptureStderr();
2666 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2667 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2668}
2669
2670TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
2671 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
2672 Options options =
2673 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2674 const string expected_stderr =
2675 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
2676 CaptureStderr();
2677 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2678 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2679}
2680
2681TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
2682 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
2683 Options options =
2684 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2685 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
2686 CaptureStderr();
2687 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2688 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2689}
2690
Christopher Wiley90be4e32015-10-20 14:55:25 -07002691} // namespace aidl
2692} // namespace android