blob: 047157021c44831672f84f05c9fd80ece871ce6a [file] [log] [blame]
Christopher Wiley90be4e32015-10-20 14:55:25 -07001/*
2 * Copyright (C) 2015, The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Christopher Wiley90be4e32015-10-20 14:55:25 -070017#include <memory>
Christopher Wiley12e894a2016-01-29 11:55:07 -080018#include <set>
19#include <string>
Christopher Wiley90be4e32015-10-20 14:55:25 -070020#include <vector>
21
Christopher Wileyec31a052016-01-25 07:28:51 -080022#include <android-base/stringprintf.h>
Jiyong Parkf1f5c802020-05-19 17:33:00 +090023#include <gmock/gmock.h>
Christopher Wiley90be4e32015-10-20 14:55:25 -070024#include <gtest/gtest.h>
25
26#include "aidl.h"
Steven Moreland49585242019-12-18 16:06:49 -080027#include "aidl_checkapi.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070028#include "aidl_language.h"
Steven Moreland860b1942018-08-16 14:59:28 -070029#include "aidl_to_cpp.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090030#include "aidl_to_java.h"
Jiyong Park2a7c92b2020-07-22 19:12:36 +090031#include "logging.h"
Jeongik Cha047c5ee2019-08-07 23:16:49 +090032#include "options.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070033#include "tests/fake_io_delegate.h"
Christopher Wiley90be4e32015-10-20 14:55:25 -070034
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090035using android::aidl::internals::parse_preprocessed_file;
Christopher Wiley90be4e32015-10-20 14:55:25 -070036using android::aidl::test::FakeIoDelegate;
Christopher Wileyec31a052016-01-25 07:28:51 -080037using android::base::StringPrintf;
Christopher Wiley12e894a2016-01-29 11:55:07 -080038using std::set;
Christopher Wiley90be4e32015-10-20 14:55:25 -070039using std::string;
40using std::unique_ptr;
Christopher Wiley12e894a2016-01-29 11:55:07 -080041using std::vector;
Devin Moore7b8d5c92020-03-17 14:14:08 -070042using testing::TestParamInfo;
Jeongik Cha2a5b4d82019-08-06 19:37:59 +090043using testing::internal::CaptureStderr;
44using testing::internal::GetCapturedStderr;
Christopher Wiley90be4e32015-10-20 14:55:25 -070045
46namespace android {
47namespace aidl {
Christopher Wileyf8136192016-04-12 14:19:35 -070048namespace {
49
50const char kExpectedDepFileContents[] =
51R"(place/for/output/p/IFoo.java : \
52 p/IFoo.aidl
53
54p/IFoo.aidl :
55)";
56
Dan Willemsen93298ee2016-11-10 23:55:55 -080057const char kExpectedNinjaDepFileContents[] =
58R"(place/for/output/p/IFoo.java : \
59 p/IFoo.aidl
60)";
61
Jiyong Parkdf202122019-09-30 20:48:35 +090062const char kExpectedParcelableDeclarationDepFileContents[] =
63 R"( : \
64 p/Foo.aidl
65
66p/Foo.aidl :
67)";
68
69const char kExpectedStructuredParcelableDepFileContents[] =
Steven Moreland2a9a7d62019-02-05 16:11:54 -080070 R"(place/for/output/p/Foo.java : \
Christopher Wileyb1bbdf82016-04-21 11:43:45 -070071 p/Foo.aidl
72
73p/Foo.aidl :
74)";
75
Jiyong Parkd4e73c82019-07-24 21:39:15 +090076const char kExpectedJavaParcelableOutputContests[] =
Jeongik Chaa755c2a2018-12-12 16:28:23 +090077 R"(/*
78 * This file is auto-generated. DO NOT MODIFY.
Jeongik Chaa755c2a2018-12-12 16:28:23 +090079 */
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080080@android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090081public class Rect implements android.os.Parcelable
82{
83 // Comment
84
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080085 @android.annotation.Hide
Jeongik Chaa755c2a2018-12-12 16:28:23 +090086 public int x = 5;
87
Makoto Onuki78a1c1c2020-03-04 16:57:23 -080088 @android.annotation.Hide
89 @android.compat.annotation.UnsupportedAppUsage(expectedSignature = "dummy", implicitMember = "dummy", maxTargetSdk = 28, publicAlternatives = "dummy", trackingBug = 42L, overrideSourcePosition="Rect.aidl:7:1:10:14")
Steven Moreland541788d2020-05-21 22:05:52 +000090 public int y = 0;
Jiyong Parkd4e73c82019-07-24 21:39:15 +090091
92 public android.os.ParcelFileDescriptor fd;
Jeongik Chaa755c2a2018-12-12 16:28:23 +090093 public static final android.os.Parcelable.Creator<Rect> CREATOR = new android.os.Parcelable.Creator<Rect>() {
94 @Override
95 public Rect createFromParcel(android.os.Parcel _aidl_source) {
96 Rect _aidl_out = new Rect();
97 _aidl_out.readFromParcel(_aidl_source);
98 return _aidl_out;
99 }
100 @Override
101 public Rect[] newArray(int _aidl_size) {
102 return new Rect[_aidl_size];
103 }
104 };
105 @Override public final void writeToParcel(android.os.Parcel _aidl_parcel, int _aidl_flag)
106 {
107 int _aidl_start_pos = _aidl_parcel.dataPosition();
108 _aidl_parcel.writeInt(0);
109 _aidl_parcel.writeInt(x);
110 _aidl_parcel.writeInt(y);
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900111 if ((fd!=null)) {
112 _aidl_parcel.writeInt(1);
113 fd.writeToParcel(_aidl_parcel, 0);
114 }
115 else {
116 _aidl_parcel.writeInt(0);
117 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900118 int _aidl_end_pos = _aidl_parcel.dataPosition();
119 _aidl_parcel.setDataPosition(_aidl_start_pos);
120 _aidl_parcel.writeInt(_aidl_end_pos - _aidl_start_pos);
121 _aidl_parcel.setDataPosition(_aidl_end_pos);
122 }
123 public final void readFromParcel(android.os.Parcel _aidl_parcel)
124 {
125 int _aidl_start_pos = _aidl_parcel.dataPosition();
126 int _aidl_parcelable_size = _aidl_parcel.readInt();
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900127 try {
Jeongik Cha36f76c32020-07-28 00:25:52 +0900128 if (_aidl_parcelable_size < 0) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900129 x = _aidl_parcel.readInt();
130 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
131 y = _aidl_parcel.readInt();
132 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900133 if ((0!=_aidl_parcel.readInt())) {
134 fd = android.os.ParcelFileDescriptor.CREATOR.createFromParcel(_aidl_parcel);
135 }
136 else {
137 fd = null;
138 }
139 if (_aidl_parcel.dataPosition() - _aidl_start_pos >= _aidl_parcelable_size) return;
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900140 } finally {
Jeongik Cha8b329982020-09-01 20:59:36 +0900141 if (_aidl_start_pos > (Integer.MAX_VALUE - _aidl_parcelable_size)) {
142 throw new android.os.BadParcelableException("Overflow in the size of parcelable");
143 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900144 _aidl_parcel.setDataPosition(_aidl_start_pos + _aidl_parcelable_size);
145 }
146 }
147 @Override public int describeContents()
148 {
Jeongik Cha372a8c82018-12-12 16:31:11 +0900149 return 0;
150 }
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900151}
152)";
153
Devin Moore2f2077a2020-08-28 11:27:53 -0700154// clang-format off
155const char kExpectedCppHeaderOutput[] =
156 R"(#pragma once
157
158#include <binder/IBinder.h>
159#include <binder/IInterface.h>
160#include <binder/Status.h>
161#include <optional>
162#include <utils/String16.h>
163#include <utils/StrongPointer.h>
164#include <vector>
165
166class IFoo : public ::android::IInterface {
167public:
168 DECLARE_META_INTERFACE(Foo)
169 virtual ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>* _aidl_return) = 0;
170}; // class IFoo
171class IFooDefault : public IFoo {
172public:
173 ::android::IBinder* onAsBinder() override {
174 return nullptr;
175 }
176 ::android::binder::Status foo(::std::optional<::std::vector<::std::optional<::android::String16>>>*) override {
177 return ::android::binder::Status::fromStatusT(::android::UNKNOWN_TRANSACTION);
178 }
179}; // class IFooDefault
180)";
181// clang-format on
182
Christopher Wileyf8136192016-04-12 14:19:35 -0700183} // namespace
Christopher Wiley90be4e32015-10-20 14:55:25 -0700184
Devin Moore7b8d5c92020-03-17 14:14:08 -0700185class AidlTest : public ::testing::TestWithParam<Options::Language> {
Christopher Wiley90be4e32015-10-20 14:55:25 -0700186 protected:
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900187 AidlDefinedType* Parse(const string& path, const string& contents, AidlTypenames& typenames_,
188 Options::Language lang, AidlError* error = nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700189 const vector<string> additional_arguments = {}) {
Christopher Wiley0522cd52015-10-28 15:39:44 -0700190 io_delegate_.SetFileContents(path, contents);
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900191 vector<string> args;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700192 args.emplace_back("aidl");
193 args.emplace_back("--lang=" + Options::LanguageToString(lang));
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700194 for (const string& s : additional_arguments) {
195 args.emplace_back(s);
196 }
197 for (const string& f : preprocessed_files_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900198 args.emplace_back("--preprocessed=" + f);
199 }
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700200 for (const string& i : import_paths_) {
Jiyong Parkfbbfa932018-07-30 21:44:10 +0900201 args.emplace_back("--include=" + i);
202 }
203 args.emplace_back(path);
204 Options options = Options::From(args);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900205 vector<string> imported_files;
Jiyong Park8c380532018-08-30 14:55:26 +0900206 ImportResolver import_resolver{io_delegate_, path, import_paths_, {}};
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700207 AidlError actual_error = ::android::aidl::internals::load_and_validate_aidl(
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900208 path, options, io_delegate_, &typenames_, &imported_files);
Jiyong Parkb034bf02018-07-30 17:44:33 +0900209
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700210 if (error != nullptr) {
211 *error = actual_error;
212 }
Jiyong Parkb034bf02018-07-30 17:44:33 +0900213
214 if (actual_error != AidlError::OK) {
215 return nullptr;
216 }
217
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900218 const auto& defined_types = typenames_.MainDocument().DefinedTypes();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900219 EXPECT_EQ(1ul, defined_types.size());
220
Jiyong Park8e79b7f2020-07-20 20:52:38 +0900221 return defined_types.front().get();
Christopher Wiley90be4e32015-10-20 14:55:25 -0700222 }
Christopher Wiley0522cd52015-10-28 15:39:44 -0700223
Devin Moore7b8d5c92020-03-17 14:14:08 -0700224 Options::Language GetLanguage() { return GetParam(); }
225
Christopher Wiley0522cd52015-10-28 15:39:44 -0700226 FakeIoDelegate io_delegate_;
Christopher Wiley41544372015-11-03 14:52:29 -0800227 vector<string> preprocessed_files_;
Jiyong Park8c380532018-08-30 14:55:26 +0900228 set<string> import_paths_;
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900229 AidlTypenames typenames_;
Christopher Wiley90be4e32015-10-20 14:55:25 -0700230};
231
Devin Moore7b8d5c92020-03-17 14:14:08 -0700232// Instantiate the AidlTest parameterized suite, calling all of the TEST_P
233// tests with each of the supported languages as a parameter.
234INSTANTIATE_TEST_SUITE_P(AidlTestSuite, AidlTest,
235 testing::Values(Options::Language::CPP, Options::Language::JAVA,
Andrei Homescub62afd92020-05-11 19:24:59 -0700236 Options::Language::NDK, Options::Language::RUST),
Devin Moore7b8d5c92020-03-17 14:14:08 -0700237 [](const testing::TestParamInfo<Options::Language>& info) {
238 return Options::LanguageToString(info.param);
239 });
240
241TEST_P(AidlTest, AcceptMissingPackage) {
242 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { }", typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700243}
244
Devin Moore7b8d5c92020-03-17 14:14:08 -0700245TEST_P(AidlTest, EndsInSingleLineComment) {
246 EXPECT_NE(nullptr, Parse("IFoo.aidl", "interface IFoo { } // foo", typenames_, GetLanguage()));
Steven Moreland9c2988f2019-07-17 17:49:10 -0700247}
248
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000249TEST_P(AidlTest, InterfaceRequiresCorrectPath) {
250 const string expected_stderr =
251 "ERROR: a/Foo.aidl:1.11-21: IBar should be declared in a file called a/IBar.aidl\n";
252 const std::string file_contents = "package a; interface IBar {}";
253 CaptureStderr();
254 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
255 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
256}
257
258TEST_P(AidlTest, ParcelableRequiresCorrectPath) {
259 const string expected_stderr =
260 "ERROR: a/Foo.aidl:1.11-21: Bar should be declared in a file called a/Bar.aidl\n";
261 const std::string file_contents = "package a; interface Bar {}";
262 CaptureStderr();
263 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
264 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
265}
266
267TEST_P(AidlTest, UnstructuredParcelableRequiresCorrectPath) {
268 const string expected_stderr =
269 "ERROR: a/Foo.aidl:1.22-26: Bar should be declared in a file called a/Bar.aidl\n";
270 const std::string file_contents = "package a; parcelable Bar cpp_header \"anything.h\";";
271 CaptureStderr();
272 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
273 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
274}
275
276TEST_P(AidlTest, EnumRequiresCorrectPath) {
277 const string expected_stderr =
278 "ERROR: a/Foo.aidl:1.16-20: Bar should be declared in a file called a/Bar.aidl\n";
279 const std::string file_contents = "package a; enum Bar { A, }";
280 CaptureStderr();
281 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", file_contents, typenames_, GetLanguage()));
282 EXPECT_EQ(expected_stderr, GetCapturedStderr()) << file_contents;
283}
284
Devin Moore7b8d5c92020-03-17 14:14:08 -0700285TEST_P(AidlTest, RejectsArraysOfBinders) {
Jiyong Park8c380532018-08-30 14:55:26 +0900286 import_paths_.emplace("");
Christopher Wiley0522cd52015-10-28 15:39:44 -0700287 io_delegate_.SetFileContents("bar/IBar.aidl",
288 "package bar; interface IBar {}");
Devin Moore097a3ab2020-03-11 16:08:44 -0700289 const string path = "foo/IFoo.aidl";
290 const string contents =
291 "package foo;\n"
292 "import bar.IBar;\n"
293 "interface IFoo { void f(in IBar[] input); }";
294 const string expected_stderr = "ERROR: foo/IFoo.aidl:3.27-32: Binder type cannot be an array\n";
295 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700296 EXPECT_EQ(nullptr, Parse(path, contents, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700297 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley0522cd52015-10-28 15:39:44 -0700298}
299
Devin Moore7b8d5c92020-03-17 14:14:08 -0700300TEST_P(AidlTest, SupportOnlyOutParameters) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700301 const string interface_list = "package a; interface IBar { void f(out List<String> bar); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700302 EXPECT_NE(nullptr, Parse("a/IBar.aidl", interface_list, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900303}
Devin Moore097a3ab2020-03-11 16:08:44 -0700304
Jiyong Park40782d02020-07-24 19:17:43 +0900305TEST_P(AidlTest, RejectOutParametersForIBinder) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700306 const string interface_ibinder = "package a; interface IBaz { void f(out IBinder bar); }";
307 const string expected_ibinder_stderr =
308 "ERROR: a/IBaz.aidl:1.47-51: 'out IBinder bar' can only be an in parameter.\n";
309 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700310 EXPECT_EQ(nullptr, Parse("a/IBaz.aidl", interface_ibinder, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700311 EXPECT_EQ(expected_ibinder_stderr, GetCapturedStderr());
Jeongik Chaa2080bf2019-06-18 16:44:29 +0900312}
313
Jiyong Park40782d02020-07-24 19:17:43 +0900314TEST_P(AidlTest, RejectsOutParametersInOnewayInterface) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700315 const string oneway_interface = "package a; oneway interface IBar { void f(out int bar); }";
316 const string expected_stderr =
317 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700318 CaptureStderr();
319 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
320 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park40782d02020-07-24 19:17:43 +0900321}
Devin Moore7b8d5c92020-03-17 14:14:08 -0700322
Jiyong Park40782d02020-07-24 19:17:43 +0900323TEST_P(AidlTest, RejectsOutParametersInOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700324 const string oneway_method = "package a; interface IBar { oneway void f(out int bar); }";
Jiyong Park40782d02020-07-24 19:17:43 +0900325 const string expected_stderr =
326 "ERROR: a/IBar.aidl:1.40-42: oneway method 'f' cannot have out parameters\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700327 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700328 EXPECT_EQ(nullptr, Parse("a/IBar.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700329 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700330}
331
Devin Moore7b8d5c92020-03-17 14:14:08 -0700332TEST_P(AidlTest, RejectsOnewayNonVoidReturn) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700333 const string oneway_method = "package a; interface IFoo { oneway int f(); }";
334 const string expected_stderr =
335 "ERROR: a/IFoo.aidl:1.39-41: oneway method 'f' cannot return a value\n";
336 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700337 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700338 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley90be4e32015-10-20 14:55:25 -0700339}
340
Devin Moore7b8d5c92020-03-17 14:14:08 -0700341TEST_P(AidlTest, RejectsNullablePrimitive) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700342 const string oneway_method = "package a; interface IFoo { @nullable int f(); }";
343 const string expected_stderr =
344 "ERROR: a/IFoo.aidl:1.38-42: Primitive type cannot get nullable annotation\n";
345 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700346 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700347 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Casey Dahlin57dbe242015-12-04 11:44:02 -0800348}
349
Devin Moore2f2077a2020-08-28 11:27:53 -0700350TEST_P(AidlTest, AcceptNullableList) {
351 const string oneway_method = "package a; interface IFoo { @nullable List<String> f(); }";
352 const string expected_stderr = "";
353 CaptureStderr();
354 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
355 EXPECT_EQ(expected_stderr, GetCapturedStderr());
356}
357
Devin Moore7b8d5c92020-03-17 14:14:08 -0700358TEST_P(AidlTest, RejectsDuplicatedArgumentNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700359 const string method = "package a; interface IFoo { void f(int a, int a); }";
360 const string expected_stderr =
361 "ERROR: a/IFoo.aidl:1.33-35: method 'f' has duplicate argument name 'a'\n";
362 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700363 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700364 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandb3cd3c72018-10-11 12:37:45 -0700365}
366
Jeongik Cha13066da2020-08-06 15:43:19 +0900367TEST_P(AidlTest, RejectsDuplicatedFieldNames) {
368 const string method = "package a; parcelable Foo { int a; String a; }";
369 const string expected_stderr =
370 "ERROR: a/Foo.aidl:1.22-26: The parcelable 'Foo' has duplicate field name 'a'\n";
371 CaptureStderr();
372 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", method, typenames_, GetLanguage()));
373 EXPECT_EQ(expected_stderr, GetCapturedStderr());
374}
375
Devin Moore7b8d5c92020-03-17 14:14:08 -0700376TEST_P(AidlTest, RejectsDuplicatedAnnotationParams) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700377 const string method = "package a; interface IFoo { @UnsupportedAppUsage(foo=1, foo=2)void f(); }";
378 const string expected_stderr = "ERROR: a/IFoo.aidl:1.56-62: Trying to redefine parameter foo.\n";
379 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700380 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700381 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Onea9445fc62019-06-27 18:11:59 +0100382}
383
Devin Moore7b8d5c92020-03-17 14:14:08 -0700384TEST_P(AidlTest, RejectUnsupportedInterfaceAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700385 AidlError error;
386 const string method = "package a; @nullable interface IFoo { int f(); }";
387 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800388 "ERROR: a/IFoo.aidl:1.21-31: 'nullable' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900389 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, Descriptor\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700390 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700391 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700392 EXPECT_EQ(expected_stderr, GetCapturedStderr());
393 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800394}
395
Devin Moore7b8d5c92020-03-17 14:14:08 -0700396TEST_P(AidlTest, RejectUnsupportedTypeAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700397 AidlError error;
398 const string method = "package a; interface IFoo { @JavaOnlyStableParcelable int f(); }";
399 const string expected_stderr =
Devin Moore24f68572020-02-26 13:20:59 -0800400 "ERROR: a/IFoo.aidl:1.54-58: 'JavaOnlyStableParcelable' is not a supported annotation "
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +0900401 "for this node. It must be one of: Hide, UnsupportedAppUsage, nullable, utf8InCpp, JavaPassthrough\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700402 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700403 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700404 EXPECT_EQ(expected_stderr, GetCapturedStderr());
405 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800406}
407
Devin Moore7b8d5c92020-03-17 14:14:08 -0700408TEST_P(AidlTest, RejectUnsupportedParcelableAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700409 AidlError error;
410 const string method = "package a; @nullable parcelable IFoo cpp_header \"IFoo.h\";";
411 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000412 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900413 "It must be one of: Hide, JavaOnlyStableParcelable, UnsupportedAppUsage, VintfStability, "
Jeongik Chad0a10272020-08-06 16:33:36 +0900414 "JavaPassthrough, JavaOnlyImmutable\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700415 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000416 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700417 EXPECT_EQ(expected_stderr, GetCapturedStderr());
418 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800419}
420
Devin Moore7b8d5c92020-03-17 14:14:08 -0700421TEST_P(AidlTest, RejectUnsupportedParcelableDefineAnnotations) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700422 AidlError error;
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000423 const string method = "package a; @nullable parcelable IFoo { String a; String b; }";
Devin Moore097a3ab2020-03-11 16:08:44 -0700424 const string expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000425 "ERROR: a/IFoo.aidl:1.32-37: 'nullable' is not a supported annotation for this node. "
Jeongik Cha36f76c32020-07-28 00:25:52 +0900426 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, JavaDebug, "
Andrei Homescue61feb52020-08-18 15:44:24 -0700427 "JavaOnlyImmutable, FixedSize, RustDerive\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700428 CaptureStderr();
Steven Morelandebc3c5d2020-09-30 23:40:33 +0000429 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", method, typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700430 EXPECT_EQ(expected_stderr, GetCapturedStderr());
431 EXPECT_EQ(AidlError::BAD_TYPE, error);
Devin Moore24f68572020-02-26 13:20:59 -0800432}
433
Jiyong Park40782d02020-07-24 19:17:43 +0900434TEST_P(AidlTest, ParsesNonNullableAnnotation) {
435 auto parse_result =
436 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
437 ASSERT_NE(nullptr, parse_result);
438 const AidlInterface* interface = parse_result->AsInterface();
439 ASSERT_NE(nullptr, interface);
440 ASSERT_FALSE(interface->GetMethods().empty());
441 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsNullable());
442}
443
Devin Moore7b8d5c92020-03-17 14:14:08 -0700444TEST_P(AidlTest, ParsesNullableAnnotation) {
Jiyong Park40782d02020-07-24 19:17:43 +0900445 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @nullable String f(); }",
446 typenames_, GetLanguage());
447 ASSERT_NE(nullptr, parse_result);
448 const AidlInterface* interface = parse_result->AsInterface();
449 ASSERT_NE(nullptr, interface);
450 ASSERT_FALSE(interface->GetMethods().empty());
451 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsNullable());
452}
453
454TEST_P(AidlTest, ParsesNonUtf8Annotations) {
455 auto parse_result =
456 Parse("a/IFoo.aidl", "package a; interface IFoo { String f(); }", typenames_, GetLanguage());
457 ASSERT_NE(nullptr, parse_result);
458 const AidlInterface* interface = parse_result->AsInterface();
459 ASSERT_NE(nullptr, interface);
460 ASSERT_FALSE(interface->GetMethods().empty());
461 EXPECT_FALSE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800462}
463
Devin Moore7b8d5c92020-03-17 14:14:08 -0700464TEST_P(AidlTest, ParsesUtf8Annotations) {
Jiyong Park40782d02020-07-24 19:17:43 +0900465 auto parse_result = Parse("a/IFoo.aidl", "package a; interface IFoo { @utf8InCpp String f(); }",
466 typenames_, GetLanguage());
467 ASSERT_NE(nullptr, parse_result);
468 const AidlInterface* interface = parse_result->AsInterface();
469 ASSERT_NE(nullptr, interface);
470 ASSERT_FALSE(interface->GetMethods().empty());
471 EXPECT_TRUE(interface->GetMethods()[0]->GetType().IsUtf8InCpp());
Christopher Wileyec31a052016-01-25 07:28:51 -0800472}
473
Devin Moore7b8d5c92020-03-17 14:14:08 -0700474TEST_P(AidlTest, VintfRequiresStructuredAndStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700475 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700476 const string expected_stderr =
477 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
478 "\"vintf\"'\n"
479 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
480 "--structured\n";
481 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700482 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700483 GetLanguage(), &error));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700484 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700485 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700486}
487
Devin Moore7b8d5c92020-03-17 14:14:08 -0700488TEST_P(AidlTest, VintfRequiresStructured) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700489 AidlError error;
Devin Moore0d0e3f62020-03-30 17:45:39 -0700490 const string expected_stderr =
491 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface "
492 "--structured\n";
493 CaptureStderr();
Devin Moore097a3ab2020-03-11 16:08:44 -0700494 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700495 GetLanguage(), &error, {"--stability", "vintf"}));
Devin Moore0d0e3f62020-03-30 17:45:39 -0700496 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700497 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700498}
499
Devin Moore7b8d5c92020-03-17 14:14:08 -0700500TEST_P(AidlTest, VintfRequiresSpecifiedStability) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700501 AidlError error;
Devin Moore097a3ab2020-03-11 16:08:44 -0700502 const string expected_stderr =
503 "ERROR: IFoo.aidl:1.16-26: Must compile @VintfStability type w/ aidl_interface 'stability: "
504 "\"vintf\"'\n";
505 CaptureStderr();
506 ASSERT_EQ(nullptr, Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
Devin Moore7b8d5c92020-03-17 14:14:08 -0700507 GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700509 ASSERT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Morelanda57d0a62019-07-30 09:41:14 -0700510}
511
Devin Moore7b8d5c92020-03-17 14:14:08 -0700512TEST_P(AidlTest, ParsesStabilityAnnotations) {
Steven Morelanda57d0a62019-07-30 09:41:14 -0700513 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700514 auto parse_result = Parse("IFoo.aidl", "@VintfStability interface IFoo {}", typenames_,
515 GetLanguage(), &error, {"--structured", "--stability", "vintf"});
Steven Morelanda57d0a62019-07-30 09:41:14 -0700516 ASSERT_EQ(AidlError::OK, error);
517 ASSERT_NE(nullptr, parse_result);
518 const AidlInterface* interface = parse_result->AsInterface();
519 ASSERT_NE(nullptr, interface);
520 ASSERT_TRUE(interface->IsVintfStability());
Steven Morelanda57d0a62019-07-30 09:41:14 -0700521}
522
Jeongik Cha64783ed2019-06-07 18:30:54 +0900523TEST_F(AidlTest, ParsesJavaOnlyStableParcelable) {
524 Options java_options = Options::From("aidl -o out --structured a/Foo.aidl");
Jeongik Cha88f95a82020-01-15 13:02:16 +0900525 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out/include a/Foo.aidl");
526 Options cpp_structured_options =
Jeongik Cha64783ed2019-06-07 18:30:54 +0900527 Options::From("aidl --lang=cpp --structured -o out -h out/include a/Foo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -0700528 Options rust_options = Options::From("aidl --lang=rust -o out --structured a/Foo.aidl");
Jeongik Cha64783ed2019-06-07 18:30:54 +0900529 io_delegate_.SetFileContents(
Jeongik Cha88f95a82020-01-15 13:02:16 +0900530 "a/Foo.aidl",
531 StringPrintf("package a; @JavaOnlyStableParcelable parcelable Foo cpp_header \"Foo.h\" ;"));
Jeongik Cha64783ed2019-06-07 18:30:54 +0900532
533 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
Jeongik Cha88f95a82020-01-15 13:02:16 +0900534 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700535 const string expected_stderr =
Jeongik Cha88f95a82020-01-15 13:02:16 +0900536 "ERROR: a/Foo.aidl:1.48-52: Cannot declared parcelable in a --structured interface. "
Devin Moorec054bf82020-03-10 16:31:48 -0700537 "Parcelable must be defined in AIDL directly.\n";
538 CaptureStderr();
Jeongik Cha88f95a82020-01-15 13:02:16 +0900539 EXPECT_NE(0, ::android::aidl::compile_aidl(cpp_structured_options, io_delegate_));
Devin Moorec054bf82020-03-10 16:31:48 -0700540 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Andrei Homescub62afd92020-05-11 19:24:59 -0700541
542 CaptureStderr();
543 EXPECT_NE(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
544 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha64783ed2019-06-07 18:30:54 +0900545}
546
Jiyong Park43113fb2020-07-20 16:26:19 +0900547TEST_F(AidlTest, ParsesJavaDebugAnnotation) {
548 io_delegate_.SetFileContents("a/IFoo.aidl", R"(package a;
549 @JavaDebug parcelable IFoo { int a; float b; })");
550 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
551 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
552
553 string java_out;
554 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
555 EXPECT_THAT(java_out, testing::HasSubstr("public String toString() {"));
556
557 // Other backends shouldn't be bothered
558 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/IFoo.aidl");
559 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
560
561 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/IFoo.aidl");
562 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
563}
564
565TEST_F(AidlTest, RejectsJavaDebugAnnotation) {
566 {
567 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug interface IFoo{}");
568 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
569 CaptureStderr();
570 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
571 const std::string expected_stderr =
572 "ERROR: a/IFoo.aidl:1.22-32: 'JavaDebug' is not a supported annotation for this node. "
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900573 "It must be one of: Hide, UnsupportedAppUsage, VintfStability, JavaPassthrough, "
574 "Descriptor\n";
Jiyong Park43113fb2020-07-20 16:26:19 +0900575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
576 }
577
578 {
579 io_delegate_.SetFileContents("a/IFoo.aidl", "package a; @JavaDebug enum IFoo { A=1, }");
580 Options java_options = Options::From("aidl --lang=java -o out a/IFoo.aidl");
581 CaptureStderr();
582 EXPECT_NE(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
583 const std::string expected_stderr =
584 "ERROR: a/IFoo.aidl:1.27-32: 'JavaDebug' is not a supported annotation for this node. "
585 "It must be one of: Backing, Hide, VintfStability, JavaPassthrough\n";
586 EXPECT_EQ(expected_stderr, GetCapturedStderr());
587 }
588}
589
Jiyong Park27fd7fd2020-08-27 16:25:09 +0900590TEST_P(AidlTest, ParseDescriptorAnnotation) {
591 AidlError error;
592 auto parse_result = Parse("IFoo.aidl", R"(@Descriptor(value="IBar") interface IFoo{})",
593 typenames_, GetLanguage(), &error, {"--structured"});
594 ASSERT_EQ(AidlError::OK, error);
595 ASSERT_NE(nullptr, parse_result);
596 const AidlInterface* interface = parse_result->AsInterface();
597 ASSERT_NE(nullptr, interface);
598 ASSERT_EQ("IBar", interface->GetDescriptor());
599}
600
Jiyong Park40782d02020-07-24 19:17:43 +0900601TEST_P(AidlTest, AcceptsOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700602 const string oneway_method = "package a; interface IFoo { oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700603 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Jiyong Park40782d02020-07-24 19:17:43 +0900604}
605
606TEST_P(AidlTest, AcceptsOnewayInterface) {
607 const string oneway_interface = "package a; oneway interface IBar { void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700608 EXPECT_NE(nullptr, Parse("a/IBar.aidl", oneway_interface, typenames_, GetLanguage()));
Christopher Wiley90be4e32015-10-20 14:55:25 -0700609}
Christopher Wileyef140932015-11-03 09:29:19 -0800610
Devin Moore7b8d5c92020-03-17 14:14:08 -0700611TEST_P(AidlTest, AcceptsAnnotatedOnewayMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700612 const string oneway_method =
613 "package a; interface IFoo { @UnsupportedAppUsage oneway void f(int a); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -0700614 EXPECT_NE(nullptr, Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage()));
Artur Satayev91fe8712019-07-29 13:06:01 +0100615}
616
Steven Moreland65297cc2020-04-20 20:17:36 -0700617TEST_P(AidlTest, AnnotationsInMultiplePlaces) {
618 const string oneway_method =
619 "package a; interface IFoo { @UnsupportedAppUsage oneway @Hide void f(int a); }";
620 const AidlDefinedType* defined = Parse("a/IFoo.aidl", oneway_method, typenames_, GetLanguage());
621 ASSERT_NE(nullptr, defined);
622 const AidlInterface* iface = defined->AsInterface();
623 ASSERT_NE(nullptr, iface);
624
625 const auto& methods = iface->GetMethods();
626 ASSERT_EQ(1u, methods.size());
627 const auto& method = methods[0];
628 const AidlTypeSpecifier& ret_type = method->GetType();
629
630 // TODO(b/151102494): these annotations should be on the method
631 ASSERT_NE(nullptr, ret_type.UnsupportedAppUsage());
632 ASSERT_TRUE(ret_type.IsHide());
633}
634
Devin Moore7b8d5c92020-03-17 14:14:08 -0700635TEST_P(AidlTest, WritesComments) {
Artur Satayev91fe8712019-07-29 13:06:01 +0100636 string foo_interface =
637 "package a; /* foo */ interface IFoo {"
638 " /* i */ int i();"
639 " /* j */ @nullable String j();"
640 " /* k */ @UnsupportedAppUsage oneway void k(int a); }";
641
Devin Moore7b8d5c92020-03-17 14:14:08 -0700642 auto parse_result = Parse("a/IFoo.aidl", foo_interface, typenames_, GetLanguage());
Artur Satayev91fe8712019-07-29 13:06:01 +0100643 EXPECT_NE(nullptr, parse_result);
644 EXPECT_EQ("/* foo */", parse_result->GetComments());
645
646 const AidlInterface* interface = parse_result->AsInterface();
647 EXPECT_EQ("/* i */", interface->GetMethods()[0]->GetComments());
648 EXPECT_EQ("/* j */", interface->GetMethods()[1]->GetComments());
649 EXPECT_EQ("/* k */", interface->GetMethods()[2]->GetComments());
650}
651
Jooyung Han1a551d32020-10-05 15:37:26 +0900652TEST_P(AidlTest, CppHeaderCanBeIdentifierAsWell) {
653 io_delegate_.SetFileContents("p/cpp_header.aidl",
654 R"(package p;
655 parcelable cpp_header cpp_header "bar/header";)");
656 import_paths_.emplace("");
657 const string input_path = "p/IFoo.aidl";
658 const string input = R"(package p;
659 import p.cpp_header;
660 interface IFoo {
661 // get bar
662 cpp_header get();
663 })";
664
665 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
666 EXPECT_NE(nullptr, parse_result);
667 const AidlInterface* interface = parse_result->AsInterface();
668 EXPECT_EQ("// get bar\n", interface->GetMethods()[0]->GetComments());
669}
670
Christopher Wileyef140932015-11-03 09:29:19 -0800671TEST_F(AidlTest, ParsesPreprocessedFile) {
672 string simple_content = "parcelable a.Foo;\ninterface b.IBar;";
673 io_delegate_.SetFileContents("path", simple_content);
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700674 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900675 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700676 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
677 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800678}
679
680TEST_F(AidlTest, ParsesPreprocessedFileWithWhitespace) {
681 string simple_content = "parcelable a.Foo;\n interface b.IBar ;\t";
682 io_delegate_.SetFileContents("path", simple_content);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900683
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700684 EXPECT_FALSE(typenames_.ResolveTypename("a.Foo").is_resolved);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900685 EXPECT_TRUE(parse_preprocessed_file(io_delegate_, "path", &typenames_));
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700686 EXPECT_TRUE(typenames_.ResolveTypename("a.Foo").is_resolved);
687 EXPECT_TRUE(typenames_.ResolveTypename("b.IBar").is_resolved);
Christopher Wileyef140932015-11-03 09:29:19 -0800688}
689
Devin Moore7b8d5c92020-03-17 14:14:08 -0700690TEST_P(AidlTest, PreferImportToPreprocessed) {
Christopher Wiley41544372015-11-03 14:52:29 -0800691 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;");
692 io_delegate_.SetFileContents("one/IBar.aidl", "package one; "
693 "interface IBar {}");
694 preprocessed_files_.push_back("preprocessed");
Jiyong Park8c380532018-08-30 14:55:26 +0900695 import_paths_.emplace("");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900696 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700697 typenames_, GetLanguage());
Christopher Wiley41544372015-11-03 14:52:29 -0800698 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900699
Christopher Wiley41544372015-11-03 14:52:29 -0800700 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700701 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
702 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Christopher Wiley41544372015-11-03 14:52:29 -0800703 // But if we request just "IBar" we should get our imported one.
Steven Moreland02e012e2018-08-02 14:58:10 -0700704 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900705 ambiguous_type.Resolve(typenames_);
706 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
Christopher Wiley41544372015-11-03 14:52:29 -0800707}
708
Jiyong Park8f6ec462020-01-19 20:52:47 +0900709// Special case of PreferImportToPreprocessed. Imported type should be preferred
710// even when the preprocessed file already has the same type.
Devin Moore7b8d5c92020-03-17 14:14:08 -0700711TEST_P(AidlTest, B147918827) {
Jiyong Park8f6ec462020-01-19 20:52:47 +0900712 io_delegate_.SetFileContents("preprocessed", "interface another.IBar;\ninterface one.IBar;");
713 io_delegate_.SetFileContents("one/IBar.aidl",
714 "package one; "
715 "interface IBar {}");
716 preprocessed_files_.push_back("preprocessed");
717 import_paths_.emplace("");
718 auto parse_result = Parse("p/IFoo.aidl", "package p; import one.IBar; interface IFoo {}",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700719 typenames_, GetLanguage());
Jiyong Park8f6ec462020-01-19 20:52:47 +0900720 EXPECT_NE(nullptr, parse_result);
721
722 // We expect to know about both kinds of IBar
Steven Morelandcb1bcd72020-04-29 16:30:35 -0700723 EXPECT_TRUE(typenames_.ResolveTypename("one.IBar").is_resolved);
724 EXPECT_TRUE(typenames_.ResolveTypename("another.IBar").is_resolved);
Jiyong Park8f6ec462020-01-19 20:52:47 +0900725 // But if we request just "IBar" we should get our imported one.
726 AidlTypeSpecifier ambiguous_type(AIDL_LOCATION_HERE, "IBar", false, nullptr, "");
727 ambiguous_type.Resolve(typenames_);
728 EXPECT_EQ("one.IBar", ambiguous_type.GetName());
729}
730
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800731TEST_F(AidlTest, WritePreprocessedFile) {
732 io_delegate_.SetFileContents("p/Outer.aidl",
733 "package p; parcelable Outer.Inner;");
734 io_delegate_.SetFileContents("one/IBar.aidl", "package one; import p.Outer;"
735 "interface IBar {}");
736
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900737 vector<string> args {
738 "aidl",
739 "--preprocess",
740 "preprocessed",
741 "p/Outer.aidl",
742 "one/IBar.aidl"};
743 Options options = Options::From(args);
Casey Dahlinc1f39b42015-11-24 10:34:34 -0800744 EXPECT_TRUE(::android::aidl::preprocess_aidl(options, io_delegate_));
745
746 string output;
747 EXPECT_TRUE(io_delegate_.GetWrittenContents("preprocessed", &output));
748 EXPECT_EQ("parcelable p.Outer.Inner;\ninterface one.IBar;\n", output);
749}
750
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900751TEST_F(AidlTest, JavaParcelableOutput) {
Andrei Onea9445fc62019-06-27 18:11:59 +0100752 io_delegate_.SetFileContents(
753 "Rect.aidl",
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800754 "@Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100755 "parcelable Rect {\n"
756 " // Comment\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800757 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100758 " int x=5;\n"
Makoto Onuki78a1c1c2020-03-04 16:57:23 -0800759 " @Hide\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100760 " @UnsupportedAppUsage(maxTargetSdk = 28, trackingBug = 42, implicitMember = \"dummy\", "
Andrei Onea07fa3e02019-07-04 17:55:19 +0100761 "expectedSignature = \"dummy\", publicAlternatives = \"d\" \n + \"u\" + \n \"m\" \n + \"m\" "
762 "+ \"y\")\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100763 " int y;\n"
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900764 " ParcelFileDescriptor fd;\n"
Andrei Onea9445fc62019-06-27 18:11:59 +0100765 "}");
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900766
767 vector<string> args{"aidl", "Rect.aidl"};
768 Options options = Options::From(args);
769 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
770
771 string output;
772 EXPECT_TRUE(io_delegate_.GetWrittenContents("Rect.java", &output));
Jiyong Parkd4e73c82019-07-24 21:39:15 +0900773 EXPECT_EQ(kExpectedJavaParcelableOutputContests, output);
Jeongik Chaa755c2a2018-12-12 16:28:23 +0900774}
775
Devin Moore2f2077a2020-08-28 11:27:53 -0700776TEST_F(AidlTest, CppHeaderIncludes) {
777 io_delegate_.SetFileContents("IFoo.aidl",
778 "interface IFoo {\n"
779 " @nullable List<String> foo();\n"
780 "}");
781
782 vector<string> args{"aidl", "--lang=cpp", "IFoo.aidl"};
783 Options options = Options::From(args);
784 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
785 std::vector<std::string> empty;
786 EXPECT_EQ(empty, io_delegate_.ListFiles(""));
787 EXPECT_EQ(empty, io_delegate_.ListFiles("/"));
788 EXPECT_EQ(empty, io_delegate_.ListFiles("out"));
789
790 // Make sure the optional and String16.h includes are added
791 string output;
792 EXPECT_TRUE(io_delegate_.GetWrittenContents("IFoo.h", &output));
793 EXPECT_EQ(kExpectedCppHeaderOutput, output);
794}
795
Devin Moore7b8d5c92020-03-17 14:14:08 -0700796TEST_P(AidlTest, RequireOuterClass) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700797 const string expected_stderr = "ERROR: p/IFoo.aidl:1.54-60: Failed to resolve 'Inner'\n";
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800798 io_delegate_.SetFileContents("p/Outer.aidl",
799 "package p; parcelable Outer.Inner;");
Jiyong Park8c380532018-08-30 14:55:26 +0900800 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700801 CaptureStderr();
802 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
803 "package p; import p.Outer; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700804 typenames_, GetLanguage()));
Devin Moore097a3ab2020-03-11 16:08:44 -0700805 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800806}
807
Devin Moore7b8d5c92020-03-17 14:14:08 -0700808TEST_P(AidlTest, ParseCompoundParcelableFromPreprocess) {
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800809 io_delegate_.SetFileContents("preprocessed",
810 "parcelable p.Outer.Inner;");
811 preprocessed_files_.push_back("preprocessed");
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900812 auto parse_result = Parse("p/IFoo.aidl", "package p; interface IFoo { void f(in Inner c); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700813 typenames_, GetLanguage());
Christopher Wiley63bce2a2015-11-03 14:55:03 -0800814 // TODO(wiley): This should actually return nullptr because we require
815 // the outer class name. However, for legacy reasons,
816 // this behavior must be maintained. b/17415692
817 EXPECT_NE(nullptr, parse_result);
818}
819
Christopher Wiley632801d2015-11-05 14:15:49 -0800820TEST_F(AidlTest, FailOnParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700821 const string expected_foo_stderr =
822 "ERROR: p/IFoo.aidl:1.22-27: Refusing to generate code with unstructured parcelables. "
823 "Declared parcelables should be in their own file and/or cannot be used with --structured "
824 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700825 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; parcelable IFoo;");
826
Christopher Wiley632801d2015-11-05 14:15:49 -0800827 // By default, we shouldn't fail on parcelable.
Steven Morelande2c64b42018-09-18 15:06:37 -0700828 Options options1 = Options::From("aidl p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700829 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900830 EXPECT_EQ(0, ::android::aidl::compile_aidl(options1, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700831 EXPECT_EQ("", GetCapturedStderr());
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900832
Steven Morelande2c64b42018-09-18 15:06:37 -0700833 // -b considers this an error
Jiyong Park6f77e0c2018-07-28 16:55:44 +0900834 Options options2 = Options::From("aidl -b p/IFoo.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700835 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +0900836 EXPECT_NE(0, ::android::aidl::compile_aidl(options2, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700837 EXPECT_EQ(expected_foo_stderr, GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700838
Devin Moore097a3ab2020-03-11 16:08:44 -0700839 const string expected_bar_stderr =
840 "ERROR: p/IBar.aidl:1.22-26: Refusing to generate code with unstructured parcelables. "
841 "Declared parcelables should be in their own file and/or cannot be used with --structured "
842 "interfaces.\n";
Steven Morelande2c64b42018-09-18 15:06:37 -0700843 io_delegate_.SetFileContents("p/IBar.aidl", "package p; parcelable Foo; interface IBar{}");
844
Jiyong Parkda8c6932019-08-12 19:56:08 +0900845 // With '-b' option, a parcelable and an interface should fail.
Steven Morelande2c64b42018-09-18 15:06:37 -0700846 Options options3 = Options::From("aidl p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700847 CaptureStderr();
Jiyong Parkda8c6932019-08-12 19:56:08 +0900848 EXPECT_EQ(0, ::android::aidl::compile_aidl(options3, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700849 EXPECT_EQ("", GetCapturedStderr());
Steven Morelande2c64b42018-09-18 15:06:37 -0700850 Options options4 = Options::From("aidl -b p/IBar.aidl");
Devin Moore097a3ab2020-03-11 16:08:44 -0700851 CaptureStderr();
Steven Morelande2c64b42018-09-18 15:06:37 -0700852 EXPECT_NE(0, ::android::aidl::compile_aidl(options4, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -0700853 EXPECT_EQ(expected_bar_stderr, GetCapturedStderr());
Christopher Wiley632801d2015-11-05 14:15:49 -0800854}
855
Devin Moore7b8d5c92020-03-17 14:14:08 -0700856TEST_P(AidlTest, StructuredFailOnUnstructuredParcelable) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700857 const string expected_stderr =
858 "ERROR: ./o/WhoKnowsWhat.aidl:1.22-35: o.WhoKnowsWhat is not structured, but this is a "
859 "structured interface.\n";
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700860 io_delegate_.SetFileContents("o/WhoKnowsWhat.aidl", "package o; parcelable WhoKnowsWhat;");
861 import_paths_.emplace("");
Devin Moore097a3ab2020-03-11 16:08:44 -0700862 AidlError error;
863 CaptureStderr();
864 EXPECT_EQ(
865 nullptr,
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700866 Parse("p/IFoo.aidl",
867 "package p; import o.WhoKnowsWhat; interface IFoo { void f(in WhoKnowsWhat thisIs); }",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700868 typenames_, GetLanguage(), &error, {"--structured"}));
Devin Moore097a3ab2020-03-11 16:08:44 -0700869 EXPECT_EQ(expected_stderr, GetCapturedStderr());
870 EXPECT_EQ(AidlError::NOT_STRUCTURED, error);
Steven Moreland1eac5fa2018-08-27 19:35:05 -0700871}
872
Devin Moore7b8d5c92020-03-17 14:14:08 -0700873TEST_P(AidlTest, FailOnDuplicateConstantNames) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700874 AidlError error;
875 const string expected_stderr =
876 "ERROR: p/IFoo.aidl:4.34-45: Found duplicate constant name 'DUPLICATED'\n";
877 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900878 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
879 R"(package p;
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700880 interface IFoo {
881 const String DUPLICATED = "d";
882 const int DUPLICATED = 1;
883 }
884 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700885 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700886 EXPECT_EQ(expected_stderr, GetCapturedStderr());
887 EXPECT_EQ(AidlError::BAD_TYPE, error);
Christopher Wiley69b44cf2016-05-03 13:43:33 -0700888}
889
Devin Moore7b8d5c92020-03-17 14:14:08 -0700890TEST_P(AidlTest, FailOnManyDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700891 AidlError error;
Devin Moore5de18ed2020-04-02 13:52:29 -0700892 const string expected_stderr =
893 "ERROR: p/IFoo.aidl:3.33-38: You must declare only one type per file.\n";
Devin Moorec054bf82020-03-10 16:31:48 -0700894 CaptureStderr();
Steven Morelandc258abc2018-07-10 14:03:38 -0700895 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
896 R"(package p;
897 interface IFoo {}
Steven Morelandc258abc2018-07-10 14:03:38 -0700898 parcelable IBar {}
899 parcelable StructuredParcelable {}
900 interface IBaz {}
Jeongik Cha2a5b4d82019-08-06 19:37:59 +0900901 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700902 typenames_, GetLanguage(), &error));
Devin Moorec054bf82020-03-10 16:31:48 -0700903 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Steven Morelandc258abc2018-07-10 14:03:38 -0700904 // Parse success is important for clear error handling even if the cases aren't
905 // actually supported in code generation.
Devin Moore097a3ab2020-03-11 16:08:44 -0700906 EXPECT_EQ(AidlError::BAD_TYPE, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700907}
908
Devin Moore7b8d5c92020-03-17 14:14:08 -0700909TEST_P(AidlTest, FailOnNoDefinedTypes) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700910 AidlError error;
911 const string expected_stderr = "ERROR: p/IFoo.aidl:1.11-11: syntax error, unexpected $end\n";
912 CaptureStderr();
Devin Moore7b8d5c92020-03-17 14:14:08 -0700913 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p;)", typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700914 EXPECT_EQ(expected_stderr, GetCapturedStderr());
915 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Steven Morelandc258abc2018-07-10 14:03:38 -0700916}
917
Steven Morelandf9e922f2020-07-08 21:15:27 +0000918TEST_P(AidlTest, FailOnEmptyListWithComma) {
919 AidlError error;
920 const string expected_stderr =
921 "ERROR: p/Foo.aidl:1.45-47: syntax error, unexpected ',', expecting '}'\n";
922 CaptureStderr();
923 EXPECT_EQ(nullptr, Parse("p/Foo.aidl", R"(package p; parcelable Foo { uint64_t[] a = { , }; })",
924 typenames_, GetLanguage(), &error));
925 EXPECT_EQ(expected_stderr, GetCapturedStderr());
926 EXPECT_EQ(AidlError::PARSE_ERROR, error);
927}
928
Devin Moore7b8d5c92020-03-17 14:14:08 -0700929TEST_P(AidlTest, FailOnMalformedConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700930 AidlError error;
931 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -0700932 "ERROR: p/IFoo.aidl:3.50-71: Could not parse hexvalue: 0xffffffffffffffffff\n";
Devin Moore097a3ab2020-03-11 16:08:44 -0700933 CaptureStderr();
Jeongik Cha047c5ee2019-08-07 23:16:49 +0900934 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
935 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700936 interface IFoo {
937 const int BAD_HEX_VALUE = 0xffffffffffffffffff;
938 }
939 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700940 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -0700941 EXPECT_EQ(expected_stderr, GetCapturedStderr());
942 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Roshan Pius3b2203d2016-07-22 16:13:20 -0700943}
944
Jiyong Park18132182020-06-08 20:24:40 +0900945TEST_P(AidlTest, FailOnMalformedQualifiedNameAsIdentifier) {
946 AidlError error;
947 const string expected_stderr =
948 "ERROR: p/IFoo.aidl:1.25-26: syntax error, unexpected ';', expecting identifier or "
949 "cpp_header (which can also be used as an identifier)\n";
950 CaptureStderr();
951 // Notice the trailing dot(.) in the name, which isn't a correct name
952 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p; parcelable A.; )", typenames_,
953 GetLanguage(), &error));
954 EXPECT_EQ(expected_stderr, GetCapturedStderr());
955 EXPECT_EQ(AidlError::PARSE_ERROR, error);
956}
957
958TEST_P(AidlTest, FailOnMalformedQualifiedNameAsPackage) {
959 AidlError error;
960 const string expected_stderr =
961 "ERROR: p/IFoo.aidl:1.11-12: syntax error, unexpected ';', expecting identifier or "
962 "cpp_header (which can also be used as an identifier)\n";
963 CaptureStderr();
964 // Notice the trailing dot(.) in the package name
965 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl", R"(package p.; parcelable A; )", typenames_,
966 GetLanguage(), &error));
967 EXPECT_EQ(expected_stderr, GetCapturedStderr());
968 EXPECT_EQ(AidlError::PARSE_ERROR, error);
969}
970
Devin Moore7b8d5c92020-03-17 14:14:08 -0700971TEST_P(AidlTest, ParsePositiveConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700972 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700973 auto parse_result = Parse("p/IFoo.aidl",
974 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700975 interface IFoo {
976 const int POSITIVE_HEX_VALUE = 0xf5;
977 }
978 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700979 typenames_, GetLanguage(), &error);
980 EXPECT_NE(nullptr, parse_result);
981 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -0700982 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -0700983 const auto& cpp_constants = interface->GetConstantDeclarations();
984 EXPECT_EQ((size_t)1, cpp_constants.size());
985 EXPECT_EQ("POSITIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -0700986 EXPECT_TRUE(cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -0700987 EXPECT_EQ("245", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -0700988}
989
Devin Moore7b8d5c92020-03-17 14:14:08 -0700990TEST_P(AidlTest, ParseNegativeConstHexValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -0700991 AidlError error;
Devin Moore7b8d5c92020-03-17 14:14:08 -0700992 auto parse_result = Parse("p/IFoo.aidl",
993 R"(package p;
Roshan Pius3b2203d2016-07-22 16:13:20 -0700994 interface IFoo {
995 const int NEGATIVE_HEX_VALUE = 0xffffffff;
996 }
997 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -0700998 typenames_, GetLanguage(), &error);
999 ASSERT_NE(nullptr, parse_result);
1000 const AidlInterface* interface = parse_result->AsInterface();
Steven Moreland5557f1c2018-07-02 13:50:23 -07001001 ASSERT_NE(nullptr, interface);
Steven Moreland693640b2018-07-19 13:46:27 -07001002 const auto& cpp_constants = interface->GetConstantDeclarations();
1003 EXPECT_EQ((size_t)1, cpp_constants.size());
1004 EXPECT_EQ("NEGATIVE_HEX_VALUE", cpp_constants[0]->GetName());
Will McVickerd7d18df2019-09-12 13:40:50 -07001005 EXPECT_EQ(true, cpp_constants[0]->CheckValid(typenames_));
Steven Moreland860b1942018-08-16 14:59:28 -07001006 EXPECT_EQ("-1", cpp_constants[0]->ValueString(cpp::ConstantValueDecorator));
Roshan Pius3b2203d2016-07-22 16:13:20 -07001007}
1008
Devin Moore7b8d5c92020-03-17 14:14:08 -07001009TEST_P(AidlTest, UnderstandsNestedParcelables) {
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001010 io_delegate_.SetFileContents(
1011 "p/Outer.aidl",
1012 "package p; parcelable Outer.Inner cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001013 import_paths_.emplace("");
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001014 const string input_path = "p/IFoo.aidl";
1015 const string input = "package p; import p.Outer; interface IFoo"
1016 " { Outer.Inner get(); }";
1017
Devin Moore7b8d5c92020-03-17 14:14:08 -07001018 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1019 EXPECT_NE(nullptr, parse_result);
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001020
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001021 EXPECT_TRUE(typenames_.ResolveTypename("p.Outer.Inner").is_resolved);
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001022 // C++ uses "::" instead of "." to refer to a inner class.
Jeongik Cha047c5ee2019-08-07 23:16:49 +09001023 AidlTypeSpecifier nested_type(AIDL_LOCATION_HERE, "p.Outer.Inner", false, nullptr, "");
1024 EXPECT_EQ("::p::Outer::Inner", cpp::CppNameOf(nested_type, typenames_));
Ningyuan Wangd17c58b2016-09-29 14:33:14 -07001025}
1026
Devin Moore7b8d5c92020-03-17 14:14:08 -07001027TEST_P(AidlTest, UnderstandsNativeParcelables) {
Christopher Wiley9078d722015-11-17 10:23:49 -08001028 io_delegate_.SetFileContents(
1029 "p/Bar.aidl",
Casey Dahlincd639212015-12-15 12:51:04 -08001030 "package p; parcelable Bar cpp_header \"baz/header\";");
Jiyong Park8c380532018-08-30 14:55:26 +09001031 import_paths_.emplace("");
Christopher Wiley9078d722015-11-17 10:23:49 -08001032 const string input_path = "p/IFoo.aidl";
1033 const string input = "package p; import p.Bar; interface IFoo { }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001034 auto parse_result = Parse(input_path, input, typenames_, GetLanguage());
1035 EXPECT_NE(nullptr, parse_result);
Steven Morelandcb1bcd72020-04-29 16:30:35 -07001036 EXPECT_TRUE(typenames_.ResolveTypename("p.Bar").is_resolved);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001037 AidlTypeSpecifier native_type(AIDL_LOCATION_HERE, "p.Bar", false, nullptr, "");
1038 native_type.Resolve(typenames_);
1039
1040 EXPECT_EQ("p.Bar", java::InstantiableJavaSignatureOf(native_type, typenames_));
1041 // C++ understands C++ specific stuff
1042 EXPECT_EQ("::p::Bar", cpp::CppNameOf(native_type, typenames_));
1043 set<string> headers;
Devin Moore2f2077a2020-08-28 11:27:53 -07001044 cpp::AddHeaders(native_type, typenames_, &headers);
Devin Moore7b8d5c92020-03-17 14:14:08 -07001045 EXPECT_EQ(1u, headers.size());
1046 EXPECT_EQ(1u, headers.count("baz/header"));
Christopher Wiley9078d722015-11-17 10:23:49 -08001047}
1048
Christopher Wileyf8136192016-04-12 14:19:35 -07001049TEST_F(AidlTest, WritesCorrectDependencyFile) {
1050 // While the in tree build system always gives us an output file name,
1051 // other android tools take advantage of our ability to infer the intended
1052 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001053 vector<string> args = {
1054 "aidl",
1055 "-d dep/file/path",
1056 "-o place/for/output",
1057 "p/IFoo.aidl"};
1058 Options options = Options::From(args);
1059 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001060 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyf8136192016-04-12 14:19:35 -07001061 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001062 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Christopher Wileyf8136192016-04-12 14:19:35 -07001063 EXPECT_EQ(actual_dep_file_contents, kExpectedDepFileContents);
1064}
1065
Dan Willemsen93298ee2016-11-10 23:55:55 -08001066TEST_F(AidlTest, WritesCorrectDependencyFileNinja) {
1067 // While the in tree build system always gives us an output file name,
1068 // other android tools take advantage of our ability to infer the intended
1069 // file name. This test makes sure we handle this correctly.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001070 vector<string> args = {
1071 "aidl",
1072 "-d dep/file/path",
1073 "--ninja",
1074 "-o place/for/output",
1075 "p/IFoo.aidl"};
1076 Options options = Options::From(args);
1077 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; interface IFoo {}");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001078 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001079 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001080 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Dan Willemsen93298ee2016-11-10 23:55:55 -08001081 EXPECT_EQ(actual_dep_file_contents, kExpectedNinjaDepFileContents);
1082}
1083
Jiyong Parkdf202122019-09-30 20:48:35 +09001084TEST_F(AidlTest, WritesTrivialDependencyFileForParcelableDeclaration) {
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001085 // The SDK uses aidl to decide whether a .aidl file is a parcelable. It does
1086 // this by calling aidl with every .aidl file it finds, then parsing the
1087 // generated dependency files. Those that reference .java output files are
1088 // for interfaces and those that do not are parcelables. However, for both
1089 // parcelables and interfaces, we *must* generate a non-empty dependency file.
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001090 vector<string> args = {
1091 "aidl",
1092 "-o place/for/output",
1093 "-d dep/file/path",
1094 "p/Foo.aidl"};
1095 Options options = Options::From(args);
1096 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001097 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001098 string actual_dep_file_contents;
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001099 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
Jiyong Parkdf202122019-09-30 20:48:35 +09001100 EXPECT_EQ(actual_dep_file_contents, kExpectedParcelableDeclarationDepFileContents);
1101}
1102
1103TEST_F(AidlTest, WritesDependencyFileForStructuredParcelable) {
1104 vector<string> args = {
1105 "aidl",
1106 "--structured",
1107 "-o place/for/output",
1108 "-d dep/file/path",
1109 "p/Foo.aidl"};
1110 Options options = Options::From(args);
1111 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo {int a;}");
1112 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1113 string actual_dep_file_contents;
1114 EXPECT_TRUE(io_delegate_.GetWrittenContents(options.DependencyFile(), &actual_dep_file_contents));
1115 EXPECT_EQ(actual_dep_file_contents, kExpectedStructuredParcelableDepFileContents);
Christopher Wileyb1bbdf82016-04-21 11:43:45 -07001116}
1117
Jiyong Park9ca5c7e2019-10-17 15:01:14 +09001118TEST_F(AidlTest, NoJavaOutputForParcelableDeclaration) {
1119 vector<string> args = {
1120 "aidl",
1121 "--lang=java",
1122 "-o place/for/output",
1123 "p/Foo.aidl"};
1124 Options options = Options::From(args);
1125 io_delegate_.SetFileContents(options.InputFiles().front(), "package p; parcelable Foo;");
1126 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1127 string output_file_contents;
1128 EXPECT_FALSE(io_delegate_.GetWrittenContents(options.OutputFile(), &output_file_contents));
1129}
1130
Jeongik Cha08ca2182019-11-21 14:01:13 +09001131// TODO(b/136048684)
Devin Moore7b8d5c92020-03-17 14:14:08 -07001132TEST_P(AidlTest, PrimitiveList) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001133 const string primitive_interface =
Jeongik Cha08ca2182019-11-21 14:01:13 +09001134 "package a; interface IFoo {\n"
1135 " List<int> foo(); }";
Devin Moore7b8d5c92020-03-17 14:14:08 -07001136 string expected_stderr;
1137 switch (GetLanguage()) {
1138 case Options::Language::CPP:
1139 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001140 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001141 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in cpp supports only "
1142 "String and IBinder.\n";
1143 break;
1144 case Options::Language::JAVA:
1145 expected_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001146 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n"
Devin Moore7b8d5c92020-03-17 14:14:08 -07001147 "ERROR: a/IFoo.aidl:2.1-7: List<int> is not supported. List in Java supports only "
1148 "String, IBinder, and ParcelFileDescriptor.\n";
1149 break;
1150 case Options::Language::NDK:
Andrei Homescub62afd92020-05-11 19:24:59 -07001151 case Options::Language::RUST:
1152 expected_stderr =
1153 "ERROR: a/IFoo.aidl:2.1-7: A generic type cannot have any primitive type parameters.\n";
1154 break;
Devin Moore7b8d5c92020-03-17 14:14:08 -07001155 default:
1156 AIDL_FATAL(AIDL_LOCATION_HERE)
1157 << "Unexpected Options::Language enumerator: " << static_cast<size_t>(GetLanguage());
1158 }
1159 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001160 AidlTypenames tn1;
1161 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001162 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore7b8d5c92020-03-17 14:14:08 -07001163
1164 string primitive_parcelable =
1165 "package a; parcelable IFoo {\n"
Jeongik Cha08ca2182019-11-21 14:01:13 +09001166 " List<int> foo;}";
Devin Moore097a3ab2020-03-11 16:08:44 -07001167 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001168 AidlTypenames tn2;
1169 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage()));
Devin Moore7b8d5c92020-03-17 14:14:08 -07001170 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Cha08ca2182019-11-21 14:01:13 +09001171}
1172
Devin Moore21b26772020-08-26 16:37:56 -07001173TEST_P(AidlTest, RejectsListArray) {
Devin Moore6a01ca12020-08-28 10:24:19 -07001174 const string expected_stderr = "ERROR: a/Foo.aidl:2.1-7: List[] is not supported.\n";
Devin Moore21b26772020-08-26 16:37:56 -07001175 const string list_array_parcelable =
1176 "package a; parcelable Foo {\n"
1177 " List[] lists; }";
1178 CaptureStderr();
1179 EXPECT_EQ(nullptr, Parse("a/Foo.aidl", list_array_parcelable, typenames_, GetLanguage()));
1180 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1181}
1182
Jiyong Parkf8d53612020-05-04 14:06:13 +09001183TEST_P(AidlTest, RejectsPrimitiveListInStableAidl) {
1184 AidlError error;
1185 string expected_stderr =
1186 "ERROR: a/IFoo.aidl:2.7-11: "
1187 "Encountered an untyped List or Map. The use of untyped List/Map is "
1188 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1189 "the receiving side. Consider switching to an array or a generic List/Map.\n";
1190 if (GetLanguage() != Options::Language::JAVA) {
1191 expected_stderr =
1192 "ERROR: a/IFoo.aidl:2.1-7: "
1193 "Currently, only the Java backend supports non-generic List.\n";
1194 }
1195
1196 const string primitive_interface =
1197 "package a; interface IFoo {\n"
1198 " List foo(); }";
1199 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001200 AidlTypenames tn1;
1201 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_interface, tn1, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001202 {"--structured"}));
1203 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkf8d53612020-05-04 14:06:13 +09001204
1205 string primitive_parcelable =
1206 "package a; parcelable IFoo {\n"
1207 " List foo;}";
1208 CaptureStderr();
Jiyong Park40782d02020-07-24 19:17:43 +09001209 AidlTypenames tn2;
1210 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", primitive_parcelable, tn2, GetLanguage(), &error,
Jiyong Parkf8d53612020-05-04 14:06:13 +09001211 {"--structured"}));
1212 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1213}
1214
Jeongik Cha225519b2020-08-29 01:55:32 +09001215TEST_P(AidlTest, ExtensionTest) {
1216 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001217 string extendable_parcelable =
1218 "package a; parcelable Data {\n"
1219 " ParcelableHolder extension;\n"
1220 " ParcelableHolder extension2;\n"
1221 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001222 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1223 EXPECT_EQ(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1224 EXPECT_EQ(
1225 "ERROR: a/Data.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1226 "yet.\n",
1227 GetCapturedStderr());
1228 } else {
1229 EXPECT_NE(nullptr, Parse("a/Data.aidl", extendable_parcelable, typenames_, GetLanguage()));
1230 EXPECT_EQ("", GetCapturedStderr());
1231 }
1232}
1233TEST_P(AidlTest, ParcelableHolderAsReturnType) {
1234 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001235 string parcelableholder_return_interface =
1236 "package a; interface IFoo {\n"
1237 " ParcelableHolder foo();\n"
1238 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001239 EXPECT_EQ(nullptr,
1240 Parse("a/IFoo.aidl", parcelableholder_return_interface, typenames_, GetLanguage()));
Jeongik Cha649e8a72020-03-27 17:47:40 +09001241
Jeongik Cha225519b2020-08-29 01:55:32 +09001242 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1243 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001244 "ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001245 "ERROR: a/IFoo.aidl:2.1-19: The NDK and Rust backend does not support ParcelableHolder "
1246 "yet.\n",
1247 GetCapturedStderr());
1248 return;
1249 }
1250 EXPECT_EQ("ERROR: a/IFoo.aidl:2.19-23: ParcelableHolder cannot be a return type\n",
1251 GetCapturedStderr());
1252}
1253
1254TEST_P(AidlTest, ParcelableHolderAsArgumentType) {
1255 CaptureStderr();
Jeongik Cha649e8a72020-03-27 17:47:40 +09001256 string extendable_parcelable_arg_interface =
1257 "package a; interface IFoo {\n"
1258 " void foo(in ParcelableHolder ph);\n"
1259 "}";
Jeongik Cha225519b2020-08-29 01:55:32 +09001260 EXPECT_EQ(nullptr,
1261 Parse("a/IFoo.aidl", extendable_parcelable_arg_interface, typenames_, GetLanguage()));
1262
1263 if (GetLanguage() == Options::Language::NDK || GetLanguage() == Options::Language::RUST) {
1264 EXPECT_EQ(
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001265 "ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n"
Jeongik Cha225519b2020-08-29 01:55:32 +09001266 "ERROR: a/IFoo.aidl:2.14-31: The NDK and Rust backend does not support ParcelableHolder "
1267 "yet.\n",
1268 GetCapturedStderr());
1269 return;
1270 }
1271 EXPECT_EQ("ERROR: a/IFoo.aidl:2.31-34: ParcelableHolder cannot be an argument type\n",
1272 GetCapturedStderr());
Jeongik Cha649e8a72020-03-27 17:47:40 +09001273}
1274
Jiyong Park02da7422018-07-16 16:00:26 +09001275TEST_F(AidlTest, ApiDump) {
1276 io_delegate_.SetFileContents(
1277 "foo/bar/IFoo.aidl",
1278 "package foo.bar;\n"
1279 "import foo.bar.Data;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001280 "// comment @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001281 "interface IFoo {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001282 " /* @hide */\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001283 " int foo(out int[] a, String b, boolean c, inout List<String> d);\n"
1284 " int foo2(@utf8InCpp String x, inout List<String> y);\n"
1285 " IFoo foo3(IFoo foo);\n"
1286 " Data getData();\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001287 " // @hide\n"
Jiyong Parka428d212018-08-29 22:26:30 +09001288 " const int A = 1;\n"
1289 " const String STR = \"Hello\";\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001290 "}\n");
1291 io_delegate_.SetFileContents("foo/bar/Data.aidl",
1292 "package foo.bar;\n"
1293 "import foo.bar.IFoo;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001294 "/* @hide*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001295 "parcelable Data {\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001296 " // @hide\n"
Jiyong Parka468e2a2018-08-29 21:25:18 +09001297 " int x = 10;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001298 " // @hide\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001299 " int y;\n"
1300 " IFoo foo;\n"
1301 " List<IFoo> a;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001302 " /*@hide2*/\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001303 " List<foo.bar.IFoo> b;\n"
Jeongik Cha997281d2020-01-16 15:23:59 +09001304 " // It should be @hide property\n"
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001305 " @nullable String[] c;\n"
Jiyong Park02da7422018-07-16 16:00:26 +09001306 "}\n");
1307 io_delegate_.SetFileContents("api.aidl", "");
Jiyong Park633246c2019-11-25 10:50:05 +09001308 vector<string> args = {"aidl", "--dumpapi", "--out=dump", "--include=.",
1309 "foo/bar/IFoo.aidl", "foo/bar/Data.aidl"};
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001310 Options options = Options::From(args);
Jiyong Park02da7422018-07-16 16:00:26 +09001311 bool result = dump_api(options, io_delegate_);
1312 ASSERT_TRUE(result);
1313 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001314 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001315 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001316/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001317interface IFoo {
Jeongik Cha997281d2020-01-16 15:23:59 +09001318 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001319 int foo(out int[] a, String b, boolean c, inout List<String> d);
1320 int foo2(@utf8InCpp String x, inout List<String> y);
1321 foo.bar.IFoo foo3(foo.bar.IFoo foo);
1322 foo.bar.Data getData();
Jeongik Cha997281d2020-01-16 15:23:59 +09001323 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001324 const int A = 1;
1325 const String STR = "Hello";
1326}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001327)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001328
Jiyong Parke59c3682018-09-11 23:10:25 +09001329 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/Data.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001330 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jeongik Cha997281d2020-01-16 15:23:59 +09001331/* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001332parcelable Data {
Jeongik Cha997281d2020-01-16 15:23:59 +09001333 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001334 int x = 10;
Jeongik Cha997281d2020-01-16 15:23:59 +09001335 /* @hide */
Jiyong Parke59c3682018-09-11 23:10:25 +09001336 int y;
1337 foo.bar.IFoo foo;
1338 List<foo.bar.IFoo> a;
1339 List<foo.bar.IFoo> b;
Jeongik Cha997281d2020-01-16 15:23:59 +09001340 /* @hide */
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001341 @nullable String[] c;
Jiyong Park02da7422018-07-16 16:00:26 +09001342}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001343)"));
Jiyong Park02da7422018-07-16 16:00:26 +09001344}
1345
Jiyong Parked65bf42018-08-28 15:43:27 +09001346TEST_F(AidlTest, ApiDumpWithManualIds) {
1347 io_delegate_.SetFileContents(
1348 "foo/bar/IFoo.aidl",
1349 "package foo.bar;\n"
1350 "interface IFoo {\n"
1351 " int foo() = 1;\n"
1352 " int bar() = 2;\n"
1353 " int baz() = 10;\n"
1354 "}\n");
1355
Jiyong Parke59c3682018-09-11 23:10:25 +09001356 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001357 Options options = Options::From(args);
1358 bool result = dump_api(options, io_delegate_);
1359 ASSERT_TRUE(result);
1360 string actual;
Jiyong Parke59c3682018-09-11 23:10:25 +09001361 EXPECT_TRUE(io_delegate_.GetWrittenContents("dump/foo/bar/IFoo.aidl", &actual));
Paul Trautrimb01451d2020-02-27 13:10:16 +09001362 EXPECT_EQ(actual, string(kPreamble).append(R"(package foo.bar;
Jiyong Parke59c3682018-09-11 23:10:25 +09001363interface IFoo {
1364 int foo() = 1;
1365 int bar() = 2;
1366 int baz() = 10;
Jiyong Parked65bf42018-08-28 15:43:27 +09001367}
Paul Trautrimb01451d2020-02-27 13:10:16 +09001368)"));
Jiyong Parked65bf42018-08-28 15:43:27 +09001369}
1370
1371TEST_F(AidlTest, ApiDumpWithManualIdsOnlyOnSomeMethods) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001372 const string expected_stderr =
1373 "ERROR: foo/bar/IFoo.aidl:4.8-12: You must either assign id's to all methods or to none of "
1374 "them.\n";
Jiyong Parked65bf42018-08-28 15:43:27 +09001375 io_delegate_.SetFileContents(
1376 "foo/bar/IFoo.aidl",
1377 "package foo.bar;\n"
1378 "interface IFoo {\n"
1379 " int foo() = 1;\n"
1380 " int bar();\n"
1381 " int baz() = 10;\n"
1382 "}\n");
1383
Jiyong Parke59c3682018-09-11 23:10:25 +09001384 vector<string> args = {"aidl", "--dumpapi", "-o dump", "foo/bar/IFoo.aidl"};
Jiyong Parked65bf42018-08-28 15:43:27 +09001385 Options options = Options::From(args);
Devin Moore097a3ab2020-03-11 16:08:44 -07001386 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09001387 EXPECT_FALSE(dump_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001388 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09001389}
1390
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001391TEST_F(AidlTest, CheckNumGenericTypeSecifier) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001392 const string expected_list_stderr =
Steven Morelandebc3c5d2020-09-30 23:40:33 +00001393 "ERROR: p/IFoo.aidl:1.37-41: List can only have one type parameter, but got: "
1394 "'List<String,String>'\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07001395 const string expected_map_stderr =
1396 "ERROR: p/IFoo.aidl:1.37-40: Map must have 0 or 2 type parameters, but got 'Map<String>'\n";
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001397 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1398 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001399 "package p; interface IFoo {"
1400 "void foo(List<String, String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001401 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001402 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001403 EXPECT_EQ(expected_list_stderr, GetCapturedStderr());
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001404
Jiyong Park6f77e0c2018-07-28 16:55:44 +09001405 io_delegate_.SetFileContents(options.InputFiles().front(),
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001406 "package p; interface IFoo {"
1407 "void foo(Map<String> a);}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001408 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001409 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001410 EXPECT_EQ(expected_map_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001411}
1412
Jeongik Chae48d9942020-01-02 17:39:00 +09001413TEST_F(AidlTest, CheckTypeParameterInMapType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001414 const string expected_stderr =
1415 "ERROR: p/IFoo.aidl:1.28-31: The type of key in map must be String, but it is 'p.Bar'\n";
Jeongik Chae48d9942020-01-02 17:39:00 +09001416 Options options = Options::From("aidl -I p p/IFoo.aidl");
1417 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar { String s; }");
1418
1419 io_delegate_.SetFileContents("p/IFoo.aidl",
1420 "package p; interface IFoo {"
1421 "Map<String, Bar> foo();}");
1422 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1423
1424 io_delegate_.SetFileContents("p/IFoo.aidl",
1425 "package p; interface IFoo {"
1426 "Map<Bar, Bar> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001427 CaptureStderr();
Jeongik Chae48d9942020-01-02 17:39:00 +09001428 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001429 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chae48d9942020-01-02 17:39:00 +09001430
1431 io_delegate_.SetFileContents("p/IFoo.aidl",
1432 "package p; interface IFoo {"
1433 "Map<String, String> foo();}");
1434 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1435
1436 io_delegate_.SetFileContents("p/IFoo.aidl",
1437 "package p; interface IFoo {"
1438 "Map<String, ParcelFileDescriptor> foo();}");
1439 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1440}
1441
Jeongik Chadf76dc72019-11-28 00:08:47 +09001442TEST_F(AidlTest, WrongGenericType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001443 const string expected_stderr = "ERROR: p/IFoo.aidl:1.28-34: String is not a generic type.\n";
Jeongik Chadf76dc72019-11-28 00:08:47 +09001444 Options options = Options::From("aidl p/IFoo.aidl IFoo.java");
1445 io_delegate_.SetFileContents(options.InputFiles().front(),
1446 "package p; interface IFoo {"
1447 "String<String> foo(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001448 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001449 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001450 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001451}
1452
1453TEST_F(AidlTest, UserDefinedUnstructuredGenericParcelableType) {
1454 Options optionsForParcelable = Options::From("aidl -I p p/Bar.aidl");
1455 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001456 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001457 EXPECT_NE(0, ::android::aidl::compile_aidl(optionsForParcelable, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001458 EXPECT_EQ("ERROR: p/Bar.aidl:1.22-26: Every type parameter should be unique.\n",
1459 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001460
1461 Options options = Options::From("aidl -I p p/IFoo.aidl");
1462 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar;");
1463 io_delegate_.SetFileContents("p/IFoo.aidl",
1464 "package p; interface IFoo {"
1465 "Bar<String, String> foo();}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001466 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001467 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001468 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar is not a generic type.\n", GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001469 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T>;");
Devin Moore097a3ab2020-03-11 16:08:44 -07001470 CaptureStderr();
Jeongik Chadf76dc72019-11-28 00:08:47 +09001471 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001472 EXPECT_EQ("ERROR: p/IFoo.aidl:1.28-31: p.Bar must have 1 type parameters, but got 2\n",
1473 GetCapturedStderr());
Jeongik Chadf76dc72019-11-28 00:08:47 +09001474 io_delegate_.SetFileContents("p/Bar.aidl", "package p; parcelable Bar<T, V>;");
1475 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1476 io_delegate_.SetFileContents("p/IFoo.aidl",
1477 "package p; interface IFoo {"
1478 "Bar<String, ParcelFileDescriptor> foo();}");
1479 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chae74c86d2019-12-12 16:54:03 +09001480
1481 io_delegate_.SetFileContents("p/IFoo.aidl",
1482 "package p; interface IFoo {"
1483 "Bar<int, long> foo();}");
1484
1485 io_delegate_.SetFileContents("p/IFoo.aidl",
1486 "package p; interface IFoo {"
1487 "Bar<int[], long[]> foo();}");
1488
1489 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jeongik Chadf76dc72019-11-28 00:08:47 +09001490}
1491
Jeongik Cha0e426012019-07-29 15:57:02 +09001492TEST_F(AidlTest, FailOnMultipleTypesInSingleFile) {
1493 std::vector<std::string> rawOptions{"aidl --lang=java -o out foo/bar/Foo.aidl",
Andrei Homescub62afd92020-05-11 19:24:59 -07001494 "aidl --lang=cpp -o out -h out/include foo/bar/Foo.aidl",
1495 "aidl --lang=rust -o out foo/bar/Foo.aidl"};
Devin Moore5de18ed2020-04-02 13:52:29 -07001496 for (const auto& rawOption : rawOptions) {
1497 string expected_stderr =
1498 "ERROR: foo/bar/Foo.aidl:3.1-10: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001499 Options options = Options::From(rawOption);
1500 io_delegate_.SetFileContents(options.InputFiles().front(),
1501 "package foo.bar;\n"
1502 "interface IFoo1 { int foo(); }\n"
1503 "interface IFoo2 { int foo(); }\n"
1504 "parcelable Data1 { int a; int b;}\n"
1505 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001506 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001507 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001508 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001509
Jeongik Cha0e426012019-07-29 15:57:02 +09001510 io_delegate_.SetFileContents(options.InputFiles().front(),
1511 "package foo.bar;\n"
1512 "interface IFoo1 { int foo(); }\n"
1513 "interface IFoo2 { int foo(); }\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001514 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001515 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001516 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001517
Devin Moore5de18ed2020-04-02 13:52:29 -07001518 expected_stderr = "ERROR: foo/bar/Foo.aidl:3.11-17: You must declare only one type per file.\n";
Jeongik Cha0e426012019-07-29 15:57:02 +09001519 io_delegate_.SetFileContents(options.InputFiles().front(),
1520 "package foo.bar;\n"
1521 "parcelable Data1 { int a; int b;}\n"
1522 "parcelable Data2 { int a; int b;}\n");
Devin Moore097a3ab2020-03-11 16:08:44 -07001523 CaptureStderr();
Jeongik Cha0e426012019-07-29 15:57:02 +09001524 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001525 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkb034bf02018-07-30 17:44:33 +09001526 }
1527}
1528
Devin Moorebdba2a82020-03-31 15:19:02 -07001529TEST_P(AidlTest, FailParseOnEmptyFile) {
1530 const string contents = "";
1531 const string expected_stderr = "ERROR: a/IFoo.aidl:1.1-1: syntax error, unexpected $end\n";
1532 CaptureStderr();
1533 EXPECT_EQ(nullptr, Parse("a/IFoo.aidl", contents, typenames_, GetLanguage()));
1534 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1535}
1536
Jiyong Parkb034bf02018-07-30 17:44:33 +09001537TEST_F(AidlTest, MultipleInputFiles) {
1538 Options options = Options::From(
Jiyong Park633246c2019-11-25 10:50:05 +09001539 "aidl --lang=java -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001540
1541 io_delegate_.SetFileContents(options.InputFiles().at(0),
1542 "package foo.bar;\n"
1543 "import foo.bar.Data;\n"
1544 "interface IFoo { Data getData(); }\n");
1545
1546 io_delegate_.SetFileContents(options.InputFiles().at(1),
1547 "package foo.bar;\n"
1548 "import foo.bar.IFoo;\n"
1549 "parcelable Data { IFoo foo; }\n");
1550
1551 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1552
1553 string content;
1554 for (const auto file : {
1555 "out/foo/bar/IFoo.java", "out/foo/bar/Data.java"}) {
1556 content.clear();
1557 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1558 EXPECT_FALSE(content.empty());
1559 }
1560}
1561
1562TEST_F(AidlTest, MultipleInputFilesCpp) {
1563 Options options = Options::From("aidl --lang=cpp -o out -h out/include "
Jiyong Park633246c2019-11-25 10:50:05 +09001564 "-I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001565
1566 io_delegate_.SetFileContents(options.InputFiles().at(0),
1567 "package foo.bar;\n"
1568 "import foo.bar.Data;\n"
1569 "interface IFoo { Data getData(); }\n");
1570
1571 io_delegate_.SetFileContents(options.InputFiles().at(1),
1572 "package foo.bar;\n"
1573 "import foo.bar.IFoo;\n"
1574 "parcelable Data { IFoo foo; }\n");
1575
1576 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1577
1578 string content;
1579 for (const auto file : {
Jiyong Parkb03551f2018-08-06 19:20:51 +09001580 "out/foo/bar/IFoo.cpp", "out/foo/bar/Data.cpp",
Jiyong Parkb034bf02018-07-30 17:44:33 +09001581 "out/include/foo/bar/IFoo.h", "out/include/foo/bar/Data.h",
1582 "out/include/foo/bar/BpFoo.h", "out/include/foo/bar/BpData.h",
1583 "out/include/foo/bar/BnFoo.h", "out/include/foo/bar/BnData.h"}) {
1584 content.clear();
1585 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1586 EXPECT_FALSE(content.empty());
1587 }
Jiyong Park1d2df7d2018-07-23 15:22:50 +09001588}
1589
Andrei Homescub62afd92020-05-11 19:24:59 -07001590TEST_F(AidlTest, MultipleInputFilesRust) {
1591 Options options =
1592 Options::From("aidl --lang=rust -o out -I . foo/bar/IFoo.aidl foo/bar/Data.aidl");
1593
1594 io_delegate_.SetFileContents(options.InputFiles().at(0),
1595 "package foo.bar;\n"
1596 "import foo.bar.Data;\n"
1597 "interface IFoo { Data getData(); }\n");
1598
1599 io_delegate_.SetFileContents(options.InputFiles().at(1),
1600 "package foo.bar;\n"
1601 "import foo.bar.IFoo;\n"
1602 "parcelable Data { IFoo foo; }\n");
1603
1604 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
1605
1606 string content;
1607 for (const auto file : {"out/foo/bar/IFoo.rs", "out/foo/bar/Data.rs"}) {
1608 content.clear();
1609 EXPECT_TRUE(io_delegate_.GetWrittenContents(file, &content));
1610 EXPECT_FALSE(content.empty());
1611 }
1612}
1613
Devin Moore097a3ab2020-03-11 16:08:44 -07001614TEST_F(AidlTest, ConflictWithMetaTransactionGetVersion) {
1615 const string expected_stderr =
1616 "ERROR: p/IFoo.aidl:1.31-51: method getInterfaceVersion() is reserved for internal use.\n";
Jiyong Park309668e2018-07-28 16:55:44 +09001617 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
1618 // int getInterfaceVersion() is one of the meta transactions
1619 io_delegate_.SetFileContents(options.InputFiles().front(),
1620 "package p; interface IFoo {"
1621 "int getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001622 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001623 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001624 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1625}
Jiyong Park309668e2018-07-28 16:55:44 +09001626
Devin Moore097a3ab2020-03-11 16:08:44 -07001627TEST_F(AidlTest, ConflictWithSimilarMetaTransaction) {
1628 // boolean getInterfaceVersion() is not a meta transaction, but should be
1629 // prevented because return type is not part of a method signature
1630 const string expected_stderr =
1631 "ERROR: p/IFoo.aidl:1.35-55: method getInterfaceVersion() is reserved for internal use.\n";
1632 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001633 io_delegate_.SetFileContents(options.InputFiles().front(),
1634 "package p; interface IFoo {"
1635 "boolean getInterfaceVersion(); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001636 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001637 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001638 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1639}
Jiyong Park309668e2018-07-28 16:55:44 +09001640
Devin Moore097a3ab2020-03-11 16:08:44 -07001641TEST_F(AidlTest, ConflictWithMetaTransactionGetName) {
Jiyong Park309668e2018-07-28 16:55:44 +09001642 // this is another reserved name
Devin Moore097a3ab2020-03-11 16:08:44 -07001643 const string expected_stderr =
1644 "ERROR: p/IFoo.aidl:1.34-53: method getTransactionName(int) is reserved for internal use.\n";
1645 Options options = Options::From("aidl --lang=java -o place/for/output p/IFoo.aidl");
Jiyong Park309668e2018-07-28 16:55:44 +09001646 io_delegate_.SetFileContents(options.InputFiles().front(),
1647 "package p; interface IFoo {"
1648 "String getTransactionName(int code); }");
Devin Moore097a3ab2020-03-11 16:08:44 -07001649 CaptureStderr();
Jiyong Parkb034bf02018-07-30 17:44:33 +09001650 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001651 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park309668e2018-07-28 16:55:44 +09001652
1653 // this is not a meta interface method as it differs type arguments
1654 io_delegate_.SetFileContents(options.InputFiles().front(),
1655 "package p; interface IFoo {"
1656 "String getTransactionName(); }");
Jiyong Parkb034bf02018-07-30 17:44:33 +09001657 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
Jiyong Park309668e2018-07-28 16:55:44 +09001658}
1659
Daniel Norman85aed542019-08-21 12:01:14 -07001660TEST_F(AidlTest, DifferentOrderAnnotationsInCheckAPI) {
Jeongik Cha3271ffa2018-12-04 15:19:20 +09001661 Options options = Options::From("aidl --checkapi old new");
1662 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1663 "package p; interface IFoo{ @utf8InCpp @nullable String foo();}");
1664 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1665 "package p; interface IFoo{ @nullable @utf8InCpp String foo();}");
1666
1667 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1668}
1669
Jiyong Park3656c3c2018-08-01 20:02:01 +09001670TEST_F(AidlTest, SuccessOnIdenticalApiDumps) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001671 Options options = Options::From("aidl --checkapi old new");
1672 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
1673 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo();}");
Jiyong Park3656c3c2018-08-01 20:02:01 +09001674
1675 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
1676}
1677
Daniel Norman85aed542019-08-21 12:01:14 -07001678class AidlTestCompatibleChanges : public AidlTest {
1679 protected:
1680 Options options_ = Options::From("aidl --checkapi old new");
1681};
1682
1683TEST_F(AidlTestCompatibleChanges, NewType) {
1684 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1685 "package p;"
1686 "interface IFoo {"
1687 " void foo(int a);"
1688 "}");
1689 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1690 "package p;"
1691 "interface IFoo {"
1692 " void foo(int a);"
1693 "}");
1694 io_delegate_.SetFileContents("new/p/IBar.aidl",
1695 "package p;"
1696 "interface IBar {"
1697 " void bar();"
1698 "}");
1699 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1700}
1701
1702TEST_F(AidlTestCompatibleChanges, NewMethod) {
1703 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1704 "package p;"
1705 "interface IFoo {"
1706 " void foo(int a);"
1707 "}");
1708 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1709 "package p;"
1710 "interface IFoo {"
1711 " void foo(int a);"
1712 " void bar();"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001713 " void baz(in List<IFoo> arg);"
Daniel Norman85aed542019-08-21 12:01:14 -07001714 "}");
1715 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1716}
1717
1718TEST_F(AidlTestCompatibleChanges, NewField) {
1719 io_delegate_.SetFileContents("old/p/Data.aidl",
1720 "package p;"
1721 "parcelable Data {"
1722 " int foo;"
1723 "}");
1724 io_delegate_.SetFileContents("new/p/Data.aidl",
1725 "package p;"
1726 "parcelable Data {"
1727 " int foo;"
Steven Moreland370ed342020-04-28 18:14:39 -07001728 " int bar = 0;"
Jiyong Parkf8d53612020-05-04 14:06:13 +09001729 " @nullable List<Data> list;"
Daniel Norman85aed542019-08-21 12:01:14 -07001730 "}");
1731 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1732}
1733
1734TEST_F(AidlTestCompatibleChanges, NewEnumerator) {
1735 io_delegate_.SetFileContents("old/p/Enum.aidl",
1736 "package p;"
1737 "enum Enum {"
1738 " FOO = 1,"
1739 "}");
1740 io_delegate_.SetFileContents("new/p/Enum.aidl",
1741 "package p;"
1742 "enum Enum {"
1743 " FOO = 1,"
1744 " BAR = 2,"
1745 "}");
1746 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1747}
1748
1749TEST_F(AidlTestCompatibleChanges, ReorderedEnumerator) {
1750 io_delegate_.SetFileContents("old/p/Enum.aidl",
1751 "package p;"
1752 "enum Enum {"
1753 " FOO = 1,"
1754 " BAR = 2,"
1755 "}");
1756 io_delegate_.SetFileContents("new/p/Enum.aidl",
1757 "package p;"
1758 "enum Enum {"
1759 " BAR = 2,"
1760 " FOO = 1,"
1761 "}");
1762 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1763}
1764
1765TEST_F(AidlTestCompatibleChanges, NewPackage) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001766 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1767 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001768 "interface IFoo {"
1769 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001770 "}");
1771 io_delegate_.SetFileContents("old/p/Data.aidl",
1772 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001773 "parcelable Data {"
1774 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001775 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001776 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1777 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001778 "interface IFoo {"
1779 " void foo(int a);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001780 "}");
1781 io_delegate_.SetFileContents("new/p/Data.aidl",
1782 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001783 "parcelable Data {"
1784 " int foo;"
Jiyong Parke59c3682018-09-11 23:10:25 +09001785 "}");
1786 io_delegate_.SetFileContents("new/q/IFoo.aidl",
1787 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001788 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09001789 " void foo(int a);"
1790 "}");
1791 io_delegate_.SetFileContents("new/q/Data.aidl",
1792 "package q;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001793 "parcelable Data {"
1794 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001795 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001796 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1797}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001798
Daniel Norman85aed542019-08-21 12:01:14 -07001799TEST_F(AidlTestCompatibleChanges, ArgNameChange) {
1800 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1801 "package p;"
1802 "interface IFoo {"
1803 " void foo(int a);"
1804 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001805 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1806 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001807 "interface IFoo {"
1808 " void foo(int b);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001809 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07001810 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1811}
Jiyong Parke59c3682018-09-11 23:10:25 +09001812
Daniel Norman85aed542019-08-21 12:01:14 -07001813TEST_F(AidlTestCompatibleChanges, AddedConstValue) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001814 io_delegate_.SetFileContents("old/p/I.aidl",
1815 "package p; interface I {"
1816 "const int A = 1; }");
1817 io_delegate_.SetFileContents("new/p/I.aidl",
1818 "package p ; interface I {"
1819 "const int A = 1; const int B = 2;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001820 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
1821}
Jiyong Parka428d212018-08-29 22:26:30 +09001822
Daniel Norman85aed542019-08-21 12:01:14 -07001823TEST_F(AidlTestCompatibleChanges, ChangedConstValueOrder) {
Jiyong Parke59c3682018-09-11 23:10:25 +09001824 io_delegate_.SetFileContents("old/p/I.aidl",
1825 "package p; interface I {"
1826 "const int A = 1; const int B = 2;}");
1827 io_delegate_.SetFileContents("new/p/I.aidl",
1828 "package p ; interface I {"
1829 "const int B = 2; const int A = 1;}");
Daniel Norman85aed542019-08-21 12:01:14 -07001830 EXPECT_TRUE(::android::aidl::check_api(options_, io_delegate_));
Jiyong Park3656c3c2018-08-01 20:02:01 +09001831}
1832
Daniel Norman85aed542019-08-21 12:01:14 -07001833class AidlTestIncompatibleChanges : public AidlTest {
1834 protected:
1835 Options options_ = Options::From("aidl --checkapi old new");
1836};
1837
1838TEST_F(AidlTestIncompatibleChanges, RemovedType) {
Jiyong Park0cf03b12020-07-22 19:36:34 +09001839 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001840 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1841 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001842 "interface IFoo {"
1843 " void foo(in String[] str);"
1844 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001845 "}");
Devin Moored131d5e2020-03-31 10:39:10 -07001846 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001847 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moored131d5e2020-03-31 10:39:10 -07001848 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001849}
1850
1851TEST_F(AidlTestIncompatibleChanges, RemovedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001852 const string expected_stderr =
1853 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001854 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1855 "package p;"
1856 "interface IFoo {"
1857 " void foo(in String[] str);"
1858 " void bar(@utf8InCpp String str);"
1859 "}");
1860 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1861 "package p;"
1862 "interface IFoo {"
1863 " void foo(in String[] str);"
1864 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001865 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001866 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001867 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001868}
1869
Jiyong Parkf8d53612020-05-04 14:06:13 +09001870TEST_F(AidlTestIncompatibleChanges, UntypedListInInterface) {
1871 const string expected_stderr =
1872 "ERROR: new/p/IFoo.aidl:1.61-65: "
1873 "Encountered an untyped List or Map. The use of untyped List/Map is "
1874 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1875 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1876 "ERROR: new/p/IFoo.aidl: Failed to read.\n";
1877 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1878 "package p;"
1879 "interface IFoo {"
1880 " void foo(in String[] str);"
1881 "}");
1882 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1883 "package p;"
1884 "interface IFoo {"
1885 " void foo(in String[] str);"
1886 " void bar(in List arg);"
1887 "}");
1888 CaptureStderr();
1889 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1890 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1891}
1892
1893TEST_F(AidlTestCompatibleChanges, UntypedListInParcelable) {
1894 const string expected_stderr =
1895 "ERROR: new/p/Data.aidl:1.54-59: "
1896 "Encountered an untyped List or Map. The use of untyped List/Map is "
1897 "prohibited because it is not guaranteed that the objects in the list are recognizable in "
1898 "the receiving side. Consider switching to an array or a generic List/Map.\n"
1899 "ERROR: new/p/Data.aidl: Failed to read.\n";
1900 io_delegate_.SetFileContents("old/p/Data.aidl",
1901 "package p;"
1902 "parcelable Data {"
1903 " int foo;"
1904 "}");
1905 io_delegate_.SetFileContents("new/p/Data.aidl",
1906 "package p;"
1907 "parcelable Data {"
1908 " int foo;"
1909 " @nullable List list;"
1910 "}");
1911 CaptureStderr();
1912 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
1913 EXPECT_EQ(expected_stderr, GetCapturedStderr());
1914}
1915
Daniel Norman85aed542019-08-21 12:01:14 -07001916TEST_F(AidlTestIncompatibleChanges, RemovedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001917 const string expected_stderr =
1918 "ERROR: new/p/Data.aidl:1.21-26: Number of fields in p.Data is reduced from 2 to 1.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09001919 io_delegate_.SetFileContents("old/p/Data.aidl",
1920 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001921 "parcelable Data {"
1922 " int foo;"
1923 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001924 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001925 io_delegate_.SetFileContents("new/p/Data.aidl",
1926 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001927 "parcelable Data {"
1928 " int foo;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001929 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001930 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001931 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001932 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001933}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001934
Daniel Norman85aed542019-08-21 12:01:14 -07001935TEST_F(AidlTestIncompatibleChanges, RemovedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001936 const string expected_stderr =
1937 "ERROR: new/p/Enum.aidl:1.15-20: Removed enumerator from p.Enum: FOO\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001938 io_delegate_.SetFileContents("old/p/Enum.aidl",
1939 "package p;"
1940 "enum Enum {"
1941 " FOO = 1,"
1942 " BAR = 2,"
1943 "}");
1944 io_delegate_.SetFileContents("new/p/Enum.aidl",
1945 "package p;"
1946 "enum Enum {"
1947 " BAR = 2,"
1948 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001949 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001950 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001951 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001952}
1953
1954TEST_F(AidlTestIncompatibleChanges, RenamedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001955 const string expected_stderr =
1956 "ERROR: old/p/IFoo.aidl:1.61-65: Removed or changed method: p.IFoo.bar(String)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001957 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1958 "package p;"
1959 "interface IFoo {"
1960 " void foo(in String[] str);"
1961 " void bar(@utf8InCpp String str);"
1962 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001963 io_delegate_.SetFileContents("new/p/IFoo.aidl",
1964 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001965 "interface IFoo {"
1966 " void foo(in String[] str);"
1967 " void bar2(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001968 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001969 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001970 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001971 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001972}
1973
Daniel Norman85aed542019-08-21 12:01:14 -07001974TEST_F(AidlTestIncompatibleChanges, RenamedType) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001975 const string expected_stderr = "ERROR: old/p/IFoo.aidl:1.11-20: Removed type: p.IFoo\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001976 io_delegate_.SetFileContents("old/p/IFoo.aidl",
1977 "package p;"
1978 "interface IFoo {"
1979 " void foo(in String[] str);"
1980 " void bar(@utf8InCpp String str);"
1981 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09001982 io_delegate_.SetFileContents("new/p/IFoo2.aidl",
1983 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09001984 "interface IFoo2 {"
1985 " void foo(in String[] str);"
1986 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09001987 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07001988 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07001989 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07001990 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07001991}
Jiyong Park3656c3c2018-08-01 20:02:01 +09001992
Daniel Norman85aed542019-08-21 12:01:14 -07001993TEST_F(AidlTestIncompatibleChanges, ChangedEnumerator) {
Devin Moore097a3ab2020-03-11 16:08:44 -07001994 const string expected_stderr =
1995 "ERROR: new/p/Enum.aidl:1.15-20: Changed enumerator value: p.Enum::FOO from 1 to 3.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07001996 io_delegate_.SetFileContents("old/p/Enum.aidl",
1997 "package p;"
1998 "enum Enum {"
1999 " FOO = 1,"
2000 " BAR = 2,"
2001 "}");
2002 io_delegate_.SetFileContents("new/p/Enum.aidl",
2003 "package p;"
2004 "enum Enum {"
2005 " FOO = 3,"
2006 " BAR = 2,"
2007 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002008 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002009 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002010 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002011}
2012
2013TEST_F(AidlTestIncompatibleChanges, ReorderedMethod) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002014 const string expected_stderr =
2015 "ERROR: new/p/IFoo.aidl:1.67-71: Transaction ID changed: p.IFoo.foo(String[]) is changed "
2016 "from 0 to 1.\n"
2017 "ERROR: new/p/IFoo.aidl:1.33-37: Transaction ID changed: p.IFoo.bar(String) is changed from "
2018 "1 to 0.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002019 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2020 "package p;"
2021 "interface IFoo {"
2022 " void foo(in String[] str);"
2023 " void bar(@utf8InCpp String str);"
2024 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002025 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2026 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002027 "interface IFoo {"
2028 " void bar(@utf8InCpp String str);"
2029 " void foo(in String[] str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002030 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002031 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002032 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002033 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002034}
2035
2036TEST_F(AidlTestIncompatibleChanges, ReorderedField) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002037 const string expected_stderr =
Jiyong Parkb07d9932020-05-15 12:56:54 +09002038 "ERROR: new/p/Data.aidl:1.33-37: Reordered bar from 1 to 0.\n"
2039 "ERROR: new/p/Data.aidl:1.43-47: Reordered foo from 0 to 1.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002040 io_delegate_.SetFileContents("old/p/Data.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002041 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002042 "parcelable Data {"
2043 " int foo;"
2044 " int bar;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002045 "}");
Daniel Norman85aed542019-08-21 12:01:14 -07002046 io_delegate_.SetFileContents("new/p/Data.aidl",
2047 "package p;"
2048 "parcelable Data {"
2049 " int bar;"
2050 " int foo;"
2051 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002052 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002053 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002054 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002055}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002056
Daniel Norman85aed542019-08-21 12:01:14 -07002057TEST_F(AidlTestIncompatibleChanges, ChangedDirectionSpecifier) {
Devin Mooreeccdb902020-03-24 16:22:40 -07002058 const string expected_stderr = "ERROR: new/p/IFoo.aidl:1.33-37: Direction changed: in to out.\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002059 io_delegate_.SetFileContents("old/p/IFoo.aidl",
Jiyong Parke59c3682018-09-11 23:10:25 +09002060 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002061 "interface IFoo {"
2062 " void foo(in String[] str);"
2063 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002064 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002065 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2066 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002067 "interface IFoo {"
2068 " void foo(out String[] str);"
2069 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002070 "}");
Devin Mooreeccdb902020-03-24 16:22:40 -07002071 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002072 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Mooreeccdb902020-03-24 16:22:40 -07002073 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002074}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002075
Daniel Norman85aed542019-08-21 12:01:14 -07002076TEST_F(AidlTestIncompatibleChanges, AddedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002077 const string expected_stderr =
2078 "ERROR: new/p/IFoo.aidl:1.51-58: Changed annotations: (empty) to @utf8InCpp\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002079 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2080 "package p;"
2081 "interface IFoo {"
2082 " void foo(in String[] str);"
2083 " void bar(@utf8InCpp String str);"
2084 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002085 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2086 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002087 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002088 " void foo(in @utf8InCpp String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002089 " void bar(@utf8InCpp String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002090 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002091 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002092 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002093 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002094}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002095
Daniel Norman85aed542019-08-21 12:01:14 -07002096TEST_F(AidlTestIncompatibleChanges, RemovedAnnotation) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002097 const string expected_stderr =
2098 "ERROR: new/p/IFoo.aidl:1.66-72: Changed annotations: @utf8InCpp to (empty)\n";
Daniel Norman85aed542019-08-21 12:01:14 -07002099 io_delegate_.SetFileContents("old/p/IFoo.aidl",
2100 "package p;"
2101 "interface IFoo {"
2102 " void foo(in String[] str);"
2103 " void bar(@utf8InCpp String str);"
2104 "}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002105 io_delegate_.SetFileContents("new/p/IFoo.aidl",
2106 "package p;"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002107 "interface IFoo {"
Jiyong Parke59c3682018-09-11 23:10:25 +09002108 " void foo(in String[] str);"
Jiyong Park3656c3c2018-08-01 20:02:01 +09002109 " void bar(String str);"
Jiyong Parke59c3682018-09-11 23:10:25 +09002110 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002111 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002112 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002113 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002114}
Jiyong Park3656c3c2018-08-01 20:02:01 +09002115
Devin Mooredb7ac512020-08-07 11:17:36 -07002116TEST_F(AidlTestIncompatibleChanges, AddedParcelableAnnotation) {
2117 const string expected_stderr =
2118 "ERROR: new/p/Foo.aidl:1.47-51: Changed annotations: (empty) to @JavaOnlyStableParcelable\n";
2119 io_delegate_.SetFileContents("old/p/Foo.aidl",
2120 "package p;"
2121 "parcelable Foo {"
2122 " int A;"
2123 "}");
2124 io_delegate_.SetFileContents("new/p/Foo.aidl",
2125 "package p;"
2126 "@JavaOnlyStableParcelable parcelable Foo {"
2127 " int A;"
2128 "}");
2129 CaptureStderr();
2130 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2131 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2132}
2133
2134TEST_F(AidlTestIncompatibleChanges, RemovedParcelableAnnotation) {
2135 const string expected_stderr =
2136 "ERROR: new/p/Foo.aidl:1.21-25: Changed annotations: @JavaOnlyStableParcelable to (empty)\n";
2137 io_delegate_.SetFileContents("old/p/Foo.aidl",
2138 "package p;"
2139 "@JavaOnlyStableParcelable parcelable Foo {"
2140 " int A;"
2141 "}");
2142 io_delegate_.SetFileContents("new/p/Foo.aidl",
2143 "package p;"
2144 "parcelable Foo {"
2145 " int A;"
2146 "}");
2147 CaptureStderr();
2148 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2149 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2150}
2151
Daniel Norman85aed542019-08-21 12:01:14 -07002152TEST_F(AidlTestIncompatibleChanges, RemovedPackage) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002153 const string expected_stderr = "ERROR: old/q/IFoo.aidl:1.11-21: Removed type: q.IFoo\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002154 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{}");
2155 io_delegate_.SetFileContents("old/q/IFoo.aidl", "package q; interface IFoo{}");
Jiyong Parke59c3682018-09-11 23:10:25 +09002156 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002157 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002158 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002159 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002160}
Jiyong Parka468e2a2018-08-29 21:25:18 +09002161
Daniel Norman85aed542019-08-21 12:01:14 -07002162TEST_F(AidlTestIncompatibleChanges, ChangedDefaultValue) {
Steven Moreland370ed342020-04-28 18:14:39 -07002163 const string expected_stderr = "ERROR: new/p/D.aidl:1.30-32: Changed default value: 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002164 io_delegate_.SetFileContents("old/p/D.aidl", "package p; parcelable D { int a = 1; }");
2165 io_delegate_.SetFileContents("new/p/D.aidl", "package p; parcelable D { int a = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002166 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002167 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002168 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002169}
Jiyong Parka428d212018-08-29 22:26:30 +09002170
Daniel Norman85aed542019-08-21 12:01:14 -07002171TEST_F(AidlTestIncompatibleChanges, RemovedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002172 const string expected_stderr =
2173 "ERROR: old/p/I.aidl:1.51-53: Removed constant declaration: p.I.B\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002174 io_delegate_.SetFileContents("old/p/I.aidl",
2175 "package p; interface I {"
2176 "const int A = 1; const int B = 2;}");
2177 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 1; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002178 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002179 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002180 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Daniel Norman85aed542019-08-21 12:01:14 -07002181}
Jiyong Parka428d212018-08-29 22:26:30 +09002182
Daniel Norman85aed542019-08-21 12:01:14 -07002183TEST_F(AidlTestIncompatibleChanges, ChangedConstValue) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002184 const string expected_stderr =
2185 "ERROR: new/p/I.aidl:1.11-21: Changed constant value: p.I.A from 1 to 2.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002186 io_delegate_.SetFileContents("old/p/I.aidl", "package p; interface I { const int A = 1; }");
2187 io_delegate_.SetFileContents("new/p/I.aidl", "package p; interface I { const int A = 2; }");
Devin Moore097a3ab2020-03-11 16:08:44 -07002188 CaptureStderr();
Daniel Norman85aed542019-08-21 12:01:14 -07002189 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002190 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3c35e392018-08-30 13:10:30 +09002191}
2192
Devin Moorec7e47a32020-08-07 10:55:25 -07002193TEST_F(AidlTestIncompatibleChanges, FixedSizeAddedField) {
2194 const string expected_stderr =
2195 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is changed from 1 to 2. "
2196 "This is an incompatible change for FixedSize types.\n";
2197 io_delegate_.SetFileContents("old/p/Foo.aidl",
2198 "package p; @FixedSize parcelable Foo { int A = 1; }");
2199 io_delegate_.SetFileContents("new/p/Foo.aidl",
2200 "package p; @FixedSize parcelable Foo { int A = 1; int B = 2; }");
2201 CaptureStderr();
2202 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2203 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2204}
2205
2206TEST_F(AidlTestIncompatibleChanges, FixedSizeRemovedField) {
2207 const string expected_stderr =
2208 "ERROR: new/p/Foo.aidl:1.33-37: Number of fields in p.Foo is reduced from 2 to 1.\n";
2209 io_delegate_.SetFileContents("old/p/Foo.aidl",
2210 "package p; @FixedSize parcelable Foo { int A = 1; int B = 1; }");
2211 io_delegate_.SetFileContents("new/p/Foo.aidl",
2212 "package p; @FixedSize parcelable Foo { int A = 1; }");
2213 CaptureStderr();
2214 EXPECT_FALSE(::android::aidl::check_api(options_, io_delegate_));
2215 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2216}
2217
2218TEST_P(AidlTest, RejectNonFixedSizeFromFixedSize) {
2219 const string expected_stderr =
2220 "ERROR: Foo.aidl:1.36-38: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2221 "a.\n"
2222 "ERROR: Foo.aidl:1.44-46: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2223 "b.\n"
2224 "ERROR: Foo.aidl:1.55-57: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2225 "c.\n"
2226 "ERROR: Foo.aidl:1.80-82: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2227 "d.\n"
2228 "ERROR: Foo.aidl:1.92-94: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2229 "e.\n"
2230 "ERROR: Foo.aidl:1.109-111: The @FixedSize parcelable 'Foo' has a non-fixed size field named "
2231 "f.\n";
2232
2233 io_delegate_.SetFileContents("Foo.aidl",
2234 "@FixedSize parcelable Foo { "
2235 " int[] a;"
2236 " Bar b;"
2237 " String c;"
2238 " ParcelFileDescriptor d;"
2239 " IBinder e;"
2240 " List<String> f;"
Steven Moreland265f3d42020-09-24 19:06:54 +00002241 " int isFixedSize;"
Devin Moorec7e47a32020-08-07 10:55:25 -07002242 "}");
2243 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { int a; }");
2244 Options options =
2245 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2246
2247 CaptureStderr();
2248 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2249 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2250}
2251
2252TEST_P(AidlTest, AcceptFixedSizeFromFixedSize) {
2253 const string expected_stderr = "";
2254
2255 io_delegate_.SetFileContents("Foo.aidl", "@FixedSize parcelable Foo { int a; Bar b; }");
2256 io_delegate_.SetFileContents("Bar.aidl", "@FixedSize parcelable Bar { Val c; }");
2257 io_delegate_.SetFileContents("Val.aidl", "enum Val { A, B, }");
2258 Options options =
2259 Options::From("aidl Foo.aidl -I . --lang=" + Options::LanguageToString(GetLanguage()));
2260
2261 CaptureStderr();
2262 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2263 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2264}
2265
Jiyong Park8c380532018-08-30 14:55:26 +09002266TEST_F(AidlTest, RejectAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002267 const string expected_stderr =
2268 "ERROR: p/IFoo.aidl: Duplicate files found for q.IBar from:\n"
2269 "dir1/q/IBar.aidl\n"
2270 "dir2/q/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002271 "ERROR: p/IFoo.aidl: Couldn't find import for class q.IBar\n";
Jiyong Park8c380532018-08-30 14:55:26 +09002272 Options options = Options::From("aidl --lang=java -o out -I dir1 -I dir2 p/IFoo.aidl");
2273 io_delegate_.SetFileContents("p/IFoo.aidl", "package p; import q.IBar; interface IFoo{}");
2274 io_delegate_.SetFileContents("dir1/q/IBar.aidl", "package q; interface IBar{}");
2275 io_delegate_.SetFileContents("dir2/q/IBar.aidl", "package q; interface IBar{}");
2276
Devin Moore097a3ab2020-03-11 16:08:44 -07002277 CaptureStderr();
Jiyong Park8c380532018-08-30 14:55:26 +09002278 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002279 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park8c380532018-08-30 14:55:26 +09002280}
2281
Jiyong Parked65bf42018-08-28 15:43:27 +09002282TEST_F(AidlTest, HandleManualIdAssignments) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002283 const string expected_stderr =
2284 "ERROR: new/p/IFoo.aidl:1.32-36: Transaction ID changed: p.IFoo.foo() is changed from 10 to "
2285 "11.\n";
Jiyong Parke59c3682018-09-11 23:10:25 +09002286 Options options = Options::From("aidl --checkapi old new");
2287 io_delegate_.SetFileContents("old/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
2288 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 10;}");
Jiyong Parked65bf42018-08-28 15:43:27 +09002289
2290 EXPECT_TRUE(::android::aidl::check_api(options, io_delegate_));
2291
Jiyong Parke59c3682018-09-11 23:10:25 +09002292 io_delegate_.SetFileContents("new/p/IFoo.aidl", "package p; interface IFoo{ void foo() = 11;}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002293 CaptureStderr();
Jiyong Parked65bf42018-08-28 15:43:27 +09002294 EXPECT_FALSE(::android::aidl::check_api(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002295 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parked65bf42018-08-28 15:43:27 +09002296}
2297
Jiyong Parke05195e2018-10-08 18:24:23 +09002298TEST_F(AidlTest, ParcelFileDescriptorIsBuiltinType) {
2299 Options javaOptions = Options::From("aidl --lang=java -o out p/IFoo.aidl");
2300 Options cppOptions = Options::From("aidl --lang=cpp -h out -o out p/IFoo.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002301 Options rustOptions = Options::From("aidl --lang=rust -o out p/IFoo.aidl");
Jiyong Parke05195e2018-10-08 18:24:23 +09002302
2303 // use without import
2304 io_delegate_.SetFileContents("p/IFoo.aidl",
2305 "package p; interface IFoo{ void foo(in ParcelFileDescriptor fd);}");
2306 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2307 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002308 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002309
Devin Moore7b8d5c92020-03-17 14:14:08 -07002310 // use without import but with full name
Jiyong Parke05195e2018-10-08 18:24:23 +09002311 io_delegate_.SetFileContents(
2312 "p/IFoo.aidl",
2313 "package p; interface IFoo{ void foo(in android.os.ParcelFileDescriptor fd);}");
2314 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2315 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002316 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002317
2318 // use with import (as before)
2319 io_delegate_.SetFileContents("p/IFoo.aidl",
2320 "package p;"
2321 "import android.os.ParcelFileDescriptor;"
2322 "interface IFoo{"
2323 " void foo(in ParcelFileDescriptor fd);"
2324 "}");
2325 EXPECT_EQ(0, ::android::aidl::compile_aidl(javaOptions, io_delegate_));
2326 EXPECT_EQ(0, ::android::aidl::compile_aidl(cppOptions, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002327 EXPECT_EQ(0, ::android::aidl::compile_aidl(rustOptions, io_delegate_));
Jiyong Parke05195e2018-10-08 18:24:23 +09002328}
Jiyong Parked65bf42018-08-28 15:43:27 +09002329
Jiyong Park3633b722019-04-11 15:38:26 +09002330TEST_F(AidlTest, ManualIds) {
2331 Options options = Options::From("aidl --lang=java -o out IFoo.aidl");
2332 io_delegate_.SetFileContents("IFoo.aidl",
2333 "interface IFoo {\n"
2334 " void foo() = 0;\n"
2335 " void bar() = 1;\n"
2336 "}");
2337 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2338}
2339
2340TEST_F(AidlTest, ManualIdsWithMetaTransactions) {
2341 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2342 io_delegate_.SetFileContents("IFoo.aidl",
2343 "interface IFoo {\n"
2344 " void foo() = 0;\n"
2345 " void bar() = 1;\n"
2346 "}");
2347 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2348}
2349
2350TEST_F(AidlTest, FailOnDuplicatedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002351 const string expected_stderr =
2352 "ERROR: IFoo.aidl:3.7-11: Found duplicate method id (3) for method bar\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002353 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2354 io_delegate_.SetFileContents("IFoo.aidl",
2355 "interface IFoo {\n"
2356 " void foo() = 3;\n"
2357 " void bar() = 3;\n"
2358 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002359 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002360 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002361 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002362}
2363
2364TEST_F(AidlTest, FailOnOutOfRangeIds) {
2365 // 16777115 is kLastMetaMethodId + 1
Devin Moore097a3ab2020-03-11 16:08:44 -07002366 const string expected_stderr =
2367 "ERROR: IFoo.aidl:3.7-11: Found out of bounds id (16777115) for method bar. "
2368 "Value for id must be between 0 and 16777114 inclusive.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002369 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2370 io_delegate_.SetFileContents("IFoo.aidl",
2371 "interface IFoo {\n"
2372 " void foo() = 3;\n"
2373 " void bar() = 16777115;\n"
2374 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002375 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002376 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002377 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002378}
2379
2380TEST_F(AidlTest, FailOnPartiallyAssignedIds) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002381 const string expected_stderr =
2382 "ERROR: IFoo.aidl:3.7-11: You must either assign id's to all methods or to none of them.\n";
Jiyong Park3633b722019-04-11 15:38:26 +09002383 Options options = Options::From("aidl --lang=java --version 10 -o out IFoo.aidl");
2384 io_delegate_.SetFileContents("IFoo.aidl",
2385 "interface IFoo {\n"
2386 " void foo() = 3;\n"
2387 " void bar();\n"
2388 "}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002389 CaptureStderr();
Jiyong Park3633b722019-04-11 15:38:26 +09002390 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002391 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Park3633b722019-04-11 15:38:26 +09002392}
2393
Jiyong Parkc6816252019-07-08 08:12:28 +09002394TEST_F(AidlTest, AllowDuplicatedImportPaths) {
2395 Options options = Options::From("aidl --lang=java -I dir -I dir IFoo.aidl");
2396 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2397 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
2398 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2399}
2400
2401TEST_F(AidlTest, FailOnAmbiguousImports) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002402 const string expected_stderr =
2403 "ERROR: IFoo.aidl: Duplicate files found for IBar from:\n"
2404 "dir/IBar.aidl\n"
2405 "dir2/IBar.aidl\n"
Devin Moore5de18ed2020-04-02 13:52:29 -07002406 "ERROR: IFoo.aidl: Couldn't find import for class IBar\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002407
Jiyong Parkc6816252019-07-08 08:12:28 +09002408 Options options = Options::From("aidl --lang=java -I dir -I dir2 IFoo.aidl");
2409 io_delegate_.SetFileContents("dir/IBar.aidl", "interface IBar{}");
2410 io_delegate_.SetFileContents("dir2/IBar.aidl", "interface IBar{}");
2411 io_delegate_.SetFileContents("IFoo.aidl", "import IBar; interface IFoo{}");
Devin Moore097a3ab2020-03-11 16:08:44 -07002412 CaptureStderr();
Jiyong Parkc6816252019-07-08 08:12:28 +09002413 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
Devin Moore097a3ab2020-03-11 16:08:44 -07002414 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Jiyong Parkc6816252019-07-08 08:12:28 +09002415}
2416
Jiyong Parkf1f5c802020-05-19 17:33:00 +09002417TEST_F(AidlTest, UnusedImportDoesNotContributeInclude) {
2418 io_delegate_.SetFileContents("a/b/IFoo.aidl",
2419 "package a.b;\n"
2420 "import a.b.IBar;\n"
2421 "import a.b.IQux;\n"
2422 "interface IFoo { IQux foo(); }\n");
2423 io_delegate_.SetFileContents("a/b/IBar.aidl", "package a.b; interface IBar { void foo(); }");
2424 io_delegate_.SetFileContents("a/b/IQux.aidl", "package a.b; interface IQux { void foo(); }");
2425
2426 Options options = Options::From("aidl --lang=ndk a/b/IFoo.aidl -I . -o out -h out/include");
2427 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2428
2429 string output;
2430 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/include/aidl/a/b/IFoo.h", &output));
2431 // IBar was imported but wasn't used. include is not expected.
2432 EXPECT_THAT(output, Not(testing::HasSubstr("#include <aidl/a/b/IBar.h>")));
2433 // IBar was imported and used. include is expected.
2434 EXPECT_THAT(output, (testing::HasSubstr("#include <aidl/a/b/IQux.h>")));
2435}
2436
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002437TEST_F(AidlTest, ParseJavaPassthroughAnnotation) {
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002438 io_delegate_.SetFileContents("a/IFoo.aidl", R"--(package a;
Jooyung Han4cde01d2020-10-13 11:10:47 +09002439 import a.MyEnum;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002440 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2441 @JavaPassthrough(annotation="@com.android.AliceTwo")
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002442 interface IFoo {
2443 @JavaPassthrough(annotation="@com.android.Bob")
Jooyung Han4cde01d2020-10-13 11:10:47 +09002444 void foo(@JavaPassthrough(annotation="@com.android.Cat") int x, MyEnum y);
Jiyong Park7c3b0e42020-08-04 16:08:32 +09002445 const @JavaPassthrough(annotation="@com.android.David") int A = 3;
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002446 })--");
Jooyung Han4cde01d2020-10-13 11:10:47 +09002447 // JavaPassthrough should work with other types as well (e.g. enum)
2448 io_delegate_.SetFileContents("a/MyEnum.aidl", R"--(package a;
2449 @JavaPassthrough(annotation="@com.android.Alice(arg=com.android.Alice.Value.A)")
2450 @JavaPassthrough(annotation="@com.android.AliceTwo")
2451 @Backing(type="byte")
2452 enum MyEnum {
2453 a, b, c
2454 })--");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002455
Jooyung Han4cde01d2020-10-13 11:10:47 +09002456 Options java_options = Options::From("aidl -I . --lang=java -o out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002457 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2458
2459 string java_out;
2460 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/IFoo.java", &java_out));
Jooyung Hane6bc5e12020-10-13 10:57:10 +09002461 // type-decl-level annotations with newline at the end
2462 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2463 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2464 // member-decl-level annotations with newline at the end
2465 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Bob\n"));
2466 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.David\n"));
2467 // inline annotations with space at the end
2468 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Cat "));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002469
Jooyung Han4cde01d2020-10-13 11:10:47 +09002470 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/MyEnum.java", &java_out));
2471 // type-decl-level annotations with newline at the end
2472 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.Alice(arg=com.android.Alice.Value.A)\n"));
2473 EXPECT_THAT(java_out, testing::HasSubstr("@com.android.AliceTwo\n"));
2474
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002475 // Other backends shouldn't be bothered
Jooyung Han4cde01d2020-10-13 11:10:47 +09002476 Options cpp_options =
2477 Options::From("aidl -I . --lang=cpp -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002478 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2479
Jooyung Han4cde01d2020-10-13 11:10:47 +09002480 Options ndk_options =
2481 Options::From("aidl -I . --lang=ndk -o out -h out a/IFoo.aidl a/MyEnum.aidl");
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002482 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
Andrei Homescub62afd92020-05-11 19:24:59 -07002483
Jooyung Han4cde01d2020-10-13 11:10:47 +09002484 Options rust_options = Options::From("aidl -I . --lang=rust -o out a/IFoo.aidl a/MyEnum.aidl");
Andrei Homescub62afd92020-05-11 19:24:59 -07002485 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
Jiyong Parkbf5fd5c2020-06-05 19:48:05 +09002486}
2487
Andrei Homescue61feb52020-08-18 15:44:24 -07002488TEST_F(AidlTest, ParseRustDerive) {
2489 io_delegate_.SetFileContents("a/Foo.aidl", R"(package a;
2490 @RustDerive(Clone=true, Copy=false)
2491 parcelable Foo {
2492 int a;
2493 })");
2494
2495 Options rust_options = Options::From("aidl --lang=rust -o out a/Foo.aidl");
2496 EXPECT_EQ(0, ::android::aidl::compile_aidl(rust_options, io_delegate_));
2497
2498 string rust_out;
2499 EXPECT_TRUE(io_delegate_.GetWrittenContents("out/a/Foo.rs", &rust_out));
2500 EXPECT_THAT(rust_out, testing::HasSubstr("#[derive(Debug, Clone)]"));
2501
2502 // Other backends shouldn't be bothered
2503 Options cpp_options = Options::From("aidl --lang=cpp -o out -h out a/Foo.aidl");
2504 EXPECT_EQ(0, ::android::aidl::compile_aidl(cpp_options, io_delegate_));
2505
2506 Options ndk_options = Options::From("aidl --lang=ndk -o out -h out a/Foo.aidl");
2507 EXPECT_EQ(0, ::android::aidl::compile_aidl(ndk_options, io_delegate_));
2508
2509 Options java_options = Options::From("aidl --lang=java -o out a/Foo.aidl");
2510 EXPECT_EQ(0, ::android::aidl::compile_aidl(java_options, io_delegate_));
2511}
2512
Jiyong Park56f73d72019-06-11 12:20:28 +09002513class AidlOutputPathTest : public AidlTest {
2514 protected:
2515 void SetUp() override {
2516 AidlTest::SetUp();
2517 io_delegate_.SetFileContents("sub/dir/foo/bar/IFoo.aidl", "package foo.bar; interface IFoo {}");
2518 }
2519
2520 void Test(const Options& options, const std::string expected_output_path) {
2521 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2522 // check the existence
2523 EXPECT_TRUE(io_delegate_.GetWrittenContents(expected_output_path, nullptr));
2524 }
2525};
2526
2527TEST_F(AidlOutputPathTest, OutDirWithNoOutputFile) {
2528 // <out_dir> / <package_name> / <type_name>.java
2529 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl"), "out/foo/bar/IFoo.java");
2530}
2531
2532TEST_F(AidlOutputPathTest, OutDirWithOutputFile) {
2533 // when output file is explicitly set, it is always respected. -o option is
2534 // ignored.
2535 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2536}
2537
2538TEST_F(AidlOutputPathTest, NoOutDirWithOutputFile) {
2539 Test(Options::From("aidl -o out sub/dir/foo/bar/IFoo.aidl output/IFoo.java"), "output/IFoo.java");
2540}
2541
2542TEST_F(AidlOutputPathTest, NoOutDirWithNoOutputFile) {
2543 // output is the same as the input file except for the suffix
2544 Test(Options::From("aidl sub/dir/foo/bar/IFoo.aidl"), "sub/dir/foo/bar/IFoo.java");
2545}
2546
Devin Moore7b8d5c92020-03-17 14:14:08 -07002547TEST_P(AidlTest, FailOnOutOfBoundsInt32MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002548 AidlError error;
2549 const string expected_stderr =
2550 "ERROR: p/IFoo.aidl:3.58-69: Invalid type specifier for an int64 literal: int\n";
2551 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002552 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2553 R"(package p;
2554 interface IFoo {
2555 const int int32_max_oob = 2147483650;
2556 }
2557 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002558 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002559 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2560 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002561}
2562
Devin Moore7b8d5c92020-03-17 14:14:08 -07002563TEST_P(AidlTest, FailOnOutOfBoundsInt32MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002564 AidlError error;
2565 const string expected_stderr =
2566 "ERROR: p/IFoo.aidl:3.58-60: Invalid type specifier for an int64 literal: int\n";
2567 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002568 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2569 R"(package p;
2570 interface IFoo {
2571 const int int32_min_oob = -2147483650;
2572 }
2573 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002574 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002575 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2576 EXPECT_EQ(AidlError::BAD_TYPE, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002577}
2578
Devin Moore7b8d5c92020-03-17 14:14:08 -07002579TEST_P(AidlTest, FailOnOutOfBoundsInt64MaxConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002580 AidlError error;
2581 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002582 "ERROR: p/IFoo.aidl:3.59-86: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002583 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002584 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2585 R"(package p;
2586 interface IFoo {
2587 const long int64_max_oob = 21474836509999999999999999;
2588 }
2589 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002590 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002591 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2592 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002593}
2594
Devin Moore7b8d5c92020-03-17 14:14:08 -07002595TEST_P(AidlTest, FailOnOutOfBoundsInt64MinConstInt) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002596 AidlError error;
2597 const string expected_stderr =
Devin Moore2a088902020-09-17 10:51:19 -07002598 "ERROR: p/IFoo.aidl:3.61-87: Could not parse integer: 21474836509999999999999999\n";
Devin Moore097a3ab2020-03-11 16:08:44 -07002599 CaptureStderr();
Will McVickera4e5b132019-10-03 13:52:21 -07002600 EXPECT_EQ(nullptr, Parse("p/IFoo.aidl",
2601 R"(package p;
2602 interface IFoo {
2603 const long int64_min_oob = -21474836509999999999999999;
2604 }
2605 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002606 typenames_, GetLanguage(), &error));
Devin Moore097a3ab2020-03-11 16:08:44 -07002607 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2608 EXPECT_EQ(AidlError::PARSE_ERROR, error);
Will McVickera4e5b132019-10-03 13:52:21 -07002609}
2610
Devin Moore7b8d5c92020-03-17 14:14:08 -07002611TEST_P(AidlTest, FailOnOutOfBoundsAutofilledEnum) {
Devin Moore097a3ab2020-03-11 16:08:44 -07002612 AidlError error;
Devin Mooredf93ebb2020-03-25 14:03:35 -07002613 const string expected_stderr =
2614 "ERROR: p/TestEnum.aidl:3.35-44: Invalid type specifier for an int32 "
2615 "literal: byte\n"
2616 "ERROR: p/TestEnum.aidl:5.1-36: Enumerator type differs from enum backing type.\n";
2617 CaptureStderr();
Daniel Normanb28684e2019-10-17 15:31:39 -07002618 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2619 R"(package p;
2620 @Backing(type="byte")
2621 enum TestEnum {
2622 FOO = 127,
2623 BAR,
2624 }
2625 )",
Devin Moore7b8d5c92020-03-17 14:14:08 -07002626 typenames_, GetLanguage(), &error));
Devin Mooredf93ebb2020-03-25 14:03:35 -07002627 EXPECT_EQ(expected_stderr, GetCapturedStderr());
Devin Moore097a3ab2020-03-11 16:08:44 -07002628 EXPECT_EQ(AidlError::BAD_TYPE, error);
Daniel Normanb28684e2019-10-17 15:31:39 -07002629}
2630
Devin Mooredecaf292020-04-30 09:16:40 -07002631TEST_P(AidlTest, UnsupportedBackingAnnotationParam) {
2632 AidlError error;
2633 const string expected_stderr =
2634 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2635 "be one of: type\n"
2636 "ERROR: p/TestEnum.aidl:2.1-51: Parameter foo not supported for annotation Backing. It must "
2637 "be one of: type\n";
2638 CaptureStderr();
2639 EXPECT_EQ(nullptr, Parse("p/TestEnum.aidl",
2640 R"(package p;
2641 @Backing(foo="byte")
2642 enum TestEnum {
2643 FOO = 1,
2644 BAR,
2645 }
2646 )",
2647 typenames_, GetLanguage(), &error));
2648 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2649 EXPECT_EQ(AidlError::BAD_TYPE, error);
2650}
2651
Jeongik Chad0a10272020-08-06 16:33:36 +09002652TEST_P(AidlTest, SupportJavaOnlyImmutableAnnotation) {
2653 io_delegate_.SetFileContents("Foo.aidl",
2654 "@JavaOnlyImmutable parcelable Foo { int a; Bar b; List<Bar> c; "
2655 "Map<String, Baz> d; Bar[] e; }");
2656 io_delegate_.SetFileContents("Bar.aidl", "@JavaOnlyImmutable parcelable Bar { String a; }");
2657 io_delegate_.SetFileContents("Baz.aidl",
2658 "@JavaOnlyImmutable @JavaOnlyStableParcelable parcelable Baz;");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002659 Options options = Options::From("aidl --lang=java -I . Foo.aidl");
2660 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2661}
2662
Jeongik Chad0a10272020-08-06 16:33:36 +09002663TEST_P(AidlTest, RejectMutableParcelableFromJavaOnlyImmutableParcelable) {
2664 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { Bar bar; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002665 io_delegate_.SetFileContents("Bar.aidl", "parcelable Bar { String a; }");
2666 Options options = Options::From("aidl --lang=java Foo.aidl -I .");
2667 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2668}
2669
2670TEST_P(AidlTest, ImmtuableParcelableCannotBeInOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002671 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002672 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(inout Foo); }");
2673 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2674 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2675}
2676
2677TEST_P(AidlTest, ImmtuableParcelableCannotBeOut) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002678 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; }");
Jeongik Cha36f76c32020-07-28 00:25:52 +09002679 io_delegate_.SetFileContents("IBar.aidl", "interface IBar { void my(out Foo); }");
2680 Options options = Options::From("aidl --lang=java IBar.aidl -I .");
2681 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2682}
2683
Jeongik Cha91180252020-07-31 15:43:11 +09002684TEST_P(AidlTest, ImmtuableParcelableFieldNameRestriction) {
Jeongik Chad0a10272020-08-06 16:33:36 +09002685 io_delegate_.SetFileContents("Foo.aidl", "@JavaOnlyImmutable parcelable Foo { int a; int A; }");
Jeongik Cha91180252020-07-31 15:43:11 +09002686 Options options = Options::From("aidl --lang=java Foo.aidl");
2687 const string expected_stderr =
Jeongik Chad0a10272020-08-06 16:33:36 +09002688 "ERROR: Foo.aidl:1.30-34: The parcelable 'Foo' has duplicate field name 'A' after "
Jeongik Cha91180252020-07-31 15:43:11 +09002689 "capitalizing the first letter\n";
2690 CaptureStderr();
2691 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2692 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2693}
Devin Moore53fc99c2020-08-12 08:07:52 -07002694
2695TEST_P(AidlTest, GenericStructuredParcelable) {
2696 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T, U> { int a; int A; }");
2697 Options options =
2698 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2699 const string expected_stderr = "";
2700 CaptureStderr();
2701 EXPECT_EQ(0, ::android::aidl::compile_aidl(options, io_delegate_));
2702 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2703}
2704
2705TEST_P(AidlTest, RejectGenericStructuredParcelabelRepeatedParam) {
2706 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { int a; int A; }");
2707 Options options =
2708 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2709 const string expected_stderr =
2710 "ERROR: Foo.aidl:1.11-15: Every type parameter should be unique.\n";
2711 CaptureStderr();
2712 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2713 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2714}
2715
2716TEST_P(AidlTest, RejectGenericStructuredParcelableField) {
2717 io_delegate_.SetFileContents("Foo.aidl", "parcelable Foo<T,T> { T a; int A; }");
2718 Options options =
2719 Options::From("aidl Foo.aidl --lang=" + Options::LanguageToString(GetLanguage()));
2720 const string expected_stderr = "ERROR: Foo.aidl:1.22-24: Failed to resolve 'T'\n";
2721 CaptureStderr();
2722 EXPECT_NE(0, ::android::aidl::compile_aidl(options, io_delegate_));
2723 EXPECT_EQ(expected_stderr, GetCapturedStderr());
2724}
2725
Christopher Wiley90be4e32015-10-20 14:55:25 -07002726} // namespace aidl
2727} // namespace android