blob: 56ece5c60a45f8b12d2c8a5e45f1b15cee37d411 [file] [log] [blame]
Alexander Kornienko76c28802015-08-19 11:15:36 +00001//===--- IdentifierNamingCheck.cpp - clang-tidy ---------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Alexander Kornienko76c28802015-08-19 11:15:36 +00006//
7//===----------------------------------------------------------------------===//
8
9#include "IdentifierNamingCheck.h"
10
Roman Lebedev08701ec2018-10-26 13:09:27 +000011#include "../utils/ASTUtils.h"
Alexander Kornienko76c28802015-08-19 11:15:36 +000012#include "clang/ASTMatchers/ASTMatchFinder.h"
Alexander Kornienko21503902016-06-17 09:25:24 +000013#include "clang/Frontend/CompilerInstance.h"
14#include "clang/Lex/PPCallbacks.h"
15#include "clang/Lex/Preprocessor.h"
Mandeep Singh Grang7c7ea7d2016-11-08 07:50:19 +000016#include "llvm/ADT/DenseMapInfo.h"
17#include "llvm/Support/Debug.h"
18#include "llvm/Support/Format.h"
Alexander Kornienko76c28802015-08-19 11:15:36 +000019
20#define DEBUG_TYPE "clang-tidy"
21
22using namespace clang::ast_matchers;
23
Alexander Kornienko21503902016-06-17 09:25:24 +000024namespace llvm {
25/// Specialisation of DenseMapInfo to allow NamingCheckId objects in DenseMaps
26template <>
27struct DenseMapInfo<
28 clang::tidy::readability::IdentifierNamingCheck::NamingCheckId> {
29 using NamingCheckId =
30 clang::tidy::readability::IdentifierNamingCheck::NamingCheckId;
31
32 static inline NamingCheckId getEmptyKey() {
33 return NamingCheckId(
34 clang::SourceLocation::getFromRawEncoding(static_cast<unsigned>(-1)),
35 "EMPTY");
36 }
37
38 static inline NamingCheckId getTombstoneKey() {
39 return NamingCheckId(
40 clang::SourceLocation::getFromRawEncoding(static_cast<unsigned>(-2)),
41 "TOMBSTONE");
42 }
43
44 static unsigned getHashValue(NamingCheckId Val) {
45 assert(Val != getEmptyKey() && "Cannot hash the empty key!");
46 assert(Val != getTombstoneKey() && "Cannot hash the tombstone key!");
47
48 std::hash<NamingCheckId::second_type> SecondHash;
49 return Val.first.getRawEncoding() + SecondHash(Val.second);
50 }
51
Benjamin Kramera079cdb2017-03-21 21:34:58 +000052 static bool isEqual(const NamingCheckId &LHS, const NamingCheckId &RHS) {
Alexander Kornienko21503902016-06-17 09:25:24 +000053 if (RHS == getEmptyKey())
54 return LHS == getEmptyKey();
55 if (RHS == getTombstoneKey())
56 return LHS == getTombstoneKey();
57 return LHS == RHS;
58 }
59};
60} // namespace llvm
61
Alexander Kornienko76c28802015-08-19 11:15:36 +000062namespace clang {
63namespace tidy {
64namespace readability {
65
Alexander Kornienko3d777682015-09-28 08:59:12 +000066// clang-format off
Alexander Kornienko76c28802015-08-19 11:15:36 +000067#define NAMING_KEYS(m) \
68 m(Namespace) \
69 m(InlineNamespace) \
70 m(EnumConstant) \
71 m(ConstexprVariable) \
72 m(ConstantMember) \
73 m(PrivateMember) \
74 m(ProtectedMember) \
75 m(PublicMember) \
76 m(Member) \
77 m(ClassConstant) \
78 m(ClassMember) \
79 m(GlobalConstant) \
Jonas Tothc97671e2018-10-04 15:47:57 +000080 m(GlobalConstantPointer) \
81 m(GlobalPointer) \
Alexander Kornienko76c28802015-08-19 11:15:36 +000082 m(GlobalVariable) \
83 m(LocalConstant) \
Jonas Tothc97671e2018-10-04 15:47:57 +000084 m(LocalConstantPointer) \
85 m(LocalPointer) \
Alexander Kornienko76c28802015-08-19 11:15:36 +000086 m(LocalVariable) \
87 m(StaticConstant) \
88 m(StaticVariable) \
89 m(Constant) \
90 m(Variable) \
91 m(ConstantParameter) \
92 m(ParameterPack) \
93 m(Parameter) \
Jonas Tothc97671e2018-10-04 15:47:57 +000094 m(PointerParameter) \
95 m(ConstantPointerParameter) \
Alexander Kornienko76c28802015-08-19 11:15:36 +000096 m(AbstractClass) \
97 m(Struct) \
98 m(Class) \
99 m(Union) \
100 m(Enum) \
101 m(GlobalFunction) \
102 m(ConstexprFunction) \
103 m(Function) \
104 m(ConstexprMethod) \
105 m(VirtualMethod) \
106 m(ClassMethod) \
107 m(PrivateMethod) \
108 m(ProtectedMethod) \
109 m(PublicMethod) \
110 m(Method) \
111 m(Typedef) \
112 m(TypeTemplateParameter) \
113 m(ValueTemplateParameter) \
114 m(TemplateTemplateParameter) \
115 m(TemplateParameter) \
Alexander Kornienko5ae76e02016-06-07 09:11:19 +0000116 m(TypeAlias) \
Alexander Kornienko21503902016-06-17 09:25:24 +0000117 m(MacroDefinition) \
Yan Zhang004b6c62018-04-23 00:15:15 +0000118 m(ObjcIvar) \
Alexander Kornienko76c28802015-08-19 11:15:36 +0000119
120enum StyleKind {
121#define ENUMERATE(v) SK_ ## v,
122 NAMING_KEYS(ENUMERATE)
123#undef ENUMERATE
124 SK_Count,
125 SK_Invalid
126};
127
128static StringRef const StyleNames[] = {
129#define STRINGIZE(v) #v,
130 NAMING_KEYS(STRINGIZE)
131#undef STRINGIZE
132};
133
134#undef NAMING_KEYS
Alexander Kornienko3d777682015-09-28 08:59:12 +0000135// clang-format on
Alexander Kornienko76c28802015-08-19 11:15:36 +0000136
Alexander Kornienko21503902016-06-17 09:25:24 +0000137namespace {
138/// Callback supplies macros to IdentifierNamingCheck::checkMacro
139class IdentifierNamingCheckPPCallbacks : public PPCallbacks {
140public:
141 IdentifierNamingCheckPPCallbacks(Preprocessor *PP,
142 IdentifierNamingCheck *Check)
143 : PP(PP), Check(Check) {}
144
145 /// MacroDefined calls checkMacro for macros in the main file
146 void MacroDefined(const Token &MacroNameTok,
147 const MacroDirective *MD) override {
148 Check->checkMacro(PP->getSourceManager(), MacroNameTok, MD->getMacroInfo());
149 }
150
151 /// MacroExpands calls expandMacro for macros in the main file
152 void MacroExpands(const Token &MacroNameTok, const MacroDefinition &MD,
153 SourceRange /*Range*/,
154 const MacroArgs * /*Args*/) override {
155 Check->expandMacro(MacroNameTok, MD.getMacroInfo());
156 }
157
158private:
159 Preprocessor *PP;
160 IdentifierNamingCheck *Check;
161};
162} // namespace
163
Alexander Kornienko76c28802015-08-19 11:15:36 +0000164IdentifierNamingCheck::IdentifierNamingCheck(StringRef Name,
165 ClangTidyContext *Context)
166 : ClangTidyCheck(Name, Context) {
167 auto const fromString = [](StringRef Str) {
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000168 return llvm::StringSwitch<llvm::Optional<CaseType>>(Str)
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000169 .Case("aNy_CasE", CT_AnyCase)
Alexander Kornienko76c28802015-08-19 11:15:36 +0000170 .Case("lower_case", CT_LowerCase)
171 .Case("UPPER_CASE", CT_UpperCase)
172 .Case("camelBack", CT_CamelBack)
173 .Case("CamelCase", CT_CamelCase)
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000174 .Case("Camel_Snake_Case", CT_CamelSnakeCase)
175 .Case("camel_Snake_Back", CT_CamelSnakeBack)
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000176 .Default(llvm::None);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000177 };
178
179 for (auto const &Name : StyleNames) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000180 auto const caseOptional =
181 fromString(Options.get((Name + "Case").str(), ""));
182 auto prefix = Options.get((Name + "Prefix").str(), "");
183 auto postfix = Options.get((Name + "Suffix").str(), "");
184
185 if (caseOptional || !prefix.empty() || !postfix.empty()) {
186 NamingStyles.push_back(NamingStyle(caseOptional, prefix, postfix));
187 } else {
188 NamingStyles.push_back(llvm::None);
189 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000190 }
191
192 IgnoreFailedSplit = Options.get("IgnoreFailedSplit", 0);
193}
194
195void IdentifierNamingCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
196 auto const toString = [](CaseType Type) {
197 switch (Type) {
198 case CT_AnyCase:
199 return "aNy_CasE";
200 case CT_LowerCase:
201 return "lower_case";
202 case CT_CamelBack:
203 return "camelBack";
204 case CT_UpperCase:
205 return "UPPER_CASE";
206 case CT_CamelCase:
207 return "CamelCase";
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000208 case CT_CamelSnakeCase:
209 return "Camel_Snake_Case";
210 case CT_CamelSnakeBack:
211 return "camel_Snake_Back";
Alexander Kornienko76c28802015-08-19 11:15:36 +0000212 }
213
214 llvm_unreachable("Unknown Case Type");
215 };
216
217 for (size_t i = 0; i < SK_Count; ++i) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000218 if (NamingStyles[i]) {
219 if (NamingStyles[i]->Case) {
220 Options.store(Opts, (StyleNames[i] + "Case").str(),
221 toString(*NamingStyles[i]->Case));
222 }
223 Options.store(Opts, (StyleNames[i] + "Prefix").str(),
224 NamingStyles[i]->Prefix);
225 Options.store(Opts, (StyleNames[i] + "Suffix").str(),
226 NamingStyles[i]->Suffix);
227 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000228 }
229
230 Options.store(Opts, "IgnoreFailedSplit", IgnoreFailedSplit);
231}
232
233void IdentifierNamingCheck::registerMatchers(MatchFinder *Finder) {
Alexander Kornienko76c28802015-08-19 11:15:36 +0000234 Finder->addMatcher(namedDecl().bind("decl"), this);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000235 Finder->addMatcher(usingDecl().bind("using"), this);
236 Finder->addMatcher(declRefExpr().bind("declRef"), this);
237 Finder->addMatcher(cxxConstructorDecl().bind("classRef"), this);
238 Finder->addMatcher(cxxDestructorDecl().bind("classRef"), this);
239 Finder->addMatcher(typeLoc().bind("typeLoc"), this);
240 Finder->addMatcher(nestedNameSpecifierLoc().bind("nestedNameLoc"), this);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000241}
242
Alexander Kornienko21503902016-06-17 09:25:24 +0000243void IdentifierNamingCheck::registerPPCallbacks(CompilerInstance &Compiler) {
244 Compiler.getPreprocessor().addPPCallbacks(
245 llvm::make_unique<IdentifierNamingCheckPPCallbacks>(
246 &Compiler.getPreprocessor(), this));
247}
248
Alexander Kornienko76c28802015-08-19 11:15:36 +0000249static bool matchesStyle(StringRef Name,
250 IdentifierNamingCheck::NamingStyle Style) {
251 static llvm::Regex Matchers[] = {
252 llvm::Regex("^.*$"),
253 llvm::Regex("^[a-z][a-z0-9_]*$"),
254 llvm::Regex("^[a-z][a-zA-Z0-9]*$"),
255 llvm::Regex("^[A-Z][A-Z0-9_]*$"),
256 llvm::Regex("^[A-Z][a-zA-Z0-9]*$"),
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000257 llvm::Regex("^[A-Z]([a-z0-9]*(_[A-Z])?)*"),
258 llvm::Regex("^[a-z]([a-z0-9]*(_[A-Z])?)*"),
Alexander Kornienko76c28802015-08-19 11:15:36 +0000259 };
260
261 bool Matches = true;
262 if (Name.startswith(Style.Prefix))
263 Name = Name.drop_front(Style.Prefix.size());
264 else
265 Matches = false;
266
267 if (Name.endswith(Style.Suffix))
268 Name = Name.drop_back(Style.Suffix.size());
269 else
270 Matches = false;
271
Alexander Kornienkoeec01ad2017-04-26 16:39:11 +0000272 // Ensure the name doesn't have any extra underscores beyond those specified
273 // in the prefix and suffix.
274 if (Name.startswith("_") || Name.endswith("_"))
275 Matches = false;
276
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000277 if (Style.Case && !Matchers[static_cast<size_t>(*Style.Case)].match(Name))
Alexander Kornienko76c28802015-08-19 11:15:36 +0000278 Matches = false;
279
280 return Matches;
281}
282
283static std::string fixupWithCase(StringRef Name,
284 IdentifierNamingCheck::CaseType Case) {
285 static llvm::Regex Splitter(
286 "([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$)");
287
288 SmallVector<StringRef, 8> Substrs;
289 Name.split(Substrs, "_", -1, false);
290
291 SmallVector<StringRef, 8> Words;
292 for (auto Substr : Substrs) {
293 while (!Substr.empty()) {
294 SmallVector<StringRef, 8> Groups;
295 if (!Splitter.match(Substr, &Groups))
296 break;
297
298 if (Groups[2].size() > 0) {
299 Words.push_back(Groups[1]);
300 Substr = Substr.substr(Groups[0].size());
301 } else if (Groups[3].size() > 0) {
302 Words.push_back(Groups[3]);
303 Substr = Substr.substr(Groups[0].size() - Groups[4].size());
304 } else if (Groups[5].size() > 0) {
305 Words.push_back(Groups[5]);
306 Substr = Substr.substr(Groups[0].size() - Groups[6].size());
307 }
308 }
309 }
310
311 if (Words.empty())
312 return Name;
313
314 std::string Fixup;
315 switch (Case) {
316 case IdentifierNamingCheck::CT_AnyCase:
317 Fixup += Name;
318 break;
319
320 case IdentifierNamingCheck::CT_LowerCase:
321 for (auto const &Word : Words) {
322 if (&Word != &Words.front())
323 Fixup += "_";
324 Fixup += Word.lower();
325 }
326 break;
327
328 case IdentifierNamingCheck::CT_UpperCase:
329 for (auto const &Word : Words) {
330 if (&Word != &Words.front())
331 Fixup += "_";
332 Fixup += Word.upper();
333 }
334 break;
335
336 case IdentifierNamingCheck::CT_CamelCase:
337 for (auto const &Word : Words) {
338 Fixup += Word.substr(0, 1).upper();
339 Fixup += Word.substr(1).lower();
340 }
341 break;
342
343 case IdentifierNamingCheck::CT_CamelBack:
344 for (auto const &Word : Words) {
345 if (&Word == &Words.front()) {
346 Fixup += Word.lower();
347 } else {
348 Fixup += Word.substr(0, 1).upper();
349 Fixup += Word.substr(1).lower();
350 }
351 }
352 break;
Kirill Bobyrev5d8f0712016-07-20 12:28:38 +0000353
354 case IdentifierNamingCheck::CT_CamelSnakeCase:
355 for (auto const &Word : Words) {
356 if (&Word != &Words.front())
357 Fixup += "_";
358 Fixup += Word.substr(0, 1).upper();
359 Fixup += Word.substr(1).lower();
360 }
361 break;
362
363 case IdentifierNamingCheck::CT_CamelSnakeBack:
364 for (auto const &Word : Words) {
365 if (&Word != &Words.front()) {
366 Fixup += "_";
367 Fixup += Word.substr(0, 1).upper();
368 } else {
369 Fixup += Word.substr(0, 1).lower();
370 }
371 Fixup += Word.substr(1).lower();
372 }
373 break;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000374 }
375
376 return Fixup;
377}
378
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000379static std::string
380fixupWithStyle(StringRef Name,
381 const IdentifierNamingCheck::NamingStyle &Style) {
Alexander Kornienkoeec01ad2017-04-26 16:39:11 +0000382 const std::string Fixed = fixupWithCase(
383 Name, Style.Case.getValueOr(IdentifierNamingCheck::CaseType::CT_AnyCase));
384 StringRef Mid = StringRef(Fixed).trim("_");
385 if (Mid.empty())
386 Mid = "_";
387 return (Style.Prefix + Mid + Style.Suffix).str();
Alexander Kornienko76c28802015-08-19 11:15:36 +0000388}
389
390static StyleKind findStyleKind(
391 const NamedDecl *D,
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000392 const std::vector<llvm::Optional<IdentifierNamingCheck::NamingStyle>>
393 &NamingStyles) {
Artem Belevichfcfcd502018-09-18 21:51:02 +0000394 assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() &&
395 "Decl must be an explicit identifier with a name.");
396
Yan Zhang004b6c62018-04-23 00:15:15 +0000397 if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar])
398 return SK_ObjcIvar;
399
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000400 if (isa<TypedefDecl>(D) && NamingStyles[SK_Typedef])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000401 return SK_Typedef;
402
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000403 if (isa<TypeAliasDecl>(D) && NamingStyles[SK_TypeAlias])
Alexander Kornienko5ae76e02016-06-07 09:11:19 +0000404 return SK_TypeAlias;
405
Alexander Kornienko76c28802015-08-19 11:15:36 +0000406 if (const auto *Decl = dyn_cast<NamespaceDecl>(D)) {
407 if (Decl->isAnonymousNamespace())
408 return SK_Invalid;
409
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000410 if (Decl->isInline() && NamingStyles[SK_InlineNamespace])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000411 return SK_InlineNamespace;
412
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000413 if (NamingStyles[SK_Namespace])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000414 return SK_Namespace;
415 }
416
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000417 if (isa<EnumDecl>(D) && NamingStyles[SK_Enum])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000418 return SK_Enum;
419
420 if (isa<EnumConstantDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000421 if (NamingStyles[SK_EnumConstant])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000422 return SK_EnumConstant;
423
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000424 if (NamingStyles[SK_Constant])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000425 return SK_Constant;
426
427 return SK_Invalid;
428 }
429
430 if (const auto *Decl = dyn_cast<CXXRecordDecl>(D)) {
431 if (Decl->isAnonymousStructOrUnion())
432 return SK_Invalid;
433
Jonathan Coe89f12c02016-11-03 13:52:09 +0000434 if (!Decl->getCanonicalDecl()->isThisDeclarationADefinition())
435 return SK_Invalid;
436
Alexander Kornienko76c28802015-08-19 11:15:36 +0000437 if (Decl->hasDefinition() && Decl->isAbstract() &&
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000438 NamingStyles[SK_AbstractClass])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000439 return SK_AbstractClass;
440
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000441 if (Decl->isStruct() && NamingStyles[SK_Struct])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000442 return SK_Struct;
443
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000444 if (Decl->isStruct() && NamingStyles[SK_Class])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000445 return SK_Class;
446
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000447 if (Decl->isClass() && NamingStyles[SK_Class])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000448 return SK_Class;
449
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000450 if (Decl->isClass() && NamingStyles[SK_Struct])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000451 return SK_Struct;
452
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000453 if (Decl->isUnion() && NamingStyles[SK_Union])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000454 return SK_Union;
455
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000456 if (Decl->isEnum() && NamingStyles[SK_Enum])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000457 return SK_Enum;
458
459 return SK_Invalid;
460 }
461
462 if (const auto *Decl = dyn_cast<FieldDecl>(D)) {
463 QualType Type = Decl->getType();
464
Alexander Kornienkoba874922017-12-11 19:02:26 +0000465 if (!Type.isNull() && Type.isConstQualified()) {
466 if (NamingStyles[SK_ConstantMember])
467 return SK_ConstantMember;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000468
Alexander Kornienkoba874922017-12-11 19:02:26 +0000469 if (NamingStyles[SK_Constant])
470 return SK_Constant;
471 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000472
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000473 if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000474 return SK_PrivateMember;
475
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000476 if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000477 return SK_ProtectedMember;
478
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000479 if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000480 return SK_PublicMember;
481
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000482 if (NamingStyles[SK_Member])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000483 return SK_Member;
484
485 return SK_Invalid;
486 }
487
488 if (const auto *Decl = dyn_cast<ParmVarDecl>(D)) {
489 QualType Type = Decl->getType();
490
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000491 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000492 return SK_ConstexprVariable;
493
Alexander Kornienkoba874922017-12-11 19:02:26 +0000494 if (!Type.isNull() && Type.isConstQualified()) {
Jonas Tothc97671e2018-10-04 15:47:57 +0000495 if (Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_ConstantPointerParameter])
496 return SK_ConstantPointerParameter;
497
Alexander Kornienkoba874922017-12-11 19:02:26 +0000498 if (NamingStyles[SK_ConstantParameter])
499 return SK_ConstantParameter;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000500
Alexander Kornienkoba874922017-12-11 19:02:26 +0000501 if (NamingStyles[SK_Constant])
502 return SK_Constant;
503 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000504
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000505 if (Decl->isParameterPack() && NamingStyles[SK_ParameterPack])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000506 return SK_ParameterPack;
507
Jonas Tothc97671e2018-10-04 15:47:57 +0000508 if (!Type.isNull() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_PointerParameter])
509 return SK_PointerParameter;
510
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000511 if (NamingStyles[SK_Parameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000512 return SK_Parameter;
513
514 return SK_Invalid;
515 }
516
517 if (const auto *Decl = dyn_cast<VarDecl>(D)) {
518 QualType Type = Decl->getType();
519
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000520 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000521 return SK_ConstexprVariable;
522
Alexander Kornienkoba874922017-12-11 19:02:26 +0000523 if (!Type.isNull() && Type.isConstQualified()) {
524 if (Decl->isStaticDataMember() && NamingStyles[SK_ClassConstant])
525 return SK_ClassConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000526
Jonas Tothc97671e2018-10-04 15:47:57 +0000527 if (Decl->isFileVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_GlobalConstantPointer])
528 return SK_GlobalConstantPointer;
529
Alexander Kornienkoba874922017-12-11 19:02:26 +0000530 if (Decl->isFileVarDecl() && NamingStyles[SK_GlobalConstant])
531 return SK_GlobalConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000532
Alexander Kornienkoba874922017-12-11 19:02:26 +0000533 if (Decl->isStaticLocal() && NamingStyles[SK_StaticConstant])
534 return SK_StaticConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000535
Jonas Tothc97671e2018-10-04 15:47:57 +0000536 if (Decl->isLocalVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_LocalConstantPointer])
537 return SK_LocalConstantPointer;
538
Alexander Kornienkoba874922017-12-11 19:02:26 +0000539 if (Decl->isLocalVarDecl() && NamingStyles[SK_LocalConstant])
540 return SK_LocalConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000541
Alexander Kornienkoba874922017-12-11 19:02:26 +0000542 if (Decl->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalConstant])
543 return SK_LocalConstant;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000544
Alexander Kornienkoba874922017-12-11 19:02:26 +0000545 if (NamingStyles[SK_Constant])
546 return SK_Constant;
547 }
Alexander Kornienko76c28802015-08-19 11:15:36 +0000548
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000549 if (Decl->isStaticDataMember() && NamingStyles[SK_ClassMember])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000550 return SK_ClassMember;
551
Jonas Tothc97671e2018-10-04 15:47:57 +0000552 if (Decl->isFileVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_GlobalPointer])
553 return SK_GlobalPointer;
554
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000555 if (Decl->isFileVarDecl() && NamingStyles[SK_GlobalVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000556 return SK_GlobalVariable;
557
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000558 if (Decl->isStaticLocal() && NamingStyles[SK_StaticVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000559 return SK_StaticVariable;
Jonas Tothc97671e2018-10-04 15:47:57 +0000560
561 if (Decl->isLocalVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_LocalPointer])
562 return SK_LocalPointer;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000563
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000564 if (Decl->isLocalVarDecl() && NamingStyles[SK_LocalVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000565 return SK_LocalVariable;
566
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000567 if (Decl->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalVariable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000568 return SK_LocalVariable;
569
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000570 if (NamingStyles[SK_Variable])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000571 return SK_Variable;
572
573 return SK_Invalid;
574 }
575
576 if (const auto *Decl = dyn_cast<CXXMethodDecl>(D)) {
577 if (Decl->isMain() || !Decl->isUserProvided() ||
Alexander Kornienko76c28802015-08-19 11:15:36 +0000578 Decl->size_overridden_methods() > 0)
579 return SK_Invalid;
580
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000581 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000582 return SK_ConstexprMethod;
583
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000584 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000585 return SK_ConstexprFunction;
586
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000587 if (Decl->isStatic() && NamingStyles[SK_ClassMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000588 return SK_ClassMethod;
589
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000590 if (Decl->isVirtual() && NamingStyles[SK_VirtualMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000591 return SK_VirtualMethod;
592
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000593 if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000594 return SK_PrivateMethod;
595
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000596 if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000597 return SK_ProtectedMethod;
598
Alexander Kornienko1c657f72017-03-22 12:50:05 +0000599 if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMethod])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000600 return SK_PublicMethod;
601
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000602 if (NamingStyles[SK_Method])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000603 return SK_Method;
604
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000605 if (NamingStyles[SK_Function])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000606 return SK_Function;
607
608 return SK_Invalid;
609 }
610
611 if (const auto *Decl = dyn_cast<FunctionDecl>(D)) {
612 if (Decl->isMain())
613 return SK_Invalid;
614
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000615 if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000616 return SK_ConstexprFunction;
617
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000618 if (Decl->isGlobal() && NamingStyles[SK_GlobalFunction])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000619 return SK_GlobalFunction;
620
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000621 if (NamingStyles[SK_Function])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000622 return SK_Function;
623 }
624
625 if (isa<TemplateTypeParmDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000626 if (NamingStyles[SK_TypeTemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000627 return SK_TypeTemplateParameter;
628
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000629 if (NamingStyles[SK_TemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000630 return SK_TemplateParameter;
631
632 return SK_Invalid;
633 }
634
635 if (isa<NonTypeTemplateParmDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000636 if (NamingStyles[SK_ValueTemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000637 return SK_ValueTemplateParameter;
638
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000639 if (NamingStyles[SK_TemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000640 return SK_TemplateParameter;
641
642 return SK_Invalid;
643 }
644
645 if (isa<TemplateTemplateParmDecl>(D)) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000646 if (NamingStyles[SK_TemplateTemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000647 return SK_TemplateTemplateParameter;
648
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000649 if (NamingStyles[SK_TemplateParameter])
Alexander Kornienko76c28802015-08-19 11:15:36 +0000650 return SK_TemplateParameter;
651
652 return SK_Invalid;
653 }
654
655 return SK_Invalid;
656}
657
Alexander Kornienko3d777682015-09-28 08:59:12 +0000658static void addUsage(IdentifierNamingCheck::NamingCheckFailureMap &Failures,
Alexander Kornienko21503902016-06-17 09:25:24 +0000659 const IdentifierNamingCheck::NamingCheckId &Decl,
Jason Henline481e6aa2016-10-24 17:20:32 +0000660 SourceRange Range, SourceManager *SourceMgr = nullptr) {
Jonathan Coe2c8592a2016-01-26 18:55:55 +0000661 // Do nothing if the provided range is invalid.
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000662 if (Range.getBegin().isInvalid() || Range.getEnd().isInvalid())
663 return;
664
Jason Henline481e6aa2016-10-24 17:20:32 +0000665 // If we have a source manager, use it to convert to the spelling location for
666 // performing the fix. This is necessary because macros can map the same
667 // spelling location to different source locations, and we only want to fix
668 // the token once, before it is expanded by the macro.
669 SourceLocation FixLocation = Range.getBegin();
670 if (SourceMgr)
671 FixLocation = SourceMgr->getSpellingLoc(FixLocation);
672 if (FixLocation.isInvalid())
673 return;
674
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000675 // Try to insert the identifier location in the Usages map, and bail out if it
676 // is already in there
Alexander Kornienko3d777682015-09-28 08:59:12 +0000677 auto &Failure = Failures[Decl];
Jason Henline481e6aa2016-10-24 17:20:32 +0000678 if (!Failure.RawUsageLocs.insert(FixLocation.getRawEncoding()).second)
Alexander Kornienko3d777682015-09-28 08:59:12 +0000679 return;
680
Jason Henline481e6aa2016-10-24 17:20:32 +0000681 if (!Failure.ShouldFix)
682 return;
683
Roman Lebedev08701ec2018-10-26 13:09:27 +0000684 Failure.ShouldFix = utils::rangeCanBeFixed(Range, SourceMgr);
Alexander Kornienko3d777682015-09-28 08:59:12 +0000685}
686
Alexander Kornienko21503902016-06-17 09:25:24 +0000687/// Convenience method when the usage to be added is a NamedDecl
688static void addUsage(IdentifierNamingCheck::NamingCheckFailureMap &Failures,
Mandeep Singh Grang7c7ea7d2016-11-08 07:50:19 +0000689 const NamedDecl *Decl, SourceRange Range,
690 SourceManager *SourceMgr = nullptr) {
Alexander Kornienkoba874922017-12-11 19:02:26 +0000691 return addUsage(Failures,
692 IdentifierNamingCheck::NamingCheckId(Decl->getLocation(),
693 Decl->getNameAsString()),
Jason Henline481e6aa2016-10-24 17:20:32 +0000694 Range, SourceMgr);
Alexander Kornienko21503902016-06-17 09:25:24 +0000695}
696
Alexander Kornienko76c28802015-08-19 11:15:36 +0000697void IdentifierNamingCheck::check(const MatchFinder::MatchResult &Result) {
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000698 if (const auto *Decl =
699 Result.Nodes.getNodeAs<CXXConstructorDecl>("classRef")) {
700 if (Decl->isImplicit())
701 return;
702
703 addUsage(NamingCheckFailures, Decl->getParent(),
Alexander Kornienko21503902016-06-17 09:25:24 +0000704 Decl->getNameInfo().getSourceRange());
Eric Fiselier732a3e02016-11-16 21:15:58 +0000705
706 for (const auto *Init : Decl->inits()) {
707 if (!Init->isWritten() || Init->isInClassMemberInitializer())
708 continue;
709 if (const auto *FD = Init->getAnyMember())
Alexander Kornienkoba874922017-12-11 19:02:26 +0000710 addUsage(NamingCheckFailures, FD,
711 SourceRange(Init->getMemberLocation()));
Eric Fiselier732a3e02016-11-16 21:15:58 +0000712 // Note: delegating constructors and base class initializers are handled
713 // via the "typeLoc" matcher.
714 }
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000715 return;
716 }
717
718 if (const auto *Decl =
719 Result.Nodes.getNodeAs<CXXDestructorDecl>("classRef")) {
720 if (Decl->isImplicit())
721 return;
722
723 SourceRange Range = Decl->getNameInfo().getSourceRange();
724 if (Range.getBegin().isInvalid())
725 return;
726 // The first token that will be found is the ~ (or the equivalent trigraph),
727 // we want instead to replace the next token, that will be the identifier.
728 Range.setBegin(CharSourceRange::getTokenRange(Range).getEnd());
729
Alexander Kornienko21503902016-06-17 09:25:24 +0000730 addUsage(NamingCheckFailures, Decl->getParent(), Range);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000731 return;
732 }
733
734 if (const auto *Loc = Result.Nodes.getNodeAs<TypeLoc>("typeLoc")) {
735 NamedDecl *Decl = nullptr;
736 if (const auto &Ref = Loc->getAs<TagTypeLoc>()) {
737 Decl = Ref.getDecl();
738 } else if (const auto &Ref = Loc->getAs<InjectedClassNameTypeLoc>()) {
739 Decl = Ref.getDecl();
740 } else if (const auto &Ref = Loc->getAs<UnresolvedUsingTypeLoc>()) {
741 Decl = Ref.getDecl();
742 } else if (const auto &Ref = Loc->getAs<TemplateTypeParmTypeLoc>()) {
743 Decl = Ref.getDecl();
744 }
745
746 if (Decl) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000747 addUsage(NamingCheckFailures, Decl, Loc->getSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000748 return;
749 }
750
751 if (const auto &Ref = Loc->getAs<TemplateSpecializationTypeLoc>()) {
752 const auto *Decl =
753 Ref.getTypePtr()->getTemplateName().getAsTemplateDecl();
754
755 SourceRange Range(Ref.getTemplateNameLoc(), Ref.getTemplateNameLoc());
756 if (const auto *ClassDecl = dyn_cast<TemplateDecl>(Decl)) {
Matthias Gehrea9e812b2016-07-09 20:09:28 +0000757 if (const auto *TemplDecl = ClassDecl->getTemplatedDecl())
758 addUsage(NamingCheckFailures, TemplDecl, Range);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000759 return;
760 }
761 }
762
763 if (const auto &Ref =
764 Loc->getAs<DependentTemplateSpecializationTypeLoc>()) {
Matthias Gehrea9e812b2016-07-09 20:09:28 +0000765 if (const auto *Decl = Ref.getTypePtr()->getAsTagDecl())
766 addUsage(NamingCheckFailures, Decl, Loc->getSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000767 return;
768 }
769 }
770
771 if (const auto *Loc =
772 Result.Nodes.getNodeAs<NestedNameSpecifierLoc>("nestedNameLoc")) {
773 if (NestedNameSpecifier *Spec = Loc->getNestedNameSpecifier()) {
774 if (NamespaceDecl *Decl = Spec->getAsNamespace()) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000775 addUsage(NamingCheckFailures, Decl, Loc->getLocalSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000776 return;
777 }
778 }
779 }
780
781 if (const auto *Decl = Result.Nodes.getNodeAs<UsingDecl>("using")) {
782 for (const auto &Shadow : Decl->shadows()) {
783 addUsage(NamingCheckFailures, Shadow->getTargetDecl(),
Alexander Kornienko21503902016-06-17 09:25:24 +0000784 Decl->getNameInfo().getSourceRange());
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000785 }
786 return;
787 }
788
789 if (const auto *DeclRef = Result.Nodes.getNodeAs<DeclRefExpr>("declRef")) {
Alexander Kornienko76c28802015-08-19 11:15:36 +0000790 SourceRange Range = DeclRef->getNameInfo().getSourceRange();
Mandeep Singh Grang7c7ea7d2016-11-08 07:50:19 +0000791 addUsage(NamingCheckFailures, DeclRef->getDecl(), Range,
792 Result.SourceManager);
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000793 return;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000794 }
795
796 if (const auto *Decl = Result.Nodes.getNodeAs<NamedDecl>("decl")) {
797 if (!Decl->getIdentifier() || Decl->getName().empty() || Decl->isImplicit())
798 return;
799
Alexander Kornienko21503902016-06-17 09:25:24 +0000800 // Fix type aliases in value declarations
801 if (const auto *Value = Result.Nodes.getNodeAs<ValueDecl>("decl")) {
802 if (const auto *Typedef =
803 Value->getType().getTypePtr()->getAs<TypedefType>()) {
804 addUsage(NamingCheckFailures, Typedef->getDecl(),
805 Value->getSourceRange());
806 }
807 }
808
809 // Fix type aliases in function declarations
810 if (const auto *Value = Result.Nodes.getNodeAs<FunctionDecl>("decl")) {
811 if (const auto *Typedef =
812 Value->getReturnType().getTypePtr()->getAs<TypedefType>()) {
813 addUsage(NamingCheckFailures, Typedef->getDecl(),
814 Value->getSourceRange());
815 }
816 for (unsigned i = 0; i < Value->getNumParams(); ++i) {
817 if (const auto *Typedef = Value->parameters()[i]
818 ->getType()
819 .getTypePtr()
820 ->getAs<TypedefType>()) {
821 addUsage(NamingCheckFailures, Typedef->getDecl(),
822 Value->getSourceRange());
823 }
824 }
825 }
826
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000827 // Ignore ClassTemplateSpecializationDecl which are creating duplicate
828 // replacements with CXXRecordDecl
829 if (isa<ClassTemplateSpecializationDecl>(Decl))
830 return;
831
Alexander Kornienko76c28802015-08-19 11:15:36 +0000832 StyleKind SK = findStyleKind(Decl, NamingStyles);
833 if (SK == SK_Invalid)
834 return;
835
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000836 if (!NamingStyles[SK])
837 return;
838
839 const NamingStyle &Style = *NamingStyles[SK];
Alexander Kornienko76c28802015-08-19 11:15:36 +0000840 StringRef Name = Decl->getName();
841 if (matchesStyle(Name, Style))
842 return;
843
844 std::string KindName = fixupWithCase(StyleNames[SK], CT_LowerCase);
845 std::replace(KindName.begin(), KindName.end(), '_', ' ');
846
847 std::string Fixup = fixupWithStyle(Name, Style);
848 if (StringRef(Fixup).equals(Name)) {
849 if (!IgnoreFailedSplit) {
Nicola Zaghen0efd5242018-05-15 16:37:45 +0000850 LLVM_DEBUG(llvm::dbgs()
Stephen Kelly43465bf2018-08-09 22:42:26 +0000851 << Decl->getBeginLoc().printToString(*Result.SourceManager)
Nicola Zaghen0efd5242018-05-15 16:37:45 +0000852 << llvm::format(": unable to split words for %s '%s'\n",
853 KindName.c_str(), Name.str().c_str()));
Alexander Kornienko76c28802015-08-19 11:15:36 +0000854 }
855 } else {
Alexander Kornienko21503902016-06-17 09:25:24 +0000856 NamingCheckFailure &Failure = NamingCheckFailures[NamingCheckId(
857 Decl->getLocation(), Decl->getNameAsString())];
Alexander Kornienko76c28802015-08-19 11:15:36 +0000858 SourceRange Range =
859 DeclarationNameInfo(Decl->getDeclName(), Decl->getLocation())
860 .getSourceRange();
861
862 Failure.Fixup = std::move(Fixup);
863 Failure.KindName = std::move(KindName);
Alexander Kornienko21503902016-06-17 09:25:24 +0000864 addUsage(NamingCheckFailures, Decl, Range);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000865 }
866 }
867}
868
Alexander Kornienko21503902016-06-17 09:25:24 +0000869void IdentifierNamingCheck::checkMacro(SourceManager &SourceMgr,
870 const Token &MacroNameTok,
871 const MacroInfo *MI) {
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000872 if (!NamingStyles[SK_MacroDefinition])
873 return;
874
Alexander Kornienko21503902016-06-17 09:25:24 +0000875 StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
Alexander Kornienkoee9247e2017-03-22 12:49:58 +0000876 const NamingStyle &Style = *NamingStyles[SK_MacroDefinition];
Alexander Kornienko21503902016-06-17 09:25:24 +0000877 if (matchesStyle(Name, Style))
878 return;
879
880 std::string KindName =
881 fixupWithCase(StyleNames[SK_MacroDefinition], CT_LowerCase);
882 std::replace(KindName.begin(), KindName.end(), '_', ' ');
883
884 std::string Fixup = fixupWithStyle(Name, Style);
885 if (StringRef(Fixup).equals(Name)) {
886 if (!IgnoreFailedSplit) {
Nicola Zaghen0efd5242018-05-15 16:37:45 +0000887 LLVM_DEBUG(llvm::dbgs()
888 << MacroNameTok.getLocation().printToString(SourceMgr)
889 << llvm::format(": unable to split words for %s '%s'\n",
890 KindName.c_str(), Name.str().c_str()));
Alexander Kornienko21503902016-06-17 09:25:24 +0000891 }
892 } else {
893 NamingCheckId ID(MI->getDefinitionLoc(), Name);
894 NamingCheckFailure &Failure = NamingCheckFailures[ID];
895 SourceRange Range(MacroNameTok.getLocation(), MacroNameTok.getEndLoc());
896
897 Failure.Fixup = std::move(Fixup);
898 Failure.KindName = std::move(KindName);
899 addUsage(NamingCheckFailures, ID, Range);
900 }
901}
902
903void IdentifierNamingCheck::expandMacro(const Token &MacroNameTok,
904 const MacroInfo *MI) {
905 StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
906 NamingCheckId ID(MI->getDefinitionLoc(), Name);
907
908 auto Failure = NamingCheckFailures.find(ID);
909 if (Failure == NamingCheckFailures.end())
910 return;
911
912 SourceRange Range(MacroNameTok.getLocation(), MacroNameTok.getEndLoc());
913 addUsage(NamingCheckFailures, ID, Range);
914}
915
Alexander Kornienko76c28802015-08-19 11:15:36 +0000916void IdentifierNamingCheck::onEndOfTranslationUnit() {
917 for (const auto &Pair : NamingCheckFailures) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000918 const NamingCheckId &Decl = Pair.first;
Alexander Kornienko76c28802015-08-19 11:15:36 +0000919 const NamingCheckFailure &Failure = Pair.second;
920
Alexander Kornienko3d777682015-09-28 08:59:12 +0000921 if (Failure.KindName.empty())
922 continue;
923
Alexander Kornienko76c28802015-08-19 11:15:36 +0000924 if (Failure.ShouldFix) {
Alexander Kornienko21503902016-06-17 09:25:24 +0000925 auto Diag = diag(Decl.first, "invalid case style for %0 '%1'")
926 << Failure.KindName << Decl.second;
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000927
Alexander Kornienko3d777682015-09-28 08:59:12 +0000928 for (const auto &Loc : Failure.RawUsageLocs) {
929 // We assume that the identifier name is made of one token only. This is
930 // always the case as we ignore usages in macros that could build
931 // identifier names by combining multiple tokens.
Alexander Kornienko30c423b2015-10-01 09:19:40 +0000932 //
933 // For destructors, we alread take care of it by remembering the
934 // location of the start of the identifier and not the start of the
935 // tilde.
936 //
937 // Other multi-token identifiers, such as operators are not checked at
938 // all.
Alexander Kornienko76c28802015-08-19 11:15:36 +0000939 Diag << FixItHint::CreateReplacement(
Alexander Kornienko3d777682015-09-28 08:59:12 +0000940 SourceRange(SourceLocation::getFromRawEncoding(Loc)),
941 Failure.Fixup);
Alexander Kornienko76c28802015-08-19 11:15:36 +0000942 }
943 }
944 }
945}
946
947} // namespace readability
948} // namespace tidy
949} // namespace clang