blob: f108e8c74b1769a56105070a7fe933a01d4a8508 [file] [log] [blame]
Serge Guelton16228bc2019-01-03 15:44:24 +00001#!/usr/bin/env python
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00002
Sanjay Patelcae64a02017-06-12 17:44:30 +00003"""A script to generate FileCheck statements for 'opt' regression tests.
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00004
Sanjay Patelcae64a02017-06-12 17:44:30 +00005This script is a utility to update LLVM opt test cases with new
Sanjay Patelfff7a3d2016-03-24 23:19:26 +00006FileCheck patterns. It can either update all of the tests in the file or
7a single test function.
Sanjay Patel40641582016-04-05 18:00:47 +00008
9Example usage:
Sanjay Patelcae64a02017-06-12 17:44:30 +000010$ update_test_checks.py --opt=../bin/opt test/foo.ll
Sanjay Patel40641582016-04-05 18:00:47 +000011
12Workflow:
131. Make a compiler patch that requires updating some number of FileCheck lines
14 in regression test files.
152. Save the patch and revert it from your local work area.
163. Update the RUN-lines in the affected regression tests to look canonical.
17 Example: "; RUN: opt < %s -instcombine -S | FileCheck %s"
184. Refresh the FileCheck lines for either the entire file or select functions by
19 running this script.
205. Commit the fresh baseline of checks.
216. Apply your patch from step 1 and rebuild your local binaries.
227. Re-run this script on affected regression tests.
238. Check the diffs to ensure the script has done something reasonable.
249. Submit a patch including the regression test diffs for review.
25
26A common pattern is to have the script insert complete checking of every
27instruction. Then, edit it down to only check the relevant instructions.
28The script is designed to make adding checks to a test case fast, it is *not*
29designed to be authoratitive about what constitutes a good test!
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000030"""
31
Serge Guelton4a274782019-01-03 14:11:33 +000032from __future__ import print_function
33
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000034import argparse
Simon Pilgrimf509fe42019-03-05 10:44:37 +000035import glob
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000036import itertools
37import os # Used to advertise this file's name ("autogenerated_note").
38import string
39import subprocess
40import sys
41import tempfile
42import re
43
Fangrui Songee4e2e72018-01-30 00:40:05 +000044from UpdateTestChecks import common
45
Sanjay Patel16be4df92016-04-05 19:50:21 +000046ADVERT = '; NOTE: Assertions have been autogenerated by '
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000047
48# RegEx: this is where the magic happens.
49
Sanjay Patele54e6f52016-03-25 17:00:12 +000050IR_FUNCTION_RE = re.compile('^\s*define\s+(?:internal\s+)?[^@]*@([\w-]+)\s*\(')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000051
52
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000053
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000054
55
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000056def main():
Sanjay Patel40641582016-04-05 18:00:47 +000057 from argparse import RawTextHelpFormatter
58 parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000059 parser.add_argument('-v', '--verbose', action='store_true',
60 help='Show verbose output')
Sanjay Patelcae64a02017-06-12 17:44:30 +000061 parser.add_argument('--opt-binary', default='opt',
62 help='The opt binary used to generate the test case')
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000063 parser.add_argument(
64 '--function', help='The function in the test file to update')
65 parser.add_argument('tests', nargs='+')
66 args = parser.parse_args()
67
Sanjay Patel16be4df92016-04-05 19:50:21 +000068 autogenerated_note = (ADVERT + 'utils/' + os.path.basename(__file__))
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000069
Sanjay Patelcae64a02017-06-12 17:44:30 +000070 opt_basename = os.path.basename(args.opt_binary)
71 if (opt_basename != "opt"):
Serge Guelton4a274782019-01-03 14:11:33 +000072 print('ERROR: Unexpected opt name: ' + opt_basename, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000073 sys.exit(1)
74
Simon Pilgrimf509fe42019-03-05 10:44:37 +000075 test_paths = [test for pattern in args.tests for test in glob.glob(pattern)]
76 for test in test_paths:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000077 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +000078 print('Scanning for RUN lines in test file: %s' % (test,), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000079 with open(test) as f:
80 input_lines = [l.rstrip() for l in f]
81
Bryant Wong291264b2016-12-29 19:32:34 +000082 raw_lines = [m.group(1)
Fangrui Songee4e2e72018-01-30 00:40:05 +000083 for m in [common.RUN_LINE_RE.match(l) for l in input_lines] if m]
Bryant Wong291264b2016-12-29 19:32:34 +000084 run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
85 for l in raw_lines[1:]:
Bryant Wong507256b2016-12-29 20:05:51 +000086 if run_lines[-1].endswith("\\"):
87 run_lines[-1] = run_lines[-1].rstrip("\\") + " " + l
88 else:
89 run_lines.append(l)
Bryant Wong291264b2016-12-29 19:32:34 +000090
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000091 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +000092 print('Found %d RUN lines:' % (len(run_lines),), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000093 for l in run_lines:
Serge Guelton4a274782019-01-03 14:11:33 +000094 print(' RUN: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +000095
96 prefix_list = []
97 for l in run_lines:
98 (tool_cmd, filecheck_cmd) = tuple([cmd.strip() for cmd in l.split('|', 1)])
99
Sanjay Patelcae64a02017-06-12 17:44:30 +0000100 if not tool_cmd.startswith(opt_basename + ' '):
Serge Guelton4a274782019-01-03 14:11:33 +0000101 print('WARNING: Skipping non-%s RUN line: %s' % (opt_basename, l), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000102 continue
103
104 if not filecheck_cmd.startswith('FileCheck '):
Serge Guelton4a274782019-01-03 14:11:33 +0000105 print('WARNING: Skipping non-FileChecked RUN line: ' + l, file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000106 continue
107
Sanjay Patelcae64a02017-06-12 17:44:30 +0000108 tool_cmd_args = tool_cmd[len(opt_basename):].strip()
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000109 tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip()
110
Fangrui Songee4e2e72018-01-30 00:40:05 +0000111 check_prefixes = [item for m in common.CHECK_PREFIX_RE.finditer(filecheck_cmd)
Nikolai Bozhenov33ee40e2017-01-14 09:39:35 +0000112 for item in m.group(1).split(',')]
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000113 if not check_prefixes:
114 check_prefixes = ['CHECK']
115
116 # FIXME: We should use multiple check prefixes to common check lines. For
117 # now, we just ignore all but the last.
118 prefix_list.append((check_prefixes, tool_cmd_args))
119
120 func_dict = {}
121 for prefixes, _ in prefix_list:
122 for prefix in prefixes:
123 func_dict.update({prefix: dict()})
Sanjay Patelcae64a02017-06-12 17:44:30 +0000124 for prefixes, opt_args in prefix_list:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000125 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000126 print('Extracted opt cmd: ' + opt_basename + ' ' + opt_args, file=sys.stderr)
127 print('Extracted FileCheck prefixes: ' + str(prefixes), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000128
Fangrui Songee4e2e72018-01-30 00:40:05 +0000129 raw_tool_output = common.invoke_tool(args.opt_binary, opt_args, test)
130 common.build_function_body_dictionary(
Fangrui Song4f0f4262018-02-10 05:01:33 +0000131 common.OPT_FUNCTION_RE, common.scrub_body, [],
132 raw_tool_output, prefixes, func_dict, args.verbose)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000133
134 is_in_function = False
135 is_in_function_start = False
136 prefix_set = set([prefix for prefixes, _ in prefix_list for prefix in prefixes])
137 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000138 print('Rewriting FileCheck prefixes: %s' % (prefix_set,), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000139 output_lines = []
140 output_lines.append(autogenerated_note)
141
142 for input_line in input_lines:
143 if is_in_function_start:
144 if input_line == '':
145 continue
146 if input_line.lstrip().startswith(';'):
Fangrui Songee4e2e72018-01-30 00:40:05 +0000147 m = common.CHECK_RE.match(input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000148 if not m or m.group(1) not in prefix_set:
149 output_lines.append(input_line)
150 continue
151
152 # Print out the various check lines here.
Simon Pilgrimabba0482018-04-05 09:30:42 +0000153 common.add_ir_checks(output_lines, ';', prefix_list, func_dict, func_name)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000154 is_in_function_start = False
155
156 if is_in_function:
Fangrui Songee4e2e72018-01-30 00:40:05 +0000157 if common.should_add_line_to_output(input_line, prefix_set):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000158 # This input line of the function body will go as-is into the output.
Sanjay Pateld8592712016-03-27 20:43:02 +0000159 # Except make leading whitespace uniform: 2 spaces.
Fangrui Songee4e2e72018-01-30 00:40:05 +0000160 input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000161 output_lines.append(input_line)
162 else:
163 continue
164 if input_line.strip() == '}':
165 is_in_function = False
166 continue
167
Sanjay Patel16be4df92016-04-05 19:50:21 +0000168 # Discard any previous script advertising.
169 if input_line.startswith(ADVERT):
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000170 continue
171
172 # If it's outside a function, it just gets copied to the output.
173 output_lines.append(input_line)
174
175 m = IR_FUNCTION_RE.match(input_line)
176 if not m:
177 continue
Fangrui Songee4e2e72018-01-30 00:40:05 +0000178 func_name = m.group(1)
179 if args.function is not None and func_name != args.function:
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000180 # When filtering on a specific function, skip all others.
181 continue
182 is_in_function = is_in_function_start = True
183
184 if args.verbose:
Serge Guelton4a274782019-01-03 14:11:33 +0000185 print('Writing %d lines to %s...' % (len(output_lines), test), file=sys.stderr)
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000186
187 with open(test, 'wb') as f:
Simon Pilgrimd82bd4d2019-01-30 16:15:59 +0000188 f.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines])
Sanjay Patelfff7a3d2016-03-24 23:19:26 +0000189
190
191if __name__ == '__main__':
192 main()